Fix Coverity ID 589, dead code
authorVolker Lendecke <vl@samba.org>
Sun, 31 Aug 2008 10:15:35 +0000 (12:15 +0200)
committerVolker Lendecke <vl@samba.org>
Sun, 31 Aug 2008 10:15:35 +0000 (12:15 +0200)
(This used to be commit 67c0835226e189deba5856710a1dea19ac5f30fd)

source3/nsswitch/libwbclient/wbc_sid.c

index 324a19bd564711522ea92a852b4cbb9797d665e5..f4ffa4e5caac6a5bc250d44e486cf3bec3e8e24b 100644 (file)
@@ -294,9 +294,18 @@ wbcErr wbcLookupSid(const struct wbcDomainSid *sid,
                }
        }
        else {
+#if 0
+               /*
+                * Found by Coverity: In this particular routine we can't end
+                * up here with a non-NULL name. Further up there are just two
+                * exit paths that lead here, neither of which leave an
+                * allocated name. If you add more paths up there, re-activate
+                * this.
+                */
                if (name != NULL) {
                        talloc_free(name);
                }
+#endif
                if (domain != NULL) {
                        talloc_free(domain);
                }