s3:test_registry_upgrade: make more portable and eliminate "local" keyword

prefer to use function syntax with (...)  to make variables local

diff --git a/source3/script/tests/test_registry_upgrade.sh b/source3/script/tests/test_registry_upgrade.sh
index 8e012bf983a51f2e4a199dc6a3bb3e26e5cfd401..4e97153fec1f483b4ba835c82352d69cee298277 100755 (executable)
--- a/source3/script/tests/test_registry_upgrade.sh
+++ b/source3/script/tests/test_registry_upgrade.sh
@@ -31,11 +31,11 @@ REGPATH="HKLM\Software\Samba"
 LOGDIR_PREFIX="registry_upgrade"
 
 registry_check()
-{
-    local CHECKNO="$1"
-    local CHECKDIFF="$2"
-    local REGVER=""
-    local ALLOWEDERR="INFO: version =|Check database:|overwrite registry format version 0 with 1|no INFO/version found"
+(
+    CHECKNO="$1"
+    CHECKDIFF="$2"
+    REGVER=""
+    ALLOWEDERR="INFO: version =|Check database:|overwrite registry format version 0 with 1|no INFO/version found"
 
     test "x$CHECKNO" = "x0" && {
         REGVER="--reg-version=1"
@@ -71,7 +71,7 @@ registry_check()
     }
 
     return 0
-}
+)
 
 registry_upgrade()
 {