s4:param remove reference to private header from source4/param/param.h

source4/param/param.h has a

param.h is a public header (and parmlist isn't, even if the relative path
could work), so I suggest making it a forward declaration in the header, and
including parmlist.h in the implementation.

(commit message included from e-mail by Andrew Bartlett)
Signed-off-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/source4/param/generic.c b/source4/param/generic.c
index 41d01de9d38ca67c63bec995ad7b262a43156a63..29b97bc09edc72e93b523b754ff8259d56eeb6c9 100644 (file)
--- a/source4/param/generic.c
+++ b/source4/param/generic.c
@@ -18,6 +18,7 @@
 
 #include "includes.h"
 #include "../lib/util/dlinklist.h"
 
 #include "includes.h"
 #include "../lib/util/dlinklist.h"

+#include "../lib/util/parmlist.h"

 #include "param/param.h"
 #include "param/loadparm.h"
 #include "system/filesys.h"
 #include "param/param.h"
 #include "param/loadparm.h"
 #include "system/filesys.h"

diff --git a/source4/param/loadparm.c b/source4/param/loadparm.c
index f2e4ace122c2cc9fe0693e94bb95872bdeb169ab..d65c3f9b16f31f74a0fbf4961fdf71ebb9af942c 100644 (file)
--- a/source4/param/loadparm.c
+++ b/source4/param/loadparm.c
@@ -61,6 +61,7 @@
 #include "smb_server/smb_server.h"
 #include "libcli/raw/signing.h"
 #include "../lib/util/dlinklist.h"
 #include "smb_server/smb_server.h"
 #include "libcli/raw/signing.h"
 #include "../lib/util/dlinklist.h"

+#include "../lib/util/parmlist.h"

 #include "param/param.h"
 #include "param/loadparm.h"
 #include "libcli/raw/libcliraw.h"
 #include "param/param.h"
 #include "param/loadparm.h"
 #include "libcli/raw/libcliraw.h"

diff --git a/source4/param/param.h b/source4/param/param.h
index 3ce5e93acf595175ecc7b4535a48bb2642b260c8..52224252a0a0b089c41c918065e7e1228618e3e8 100644 (file)
--- a/source4/param/param.h
+++ b/source4/param/param.h
@@ -20,7 +20,7 @@
 #ifndef _PARAM_H /* _PARAM_H */
 #define _PARAM_H 
 
 #ifndef _PARAM_H /* _PARAM_H */
 #define _PARAM_H 
 

-#include "../lib/util/parmlist.h"
+struct parmlist_entry;

 
 struct param_context {
        struct param_section *sections;
 
 struct param_context {
        struct param_section *sections;