Based on code from Richard Sharpe <realrichardsharpe@gmail.com>,

ensure we don't crash on a NULL DACL.

diff --git a/source3/smbd/file_access.c b/source3/smbd/file_access.c
index 9fff8e3051fdc39cd156f87fbceb5ad9006d48a7..6ced6a625587798ffdadb1d92b75a1d88048e679 100644 (file)
--- a/source3/smbd/file_access.c
+++ b/source3/smbd/file_access.c
@@ -155,7 +155,10 @@ bool directory_has_default_acl(connection_struct *conn, const char *fname)
        NTSTATUS status = SMB_VFS_GET_NT_ACL(conn, fname,
                                SECINFO_DACL, &secdesc);
 
-       if (!NT_STATUS_IS_OK(status) || secdesc == NULL) {
+       if (!NT_STATUS_IS_OK(status) ||
+                       secdesc == NULL ||
+                       secdesc->dacl == NULL) {
+               TALLOC_FREE(secdesc);
                return false;
        }