Fix a valgrind error in get_relative_fid_filename
authorVolker Lendecke <vl@samba.org>
Sat, 13 Dec 2008 09:31:11 +0000 (10:31 +0100)
committerVolker Lendecke <vl@samba.org>
Sat, 13 Dec 2008 09:31:11 +0000 (10:31 +0100)
It doesn't really make sense to check the length of a not-yet-allocated string
:-)

Volker

source3/smbd/open.c

index 1e988f65ec6a22ab49023d6b40411e3d1805713f..d22eda2bb5490b8bd9afa141ebdbce40a22421f7 100644 (file)
@@ -3067,7 +3067,7 @@ NTSTATUS get_relative_fid_filename(connection_struct *conn,
        files_struct *dir_fsp;
        char *parent_fname = NULL;
 
        files_struct *dir_fsp;
        char *parent_fname = NULL;
 
-       if (root_dir_fid == 0 || !fname || !new_fname || !*new_fname) {
+       if (root_dir_fid == 0 || !fname || !new_fname) {
                return NT_STATUS_INTERNAL_ERROR;
        }
 
                return NT_STATUS_INTERNAL_ERROR;
        }