Insure uninitialized memory read fixes.

Jeremy.

diff --git a/source/include/proto.h b/source/include/proto.h
index b7c58e9c7cb4d050bccf6bad3c2cdb730e46c999..c2fe1bf88098ec4f92d3bc92590a7d1b65d3de95 100644 (file)
--- a/source/include/proto.h
+++ b/source/include/proto.h
@@ -2002,7 +2002,7 @@ BOOL net_io_r_srv_pwset(char *desc, NET_R_SRV_PWSET *r_s, prs_struct *ps, int de
 void init_id_info1(NET_ID_INFO_1 *id, char *domain_name,
                                uint32 param_ctrl, uint32 log_id_low, uint32 log_id_high,
                                char *user_name, char *wksta_name,
-                               char sess_key[16],
+                               char *sess_key,
                                unsigned char lm_cypher[16], unsigned char nt_cypher[16]);
 void init_id_info2(NET_ID_INFO_2 *id, char *domain_name,
                                uint32 param_ctrl, uint32 log_id_low, uint32 log_id_high,

diff --git a/source/rpc_parse/parse_net.c b/source/rpc_parse/parse_net.c
index 002d7e56aaf439831bd3c97cd3e1b54530578bd6..912e18600e61e009f52ba4bd514fc8cf88143087 100644 (file)
--- a/source/rpc_parse/parse_net.c
+++ b/source/rpc_parse/parse_net.c
@@ -635,7 +635,7 @@ static int init_dom_sid2s(char *sids_str, DOM_SID2 *sids, int max_sids)
 void init_id_info1(NET_ID_INFO_1 *id, char *domain_name,
                                uint32 param_ctrl, uint32 log_id_low, uint32 log_id_high,
                                char *user_name, char *wksta_name,
-                               char sess_key[16],
+                               char *sess_key,
                                unsigned char lm_cypher[16], unsigned char nt_cypher[16])
 {
        int len_domain_name = strlen(domain_name);
@@ -994,7 +994,7 @@ void init_net_user_info3(NET_USER_INFO_3 *usr,
        DOM_GID *gids,
        uint32 user_flgs,
 
-       char sess_key[16],
+       char *sess_key,
 
        char *logon_srv,
        char *logon_dom,

diff --git a/source/smbd/password.c b/source/smbd/password.c
index cff47c0a9434fc24d1024e28f559582b84e0aa66..989d3f045d0fe2563b4a9e98a05f703fff9a227a 100644 (file)
--- a/source/smbd/password.c
+++ b/source/smbd/password.c
@@ -270,6 +270,8 @@ uint16 register_vuid(uid_t uid,gid_t gid, char *unix_name, char *requested_name,
       }
   }
 
+  memset(&vuser->dc, '\0', sizeof(vuser->dc));
+
   return (uint16)((num_validated_users - 1) + VUID_OFFSET);
 }