Thanks to David Edward Shapiro <David.Edward.Shapiro@btitele.com> for spotting

this!

(groupname and domain name paramaters swapped, giving 'interesting' results...)

Andrew Bartlett
(This used to be commit 5aed3759d8edbe59df8c1ea70827c4b931393134)

diff --git a/source3/lib/username.c b/source3/lib/username.c
index 8c9c3a7ca9b274f7fca642bfb710a109b13bce61..6482bab87ef7e805d96a5b4c96520c742126cc4d 100644 (file)
--- a/source3/lib/username.c
+++ b/source3/lib/username.c
@@ -575,7 +575,7 @@ BOOL user_in_list(const char *user,char **list)
                                domain[PTR_DIFF(p, *list)] = 0;
 
                                /* Check to see if name is a Windows group */
-                               if (winbind_lookup_name(groupname, domain, &g_sid, &name_type) && name_type == SID_NAME_DOM_GRP) {
+                               if (winbind_lookup_name(domain, groupname, &g_sid, &name_type) && name_type == SID_NAME_DOM_GRP) {
                                        
                                /* Check if user name is in the Windows group */
                                        ret = user_in_winbind_group_list(user, *list, &winbind_answered);