fix potential handle leak in _spoolss_open_printer_ex(); final fix for CR2102; review...
authorGerald Carter <jerry@samba.org>
Tue, 1 Apr 2003 14:57:59 +0000 (14:57 +0000)
committerGerald Carter <jerry@samba.org>
Tue, 1 Apr 2003 14:57:59 +0000 (14:57 +0000)
source/rpc_server/srv_spoolss_nt.c

index 4dd4456b2cc784fb97e2c5c9b79fd113fd41c5ec..3c309d6e1695f24c6f65f7cfe029ebcae65b36dc 100644 (file)
@@ -1623,8 +1623,10 @@ Can't find printer handle we created for printer %s\n", name ));
                /* NT doesn't let us connect to a printer if the connecting user
                   doesn't have print permission.  */
 
-               if (!get_printer_snum(p, handle, &snum))
+               if (!get_printer_snum(p, handle, &snum)) {
+                       close_printer_handle(p, handle);
                        return WERR_BADFID;
+               }
 
                se_map_standard(&printer_default->access_required, &printer_std_mapping);