Explain why we use signing for DCs, but not file servers
authorAndrew Bartlett <abartlet@samba.org>
Mon, 22 Sep 2008 23:32:04 +0000 (16:32 -0700)
committerAndrew Bartlett <abartlet@samba.org>
Mon, 22 Sep 2008 23:32:04 +0000 (16:32 -0700)
source4/smb_server/smb/signing.c

index ee4531c8f69bde31e29ddffc56c0327fce70c0fd..21dc99b165187ef83838b83ec4d9201d94fdfe06 100644 (file)
@@ -118,10 +118,19 @@ bool smbsrv_init_signing(struct smbsrv_connection *smb_conn)
                smb_conn->signing.mandatory_signing = true;
                break;
        case SMB_SIGNING_AUTO:
+               /* If we are a domain controller, SMB signing is
+                * really important, as it can prevent a number of
+                * attacks on communications between us and the
+                * clients */
+
                if (lp_server_role(smb_conn->lp_ctx) == ROLE_DOMAIN_CONTROLLER) {
                        smb_conn->signing.allow_smb_signing = true;
                        smb_conn->signing.mandatory_signing = true;
                } else {
+                       /* However, it really sucks (no sendfile, CPU
+                        * overhead) performance-wise when used on a
+                        * file server, so disable it by default (auto
+                        * is the default) on non-DCs */
                        smb_conn->signing.allow_smb_signing = false;
                }
                break;