fixed create_action for truncated files
[kai/samba.git] / source4 / ntvfs / posix / pvfs_open.c
index 174cab51eca3e5e81a3d135b39d9c0430d402e35..a1c5571258686368de53946d58baabe3be4d6f6d 100644 (file)
@@ -7,7 +7,7 @@
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 2 of the License, or
+   the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
    
    This program is distributed in the hope that it will be useful,
    GNU General Public License for more details.
    
    You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software
-   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
 #include "includes.h"
 #include "vfs_posix.h"
 #include "system/dir.h"
 #include "system/time.h"
-#include "dlinklist.h"
+#include "lib/util/dlinklist.h"
 #include "messaging/messaging.h"
-#include "librpc/gen_ndr/ndr_xattr.h"
-
-/*
-  create file handles with convenient numbers for sniffers
-*/
-#define PVFS_MIN_FILE_FNUM 0x100
-#define PVFS_MIN_NEW_FNUM  0x200
-#define PVFS_MIN_DIR_FNUM  0x300
+#include "librpc/gen_ndr/xattr.h"
 
 /*
   find open file handle given fnum
 */
 struct pvfs_file *pvfs_find_fd(struct pvfs_state *pvfs,
-                              struct ntvfs_request *req, uint16_t fnum)
+                              struct ntvfs_request *req, struct ntvfs_handle *h)
 {
+       void *p;
        struct pvfs_file *f;
 
-       f = idr_find(pvfs->idtree_fnum, fnum);
-       if (f == NULL) {
-               return NULL;
-       }
+       p = ntvfs_handle_get_backend_data(h, pvfs->ntvfs);
+       if (!p) return NULL;
 
-       if (f->fnum != fnum) {
-               smb_panic("pvfs_find_fd: idtree_fnum corruption\n");
-       }
-
-       if (req->session != f->session) {
-               DEBUG(2,("pvfs_find_fd: attempt to use wrong session for fnum %d\n", 
-                        fnum));
-               return NULL;
-       }
+       f = talloc_get_type(p, struct pvfs_file);
+       if (!f) return NULL;
 
        return f;
 }
 
-
 /*
   cleanup a open directory handle
 */
-static int pvfs_dir_handle_destructor(void *p)
+static int pvfs_dir_handle_destructor(struct pvfs_file_handle *h)
 {
-       struct pvfs_file_handle *h = p;
-       int open_count;
-       char *path;
-
-       if (h->name->stream_name == NULL && 
-           pvfs_delete_on_close_set(h->pvfs, h, &open_count, &path) &&
-           open_count == 1) {
-               NTSTATUS status;
-               status = pvfs_xattr_unlink_hook(h->pvfs, path);
-               if (!NT_STATUS_IS_OK(status)) {
-                       DEBUG(0,("Warning: xattr unlink hook failed for '%s' - %s\n",
-                                path, nt_errstr(status)));
-               }
-               if (rmdir(path) != 0) {
-                       DEBUG(0,("pvfs_dir_handle_destructor: failed to rmdir '%s' - %s\n", 
-                                path, strerror(errno)));
-               }
-       }
-
        if (h->have_opendb_entry) {
                struct odb_lock *lck;
                NTSTATUS status;
+               const char *delete_path = NULL;
 
                lck = odb_lock(h, h->pvfs->odb_context, &h->odb_locking_key);
                if (lck == NULL) {
@@ -96,12 +61,24 @@ static int pvfs_dir_handle_destructor(void *p)
                        return 0;
                }
 
-               status = odb_close_file(lck, h);
+               status = odb_close_file(lck, h, &delete_path);
                if (!NT_STATUS_IS_OK(status)) {
-                       DEBUG(0,("Unable to remove opendb entry for '%s' - %s\n", 
+                       DEBUG(0,("Unable to remove opendb entry for '%s' - %s\n",
                                 h->name->full_name, nt_errstr(status)));
                }
 
+               if (h->name->stream_name == NULL && delete_path) {
+                       status = pvfs_xattr_unlink_hook(h->pvfs, delete_path);
+                       if (!NT_STATUS_IS_OK(status)) {
+                               DEBUG(0,("Warning: xattr unlink hook failed for '%s' - %s\n",
+                                        delete_path, nt_errstr(status)));
+                       }
+                       if (rmdir(delete_path) != 0) {
+                               DEBUG(0,("pvfs_dir_handle_destructor: failed to rmdir '%s' - %s\n",
+                                        delete_path, strerror(errno)));
+                       }
+               }
+
                talloc_free(lck);
        }
 
@@ -111,11 +88,11 @@ static int pvfs_dir_handle_destructor(void *p)
 /*
   cleanup a open directory fnum
 */
-static int pvfs_dir_fnum_destructor(void *p)
+static int pvfs_dir_fnum_destructor(struct pvfs_file *f)
 {
-       struct pvfs_file *f = p;
-       DLIST_REMOVE(f->pvfs->open_files, f);
-       idr_remove(f->pvfs->idtree_fnum, f->fnum);
+       DLIST_REMOVE(f->pvfs->files.list, f);
+       ntvfs_handle_remove_backend_data(f->ntvfs, f->pvfs->ntvfs);
+
        return 0;
 }
 
@@ -125,7 +102,7 @@ static int pvfs_dir_fnum_destructor(void *p)
 static NTSTATUS pvfs_open_setup_eas_acl(struct pvfs_state *pvfs,
                                        struct ntvfs_request *req,
                                        struct pvfs_filename *name,
-                                       int fd, int fnum,
+                                       int fd, struct pvfs_file *f,
                                        union smb_open *io)
 {
        NTSTATUS status;
@@ -143,8 +120,14 @@ static NTSTATUS pvfs_open_setup_eas_acl(struct pvfs_state *pvfs,
        /* setup an initial sec_desc if requested */
        if (io->ntcreatex.in.sec_desc) {
                union smb_setfileinfo set;
-
-               set.set_secdesc.in.file.fnum = fnum;
+/* 
+ * TODO: set the full ACL! 
+ *       - vista denies the creation of the file with NT_STATUS_PRIVILEGE_NOT_HELD,
+ *         when a SACL is present on the sd,
+ *         but the user doesn't have SeSecurityPrivilege
+ *       - w2k3 allows it
+ */
+               set.set_secdesc.in.file.ntvfs = f->ntvfs;
                set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
                set.set_secdesc.in.sd = io->ntcreatex.in.sec_desc;
 
@@ -161,8 +144,8 @@ static NTSTATUS pvfs_open_setup_eas_acl(struct pvfs_state *pvfs,
   form the lock context used for opendb locking. Note that we must
   zero here to take account of possible padding on some architectures
 */
-static NTSTATUS pvfs_locking_key(struct pvfs_filename *name, 
-                                TALLOC_CTX *mem_ctx, DATA_BLOB *key)
+NTSTATUS pvfs_locking_key(struct pvfs_filename *name,
+                         TALLOC_CTX *mem_ctx, DATA_BLOB *key)
 {
        struct {
                dev_t device;
@@ -191,20 +174,27 @@ static NTSTATUS pvfs_open_directory(struct pvfs_state *pvfs,
                                    union smb_open *io)
 {
        struct pvfs_file *f;
-       int fnum;
+       struct ntvfs_handle *h;
        NTSTATUS status;
        uint32_t create_action;
        uint32_t access_mask = io->generic.in.access_mask;
        struct odb_lock *lck;
-       BOOL del_on_close;
+       bool del_on_close;
        uint32_t create_options;
        uint32_t share_access;
+       bool forced;
 
        create_options = io->generic.in.create_options;
        share_access   = io->generic.in.share_access;
 
+       forced = (io->generic.in.create_options & NTCREATEX_OPTIONS_DIRECTORY)?true:false;
+
        if (name->stream_name) {
-               return NT_STATUS_NOT_A_DIRECTORY;
+               if (forced) {
+                       return NT_STATUS_NOT_A_DIRECTORY;
+               } else {
+                       return NT_STATUS_FILE_IS_A_DIRECTORY;
+               }
        }
 
        /* if the client says it must be a directory, and it isn't,
@@ -213,6 +203,13 @@ static NTSTATUS pvfs_open_directory(struct pvfs_state *pvfs,
                return NT_STATUS_NOT_A_DIRECTORY;
        }
 
+       /* found with gentest */
+       if (io->ntcreatex.in.access_mask == SEC_FLAG_MAXIMUM_ALLOWED &&
+           (io->ntcreatex.in.create_options & NTCREATEX_OPTIONS_DIRECTORY) &&
+           (io->ntcreatex.in.create_options & NTCREATEX_OPTIONS_DELETE_ON_CLOSE)) {
+               return NT_STATUS_INVALID_PARAMETER;
+       }
+       
        switch (io->generic.in.open_disposition) {
        case NTCREATEX_DISP_OPEN_IF:
                break;
@@ -236,7 +233,10 @@ static NTSTATUS pvfs_open_directory(struct pvfs_state *pvfs,
                return NT_STATUS_INVALID_PARAMETER;
        }
 
-       f = talloc(req, struct pvfs_file);
+       status = ntvfs_handle_new(pvfs->ntvfs, req, &h);
+       NT_STATUS_NOT_OK_RETURN(status);
+
+       f = talloc(h, struct pvfs_file);
        if (f == NULL) {
                return NT_STATUS_NO_MEMORY;
        }
@@ -246,11 +246,6 @@ static NTSTATUS pvfs_open_directory(struct pvfs_state *pvfs,
                return NT_STATUS_NO_MEMORY;
        }
 
-       fnum = idr_get_new_above(pvfs->idtree_fnum, f, PVFS_MIN_DIR_FNUM, UINT16_MAX);
-       if (fnum == -1) {
-               return NT_STATUS_TOO_MANY_OPENED_FILES;
-       }
-
        if (name->exists) {
                /* check the security descriptor */
                status = pvfs_access_check(pvfs, req, name, &access_mask);
@@ -258,44 +253,42 @@ static NTSTATUS pvfs_open_directory(struct pvfs_state *pvfs,
                status = pvfs_access_check_create(pvfs, req, name, &access_mask);
        }
        if (!NT_STATUS_IS_OK(status)) {
-               idr_remove(pvfs->idtree_fnum, fnum);
                return status;
        }
 
-       f->fnum          = fnum;
-       f->session       = req->session;
-       f->smbpid        = req->smbpid;
+       f->ntvfs         = h;
        f->pvfs          = pvfs;
        f->pending_list  = NULL;
        f->lock_count    = 0;
        f->share_access  = io->generic.in.share_access;
        f->impersonation = io->generic.in.impersonation;
        f->access_mask   = access_mask;
+       f->brl_handle    = NULL;
+       f->notify_buffer = NULL;
+       f->search        = NULL;
 
        f->handle->pvfs              = pvfs;
        f->handle->name              = talloc_steal(f->handle, name);
        f->handle->fd                = -1;
        f->handle->odb_locking_key   = data_blob(NULL, 0);
-       f->handle->brl_locking_key   = data_blob(NULL, 0);
        f->handle->create_options    = io->generic.in.create_options;
        f->handle->seek_offset       = 0;
        f->handle->position          = 0;
        f->handle->mode              = 0;
-       f->handle->sticky_write_time = False;
+       f->handle->oplock            = NULL;
+       f->handle->open_completed    = false;
 
        if ((create_options & NTCREATEX_OPTIONS_DELETE_ON_CLOSE) &&
            pvfs_directory_empty(pvfs, f->handle->name)) {
-               del_on_close = True;
+               del_on_close = true;
        } else {
-               del_on_close = False;
+               del_on_close = false;
        }
 
-
        if (name->exists) {
                /* form the lock context used for opendb locking */
                status = pvfs_locking_key(name, f->handle, &f->handle->odb_locking_key);
                if (!NT_STATUS_IS_OK(status)) {
-                       idr_remove(pvfs->idtree_fnum, f->fnum);
                        return status;
                }
 
@@ -306,24 +299,31 @@ static NTSTATUS pvfs_open_directory(struct pvfs_state *pvfs,
                                 name->full_name));
                        /* we were supposed to do a blocking lock, so something
                           is badly wrong! */
-                       idr_remove(pvfs->idtree_fnum, fnum);
                        return NT_STATUS_INTERNAL_DB_CORRUPTION;
                }
                
                /* see if we are allowed to open at the same time as existing opens */
-               status = odb_open_file(lck, f->handle, f->handle->name->stream_id,
-                                      share_access, access_mask, del_on_close, name->full_name);
+               status = odb_can_open(lck, name->stream_id,
+                                     share_access, access_mask, del_on_close,
+                                     io->generic.in.open_disposition, false);
+               if (!NT_STATUS_IS_OK(status)) {
+                       talloc_free(lck);
+                       return status;
+               }
+
+               /* now really mark the file as open */
+               status = odb_open_file(lck, f->handle, name->full_name,
+                                      NULL, false, OPLOCK_NONE, NULL);
 
                if (!NT_STATUS_IS_OK(status)) {
-                       idr_remove(pvfs->idtree_fnum, f->fnum);
                        talloc_free(lck);
                        return status;
                }
 
-               f->handle->have_opendb_entry = True;
+               f->handle->have_opendb_entry = true;
        }
 
-       DLIST_ADD(pvfs->open_files, f);
+       DLIST_ADD(pvfs->files.list, f);
 
        /* setup destructors to avoid leaks on abnormal termination */
        talloc_set_destructor(f->handle, pvfs_dir_handle_destructor);
@@ -334,7 +334,6 @@ static NTSTATUS pvfs_open_directory(struct pvfs_state *pvfs,
                mode_t mode = pvfs_fileperms(pvfs, attrib);
 
                if (mkdir(name->full_name, mode) == -1) {
-                       idr_remove(pvfs->idtree_fnum, fnum);
                        return pvfs_map_errno(pvfs,errno);
                }
 
@@ -345,7 +344,7 @@ static NTSTATUS pvfs_open_directory(struct pvfs_state *pvfs,
                        goto cleanup_delete;
                }
 
-               status = pvfs_open_setup_eas_acl(pvfs, req, name, -1, fnum, io);
+               status = pvfs_open_setup_eas_acl(pvfs, req, name, -1, f, io);
                if (!NT_STATUS_IS_OK(status)) {
                        goto cleanup_delete;
                }
@@ -353,7 +352,6 @@ static NTSTATUS pvfs_open_directory(struct pvfs_state *pvfs,
                /* form the lock context used for opendb locking */
                status = pvfs_locking_key(name, f->handle, &f->handle->odb_locking_key);
                if (!NT_STATUS_IS_OK(status)) {
-                       idr_remove(pvfs->idtree_fnum, f->fnum);
                        return status;
                }
 
@@ -363,34 +361,50 @@ static NTSTATUS pvfs_open_directory(struct pvfs_state *pvfs,
                                 name->full_name));
                        /* we were supposed to do a blocking lock, so something
                           is badly wrong! */
-                       idr_remove(pvfs->idtree_fnum, fnum);
                        return NT_STATUS_INTERNAL_DB_CORRUPTION;
                }
 
-               status = odb_open_file(lck, f->handle, f->handle->name->stream_id,
-                                      share_access, access_mask, del_on_close, name->full_name);
+               status = odb_can_open(lck, name->stream_id,
+                                     share_access, access_mask, del_on_close,
+                                     io->generic.in.open_disposition, false);
+
+               if (!NT_STATUS_IS_OK(status)) {
+                       goto cleanup_delete;
+               }
+
+               status = odb_open_file(lck, f->handle, name->full_name,
+                                      NULL, false, OPLOCK_NONE, NULL);
 
                if (!NT_STATUS_IS_OK(status)) {
                        goto cleanup_delete;
                }
 
-               f->handle->have_opendb_entry = True;
+               f->handle->have_opendb_entry = true;
 
                create_action = NTCREATEX_ACTION_CREATED;
+
+               notify_trigger(pvfs->notify_context, 
+                              NOTIFY_ACTION_ADDED, 
+                              FILE_NOTIFY_CHANGE_DIR_NAME,
+                              name->full_name);
        } else {
                create_action = NTCREATEX_ACTION_EXISTED;
        }
 
        if (!name->exists) {
-               idr_remove(pvfs->idtree_fnum, fnum);
                return NT_STATUS_OBJECT_NAME_NOT_FOUND;
        }
 
        /* the open succeeded, keep this handle permanently */
-       talloc_steal(pvfs, f);
+       status = ntvfs_handle_set_backend_data(h, pvfs->ntvfs, f);
+       if (!NT_STATUS_IS_OK(status)) {
+               goto cleanup_delete;
+       }
+
+       f->handle->open_completed = true;
 
        io->generic.out.oplock_level  = OPLOCK_NONE;
-       io->generic.out.file.fnum     = f->fnum;
+       io->generic.out.file.ntvfs    = h;
        io->generic.out.create_action = create_action;
        io->generic.out.create_time   = name->dos.create_time;
        io->generic.out.access_time   = name->dos.access_time;
@@ -406,7 +420,6 @@ static NTSTATUS pvfs_open_directory(struct pvfs_state *pvfs,
        return NT_STATUS_OK;
 
 cleanup_delete:
-       idr_remove(pvfs->idtree_fnum, fnum);
        rmdir(name->full_name);
        return status;
 }
@@ -414,22 +427,8 @@ cleanup_delete:
 /*
   destroy a struct pvfs_file_handle
 */
-static int pvfs_handle_destructor(void *p)
+static int pvfs_handle_destructor(struct pvfs_file_handle *h)
 {
-       struct pvfs_file_handle *h = p;
-       int open_count;
-       char *path;
-
-       /* the write time is no longer sticky */
-       if (h->sticky_write_time) {
-               NTSTATUS status;
-               status = pvfs_dosattrib_load(h->pvfs, h->name, h->fd);
-               if (NT_STATUS_IS_OK(status)) {
-                       h->name->dos.flags &= ~XATTR_ATTRIB_FLAG_STICKY_WRITE_TIME;
-                       pvfs_dosattrib_save(h->pvfs, h->name, h->fd);
-               }
-       }
-       
        if ((h->create_options & NTCREATEX_OPTIONS_DELETE_ON_CLOSE) &&
            h->name->stream_name) {
                NTSTATUS status;
@@ -448,24 +447,10 @@ static int pvfs_handle_destructor(void *p)
                h->fd = -1;
        }
 
-       if (h->name->stream_name == NULL && 
-           pvfs_delete_on_close_set(h->pvfs, h, &open_count, &path) &&
-           open_count == 1) {
-               NTSTATUS status;
-               status = pvfs_xattr_unlink_hook(h->pvfs, path);
-               if (!NT_STATUS_IS_OK(status)) {
-                       DEBUG(0,("Warning: xattr unlink hook failed for '%s' - %s\n",
-                                path, nt_errstr(status)));
-               }
-               if (unlink(path) != 0) {
-                       DEBUG(0,("pvfs_close: failed to delete '%s' - %s\n", 
-                                path, strerror(errno)));
-               }
-       }
-
        if (h->have_opendb_entry) {
                struct odb_lock *lck;
                NTSTATUS status;
+               const char *delete_path = NULL;
 
                lck = odb_lock(h, h->pvfs->odb_context, &h->odb_locking_key);
                if (lck == NULL) {
@@ -473,12 +458,30 @@ static int pvfs_handle_destructor(void *p)
                        return 0;
                }
 
-               status = odb_close_file(lck, h);
+               status = odb_close_file(lck, h, &delete_path);
                if (!NT_STATUS_IS_OK(status)) {
                        DEBUG(0,("Unable to remove opendb entry for '%s' - %s\n", 
                                 h->name->full_name, nt_errstr(status)));
                }
 
+               if (h->name->stream_name == NULL &&
+                   h->open_completed && delete_path) {
+                       status = pvfs_xattr_unlink_hook(h->pvfs, delete_path);
+                       if (!NT_STATUS_IS_OK(status)) {
+                               DEBUG(0,("Warning: xattr unlink hook failed for '%s' - %s\n",
+                                        delete_path, nt_errstr(status)));
+                       }
+                       if (unlink(delete_path) != 0) {
+                               DEBUG(0,("pvfs_close: failed to delete '%s' - %s\n",
+                                        delete_path, strerror(errno)));
+                       } else {
+                               notify_trigger(h->pvfs->notify_context,
+                                              NOTIFY_ACTION_REMOVED,
+                                              FILE_NOTIFY_CHANGE_FILE_NAME,
+                                              delete_path);
+                       }
+               }
+
                talloc_free(lck);
        }
 
@@ -489,13 +492,11 @@ static int pvfs_handle_destructor(void *p)
 /*
   destroy a struct pvfs_file
 */
-static int pvfs_fnum_destructor(void *p)
+static int pvfs_fnum_destructor(struct pvfs_file *f)
 {
-       struct pvfs_file *f = p;
-
-       DLIST_REMOVE(f->pvfs->open_files, f);
+       DLIST_REMOVE(f->pvfs->files.list, f);
        pvfs_lock_close(f->pvfs, f);
-       idr_remove(f->pvfs->idtree_fnum, f->fnum);
+       ntvfs_handle_remove_backend_data(f->ntvfs, f->pvfs->ntvfs);
 
        return 0;
 }
@@ -507,32 +508,37 @@ static int pvfs_fnum_destructor(void *p)
   account of file streams (each stream is a separate byte range
   locking space)
 */
-static NTSTATUS pvfs_brl_locking_key(struct pvfs_filename *name, 
-                                    TALLOC_CTX *mem_ctx, DATA_BLOB *key)
+static NTSTATUS pvfs_brl_locking_handle(TALLOC_CTX *mem_ctx,
+                                       struct pvfs_filename *name,
+                                       struct ntvfs_handle *ntvfs,
+                                       struct brl_handle **_h)
 {
-       DATA_BLOB odb_key;
+       DATA_BLOB odb_key, key;
        NTSTATUS status;
+       struct brl_handle *h;
+
        status = pvfs_locking_key(name, mem_ctx, &odb_key);
-       if (!NT_STATUS_IS_OK(status)) {
-               return status;
-       }
+       NT_STATUS_NOT_OK_RETURN(status);
+
        if (name->stream_name == NULL) {
-               *key = odb_key;
-               return NT_STATUS_OK;
-       }
-       *key = data_blob_talloc(mem_ctx, NULL, 
-                               odb_key.length + strlen(name->stream_name) + 1);
-       if (key->data == NULL) {
-               return NT_STATUS_NO_MEMORY;
+               key = odb_key;
+       } else {
+               key = data_blob_talloc(mem_ctx, NULL, 
+                                      odb_key.length + strlen(name->stream_name) + 1);
+               NT_STATUS_HAVE_NO_MEMORY(key.data);
+               memcpy(key.data, odb_key.data, odb_key.length);
+               memcpy(key.data + odb_key.length, 
+                      name->stream_name, strlen(name->stream_name) + 1);
+               data_blob_free(&odb_key);
        }
-       memcpy(key->data, odb_key.data, odb_key.length);
-       memcpy(key->data + odb_key.length, 
-              name->stream_name, strlen(name->stream_name)+1);
-       data_blob_free(&odb_key);
+
+       h = brl_create_handle(mem_ctx, ntvfs, &key);
+       NT_STATUS_HAVE_NO_MEMORY(h);
+
+       *_h = h;
        return NT_STATUS_OK;
 }
 
-
 /*
   create a new file
 */
@@ -543,21 +549,32 @@ static NTSTATUS pvfs_create_file(struct pvfs_state *pvfs,
 {
        struct pvfs_file *f;
        NTSTATUS status;
-       int flags, fnum, fd;
+       struct ntvfs_handle *h;
+       int flags, fd;
        struct odb_lock *lck;
        uint32_t create_options = io->generic.in.create_options;
        uint32_t share_access = io->generic.in.share_access;
        uint32_t access_mask = io->generic.in.access_mask;
        mode_t mode;
        uint32_t attrib;
-       BOOL del_on_close;
+       bool del_on_close;
        struct pvfs_filename *parent;
+       uint32_t oplock_level = OPLOCK_NONE, oplock_granted;
+       bool allow_level_II_oplock = false;
+
+       if (io->ntcreatex.in.file_attr & ~FILE_ATTRIBUTE_ALL_MASK) {
+               return NT_STATUS_INVALID_PARAMETER;
+       }
 
+       if (io->ntcreatex.in.file_attr & FILE_ATTRIBUTE_ENCRYPTED) {
+               return NT_STATUS_ACCESS_DENIED;
+       }
+           
        if ((io->ntcreatex.in.file_attr & FILE_ATTRIBUTE_READONLY) &&
            (create_options & NTCREATEX_OPTIONS_DELETE_ON_CLOSE)) {
                return NT_STATUS_CANNOT_DELETE;
        }
-       
+
        status = pvfs_access_check_create(pvfs, req, name, &access_mask);
        NT_STATUS_NOT_OK_RETURN(status);
 
@@ -568,7 +585,7 @@ static NTSTATUS pvfs_create_file(struct pvfs_state *pvfs,
                status = pvfs_locking_key(parent, req, &locking_key);
                NT_STATUS_NOT_OK_RETURN(status);
                status = odb_get_delete_on_close(pvfs->odb_context, &locking_key, 
-                                                &del_on_close, NULL, NULL);
+                                                &del_on_close);
                NT_STATUS_NOT_OK_RETURN(status);
                if (del_on_close) {
                        return NT_STATUS_DELETE_PENDING;
@@ -581,28 +598,21 @@ static NTSTATUS pvfs_create_file(struct pvfs_state *pvfs,
                flags = O_RDONLY;
        }
 
-       f = talloc(req, struct pvfs_file);
-       if (f == NULL) {
-               return NT_STATUS_NO_MEMORY;
-       }
+       status = ntvfs_handle_new(pvfs->ntvfs, req, &h);
+       NT_STATUS_NOT_OK_RETURN(status);
 
-       f->handle = talloc(f, struct pvfs_file_handle);
-       if (f->handle == NULL) {
-               return NT_STATUS_NO_MEMORY;
-       }
+       f = talloc(h, struct pvfs_file);
+       NT_STATUS_HAVE_NO_MEMORY(f);
 
-       fnum = idr_get_new_above(pvfs->idtree_fnum, f, PVFS_MIN_NEW_FNUM, UINT16_MAX);
-       if (fnum == -1) {
-               return NT_STATUS_TOO_MANY_OPENED_FILES;
-       }
+       f->handle = talloc(f, struct pvfs_file_handle);
+       NT_STATUS_HAVE_NO_MEMORY(f->handle);
 
        attrib = io->ntcreatex.in.file_attr | FILE_ATTRIBUTE_ARCHIVE;
        mode = pvfs_fileperms(pvfs, attrib);
 
        /* create the file */
-       fd = open(name->full_name, flags | O_CREAT | O_EXCL, mode);
+       fd = open(name->full_name, flags | O_CREAT | O_EXCL| O_NONBLOCK, mode);
        if (fd == -1) {
-               idr_remove(pvfs->idtree_fnum, fnum);
                return pvfs_map_errno(pvfs, errno);
        }
 
@@ -612,7 +622,6 @@ static NTSTATUS pvfs_create_file(struct pvfs_state *pvfs,
        if (name->stream_name) {
                status = pvfs_stream_create(pvfs, name, fd);
                if (!NT_STATUS_IS_OK(status)) {
-                       idr_remove(pvfs->idtree_fnum, fnum);
                        close(fd);
                        return status;
                }
@@ -621,11 +630,12 @@ static NTSTATUS pvfs_create_file(struct pvfs_state *pvfs,
        /* re-resolve the open fd */
        status = pvfs_resolve_name_fd(pvfs, fd, name);
        if (!NT_STATUS_IS_OK(status)) {
-               idr_remove(pvfs->idtree_fnum, fnum);
                close(fd);
                return status;
        }
 
+       /* support initial alloc sizes */
+       name->dos.alloc_size = io->ntcreatex.in.alloc_size;
        name->dos.attrib = attrib;
        status = pvfs_dosattrib_save(pvfs, name, fd);
        if (!NT_STATUS_IS_OK(status)) {
@@ -633,7 +643,7 @@ static NTSTATUS pvfs_create_file(struct pvfs_state *pvfs,
        }
 
 
-       status = pvfs_open_setup_eas_acl(pvfs, req, name, fd, fnum, io);
+       status = pvfs_open_setup_eas_acl(pvfs, req, name, fd, f, io);
        if (!NT_STATUS_IS_OK(status)) {
                goto cleanup_delete;
        }
@@ -645,7 +655,7 @@ static NTSTATUS pvfs_create_file(struct pvfs_state *pvfs,
                goto cleanup_delete;
        }
 
-       status = pvfs_brl_locking_key(name, f->handle, &f->handle->brl_locking_key);
+       status = pvfs_brl_locking_handle(f, name, h, &f->brl_handle);
        if (!NT_STATUS_IS_OK(status)) {
                goto cleanup_delete;
        }
@@ -662,32 +672,44 @@ static NTSTATUS pvfs_create_file(struct pvfs_state *pvfs,
        }
 
        if (create_options & NTCREATEX_OPTIONS_DELETE_ON_CLOSE) {
-               del_on_close = True;
+               del_on_close = true;
        } else {
-               del_on_close = False;
+               del_on_close = false;
        }
 
-       status = odb_open_file(lck, f->handle, name->stream_id,
-                              share_access, access_mask, del_on_close, name->full_name);
-       talloc_free(lck);
+       if (pvfs->flags & PVFS_FLAG_FAKE_OPLOCKS) {
+               oplock_level = OPLOCK_NONE;
+       } else if (io->ntcreatex.in.flags & NTCREATEX_FLAGS_REQUEST_BATCH_OPLOCK) {
+               oplock_level = OPLOCK_BATCH;
+       } else if (io->ntcreatex.in.flags & NTCREATEX_FLAGS_REQUEST_OPLOCK) {
+               oplock_level = OPLOCK_EXCLUSIVE;
+       }
+
+       if (req->client_caps & NTVFS_CLIENT_CAP_LEVEL_II_OPLOCKS) {
+               allow_level_II_oplock = true;
+       }
+
+       status = odb_can_open(lck, name->stream_id,
+                             share_access, access_mask, del_on_close,
+                             io->generic.in.open_disposition, false);
        if (!NT_STATUS_IS_OK(status)) {
+               talloc_free(lck);
                /* bad news, we must have hit a race - we don't delete the file
-                  here as the most likely scenario is that someone else created 
+                  here as the most likely scenario is that someone else created
                   the file at the same time */
-               idr_remove(pvfs->idtree_fnum, fnum);
                close(fd);
                return status;
        }
 
-       f->fnum              = fnum;
-       f->session           = req->session;
-       f->smbpid            = req->smbpid;
+       f->ntvfs             = h;
        f->pvfs              = pvfs;
        f->pending_list      = NULL;
        f->lock_count        = 0;
        f->share_access      = io->generic.in.share_access;
        f->access_mask       = access_mask;
        f->impersonation     = io->generic.in.impersonation;
+       f->notify_buffer     = NULL;
+       f->search            = NULL;
 
        f->handle->pvfs              = pvfs;
        f->handle->name              = talloc_steal(f->handle, name);
@@ -696,23 +718,40 @@ static NTSTATUS pvfs_create_file(struct pvfs_state *pvfs,
        f->handle->seek_offset       = 0;
        f->handle->position          = 0;
        f->handle->mode              = 0;
-       f->handle->have_opendb_entry = True;
-       f->handle->sticky_write_time = False;
+       f->handle->oplock            = NULL;
+       f->handle->have_opendb_entry = true;
+       f->handle->open_completed    = false;
 
-       DLIST_ADD(pvfs->open_files, f);
+       status = odb_open_file(lck, f->handle, name->full_name,
+                              &f->handle->fd, allow_level_II_oplock,
+                              oplock_level, &oplock_granted);
+       talloc_free(lck);
+       if (!NT_STATUS_IS_OK(status)) {
+               /* bad news, we must have hit a race - we don't delete the file
+                  here as the most likely scenario is that someone else created
+                  the file at the same time */
+               close(fd);
+               return status;
+       }
+
+       DLIST_ADD(pvfs->files.list, f);
 
        /* setup a destructor to avoid file descriptor leaks on
           abnormal termination */
        talloc_set_destructor(f, pvfs_fnum_destructor);
        talloc_set_destructor(f->handle, pvfs_handle_destructor);
 
-       
        if (pvfs->flags & PVFS_FLAG_FAKE_OPLOCKS) {
-               io->generic.out.oplock_level  = OPLOCK_EXCLUSIVE;
-       } else {
-               io->generic.out.oplock_level  = OPLOCK_NONE;
+               oplock_granted = OPLOCK_BATCH;
+       } else if (oplock_granted != OPLOCK_NONE) {
+               status = pvfs_setup_oplock(f, oplock_granted);
+               if (!NT_STATUS_IS_OK(status)) {
+                       return status;
+               }
        }
-       io->generic.out.file.fnum     = f->fnum;
+
+       io->generic.out.oplock_level  = oplock_granted;
+       io->generic.out.file.ntvfs    = f->ntvfs;
        io->generic.out.create_action = NTCREATEX_ACTION_CREATED;
        io->generic.out.create_time   = name->dos.create_time;
        io->generic.out.access_time   = name->dos.access_time;
@@ -726,33 +765,46 @@ static NTSTATUS pvfs_create_file(struct pvfs_state *pvfs,
        io->generic.out.is_directory  = 0;
 
        /* success - keep the file handle */
-       talloc_steal(pvfs, f);
+       status = ntvfs_handle_set_backend_data(h, pvfs->ntvfs, f);
+       if (!NT_STATUS_IS_OK(status)) {
+               goto cleanup_delete;
+       }
+
+       f->handle->open_completed = true;
+
+       notify_trigger(pvfs->notify_context, 
+                      NOTIFY_ACTION_ADDED, 
+                      FILE_NOTIFY_CHANGE_FILE_NAME,
+                      name->full_name);
 
        return NT_STATUS_OK;
 
 cleanup_delete:
-       idr_remove(pvfs->idtree_fnum, fnum);
        close(fd);
        unlink(name->full_name);
        return status;
 }
 
-
 /*
-  state of a pending open retry
+  state of a pending retry
 */
-struct pvfs_open_retry {
+struct pvfs_odb_retry {
        struct ntvfs_module_context *ntvfs;
        struct ntvfs_request *req;
-       union smb_open *io;
-       void *wait_handle;
        DATA_BLOB odb_locking_key;
+       void *io;
+       void *private_data;
+       void (*callback)(struct pvfs_odb_retry *r,
+                        struct ntvfs_module_context *ntvfs,
+                        struct ntvfs_request *req,
+                        void *io,
+                        void *private_data,
+                        enum pvfs_wait_notice reason);
 };
 
-/* destroy a pending open request */
-static int pvfs_retry_destructor(void *ptr)
+/* destroy a pending request */
+static int pvfs_odb_retry_destructor(struct pvfs_odb_retry *r)
 {
-       struct pvfs_open_retry *r = ptr;
        struct pvfs_state *pvfs = r->ntvfs->private_data;
        if (r->odb_locking_key.data) {
                struct odb_lock *lck;
@@ -765,26 +817,121 @@ static int pvfs_retry_destructor(void *ptr)
        return 0;
 }
 
+static void pvfs_odb_retry_callback(void *_r, enum pvfs_wait_notice reason)
+{
+       struct pvfs_odb_retry *r = talloc_get_type(_r, struct pvfs_odb_retry);
+
+       if (reason == PVFS_WAIT_EVENT) {
+               /*
+                * The pending odb entry is already removed.
+                * We use a null locking key to indicate this
+                * to the destructor.
+                */
+               data_blob_free(&r->odb_locking_key);
+       }
+
+       r->callback(r, r->ntvfs, r->req, r->io, r->private_data, reason);
+}
+
 /*
-  retry an open
+  setup for a retry of a request that was rejected
+  by odb_can_open()
 */
-static void pvfs_open_retry(void *private, enum pvfs_wait_notice reason)
+NTSTATUS pvfs_odb_retry_setup(struct ntvfs_module_context *ntvfs,
+                             struct ntvfs_request *req,
+                             struct odb_lock *lck,
+                             struct timeval end_time,
+                             void *io,
+                             void *private_data,
+                             void (*callback)(struct pvfs_odb_retry *r,
+                                              struct ntvfs_module_context *ntvfs,
+                                              struct ntvfs_request *req,
+                                              void *io,
+                                              void *private_data,
+                                              enum pvfs_wait_notice reason))
 {
-       struct pvfs_open_retry *r = private;
-       struct ntvfs_module_context *ntvfs = r->ntvfs;
-       struct ntvfs_request *req = r->req;
-       union smb_open *io = r->io;
+       struct pvfs_state *pvfs = ntvfs->private_data;
+       struct pvfs_odb_retry *r;
+       struct pvfs_wait *wait_handle;
        NTSTATUS status;
 
+       r = talloc(req, struct pvfs_odb_retry);
+       NT_STATUS_HAVE_NO_MEMORY(r);
+
+       r->ntvfs = ntvfs;
+       r->req = req;
+       r->io = io;
+       r->private_data = private_data;
+       r->callback = callback;
+       r->odb_locking_key = odb_get_key(r, lck);
+       if (r->odb_locking_key.data == NULL) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       /* setup a pending lock */
+       status = odb_open_file_pending(lck, r);
+       if (NT_STATUS_EQUAL(NT_STATUS_OBJECT_NAME_NOT_FOUND,status)) {
+               /*
+                * maybe only a unix application
+                * has the file open
+                */
+               data_blob_free(&r->odb_locking_key);
+       } else if (!NT_STATUS_IS_OK(status)) {
+               return status;
+       }
+
+       talloc_free(lck);
+
+       talloc_set_destructor(r, pvfs_odb_retry_destructor);
+
+       wait_handle = pvfs_wait_message(pvfs, req,
+                                       MSG_PVFS_RETRY_OPEN, end_time,
+                                       pvfs_odb_retry_callback, r);
+       if (wait_handle == NULL) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       talloc_steal(r, wait_handle);
+
+       return NT_STATUS_OK;
+}
+
+/*
+  retry an open after a sharing violation
+*/
+static void pvfs_retry_open_sharing(struct pvfs_odb_retry *r,
+                                   struct ntvfs_module_context *ntvfs,
+                                   struct ntvfs_request *req,
+                                   void *_io,
+                                   void *private_data,
+                                   enum pvfs_wait_notice reason)
+{
+       union smb_open *io = talloc_get_type(_io, union smb_open);
+       struct timeval *final_timeout = NULL;
+       NTSTATUS status;
+
+       if (private_data) {
+               final_timeout = talloc_get_type(private_data,
+                                               struct timeval);
+       }
+
        /* w2k3 ignores SMBntcancel for outstanding open requests. It's probably
           just a bug in their server, but we better do the same */
        if (reason == PVFS_WAIT_CANCEL) {
                return;
        }
 
-       talloc_free(r->wait_handle);
-
        if (reason == PVFS_WAIT_TIMEOUT) {
+               if (final_timeout &&
+                   !timeval_expired(final_timeout)) {
+                       /*
+                        * we need to retry periodictly
+                        * after an EAGAIN as there's
+                        * no way the kernel tell us
+                        * an oplock is released.
+                        */
+                       goto retry;
+               }
                /* if it timed out, then give the failure
                   immediately */
                talloc_free(r);
@@ -793,9 +940,7 @@ static void pvfs_open_retry(void *private, enum pvfs_wait_notice reason)
                return;
        }
 
-       /* the pending odb entry is already removed. We use a null locking
-          key to indicate this */
-       data_blob_free(&r->odb_locking_key);
+retry:
        talloc_free(r);
 
        /* try the open again, which could trigger another retry setup
@@ -834,6 +979,7 @@ static NTSTATUS pvfs_open_deny_dos(struct ntvfs_module_context *ntvfs,
        struct pvfs_state *pvfs = ntvfs->private_data;
        struct pvfs_file *f2;
        struct pvfs_filename *name;
+       NTSTATUS status;
 
        /* search for an existing open with the right parameters. Note
           the magic ntcreatex options flag, which is set in the
@@ -845,10 +991,10 @@ static NTSTATUS pvfs_open_deny_dos(struct ntvfs_module_context *ntvfs,
           circumstances you actually get the _same_ handle back
           twice, rather than a new handle.
        */
-       for (f2=pvfs->open_files;f2;f2=f2->next) {
+       for (f2=pvfs->files.list;f2;f2=f2->next) {
                if (f2 != f &&
-                   f2->session == req->session &&
-                   f2->smbpid == req->smbpid &&
+                   f2->ntvfs->session_info == req->session_info &&
+                   f2->ntvfs->smbpid == req->smbpid &&
                    (f2->handle->create_options & 
                     (NTCREATEX_OPTIONS_PRIVATE_DENY_DOS |
                      NTCREATEX_OPTIONS_PRIVATE_DENY_FCB)) &&
@@ -880,7 +1026,7 @@ static NTSTATUS pvfs_open_deny_dos(struct ntvfs_module_context *ntvfs,
        name = f->handle->name;
 
        io->generic.out.oplock_level  = OPLOCK_NONE;
-       io->generic.out.file.fnum     = f->fnum;
+       io->generic.out.file.ntvfs    = f->ntvfs;
        io->generic.out.create_action = NTCREATEX_ACTION_EXISTED;
        io->generic.out.create_time   = name->dos.create_time;
        io->generic.out.access_time   = name->dos.access_time;
@@ -892,8 +1038,9 @@ static NTSTATUS pvfs_open_deny_dos(struct ntvfs_module_context *ntvfs,
        io->generic.out.file_type     = FILE_TYPE_DISK;
        io->generic.out.ipc_state     = 0;
        io->generic.out.is_directory  = 0;
-
-       talloc_steal(f->pvfs, f);
+       status = ntvfs_handle_set_backend_data(f->ntvfs, ntvfs, f);
+       NT_STATUS_NOT_OK_RETURN(status);
 
        return NT_STATUS_OK;
 }
@@ -907,12 +1054,13 @@ static NTSTATUS pvfs_open_setup_retry(struct ntvfs_module_context *ntvfs,
                                      struct ntvfs_request *req, 
                                      union smb_open *io,
                                      struct pvfs_file *f,
-                                     struct odb_lock *lck)
+                                     struct odb_lock *lck,
+                                     NTSTATUS parent_status)
 {
        struct pvfs_state *pvfs = ntvfs->private_data;
-       struct pvfs_open_retry *r;
        NTSTATUS status;
        struct timeval end_time;
+       struct timeval *final_timeout = NULL;
 
        if (io->generic.in.create_options & 
            (NTCREATEX_OPTIONS_PRIVATE_DENY_DOS | NTCREATEX_OPTIONS_PRIVATE_DENY_FCB)) {
@@ -924,40 +1072,37 @@ static NTSTATUS pvfs_open_setup_retry(struct ntvfs_module_context *ntvfs,
                }
        }
 
-       r = talloc(req, struct pvfs_open_retry);
-       if (r == NULL) {
-               return NT_STATUS_NO_MEMORY;
-       }
-
-       r->ntvfs = ntvfs;
-       r->req = req;
-       r->io = io;
-       r->odb_locking_key = data_blob_talloc(r, 
-                                             f->handle->odb_locking_key.data, 
-                                             f->handle->odb_locking_key.length);
-
-       end_time = timeval_add(&req->request_time, 0, pvfs->sharing_violation_delay);
-
-       /* setup a pending lock */
-       status = odb_open_file_pending(lck, r);
-       if (!NT_STATUS_IS_OK(status)) {
-               return status;
-       }
-
-       talloc_free(lck);
+       /* the retry should allocate a new file handle */
        talloc_free(f);
 
-       talloc_set_destructor(r, pvfs_retry_destructor);
-
-       r->wait_handle = pvfs_wait_message(pvfs, req, MSG_PVFS_RETRY_OPEN, end_time, 
-                                          pvfs_open_retry, r);
-       if (r->wait_handle == NULL) {
-               return NT_STATUS_NO_MEMORY;
+       if (NT_STATUS_EQUAL(parent_status, NT_STATUS_SHARING_VIOLATION)) {
+               end_time = timeval_add(&req->statistics.request_time,
+                                      0, pvfs->sharing_violation_delay);
+       } else if (NT_STATUS_EQUAL(parent_status, NT_STATUS_OPLOCK_NOT_GRANTED)) {
+               end_time = timeval_add(&req->statistics.request_time,
+                                      pvfs->oplock_break_timeout, 0);
+       } else if (NT_STATUS_EQUAL(parent_status, STATUS_MORE_ENTRIES)) {
+               /*
+                * we got EAGAIN which means a unix application
+                * has an oplock or share mode
+                *
+                * we retry every 4/5 of the sharing violation delay
+                * to see if the unix application
+                * has released the oplock or share mode.
+                */
+               final_timeout = talloc(req, struct timeval);
+               NT_STATUS_HAVE_NO_MEMORY(final_timeout);
+               *final_timeout = timeval_add(&req->statistics.request_time,
+                                            pvfs->oplock_break_timeout,
+                                            0);
+               end_time = timeval_current_ofs(0, (pvfs->sharing_violation_delay*4)/5);
+               end_time = timeval_min(final_timeout, &end_time);
+       } else {
+               return NT_STATUS_INTERNAL_ERROR;
        }
 
-       talloc_steal(pvfs, r);
-
-       return NT_STATUS_OK;
+       return pvfs_odb_retry_setup(ntvfs, req, lck, end_time, io,
+                                   final_timeout, pvfs_retry_open_sharing);
 }
 
 /*
@@ -970,13 +1115,18 @@ NTSTATUS pvfs_open(struct ntvfs_module_context *ntvfs,
        int flags;
        struct pvfs_filename *name;
        struct pvfs_file *f;
+       struct ntvfs_handle *h;
        NTSTATUS status;
-       int fnum, fd;
+       int fd;
        struct odb_lock *lck;
        uint32_t create_options;
        uint32_t share_access;
        uint32_t access_mask;
-       BOOL stream_existed, stream_truncate=False;
+       uint32_t create_action = NTCREATEX_ACTION_EXISTED;
+       bool del_on_close;
+       bool stream_existed, stream_truncate=false;
+       uint32_t oplock_level = OPLOCK_NONE, oplock_granted;
+       bool allow_level_II_oplock = false;
 
        /* use the generic mapping code to avoid implementing all the
           different open calls. */
@@ -985,6 +1135,48 @@ NTSTATUS pvfs_open(struct ntvfs_module_context *ntvfs,
                return ntvfs_map_open(ntvfs, req, io);
        }
 
+       create_options = io->generic.in.create_options;
+       share_access   = io->generic.in.share_access;
+       access_mask    = io->generic.in.access_mask;
+
+       if (share_access & ~NTCREATEX_SHARE_ACCESS_MASK) {
+               return NT_STATUS_INVALID_PARAMETER;
+       }
+
+       /* some create options are not supported */
+       if (create_options & NTCREATEX_OPTIONS_NOT_SUPPORTED_MASK) {
+               return NT_STATUS_NOT_SUPPORTED;
+       }
+
+       /* other create options are not allowed */
+       if ((create_options & NTCREATEX_OPTIONS_DELETE_ON_CLOSE) &&
+           !(access_mask & SEC_STD_DELETE)) {
+               return NT_STATUS_INVALID_PARAMETER;
+       }
+
+       if (access_mask & SEC_MASK_INVALID) {
+               return NT_STATUS_ACCESS_DENIED;
+       }
+
+       /* what does this bit really mean?? */
+       if (req->ctx->protocol == PROTOCOL_SMB2 &&
+           access_mask == SEC_STD_SYNCHRONIZE) {
+               return NT_STATUS_ACCESS_DENIED;
+       }
+
+       if (io->ntcreatex.in.file_attr & (FILE_ATTRIBUTE_DEVICE|
+                                         FILE_ATTRIBUTE_VOLUME| 
+                                         (~FILE_ATTRIBUTE_ALL_MASK))) {
+               return NT_STATUS_INVALID_PARAMETER;
+       }
+
+       /* we ignore some file_attr bits */
+       io->ntcreatex.in.file_attr &= ~(FILE_ATTRIBUTE_NONINDEXED | 
+                                       FILE_ATTRIBUTE_COMPRESSED |
+                                       FILE_ATTRIBUTE_REPARSE_POINT |
+                                       FILE_ATTRIBUTE_SPARSE |
+                                       FILE_ATTRIBUTE_NORMAL);
+
        /* resolve the cifs name to a posix name */
        status = pvfs_resolve_name(pvfs, req, io->ntcreatex.in.fname, 
                                   PVFS_RESOLVE_STREAMS, &name);
@@ -992,6 +1184,20 @@ NTSTATUS pvfs_open(struct ntvfs_module_context *ntvfs,
                return status;
        }
 
+       /* if the client specified that it must not be a directory then
+          check that it isn't */
+       if (name->exists && (name->dos.attrib & FILE_ATTRIBUTE_DIRECTORY) &&
+           (io->generic.in.create_options & NTCREATEX_OPTIONS_NON_DIRECTORY_FILE)) {
+               return NT_STATUS_FILE_IS_A_DIRECTORY;
+       }
+
+       /* if the client specified that it must be a directory then
+          check that it is */
+       if (name->exists && !(name->dos.attrib & FILE_ATTRIBUTE_DIRECTORY) &&
+           (io->generic.in.create_options & NTCREATEX_OPTIONS_DIRECTORY)) {
+               return NT_STATUS_NOT_A_DIRECTORY;
+       }
+
        /* directory opens are handled separately */
        if ((name->exists && (name->dos.attrib & FILE_ATTRIBUTE_DIRECTORY)) ||
            (io->generic.in.create_options & NTCREATEX_OPTIONS_DIRECTORY)) {
@@ -1002,16 +1208,6 @@ NTSTATUS pvfs_open(struct ntvfs_module_context *ntvfs,
           open doesn't match */
        io->generic.in.file_attr &= ~FILE_ATTRIBUTE_DIRECTORY;
 
-       create_options = io->generic.in.create_options;
-       share_access   = io->generic.in.share_access;
-       access_mask    = io->generic.in.access_mask;
-
-       /* certain create options are not allowed */
-       if ((create_options & NTCREATEX_OPTIONS_DELETE_ON_CLOSE) &&
-           !(access_mask & SEC_STD_DELETE)) {
-               return NT_STATUS_INVALID_PARAMETER;
-       }
-
        flags = 0;
 
        switch (io->generic.in.open_disposition) {
@@ -1020,8 +1216,9 @@ NTSTATUS pvfs_open(struct ntvfs_module_context *ntvfs,
                if (name->stream_name == NULL) {
                        flags = O_TRUNC;
                } else {
-                       stream_truncate = True;
+                       stream_truncate = true;
                }
+               create_action = NTCREATEX_ACTION_TRUNCATED;
                break;
 
        case NTCREATEX_DISP_OPEN:
@@ -1038,8 +1235,9 @@ NTSTATUS pvfs_open(struct ntvfs_module_context *ntvfs,
                if (name->stream_name == NULL) {
                        flags = O_TRUNC;
                } else {
-                       stream_truncate = True;
+                       stream_truncate = true;
                }
+               create_action = NTCREATEX_ACTION_TRUNCATED;
                break;
 
        case NTCREATEX_DISP_CREATE:
@@ -1088,7 +1286,10 @@ NTSTATUS pvfs_open(struct ntvfs_module_context *ntvfs,
                return status;
        }
 
-       f = talloc(req, struct pvfs_file);
+       status = ntvfs_handle_new(pvfs->ntvfs, req, &h);
+       NT_STATUS_NOT_OK_RETURN(status);
+
+       f = talloc(h, struct pvfs_file);
        if (f == NULL) {
                return NT_STATUS_NO_MEMORY;
        }
@@ -1098,21 +1299,15 @@ NTSTATUS pvfs_open(struct ntvfs_module_context *ntvfs,
                return NT_STATUS_NO_MEMORY;
        }
 
-       /* allocate a fnum */
-       fnum = idr_get_new_above(pvfs->idtree_fnum, f, PVFS_MIN_FILE_FNUM, UINT16_MAX);
-       if (fnum == -1) {
-               return NT_STATUS_TOO_MANY_OPENED_FILES;
-       }
-
-       f->fnum          = fnum;
-       f->session       = req->session;
-       f->smbpid        = req->smbpid;
+       f->ntvfs         = h;
        f->pvfs          = pvfs;
        f->pending_list  = NULL;
        f->lock_count    = 0;
        f->share_access  = io->generic.in.share_access;
        f->access_mask   = access_mask;
        f->impersonation = io->generic.in.impersonation;
+       f->notify_buffer = NULL;
+       f->search        = NULL;
 
        f->handle->pvfs              = pvfs;
        f->handle->fd                = -1;
@@ -1121,20 +1316,19 @@ NTSTATUS pvfs_open(struct ntvfs_module_context *ntvfs,
        f->handle->seek_offset       = 0;
        f->handle->position          = 0;
        f->handle->mode              = 0;
-       f->handle->have_opendb_entry = False;
-       f->handle->sticky_write_time = False;
+       f->handle->oplock            = NULL;
+       f->handle->have_opendb_entry = false;
+       f->handle->open_completed    = false;
 
        /* form the lock context used for byte range locking and
           opendb locking */
        status = pvfs_locking_key(name, f->handle, &f->handle->odb_locking_key);
        if (!NT_STATUS_IS_OK(status)) {
-               idr_remove(pvfs->idtree_fnum, f->fnum);
                return status;
        }
 
-       status = pvfs_brl_locking_key(name, f->handle, &f->handle->brl_locking_key);
+       status = pvfs_brl_locking_handle(f, name, h, &f->brl_handle);
        if (!NT_STATUS_IS_OK(status)) {
-               idr_remove(pvfs->idtree_fnum, f->fnum);
                return status;
        }
 
@@ -1145,26 +1339,54 @@ NTSTATUS pvfs_open(struct ntvfs_module_context *ntvfs,
                         name->full_name));
                /* we were supposed to do a blocking lock, so something
                   is badly wrong! */
-               idr_remove(pvfs->idtree_fnum, fnum);
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
-       DLIST_ADD(pvfs->open_files, f);
+       DLIST_ADD(pvfs->files.list, f);
 
        /* setup a destructor to avoid file descriptor leaks on
           abnormal termination */
        talloc_set_destructor(f, pvfs_fnum_destructor);
        talloc_set_destructor(f->handle, pvfs_handle_destructor);
 
+       /* 
+        * Only SMB2 takes care of the delete_on_close,
+        * on existing files
+        */
+       if (create_options & NTCREATEX_OPTIONS_DELETE_ON_CLOSE &&
+           req->ctx->protocol == PROTOCOL_SMB2) {
+               del_on_close = true;
+       } else {
+               del_on_close = false;
+       }
+
+       if (pvfs->flags & PVFS_FLAG_FAKE_OPLOCKS) {
+               oplock_level = OPLOCK_NONE;
+       } else if (io->ntcreatex.in.flags & NTCREATEX_FLAGS_REQUEST_BATCH_OPLOCK) {
+               oplock_level = OPLOCK_BATCH;
+       } else if (io->ntcreatex.in.flags & NTCREATEX_FLAGS_REQUEST_OPLOCK) {
+               oplock_level = OPLOCK_EXCLUSIVE;
+       }
+
+       if (req->client_caps & NTVFS_CLIENT_CAP_LEVEL_II_OPLOCKS) {
+               allow_level_II_oplock = true;
+       }
+
        /* see if we are allowed to open at the same time as existing opens */
-       status = odb_open_file(lck, f->handle, f->handle->name->stream_id,
-                              share_access, access_mask, False, name->full_name);
+       status = odb_can_open(lck, name->stream_id,
+                             share_access, access_mask, del_on_close,
+                             io->generic.in.open_disposition, false);
 
-       /* on a sharing violation we need to retry when the file is closed by 
-          the other user, or after 1 second */
-       if (NT_STATUS_EQUAL(status, NT_STATUS_SHARING_VIOLATION) &&
+       /*
+        * on a sharing violation we need to retry when the file is closed by
+        * the other user, or after 1 second
+        * on a non granted oplock we need to retry when the file is closed by
+        * the other user, or after 30 seconds
+       */
+       if ((NT_STATUS_EQUAL(status, NT_STATUS_SHARING_VIOLATION) ||
+            NT_STATUS_EQUAL(status, NT_STATUS_OPLOCK_NOT_GRANTED)) &&
            (req->async_states->state & NTVFS_ASYNC_STATE_MAY_ASYNC)) {
-               return pvfs_open_setup_retry(ntvfs, req, io, f, lck);
+               return pvfs_open_setup_retry(ntvfs, req, io, f, lck, status);
        }
 
        if (!NT_STATUS_IS_OK(status)) {
@@ -1172,8 +1394,6 @@ NTSTATUS pvfs_open(struct ntvfs_module_context *ntvfs,
                return status;
        }
 
-       f->handle->have_opendb_entry = True;
-
        if (access_mask & (SEC_FILE_WRITE_DATA | SEC_FILE_APPEND_DATA)) {
                flags |= O_RDWR;
        } else {
@@ -1181,14 +1401,46 @@ NTSTATUS pvfs_open(struct ntvfs_module_context *ntvfs,
        }
 
        /* do the actual open */
-       fd = open(f->handle->name->full_name, flags);
+       fd = open(f->handle->name->full_name, flags | O_NONBLOCK);
        if (fd == -1) {
+               status = pvfs_map_errno(f->pvfs, errno);
+
+               /*
+                * STATUS_MORE_ENTRIES is EAGAIN or EWOULDBLOCK
+                */
+               if (NT_STATUS_EQUAL(status, STATUS_MORE_ENTRIES) &&
+                   (req->async_states->state & NTVFS_ASYNC_STATE_MAY_ASYNC)) {
+                       return pvfs_open_setup_retry(ntvfs, req, io, f, lck, status);
+               }
+
                talloc_free(lck);
-               return pvfs_map_errno(f->pvfs, errno);
+               return status;
        }
 
        f->handle->fd = fd;
 
+       /* now really mark the file as open */
+       status = odb_open_file(lck, f->handle, name->full_name,
+                              &f->handle->fd, allow_level_II_oplock,
+                              oplock_level, &oplock_granted);
+
+       if (!NT_STATUS_IS_OK(status)) {
+               talloc_free(lck);
+               return status;
+       }
+
+       f->handle->have_opendb_entry = true;
+
+       if (pvfs->flags & PVFS_FLAG_FAKE_OPLOCKS) {
+               oplock_granted = OPLOCK_BATCH;
+       } else if (oplock_granted != OPLOCK_NONE) {
+               status = pvfs_setup_oplock(f, oplock_granted);
+               if (!NT_STATUS_IS_OK(status)) {
+                       talloc_free(lck);
+                       return status;
+               }
+       }
+
        stream_existed = name->stream_exists;
 
        /* if this was a stream create then create the stream as well */
@@ -1224,6 +1476,7 @@ NTSTATUS pvfs_open(struct ntvfs_module_context *ntvfs,
                        talloc_free(lck);
                        return pvfs_map_errno(pvfs, errno);
                }
+               name->dos.alloc_size = io->ntcreatex.in.alloc_size;
                name->dos.attrib = attrib;
                status = pvfs_dosattrib_save(pvfs, name, fd);
                if (!NT_STATUS_IS_OK(status)) {
@@ -1234,14 +1487,18 @@ NTSTATUS pvfs_open(struct ntvfs_module_context *ntvfs,
            
        talloc_free(lck);
 
-       if (pvfs->flags & PVFS_FLAG_FAKE_OPLOCKS) {
-               io->generic.out.oplock_level  = OPLOCK_EXCLUSIVE;
-       } else {
-               io->generic.out.oplock_level  = OPLOCK_NONE;
-       }
-       io->generic.out.file.fnum     = f->fnum;
+       status = ntvfs_handle_set_backend_data(h, ntvfs, f);
+       NT_STATUS_NOT_OK_RETURN(status);
+
+       /* mark the open as having completed fully, so delete on close
+          can now be used */
+       f->handle->open_completed     = true;
+
+       io->generic.out.oplock_level  = oplock_granted;
+       io->generic.out.file.ntvfs    = h;
        io->generic.out.create_action = stream_existed?
-               NTCREATEX_ACTION_EXISTED:NTCREATEX_ACTION_CREATED;
+               create_action:NTCREATEX_ACTION_CREATED;
+       
        io->generic.out.create_time   = name->dos.create_time;
        io->generic.out.access_time   = name->dos.access_time;
        io->generic.out.write_time    = name->dos.write_time;
@@ -1253,9 +1510,6 @@ NTSTATUS pvfs_open(struct ntvfs_module_context *ntvfs,
        io->generic.out.ipc_state     = 0;
        io->generic.out.is_directory  = 0;
 
-       /* success - keep the file handle */
-       talloc_steal(f->pvfs, f);
-
        return NT_STATUS_OK;
 }
 
@@ -1274,23 +1528,42 @@ NTSTATUS pvfs_close(struct ntvfs_module_context *ntvfs,
                return NT_STATUS_DOS(ERRSRV, ERRerror);
        }
 
-       if (io->generic.level != RAW_CLOSE_CLOSE) {
+       if (io->generic.level != RAW_CLOSE_GENERIC) {
                return ntvfs_map_close(ntvfs, req, io);
        }
 
-       f = pvfs_find_fd(pvfs, req, io->close.in.file.fnum);
+       f = pvfs_find_fd(pvfs, req, io->generic.in.file.ntvfs);
        if (!f) {
                return NT_STATUS_INVALID_HANDLE;
        }
 
-       if (!null_time(io->close.in.write_time)) {
+       if (!null_time(io->generic.in.write_time)) {
                unix_times.actime = 0;
                unix_times.modtime = io->close.in.write_time;
                utime(f->handle->name->full_name, &unix_times);
-       } else if (f->handle->sticky_write_time) {
-               unix_times.actime = 0;
-               unix_times.modtime = nt_time_to_unix(f->handle->name->dos.write_time);
-               utime(f->handle->name->full_name, &unix_times);
+       }
+
+       if (io->generic.in.flags & SMB2_CLOSE_FLAGS_FULL_INFORMATION) {
+               struct pvfs_filename *name;
+               NTSTATUS status;
+               struct pvfs_file_handle *h = f->handle;
+
+               status = pvfs_resolve_name_handle(pvfs, h);
+               if (!NT_STATUS_IS_OK(status)) {
+                       return status;
+               }
+               name = h->name;
+
+               io->generic.out.flags = SMB2_CLOSE_FLAGS_FULL_INFORMATION;
+               io->generic.out.create_time = name->dos.create_time;
+               io->generic.out.access_time = name->dos.access_time;
+               io->generic.out.write_time  = name->dos.write_time;
+               io->generic.out.change_time = name->dos.change_time;
+               io->generic.out.alloc_size  = name->dos.alloc_size;
+               io->generic.out.size        = name->st.st_size;
+               io->generic.out.file_attr   = name->dos.attrib;         
+       } else {
+               ZERO_STRUCT(io->generic.out);
        }
 
        talloc_free(f);
@@ -1308,9 +1581,9 @@ NTSTATUS pvfs_logoff(struct ntvfs_module_context *ntvfs,
        struct pvfs_state *pvfs = ntvfs->private_data;
        struct pvfs_file *f, *next;
 
-       for (f=pvfs->open_files;f;f=next) {
+       for (f=pvfs->files.list;f;f=next) {
                next = f->next;
-               if (f->session == req->session) {
+               if (f->ntvfs->session_info == req->session_info) {
                        talloc_free(f);
                }
        }
@@ -1328,10 +1601,10 @@ NTSTATUS pvfs_exit(struct ntvfs_module_context *ntvfs,
        struct pvfs_state *pvfs = ntvfs->private_data;
        struct pvfs_file *f, *next;
 
-       for (f=pvfs->open_files;f;f=next) {
+       for (f=pvfs->files.list;f;f=next) {
                next = f->next;
-               if (f->session == req->session &&
-                   f->smbpid == req->smbpid) {
+               if (f->ntvfs->session_info == req->session_info &&
+                   f->ntvfs->smbpid == req->smbpid) {
                        talloc_free(f);
                }
        }
@@ -1345,7 +1618,7 @@ NTSTATUS pvfs_exit(struct ntvfs_module_context *ntvfs,
 */
 NTSTATUS pvfs_set_delete_on_close(struct pvfs_state *pvfs,
                                  struct ntvfs_request *req, 
-                                 struct pvfs_file *f, BOOL del_on_close)
+                                 struct pvfs_file *f, bool del_on_close)
 {
        struct odb_lock *lck;
        NTSTATUS status;
@@ -1390,6 +1663,9 @@ NTSTATUS pvfs_can_delete(struct pvfs_state *pvfs,
        NTSTATUS status;
        DATA_BLOB key;
        struct odb_lock *lck;
+       uint32_t share_access;
+       uint32_t access_mask;
+       bool delete_on_close;
 
        status = pvfs_locking_key(name, name, &key);
        if (!NT_STATUS_IS_OK(status)) {
@@ -1402,21 +1678,38 @@ NTSTATUS pvfs_can_delete(struct pvfs_state *pvfs,
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
-       status = odb_can_open(lck,
-                             NTCREATEX_SHARE_ACCESS_READ |
-                             NTCREATEX_SHARE_ACCESS_WRITE | 
-                             NTCREATEX_SHARE_ACCESS_DELETE, 
-                             NTCREATEX_OPTIONS_DELETE_ON_CLOSE, 
-                             SEC_STD_DELETE);
+       share_access    = NTCREATEX_SHARE_ACCESS_READ |
+                         NTCREATEX_SHARE_ACCESS_WRITE |
+                         NTCREATEX_SHARE_ACCESS_DELETE;
+       access_mask     = SEC_STD_DELETE;
+       delete_on_close = true;
+
+       status = odb_can_open(lck, name->stream_id,
+                             share_access, access_mask, delete_on_close,
+                             NTCREATEX_DISP_OPEN, false);
 
        if (NT_STATUS_IS_OK(status)) {
-               status = pvfs_access_check_simple(pvfs, req, name, SEC_STD_DELETE);
+               status = pvfs_access_check_simple(pvfs, req, name, access_mask);
        }
 
-       if (!NT_STATUS_IS_OK(status)) {
+       /*
+        * if it's a sharing violation or we got no oplock
+        * only keep the lock if the caller requested access
+        * to the lock
+        */
+       if (NT_STATUS_EQUAL(status, NT_STATUS_SHARING_VIOLATION) ||
+           NT_STATUS_EQUAL(status, NT_STATUS_OPLOCK_NOT_GRANTED)) {
+               if (lckp) {
+                       *lckp = lck;
+               } else {
+                       talloc_free(lck);
+               }
+       } else if (!NT_STATUS_IS_OK(status)) {
                talloc_free(lck);
-               *lckp = lck;
-       } else if (lckp != NULL) {
+               if (lckp) {
+                       *lckp = NULL;
+               }
+       } else if (lckp) {
                *lckp = lck;
        }
 
@@ -1435,6 +1728,9 @@ NTSTATUS pvfs_can_rename(struct pvfs_state *pvfs,
        NTSTATUS status;
        DATA_BLOB key;
        struct odb_lock *lck;
+       uint32_t share_access;
+       uint32_t access_mask;
+       bool delete_on_close;
 
        status = pvfs_locking_key(name, name, &key);
        if (!NT_STATUS_IS_OK(status)) {
@@ -1447,16 +1743,105 @@ NTSTATUS pvfs_can_rename(struct pvfs_state *pvfs,
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
-       status = odb_can_open(lck,
-                             NTCREATEX_SHARE_ACCESS_READ |
-                             NTCREATEX_SHARE_ACCESS_WRITE,
-                             0,
-                             SEC_STD_DELETE);
+       share_access    = NTCREATEX_SHARE_ACCESS_READ |
+                         NTCREATEX_SHARE_ACCESS_WRITE;
+       access_mask     = SEC_STD_DELETE;
+       delete_on_close = false;
 
-       if (!NT_STATUS_IS_OK(status)) {
+       status = odb_can_open(lck, name->stream_id,
+                             share_access, access_mask, delete_on_close,
+                             NTCREATEX_DISP_OPEN, false);
+
+       /*
+        * if it's a sharing violation or we got no oplock
+        * only keep the lock if the caller requested access
+        * to the lock
+        */
+       if (NT_STATUS_EQUAL(status, NT_STATUS_SHARING_VIOLATION) ||
+           NT_STATUS_EQUAL(status, NT_STATUS_OPLOCK_NOT_GRANTED)) {
+               if (lckp) {
+                       *lckp = lck;
+               } else {
+                       talloc_free(lck);
+               }
+       } else if (!NT_STATUS_IS_OK(status)) {
                talloc_free(lck);
+               if (lckp) {
+                       *lckp = NULL;
+               }
+       } else if (lckp) {
                *lckp = lck;
-       } else if (lckp != NULL) {
+       }
+
+       return status;
+}
+
+/*
+  determine if the file size of a file can be changed,
+  or if it is prevented by an already open file
+*/
+NTSTATUS pvfs_can_update_file_size(struct pvfs_state *pvfs,
+                                  struct ntvfs_request *req,
+                                  struct pvfs_filename *name,
+                                  struct odb_lock **lckp)
+{
+       NTSTATUS status;
+       DATA_BLOB key;
+       struct odb_lock *lck;
+       uint32_t share_access;
+       uint32_t access_mask;
+       bool break_to_none;
+       bool delete_on_close;
+
+       status = pvfs_locking_key(name, name, &key);
+       if (!NT_STATUS_IS_OK(status)) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       lck = odb_lock(req, pvfs->odb_context, &key);
+       if (lck == NULL) {
+               DEBUG(0,("Unable to lock opendb for can_stat\n"));
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+       }
+
+       share_access    = NTCREATEX_SHARE_ACCESS_READ |
+                         NTCREATEX_SHARE_ACCESS_WRITE |
+                         NTCREATEX_SHARE_ACCESS_DELETE;
+       /*
+        * I would have thought that we would need to pass
+        * SEC_FILE_WRITE_DATA | SEC_FILE_APPEND_DATA here too
+        *
+        * But you only need SEC_FILE_WRITE_ATTRIBUTE permissions
+        * to set the filesize.
+        *
+        * --metze
+        */
+       access_mask     = SEC_FILE_WRITE_ATTRIBUTE;
+       delete_on_close = false;
+       break_to_none   = true;
+
+       status = odb_can_open(lck, name->stream_id,
+                             share_access, access_mask, delete_on_close,
+                             NTCREATEX_DISP_OPEN, break_to_none);
+
+       /*
+        * if it's a sharing violation or we got no oplock
+        * only keep the lock if the caller requested access
+        * to the lock
+        */
+       if (NT_STATUS_EQUAL(status, NT_STATUS_SHARING_VIOLATION) ||
+           NT_STATUS_EQUAL(status, NT_STATUS_OPLOCK_NOT_GRANTED)) {
+               if (lckp) {
+                       *lckp = lck;
+               } else {
+                       talloc_free(lck);
+               }
+       } else if (!NT_STATUS_IS_OK(status)) {
+               talloc_free(lck);
+               if (lckp) {
+                       *lckp = NULL;
+               }
+       } else if (lckp) {
                *lckp = lck;
        }
 
@@ -1474,6 +1859,9 @@ NTSTATUS pvfs_can_stat(struct pvfs_state *pvfs,
        NTSTATUS status;
        DATA_BLOB key;
        struct odb_lock *lck;
+       uint32_t share_access;
+       uint32_t access_mask;
+       bool delete_on_close;
 
        status = pvfs_locking_key(name, name, &key);
        if (!NT_STATUS_IS_OK(status)) {
@@ -1486,10 +1874,18 @@ NTSTATUS pvfs_can_stat(struct pvfs_state *pvfs,
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
-       status = odb_can_open(lck,
-                             NTCREATEX_SHARE_ACCESS_READ |
-                             NTCREATEX_SHARE_ACCESS_WRITE,
-                             0, 0);
+       share_access    = NTCREATEX_SHARE_ACCESS_READ |
+                         NTCREATEX_SHARE_ACCESS_WRITE;
+       access_mask     = SEC_FILE_READ_ATTRIBUTE;
+       delete_on_close = false;
+
+       status = odb_can_open(lck, name->stream_id,
+                             share_access, access_mask, delete_on_close,
+                             NTCREATEX_DISP_OPEN, false);
+
+       if (!NT_STATUS_IS_OK(status)) {
+               talloc_free(lck);
+       }
 
        return status;
 }
@@ -1498,17 +1894,16 @@ NTSTATUS pvfs_can_stat(struct pvfs_state *pvfs,
 /*
   determine if delete on close is set on 
 */
-BOOL pvfs_delete_on_close_set(struct pvfs_state *pvfs, struct pvfs_file_handle *h, 
-                             int *open_count, char **path)
+bool pvfs_delete_on_close_set(struct pvfs_state *pvfs, struct pvfs_file_handle *h)
 {
        NTSTATUS status;
-       BOOL del_on_close;
+       bool del_on_close;
 
        status = odb_get_delete_on_close(pvfs->odb_context, &h->odb_locking_key, 
-                                        &del_on_close, open_count, path);
+                                        &del_on_close);
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(1,("WARNING: unable to determine delete on close status for open file\n"));
-               return False;
+               return false;
        }
 
        return del_on_close;