s4-repl: Allow dsdb_replicated_objects_commit() to use different schema while committ...
[kai/samba.git] / source4 / libnet / libnet_vampire.c
index c8161e182d662e6a22dc0fcea8421ca60bdae539..40cf01ed528740a4b5df08380fbf139bddd428e6 100644 (file)
 #include "librpc/gen_ndr/ndr_drsblobs.h"
 #include "librpc/gen_ndr/ndr_misc.h"
 #include "system/time.h"
-#include "lib/ldb_wrap.h"
+#include "ldb_wrap.h"
 #include "auth/auth.h"
+#include "auth/credentials/credentials.h"
 #include "param/param.h"
 #include "param/provision.h"
-#include "libcli/security/dom_sid.h"
+#include "libcli/security/security.h"
+#include "dsdb/common/util.h"
 
 /* 
 List of tasks vampire.py must perform:
@@ -53,11 +55,21 @@ List of tasks vampire.py must perform:
 - Write out the secrets database, using the code from libnet_Join
 
 */
-struct vampire_state {
+struct libnet_vampire_cb_state {
        const char *netbios_name;
-       struct libnet_JoinDomain *join;
+       const char *domain_name;
+       const char *realm;
        struct cli_credentials *machine_account;
+
+       /* Schema loaded from local LDIF files */
+       struct dsdb_schema *provision_schema;
+
+        /* 1st pass, with some OIDs/attribute names/class names not
+        * converted, because we may not know them yet */
        struct dsdb_schema *self_made_schema;
+
+       /* prefixMap in LDB format, from the remote DRS server */
+       DATA_BLOB prefixmap_blob;
        const struct dsdb_schema *schema;
 
        struct ldb_context *ldb;
@@ -74,12 +86,66 @@ struct vampire_state {
        struct tevent_context *event_ctx;
        unsigned total_objects;
        char *last_partition;
+       const char *server_dn_str;
 };
 
-static NTSTATUS vampire_prepare_db(void *private_data,
-                                             const struct libnet_BecomeDC_PrepareDB *p)
+/* initialise a state structure ready for replication of chunks */
+void *libnet_vampire_replicate_init(TALLOC_CTX *mem_ctx,
+                                   struct ldb_context *samdb,
+                                   struct loadparm_context *lp_ctx)
 {
-       struct vampire_state *s = talloc_get_type(private_data, struct vampire_state);
+       struct libnet_vampire_cb_state *s = talloc_zero(mem_ctx, struct libnet_vampire_cb_state);
+       if (!s) {
+               return NULL;
+       }
+
+       s->ldb              = samdb;
+       s->lp_ctx           = lp_ctx;
+       s->provision_schema = dsdb_get_schema(s->ldb, s);
+       s->schema           = s->provision_schema;
+       s->netbios_name     = lpcfg_netbios_name(lp_ctx);
+       s->domain_name      = lpcfg_workgroup(lp_ctx);
+       s->realm            = lpcfg_realm(lp_ctx);
+
+       return s;
+}
+
+/* Caller is expected to keep supplied pointers around for the lifetime of the structure */
+void *libnet_vampire_cb_state_init(TALLOC_CTX *mem_ctx,
+                                  struct loadparm_context *lp_ctx, struct tevent_context *event_ctx,
+                                  const char *netbios_name, const char *domain_name, const char *realm,
+                                  const char *targetdir)
+{
+       struct libnet_vampire_cb_state *s = talloc_zero(mem_ctx, struct libnet_vampire_cb_state);
+       if (!s) {
+               return NULL;
+       }
+
+       s->lp_ctx = lp_ctx;
+       s->event_ctx = event_ctx;
+       s->netbios_name = netbios_name;
+       s->domain_name = domain_name;
+       s->realm = realm;
+       s->targetdir = targetdir;
+       return s;
+}
+
+struct ldb_context *libnet_vampire_cb_ldb(struct libnet_vampire_cb_state *state)
+{
+       state = talloc_get_type_abort(state, struct libnet_vampire_cb_state);
+       return state->ldb;
+}
+
+struct loadparm_context *libnet_vampire_cb_lp_ctx(struct libnet_vampire_cb_state *state)
+{
+       state = talloc_get_type_abort(state, struct libnet_vampire_cb_state);
+       return state->lp_ctx;
+}
+
+NTSTATUS libnet_vampire_cb_prepare_db(void *private_data,
+                                     const struct libnet_BecomeDC_PrepareDB *p)
+{
+       struct libnet_vampire_cb_state *s = talloc_get_type(private_data, struct libnet_vampire_cb_state);
        struct provision_settings settings;
        struct provision_result result;
        NTSTATUS status;
@@ -91,10 +157,10 @@ static NTSTATUS vampire_prepare_db(void *private_data,
        settings.config_dn_str = p->forest->config_dn_str;
        settings.schema_dn_str = p->forest->schema_dn_str;
        settings.netbios_name = p->dest_dsa->netbios_name;
-       settings.realm = s->join->out.realm;
-       settings.domain = s->join->out.domain_name;
+       settings.realm = s->realm;
+       settings.domain = s->domain_name;
        settings.server_dn_str = p->dest_dsa->server_dn_str;
-       settings.machine_password = generate_random_str(s, 16);
+       settings.machine_password = generate_random_password(s, 16, 255);
        settings.targetdir = s->targetdir;
 
        status = provision_bare(s, s->lp_ctx, &settings, &result);
@@ -103,8 +169,10 @@ static NTSTATUS vampire_prepare_db(void *private_data,
                return status;
        }
 
-       s->ldb = result.samdb;
-       s->lp_ctx = result.lp_ctx;
+       s->ldb = talloc_steal(s, result.samdb);
+       s->lp_ctx = talloc_reparent(talloc_parent(result.lp_ctx), s, result.lp_ctx);
+       s->provision_schema = dsdb_get_schema(s->ldb, s);
+       s->server_dn_str = talloc_steal(s, p->dest_dsa->server_dn_str);
 
        /* wrap the entire vapire operation in a transaction.  This
           isn't just cosmetic - we use this to ensure that linked
@@ -124,10 +192,10 @@ static NTSTATUS vampire_prepare_db(void *private_data,
 
 }
 
-static NTSTATUS vampire_check_options(void *private_data,
-                                            const struct libnet_BecomeDC_CheckOptions *o)
+NTSTATUS libnet_vampire_cb_check_options(void *private_data,
+                                        const struct libnet_BecomeDC_CheckOptions *o)
 {
-       struct vampire_state *s = talloc_get_type(private_data, struct vampire_state);
+       struct libnet_vampire_cb_state *s = talloc_get_type(private_data, struct libnet_vampire_cb_state);
 
        DEBUG(0,("Become DC [%s] of Domain[%s]/[%s]\n",
                s->netbios_name,
@@ -148,26 +216,34 @@ static NTSTATUS vampire_check_options(void *private_data,
        return NT_STATUS_OK;
 }
 
-static NTSTATUS vampire_apply_schema(struct vampire_state *s,
-                                 const struct libnet_BecomeDC_StoreChunk *c)
+static NTSTATUS libnet_vampire_cb_apply_schema(struct libnet_vampire_cb_state *s,
+                                              const struct libnet_BecomeDC_StoreChunk *c)
 {
+       struct schema_list {
+               struct schema_list *next, *prev;
+               const struct drsuapi_DsReplicaObjectListItemEx *obj;
+       };
+
        WERROR status;
+       struct dsdb_schema_prefixmap *pfm_remote;
        const struct drsuapi_DsReplicaOIDMapping_Ctr *mapping_ctr;
-       uint32_t object_count;
+       struct schema_list *schema_list = NULL, *schema_list_item, *schema_list_next_item;
+       struct dsdb_schema *working_schema;
+       struct dsdb_schema *provision_schema;
+       uint32_t object_count = 0;
        struct drsuapi_DsReplicaObjectListItemEx *first_object;
-       struct drsuapi_DsReplicaObjectListItemEx *cur;
+       const struct drsuapi_DsReplicaObjectListItemEx *cur;
        uint32_t linked_attributes_count;
        struct drsuapi_DsReplicaLinkedAttribute *linked_attributes;
        const struct drsuapi_DsReplicaCursor2CtrEx *uptodateness_vector;
-       struct dsdb_extended_replicated_objects *objs;
+       struct dsdb_extended_replicated_objects *schema_objs;
        struct repsFromTo1 *s_dsa;
        char *tmp_dns_name;
+       struct ldb_context *schema_ldb;
        struct ldb_message *msg;
-       struct ldb_val prefixMap_val;
        struct ldb_message_element *prefixMap_el;
-       struct ldb_val schemaInfo_val;
        uint32_t i;
-       int ret;
+       int ret, pass_no;
        bool ok;
        uint64_t seq_num;
 
@@ -205,9 +281,17 @@ static NTSTATUS vampire_apply_schema(struct vampire_state *s,
                return NT_STATUS_INVALID_PARAMETER;
        }
 
-       s_dsa->replica_flags            = DRSUAPI_DS_REPLICA_NEIGHBOUR_WRITEABLE
-                                       | DRSUAPI_DS_REPLICA_NEIGHBOUR_SYNC_ON_STARTUP
-                                       | DRSUAPI_DS_REPLICA_NEIGHBOUR_DO_SCHEDULED_SYNCS;
+       status = dsdb_schema_pfm_from_drsuapi_pfm(mapping_ctr, true,
+                                                 s, &pfm_remote, NULL);
+       if (!W_ERROR_IS_OK(status)) {
+               DEBUG(0,(__location__ ": Failed to decode remote prefixMap: %s",
+                        win_errstr(status)));
+               return werror_to_ntstatus(status);
+       }
+
+       s_dsa->replica_flags            = DRSUAPI_DRS_WRIT_REP
+                                       | DRSUAPI_DRS_INIT_SYNC
+                                       | DRSUAPI_DRS_PER_SYNC;
        memset(s_dsa->schedule, 0x11, sizeof(s_dsa->schedule));
 
        tmp_dns_name    = GUID_string(s_dsa->other_info, &s_dsa->source_dsa_obj_guid);
@@ -216,135 +300,184 @@ static NTSTATUS vampire_apply_schema(struct vampire_state *s,
        NT_STATUS_HAVE_NO_MEMORY(tmp_dns_name);
        s_dsa->other_info->dns_name = tmp_dns_name;
 
-       for (cur = first_object; cur; cur = cur->next_object) {
-               bool is_attr = false;
-               bool is_class = false;
+       schema_ldb = provision_get_schema(s, s->lp_ctx, &s->prefixmap_blob);
+       if (!schema_ldb) {
+               DEBUG(0,("Failed to re-load from local provision using remote prefixMap. "
+                        "Will continue with local prefixMap\n"));
+               provision_schema = dsdb_get_schema(s->ldb, s);
+       } else {
+               provision_schema = dsdb_get_schema(schema_ldb, s);
+               ret = dsdb_reference_schema(s->ldb, provision_schema, false);
+               if (ret != LDB_SUCCESS) {
+                       DEBUG(0,("Failed to attach schema from local provision using remote prefixMap."));
+                       return NT_STATUS_UNSUCCESSFUL;
+               }
+               talloc_free(schema_ldb);
+       }
 
-               for (i=0; i < cur->object.attribute_ctr.num_attributes; i++) {
-                       struct drsuapi_DsReplicaAttribute *a;
-                       uint32_t j;
-                       const char *oid = NULL;
+       /* create a list of objects yet to be converted */
+       for (cur = first_object; cur; cur = cur->next_object) {
+               schema_list_item = talloc(s, struct schema_list);
+               schema_list_item->obj = cur;
+               DLIST_ADD_END(schema_list, schema_list_item, struct schema_list);
+       }
 
-                       a = &cur->object.attribute_ctr.attributes[i];
-                       status = dsdb_map_int2oid(s->self_made_schema, a->attid, s, &oid);
+       /* resolve objects until all are resolved and in local schema */
+       pass_no = 1;
+       working_schema = provision_schema;
+
+       while (schema_list) {
+               uint32_t converted_obj_count = 0;
+               uint32_t failed_obj_count = 0;
+               TALLOC_CTX *tmp_ctx = talloc_new(s);
+               NT_STATUS_HAVE_NO_MEMORY(tmp_ctx);
+
+               for (schema_list_item = schema_list; schema_list_item; schema_list_item=schema_list_next_item) {
+                       struct dsdb_extended_replicated_object object;
+
+                       cur = schema_list_item->obj;
+
+                       /* Save the next item, now we have saved out
+                        * the current one, so we can DLIST_REMOVE it
+                        * safely */
+                       schema_list_next_item = schema_list_item->next;
+
+                       /*
+                        * Convert the objects into LDB messages using the
+                        * schema we have so far. It's ok if we fail to convert
+                        * an object. We should convert more objects on next pass.
+                        */
+                       status = dsdb_convert_object_ex(s->ldb, working_schema, pfm_remote,
+                                                       cur, c->gensec_skey,
+                                                       tmp_ctx, &object);
                        if (!W_ERROR_IS_OK(status)) {
-                               return werror_to_ntstatus(status);
-                       }
-
-                       switch (a->attid) {
-                       case DRSUAPI_ATTRIBUTE_objectClass:
-                               for (j=0; j < a->value_ctr.num_values; j++) {
-                                       uint32_t val = 0xFFFFFFFF;
-
-                                       if (a->value_ctr.values[j].blob
-                                           && a->value_ctr.values[j].blob->length == 4) {
-                                               val = IVAL(a->value_ctr.values[j].blob->data,0);
-                                       }
-
-                                       if (val == DRSUAPI_OBJECTCLASS_attributeSchema) {
-                                               is_attr = true;
-                                       }
-                                       if (val == DRSUAPI_OBJECTCLASS_classSchema) {
-                                               is_class = true;
-                                       }
+                               DEBUG(1,("Warning: Failed to convert schema object %s into ldb msg\n",
+                                        cur->object.identifier->dn));
+
+                               failed_obj_count++;
+                       } else {
+                               /*
+                                * Convert the schema from ldb_message format
+                                * (OIDs as OID strings) into schema, using
+                                * the remote prefixMap
+                                */
+                               status = dsdb_schema_set_el_from_ldb_msg(s->ldb,
+                                                                        s->self_made_schema,
+                                                                        object.msg);
+                               if (!W_ERROR_IS_OK(status)) {
+                                       DEBUG(1,("Warning: failed to convert object %s into a schema element: %s\n",
+                                                ldb_dn_get_linearized(object.msg->dn),
+                                                win_errstr(status)));
+                                       failed_obj_count++;
+                               } else {
+                                       DLIST_REMOVE(schema_list, schema_list_item);
+                                       converted_obj_count++;
                                }
-
-                               break;
-                       default:
-                               break;
                        }
                }
+               talloc_free(tmp_ctx);
 
-               if (is_attr) {
-                       struct dsdb_attribute *sa;
-
-                       sa = talloc_zero(s->self_made_schema, struct dsdb_attribute);
-                       NT_STATUS_HAVE_NO_MEMORY(sa);
+               DEBUG(4,("Schema load pass %d: %d/%d of %d objects left to be converted.\n",
+                        pass_no, failed_obj_count, converted_obj_count, object_count));
+               pass_no++;
 
-                       status = dsdb_attribute_from_drsuapi(s->ldb, s->self_made_schema, &cur->object, s, sa);
-                       if (!W_ERROR_IS_OK(status)) {
-                               return werror_to_ntstatus(status);
-                       }
-
-                       DLIST_ADD_END(s->self_made_schema->attributes, sa, struct dsdb_attribute *);
+               /* check if we converted any objects in this pass */
+               if (converted_obj_count == 0) {
+                       DEBUG(0,("Can't continue Schema load: didn't manage to convert any objects: all %d remaining of %d objects failed to convert\n", failed_obj_count, object_count));
+                       return NT_STATUS_INTERNAL_ERROR;
                }
 
-               if (is_class) {
-                       struct dsdb_class *sc;
+               if (schema_list) {
+                       /* prepare for another cycle */
+                       working_schema = s->self_made_schema;
 
-                       sc = talloc_zero(s->self_made_schema, struct dsdb_class);
-                       NT_STATUS_HAVE_NO_MEMORY(sc);
-
-                       status = dsdb_class_from_drsuapi(s->self_made_schema, &cur->object, s, sc);
-                       if (!W_ERROR_IS_OK(status)) {
-                               return werror_to_ntstatus(status);
+                       ret = dsdb_setup_sorted_accessors(s->ldb, working_schema);
+                       if (LDB_SUCCESS != ret) {
+                               DEBUG(0,("Failed to create schema-cache indexes!\n"));
+                               return NT_STATUS_INTERNAL_ERROR;
                        }
-
-                       DLIST_ADD_END(s->self_made_schema->classes, sc, struct dsdb_class *);
                }
-       }
+       };
+
+       /* free temp objects for 1st conversion phase */
+       talloc_unlink(s, provision_schema);
+       TALLOC_FREE(schema_list);
 
-       /* attach the schema to the ldb */
+       /*
+        * attach the schema we just brought over DRS to the ldb,
+        * so we can use it in dsdb_convert_object_ex below
+        */
        ret = dsdb_set_schema(s->ldb, s->self_made_schema);
        if (ret != LDB_SUCCESS) {
+               DEBUG(0,("Failed to attach working schema from DRS.\n"));
                return NT_STATUS_FOOBAR;
        }
+
        /* we don't want to access the self made schema anymore */
+       s->schema = s->self_made_schema;
        s->self_made_schema = NULL;
-       s->schema = dsdb_get_schema(s->ldb);
-
-       status = dsdb_extended_replicated_objects_commit(s->ldb,
-                                                        c->partition->nc.dn,
-                                                        mapping_ctr,
-                                                        object_count,
-                                                        first_object,
-                                                        linked_attributes_count,
-                                                        linked_attributes,
-                                                        s_dsa,
-                                                        uptodateness_vector,
-                                                        c->gensec_skey,
-                                                        s, &objs, &seq_num);
+
+       /* Now convert the schema elements again, using the schema we finalised, ready to actually import */
+       status = dsdb_replicated_objects_convert(s->ldb,
+                                                s->schema,
+                                                c->partition->nc.dn,
+                                                mapping_ctr,
+                                                object_count,
+                                                first_object,
+                                                linked_attributes_count,
+                                                linked_attributes,
+                                                s_dsa,
+                                                uptodateness_vector,
+                                                c->gensec_skey,
+                                                s, &schema_objs);
        if (!W_ERROR_IS_OK(status)) {
-               DEBUG(0,("Failed to commit objects: %s\n", win_errstr(status)));
+               DEBUG(0,("Failed to convert objects when trying to import over DRS (2nd pass, to store remote schema): %s\n", win_errstr(status)));
                return werror_to_ntstatus(status);
        }
 
-       if (lp_parm_bool(s->lp_ctx, NULL, "become dc", "dump objects", false)) {
-               for (i=0; i < objs->num_objects; i++) {
+       if (lpcfg_parm_bool(s->lp_ctx, NULL, "become dc", "dump objects", false)) {
+               for (i=0; i < schema_objs->num_objects; i++) {
                        struct ldb_ldif ldif;
                        fprintf(stdout, "#\n");
                        ldif.changetype = LDB_CHANGETYPE_NONE;
-                       ldif.msg = objs->objects[i].msg;
+                       ldif.msg = schema_objs->objects[i].msg;
                        ldb_ldif_write_file(s->ldb, stdout, &ldif);
-                       NDR_PRINT_DEBUG(replPropertyMetaDataBlob, objs->objects[i].meta_data);
+                       NDR_PRINT_DEBUG(replPropertyMetaDataBlob, schema_objs->objects[i].meta_data);
                }
        }
 
-       msg = ldb_msg_new(objs);
-       NT_STATUS_HAVE_NO_MEMORY(msg);
-       msg->dn = objs->partition_dn;
-
-       status = dsdb_get_oid_mappings_ldb(s->schema, msg, &prefixMap_val, &schemaInfo_val);
+       status = dsdb_replicated_objects_commit(s->ldb, NULL, schema_objs, &seq_num);
        if (!W_ERROR_IS_OK(status)) {
-               DEBUG(0,("Failed dsdb_get_oid_mappings_ldb(%s)\n", win_errstr(status)));
+               DEBUG(0,("Failed to commit objects: %s\n", win_errstr(status)));
                return werror_to_ntstatus(status);
        }
 
-       /* we only add prefixMap here, because schemaInfo is a replicated attribute and already applied */
-       ret = ldb_msg_add_value(msg, "prefixMap", &prefixMap_val, &prefixMap_el);
+       msg = ldb_msg_new(schema_objs);
+       NT_STATUS_HAVE_NO_MEMORY(msg);
+       msg->dn = schema_objs->partition_dn;
+
+       /* We must ensure a prefixMap has been written.  Unlike other
+        * attributes (including schemaInfo), it is not replicated in
+        * the normal replication stream.  We can use the one from
+        * s->prefixmap_blob because we operate with one, unchanging
+        * prefixMap for this entire operation.  */
+       ret = ldb_msg_add_value(msg, "prefixMap", &s->prefixmap_blob, &prefixMap_el);
        if (ret != LDB_SUCCESS) {
                return NT_STATUS_FOOBAR;
        }
-       prefixMap_el->flags = LDB_FLAG_MOD_REPLACE;
+       /* We want to know if a prefixMap was written already, as it
+        * would mean that the above comment was not true, and we have
+        * somehow updated the prefixMap during this transaction */
+       prefixMap_el->flags = LDB_FLAG_MOD_ADD;
 
        ret = ldb_modify(s->ldb, msg);
        if (ret != LDB_SUCCESS) {
-               DEBUG(0,("Failed to add prefixMap and schemaInfo %s\n", ldb_strerror(ret)));
+               DEBUG(0,("Failed to add prefixMap: %s\n", ldb_errstring(s->ldb)));
                return NT_STATUS_FOOBAR;
        }
 
        talloc_free(s_dsa);
-       talloc_free(objs);
+       talloc_free(schema_objs);
 
        /* We must set these up to ensure the replMetaData is written
         * correctly, before our NTDS Settings entry is replicated */
@@ -359,7 +492,7 @@ static NTSTATUS vampire_apply_schema(struct vampire_state *s,
                return NT_STATUS_FOOBAR;
        }
 
-       s->schema = dsdb_get_schema(s->ldb);
+       s->schema = dsdb_get_schema(s->ldb, s);
        if (!s->schema) {
                DEBUG(0,("Failed to get loaded dsdb_schema\n"));
                return NT_STATUS_FOOBAR;
@@ -368,10 +501,10 @@ static NTSTATUS vampire_apply_schema(struct vampire_state *s,
        return NT_STATUS_OK;
 }
 
-static NTSTATUS vampire_schema_chunk(void *private_data,
-                                           const struct libnet_BecomeDC_StoreChunk *c)
+NTSTATUS libnet_vampire_cb_schema_chunk(void *private_data,
+                                       const struct libnet_BecomeDC_StoreChunk *c)
 {
-       struct vampire_state *s = talloc_get_type(private_data, struct vampire_state);
+       struct libnet_vampire_cb_state *s = talloc_get_type(private_data, struct libnet_vampire_cb_state);
        WERROR status;
        const struct drsuapi_DsReplicaOIDMapping_Ctr *mapping_ctr;
        uint32_t nc_object_count;
@@ -410,23 +543,42 @@ static NTSTATUS vampire_schema_chunk(void *private_data,
                        c->partition->nc.dn, object_count, nc_object_count,
                        linked_attributes_count, nc_linked_attributes_count));
        } else {
-               DEBUG(0,("Schema-DN[%s] objects[%u] linked_values[%u\n",
+               DEBUG(0,("Schema-DN[%s] objects[%u] linked_values[%u]\n",
                c->partition->nc.dn, object_count, linked_attributes_count));
        }
 
-       if (!s->schema) {
-               s->self_made_schema = dsdb_new_schema(s, lp_iconv_convenience(s->lp_ctx));
+       if (!s->self_made_schema) {
+               WERROR werr;
+               struct drsuapi_DsReplicaOIDMapping_Ctr mapping_ctr_without_schema_info;
+               /* Put the DRS prefixmap aside for the schema we are
+                * about to load in the provision, and into the one we
+                * are making with the help of DRS */
+
+               mapping_ctr_without_schema_info = *mapping_ctr;
+
+               /* This strips off the 0xFF schema info from the end,
+                * because we don't want it in the blob */
+               if (mapping_ctr_without_schema_info.num_mappings > 0) {
+                       mapping_ctr_without_schema_info.num_mappings--;
+               }
+               werr = dsdb_get_drsuapi_prefixmap_as_blob(&mapping_ctr_without_schema_info, s, &s->prefixmap_blob);
+               if (!W_ERROR_IS_OK(werr)) {
+                       return werror_to_ntstatus(werr);
+               }
 
+               /* Set up two manually-constructed schema - the local
+                * schema from the provision will be used to build
+                * one, which will then in turn be used to build the
+                * other. */
+               s->self_made_schema = dsdb_new_schema(s);
                NT_STATUS_HAVE_NO_MEMORY(s->self_made_schema);
 
-               status = dsdb_load_oid_mappings_drsuapi(s->self_made_schema, mapping_ctr);
+               status = dsdb_load_prefixmap_from_drsuapi(s->self_made_schema, mapping_ctr);
                if (!W_ERROR_IS_OK(status)) {
                        return werror_to_ntstatus(status);
                }
-
-               s->schema = s->self_made_schema;
        } else {
-               status = dsdb_verify_oid_mappings_drsuapi(s->schema, mapping_ctr);
+               status = dsdb_schema_pfm_contains_drsuapi_pfm(s->self_made_schema->prefixmap, mapping_ctr);
                if (!W_ERROR_IS_OK(status)) {
                        return werror_to_ntstatus(status);
                }
@@ -444,17 +596,18 @@ static NTSTATUS vampire_schema_chunk(void *private_data,
        s->schema_part.last_object = cur;
 
        if (!c->partition->more_data) {
-               return vampire_apply_schema(s, c);
+               return libnet_vampire_cb_apply_schema(s, c);
        }
 
        return NT_STATUS_OK;
 }
 
-static NTSTATUS vampire_store_chunk(void *private_data,
-                                          const struct libnet_BecomeDC_StoreChunk *c)
+NTSTATUS libnet_vampire_cb_store_chunk(void *private_data,
+                            const struct libnet_BecomeDC_StoreChunk *c)
 {
-       struct vampire_state *s = talloc_get_type(private_data, struct vampire_state);
+       struct libnet_vampire_cb_state *s = talloc_get_type(private_data, struct libnet_vampire_cb_state);
        WERROR status;
+       struct dsdb_schema *schema;
        const struct drsuapi_DsReplicaOIDMapping_Ctr *mapping_ctr;
        uint32_t nc_object_count;
        uint32_t object_count;
@@ -505,9 +658,9 @@ static NTSTATUS vampire_store_chunk(void *private_data,
                return NT_STATUS_INVALID_PARAMETER;
        }
 
-       s_dsa->replica_flags            = DRSUAPI_DS_REPLICA_NEIGHBOUR_WRITEABLE
-                                       | DRSUAPI_DS_REPLICA_NEIGHBOUR_SYNC_ON_STARTUP
-                                       | DRSUAPI_DS_REPLICA_NEIGHBOUR_DO_SCHEDULED_SYNCS;
+       s_dsa->replica_flags            = DRSUAPI_DRS_WRIT_REP
+                                       | DRSUAPI_DRS_INIT_SYNC
+                                       | DRSUAPI_DRS_PER_SYNC;
        memset(s_dsa->schedule, 0x11, sizeof(s_dsa->schedule));
 
        tmp_dns_name    = GUID_string(s_dsa->other_info, &s_dsa->source_dsa_obj_guid);
@@ -529,28 +682,35 @@ static NTSTATUS vampire_store_chunk(void *private_data,
                        c->partition->nc.dn, s->total_objects, nc_object_count,
                        linked_attributes_count, nc_linked_attributes_count));
        } else {
-               DEBUG(0,("Partition[%s] objects[%u] linked_values[%u\n",
+               DEBUG(0,("Partition[%s] objects[%u] linked_values[%u]\n",
                c->partition->nc.dn, s->total_objects, linked_attributes_count));
        }
 
 
-       status = dsdb_extended_replicated_objects_commit(s->ldb,
-                                                        c->partition->nc.dn,
-                                                        mapping_ctr,
-                                                        object_count,
-                                                        first_object,
-                                                        linked_attributes_count,
-                                                        linked_attributes,
-                                                        s_dsa,
-                                                        uptodateness_vector,
-                                                        c->gensec_skey,
-                                                        s, &objs, &seq_num);
+       schema = dsdb_get_schema(s->ldb, NULL);
+       if (!schema) {
+               DEBUG(0,(__location__ ": Schema is not loaded yet!\n"));
+               return NT_STATUS_INTERNAL_ERROR;
+       }
+
+       status = dsdb_replicated_objects_convert(s->ldb,
+                                                schema,
+                                                c->partition->nc.dn,
+                                                mapping_ctr,
+                                                object_count,
+                                                first_object,
+                                                linked_attributes_count,
+                                                linked_attributes,
+                                                s_dsa,
+                                                uptodateness_vector,
+                                                c->gensec_skey,
+                                                s, &objs);
        if (!W_ERROR_IS_OK(status)) {
-               DEBUG(0,("Failed to commit objects: %s\n", win_errstr(status)));
+               DEBUG(0,("Failed to convert objects: %s\n", win_errstr(status)));
                return werror_to_ntstatus(status);
        }
 
-       if (lp_parm_bool(s->lp_ctx, NULL, "become dc", "dump objects", false)) {
+       if (lpcfg_parm_bool(s->lp_ctx, NULL, "become dc", "dump objects", false)) {
                for (i=0; i < objs->num_objects; i++) {
                        struct ldb_ldif ldif;
                        fprintf(stdout, "#\n");
@@ -560,6 +720,12 @@ static NTSTATUS vampire_store_chunk(void *private_data,
                        NDR_PRINT_DEBUG(replPropertyMetaDataBlob, objs->objects[i].meta_data);
                }
        }
+       status = dsdb_replicated_objects_commit(s->ldb, NULL, objs, &seq_num);
+       if (!W_ERROR_IS_OK(status)) {
+               DEBUG(0,("Failed to commit objects: %s\n", win_errstr(status)));
+               return werror_to_ntstatus(status);
+       }
+
        talloc_free(s_dsa);
        talloc_free(objs);
 
@@ -580,7 +746,7 @@ static NTSTATUS vampire_store_chunk(void *private_data,
                        return NT_STATUS_FOOBAR;
                }
 
-               if (lp_parm_bool(s->lp_ctx, NULL, "become dc", "dump objects", false)) {
+               if (lpcfg_parm_bool(s->lp_ctx, NULL, "become dc", "dump objects", false)) {
                        DEBUG(0,("# %s\n", sa->lDAPDisplayName));
                        NDR_PRINT_DEBUG(drsuapi_DsReplicaLinkedAttribute, &linked_attributes[i]);
                        dump_data(0,
@@ -592,17 +758,60 @@ static NTSTATUS vampire_store_chunk(void *private_data,
        return NT_STATUS_OK;
 }
 
+static NTSTATUS update_dnshostname_for_server(TALLOC_CTX *mem_ctx,
+                                             struct ldb_context *ldb,
+                                             const char *server_dn_str,
+                                             const char *netbios_name,
+                                             const char *realm)
+{
+       int ret;
+       struct ldb_message *msg;
+       struct ldb_message_element *el;
+       struct ldb_dn *server_dn;
+       const char *dNSHostName = strlower_talloc(mem_ctx,
+                                                 talloc_asprintf(mem_ctx,
+                                                                 "%s.%s",
+                                                                 netbios_name,
+                                                                 realm));
+       msg = ldb_msg_new(mem_ctx);
+       if (msg == NULL) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       server_dn = ldb_dn_new(mem_ctx, ldb, server_dn_str);
+       if (!server_dn) {
+               return NT_STATUS_INTERNAL_ERROR;
+       }
+
+       msg->dn = server_dn;
+       ret = ldb_msg_add_empty(msg, "dNSHostName", LDB_FLAG_MOD_ADD, &el);
+       if (ret != LDB_SUCCESS) {
+               return NT_STATUS_INTERNAL_ERROR;
+       }
+
+       ret = ldb_msg_add_steal_string(msg,
+                                      "dNSHostName",
+                                      talloc_asprintf(el->values, "%s", dNSHostName));
+       if (ret != LDB_SUCCESS) {
+               return NT_STATUS_INTERNAL_ERROR;
+       }
+
+       ret = dsdb_modify(ldb, msg, DSDB_MODIFY_PERMISSIVE);
+       if (ret != LDB_SUCCESS) {
+               DEBUG(0,(__location__ ": Failed to add dnsHostName to the Server object: %s\n",
+                        ldb_errstring(ldb)));
+               return NT_STATUS_INTERNAL_ERROR;
+       }
+
+       return NT_STATUS_OK;
+}
+
+
 NTSTATUS libnet_Vampire(struct libnet_context *ctx, TALLOC_CTX *mem_ctx, 
                        struct libnet_Vampire *r)
 {
        struct libnet_JoinDomain *join;
-       struct provision_store_self_join_settings *set_secrets;
-       struct libnet_BecomeDC b;
-       struct vampire_state *s;
-       struct ldb_message *msg;
-       const char *error_string;
-       int ldb_ret;
-       uint32_t i;
+       struct libnet_Replicate rep;
        NTSTATUS status;
 
        const char *account_name;
@@ -610,15 +819,7 @@ NTSTATUS libnet_Vampire(struct libnet_context *ctx, TALLOC_CTX *mem_ctx,
        
        r->out.error_string = NULL;
 
-       s = talloc_zero(mem_ctx, struct vampire_state);
-       if (!s) {
-               return NT_STATUS_NO_MEMORY;
-       }
-
-       s->lp_ctx = ctx->lp_ctx;
-       s->event_ctx = ctx->event_ctx;
-
-       join = talloc_zero(s, struct libnet_JoinDomain);
+       join = talloc_zero(mem_ctx, struct libnet_JoinDomain);
        if (!join) {
                return NT_STATUS_NO_MEMORY;
        }
@@ -626,21 +827,26 @@ NTSTATUS libnet_Vampire(struct libnet_context *ctx, TALLOC_CTX *mem_ctx,
        if (r->in.netbios_name != NULL) {
                netbios_name = r->in.netbios_name;
        } else {
-               netbios_name = talloc_reference(join, lp_netbios_name(ctx->lp_ctx));
+               netbios_name = talloc_reference(join, lpcfg_netbios_name(ctx->lp_ctx));
                if (!netbios_name) {
+                       talloc_free(join);
                        r->out.error_string = NULL;
-                       talloc_free(s);
                        return NT_STATUS_NO_MEMORY;
                }
        }
 
        account_name = talloc_asprintf(join, "%s$", netbios_name);
        if (!account_name) {
+               talloc_free(join);
                r->out.error_string = NULL;
-               talloc_free(s);
                return NT_STATUS_NO_MEMORY;
        }
        
+       /* Re-use the domain we are joining as the domain for the user
+        * to be authenticated with, unless they specified
+        * otherwise */
+       cli_credentials_set_domain(ctx->cred, r->in.domain_name, CRED_GUESS_ENV);
+
        join->in.domain_name    = r->in.domain_name;
        join->in.account_name   = account_name;
        join->in.netbios_name   = netbios_name;
@@ -650,27 +856,97 @@ NTSTATUS libnet_Vampire(struct libnet_context *ctx, TALLOC_CTX *mem_ctx,
        status = libnet_JoinDomain(ctx, join, join);
        if (!NT_STATUS_IS_OK(status)) {
                r->out.error_string = talloc_steal(mem_ctx, join->out.error_string);
-               talloc_free(s);
+               talloc_free(join);
                return status;
        }
-       
-       s->join = join;
 
-       s->targetdir = r->in.targetdir;
+       rep.in.domain_name   = join->out.domain_name;
+       rep.in.netbios_name  = netbios_name;
+       rep.in.targetdir     = r->in.targetdir;
+       rep.in.domain_sid    = join->out.domain_sid;
+       rep.in.realm         = join->out.realm;
+       rep.in.server        = join->out.samr_binding->host;
+       rep.in.join_password = join->out.join_password;
+       rep.in.kvno          = join->out.kvno;
+
+       status = libnet_Replicate(ctx, mem_ctx, &rep);
+
+       r->out.domain_sid   = join->out.domain_sid;
+       r->out.domain_name  = join->out.domain_name;
+       r->out.error_string = rep.out.error_string;
+
+       return status;
+}
+
+
+
+NTSTATUS libnet_Replicate(struct libnet_context *ctx, TALLOC_CTX *mem_ctx,
+                         struct libnet_Replicate *r)
+{
+       struct provision_store_self_join_settings *set_secrets;
+       struct libnet_BecomeDC b;
+       struct libnet_vampire_cb_state *s;
+       struct ldb_message *msg;
+       const char *error_string;
+       int ldb_ret;
+       uint32_t i;
+       NTSTATUS status;
+       TALLOC_CTX *tmp_ctx = talloc_new(mem_ctx);
+       const char *account_name;
+       const char *netbios_name;
+
+       r->out.error_string = NULL;
+
+       netbios_name = r->in.netbios_name;
+       account_name = talloc_asprintf(tmp_ctx, "%s$", netbios_name);
+       if (!account_name) {
+               talloc_free(tmp_ctx);
+               r->out.error_string = NULL;
+               return NT_STATUS_NO_MEMORY;
+       }
+       
+       /* Re-use the domain we are joining as the domain for the user
+        * to be authenticated with, unless they specified
+        * otherwise */
+       cli_credentials_set_domain(ctx->cred, r->in.domain_name, CRED_GUESS_ENV);
+
+       s = libnet_vampire_cb_state_init(mem_ctx, ctx->lp_ctx, ctx->event_ctx,
+                                        netbios_name, r->in.domain_name, r->in.realm,
+                                        r->in.targetdir);
+       if (!s) {
+               return NT_STATUS_NO_MEMORY;
+       }
+       talloc_steal(s, tmp_ctx);
 
        ZERO_STRUCT(b);
-       b.in.domain_dns_name            = join->out.realm;
-       b.in.domain_netbios_name        = join->out.domain_name;
-       b.in.domain_sid                 = join->out.domain_sid;
-       b.in.source_dsa_address         = join->out.samr_binding->host;
+
+       /* Be more robust:
+        * We now know the domain and realm for sure - if they didn't
+        * put one on the command line, use this for the rest of the
+        * join */
+       cli_credentials_set_realm(ctx->cred, r->in.realm, CRED_GUESS_ENV);
+       cli_credentials_set_domain(ctx->cred, r->in.domain_name, CRED_GUESS_ENV);
+
+       /* Now set these values into the smb.conf - we probably had
+        * empty or useless defaults here from whatever smb.conf we
+        * started with */
+       lpcfg_set_cmdline(s->lp_ctx, "realm", r->in.realm);
+       lpcfg_set_cmdline(s->lp_ctx, "workgroup", r->in.domain_name);
+
+       b.in.domain_dns_name            = r->in.realm;
+       b.in.domain_netbios_name        = r->in.domain_name;
+       b.in.domain_sid                 = r->in.domain_sid;
+       b.in.source_dsa_address         = r->in.server;
        b.in.dest_dsa_netbios_name      = netbios_name;
 
        b.in.callbacks.private_data     = s;
-       b.in.callbacks.check_options    = vampire_check_options;
-       b.in.callbacks.prepare_db       = vampire_prepare_db;
-       b.in.callbacks.schema_chunk     = vampire_schema_chunk;
-       b.in.callbacks.config_chunk     = vampire_store_chunk;
-       b.in.callbacks.domain_chunk     = vampire_store_chunk;
+       b.in.callbacks.check_options    = libnet_vampire_cb_check_options;
+       b.in.callbacks.prepare_db       = libnet_vampire_cb_prepare_db;
+       b.in.callbacks.schema_chunk     = libnet_vampire_cb_schema_chunk;
+       b.in.callbacks.config_chunk     = libnet_vampire_cb_store_chunk;
+       b.in.callbacks.domain_chunk     = libnet_vampire_cb_store_chunk;
+
+       b.in.rodc_join = lpcfg_parm_bool(s->lp_ctx, NULL, "repl", "RODC", false);
 
        status = libnet_BecomeDC(ctx, s, &b);
        if (!NT_STATUS_IS_OK(status)) {
@@ -706,17 +982,25 @@ NTSTATUS libnet_Vampire(struct libnet_context *ctx, TALLOC_CTX *mem_ctx,
        printf("mark ROOTDSE with isSynchronized=TRUE\n");
        ldb_ret = ldb_modify(s->ldb, msg);
        if (ldb_ret != LDB_SUCCESS) {
-               printf("ldb_modify() failed: %d\n", ldb_ret);
+               printf("ldb_modify() failed: %d : %s\n", ldb_ret, ldb_errstring(s->ldb));
                talloc_free(s);
                return NT_STATUS_INTERNAL_DB_ERROR;
        }
-
+       /* during dcpromo the 2nd computer adds dNSHostName attribute to his Server object
+        * the attribute appears on the original DC after replication
+        */
+       status = update_dnshostname_for_server(s, s->ldb, s->server_dn_str, s->netbios_name, s->realm);
+       if (!NT_STATUS_IS_OK(status)) {
+               printf("Failed to update dNSHostName on Server object - %s\n", nt_errstr(status));
+               talloc_free(s);
+               return status;
+       }
        /* prepare the transaction - this prepares to commit all the changes in
           the ldb from the whole vampire.  Note that this 
           triggers the writing of the linked attribute backlinks.
        */
        if (ldb_transaction_prepare_commit(s->ldb) != LDB_SUCCESS) {
-               printf("Failed to prepare_commit vampire transaction\n");
+               printf("Failed to prepare_commit vampire transaction: %s\n", ldb_errstring(s->ldb));
                return NT_STATUS_INTERNAL_DB_ERROR;
        }
 
@@ -728,25 +1012,21 @@ NTSTATUS libnet_Vampire(struct libnet_context *ctx, TALLOC_CTX *mem_ctx,
        }
        
        ZERO_STRUCTP(set_secrets);
-       set_secrets->domain_name = join->out.domain_name;
-       set_secrets->realm = join->out.realm;
-       set_secrets->account_name = account_name;
+       set_secrets->domain_name = r->in.domain_name;
+       set_secrets->realm = r->in.realm;
        set_secrets->netbios_name = netbios_name;
        set_secrets->secure_channel_type = SEC_CHAN_BDC;
-       set_secrets->machine_password = join->out.join_password;
-       set_secrets->key_version_number = join->out.kvno;
-       set_secrets->domain_sid = join->out.domain_sid;
+       set_secrets->machine_password = r->in.join_password;
+       set_secrets->key_version_number = r->in.kvno;
+       set_secrets->domain_sid = r->in.domain_sid;
        
-       status = provision_store_self_join(ctx, ctx->lp_ctx, ctx->event_ctx, set_secrets, &error_string);
+       status = provision_store_self_join(ctx, s->lp_ctx, ctx->event_ctx, set_secrets, &error_string);
        if (!NT_STATUS_IS_OK(status)) {
                r->out.error_string = talloc_steal(mem_ctx, error_string);
                talloc_free(s);
                return status;
        }
 
-       r->out.domain_name = talloc_steal(r, join->out.domain_name);
-       r->out.domain_sid = dom_sid_dup(r, join->out.domain_sid);
-       
        /* commit the transaction now we know the secrets were written
         * out properly
        */
@@ -758,5 +1038,4 @@ NTSTATUS libnet_Vampire(struct libnet_context *ctx, TALLOC_CTX *mem_ctx,
        talloc_free(s);
 
        return NT_STATUS_OK;
-
 }