LDB ASYNC: core modules
[kai/samba.git] / source4 / lib / ldb / modules / paged_results.c
index bdfaea6d51533bc82b312c7bf59fa1c1eb5bc1dd..d3bb83bbcd9ec6bbe8a568784b8b226b0252b8cc 100644 (file)
@@ -1,7 +1,7 @@
 /* 
    ldb database library
 
-   Copyright (C) Simo Sorce  2005-2006
+   Copyright (C) Simo Sorce  2005-2008
 
      ** NOTE! The following LGPL license applies to the ldb
      ** library. This does NOT imply that all of Samba is released
@@ -10,7 +10,7 @@
    This library is free software; you can redistribute it and/or
    modify it under the terms of the GNU Lesser General Public
    License as published by the Free Software Foundation; either
-   version 2 of the License, or (at your option) any later version.
+   version 3 of the License, or (at your option) any later version.
 
    This library is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ -18,8 +18,7 @@
    Lesser General Public License for more details.
 
    You should have received a copy of the GNU Lesser General Public
-   License along with this library; if not, write to the Free Software
-   Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+   License along with this library; if not, see <http://www.gnu.org/licenses/>.
 */
 
 /*
  *  Author: Simo Sorce
  */
 
-#include "includes.h"
-#include "ldb/include/includes.h"
+#include "ldb_includes.h"
 
 struct message_store {
-       /* keep the whole ldb_async_result as an optimization
+       /* keep the whole ldb_reply as an optimization
         * instead of freeing and talloc-ing the container
         * on each result */
-       struct ldb_async_result *r;
+       struct ldb_reply *r;
        struct message_store *next;
 };
 
+struct private_data;
+
 struct results_store {
+
+       struct private_data *priv;
+
        char *cookie;
        time_t timestamp;
-       int num_sent; /* To be removed */
-       struct ldb_result *result; /* To be removed */
-       struct results_store *prev;
+
        struct results_store *next;
-       
+
        struct message_store *first;
        struct message_store *last;
        int num_entries;
@@ -60,8 +61,6 @@ struct results_store {
        struct message_store *last_ref;
 
        struct ldb_control **controls;
-
-       struct ldb_request *req;
 };
 
 struct private_data {
@@ -71,165 +70,222 @@ struct private_data {
        
 };
 
-int store_destructor(struct results_store *store)
+int store_destructor(struct results_store *del)
 {
-       if (store->prev) {
-               store->prev->next = store->next;
+       struct private_data *priv = del->priv;
+       struct results_store *loop;
+
+       if (priv->store == del) {
+               priv->store = del->next;
+               return 0;
        }
-       if (store->next) {
-               store->next->prev = store->prev;
+
+       for (loop = priv->store; loop; loop = loop->next) {
+               if (loop->next == del) {
+                       loop->next = del->next;
+                       return 0;
+               }
        }
-       
-       return 0;
+
+       /* is not in list ? */
+       return -1;
 }
 
 static struct results_store *new_store(struct private_data *priv)
 {
-       struct results_store *new;
+       struct results_store *newr;
        int new_id = priv->next_free_id++;
 
        /* TODO: we should have a limit on the number of
         * outstanding paged searches
         */
 
-       new = talloc(priv, struct results_store);
-       if (!new) return NULL;
+       newr = talloc(priv, struct results_store);
+       if (!newr) return NULL;
+
+       newr->priv = priv;
 
-       new->cookie = talloc_asprintf(new, "%d", new_id);
-       if (!new->cookie) {
-               talloc_free(new);
+       newr->cookie = talloc_asprintf(newr, "%d", new_id);
+       if (!newr->cookie) {
+               talloc_free(newr);
                return NULL;
        }
 
-       new->timestamp = time(NULL);
+       newr->timestamp = time(NULL);
 
-       new->num_sent = 0; /* To be removed */
-       new->result = NULL; /* To be removed */
+       newr->first = NULL;
+       newr->num_entries = 0;
+       newr->first_ref = NULL;
+       newr->controls = NULL;
 
-       new->first = NULL;
-       new->num_entries = 0;
-       new->first_ref = NULL;
-       new->controls = NULL;
+       newr->next = priv->store;
+       priv->store = newr;
 
-       /* put this entry as first */
-       new->prev = NULL;
-       new->next = priv->store;
-       if (priv->store != NULL) priv->store->prev = new;
-       priv->store = new;
+       talloc_set_destructor(newr, store_destructor);
 
-       talloc_set_destructor(new, store_destructor);
-
-       return new;
+       return newr;
 }
 
-struct paged_async_context {
+struct paged_context {
        struct ldb_module *module;
-       void *up_context;
-       int (*up_callback)(struct ldb_context *, void *, struct ldb_async_result *);
-
-       int size;
+       struct ldb_request *req;
 
        struct results_store *store;
+       int size;
+       struct ldb_control **controls;
 };
 
-static struct ldb_async_handle *init_handle(void *mem_ctx, struct ldb_module *module,
-                                           void *context,
-                                           int (*callback)(struct ldb_context *, void *, struct ldb_async_result *))
+static int paged_results(struct paged_context *ac)
 {
-       struct paged_async_context *ac;
-       struct ldb_async_handle *h;
+       struct ldb_paged_control *paged;
+       struct message_store *msg;
+       int i, num_ctrls, ret;
 
-       h = talloc_zero(mem_ctx, struct ldb_async_handle);
-       if (h == NULL) {
-               ldb_set_errstring(module->ldb, talloc_asprintf(module, "Out of Memory"));
-               return NULL;
+       if (ac->store == NULL) {
+               return LDB_ERR_OPERATIONS_ERROR;
        }
 
-       h->module = module;
+       while (ac->store->num_entries > 0 && ac->size > 0) {
+               msg = ac->store->first;
+               ret = ldb_module_send_entry(ac->req, msg->r->message);
+               if (ret != LDB_SUCCESS) {
+                       return ret;
+               }
 
-       ac = talloc_zero(h, struct paged_async_context);
-       if (ac == NULL) {
-               ldb_set_errstring(module->ldb, talloc_asprintf(module, "Out of Memory"));
-               talloc_free(h);
-               return NULL;
+               ac->store->first = msg->next;
+               talloc_free(msg);
+               ac->store->num_entries--;
+               ac->size--;
        }
 
-       h->private_data = (void *)ac;
+       while (ac->store->first_ref != NULL) {
+               msg = ac->store->first_ref;
+               ret = ldb_module_send_referral(ac->req, msg->r->referral);
+               if (ret != LDB_SUCCESS) {
+                       return ret;
+               }
 
-       h->state = LDB_ASYNC_INIT;
-       h->status = LDB_SUCCESS;
+               ac->store->first_ref = msg->next;
+               talloc_free(msg);
+       }
 
-       ac->module = module;
-       ac->up_context = context;
-       ac->up_callback = callback;
+       /* return result done */
+       num_ctrls = 1;
+       i = 0;
+
+       if (ac->store->controls != NULL) {
+               while (ac->store->controls[i]) i++; /* counting */
+
+               num_ctrls += i;
+       }
+
+       ac->controls = talloc_array(ac, struct ldb_control *, num_ctrls +1);
+       if (ac->controls == NULL) {
+               return LDB_ERR_OPERATIONS_ERROR;
+       }
+       ac->controls[num_ctrls] = NULL;
+
+       for (i = 0; i < (num_ctrls -1); i++) {
+               ac->controls[i] = talloc_reference(ac->controls, ac->store->controls[i]);
+       }
+
+       ac->controls[i] = talloc(ac->controls, struct ldb_control);
+       if (ac->controls[i] == NULL) {
+               return LDB_ERR_OPERATIONS_ERROR;
+       }
+
+       ac->controls[i]->oid = talloc_strdup(ac->controls[i],
+                                               LDB_CONTROL_PAGED_RESULTS_OID);
+       if (ac->controls[i]->oid == NULL) {
+               return LDB_ERR_OPERATIONS_ERROR;
+       }
+
+       ac->controls[i]->critical = 0;
+
+       paged = talloc(ac->controls[i], struct ldb_paged_control);
+       if (paged == NULL) {
+               return LDB_ERR_OPERATIONS_ERROR;
+       }
+
+       ac->controls[i]->data = paged;
+
+       if (ac->size > 0) {
+               paged->size = 0;
+               paged->cookie = NULL;
+               paged->cookie_len = 0;
+       } else {
+               paged->size = ac->store->num_entries;
+               paged->cookie = talloc_strdup(paged, ac->store->cookie);
+               paged->cookie_len = strlen(paged->cookie) + 1;
+       }
 
-       return h;
+       return LDB_SUCCESS;
 }
 
-static int paged_search_async_callback(struct ldb_context *ldb, void *context, struct ldb_async_result *ares)
+static int paged_search_callback(struct ldb_request *req, struct ldb_reply *ares)
 {
-       struct paged_async_context *ac = NULL;
+       struct paged_context *ac ;
+       struct message_store *msg_store;
+       int ret;
 
-       if (!context || !ares) {
-               ldb_set_errstring(ldb, talloc_asprintf(ldb, "NULL Context or Result in callback"));
-               goto error;
+       ac = talloc_get_type(req->context, struct paged_context);
+
+       if (!ares) {
+               return ldb_module_done(ac->req, NULL, NULL,
+                                       LDB_ERR_OPERATIONS_ERROR);
+       }
+       if (ares->error != LDB_SUCCESS) {
+               return ldb_module_done(ac->req, ares->controls,
+                                       ares->response, ares->error);
        }
 
-       ac = talloc_get_type(context, struct paged_async_context);
+       switch (ares->type) {
+       case LDB_REPLY_ENTRY:
+               msg_store = talloc(ac->store, struct message_store);
+               if (msg_store == NULL) {
+                       return ldb_module_done(ac->req, NULL, NULL,
+                                               LDB_ERR_OPERATIONS_ERROR);
+               }
+               msg_store->next = NULL;
+               msg_store->r = talloc_steal(msg_store, ares);
 
-       if (ares->type == LDB_REPLY_ENTRY) {
                if (ac->store->first == NULL) {
-                       ac->store->first = ac->store->last = talloc(ac->store, struct message_store);
+                       ac->store->first = msg_store;
                } else {
-                       ac->store->last->next = talloc(ac->store, struct message_store);
-                       ac->store->last = ac->store->last->next;
-               }
-               if (ac->store->last == NULL) {
-                       goto error;
+                       ac->store->last->next = msg_store;
                }
+               ac->store->last = msg_store;
 
                ac->store->num_entries++;
 
-               ac->store->last->r = talloc_steal(ac->store->last, ares);
-               if (ac->store->last->r == NULL) {
-                       goto error;
+               break;
+
+       case LDB_REPLY_REFERRAL:
+               msg_store = talloc(ac->store, struct message_store);
+               if (msg_store == NULL) {
+                       return ldb_module_done(ac->req, NULL, NULL,
+                                               LDB_ERR_OPERATIONS_ERROR);
                }
-               ac->store->last->next = NULL;
-       }
+               msg_store->next = NULL;
+               msg_store->r = talloc_steal(msg_store, ares);
 
-       if (ares->type == LDB_REPLY_REFERRAL) {
                if (ac->store->first_ref == NULL) {
-                       ac->store->first_ref = ac->store->last_ref = talloc(ac->store, struct message_store);
+                       ac->store->first_ref = msg_store;
                } else {
-                       ac->store->last_ref->next = talloc(ac->store, struct message_store);
-                       ac->store->last_ref = ac->store->last_ref->next;
-               }
-               if (ac->store->last_ref == NULL) {
-                       goto error;
+                       ac->store->last_ref->next = msg_store;
                }
+               ac->store->last_ref = msg_store;
 
-               ac->store->last_ref->r = talloc_steal(ac->store->last, ares);
-               if (ac->store->last_ref->r == NULL) {
-                       goto error;
-               }
-               ac->store->last_ref->next = NULL;
-       }
+               break;
 
-       if (ares->type == LDB_REPLY_DONE) {
-               if (ares->controls) {
-                       ac->store->controls = talloc_steal(ac->store, ares->controls);
-                       if (! ac->store->controls) {
-                               goto error;
-                       }
-               }
-               talloc_free(ares);
+       case LDB_REPLY_DONE:
+               ac->store->controls = talloc_move(ac->store, &ares->controls);
+               ret = paged_results(ac);
+               return ldb_module_done(ac->req, ac->controls,
+                                       ares->response, ret);
        }
 
        return LDB_SUCCESS;
-
-error:
-       talloc_free(ares);
-       return LDB_ERR_OPERATIONS_ERROR;
 }
 
 static int paged_search(struct ldb_module *module, struct ldb_request *req)
@@ -238,76 +294,68 @@ static int paged_search(struct ldb_module *module, struct ldb_request *req)
        struct private_data *private_data;
        struct ldb_paged_control *paged_ctrl;
        struct ldb_control **saved_controls;
-       struct paged_async_context *ac;
-       struct ldb_async_handle *h;
+       struct ldb_request *search_req;
+       struct paged_context *ac;
        int ret;
 
        /* check if there's a paged request control */
-       control = get_control_from_list(req->controls, LDB_CONTROL_PAGED_RESULTS_OID);
+       control = ldb_request_get_control(req, LDB_CONTROL_PAGED_RESULTS_OID);
        if (control == NULL) {
                /* not found go on */
                return ldb_next_request(module, req);
        }
 
-       private_data = talloc_get_type(module->private_data, struct private_data);
-
-       req->async.handle = NULL;
-
-       if (!req->async.callback || !req->async.context) {
-               ldb_set_errstring(module->ldb, talloc_asprintf(module,
-                                 "Async interface called with NULL callback function or NULL context"));
-               return LDB_ERR_OPERATIONS_ERROR;
-       }
-       
        paged_ctrl = talloc_get_type(control->data, struct ldb_paged_control);
        if (!paged_ctrl) {
                return LDB_ERR_PROTOCOL_ERROR;
        }
 
-       h = init_handle(req, module, req->async.context, req->async.callback);
-       if (!h) {
+       private_data = talloc_get_type(module->private_data, struct private_data);
+
+       ac = talloc_zero(req, struct paged_context);
+       if (ac == NULL) {
+               ldb_set_errstring(module->ldb, "Out of Memory");
                return LDB_ERR_OPERATIONS_ERROR;
        }
-       ac = talloc_get_type(h->private_data, struct paged_async_context);
 
+       ac->module = module;
+       ac->req = req;
        ac->size = paged_ctrl->size;
 
        /* check if it is a continuation search the store */
        if (paged_ctrl->cookie_len == 0) {
-               
-               ac->store = new_store(private_data);
-               if (ac->store == NULL) {
-                       talloc_free(h);
-                       return LDB_ERR_UNWILLING_TO_PERFORM;
+               if (paged_ctrl->size == 0) {
+                       return LDB_ERR_OPERATIONS_ERROR;
                }
 
-               ac->store->req = talloc(ac->store, struct ldb_request);
-               if (!ac->store->req)
+               ac->store = new_store(private_data);
+               if (ac->store == NULL) {
                        return LDB_ERR_OPERATIONS_ERROR;
+               }
 
-               ac->store->req->operation = req->operation;
-               ac->store->req->op.search.base = req->op.search.base;
-               ac->store->req->op.search.scope = req->op.search.scope;
-               ac->store->req->op.search.tree = req->op.search.tree;
-               ac->store->req->op.search.attrs = req->op.search.attrs;
-               ac->store->req->controls = req->controls;
+               ret = ldb_build_search_req_ex(&search_req, module->ldb, ac,
+                                               req->op.search.base,
+                                               req->op.search.scope,
+                                               req->op.search.tree,
+                                               req->op.search.attrs,
+                                               req->controls,
+                                               ac,
+                                               paged_search_callback,
+                                               req);
 
                /* save it locally and remove it from the list */
                /* we do not need to replace them later as we
                 * are keeping the original req intact */
-               if (!save_controls(control, ac->store->req, &saved_controls)) {
+               if (!save_controls(control, search_req, &saved_controls)) {
                        return LDB_ERR_OPERATIONS_ERROR;
                }
 
-               ac->store->req->async.context = ac;
-               ac->store->req->async.callback = paged_search_async_callback;
-               ldb_set_timeout_from_prev_req(module->ldb, req, ac->store->req);
-
-               ret = ldb_next_request(module, ac->store->req);
+               return ldb_next_request(module, search_req);
 
        } else {
                struct results_store *current = NULL;
 
+               /* TODO: age out old outstanding requests */
                for (current = private_data->store; current; current = current->next) {
                        if (strcmp(current->cookie, paged_ctrl->cookie) == 0) {
                                current->timestamp = time(NULL);
@@ -315,257 +363,52 @@ static int paged_search(struct ldb_module *module, struct ldb_request *req)
                        }
                }
                if (current == NULL) {
-                       talloc_free(h);
                        return LDB_ERR_UNWILLING_TO_PERFORM;
                }
 
                ac->store = current;
-               ret = LDB_SUCCESS;
-       }
-
-       req->async.handle = h;
-
-       /* check if it is an abandon */
-       if (ac->size == 0) {
-               talloc_free(ac->store);
-               h->status = LDB_SUCCESS;
-               h->state = LDB_ASYNC_DONE;
-               return LDB_SUCCESS;
-       }
-
-       /* TODO: age out old outstanding requests */
-
-       return ret;
-
-}
-
-static int paged_results(struct ldb_async_handle *handle)
-{
-       struct paged_async_context *ac;
-       struct ldb_paged_control *paged;
-       struct ldb_async_result *ares;
-       struct message_store *msg;
-       int i, num_ctrls, ret;
-
-       ac = talloc_get_type(handle->private_data, struct paged_async_context);
 
-       if (ac->store == NULL)
-               return LDB_ERR_OPERATIONS_ERROR;
-
-       while (ac->store->num_entries > 0 && ac->size > 0) {
-               msg = ac->store->first;
-               ret = ac->up_callback(ac->module->ldb, ac->up_context, msg->r);
-               if (ret != LDB_SUCCESS) {
-                       handle->status = ret;
-                       handle->state = LDB_ASYNC_DONE;
-                       return ret;
+               /* check if it is an abandon */
+               if (ac->size == 0) {
+                       return ldb_module_done(req, NULL, NULL,
+                                                               LDB_SUCCESS);
                }
 
-               ac->store->first = msg->next;
-               talloc_free(msg);
-               ac->store->num_entries--;
-               ac->size--;
-       }
-
-       handle->state = LDB_ASYNC_DONE;
-
-       while (ac->store->first_ref != NULL) {
-               msg = ac->store->first_ref;
-               ret = ac->up_callback(ac->module->ldb, ac->up_context, msg->r);
+               ret = paged_results(ac);
                if (ret != LDB_SUCCESS) {
-                       handle->status = ret;
-                       handle->state = LDB_ASYNC_DONE;
-                       return ret;
-               }
-
-               ac->store->first_ref = msg->next;
-               talloc_free(msg);
-       }
-
-       ares = talloc_zero(ac->store, struct ldb_async_result);
-       if (ares == NULL) {
-               handle->status = LDB_ERR_OPERATIONS_ERROR;
-               return handle->status;
-       }
-       num_ctrls = 2;
-       i = 0;
-
-       if (ac->store->controls != NULL) {
-               ares->controls = ac->store->controls;
-               while (ares->controls[i]) i++; /* counting */
-
-               ares->controls = talloc_steal(ares, ac->store->controls);
-               num_ctrls += i;
-       }
-
-       ares->controls = talloc_realloc(ares, ares->controls, struct ldb_control *, num_ctrls);
-       if (ares->controls == NULL) {
-               handle->status = LDB_ERR_OPERATIONS_ERROR;
-               return handle->status;
-       }
-
-       ares->controls[i] = talloc(ares->controls, struct ldb_control);
-       if (ares->controls[i] == NULL) {
-               handle->status = LDB_ERR_OPERATIONS_ERROR;
-               return handle->status;
-       }
-
-       ares->controls[i]->oid = talloc_strdup(ares->controls[i], LDB_CONTROL_PAGED_RESULTS_OID);
-       if (ares->controls[i]->oid == NULL) {
-               handle->status = LDB_ERR_OPERATIONS_ERROR;
-               return handle->status;
-       }
-               
-       ares->controls[i]->critical = 0;
-       ares->controls[i + 1] = NULL;
-
-       paged = talloc(ares->controls[i], struct ldb_paged_control);
-       if (paged == NULL) {
-               handle->status = LDB_ERR_OPERATIONS_ERROR;
-               return handle->status;
-       }
-       
-       ares->controls[i]->data = paged;
-
-       if (ac->size > 0) {
-               paged->size = 0;
-               paged->cookie = NULL;
-               paged->cookie_len = 0;
-       } else {
-               paged->size = ac->store->num_entries;
-               paged->cookie = talloc_strdup(paged, ac->store->cookie);
-               paged->cookie_len = strlen(paged->cookie) + 1;
-       }
-
-       ares->type = LDB_REPLY_DONE;
-
-       ret = ac->up_callback(ac->module->ldb, ac->up_context, ares);
-
-       handle->status = ret;
-
-       return ret;
-}
-
-static int paged_async_wait(struct ldb_async_handle *handle, enum ldb_async_wait_type type)
-{
-       struct paged_async_context *ac;
-       int ret;
-    
-       if (!handle || !handle->private_data) {
-               return LDB_ERR_OPERATIONS_ERROR;
-       }
-
-       if (handle->state == LDB_ASYNC_DONE) {
-               return handle->status;
-       }
-
-       handle->state = LDB_ASYNC_PENDING;
-
-       ac = talloc_get_type(handle->private_data, struct paged_async_context);
-
-       if (ac->store->req->async.handle->state == LDB_ASYNC_DONE) {
-               /* if lower level is finished we do not need to call it anymore */
-               /* return all we have until size == 0 or we empty storage */
-               ret = paged_results(handle);
-
-               /* we are done, if num_entries is zero free the storage
-                * as that mean we delivered the last batch */
-               if (ac->store->num_entries == 0) {
-                       talloc_free(ac->store);
+                       return ldb_module_done(req, NULL, NULL, ret);
                }
-
-               return ret;
+               return ldb_module_done(req, ac->controls, NULL,
+                                                               LDB_SUCCESS);
        }
-
-       if (type == LDB_WAIT_ALL) {
-               while (ac->store->req->async.handle->state != LDB_ASYNC_DONE) {
-                       ret = ldb_async_wait(ac->store->req->async.handle, type);
-                       if (ret != LDB_SUCCESS) {
-                               handle->state = LDB_ASYNC_DONE;
-                               handle->status = ret;
-                               return ret;
-                       }
-               }
-
-               ret = paged_results(handle);
-
-               /* we are done, if num_entries is zero free the storage
-                * as that mean we delivered the last batch */
-               if (ac->store->num_entries == 0) {
-                       talloc_free(ac->store);
-               }
-
-               return ret;
-       }
-
-       ret = ldb_async_wait(ac->store->req->async.handle, type);
-       if (ret != LDB_SUCCESS) {
-               handle->state = LDB_ASYNC_DONE;
-               handle->status = ret;
-               return ret;
-       }
-
-       handle->status = ret;
-
-       if (ac->store->num_entries >= ac->size ||
-           ac->store->req->async.handle->state == LDB_ASYNC_DONE) {
-
-               ret = paged_results(handle);
-
-               /* we are done, if num_entries is zero free the storage
-                * as that mean we delivered the last batch */
-               if (ac->store->num_entries == 0) {
-                       talloc_free(ac->store);
-               }
-       }
-
-       return ret;
 }
 
 static int paged_request_init(struct ldb_module *module)
 {
        struct private_data *data;
-       struct ldb_request *req;
        int ret;
 
        data = talloc(module, struct private_data);
        if (data == NULL) {
                return LDB_ERR_OTHER;
        }
-       
+
        data->next_free_id = 1;
        data->store = NULL;
        module->private_data = data;
 
-       req = talloc(module, struct ldb_request);
-       if (req == NULL) {
-               return LDB_ERR_OPERATIONS_ERROR;
-       }
-
-       req->operation = LDB_REQ_REGISTER;
-       req->op.reg.oid = LDB_CONTROL_PAGED_RESULTS_OID;
-       req->controls = NULL;
-
-       ret = ldb_request(module->ldb, req);
+       ret = ldb_mod_register_control(module, LDB_CONTROL_PAGED_RESULTS_OID);
        if (ret != LDB_SUCCESS) {
-               ldb_debug(module->ldb, LDB_DEBUG_ERROR, "paged_request: Unable to register control with rootdse!\n");
-               talloc_free(req);
-               return LDB_ERR_OTHER;
+               ldb_debug(module->ldb, LDB_DEBUG_WARNING,
+                       "paged_request:"
+                       "Unable to register control with rootdse!\n");
        }
 
-       talloc_free(req);
        return ldb_next_init(module);
 }
 
-static const struct ldb_module_ops paged_ops = {
+const struct ldb_module_ops ldb_paged_results_module_ops = {
        .name           = "paged_results",
        .search         = paged_search,
-       .async_wait     = paged_async_wait,
        .init_context   = paged_request_init
 };
-
-int ldb_paged_results_init(void)
-{
-       return ldb_register_module(&paged_ops);
-}
-