Put the internal gensec_gssapi state into a header.
[kai/samba.git] / source4 / auth / gensec / gensec_gssapi.c
index f241a646cc54e91d9c592700386da8e564b01951..20576256c283cbea0106d1b1fc6a9858aa32361e 100644 (file)
@@ -8,7 +8,7 @@
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 2 of the License, or
+   the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
    
    This program is distributed in the hope that it will be useful,
 
    
    You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software
-   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
 #include "includes.h"
+#include "lib/events/events.h"
 #include "system/kerberos.h"
 #include "auth/kerberos/kerberos.h"
 #include "librpc/gen_ndr/krb5pac.h"
 #include "lib/ldb/include/ldb.h"
 #include "auth/auth_sam.h"
 #include "librpc/rpc/dcerpc.h"
-
-enum gensec_gssapi_sasl_state 
-{
-       STAGE_GSS_NEG,
-       STAGE_SASL_SSF_NEG,
-       STAGE_SASL_SSF_ACCEPT,
-       STAGE_DONE
-};
-
-#define NEG_SEAL 0x4
-#define NEG_SIGN 0x2
-#define NEG_NONE 0x1
-
-struct gensec_gssapi_state {
-       gss_ctx_id_t gssapi_context;
-       struct gss_channel_bindings_struct *input_chan_bindings;
-       gss_name_t server_name;
-       gss_name_t client_name;
-       OM_uint32 want_flags, got_flags;
-       const gss_OID_desc *gss_oid;
-
-       DATA_BLOB session_key;
-       DATA_BLOB pac;
-
-       struct smb_krb5_context *smb_krb5_context;
-       struct gssapi_creds_container *client_cred;
-       struct gssapi_creds_container *server_cred;
-
-       gss_cred_id_t delegated_cred_handle;
-
-       BOOL sasl; /* We have two different mechs in this file: One
-                   * for SASL wrapped GSSAPI and another for normal
-                   * GSSAPI */
-       enum gensec_gssapi_sasl_state sasl_state;
-       uint8_t sasl_protection; /* What was negotiated at the SASL
-                                 * layer, independent of the GSSAPI
-                                 * layer... */
-
-       size_t max_wrap_buf_size;
-};
+#include "auth/credentials/credentials.h"
+#include "auth/credentials/credentials_krb5.h"
+#include "auth/gensec/gensec.h"
+#include "auth/gensec/gensec_proto.h"
+#include "param/param.h"
+#include "auth/session_proto.h"
+#include <gssapi/gssapi.h>
+#include <gssapi/gssapi_krb5.h>
+#include "auth/gensec/gensec_gssapi.h"
 
 static size_t gensec_gssapi_max_input_size(struct gensec_security *gensec_security);
 static size_t gensec_gssapi_max_wrapped_size(struct gensec_security *gensec_security);
 
 static char *gssapi_error_string(TALLOC_CTX *mem_ctx, 
-                                OM_uint32 maj_stat, OM_uint32 min_stat)
+                                OM_uint32 maj_stat, OM_uint32 min_stat, 
+                                const gss_OID mech)
 {
        OM_uint32 disp_min_stat, disp_maj_stat;
        gss_buffer_desc maj_error_message;
        gss_buffer_desc min_error_message;
+       char *maj_error_string, *min_error_string;
        OM_uint32 msg_ctx = 0;
 
        char *ret;
 
        maj_error_message.value = NULL;
        min_error_message.value = NULL;
+       maj_error_message.length = 0;
+       min_error_message.length = 0;
        
        disp_maj_stat = gss_display_status(&disp_min_stat, maj_stat, GSS_C_GSS_CODE,
-                          GSS_C_NULL_OID, &msg_ctx, &maj_error_message);
+                          mech, &msg_ctx, &maj_error_message);
        disp_maj_stat = gss_display_status(&disp_min_stat, min_stat, GSS_C_MECH_CODE,
-                          GSS_C_NULL_OID, &msg_ctx, &min_error_message);
-       ret = talloc_asprintf(mem_ctx, "%s: %s", (char *)maj_error_message.value, (char *)min_error_message.value);
+                          mech, &msg_ctx, &min_error_message);
+       
+       maj_error_string = talloc_strndup(mem_ctx, (char *)maj_error_message.value, maj_error_message.length);
+
+       min_error_string = talloc_strndup(mem_ctx, (char *)min_error_message.value, min_error_message.length);
+
+       ret = talloc_asprintf(mem_ctx, "%s: %s", maj_error_string, min_error_string);
+
+       talloc_free(maj_error_string);
+       talloc_free(min_error_string);
 
        gss_release_buffer(&disp_min_stat, &maj_error_message);
        gss_release_buffer(&disp_min_stat, &min_error_message);
@@ -100,7 +81,7 @@ static char *gssapi_error_string(TALLOC_CTX *mem_ctx,
 }
 
 
-static int gensec_gssapi_destory(struct gensec_gssapi_state *gensec_gssapi_state)
+static int gensec_gssapi_destructor(struct gensec_gssapi_state *gensec_gssapi_state)
 {
        OM_uint32 maj_stat, min_stat;
        
@@ -121,23 +102,61 @@ static int gensec_gssapi_destory(struct gensec_gssapi_state *gensec_gssapi_state
        if (gensec_gssapi_state->client_name != GSS_C_NO_NAME) {
                maj_stat = gss_release_name(&min_stat, &gensec_gssapi_state->client_name);
        }
+
+       if (gensec_gssapi_state->lucid) {
+               gss_krb5_free_lucid_sec_context(&min_stat, gensec_gssapi_state->lucid);
+       }
+
        return 0;
 }
 
+static NTSTATUS gensec_gssapi_init_lucid(struct gensec_gssapi_state *gensec_gssapi_state)
+{
+       OM_uint32 maj_stat, min_stat;
+
+       if (gensec_gssapi_state->lucid) {
+               return NT_STATUS_OK;
+       }
+
+       maj_stat = gss_krb5_export_lucid_sec_context(&min_stat,
+                                                    &gensec_gssapi_state->gssapi_context,
+                                                    1,
+                                                    (void **)&gensec_gssapi_state->lucid);
+       if (maj_stat != GSS_S_COMPLETE) {
+               DEBUG(0,("gensec_gssapi_init_lucid: %s\n",
+                       gssapi_error_string(gensec_gssapi_state,
+                                           maj_stat, min_stat,
+                                           gensec_gssapi_state->gss_oid)));
+               return NT_STATUS_INTERNAL_ERROR;
+       }
+
+       if (gensec_gssapi_state->lucid->version != 1) {
+               DEBUG(0,("gensec_gssapi_init_lucid: lucid version[%d] != 1\n",
+                       gensec_gssapi_state->lucid->version));
+               gss_krb5_free_lucid_sec_context(&min_stat, gensec_gssapi_state->lucid);
+               gensec_gssapi_state->lucid = NULL;
+               return NT_STATUS_INTERNAL_ERROR;
+       }
+
+       return NT_STATUS_OK;
+}
+
 static NTSTATUS gensec_gssapi_start(struct gensec_security *gensec_security)
 {
        struct gensec_gssapi_state *gensec_gssapi_state;
        krb5_error_code ret;
-       
+       struct gsskrb5_send_to_kdc send_to_kdc;
+
        gensec_gssapi_state = talloc(gensec_security, struct gensec_gssapi_state);
        if (!gensec_gssapi_state) {
                return NT_STATUS_NO_MEMORY;
        }
        
+       gensec_gssapi_state->gss_exchange_count = 0;
        gensec_gssapi_state->max_wrap_buf_size
-               = lp_parm_int(-1, "gensec_gssapi", "max wrap buf size", 65536);
+               = lp_parm_int(gensec_security->lp_ctx, NULL, "gensec_gssapi", "max wrap buf size", 65536);
                
-       gensec_gssapi_state->sasl = False;
+       gensec_gssapi_state->sasl = false;
        gensec_gssapi_state->sasl_state = STAGE_GSS_NEG;
 
        gensec_security->private_data = gensec_gssapi_state;
@@ -145,18 +164,22 @@ static NTSTATUS gensec_gssapi_start(struct gensec_security *gensec_security)
        gensec_gssapi_state->gssapi_context = GSS_C_NO_CONTEXT;
        gensec_gssapi_state->server_name = GSS_C_NO_NAME;
        gensec_gssapi_state->client_name = GSS_C_NO_NAME;
+       gensec_gssapi_state->lucid = NULL;
 
        /* TODO: Fill in channel bindings */
        gensec_gssapi_state->input_chan_bindings = GSS_C_NO_CHANNEL_BINDINGS;
        
        gensec_gssapi_state->want_flags = 0;
-       if (lp_parm_bool(-1, "gensec_gssapi", "mutual", True)) {
+       if (lp_parm_bool(gensec_security->lp_ctx, NULL, "gensec_gssapi", "mutual", true)) {
                gensec_gssapi_state->want_flags |= GSS_C_MUTUAL_FLAG;
        }
-       if (lp_parm_bool(-1, "gensec_gssapi", "delegation", True)) {
+       if (lp_parm_bool(gensec_security->lp_ctx, NULL, "gensec_gssapi", "delegation", true)) {
                gensec_gssapi_state->want_flags |= GSS_C_DELEG_FLAG;
        }
-       if (lp_parm_bool(-1, "gensec_gssapi", "sequence", True)) {
+       if (lp_parm_bool(gensec_security->lp_ctx, NULL, "gensec_gssapi", "replay", true)) {
+               gensec_gssapi_state->want_flags |= GSS_C_REPLAY_FLAG;
+       }
+       if (lp_parm_bool(gensec_security->lp_ctx, NULL, "gensec_gssapi", "sequence", true)) {
                gensec_gssapi_state->want_flags |= GSS_C_SEQUENCE_FLAG;
        }
 
@@ -166,8 +189,9 @@ static NTSTATUS gensec_gssapi_start(struct gensec_security *gensec_security)
        gensec_gssapi_state->pac = data_blob(NULL, 0);
 
        gensec_gssapi_state->delegated_cred_handle = GSS_C_NO_CREDENTIAL;
+       gensec_gssapi_state->sig_size = 0;
 
-       talloc_set_destructor(gensec_gssapi_state, gensec_gssapi_destory); 
+       talloc_set_destructor(gensec_gssapi_state, gensec_gssapi_destructor);
 
        if (gensec_security->want_features & GENSEC_FEATURE_SIGN) {
                gensec_gssapi_state->want_flags |= GSS_C_INTEG_FLAG;
@@ -179,13 +203,49 @@ static NTSTATUS gensec_gssapi_start(struct gensec_security *gensec_security)
                gensec_gssapi_state->want_flags |= GSS_C_DCE_STYLE;
        }
 
-       gensec_gssapi_state->gss_oid = gss_mech_krb5;
+       gensec_gssapi_state->gss_oid = GSS_C_NULL_OID;
        
+       send_to_kdc.func = smb_krb5_send_and_recv_func;
+       send_to_kdc.ptr = gensec_security->event_ctx;
+
+       ret = gsskrb5_set_send_to_kdc(&send_to_kdc);
+       if (ret) {
+               DEBUG(1,("gensec_krb5_start: gsskrb5_set_send_to_kdc failed\n"));
+               talloc_free(gensec_gssapi_state);
+               return NT_STATUS_INTERNAL_ERROR;
+       }
+       if (lp_realm(gensec_security->lp_ctx) && *lp_realm(gensec_security->lp_ctx)) {
+               char *upper_realm = strupper_talloc(gensec_gssapi_state, lp_realm(gensec_security->lp_ctx));
+               if (!upper_realm) {
+                       DEBUG(1,("gensec_krb5_start: could not uppercase realm: %s\n", lp_realm(gensec_security->lp_ctx)));
+                       talloc_free(gensec_gssapi_state);
+                       return NT_STATUS_NO_MEMORY;
+               }
+               ret = gsskrb5_set_default_realm(upper_realm);
+               talloc_free(upper_realm);
+               if (ret) {
+                       DEBUG(1,("gensec_krb5_start: gsskrb5_set_default_realm failed\n"));
+                       talloc_free(gensec_gssapi_state);
+                       return NT_STATUS_INTERNAL_ERROR;
+               }
+       }
+
+       /* don't do DNS lookups of any kind, it might/will fail for a netbios name */
+       ret = gsskrb5_set_dns_canonicalize(lp_parm_bool(gensec_security->lp_ctx, NULL, "krb5", "set_dns_canonicalize", false));
+       if (ret) {
+               DEBUG(1,("gensec_krb5_start: gsskrb5_set_dns_canonicalize failed\n"));
+               talloc_free(gensec_gssapi_state);
+               return NT_STATUS_INTERNAL_ERROR;
+       }
+
        ret = smb_krb5_init_context(gensec_gssapi_state, 
+                                   gensec_security->event_ctx,
+                                   gensec_security->lp_ctx,
                                    &gensec_gssapi_state->smb_krb5_context);
        if (ret) {
-               DEBUG(1,("gensec_krb5_start: krb5_init_context failed (%s)\n",                                  
+               DEBUG(1,("gensec_krb5_start: krb5_init_context failed (%s)\n",
                         error_message(ret)));
+               talloc_free(gensec_gssapi_state);
                return NT_STATUS_INTERNAL_ERROR;
        }
        return NT_STATUS_OK;
@@ -212,7 +272,9 @@ static NTSTATUS gensec_gssapi_server_start(struct gensec_security *gensec_securi
                DEBUG(3, ("No machine account credentials specified\n"));
                return NT_STATUS_CANT_ACCESS_DOMAIN_INFO;
        } else {
-               ret = cli_credentials_get_server_gss_creds(machine_account, &gcc);
+               ret = cli_credentials_get_server_gss_creds(machine_account, 
+                                                          gensec_security->event_ctx, 
+                                                          gensec_security->lp_ctx, &gcc);
                if (ret) {
                        DEBUG(1, ("Aquiring acceptor credentials failed: %s\n", 
                                  error_message(ret)));
@@ -233,7 +295,7 @@ static NTSTATUS gensec_gssapi_sasl_server_start(struct gensec_security *gensec_s
 
        if (NT_STATUS_IS_OK(nt_status)) {
                gensec_gssapi_state = talloc_get_type(gensec_security->private_data, struct gensec_gssapi_state);
-               gensec_gssapi_state->sasl = True;
+               gensec_gssapi_state->sasl = true;
        }
        return nt_status;
 }
@@ -264,15 +326,6 @@ static NTSTATUS gensec_gssapi_client_start(struct gensec_security *gensec_securi
                return NT_STATUS_INVALID_PARAMETER;
        }
 
-       if (((gensec_security->want_features & GENSEC_FEATURE_SIGN)
-            || (gensec_security->want_features & GENSEC_FEATURE_SEAL))
-           && (gensec_security->want_features & GENSEC_FEATURE_DCE_STYLE)
-           && !lp_parm_bool(-1, "gensec_gssapi", "dce_signseal", 
-                            cli_credentials_get_kerberos_state(creds) == CRED_MUST_USE_KERBEROS)) {
-               DEBUG(2, ("GSSAPI sign/seal disabled for DCE/RPC. "));
-               return NT_STATUS_INVALID_PARAMETER;
-       }
-
        nt_status = gensec_gssapi_start(gensec_security);
        if (!NT_STATUS_IS_OK(nt_status)) {
                return nt_status;
@@ -280,22 +333,21 @@ static NTSTATUS gensec_gssapi_client_start(struct gensec_security *gensec_securi
 
        gensec_gssapi_state = talloc_get_type(gensec_security->private_data, struct gensec_gssapi_state);
 
-       principal = gensec_get_target_principal(gensec_security);
-       if (principal && lp_client_use_spnego_principal()) {
-               name_token.value  = discard_const_p(uint8_t, principal);
-               name_token.length = strlen(principal);
+       gensec_gssapi_state->gss_oid = gss_mech_krb5;
 
+       principal = gensec_get_target_principal(gensec_security);
+       if (principal && lp_client_use_spnego_principal(gensec_security->lp_ctx)) {
                name_type = GSS_C_NULL_OID;
        } else {
                principal = talloc_asprintf(gensec_gssapi_state, "%s@%s", 
                                            gensec_get_target_service(gensec_security), 
                                            hostname);
 
-               name_token.value  = discard_const_p(uint8_t, principal);
-               name_token.length = strlen(principal);
-
                name_type = GSS_C_NT_HOSTBASED_SERVICE;
        }               
+       name_token.value  = discard_const_p(uint8_t, principal);
+       name_token.length = strlen(principal);
+
 
        maj_stat = gss_import_name (&min_stat,
                                    &name_token,
@@ -304,24 +356,31 @@ static NTSTATUS gensec_gssapi_client_start(struct gensec_security *gensec_securi
        if (maj_stat) {
                DEBUG(2, ("GSS Import name of %s failed: %s\n",
                          (char *)name_token.value,
-                         gssapi_error_string(gensec_gssapi_state, maj_stat, min_stat)));
+                         gssapi_error_string(gensec_gssapi_state, maj_stat, min_stat, gensec_gssapi_state->gss_oid)));
                return NT_STATUS_INVALID_PARAMETER;
        }
 
-       ret = cli_credentials_get_client_gss_creds(creds, &gcc);
+       ret = cli_credentials_get_client_gss_creds(creds, 
+                                                  gensec_security->event_ctx, 
+                                                  gensec_security->lp_ctx, &gcc);
        switch (ret) {
        case 0:
                break;
+       case KRB5KDC_ERR_PREAUTH_FAILED:
+               return NT_STATUS_LOGON_FAILURE;
        case KRB5_KDC_UNREACH:
-               DEBUG(3, ("Cannot reach a KDC we require\n"));
+               DEBUG(3, ("Cannot reach a KDC we require to contact %s\n", principal));
                return NT_STATUS_INVALID_PARAMETER; /* Make SPNEGO ignore us, we can't go any further here */
        default:
-               DEBUG(1, ("Aquiring initiator credentails failed\n"));
+               DEBUG(1, ("Aquiring initiator credentials failed\n"));
                return NT_STATUS_UNSUCCESSFUL;
        }
 
        gensec_gssapi_state->client_cred = gcc;
-
+       if (!talloc_reference(gensec_gssapi_state, gcc)) {
+               return NT_STATUS_NO_MEMORY;
+       }
+       
        return NT_STATUS_OK;
 }
 
@@ -333,7 +392,7 @@ static NTSTATUS gensec_gssapi_sasl_client_start(struct gensec_security *gensec_s
 
        if (NT_STATUS_IS_OK(nt_status)) {
                gensec_gssapi_state = talloc_get_type(gensec_security->private_data, struct gensec_gssapi_state);
-               gensec_gssapi_state->sasl = True;
+               gensec_gssapi_state->sasl = true;
        }
        return nt_status;
 }
@@ -374,12 +433,13 @@ static NTSTATUS gensec_gssapi_update(struct gensec_security *gensec_security,
                                   TALLOC_CTX *out_mem_ctx, 
                                   const DATA_BLOB in, DATA_BLOB *out) 
 {
-       struct gensec_gssapi_state *gensec_gssapi_state = gensec_security->private_data;
+       struct gensec_gssapi_state *gensec_gssapi_state
+               = talloc_get_type(gensec_security->private_data, struct gensec_gssapi_state);
        NTSTATUS nt_status = NT_STATUS_LOGON_FAILURE;
        OM_uint32 maj_stat, min_stat;
        OM_uint32 min_stat2;
        gss_buffer_desc input_token, output_token;
-       gss_OID gss_oid_p;
+       gss_OID gss_oid_p = NULL;
        input_token.length = in.length;
        input_token.value = in.data;
 
@@ -393,15 +453,18 @@ static NTSTATUS gensec_gssapi_update(struct gensec_security *gensec_security,
                                                        gensec_gssapi_state->client_cred->creds,
                                                        &gensec_gssapi_state->gssapi_context, 
                                                        gensec_gssapi_state->server_name, 
-                                                       discard_const_p(gss_OID_desc, gensec_gssapi_state->gss_oid),
+                                                       gensec_gssapi_state->gss_oid,
                                                        gensec_gssapi_state->want_flags, 
                                                        0, 
                                                        gensec_gssapi_state->input_chan_bindings,
                                                        &input_token, 
-                                                       NULL, 
+                                                       &gss_oid_p,
                                                        &output_token, 
                                                        &gensec_gssapi_state->got_flags, /* ret flags */
                                                        NULL);
+                       if (gss_oid_p) {
+                               gensec_gssapi_state->gss_oid = gss_oid_p;
+                       }
                        break;
                }
                case GENSEC_SERVER:
@@ -417,7 +480,9 @@ static NTSTATUS gensec_gssapi_update(struct gensec_security *gensec_security,
                                                          &gensec_gssapi_state->got_flags, 
                                                          NULL, 
                                                          &gensec_gssapi_state->delegated_cred_handle);
-                       gensec_gssapi_state->gss_oid = gss_oid_p;
+                       if (gss_oid_p) {
+                               gensec_gssapi_state->gss_oid = gss_oid_p;
+                       }
                        break;
                }
                default:
@@ -425,6 +490,8 @@ static NTSTATUS gensec_gssapi_update(struct gensec_security *gensec_security,
                        
                }
 
+               gensec_gssapi_state->gss_exchange_count++;
+
                if (maj_stat == GSS_S_COMPLETE) {
                        *out = data_blob_talloc(out_mem_ctx, output_token.value, output_token.length);
                        gss_release_buffer(&min_stat2, &output_token);
@@ -471,29 +538,29 @@ static NTSTATUS gensec_gssapi_update(struct gensec_security *gensec_security,
                        gss_release_buffer(&min_stat2, &output_token);
                        
                        return NT_STATUS_MORE_PROCESSING_REQUIRED;
-               } else if ((gensec_gssapi_state->gss_oid->length == gss_mech_krb5->length)
-                          && (memcmp(gensec_gssapi_state->gss_oid->elements, gss_mech_krb5->elements, 
-                                     gensec_gssapi_state->gss_oid->length) == 0)) {
+               } else if (gss_oid_equal(gensec_gssapi_state->gss_oid, gss_mech_krb5)) {
                        switch (min_stat) {
                        case KRB5_KDC_UNREACH:
                                DEBUG(3, ("Cannot reach a KDC we require: %s\n",
-                                         gssapi_error_string(gensec_gssapi_state, maj_stat, min_stat)));
+                                         gssapi_error_string(gensec_gssapi_state, maj_stat, min_stat, gensec_gssapi_state->gss_oid)));
                                return NT_STATUS_INVALID_PARAMETER; /* Make SPNEGO ignore us, we can't go any further here */
                        case KRB5KDC_ERR_S_PRINCIPAL_UNKNOWN:
                                DEBUG(3, ("Server is not registered with our KDC: %s\n", 
-                                         gssapi_error_string(gensec_gssapi_state, maj_stat, min_stat)));
+                                         gssapi_error_string(gensec_gssapi_state, maj_stat, min_stat, gensec_gssapi_state->gss_oid)));
                                return NT_STATUS_INVALID_PARAMETER; /* Make SPNEGO ignore us, we can't go any further here */
                        case KRB5KRB_AP_ERR_MSG_TYPE:
                                /* garbage input, possibly from the auto-mech detection */
                                return NT_STATUS_INVALID_PARAMETER;
                        default:
-                               DEBUG(1, ("GSS(krb5) Update failed: %s\n", 
-                                         gssapi_error_string(out_mem_ctx, maj_stat, min_stat)));
+                               DEBUG(1, ("GSS Update(krb5)(%d) Update failed: %s\n", 
+                                         gensec_gssapi_state->gss_exchange_count,
+                                         gssapi_error_string(out_mem_ctx, maj_stat, min_stat, gensec_gssapi_state->gss_oid)));
                                return nt_status;
                        }
                } else {
-                       DEBUG(1, ("GSS Update failed: %s\n", 
-                                 gssapi_error_string(out_mem_ctx, maj_stat, min_stat)));
+                       DEBUG(1, ("GSS Update(%d) failed: %s\n", 
+                                 gensec_gssapi_state->gss_exchange_count,
+                                 gssapi_error_string(out_mem_ctx, maj_stat, min_stat, gensec_gssapi_state->gss_oid)));
                        return nt_status;
                }
                break;
@@ -526,7 +593,7 @@ static NTSTATUS gensec_gssapi_update(struct gensec_security *gensec_security,
                                              &qop_state);
                        if (GSS_ERROR(maj_stat)) {
                                DEBUG(1, ("gensec_gssapi_update: GSS UnWrap of SASL protection negotiation failed: %s\n", 
-                                         gssapi_error_string(out_mem_ctx, maj_stat, min_stat)));
+                                         gssapi_error_string(out_mem_ctx, maj_stat, min_stat, gensec_gssapi_state->gss_oid)));
                                return NT_STATUS_ACCESS_DENIED;
                        }
                        
@@ -571,14 +638,14 @@ static NTSTATUS gensec_gssapi_update(struct gensec_security *gensec_security,
 
                        maj_stat = gss_wrap(&min_stat, 
                                            gensec_gssapi_state->gssapi_context, 
-                                           False,
+                                           false,
                                            GSS_C_QOP_DEFAULT,
                                            &input_token,
                                            &conf_state,
                                            &output_token);
                        if (GSS_ERROR(maj_stat)) {
-                               DEBUG(1, ("gensec_gssapi_wrap: GSS Wrap failed: %s\n", 
-                                         gssapi_error_string(out_mem_ctx, maj_stat, min_stat)));
+                               DEBUG(1, ("GSS Update(SSF_NEG): GSS Wrap failed: %s\n", 
+                                         gssapi_error_string(out_mem_ctx, maj_stat, min_stat, gensec_gssapi_state->gss_oid)));
                                return NT_STATUS_ACCESS_DENIED;
                        }
                        
@@ -636,14 +703,14 @@ static NTSTATUS gensec_gssapi_update(struct gensec_security *gensec_security,
 
                        maj_stat = gss_wrap(&min_stat, 
                                            gensec_gssapi_state->gssapi_context, 
-                                           False,
+                                           false,
                                            GSS_C_QOP_DEFAULT,
                                            &input_token,
                                            &conf_state,
                                            &output_token);
                        if (GSS_ERROR(maj_stat)) {
-                               DEBUG(1, ("gensec_gssapi_wrap: GSS Wrap failed: %s\n", 
-                                         gssapi_error_string(out_mem_ctx, maj_stat, min_stat)));
+                               DEBUG(1, ("GSS Update(SSF_NEG): GSS Wrap failed: %s\n", 
+                                         gssapi_error_string(out_mem_ctx, maj_stat, min_stat, gensec_gssapi_state->gss_oid)));
                                return NT_STATUS_ACCESS_DENIED;
                        }
                        
@@ -676,7 +743,7 @@ static NTSTATUS gensec_gssapi_update(struct gensec_security *gensec_security,
                                      &qop_state);
                if (GSS_ERROR(maj_stat)) {
                        DEBUG(1, ("gensec_gssapi_update: GSS UnWrap of SASL protection negotiation failed: %s\n", 
-                                 gssapi_error_string(out_mem_ctx, maj_stat, min_stat)));
+                                 gssapi_error_string(out_mem_ctx, maj_stat, min_stat, gensec_gssapi_state->gss_oid)));
                        return NT_STATUS_ACCESS_DENIED;
                }
                        
@@ -734,7 +801,8 @@ static NTSTATUS gensec_gssapi_wrap(struct gensec_security *gensec_security,
                                   const DATA_BLOB *in, 
                                   DATA_BLOB *out)
 {
-       struct gensec_gssapi_state *gensec_gssapi_state = gensec_security->private_data;
+       struct gensec_gssapi_state *gensec_gssapi_state
+               = talloc_get_type(gensec_security->private_data, struct gensec_gssapi_state);
        OM_uint32 maj_stat, min_stat;
        gss_buffer_desc input_token, output_token;
        int conf_state;
@@ -750,7 +818,7 @@ static NTSTATUS gensec_gssapi_wrap(struct gensec_security *gensec_security,
                            &output_token);
        if (GSS_ERROR(maj_stat)) {
                DEBUG(1, ("gensec_gssapi_wrap: GSS Wrap failed: %s\n", 
-                         gssapi_error_string(mem_ctx, maj_stat, min_stat)));
+                         gssapi_error_string(mem_ctx, maj_stat, min_stat, gensec_gssapi_state->gss_oid)));
                return NT_STATUS_ACCESS_DENIED;
        }
 
@@ -761,8 +829,8 @@ static NTSTATUS gensec_gssapi_wrap(struct gensec_security *gensec_security,
                size_t max_wrapped_size = gensec_gssapi_max_wrapped_size(gensec_security);
                if (max_wrapped_size < out->length) {
                        DEBUG(1, ("gensec_gssapi_wrap: when wrapped, INPUT data (%u) is grew to be larger than SASL negotiated maximum output size (%u > %u)\n",
-                                 in->length, 
-                                 out->length, 
+                                 (unsigned)in->length, 
+                                 (unsigned)out->length, 
                                  (unsigned int)max_wrapped_size));
                        return NT_STATUS_INVALID_PARAMETER;
                }
@@ -780,7 +848,8 @@ static NTSTATUS gensec_gssapi_unwrap(struct gensec_security *gensec_security,
                                     const DATA_BLOB *in, 
                                     DATA_BLOB *out)
 {
-       struct gensec_gssapi_state *gensec_gssapi_state = gensec_security->private_data;
+       struct gensec_gssapi_state *gensec_gssapi_state
+               = talloc_get_type(gensec_security->private_data, struct gensec_gssapi_state);
        OM_uint32 maj_stat, min_stat;
        gss_buffer_desc input_token, output_token;
        int conf_state;
@@ -804,7 +873,7 @@ static NTSTATUS gensec_gssapi_unwrap(struct gensec_security *gensec_security,
                              &qop_state);
        if (GSS_ERROR(maj_stat)) {
                DEBUG(1, ("gensec_gssapi_unwrap: GSS UnWrap failed: %s\n", 
-                         gssapi_error_string(mem_ctx, maj_stat, min_stat)));
+                         gssapi_error_string(mem_ctx, maj_stat, min_stat, gensec_gssapi_state->gss_oid)));
                return NT_STATUS_ACCESS_DENIED;
        }
 
@@ -818,51 +887,12 @@ static NTSTATUS gensec_gssapi_unwrap(struct gensec_security *gensec_security,
        return NT_STATUS_OK;
 }
 
-/* Find out the size of the signature, assuming (incorrectly) that it
- * GSSAPI provides any guarantees as to it's size.
- *
- * This is needed by the DCE/RPC code, which uses AEAD 
- * (signed headers, including signature legnth and a sealed body)
- */
-static size_t gensec_gssapi_sig_size(struct gensec_security *gensec_security, size_t data_size) 
-{
-       struct gensec_gssapi_state *gensec_gssapi_state = gensec_security->private_data;
-       OM_uint32 maj_stat, min_stat;
-       OM_uint32 output_size;
-       if ((gensec_gssapi_state->gss_oid->length != gss_mech_krb5->length)
-           || (memcmp(gensec_gssapi_state->gss_oid->elements, gss_mech_krb5->elements, 
-                      gensec_gssapi_state->gss_oid->length) != 0)) {
-               DEBUG(1, ("NO sig size available for this mech\n"));
-               return 0;
-       }
-               
-       maj_stat = gsskrb5_wrap_size(&min_stat, 
-                                    gensec_gssapi_state->gssapi_context,
-                                    gensec_have_feature(gensec_security, GENSEC_FEATURE_SEAL),
-                                    GSS_C_QOP_DEFAULT,
-                                    data_size, 
-                                    &output_size);
-       if (GSS_ERROR(maj_stat)) {
-               TALLOC_CTX *mem_ctx = talloc_new(NULL); 
-               DEBUG(1, ("gensec_gssapi_sig_size: determinaing signature size with gsskrb5_wrap_size failed: %s\n", 
-                         gssapi_error_string(mem_ctx, maj_stat, min_stat)));
-               talloc_free(mem_ctx);
-               return 0;
-       }
-
-       if (output_size < data_size) {
-               return 0;
-       }
-
-       /* The difference between the max output and the max input must be the signature */
-       return output_size - data_size;
-}
-
 /* Find out the maximum input size negotiated on this connection */
 
 static size_t gensec_gssapi_max_input_size(struct gensec_security *gensec_security) 
 {
-       struct gensec_gssapi_state *gensec_gssapi_state = gensec_security->private_data;
+       struct gensec_gssapi_state *gensec_gssapi_state
+               = talloc_get_type(gensec_security->private_data, struct gensec_gssapi_state);
        OM_uint32 maj_stat, min_stat;
        OM_uint32 max_input_size;
 
@@ -875,7 +905,7 @@ static size_t gensec_gssapi_max_input_size(struct gensec_security *gensec_securi
        if (GSS_ERROR(maj_stat)) {
                TALLOC_CTX *mem_ctx = talloc_new(NULL); 
                DEBUG(1, ("gensec_gssapi_max_input_size: determinaing signature size with gss_wrap_size_limit failed: %s\n", 
-                         gssapi_error_string(mem_ctx, maj_stat, min_stat)));
+                         gssapi_error_string(mem_ctx, maj_stat, min_stat, gensec_gssapi_state->gss_oid)));
                talloc_free(mem_ctx);
                return 0;
        }
@@ -886,7 +916,7 @@ static size_t gensec_gssapi_max_input_size(struct gensec_security *gensec_securi
 /* Find out the maximum output size negotiated on this connection */
 static size_t gensec_gssapi_max_wrapped_size(struct gensec_security *gensec_security) 
 {
-       struct gensec_gssapi_state *gensec_gssapi_state = gensec_security->private_data;
+       struct gensec_gssapi_state *gensec_gssapi_state = talloc_get_type(gensec_security->private_data, struct gensec_gssapi_state);;
        return gensec_gssapi_state->max_wrap_buf_size;
 }
 
@@ -896,7 +926,8 @@ static NTSTATUS gensec_gssapi_seal_packet(struct gensec_security *gensec_securit
                                          const uint8_t *whole_pdu, size_t pdu_length, 
                                          DATA_BLOB *sig)
 {
-       struct gensec_gssapi_state *gensec_gssapi_state = gensec_security->private_data;
+       struct gensec_gssapi_state *gensec_gssapi_state
+               = talloc_get_type(gensec_security->private_data, struct gensec_gssapi_state);
        OM_uint32 maj_stat, min_stat;
        gss_buffer_desc input_token, output_token;
        int conf_state;
@@ -914,18 +945,16 @@ static NTSTATUS gensec_gssapi_seal_packet(struct gensec_security *gensec_securit
                            &output_token);
        if (GSS_ERROR(maj_stat)) {
                DEBUG(1, ("gensec_gssapi_seal_packet: GSS Wrap failed: %s\n", 
-                         gssapi_error_string(mem_ctx, maj_stat, min_stat)));
+                         gssapi_error_string(mem_ctx, maj_stat, min_stat, gensec_gssapi_state->gss_oid)));
                return NT_STATUS_ACCESS_DENIED;
        }
 
-       sig_length = gensec_gssapi_sig_size(gensec_security, length);
-
-       /* Caller must pad to right boundary */
-       if (output_token.length != (length + sig_length)) {
-               DEBUG(1, ("gensec_gssapi_seal_packet: GSS Wrap length [%ld] does not match caller length [%ld] plus sig size [%ld] = [%ld]\n", 
-                         (long)output_token.length, (long)length, (long)sig_length, (long)(length + sig_length)));
+       if (output_token.length < input_token.length) {
+               DEBUG(1, ("gensec_gssapi_seal_packet: GSS Wrap length [%ld] *less* than caller length [%ld]\n", 
+                         (long)output_token.length, (long)length));
                return NT_STATUS_INTERNAL_ERROR;
        }
+       sig_length = output_token.length - input_token.length;
 
        memcpy(data, ((uint8_t *)output_token.value) + sig_length, length);
        *sig = data_blob_talloc(mem_ctx, (uint8_t *)output_token.value, sig_length);
@@ -949,7 +978,8 @@ static NTSTATUS gensec_gssapi_unseal_packet(struct gensec_security *gensec_secur
                                            const uint8_t *whole_pdu, size_t pdu_length,
                                            const DATA_BLOB *sig)
 {
-       struct gensec_gssapi_state *gensec_gssapi_state = gensec_security->private_data;
+       struct gensec_gssapi_state *gensec_gssapi_state
+               = talloc_get_type(gensec_security->private_data, struct gensec_gssapi_state);
        OM_uint32 maj_stat, min_stat;
        gss_buffer_desc input_token, output_token;
        int conf_state;
@@ -974,7 +1004,7 @@ static NTSTATUS gensec_gssapi_unseal_packet(struct gensec_security *gensec_secur
                              &qop_state);
        if (GSS_ERROR(maj_stat)) {
                DEBUG(1, ("gensec_gssapi_unseal_packet: GSS UnWrap failed: %s\n", 
-                         gssapi_error_string(mem_ctx, maj_stat, min_stat)));
+                         gssapi_error_string(mem_ctx, maj_stat, min_stat, gensec_gssapi_state->gss_oid)));
                return NT_STATUS_ACCESS_DENIED;
        }
 
@@ -999,42 +1029,31 @@ static NTSTATUS gensec_gssapi_sign_packet(struct gensec_security *gensec_securit
                                          const uint8_t *whole_pdu, size_t pdu_length, 
                                          DATA_BLOB *sig)
 {
-       struct gensec_gssapi_state *gensec_gssapi_state = gensec_security->private_data;
+       struct gensec_gssapi_state *gensec_gssapi_state
+               = talloc_get_type(gensec_security->private_data, struct gensec_gssapi_state);
        OM_uint32 maj_stat, min_stat;
        gss_buffer_desc input_token, output_token;
-       int conf_state;
-       ssize_t sig_length = 0;
 
-       input_token.length = length;
-       input_token.value = discard_const_p(uint8_t *, data);
+       if (gensec_security->want_features & GENSEC_FEATURE_SIGN_PKT_HEADER) {
+               input_token.length = pdu_length;
+               input_token.value = discard_const_p(uint8_t *, whole_pdu);
+       } else {
+               input_token.length = length;
+               input_token.value = discard_const_p(uint8_t *, data);
+       }
 
-       maj_stat = gss_wrap(&min_stat, 
+       maj_stat = gss_get_mic(&min_stat,
                            gensec_gssapi_state->gssapi_context,
-                           0,
                            GSS_C_QOP_DEFAULT,
                            &input_token,
-                           &conf_state,
                            &output_token);
        if (GSS_ERROR(maj_stat)) {
-               DEBUG(1, ("GSS Wrap failed: %s\n", 
-                         gssapi_error_string(mem_ctx, maj_stat, min_stat)));
+               DEBUG(1, ("GSS GetMic failed: %s\n",
+                         gssapi_error_string(mem_ctx, maj_stat, min_stat, gensec_gssapi_state->gss_oid)));
                return NT_STATUS_ACCESS_DENIED;
        }
 
-       if (output_token.length < length) {
-               return NT_STATUS_INTERNAL_ERROR;
-       }
-
-       sig_length = gensec_gssapi_sig_size(gensec_security, length);
-
-       /* Caller must pad to right boundary */
-       if (output_token.length != (length + sig_length)) {
-               DEBUG(1, ("gensec_gssapi_sign_packet: GSS Wrap length [%ld] does not match caller length [%ld] plus sig size [%ld] = [%ld]\n", 
-                         (long)output_token.length, (long)length, (long)sig_length, (long)(length + sig_length)));
-               return NT_STATUS_INTERNAL_ERROR;
-       }
-
-       *sig = data_blob_talloc(mem_ctx, (uint8_t *)output_token.value, sig_length);
+       *sig = data_blob_talloc(mem_ctx, (uint8_t *)output_token.value, output_token.length);
 
        dump_data_pw("gensec_gssapi_seal_packet: sig\n", sig->data, sig->length);
 
@@ -1049,49 +1068,46 @@ static NTSTATUS gensec_gssapi_check_packet(struct gensec_security *gensec_securi
                                           const uint8_t *whole_pdu, size_t pdu_length, 
                                           const DATA_BLOB *sig)
 {
-       struct gensec_gssapi_state *gensec_gssapi_state = gensec_security->private_data;
+       struct gensec_gssapi_state *gensec_gssapi_state
+               = talloc_get_type(gensec_security->private_data, struct gensec_gssapi_state);
        OM_uint32 maj_stat, min_stat;
-       gss_buffer_desc input_token, output_token;
-       int conf_state;
+       gss_buffer_desc input_token;
+       gss_buffer_desc input_message;
        gss_qop_t qop_state;
-       DATA_BLOB in;
 
        dump_data_pw("gensec_gssapi_seal_packet: sig\n", sig->data, sig->length);
 
-       in = data_blob_talloc(mem_ctx, NULL, sig->length + length);
+       if (gensec_security->want_features & GENSEC_FEATURE_SIGN_PKT_HEADER) {
+               input_message.length = pdu_length;
+               input_message.value = discard_const(whole_pdu);
+       } else {
+               input_message.length = length;
+               input_message.value = discard_const(data);
+       }
 
-       memcpy(in.data, sig->data, sig->length);
-       memcpy(in.data + sig->length, data, length);
+       input_token.length = sig->length;
+       input_token.value = sig->data;
 
-       input_token.length = in.length;
-       input_token.value = in.data;
-       
-       maj_stat = gss_unwrap(&min_stat, 
+       maj_stat = gss_verify_mic(&min_stat,
                              gensec_gssapi_state->gssapi_context, 
+                             &input_message,
                              &input_token,
-                             &output_token, 
-                             &conf_state,
                              &qop_state);
        if (GSS_ERROR(maj_stat)) {
-               DEBUG(1, ("GSS UnWrap failed: %s\n", 
-                         gssapi_error_string(mem_ctx, maj_stat, min_stat)));
+               DEBUG(1, ("GSS VerifyMic failed: %s\n",
+                         gssapi_error_string(mem_ctx, maj_stat, min_stat, gensec_gssapi_state->gss_oid)));
                return NT_STATUS_ACCESS_DENIED;
        }
 
-       if (output_token.length != length) {
-               return NT_STATUS_INTERNAL_ERROR;
-       }
-
-       gss_release_buffer(&min_stat, &output_token);
-
        return NT_STATUS_OK;
 }
 
 /* Try to figure out what features we actually got on the connection */
-static BOOL gensec_gssapi_have_feature(struct gensec_security *gensec_security, 
+static bool gensec_gssapi_have_feature(struct gensec_security *gensec_security, 
                                       uint32_t feature) 
 {
-       struct gensec_gssapi_state *gensec_gssapi_state = gensec_security->private_data;
+       struct gensec_gssapi_state *gensec_gssapi_state
+               = talloc_get_type(gensec_security->private_data, struct gensec_gssapi_state);
        if (feature & GENSEC_FEATURE_SIGN) {
                /* If we are going GSSAPI SASL, then we honour the second negotiation */
                if (gensec_gssapi_state->sasl 
@@ -1112,19 +1128,43 @@ static BOOL gensec_gssapi_have_feature(struct gensec_security *gensec_security,
        }
        if (feature & GENSEC_FEATURE_SESSION_KEY) {
                /* Only for GSSAPI/Krb5 */
-               if ((gensec_gssapi_state->gss_oid->length == gss_mech_krb5->length)
-                   && (memcmp(gensec_gssapi_state->gss_oid->elements, gss_mech_krb5->elements, gensec_gssapi_state->gss_oid->length) == 0)) {
-                       return True;
+               if (gss_oid_equal(gensec_gssapi_state->gss_oid, gss_mech_krb5)) {
+                       return true;
                }
        }
        if (feature & GENSEC_FEATURE_DCE_STYLE) {
                return gensec_gssapi_state->got_flags & GSS_C_DCE_STYLE;
        }
+       if (feature & GENSEC_FEATURE_NEW_SPNEGO) {
+               NTSTATUS status;
+
+               if (!(gensec_gssapi_state->got_flags & GSS_C_INTEG_FLAG)) {
+                       return false;
+               }
+
+               if (lp_parm_bool(gensec_security->lp_ctx, NULL, "gensec_gssapi", "force_new_spnego", false)) {
+                       return true;
+               }
+               if (lp_parm_bool(gensec_security->lp_ctx, NULL, "gensec_gssapi", "disable_new_spnego", false)) {
+                       return false;
+               }
+
+               status = gensec_gssapi_init_lucid(gensec_gssapi_state);
+               if (!NT_STATUS_IS_OK(status)) {
+                       return false;
+               }
+
+               if (gensec_gssapi_state->lucid->protocol == 1) {
+                       return true;
+               }
+
+               return false;
+       }
        /* We can always do async (rather than strict request/reply) packets.  */
        if (feature & GENSEC_FEATURE_ASYNC_REPLIES) {
-               return True;
+               return true;
        }
-       return False;
+       return false;
 }
 
 /*
@@ -1136,43 +1176,38 @@ static BOOL gensec_gssapi_have_feature(struct gensec_security *gensec_security,
 static NTSTATUS gensec_gssapi_session_key(struct gensec_security *gensec_security, 
                                          DATA_BLOB *session_key) 
 {
-       struct gensec_gssapi_state *gensec_gssapi_state = gensec_security->private_data;
-       
+       struct gensec_gssapi_state *gensec_gssapi_state
+               = talloc_get_type(gensec_security->private_data, struct gensec_gssapi_state);
+       OM_uint32 maj_stat, min_stat;
+       krb5_keyblock *subkey;
+
        if (gensec_gssapi_state->session_key.data) {
                *session_key = gensec_gssapi_state->session_key;
                return NT_STATUS_OK;
        }
 
-       /* Ensure we only call this for GSSAPI/krb5, otherwise things
-        * could get very ugly */
-       if ((gensec_gssapi_state->gss_oid->length == gss_mech_krb5->length)
-           && (memcmp(gensec_gssapi_state->gss_oid->elements, gss_mech_krb5->elements, 
-                      gensec_gssapi_state->gss_oid->length) == 0)) {
-               OM_uint32 maj_stat, min_stat;
-               gss_buffer_desc skey;
-               
-               maj_stat = gsskrb5_get_initiator_subkey(&min_stat, 
-                                                       gensec_gssapi_state->gssapi_context, 
-                                                       &skey);
-               
-               if (maj_stat == 0) {
-                       DEBUG(10, ("Got KRB5 session key of length %d\n",  
-                                  (int)skey.length));
-                       gensec_gssapi_state->session_key = data_blob_talloc(gensec_gssapi_state, 
-                                                                           skey.value, skey.length);
-                       *session_key = gensec_gssapi_state->session_key;
-                       dump_data_pw("KRB5 Session Key:\n", session_key->data, session_key->length);
-                       
-                       gss_release_buffer(&min_stat, &skey);
-                       return NT_STATUS_OK;
-               }
+       maj_stat = gsskrb5_get_subkey(&min_stat,
+                                     gensec_gssapi_state->gssapi_context,
+                                     &subkey);
+       if (maj_stat != 0) {
+               DEBUG(1, ("NO session key for this mech\n"));
                return NT_STATUS_NO_USER_SESSION_KEY;
        }
        
-       DEBUG(1, ("NO session key for this mech\n"));
-       return NT_STATUS_NO_USER_SESSION_KEY;
-}
+       DEBUG(10, ("Got KRB5 session key of length %d%s\n",
+                  (int)KRB5_KEY_LENGTH(subkey),
+                  (gensec_gssapi_state->sasl_state == STAGE_DONE)?" (done)":""));
+       *session_key = data_blob_talloc(gensec_gssapi_state,
+                                       KRB5_KEY_DATA(subkey), KRB5_KEY_LENGTH(subkey));
+       krb5_free_keyblock(gensec_gssapi_state->smb_krb5_context->krb5_context, subkey);
+       if (gensec_gssapi_state->sasl_state == STAGE_DONE) {
+               /* only cache in the done stage */
+               gensec_gssapi_state->session_key = *session_key;
+       }
+       dump_data_pw("KRB5 Session Key:\n", session_key->data, session_key->length);
 
+       return NT_STATUS_OK;
+}
 
 /* Get some basic (and authorization) information about the user on
  * this session.  This uses either the PAC (if present) or a local
@@ -1182,7 +1217,8 @@ static NTSTATUS gensec_gssapi_session_info(struct gensec_security *gensec_securi
 {
        NTSTATUS nt_status;
        TALLOC_CTX *mem_ctx;
-       struct gensec_gssapi_state *gensec_gssapi_state = gensec_security->private_data;
+       struct gensec_gssapi_state *gensec_gssapi_state
+               = talloc_get_type(gensec_security->private_data, struct gensec_gssapi_state);
        struct auth_serversupplied_info *server_info = NULL;
        struct auth_session_info *session_info = NULL;
        struct PAC_LOGON_INFO *logon_info;
@@ -1209,12 +1245,16 @@ static NTSTATUS gensec_gssapi_session_info(struct gensec_security *gensec_securi
                                     gensec_gssapi_state->client_name,
                                     &name_token,
                                     NULL);
-       if (maj_stat) {
+       if (GSS_ERROR(maj_stat)) {
+               DEBUG(1, ("GSS display_name failed: %s\n", 
+                         gssapi_error_string(mem_ctx, maj_stat, min_stat, gensec_gssapi_state->gss_oid)));
                talloc_free(mem_ctx);
                return NT_STATUS_FOOBAR;
        }
 
-       principal_string = talloc_strndup(mem_ctx, name_token.value, name_token.length);
+       principal_string = talloc_strndup(mem_ctx, 
+                                         (const char *)name_token.value, 
+                                         name_token.length);
 
        gss_release_buffer(&min_stat, &name_token);
 
@@ -1223,77 +1263,101 @@ static NTSTATUS gensec_gssapi_session_info(struct gensec_security *gensec_securi
                return NT_STATUS_NO_MEMORY;
        }
 
-       maj_stat = gss_krb5_copy_service_keyblock(&min_stat, 
-                                                 gensec_gssapi_state->gssapi_context, 
-                                                 &keyblock);
-
-       if (maj_stat == 0) {
-               maj_stat = gsskrb5_extract_authtime_from_sec_context(&min_stat,
-                                                                    gensec_gssapi_state->gssapi_context, 
-                                                                    &authtime);
-       }
-
-       if (maj_stat == 0) {
-               maj_stat = gsskrb5_extract_authz_data_from_sec_context(&min_stat, 
-                                                                      gensec_gssapi_state->gssapi_context, 
-                                                                      KRB5_AUTHDATA_WIN2K_PAC,
-                                                                      &pac);
-       }
-
+       maj_stat = gsskrb5_extract_authz_data_from_sec_context(&min_stat, 
+                                                              gensec_gssapi_state->gssapi_context, 
+                                                              KRB5_AUTHDATA_WIN2K_PAC,
+                                                              &pac);
+       
+       
        if (maj_stat == 0) {
                pac_blob = data_blob_talloc(mem_ctx, pac.value, pac.length);
                gss_release_buffer(&min_stat, &pac);
+
+       } else {
+               pac_blob = data_blob(NULL, 0);
        }
        
        /* IF we have the PAC - otherwise we need to get this
         * data from elsewere - local ldb, or (TODO) lookup of some
         * kind... 
         */
-       if (maj_stat == 0) {
+       if (pac_blob.length) {
                krb5_error_code ret;
+               union netr_Validation validation;
 
-               ret = krb5_parse_name(gensec_gssapi_state->smb_krb5_context->krb5_context,
-                                     principal_string, &principal);
+               maj_stat = gsskrb5_extract_authtime_from_sec_context(&min_stat,
+                                                                    gensec_gssapi_state->gssapi_context, 
+                                                                    &authtime);
+               
+               if (GSS_ERROR(maj_stat)) {
+                       DEBUG(1, ("gsskrb5_extract_authtime_from_sec_context: %s\n", 
+                                 gssapi_error_string(mem_ctx, maj_stat, min_stat, gensec_gssapi_state->gss_oid)));
+                       talloc_free(mem_ctx);
+                       return NT_STATUS_FOOBAR;
+               }
+
+               maj_stat = gsskrb5_extract_service_keyblock(&min_stat, 
+                                                           gensec_gssapi_state->gssapi_context, 
+                                                           &keyblock);
+               
+               if (GSS_ERROR(maj_stat)) {
+                       DEBUG(1, ("gsskrb5_copy_service_keyblock failed: %s\n", 
+                                 gssapi_error_string(mem_ctx, maj_stat, min_stat, gensec_gssapi_state->gss_oid)));
+                       talloc_free(mem_ctx);
+                       return NT_STATUS_FOOBAR;
+               } 
+
+               ret = krb5_parse_name_flags(gensec_gssapi_state->smb_krb5_context->krb5_context,
+                                           principal_string, 
+                                           KRB5_PRINCIPAL_PARSE_MUST_REALM,
+                                           &principal);
                if (ret) {
+                       krb5_free_keyblock(gensec_gssapi_state->smb_krb5_context->krb5_context,
+                                          keyblock);
                        talloc_free(mem_ctx);
                        return NT_STATUS_INVALID_PARAMETER;
                }
                
                /* decode and verify the pac */
-               nt_status = kerberos_pac_logon_info(mem_ctx, &logon_info, pac_blob,
+               nt_status = kerberos_pac_logon_info(mem_ctx, lp_iconv_convenience(gensec_security->lp_ctx), &logon_info, pac_blob,
                                                    gensec_gssapi_state->smb_krb5_context->krb5_context,
                                                    NULL, keyblock, principal, authtime, NULL);
                krb5_free_principal(gensec_gssapi_state->smb_krb5_context->krb5_context, principal);
+               krb5_free_keyblock(gensec_gssapi_state->smb_krb5_context->krb5_context,
+                                  keyblock);
 
-               if (NT_STATUS_IS_OK(nt_status)) {
-                       union netr_Validation validation;
-                       validation.sam3 = &logon_info->info3;
-                       nt_status = make_server_info_netlogon_validation(gensec_gssapi_state, 
-                                                                        NULL,
-                                                                        3, &validation,
-                                                                        &server_info); 
-                       if (!NT_STATUS_IS_OK(nt_status)) {
-                               talloc_free(mem_ctx);
-                               return nt_status;
-                       }
-               } else {
-                       maj_stat = 1;
+               if (!NT_STATUS_IS_OK(nt_status)) {
+                       talloc_free(mem_ctx);
+                       return nt_status;
                }
-       }
-       
-       if (maj_stat) {
-               DEBUG(1, ("Unable to use PAC, resorting to local user lookup!\n"));
-               nt_status = sam_get_server_info_principal(mem_ctx, principal_string,
+               validation.sam3 = &logon_info->info3;
+               nt_status = make_server_info_netlogon_validation(gensec_gssapi_state, 
+                                                                NULL,
+                                                                3, &validation,
+                                                                &server_info); 
+               if (!NT_STATUS_IS_OK(nt_status)) {
+                       talloc_free(mem_ctx);
+                       return nt_status;
+               }
+       } else if (!lp_parm_bool(gensec_security->lp_ctx, NULL, "gensec", "require_pac", false)) {
+               DEBUG(1, ("Unable to find PAC, resorting to local user lookup: %s\n",
+                         gssapi_error_string(mem_ctx, maj_stat, min_stat, gensec_gssapi_state->gss_oid)));
+               nt_status = sam_get_server_info_principal(mem_ctx, gensec_security->event_ctx, gensec_security->lp_ctx, principal_string,
                                                          &server_info);
 
                if (!NT_STATUS_IS_OK(nt_status)) {
                        talloc_free(mem_ctx);
                        return nt_status;
                }
+       } else {
+               DEBUG(1, ("Unable to find PAC in ticket from %s, failing to allow access: %s\n",
+                         principal_string,
+                         gssapi_error_string(mem_ctx, maj_stat, min_stat, gensec_gssapi_state->gss_oid)));
+               return NT_STATUS_ACCESS_DENIED;
        }
 
        /* references the server_info into the session_info */
-       nt_status = auth_generate_session_info(mem_ctx, server_info, &session_info);
+       nt_status = auth_generate_session_info(mem_ctx, gensec_security->event_ctx, gensec_security->lp_ctx, server_info, &session_info);
        if (!NT_STATUS_IS_OK(nt_status)) {
                talloc_free(mem_ctx);
                return nt_status;
@@ -1316,15 +1380,23 @@ static NTSTATUS gensec_gssapi_session_info(struct gensec_security *gensec_securi
                        return NT_STATUS_NO_MEMORY;
                }
 
-               cli_credentials_set_conf(session_info->credentials);
+               cli_credentials_set_conf(session_info->credentials, gensec_security->lp_ctx);
+               /* Just so we don't segfault trying to get at a username */
+               cli_credentials_set_anonymous(session_info->credentials);
                
                ret = cli_credentials_set_client_gss_creds(session_info->credentials, 
+                                                          gensec_security->event_ctx,
+                                                          gensec_security->lp_ctx, 
                                                           gensec_gssapi_state->delegated_cred_handle,
                                                           CRED_SPECIFIED);
                if (ret) {
                        talloc_free(mem_ctx);
                        return NT_STATUS_NO_MEMORY;
                }
+               
+               /* This credential handle isn't useful for password authentication, so ensure nobody tries to do that */
+               cli_credentials_set_kerberos_state(session_info->credentials, CRED_MUST_USE_KERBEROS);
+
                /* It has been taken from this place... */
                gensec_gssapi_state->delegated_cred_handle = GSS_C_NO_CREDENTIAL;
        }
@@ -1335,12 +1407,96 @@ static NTSTATUS gensec_gssapi_session_info(struct gensec_security *gensec_securi
        return NT_STATUS_OK;
 }
 
+size_t gensec_gssapi_sig_size(struct gensec_security *gensec_security, size_t data_size)
+{
+       struct gensec_gssapi_state *gensec_gssapi_state
+               = talloc_get_type(gensec_security->private_data, struct gensec_gssapi_state);
+       NTSTATUS status;
+
+       if (gensec_gssapi_state->sig_size) {
+               return gensec_gssapi_state->sig_size;
+       }
+
+       if (gensec_gssapi_state->got_flags & GSS_C_CONF_FLAG) {
+               gensec_gssapi_state->sig_size = 45;
+       } else {
+               gensec_gssapi_state->sig_size = 37;
+       }
+
+       status = gensec_gssapi_init_lucid(gensec_gssapi_state);
+       if (!NT_STATUS_IS_OK(status)) {
+               return gensec_gssapi_state->sig_size;
+       }
+
+       if (gensec_gssapi_state->lucid->protocol == 1) {
+               if (gensec_gssapi_state->got_flags & GSS_C_CONF_FLAG) {
+                       /*
+                        * TODO: windows uses 76 here, but we don't know
+                        *       gss_wrap works with aes keys yet
+                        */
+                       gensec_gssapi_state->sig_size = 76;
+               } else {
+                       gensec_gssapi_state->sig_size = 28;
+               }
+       } else if (gensec_gssapi_state->lucid->protocol == 0) {
+               switch (gensec_gssapi_state->lucid->rfc1964_kd.ctx_key.type) {
+               case KEYTYPE_DES:
+               case KEYTYPE_ARCFOUR:
+               case KEYTYPE_ARCFOUR_56:
+                       if (gensec_gssapi_state->got_flags & GSS_C_CONF_FLAG) {
+                               gensec_gssapi_state->sig_size = 45;
+                       } else {
+                               gensec_gssapi_state->sig_size = 37;
+                       }
+                       break;
+               case KEYTYPE_DES3:
+                       if (gensec_gssapi_state->got_flags & GSS_C_CONF_FLAG) {
+                               gensec_gssapi_state->sig_size = 57;
+                       } else {
+                               gensec_gssapi_state->sig_size = 49;
+                       }
+                       break;
+               }
+       }
+
+       return gensec_gssapi_state->sig_size;
+}
+
 static const char *gensec_gssapi_krb5_oids[] = { 
-       GENSEC_OID_KERBEROS5,
        GENSEC_OID_KERBEROS5_OLD,
+       GENSEC_OID_KERBEROS5,
+       NULL 
+};
+
+static const char *gensec_gssapi_spnego_oids[] = { 
+       GENSEC_OID_SPNEGO,
        NULL 
 };
 
+/* As a server, this could in theory accept any GSSAPI mech */
+static const struct gensec_security_ops gensec_gssapi_spnego_security_ops = {
+       .name           = "gssapi_spnego",
+       .sasl_name      = "GSS-SPNEGO",
+       .auth_type      = DCERPC_AUTH_TYPE_SPNEGO,
+       .oid            = gensec_gssapi_spnego_oids,
+       .client_start   = gensec_gssapi_client_start,
+       .server_start   = gensec_gssapi_server_start,
+       .magic          = gensec_gssapi_magic,
+       .update         = gensec_gssapi_update,
+       .session_key    = gensec_gssapi_session_key,
+       .session_info   = gensec_gssapi_session_info,
+       .sign_packet    = gensec_gssapi_sign_packet,
+       .check_packet   = gensec_gssapi_check_packet,
+       .seal_packet    = gensec_gssapi_seal_packet,
+       .unseal_packet  = gensec_gssapi_unseal_packet,
+       .wrap           = gensec_gssapi_wrap,
+       .unwrap         = gensec_gssapi_unwrap,
+       .have_feature   = gensec_gssapi_have_feature,
+       .enabled        = false,
+       .kerberos       = true,
+       .priority       = GENSEC_GSSAPI
+};
+
 /* As a server, this could in theory accept any GSSAPI mech */
 static const struct gensec_security_ops gensec_gssapi_krb5_security_ops = {
        .name           = "gssapi_krb5",
@@ -1360,8 +1516,9 @@ static const struct gensec_security_ops gensec_gssapi_krb5_security_ops = {
        .wrap           = gensec_gssapi_wrap,
        .unwrap         = gensec_gssapi_unwrap,
        .have_feature   = gensec_gssapi_have_feature,
-       .enabled        = True,
-       .kerberos       = True
+       .enabled        = true,
+       .kerberos       = true,
+       .priority       = GENSEC_GSSAPI
 };
 
 /* As a server, this could in theory accept any GSSAPI mech */
@@ -1378,14 +1535,22 @@ static const struct gensec_security_ops gensec_gssapi_sasl_krb5_security_ops = {
        .wrap             = gensec_gssapi_wrap,
        .unwrap           = gensec_gssapi_unwrap,
        .have_feature     = gensec_gssapi_have_feature,
-       .enabled          = True,
-       .kerberos         = True
+       .enabled          = true,
+       .kerberos         = true,
+       .priority         = GENSEC_GSSAPI
 };
 
-NTSTATUS gensec_gssapi_init(void)
+_PUBLIC_ NTSTATUS gensec_gssapi_init(void)
 {
        NTSTATUS ret;
 
+       ret = gensec_register(&gensec_gssapi_spnego_security_ops);
+       if (!NT_STATUS_IS_OK(ret)) {
+               DEBUG(0,("Failed to register '%s' gensec backend!\n",
+                       gensec_gssapi_spnego_security_ops.name));
+               return ret;
+       }
+
        ret = gensec_register(&gensec_gssapi_krb5_security_ops);
        if (!NT_STATUS_IS_OK(ret)) {
                DEBUG(0,("Failed to register '%s' gensec backend!\n",