s3-registry: Check return code of push_reg_sz().
[kai/samba.git] / source3 / winbindd / winbindd_pam.c
index 48df304f875f34482655855f3ce4f9b76cbb75de..b23d421fcda1a2fee1fcd2637f68543946980151 100644 (file)
 #include "includes.h"
 #include "winbindd.h"
 #include "../libcli/auth/libcli_auth.h"
-#include "../librpc/gen_ndr/cli_samr.h"
+#include "../librpc/gen_ndr/ndr_samr_c.h"
+#include "rpc_client/cli_pipe.h"
 #include "rpc_client/cli_samr.h"
 #include "../librpc/gen_ndr/ndr_netlogon.h"
 #include "rpc_client/cli_netlogon.h"
 #include "smb_krb5.h"
 #include "../lib/crypto/arcfour.h"
-#include "../libcli/security/dom_sid.h"
+#include "../libcli/security/security.h"
 #include "ads.h"
 #include "../librpc/gen_ndr/krb5pac.h"
+#include "passdb/machine_sid.h"
+#include "auth.h"
+#include "../lib/tsocket/tsocket.h"
+#include "auth/kerberos/pac_utils.h"
+#include "auth/gensec/gensec.h"
+#include "librpc/crypto/gse_krb5.h"
 
 #undef DBGC_CLASS
 #define DBGC_CLASS DBGC_WINBIND
 #define LOGON_KRB5_FAIL_CLOCK_SKEW     0x02000000
 
 static NTSTATUS append_info3_as_txt(TALLOC_CTX *mem_ctx,
-                                   struct winbindd_cli_state *state,
+                                   struct winbindd_response *resp,
                                    struct netr_SamInfo3 *info3)
 {
        char *ex;
        uint32_t i;
 
-       state->response->data.auth.info3.logon_time =
-               nt_time_to_unix(info3->base.last_logon);
-       state->response->data.auth.info3.logoff_time =
-               nt_time_to_unix(info3->base.last_logoff);
-       state->response->data.auth.info3.kickoff_time =
-               nt_time_to_unix(info3->base.acct_expiry);
-       state->response->data.auth.info3.pass_last_set_time =
+       resp->data.auth.info3.logon_time =
+               nt_time_to_unix(info3->base.logon_time);
+       resp->data.auth.info3.logoff_time =
+               nt_time_to_unix(info3->base.logoff_time);
+       resp->data.auth.info3.kickoff_time =
+               nt_time_to_unix(info3->base.kickoff_time);
+       resp->data.auth.info3.pass_last_set_time =
                nt_time_to_unix(info3->base.last_password_change);
-       state->response->data.auth.info3.pass_can_change_time =
+       resp->data.auth.info3.pass_can_change_time =
                nt_time_to_unix(info3->base.allow_password_change);
-       state->response->data.auth.info3.pass_must_change_time =
+       resp->data.auth.info3.pass_must_change_time =
                nt_time_to_unix(info3->base.force_password_change);
 
-       state->response->data.auth.info3.logon_count = info3->base.logon_count;
-       state->response->data.auth.info3.bad_pw_count = info3->base.bad_password_count;
+       resp->data.auth.info3.logon_count = info3->base.logon_count;
+       resp->data.auth.info3.bad_pw_count = info3->base.bad_password_count;
 
-       state->response->data.auth.info3.user_rid = info3->base.rid;
-       state->response->data.auth.info3.group_rid = info3->base.primary_gid;
-       sid_to_fstring(state->response->data.auth.info3.dom_sid, info3->base.domain_sid);
+       resp->data.auth.info3.user_rid = info3->base.rid;
+       resp->data.auth.info3.group_rid = info3->base.primary_gid;
+       sid_to_fstring(resp->data.auth.info3.dom_sid, info3->base.domain_sid);
 
-       state->response->data.auth.info3.num_groups = info3->base.groups.count;
-       state->response->data.auth.info3.user_flgs = info3->base.user_flags;
+       resp->data.auth.info3.num_groups = info3->base.groups.count;
+       resp->data.auth.info3.user_flgs = info3->base.user_flags;
 
-       state->response->data.auth.info3.acct_flags = info3->base.acct_flags;
-       state->response->data.auth.info3.num_other_sids = info3->sidcount;
+       resp->data.auth.info3.acct_flags = info3->base.acct_flags;
+       resp->data.auth.info3.num_other_sids = info3->sidcount;
 
-       fstrcpy(state->response->data.auth.info3.user_name,
+       fstrcpy(resp->data.auth.info3.user_name,
                info3->base.account_name.string);
-       fstrcpy(state->response->data.auth.info3.full_name,
+       fstrcpy(resp->data.auth.info3.full_name,
                info3->base.full_name.string);
-       fstrcpy(state->response->data.auth.info3.logon_script,
+       fstrcpy(resp->data.auth.info3.logon_script,
                info3->base.logon_script.string);
-       fstrcpy(state->response->data.auth.info3.profile_path,
+       fstrcpy(resp->data.auth.info3.profile_path,
                info3->base.profile_path.string);
-       fstrcpy(state->response->data.auth.info3.home_dir,
+       fstrcpy(resp->data.auth.info3.home_dir,
                info3->base.home_directory.string);
-       fstrcpy(state->response->data.auth.info3.dir_drive,
+       fstrcpy(resp->data.auth.info3.dir_drive,
                info3->base.home_drive.string);
 
-       fstrcpy(state->response->data.auth.info3.logon_srv,
+       fstrcpy(resp->data.auth.info3.logon_srv,
                info3->base.logon_server.string);
-       fstrcpy(state->response->data.auth.info3.logon_dom,
-               info3->base.domain.string);
+       fstrcpy(resp->data.auth.info3.logon_dom,
+               info3->base.logon_domain.string);
 
-       ex = talloc_strdup(state->mem_ctx, "");
+       ex = talloc_strdup(mem_ctx, "");
        NT_STATUS_HAVE_NO_MEMORY(ex);
 
        for (i=0; i < info3->base.groups.count; i++) {
@@ -115,14 +122,14 @@ static NTSTATUS append_info3_as_txt(TALLOC_CTX *mem_ctx,
                talloc_free(sid);
        }
 
-       state->response->extra_data.data = ex;
-       state->response->length += talloc_get_size(ex);
+       resp->extra_data.data = ex;
+       resp->length += talloc_get_size(ex);
 
        return NT_STATUS_OK;
 }
 
 static NTSTATUS append_info3_as_ndr(TALLOC_CTX *mem_ctx,
-                                   struct winbindd_cli_state *state,
+                                   struct winbindd_response *resp,
                                    struct netr_SamInfo3 *info3)
 {
        DATA_BLOB blob;
@@ -135,14 +142,14 @@ static NTSTATUS append_info3_as_ndr(TALLOC_CTX *mem_ctx,
                return ndr_map_error2ntstatus(ndr_err);
        }
 
-       state->response->extra_data.data = blob.data;
-       state->response->length += blob.length;
+       resp->extra_data.data = blob.data;
+       resp->length += blob.length;
 
        return NT_STATUS_OK;
 }
 
 static NTSTATUS append_unix_username(TALLOC_CTX *mem_ctx,
-                                    struct winbindd_cli_state *state,
+                                    struct winbindd_response *resp,
                                     const struct netr_SamInfo3 *info3,
                                     const char *name_domain,
                                     const char *name_user)
@@ -152,7 +159,7 @@ static NTSTATUS append_unix_username(TALLOC_CTX *mem_ctx,
 
        const char *nt_username, *nt_domain;
 
-       nt_domain = talloc_strdup(mem_ctx, info3->base.domain.string);
+       nt_domain = talloc_strdup(mem_ctx, info3->base.logon_domain.string);
        if (!nt_domain) {
                /* If the server didn't give us one, just use the one
                 * we sent them */
@@ -166,17 +173,17 @@ static NTSTATUS append_unix_username(TALLOC_CTX *mem_ctx,
                nt_username = name_user;
        }
 
-       fill_domain_username(state->response->data.auth.unix_username,
+       fill_domain_username(resp->data.auth.unix_username,
                             nt_domain, nt_username, true);
 
-       DEBUG(5,("Setting unix username to [%s]\n",
-               state->response->data.auth.unix_username));
+       DEBUG(5, ("Setting unix username to [%s]\n",
+                 resp->data.auth.unix_username));
 
        return NT_STATUS_OK;
 }
 
 static NTSTATUS append_afs_token(TALLOC_CTX *mem_ctx,
-                                struct winbindd_cli_state *state,
+                                struct winbindd_response *resp,
                                 const struct netr_SamInfo3 *info3,
                                 const char *name_domain,
                                 const char *name_user)
@@ -213,7 +220,9 @@ static NTSTATUS append_afs_token(TALLOC_CTX *mem_ctx,
                return NT_STATUS_NO_MEMORY;
        }
 
-       strlower_m(afsname);
+       if (!strlower_m(afsname)) {
+               return NT_STATUS_INVALID_PARAMETER;
+       }
 
        DEBUG(10, ("Generating token for user %s\n", afsname));
 
@@ -230,13 +239,11 @@ static NTSTATUS append_afs_token(TALLOC_CTX *mem_ctx,
        if (token == NULL) {
                return NT_STATUS_OK;
        }
-       state->response->extra_data.data = talloc_strdup(state->mem_ctx,
-                                                        token);
-       if (state->response->extra_data.data == NULL) {
+       resp->extra_data.data = talloc_strdup(mem_ctx, token);
+       if (resp->extra_data.data == NULL) {
                return NT_STATUS_NO_MEMORY;
        }
-       state->response->length +=
-               strlen((const char *)state->response->extra_data.data)+1;
+       resp->length += strlen((const char *)resp->extra_data.data)+1;
 
        return NT_STATUS_OK;
 }
@@ -256,12 +263,12 @@ static NTSTATUS check_info3_in_group(struct netr_SamInfo3 *info3,
  */
 {
        struct dom_sid *require_membership_of_sid;
-       size_t num_require_membership_of_sid;
+       uint32_t num_require_membership_of_sid;
        char *req_sid;
        const char *p;
        struct dom_sid sid;
        size_t i;
-       struct nt_user_token *token;
+       struct security_token *token;
        TALLOC_CTX *frame = talloc_stackframe();
        NTSTATUS status;
 
@@ -269,10 +276,11 @@ static NTSTATUS check_info3_in_group(struct netr_SamInfo3 *info3,
 
        if (!group_sid || !group_sid[0]) {
                /* NO sid supplied, all users may access */
+               TALLOC_FREE(frame);
                return NT_STATUS_OK;
        }
 
-       token = talloc_zero(talloc_tos(), struct nt_user_token);
+       token = talloc_zero(talloc_tos(), struct security_token);
        if (token == NULL) {
                DEBUG(0, ("talloc failed\n"));
                TALLOC_FREE(frame);
@@ -305,7 +313,7 @@ static NTSTATUS check_info3_in_group(struct netr_SamInfo3 *info3,
        status = sid_array_from_info3(talloc_tos(), info3,
                                      &token->sids,
                                      &token->num_sids,
-                                     true, false);
+                                     true);
        if (!NT_STATUS_IS_OK(status)) {
                TALLOC_FREE(frame);
                return status;
@@ -321,7 +329,7 @@ static NTSTATUS check_info3_in_group(struct netr_SamInfo3 *info3,
                return status;
        }
 
-       debug_nt_user_token(DBGC_CLASS, 10, token);
+       security_token_debug(DBGC_CLASS, 10, token);
 
        for (i=0; i<num_require_membership_of_sid; i++) {
                DEBUG(10, ("Checking SID %s\n", sid_string_dbg(
@@ -384,33 +392,37 @@ static void fill_in_password_policy(struct winbindd_response *r,
        r->data.auth.policy.password_properties =
                p->password_properties;
        r->data.auth.policy.expire      =
-               nt_time_to_unix_abs((NTTIME *)&(p->max_password_age));
+               nt_time_to_unix_abs((const NTTIME *)&(p->max_password_age));
        r->data.auth.policy.min_passwordage =
-               nt_time_to_unix_abs((NTTIME *)&(p->min_password_age));
+               nt_time_to_unix_abs((const NTTIME *)&(p->min_password_age));
 }
 
 static NTSTATUS fillup_password_policy(struct winbindd_domain *domain,
-                                      struct winbindd_cli_state *state)
+                                      struct winbindd_response *response)
 {
+       TALLOC_CTX *frame = talloc_stackframe();
        struct winbindd_methods *methods;
-       NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
+       NTSTATUS status;
        struct samr_DomInfo1 password_policy;
 
        if ( !winbindd_can_contact_domain( domain ) ) {
                DEBUG(5,("fillup_password_policy: No inbound trust to "
                         "contact domain %s\n", domain->name));
-               return NT_STATUS_NOT_SUPPORTED;
+               status = NT_STATUS_NOT_SUPPORTED;
+               goto done;
        }
 
        methods = domain->methods;
 
-       status = methods->password_policy(domain, state->mem_ctx, &password_policy);
+       status = methods->password_policy(domain, talloc_tos(), &password_policy);
        if (NT_STATUS_IS_ERR(status)) {
-               return status;
+               goto done;
        }
 
-       fill_in_password_policy(state->response, &password_policy);
+       fill_in_password_policy(response, &password_policy);
 
+done:
+       TALLOC_FREE(frame);
        return NT_STATUS_OK;
 }
 
@@ -463,7 +475,7 @@ static NTSTATUS get_pwd_properties(struct winbindd_domain *domain,
 static const char *generate_krb5_ccache(TALLOC_CTX *mem_ctx,
                                        const char *type,
                                        uid_t uid,
-                                       bool *internal_ccache)
+                                       const char **user_ccache_file)
 {
        /* accept FILE and WRFILE as krb5_cc_type from the client and then
         * build the full ccname string based on the user's uid here -
@@ -471,62 +483,33 @@ static const char *generate_krb5_ccache(TALLOC_CTX *mem_ctx,
 
        const char *gen_cc = NULL;
 
-       *internal_ccache = true;
-
-       if (uid == -1) {
-               goto memory_ccache;
+       if (uid != -1) {
+               if (strequal(type, "FILE")) {
+                       gen_cc = talloc_asprintf(
+                               mem_ctx, "FILE:/tmp/krb5cc_%d", uid);
+               }
+               if (strequal(type, "WRFILE")) {
+                       gen_cc = talloc_asprintf(
+                               mem_ctx, "WRFILE:/tmp/krb5cc_%d", uid);
+               }
        }
 
-       if (!type || type[0] == '\0') {
-               goto memory_ccache;
-       }
+       *user_ccache_file = gen_cc;
 
-       if (strequal(type, "FILE")) {
-               gen_cc = talloc_asprintf(mem_ctx, "FILE:/tmp/krb5cc_%d", uid);
-       } else if (strequal(type, "WRFILE")) {
-               gen_cc = talloc_asprintf(mem_ctx, "WRFILE:/tmp/krb5cc_%d", uid);
-       } else {
-               DEBUG(10,("we don't allow to set a %s type ccache\n", type));
-               goto memory_ccache;
+       if (gen_cc == NULL) {
+               gen_cc = talloc_strdup(mem_ctx, "MEMORY:winbindd_pam_ccache");
        }
-
-       *internal_ccache = false;
-       goto done;
-
-  memory_ccache:
-       gen_cc = talloc_strdup(mem_ctx, "MEMORY:winbindd_pam_ccache");
-
-  done:
        if (gen_cc == NULL) {
                DEBUG(0,("out of memory\n"));
                return NULL;
        }
 
-       DEBUG(10,("using ccache: %s %s\n", gen_cc, *internal_ccache ? "(internal)":""));
+       DEBUG(10, ("using ccache: %s%s\n", gen_cc,
+                  (*user_ccache_file == NULL) ? " (internal)":""));
 
        return gen_cc;
 }
 
-static void setup_return_cc_name(struct winbindd_cli_state *state, const char *cc)
-{
-       const char *type = state->request->data.auth.krb5_cc_type;
-
-       state->response->data.auth.krb5ccname[0] = '\0';
-
-       if (type[0] == '\0') {
-               return;
-       }
-
-       if (!strequal(type, "FILE") &&
-           !strequal(type, "WRFILE")) {
-               DEBUG(10,("won't return krbccname for a %s type ccache\n",
-                       type));
-               return;
-       }
-
-       fstrcpy(state->response->data.auth.krb5ccname, cc);
-}
-
 #endif
 
 uid_t get_uid_from_request(struct winbindd_request *request)
@@ -542,19 +525,19 @@ uid_t get_uid_from_request(struct winbindd_request *request)
        return uid;
 }
 
-static uid_t get_uid_from_state(struct winbindd_cli_state *state)
-{
-       return get_uid_from_request(state->request);
-}
-
 /**********************************************************************
  Authenticate a user with a clear text password using Kerberos and fill up
  ccache if required
  **********************************************************************/
 
-static NTSTATUS winbindd_raw_kerberos_login(struct winbindd_domain *domain,
-                                           struct winbindd_cli_state *state,
-                                           struct netr_SamInfo3 **info3)
+static NTSTATUS winbindd_raw_kerberos_login(TALLOC_CTX *mem_ctx,
+                                           struct winbindd_domain *domain,
+                                           const char *user,
+                                           const char *pass,
+                                           const char *krb5_cc_type,
+                                           uid_t uid,
+                                           struct netr_SamInfo3 **info3,
+                                           fstring krb5ccname)
 {
 #ifdef HAVE_KRB5
        NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
@@ -566,10 +549,9 @@ static NTSTATUS winbindd_raw_kerberos_login(struct winbindd_domain *domain,
        fstring name_domain, name_user;
        time_t ticket_lifetime = 0;
        time_t renewal_until = 0;
-       uid_t uid = -1;
        ADS_STRUCT *ads;
        time_t time_offset = 0;
-       bool internal_ccache = true;
+       const char *user_ccache_file;
        struct PAC_LOGON_INFO *logon_info = NULL;
 
        *info3 = NULL;
@@ -577,15 +559,14 @@ static NTSTATUS winbindd_raw_kerberos_login(struct winbindd_domain *domain,
        /* 1st step:
         * prepare a krb5_cc_cache string for the user */
 
-       uid = get_uid_from_state(state);
        if (uid == -1) {
                DEBUG(0,("no valid uid\n"));
        }
 
-       cc = generate_krb5_ccache(state->mem_ctx,
-                                 state->request->data.auth.krb5_cc_type,
-                                 state->request->data.auth.uid,
-                                 &internal_ccache);
+       cc = generate_krb5_ccache(mem_ctx,
+                                 krb5_cc_type,
+                                 uid,
+                                 &user_ccache_file);
        if (cc == NULL) {
                return NT_STATUS_NO_MEMORY;
        }
@@ -603,17 +584,19 @@ static NTSTATUS winbindd_raw_kerberos_login(struct winbindd_domain *domain,
        /* 3rd step:
         * do kerberos auth and setup ccache as the user */
 
-       parse_domain_user(state->request->data.auth.user, name_domain, name_user);
+       parse_domain_user(user, name_domain, name_user);
 
        realm = domain->alt_name;
-       strupper_m(realm);
+       if (!strupper_m(realm)) {
+               return NT_STATUS_INVALID_PARAMETER;
+       }
 
-       principal_s = talloc_asprintf(state->mem_ctx, "%s@%s", name_user, realm);
+       principal_s = talloc_asprintf(mem_ctx, "%s@%s", name_user, realm);
        if (principal_s == NULL) {
                return NT_STATUS_NO_MEMORY;
        }
 
-       service = talloc_asprintf(state->mem_ctx, "%s/%s@%s", KRB5_TGS_NAME, realm, realm);
+       service = talloc_asprintf(mem_ctx, "%s/%s@%s", KRB5_TGS_NAME, realm, realm);
        if (service == NULL) {
                return NT_STATUS_NO_MEMORY;
        }
@@ -623,14 +606,14 @@ static NTSTATUS winbindd_raw_kerberos_login(struct winbindd_domain *domain,
 
        /************************ ENTERING NON-ROOT **********************/
 
-       if (!internal_ccache) {
+       if (user_ccache_file != NULL) {
                set_effective_uid(uid);
                DEBUG(10,("winbindd_raw_kerberos_login: uid is %d\n", uid));
        }
 
-       result = kerberos_return_pac(state->mem_ctx,
+       result = kerberos_return_pac(mem_ctx,
                                     principal_s,
-                                    state->request->data.auth.pass,
+                                    pass,
                                     time_offset,
                                     &ticket_lifetime,
                                     &renewal_until,
@@ -640,7 +623,7 @@ static NTSTATUS winbindd_raw_kerberos_login(struct winbindd_domain *domain,
                                     WINBINDD_PAM_AUTH_KRB5_RENEW_TIME,
                                     NULL,
                                     &logon_info);
-       if (!internal_ccache) {
+       if (user_ccache_file != NULL) {
                gain_root_privilege();
        }
 
@@ -658,14 +641,15 @@ static NTSTATUS winbindd_raw_kerberos_login(struct winbindd_domain *domain,
        /* if we had a user's ccache then return that string for the pam
         * environment */
 
-       if (!internal_ccache) {
+       if (user_ccache_file != NULL) {
 
-               setup_return_cc_name(state, cc);
+               fstrcpy(krb5ccname, user_ccache_file);
 
                result = add_ccache_to_list(principal_s,
                                            cc,
                                            service,
-                                           state->request->data.auth.user,
+                                           user,
+                                           pass,
                                            realm,
                                            uid,
                                            time(NULL),
@@ -706,10 +690,10 @@ failed:
                         "%s\n", error_message(krb5_ret)));
        }
 
-       if (!NT_STATUS_IS_OK(remove_ccache(state->request->data.auth.user))) {
+       if (!NT_STATUS_IS_OK(remove_ccache(user))) {
                DEBUG(3,("winbindd_raw_kerberos_login: "
                          "could not remove ccache for user %s\n",
-                       state->request->data.auth.user));
+                       user));
        }
 
        return result;
@@ -743,31 +727,32 @@ bool check_request_flags(uint32_t flags)
 /****************************************************************
 ****************************************************************/
 
-static NTSTATUS append_auth_data(struct winbindd_cli_state *state,
-                                struct netr_SamInfo3 *info3,
-                                const char *name_domain,
-                                const char *name_user)
+NTSTATUS append_auth_data(TALLOC_CTX *mem_ctx,
+                         struct winbindd_response *resp,
+                         uint32_t request_flags,
+                         struct netr_SamInfo3 *info3,
+                         const char *name_domain,
+                         const char *name_user)
 {
        NTSTATUS result;
-       uint32_t flags = state->request->flags;
 
-       if (flags & WBFLAG_PAM_USER_SESSION_KEY) {
-               memcpy(state->response->data.auth.user_session_key,
+       if (request_flags & WBFLAG_PAM_USER_SESSION_KEY) {
+               memcpy(resp->data.auth.user_session_key,
                       info3->base.key.key,
-                      sizeof(state->response->data.auth.user_session_key)
+                      sizeof(resp->data.auth.user_session_key)
                       /* 16 */);
        }
 
-       if (flags & WBFLAG_PAM_LMKEY) {
-               memcpy(state->response->data.auth.first_8_lm_hash,
+       if (request_flags & WBFLAG_PAM_LMKEY) {
+               memcpy(resp->data.auth.first_8_lm_hash,
                       info3->base.LMSessKey.key,
-                      sizeof(state->response->data.auth.first_8_lm_hash)
+                      sizeof(resp->data.auth.first_8_lm_hash)
                       /* 8 */);
        }
 
-       if (flags & WBFLAG_PAM_UNIX_NAME) {
-               result = append_unix_username(state->mem_ctx, state, info3,
-                                             name_domain, name_user);
+       if (request_flags & WBFLAG_PAM_UNIX_NAME) {
+               result = append_unix_username(mem_ctx, resp,
+                                             info3, name_domain, name_user);
                if (!NT_STATUS_IS_OK(result)) {
                        DEBUG(10,("Failed to append Unix Username: %s\n",
                                nt_errstr(result)));
@@ -777,8 +762,8 @@ static NTSTATUS append_auth_data(struct winbindd_cli_state *state,
 
        /* currently, anything from here on potentially overwrites extra_data. */
 
-       if (flags & WBFLAG_PAM_INFO3_NDR) {
-               result = append_info3_as_ndr(state->mem_ctx, state, info3);
+       if (request_flags & WBFLAG_PAM_INFO3_NDR) {
+               result = append_info3_as_ndr(mem_ctx, resp, info3);
                if (!NT_STATUS_IS_OK(result)) {
                        DEBUG(10,("Failed to append INFO3 (NDR): %s\n",
                                nt_errstr(result)));
@@ -786,8 +771,8 @@ static NTSTATUS append_auth_data(struct winbindd_cli_state *state,
                }
        }
 
-       if (flags & WBFLAG_PAM_INFO3_TEXT) {
-               result = append_info3_as_txt(state->mem_ctx, state, info3);
+       if (request_flags & WBFLAG_PAM_INFO3_TEXT) {
+               result = append_info3_as_txt(mem_ctx, resp, info3);
                if (!NT_STATUS_IS_OK(result)) {
                        DEBUG(10,("Failed to append INFO3 (TXT): %s\n",
                                nt_errstr(result)));
@@ -795,9 +780,9 @@ static NTSTATUS append_auth_data(struct winbindd_cli_state *state,
                }
        }
 
-       if (flags & WBFLAG_PAM_AFS_TOKEN) {
-               result = append_afs_token(state->mem_ctx, state, info3,
-                                         name_domain, name_user);
+       if (request_flags & WBFLAG_PAM_AFS_TOKEN) {
+               result = append_afs_token(mem_ctx, resp,
+                                         info3, name_domain, name_user);
                if (!NT_STATUS_IS_OK(result)) {
                        DEBUG(10,("Failed to append AFS token: %s\n",
                                nt_errstr(result)));
@@ -838,8 +823,7 @@ static NTSTATUS winbindd_dual_pam_auth_cached(struct winbindd_domain *domain,
        parse_domain_user(state->request->data.auth.user, name_domain, name_user);
 
 
-       if (!lookup_cached_name(state->mem_ctx,
-                               name_domain,
+       if (!lookup_cached_name(name_domain,
                                name_user,
                                &sid,
                                &type)) {
@@ -920,7 +904,7 @@ static NTSTATUS winbindd_dual_pam_auth_cached(struct winbindd_domain *domain,
                        return NT_STATUS_LOGON_FAILURE;
                }
 
-               kickoff_time = nt_time_to_unix(my_info3->base.acct_expiry);
+               kickoff_time = nt_time_to_unix(my_info3->base.kickoff_time);
                if (kickoff_time != 0 && time(NULL) > kickoff_time) {
                        return NT_STATUS_ACCOUNT_EXPIRED;
                }
@@ -945,9 +929,9 @@ static NTSTATUS winbindd_dual_pam_auth_cached(struct winbindd_domain *domain,
                        char *realm = NULL;
                        const char *principal_s = NULL;
                        const char *service = NULL;
-                       bool internal_ccache = false;
+                       const char *user_ccache_file;
 
-                       uid = get_uid_from_state(state);
+                       uid = get_uid_from_request(state->request);
                        if (uid == -1) {
                                DEBUG(0,("winbindd_dual_pam_auth_cached: invalid uid\n"));
                                return NT_STATUS_INVALID_PARAMETER;
@@ -956,13 +940,15 @@ static NTSTATUS winbindd_dual_pam_auth_cached(struct winbindd_domain *domain,
                        cc = generate_krb5_ccache(state->mem_ctx,
                                                state->request->data.auth.krb5_cc_type,
                                                state->request->data.auth.uid,
-                                               &internal_ccache);
+                                               &user_ccache_file);
                        if (cc == NULL) {
                                return NT_STATUS_NO_MEMORY;
                        }
 
                        realm = domain->alt_name;
-                       strupper_m(realm);
+                       if (!strupper_m(realm)) {
+                               return NT_STATUS_INVALID_PARAMETER;
+                       }
 
                        principal_s = talloc_asprintf(state->mem_ctx, "%s@%s", name_user, realm);
                        if (principal_s == NULL) {
@@ -974,14 +960,16 @@ static NTSTATUS winbindd_dual_pam_auth_cached(struct winbindd_domain *domain,
                                return NT_STATUS_NO_MEMORY;
                        }
 
-                       if (!internal_ccache) {
+                       if (user_ccache_file != NULL) {
 
-                               setup_return_cc_name(state, cc);
+                               fstrcpy(state->response->data.auth.krb5ccname,
+                                       user_ccache_file);
 
                                result = add_ccache_to_list(principal_s,
                                                            cc,
                                                            service,
                                                            state->request->data.auth.user,
+                                                           state->request->data.auth.pass,
                                                            domain->alt_name,
                                                            uid,
                                                            time(NULL),
@@ -1001,11 +989,10 @@ static NTSTATUS winbindd_dual_pam_auth_cached(struct winbindd_domain *domain,
                /* FIXME: we possibly should handle logon hours as well (does xp when
                 * offline?) see auth/auth_sam.c:sam_account_ok for details */
 
-               unix_to_nt_time(&my_info3->base.last_logon, time(NULL));
+               unix_to_nt_time(&my_info3->base.logon_time, time(NULL));
                my_info3->base.bad_password_count = 0;
 
                result = winbindd_update_creds_by_info3(domain,
-                                                       state->mem_ctx,
                                                        state->request->data.auth.user,
                                                        state->request->data.auth.pass,
                                                        my_info3);
@@ -1019,7 +1006,10 @@ static NTSTATUS winbindd_dual_pam_auth_cached(struct winbindd_domain *domain,
 
        }
 
-       /* User does *NOT* know the correct password, modify info3 accordingly */
+       /* User does *NOT* know the correct password, modify info3 accordingly, but only if online */
+       if (domain->online == false) {
+               goto failed;
+       }
 
        /* failure of this is not critical */
        result = get_max_bad_attempts_from_lockout_policy(domain, state->mem_ctx, &max_allowed_bad_attempts);
@@ -1053,7 +1043,6 @@ static NTSTATUS winbindd_dual_pam_auth_cached(struct winbindd_domain *domain,
 
 failed:
        result = winbindd_update_creds_by_info3(domain,
-                                               state->mem_ctx,
                                                state->request->data.auth.user,
                                                NULL,
                                                my_info3);
@@ -1102,7 +1091,8 @@ static NTSTATUS winbindd_dual_pam_auth_kerberos(struct winbindd_domain *domain,
                        DEBUG(3, ("Authentication for domain for [%s] -> [%s]\\[%s] failed as %s is not a trusted domain\n",
                                  state->request->data.auth.user, name_domain, name_user, name_domain));
 
-                       contact_domain = find_our_domain();
+                       result =  NT_STATUS_NO_SUCH_USER;
+                       goto done;
                }
        }
 
@@ -1120,12 +1110,19 @@ static NTSTATUS winbindd_dual_pam_auth_kerberos(struct winbindd_domain *domain,
                return NT_STATUS_INVALID_LOGON_TYPE;
        }
 try_login:
-       result = winbindd_raw_kerberos_login(contact_domain, state, info3);
+       result = winbindd_raw_kerberos_login(
+               state->mem_ctx, contact_domain,
+               state->request->data.auth.user,
+               state->request->data.auth.pass,
+               state->request->data.auth.krb5_cc_type,
+               get_uid_from_request(state->request),
+               info3, state->response->data.auth.krb5ccname);
 done:
        return result;
 }
 
 static NTSTATUS winbindd_dual_auth_passdb(TALLOC_CTX *mem_ctx,
+                                         uint32_t logon_parameters,
                                          const char *domain, const char *user,
                                          const DATA_BLOB *challenge,
                                          const DATA_BLOB *lm_resp,
@@ -1133,15 +1130,26 @@ static NTSTATUS winbindd_dual_auth_passdb(TALLOC_CTX *mem_ctx,
                                          struct netr_SamInfo3 **pinfo3)
 {
        struct auth_usersupplied_info *user_info = NULL;
+       struct tsocket_address *local;
        NTSTATUS status;
-
+       int rc;
+
+       rc = tsocket_address_inet_from_strings(mem_ctx,
+                                              "ip",
+                                              "127.0.0.1",
+                                              0,
+                                              &local);
+       if (rc < 0) {
+               return NT_STATUS_NO_MEMORY;
+       }
        status = make_user_info(&user_info, user, user, domain, domain,
-                               global_myname(), lm_resp, nt_resp, NULL, NULL,
+                               lp_netbios_name(), local, lm_resp, nt_resp, NULL, NULL,
                                NULL, AUTH_PASSWORD_RESPONSE);
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(10, ("make_user_info failed: %s\n", nt_errstr(status)));
                return status;
        }
+       user_info->logon_parameters = logon_parameters;
 
        /* We don't want any more mapping of the username */
        user_info->mapped_state = True;
@@ -1149,126 +1157,83 @@ static NTSTATUS winbindd_dual_auth_passdb(TALLOC_CTX *mem_ctx,
        status = check_sam_security_info3(challenge, talloc_tos(), user_info,
                                          pinfo3);
        free_user_info(&user_info);
-       DEBUG(10, ("Authenticated user %s\\%s successfully\n", domain, user));
-       return NT_STATUS_OK;
+       DEBUG(10, ("Authenticaticating user %s\\%s returned %s\n", domain,
+                  user, nt_errstr(status)));
+       return status;
 }
 
-typedef        NTSTATUS (*netlogon_fn_t)(struct rpc_pipe_client *cli,
-                                 TALLOC_CTX *mem_ctx,
-                                 uint32 logon_parameters,
-                                 const char *server,
-                                 const char *username,
-                                 const char *domain,
-                                 const char *workstation,
-                                 const uint8 chal[8],
-                                 DATA_BLOB lm_response,
-                                 DATA_BLOB nt_response,
-                                 struct netr_SamInfo3 **info3);
-
-static NTSTATUS winbindd_dual_pam_auth_samlogon(struct winbindd_domain *domain,
-                                               struct winbindd_cli_state *state,
-                                               struct netr_SamInfo3 **info3)
+static NTSTATUS winbind_samlogon_retry_loop(struct winbindd_domain *domain,
+                                           TALLOC_CTX *mem_ctx,
+                                           uint32_t logon_parameters,
+                                           const char *server,
+                                           const char *username,
+                                           const char *domainname,
+                                           const char *workstation,
+                                           const uint8_t chal[8],
+                                           DATA_BLOB lm_response,
+                                           DATA_BLOB nt_response,
+                                           struct netr_SamInfo3 **info3)
 {
-
-       struct rpc_pipe_client *netlogon_pipe;
-       uchar chal[8];
-       DATA_BLOB lm_resp;
-       DATA_BLOB nt_resp;
        int attempts = 0;
-       unsigned char local_lm_response[24];
-       unsigned char local_nt_response[24];
-       fstring name_domain, name_user;
-       bool retry;
+       int netr_attempts = 0;
+       bool retry = false;
        NTSTATUS result;
-       struct netr_SamInfo3 *my_info3 = NULL;
-
-       *info3 = NULL;
-
-       DEBUG(10,("winbindd_dual_pam_auth_samlogon\n"));
-
-       /* Parse domain and username */
-
-       parse_domain_user(state->request->data.auth.user, name_domain, name_user);
-
-       /* do password magic */
-
-       generate_random_buffer(chal, sizeof(chal));
-
-       if (lp_client_ntlmv2_auth()) {
-               DATA_BLOB server_chal;
-               DATA_BLOB names_blob;
-               DATA_BLOB nt_response;
-               DATA_BLOB lm_response;
-               server_chal = data_blob_talloc(state->mem_ctx, chal, 8);
-
-               /* note that the 'workgroup' here is a best guess - we don't know
-                  the server's domain at this point.  The 'server name' is also
-                  dodgy...
-               */
-               names_blob = NTLMv2_generate_names_blob(state->mem_ctx, global_myname(), lp_workgroup());
-
-               if (!SMBNTLMv2encrypt(NULL, name_user, name_domain,
-                                     state->request->data.auth.pass,
-                                     &server_chal,
-                                     &names_blob,
-                                     &lm_response, &nt_response, NULL, NULL)) {
-                       data_blob_free(&names_blob);
-                       data_blob_free(&server_chal);
-                       DEBUG(0, ("winbindd_pam_auth: SMBNTLMv2encrypt() failed!\n"));
-                       result = NT_STATUS_NO_MEMORY;
-                       goto done;
-               }
-               data_blob_free(&names_blob);
-               data_blob_free(&server_chal);
-               lm_resp = data_blob_talloc(state->mem_ctx, lm_response.data,
-                                          lm_response.length);
-               nt_resp = data_blob_talloc(state->mem_ctx, nt_response.data,
-                                          nt_response.length);
-               data_blob_free(&lm_response);
-               data_blob_free(&nt_response);
-
-       } else {
-               if (lp_client_lanman_auth()
-                   && SMBencrypt(state->request->data.auth.pass,
-                                 chal,
-                                 local_lm_response)) {
-                       lm_resp = data_blob_talloc(state->mem_ctx,
-                                                  local_lm_response,
-                                                  sizeof(local_lm_response));
-               } else {
-                       lm_resp = data_blob_null;
-               }
-               SMBNTencrypt(state->request->data.auth.pass,
-                            chal,
-                            local_nt_response);
-
-               nt_resp = data_blob_talloc(state->mem_ctx,
-                                          local_nt_response,
-                                          sizeof(local_nt_response));
-       }
-
-       if (strequal(name_domain, get_global_sam_name())) {
-               DATA_BLOB chal_blob = data_blob_const(chal, sizeof(chal));
-
-               result = winbindd_dual_auth_passdb(
-                       state->mem_ctx, name_domain, name_user,
-                       &chal_blob, &lm_resp, &nt_resp, info3);
-               goto done;
-       }
-
-       /* check authentication loop */
 
        do {
-               netlogon_fn_t logon_fn;
+               struct rpc_pipe_client *netlogon_pipe;
+               const struct pipe_auth_data *auth;
+               uint32_t neg_flags = 0;
 
-               ZERO_STRUCTP(my_info3);
+               ZERO_STRUCTP(info3);
                retry = false;
 
                result = cm_connect_netlogon(domain, &netlogon_pipe);
 
                if (!NT_STATUS_IS_OK(result)) {
-                       DEBUG(3, ("could not open handle to NETLOGON pipe\n"));
-                       goto done;
+                       DEBUG(3,("Could not open handle to NETLOGON pipe "
+                                "(error: %s, attempts: %d)\n",
+                                 nt_errstr(result), netr_attempts));
+
+                       /* After the first retry always close the connection */
+                       if (netr_attempts > 0) {
+                               DEBUG(3, ("This is again a problem for this "
+                                         "particular call, forcing the close "
+                                         "of this connection\n"));
+                               invalidate_cm_connection(&domain->conn);
+                       }
+
+                       /* After the second retry failover to the next DC */
+                       if (netr_attempts > 1) {
+                               /*
+                                * If the netlogon server is not reachable then
+                                * it is possible that the DC is rebuilding
+                                * sysvol and shutdown netlogon for that time.
+                                * We should failover to the next dc.
+                                */
+                               DEBUG(3, ("This is the third problem for this "
+                                         "particular call, adding DC to the "
+                                         "negative cache list\n"));
+                               add_failed_connection_entry(domain->name,
+                                                           domain->dcname,
+                                                           result);
+                               saf_delete(domain->name);
+                       }
+
+                       /* Only allow 3 retries */
+                       if (netr_attempts < 3) {
+                               DEBUG(3, ("The connection to netlogon "
+                                         "failed, retrying\n"));
+                               netr_attempts++;
+                               retry = true;
+                               continue;
+                       }
+                       return result;
+               }
+               netr_attempts = 0;
+
+               auth = netlogon_pipe->auth;
+               if (netlogon_pipe->dc) {
+                       neg_flags = netlogon_pipe->dc->negotiate_flags;
                }
 
                /* It is really important to try SamLogonEx here,
@@ -1290,34 +1255,108 @@ static NTSTATUS winbindd_dual_pam_auth_samlogon(struct winbindd_domain *domain,
                 * wrapping SamLogon context.
                 *
                 *  -- abartlet 21 April 2008
+                *
+                * It's also important to use NetlogonValidationSamInfo4 (6),
+                * because it relies on the rpc transport encryption
+                * and avoids using the global netlogon schannel
+                * session key to en/decrypt secret information
+                * like the user_session_key for network logons.
+                *
+                * [MS-APDS] 3.1.5.2 NTLM Network Logon
+                * says NETLOGON_NEG_CROSS_FOREST_TRUSTS and
+                * NETLOGON_NEG_AUTHENTICATED_RPC set together
+                * are the indication that the server supports
+                * NetlogonValidationSamInfo4 (6). And it must only
+                * be used if "SealSecureChannel" is used.
+                *
+                * -- metze 4 February 2011
                 */
 
-               logon_fn = domain->can_do_samlogon_ex
-                       ? rpccli_netlogon_sam_network_logon_ex
-                       : rpccli_netlogon_sam_network_logon;
-
-               result = logon_fn(netlogon_pipe,
-                                 state->mem_ctx,
-                                 0,
-                                 domain->dcname,         /* server name */
-                                 name_user,              /* user name */
-                                 name_domain,            /* target domain */
-                                 global_myname(),        /* workstation */
-                                 chal,
-                                 lm_resp,
-                                 nt_resp,
-                                 &my_info3);
-               attempts += 1;
+               if (auth == NULL) {
+                       domain->can_do_validation6 = false;
+               } else if (auth->auth_type != DCERPC_AUTH_TYPE_SCHANNEL) {
+                       domain->can_do_validation6 = false;
+               } else if (auth->auth_level != DCERPC_AUTH_LEVEL_PRIVACY) {
+                       domain->can_do_validation6 = false;
+               } else if (!(neg_flags & NETLOGON_NEG_CROSS_FOREST_TRUSTS)) {
+                       domain->can_do_validation6 = false;
+               } else if (!(neg_flags & NETLOGON_NEG_AUTHENTICATED_RPC)) {
+                       domain->can_do_validation6 = false;
+               }
+
+               if (domain->can_do_samlogon_ex && domain->can_do_validation6) {
+                       result = rpccli_netlogon_sam_network_logon_ex(
+                                       netlogon_pipe,
+                                       mem_ctx,
+                                       logon_parameters,
+                                       server,         /* server name */
+                                       username,       /* user name */
+                                       domainname,     /* target domain */
+                                       workstation,    /* workstation */
+                                       chal,
+                                       6,
+                                       lm_response,
+                                       nt_response,
+                                       info3);
+               } else {
+                       result = rpccli_netlogon_sam_network_logon(
+                                       netlogon_pipe,
+                                       mem_ctx,
+                                       logon_parameters,
+                                       server,         /* server name */
+                                       username,       /* user name */
+                                       domainname,     /* target domain */
+                                       workstation,    /* workstation */
+                                       chal,
+                                       domain->can_do_validation6 ? 6 : 3,
+                                       lm_response,
+                                       nt_response,
+                                       info3);
+               }
+
+               if (NT_STATUS_EQUAL(result, NT_STATUS_RPC_PROCNUM_OUT_OF_RANGE)) {
 
-               if ((NT_STATUS_V(result) == DCERPC_FAULT_OP_RNG_ERROR)
-                   && domain->can_do_samlogon_ex) {
-                       DEBUG(3, ("Got a DC that can not do NetSamLogonEx, "
-                                 "retrying with NetSamLogon\n"));
-                       domain->can_do_samlogon_ex = false;
+                       /*
+                        * It's likely that the server also does not support
+                        * validation level 6
+                        */
+                       domain->can_do_validation6 = false;
+
+                       if (domain->can_do_samlogon_ex) {
+                               DEBUG(3, ("Got a DC that can not do NetSamLogonEx, "
+                                         "retrying with NetSamLogon\n"));
+                               domain->can_do_samlogon_ex = false;
+                               retry = true;
+                               continue;
+                       }
+
+
+                       /* Got DCERPC_FAULT_OP_RNG_ERROR for SamLogon
+                        * (no Ex). This happens against old Samba
+                        * DCs. Drop the connection.
+                        */
+                       invalidate_cm_connection(&domain->conn);
+                       result = NT_STATUS_LOGON_FAILURE;
+                       break;
+               }
+
+               if (domain->can_do_validation6 &&
+                   (NT_STATUS_EQUAL(result, NT_STATUS_INVALID_INFO_CLASS) ||
+                    NT_STATUS_EQUAL(result, NT_STATUS_INVALID_PARAMETER) ||
+                    NT_STATUS_EQUAL(result, NT_STATUS_BUFFER_TOO_SMALL))) {
+                       DEBUG(3,("Got a DC that can not do validation level 6, "
+                                 "retrying with level 3\n"));
+                       domain->can_do_validation6 = false;
                        retry = true;
                        continue;
                }
 
+               /*
+                * we increment this after the "feature negotiation"
+                * for can_do_samlogon_ex and can_do_validation6
+                */
+               attempts += 1;
+
                /* We have to try a second time as cm_connect_netlogon
                   might not yet have noticed that the DC has killed
                   our connection. */
@@ -1333,31 +1372,127 @@ static NTSTATUS winbindd_dual_pam_auth_samlogon(struct winbindd_domain *domain,
                   rpc changetrustpw' */
 
                if ( NT_STATUS_EQUAL(result, NT_STATUS_ACCESS_DENIED) ) {
-                       DEBUG(3,("winbindd_pam_auth: sam_logon returned "
+                       DEBUG(3,("winbind_samlogon_retry_loop: sam_logon returned "
                                 "ACCESS_DENIED.  Maybe the trust account "
                                "password was changed and we didn't know it. "
                                 "Killing connections to domain %s\n",
-                               name_domain));
+                               domainname));
                        invalidate_cm_connection(&domain->conn);
                        retry = true;
                }
 
        } while ( (attempts < 2) && retry );
 
+       if (NT_STATUS_EQUAL(result, NT_STATUS_IO_TIMEOUT)) {
+               DEBUG(3,("winbind_samlogon_retry_loop: sam_network_logon(ex) "
+                               "returned NT_STATUS_IO_TIMEOUT after the retry."
+                               "Killing connections to domain %s\n",
+                       domainname));
+               invalidate_cm_connection(&domain->conn);
+       }
+       return result;
+}
+
+static NTSTATUS winbindd_dual_pam_auth_samlogon(TALLOC_CTX *mem_ctx,
+                                               struct winbindd_domain *domain,
+                                               const char *user,
+                                               const char *pass,
+                                               uint32_t request_flags,
+                                               struct netr_SamInfo3 **info3)
+{
+
+       uchar chal[8];
+       DATA_BLOB lm_resp;
+       DATA_BLOB nt_resp;
+       unsigned char local_nt_response[24];
+       fstring name_domain, name_user;
+       NTSTATUS result;
+       struct netr_SamInfo3 *my_info3 = NULL;
+
+       *info3 = NULL;
+
+       DEBUG(10,("winbindd_dual_pam_auth_samlogon\n"));
+
+       /* Parse domain and username */
+
+       parse_domain_user(user, name_domain, name_user);
+
+       /* do password magic */
+
+       generate_random_buffer(chal, sizeof(chal));
+
+       if (lp_client_ntlmv2_auth()) {
+               DATA_BLOB server_chal;
+               DATA_BLOB names_blob;
+               server_chal = data_blob_const(chal, 8);
+
+               /* note that the 'workgroup' here is for the local
+                  machine.  The 'server name' must match the
+                  'workstation' passed to the actual SamLogon call.
+               */
+               names_blob = NTLMv2_generate_names_blob(
+                       mem_ctx, lp_netbios_name(), lp_workgroup());
+
+               if (!SMBNTLMv2encrypt(mem_ctx, name_user, name_domain,
+                                     pass,
+                                     &server_chal,
+                                     &names_blob,
+                                     &lm_resp, &nt_resp, NULL, NULL)) {
+                       data_blob_free(&names_blob);
+                       DEBUG(0, ("winbindd_pam_auth: SMBNTLMv2encrypt() failed!\n"));
+                       result = NT_STATUS_NO_MEMORY;
+                       goto done;
+               }
+               data_blob_free(&names_blob);
+       } else {
+               lm_resp = data_blob_null;
+               SMBNTencrypt(pass, chal, local_nt_response);
+
+               nt_resp = data_blob_talloc(mem_ctx, local_nt_response,
+                                          sizeof(local_nt_response));
+       }
+
+       if (strequal(name_domain, get_global_sam_name())) {
+               DATA_BLOB chal_blob = data_blob_const(chal, sizeof(chal));
+
+               result = winbindd_dual_auth_passdb(
+                       mem_ctx, 0, name_domain, name_user,
+                       &chal_blob, &lm_resp, &nt_resp, info3);
+               goto done;
+       }
+
+       /* check authentication loop */
+
+       result = winbind_samlogon_retry_loop(domain,
+                                            mem_ctx,
+                                            0,
+                                            domain->dcname,
+                                            name_user,
+                                            name_domain,
+                                            lp_netbios_name(),
+                                            chal,
+                                            lm_resp,
+                                            nt_resp,
+                                            &my_info3);
+       if (!NT_STATUS_IS_OK(result)) {
+               goto done;
+       }
+
        /* handle the case where a NT4 DC does not fill in the acct_flags in
         * the samlogon reply info3. When accurate info3 is required by the
         * caller, we look up the account flags ourselve - gd */
 
-       if ((state->request->flags & WBFLAG_PAM_INFO3_TEXT) &&
+       if ((request_flags & WBFLAG_PAM_INFO3_TEXT) &&
            NT_STATUS_IS_OK(result) && (my_info3->base.acct_flags == 0)) {
 
                struct rpc_pipe_client *samr_pipe;
                struct policy_handle samr_domain_handle, user_pol;
                union samr_UserInfo *info = NULL;
-               NTSTATUS status_tmp;
+               NTSTATUS status_tmp, result_tmp;
                uint32 acct_flags;
+               struct dcerpc_binding_handle *b;
 
-               status_tmp = cm_connect_sam(domain, state->mem_ctx,
+               status_tmp = cm_connect_sam(domain, mem_ctx,
                                            &samr_pipe, &samr_domain_handle);
 
                if (!NT_STATUS_IS_OK(status_tmp)) {
@@ -1366,34 +1501,49 @@ static NTSTATUS winbindd_dual_pam_auth_samlogon(struct winbindd_domain *domain,
                        goto done;
                }
 
-               status_tmp = rpccli_samr_OpenUser(samr_pipe, state->mem_ctx,
+               b = samr_pipe->binding_handle;
+
+               status_tmp = dcerpc_samr_OpenUser(b, mem_ctx,
                                                  &samr_domain_handle,
                                                  MAXIMUM_ALLOWED_ACCESS,
                                                  my_info3->base.rid,
-                                                 &user_pol);
+                                                 &user_pol,
+                                                 &result_tmp);
 
                if (!NT_STATUS_IS_OK(status_tmp)) {
                        DEBUG(3, ("could not open user handle on SAMR pipe: %s\n",
                                nt_errstr(status_tmp)));
                        goto done;
                }
+               if (!NT_STATUS_IS_OK(result_tmp)) {
+                       DEBUG(3, ("could not open user handle on SAMR pipe: %s\n",
+                               nt_errstr(result_tmp)));
+                       goto done;
+               }
 
-               status_tmp = rpccli_samr_QueryUserInfo(samr_pipe, state->mem_ctx,
+               status_tmp = dcerpc_samr_QueryUserInfo(b, mem_ctx,
                                                       &user_pol,
                                                       16,
-                                                      &info);
+                                                      &info,
+                                                      &result_tmp);
 
                if (!NT_STATUS_IS_OK(status_tmp)) {
                        DEBUG(3, ("could not query user info on SAMR pipe: %s\n",
                                nt_errstr(status_tmp)));
-                       rpccli_samr_Close(samr_pipe, state->mem_ctx, &user_pol);
+                       dcerpc_samr_Close(b, mem_ctx, &user_pol, &result_tmp);
+                       goto done;
+               }
+               if (!NT_STATUS_IS_OK(result_tmp)) {
+                       DEBUG(3, ("could not query user info on SAMR pipe: %s\n",
+                               nt_errstr(result_tmp)));
+                       dcerpc_samr_Close(b, mem_ctx, &user_pol, &result_tmp);
                        goto done;
                }
 
                acct_flags = info->info16.acct_flags;
 
                if (acct_flags == 0) {
-                       rpccli_samr_Close(samr_pipe, state->mem_ctx, &user_pol);
+                       dcerpc_samr_Close(b, mem_ctx, &user_pol, &result_tmp);
                        goto done;
                }
 
@@ -1401,7 +1551,7 @@ static NTSTATUS winbindd_dual_pam_auth_samlogon(struct winbindd_domain *domain,
 
                DEBUG(10,("successfully retrieved acct_flags 0x%x\n", acct_flags));
 
-               rpccli_samr_Close(samr_pipe, state->mem_ctx, &user_pol);
+               dcerpc_samr_Close(b, mem_ctx, &user_pol, &result_tmp);
        }
 
        *info3 = my_info3;
@@ -1450,8 +1600,8 @@ enum winbindd_result winbindd_dual_pam_auth(struct winbindd_domain *domain,
                fstr_sprintf( domain_user, "%s%c%s", name_domain,
                        *lp_winbind_separator(),
                        name_user );
-               safe_strcpy( state->request->data.auth.user, domain_user,
-                            sizeof(state->request->data.auth.user)-1 );
+               strlcpy( state->request->data.auth.user, domain_user,
+                            sizeof(state->request->data.auth.user));
        }
 
        if (!domain->online) {
@@ -1522,7 +1672,12 @@ enum winbindd_result winbindd_dual_pam_auth(struct winbindd_domain *domain,
 sam_logon:
        /* Check for Samlogon authentication */
        if (domain->online) {
-               result = winbindd_dual_pam_auth_samlogon(domain, state, &info3);
+               result = winbindd_dual_pam_auth_samlogon(
+                       state->mem_ctx, domain,
+                       state->request->data.auth.user,
+                       state->request->data.auth.pass,
+                       state->request->flags,
+                       &info3);
 
                if (NT_STATUS_IS_OK(result)) {
                        DEBUG(10,("winbindd_dual_pam_auth_samlogon succeeded\n"));
@@ -1580,7 +1735,11 @@ process_result:
                        goto done;
                }
 
-               wcache_invalidate_samlogon(find_domain_from_name(name_domain), info3);
+               sid_compose(&user_sid, info3->base.domain_sid,
+                           info3->base.rid);
+
+               wcache_invalidate_samlogon(find_domain_from_name(name_domain),
+                                          &user_sid);
                netsamlogon_cache_store(name_user, info3);
 
                /* save name_to_sid info as early as possible (only if
@@ -1588,8 +1747,6 @@ process_result:
                   the cache entry by storing the seq_num for the wrong
                   domain). */
                if ( domain->primary ) {
-                       sid_compose(&user_sid, info3->base.domain_sid,
-                                   info3->base.rid);
                        cache_name2sid(domain, name_domain, name_user,
                                       SID_NAME_USER, &user_sid);
                }
@@ -1606,8 +1763,9 @@ process_result:
                        goto done;
                }
 
-               result = append_auth_data(state, info3, name_domain,
-                                         name_user);
+               result = append_auth_data(state->mem_ctx, state->response,
+                                         state->request->flags, info3,
+                                         name_domain, name_user);
                if (!NT_STATUS_IS_OK(result)) {
                        goto done;
                }
@@ -1616,7 +1774,6 @@ process_result:
                    && lp_winbind_offline_logon()) {
 
                        result = winbindd_store_creds(domain,
-                                                     state->mem_ctx,
                                                      state->request->data.auth.user,
                                                      state->request->data.auth.pass,
                                                      info3);
@@ -1633,7 +1790,8 @@ process_result:
 
                        result = NT_STATUS_NOT_SUPPORTED;
                        if (our_domain == domain ) {
-                               result = fillup_password_policy(our_domain, state);
+                               result = fillup_password_policy(
+                                       our_domain, state->response);
                        }
 
                        if (!NT_STATUS_IS_OK(result)
@@ -1670,12 +1828,9 @@ enum winbindd_result winbindd_dual_pam_auth_crap(struct winbindd_domain *domain,
 {
        NTSTATUS result;
        struct netr_SamInfo3 *info3 = NULL;
-       struct rpc_pipe_client *netlogon_pipe;
        const char *name_user = NULL;
        const char *name_domain = NULL;
        const char *workstation;
-       int attempts = 0;
-       bool retry;
 
        DATA_BLOB lm_resp, nt_resp;
 
@@ -1724,83 +1879,38 @@ enum winbindd_result winbindd_dual_pam_auth_crap(struct winbindd_domain *domain,
                        sizeof(state->request->data.auth_crap.chal));
 
                result = winbindd_dual_auth_passdb(
-                       state->mem_ctx, name_domain, name_user,
+                       state->mem_ctx,
+                       state->request->data.auth_crap.logon_parameters,
+                       name_domain, name_user,
                        &chal_blob, &lm_resp, &nt_resp, &info3);
                goto process_result;
        }
 
-       do {
-               netlogon_fn_t logon_fn;
-
-               retry = false;
-
-               netlogon_pipe = NULL;
-               result = cm_connect_netlogon(domain, &netlogon_pipe);
-
-               if (!NT_STATUS_IS_OK(result)) {
-                       DEBUG(3, ("could not open handle to NETLOGON pipe (error: %s)\n",
-                                 nt_errstr(result)));
-                       goto done;
-               }
-
-               logon_fn = domain->can_do_samlogon_ex
-                       ? rpccli_netlogon_sam_network_logon_ex
-                       : rpccli_netlogon_sam_network_logon;
-
-               result = logon_fn(netlogon_pipe,
-                                 state->mem_ctx,
-                                 state->request->data.auth_crap.logon_parameters,
-                                 domain->dcname,
-                                 name_user,
-                                 name_domain,
-                                 /* Bug #3248 - found by Stefan Burkei. */
-                                 workstation, /* We carefully set this above so use it... */
-                                 state->request->data.auth_crap.chal,
-                                 lm_resp,
-                                 nt_resp,
-                                 &info3);
-
-               if ((NT_STATUS_V(result) == DCERPC_FAULT_OP_RNG_ERROR)
-                   && domain->can_do_samlogon_ex) {
-                       DEBUG(3, ("Got a DC that can not do NetSamLogonEx, "
-                                 "retrying with NetSamLogon\n"));
-                       domain->can_do_samlogon_ex = false;
-                       retry = true;
-                       continue;
-               }
-
-               attempts += 1;
-
-               /* We have to try a second time as cm_connect_netlogon
-                  might not yet have noticed that the DC has killed
-                  our connection. */
-
-               if (!rpccli_is_connected(netlogon_pipe)) {
-                       retry = true;
-                       continue;
-               }
-
-               /* if we get access denied, a possible cause was that we had and open
-                  connection to the DC, but someone changed our machine account password
-                  out from underneath us using 'net rpc changetrustpw' */
-
-               if ( NT_STATUS_EQUAL(result, NT_STATUS_ACCESS_DENIED) ) {
-                       DEBUG(3,("winbindd_pam_auth: sam_logon returned "
-                                "ACCESS_DENIED.  Maybe the trust account "
-                               "password was changed and we didn't know it. "
-                                "Killing connections to domain %s\n",
-                               name_domain));
-                       invalidate_cm_connection(&domain->conn);
-                       retry = true;
-               }
-
-       } while ( (attempts < 2) && retry );
+       result = winbind_samlogon_retry_loop(domain,
+                                            state->mem_ctx,
+                                            state->request->data.auth_crap.logon_parameters,
+                                            domain->dcname,
+                                            name_user,
+                                            name_domain,
+                                            /* Bug #3248 - found by Stefan Burkei. */
+                                            workstation, /* We carefully set this above so use it... */
+                                            state->request->data.auth_crap.chal,
+                                            lm_resp,
+                                            nt_resp,
+                                            &info3);
+       if (!NT_STATUS_IS_OK(result)) {
+               goto done;
+       }
 
 process_result:
 
        if (NT_STATUS_IS_OK(result)) {
+               struct dom_sid user_sid;
 
-               wcache_invalidate_samlogon(find_domain_from_name(name_domain), info3);
+               sid_compose(&user_sid, info3->base.domain_sid,
+                           info3->base.rid);
+               wcache_invalidate_samlogon(find_domain_from_name(name_domain),
+                                          &user_sid);
                netsamlogon_cache_store(name_user, info3);
 
                /* Check if the user is in the right group */
@@ -1816,8 +1926,9 @@ process_result:
                        goto done;
                }
 
-               result = append_auth_data(state, info3, name_domain,
-                                         name_user);
+               result = append_auth_data(state->mem_ctx, state->response,
+                                         state->request->flags, info3,
+                                         name_domain, name_user);
                if (!NT_STATUS_IS_OK(result)) {
                        goto done;
                }
@@ -1859,6 +1970,7 @@ enum winbindd_result winbindd_dual_pam_chauthtok(struct winbindd_domain *contact
        struct userPwdChangeFailureInformation *reject = NULL;
        NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
        fstring domain, user;
+       struct dcerpc_binding_handle *b = NULL;
 
        ZERO_STRUCT(dom_pol);
 
@@ -1886,6 +1998,8 @@ enum winbindd_result winbindd_dual_pam_chauthtok(struct winbindd_domain *contact
                goto done;
        }
 
+       b = cli->binding_handle;
+
        result = rpccli_samr_chgpasswd_user3(cli, state->mem_ctx,
                                             user,
                                             newpass,
@@ -1911,10 +2025,10 @@ enum winbindd_result winbindd_dual_pam_chauthtok(struct winbindd_domain *contact
         * short to comply with the samr_ChangePasswordUser3 idl - gd */
 
        /* only fallback when the chgpasswd_user3 call is not supported */
-       if ((NT_STATUS_EQUAL(result, NT_STATUS(DCERPC_FAULT_OP_RNG_ERROR))) ||
-                  (NT_STATUS_EQUAL(result, NT_STATUS_NOT_SUPPORTED)) ||
-                  (NT_STATUS_EQUAL(result, NT_STATUS_BUFFER_TOO_SMALL)) ||
-                  (NT_STATUS_EQUAL(result, NT_STATUS_NOT_IMPLEMENTED))) {
+       if (NT_STATUS_EQUAL(result, NT_STATUS_RPC_PROCNUM_OUT_OF_RANGE) ||
+           NT_STATUS_EQUAL(result, NT_STATUS_NOT_SUPPORTED) ||
+           NT_STATUS_EQUAL(result, NT_STATUS_BUFFER_TOO_SMALL) ||
+           NT_STATUS_EQUAL(result, NT_STATUS_NOT_IMPLEMENTED)) {
 
                DEBUG(10,("Password change with chgpasswd_user3 failed with: %s, retrying chgpasswd_user2\n",
                        nt_errstr(result)));
@@ -1931,26 +2045,26 @@ enum winbindd_result winbindd_dual_pam_chauthtok(struct winbindd_domain *contact
 
 done:
 
-       if (NT_STATUS_IS_OK(result) && (state->request->flags & WBFLAG_PAM_CACHED_LOGIN)) {
-               if (lp_winbind_offline_logon()) {
-                       result = winbindd_update_creds_by_name(contact_domain,
-                                                        state->mem_ctx, user,
-                                                        newpass);
-                       /* Again, this happens when we login from gdm or xdm
-                        * and the password expires, *BUT* cached crendentials
-                        * doesn't exist. winbindd_update_creds_by_name()
-                        * returns NT_STATUS_NO_SUCH_USER.
-                        * This is not a failure.
-                        * --- BoYang
-                        * */
-                       if (NT_STATUS_EQUAL(result, NT_STATUS_NO_SUCH_USER)) {
-                               result = NT_STATUS_OK;
-                       }
+       if (NT_STATUS_IS_OK(result)
+           && (state->request->flags & WBFLAG_PAM_CACHED_LOGIN)
+           && lp_winbind_offline_logon()) {
+               result = winbindd_update_creds_by_name(contact_domain, user,
+                                                      newpass);
+               /* Again, this happens when we login from gdm or xdm
+                * and the password expires, *BUT* cached crendentials
+                * doesn't exist. winbindd_update_creds_by_name()
+                * returns NT_STATUS_NO_SUCH_USER.
+                * This is not a failure.
+                * --- BoYang
+                * */
+               if (NT_STATUS_EQUAL(result, NT_STATUS_NO_SUCH_USER)) {
+                       result = NT_STATUS_OK;
+               }
 
-                       if (!NT_STATUS_IS_OK(result)) {
-                               DEBUG(10,("Failed to store creds: %s\n", nt_errstr(result)));
-                               goto process_result;
-                       }
+               if (!NT_STATUS_IS_OK(result)) {
+                       DEBUG(10, ("Failed to store creds: %s\n",
+                                  nt_errstr(result)));
+                       goto process_result;
                }
        }
 
@@ -1958,7 +2072,8 @@ done:
 
                NTSTATUS policy_ret;
 
-               policy_ret = fillup_password_policy(contact_domain, state);
+               policy_ret = fillup_password_policy(
+                       contact_domain, state->response);
 
                /* failure of this is non critical, it will just provide no
                 * additional information to the client why the change has
@@ -1974,9 +2089,10 @@ process_result:
 
        if (strequal(contact_domain->name, get_global_sam_name())) {
                /* FIXME: internal rpc pipe does not cache handles yet */
-               if (cli) {
+               if (b) {
                        if (is_valid_policy_hnd(&dom_pol)) {
-                               rpccli_samr_Close(cli, state->mem_ctx, &dom_pol);
+                               NTSTATUS _result;
+                               dcerpc_samr_Close(b, state->mem_ctx, &dom_pol, &_result);
                        }
                        TALLOC_FREE(cli);
                }
@@ -2042,6 +2158,13 @@ enum winbindd_result winbindd_dual_pam_logoff(struct winbindd_domain *domain,
                goto process_result;
        }
 
+       /*
+        * Remove any mlock'ed memory creds in the child
+        * we might be using for krb5 ticket renewal.
+        */
+
+       winbindd_delete_memory_creds(state->request->data.logoff.user);
+
 #else
        result = NT_STATUS_NOT_SUPPORTED;
 #endif
@@ -2067,6 +2190,7 @@ enum winbindd_result winbindd_dual_pam_chng_pswd_auth_crap(struct winbindd_domai
        struct policy_handle dom_pol;
        struct winbindd_domain *contact_domain = domainSt;
        struct rpc_pipe_client *cli = NULL;
+       struct dcerpc_binding_handle *b = NULL;
 
        ZERO_STRUCT(dom_pol);
 
@@ -2106,7 +2230,7 @@ enum winbindd_result winbindd_dual_pam_chng_pswd_auth_crap(struct winbindd_domai
        }
 
        if (!*domain && lp_winbind_use_default_domain()) {
-               fstrcpy(domain,(char *)lp_workgroup());
+               fstrcpy(domain,lp_workgroup());
        }
 
        if(!*user) {
@@ -2134,8 +2258,8 @@ enum winbindd_result winbindd_dual_pam_chng_pswd_auth_crap(struct winbindd_domai
                        state->request->data.chng_pswd_auth_crap.old_lm_hash_enc,
                        state->request->data.chng_pswd_auth_crap.old_lm_hash_enc_len);
        } else {
-               new_lm_password.length = 0;
-               old_lm_hash_enc.length = 0;
+               new_lm_password = data_blob_null;
+               old_lm_hash_enc = data_blob_null;
        }
 
        /* Get sam handle */
@@ -2146,6 +2270,8 @@ enum winbindd_result winbindd_dual_pam_chng_pswd_auth_crap(struct winbindd_domai
                goto done;
        }
 
+       b = cli->binding_handle;
+
        result = rpccli_samr_chng_pswd_auth_crap(
                cli, state->mem_ctx, user, new_nt_password, old_nt_hash_enc,
                new_lm_password, old_lm_hash_enc);
@@ -2154,9 +2280,10 @@ enum winbindd_result winbindd_dual_pam_chng_pswd_auth_crap(struct winbindd_domai
 
        if (strequal(contact_domain->name, get_global_sam_name())) {
                /* FIXME: internal rpc pipe does not cache handles yet */
-               if (cli) {
+               if (b) {
                        if (is_valid_policy_hnd(&dom_pol)) {
-                               rpccli_samr_Close(cli, state->mem_ctx, &dom_pol);
+                               NTSTATUS _result;
+                               dcerpc_samr_Close(b, state->mem_ctx, &dom_pol, &_result);
                        }
                        TALLOC_FREE(cli);
                }
@@ -2172,3 +2299,116 @@ enum winbindd_result winbindd_dual_pam_chng_pswd_auth_crap(struct winbindd_domai
 
        return NT_STATUS_IS_OK(result) ? WINBINDD_OK : WINBINDD_ERROR;
 }
+
+#ifdef HAVE_KRB5
+static NTSTATUS extract_pac_vrfy_sigs(TALLOC_CTX *mem_ctx, DATA_BLOB pac_blob,
+                                     struct PAC_LOGON_INFO **logon_info)
+{
+       krb5_context krbctx = NULL;
+       krb5_error_code k5ret;
+       krb5_keytab keytab;
+       krb5_kt_cursor cursor;
+       krb5_keytab_entry entry;
+       NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
+
+       ZERO_STRUCT(entry);
+       ZERO_STRUCT(cursor);
+
+       k5ret = krb5_init_context(&krbctx);
+       if (k5ret) {
+               DEBUG(1, ("Failed to initialize kerberos context: %s\n",
+                         error_message(k5ret)));
+               status = krb5_to_nt_status(k5ret);
+               goto out;
+       }
+
+       k5ret =  gse_krb5_get_server_keytab(krbctx, &keytab);
+       if (k5ret) {
+               DEBUG(1, ("Failed to get keytab: %s\n",
+                         error_message(k5ret)));
+               status = krb5_to_nt_status(k5ret);
+               goto out_free;
+       }
+
+       k5ret = krb5_kt_start_seq_get(krbctx, keytab, &cursor);
+       if (k5ret) {
+               DEBUG(1, ("Failed to start seq: %s\n",
+                         error_message(k5ret)));
+               status = krb5_to_nt_status(k5ret);
+               goto out_keytab;
+       }
+
+       k5ret = krb5_kt_next_entry(krbctx, keytab, &entry, &cursor);
+       while (k5ret == 0) {
+               status = kerberos_pac_logon_info(mem_ctx, pac_blob,
+                                                krbctx, NULL,
+                                                KRB5_KT_KEY(&entry), NULL, 0,
+                                                logon_info);
+               if (NT_STATUS_IS_OK(status)) {
+                       break;
+               }
+               k5ret = smb_krb5_kt_free_entry(krbctx, &entry);
+               k5ret = krb5_kt_next_entry(krbctx, keytab, &entry, &cursor);
+       }
+
+       k5ret = krb5_kt_end_seq_get(krbctx, keytab, &cursor);
+       if (k5ret) {
+               DEBUG(1, ("Failed to end seq: %s\n",
+                         error_message(k5ret)));
+       }
+out_keytab:
+       k5ret = krb5_kt_close(krbctx, keytab);
+       if (k5ret) {
+               DEBUG(1, ("Failed to close keytab: %s\n",
+                         error_message(k5ret)));
+       }
+out_free:
+       krb5_free_context(krbctx);
+out:
+       return status;
+}
+
+NTSTATUS winbindd_pam_auth_pac_send(struct winbindd_cli_state *state,
+                                   struct netr_SamInfo3 **info3)
+{
+       struct winbindd_request *req = state->request;
+       DATA_BLOB pac_blob;
+       struct PAC_LOGON_INFO *logon_info = NULL;
+       NTSTATUS result;
+
+       pac_blob = data_blob_const(req->extra_data.data, req->extra_len);
+       result = extract_pac_vrfy_sigs(state->mem_ctx, pac_blob, &logon_info);
+       if (!NT_STATUS_IS_OK(result) &&
+           !NT_STATUS_EQUAL(result, NT_STATUS_ACCESS_DENIED)) {
+               DEBUG(1, ("Error during PAC signature verification: %s\n",
+                         nt_errstr(result)));
+               return result;
+       }
+
+       if (logon_info) {
+               /* Signature verification succeeded, trust the PAC */
+               netsamlogon_cache_store(NULL, &logon_info->info3);
+
+       } else {
+               /* Try without signature verification */
+               result = kerberos_pac_logon_info(state->mem_ctx, pac_blob, NULL,
+                                                NULL, NULL, NULL, 0,
+                                                &logon_info);
+               if (!NT_STATUS_IS_OK(result)) {
+                       DEBUG(10, ("Could not extract PAC: %s\n",
+                                  nt_errstr(result)));
+                       return result;
+               }
+       }
+
+       *info3 = &logon_info->info3;
+
+       return NT_STATUS_OK;
+}
+#else /* HAVE_KRB5 */
+NTSTATUS winbindd_pam_auth_pac_send(struct winbindd_cli_state *state,
+                                   struct netr_SamInfo3 **info3)
+{
+       return NT_STATUS_NO_SUCH_USER;
+}
+#endif /* HAVE_KRB5 */