Replace cli_rpc_pipe_close by a talloc destructor on rpc_pipe_struct
[kai/samba.git] / source3 / winbindd / winbindd_cm.c
index ef159f0670cdc650186e00650515d87b381b2f07..73f74ca8ec04b0864c4014d75d3bf53670ff7f0e 100644 (file)
@@ -199,9 +199,8 @@ static bool fork_child_dc_connect(struct winbindd_domain *domain)
 
        /* Leave messages blocked - we will never process one. */
 
-       /* tdb needs special fork handling */
-       if (tdb_reopen_all(1) == -1) {
-               DEBUG(0,("tdb_reopen_all failed.\n"));
+       if (!reinit_after_fork(winbind_messaging_context())) {
+               DEBUG(0,("reinit_after_fork() failed\n"));
                _exit(0);
        }
 
@@ -570,8 +569,8 @@ static bool get_dc_name_via_netlogon(struct winbindd_domain *domain,
        WERROR werr;
        TALLOC_CTX *mem_ctx;
        unsigned int orig_timeout;
-       char *tmp = NULL;
-       char *p;
+       const char *tmp = NULL;
+       const char *p;
 
        /* Hmmmm. We can only open one connection to the NETLOGON pipe at the
         * moment.... */
@@ -599,22 +598,23 @@ static bool get_dc_name_via_netlogon(struct winbindd_domain *domain,
        /* This call can take a long time - allow the server to time out.
           35 seconds should do it. */
 
-       orig_timeout = cli_set_timeout(netlogon_pipe->cli, 35000);
+       orig_timeout = rpccli_set_timeout(netlogon_pipe, 35000);
 
        if (our_domain->active_directory) {
-               struct DS_DOMAIN_CONTROLLER_INFO *domain_info = NULL;
-
-               werr = rpccli_netlogon_dsr_getdcname(netlogon_pipe,
-                                                    mem_ctx,
-                                                    our_domain->dcname,
-                                                    domain->name,
-                                                    NULL,
-                                                    NULL,
-                                                    DS_RETURN_DNS_NAME,
-                                                    &domain_info);
+               struct netr_DsRGetDCNameInfo *domain_info = NULL;
+
+               result = rpccli_netr_DsRGetDCName(netlogon_pipe,
+                                                 mem_ctx,
+                                                 our_domain->dcname,
+                                                 domain->name,
+                                                 NULL,
+                                                 NULL,
+                                                 DS_RETURN_DNS_NAME,
+                                                 &domain_info,
+                                                 &werr);
                if (W_ERROR_IS_OK(werr)) {
                        tmp = talloc_strdup(
-                               mem_ctx, domain_info->domain_controller_name);
+                               mem_ctx, domain_info->dc_unc);
                        if (tmp == NULL) {
                                DEBUG(0, ("talloc_strdup failed\n"));
                                talloc_destroy(mem_ctx);
@@ -626,29 +626,35 @@ static bool get_dc_name_via_netlogon(struct winbindd_domain *domain,
                        }
                        if (strlen(domain->forest_name) == 0) {
                                fstrcpy(domain->forest_name,
-                                       domain_info->dns_forest_name);
+                                       domain_info->forest_name);
                        }
                }
        } else {
-
-               werr = rpccli_netlogon_getanydcname(netlogon_pipe,
-                                                   mem_ctx,
-                                                   our_domain->dcname,
-                                                   domain->name,
-                                                   &tmp);
+               result = rpccli_netr_GetAnyDCName(netlogon_pipe, mem_ctx,
+                                                 our_domain->dcname,
+                                                 domain->name,
+                                                 &tmp,
+                                                 &werr);
        }
 
        /* And restore our original timeout. */
-       cli_set_timeout(netlogon_pipe->cli, orig_timeout);
+       rpccli_set_timeout(netlogon_pipe, orig_timeout);
+
+       if (!NT_STATUS_IS_OK(result)) {
+               DEBUG(10,("rpccli_netr_GetAnyDCName failed: %s\n",
+                       nt_errstr(result)));
+               talloc_destroy(mem_ctx);
+               return false;
+       }
 
        if (!W_ERROR_IS_OK(werr)) {
-               DEBUG(10, ("rpccli_netlogon_getanydcname failed: %s\n",
+               DEBUG(10,("rpccli_netr_GetAnyDCName failed: %s\n",
                           dos_errstr(werr)));
                talloc_destroy(mem_ctx);
-               return False;
+               return false;
        }
 
-       /* cli_netlogon_getanydcname gives us a name with \\ */
+       /* rpccli_netr_GetAnyDCName gives us a name with \\ */
        p = tmp;
        if (*p == '\\') {
                p+=1;
@@ -661,7 +667,7 @@ static bool get_dc_name_via_netlogon(struct winbindd_domain *domain,
 
        talloc_destroy(mem_ctx);
 
-       DEBUG(10, ("rpccli_netlogon_getanydcname returned %s\n", dcname));
+       DEBUG(10,("rpccli_netr_GetAnyDCName returned %s\n", dcname));
 
        if (!resolve_name(dcname, dc_ss, 0x20)) {
                return False;
@@ -679,8 +685,22 @@ static NTSTATUS get_trust_creds(const struct winbindd_domain *domain,
                                char **machine_krb5_principal)
 {
        const char *account_name;
+       const char *name = NULL;
+       
+       /* If we are a DC and this is not our own domain */
 
-       if (!get_trust_pw_clear(domain->name, machine_password,
+       if (IS_DC) {
+               name = domain->name;
+       } else {
+               struct winbindd_domain *our_domain = find_our_domain();
+
+               if (!our_domain)
+                       return NT_STATUS_INVALID_SERVER_STATE;          
+               
+               name = our_domain->name;                
+       }       
+       
+       if (!get_trust_pw_clear(name, machine_password,
                                &account_name, NULL))
        {
                return NT_STATUS_CANT_ACCESS_DOMAIN_INFO;
@@ -694,11 +714,15 @@ static NTSTATUS get_trust_creds(const struct winbindd_domain *domain,
 
        /* this is at least correct when domain is our domain,
         * which is the only case, when this is currently used: */
-       if ((machine_krb5_principal != NULL) &&
-           (asprintf(machine_krb5_principal, "%s$@%s", account_name,
-                     domain->alt_name) == -1))
+       if (machine_krb5_principal != NULL)
        {
-               return NT_STATUS_NO_MEMORY;
+               if (asprintf(machine_krb5_principal, "%s$@%s",
+                            account_name, domain->alt_name) == -1)
+               {
+                       return NT_STATUS_NO_MEMORY;
+               }
+
+               strupper_m(*machine_krb5_principal);
        }
 
        return NT_STATUS_OK;
@@ -722,7 +746,7 @@ static NTSTATUS cm_prepare_connection(const struct winbindd_domain *domain,
        char *ipc_domain = NULL;
        char *ipc_password = NULL;
 
-       bool got_mutex;
+       struct named_mutex *mutex;
 
        NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
 
@@ -736,10 +760,9 @@ static NTSTATUS cm_prepare_connection(const struct winbindd_domain *domain,
 
        *retry = True;
 
-       got_mutex = secrets_named_mutex(controller,
-                                       WINBIND_SERVER_MUTEX_WAIT_TIME);
-
-       if (!got_mutex) {
+       mutex = grab_named_mutex(talloc_tos(), controller,
+                                WINBIND_SERVER_MUTEX_WAIT_TIME);
+       if (mutex == NULL) {
                DEBUG(0,("cm_prepare_connection: mutex grab failed for %s\n",
                         controller));
                result = NT_STATUS_POSSIBLE_DEADLOCK;
@@ -801,7 +824,7 @@ static NTSTATUS cm_prepare_connection(const struct winbindd_domain *domain,
                                         &machine_account,
                                         &machine_krb5_principal);
                if (!NT_STATUS_IS_OK(result)) {
-                       goto done;
+                       goto anon_fallback;
                }
 
                if (lp_security() == SEC_ADS) {
@@ -886,6 +909,8 @@ static NTSTATUS cm_prepare_connection(const struct winbindd_domain *domain,
                }
        }
 
+ anon_fallback:
+
        /* Fall back to anonymous connection, this might fail later */
 
        if (NT_STATUS_IS_OK(cli_session_setup(*cli, "", NULL, 0,
@@ -927,8 +952,7 @@ static NTSTATUS cm_prepare_connection(const struct winbindd_domain *domain,
                goto done;
        }
 
-       secrets_named_mutex_release(controller);
-       got_mutex = False;
+       TALLOC_FREE(mutex);
        *retry = False;
 
        /* set the domain if empty; needed for schannel connections */
@@ -939,10 +963,7 @@ static NTSTATUS cm_prepare_connection(const struct winbindd_domain *domain,
        result = NT_STATUS_OK;
 
  done:
-       if (got_mutex) {
-               secrets_named_mutex_release(controller);
-       }
-
+       TALLOC_FREE(mutex);
        SAFE_FREE(machine_account);
        SAFE_FREE(machine_password);
        SAFE_FREE(machine_krb5_principal);
@@ -999,164 +1020,6 @@ static bool add_sockaddr_to_array(TALLOC_CTX *mem_ctx,
        return True;
 }
 
-static void mailslot_name(struct in_addr dc_ip, fstring name)
-{
-       fstr_sprintf(name, "\\MAILSLOT\\NET\\GETDC%X", dc_ip.s_addr);
-}
-
-static bool send_getdc_request(struct sockaddr_storage *dc_ss,
-                              const char *domain_name,
-                              const DOM_SID *sid)
-{
-       char outbuf[1024];
-       struct in_addr dc_ip;
-       char *p;
-       fstring my_acct_name;
-       fstring my_mailslot;
-       size_t sid_size;
-
-       if (dc_ss->ss_family != AF_INET) {
-               return false;
-       }
-
-       dc_ip = ((struct sockaddr_in *)dc_ss)->sin_addr;
-       mailslot_name(dc_ip, my_mailslot);
-
-       memset(outbuf, '\0', sizeof(outbuf));
-
-       p = outbuf;
-
-       SCVAL(p, 0, SAMLOGON);
-       p++;
-
-       SCVAL(p, 0, 0); /* Count pointer ... */
-       p++;
-
-       SIVAL(p, 0, 0); /* The sender's token ... */
-       p += 2;
-
-       p += dos_PutUniCode(p, global_myname(),
-                       sizeof(outbuf) - PTR_DIFF(p, outbuf), True);
-       fstr_sprintf(my_acct_name, "%s$", global_myname());
-       p += dos_PutUniCode(p, my_acct_name,
-                       sizeof(outbuf) - PTR_DIFF(p, outbuf), True);
-
-       if (strlen(my_mailslot)+1 > sizeof(outbuf) - PTR_DIFF(p, outbuf)) {
-               return false;
-       }
-
-       memcpy(p, my_mailslot, strlen(my_mailslot)+1);
-       p += strlen(my_mailslot)+1;
-
-       if (sizeof(outbuf) - PTR_DIFF(p, outbuf) < 8) {
-               return false;
-       }
-
-       SIVAL(p, 0, 0x80);
-       p+=4;
-
-       sid_size = ndr_size_dom_sid(sid, 0);
-
-       SIVAL(p, 0, sid_size);
-       p+=4;
-
-       p = ALIGN4(p, outbuf);
-       if (PTR_DIFF(p, outbuf) > sizeof(outbuf)) {
-               return false;
-       }
-
-       if (sid_size + 8 > sizeof(outbuf) - PTR_DIFF(p, outbuf)) {
-               return false;
-       }
-       sid_linearize(p, sizeof(outbuf) - PTR_DIFF(p, outbuf), sid);
-
-       p += sid_size;
-
-       SIVAL(p, 0, 1);
-       SSVAL(p, 4, 0xffff);
-       SSVAL(p, 6, 0xffff);
-       p+=8;
-
-       return cli_send_mailslot(winbind_messaging_context(),
-                                False, "\\MAILSLOT\\NET\\NTLOGON", 0,
-                                outbuf, PTR_DIFF(p, outbuf),
-                                global_myname(), 0, domain_name, 0x1c,
-                                dc_ss);
-}
-
-static bool receive_getdc_response(struct sockaddr_storage *dc_ss,
-                                  const char *domain_name,
-                                  fstring dc_name)
-{
-       struct packet_struct *packet;
-       fstring my_mailslot;
-       char *buf, *p;
-       fstring dcname, user, domain;
-       int len;
-       struct in_addr dc_ip;
-
-       if (dc_ss->ss_family != AF_INET) {
-               return false;
-       }
-       dc_ip = ((struct sockaddr_in *)dc_ss)->sin_addr;
-       mailslot_name(dc_ip, my_mailslot);
-
-       packet = receive_unexpected(DGRAM_PACKET, 0, my_mailslot);
-
-       if (packet == NULL) {
-               DEBUG(5, ("Did not receive packet for %s\n", my_mailslot));
-               return False;
-       }
-
-       DEBUG(5, ("Received packet for %s\n", my_mailslot));
-
-       buf = packet->packet.dgram.data;
-       len = packet->packet.dgram.datasize;
-
-       if (len < 70) {
-               /* 70 is a completely arbitrary value to make sure
-                  the SVAL below does not read uninitialized memory */
-               DEBUG(3, ("GetDC got short response\n"));
-               return False;
-       }
-
-       /* This should be (buf-4)+SVAL(buf-4, smb_vwv12)... */
-       p = buf+SVAL(buf, smb_vwv10);
-
-       if (CVAL(p,0) != SAMLOGON_R) {
-               DEBUG(8, ("GetDC got invalid response type %d\n", CVAL(p, 0)));
-               return False;
-       }
-
-       p+=2;
-       pull_ucs2(buf, dcname, p, sizeof(dcname), PTR_DIFF(buf+len, p),
-                 STR_TERMINATE|STR_NOALIGN);
-       p = skip_unibuf(p, PTR_DIFF(buf+len, p));
-       pull_ucs2(buf, user, p, sizeof(dcname), PTR_DIFF(buf+len, p),
-                 STR_TERMINATE|STR_NOALIGN);
-       p = skip_unibuf(p, PTR_DIFF(buf+len, p));
-       pull_ucs2(buf, domain, p, sizeof(dcname), PTR_DIFF(buf+len, p),
-                 STR_TERMINATE|STR_NOALIGN);
-       p = skip_unibuf(p, PTR_DIFF(buf+len, p));
-
-       if (!strequal(domain, domain_name)) {
-               DEBUG(3, ("GetDC: Expected domain %s, got %s\n",
-                         domain_name, domain));
-               return False;
-       }
-
-       p = dcname;
-       if (*p == '\\') p += 1;
-       if (*p == '\\') p += 1;
-
-       fstrcpy(dc_name, p);
-
-       DEBUG(10, ("GetDC gave name %s for domain %s\n",
-                  dc_name, domain));
-
-       return True;
-}
-
 /*******************************************************************
  convert an ip to a name
 *******************************************************************/
@@ -1228,7 +1091,8 @@ static bool dcip_to_name(const struct winbindd_domain *domain,
 
        /* try GETDC requests next */
 
-       if (send_getdc_request(pss, domain->name, &domain->sid)) {
+       if (send_getdc_request(winbind_messaging_context(),
+                              pss, domain->name, &domain->sid)) {
                int i;
                smb_msleep(100);
                for (i=0; i<5; i++) {
@@ -1568,33 +1432,27 @@ void invalidate_cm_connection(struct winbindd_cm_conn *conn)
        }
 
        if (conn->samr_pipe != NULL) {
-               if (!cli_rpc_pipe_close(conn->samr_pipe)) {
-                       /* Ok, it must be dead. Drop timeout to 0.5 sec. */
-                       if (conn->cli) {
-                               cli_set_timeout(conn->cli, 500);
-                       }
+               TALLOC_FREE(conn->samr_pipe);
+               /* Ok, it must be dead. Drop timeout to 0.5 sec. */
+               if (conn->cli) {
+                       cli_set_timeout(conn->cli, 500);
                }
-               conn->samr_pipe = NULL;
        }
 
        if (conn->lsa_pipe != NULL) {
-               if (!cli_rpc_pipe_close(conn->lsa_pipe)) {
-                       /* Ok, it must be dead. Drop timeout to 0.5 sec. */
-                       if (conn->cli) {
-                               cli_set_timeout(conn->cli, 500);
-                       }
+               TALLOC_FREE(conn->lsa_pipe);
+               /* Ok, it must be dead. Drop timeout to 0.5 sec. */
+               if (conn->cli) {
+                       cli_set_timeout(conn->cli, 500);
                }
-               conn->lsa_pipe = NULL;
        }
 
        if (conn->netlogon_pipe != NULL) {
-               if (!cli_rpc_pipe_close(conn->netlogon_pipe)) {
-                       /* Ok, it must be dead. Drop timeout to 0.5 sec. */
-                       if (conn->cli) {
-                               cli_set_timeout(conn->cli, 500);
-                       }
+               TALLOC_FREE(conn->netlogon_pipe);
+               /* Ok, it must be dead. Drop timeout to 0.5 sec. */
+               if (conn->cli) {
+                       cli_set_timeout(conn->cli, 500);
                }
-               conn->netlogon_pipe = NULL;
        }
 
        if (conn->cli) {
@@ -1698,12 +1556,11 @@ static bool set_dc_type_and_flags_trustinfo( struct winbindd_domain *domain )
 {
        struct winbindd_domain *our_domain;
        NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
-       struct ds_domain_trust *domains = NULL;
-       int count = 0;
+       struct netr_DomainTrustList trusts;
        int i;
-       uint32 flags = (DS_DOMAIN_IN_FOREST | 
-                       DS_DOMAIN_DIRECT_OUTBOUND | 
-                       DS_DOMAIN_DIRECT_INBOUND);
+       uint32 flags = (NETR_TRUST_FLAG_IN_FOREST |
+                       NETR_TRUST_FLAG_OUTBOUND |
+                       NETR_TRUST_FLAG_INBOUND);
        struct rpc_pipe_client *cli;
        TALLOC_CTX *mem_ctx = NULL;
 
@@ -1745,27 +1602,35 @@ static bool set_dc_type_and_flags_trustinfo( struct winbindd_domain *domain )
                return False;
        }       
 
-       result = rpccli_ds_enum_domain_trusts(cli, mem_ctx,
-                                             cli->cli->desthost, 
-                                             flags, &domains,
-                                             (unsigned int *)&count);
+       result = rpccli_netr_DsrEnumerateDomainTrusts(cli, mem_ctx,
+                                                     cli->desthost,
+                                                     flags,
+                                                     &trusts,
+                                                     NULL);
+       if (!NT_STATUS_IS_OK(result)) {
+               DEBUG(0,("set_dc_type_and_flags_trustinfo: "
+                       "failed to query trusted domain list: %s\n",
+                       nt_errstr(result)));
+               talloc_destroy(mem_ctx);
+               return false;
+       }
 
        /* Now find the domain name and get the flags */
 
-       for ( i=0; i<count; i++ ) {
-               if ( strequal( domain->name, domains[i].netbios_domain ) ) {                    
-                       domain->domain_flags          = domains[i].flags;
-                       domain->domain_type           = domains[i].trust_type;
-                       domain->domain_trust_attribs  = domains[i].trust_attributes;
-                                               
-                       if ( domain->domain_type == DS_DOMAIN_TRUST_TYPE_UPLEVEL )
+       for ( i=0; i<trusts.count; i++ ) {
+               if ( strequal( domain->name, trusts.array[i].netbios_name) ) {
+                       domain->domain_flags          = trusts.array[i].trust_flags;
+                       domain->domain_type           = trusts.array[i].trust_type;
+                       domain->domain_trust_attribs  = trusts.array[i].trust_attributes;
+
+                       if ( domain->domain_type == NETR_TRUST_TYPE_UPLEVEL )
                                domain->active_directory = True;
 
                        /* This flag is only set if the domain is *our* 
                           primary domain and the primary domain is in
                           native mode */
 
-                       domain->native_mode = (domain->domain_flags & DS_DOMAIN_NATIVE_MODE);
+                       domain->native_mode = (domain->domain_flags & NETR_TRUST_FLAG_NATIVE);
 
                        DEBUG(5, ("set_dc_type_and_flags_trustinfo: domain %s is %sin "
                                  "native mode.\n", domain->name, 
@@ -1801,18 +1666,13 @@ static bool set_dc_type_and_flags_trustinfo( struct winbindd_domain *domain )
 static void set_dc_type_and_flags_connect( struct winbindd_domain *domain )
 {
        NTSTATUS                result;
-       DS_DOMINFO_CTR          ctr;
+       WERROR werr;
        TALLOC_CTX              *mem_ctx = NULL;
        struct rpc_pipe_client  *cli;
        POLICY_HND pol;
+       union dssetup_DsRoleInfo info;
+       union lsa_PolicyInformation *lsa_info = NULL;
 
-       const char *domain_name = NULL;
-       const char *dns_name = NULL;
-       const char *forest_name = NULL;
-       DOM_SID *dom_sid = NULL;        
-
-       ZERO_STRUCT( ctr );
-       
        if (!connection_ok(domain)) {
                return;
        }
@@ -1826,25 +1686,26 @@ static void set_dc_type_and_flags_connect( struct winbindd_domain *domain )
 
        DEBUG(5, ("set_dc_type_and_flags_connect: domain %s\n", domain->name ));
 
-       cli = cli_rpc_pipe_open_noauth(domain->conn.cli, PI_LSARPC_DS,
+       cli = cli_rpc_pipe_open_noauth(domain->conn.cli, PI_DSSETUP,
                                       &result);
 
        if (cli == NULL) {
                DEBUG(5, ("set_dc_type_and_flags_connect: Could not bind to "
-                         "PI_LSARPC_DS on domain %s: (%s)\n",
+                         "PI_DSSETUP on domain %s: (%s)\n",
                          domain->name, nt_errstr(result)));
 
                /* if this is just a non-AD domain we need to continue
                 * identifying so that we can in the end return with
                 * domain->initialized = True - gd */
 
-               goto no_lsarpc_ds;
+               goto no_dssetup;
        }
 
-       result = rpccli_ds_getprimarydominfo(cli, mem_ctx,
-                                            DsRolePrimaryDomainInfoBasic,
-                                            &ctr);
-       cli_rpc_pipe_close(cli);
+       result = rpccli_dssetup_DsRoleGetPrimaryDomainInformation(cli, mem_ctx,
+                                                                 DS_ROLE_BASIC_INFORMATION,
+                                                                 &info,
+                                                                 &werr);
+       TALLOC_FREE(cli);
 
        if (!NT_STATUS_IS_OK(result)) {
                DEBUG(5, ("set_dc_type_and_flags_connect: rpccli_ds_getprimarydominfo "
@@ -1852,33 +1713,33 @@ static void set_dc_type_and_flags_connect( struct winbindd_domain *domain )
                          domain->name, nt_errstr(result)));
 
                /* older samba3 DCs will return DCERPC_FAULT_OP_RNG_ERROR for
-                * every opcode on the LSARPC_DS pipe, continue with
-                * no_lsarpc_ds mode here as well to get domain->initialized
+                * every opcode on the DSSETUP pipe, continue with
+                * no_dssetup mode here as well to get domain->initialized
                 * set - gd */
 
                if (NT_STATUS_V(result) == DCERPC_FAULT_OP_RNG_ERROR) {
-                       goto no_lsarpc_ds;
+                       goto no_dssetup;
                }
 
                TALLOC_FREE(mem_ctx);
                return;
        }
-       
-       if ((ctr.basic->flags & DSROLE_PRIMARY_DS_RUNNING) &&
-           !(ctr.basic->flags & DSROLE_PRIMARY_DS_MIXED_MODE)) {
+
+       if ((info.basic.flags & DS_ROLE_PRIMARY_DS_RUNNING) &&
+           !(info.basic.flags & DS_ROLE_PRIMARY_DS_MIXED_MODE)) {
                domain->native_mode = True;
        } else {
                domain->native_mode = False;
        }
 
-no_lsarpc_ds:
+no_dssetup:
        cli = cli_rpc_pipe_open_noauth(domain->conn.cli, PI_LSARPC, &result);
 
        if (cli == NULL) {
                DEBUG(5, ("set_dc_type_and_flags_connect: Could not bind to "
                          "PI_LSARPC on domain %s: (%s)\n",
                          domain->name, nt_errstr(result)));
-               cli_rpc_pipe_close(cli);
+               TALLOC_FREE(cli);
                TALLOC_FREE(mem_ctx);
                return;
        }
@@ -1889,54 +1750,65 @@ no_lsarpc_ds:
        if (NT_STATUS_IS_OK(result)) {
                /* This particular query is exactly what Win2k clients use 
                   to determine that the DC is active directory */
-               result = rpccli_lsa_query_info_policy2(cli, mem_ctx, &pol,
-                                                      12, &domain_name,
-                                                      &dns_name, &forest_name,
-                                                      NULL, &dom_sid);
+               result = rpccli_lsa_QueryInfoPolicy2(cli, mem_ctx,
+                                                    &pol,
+                                                    LSA_POLICY_INFO_DNS,
+                                                    &lsa_info);
        }
 
        if (NT_STATUS_IS_OK(result)) {
                domain->active_directory = True;
 
-               if (domain_name)
-                       fstrcpy(domain->name, domain_name);
+               if (lsa_info->dns.name.string) {
+                       fstrcpy(domain->name, lsa_info->dns.name.string);
+               }
 
-               if (dns_name)
-                       fstrcpy(domain->alt_name, dns_name);
+               if (lsa_info->dns.dns_domain.string) {
+                       fstrcpy(domain->alt_name,
+                               lsa_info->dns.dns_domain.string);
+               }
 
                /* See if we can set some domain trust flags about
                   ourself */
 
-               if ( forest_name ) {
-                       fstrcpy(domain->forest_name, forest_name);              
+               if (lsa_info->dns.dns_forest.string) {
+                       fstrcpy(domain->forest_name,
+                               lsa_info->dns.dns_forest.string);
 
                        if (strequal(domain->forest_name, domain->alt_name)) {
-                               domain->domain_flags = DS_DOMAIN_TREE_ROOT;
+                               domain->domain_flags |= NETR_TRUST_FLAG_TREEROOT;
                        }
                }
 
-               if (dom_sid) 
-                       sid_copy(&domain->sid, dom_sid);
+               if (lsa_info->dns.sid) {
+                       sid_copy(&domain->sid, lsa_info->dns.sid);
+               }
        } else {
                domain->active_directory = False;
 
                result = rpccli_lsa_open_policy(cli, mem_ctx, True, 
                                                SEC_RIGHTS_MAXIMUM_ALLOWED,
                                                &pol);
-                       
-               if (!NT_STATUS_IS_OK(result))
+
+               if (!NT_STATUS_IS_OK(result)) {
                        goto done;
-                       
-               result = rpccli_lsa_query_info_policy(cli, mem_ctx, 
-                                                     &pol, 5, &domain_name, 
-                                                     &dom_sid);
-                       
+               }
+
+               result = rpccli_lsa_QueryInfoPolicy(cli, mem_ctx,
+                                                   &pol,
+                                                   LSA_POLICY_INFO_ACCOUNT_DOMAIN,
+                                                   &lsa_info);
+
                if (NT_STATUS_IS_OK(result)) {
-                       if (domain_name)
-                               fstrcpy(domain->name, domain_name);
 
-                       if (dom_sid) 
-                               sid_copy(&domain->sid, dom_sid);
+                       if (lsa_info->account_domain.name.string) {
+                               fstrcpy(domain->name,
+                                       lsa_info->account_domain.name.string);
+                       }
+
+                       if (lsa_info->account_domain.sid) {
+                               sid_copy(&domain->sid, lsa_info->account_domain.sid);
+                       }
                }
        }
 done:
@@ -1947,7 +1819,7 @@ done:
        DEBUG(5,("set_dc_type_and_flags_connect: domain %s is %srunning active directory.\n",
                  domain->name, domain->active_directory ? "" : "NOT "));
 
-       cli_rpc_pipe_close(cli);
+       TALLOC_FREE(cli);
 
        TALLOC_FREE(mem_ctx);
 
@@ -2083,16 +1955,17 @@ NTSTATUS cm_connect_sam(struct winbindd_domain *domain, TALLOC_CTX *mem_ctx,
                  "pipe: user %s\\%s\n", domain->name,
                  domain_name, machine_account));
 
-       result = rpccli_samr_connect(conn->samr_pipe, mem_ctx,
-                                    SEC_RIGHTS_MAXIMUM_ALLOWED,
-                                    &conn->sam_connect_handle);
+       result = rpccli_samr_Connect2(conn->samr_pipe, mem_ctx,
+                                     conn->samr_pipe->desthost,
+                                     SEC_RIGHTS_MAXIMUM_ALLOWED,
+                                     &conn->sam_connect_handle);
        if (NT_STATUS_IS_OK(result)) {
                goto open_domain;
        }
-       DEBUG(10,("cm_connect_sam: ntlmssp-sealed rpccli_samr_connect "
+       DEBUG(10,("cm_connect_sam: ntlmssp-sealed rpccli_samr_Connect2 "
                  "failed for domain %s, error was %s. Trying schannel\n",
                  domain->name, nt_errstr(result) ));
-       cli_rpc_pipe_close(conn->samr_pipe);
+       TALLOC_FREE(conn->samr_pipe);
 
  schannel:
 
@@ -2117,16 +1990,17 @@ NTSTATUS cm_connect_sam(struct winbindd_domain *domain, TALLOC_CTX *mem_ctx,
        DEBUG(10,("cm_connect_sam: connected to SAMR pipe for domain %s using "
                  "schannel.\n", domain->name ));
 
-       result = rpccli_samr_connect(conn->samr_pipe, mem_ctx,
-                                    SEC_RIGHTS_MAXIMUM_ALLOWED,
-                                    &conn->sam_connect_handle);
+       result = rpccli_samr_Connect2(conn->samr_pipe, mem_ctx,
+                                     conn->samr_pipe->desthost,
+                                     SEC_RIGHTS_MAXIMUM_ALLOWED,
+                                     &conn->sam_connect_handle);
        if (NT_STATUS_IS_OK(result)) {
                goto open_domain;
        }
-       DEBUG(10,("cm_connect_sam: schannel-sealed rpccli_samr_connect failed "
+       DEBUG(10,("cm_connect_sam: schannel-sealed rpccli_samr_Connect2 failed "
                  "for domain %s, error was %s. Trying anonymous\n",
                  domain->name, nt_errstr(result) ));
-       cli_rpc_pipe_close(conn->samr_pipe);
+       TALLOC_FREE(conn->samr_pipe);
 
  anonymous:
 
@@ -2139,23 +2013,24 @@ NTSTATUS cm_connect_sam(struct winbindd_domain *domain, TALLOC_CTX *mem_ctx,
                goto done;
        }
 
-       result = rpccli_samr_connect(conn->samr_pipe, mem_ctx,
-                                    SEC_RIGHTS_MAXIMUM_ALLOWED,
-                                    &conn->sam_connect_handle);
+       result = rpccli_samr_Connect2(conn->samr_pipe, mem_ctx,
+                                     conn->samr_pipe->desthost,
+                                     SEC_RIGHTS_MAXIMUM_ALLOWED,
+                                     &conn->sam_connect_handle);
        if (!NT_STATUS_IS_OK(result)) {
-               DEBUG(10,("cm_connect_sam: rpccli_samr_connect failed "
+               DEBUG(10,("cm_connect_sam: rpccli_samr_Connect2 failed "
                          "for domain %s Error was %s\n",
                          domain->name, nt_errstr(result) ));
                goto done;
        }
 
  open_domain:
-       result = rpccli_samr_open_domain(conn->samr_pipe,
-                                        mem_ctx,
-                                        &conn->sam_connect_handle,
-                                        SEC_RIGHTS_MAXIMUM_ALLOWED,
-                                        &domain->sid,
-                                        &conn->sam_domain_handle);
+       result = rpccli_samr_OpenDomain(conn->samr_pipe,
+                                       mem_ctx,
+                                       &conn->sam_connect_handle,
+                                       SEC_RIGHTS_MAXIMUM_ALLOWED,
+                                       &domain->sid,
+                                       &conn->sam_domain_handle);
 
  done:
 
@@ -2227,7 +2102,7 @@ NTSTATUS cm_connect_lsa(struct winbindd_domain *domain, TALLOC_CTX *mem_ctx,
        DEBUG(10,("cm_connect_lsa: rpccli_lsa_open_policy failed, trying "
                  "schannel\n"));
 
-       cli_rpc_pipe_close(conn->lsa_pipe);
+       TALLOC_FREE(conn->lsa_pipe);
 
  schannel:
 
@@ -2262,7 +2137,7 @@ NTSTATUS cm_connect_lsa(struct winbindd_domain *domain, TALLOC_CTX *mem_ctx,
        DEBUG(10,("cm_connect_lsa: rpccli_lsa_open_policy failed, trying "
                  "anonymous\n"));
 
-       cli_rpc_pipe_close(conn->lsa_pipe);
+       TALLOC_FREE(conn->lsa_pipe);
 
  anonymous:
 
@@ -2298,7 +2173,7 @@ NTSTATUS cm_connect_netlogon(struct winbindd_domain *domain,
        struct winbindd_cm_conn *conn;
        NTSTATUS result;
 
-       uint32 neg_flags = NETLOGON_NEG_AUTH2_FLAGS;
+       uint32_t neg_flags = NETLOGON_NEG_AUTH2_ADS_FLAGS;
        uint8  mach_pwd[16];
        uint32  sec_chan_type;
        const char *account_name;
@@ -2337,7 +2212,7 @@ NTSTATUS cm_connect_netlogon(struct winbindd_domain *domain,
        if (!get_trust_pw_hash(domain->name, mach_pwd, &account_name,
                               &sec_chan_type))
        {
-               cli_rpc_pipe_close(netlogon_pipe);
+               TALLOC_FREE(netlogon_pipe);
                return NT_STATUS_CANT_ACCESS_DOMAIN_INFO;
        }
 
@@ -2352,20 +2227,25 @@ NTSTATUS cm_connect_netlogon(struct winbindd_domain *domain,
                 &neg_flags);
 
        if (!NT_STATUS_IS_OK(result)) {
-               cli_rpc_pipe_close(netlogon_pipe);
+               TALLOC_FREE(netlogon_pipe);
                return result;
        }
 
        if ((lp_client_schannel() == True) &&
                        ((neg_flags & NETLOGON_NEG_SCHANNEL) == 0)) {
                DEBUG(3, ("Server did not offer schannel\n"));
-               cli_rpc_pipe_close(netlogon_pipe);
+               TALLOC_FREE(netlogon_pipe);
                return NT_STATUS_ACCESS_DENIED;
        }
 
  no_schannel:
        if ((lp_client_schannel() == False) ||
                        ((neg_flags & NETLOGON_NEG_SCHANNEL) == 0)) {
+               /*
+                * NetSamLogonEx only works for schannel
+                */
+               domain->can_do_samlogon_ex = False;
+
                /* We're done - just keep the existing connection to NETLOGON
                 * open */
                conn->netlogon_pipe = netlogon_pipe;
@@ -2387,7 +2267,7 @@ NTSTATUS cm_connect_netlogon(struct winbindd_domain *domain,
                                                    &result);
 
        /* We can now close the initial netlogon pipe. */
-       cli_rpc_pipe_close(netlogon_pipe);
+       TALLOC_FREE(netlogon_pipe);
 
        if (conn->netlogon_pipe == NULL) {
                DEBUG(3, ("Could not open schannel'ed NETLOGON pipe. Error "
@@ -2397,6 +2277,11 @@ NTSTATUS cm_connect_netlogon(struct winbindd_domain *domain,
                return !NT_STATUS_IS_OK(result) ? result : NT_STATUS_PIPE_NOT_AVAILABLE;
        }
 
+       /*
+        * Try NetSamLogonEx for AD domains
+        */
+       domain->can_do_samlogon_ex = domain->active_directory;
+
        *cli = conn->netlogon_pipe;
        return NT_STATUS_OK;
 }