Avoid overriding default ccache for ads operations.
[kai/samba.git] / source3 / winbindd / winbindd_ads.c
index db7ceca04de661aef3c7f5a728c9f74aa7b84013..628fd1c3f2790c7902b0e8651240c6779a1ce921 100644 (file)
@@ -6,23 +6,32 @@
    Copyright (C) Andrew Tridgell 2001
    Copyright (C) Andrew Bartlett <abartlet@samba.org> 2003
    Copyright (C) Gerald (Jerry) Carter 2004
-   
+
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
-   
+
    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.
-   
+
    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
 #include "includes.h"
 #include "winbindd.h"
+#include "rpc_client/rpc_client.h"
+#include "../librpc/gen_ndr/ndr_netlogon_c.h"
+#include "../libds/common/flags.h"
+#include "ads.h"
+#include "secrets.h"
+#include "../libcli/ldap/ldap_ndr.h"
+#include "../libcli/security/security.h"
+#include "../libds/common/flag_mapping.h"
+#include "passdb.h"
 
 #ifdef HAVE_ADS
 
@@ -69,30 +78,31 @@ static ADS_STRUCT *ads_cached_connection(struct winbindd_domain *domain)
                }
        }
 
-       /* we don't want this to affect the users ccache */
-       setenv("KRB5CCNAME", "MEMORY:winbind_ccache", 1);
-
        ads = ads_init(domain->alt_name, domain->name, NULL);
        if (!ads) {
                DEBUG(1,("ads_init for domain %s failed\n", domain->name));
                return NULL;
        }
 
+       /* we don't want ads operations to affect the default ccache */
+       ads->auth.ccache_name = SMB_STRDUP("MEMORY:winbind_ccache");
+
        /* the machine acct password might have change - fetch it every time */
 
        SAFE_FREE(ads->auth.password);
        SAFE_FREE(ads->auth.realm);
 
        if ( IS_DC ) {
-               DOM_SID sid;
-               time_t last_set_time;
 
-               if ( !pdb_get_trusteddom_pw( domain->name, &ads->auth.password, &sid, &last_set_time ) ) {
+               if ( !pdb_get_trusteddom_pw( domain->name, &ads->auth.password, NULL, NULL ) ) {
                        ads_destroy( &ads );
                        return NULL;
                }
                ads->auth.realm = SMB_STRDUP( ads->server.realm );
-               strupper_m( ads->auth.realm );
+               if (!strupper_m( ads->auth.realm )) {
+                       ads_destroy( &ads );
+                       return NULL;
+               }
        }
        else {
                struct winbindd_domain *our_domain = domain;
@@ -107,7 +117,10 @@ static ADS_STRUCT *ads_cached_connection(struct winbindd_domain *domain)
 
                if ( our_domain->alt_name[0] != '\0' ) {
                        ads->auth.realm = SMB_STRDUP( our_domain->alt_name );
-                       strupper_m( ads->auth.realm );
+                       if (!strupper_m( ads->auth.realm )) {
+                               ads_destroy( &ads );
+                               return NULL;
+                       }
                }
                else
                        ads->auth.realm = SMB_STRDUP( lp_realm() );
@@ -153,7 +166,7 @@ static ADS_STRUCT *ads_cached_connection(struct winbindd_domain *domain)
 static NTSTATUS query_user_list(struct winbindd_domain *domain,
                               TALLOC_CTX *mem_ctx,
                               uint32 *num_entries, 
-                              WINBIND_USERINFO **info)
+                              struct wbint_userinfo **pinfo)
 {
        ADS_STRUCT *ads = NULL;
        const char *attrs[] = { "*", NULL };
@@ -174,15 +187,19 @@ static NTSTATUS query_user_list(struct winbindd_domain *domain,
        }
 
        ads = ads_cached_connection(domain);
-       
+
        if (!ads) {
                domain->last_status = NT_STATUS_SERVER_DISABLED;
                goto done;
        }
 
        rc = ads_search_retry(ads, &res, "(objectCategory=user)", attrs);
-       if (!ADS_ERR_OK(rc) || !res) {
+       if (!ADS_ERR_OK(rc)) {
                DEBUG(1,("query_user_list ads_search: %s\n", ads_errstr(rc)));
+               status = ads_ntstatus(rc);
+       } else if (!res) {
+               DEBUG(1,("query_user_list ads_search returned NULL res\n"));
+
                goto done;
        }
 
@@ -192,69 +209,77 @@ static NTSTATUS query_user_list(struct winbindd_domain *domain,
                goto done;
        }
 
-       (*info) = TALLOC_ZERO_ARRAY(mem_ctx, WINBIND_USERINFO, count);
-       if (!*info) {
+       (*pinfo) = talloc_zero_array(mem_ctx, struct wbint_userinfo, count);
+       if (!*pinfo) {
                status = NT_STATUS_NO_MEMORY;
                goto done;
        }
 
-       i = 0;
+       count = 0;
 
        for (msg = ads_first_entry(ads, res); msg; msg = ads_next_entry(ads, msg)) {
-               char *name, *gecos = NULL;
-               char *homedir = NULL;
-               char *shell = NULL;
+               struct wbint_userinfo *info = &((*pinfo)[count]);
                uint32 group;
                uint32 atype;
-               DOM_SID user_sid;
-               gid_t primary_gid = (gid_t)-1;
 
                if (!ads_pull_uint32(ads, msg, "sAMAccountType", &atype) ||
-                   ads_atype_map(atype) != SID_NAME_USER) {
+                   ds_atype_map(atype) != SID_NAME_USER) {
                        DEBUG(1,("Not a user account? atype=0x%x\n", atype));
                        continue;
                }
 
-               name = ads_pull_username(ads, mem_ctx, msg);
-
-               if ( ads_pull_sid( ads, msg, "objectSid", &user_sid ) ) {
-                       status = nss_get_info_cached( domain, &user_sid, mem_ctx, 
-                                              ads, msg, &homedir, &shell, &gecos,
-                                              &primary_gid );
-               }
+               info->acct_name = ads_pull_username(ads, mem_ctx, msg);
+               info->full_name = ads_pull_string(ads, mem_ctx, msg, "name");
+               info->homedir = NULL;
+               info->shell = NULL;
+               info->primary_gid = (gid_t)-1;
 
-               if (gecos == NULL) {
-                       gecos = ads_pull_string(ads, mem_ctx, msg, "name");
-               }
-       
                if (!ads_pull_sid(ads, msg, "objectSid",
-                                 &(*info)[i].user_sid)) {
-                       DEBUG(1,("No sid for %s !?\n", name));
+                                 &info->user_sid)) {
+                       DEBUG(1, ("No sid for %s !?\n", info->acct_name));
                        continue;
                }
+
                if (!ads_pull_uint32(ads, msg, "primaryGroupID", &group)) {
-                       DEBUG(1,("No primary group for %s !?\n", name));
+                       DEBUG(1, ("No primary group for %s !?\n",
+                                 info->acct_name));
                        continue;
                }
+               sid_compose(&info->group_sid, &domain->sid, group);
 
-               (*info)[i].acct_name = name;
-               (*info)[i].full_name = gecos;
-               (*info)[i].homedir = homedir;
-               (*info)[i].shell = shell;
-               (*info)[i].primary_gid = primary_gid;
-               sid_compose(&(*info)[i].group_sid, &domain->sid, group);
-               i++;
+               count += 1;
+       }
+
+       (*num_entries) = count;
+       ads_msgfree(ads, res);
+
+       for (i=0; i<count; i++) {
+               struct wbint_userinfo *info = &((*pinfo)[i]);
+               const char *gecos = NULL;
+               gid_t primary_gid = (gid_t)-1;
+
+               status = nss_get_info_cached(domain, &info->user_sid, mem_ctx,
+                                            &info->homedir, &info->shell,
+                                            &gecos, &primary_gid);
+               if (!NT_STATUS_IS_OK(status)) {
+                       /*
+                        * Deliberately ignore this error, there might be more
+                        * users to fill
+                        */
+                       continue;
+               }
+
+               if (gecos != NULL) {
+                       info->full_name = gecos;
+               }
+               info->primary_gid = primary_gid;
        }
 
-       (*num_entries) = i;
        status = NT_STATUS_OK;
 
        DEBUG(3,("ads query_user_list gave %d entries\n", (*num_entries)));
 
 done:
-       if (res) 
-               ads_msgfree(ads, res);
-
        return status;
 }
 
@@ -262,7 +287,7 @@ done:
 static NTSTATUS enum_dom_groups(struct winbindd_domain *domain,
                                TALLOC_CTX *mem_ctx,
                                uint32 *num_entries, 
-                               struct acct_info **info)
+                               struct wb_acct_info **info)
 {
        ADS_STRUCT *ads = NULL;
        const char *attrs[] = {"userPrincipalName", "sAMAccountName",
@@ -325,9 +350,13 @@ static NTSTATUS enum_dom_groups(struct winbindd_domain *domain,
        }
 
        rc = ads_search_retry(ads, &res, filter, attrs);
-       if (!ADS_ERR_OK(rc) || !res) {
+       if (!ADS_ERR_OK(rc)) {
+               status = ads_ntstatus(rc);
                DEBUG(1,("enum_dom_groups ads_search: %s\n", ads_errstr(rc)));
                goto done;
+       } else if (!res) {
+               DEBUG(1,("enum_dom_groups ads_search returned NULL res\n"));
+               goto done;
        }
 
        count = ads_count_replies(ads, res);
@@ -336,17 +365,17 @@ static NTSTATUS enum_dom_groups(struct winbindd_domain *domain,
                goto done;
        }
 
-       (*info) = TALLOC_ZERO_ARRAY(mem_ctx, struct acct_info, count);
+       (*info) = talloc_zero_array(mem_ctx, struct wb_acct_info, count);
        if (!*info) {
                status = NT_STATUS_NO_MEMORY;
                goto done;
        }
 
        i = 0;
-       
+
        for (msg = ads_first_entry(ads, res); msg; msg = ads_next_entry(ads, msg)) {
                char *name, *gecos;
-               DOM_SID sid;
+               struct dom_sid sid;
                uint32 rid;
 
                name = ads_pull_username(ads, mem_ctx, msg);
@@ -384,7 +413,7 @@ done:
 static NTSTATUS enum_local_groups(struct winbindd_domain *domain,
                                TALLOC_CTX *mem_ctx,
                                uint32 *num_entries, 
-                               struct acct_info **info)
+                               struct wb_acct_info **info)
 {
        /*
         * This is a stub function only as we returned the domain 
@@ -393,14 +422,55 @@ static NTSTATUS enum_local_groups(struct winbindd_domain *domain,
         * using LDAP.
         *
         * if we ever need to enumerate domain local groups separately, 
-        * then this the optimization in enum_dom_groups() will need 
+        * then this optimization in enum_dom_groups() will need
         * to be split out
         */
        *num_entries = 0;
-       
+
        return NT_STATUS_OK;
 }
 
+/* convert a single name to a sid in a domain - use rpc methods */
+static NTSTATUS name_to_sid(struct winbindd_domain *domain,
+                           TALLOC_CTX *mem_ctx,
+                           const char *domain_name,
+                           const char *name,
+                           uint32_t flags,
+                           struct dom_sid *sid,
+                           enum lsa_SidType *type)
+{
+       return reconnect_methods.name_to_sid(domain, mem_ctx,
+                                            domain_name, name, flags,
+                                            sid, type);
+}
+
+/* convert a domain SID to a user or group name - use rpc methods */
+static NTSTATUS sid_to_name(struct winbindd_domain *domain,
+                           TALLOC_CTX *mem_ctx,
+                           const struct dom_sid *sid,
+                           char **domain_name,
+                           char **name,
+                           enum lsa_SidType *type)
+{
+       return reconnect_methods.sid_to_name(domain, mem_ctx, sid,
+                                            domain_name, name, type);
+}
+
+/* convert a list of rids to names - use rpc methods */
+static NTSTATUS rids_to_names(struct winbindd_domain *domain,
+                             TALLOC_CTX *mem_ctx,
+                             const struct dom_sid *sid,
+                             uint32 *rids,
+                             size_t num_rids,
+                             char **domain_name,
+                             char ***names,
+                             enum lsa_SidType **types)
+{
+       return reconnect_methods.rids_to_names(domain, mem_ctx, sid,
+                                              rids, num_rids,
+                                              domain_name, names, types);
+}
+
 /* If you are looking for "dn_lookup": Yes, it used to be here!
  * It has gone now since it was a major speed bottleneck in
  * lookup_groupmem (its only use). It has been replaced by
@@ -409,8 +479,8 @@ static NTSTATUS enum_local_groups(struct winbindd_domain *domain,
 /* Lookup user information from a rid */
 static NTSTATUS query_user(struct winbindd_domain *domain, 
                           TALLOC_CTX *mem_ctx, 
-                          const DOM_SID *sid, 
-                          WINBIND_USERINFO *info)
+                          const struct dom_sid *sid,
+                          struct wbint_userinfo *info)
 {
        ADS_STRUCT *ads = NULL;
        const char *attrs[] = { "*", NULL };
@@ -421,34 +491,36 @@ static NTSTATUS query_user(struct winbindd_domain *domain,
        char *sidstr;
        uint32 group_rid;
        NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
-       NET_USER_INFO_3 *user;
+       struct netr_SamInfo3 *user = NULL;
+       gid_t gid = -1;
+       int ret;
+       char *ads_name;
 
        DEBUG(3,("ads: query_user\n"));
 
        info->homedir = NULL;
        info->shell = NULL;
-       info->primary_gid = (gid_t)-1;
 
        /* try netsamlogon cache first */
-                       
-       if ( (user = netsamlogon_cache_get( mem_ctx, sid )) != NULL ) 
+
+       if (winbindd_use_cache() && (user = netsamlogon_cache_get( mem_ctx, sid )) != NULL )
        {
-                               
                DEBUG(5,("query_user: Cache lookup succeeded for %s\n", 
                         sid_string_dbg(sid)));
 
-               sid_compose(&info->user_sid, &domain->sid, user->user_rid);
-               sid_compose(&info->group_sid, &domain->sid, user->group_rid);
-                               
-               info->acct_name = unistr2_to_ascii_talloc(mem_ctx, &user->uni_user_name);
-               info->full_name = unistr2_to_ascii_talloc(mem_ctx, &user->uni_full_name);
-               
-               nss_get_info_cached( domain, sid, mem_ctx, NULL, NULL, 
+               sid_compose(&info->user_sid, &domain->sid, user->base.rid);
+               sid_compose(&info->group_sid, &domain->sid, user->base.primary_gid);
+
+               info->acct_name = talloc_strdup(mem_ctx, user->base.account_name.string);
+               info->full_name = talloc_strdup(mem_ctx, user->base.full_name.string);
+
+               nss_get_info_cached( domain, sid, mem_ctx,
                              &info->homedir, &info->shell, &info->full_name, 
-                             &info->primary_gid );     
+                             &gid );
+               info->primary_gid = gid;
 
                TALLOC_FREE(user);
-                               
+
                return NT_STATUS_OK;
        }
 
@@ -464,70 +536,93 @@ static NTSTATUS query_user(struct winbindd_domain *domain,
 
                /* Assume "Domain Users" for the primary group */
 
-               sid_compose(&info->group_sid, &domain->sid, DOMAIN_GROUP_RID_USERS );
+               sid_compose(&info->group_sid, &domain->sid, DOMAIN_RID_USERS );
 
                /* Try to fill in what the nss_info backend can do */
 
-               nss_get_info_cached( domain, sid, mem_ctx, NULL, NULL, 
+               nss_get_info_cached( domain, sid, mem_ctx,
                              &info->homedir, &info->shell, &info->full_name, 
-                             &info->primary_gid );
+                             &gid);
+               info->primary_gid = gid;
 
-               status = NT_STATUS_OK;
-               goto done;
+               return NT_STATUS_OK;
        }
 
        /* no cache...do the query */
 
        if ( (ads = ads_cached_connection(domain)) == NULL ) {
                domain->last_status = NT_STATUS_SERVER_DISABLED;
-               goto done;
+               return NT_STATUS_SERVER_DISABLED;
        }
 
-       sidstr = sid_binstring(sid);
-       asprintf(&ldap_exp, "(objectSid=%s)", sidstr);
+       sidstr = ldap_encode_ndr_dom_sid(talloc_tos(), sid);
+
+       ret = asprintf(&ldap_exp, "(objectSid=%s)", sidstr);
+       TALLOC_FREE(sidstr);
+       if (ret == -1) {
+               return NT_STATUS_NO_MEMORY;
+       }
        rc = ads_search_retry(ads, &msg, ldap_exp, attrs);
-       free(ldap_exp);
-       free(sidstr);
-       if (!ADS_ERR_OK(rc) || !msg) {
+       SAFE_FREE(ldap_exp);
+       if (!ADS_ERR_OK(rc)) {
                DEBUG(1,("query_user(sid=%s) ads_search: %s\n",
                         sid_string_dbg(sid), ads_errstr(rc)));
-               goto done;
+               return ads_ntstatus(rc);
+       } else if (!msg) {
+               DEBUG(1,("query_user(sid=%s) ads_search returned NULL res\n",
+                        sid_string_dbg(sid)));
+               return NT_STATUS_INTERNAL_ERROR;
        }
 
        count = ads_count_replies(ads, msg);
        if (count != 1) {
                DEBUG(1,("query_user(sid=%s): Not found\n",
                         sid_string_dbg(sid)));
-               goto done;
+               ads_msgfree(ads, msg);
+               return NT_STATUS_NO_SUCH_USER;
        }
 
        info->acct_name = ads_pull_username(ads, mem_ctx, msg);
 
-       nss_get_info_cached( domain, sid, mem_ctx, ads, msg, 
-                     &info->homedir, &info->shell, &info->full_name, 
-                     &info->primary_gid );     
-
-       if (info->full_name == NULL) {
-               info->full_name = ads_pull_string(ads, mem_ctx, msg, "name");
-       }
-
        if (!ads_pull_uint32(ads, msg, "primaryGroupID", &group_rid)) {
                DEBUG(1,("No primary group for %s !?\n",
                         sid_string_dbg(sid)));
-               goto done;
+               ads_msgfree(ads, msg);
+               return NT_STATUS_NO_SUCH_USER;
        }
-
        sid_copy(&info->user_sid, sid);
        sid_compose(&info->group_sid, &domain->sid, group_rid);
 
+       /*
+        * We have to fetch the "name" attribute before doing the
+        * nss_get_info_cached call. nss_get_info_cached might destroy
+        * the ads struct, potentially invalidating the ldap message.
+        */
+       ads_name = ads_pull_string(ads, mem_ctx, msg, "name");
+
+       ads_msgfree(ads, msg);
+       msg = NULL;
+
+       status = nss_get_info_cached( domain, sid, mem_ctx,
+                     &info->homedir, &info->shell, &info->full_name, 
+                     &gid);
+       info->primary_gid = gid;
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(1, ("nss_get_info_cached failed: %s\n",
+                         nt_errstr(status)));
+               return status;
+       }
+
+       if (info->full_name == NULL) {
+               info->full_name = ads_name;
+       } else {
+               TALLOC_FREE(ads_name);
+       }
+
        status = NT_STATUS_OK;
 
        DEBUG(3,("ads query_user gave %s\n", info->acct_name));
-done:
-       if (msg) 
-               ads_msgfree(ads, msg);
-
-       return status;
+       return NT_STATUS_OK;
 }
 
 /* Lookup groups a user is a member of - alternate method, for when
@@ -535,8 +630,8 @@ done:
 static NTSTATUS lookup_usergroups_member(struct winbindd_domain *domain,
                                         TALLOC_CTX *mem_ctx,
                                         const char *user_dn, 
-                                        DOM_SID *primary_group,
-                                        size_t *p_num_groups, DOM_SID **user_sids)
+                                        struct dom_sid *primary_group,
+                                        uint32_t *p_num_groups, struct dom_sid **user_sids)
 {
        ADS_STATUS rc;
        NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
@@ -547,7 +642,7 @@ static NTSTATUS lookup_usergroups_member(struct winbindd_domain *domain,
        ADS_STRUCT *ads;
        const char *group_attrs[] = {"objectSid", NULL};
        char *escaped_dn;
-       size_t num_groups = 0;
+       uint32_t num_groups = 0;
 
        DEBUG(3,("ads: lookup_usergroups_member\n"));
 
@@ -564,7 +659,7 @@ static NTSTATUS lookup_usergroups_member(struct winbindd_domain *domain,
                goto done;
        }
 
-       if (!(escaped_dn = escape_ldap_string_alloc(user_dn))) {
+       if (!(escaped_dn = escape_ldap_string(talloc_tos(), user_dn))) {
                status = NT_STATUS_NO_MEMORY;
                goto done;
        }
@@ -576,22 +671,26 @@ static NTSTATUS lookup_usergroups_member(struct winbindd_domain *domain,
                GROUP_TYPE_SECURITY_ENABLED);
        if (!ldap_exp) {
                DEBUG(1,("lookup_usergroups(dn=%s) asprintf failed!\n", user_dn));
-               SAFE_FREE(escaped_dn);
+               TALLOC_FREE(escaped_dn);
                status = NT_STATUS_NO_MEMORY;
                goto done;
        }
 
-       SAFE_FREE(escaped_dn);
+       TALLOC_FREE(escaped_dn);
 
        rc = ads_search_retry(ads, &res, ldap_exp, group_attrs);
-       
-       if (!ADS_ERR_OK(rc) || !res) {
+
+       if (!ADS_ERR_OK(rc)) {
                DEBUG(1,("lookup_usergroups ads_search member=%s: %s\n", user_dn, ads_errstr(rc)));
                return ads_ntstatus(rc);
+       } else if (!res) {
+               DEBUG(1,("lookup_usergroups ads_search returned NULL res\n"));
+               return NT_STATUS_INTERNAL_ERROR;
        }
-       
+
+
        count = ads_count_replies(ads, res);
-       
+
        *user_sids = NULL;
        num_groups = 0;
 
@@ -605,13 +704,13 @@ static NTSTATUS lookup_usergroups_member(struct winbindd_domain *domain,
        if (count > 0) {
                for (msg = ads_first_entry(ads, res); msg;
                     msg = ads_next_entry(ads, msg)) {
-                       DOM_SID group_sid;
-               
+                       struct dom_sid group_sid;
+
                        if (!ads_pull_sid(ads, msg, "objectSid", &group_sid)) {
                                DEBUG(1,("No sid for this group ?!?\n"));
                                continue;
                        }
-       
+
                        /* ignore Builtin groups from ADS - Guenther */
                        if (sid_check_is_in_builtin(&group_sid)) {
                                continue;
@@ -641,26 +740,27 @@ done:
    tokenGroups are not available. */
 static NTSTATUS lookup_usergroups_memberof(struct winbindd_domain *domain,
                                           TALLOC_CTX *mem_ctx,
-                                          const char *user_dn, 
-                                          DOM_SID *primary_group,
-                                          size_t *p_num_groups, DOM_SID **user_sids)
+                                          const char *user_dn,
+                                          struct dom_sid *primary_group,
+                                          uint32_t *p_num_groups,
+                                          struct dom_sid **user_sids)
 {
        ADS_STATUS rc;
        NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
        ADS_STRUCT *ads;
        const char *attrs[] = {"memberOf", NULL};
-       size_t num_groups = 0;
-       DOM_SID *group_sids = NULL;
+       uint32_t num_groups = 0;
+       struct dom_sid *group_sids = NULL;
        int i;
-       char **strings;
-       size_t num_strings = 0;
+       char **strings = NULL;
+       size_t num_strings = 0, num_sids = 0;
 
 
        DEBUG(3,("ads: lookup_usergroups_memberof\n"));
 
        if ( !winbindd_can_contact_domain( domain ) ) {
-               DEBUG(10,("lookup_usergroups_memberof: No incoming trust for domain %s\n",
-                         domain->name));               
+               DEBUG(10,("lookup_usergroups_memberof: No incoming trust for "
+                         "domain %s\n", domain->name));
                return NT_STATUS_OK;
        }
 
@@ -668,19 +768,19 @@ static NTSTATUS lookup_usergroups_memberof(struct winbindd_domain *domain,
 
        if (!ads) {
                domain->last_status = NT_STATUS_SERVER_DISABLED;
-               goto done;
+               return NT_STATUS_UNSUCCESSFUL;
        }
 
-       rc = ads_search_retry_extended_dn_ranged(ads, mem_ctx, user_dn, attrs, 
-                                                ADS_EXTENDED_DN_HEX_STRING, 
+       rc = ads_search_retry_extended_dn_ranged(ads, mem_ctx, user_dn, attrs,
+                                                ADS_EXTENDED_DN_HEX_STRING,
                                                 &strings, &num_strings);
 
        if (!ADS_ERR_OK(rc)) {
-               DEBUG(1,("lookup_usergroups_memberof ads_search member=%s: %s\n", 
-                       user_dn, ads_errstr(rc)));
+               DEBUG(1,("lookup_usergroups_memberof ads_search "
+                       "member=%s: %s\n", user_dn, ads_errstr(rc)));
                return ads_ntstatus(rc);
        }
-       
+
        *user_sids = NULL;
        num_groups = 0;
 
@@ -691,23 +791,28 @@ static NTSTATUS lookup_usergroups_memberof(struct winbindd_domain *domain,
                goto done;
        }
 
-       group_sids = TALLOC_ZERO_ARRAY(mem_ctx, DOM_SID, num_strings + 1);
+       group_sids = talloc_zero_array(mem_ctx, struct dom_sid, num_strings + 1);
        if (!group_sids) {
-               TALLOC_FREE(strings);
                status = NT_STATUS_NO_MEMORY;
                goto done;
        }
 
        for (i=0; i<num_strings; i++) {
-
-               if (!ads_get_sid_from_extended_dn(mem_ctx, strings[i], 
-                                                 ADS_EXTENDED_DN_HEX_STRING, 
-                                                 &(group_sids)[i])) {
-                       TALLOC_FREE(group_sids);
-                       TALLOC_FREE(strings);
-                       status = NT_STATUS_NO_MEMORY;
-                       goto done;
+               rc = ads_get_sid_from_extended_dn(mem_ctx, strings[i],
+                                                 ADS_EXTENDED_DN_HEX_STRING,
+                                                 &(group_sids)[i]);
+               if (!ADS_ERR_OK(rc)) {
+                       /* ignore members without SIDs */
+                       if (NT_STATUS_EQUAL(ads_ntstatus(rc),
+                           NT_STATUS_NOT_FOUND)) {
+                               continue;
+                       }
+                       else {
+                               status = ads_ntstatus(rc);
+                               goto done;
+                       }
                }
+               num_sids++;
        }
 
        if (i == 0) {
@@ -716,7 +821,7 @@ static NTSTATUS lookup_usergroups_memberof(struct winbindd_domain *domain,
                goto done;
        }
 
-       for (i=0; i<num_strings; i++) {
+       for (i=0; i<num_sids; i++) {
 
                /* ignore Builtin groups from ADS - Guenther */
                if (sid_check_is_in_builtin(&group_sids[i])) {
@@ -728,14 +833,17 @@ static NTSTATUS lookup_usergroups_memberof(struct winbindd_domain *domain,
                if (!NT_STATUS_IS_OK(status)) {
                        goto done;
                }
-       
+
        }
 
        *p_num_groups = num_groups;
        status = (*user_sids != NULL) ? NT_STATUS_OK : NT_STATUS_NO_MEMORY;
 
-       DEBUG(3,("ads lookup_usergroups (memberof) succeeded for dn=%s\n", user_dn));
+       DEBUG(3,("ads lookup_usergroups (memberof) succeeded for dn=%s\n",
+               user_dn));
+
 done:
+       TALLOC_FREE(strings);
        TALLOC_FREE(group_sids);
 
        return status;
@@ -745,8 +853,8 @@ done:
 /* Lookup groups a user is a member of. */
 static NTSTATUS lookup_usergroups(struct winbindd_domain *domain,
                                  TALLOC_CTX *mem_ctx,
-                                 const DOM_SID *sid, 
-                                 uint32 *p_num_groups, DOM_SID **user_sids)
+                                 const struct dom_sid *sid,
+                                 uint32 *p_num_groups, struct dom_sid **user_sids)
 {
        ADS_STRUCT *ads = NULL;
        const char *attrs[] = {"tokenGroups", "primaryGroupID", NULL};
@@ -754,12 +862,12 @@ static NTSTATUS lookup_usergroups(struct winbindd_domain *domain,
        int count;
        LDAPMessage *msg = NULL;
        char *user_dn = NULL;
-       DOM_SID *sids;
+       struct dom_sid *sids;
        int i;
-       DOM_SID primary_group;
+       struct dom_sid primary_group;
        uint32 primary_group_rid;
        NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
-       size_t num_groups = 0;
+       uint32_t num_groups = 0;
 
        DEBUG(3,("ads: lookup_usergroups\n"));
        *p_num_groups = 0;
@@ -780,7 +888,7 @@ static NTSTATUS lookup_usergroups(struct winbindd_domain *domain,
        }
 
        ads = ads_cached_connection(domain);
-       
+
        if (!ads) {
                domain->last_status = NT_STATUS_SERVER_DISABLED;
                status = NT_STATUS_SERVER_DISABLED;
@@ -795,7 +903,7 @@ static NTSTATUS lookup_usergroups(struct winbindd_domain *domain,
                          "%s\n", sid_string_dbg(sid), ads_errstr(rc)));
                goto done;
        }
-       
+
        count = ads_count_replies(ads, msg);
        if (count != 1) {
                status = NT_STATUS_UNSUCCESSFUL;
@@ -812,7 +920,7 @@ static NTSTATUS lookup_usergroups(struct winbindd_domain *domain,
                goto done;
        }
 
-       user_dn = ads_get_dn(ads, msg);
+       user_dn = ads_get_dn(ads, mem_ctx, msg);
        if (user_dn == NULL) {
                status = NT_STATUS_NO_MEMORY;
                goto done;
@@ -824,8 +932,7 @@ static NTSTATUS lookup_usergroups(struct winbindd_domain *domain,
                goto done;
        }
 
-       sid_copy(&primary_group, &domain->sid);
-       sid_append_rid(&primary_group, primary_group_rid);
+       sid_compose(&primary_group, &domain->sid, primary_group_rid);
 
        count = ads_pull_sids(ads, mem_ctx, msg, "tokenGroups", &sids);
 
@@ -838,14 +945,14 @@ static NTSTATUS lookup_usergroups(struct winbindd_domain *domain,
        if (count == 0) {
 
                /* no tokenGroups */
-               
+
                /* lookup what groups this user is a member of by DN search on
                 * "memberOf" */
 
                status = lookup_usergroups_memberof(domain, mem_ctx, user_dn,
                                                    &primary_group,
                                                    &num_groups, user_sids);
-               *p_num_groups = (uint32)num_groups;
+               *p_num_groups = num_groups;
                if (NT_STATUS_IS_OK(status)) {
                        goto done;
                }
@@ -856,7 +963,7 @@ static NTSTATUS lookup_usergroups(struct winbindd_domain *domain,
                status = lookup_usergroups_member(domain, mem_ctx, user_dn, 
                                                  &primary_group,
                                                  &num_groups, user_sids);
-               *p_num_groups = (uint32)num_groups;
+               *p_num_groups = num_groups;
                goto done;
        }
 
@@ -868,7 +975,7 @@ static NTSTATUS lookup_usergroups(struct winbindd_domain *domain,
        if (!NT_STATUS_IS_OK(status)) {
                goto done;
        }
-       
+
        for (i=0;i<count;i++) {
 
                /* ignore Builtin groups from ADS - Guenther */
@@ -889,18 +996,32 @@ static NTSTATUS lookup_usergroups(struct winbindd_domain *domain,
        DEBUG(3,("ads lookup_usergroups (tokenGroups) succeeded for sid=%s\n",
                 sid_string_dbg(sid)));
 done:
-       ads_memfree(ads, user_dn);
+       TALLOC_FREE(user_dn);
        ads_msgfree(ads, msg);
        return status;
 }
 
+/* Lookup aliases a user is member of - use rpc methods */
+static NTSTATUS lookup_useraliases(struct winbindd_domain *domain,
+                                  TALLOC_CTX *mem_ctx,
+                                  uint32 num_sids, const struct dom_sid *sids,
+                                  uint32 *num_aliases, uint32 **alias_rids)
+{
+       return reconnect_methods.lookup_useraliases(domain, mem_ctx,
+                                                   num_sids, sids,
+                                                   num_aliases,
+                                                   alias_rids);
+}
+
 /*
   find the members of a group, given a group rid and domain
  */
 static NTSTATUS lookup_groupmem(struct winbindd_domain *domain,
                                TALLOC_CTX *mem_ctx,
-                               const DOM_SID *group_sid, uint32 *num_names, 
-                               DOM_SID **sid_mem, char ***names, 
+                               const struct dom_sid *group_sid,
+                               enum lsa_SidType type,
+                               uint32 *num_names,
+                               struct dom_sid **sid_mem, char ***names,
                                uint32 **name_types)
 {
        ADS_STATUS rc;
@@ -912,16 +1033,14 @@ static NTSTATUS lookup_groupmem(struct winbindd_domain *domain,
        int i;
        size_t num_members = 0;
        ads_control args;
-        struct rpc_pipe_client *cli;
-        POLICY_HND lsa_policy;
-       DOM_SID *sid_mem_nocache = NULL;
+       struct dom_sid *sid_mem_nocache = NULL;
        char **names_nocache = NULL;
        enum lsa_SidType *name_types_nocache = NULL;
        char **domains_nocache = NULL;     /* only needed for rpccli_lsa_lookup_sids */
        uint32 num_nocache = 0;
        TALLOC_CTX *tmp_ctx = NULL;
 
-       DEBUG(10,("ads: lookup_groupmem %s sid=%s\n", domain->name, 
+       DEBUG(10,("ads: lookup_groupmem %s sid=%s\n", domain->name,
                  sid_string_dbg(group_sid)));
 
        *num_names = 0;
@@ -935,52 +1054,50 @@ static NTSTATUS lookup_groupmem(struct winbindd_domain *domain,
 
        if ( !winbindd_can_contact_domain( domain ) ) {
                DEBUG(10,("lookup_groupmem: No incoming trust for domain %s\n",
-                         domain->name));               
+                         domain->name));
                return NT_STATUS_OK;
        }
 
        ads = ads_cached_connection(domain);
-       
+
        if (!ads) {
                domain->last_status = NT_STATUS_SERVER_DISABLED;
                goto done;
        }
 
-       if ((sidbinstr = sid_binstring(group_sid)) == NULL) {
+       if ((sidbinstr = ldap_encode_ndr_dom_sid(talloc_tos(), group_sid)) == NULL) {
                status = NT_STATUS_NO_MEMORY;
                goto done;
        }
 
        /* search for all members of the group */
-       if (!(ldap_exp = talloc_asprintf(tmp_ctx, "(objectSid=%s)", 
-                                        sidbinstr))) 
-       {
-               SAFE_FREE(sidbinstr);
+       ldap_exp = talloc_asprintf(tmp_ctx, "(objectSid=%s)", sidbinstr);
+       TALLOC_FREE(sidbinstr);
+       if (ldap_exp == NULL) {
                DEBUG(1, ("ads: lookup_groupmem: talloc_asprintf for ldap_exp failed!\n"));
                status = NT_STATUS_NO_MEMORY;
                goto done;
        }
-       SAFE_FREE(sidbinstr);
 
        args.control = ADS_EXTENDED_DN_OID;
        args.val = ADS_EXTENDED_DN_HEX_STRING;
        args.critical = True;
 
-       rc = ads_ranged_search(ads, tmp_ctx, LDAP_SCOPE_SUBTREE, ads->config.bind_path, 
+       rc = ads_ranged_search(ads, tmp_ctx, LDAP_SCOPE_SUBTREE, ads->config.bind_path,
                               ldap_exp, &args, "member", &members, &num_members);
 
        if (!ADS_ERR_OK(rc)) {
                DEBUG(0,("ads_ranged_search failed with: %s\n", ads_errstr(rc)));
                status = NT_STATUS_UNSUCCESSFUL;
                goto done;
-       } 
-       
+       }
+
        DEBUG(10, ("ads lookup_groupmem: got %d sids via extended dn call\n", (int)num_members));
-       
+
        /* Now that we have a list of sids, we need to get the
         * lists of names and name_types belonging to these sids.
-        * even though conceptually not quite clean,  we use the 
-        * RPC call lsa_lookup_sids for this since it can handle a 
+        * even though conceptually not quite clean,  we use the
+        * RPC call lsa_lookup_sids for this since it can handle a
         * list of sids. ldap calls can just resolve one sid at a time.
         *
         * At this stage, the sids are still hidden in the exetended dn
@@ -988,12 +1105,12 @@ static NTSTATUS lookup_groupmem(struct winbindd_domain *domain,
         * stated above: In extracting the sids from the member strings,
         * we try to resolve as many sids as possible from the
         * cache. Only the rest is passed to the lsa_lookup_sids call. */
-       
+
        if (num_members) {
-               (*sid_mem) = TALLOC_ZERO_ARRAY(mem_ctx, DOM_SID, num_members);
-               (*names) = TALLOC_ZERO_ARRAY(mem_ctx, char *, num_members);
-               (*name_types) = TALLOC_ZERO_ARRAY(mem_ctx, uint32, num_members);
-               (sid_mem_nocache) = TALLOC_ZERO_ARRAY(tmp_ctx, DOM_SID, num_members);
+               (*sid_mem) = talloc_zero_array(mem_ctx, struct dom_sid, num_members);
+               (*names) = talloc_zero_array(mem_ctx, char *, num_members);
+               (*name_types) = talloc_zero_array(mem_ctx, uint32, num_members);
+               (sid_mem_nocache) = talloc_zero_array(tmp_ctx, struct dom_sid, num_members);
 
                if ((members == NULL) || (*sid_mem == NULL) ||
                    (*names == NULL) || (*name_types == NULL) ||
@@ -1013,20 +1130,33 @@ static NTSTATUS lookup_groupmem(struct winbindd_domain *domain,
        for (i=0; i<num_members; i++) {
                enum lsa_SidType name_type;
                char *name, *domain_name;
-               DOM_SID sid;
-
-               if (!ads_get_sid_from_extended_dn(tmp_ctx, members[i], args.val, &sid)) {
-                       status = NT_STATUS_INVALID_PARAMETER;
-                       goto done;
+               struct dom_sid sid;
+
+               rc = ads_get_sid_from_extended_dn(tmp_ctx, members[i], args.val,
+                   &sid);
+               if (!ADS_ERR_OK(rc)) {
+                       if (NT_STATUS_EQUAL(ads_ntstatus(rc),
+                           NT_STATUS_NOT_FOUND)) {
+                               /* Group members can be objects, like Exchange
+                                * Public Folders, that don't have a SID.  Skip
+                                * them. */
+                               continue;
+                       }
+                       else {
+                               status = ads_ntstatus(rc);
+                               goto done;
+                       }
                }
-               if (lookup_cached_sid(mem_ctx, &sid, &domain_name, &name, &name_type)) {
+               if (lookup_cached_sid(mem_ctx, &sid, &domain_name, &name,
+                   &name_type)) {
                        DEBUG(10,("ads: lookup_groupmem: got sid %s from "
                                  "cache\n", sid_string_dbg(&sid)));
                        sid_copy(&(*sid_mem)[*num_names], &sid);
-                       (*names)[*num_names] = talloc_asprintf(*names, "%s%c%s",
-                                                              domain_name,
-                                                              *lp_winbind_separator(),
-                                                              name );
+                       (*names)[*num_names] = fill_domain_username_talloc(
+                                                       *names,
+                                                       domain_name,
+                                                       name,
+                                                       true);
 
                        (*name_types)[*num_names] = name_type;
                        (*num_names)++;
@@ -1045,37 +1175,48 @@ static NTSTATUS lookup_groupmem(struct winbindd_domain *domain,
        /* handle sids not resolved from cache by lsa_lookup_sids */
        if (num_nocache > 0) {
 
-               status = cm_connect_lsa(domain, tmp_ctx, &cli, &lsa_policy);
-
-               if (!NT_STATUS_IS_OK(status)) {
-                       goto done;
+               status = winbindd_lookup_sids(tmp_ctx,
+                                             domain,
+                                             num_nocache,
+                                             sid_mem_nocache,
+                                             &domains_nocache,
+                                             &names_nocache,
+                                             &name_types_nocache);
+
+               if (!(NT_STATUS_IS_OK(status) ||
+                     NT_STATUS_EQUAL(status, STATUS_SOME_UNMAPPED) ||
+                     NT_STATUS_EQUAL(status, NT_STATUS_NONE_MAPPED)))
+               {
+                       DEBUG(1, ("lsa_lookupsids call failed with %s "
+                                 "- retrying...\n", nt_errstr(status)));
+
+                       status = winbindd_lookup_sids(tmp_ctx,
+                                                     domain,
+                                                     num_nocache,
+                                                     sid_mem_nocache,
+                                                     &domains_nocache,
+                                                     &names_nocache,
+                                                     &name_types_nocache);
                }
 
-               status = rpccli_lsa_lookup_sids(cli, tmp_ctx, 
-                                               &lsa_policy,
-                                               num_nocache, 
-                                               sid_mem_nocache, 
-                                               &domains_nocache, 
-                                               &names_nocache, 
-                                               &name_types_nocache);
-
                if (NT_STATUS_IS_OK(status) ||
-                   NT_STATUS_EQUAL(status, STATUS_SOME_UNMAPPED)) 
+                   NT_STATUS_EQUAL(status, STATUS_SOME_UNMAPPED))
                {
-                       /* Copy the entries over from the "_nocache" arrays 
-                        * to the result arrays, skipping the gaps the 
+                       /* Copy the entries over from the "_nocache" arrays
+                        * to the result arrays, skipping the gaps the
                         * lookup_sids call left. */
                        for (i=0; i < num_nocache; i++) {
-                               if (((names_nocache)[i] != NULL) && 
-                                   ((name_types_nocache)[i] != SID_NAME_UNKNOWN)) 
+                               if (((names_nocache)[i] != NULL) &&
+                                   ((name_types_nocache)[i] != SID_NAME_UNKNOWN))
                                {
                                        sid_copy(&(*sid_mem)[*num_names],
                                                 &sid_mem_nocache[i]);
-                                       (*names)[*num_names] = talloc_asprintf( *names, 
-                                                                               "%s%c%s",
-                                                                               domains_nocache[i],
-                                                                               *lp_winbind_separator(),
-                                                                               names_nocache[i] );
+                                       (*names)[*num_names] =
+                                               fill_domain_username_talloc(
+                                                       *names,
+                                                       domains_nocache[i],
+                                                       names_nocache[i],
+                                                       true);
                                        (*name_types)[*num_names] = name_types_nocache[i];
                                        (*num_names)++;
                                }
@@ -1125,16 +1266,16 @@ static NTSTATUS sequence_number(struct winbindd_domain *domain, uint32 *seq)
        *seq = DOM_SEQUENCE_NONE;
 
        ads = ads_cached_connection(domain);
-       
+
        if (!ads) {
                domain->last_status = NT_STATUS_SERVER_DISABLED;
                return NT_STATUS_UNSUCCESSFUL;
        }
 
        rc = ads_USN(ads, seq);
-       
+
        if (!ADS_ERR_OK(rc)) {
-       
+
                /* its a dead connection, destroy it */
 
                if (domain->private_data) {
@@ -1148,36 +1289,44 @@ static NTSTATUS sequence_number(struct winbindd_domain *domain, uint32 *seq)
        return ads_ntstatus(rc);
 }
 
+/* find the lockout policy of a domain - use rpc methods */
+static NTSTATUS lockout_policy(struct winbindd_domain *domain,
+                              TALLOC_CTX *mem_ctx,
+                              struct samr_DomInfo12 *policy)
+{
+       return reconnect_methods.lockout_policy(domain, mem_ctx, policy);
+}
+
+/* find the password policy of a domain - use rpc methods */
+static NTSTATUS password_policy(struct winbindd_domain *domain,
+                               TALLOC_CTX *mem_ctx,
+                               struct samr_DomInfo1 *policy)
+{
+       return reconnect_methods.password_policy(domain, mem_ctx, policy);
+}
+
 /* get a list of trusted domains */
 static NTSTATUS trusted_domains(struct winbindd_domain *domain,
                                TALLOC_CTX *mem_ctx,
-                               uint32 *num_domains,
-                               char ***names,
-                               char ***alt_names,
-                               DOM_SID **dom_sids)
+                               struct netr_DomainTrustList *trusts)
 {
        NTSTATUS                result = NT_STATUS_UNSUCCESSFUL;
-       struct netr_DomainTrustList trusts;
+       WERROR werr;
        int                     i;
        uint32                  flags;  
        struct rpc_pipe_client *cli;
-       uint32                 fr_flags = (NETR_TRUST_FLAG_IN_FOREST | NETR_TRUST_FLAG_TREEROOT);
        int ret_count;
-       
+       struct dcerpc_binding_handle *b;
+
        DEBUG(3,("ads: trusted_domains\n"));
 
-       *num_domains = 0;
-       *alt_names   = NULL;
-       *names       = NULL;
-       *dom_sids    = NULL;
+       ZERO_STRUCTP(trusts);
 
        /* If this is our primary domain or a root in our forest,
           query for all trusts.  If not, then just look for domain
           trusts in the target forest */
 
-       if ( domain->primary ||
-               ((domain->domain_flags&fr_flags) == fr_flags) ) 
-       {
+       if (domain->primary || domain_is_forest_root(domain)) {
                flags = NETR_TRUST_FLAG_OUTBOUND |
                        NETR_TRUST_FLAG_INBOUND |
                        NETR_TRUST_FLAG_IN_FOREST;
@@ -1194,110 +1343,130 @@ static NTSTATUS trusted_domains(struct winbindd_domain *domain,
                return NT_STATUS_UNSUCCESSFUL;
        }
 
-       result = rpccli_netr_DsrEnumerateDomainTrusts(cli, mem_ctx,
-                                                     cli->cli->desthost,
+       b = cli->binding_handle;
+
+       result = dcerpc_netr_DsrEnumerateDomainTrusts(b, mem_ctx,
+                                                     cli->desthost,
                                                      flags,
-                                                     &trusts,
-                                                     NULL);
-       if ( NT_STATUS_IS_OK(result) && trusts.count) {
+                                                     trusts,
+                                                     &werr);
+       if (!NT_STATUS_IS_OK(result)) {
+               return result;
+       }
 
-               /* Allocate memory for trusted domain names and sids */
+       if (!W_ERROR_IS_OK(werr)) {
+               return werror_to_ntstatus(werr);
+       }
+       if (trusts->count == 0) {
+               return NT_STATUS_OK;
+       }
 
-               if ( !(*names = TALLOC_ARRAY(mem_ctx, char *, trusts.count)) ) {
-                       DEBUG(0, ("trusted_domains: out of memory\n"));
-                       return NT_STATUS_NO_MEMORY;
-               }
+       /* Copy across names and sids */
 
-               if ( !(*alt_names = TALLOC_ARRAY(mem_ctx, char *, trusts.count)) ) {
-                       DEBUG(0, ("trusted_domains: out of memory\n"));
-                       return NT_STATUS_NO_MEMORY;
-               }
+       ret_count = 0;
+       for (i = 0; i < trusts->count; i++) {
+               struct netr_DomainTrust *trust = &trusts->array[i];
+               struct winbindd_domain d;
+
+               ZERO_STRUCT(d);
 
-               if ( !(*dom_sids = TALLOC_ARRAY(mem_ctx, DOM_SID, trusts.count)) ) {
-                       DEBUG(0, ("trusted_domains: out of memory\n"));
-                       return NT_STATUS_NO_MEMORY;
+               /*
+                * drop external trusts if this is not our primary
+                * domain.  This means that the returned number of
+                * domains may be less that the ones actually trusted
+                * by the DC.
+                */
+
+               if ((trust->trust_attributes
+                    == NETR_TRUST_ATTRIBUTE_QUARANTINED_DOMAIN) &&
+                   !domain->primary )
+               {
+                       DEBUG(10,("trusted_domains: Skipping external trusted "
+                                 "domain %s because it is outside of our "
+                                 "primary domain\n",
+                                 trust->netbios_name));
+                       continue;
                }
 
-               /* Copy across names and sids */
-
-
-               ret_count = 0;          
-               for (i = 0; i < trusts.count; i++) {
-                       struct winbindd_domain d;
-                       
-                       /* drop external trusts if this is not our primary 
-                          domain.  This means that the returned number of 
-                          domains may be less that the ones actually trusted
-                          by the DC. */
-
-                       if ( (trusts.array[i].trust_attributes == NETR_TRUST_ATTRIBUTE_QUARANTINED_DOMAIN) &&
-                            !domain->primary ) 
-                       {
-                               DEBUG(10,("trusted_domains: Skipping external trusted domain "
-                                         "%s because it is outside of our primary domain\n",
-                                         trusts.array[i].netbios_name));
-                               continue;                               
-                       }
-                       
-                       (*names)[ret_count] = CONST_DISCARD(char *, trusts.array[i].netbios_name);
-                       (*alt_names)[ret_count] = CONST_DISCARD(char *, trusts.array[i].dns_name);
-                       sid_copy(&(*dom_sids)[ret_count], trusts.array[i].sid);
+               /* add to the trusted domain cache */
+
+               fstrcpy(d.name, trust->netbios_name);
+               fstrcpy(d.alt_name, trust->dns_name);
+               if (trust->sid) {
+                       sid_copy(&d.sid, trust->sid);
+               } else {
+                       sid_copy(&d.sid, &global_sid_NULL);
+               }
 
-                       /* add to the trusted domain cache */
+               if ( domain->primary ) {
+                       DEBUG(10,("trusted_domains(ads):  Searching "
+                                 "trusted domain list of %s and storing "
+                                 "trust flags for domain %s\n",
+                                 domain->name, d.alt_name));
 
-                       fstrcpy( d.name,  trusts.array[i].netbios_name);
-                       fstrcpy( d.alt_name, trusts.array[i].dns_name);
-                       sid_copy( &d.sid, trusts.array[i].sid);
+                       d.domain_flags = trust->trust_flags;
+                       d.domain_type = trust->trust_type;
+                       d.domain_trust_attribs = trust->trust_attributes;
 
+                       wcache_tdc_add_domain( &d );
+                       ret_count++;
+               } else if (domain_is_forest_root(domain)) {
+                       /* Check if we already have this record. If
+                        * we are following our forest root that is not
+                        * our primary domain, we want to keep trust
+                        * flags from the perspective of our primary
+                        * domain not our forest root. */
+                       struct winbindd_tdc_domain *exist = NULL;
+
+                       exist = wcache_tdc_fetch_domain(
+                               talloc_tos(), trust->netbios_name);
+                       if (!exist) {
+                               DEBUG(10,("trusted_domains(ads):  Searching "
+                                         "trusted domain list of %s and "
+                                         "storing trust flags for domain "
+                                         "%s\n", domain->name, d.alt_name));
+                               d.domain_flags = trust->trust_flags;
+                               d.domain_type = trust->trust_type;
+                               d.domain_trust_attribs =
+                                       trust->trust_attributes;
+
+                               wcache_tdc_add_domain( &d );
+                               ret_count++;
+                       }
+                       TALLOC_FREE(exist);
+               } else {
                        /* This gets a little tricky.  If we are
                           following a transitive forest trust, then
-                          innerit the flags, type, and attrins from
+                          innerit the flags, type, and attribs from
                           the domain we queried to make sure we don't
                           record the view of the trust from the wrong
                           side.  Always view it from the side of our
                           primary domain.   --jerry */
-                       if ( domain->primary ||
-                            ((domain->domain_flags&fr_flags) == fr_flags) ) 
-                       {
-                               DEBUG(10,("trusted_domains(ads):  Storing trust "
-                                         "flags for domain %s\n", d.alt_name));
-
-                               /* Look this up in cache to make sure
-                                  we have the current trust flags and
-                                  attributes */
-
-                               d.domain_flags = trusts.array[i].trust_flags;
-                               d.domain_type = trusts.array[i].trust_type;
-                               d.domain_trust_attribs = trusts.array[i].trust_attributes;
+                       struct winbindd_tdc_domain *parent = NULL;
+
+                       DEBUG(10,("trusted_domains(ads):  Searching "
+                                 "trusted domain list of %s and inheriting "
+                                 "trust flags for domain %s\n",
+                                 domain->name, d.alt_name));
+
+                       parent = wcache_tdc_fetch_domain(talloc_tos(),
+                                                        domain->name);
+                       if (parent) {
+                               d.domain_flags = parent->trust_flags;
+                               d.domain_type  = parent->trust_type;
+                               d.domain_trust_attribs = parent->trust_attribs;
                        } else {
-                               /* Look up the record in the cache */
-                               struct winbindd_tdc_domain *parent;
-
-                               DEBUG(10,("trusted_domains(ads):  Inheriting trust "
-                                         "flags for domain %s\n", d.alt_name));                                
-
-                               parent = wcache_tdc_fetch_domain(NULL, domain->name);
-                               if (parent) {
-                                       d.domain_flags = parent->trust_flags;
-                                       d.domain_type  = parent->trust_type;
-                                       d.domain_trust_attribs = parent->trust_attribs;
-                               } else {
-                               d.domain_flags = domain->domain_flags;                          
+                               d.domain_flags = domain->domain_flags;
                                d.domain_type  = domain->domain_type;
-                               d.domain_trust_attribs = domain->domain_trust_attribs;
-                       }
-                               TALLOC_FREE(parent);
+                               d.domain_trust_attribs =
+                                       domain->domain_trust_attribs;
                        }
+                       TALLOC_FREE(parent);
 
                        wcache_tdc_add_domain( &d );
-
                        ret_count++;
-
                }
-
-               *num_domains = ret_count;       
        }
-
        return result;
 }
 
@@ -1307,16 +1476,16 @@ struct winbindd_methods ads_methods = {
        query_user_list,
        enum_dom_groups,
        enum_local_groups,
-       msrpc_name_to_sid,
-       msrpc_sid_to_name,
-       msrpc_rids_to_names,
+       name_to_sid,
+       sid_to_name,
+       rids_to_names,
        query_user,
        lookup_usergroups,
-       msrpc_lookup_useraliases,
+       lookup_useraliases,
        lookup_groupmem,
        sequence_number,
-       msrpc_lockout_policy,
-       msrpc_password_policy,
+       lockout_policy,
+       password_policy,
        trusted_domains,
 };