net: share_type is defined in net_rap.c, net_rpc.c needs to use that.
[kai/samba.git] / source3 / utils / net_rpc.c
index 148d243ef8f221fc05838b6f3efd1ed35aa6e214..7ebd749899c6b004ef1094df2f03f77466feb341 100644 (file)
@@ -26,6 +26,8 @@
 static int net_mode_share;
 static bool sync_files(struct copy_clistate *cp_clistate, const char *mask);
 
+extern const char *share_type[];
+
 /**
  * @file net_rpc.c
  *
@@ -725,271 +727,93 @@ static int rpc_user_delete(struct net_context *c, int argc, const char **argv)
 }
 
 /**
- * Set a password for a user on a remote RPC server.
- *
- * All parameters are provided by the run_rpc_command function, except for
- * argc, argv which are passed through.
+ * Set a user's password on a remote RPC server.
  *
- * @param domain_sid The domain sid acquired from the remote server.
- * @param cli A cli_state connected to the server.
- * @param mem_ctx Talloc context, destroyed on completion of the function.
  * @param argc  Standard main() style argc.
  * @param argv  Standard main() style argv. Initial components are already
  *              stripped.
  *
- * @return Normal NTSTATUS return.
+ * @return A shell status integer (0 for success).
  **/
 
-static NTSTATUS rpc_user_password_internals(struct net_context *c,
-                                       const DOM_SID *domain_sid,
-                                       const char *domain_name,
-                                       struct cli_state *cli,
-                                       struct rpc_pipe_client *pipe_hnd,
-                                       TALLOC_CTX *mem_ctx,
-                                       int argc,
-                                       const char **argv)
+static int rpc_user_password(struct net_context *c, int argc, const char **argv)
 {
-       NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
-       POLICY_HND connect_pol, domain_pol, user_pol;
-       const char *user;
-       const char *new_password;
+       NET_API_STATUS status;
        char *prompt = NULL;
-       union samr_UserInfo info;
-       struct samr_CryptPassword crypt_pwd;
+       struct USER_INFO_1003 u1003;
+       uint32_t parm_err = 0;
 
        if (argc < 1 || c->display_usage) {
                rpc_user_usage(c, argc, argv);
-               return NT_STATUS_OK;
+               return 0;
        }
 
-       user = argv[0];
-
        if (argv[1]) {
-               new_password = argv[1];
+               u1003.usri1003_password = argv[1];
        } else {
-               asprintf(&prompt, "Enter new password for %s:", user);
-               new_password = getpass(prompt);
+               asprintf(&prompt, "Enter new password for %s:", argv[0]);
+               u1003.usri1003_password = getpass(prompt);
                SAFE_FREE(prompt);
        }
 
-       /* Get sam policy and domain handles */
-
-       result = rpccli_samr_Connect2(pipe_hnd, mem_ctx,
-                                     pipe_hnd->desthost,
-                                     MAXIMUM_ALLOWED_ACCESS,
-                                     &connect_pol);
-
-       if (!NT_STATUS_IS_OK(result)) {
-               goto done;
-       }
-
-       result = rpccli_samr_OpenDomain(pipe_hnd, mem_ctx,
-                                       &connect_pol,
-                                       MAXIMUM_ALLOWED_ACCESS,
-                                       CONST_DISCARD(struct dom_sid2 *, domain_sid),
-                                       &domain_pol);
-
-       if (!NT_STATUS_IS_OK(result)) {
-               goto done;
-       }
-
-       /* Get handle on user */
-
-       {
-               struct samr_Ids user_rids, name_types;
-               struct lsa_String lsa_acct_name;
-
-               init_lsa_String(&lsa_acct_name, user);
-
-               result = rpccli_samr_LookupNames(pipe_hnd, mem_ctx,
-                                                &domain_pol,
-                                                1,
-                                                &lsa_acct_name,
-                                                &user_rids,
-                                                &name_types);
-               if (!NT_STATUS_IS_OK(result)) {
-                       goto done;
-               }
-
-               result = rpccli_samr_OpenUser(pipe_hnd, mem_ctx,
-                                             &domain_pol,
-                                             MAXIMUM_ALLOWED_ACCESS,
-                                             user_rids.ids[0],
-                                             &user_pol);
-
-               if (!NT_STATUS_IS_OK(result)) {
-                       goto done;
-               }
-       }
-
-       /* Set password on account */
-
-       init_samr_CryptPassword(new_password,
-                               &cli->user_session_key,
-                               &crypt_pwd);
-
-       init_samr_user_info24(&info.info24, crypt_pwd.data, 24);
-
-       result = rpccli_samr_SetUserInfo2(pipe_hnd, mem_ctx,
-                                         &user_pol,
-                                         24,
-                                         &info);
-
-       if (!NT_STATUS_IS_OK(result)) {
-               goto done;
-       }
+       status = NetUserSetInfo(c->opt_host, argv[0], 1003, (uint8_t *)&u1003, &parm_err);
 
        /* Display results */
+       if (status != 0) {
+               d_fprintf(stderr, "Failed to set password for '%s' with: %s.\n",
+                       argv[0], libnetapi_get_error_string(c->netapi_ctx,
+                                                           status));
+               return -1;
+       }
 
- done:
-       return result;
-
+       return 0;
 }
 
 /**
- * Set a user's password on a remote RPC server.
+ * List a user's groups from a remote RPC server.
  *
  * @param argc  Standard main() style argc.
  * @param argv  Standard main() style argv. Initial components are already
  *              stripped.
  *
- * @return A shell status integer (0 for success).
+ * @return A shell status integer (0 for success)
  **/
 
-static int rpc_user_password(struct net_context *c, int argc, const char **argv)
-{
-       return run_rpc_command(c, NULL, &ndr_table_samr.syntax_id, 0,
-                              rpc_user_password_internals, argc, argv);
-}
-
-/**
- * List user's groups on a remote RPC server.
- *
- * All parameters are provided by the run_rpc_command function, except for
- * argc, argv which are passed through.
- *
- * @param domain_sid The domain sid acquired from the remote server.
- * @param cli A cli_state connected to the server.
- * @param mem_ctx Talloc context, destroyed on completion of the function.
- * @param argc  Standard main() style argc.
- * @param argv  Standard main() style argv. Initial components are already
- *              stripped.
- *
- * @return Normal NTSTATUS return.
- **/
+static int rpc_user_info(struct net_context *c, int argc, const char **argv)
 
-static NTSTATUS rpc_user_info_internals(struct net_context *c,
-                       const DOM_SID *domain_sid,
-                       const char *domain_name,
-                       struct cli_state *cli,
-                       struct rpc_pipe_client *pipe_hnd,
-                       TALLOC_CTX *mem_ctx,
-                       int argc,
-                       const char **argv)
 {
-       POLICY_HND connect_pol, domain_pol, user_pol;
-       NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
+       NET_API_STATUS status;
+       struct GROUP_USERS_INFO_0 *u0 = NULL;
+       uint32_t entries_read = 0;
+       uint32_t total_entries = 0;
        int i;
-       struct samr_RidWithAttributeArray *rid_array = NULL;
-       struct lsa_Strings names;
-       struct samr_Ids types;
-       uint32_t *lrids = NULL;
-       struct samr_Ids rids, name_types;
-       struct lsa_String lsa_acct_name;
 
 
        if (argc < 1 || c->display_usage) {
                rpc_user_usage(c, argc, argv);
-               return NT_STATUS_OK;
+               return 0;
        }
-       /* Get sam policy handle */
-
-       result = rpccli_samr_Connect2(pipe_hnd, mem_ctx,
-                                     pipe_hnd->desthost,
-                                     MAXIMUM_ALLOWED_ACCESS,
-                                     &connect_pol);
-       if (!NT_STATUS_IS_OK(result)) goto done;
-
-       /* Get domain policy handle */
-
-       result = rpccli_samr_OpenDomain(pipe_hnd, mem_ctx,
-                                       &connect_pol,
-                                       MAXIMUM_ALLOWED_ACCESS,
-                                       CONST_DISCARD(struct dom_sid2 *, domain_sid),
-                                       &domain_pol);
-       if (!NT_STATUS_IS_OK(result)) goto done;
-
-       /* Get handle on user */
-
-       init_lsa_String(&lsa_acct_name, argv[0]);
-
-       result = rpccli_samr_LookupNames(pipe_hnd, mem_ctx,
-                                        &domain_pol,
-                                        1,
-                                        &lsa_acct_name,
-                                        &rids,
-                                        &name_types);
-
-       if (!NT_STATUS_IS_OK(result)) goto done;
-
-       result = rpccli_samr_OpenUser(pipe_hnd, mem_ctx,
-                                     &domain_pol,
-                                     MAXIMUM_ALLOWED_ACCESS,
-                                     rids.ids[0],
-                                     &user_pol);
-       if (!NT_STATUS_IS_OK(result)) goto done;
-
-       result = rpccli_samr_GetGroupsForUser(pipe_hnd, mem_ctx,
-                                             &user_pol,
-                                             &rid_array);
-
-       if (!NT_STATUS_IS_OK(result)) goto done;
 
-       /* Look up rids */
-
-       if (rid_array->count) {
-               if ((lrids = TALLOC_ARRAY(mem_ctx, uint32, rid_array->count)) == NULL) {
-                       result = NT_STATUS_NO_MEMORY;
-                       goto done;
-               }
-
-               for (i = 0; i < rid_array->count; i++)
-                       lrids[i] = rid_array->rids[i].rid;
-
-               result = rpccli_samr_LookupRids(pipe_hnd, mem_ctx,
-                                               &domain_pol,
-                                               rid_array->count,
-                                               lrids,
-                                               &names,
-                                               &types);
-
-               if (!NT_STATUS_IS_OK(result)) {
-                       goto done;
-               }
-
-               /* Display results */
-
-               for (i = 0; i < names.count; i++)
-                       printf("%s\n", names.names[i].string);
+       status = NetUserGetGroups(c->opt_host,
+                                 argv[0],
+                                 0,
+                                 (uint8_t **)&u0,
+                                 (uint32_t)-1,
+                                 &entries_read,
+                                 &total_entries);
+       if (status != 0) {
+               d_fprintf(stderr, "Failed to get groups for '%s' with: %s.\n",
+                       argv[0], libnetapi_get_error_string(c->netapi_ctx,
+                                                           status));
+               return -1;
        }
- done:
-       return result;
-}
 
-/**
- * List a user's groups from a remote RPC server.
- *
- * @param argc  Standard main() style argc.
- * @param argv  Standard main() style argv. Initial components are already
- *              stripped.
- *
- * @return A shell status integer (0 for success)
- **/
+       for (i=0; i < entries_read; i++) {
+               printf("%s\n", u0->grui0_name);
+               u0++;
+       }
 
-static int rpc_user_info(struct net_context *c, int argc, const char **argv)
-{
-       return run_rpc_command(c, NULL, &ndr_table_samr.syntax_id, 0,
-                              rpc_user_info_internals, argc, argv);
+       return 0;
 }
 
 /**
@@ -1008,80 +832,54 @@ static int rpc_user_info(struct net_context *c, int argc, const char **argv)
  * @return Normal NTSTATUS return.
  **/
 
-static NTSTATUS rpc_user_list_internals(struct net_context *c,
-                                       const DOM_SID *domain_sid,
-                                       const char *domain_name,
-                                       struct cli_state *cli,
-                                       struct rpc_pipe_client *pipe_hnd,
-                                       TALLOC_CTX *mem_ctx,
-                                       int argc,
-                                       const char **argv)
+static int rpc_user_list(struct net_context *c, int argc, const char **argv)
 {
-       POLICY_HND connect_pol, domain_pol;
-       NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
-       uint32 start_idx=0, num_entries, i, loop_count = 0;
-
-       /* Get sam policy handle */
-
-       result = rpccli_samr_Connect2(pipe_hnd, mem_ctx,
-                                     pipe_hnd->desthost,
-                                     MAXIMUM_ALLOWED_ACCESS,
-                                     &connect_pol);
-       if (!NT_STATUS_IS_OK(result)) {
-               goto done;
-       }
-
-       /* Get domain policy handle */
-
-       result = rpccli_samr_OpenDomain(pipe_hnd, mem_ctx,
-                                       &connect_pol,
-                                       MAXIMUM_ALLOWED_ACCESS,
-                                       CONST_DISCARD(struct dom_sid2 *, domain_sid),
-                                       &domain_pol);
-       if (!NT_STATUS_IS_OK(result)) {
-               goto done;
-       }
+       NET_API_STATUS status;
+       uint32_t start_idx=0, num_entries, i, loop_count = 0;
+       struct NET_DISPLAY_USER *info = NULL;
+       void *buffer = NULL;
 
        /* Query domain users */
        if (c->opt_long_list_entries)
                d_printf("\nUser name             Comment"
                         "\n-----------------------------\n");
        do {
-               const char *user = NULL;
-               const char *desc = NULL;
-               uint32 max_entries, max_size;
-               uint32_t total_size, returned_size;
-               union samr_DispInfo info;
+               uint32_t max_entries, max_size;
 
                get_query_dispinfo_params(
                        loop_count, &max_entries, &max_size);
 
-               result = rpccli_samr_QueryDisplayInfo(pipe_hnd, mem_ctx,
-                                                     &domain_pol,
-                                                     1,
-                                                     start_idx,
-                                                     max_entries,
-                                                     max_size,
-                                                     &total_size,
-                                                     &returned_size,
-                                                     &info);
-               loop_count++;
-               start_idx += info.info1.count;
-               num_entries = info.info1.count;
+               status = NetQueryDisplayInformation(c->opt_host,
+                                                   1,
+                                                   start_idx,
+                                                   max_entries,
+                                                   max_size,
+                                                   &num_entries,
+                                                   &buffer);
+               if (status != 0 && status != ERROR_MORE_DATA) {
+                       return status;
+               }
+
+               info = (struct NET_DISPLAY_USER *)buffer;
 
                for (i = 0; i < num_entries; i++) {
-                       user = info.info1.entries[i].account_name.string;
-                       if (c->opt_long_list_entries)
-                               desc = info.info1.entries[i].description.string;
+
                        if (c->opt_long_list_entries)
-                               printf("%-21.21s %s\n", user, desc);
+                               printf("%-21.21s %s\n", info->usri1_name,
+                                       info->usri1_comment);
                        else
-                               printf("%s\n", user);
+                               printf("%s\n", info->usri1_name);
+                       info++;
                }
-       } while (NT_STATUS_EQUAL(result, STATUS_MORE_ENTRIES));
 
- done:
-       return result;
+               NetApiBufferFree(buffer);
+
+               loop_count++;
+               start_idx += num_entries;
+
+       } while (status == ERROR_MORE_DATA);
+
+       return status;
 }
 
 /**
@@ -1158,9 +956,7 @@ int net_rpc_user(struct net_context *c, int argc, const char **argv)
                        return 0;
                }
 
-               return run_rpc_command(c, NULL, &ndr_table_samr.syntax_id, 0,
-                                      rpc_user_list_internals,
-                                      argc, argv);
+               return rpc_user_list(c, argc, argv);
        }
 
        return net_run_function(c, argc, argv, "net rpc user", func);
@@ -1172,9 +968,7 @@ static NTSTATUS rpc_sh_user_list(struct net_context *c,
                                 struct rpc_pipe_client *pipe_hnd,
                                 int argc, const char **argv)
 {
-       return rpc_user_list_internals(c, ctx->domain_sid, ctx->domain_name,
-                                      ctx->cli, pipe_hnd, mem_ctx,
-                                      argc, argv);
+       return werror_to_ntstatus(W_ERROR(rpc_user_list(c, argc, argv)));
 }
 
 static NTSTATUS rpc_sh_user_info(struct net_context *c,
@@ -1183,9 +977,7 @@ static NTSTATUS rpc_sh_user_info(struct net_context *c,
                                 struct rpc_pipe_client *pipe_hnd,
                                 int argc, const char **argv)
 {
-       return rpc_user_info_internals(c, ctx->domain_sid, ctx->domain_name,
-                                      ctx->cli, pipe_hnd, mem_ctx,
-                                      argc, argv);
+       return werror_to_ntstatus(W_ERROR(rpc_user_info(c, argc, argv)));
 }
 
 static NTSTATUS rpc_sh_handle_user(struct net_context *c,
@@ -2999,108 +2791,58 @@ static int rpc_share_usage(struct net_context *c, int argc, const char **argv)
 /**
  * Add a share on a remote RPC server.
  *
- * All parameters are provided by the run_rpc_command function, except for
- * argc, argv which are passed through.
- *
- * @param domain_sid The domain sid acquired from the remote server.
- * @param cli A cli_state connected to the server.
- * @param mem_ctx Talloc context, destroyed on completion of the function.
  * @param argc  Standard main() style argc.
  * @param argv  Standard main() style argv. Initial components are already
  *              stripped.
  *
- * @return Normal NTSTATUS return.
+ * @return A shell status integer (0 for success).
  **/
-static NTSTATUS rpc_share_add_internals(struct net_context *c,
-                                       const DOM_SID *domain_sid,
-                                       const char *domain_name,
-                                       struct cli_state *cli,
-                                       struct rpc_pipe_client *pipe_hnd,
-                                       TALLOC_CTX *mem_ctx,int argc,
-                                       const char **argv)
+
+static int rpc_share_add(struct net_context *c, int argc, const char **argv)
 {
-       WERROR result;
-       NTSTATUS status;
+       NET_API_STATUS status;
        char *sharename;
        char *path;
        uint32 type = STYPE_DISKTREE; /* only allow disk shares to be added */
        uint32 num_users=0, perms=0;
        char *password=NULL; /* don't allow a share password */
-       uint32 level = 2;
-       union srvsvc_NetShareInfo info;
-       struct srvsvc_NetShareInfo2 info2;
+       struct SHARE_INFO_2 i2;
        uint32_t parm_error = 0;
 
-       if ((sharename = talloc_strdup(mem_ctx, argv[0])) == NULL) {
-               return NT_STATUS_NO_MEMORY;
+       if ((argc < 1) || !strchr(argv[0], '=') || c->display_usage) {
+               return rpc_share_usage(c, argc, argv);
        }
 
-       path = strchr(sharename, '=');
-       if (!path)
-               return NT_STATUS_UNSUCCESSFUL;
-       *path++ = '\0';
-
-       info2.name              = sharename;
-       info2.type              = type;
-       info2.comment           = c->opt_comment;
-       info2.permissions       = perms;
-       info2.max_users         = c->opt_maxusers;
-       info2.current_users     = num_users;
-       info2.path              = path;
-       info2.password          = password;
+       if ((sharename = talloc_strdup(c, argv[0])) == NULL) {
+               return -1;
+       }
 
-       info.info2 = &info2;
+       path = strchr(sharename, '=');
+       if (!path) {
+               return -1;
+       }
 
-       status = rpccli_srvsvc_NetShareAdd(pipe_hnd, mem_ctx,
-                                          pipe_hnd->desthost,
-                                          level,
-                                          &info,
-                                          &parm_error,
-                                          &result);
-       return status;
-}
+       *path++ = '\0';
 
-static int rpc_share_add(struct net_context *c, int argc, const char **argv)
-{
-       if ((argc < 1) || !strchr(argv[0], '=') || c->display_usage) {
-               return rpc_share_usage(c, argc, argv);
+       i2.shi2_netname         = sharename;
+       i2.shi2_type            = type;
+       i2.shi2_remark          = c->opt_comment;
+       i2.shi2_permissions     = perms;
+       i2.shi2_max_uses        = c->opt_maxusers;
+       i2.shi2_current_uses    = num_users;
+       i2.shi2_path            = path;
+       i2.shi2_passwd          = password;
+
+       status = NetShareAdd(c->opt_host,
+                            2,
+                            (uint8_t *)&i2,
+                            &parm_error);
+       if (status != 0) {
+               printf("NetShareAdd failed with: %s\n",
+                       libnetapi_get_error_string(c->netapi_ctx, status));
        }
-       return run_rpc_command(c, NULL, &ndr_table_srvsvc.syntax_id, 0,
-                              rpc_share_add_internals,
-                              argc, argv);
-}
-
-/**
- * Delete a share on a remote RPC server.
- *
- * All parameters are provided by the run_rpc_command function, except for
- * argc, argv which are passed through.
- *
- * @param domain_sid The domain sid acquired from the remote server.
- * @param cli A cli_state connected to the server.
- * @param mem_ctx Talloc context, destroyed on completion of the function.
- * @param argc  Standard main() style argc.
- * @param argv  Standard main() style argv. Initial components are already
- *              stripped.
- *
- * @return Normal NTSTATUS return.
- **/
-static NTSTATUS rpc_share_del_internals(struct net_context *c,
-                                       const DOM_SID *domain_sid,
-                                       const char *domain_name,
-                                       struct cli_state *cli,
-                                       struct rpc_pipe_client *pipe_hnd,
-                                       TALLOC_CTX *mem_ctx,
-                                       int argc,
-                                       const char **argv)
-{
-       WERROR result;
 
-       return rpccli_srvsvc_NetShareDel(pipe_hnd, mem_ctx,
-                                        pipe_hnd->desthost,
-                                        argv[0],
-                                        0,
-                                        &result);
+       return status;
 }
 
 /**
@@ -3118,9 +2860,8 @@ static int rpc_share_delete(struct net_context *c, int argc, const char **argv)
        if (argc < 1 || c->display_usage) {
                return rpc_share_usage(c, argc, argv);
        }
-       return run_rpc_command(c, NULL, &ndr_table_srvsvc.syntax_id, 0,
-                              rpc_share_del_internals,
-                              argc, argv);
+
+       return NetShareDel(c->opt_host, argv[0], 0);
 }
 
 /**
@@ -3135,7 +2876,7 @@ static void display_share_info_1(struct net_context *c,
        if (c->opt_long_list_entries) {
                d_printf("%-12s %-8.8s %-50s\n",
                         r->name,
-                        c->share_type[r->type & ~(STYPE_TEMPORARY|STYPE_HIDDEN)],
+                        share_type[r->type & ~(STYPE_TEMPORARY|STYPE_HIDDEN)],
                         r->comment);
        } else {
                d_printf("%s\n", r->name);
@@ -4812,6 +4553,8 @@ int net_usersidlist_usage(struct net_context *c, int argc, const char **argv)
 
 int net_rpc_share(struct net_context *c, int argc, const char **argv)
 {
+       NET_API_STATUS status;
+
        struct functable func[] = {
                {
                        "add",
@@ -4856,6 +4599,15 @@ int net_rpc_share(struct net_context *c, int argc, const char **argv)
                {NULL, NULL, 0, NULL, NULL}
        };
 
+       status = libnetapi_init(&c->netapi_ctx);
+       if (status != 0) {
+               return -1;
+       }
+       libnetapi_set_username(c->netapi_ctx, c->opt_user_name);
+       libnetapi_set_password(c->netapi_ctx, c->opt_password);
+       if (c->opt_kerberos) {
+               libnetapi_set_use_kerberos(c->netapi_ctx);
+       }
 
        if (argc == 0) {
                if (c->display_usage) {
@@ -4892,11 +4644,9 @@ static NTSTATUS rpc_sh_share_add(struct net_context *c,
                                 struct rpc_pipe_client *pipe_hnd,
                                 int argc, const char **argv)
 {
-       WERROR result;
-       NTSTATUS status;
+       NET_API_STATUS status;
        uint32_t parm_err = 0;
-       union srvsvc_NetShareInfo info;
-       struct srvsvc_NetShareInfo2 info2;
+       struct SHARE_INFO_2 i2;
 
        if ((argc < 2) || (argc > 3)) {
                d_fprintf(stderr, "usage: %s <share> <path> [comment]\n",
@@ -4904,25 +4654,21 @@ static NTSTATUS rpc_sh_share_add(struct net_context *c,
                return NT_STATUS_INVALID_PARAMETER;
        }
 
-       info2.name              = argv[0];
-       info2.type              = STYPE_DISKTREE;
-       info2.comment           = (argc == 3) ? argv[2] : "";
-       info2.permissions       = 0;
-       info2.max_users         = 0;
-       info2.current_users     = 0;
-       info2.path              = argv[1];
-       info2.password          = NULL;
+       i2.shi2_netname         = argv[0];
+       i2.shi2_type            = STYPE_DISKTREE;
+       i2.shi2_remark          = (argc == 3) ? argv[2] : "";
+       i2.shi2_permissions     = 0;
+       i2.shi2_max_uses        = 0;
+       i2.shi2_current_uses    = 0;
+       i2.shi2_path            = argv[1];
+       i2.shi2_passwd          = NULL;
 
-       info.info2 = &info2;
+       status = NetShareAdd(pipe_hnd->desthost,
+                            2,
+                            (uint8_t *)&i2,
+                            &parm_err);
 
-       status = rpccli_srvsvc_NetShareAdd(pipe_hnd, mem_ctx,
-                                          pipe_hnd->desthost,
-                                          2,
-                                          &info,
-                                          &parm_err,
-                                          &result);
-
-       return status;
+       return werror_to_ntstatus(W_ERROR(status));
 }
 
 static NTSTATUS rpc_sh_share_delete(struct net_context *c,
@@ -4931,21 +4677,12 @@ static NTSTATUS rpc_sh_share_delete(struct net_context *c,
                                    struct rpc_pipe_client *pipe_hnd,
                                    int argc, const char **argv)
 {
-       WERROR result;
-       NTSTATUS status;
-
        if (argc != 1) {
                d_fprintf(stderr, "usage: %s <share>\n", ctx->whoami);
                return NT_STATUS_INVALID_PARAMETER;
        }
 
-       status = rpccli_srvsvc_NetShareDel(pipe_hnd, mem_ctx,
-                                          pipe_hnd->desthost,
-                                          argv[0],
-                                          0,
-                                          &result);
-
-       return status;
+       return werror_to_ntstatus(W_ERROR(NetShareDel(pipe_hnd->desthost, argv[0], 0)));
 }
 
 static NTSTATUS rpc_sh_share_info(struct net_context *c,