Removed version number from file header.
[kai/samba.git] / source3 / rpc_server / srv_spoolss_nt.c
index 4355e2eb5941e00fe1bae5929a463b4aeb602cd7..bba7c54b81e66640bdd8c8784f6d6dae22d0209b 100644 (file)
@@ -1,11 +1,12 @@
-#define OLD_NTDOMAIN 1
 /*
- *  Unix SMB/Netbios implementation.
- *  Version 1.9.
+ *  Unix SMB/CIFS implementation.
  *  RPC Pipe client / server routines
  *  Copyright (C) Andrew Tridgell              1992-2000,
  *  Copyright (C) Luke Kenneth Casson Leighton 1996-2000,
  *  Copyright (C) Jean François Micouleau      1998-2000.
+ *  Copyright (C) Jeremy Allison                   2001.
+ *  Copyright (C) Gerald Carter                       2000-2001.
+ *  Copyright (C) Tim Potter                       2001.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License as published by
  *  Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  */
 
-#include "includes.h"
+/* Since the SPOOLSS rpc routines are basically DOS 16-bit calls wrapped
+   up, all the errors returned are DOS errors, not NT status codes. */
 
-extern int DEBUGLEVEL;
-extern pstring global_myname;
+#include "includes.h"
 
 #ifndef MAX_OPEN_PRINTER_EXS
 #define MAX_OPEN_PRINTER_EXS 50
 #endif
 
+#define PHANTOM_DEVMODE_KEY "_p_f_a_n_t_0_m_"
 #define PRINTER_HANDLE_IS_PRINTER      0
 #define PRINTER_HANDLE_IS_PRINTSERVER  1
 
+struct table_node {
+       char    *long_archi;
+       char    *short_archi;
+       int     version;
+};
+
+
 /* structure to store the printer handles */
 /* and a reference to what it's pointing to */
 /* and the notify info asked about */
 /* that's the central struct */
 typedef struct _Printer{
-       ubi_dlNode Next;
-       ubi_dlNode Prev;
-
-       BOOL open;
        BOOL document_started;
        BOOL page_started;
-       int jobid; /* jobid in printing backend */
-       POLICY_HND printer_hnd;
+    int jobid; /* jobid in printing backend */
        BOOL printer_type;
        union {
                fstring handlename;
@@ -77,25 +81,41 @@ typedef struct _counter_printer_0 {
        uint32 counter;
 } counter_printer_0;
 
-static ubi_dlList Printer_list;
 static ubi_dlList counter_list;
 
 static struct cli_state cli;
 static uint32 smb_connections=0;
 
-#define OPEN_HANDLE(pnum)    ((pnum!=NULL) && (pnum->open!=False) && (IVAL(pnum->printer_hnd.data,16)==(uint32)sys_getpid()))
-#define OUR_HANDLE(pnum) ((pnum==NULL)?"NULL":(IVAL(pnum->data,16)==sys_getpid()?"OURS":"OTHER"))
+#define OUR_HANDLE(hnd) ((hnd==NULL)?"NULL":(IVAL(hnd->data5,4)==(uint32)sys_getpid()?"OURS":"OTHER"))
 
 /* translate between internal status numbers and NT status numbers */
 static int nt_printj_status(int v)
 {
        switch (v) {
-       case LPQ_PAUSED:
-               return PRINTER_STATUS_PAUSED;
        case LPQ_QUEUED:
+               return 0;
+       case LPQ_PAUSED:
+               return JOB_STATUS_PAUSED;
        case LPQ_SPOOLING:
+               return JOB_STATUS_SPOOLING;
        case LPQ_PRINTING:
-               return 0;
+               return JOB_STATUS_PRINTING;
+       case LPQ_ERROR:
+               return JOB_STATUS_ERROR;
+       case LPQ_DELETING:
+               return JOB_STATUS_DELETING;
+       case LPQ_OFFLINE:
+               return JOB_STATUS_OFFLINE;
+       case LPQ_PAPEROUT:
+               return JOB_STATUS_PAPEROUT;
+       case LPQ_PRINTED:
+               return JOB_STATUS_PRINTED;
+       case LPQ_DELETED:
+               return JOB_STATUS_DELETED;
+       case LPQ_BLOCKED:
+               return JOB_STATUS_BLOCKED;
+       case LPQ_USER_INTERVENTION:
+               return JOB_STATUS_USER_INTERVENTION;
        }
        return 0;
 }
@@ -114,125 +134,127 @@ static int nt_printq_status(int v)
 }
 
 /****************************************************************************
-  initialise printer handle states...
-****************************************************************************/
-void init_printer_hnd(void)
-{
-       ubi_dlInitList(&Printer_list);
-       ubi_dlInitList(&counter_list);
-}
-
-/****************************************************************************
-  create a unique printer handle
+ Functions to handle SPOOL_NOTIFY_OPTION struct stored in Printer_entry.
 ****************************************************************************/
-static void create_printer_hnd(POLICY_HND *hnd)
-{
-       static uint32 prt_hnd_low  = 0;
-       static uint32 prt_hnd_high = 0;
-
-       if (hnd == NULL) return;
 
-       /* i severely doubt that prt_hnd_high will ever be non-zero... */
-       prt_hnd_low++;
-       if (prt_hnd_low == 0) prt_hnd_high++;
-
-       SIVAL(hnd->data, 0 , 0x0);          /* first bit must be null */
-       SIVAL(hnd->data, 4 , prt_hnd_low ); /* second bit is incrementing */
-       SIVAL(hnd->data, 8 , prt_hnd_high); /* second bit is incrementing */
-       SIVAL(hnd->data, 12, time(NULL));   /* something random */
-       SIVAL(hnd->data, 16, sys_getpid());     /* something more random */
-}
-
-/****************************************************************************
-  find printer index by handle
-****************************************************************************/
-static Printer_entry *find_printer_index_by_hnd(const POLICY_HND *hnd)
+static void free_spool_notify_option(SPOOL_NOTIFY_OPTION **pp)
 {
-       Printer_entry *find_printer;
-
-       find_printer = (Printer_entry *)ubi_dlFirst(&Printer_list);
-
-       for(; find_printer; find_printer = (Printer_entry *)ubi_dlNext(find_printer)) {
-
-               if (memcmp(&(find_printer->printer_hnd), hnd, sizeof(*hnd)) == 0) {
-                       DEBUG(4,("Found printer handle \n"));
-                       /*dump_data(4, hnd->data, sizeof(hnd->data));*/
-                       return find_printer;
-               }
-       }
-       
-       DEBUG(3,("Whoops, Printer handle not found: "));
-       /*dump_data(4, hnd->data, sizeof(hnd->data));*/
-       return NULL;
-}
+       if (*pp == NULL)
+               return;
 
-/****************************************************************************
-  clear an handle
-****************************************************************************/
-static void clear_handle(POLICY_HND *hnd)
-{
-       ZERO_STRUCTP(hnd);
+       SAFE_FREE((*pp)->ctr.type);
+       SAFE_FREE(*pp);
 }
 
 /***************************************************************************
  Disconnect from the client
 ****************************************************************************/
-static BOOL srv_spoolss_replycloseprinter(POLICY_HND *handle)
+
+static void srv_spoolss_replycloseprinter(POLICY_HND *handle)
 {
-       uint32 status;
+       WERROR status;
 
        /* weird if the test succeds !!! */
        if (smb_connections==0) {
                DEBUG(0,("srv_spoolss_replycloseprinter:Trying to close non-existant notify backchannel !\n"));
-               return False;
+               return;
        }
 
        if(!cli_spoolss_reply_close_printer(&cli, handle, &status))
-               return False;
+               DEBUG(0,("srv_spoolss_replycloseprinter: reply_close_printer failed.\n"));
 
        /* if it's the last connection, deconnect the IPC$ share */
        if (smb_connections==1) {
                if(!spoolss_disconnect_from_client(&cli))
-                       return False;
+                       return;
 
                message_deregister(MSG_PRINTER_NOTIFY);
        }
 
        smb_connections--;
-
-       return True;
 }
 
 /****************************************************************************
-  close printer index by handle
+ Functions to free a printer entry datastruct.
 ****************************************************************************/
-static BOOL close_printer_handle(POLICY_HND *hnd)
-{
-       Printer_entry *Printer = find_printer_index_by_hnd(hnd);
 
-       if (!OPEN_HANDLE(Printer)) {
-               DEBUG(0,("close_printer_handle: Invalid handle (%s)\n", OUR_HANDLE(hnd)));
-               return False;
-       }
+static void free_printer_entry(void *ptr)
+{
+       Printer_entry *Printer = (Printer_entry *)ptr;
 
        if (Printer->notify.client_connected==True)
-               if(!srv_spoolss_replycloseprinter(&Printer->notify.client_hnd))
-                       return ERROR_INVALID_HANDLE;
+               srv_spoolss_replycloseprinter(&Printer->notify.client_hnd);
 
-       Printer->open=False;
        Printer->notify.flags=0;
        Printer->notify.options=0;
        Printer->notify.localmachine[0]='\0';
        Printer->notify.printerlocal=0;
-       safe_free(Printer->notify.option);
+       free_spool_notify_option(&Printer->notify.option);
        Printer->notify.option=NULL;
        Printer->notify.client_connected=False;
 
-       clear_handle(hnd);
+       SAFE_FREE(Printer);
+}
+
+/****************************************************************************
+ Functions to duplicate a SPOOL_NOTIFY_OPTION struct stored in Printer_entry.
+****************************************************************************/
+
+SPOOL_NOTIFY_OPTION *dup_spool_notify_option(SPOOL_NOTIFY_OPTION *sp)
+{
+       SPOOL_NOTIFY_OPTION *new_sp = NULL;
+
+       if (!sp)
+               return NULL;
+
+       new_sp = (SPOOL_NOTIFY_OPTION *)malloc(sizeof(SPOOL_NOTIFY_OPTION));
+       if (!new_sp)
+               return NULL;
+
+       *new_sp = *sp;
+
+       if (sp->ctr.count) {
+               new_sp->ctr.type = (SPOOL_NOTIFY_OPTION_TYPE *)memdup(sp->ctr.type, sizeof(SPOOL_NOTIFY_OPTION_TYPE) * sp->ctr.count);
 
-       ubi_dlRemThis(&Printer_list, Printer);
+               if (!new_sp->ctr.type) {
+                       SAFE_FREE(new_sp);
+                       return NULL;
+               }
+       }
+
+       return new_sp;
+}
+
+/****************************************************************************
+  find printer index by handle
+****************************************************************************/
+
+static Printer_entry *find_printer_index_by_hnd(pipes_struct *p, POLICY_HND *hnd)
+{
+       Printer_entry *find_printer = NULL;
+
+       if(!find_policy_by_hnd(p,hnd,(void **)&find_printer)) {
+               DEBUG(3,("find_printer_index_by_hnd: Printer handle not found: "));
+               return NULL;
+       }
+
+       return find_printer;
+}
+
+/****************************************************************************
+  close printer index by handle
+****************************************************************************/
+
+static BOOL close_printer_handle(pipes_struct *p, POLICY_HND *hnd)
+{
+       Printer_entry *Printer = find_printer_index_by_hnd(p, hnd);
+
+       if (!Printer) {
+               DEBUG(0,("close_printer_handle: Invalid handle (%s)\n", OUR_HANDLE(hnd)));
+               return False;
+       }
 
-       safe_free(Printer);
+       close_policy_hnd(p, hnd);
 
        return True;
 }      
@@ -240,73 +262,69 @@ static BOOL close_printer_handle(POLICY_HND *hnd)
 /****************************************************************************
   delete a printer given a handle
 ****************************************************************************/
-static BOOL delete_printer_handle(POLICY_HND *hnd)
+static WERROR delete_printer_handle(pipes_struct *p, POLICY_HND *hnd)
 {
-       Printer_entry *Printer = find_printer_index_by_hnd(hnd);
+       Printer_entry *Printer = find_printer_index_by_hnd(p, hnd);
 
-       if (!OPEN_HANDLE(Printer)) {
+       if (!Printer) {
                DEBUG(0,("delete_printer_handle: Invalid handle (%s)\n", OUR_HANDLE(hnd)));
-               return False;
+               return WERR_BADFID;
        }
 
        if (del_a_printer(Printer->dev.handlename) != 0) {
                DEBUG(3,("Error deleting printer %s\n", Printer->dev.handlename));
-               return False;
+               return WERR_BADFID;
+       }
+
+       /* Check calling user has permission to delete printer.  Note that
+          since we set the snum parameter to -1 only administrators can
+          delete the printer.  This stops people with the Full Control
+          permission from deleting the printer. */
+
+       if (!print_access_check(NULL, -1, PRINTER_ACCESS_ADMINISTER)) {
+               DEBUG(3, ("printer delete denied by security descriptor\n"));
+               return WERR_ACCESS_DENIED;
        }
 
        if (*lp_deleteprinter_cmd()) {
 
-               pid_t local_pid = sys_getpid();
                char *cmd = lp_deleteprinter_cmd();
-               char *path;
-               pstring tmp_file;
                pstring command;
                int ret;
                int i;
 
-               if (*lp_pathname(lp_servicenumber(PRINTERS_NAME)))
-                       path = lp_pathname(lp_servicenumber(PRINTERS_NAME));
-               else
-                       path = tmpdir();
-               
                /* Printer->dev.handlename equals portname equals sharename */
-               slprintf(command, sizeof(command), "%s \"%s\"", cmd,
+               slprintf(command, sizeof(command)-1, "%s \"%s\"", cmd,
                                        Printer->dev.handlename);
-               slprintf(tmp_file, sizeof(tmp_file), "%s/smbcmd.%d", path, local_pid);
 
-               unlink(tmp_file);
-               DEBUG(10,("Running [%s > %s]\n", command,tmp_file));
-               ret = smbrun(command, tmp_file, False);
+               DEBUG(10,("Running [%s]\n", command));
+               ret = smbrun(command, NULL);
                if (ret != 0) {
-                       unlink(tmp_file);
-                       return False;
+                       return WERR_BADFID; /* What to return here? */
                }
                DEBUGADD(10,("returned [%d]\n", ret));
-               DEBUGADD(10,("Unlinking output file [%s]\n", tmp_file));
-               unlink(tmp_file);
 
                /* Send SIGHUP to process group... is there a better way? */
                kill(0, SIGHUP);
 
                if ( ( i = lp_servicenumber( Printer->dev.handlename ) ) >= 0 ) {
-                       lp_remove_service( i );
                        lp_killservice( i );
-                       return True;
+                       return WERR_OK;
                } else
-                       return False;
+                       return WERR_ACCESS_DENIED;
        }
 
-       return True;
-}      
+       return WERR_OK;
+}
 
 /****************************************************************************
   return the snum of a printer corresponding to an handle
 ****************************************************************************/
-static BOOL get_printer_snum(POLICY_HND *hnd, int *number)
+static BOOL get_printer_snum(pipes_struct *p, POLICY_HND *hnd, int *number)
 {
-       Printer_entry *Printer = find_printer_index_by_hnd(hnd);
+       Printer_entry *Printer = find_printer_index_by_hnd(p, hnd);
                
-       if (!OPEN_HANDLE(Printer)) {
+       if (!Printer) {
                DEBUG(0,("get_printer_snum: Invalid handle (%s)\n", OUR_HANDLE(hnd)));
                return False;
        }
@@ -326,11 +344,11 @@ static BOOL get_printer_snum(POLICY_HND *hnd, int *number)
 /****************************************************************************
   set printer handle type.
 ****************************************************************************/
-static BOOL set_printer_hnd_accesstype(POLICY_HND *hnd, uint32 access_required)
+static BOOL set_printer_hnd_accesstype(pipes_struct *p, POLICY_HND *hnd, uint32 access_required)
 {
-       Printer_entry *Printer = find_printer_index_by_hnd(hnd);
+       Printer_entry *Printer = find_printer_index_by_hnd(p, hnd);
 
-       if (!OPEN_HANDLE(Printer)) {
+       if (!Printer) {
                DEBUG(0,("set_printer_hnd_accesstype: Invalid handle (%s)", OUR_HANDLE(hnd)));
                return False;
        }
@@ -355,7 +373,7 @@ static BOOL set_printer_hnd_printertype(Printer_entry *Printer, char *handlename
        }
 
        /* it's a print server */
-       if (!strchr(handlename+2, '\\')) {
+       if (*handlename=='\\' && *(handlename+1)=='\\' && !strchr_m(handlename+2, '\\')) {
                DEBUGADD(4,("Printer is a print server\n"));
                Printer->printer_type = PRINTER_HANDLE_IS_PRINTSERVER;          
        }
@@ -391,8 +409,13 @@ static BOOL set_printer_hnd_name(Printer_entry *Printer, char *handlename)
        if (Printer->printer_type!=PRINTER_HANDLE_IS_PRINTER)
                return False;
        
-       aprinter=strchr(handlename+2, '\\');
-       aprinter++;
+       if (*handlename=='\\') {
+               aprinter=strchr_m(handlename+2, '\\');
+               aprinter++;
+       }
+       else {
+               aprinter=handlename;
+       }
 
        DEBUGADD(5,("searching for [%s] (len=%d)\n", aprinter, strlen(aprinter)));
 
@@ -412,10 +435,10 @@ static BOOL set_printer_hnd_name(Printer_entry *Printer, char *handlename)
                
                DEBUGADD(5,("share:%s\n",lp_servicename(snum)));
 
-               if (get_a_printer(&printer, 2, lp_servicename(snum))!=0)
+               if (!W_ERROR_IS_OK(get_a_printer(&printer, 2, lp_servicename(snum))))
                        continue;
 
-               printername=strchr(printer->info_2->printername+2, '\\');
+               printername=strchr_m(printer->info_2->printername+2, '\\');
                printername++;
 
                DEBUG(10,("set_printer_hnd_name: name [%s], aprinter [%s]\n",
@@ -455,7 +478,7 @@ static BOOL set_printer_hnd_name(Printer_entry *Printer, char *handlename)
                
                        DEBUGADD(5,("set_printer_hnd_name: share:%s\n",lp_servicename(snum)));
 
-                       if (get_a_printer(&printer, 2, lp_servicename(snum))!=0)
+                       if (!W_ERROR_IS_OK(get_a_printer(&printer, 2, lp_servicename(snum))))
                                continue;
 
                        DEBUG(10,("set_printer_hnd_name: printername [%s], aprinter [%s]\n",
@@ -496,37 +519,35 @@ static BOOL set_printer_hnd_name(Printer_entry *Printer, char *handlename)
   find first available printer slot. creates a printer handle for you.
  ****************************************************************************/
 
-static BOOL open_printer_hnd(POLICY_HND *hnd, char *name)
+static BOOL open_printer_hnd(pipes_struct *p, POLICY_HND *hnd, char *name)
 {
        Printer_entry *new_printer;
 
        DEBUG(10,("open_printer_hnd: name [%s]\n", name));
-       clear_handle(hnd);
-       create_printer_hnd(hnd);
 
        if((new_printer=(Printer_entry *)malloc(sizeof(Printer_entry))) == NULL)
                return False;
 
        ZERO_STRUCTP(new_printer);
        
-       new_printer->open = True;
        new_printer->notify.option=NULL;
                                
-       memcpy(&new_printer->printer_hnd, hnd, sizeof(*hnd));
-       
-       ubi_dlAddHead( &Printer_list, (ubi_dlNode *)new_printer);
+       if (!create_policy_hnd(p, hnd, free_printer_entry, new_printer)) {
+               SAFE_FREE(new_printer);
+               return False;
+       }
 
        if (!set_printer_hnd_printertype(new_printer, name)) {
-               close_printer_handle(hnd);
+               close_printer_handle(p, hnd);
                return False;
        }
        
        if (!set_printer_hnd_name(new_printer, name)) {
-               close_printer_handle(hnd);
+               close_printer_handle(p, hnd);
                return False;
        }
 
-       DEBUG(5, ("%d printer handles active\n", ubi_dlCount(&Printer_list)));
+       DEBUG(5, ("%d printer handles active\n", (int)p->pipe_handles->count ));
 
        return True;
 }
@@ -534,11 +555,12 @@ static BOOL open_printer_hnd(POLICY_HND *hnd, char *name)
 /********************************************************************
  Return True is the handle is a print server.
  ********************************************************************/
-static BOOL handle_is_printserver(const POLICY_HND *handle)
+
+static BOOL handle_is_printserver(pipes_struct *p, POLICY_HND *handle)
 {
-       Printer_entry *Printer=find_printer_index_by_hnd(handle);
+       Printer_entry *Printer=find_printer_index_by_hnd(p,handle);
 
-       if (!OPEN_HANDLE(Printer))
+       if (!Printer)
                return False;
                
        if (Printer->printer_type != PRINTER_HANDLE_IS_PRINTSERVER)
@@ -584,11 +606,14 @@ static BOOL alloc_buffer_size(NEW_BUFFER *buffer, uint32 buffer_size)
 /***************************************************************************
  receive the notify message
 ****************************************************************************/
-void srv_spoolss_receive_message(int msg_type, pid_t src, void *buf, size_t len)
+
+static void srv_spoolss_receive_message(int msg_type, pid_t src, void *buf, size_t len)
 {
        fstring printer;
-       uint32 status;
-       Printer_entry *find_printer;
+       WERROR status;
+       struct pipes_struct *p;
+       struct policy *pol;
+       struct handle_list *hl;
 
        *printer = '\0';
        fstrcpy(printer,buf);
@@ -600,10 +625,31 @@ void srv_spoolss_receive_message(int msg_type, pid_t src, void *buf, size_t len)
 
        DEBUG(10,("srv_spoolss_receive_message: Got message about printer %s\n", printer ));
 
-       find_printer = (Printer_entry *)ubi_dlFirst(&Printer_list);
+       /*
+        * We need to enumerate all printers. The handle list is shared
+        * across pipes of the same name, so just find the first open
+        * spoolss pipe.
+        */
+
+       hl = NULL;      
+       for ( p = get_first_internal_pipe(); p; get_next_internal_pipe(p)) {
+               if (strequal(p->name, "spoolss")) {
+                       hl = p->pipe_handles;
+                       break;
+               }
+       }
+
+       if (!hl) {
+               DEBUG(0,("srv_spoolss_receive_message: no handle list on spoolss pipe !\n"));
+               return;
+       }
+
+       /* Iterate the printer list on this pipe. */
+       for (pol = hl->Policy; pol; pol = pol->next ) {
+               Printer_entry *find_printer = (Printer_entry *)pol->data_ptr;
 
-       /* Iterate the printer list. */
-       for(; find_printer; find_printer = (Printer_entry *)ubi_dlNext(find_printer)) {
+               if (!find_printer)
+                       continue;
 
                /*
                 * if the entry is the given printer or if it's a printerserver
@@ -616,20 +662,19 @@ void srv_spoolss_receive_message(int msg_type, pid_t src, void *buf, size_t len)
 
                if (find_printer->notify.client_connected==True)
                        cli_spoolss_reply_rrpcn(&cli, &find_printer->notify.client_hnd, PRINTER_CHANGE_ALL, 0x0, &status);
-
        }
 }
 
 /***************************************************************************
  send a notify event
 ****************************************************************************/
-static BOOL srv_spoolss_sendnotify(POLICY_HND *handle)
+static BOOL srv_spoolss_sendnotify(pipes_struct *p, POLICY_HND *handle)
 {
        fstring printer;
 
-       Printer_entry *Printer=find_printer_index_by_hnd(handle);
+       Printer_entry *Printer=find_printer_index_by_hnd(p, handle);
 
-       if (!OPEN_HANDLE(Printer)) {
+       if (!Printer) {
                DEBUG(0,("srv_spoolss_sendnotify: Invalid handle (%s).\n", OUR_HANDLE(handle)));
                return False;
        }
@@ -642,7 +687,7 @@ static BOOL srv_spoolss_sendnotify(POLICY_HND *handle)
        /*srv_spoolss_receive_message(printer);*/
        DEBUG(10,("srv_spoolss_sendnotify: Sending message about printer %s\n", printer ));
 
-       message_send_all(conn_tdb_ctx(), MSG_PRINTER_NOTIFY, printer, strlen(printer) + 1, False); /* Null terminate... */
+       broadcast_printer_notify(printer);
 
        return True;
 }      
@@ -652,21 +697,28 @@ static BOOL srv_spoolss_sendnotify(POLICY_HND *handle)
  *
  * called from the spoolss dispatcher
  ********************************************************************/
-uint32 _spoolss_open_printer_ex( const UNISTR2 *printername,
-                                const PRINTER_DEFAULT *printer_default,
-                                uint32  user_switch, SPOOL_USER_CTR user_ctr,
-                                POLICY_HND *handle)
-{
-       uint32 result = NT_STATUS_NO_PROBLEMO;
-       SEC_DESC_BUF *sec_desc = NULL;
-       uint32 acc_granted, status;
+
+WERROR _spoolss_open_printer_ex( pipes_struct *p, SPOOL_Q_OPEN_PRINTER_EX *q_u, SPOOL_R_OPEN_PRINTER_EX *r_u)
+{
+#if 0
+       WERROR result = WERR_OK;
+#endif
+
+       UNISTR2 *printername = NULL;
+       PRINTER_DEFAULT *printer_default = &q_u->printer_default;
+/*     uint32 user_switch = q_u->user_switch; - notused */
+/*     SPOOL_USER_CTR user_ctr = q_u->user_ctr; - notused */
+       POLICY_HND *handle = &r_u->handle;
+
        fstring name;
-       extern struct current_user current_user;
-       
-       if (printername == NULL) {
-               result = ERROR_INVALID_PRINTER_NAME;
-               goto done;
-       }
+       int snum;
+       struct current_user user;
+
+       if (q_u->printername_ptr != 0)
+               printername = &q_u->printername;
+
+       if (printername == NULL)
+               return WERR_INVALID_PRINTER_NAME;
 
        /* some sanity check because you can open a printer or a print server */
        /* aka: \\server\printer or \\server */
@@ -674,10 +726,8 @@ uint32 _spoolss_open_printer_ex( const UNISTR2 *printername,
 
        DEBUGADD(3,("checking name: %s\n",name));
 
-       if (!open_printer_hnd(handle, name)) {
-               result = ERROR_INVALID_PRINTER_NAME;
-               goto done;
-       }
+       if (!open_printer_hnd(p, handle, name))
+               return WERR_INVALID_PRINTER_NAME;
        
 /*
        if (printer_default->datatype_ptr != NULL)
@@ -689,59 +739,166 @@ uint32 _spoolss_open_printer_ex( const UNISTR2 *printername,
                set_printer_hnd_datatype(handle, "");
 */
        
-       if (!set_printer_hnd_accesstype(handle, printer_default->access_required)) {
-               close_printer_handle(handle);
-               result = ERROR_ACCESS_DENIED;
-               goto done;
+       if (!set_printer_hnd_accesstype(p, handle, printer_default->access_required)) {
+               close_printer_handle(p, handle);
+               return WERR_ACCESS_DENIED;
        }
                
-       /* Disallow MS AddPrinterWizard if parameter disables it. A Win2k
+       /*
+          First case: the user is opening the print server:
+
+          Disallow MS AddPrinterWizard if parameter disables it. A Win2k
           client 1st tries an OpenPrinterEx with access==0, MUST be allowed.
+
           Then both Win2k and WinNT clients try an OpenPrinterEx with
-          SERVER_ALL_ACCESS, which we force to fail. Then they try
-          OpenPrinterEx with SERVER_READ which we allow. This lets the
+          SERVER_ALL_ACCESS, which we allow only if the user is root (uid=0)
+          or if the user is listed in the smb.conf printer admin parameter.
+
+          Then they try OpenPrinterEx with SERVER_READ which we allow. This lets the
           client view printer folder, but does not show the MSAPW.
 
           Note: this test needs code to check access rights here too. Jeremy
-          could you look at this? */
+          could you look at this?
+          
+          
+          Second case: the user is opening a printer:
+          NT doesn't let us connect to a printer if the connecting user
+          doesn't have print permission.
+
+       */
+
+       get_current_user(&user, p);
 
-       if (handle_is_printserver(handle) &&
-           !lp_ms_add_printer_wizard()) {
+       if (handle_is_printserver(p, handle)) {
                if (printer_default->access_required == 0) {
-                       goto done;
+                       return WERR_OK;
                }
-               else if (printer_default->access_required != (SERVER_READ)) {
-                       close_printer_handle(handle);
-                       result = ERROR_ACCESS_DENIED;
-                       goto done;
+               else if ((printer_default->access_required & SERVER_ACCESS_ADMINISTER ) == SERVER_ACCESS_ADMINISTER) {
+
+                       /* Printserver handles use global struct... */
+                       snum = -1;
+
+                       if (!lp_ms_add_printer_wizard()) {
+                               close_printer_handle(p, handle);
+                               return WERR_ACCESS_DENIED;
+                       }
+                       else if (user.uid == 0 || user_in_list(uidtoname(user.uid), lp_printer_admin(snum))) {
+                               return WERR_OK;
+                       } 
+                       else {
+                               close_printer_handle(p, handle);
+                               return WERR_ACCESS_DENIED;
+                       }
                }
        }
+       else
+       {
+               /* NT doesn't let us connect to a printer if the connecting user
+                  doesn't have print permission.  */
 
-       /* NT doesn't let us connect to a printer if the connecting user
-          doesn't have print permission.  If no security descriptor just
-          return OK. */
+               if (!get_printer_snum(p, handle, &snum))
+                       return WERR_BADFID;
 
-       if (!nt_printing_getsec(name, &sec_desc)) {
-               goto done;
-       }
-       
-       /* Yuck - we should use the pipe_user rather than current_user but
-          it doesn't seem to be filled in correctly. )-: */
+               /* map an empty access mask to the minimum access mask */
+               if (printer_default->access_required == 0x0)
+                       printer_default->access_required = PRINTER_ACCESS_USE;
+               
 
-       map_printer_permissions(sec_desc->sec);
+               /*
+                * If we are not serving the printer driver for this printer,
+                * map PRINTER_ACCESS_ADMINISTER to PRINTER_ACCESS_USE.  This
+                * will keep NT clients happy  --jerry  
+                */
+                
+               if (lp_use_client_driver(snum) 
+                       && (printer_default->access_required & PRINTER_ACCESS_ADMINISTER))
+               {
+                       printer_default->access_required = PRINTER_ACCESS_USE;
+               }
 
-       if (!se_access_check(sec_desc->sec, &current_user, PRINTER_ACCESS_USE,
-                            &acc_granted, &status)) {
-               DEBUG(3, ("access DENIED for printer open\n"));
-               close_printer_handle(handle);
-               result = ERROR_ACCESS_DENIED;
-               goto done;
-       }
+               if (!print_access_check(&user, snum, printer_default->access_required)) {
+                       DEBUG(3, ("access DENIED for printer open\n"));
+                       close_printer_handle(p, handle);
+                       return WERR_ACCESS_DENIED;
+               }
 
- done:
-       free_sec_desc_buf(&sec_desc);
+               /*
+                * If we have a default device pointer in the
+                * printer_default struct, then we need to get
+                * the printer info from the tdb and if there is
+                * no default devicemode there then we do a *SET*
+                * here ! This is insanity.... JRA.
+                */
 
-       return result;
+               /*
+                * If the openprinterex rpc call contains a devmode,
+                * it's a per-user one. This per-user devmode is derivated
+                * from the global devmode. Openprinterex() contains a per-user 
+                * devmode for when you do EMF printing and spooling.
+                * In the EMF case, the NT workstation is only doing half the job
+                * of rendering the page. The other half is done by running the printer
+                * driver on the server.
+                * The EMF file doesn't contain the page description (paper size, orientation, ...).
+                * The EMF file only contains what is to be printed on the page.
+                * So in order for the server to know how to print, the NT client sends
+                * a devicemode attached to the openprinterex call.
+                * But this devicemode is short lived, it's only valid for the current print job.
+                *
+                * If Samba would have supported EMF spooling, this devicemode would
+                * have been attached to the handle, to sent it to the driver to correctly
+                * rasterize the EMF file.
+                *
+                * As Samba only supports RAW spooling, we only receive a ready-to-print file,
+                * we just act as a pass-thru between windows and the printer.
+                *
+                * In order to know that Samba supports only RAW spooling, NT has to call
+                * getprinter() at level 2 (attribute field) or NT has to call startdoc()
+                * and until NT sends a RAW job, we refuse it.
+                *
+                * But to call getprinter() or startdoc(), you first need a valid handle,
+                * and to get an handle you have to call openprintex(). Hence why you have
+                * a devicemode in the openprinterex() call.
+                *
+                *
+                * Differences between NT4 and NT 2000.
+                * NT4:
+                * ---
+                * On NT4, you only have a global devicemode. This global devicemode can be changed
+                * by the administrator (or by a user with enough privs). Everytime a user
+                * wants to print, the devicemode is resetted to the default. In Word, everytime
+                * you print, the printer's characteristics are always reset to the global devicemode.
+                *
+                * NT 2000:
+                * -------
+                * In W2K, there is the notion of per-user devicemode. The first time you use
+                * a printer, a per-user devicemode is build from the global devicemode.
+                * If you change your per-user devicemode, it is saved in the registry, under the
+                * H_KEY_CURRENT_KEY sub_tree. So that everytime you print, you have your default
+                * printer preferences available.
+                *
+                * To change the per-user devicemode: it's the "Printing Preferences ..." button
+                * on the General Tab of the printer properties windows.
+                *
+                * To change the global devicemode: it's the "Printing Defaults..." button
+                * on the Advanced Tab of the printer properties window.
+                *
+                * JFM.
+                */
+
+
+
+#if 0
+               if (printer_default->devmode_cont.devmode != NULL) {
+                       result = printer_write_default_dev( snum, printer_default);
+                       if (result != 0) {
+                               close_printer_handle(p, handle);
+                               return result;
+                       }
+               }
+#endif
+       }
+
+       return WERR_OK;
 }
 
 /****************************************************************************
@@ -749,45 +906,64 @@ uint32 _spoolss_open_printer_ex( const UNISTR2 *printername,
 static BOOL convert_printer_info(const SPOOL_PRINTER_INFO_LEVEL *uni,
                                NT_PRINTER_INFO_LEVEL *printer, uint32 level)
 {
+       BOOL ret = True;
+
        switch (level) {
                case 2:
-                       uni_2_asc_printer_info_2(uni->info_2, &printer->info_2);
+                       ret = uni_2_asc_printer_info_2(uni->info_2, &printer->info_2);
                        break;
                default:
                        break;
        }
 
-       return True;
+       return ret;
 }
 
 static BOOL convert_printer_driver_info(const SPOOL_PRINTER_DRIVER_INFO_LEVEL *uni,
                                        NT_PRINTER_DRIVER_INFO_LEVEL *printer, uint32 level)
 {
+       BOOL result = True;
+
        switch (level) {
                case 3:
                        printer->info_3=NULL;
-                       uni_2_asc_printer_driver_3(uni->info_3, &printer->info_3);
+                       if (!uni_2_asc_printer_driver_3(uni->info_3, &printer->info_3))
+                               result = False;
                        break;
                case 6:
                        printer->info_6=NULL;
-                       uni_2_asc_printer_driver_6(uni->info_6, &printer->info_6);
+                       if (!uni_2_asc_printer_driver_6(uni->info_6, &printer->info_6))
+                               result = False;
                        break;
                default:
                        break;
        }
 
-       return True;
+       return result;
 }
 
-static BOOL convert_devicemode(const DEVICEMODE *devmode, NT_DEVICEMODE *nt_devmode)
+BOOL convert_devicemode(char *printername, const DEVICEMODE *devmode,
+                               NT_DEVICEMODE **pp_nt_devmode)
 {
-       unistr_to_dos(nt_devmode->devicename, (const char *)devmode->devicename.buffer, 31);
-       unistr_to_dos(nt_devmode->formname, (const char *)devmode->formname.buffer, 31);
+       NT_DEVICEMODE *nt_devmode = *pp_nt_devmode;
+
+       /*
+        * Ensure nt_devmode is a valid pointer
+        * as we will be overwriting it.
+        */
+               
+       if (nt_devmode == NULL) {
+               DEBUG(5, ("convert_devicemode: allocating a generic devmode\n"));
+               if ((nt_devmode = construct_nt_devicemode(printername)) == NULL)
+                       return False;
+       }
+
+       rpcstr_pull(nt_devmode->devicename,devmode->devicename.buffer, 31, -1, 0);
+       rpcstr_pull(nt_devmode->formname,devmode->formname.buffer, 31, -1, 0);
 
        nt_devmode->specversion=devmode->specversion;
        nt_devmode->driverversion=devmode->driverversion;
        nt_devmode->size=devmode->size;
-       nt_devmode->driverextra=devmode->driverextra;
        nt_devmode->fields=devmode->fields;
        nt_devmode->orientation=devmode->orientation;
        nt_devmode->papersize=devmode->papersize;
@@ -818,58 +994,167 @@ static BOOL convert_devicemode(const DEVICEMODE *devmode, NT_DEVICEMODE *nt_devm
        nt_devmode->panningwidth=devmode->panningwidth;
        nt_devmode->panningheight=devmode->panningheight;
 
-       safe_free(nt_devmode->private);
-       if (nt_devmode->driverextra != 0) {
-               /* if we had a previous private delete it and make a new one */
+       /*
+        * Only change private and driverextra if the incoming devmode
+        * has a new one. JRA.
+        */
+
+       if ((devmode->driverextra != 0) && (devmode->private != NULL)) {
+               SAFE_FREE(nt_devmode->private);
+               nt_devmode->driverextra=devmode->driverextra;
                if((nt_devmode->private=(uint8 *)malloc(nt_devmode->driverextra * sizeof(uint8))) == NULL)
                        return False;
                memcpy(nt_devmode->private, devmode->private, nt_devmode->driverextra);
        }
-       else {
-               nt_devmode->private = NULL;
-       }
+
+       *pp_nt_devmode = nt_devmode;
 
        return True;
 }
 
+/********************************************************************
+ * _spoolss_enddocprinter_internal.
+ ********************************************************************/
+
+static WERROR _spoolss_enddocprinter_internal(pipes_struct *p, POLICY_HND *handle)
+{
+       Printer_entry *Printer=find_printer_index_by_hnd(p, handle);
+       
+       if (!Printer) {
+               DEBUG(0,("_spoolss_enddocprinter_internal: Invalid handle (%s)\n", OUR_HANDLE(handle)));
+               return WERR_BADFID;
+       }
+       
+       Printer->document_started=False;
+       print_job_end(Printer->jobid,True);
+       /* error codes unhandled so far ... */
+
+       return WERR_OK;
+}
+
 /********************************************************************
  * api_spoolss_closeprinter
  ********************************************************************/
-uint32 _spoolss_closeprinter(POLICY_HND *handle)
+
+WERROR _spoolss_closeprinter(pipes_struct *p, SPOOL_Q_CLOSEPRINTER *q_u, SPOOL_R_CLOSEPRINTER *r_u)
 {
-       Printer_entry *Printer=find_printer_index_by_hnd(handle);
+       POLICY_HND *handle = &q_u->handle;
+
+       Printer_entry *Printer=find_printer_index_by_hnd(p, handle);
 
        if (Printer && Printer->document_started)
-               _spoolss_enddocprinter(handle);          /* print job was not closed */
+               _spoolss_enddocprinter_internal(p, handle);          /* print job was not closed */
+
+       memcpy(&r_u->handle, &q_u->handle, sizeof(r_u->handle));
 
-       if (!close_printer_handle(handle))
-               return ERROR_INVALID_HANDLE;    
+       if (!close_printer_handle(p, handle))
+               return WERR_BADFID;     
                
-       return NT_STATUS_NO_PROBLEMO;
+       return WERR_OK;
 }
 
 /********************************************************************
  * api_spoolss_deleteprinter
+
  ********************************************************************/
-uint32 _spoolss_deleteprinter(POLICY_HND *handle)
+
+WERROR _spoolss_deleteprinter(pipes_struct *p, SPOOL_Q_DELETEPRINTER *q_u, SPOOL_R_DELETEPRINTER *r_u)
 {
-       Printer_entry *Printer=find_printer_index_by_hnd(handle);
+       POLICY_HND *handle = &q_u->handle;
+       Printer_entry *Printer=find_printer_index_by_hnd(p, handle);
+       WERROR result;
 
        if (Printer && Printer->document_started)
-               _spoolss_enddocprinter(handle);          /* print job was not closed */
+               _spoolss_enddocprinter_internal(p, handle);  /* print job was not closed */
+
+       memcpy(&r_u->handle, &q_u->handle, sizeof(r_u->handle));
+
+       result = delete_printer_handle(p, handle);
 
-       if (!delete_printer_handle(handle))
-               return ERROR_INVALID_HANDLE;    
+       if (W_ERROR_IS_OK(result)) {
+               srv_spoolss_sendnotify(p, handle);
+       }
+               
+       return result;
+}
+
+/*******************************************************************
+ * static function to lookup the version id corresponding to an
+ * long architecture string
+ ******************************************************************/
+static int get_version_id (char * arch)
+{
+       int i;
+       struct table_node archi_table[]= {
+               {"Windows 4.0",          "WIN40",       0 },
+               {"Windows NT x86",       "W32X86",      2 },
+               {"Windows NT R4000",     "W32MIPS",     2 },    
+               {"Windows NT Alpha_AXP", "W32ALPHA",    2 },
+               {"Windows NT PowerPC",   "W32PPC",      2 },
+               {NULL,                   "",            -1 }
+       };
+       for (i=0; archi_table[i].long_archi != NULL; i++)
+       {
+               if (strcmp(arch, archi_table[i].long_archi) == 0)
+                       return (archi_table[i].version);
+        }
+       
+       return -1;
+}
+
+/********************************************************************
+ * _spoolss_deleteprinterdriver
+ *
+ * We currently delete the driver for the architecture only.
+ * This can leave the driver for other archtectures.  However,
+ * since every printer associates a "Windows NT x86" driver name
+ * and we cannot delete that one while it is in use, **and** since
+ * it is impossible to assign a driver to a Samba printer without
+ * having the "Windows NT x86" driver installed,...
+ * 
+ * ....we should not get into trouble here.  
+ *
+ *                                                      --jerry
+ ********************************************************************/
 
-       srv_spoolss_sendnotify(handle);
+WERROR _spoolss_deleteprinterdriver(pipes_struct *p, SPOOL_Q_DELETEPRINTERDRIVER *q_u, 
+                                   SPOOL_R_DELETEPRINTERDRIVER *r_u)
+{
+       fstring                         driver;
+       fstring                         arch;
+       NT_PRINTER_DRIVER_INFO_LEVEL    info;
+       int                             version;
+        
+       unistr2_to_ascii(driver, &q_u->driver, sizeof(driver)-1 );
+       unistr2_to_ascii(arch,   &q_u->arch,   sizeof(arch)-1   );
+       
+       /* check that we have a valid driver name first */
+       if ((version=get_version_id(arch)) == -1) {
+               /* this is what NT returns */
+               return WERR_INVALID_ENVIRONMENT;
+       }
                
-       return NT_STATUS_NO_PROBLEMO;
+       ZERO_STRUCT(info);
+       if (!W_ERROR_IS_OK(get_a_printer_driver(&info, 3, driver, arch, version))) {
+               return WERR_UNKNOWN_PRINTER_DRIVER;
+       }
+       
+
+       if (printer_driver_in_use(arch, driver))
+       {
+               return WERR_PRINTER_DRIVER_IN_USE;
+       }
+
+       return delete_printer_driver(info.info_3);       
 }
 
+
 /********************************************************************
  GetPrinterData on a printer server Handle.
 ********************************************************************/
-static BOOL getprinterdata_printer_server(fstring value, uint32 *type, uint8 **data, uint32 *needed, uint32 in_size)
+static BOOL getprinterdata_printer_server(TALLOC_CTX *ctx, fstring value, uint32 *type, uint8 **data, uint32 *needed, uint32 in_size)
 {              
        int i;
        
@@ -877,7 +1162,7 @@ static BOOL getprinterdata_printer_server(fstring value, uint32 *type, uint8 **d
                
        if (!strcmp(value, "BeepEnabled")) {
                *type = 0x4;
-               if((*data = (uint8 *)malloc( 4*sizeof(uint8) )) == NULL)
+               if((*data = (uint8 *)talloc(ctx, 4*sizeof(uint8) )) == NULL)
                        return False;
                SIVAL(*data, 0, 0x01);
                *needed = 0x4;                  
@@ -886,7 +1171,7 @@ static BOOL getprinterdata_printer_server(fstring value, uint32 *type, uint8 **d
 
        if (!strcmp(value, "EventLog")) {
                *type = 0x4;
-               if((*data = (uint8 *)malloc( 4*sizeof(uint8) )) == NULL)
+               if((*data = (uint8 *)talloc(ctx, 4*sizeof(uint8) )) == NULL)
                        return False;
                SIVAL(*data, 0, 0x1B);
                *needed = 0x4;                  
@@ -895,7 +1180,7 @@ static BOOL getprinterdata_printer_server(fstring value, uint32 *type, uint8 **d
 
        if (!strcmp(value, "NetPopup")) {
                *type = 0x4;
-               if((*data = (uint8 *)malloc( 4*sizeof(uint8) )) == NULL)
+               if((*data = (uint8 *)talloc(ctx, 4*sizeof(uint8) )) == NULL)
                        return False;
                SIVAL(*data, 0, 0x01);
                *needed = 0x4;
@@ -904,18 +1189,18 @@ static BOOL getprinterdata_printer_server(fstring value, uint32 *type, uint8 **d
 
        if (!strcmp(value, "MajorVersion")) {
                *type = 0x4;
-               if((*data = (uint8 *)malloc( 4*sizeof(uint8) )) == NULL)
+               if((*data = (uint8 *)talloc(ctx, 4*sizeof(uint8) )) == NULL)
                        return False;
                SIVAL(*data, 0, 0x02);
                *needed = 0x4;
                return True;
        }
 
-       if (!strcmp(value, "DefaultSpoolDirectory")) {
+   if (!strcmp(value, "DefaultSpoolDirectory")) {
                pstring string="You are using a Samba server";
                *type = 0x1;                    
                *needed = 2*(strlen(string)+1);         
-               if((*data  = (uint8 *)malloc( ((*needed > in_size) ? *needed:in_size) *sizeof(uint8))) == NULL)
+               if((*data  = (uint8 *)talloc(ctx, ((*needed > in_size) ? *needed:in_size) *sizeof(uint8))) == NULL)
                        return False;
                memset(*data, 0, (*needed > in_size) ? *needed:in_size);
                
@@ -931,7 +1216,7 @@ static BOOL getprinterdata_printer_server(fstring value, uint32 *type, uint8 **d
                pstring string="Windows NT x86";
                *type = 0x1;                    
                *needed = 2*(strlen(string)+1); 
-               if((*data  = (uint8 *)malloc( ((*needed > in_size) ? *needed:in_size) *sizeof(uint8))) == NULL)
+               if((*data  = (uint8 *)talloc(ctx, ((*needed > in_size) ? *needed:in_size) *sizeof(uint8))) == NULL)
                        return False;
                memset(*data, 0, (*needed > in_size) ? *needed:in_size);
                for (i=0; i<strlen(string); i++) {
@@ -947,7 +1232,7 @@ static BOOL getprinterdata_printer_server(fstring value, uint32 *type, uint8 **d
 /********************************************************************
  GetPrinterData on a printer Handle.
 ********************************************************************/
-static BOOL getprinterdata_printer(POLICY_HND *handle,
+static BOOL getprinterdata_printer(pipes_struct *p, TALLOC_CTX *ctx, POLICY_HND *handle,
                                fstring value, uint32 *type,
                                uint8 **data, uint32 *needed, uint32 in_size )
 {
@@ -955,19 +1240,19 @@ static BOOL getprinterdata_printer(POLICY_HND *handle,
        int snum=0;
        uint8 *idata=NULL;
        uint32 len;
-       Printer_entry *Printer = find_printer_index_by_hnd(handle);
+       Printer_entry *Printer = find_printer_index_by_hnd(p, handle);
        
        DEBUG(5,("getprinterdata_printer\n"));
 
-       if (!OPEN_HANDLE(Printer)) {
+       if (!Printer) {
                DEBUG(0,("getprinterdata_printer: Invalid handle (%s).\n", OUR_HANDLE(handle)));
                return False;
        }
 
-       if(!get_printer_snum(handle, &snum))
+       if(!get_printer_snum(p, handle, &snum))
                return False;
 
-       if(get_a_printer(&printer, 2, lp_servicename(snum)) != 0)
+       if (!W_ERROR_IS_OK(get_a_printer(&printer, 2, lp_servicename(snum))))
                return False;
 
        if (!get_specific_param(*printer, 2, value, &idata, type, &len)) {
@@ -980,7 +1265,7 @@ static BOOL getprinterdata_printer(POLICY_HND *handle,
        DEBUG(5,("getprinterdata_printer:allocating %d\n", in_size));
 
        if (in_size) {
-               if((*data  = (uint8 *)malloc( in_size *sizeof(uint8) )) == NULL) {
+               if((*data  = (uint8 *)talloc(ctx, in_size *sizeof(uint8) )) == NULL) {
                        return False;
                }
 
@@ -995,7 +1280,7 @@ static BOOL getprinterdata_printer(POLICY_HND *handle,
        
        DEBUG(5,("getprinterdata_printer:copy done\n"));
                        
-       safe_free(idata);
+       SAFE_FREE(idata);
        
        return True;
 }      
@@ -1003,16 +1288,20 @@ static BOOL getprinterdata_printer(POLICY_HND *handle,
 /********************************************************************
  * spoolss_getprinterdata
  ********************************************************************/
-uint32 _spoolss_getprinterdata(POLICY_HND *handle, UNISTR2 *valuename,
-                               uint32 in_size,
-                               uint32 *type,
-                               uint32 *out_size,
-                               uint8 **data,
-                               uint32 *needed)
+
+WERROR _spoolss_getprinterdata(pipes_struct *p, SPOOL_Q_GETPRINTERDATA *q_u, SPOOL_R_GETPRINTERDATA *r_u)
 {
+       POLICY_HND *handle = &q_u->handle;
+       UNISTR2 *valuename = &q_u->valuename;
+       uint32 in_size = q_u->size;
+       uint32 *type = &r_u->type;
+       uint32 *out_size = &r_u->size;
+       uint8 **data = &r_u->data;
+       uint32 *needed = &r_u->needed;
+
        fstring value;
        BOOL found=False;
-       Printer_entry *Printer = find_printer_index_by_hnd(handle);
+       Printer_entry *Printer = find_printer_index_by_hnd(p, handle);
        
        /*
         * Reminder: when it's a string, the length is in BYTES
@@ -1029,38 +1318,37 @@ uint32 _spoolss_getprinterdata(POLICY_HND *handle, UNISTR2 *valuename,
        
        DEBUG(4,("_spoolss_getprinterdata\n"));
        
-       if (!OPEN_HANDLE(Printer)) {
-               if((*data=(uint8 *)malloc(4*sizeof(uint8))) == NULL)
-                       return ERROR_NOT_ENOUGH_MEMORY;
+       if (!Printer) {
+               if((*data=(uint8 *)talloc_zero(p->mem_ctx, 4*sizeof(uint8))) == NULL)
+                       return WERR_NOMEM;
                DEBUG(0,("_spoolss_getprinterdata: Invalid handle (%s).\n", OUR_HANDLE(handle)));
-               return ERROR_INVALID_HANDLE;
+               return WERR_BADFID;
        }
        
        unistr2_to_ascii(value, valuename, sizeof(value)-1);
        
-       if (handle_is_printserver(handle))
-               found=getprinterdata_printer_server(value, type, data, needed, *out_size);
+       if (Printer->printer_type == PRINTER_HANDLE_IS_PRINTSERVER)
+               found=getprinterdata_printer_server(p->mem_ctx, value, type, data, needed, *out_size);
        else
-               found=getprinterdata_printer(handle, value, type, data, needed, *out_size);
+               found= getprinterdata_printer(p, p->mem_ctx, handle, value, type, data, needed, *out_size);
 
        if (found==False) {
                DEBUG(5, ("value not found, allocating %d\n", *out_size));
                /* reply this param doesn't exist */
                if (*out_size) {
-                       if((*data=(uint8 *)malloc(*out_size*sizeof(uint8))) == NULL)
-                               return ERROR_NOT_ENOUGH_MEMORY;
-                       memset(*data, '\0', *out_size*sizeof(uint8));
+                       if((*data=(uint8 *)talloc_zero(p->mem_ctx, *out_size*sizeof(uint8))) == NULL)
+                               return WERR_NOMEM;
                } else {
                        *data = NULL;
                }
 
-               return ERROR_INVALID_PARAMETER;
+               return WERR_INVALID_PARAM;
        }
        
        if (*needed > *out_size)
-               return ERROR_MORE_DATA;
-       else
-               return NT_STATUS_NO_PROBLEMO;
+               return WERR_STATUS_MORE_ENTRIES;
+       else 
+               return WERR_OK;
 }
 
 /***************************************************************************
@@ -1068,14 +1356,18 @@ uint32 _spoolss_getprinterdata(POLICY_HND *handle, UNISTR2 *valuename,
 ****************************************************************************/
 static BOOL srv_spoolss_replyopenprinter(char *printer, uint32 localprinter, uint32 type, POLICY_HND *handle)
 {
-       uint32 status;
+       WERROR status;
 
        /*
         * If it's the first connection, contact the client
         * and connect to the IPC$ share anonumously
         */
        if (smb_connections==0) {
-               if(!spoolss_connect_to_client(&cli, printer+2)) /* the +2 is to strip the leading 2 backslashs */
+               fstring unix_printer;
+
+               fstrcpy(unix_printer, printer+2); /* the +2 is to strip the leading 2 backslashs */
+
+               if(!spoolss_connect_to_client(&cli, unix_printer))
                        return False;
                message_register(MSG_PRINTER_NOTIFY, srv_spoolss_receive_message);
 
@@ -1100,23 +1392,34 @@ static BOOL srv_spoolss_replyopenprinter(char *printer, uint32 localprinter, uin
  * in fact ReplyOpenPrinter is the changenotify equivalent on the spoolss pipe
  * called from api_spoolss_rffpcnex
  ********************************************************************/
-uint32 _spoolss_rffpcnex(POLICY_HND *handle, uint32 flags, uint32 options,
-                        const UNISTR2 *localmachine, uint32 printerlocal,
-                        SPOOL_NOTIFY_OPTION *option)
+
+WERROR _spoolss_rffpcnex(pipes_struct *p, SPOOL_Q_RFFPCNEX *q_u, SPOOL_R_RFFPCNEX *r_u)
 {
+       POLICY_HND *handle = &q_u->handle;
+       uint32 flags = q_u->flags;
+       uint32 options = q_u->options;
+       UNISTR2 *localmachine = &q_u->localmachine;
+       uint32 printerlocal = q_u->printerlocal;
+       SPOOL_NOTIFY_OPTION *option = q_u->option;
+
        /* store the notify value in the printer struct */
 
-       Printer_entry *Printer=find_printer_index_by_hnd(handle);
+       Printer_entry *Printer=find_printer_index_by_hnd(p, handle);
 
-       if (!OPEN_HANDLE(Printer)) {
+       if (!Printer) {
                DEBUG(0,("_spoolss_rffpcnex: Invalid handle (%s).\n", OUR_HANDLE(handle)));
-               return ERROR_INVALID_HANDLE;
+               return WERR_BADFID;
        }
 
        Printer->notify.flags=flags;
        Printer->notify.options=options;
        Printer->notify.printerlocal=printerlocal;
-       Printer->notify.option=option;
+
+       if (Printer->notify.option)
+               free_spool_notify_option(&Printer->notify.option);
+
+       Printer->notify.option=dup_spool_notify_option(option);
+
        unistr2_to_ascii(Printer->notify.localmachine, localmachine, sizeof(Printer->notify.localmachine)-1);
 
        /* connect to the client machine and send a ReplyOpenPrinter */
@@ -1125,59 +1428,120 @@ uint32 _spoolss_rffpcnex(POLICY_HND *handle, uint32 flags, uint32 options,
                                        &Printer->notify.client_hnd))
                Printer->notify.client_connected=True;
 
-       return NT_STATUS_NO_PROBLEMO;
+       return WERR_OK;
 }
 
 /*******************************************************************
  * fill a notify_info_data with the servername
  ********************************************************************/
-static void spoolss_notify_server_name(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue,
-                                                                               NT_PRINTER_INFO_LEVEL *printer)
+
+static void spoolss_notify_server_name(int snum, 
+                                      SPOOL_NOTIFY_INFO_DATA *data, 
+                                      print_queue_struct *queue,
+                                      NT_PRINTER_INFO_LEVEL *printer,
+                                      TALLOC_CTX *mem_ctx) 
 {
-       pstring temp_name;
+       pstring temp_name, temp;
+       uint32 len;
+
+       slprintf(temp_name, sizeof(temp_name)-1, "\\\\%s", get_called_name());
 
-       snprintf(temp_name, sizeof(temp_name)-1, "\\\\%s", global_myname);
+       len = rpcstr_push(temp, temp_name, sizeof(temp)-2, STR_TERMINATE);
 
-       data->notify_data.data.length= (uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
-                                       temp_name, sizeof(data->notify_data.data.string), True) - sizeof(uint16))/sizeof(uint16));
+       data->notify_data.data.length = len / 2;
+       data->notify_data.data.string = (uint16 *)talloc(mem_ctx, len);
+
+       if (!data->notify_data.data.string) {
+               data->notify_data.data.length = 0;
+               return;
+       }
+       
+       memcpy(data->notify_data.data.string, temp, len);
 }
 
 /*******************************************************************
  * fill a notify_info_data with the printername (not including the servername).
  ********************************************************************/
-static void spoolss_notify_printer_name(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue,
-                                                                               NT_PRINTER_INFO_LEVEL *printer)
+static void spoolss_notify_printer_name(int snum, 
+                                       SPOOL_NOTIFY_INFO_DATA *data, 
+                                       print_queue_struct *queue,
+                                       NT_PRINTER_INFO_LEVEL *printer,
+                                       TALLOC_CTX *mem_ctx)
 {
+       pstring temp;
+       uint32 len;
+               
        /* the notify name should not contain the \\server\ part */
-       char *p = strrchr(printer->info_2->printername, '\\');
+       char *p = strrchr_m(printer->info_2->printername, '\\');
+
        if (!p) {
                p = printer->info_2->printername;
        } else {
                p++;
        }
 
-       data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
-                               p, sizeof(data->notify_data.data.string), True) - sizeof(uint16))/sizeof(uint16));
+       len = rpcstr_push(temp, p, sizeof(temp)-2, STR_TERMINATE);
+       data->notify_data.data.length = len / 2;
+       data->notify_data.data.string = (uint16 *)talloc(mem_ctx, len);
+       
+       if (!data->notify_data.data.string) {
+               data->notify_data.data.length = 0;
+               return;
+       }
+       
+       memcpy(data->notify_data.data.string, temp, len);
 }
 
 /*******************************************************************
  * fill a notify_info_data with the servicename
  ********************************************************************/
-static void spoolss_notify_share_name(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
+static void spoolss_notify_share_name(int snum, 
+                                     SPOOL_NOTIFY_INFO_DATA *data, 
+                                     print_queue_struct *queue,
+                                     NT_PRINTER_INFO_LEVEL *printer,
+                                     TALLOC_CTX *mem_ctx)
 {
-       data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
-                       lp_servicename(snum), sizeof(data->notify_data.data.string),True) - sizeof(uint16))/sizeof(uint16));
+       pstring temp;
+       uint32 len;
+
+       len = rpcstr_push(temp, lp_servicename(snum), sizeof(temp)-2, STR_TERMINATE);
+
+       data->notify_data.data.length = len / 2;
+       data->notify_data.data.string = (uint16 *)talloc(mem_ctx, len);
+       
+       if (!data->notify_data.data.string) {
+               data->notify_data.data.length = 0;
+               return;
+       }
+       
+       memcpy(data->notify_data.data.string, temp, len);
 }
 
 /*******************************************************************
  * fill a notify_info_data with the port name
  ********************************************************************/
-static void spoolss_notify_port_name(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
+static void spoolss_notify_port_name(int snum, 
+                                    SPOOL_NOTIFY_INFO_DATA *data, 
+                                    print_queue_struct *queue,
+                                    NT_PRINTER_INFO_LEVEL *printer,
+                                    TALLOC_CTX *mem_ctx)
 {
+       pstring temp;
+       uint32 len;
+
        /* even if it's strange, that's consistant in all the code */
 
-       data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
-               printer->info_2->portname, sizeof(data->notify_data.data.string), True)  - sizeof(uint16))/sizeof(uint16));
+       len = rpcstr_push(temp, printer->info_2->portname, sizeof(temp)-2, STR_TERMINATE);
+
+       data->notify_data.data.length = len / 2;
+       data->notify_data.data.string = (uint16 *)talloc(mem_ctx, len);
+       
+       if (!data->notify_data.data.string) {
+               data->notify_data.data.length = 0;
+               return;
+       }
+       
+       memcpy(data->notify_data.data.string, temp, len);
 }
 
 /*******************************************************************
@@ -1185,23 +1549,54 @@ static void spoolss_notify_port_name(int snum, SPOOL_NOTIFY_INFO_DATA *data, pri
  * jfmxxxx: it's incorrect, should be lp_printerdrivername()
  * but it doesn't exist, have to see what to do
  ********************************************************************/
-static void spoolss_notify_driver_name(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
+static void spoolss_notify_driver_name(int snum, 
+                                      SPOOL_NOTIFY_INFO_DATA *data,
+                                      print_queue_struct *queue,
+                                      NT_PRINTER_INFO_LEVEL *printer,
+                                      TALLOC_CTX *mem_ctx)
 {
-       data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
-                       printer->info_2->drivername, sizeof(data->notify_data.data.string)-1, True)  - sizeof(uint16))/sizeof(uint16));
+       pstring temp;
+       uint32 len;
+
+       len = rpcstr_push(temp, printer->info_2->drivername, sizeof(temp)-2, STR_TERMINATE);
+       data->notify_data.data.length = len / 2;
+       data->notify_data.data.string = (uint16 *)talloc(mem_ctx, len);
+       
+       if (!data->notify_data.data.string) {
+               data->notify_data.data.length = 0;
+               return;
+       }
+       
+       memcpy(data->notify_data.data.string, temp, len);
 }
 
 /*******************************************************************
  * fill a notify_info_data with the comment
  ********************************************************************/
-static void spoolss_notify_comment(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
+static void spoolss_notify_comment(int snum, 
+                                  SPOOL_NOTIFY_INFO_DATA *data,
+                                  print_queue_struct *queue,
+                                  NT_PRINTER_INFO_LEVEL *printer,
+                                  TALLOC_CTX *mem_ctx)
 {
+       pstring temp;
+       uint32 len;
+
        if (*printer->info_2->comment == '\0')
-               data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
-                       lp_comment(snum), sizeof(data->notify_data.data.string)-1, True)  - sizeof(uint16))/sizeof(uint16));
+               len = rpcstr_push(temp, lp_comment(snum), sizeof(temp)-2, STR_TERMINATE);
+
        else
-               data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
-                       printer->info_2->comment, sizeof(data->notify_data.data.string)-1, True)  - sizeof(uint16))/sizeof(uint16));
+               len = rpcstr_push(temp, printer->info_2->comment, sizeof(temp)-2, STR_TERMINATE);
+
+       data->notify_data.data.length = len / 2;
+       data->notify_data.data.string = (uint16 *)talloc(mem_ctx, len);
+       
+       if (!data->notify_data.data.string) {
+               data->notify_data.data.length = 0;
+               return;
+       }
+       
+       memcpy(data->notify_data.data.string, temp, len);
 }
 
 /*******************************************************************
@@ -1209,17 +1604,37 @@ static void spoolss_notify_comment(int snum, SPOOL_NOTIFY_INFO_DATA *data, print
  * jfm:xxxx incorrect, have to create a new smb.conf option
  * location = "Room 1, floor 2, building 3"
  ********************************************************************/
-static void spoolss_notify_location(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
+static void spoolss_notify_location(int snum, 
+                                   SPOOL_NOTIFY_INFO_DATA *data,
+                                   print_queue_struct *queue,
+                                   NT_PRINTER_INFO_LEVEL *printer,
+                                   TALLOC_CTX *mem_ctx)
 {
-       data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
-                       printer->info_2->location, sizeof(data->notify_data.data.string)-1, True)  - sizeof(uint16))/sizeof(uint16));
+       pstring temp;
+       uint32 len;
+
+       len = rpcstr_push(temp, printer->info_2->location,sizeof(temp)-2, STR_TERMINATE);
+
+       data->notify_data.data.length = len / 2;
+       data->notify_data.data.string = (uint16 *)talloc(mem_ctx, len);
+       
+       if (!data->notify_data.data.string) {
+               data->notify_data.data.length = 0;
+               return;
+       }
+       
+       memcpy(data->notify_data.data.string, temp, len);
 }
 
 /*******************************************************************
  * fill a notify_info_data with the device mode
  * jfm:xxxx don't to it for know but that's a real problem !!!
  ********************************************************************/
-static void spoolss_notify_devmode(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
+static void spoolss_notify_devmode(int snum, 
+                                  SPOOL_NOTIFY_INFO_DATA *data,
+                                  print_queue_struct *queue,
+                                  NT_PRINTER_INFO_LEVEL *printer,
+                                  TALLOC_CTX *mem_ctx)
 {
 }
 
@@ -1228,40 +1643,104 @@ static void spoolss_notify_devmode(int snum, SPOOL_NOTIFY_INFO_DATA *data, print
  * jfm:xxxx just return no file could add an option to smb.conf
  * separator file = "separator.txt"
  ********************************************************************/
-static void spoolss_notify_sepfile(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
+static void spoolss_notify_sepfile(int snum, 
+                                  SPOOL_NOTIFY_INFO_DATA *data, 
+                                  print_queue_struct *queue,
+                                  NT_PRINTER_INFO_LEVEL *printer,
+                                  TALLOC_CTX *mem_ctx)
 {
-       data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
-                       printer->info_2->sepfile, sizeof(data->notify_data.data.string)-1,True)  - sizeof(uint16))/sizeof(uint16));
+       pstring temp;
+       uint32 len;
+
+       len = rpcstr_push(temp, printer->info_2->sepfile, sizeof(temp)-2, STR_TERMINATE);
+
+       data->notify_data.data.length = len / 2;
+       data->notify_data.data.string = (uint16 *)talloc(mem_ctx, len);
+       
+       if (!data->notify_data.data.string) {
+               data->notify_data.data.length = 0;
+               return;
+       }
+       
+       memcpy(data->notify_data.data.string, temp, len);
 }
 
 /*******************************************************************
  * fill a notify_info_data with the print processor
  * jfm:xxxx return always winprint to indicate we don't do anything to it
  ********************************************************************/
-static void spoolss_notify_print_processor(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
+static void spoolss_notify_print_processor(int snum, 
+                                          SPOOL_NOTIFY_INFO_DATA *data,
+                                          print_queue_struct *queue,
+                                          NT_PRINTER_INFO_LEVEL *printer,
+                                          TALLOC_CTX *mem_ctx)
 {
-       data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
-                       printer->info_2->printprocessor, sizeof(data->notify_data.data.string)-1, True)  - sizeof(uint16))/sizeof(uint16));
+       pstring temp;
+       uint32 len;
+
+       len = rpcstr_push(temp,  printer->info_2->printprocessor, sizeof(temp)-2, STR_TERMINATE);
+
+       data->notify_data.data.length = len / 2;
+       data->notify_data.data.string = (uint16 *)talloc(mem_ctx, len);
+       
+       if (!data->notify_data.data.string) {
+               data->notify_data.data.length = 0;
+               return;
+       }
+       
+       memcpy(data->notify_data.data.string, temp, len);
 }
 
 /*******************************************************************
  * fill a notify_info_data with the print processor options
  * jfm:xxxx send an empty string
  ********************************************************************/
-static void spoolss_notify_parameters(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
+static void spoolss_notify_parameters(int snum, 
+                                     SPOOL_NOTIFY_INFO_DATA *data,
+                                     print_queue_struct *queue,
+                                     NT_PRINTER_INFO_LEVEL *printer,
+                                     TALLOC_CTX *mem_ctx)
 {
-       data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
-                       printer->info_2->parameters, sizeof(data->notify_data.data.string)-1, True)  - sizeof(uint16))/sizeof(uint16));
+       pstring temp;
+       uint32 len;
+
+       len = rpcstr_push(temp,  printer->info_2->parameters, sizeof(temp)-2, STR_TERMINATE);
+
+       data->notify_data.data.length = len / 2;
+       data->notify_data.data.string = (uint16 *)talloc(mem_ctx, len);
+       
+       if (!data->notify_data.data.string) {
+               data->notify_data.data.length = 0;
+               return;
+       }
+       
+       memcpy(data->notify_data.data.string, temp, len);
 }
 
 /*******************************************************************
  * fill a notify_info_data with the data type
  * jfm:xxxx always send RAW as data type
  ********************************************************************/
-static void spoolss_notify_datatype(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
+static void spoolss_notify_datatype(int snum, 
+                                   SPOOL_NOTIFY_INFO_DATA *data,
+                                   print_queue_struct *queue,
+                                   NT_PRINTER_INFO_LEVEL *printer,
+                                   TALLOC_CTX *mem_ctx)
 {
-       data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
-                       printer->info_2->datatype, sizeof(data->notify_data.data.string)-1, True)  - sizeof(uint16))/sizeof(uint16));
+       pstring temp;
+       uint32 len;
+
+       len = rpcstr_push(temp, printer->info_2->datatype, sizeof(pstring)-2, STR_TERMINATE);
+
+       data->notify_data.data.length = len / 2;
+       data->notify_data.data.string = (uint16 *)talloc(mem_ctx, len);
+       
+       if (!data->notify_data.data.string) {
+               data->notify_data.data.length = 0;
+               return;
+       }
+       
+       memcpy(data->notify_data.data.string, temp, len);
 }
 
 /*******************************************************************
@@ -1269,123 +1748,209 @@ static void spoolss_notify_datatype(int snum, SPOOL_NOTIFY_INFO_DATA *data, prin
  * jfm:xxxx send an null pointer to say no security desc
  * have to implement security before !
  ********************************************************************/
-static void spoolss_notify_security_desc(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
+static void spoolss_notify_security_desc(int snum, 
+                                        SPOOL_NOTIFY_INFO_DATA *data,
+                                        print_queue_struct *queue,
+                                        NT_PRINTER_INFO_LEVEL *printer,
+                                        TALLOC_CTX *mem_ctx)
 {
        data->notify_data.data.length=0;
-       data->notify_data.data.string[0]=0x00;
+       data->notify_data.data.string = NULL;
 }
 
 /*******************************************************************
  * fill a notify_info_data with the attributes
  * jfm:xxxx a samba printer is always shared
  ********************************************************************/
-static void spoolss_notify_attributes(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
+static void spoolss_notify_attributes(int snum, 
+                                     SPOOL_NOTIFY_INFO_DATA *data,
+                                     print_queue_struct *queue,
+                                     NT_PRINTER_INFO_LEVEL *printer,
+                                     TALLOC_CTX *mem_ctx)
 {
        data->notify_data.value[0] = printer->info_2->attributes;
+       data->notify_data.value[1] = 0;
 }
 
 /*******************************************************************
  * fill a notify_info_data with the priority
  ********************************************************************/
-static void spoolss_notify_priority(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
+static void spoolss_notify_priority(int snum, 
+                                   SPOOL_NOTIFY_INFO_DATA *data,
+                                   print_queue_struct *queue,
+                                   NT_PRINTER_INFO_LEVEL *printer,
+                                   TALLOC_CTX *mem_ctx)
 {
        data->notify_data.value[0] = printer->info_2->priority;
+       data->notify_data.value[1] = 0;
 }
 
 /*******************************************************************
  * fill a notify_info_data with the default priority
  ********************************************************************/
-static void spoolss_notify_default_priority(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
+static void spoolss_notify_default_priority(int snum, 
+                                           SPOOL_NOTIFY_INFO_DATA *data,
+                                           print_queue_struct *queue,
+                                           NT_PRINTER_INFO_LEVEL *printer,
+                                           TALLOC_CTX *mem_ctx)
 {
        data->notify_data.value[0] = printer->info_2->default_priority;
+       data->notify_data.value[1] = 0;
 }
 
 /*******************************************************************
  * fill a notify_info_data with the start time
  ********************************************************************/
-static void spoolss_notify_start_time(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
+static void spoolss_notify_start_time(int snum, 
+                                     SPOOL_NOTIFY_INFO_DATA *data,
+                                     print_queue_struct *queue,
+                                     NT_PRINTER_INFO_LEVEL *printer,
+                                     TALLOC_CTX *mem_ctx)
 {
        data->notify_data.value[0] = printer->info_2->starttime;
+       data->notify_data.value[1] = 0;
 }
 
 /*******************************************************************
  * fill a notify_info_data with the until time
  ********************************************************************/
-static void spoolss_notify_until_time(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
+static void spoolss_notify_until_time(int snum, 
+                                     SPOOL_NOTIFY_INFO_DATA *data,
+                                     print_queue_struct *queue,
+                                     NT_PRINTER_INFO_LEVEL *printer,
+                                     TALLOC_CTX *mem_ctx)
 {
        data->notify_data.value[0] = printer->info_2->untiltime;
+       data->notify_data.value[1] = 0;
 }
 
 /*******************************************************************
  * fill a notify_info_data with the status
  ********************************************************************/
-static void spoolss_notify_status(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
+static void spoolss_notify_status(int snum, 
+                                 SPOOL_NOTIFY_INFO_DATA *data,
+                                 print_queue_struct *queue,
+                                 NT_PRINTER_INFO_LEVEL *printer,
+                                 TALLOC_CTX *mem_ctx)
 {
-       int count;
-       print_queue_struct *q=NULL;
        print_status_struct status;
 
-       memset(&status, 0, sizeof(status));
-       count = print_queue_status(snum, &q, &status);
+       print_queue_length(snum, &status);
        data->notify_data.value[0]=(uint32) status.status;
-       safe_free(q);
+       data->notify_data.value[1] = 0;
 }
 
 /*******************************************************************
  * fill a notify_info_data with the number of jobs queued
  ********************************************************************/
-static void spoolss_notify_cjobs(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
+static void spoolss_notify_cjobs(int snum, 
+                                SPOOL_NOTIFY_INFO_DATA *data,
+                                print_queue_struct *queue,
+                                NT_PRINTER_INFO_LEVEL *printer, 
+                                TALLOC_CTX *mem_ctx)
 {
-       print_queue_struct *q=NULL;
-       print_status_struct status;
-
-       memset(&status, 0, sizeof(status));
-       data->notify_data.value[0] = print_queue_status(snum, &q, &status);
-       safe_free(q);
+       data->notify_data.value[0] = print_queue_length(snum, NULL);
+       data->notify_data.value[1] = 0;
 }
 
 /*******************************************************************
  * fill a notify_info_data with the average ppm
  ********************************************************************/
-static void spoolss_notify_average_ppm(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
+static void spoolss_notify_average_ppm(int snum, 
+                                      SPOOL_NOTIFY_INFO_DATA *data,
+                                      print_queue_struct *queue,
+                                      NT_PRINTER_INFO_LEVEL *printer,
+                                      TALLOC_CTX *mem_ctx)
 {
        /* always respond 8 pages per minutes */
        /* a little hard ! */
        data->notify_data.value[0] = printer->info_2->averageppm;
+       data->notify_data.value[1] = 0;
 }
 
 /*******************************************************************
  * fill a notify_info_data with username
  ********************************************************************/
-static void spoolss_notify_username(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
+static void spoolss_notify_username(int snum, 
+                                   SPOOL_NOTIFY_INFO_DATA *data,
+                                   print_queue_struct *queue,
+                                   NT_PRINTER_INFO_LEVEL *printer,
+                                   TALLOC_CTX *mem_ctx)
 {
-       data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
-                       queue->user, sizeof(data->notify_data.data.string)-1, True)  - sizeof(uint16))/sizeof(uint16));
+       pstring temp;
+       uint32 len;
+
+       len = rpcstr_push(temp, queue->user, sizeof(temp)-2, STR_TERMINATE);
+
+
+       data->notify_data.data.length = len / 2;
+       data->notify_data.data.string = (uint16 *)talloc(mem_ctx, len);
+       
+       if (!data->notify_data.data.string) {
+               data->notify_data.data.length = 0;
+               return;
+       }
+       
+       memcpy(data->notify_data.data.string, temp, len);
 }
 
 /*******************************************************************
  * fill a notify_info_data with job status
  ********************************************************************/
-static void spoolss_notify_job_status(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
+static void spoolss_notify_job_status(int snum, 
+                                     SPOOL_NOTIFY_INFO_DATA *data,
+                                     print_queue_struct *queue,
+                                     NT_PRINTER_INFO_LEVEL *printer,
+                                     TALLOC_CTX *mem_ctx)
 {
        data->notify_data.value[0]=nt_printj_status(queue->status);
+       data->notify_data.value[1] = 0;
 }
 
 /*******************************************************************
  * fill a notify_info_data with job name
  ********************************************************************/
-static void spoolss_notify_job_name(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
+static void spoolss_notify_job_name(int snum, 
+                                   SPOOL_NOTIFY_INFO_DATA *data,
+                                   print_queue_struct *queue,
+                                   NT_PRINTER_INFO_LEVEL *printer,
+                                   TALLOC_CTX *mem_ctx)
 {
-       data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
-                       queue->file, sizeof(data->notify_data.data.string)-1, True)  - sizeof(uint16))/sizeof(uint16));
+       pstring temp;
+       uint32 len;
+
+       len = rpcstr_push(temp, queue->file, sizeof(temp)-2, STR_TERMINATE);
+       
+       data->notify_data.data.length = len / 2;
+       data->notify_data.data.string = (uint16 *)talloc(mem_ctx, len);
+       
+       if (!data->notify_data.data.string) {
+               data->notify_data.data.length = 0;
+               return;
+       }
+       
+       memcpy(data->notify_data.data.string, temp, len);
 }
 
 /*******************************************************************
  * fill a notify_info_data with job status
  ********************************************************************/
-static void spoolss_notify_job_status_string(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
+static void spoolss_notify_job_status_string(int snum, 
+                                            SPOOL_NOTIFY_INFO_DATA *data,
+                                            print_queue_struct *queue,
+                                            NT_PRINTER_INFO_LEVEL *printer, 
+                                            TALLOC_CTX *mem_ctx)
 {
-       char *p = "unknown";
+       /*
+        * Now we're returning job status codes we just return a "" here. JRA.
+        */
+
+       char *p = "";
+       pstring temp;
+       uint32 len;
+
+#if 0 /* NO LONGER NEEDED - JRA. 02/22/2001 */
+       p = "unknown";
 
        switch (queue->status) {
        case LPQ_QUEUED:
@@ -1401,45 +1966,104 @@ static void spoolss_notify_job_status_string(int snum, SPOOL_NOTIFY_INFO_DATA *d
                p = "Printing";
                break;
        }
-       data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
-                               p, sizeof(data->notify_data.data.string)-1, True)  - sizeof(uint16))/sizeof(uint16));
+#endif /* NO LONGER NEEDED. */
+
+       len = rpcstr_push(temp, p, sizeof(temp) - 2, STR_TERMINATE);
+
+       data->notify_data.data.length = len / 2;
+       data->notify_data.data.string = (uint16 *)talloc(mem_ctx, len);
+       
+       if (!data->notify_data.data.string) {
+               data->notify_data.data.length = 0;
+               return;
+       }
+       
+       memcpy(data->notify_data.data.string, temp, len);
 }
 
 /*******************************************************************
  * fill a notify_info_data with job time
  ********************************************************************/
-static void spoolss_notify_job_time(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
+static void spoolss_notify_job_time(int snum, 
+                                   SPOOL_NOTIFY_INFO_DATA *data,
+                                   print_queue_struct *queue,
+                                   NT_PRINTER_INFO_LEVEL *printer,
+                                   TALLOC_CTX *mem_ctx)
 {
        data->notify_data.value[0]=0x0;
+       data->notify_data.value[1]=0;
 }
 
 /*******************************************************************
  * fill a notify_info_data with job size
  ********************************************************************/
-static void spoolss_notify_job_size(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
+static void spoolss_notify_job_size(int snum, 
+                                   SPOOL_NOTIFY_INFO_DATA *data,
+                                   print_queue_struct *queue,
+                                   NT_PRINTER_INFO_LEVEL *printer,
+                                   TALLOC_CTX *mem_ctx)
 {
        data->notify_data.value[0]=queue->size;
+       data->notify_data.value[1]=0;
 }
 
 /*******************************************************************
- * fill a notify_info_data with job position
+ Fill a notify_info_data with job position.
  ********************************************************************/
-static void spoolss_notify_job_position(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
+
+static void spoolss_notify_job_position(int snum, 
+                                       SPOOL_NOTIFY_INFO_DATA *data,
+                                       print_queue_struct *queue,
+                                       NT_PRINTER_INFO_LEVEL *printer,
+                                       TALLOC_CTX *mem_ctx)
 {
        data->notify_data.value[0]=queue->job;
+       data->notify_data.value[1]=0;
 }
 
 /*******************************************************************
- * fill a notify_info_data with submitted time
+ Fill a notify_info_data with submitted time.
  ********************************************************************/
-static void spoolss_notify_submitted_time(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
+
+static void spoolss_notify_submitted_time(int snum, 
+                                         SPOOL_NOTIFY_INFO_DATA *data,
+                                         print_queue_struct *queue,
+                                         NT_PRINTER_INFO_LEVEL *printer,
+                                         TALLOC_CTX *mem_ctx)
 {
        struct tm *t;
+       uint32 len;
+       SYSTEMTIME st;
+       char *p;
 
        t=gmtime(&queue->time);
 
-       data->notify_data.data.length = sizeof(SYSTEMTIME);
-       make_systemtime((SYSTEMTIME*)(data->notify_data.data.string), t);
+       len = sizeof(SYSTEMTIME);
+
+       data->notify_data.data.length = len;
+       data->notify_data.data.string = (uint16 *)talloc(mem_ctx, len);
+
+       if (!data->notify_data.data.string) {
+               data->notify_data.data.length = 0;
+               return;
+       }
+       
+       make_systemtime(&st, t);
+
+       /*
+        * Systemtime must be linearized as a set of UINT16's. 
+        * Fix from Benjamin (Bj) Kuit bj@it.uts.edu.au
+        */
+
+       p = (char *)data->notify_data.data.string;
+       SSVAL(p, 0, st.year);
+       SSVAL(p, 2, st.month);
+       SSVAL(p, 4, st.dayofweek);
+       SSVAL(p, 6, st.day);
+       SSVAL(p, 8, st.hour);
+        SSVAL(p, 10, st.minute);
+       SSVAL(p, 12, st.second);
+       SSVAL(p, 14, st.milliseconds);
 }
 
 #define END 65535
@@ -1452,7 +2076,7 @@ struct s_notify_info_data_table
        uint32 size;
        void (*fn) (int snum, SPOOL_NOTIFY_INFO_DATA *data,
                    print_queue_struct *queue,
-                   NT_PRINTER_INFO_LEVEL *printer);
+                   NT_PRINTER_INFO_LEVEL *printer, TALLOC_CTX *mem_ctx);
 };
 
 struct s_notify_info_data_table notify_info_data_table[] =
@@ -1594,45 +2218,50 @@ static void construct_info_data(SPOOL_NOTIFY_INFO_DATA *info_data, uint16 type,
  * fill a notify_info struct with info asked
  *
  ********************************************************************/
-static BOOL construct_notify_printer_info(SPOOL_NOTIFY_INFO *info, int snum, SPOOL_NOTIFY_OPTION_TYPE *option_type, uint32 id)
+static BOOL construct_notify_printer_info(SPOOL_NOTIFY_INFO *info, int
+                                         snum, SPOOL_NOTIFY_OPTION_TYPE
+                                         *option_type, uint32 id,
+                                         TALLOC_CTX *mem_ctx) 
 {
        int field_num,j;
        uint16 type;
        uint16 field;
 
-       SPOOL_NOTIFY_INFO_DATA *current_data;
+       SPOOL_NOTIFY_INFO_DATA *current_data, *tid;
        NT_PRINTER_INFO_LEVEL *printer = NULL;
        print_queue_struct *queue=NULL;
-       
-       DEBUG(4,("construct_notify_printer_info\n"));
-       
+
        type=option_type->type;
 
-       DEBUGADD(4,("Notify type: [%s], number of notify info: [%d] on printer: [%s]\n",
+       DEBUG(4,("construct_notify_printer_info: Notify type: [%s], number of notify info: [%d] on printer: [%s]\n",
                (option_type->type==PRINTER_NOTIFY_TYPE?"PRINTER_NOTIFY_TYPE":"JOB_NOTIFY_TYPE"),
                option_type->count, lp_servicename(snum)));
        
-       if (get_a_printer(&printer, 2, lp_servicename(snum))!=0)
+       if (!W_ERROR_IS_OK(get_a_printer(&printer, 2, lp_servicename(snum))))
                return False;
 
        for(field_num=0; field_num<option_type->count; field_num++) {
                field = option_type->fields[field_num];
-               DEBUGADD(4,("notify [%d]: type [%x], field [%x]\n", field_num, type, field));
+               DEBUG(4,("construct_notify_printer_info: notify [%d]: type [%x], field [%x]\n", field_num, type, field));
 
                if (!search_notify(type, field, &j) )
                        continue;
-               
-               if((info->data=Realloc(info->data, (info->count+1)*sizeof(SPOOL_NOTIFY_INFO_DATA))) == NULL) {
+
+               if((tid=(SPOOL_NOTIFY_INFO_DATA *)Realloc(info->data, (info->count+1)*sizeof(SPOOL_NOTIFY_INFO_DATA))) == NULL) {
+                       DEBUG(0,("construct_notify_printer_info: failed to enlarge buffer info->data!\n"));
                        return False;
                }
+               else info->data = tid;
+
                current_data=&info->data[info->count];
 
                construct_info_data(current_data, type, field, id);             
 
-               DEBUG(10,("construct_notify_printer_info: calling %s\n",
-                               notify_info_data_table[j].name ));
+               DEBUG(10,("construct_notify_printer_info: calling [%s]  snum=%d  printername=[%s])\n",
+                               notify_info_data_table[j].name, snum, printer->info_2->printername ));
 
-               notify_info_data_table[j].fn(snum, current_data, queue, printer);
+               notify_info_data_table[j].fn(snum, current_data, queue,
+                                            printer, mem_ctx);
 
                info->count++;
        }
@@ -1646,14 +2275,18 @@ static BOOL construct_notify_printer_info(SPOOL_NOTIFY_INFO *info, int snum, SPO
  * fill a notify_info struct with info asked
  *
  ********************************************************************/
-static BOOL construct_notify_jobs_info(print_queue_struct *queue, SPOOL_NOTIFY_INFO *info, int snum, SPOOL_NOTIFY_OPTION_TYPE *option_type, uint32 id)
+static BOOL construct_notify_jobs_info(print_queue_struct *queue,
+                                      SPOOL_NOTIFY_INFO *info,
+                                      NT_PRINTER_INFO_LEVEL *printer,
+                                      int snum, SPOOL_NOTIFY_OPTION_TYPE
+                                      *option_type, uint32 id,
+                                      TALLOC_CTX *mem_ctx) 
 {
        int field_num,j;
        uint16 type;
        uint16 field;
 
-       SPOOL_NOTIFY_INFO_DATA *current_data;
-       NT_PRINTER_INFO_LEVEL *printer = NULL;
+       SPOOL_NOTIFY_INFO_DATA *current_data, *tid;
        
        DEBUG(4,("construct_notify_jobs_info\n"));
        
@@ -1663,27 +2296,26 @@ static BOOL construct_notify_jobs_info(print_queue_struct *queue, SPOOL_NOTIFY_I
                (option_type->type==PRINTER_NOTIFY_TYPE?"PRINTER_NOTIFY_TYPE":"JOB_NOTIFY_TYPE"),
                option_type->count));
 
-       if (get_a_printer(&printer, 2, lp_servicename(snum))!=0)
-               return False;
-       
        for(field_num=0; field_num<option_type->count; field_num++) {
                field = option_type->fields[field_num];
 
                if (!search_notify(type, field, &j) )
                        continue;
 
-               if((info->data=Realloc(info->data, (info->count+1)*sizeof(SPOOL_NOTIFY_INFO_DATA))) == NULL) {
+               if((tid=Realloc(info->data, (info->count+1)*sizeof(SPOOL_NOTIFY_INFO_DATA))) == NULL) {
+                       DEBUG(0,("construct_notify_jobs_info: failed to enlarg buffer info->data!\n"));
                        return False;
                }
+               else info->data = tid;
 
                current_data=&(info->data[info->count]);
 
                construct_info_data(current_data, type, field, id);
-               notify_info_data_table[j].fn(snum, current_data, queue, printer);
+               notify_info_data_table[j].fn(snum, current_data, queue,
+                                            printer, mem_ctx);
                info->count++;
        }
 
-       free_a_printer(&printer, 2);    
        return True;
 }
 
@@ -1710,18 +2342,19 @@ static BOOL construct_notify_jobs_info(print_queue_struct *queue, SPOOL_NOTIFY_I
  * that's the print server case, the printer case is even worse.
  */
 
-
-
 /*******************************************************************
  *
  * enumerate all printers on the printserver
  * fill a notify_info struct with info asked
  *
  ********************************************************************/
-static uint32 printserver_notify_info(const POLICY_HND *hnd, SPOOL_NOTIFY_INFO *info)
+
+static WERROR printserver_notify_info(pipes_struct *p, POLICY_HND *hnd, 
+                                     SPOOL_NOTIFY_INFO *info,
+                                     TALLOC_CTX *mem_ctx)
 {
        int snum;
-       Printer_entry *Printer=find_printer_index_by_hnd(hnd);
+       Printer_entry *Printer=find_printer_index_by_hnd(p, hnd);
        int n_services=lp_numservices();
        int i;
        uint32 id;
@@ -1744,7 +2377,8 @@ static uint32 printserver_notify_info(const POLICY_HND *hnd, SPOOL_NOTIFY_INFO *
                
                for (snum=0; snum<n_services; snum++)
                        if ( lp_browseable(snum) && lp_snum_ok(snum) && lp_print_ok(snum) )
-                               if (construct_notify_printer_info(info, snum, option_type, id))
+                               if (construct_notify_printer_info
+                                   (info, snum, option_type, id, mem_ctx))
                                        id++;
        }
                        
@@ -1763,7 +2397,7 @@ static uint32 printserver_notify_info(const POLICY_HND *hnd, SPOOL_NOTIFY_INFO *
        }
        */
        
-       return NT_STATUS_NO_PROBLEMO;
+       return WERR_OK;
 }
 
 /*******************************************************************
@@ -1771,10 +2405,11 @@ static uint32 printserver_notify_info(const POLICY_HND *hnd, SPOOL_NOTIFY_INFO *
  * fill a notify_info struct with info asked
  *
  ********************************************************************/
-static uint32 printer_notify_info(POLICY_HND *hnd, SPOOL_NOTIFY_INFO *info)
+static WERROR printer_notify_info(pipes_struct *p, POLICY_HND *hnd, SPOOL_NOTIFY_INFO *info,
+                                 TALLOC_CTX *mem_ctx)
 {
        int snum;
-       Printer_entry *Printer=find_printer_index_by_hnd(hnd);
+       Printer_entry *Printer=find_printer_index_by_hnd(p, hnd);
        int i;
        uint32 id;
        SPOOL_NOTIFY_OPTION *option;
@@ -1791,25 +2426,43 @@ static uint32 printer_notify_info(POLICY_HND *hnd, SPOOL_NOTIFY_INFO *info)
        info->data=NULL;
        info->count=0;
 
-       get_printer_snum(hnd, &snum);
+       get_printer_snum(p, hnd, &snum);
 
        for (i=0; i<option->count; i++) {
                option_type=&option->ctr.type[i];
                
                switch ( option_type->type ) {
                case PRINTER_NOTIFY_TYPE:
-                       if(construct_notify_printer_info(info, snum, option_type, id))
+                       if(construct_notify_printer_info(info, snum, 
+                                                        option_type, id,
+                                                        mem_ctx))  
                                id--;
                        break;
                        
-               case JOB_NOTIFY_TYPE:
-                       memset(&status, 0, sizeof(status));     
+               case JOB_NOTIFY_TYPE: {
+                       NT_PRINTER_INFO_LEVEL *printer = NULL;
+
                        count = print_queue_status(snum, &queue, &status);
-                       for (j=0; j<count; j++)
-                               construct_notify_jobs_info(&queue[j], info, snum, option_type, queue[j].job);
-                       safe_free(queue);
+
+                       if (!W_ERROR_IS_OK(get_a_printer(&printer, 2, 
+                                                        lp_servicename(snum))))
+                               goto done;
+
+                       for (j=0; j<count; j++) {
+                               construct_notify_jobs_info(&queue[j], info,
+                                                          printer, snum,
+                                                          option_type,
+                                                          queue[j].job,
+                                                          mem_ctx); 
+                       }
+
+                       free_a_printer(&printer, 2);
+                       
+               done:
+                       SAFE_FREE(queue);
                        break;
                }
+               }
        }
        
        /*
@@ -1826,20 +2479,30 @@ static uint32 printer_notify_info(POLICY_HND *hnd, SPOOL_NOTIFY_INFO *info)
                info->data[i].id, info->data[i].size, info->data[i].enc_type));
        }
        */
-       return NT_STATUS_NO_PROBLEMO;
+       return WERR_OK;
 }
 
 /********************************************************************
  * spoolss_rfnpcnex
  ********************************************************************/
-uint32 _spoolss_rfnpcnex( POLICY_HND *handle, uint32 change,
-                         SPOOL_NOTIFY_OPTION *option, SPOOL_NOTIFY_INFO *info)
+
+WERROR _spoolss_rfnpcnex( pipes_struct *p, SPOOL_Q_RFNPCNEX *q_u, SPOOL_R_RFNPCNEX *r_u)
 {
-       Printer_entry *Printer=find_printer_index_by_hnd(handle);
+       POLICY_HND *handle = &q_u->handle;
+/*     uint32 change = q_u->change; - notused. */
+/*     SPOOL_NOTIFY_OPTION *option = q_u->option; - notused. */
+       SPOOL_NOTIFY_INFO *info = &r_u->info;
+
+       Printer_entry *Printer=find_printer_index_by_hnd(p, handle);
+       WERROR result = WERR_BADFID;
 
-       if (!OPEN_HANDLE(Printer)) {
-               DEBUG(0,("_spoolss_rfnpcnex: Invalid handle (%s).\n",OUR_HANDLE(handle)));
-               return ERROR_INVALID_HANDLE;
+       /* we always have a NOTIFY_INFO struct */
+       r_u->info_ptr=0x1;
+
+       if (!Printer) {
+               DEBUG(0,("_spoolss_rfnpcnex: Invalid handle (%s).\n",
+                        OUR_HANDLE(handle)));
+               goto done;
        }
 
        DEBUG(4,("Printer type %x\n",Printer->printer_type));
@@ -1855,18 +2518,20 @@ uint32 _spoolss_rfnpcnex( POLICY_HND *handle, uint32 change,
         *      informations even when _NOTHING_ has changed.
         */
 
-       /* just discard the SPOOL_NOTIFY_OPTION */
-       if (option!=NULL)
-               safe_free(option->ctr.type);
+       /* just ignore the SPOOL_NOTIFY_OPTION */
        
        switch (Printer->printer_type) {
                case PRINTER_HANDLE_IS_PRINTSERVER:
-                       return printserver_notify_info(handle, info);
+                       result = printserver_notify_info(p, handle, info, p->mem_ctx);
+                       break;
+                       
                case PRINTER_HANDLE_IS_PRINTER:
-                       return printer_notify_info(handle, info);
+                       result = printer_notify_info(p, handle, info, p->mem_ctx);
+                       break;
        }
-
-       return ERROR_INVALID_HANDLE;
+       
+ done:
+       return result;
 }
 
 /********************************************************************
@@ -1882,16 +2547,12 @@ static BOOL construct_printer_info_0(PRINTER_INFO_0 *printer, int snum)
        uint32 global_counter;
        struct tm *t;
        time_t setuptime;
-
-       print_queue_struct *queue=NULL;
        print_status_struct status;
        
-       memset(&status, 0, sizeof(status));     
-
-       if (get_a_printer(&ntprinter, 2, lp_servicename(snum)) != 0)
+       if (!W_ERROR_IS_OK(get_a_printer(&ntprinter, 2, lp_servicename(snum))))
                return False;
 
-       count = print_queue_status(snum, &queue, &status);
+       count = print_queue_length(snum, &status);
 
        /* check if we already have a counter for this printer */       
        session_counter = (counter_printer_0 *)ubi_dlFirst(&counter_list);
@@ -1926,7 +2587,7 @@ static BOOL construct_printer_info_0(PRINTER_INFO_0 *printer, int snum)
 
        init_unistr(&printer->printername, chaine);
        
-       slprintf(chaine,sizeof(chaine)-1,"\\\\%s", global_myname);
+       slprintf(chaine,sizeof(chaine)-1,"\\\\%s", get_called_name());
        init_unistr(&printer->servername, chaine);
        
        printer->cjobs = count;
@@ -1958,11 +2619,11 @@ static BOOL construct_printer_info_0(PRINTER_INFO_0 *printer, int snum)
        printer->unknown13 = 0x0;
        printer->unknown14 = 0x1;
        printer->unknown15 = 0x024a;            /* 586 Pentium ? */
-       printer->unknown16 = 0x0;
+       printer->unknown16 =  0x0;
        printer->change_id = ntprinter->info_2->changeid; /* ChangeID in milliseconds*/
-       printer->unknown18 = 0x0;
+       printer->unknown18 =  0x0;
        printer->status = nt_printq_status(status.status);
-       printer->unknown20 = 0x0;
+       printer->unknown20 =  0x0;
        printer->c_setprinter = ntprinter->info_2->c_setprinter; /* how many times setprinter has been called */
        printer->unknown22 = 0x0;
        printer->unknown23 = 0x6;               /* 6  ???*/
@@ -1973,7 +2634,6 @@ static BOOL construct_printer_info_0(PRINTER_INFO_0 *printer, int snum)
        printer->unknown28 = 0;
        printer->unknown29 = 0;
        
-       safe_free(queue);
        free_a_printer(&ntprinter,2);
        return (True);  
 }
@@ -1988,23 +2648,23 @@ static BOOL construct_printer_info_1(uint32 flags, PRINTER_INFO_1 *printer, int
        pstring chaine2;
        NT_PRINTER_INFO_LEVEL *ntprinter = NULL;
 
-       if (get_a_printer(&ntprinter, 2, lp_servicename(snum)) != 0)
+       if (!W_ERROR_IS_OK(get_a_printer(&ntprinter, 2, lp_servicename(snum))))
                return False;
 
        printer->flags=flags;
 
        if (*ntprinter->info_2->comment == '\0') {
                init_unistr(&printer->comment, lp_comment(snum));
-               snprintf(chaine,sizeof(chaine)-1,"%s%s,%s,%s",global_myname, ntprinter->info_2->printername,
+               slprintf(chaine,sizeof(chaine)-1,"%s%s,%s,%s",get_called_name(), ntprinter->info_2->printername,
                        ntprinter->info_2->drivername, lp_comment(snum));
        }
        else {
                init_unistr(&printer->comment, ntprinter->info_2->comment); /* saved comment. */
-               snprintf(chaine,sizeof(chaine)-1,"%s%s,%s,%s",global_myname, ntprinter->info_2->printername,
+               slprintf(chaine,sizeof(chaine)-1,"%s%s,%s,%s",get_called_name(), ntprinter->info_2->printername,
                        ntprinter->info_2->drivername, ntprinter->info_2->comment);
        }
                
-       snprintf(chaine2,sizeof(chaine)-1,"%s", ntprinter->info_2->printername);
+       slprintf(chaine2,sizeof(chaine)-1,"%s", ntprinter->info_2->printername);
 
        init_unistr(&printer->description, chaine);
        init_unistr(&printer->name, chaine2);   
@@ -2023,10 +2683,8 @@ static void free_dev_mode(DEVICEMODE *dev)
        if (dev == NULL)
                return;
 
-       if (dev->private)
-               safe_free(dev->private);
-
-       safe_free(dev); 
+       SAFE_FREE(dev->private);
+       SAFE_FREE(dev); 
 }
 
 /****************************************************************************
@@ -2052,7 +2710,7 @@ static DEVICEMODE *construct_dev_mode(int snum)
 
        ZERO_STRUCTP(devmode);  
 
-       if(get_a_printer(&printer, 2, lp_servicename(snum)) != 0)
+       if (!W_ERROR_IS_OK(get_a_printer(&printer, 2, lp_servicename(snum))))
                goto fail;
 
        if (printer->info_2->devmode)
@@ -2063,10 +2721,10 @@ static DEVICEMODE *construct_dev_mode(int snum)
 
        DEBUGADD(8,("loading DEVICEMODE\n"));
 
-       snprintf(adevice, sizeof(adevice), printer->info_2->printername);
+       slprintf(adevice, sizeof(adevice)-1, printer->info_2->printername);
        init_unistr(&devmode->devicename, adevice);
 
-       snprintf(aform, sizeof(aform), ntdevmode->formname);
+       slprintf(aform, sizeof(aform)-1, ntdevmode->formname);
        init_unistr(&devmode->formname, aform);
 
        devmode->specversion      = ntdevmode->specversion;
@@ -2124,15 +2782,12 @@ static BOOL construct_printer_info_2(PRINTER_INFO_2 *printer, int snum)
        int count;
        NT_PRINTER_INFO_LEVEL *ntprinter = NULL;
 
-       print_queue_struct *queue=NULL;
        print_status_struct status;
-       memset(&status, 0, sizeof(status));     
 
-       if (get_a_printer(&ntprinter, 2, lp_servicename(snum)) !=0 )
+       if (!W_ERROR_IS_OK(get_a_printer(&ntprinter, 2, lp_servicename(snum))))
                return False;
                
-       memset(&status, 0, sizeof(status));             
-       count = print_queue_status(snum, &queue, &status);
+       count = print_queue_length(snum, &status);
 
        init_unistr(&printer->servername, ntprinter->info_2->servername); /* servername*/
        init_unistr(&printer->printername, ntprinter->info_2->printername);                             /* printername*/
@@ -2177,7 +2832,6 @@ static BOOL construct_printer_info_2(PRINTER_INFO_2 *printer, int snum)
        }
 
        free_a_printer(&ntprinter, 2);
-       safe_free(queue);
        return True;
 }
 
@@ -2190,7 +2844,7 @@ static BOOL construct_printer_info_3(PRINTER_INFO_3 **pp_printer, int snum)
        NT_PRINTER_INFO_LEVEL *ntprinter = NULL;
        PRINTER_INFO_3 *printer = NULL;
 
-       if (get_a_printer(&ntprinter, 2, lp_servicename(snum)) !=0 )
+       if (!W_ERROR_IS_OK(get_a_printer(&ntprinter, 2, lp_servicename(snum))))
                return False;
 
        *pp_printer = NULL;
@@ -2235,15 +2889,58 @@ static BOOL construct_printer_info_3(PRINTER_INFO_3 **pp_printer, int snum)
        return True;
 }
 
+/********************************************************************
+ * construct_printer_info_4
+ * fill a printer_info_4 struct
+ ********************************************************************/
+
+static BOOL construct_printer_info_4(PRINTER_INFO_4 *printer, int snum)
+{
+       NT_PRINTER_INFO_LEVEL *ntprinter = NULL;
+
+       if (!W_ERROR_IS_OK(get_a_printer(&ntprinter, 2, lp_servicename(snum))))
+               return False;
+               
+       init_unistr(&printer->printername, ntprinter->info_2->printername);                             /* printername*/
+       init_unistr(&printer->servername, ntprinter->info_2->servername); /* servername*/
+       printer->attributes = ntprinter->info_2->attributes;
+
+       free_a_printer(&ntprinter, 2);
+       return True;
+}
+
+/********************************************************************
+ * construct_printer_info_5
+ * fill a printer_info_5 struct
+ ********************************************************************/
+
+static BOOL construct_printer_info_5(PRINTER_INFO_5 *printer, int snum)
+{
+       NT_PRINTER_INFO_LEVEL *ntprinter = NULL;
+
+       if (!W_ERROR_IS_OK(get_a_printer(&ntprinter, 2, lp_servicename(snum))))
+               return False;
+               
+       init_unistr(&printer->printername, ntprinter->info_2->printername);                             /* printername*/
+       init_unistr(&printer->portname, ntprinter->info_2->portname); /* portname */
+       printer->attributes = ntprinter->info_2->attributes;
+       printer->device_not_selected_timeout = 0x3a98;
+       printer->transmission_retry_timeout = 0xafc8;
+
+       free_a_printer(&ntprinter, 2);
+       return True;
+}
+
+
 /********************************************************************
  Spoolss_enumprinters.
 ********************************************************************/
-static BOOL enum_all_printers_info_1(uint32 flags, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
+static WERROR enum_all_printers_info_1(uint32 flags, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
        int snum;
        int i;
        int n_services=lp_numservices();
-       PRINTER_INFO_1 *printers=NULL;
+       PRINTER_INFO_1 *tp, *printers=NULL;
        PRINTER_INFO_1 current_prt;
        
        DEBUG(4,("enum_all_printers_info_1\n"));        
@@ -2253,12 +2950,15 @@ static BOOL enum_all_printers_info_1(uint32 flags, NEW_BUFFER *buffer, uint32 of
                        DEBUG(4,("Found a printer in smb.conf: %s[%x]\n", lp_servicename(snum), snum));
                                
                        if (construct_printer_info_1(flags, &current_prt, snum)) {
-                               if((printers=Realloc(printers, (*returned +1)*sizeof(PRINTER_INFO_1))) == NULL) {
+                               if((tp=Realloc(printers, (*returned +1)*sizeof(PRINTER_INFO_1))) == NULL) {
+                                       DEBUG(0,("enum_all_printers_info_1: failed to enlarge printers buffer!\n"));
+                                       SAFE_FREE(printers);
                                        *returned=0;
-                                       return ERROR_NOT_ENOUGH_MEMORY;
+                                       return WERR_NOMEM;
                                }
+                               else printers = tp;
                                DEBUG(4,("ReAlloced memory for [%d] PRINTER_INFO_1\n", *returned));             
-                               memcpy(&(printers[*returned]), &current_prt, sizeof(PRINTER_INFO_1));
+                               memcpy(&printers[*returned], &current_prt, sizeof(PRINTER_INFO_1));
                                (*returned)++;
                        }
                }
@@ -2266,30 +2966,30 @@ static BOOL enum_all_printers_info_1(uint32 flags, NEW_BUFFER *buffer, uint32 of
                
        /* check the required size. */  
        for (i=0; i<*returned; i++)
-               (*needed) += spoolss_size_printer_info_1(&(printers[i]));
+               (*needed) += spoolss_size_printer_info_1(&printers[i]);
 
        if (!alloc_buffer_size(buffer, *needed))
-               return ERROR_INSUFFICIENT_BUFFER;
+               return WERR_INSUFFICIENT_BUFFER;
 
        /* fill the buffer with the structures */
        for (i=0; i<*returned; i++)
-               new_smb_io_printer_info_1("", buffer, &(printers[i]), 0);       
+               smb_io_printer_info_1("", buffer, &printers[i], 0);     
 
        /* clear memory */
-       safe_free(printers);
+       SAFE_FREE(printers);
 
        if (*needed > offered) {
                *returned=0;
-               return ERROR_INSUFFICIENT_BUFFER;
+               return WERR_INSUFFICIENT_BUFFER;
        }
        else
-               return NT_STATUS_NO_PROBLEMO;
+               return WERR_OK;
 }
 
 /********************************************************************
  enum_all_printers_info_1_local.
 *********************************************************************/
-static BOOL enum_all_printers_info_1_local(NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
+static WERROR enum_all_printers_info_1_local(NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
        DEBUG(4,("enum_all_printers_info_1_local\n"));  
        
@@ -2299,25 +2999,26 @@ static BOOL enum_all_printers_info_1_local(NEW_BUFFER *buffer, uint32 offered, u
 /********************************************************************
  enum_all_printers_info_1_name.
 *********************************************************************/
-static BOOL enum_all_printers_info_1_name(fstring name, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
+static WERROR enum_all_printers_info_1_name(fstring name, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
-       fstring temp;
+       char *s = name;
+       
        DEBUG(4,("enum_all_printers_info_1_name\n"));   
        
-       fstrcpy(temp, "\\\\");
-       fstrcat(temp, global_myname);
+       if ((name[0] == '\\') && (name[1] == '\\'))
+               s = name + 2;
 
-       if (strequal(name, temp)) {
+       if (is_myname_or_ipaddr(s)) {
                return enum_all_printers_info_1(PRINTER_ENUM_ICON8, buffer, offered, needed, returned);
        }
        else
-               return ERROR_INVALID_NAME;
+               return WERR_INVALID_NAME;
 }
 
 /********************************************************************
  enum_all_printers_info_1_remote.
 *********************************************************************/
-static BOOL enum_all_printers_info_1_remote(fstring name, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
+static WERROR enum_all_printers_info_1_remote(fstring name, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
        PRINTER_INFO_1 *printer;
        fstring printername;
@@ -2333,13 +3034,13 @@ static BOOL enum_all_printers_info_1_remote(fstring name, NEW_BUFFER *buffer, ui
         */
        
        if((printer=(PRINTER_INFO_1 *)malloc(sizeof(PRINTER_INFO_1))) == NULL)
-               return ERROR_NOT_ENOUGH_MEMORY;
+               return WERR_NOMEM;
 
        *returned=1;
        
-       snprintf(printername, sizeof(printername)-1,"Windows NT Remote Printers!!\\\\%s", global_myname);               
-       snprintf(desc, sizeof(desc)-1,"%s", global_myname);
-       snprintf(comment, sizeof(comment)-1, "Logged on Domain");
+       slprintf(printername, sizeof(printername)-1,"Windows NT Remote Printers!!\\\\%s", get_called_name());           
+       slprintf(desc, sizeof(desc)-1,"%s", get_called_name());
+       slprintf(comment, sizeof(comment)-1, "Logged on Domain");
 
        init_unistr(&printer->description, desc);
        init_unistr(&printer->name, printername);       
@@ -2350,28 +3051,29 @@ static BOOL enum_all_printers_info_1_remote(fstring name, NEW_BUFFER *buffer, ui
        *needed += spoolss_size_printer_info_1(printer);
 
        if (!alloc_buffer_size(buffer, *needed)) {
-               safe_free(printer);
-               return ERROR_INSUFFICIENT_BUFFER;
+               SAFE_FREE(printer);
+               return WERR_INSUFFICIENT_BUFFER;
        }
 
        /* fill the buffer with the structures */
-       new_smb_io_printer_info_1("", buffer, printer, 0);      
+       smb_io_printer_info_1("", buffer, printer, 0);  
 
        /* clear memory */
-       safe_free(printer);
+       SAFE_FREE(printer);
 
        if (*needed > offered) {
                *returned=0;
-               return ERROR_INSUFFICIENT_BUFFER;
+               return WERR_INSUFFICIENT_BUFFER;
        }
        else
-               return NT_STATUS_NO_PROBLEMO;
+               return WERR_OK;
 }
 
 /********************************************************************
  enum_all_printers_info_1_network.
 *********************************************************************/
-static BOOL enum_all_printers_info_1_network(NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
+
+static WERROR enum_all_printers_info_1_network(NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
        DEBUG(4,("enum_all_printers_info_1_network\n"));        
        
@@ -2383,12 +3085,13 @@ static BOOL enum_all_printers_info_1_network(NEW_BUFFER *buffer, uint32 offered,
  *
  * called from api_spoolss_enumprinters (see this to understand)
  ********************************************************************/
-static BOOL enum_all_printers_info_2(NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
+
+static WERROR enum_all_printers_info_2(NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
        int snum;
        int i;
        int n_services=lp_numservices();
-       PRINTER_INFO_2 *printers=NULL;
+       PRINTER_INFO_2 *tp, *printers=NULL;
        PRINTER_INFO_2 current_prt;
 
        for (snum=0; snum<n_services; snum++) {
@@ -2396,8 +3099,13 @@ static BOOL enum_all_printers_info_2(NEW_BUFFER *buffer, uint32 offered, uint32
                        DEBUG(4,("Found a printer in smb.conf: %s[%x]\n", lp_servicename(snum), snum));
                                
                        if (construct_printer_info_2(&current_prt, snum)) {
-                               if((printers=Realloc(printers, (*returned +1)*sizeof(PRINTER_INFO_2))) == NULL)
-                                       return ERROR_NOT_ENOUGH_MEMORY;
+                               if((tp=Realloc(printers, (*returned +1)*sizeof(PRINTER_INFO_2))) == NULL) {
+                                       DEBUG(0,("enum_all_printers_info_2: failed to enlarge printers buffer!\n"));
+                                       SAFE_FREE(printers);
+                                       *returned = 0;
+                                       return WERR_NOMEM;
+                               }
+                               else printers = tp;
                                DEBUG(4,("ReAlloced memory for [%d] PRINTER_INFO_2\n", *returned));             
                                memcpy(&printers[*returned], &current_prt, sizeof(PRINTER_INFO_2));
                                (*returned)++;
@@ -2412,35 +3120,33 @@ static BOOL enum_all_printers_info_2(NEW_BUFFER *buffer, uint32 offered, uint32
        if (!alloc_buffer_size(buffer, *needed)) {
                for (i=0; i<*returned; i++) {
                        free_devmode(printers[i].devmode);
-                       free_sec_desc(&printers[i].secdesc);
                }
-               safe_free(printers);
-               return ERROR_INSUFFICIENT_BUFFER;
+               SAFE_FREE(printers);
+               return WERR_INSUFFICIENT_BUFFER;
        }
 
        /* fill the buffer with the structures */
        for (i=0; i<*returned; i++)
-               new_smb_io_printer_info_2("", buffer, &(printers[i]), 0);       
+               smb_io_printer_info_2("", buffer, &(printers[i]), 0);   
        
        /* clear memory */
        for (i=0; i<*returned; i++) {
                free_devmode(printers[i].devmode);
-               free_sec_desc(&printers[i].secdesc);
        }
-       safe_free(printers);
+       SAFE_FREE(printers);
 
        if (*needed > offered) {
                *returned=0;
-               return ERROR_INSUFFICIENT_BUFFER;
+               return WERR_INSUFFICIENT_BUFFER;
        }
        else
-               return NT_STATUS_NO_PROBLEMO;
+               return WERR_OK;
 }
 
 /********************************************************************
  * handle enumeration of printers at level 1
  ********************************************************************/
-static uint32 enumprinters_level1( uint32 flags, fstring name,
+static WERROR enumprinters_level1( uint32 flags, fstring name,
                                 NEW_BUFFER *buffer, uint32 offered,
                                 uint32 *needed, uint32 *returned)
 {
@@ -2458,50 +3164,46 @@ static uint32 enumprinters_level1( uint32 flags, fstring name,
        if (flags & PRINTER_ENUM_NETWORK)
                return enum_all_printers_info_1_network(buffer, offered, needed, returned);
 
-       return NT_STATUS_NO_PROBLEMO; /* NT4sp5 does that */
+       return WERR_OK; /* NT4sp5 does that */
 }
 
 /********************************************************************
  * handle enumeration of printers at level 2
  ********************************************************************/
-static uint32 enumprinters_level2( uint32 flags, fstring servername,
+static WERROR enumprinters_level2( uint32 flags, fstring servername,
                                 NEW_BUFFER *buffer, uint32 offered,
                                 uint32 *needed, uint32 *returned)
 {
-       fstring temp;
-       
-       fstrcpy(temp, "\\\\");
-       fstrcat(temp, global_myname);
+       char *s = servername;
 
        if (flags & PRINTER_ENUM_LOCAL) {
-               if (strequal(servername, temp))
-                       return enum_all_printers_info_2(buffer, offered, needed, returned);
-               else
                        return enum_all_printers_info_2(buffer, offered, needed, returned);
        }
 
        if (flags & PRINTER_ENUM_NAME) {
-               if (strequal(servername, temp))
+               if ((servername[0] == '\\') && (servername[1] == '\\'))
+                       s = servername + 2;
+               if (is_myname_or_ipaddr(s))
                        return enum_all_printers_info_2(buffer, offered, needed, returned);
                else
-                       return ERROR_INVALID_NAME;
+                       return WERR_INVALID_NAME;
        }
 
        if (flags & PRINTER_ENUM_REMOTE)
-               return ERROR_INVALID_LEVEL;
+               return WERR_UNKNOWN_LEVEL;
 
-       return NT_STATUS_NO_PROBLEMO;
+       return WERR_OK;
 }
 
 /********************************************************************
  * handle enumeration of printers at level 5
  ********************************************************************/
-static uint32 enumprinters_level5( uint32 flags, fstring servername,
+static WERROR enumprinters_level5( uint32 flags, fstring servername,
                                 NEW_BUFFER *buffer, uint32 offered,
                                 uint32 *needed, uint32 *returned)
 {
 /*     return enum_all_printers_info_5(buffer, offered, needed, returned);*/
-       return NT_STATUS_NO_PROBLEMO;
+       return WERR_OK;
 }
 
 /********************************************************************
@@ -2509,12 +3211,23 @@ static uint32 enumprinters_level5( uint32 flags, fstring servername,
  *
  * called from api_spoolss_enumprinters (see this to understand)
  ********************************************************************/
-uint32 _spoolss_enumprinters( uint32 flags, const UNISTR2 *servername, uint32 level,
-                             NEW_BUFFER *buffer, uint32 offered,
-                             uint32 *needed, uint32 *returned)
+
+WERROR _spoolss_enumprinters( pipes_struct *p, SPOOL_Q_ENUMPRINTERS *q_u, SPOOL_R_ENUMPRINTERS *r_u)
 {
+       uint32 flags = q_u->flags;
+       UNISTR2 *servername = &q_u->servername;
+       uint32 level = q_u->level;
+       NEW_BUFFER *buffer = NULL;
+       uint32 offered = q_u->offered;
+       uint32 *needed = &r_u->needed;
+       uint32 *returned = &r_u->returned;
+
        fstring name;
        
+       /* that's an [in out] buffer */
+       spoolss_move_buffer(q_u->buffer, &r_u->buffer);
+       buffer = r_u->buffer;
+
        DEBUG(4,("_spoolss_enumprinters\n"));
 
        *needed=0;
@@ -2545,19 +3258,19 @@ uint32 _spoolss_enumprinters( uint32 flags, const UNISTR2 *servername, uint32 le
                return enumprinters_level5(flags, name, buffer, offered, needed, returned);
        case 3:
        case 4:
-       default:
-               return ERROR_INVALID_LEVEL;
+               break;
        }
+       return WERR_UNKNOWN_LEVEL;
 }
 
 /****************************************************************************
 ****************************************************************************/
-static uint32 getprinter_level_0(int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
+static WERROR getprinter_level_0(int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
 {
        PRINTER_INFO_0 *printer=NULL;
 
        if((printer=(PRINTER_INFO_0*)malloc(sizeof(PRINTER_INFO_0))) == NULL)
-               return ERROR_NOT_ENOUGH_MEMORY;
+               return WERR_NOMEM;
 
        construct_printer_info_0(printer, snum);
        
@@ -2565,31 +3278,31 @@ static uint32 getprinter_level_0(int snum, NEW_BUFFER *buffer, uint32 offered, u
        *needed += spoolss_size_printer_info_0(printer);
 
        if (!alloc_buffer_size(buffer, *needed)) {
-               safe_free(printer);
-               return ERROR_INSUFFICIENT_BUFFER;
+               SAFE_FREE(printer);
+               return WERR_INSUFFICIENT_BUFFER;
        }
 
        /* fill the buffer with the structures */
-       new_smb_io_printer_info_0("", buffer, printer, 0);      
+       smb_io_printer_info_0("", buffer, printer, 0);  
        
        /* clear memory */
-       safe_free(printer);
+       SAFE_FREE(printer);
 
        if (*needed > offered) {
-               return ERROR_INSUFFICIENT_BUFFER;
+               return WERR_INSUFFICIENT_BUFFER;
        }
-       else
-               return NT_STATUS_NO_PROBLEMO;   
+
+       return WERR_OK;
 }
 
 /****************************************************************************
 ****************************************************************************/
-static uint32 getprinter_level_1(int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
+static WERROR getprinter_level_1(int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
 {
        PRINTER_INFO_1 *printer=NULL;
 
        if((printer=(PRINTER_INFO_1*)malloc(sizeof(PRINTER_INFO_1))) == NULL)
-               return ERROR_NOT_ENOUGH_MEMORY;
+               return WERR_NOMEM;
 
        construct_printer_info_1(PRINTER_ENUM_ICON8, printer, snum);
        
@@ -2597,31 +3310,31 @@ static uint32 getprinter_level_1(int snum, NEW_BUFFER *buffer, uint32 offered, u
        *needed += spoolss_size_printer_info_1(printer);
 
        if (!alloc_buffer_size(buffer, *needed)) {
-               safe_free(printer);
-               return ERROR_INSUFFICIENT_BUFFER;
+               SAFE_FREE(printer);
+               return WERR_INSUFFICIENT_BUFFER;
        }
 
        /* fill the buffer with the structures */
-       new_smb_io_printer_info_1("", buffer, printer, 0);      
+       smb_io_printer_info_1("", buffer, printer, 0);  
        
        /* clear memory */
-       safe_free(printer);
+       SAFE_FREE(printer);
 
        if (*needed > offered) {
-               return ERROR_INSUFFICIENT_BUFFER;
+               return WERR_INSUFFICIENT_BUFFER;
        }
-       else
-               return NT_STATUS_NO_PROBLEMO;   
+
+       return WERR_OK; 
 }
 
 /****************************************************************************
 ****************************************************************************/
-static uint32 getprinter_level_2(int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
+static WERROR getprinter_level_2(int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
 {
        PRINTER_INFO_2 *printer=NULL;
 
        if((printer=(PRINTER_INFO_2*)malloc(sizeof(PRINTER_INFO_2)))==NULL)
-               return ERROR_NOT_ENOUGH_MEMORY;
+               return WERR_NOMEM;
        
        construct_printer_info_2(printer, snum);
        
@@ -2630,110 +3343,189 @@ static uint32 getprinter_level_2(int snum, NEW_BUFFER *buffer, uint32 offered, u
 
        if (!alloc_buffer_size(buffer, *needed)) {
                free_printer_info_2(printer);
-               return ERROR_INSUFFICIENT_BUFFER;
+               return WERR_INSUFFICIENT_BUFFER;
        }
 
        /* fill the buffer with the structures */
-       if (!new_smb_io_printer_info_2("", buffer, printer, 0)) {
+       if (!smb_io_printer_info_2("", buffer, printer, 0)) {
                free_printer_info_2(printer);
-               return ERROR_NOT_ENOUGH_MEMORY;
+               return WERR_NOMEM;
        }
        
        /* clear memory */
        free_printer_info_2(printer);
 
        if (*needed > offered) {
-               return ERROR_INSUFFICIENT_BUFFER;
+               return WERR_INSUFFICIENT_BUFFER;
        }
-       else
-               return NT_STATUS_NO_PROBLEMO;   
+
+       return WERR_OK; 
 }
 
 /****************************************************************************
 ****************************************************************************/
-static uint32 getprinter_level_3(int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
+static WERROR getprinter_level_3(int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
 {
        PRINTER_INFO_3 *printer=NULL;
 
        if (!construct_printer_info_3(&printer, snum))
-               return ERROR_NOT_ENOUGH_MEMORY;
+               return WERR_NOMEM;
        
        /* check the required size. */  
        *needed += spoolss_size_printer_info_3(printer);
 
        if (!alloc_buffer_size(buffer, *needed)) {
                free_printer_info_3(printer);
-               return ERROR_INSUFFICIENT_BUFFER;
+               return WERR_INSUFFICIENT_BUFFER;
        }
 
        /* fill the buffer with the structures */
-       new_smb_io_printer_info_3("", buffer, printer, 0);      
+       smb_io_printer_info_3("", buffer, printer, 0);  
        
        /* clear memory */
        free_printer_info_3(printer);
        
        if (*needed > offered) {
-               return ERROR_INSUFFICIENT_BUFFER;
+               return WERR_INSUFFICIENT_BUFFER;
        }
-       else
-               return NT_STATUS_NO_PROBLEMO;   
+
+       return WERR_OK; 
 }
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_getprinter(POLICY_HND *handle, uint32 level,
-                          NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
+static WERROR getprinter_level_4(int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
 {
-       int snum;
-       
-       *needed=0;
+       PRINTER_INFO_4 *printer=NULL;
 
-       if (!get_printer_snum(handle, &snum))
-               return ERROR_INVALID_HANDLE;
+       if((printer=(PRINTER_INFO_4*)malloc(sizeof(PRINTER_INFO_4)))==NULL)
+               return WERR_NOMEM;
 
-       switch (level) {
-       case 0:
-               return getprinter_level_0(snum, buffer, offered, needed);
-       case 1:
-               return getprinter_level_1(snum, buffer, offered, needed);
-       case 2:         
-               return getprinter_level_2(snum, buffer, offered, needed);
-       case 3:         
-               return getprinter_level_3(snum, buffer, offered, needed);
-       default:
-               return ERROR_INVALID_LEVEL;
+       if (!construct_printer_info_4(printer, snum))
+               return WERR_NOMEM;
+       
+       /* check the required size. */  
+       *needed += spoolss_size_printer_info_4(printer);
+
+       if (!alloc_buffer_size(buffer, *needed)) {
+               free_printer_info_4(printer);
+               return WERR_INSUFFICIENT_BUFFER;
        }
-}      
-               
-/********************************************************************
- * fill a DRIVER_INFO_1 struct
- ********************************************************************/
-static void fill_printer_driver_info_1(DRIVER_INFO_1 *info, NT_PRINTER_DRIVER_INFO_LEVEL driver, fstring servername, fstring architecture)
-{
-       init_unistr( &info->name, driver.info_3->name);
-}
 
-/********************************************************************
+       /* fill the buffer with the structures */
+       smb_io_printer_info_4("", buffer, printer, 0);  
+       
+       /* clear memory */
+       free_printer_info_4(printer);
+       
+       if (*needed > offered) {
+               return WERR_INSUFFICIENT_BUFFER;
+       }
+
+       return WERR_OK; 
+}
+
+/****************************************************************************
+****************************************************************************/
+static WERROR getprinter_level_5(int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
+{
+       PRINTER_INFO_5 *printer=NULL;
+
+       if((printer=(PRINTER_INFO_5*)malloc(sizeof(PRINTER_INFO_5)))==NULL)
+               return WERR_NOMEM;
+
+       if (!construct_printer_info_5(printer, snum))
+               return WERR_NOMEM;
+       
+       /* check the required size. */  
+       *needed += spoolss_size_printer_info_5(printer);
+
+       if (!alloc_buffer_size(buffer, *needed)) {
+               free_printer_info_5(printer);
+               return WERR_INSUFFICIENT_BUFFER;
+       }
+
+       /* fill the buffer with the structures */
+       smb_io_printer_info_5("", buffer, printer, 0);  
+       
+       /* clear memory */
+       free_printer_info_5(printer);
+       
+       if (*needed > offered) {
+               return WERR_INSUFFICIENT_BUFFER;
+       }
+
+       return WERR_OK; 
+}
+
+/****************************************************************************
+****************************************************************************/
+
+WERROR _spoolss_getprinter(pipes_struct *p, SPOOL_Q_GETPRINTER *q_u, SPOOL_R_GETPRINTER *r_u)
+{
+       POLICY_HND *handle = &q_u->handle;
+       uint32 level = q_u->level;
+       NEW_BUFFER *buffer = NULL;
+       uint32 offered = q_u->offered;
+       uint32 *needed = &r_u->needed;
+
+       int snum;
+
+       /* that's an [in out] buffer */
+       spoolss_move_buffer(q_u->buffer, &r_u->buffer);
+       buffer = r_u->buffer;
+
+       *needed=0;
+
+       if (!get_printer_snum(p, handle, &snum))
+               return WERR_BADFID;
+
+       switch (level) {
+       case 0:
+               return getprinter_level_0(snum, buffer, offered, needed);
+       case 1:
+               return getprinter_level_1(snum, buffer, offered, needed);
+       case 2:         
+               return getprinter_level_2(snum, buffer, offered, needed);
+       case 3:         
+               return getprinter_level_3(snum, buffer, offered, needed);
+       case 4:         
+               return getprinter_level_4(snum, buffer, offered, needed);
+       case 5:         
+               return getprinter_level_5(snum, buffer, offered, needed);
+       }
+       return WERR_UNKNOWN_LEVEL;
+}      
+               
+/********************************************************************
+ * fill a DRIVER_INFO_1 struct
+ ********************************************************************/
+static void fill_printer_driver_info_1(DRIVER_INFO_1 *info, NT_PRINTER_DRIVER_INFO_LEVEL driver, fstring servername, fstring architecture)
+{
+       init_unistr( &info->name, driver.info_3->name);
+}
+
+/********************************************************************
  * construct_printer_driver_info_1
  ********************************************************************/
-static uint32 construct_printer_driver_info_1(DRIVER_INFO_1 *info, int snum, fstring servername, fstring architecture, uint32 version)
+static WERROR construct_printer_driver_info_1(DRIVER_INFO_1 *info, int snum, fstring servername, fstring architecture, uint32 version)
 {      
        NT_PRINTER_INFO_LEVEL *printer = NULL;
        NT_PRINTER_DRIVER_INFO_LEVEL driver;
 
        ZERO_STRUCT(driver);
 
-       if (get_a_printer(&printer, 2, lp_servicename(snum)) != 0)
-               return ERROR_INVALID_PRINTER_NAME;
+       if (!W_ERROR_IS_OK(get_a_printer(&printer, 2, lp_servicename(snum))))
+               return WERR_INVALID_PRINTER_NAME;
 
-       if (get_a_printer_driver(&driver, 3, printer->info_2->drivername, architecture, version) != 0)
-               return ERROR_UNKNOWN_PRINTER_DRIVER;
+       if (!W_ERROR_IS_OK(get_a_printer_driver(&driver, 3, printer->info_2->drivername, architecture, version)))
+               return WERR_UNKNOWN_PRINTER_DRIVER;
 
        fill_printer_driver_info_1(info, driver, servername, architecture);
 
        free_a_printer(&printer,2);
 
-       return NT_STATUS_NO_PROBLEMO;
+       return WERR_OK;
 }
 
 /********************************************************************
@@ -2751,19 +3543,19 @@ static void fill_printer_driver_info_2(DRIVER_INFO_2 *info, NT_PRINTER_DRIVER_IN
 
 
     if (strlen(driver.info_3->driverpath)) {
-               snprintf(temp, sizeof(temp)-1, "\\\\%s%s", servername, driver.info_3->driverpath);
+               slprintf(temp, sizeof(temp)-1, "\\\\%s%s", servername, driver.info_3->driverpath);
                init_unistr( &info->driverpath, temp );
     } else
         init_unistr( &info->driverpath, "" );
 
        if (strlen(driver.info_3->datafile)) {
-               snprintf(temp, sizeof(temp)-1, "\\\\%s%s", servername, driver.info_3->datafile);
+               slprintf(temp, sizeof(temp)-1, "\\\\%s%s", servername, driver.info_3->datafile);
                init_unistr( &info->datafile, temp );
        } else
                init_unistr( &info->datafile, "" );
        
        if (strlen(driver.info_3->configfile)) {
-               snprintf(temp, sizeof(temp)-1, "\\\\%s%s", servername, driver.info_3->configfile);
+               slprintf(temp, sizeof(temp)-1, "\\\\%s%s", servername, driver.info_3->configfile);
                init_unistr( &info->configfile, temp ); 
        } else
                init_unistr( &info->configfile, "" );
@@ -2773,7 +3565,7 @@ static void fill_printer_driver_info_2(DRIVER_INFO_2 *info, NT_PRINTER_DRIVER_IN
  * construct_printer_driver_info_2
  * fill a printer_info_2 struct
  ********************************************************************/
-static uint32 construct_printer_driver_info_2(DRIVER_INFO_2 *info, int snum, fstring servername, fstring architecture, uint32 version)
+static WERROR construct_printer_driver_info_2(DRIVER_INFO_2 *info, int snum, fstring servername, fstring architecture, uint32 version)
 {
        NT_PRINTER_INFO_LEVEL *printer = NULL;
        NT_PRINTER_DRIVER_INFO_LEVEL driver;
@@ -2781,17 +3573,17 @@ static uint32 construct_printer_driver_info_2(DRIVER_INFO_2 *info, int snum, fst
        ZERO_STRUCT(printer);
        ZERO_STRUCT(driver);
 
-       if (!get_a_printer(&printer, 2, lp_servicename(snum)) != 0)
-               return ERROR_INVALID_PRINTER_NAME;
+       if (!W_ERROR_IS_OK(get_a_printer(&printer, 2, lp_servicename(snum))))
+               return WERR_INVALID_PRINTER_NAME;
 
-       if (!get_a_printer_driver(&driver, 3, printer->info_2->drivername, architecture, version) != 0)
-               return ERROR_UNKNOWN_PRINTER_DRIVER;
+       if (!W_ERROR_IS_OK(get_a_printer_driver(&driver, 3, printer->info_2->drivername, architecture, version)))
+               return WERR_UNKNOWN_PRINTER_DRIVER;
 
        fill_printer_driver_info_2(info, driver, servername);
 
        free_a_printer(&printer,2);
 
-       return NT_STATUS_NO_PROBLEMO;
+       return WERR_OK;
 }
 
 /********************************************************************
@@ -2805,6 +3597,7 @@ static void init_unistr_array(uint16 **uni_array, fstring *char_array, char *ser
        int j=0;
        char *v;
        pstring line;
+       uint16 *tuary;
 
        DEBUG(6,("init_unistr_array\n"));
        *uni_array=NULL;
@@ -2817,13 +3610,14 @@ static void init_unistr_array(uint16 **uni_array, fstring *char_array, char *ser
                        if (!v) v = ""; /* hack to handle null lists */
                }
                if (strlen(v) == 0) break;
-               snprintf(line, sizeof(line)-1, "\\\\%s%s", servername, v);
+               slprintf(line, sizeof(line)-1, "\\\\%s%s", servername, v);
                DEBUGADD(6,("%d:%s:%d\n", i, line, strlen(line)));
-               if((*uni_array=Realloc(*uni_array, (j+strlen(line)+2)*sizeof(uint16))) == NULL) {
+               if((tuary=Realloc(*uni_array, (j+strlen(line)+2)*sizeof(uint16))) == NULL) {
                        DEBUG(0,("init_unistr_array: Realloc error\n" ));
                        return;
                }
-               j += (dos_PutUniCode((char *)(*uni_array+j), line , sizeof(uint16)*strlen(line), True) / sizeof(uint16) );
+               else *uni_array = tuary;
+               j += (rpcstr_push((*uni_array+j), line, sizeof(uint16)*strlen(line)+2, 0)/ sizeof(uint16));
                i++;
        }
        
@@ -2850,25 +3644,25 @@ static void fill_printer_driver_info_3(DRIVER_INFO_3 *info, NT_PRINTER_DRIVER_IN
        init_unistr( &info->architecture, driver.info_3->environment );
 
     if (strlen(driver.info_3->driverpath)) {
-        snprintf(temp, sizeof(temp)-1, "\\\\%s%s", servername, driver.info_3->driverpath);             
+        slprintf(temp, sizeof(temp)-1, "\\\\%s%s", servername, driver.info_3->driverpath);             
         init_unistr( &info->driverpath, temp );
     } else
         init_unistr( &info->driverpath, "" );
     
     if (strlen(driver.info_3->datafile)) {
-        snprintf(temp, sizeof(temp)-1, "\\\\%s%s", servername, driver.info_3->datafile);
+        slprintf(temp, sizeof(temp)-1, "\\\\%s%s", servername, driver.info_3->datafile);
         init_unistr( &info->datafile, temp );
     } else
         init_unistr( &info->datafile, "" );
 
     if (strlen(driver.info_3->configfile)) {
-        snprintf(temp, sizeof(temp)-1, "\\\\%s%s", servername, driver.info_3->configfile);
+        slprintf(temp, sizeof(temp)-1, "\\\\%s%s", servername, driver.info_3->configfile);
         init_unistr( &info->configfile, temp );        
     } else
         init_unistr( &info->configfile, "" );
 
     if (strlen(driver.info_3->helpfile)) {
-        snprintf(temp, sizeof(temp)-1, "\\\\%s%s", servername, driver.info_3->helpfile);
+        slprintf(temp, sizeof(temp)-1, "\\\\%s%s", servername, driver.info_3->helpfile);
         init_unistr( &info->helpfile, temp );
     } else
         init_unistr( &info->helpfile, "" );
@@ -2884,30 +3678,30 @@ static void fill_printer_driver_info_3(DRIVER_INFO_3 *info, NT_PRINTER_DRIVER_IN
  * construct_printer_info_3
  * fill a printer_info_3 struct
  ********************************************************************/
-static uint32 construct_printer_driver_info_3(DRIVER_INFO_3 *info, int snum, fstring servername, fstring architecture, uint32 version)
+static WERROR construct_printer_driver_info_3(DRIVER_INFO_3 *info, int snum, fstring servername, fstring architecture, uint32 version)
 {      
        NT_PRINTER_INFO_LEVEL *printer = NULL;
        NT_PRINTER_DRIVER_INFO_LEVEL driver;
-       uint32 status=0;
+       WERROR status;
        ZERO_STRUCT(driver);
 
        status=get_a_printer(&printer, 2, lp_servicename(snum) );
-       DEBUG(8,("construct_printer_driver_info_3: status: %d\n", status));
-       if (status != 0)
-               return ERROR_INVALID_PRINTER_NAME;
+       DEBUG(8,("construct_printer_driver_info_3: status: %s\n", werror_str(status)));
+       if (!W_ERROR_IS_OK(status))
+               return WERR_INVALID_PRINTER_NAME;
 
        status=get_a_printer_driver(&driver, 3, printer->info_2->drivername, architecture, version);    
-       DEBUG(8,("construct_printer_driver_info_3: status: %d\n", status));
-       if (status != 0) {
+       DEBUG(8,("construct_printer_driver_info_3: status: %s\n", werror_str(status)));
+       if (!W_ERROR_IS_OK(status)) {
                free_a_printer(&printer,2);
-               return ERROR_UNKNOWN_PRINTER_DRIVER;
+               return WERR_UNKNOWN_PRINTER_DRIVER;
        }
 
        fill_printer_driver_info_3(info, driver, servername);
 
        free_a_printer(&printer,2);
 
-       return NT_STATUS_NO_PROBLEMO;
+       return WERR_OK;
 }
 
 /********************************************************************
@@ -2929,25 +3723,25 @@ static void fill_printer_driver_info_6(DRIVER_INFO_6 *info, NT_PRINTER_DRIVER_IN
        init_unistr( &info->architecture, driver.info_3->environment );
 
        if (strlen(driver.info_3->driverpath)) {
-               snprintf(temp, sizeof(temp)-1, "\\\\%s%s", servername, driver.info_3->driverpath);              
+               slprintf(temp, sizeof(temp)-1, "\\\\%s%s", servername, driver.info_3->driverpath);              
                init_unistr( &info->driverpath, temp );
        } else
                init_unistr( &info->driverpath, "" );
 
        if (strlen(driver.info_3->datafile)) {
-               snprintf(temp, sizeof(temp)-1, "\\\\%s%s", servername, driver.info_3->datafile);
+               slprintf(temp, sizeof(temp)-1, "\\\\%s%s", servername, driver.info_3->datafile);
                init_unistr( &info->datafile, temp );
        } else
                init_unistr( &info->datafile, "" );
 
        if (strlen(driver.info_3->configfile)) {
-               snprintf(temp, sizeof(temp)-1, "\\\\%s%s", servername, driver.info_3->configfile);
+               slprintf(temp, sizeof(temp)-1, "\\\\%s%s", servername, driver.info_3->configfile);
                init_unistr( &info->configfile, temp ); 
        } else
                init_unistr( &info->configfile, "" );
 
        if (strlen(driver.info_3->helpfile)) {
-               snprintf(temp, sizeof(temp)-1, "\\\\%s%s", servername, driver.info_3->helpfile);
+               slprintf(temp, sizeof(temp)-1, "\\\\%s%s", servername, driver.info_3->helpfile);
                init_unistr( &info->helpfile, temp );
        } else
                init_unistr( &info->helpfile, "" );
@@ -2978,37 +3772,37 @@ static void fill_printer_driver_info_6(DRIVER_INFO_6 *info, NT_PRINTER_DRIVER_IN
  * construct_printer_info_6
  * fill a printer_info_6 struct
  ********************************************************************/
-static uint32 construct_printer_driver_info_6(DRIVER_INFO_6 *info, int snum, fstring servername, fstring architecture, uint32 version)
+static WERROR construct_printer_driver_info_6(DRIVER_INFO_6 *info, int snum, fstring servername, fstring architecture, uint32 version)
 {      
        NT_PRINTER_INFO_LEVEL *printer = NULL;
        NT_PRINTER_DRIVER_INFO_LEVEL driver;
-       uint32 status=0;
+       WERROR status;
        ZERO_STRUCT(driver);
 
        status=get_a_printer(&printer, 2, lp_servicename(snum) );
-       DEBUG(8,("construct_printer_driver_info_6: status: %d\n", status));
-       if (status != 0)
-               return ERROR_INVALID_PRINTER_NAME;
+       DEBUG(8,("construct_printer_driver_info_6: status: %s\n", werror_str(status)));
+       if (!W_ERROR_IS_OK(status))
+               return WERR_INVALID_PRINTER_NAME;
 
        status=get_a_printer_driver(&driver, 3, printer->info_2->drivername, architecture, version);    
-       DEBUG(8,("construct_printer_driver_info_6: status: %d\n", status));
-       if (status != 0) {
+       DEBUG(8,("construct_printer_driver_info_6: status: %s\n", werror_str(status)));
+       if (!W_ERROR_IS_OK(status)) {
                /*
                 * Is this a W2k client ?
                 */
 
                if (version < 3) {
                        free_a_printer(&printer,2);
-                       return ERROR_UNKNOWN_PRINTER_DRIVER;
+                       return WERR_UNKNOWN_PRINTER_DRIVER;
                }
 
                /* Yes - try again with a WinNT driver. */
                version = 2;
                status=get_a_printer_driver(&driver, 3, printer->info_2->drivername, architecture, version);    
-               DEBUG(8,("construct_printer_driver_info_6: status: %d\n", status));
-               if (status != 0) {
+               DEBUG(8,("construct_printer_driver_info_6: status: %s\n", werror_str(status)));
+               if (!W_ERROR_IS_OK(status)) {
                        free_a_printer(&printer,2);
-                       return ERROR_UNKNOWN_PRINTER_DRIVER;
+                       return WERR_UNKNOWN_PRINTER_DRIVER;
                }
        }
 
@@ -3016,7 +3810,7 @@ static uint32 construct_printer_driver_info_6(DRIVER_INFO_6 *info, int snum, fst
 
        free_a_printer(&printer,2);
 
-       return NT_STATUS_NO_PROBLEMO;
+       return WERR_OK;
 }
 
 /****************************************************************************
@@ -3024,7 +3818,7 @@ static uint32 construct_printer_driver_info_6(DRIVER_INFO_6 *info, int snum, fst
 
 static void free_printer_driver_info_3(DRIVER_INFO_3 *info)
 {
-       safe_free(info->dependentfiles);
+       SAFE_FREE(info->dependentfiles);
 }
 
 /****************************************************************************
@@ -3032,23 +3826,23 @@ static void free_printer_driver_info_3(DRIVER_INFO_3 *info)
 
 static void free_printer_driver_info_6(DRIVER_INFO_6 *info)
 {
-       safe_free(info->dependentfiles);
+       SAFE_FREE(info->dependentfiles);
        
 }
 
 /****************************************************************************
 ****************************************************************************/
-static uint32 getprinterdriver2_level1(fstring servername, fstring architecture, uint32 version, int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
+static WERROR getprinterdriver2_level1(fstring servername, fstring architecture, uint32 version, int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
 {
        DRIVER_INFO_1 *info=NULL;
-       uint32 status;
+       WERROR status;
        
        if((info=(DRIVER_INFO_1 *)malloc(sizeof(DRIVER_INFO_1))) == NULL)
-               return ERROR_NOT_ENOUGH_MEMORY;
+               return WERR_NOMEM;
        
        status=construct_printer_driver_info_1(info, snum, servername, architecture, version);
-       if (status != NT_STATUS_NO_PROBLEMO) {
-               safe_free(info);
+       if (!W_ERROR_IS_OK(status)) {
+               SAFE_FREE(info);
                return status;
        }
 
@@ -3056,35 +3850,35 @@ static uint32 getprinterdriver2_level1(fstring servername, fstring architecture,
        *needed += spoolss_size_printer_driver_info_1(info);
 
        if (!alloc_buffer_size(buffer, *needed)) {
-               safe_free(info);
-               return ERROR_INSUFFICIENT_BUFFER;
+               SAFE_FREE(info);
+               return WERR_INSUFFICIENT_BUFFER;
        }
 
        /* fill the buffer with the structures */
-       new_smb_io_printer_driver_info_1("", buffer, info, 0);  
+       smb_io_printer_driver_info_1("", buffer, info, 0);      
 
        /* clear memory */
-       safe_free(info);
+       SAFE_FREE(info);
 
        if (*needed > offered)
-               return ERROR_INSUFFICIENT_BUFFER;
-       else
-               return NT_STATUS_NO_PROBLEMO;
+               return WERR_INSUFFICIENT_BUFFER;
+
+       return WERR_OK;
 }
 
 /****************************************************************************
 ****************************************************************************/
-static uint32 getprinterdriver2_level2(fstring servername, fstring architecture, uint32 version, int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
+static WERROR getprinterdriver2_level2(fstring servername, fstring architecture, uint32 version, int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
 {
        DRIVER_INFO_2 *info=NULL;
-       uint32 status;
+       WERROR status;
        
        if((info=(DRIVER_INFO_2 *)malloc(sizeof(DRIVER_INFO_2))) == NULL)
-               return ERROR_NOT_ENOUGH_MEMORY;
+               return WERR_NOMEM;
        
        status=construct_printer_driver_info_2(info, snum, servername, architecture, version);
-       if (status != NT_STATUS_NO_PROBLEMO) {
-               safe_free(info);
+       if (!W_ERROR_IS_OK(status)) {
+               SAFE_FREE(info);
                return status;
        }
 
@@ -3092,33 +3886,33 @@ static uint32 getprinterdriver2_level2(fstring servername, fstring architecture,
        *needed += spoolss_size_printer_driver_info_2(info);
 
        if (!alloc_buffer_size(buffer, *needed)) {
-               safe_free(info);
-               return ERROR_INSUFFICIENT_BUFFER;
+               SAFE_FREE(info);
+               return WERR_INSUFFICIENT_BUFFER;
        }
 
        /* fill the buffer with the structures */
-       new_smb_io_printer_driver_info_2("", buffer, info, 0);  
+       smb_io_printer_driver_info_2("", buffer, info, 0);      
 
        /* clear memory */
-       safe_free(info);
+       SAFE_FREE(info);
 
        if (*needed > offered)
-               return ERROR_INSUFFICIENT_BUFFER;
-       else
-               return NT_STATUS_NO_PROBLEMO;
+               return WERR_INSUFFICIENT_BUFFER;
+       
+       return WERR_OK;
 }
 
 /****************************************************************************
 ****************************************************************************/
-static uint32 getprinterdriver2_level3(fstring servername, fstring architecture, uint32 version, int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
+static WERROR getprinterdriver2_level3(fstring servername, fstring architecture, uint32 version, int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
 {
        DRIVER_INFO_3 info;
-       uint32 status;
+       WERROR status;
 
        ZERO_STRUCT(info);
 
        status=construct_printer_driver_info_3(&info, snum, servername, architecture, version);
-       if (status != NT_STATUS_NO_PROBLEMO) {
+       if (!W_ERROR_IS_OK(status)) {
                return status;
        }
 
@@ -3127,31 +3921,31 @@ static uint32 getprinterdriver2_level3(fstring servername, fstring architecture,
 
        if (!alloc_buffer_size(buffer, *needed)) {
                free_printer_driver_info_3(&info);
-               return ERROR_INSUFFICIENT_BUFFER;
+               return WERR_INSUFFICIENT_BUFFER;
        }
 
        /* fill the buffer with the structures */
-       new_smb_io_printer_driver_info_3("", buffer, &info, 0);
+       smb_io_printer_driver_info_3("", buffer, &info, 0);
 
        free_printer_driver_info_3(&info);
 
        if (*needed > offered)
-               return ERROR_INSUFFICIENT_BUFFER;
-       else
-               return NT_STATUS_NO_PROBLEMO;
+               return WERR_INSUFFICIENT_BUFFER;
+
+       return WERR_OK;
 }
 
 /****************************************************************************
 ****************************************************************************/
-static uint32 getprinterdriver2_level6(fstring servername, fstring architecture, uint32 version, int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
+static WERROR getprinterdriver2_level6(fstring servername, fstring architecture, uint32 version, int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
 {
        DRIVER_INFO_6 info;
-       uint32 status;
+       WERROR status;
 
        ZERO_STRUCT(info);
 
        status=construct_printer_driver_info_6(&info, snum, servername, architecture, version);
-       if (status != NT_STATUS_NO_PROBLEMO) {
+       if (!W_ERROR_IS_OK(status)) {
                return status;
        }
 
@@ -3160,42 +3954,55 @@ static uint32 getprinterdriver2_level6(fstring servername, fstring architecture,
 
        if (!alloc_buffer_size(buffer, *needed)) {
                free_printer_driver_info_6(&info);
-               return ERROR_INSUFFICIENT_BUFFER;
+               return WERR_INSUFFICIENT_BUFFER;
        }
 
        /* fill the buffer with the structures */
-       new_smb_io_printer_driver_info_6("", buffer, &info, 0);
+       smb_io_printer_driver_info_6("", buffer, &info, 0);
 
        free_printer_driver_info_6(&info);
 
        if (*needed > offered)
-               return ERROR_INSUFFICIENT_BUFFER;
-       else
-               return NT_STATUS_NO_PROBLEMO;
+               return WERR_INSUFFICIENT_BUFFER;
+       
+       return WERR_OK;
 }
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_getprinterdriver2(POLICY_HND *handle, const UNISTR2 *uni_arch, uint32 level,
-                               uint32 clientmajorversion, uint32 clientminorversion,
-                               NEW_BUFFER *buffer, uint32 offered,
-                               uint32 *needed, uint32 *servermajorversion, uint32 *serverminorversion)
+
+WERROR _spoolss_getprinterdriver2(pipes_struct *p, SPOOL_Q_GETPRINTERDRIVER2 *q_u, SPOOL_R_GETPRINTERDRIVER2 *r_u)
 {
+       POLICY_HND *handle = &q_u->handle;
+       UNISTR2 *uni_arch = &q_u->architecture;
+       uint32 level = q_u->level;
+       uint32 clientmajorversion = q_u->clientmajorversion;
+/*     uint32 clientminorversion = q_u->clientminorversion; - notused. */
+       NEW_BUFFER *buffer = NULL;
+       uint32 offered = q_u->offered;
+       uint32 *needed = &r_u->needed;
+       uint32 *servermajorversion = &r_u->servermajorversion;
+       uint32 *serverminorversion = &r_u->serverminorversion;
+
        fstring servername;
        fstring architecture;
        int snum;
 
+       /* that's an [in out] buffer */
+       spoolss_move_buffer(q_u->buffer, &r_u->buffer);
+       buffer = r_u->buffer;
+
        DEBUG(4,("_spoolss_getprinterdriver2\n"));
 
        *needed=0;
        *servermajorversion=0;
        *serverminorversion=0;
 
-       pstrcpy(servername, global_myname);
+       pstrcpy(servername, get_called_name());
        unistr2_to_ascii(architecture, uni_arch, sizeof(architecture)-1);
 
-       if (!get_printer_snum(handle, &snum))
-               return ERROR_INVALID_HANDLE;
+       if (!get_printer_snum(p, handle, &snum))
+               return WERR_BADFID;
 
        switch (level) {
        case 1:
@@ -3206,56 +4013,46 @@ uint32 _spoolss_getprinterdriver2(POLICY_HND *handle, const UNISTR2 *uni_arch, u
                return getprinterdriver2_level3(servername, architecture, clientmajorversion, snum, buffer, offered, needed);
        case 6:
                return getprinterdriver2_level6(servername, architecture, clientmajorversion, snum, buffer, offered, needed);
-       default:
-               return ERROR_INVALID_LEVEL;
        }
+
+       return WERR_UNKNOWN_LEVEL;
 }
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_startpageprinter(POLICY_HND *handle)
+
+WERROR _spoolss_startpageprinter(pipes_struct *p, SPOOL_Q_STARTPAGEPRINTER *q_u, SPOOL_R_STARTPAGEPRINTER *r_u)
 {
-       Printer_entry *Printer = find_printer_index_by_hnd(handle);
+       POLICY_HND *handle = &q_u->handle;
+
+       Printer_entry *Printer = find_printer_index_by_hnd(p, handle);
 
-       if (OPEN_HANDLE(Printer)) {
-               Printer->page_started=True;
-               return 0x0;
+       if (!Printer) {
+               DEBUG(3,("Error in startpageprinter printer handle\n"));
+               return WERR_BADFID;
        }
 
-       DEBUG(3,("Error in startpageprinter printer handle\n"));
-       return ERROR_INVALID_HANDLE;
+       Printer->page_started=True;
+       return WERR_OK;
 }
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_endpageprinter(POLICY_HND *handle)
+
+WERROR _spoolss_endpageprinter(pipes_struct *p, SPOOL_Q_ENDPAGEPRINTER *q_u, SPOOL_R_ENDPAGEPRINTER *r_u)
 {
-       Printer_entry *Printer = find_printer_index_by_hnd(handle);
+       POLICY_HND *handle = &q_u->handle;
+
+       Printer_entry *Printer = find_printer_index_by_hnd(p, handle);
 
-       if (!OPEN_HANDLE(Printer)) {
+       if (!Printer) {
                DEBUG(0,("_spoolss_endpageprinter: Invalid handle (%s).\n",OUR_HANDLE(handle)));
-               return ERROR_INVALID_HANDLE;
+               return WERR_BADFID;
        }
        
        Printer->page_started=False;
 
-       return NT_STATUS_NO_PROBLEMO;
-}
-
-/****************************************************************************
- Return a user struct for a pipe user.
-****************************************************************************/
-
-static struct current_user *get_current_user(struct current_user *user, pipes_struct *p)
-{
-       if (p->ntlmssp_auth_validated) {
-               memcpy(user, &p->pipe_user, sizeof(struct current_user));
-       } else {
-               extern struct current_user current_user;
-               memcpy(user, &current_user, sizeof(struct current_user));
-       }
-
-       return user;
+       return WERR_OK;
 }
 
 /********************************************************************
@@ -3263,20 +4060,24 @@ static struct current_user *get_current_user(struct current_user *user, pipes_st
  * called from the spoolss dispatcher
  *
  ********************************************************************/
-uint32 _spoolss_startdocprinter(POLICY_HND *handle, uint32 level,
-                               pipes_struct *p, DOC_INFO *docinfo,
-                               uint32 *jobid)
+
+WERROR _spoolss_startdocprinter(pipes_struct *p, SPOOL_Q_STARTDOCPRINTER *q_u, SPOOL_R_STARTDOCPRINTER *r_u)
 {
+       POLICY_HND *handle = &q_u->handle;
+/*     uint32 level = q_u->doc_info_container.level; - notused. */
+       DOC_INFO *docinfo = &q_u->doc_info_container.docinfo;
+       uint32 *jobid = &r_u->jobid;
+
        DOC_INFO_1 *info_1 = &docinfo->doc_info_1;
        int snum;
        pstring jobname;
        fstring datatype;
-       Printer_entry *Printer = find_printer_index_by_hnd(handle);
+       Printer_entry *Printer = find_printer_index_by_hnd(p, handle);
        struct current_user user;
 
-       if (!OPEN_HANDLE(Printer)) {
+       if (!Printer) {
                DEBUG(0,("_spoolss_startdocprinter: Invalid handle (%s)\n", OUR_HANDLE(handle)));
-               return ERROR_INVALID_HANDLE;
+               return WERR_BADFID;
        }
 
        get_current_user(&user, p);
@@ -3297,13 +4098,13 @@ uint32 _spoolss_startdocprinter(POLICY_HND *handle, uint32 level,
                unistr2_to_ascii(datatype, &info_1->datatype, sizeof(datatype));
                if (strcmp(datatype, "RAW") != 0) {
                        (*jobid)=0;
-                       return ERROR_INVALID_DATATYPE;
+                       return WERR_INVALID_DATATYPE;
                }               
        }               
        
        /* get the share number of the printer */
-       if (!get_printer_snum(handle, &snum)) {
-               return ERROR_INVALID_HANDLE;
+       if (!get_printer_snum(p, handle, &snum)) {
+               return WERR_BADFID;
        }
 
        unistr2_to_ascii(jobname, &info_1->docname, sizeof(jobname));
@@ -3314,14 +4115,13 @@ uint32 _spoolss_startdocprinter(POLICY_HND *handle, uint32 level,
           NT error code. */
 
        if (Printer->jobid == -1) {
-               return map_nt_error_from_unix(errno);
+               return map_werror_from_unix(errno);
        }
        
        Printer->document_started=True;
        (*jobid) = Printer->jobid;
 
-       srv_spoolss_sendnotify(handle);
-       return 0x0;
+       return WERR_OK;
 }
 
 /********************************************************************
@@ -3329,42 +4129,38 @@ uint32 _spoolss_startdocprinter(POLICY_HND *handle, uint32 level,
  * called from the spoolss dispatcher
  *
  ********************************************************************/
-uint32 _spoolss_enddocprinter(POLICY_HND *handle)
-{
-       Printer_entry *Printer=find_printer_index_by_hnd(handle);
-       
-       if (!OPEN_HANDLE(Printer)) {
-               DEBUG(0,("_spoolss_enddocprinter: Invalid handle (%s)\n", OUR_HANDLE(handle)));
-               return ERROR_INVALID_HANDLE;
-       }
-       
-       Printer->document_started=False;
-       print_job_end(Printer->jobid);
-       /* error codes unhandled so far ... */
 
-       srv_spoolss_sendnotify(handle);
+WERROR _spoolss_enddocprinter(pipes_struct *p, SPOOL_Q_ENDDOCPRINTER *q_u, SPOOL_R_ENDDOCPRINTER *r_u)
+{
+       POLICY_HND *handle = &q_u->handle;
 
-       return 0x0;
+       return _spoolss_enddocprinter_internal(p, handle);
 }
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_writeprinter( POLICY_HND *handle,
-                               uint32 buffer_size,
-                               uint8 *buffer,
-                               uint32 *buffer_written)
+
+WERROR _spoolss_writeprinter(pipes_struct *p, SPOOL_Q_WRITEPRINTER *q_u, SPOOL_R_WRITEPRINTER *r_u)
 {
-       Printer_entry *Printer = find_printer_index_by_hnd(handle);
+       POLICY_HND *handle = &q_u->handle;
+       uint32 buffer_size = q_u->buffer_size;
+       uint8 *buffer = q_u->buffer;
+       uint32 *buffer_written = &q_u->buffer_size2;
+
+       Printer_entry *Printer = find_printer_index_by_hnd(p, handle);
        
-       if (!OPEN_HANDLE(Printer)) {
+       if (!Printer) {
                DEBUG(0,("_spoolss_writeprinter: Invalid handle (%s)\n",OUR_HANDLE(handle)));
-               return ERROR_INVALID_HANDLE;
+               r_u->buffer_written = q_u->buffer_size2;
+               return WERR_BADFID;
        }
 
-       (*buffer_written) = print_job_write(Printer->jobid, (char *)buffer,
-                                           buffer_size);
+       (*buffer_written) = print_job_write(Printer->jobid, (char *)buffer, buffer_size);
 
-       return 0x0;
+
+       r_u->buffer_written = q_u->buffer_size2;
+
+       return WERR_OK;
 }
 
 /********************************************************************
@@ -3372,42 +4168,43 @@ uint32 _spoolss_writeprinter( POLICY_HND *handle,
  * called from the spoolss dispatcher
  *
  ********************************************************************/
-static uint32 control_printer(POLICY_HND *handle, uint32 command,
+static WERROR control_printer(POLICY_HND *handle, uint32 command,
                              pipes_struct *p)
 {
        struct current_user user;
-       int snum, errcode = ERROR_INVALID_FUNCTION;
-       Printer_entry *Printer = find_printer_index_by_hnd(handle);
+       int snum;
+       WERROR errcode = WERR_BADFUNC;
+       Printer_entry *Printer = find_printer_index_by_hnd(p, handle);
 
        get_current_user(&user, p);
 
-       if (!OPEN_HANDLE(Printer)) {
+       if (!Printer) {
                DEBUG(0,("control_printer: Invalid handle (%s)\n", OUR_HANDLE(handle)));
-               return ERROR_INVALID_HANDLE;
+               return WERR_BADFID;
        }
 
-       if (!get_printer_snum(handle, &snum))
-               return ERROR_INVALID_HANDLE;
+       if (!get_printer_snum(p, handle, &snum))
+               return WERR_BADFID;
 
        switch (command) {
        case PRINTER_CONTROL_PAUSE:
                if (print_queue_pause(&user, snum, &errcode)) {
-                       errcode = 0;
+                       errcode = WERR_OK;
                }
                break;
        case PRINTER_CONTROL_RESUME:
        case PRINTER_CONTROL_UNPAUSE:
                if (print_queue_resume(&user, snum, &errcode)) {
-                       errcode = 0;
+                       errcode = WERR_OK;
                }
                break;
        case PRINTER_CONTROL_PURGE:
                if (print_queue_purge(&user, snum, &errcode)) {
-                       errcode = 0;
+                       errcode = WERR_OK;
                }
                break;
        default:
-               return ERROR_INVALID_LEVEL;
+               return WERR_UNKNOWN_LEVEL;
        }
 
        return errcode;
@@ -3417,8 +4214,10 @@ static uint32 control_printer(POLICY_HND *handle, uint32 command,
  * api_spoolss_abortprinter
  ********************************************************************/
 
-uint32 _spoolss_abortprinter(POLICY_HND *handle, pipes_struct *p)
+WERROR _spoolss_abortprinter(pipes_struct *p, SPOOL_Q_ABORTPRINTER *q_u, SPOOL_R_ABORTPRINTER *r_u)
 {
+       POLICY_HND *handle = &q_u->handle;
+
        return control_printer(handle, PRINTER_CONTROL_PURGE, p);
 }
 
@@ -3426,22 +4225,22 @@ uint32 _spoolss_abortprinter(POLICY_HND *handle, pipes_struct *p)
  * called by spoolss_api_setprinter
  * when updating a printer description
  ********************************************************************/
-static uint32 update_printer_sec(POLICY_HND *handle, uint32 level,
+static WERROR update_printer_sec(POLICY_HND *handle, uint32 level,
                                 const SPOOL_PRINTER_INFO_LEVEL *info,
                                 pipes_struct *p, SEC_DESC_BUF *secdesc_ctr)
 {
        SEC_DESC_BUF *new_secdesc_ctr = NULL, *old_secdesc_ctr = NULL;
        struct current_user user;
-       uint32 result;
+       WERROR result;
        int snum;
 
-       Printer_entry *Printer = find_printer_index_by_hnd(handle);
+       Printer_entry *Printer = find_printer_index_by_hnd(p, handle);
 
-       if (!OPEN_HANDLE(Printer) || !get_printer_snum(handle, &snum)) {
+       if (!Printer || !get_printer_snum(p, handle, &snum)) {
                DEBUG(0,("update_printer_sec: Invalid handle (%s)\n",
                         OUR_HANDLE(handle)));
 
-               result = ERROR_INVALID_HANDLE;
+               result = WERR_BADFID;
                goto done;
        }
 
@@ -3450,48 +4249,48 @@ static uint32 update_printer_sec(POLICY_HND *handle, uint32 level,
           dialog boxes when the user doesn't have permission to change
           the security descriptor. */
 
-       nt_printing_getsec(Printer->dev.handlename, &old_secdesc_ctr);
+       nt_printing_getsec(p->mem_ctx, Printer->dev.handlename, &old_secdesc_ctr);
 
        if (DEBUGLEVEL >= 10) {
-               SEC_ACL *acl;
+               SEC_ACL *the_acl;
                int i;
 
-               acl = old_secdesc_ctr->sec->dacl;
+               the_acl = old_secdesc_ctr->sec->dacl;
                DEBUG(10, ("old_secdesc_ctr for %s has %d aces:\n", 
-                          PRINTERNAME(snum), acl->num_aces));
+                          PRINTERNAME(snum), the_acl->num_aces));
 
-               for (i = 0; i < acl->num_aces; i++) {
+               for (i = 0; i < the_acl->num_aces; i++) {
                        fstring sid_str;
 
-                       sid_to_string(sid_str, &acl->ace[i].sid);
+                       sid_to_string(sid_str, &the_acl->ace[i].trustee);
 
                        DEBUG(10, ("%s 0x%08x\n", sid_str, 
-                                 acl->ace[i].info.mask));
+                                 the_acl->ace[i].info.mask));
                }
 
-               acl = secdesc_ctr->sec->dacl;
+               the_acl = secdesc_ctr->sec->dacl;
 
-               if (acl) {
+               if (the_acl) {
                        DEBUG(10, ("secdesc_ctr for %s has %d aces:\n", 
-                                  PRINTERNAME(snum), acl->num_aces));
+                                  PRINTERNAME(snum), the_acl->num_aces));
 
-                       for (i = 0; i < acl->num_aces; i++) {
+                       for (i = 0; i < the_acl->num_aces; i++) {
                                fstring sid_str;
                                
-                               sid_to_string(sid_str, &acl->ace[i].sid);
+                               sid_to_string(sid_str, &the_acl->ace[i].trustee);
                                
                                DEBUG(10, ("%s 0x%08x\n", sid_str, 
-                                          acl->ace[i].info.mask));
+                                          the_acl->ace[i].info.mask));
                        }
                } else {
                        DEBUG(10, ("dacl for secdesc_ctr is NULL\n"));
                }
        }
 
-       new_secdesc_ctr = sec_desc_merge(secdesc_ctr, old_secdesc_ctr);
+       new_secdesc_ctr = sec_desc_merge(p->mem_ctx, secdesc_ctr, old_secdesc_ctr);
 
        if (sec_desc_equal(new_secdesc_ctr->sec, old_secdesc_ctr->sec)) {
-               result = NT_STATUS_NO_PROBLEMO;
+               result = WERR_OK;
                goto done;
        }
 
@@ -3505,15 +4304,13 @@ static uint32 update_printer_sec(POLICY_HND *handle, uint32 level,
           information. */
 
        if (!print_access_check(&user, snum, PRINTER_ACCESS_ADMINISTER)) {
-               result = ERROR_ACCESS_DENIED;
+               result = WERR_ACCESS_DENIED;
                goto done;
        }
 
        result = nt_printing_setsec(Printer->dev.handlename, new_secdesc_ctr);
 
  done:
-       free_sec_desc_buf(&new_secdesc_ctr);
-       free_sec_desc_buf(&old_secdesc_ctr);
 
        return result;
 }
@@ -3530,9 +4327,9 @@ static BOOL check_printer_ok(NT_PRINTER_INFO_LEVEL_2 *info, int snum)
                 info->servername, info->printername, info->sharename, info->portname, info->drivername, info->comment, info->location));
 
        /* we force some elements to "correct" values */
-       slprintf(info->servername, sizeof(info->servername), "\\\\%s", global_myname);
-       slprintf(info->printername, sizeof(info->printername), "\\\\%s\\%s",
-                global_myname, lp_servicename(snum));
+       slprintf(info->servername, sizeof(info->servername)-1, "\\\\%s", get_called_name());
+       slprintf(info->printername, sizeof(info->printername)-1, "\\\\%s\\%s",
+                get_called_name(), lp_servicename(snum));
        fstrcpy(info->sharename, lp_servicename(snum));
        info->attributes = PRINTER_ATTRIBUTE_SHARED   \
                | PRINTER_ATTRIBUTE_LOCAL  \
@@ -3546,52 +4343,40 @@ static BOOL check_printer_ok(NT_PRINTER_INFO_LEVEL_2 *info, int snum)
 ****************************************************************************/
 static BOOL add_printer_hook(NT_PRINTER_INFO_LEVEL *printer)
 {
-       pid_t local_pid = sys_getpid();
        char *cmd = lp_addprinter_cmd();
-       char *path;
        char **qlines;
-       pstring tmp_file;
        pstring command;
        pstring driverlocation;
        int numlines;
        int ret;
-
-       if (*lp_pathname(lp_servicenumber(PRINTERS_NAME)))
-               path = lp_pathname(lp_servicenumber(PRINTERS_NAME));
-       else
-               path = tmpdir();
+       int fd;
 
        /* build driver path... only 9X architecture is needed for legacy reasons */
        slprintf(driverlocation, sizeof(driverlocation)-1, "\\\\%s\\print$\\WIN40\\0",
-                       global_myname);
+                       get_called_name());
        /* change \ to \\ for the shell */
        all_string_sub(driverlocation,"\\","\\\\",sizeof(pstring));
-       
-       slprintf(tmp_file, sizeof(tmp_file), "%s/smbcmd.%d", path, local_pid);
-       slprintf(command, sizeof(command), "%s \"%s\" \"%s\" \"%s\" \"%s\" \"%s\" \"%s\"",
+
+       slprintf(command, sizeof(command)-1, "%s \"%s\" \"%s\" \"%s\" \"%s\" \"%s\" \"%s\"",
                        cmd, printer->info_2->printername, printer->info_2->sharename,
                        printer->info_2->portname, printer->info_2->drivername,
                        printer->info_2->location, driverlocation);
 
-       unlink(tmp_file);
-
-    /* Convert script args to unix-codepage */
-    dos_to_unix(command, True);
-       DEBUG(10,("Running [%s > %s]\n", command,tmp_file));
-       ret = smbrun(command, tmp_file, False);
+       DEBUG(10,("Running [%s]\n", command));
+       ret = smbrun(command, &fd);
        DEBUGADD(10,("returned [%d]\n", ret));
 
        if ( ret != 0 ) {
-               unlink(tmp_file);
+               if (fd != -1)
+                       close(fd);
                return False;
        }
 
        numlines = 0;
-    /* Get lines and convert them back to dos-codepage */
-       qlines = file_lines_load(tmp_file, &numlines, True);
+       /* Get lines and convert them back to dos-codepage */
+       qlines = fd_lines_load(fd, &numlines);
        DEBUGADD(10,("Lines returned = [%d]\n", numlines));
-       DEBUGADD(10,("Unlinking script output file [%s]\n", tmp_file));
-       unlink(tmp_file);
+       close(fd);
 
        if(numlines) {
                /* Set the portname to what the script says the portname should be. */
@@ -3625,9 +4410,13 @@ static BOOL nt_devicemode_equal(NT_DEVICEMODE *d1, NT_DEVICEMODE *d2)
                return False; /* if either is exclusively NULL are not equal */
        }
 
-       if (!strequal(d1->devicename, d2->devicename) ||
-           !strequal(d1->formname, d2->formname)) {
-               DEBUG(10, ("nt_devicemode_equal(): device,form not equal\n"));
+       if (!strequal(d1->devicename, d2->devicename)) {
+               DEBUG(10, ("nt_devicemode_equal(): device not equal (%s != %s)\n", d1->devicename, d2->devicename));
+               return False;
+       }
+
+       if (!strequal(d1->formname, d2->formname)) {
+               DEBUG(10, ("nt_devicemode_equal(): formname not equal (%s != %s)\n", d1->formname, d2->formname));
                return False;
        }
 
@@ -3793,7 +4582,13 @@ static BOOL nt_printer_info_level_equal(NT_PRINTER_INFO_LEVEL *p1,
        pi1 = p1->info_2;
        pi2 = p2->info_2;
 
+       /* Don't check the attributes as we stomp on the value in
+          check_printer_ok() anyway. */
+
+#if 0
        PI_CHECK_INT(attributes);
+#endif
+
        PI_CHECK_INT(priority);
        PI_CHECK_INT(default_priority);
        PI_CHECK_INT(starttime);
@@ -3801,7 +4596,7 @@ static BOOL nt_printer_info_level_equal(NT_PRINTER_INFO_LEVEL *p1,
        PI_CHECK_INT(averageppm);
 
        /* Yuck - don't check the printername or servername as the
-          add_a_printer() code plays games with them.  You can't
+          mod_a_printer() code plays games with them.  You can't
           change the printername or the sharename through this interface
           in Samba. */
 
@@ -3842,39 +4637,39 @@ static BOOL nt_printer_info_level_equal(NT_PRINTER_INFO_LEVEL *p1,
  * when updating a printer description
  ********************************************************************/
 
-static uint32 update_printer(POLICY_HND *handle, uint32 level,
+static WERROR update_printer(pipes_struct *p, POLICY_HND *handle, uint32 level,
                            const SPOOL_PRINTER_INFO_LEVEL *info,
                            DEVICEMODE *devmode)
 {
        int snum;
        NT_PRINTER_INFO_LEVEL *printer = NULL, *old_printer = NULL;
-       Printer_entry *Printer = find_printer_index_by_hnd(handle);
-       uint32 result;
+       Printer_entry *Printer = find_printer_index_by_hnd(p, handle);
+       WERROR result;
 
        DEBUG(8,("update_printer\n"));
        
-       result = NT_STATUS_NO_PROBLEMO;
+       result = WERR_OK;
 
        if (level!=2) {
                DEBUG(0,("Send a mail to samba@samba.org\n"));
                DEBUGADD(0,("with the following message: update_printer: level!=2\n"));
-               result = ERROR_INVALID_LEVEL;
+               result = WERR_UNKNOWN_LEVEL;
                goto done;
        }
 
-       if (!OPEN_HANDLE(Printer)) {
-               result = ERROR_INVALID_HANDLE;
+       if (!Printer) {
+               result = WERR_BADFID;
                goto done;
        }
 
-       if (!get_printer_snum(handle, &snum)) {
-               result = ERROR_INVALID_HANDLE;
+       if (!get_printer_snum(p, handle, &snum)) {
+               result = WERR_BADFID;
                goto done;
        }
 
-       if((get_a_printer(&printer, 2, lp_servicename(snum)) != 0) ||
-          (get_a_printer(&old_printer, 2, lp_servicename(snum)) != 0)) {
-               result = ERROR_INVALID_HANDLE;
+       if (!W_ERROR_IS_OK(get_a_printer(&printer, 2, lp_servicename(snum))) ||
+           (!W_ERROR_IS_OK(get_a_printer(&old_printer, 2, lp_servicename(snum))))) {
+               result = WERR_BADFID;
                goto done;
        }
 
@@ -3886,33 +4681,27 @@ static uint32 update_printer(POLICY_HND *handle, uint32 level,
         * just read from the tdb in the pointer 'printer'.
         */
 
-       convert_printer_info(info, printer, level);
+       if (!convert_printer_info(info, printer, level)) {
+               result =  WERR_NOMEM;
+               goto done;
+       }
 
        if (info->info_2->devmode_ptr != 0) {
                /* we have a valid devmode
                   convert it and link it*/
 
-               /*
-                * Ensure printer->info_2->devmode is a valid pointer
-                * as we will be overwriting it in convert_devicemode().
-                */
-               
-               if (printer->info_2->devmode == NULL)
-                       printer->info_2->devmode = construct_nt_devicemode(printer->info_2->printername);
-
                DEBUGADD(8,("Converting the devicemode struct\n"));
-               convert_devicemode(devmode, printer->info_2->devmode);
-
-       } else {
-               if (printer->info_2->devmode != NULL)
-                       free_nt_devicemode(&printer->info_2->devmode);
-               printer->info_2->devmode=NULL;
+               if (!convert_devicemode(printer->info_2->printername, devmode,
+                               &printer->info_2->devmode)) {
+                       result =  WERR_NOMEM;
+                       goto done;
+               }
        }
 
        /* Do sanity check on the requested changes for Samba */
 
        if (!check_printer_ok(printer->info_2, snum)) {
-               result = ERROR_INVALID_PARAMETER;
+               result = WERR_INVALID_PARAM;
                goto done;
        }
 
@@ -3922,7 +4711,7 @@ static uint32 update_printer(POLICY_HND *handle, uint32 level,
 
        if (nt_printer_info_level_equal(printer, old_printer)) {
                DEBUG(3, ("printer info has not changed\n"));
-               result = NT_STATUS_NO_PROBLEMO;
+               result = WERR_OK;
                goto done;
        }
 
@@ -3931,48 +4720,48 @@ static uint32 update_printer(POLICY_HND *handle, uint32 level,
        if (!print_access_check(NULL, snum, PRINTER_ACCESS_ADMINISTER)) {
                DEBUG(3, ("printer property change denied by security "
                          "descriptor\n"));
-               result = ERROR_ACCESS_DENIED;
+               result = WERR_ACCESS_DENIED;
                goto done;
        }
 
        /* Call addprinter hook */
 
-       if (*lp_addprinter_cmd() )
-               if ( !add_printer_hook(printer) ) {
-                       result = ERROR_ACCESS_DENIED;
+       if (*lp_addprinter_cmd()) {
+               if (!add_printer_hook(printer)) {
+                       result = WERR_ACCESS_DENIED;
                        goto done;
                }
+       }
        
        /* Update printer info */
-
-       if (add_a_printer(*printer, 2)!=0) {
-               /* I don't really know what to return here !!! */
-               result = ERROR_ACCESS_DENIED;
-               goto done;
-       }
+       result = mod_a_printer(*printer, 2);
 
  done:
        free_a_printer(&printer, 2);
        free_a_printer(&old_printer, 2);
 
-       srv_spoolss_sendnotify(handle);
+       srv_spoolss_sendnotify(p, handle);
 
        return result;
 }
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_setprinter(POLICY_HND *handle, uint32 level,
-                          const SPOOL_PRINTER_INFO_LEVEL *info,
-                          DEVMODE_CTR devmode_ctr,
-                          SEC_DESC_BUF *secdesc_ctr,
-                          uint32 command, pipes_struct *p)
+
+WERROR _spoolss_setprinter(pipes_struct *p, SPOOL_Q_SETPRINTER *q_u, SPOOL_R_SETPRINTER *r_u)
 {
-       Printer_entry *Printer = find_printer_index_by_hnd(handle);
+       POLICY_HND *handle = &q_u->handle;
+       uint32 level = q_u->level;
+       SPOOL_PRINTER_INFO_LEVEL *info = &q_u->info;
+       DEVMODE_CTR devmode_ctr = q_u->devmode_ctr;
+       SEC_DESC_BUF *secdesc_ctr = q_u->secdesc_ctr;
+       uint32 command = q_u->command;
+
+       Printer_entry *Printer = find_printer_index_by_hnd(p, handle);
        
-       if (!OPEN_HANDLE(Printer)) {
+       if (!Printer) {
                DEBUG(0,("_spoolss_setprinter: Invalid handle (%s)\n", OUR_HANDLE(handle)));
-               return ERROR_INVALID_HANDLE;
+               return WERR_BADFID;
        }
 
        /* check the level */   
@@ -3980,51 +4769,53 @@ uint32 _spoolss_setprinter(POLICY_HND *handle, uint32 level,
                case 0:
                        return control_printer(handle, command, p);
                case 2:
-                       return update_printer(handle, level, info, devmode_ctr.devmode);
+                       return update_printer(p, handle, level, info, devmode_ctr.devmode);
                case 3:
                        return update_printer_sec(handle, level, info, p,
                                                  secdesc_ctr);
                default:
-                       return ERROR_INVALID_LEVEL;
+                       return WERR_UNKNOWN_LEVEL;
        }
 }
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_fcpn(POLICY_HND *handle)
+
+WERROR _spoolss_fcpn(pipes_struct *p, SPOOL_Q_FCPN *q_u, SPOOL_R_FCPN *r_u)
 {
-       Printer_entry *Printer= find_printer_index_by_hnd(handle);
+       POLICY_HND *handle = &q_u->handle;
+
+       Printer_entry *Printer= find_printer_index_by_hnd(p, handle);
        
-       if (!OPEN_HANDLE(Printer)) {
+       if (!Printer) {
                DEBUG(0,("_spoolss_fcpn: Invalid handle (%s)\n", OUR_HANDLE(handle)));
-               return ERROR_INVALID_HANDLE;
+               return WERR_BADFID;
        }
 
        if (Printer->notify.client_connected==True)
-               if(!srv_spoolss_replycloseprinter(&Printer->notify.client_hnd))
-                       return ERROR_INVALID_HANDLE;
+               srv_spoolss_replycloseprinter(&Printer->notify.client_hnd);
 
        Printer->notify.flags=0;
        Printer->notify.options=0;
        Printer->notify.localmachine[0]='\0';
        Printer->notify.printerlocal=0;
        if (Printer->notify.option)
-               safe_free(Printer->notify.option->ctr.type);
-       safe_free(Printer->notify.option);
-       Printer->notify.option=NULL;
+               free_spool_notify_option(&Printer->notify.option);
        Printer->notify.client_connected=False;
 
-       return NT_STATUS_NO_PROBLEMO;
+       return WERR_OK;
 }
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_addjob(POLICY_HND *handle, uint32 level,
-                      NEW_BUFFER *buffer, uint32 offered,
-                      uint32 *needed)
+
+WERROR _spoolss_addjob(pipes_struct *p, SPOOL_Q_ADDJOB *q_u, SPOOL_R_ADDJOB *r_u)
 {
-       *needed = 0;
-       return ERROR_INVALID_PARAMETER; /* this is what a NT server
+       /* that's an [in out] buffer (despite appearences to the contrary) */
+       spoolss_move_buffer(q_u->buffer, &r_u->buffer);
+
+       r_u->needed = 0;
+       return WERR_INVALID_PARAM; /* this is what a NT server
                                            returns for AddJob. AddJob
                                            must fail on non-local
                                            printers */
@@ -4040,7 +4831,7 @@ static void fill_job_info_1(JOB_INFO_1 *job_info, print_queue_struct *queue,
        struct tm *t;
        
        t=gmtime(&queue->time);
-       snprintf(temp_name, sizeof(temp_name), "\\\\%s", global_myname);
+       slprintf(temp_name, sizeof(temp_name)-1, "\\\\%s", get_called_name());
 
        job_info->jobid=queue->job;     
        init_unistr(&job_info->printername, lp_servicename(snum));
@@ -4061,22 +4852,19 @@ static void fill_job_info_1(JOB_INFO_1 *job_info, print_queue_struct *queue,
 /****************************************************************************
 ****************************************************************************/
 static BOOL fill_job_info_2(JOB_INFO_2 *job_info, print_queue_struct *queue,
-                            int position, int snum)
+                            int position, int snum, 
+                           NT_PRINTER_INFO_LEVEL *ntprinter)
 {
        pstring temp_name;
-       NT_PRINTER_INFO_LEVEL *ntprinter = NULL;
        pstring chaine;
        struct tm *t;
 
-       if (get_a_printer(&ntprinter, 2, lp_servicename(snum)) !=0 )
-               return False;
-       
        t=gmtime(&queue->time);
-       snprintf(temp_name, sizeof(temp_name), "\\\\%s", global_myname);
+       slprintf(temp_name, sizeof(temp_name)-1, "\\\\%s", get_called_name());
 
        job_info->jobid=queue->job;
        
-       snprintf(chaine, sizeof(chaine)-1, "\\\\%s\\%s", global_myname, ntprinter->info_2->printername);
+       slprintf(chaine, sizeof(chaine)-1, "\\\\%s\\%s", get_called_name(), ntprinter->info_2->printername);
 
        init_unistr(&job_info->printername, chaine);
        
@@ -4104,18 +4892,16 @@ static BOOL fill_job_info_2(JOB_INFO_2 *job_info, print_queue_struct *queue,
        job_info->pagesprinted=0;
 
        if((job_info->devmode = construct_dev_mode(snum)) == NULL) {
-               free_a_printer(&ntprinter, 2);
                return False;
        }
 
-       free_a_printer(&ntprinter, 2);
        return (True);
 }
 
 /****************************************************************************
  Enumjobs at level 1.
 ****************************************************************************/
-static uint32 enumjobs_level1(print_queue_struct *queue, int snum,
+static WERROR enumjobs_level1(print_queue_struct *queue, int snum,
                              NEW_BUFFER *buffer, uint32 offered,
                              uint32 *needed, uint32 *returned)
 {
@@ -4124,113 +4910,134 @@ static uint32 enumjobs_level1(print_queue_struct *queue, int snum,
        
        info=(JOB_INFO_1 *)malloc(*returned*sizeof(JOB_INFO_1));
        if (info==NULL) {
-               safe_free(queue);
+               SAFE_FREE(queue);
                *returned=0;
-               return ERROR_NOT_ENOUGH_MEMORY;
+               return WERR_NOMEM;
        }
        
        for (i=0; i<*returned; i++)
                fill_job_info_1(&info[i], &queue[i], i, snum);
 
-       safe_free(queue);
+       SAFE_FREE(queue);
 
        /* check the required size. */  
        for (i=0; i<*returned; i++)
                (*needed) += spoolss_size_job_info_1(&info[i]);
 
        if (!alloc_buffer_size(buffer, *needed)) {
-               safe_free(info);
-               return ERROR_INSUFFICIENT_BUFFER;
+               SAFE_FREE(info);
+               return WERR_INSUFFICIENT_BUFFER;
        }
 
        /* fill the buffer with the structures */
        for (i=0; i<*returned; i++)
-               new_smb_io_job_info_1("", buffer, &info[i], 0); 
+               smb_io_job_info_1("", buffer, &info[i], 0);     
 
        /* clear memory */
-       safe_free(info);
+       SAFE_FREE(info);
 
        if (*needed > offered) {
                *returned=0;
-               return ERROR_INSUFFICIENT_BUFFER;
+               return WERR_INSUFFICIENT_BUFFER;
        }
-       else
-               return NT_STATUS_NO_PROBLEMO;
+
+       return WERR_OK;
 }
 
 /****************************************************************************
  Enumjobs at level 2.
 ****************************************************************************/
-static uint32 enumjobs_level2(print_queue_struct *queue, int snum,
+static WERROR enumjobs_level2(print_queue_struct *queue, int snum,
                              NEW_BUFFER *buffer, uint32 offered,
                              uint32 *needed, uint32 *returned)
 {
+       NT_PRINTER_INFO_LEVEL *ntprinter = NULL;
        JOB_INFO_2 *info;
        int i;
+       WERROR result;
        
        info=(JOB_INFO_2 *)malloc(*returned*sizeof(JOB_INFO_2));
        if (info==NULL) {
-               safe_free(queue);
                *returned=0;
-               return ERROR_NOT_ENOUGH_MEMORY;
+               return WERR_NOMEM;
        }
-       
+
+       result = get_a_printer(&ntprinter, 2, lp_servicename(snum));
+       if (!W_ERROR_IS_OK(result)) {
+               *returned = 0;
+               return result;
+       }
+               
        for (i=0; i<*returned; i++)
-               fill_job_info_2(&(info[i]), &queue[i], i, snum);
+               fill_job_info_2(&(info[i]), &queue[i], i, snum, ntprinter);
 
-       safe_free(queue);
+       free_a_printer(&ntprinter, 2);
+       SAFE_FREE(queue);
 
        /* check the required size. */  
        for (i=0; i<*returned; i++)
                (*needed) += spoolss_size_job_info_2(&info[i]);
 
        if (!alloc_buffer_size(buffer, *needed)) {
-               safe_free(info);
-               return ERROR_INSUFFICIENT_BUFFER;
+               SAFE_FREE(info);
+               return WERR_INSUFFICIENT_BUFFER;
        }
 
        /* fill the buffer with the structures */
        for (i=0; i<*returned; i++)
-               new_smb_io_job_info_2("", buffer, &info[i], 0); 
+               smb_io_job_info_2("", buffer, &info[i], 0);     
 
        /* clear memory */
-       free_job_info_2(info);
+       for (i = 0; i < *returned; i++)
+               free_job_info_2(&info[i]);
+
+       SAFE_FREE(info);
 
        if (*needed > offered) {
                *returned=0;
-               return ERROR_INSUFFICIENT_BUFFER;
+               return WERR_INSUFFICIENT_BUFFER;
        }
-       else
-               return NT_STATUS_NO_PROBLEMO;
+
+       return WERR_OK;
 }
 
 /****************************************************************************
  Enumjobs.
 ****************************************************************************/
-uint32 _spoolss_enumjobs( POLICY_HND *handle, uint32 firstjob, uint32 numofjobs, uint32 level,                 
-                         NEW_BUFFER *buffer, uint32 offered,
-                         uint32 *needed, uint32 *returned)
+
+WERROR _spoolss_enumjobs( pipes_struct *p, SPOOL_Q_ENUMJOBS *q_u, SPOOL_R_ENUMJOBS *r_u)
 {      
+       POLICY_HND *handle = &q_u->handle;
+/*     uint32 firstjob = q_u->firstjob; - notused. */
+/*     uint32 numofjobs = q_u->numofjobs; - notused. */
+       uint32 level = q_u->level;
+       NEW_BUFFER *buffer = NULL;
+       uint32 offered = q_u->offered;
+       uint32 *needed = &r_u->needed;
+       uint32 *returned = &r_u->returned;
+
        int snum;
-       print_queue_struct *queue=NULL;
        print_status_struct prt_status;
+       print_queue_struct *queue=NULL;
 
-       DEBUG(4,("_spoolss_enumjobs\n"));
+       /* that's an [in out] buffer */
+       spoolss_move_buffer(q_u->buffer, &r_u->buffer);
+       buffer = r_u->buffer;
 
-       ZERO_STRUCT(prt_status);
+       DEBUG(4,("_spoolss_enumjobs\n"));
 
        *needed=0;
        *returned=0;
 
-       if (!get_printer_snum(handle, &snum))
-               return ERROR_INVALID_HANDLE;
+       if (!get_printer_snum(p, handle, &snum))
+               return WERR_BADFID;
 
        *returned = print_queue_status(snum, &queue, &prt_status);
        DEBUGADD(4,("count:[%d], status:[%d], [%s]\n", *returned, prt_status.status, prt_status.message));
 
        if (*returned == 0) {
-               safe_free(queue);
-               return NT_STATUS_NO_PROBLEMO;
+               SAFE_FREE(queue);
+               return WERR_OK;
        }
 
        switch (level) {
@@ -4239,37 +5046,41 @@ uint32 _spoolss_enumjobs( POLICY_HND *handle, uint32 firstjob, uint32 numofjobs,
        case 2:
                return enumjobs_level2(queue, snum, buffer, offered, needed, returned);
        default:
-               safe_free(queue);
+               SAFE_FREE(queue);
                *returned=0;
-               return ERROR_INVALID_LEVEL;
+               return WERR_UNKNOWN_LEVEL;
        }
 }
 
-
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_schedulejob( POLICY_HND *handle, uint32 jobid)
+
+WERROR _spoolss_schedulejob( pipes_struct *p, SPOOL_Q_SCHEDULEJOB *q_u, SPOOL_R_SCHEDULEJOB *r_u)
 {
-       return 0x0;
+       return WERR_OK;
 }
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_setjob(POLICY_HND *handle, uint32 jobid, uint32 level,
-                      pipes_struct *p, JOB_INFO *ctr, uint32 command)
+
+WERROR _spoolss_setjob(pipes_struct *p, SPOOL_Q_SETJOB *q_u, SPOOL_R_SETJOB *r_u)
 {
+       POLICY_HND *handle = &q_u->handle;
+       uint32 jobid = q_u->jobid;
+/*     uint32 level = q_u->level; - notused. */
+/*     JOB_INFO *ctr = &q_u->ctr; - notused. */
+       uint32 command = q_u->command;
+
        struct current_user user;
-       print_status_struct prt_status;
-       int snum, errcode = ERROR_INVALID_FUNCTION;
+       int snum;
+       WERROR errcode = WERR_BADFUNC;
                
-       memset(&prt_status, 0, sizeof(prt_status));
-
-       if (!get_printer_snum(handle, &snum)) {
-               return ERROR_INVALID_HANDLE;
+       if (!get_printer_snum(p, handle, &snum)) {
+               return WERR_BADFID;
        }
 
        if (!print_job_exists(jobid)) {
-               return ERROR_INVALID_PRINTER_NAME;
+               return WERR_INVALID_PRINTER_NAME;
        }
 
        get_current_user(&user, p);     
@@ -4278,22 +5089,22 @@ uint32 _spoolss_setjob(POLICY_HND *handle, uint32 jobid, uint32 level,
        case JOB_CONTROL_CANCEL:
        case JOB_CONTROL_DELETE:
                if (print_job_delete(&user, jobid, &errcode)) {
-                       errcode = 0;
+                       errcode = WERR_OK;
                }
                break;
        case JOB_CONTROL_PAUSE:
                if (print_job_pause(&user, jobid, &errcode)) {
-                       errcode = 0;
+                       errcode = WERR_OK;
                }               
                break;
        case JOB_CONTROL_RESTART:
        case JOB_CONTROL_RESUME:
                if (print_job_resume(&user, jobid, &errcode)) {
-                       errcode = 0;
+                       errcode = WERR_OK;
                }
                break;
        default:
-               return ERROR_INVALID_LEVEL;
+               return WERR_UNKNOWN_LEVEL;
        }
 
        return errcode;
@@ -4302,7 +5113,7 @@ uint32 _spoolss_setjob(POLICY_HND *handle, uint32 jobid, uint32 level,
 /****************************************************************************
  Enumerates all printer drivers at level 1.
 ****************************************************************************/
-static uint32 enumprinterdrivers_level1(fstring servername, fstring architecture, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
+static WERROR enumprinterdrivers_level1(fstring servername, fstring architecture, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
        int i;
        int ndrivers;
@@ -4310,7 +5121,7 @@ static uint32 enumprinterdrivers_level1(fstring servername, fstring architecture
        fstring *list = NULL;
 
        NT_PRINTER_DRIVER_INFO_LEVEL driver;
-       DRIVER_INFO_1 *driver_info_1=NULL;
+       DRIVER_INFO_1 *tdi1, *driver_info_1=NULL;
 
        *returned=0;
 
@@ -4322,21 +5133,26 @@ static uint32 enumprinterdrivers_level1(fstring servername, fstring architecture
                DEBUGADD(4,("we have:[%d] drivers in environment [%s] and version [%d]\n", ndrivers, architecture, version));
 
                if(ndrivers == -1)
-                       return ERROR_NOT_ENOUGH_MEMORY;
+                       return WERR_NOMEM;
 
                if(ndrivers != 0) {
-                       if((driver_info_1=(DRIVER_INFO_1 *)Realloc(driver_info_1, (*returned+ndrivers) * sizeof(DRIVER_INFO_1))) == NULL) {
-                               safe_free(list);
-                               return ERROR_NOT_ENOUGH_MEMORY;
+                       if((tdi1=(DRIVER_INFO_1 *)Realloc(driver_info_1, (*returned+ndrivers) * sizeof(DRIVER_INFO_1))) == NULL) {
+                               DEBUG(0,("enumprinterdrivers_level1: failed to enlarge driver info buffer!\n"));
+                               SAFE_FREE(driver_info_1);
+                               SAFE_FREE(list);
+                               return WERR_NOMEM;
                        }
+                       else driver_info_1 = tdi1;
                }
 
                for (i=0; i<ndrivers; i++) {
-                       uint32 status;
+                       WERROR status;
                        DEBUGADD(5,("\tdriver: [%s]\n", list[i]));
                        ZERO_STRUCT(driver);
-                       if ((status = get_a_printer_driver(&driver, 3, list[i], architecture, version)) != 0) {
-                               safe_free(list);
+                       status = get_a_printer_driver(&driver, 3, list[i], 
+                                                     architecture, version);
+                       if (!W_ERROR_IS_OK(status)) {
+                               SAFE_FREE(list);
                                return status;
                        }
                        fill_printer_driver_info_1(&driver_info_1[*returned+i], driver, servername, architecture );             
@@ -4344,7 +5160,7 @@ static uint32 enumprinterdrivers_level1(fstring servername, fstring architecture
                }       
 
                *returned+=ndrivers;
-               safe_free(list);
+               SAFE_FREE(list);
        }
        
        /* check the required size. */
@@ -4354,30 +5170,30 @@ static uint32 enumprinterdrivers_level1(fstring servername, fstring architecture
        }
 
        if (!alloc_buffer_size(buffer, *needed)) {
-               safe_free(driver_info_1);
-               return ERROR_INSUFFICIENT_BUFFER;
+               SAFE_FREE(driver_info_1);
+               return WERR_INSUFFICIENT_BUFFER;
        }
 
-       /* fill the buffer with the form structures */
+       /* fill the buffer with the driver structures */
        for (i=0; i<*returned; i++) {
                DEBUGADD(6,("adding driver [%d] to buffer\n",i));
-               new_smb_io_printer_driver_info_1("", buffer, &driver_info_1[i], 0);
+               smb_io_printer_driver_info_1("", buffer, &driver_info_1[i], 0);
        }
 
-       safe_free(driver_info_1);
+       SAFE_FREE(driver_info_1);
 
        if (*needed > offered) {
                *returned=0;
-               return ERROR_INSUFFICIENT_BUFFER;
+               return WERR_INSUFFICIENT_BUFFER;
        }
-       else
-               return NT_STATUS_NO_PROBLEMO;
+
+       return WERR_OK;
 }
 
 /****************************************************************************
  Enumerates all printer drivers at level 2.
 ****************************************************************************/
-static uint32 enumprinterdrivers_level2(fstring servername, fstring architecture, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
+static WERROR enumprinterdrivers_level2(fstring servername, fstring architecture, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
        int i;
        int ndrivers;
@@ -4385,7 +5201,7 @@ static uint32 enumprinterdrivers_level2(fstring servername, fstring architecture
        fstring *list = NULL;
 
        NT_PRINTER_DRIVER_INFO_LEVEL driver;
-       DRIVER_INFO_2 *driver_info_2=NULL;
+       DRIVER_INFO_2 *tdi2, *driver_info_2=NULL;
 
        *returned=0;
 
@@ -4397,22 +5213,27 @@ static uint32 enumprinterdrivers_level2(fstring servername, fstring architecture
                DEBUGADD(4,("we have:[%d] drivers in environment [%s] and version [%d]\n", ndrivers, architecture, version));
 
                if(ndrivers == -1)
-                       return ERROR_NOT_ENOUGH_MEMORY;
+                       return WERR_NOMEM;
 
                if(ndrivers != 0) {
-                       if((driver_info_2=(DRIVER_INFO_2 *)Realloc(driver_info_2, (*returned+ndrivers) * sizeof(DRIVER_INFO_2))) == NULL) {
-                               safe_free(list);
-                               return ERROR_NOT_ENOUGH_MEMORY;
+                       if((tdi2=(DRIVER_INFO_2 *)Realloc(driver_info_2, (*returned+ndrivers) * sizeof(DRIVER_INFO_2))) == NULL) {
+                               DEBUG(0,("enumprinterdrivers_level2: failed to enlarge driver info buffer!\n"));
+                               SAFE_FREE(driver_info_2);
+                               SAFE_FREE(list);
+                               return WERR_NOMEM;
                        }
+                       else driver_info_2 = tdi2;
                }
                
                for (i=0; i<ndrivers; i++) {
-                       uint32 status;
+                       WERROR status;
 
                        DEBUGADD(5,("\tdriver: [%s]\n", list[i]));
                        ZERO_STRUCT(driver);
-                       if ((status = get_a_printer_driver(&driver, 3, list[i], architecture, version)) != 0) {
-                               safe_free(list);
+                       status = get_a_printer_driver(&driver, 3, list[i], 
+                                                     architecture, version);
+                       if (!W_ERROR_IS_OK(status)) {
+                               SAFE_FREE(list);
                                return status;
                        }
                        fill_printer_driver_info_2(&driver_info_2[*returned+i], driver, servername);            
@@ -4420,7 +5241,7 @@ static uint32 enumprinterdrivers_level2(fstring servername, fstring architecture
                }       
 
                *returned+=ndrivers;
-               safe_free(list);
+               SAFE_FREE(list);
        }
        
        /* check the required size. */
@@ -4430,30 +5251,30 @@ static uint32 enumprinterdrivers_level2(fstring servername, fstring architecture
        }
 
        if (!alloc_buffer_size(buffer, *needed)) {
-               safe_free(driver_info_2);
-               return ERROR_INSUFFICIENT_BUFFER;
+               SAFE_FREE(driver_info_2);
+               return WERR_INSUFFICIENT_BUFFER;
        }
 
        /* fill the buffer with the form structures */
        for (i=0; i<*returned; i++) {
                DEBUGADD(6,("adding driver [%d] to buffer\n",i));
-               new_smb_io_printer_driver_info_2("", buffer, &(driver_info_2[i]), 0);
+               smb_io_printer_driver_info_2("", buffer, &(driver_info_2[i]), 0);
        }
 
-       safe_free(driver_info_2);
+       SAFE_FREE(driver_info_2);
 
        if (*needed > offered) {
                *returned=0;
-               return ERROR_INSUFFICIENT_BUFFER;
+               return WERR_INSUFFICIENT_BUFFER;
        }
-       else
-               return NT_STATUS_NO_PROBLEMO;
+
+       return WERR_OK;
 }
 
 /****************************************************************************
  Enumerates all printer drivers at level 3.
 ****************************************************************************/
-static uint32 enumprinterdrivers_level3(fstring servername, fstring architecture, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
+static WERROR enumprinterdrivers_level3(fstring servername, fstring architecture, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
        int i;
        int ndrivers;
@@ -4461,7 +5282,7 @@ static uint32 enumprinterdrivers_level3(fstring servername, fstring architecture
        fstring *list = NULL;
 
        NT_PRINTER_DRIVER_INFO_LEVEL driver;
-       DRIVER_INFO_3 *driver_info_3=NULL;
+       DRIVER_INFO_3 *tdi3, *driver_info_3=NULL;
 
        *returned=0;
 
@@ -4473,22 +5294,27 @@ static uint32 enumprinterdrivers_level3(fstring servername, fstring architecture
                DEBUGADD(4,("we have:[%d] drivers in environment [%s] and version [%d]\n", ndrivers, architecture, version));
 
                if(ndrivers == -1)
-                       return ERROR_NOT_ENOUGH_MEMORY;
+                       return WERR_NOMEM;
 
                if(ndrivers != 0) {
-                       if((driver_info_3=(DRIVER_INFO_3 *)Realloc(driver_info_3, (*returned+ndrivers) * sizeof(DRIVER_INFO_3))) == NULL) {
-                               safe_free(list);
-                               return ERROR_NOT_ENOUGH_MEMORY;
+                       if((tdi3=(DRIVER_INFO_3 *)Realloc(driver_info_3, (*returned+ndrivers) * sizeof(DRIVER_INFO_3))) == NULL) {
+                               DEBUG(0,("enumprinterdrivers_level3: failed to enlarge driver info buffer!\n"));
+                               SAFE_FREE(driver_info_3);
+                               SAFE_FREE(list);
+                               return WERR_NOMEM;
                        }
+                       else driver_info_3 = tdi3;
                }
 
                for (i=0; i<ndrivers; i++) {
-                       uint32 status;
+                       WERROR status;
 
                        DEBUGADD(5,("\tdriver: [%s]\n", list[i]));
                        ZERO_STRUCT(driver);
-                       if ((status = get_a_printer_driver(&driver, 3, list[i], architecture, version)) != 0) {
-                               safe_free(list);
+                       status = get_a_printer_driver(&driver, 3, list[i], 
+                                                     architecture, version);
+                       if (!W_ERROR_IS_OK(status)) {
+                               SAFE_FREE(list);
                                return status;
                        }
                        fill_printer_driver_info_3(&driver_info_3[*returned+i], driver, servername);            
@@ -4496,7 +5322,7 @@ static uint32 enumprinterdrivers_level3(fstring servername, fstring architecture
                }       
 
                *returned+=ndrivers;
-               safe_free(list);
+               SAFE_FREE(list);
        }
 
        /* check the required size. */
@@ -4506,42 +5332,53 @@ static uint32 enumprinterdrivers_level3(fstring servername, fstring architecture
        }
 
        if (!alloc_buffer_size(buffer, *needed)) {
-               safe_free(driver_info_3);
-               return ERROR_INSUFFICIENT_BUFFER;
+               SAFE_FREE(driver_info_3);
+               return WERR_INSUFFICIENT_BUFFER;
        }
        
        /* fill the buffer with the driver structures */
        for (i=0; i<*returned; i++) {
                DEBUGADD(6,("adding driver [%d] to buffer\n",i));
-               new_smb_io_printer_driver_info_3("", buffer, &driver_info_3[i], 0);
+               smb_io_printer_driver_info_3("", buffer, &driver_info_3[i], 0);
        }
 
        for (i=0; i<*returned; i++)
-               safe_free(driver_info_3[i].dependentfiles);
+               SAFE_FREE(driver_info_3[i].dependentfiles);
        
-       safe_free(driver_info_3);
+       SAFE_FREE(driver_info_3);
        
        if (*needed > offered) {
                *returned=0;
-               return ERROR_INSUFFICIENT_BUFFER;
+               return WERR_INSUFFICIENT_BUFFER;
        }
-       else
-               return NT_STATUS_NO_PROBLEMO;
+
+       return WERR_OK;
 }
 
 /****************************************************************************
  Enumerates all printer drivers.
 ****************************************************************************/
-uint32 _spoolss_enumprinterdrivers( UNISTR2 *name, UNISTR2 *environment, uint32 level,
-                                   NEW_BUFFER *buffer, uint32 offered,
-                                   uint32 *needed, uint32 *returned)
+
+WERROR _spoolss_enumprinterdrivers( pipes_struct *p, SPOOL_Q_ENUMPRINTERDRIVERS *q_u, SPOOL_R_ENUMPRINTERDRIVERS *r_u)
 {
+/*     UNISTR2 *name = &q_u->name; - notused. */
+       UNISTR2 *environment = &q_u->environment;
+       uint32 level = q_u->level;
+       NEW_BUFFER *buffer = NULL;
+       uint32 offered = q_u->offered;
+       uint32 *needed = &r_u->needed;
+       uint32 *returned = &r_u->returned;
+
        fstring *list = NULL;
        fstring servername;
        fstring architecture;
 
+       /* that's an [in out] buffer */
+       spoolss_move_buffer(q_u->buffer, &r_u->buffer);
+       buffer = r_u->buffer;
+
        DEBUG(4,("_spoolss_enumprinterdrivers\n"));
-       fstrcpy(servername, global_myname);
+       fstrcpy(servername, get_called_name());
        *needed=0;
        *returned=0;
 
@@ -4556,13 +5393,14 @@ uint32 _spoolss_enumprinterdrivers( UNISTR2 *name, UNISTR2 *environment, uint32
                return enumprinterdrivers_level3(servername, architecture, buffer, offered, needed, returned);
        default:
                *returned=0;
-               safe_free(list);
-               return ERROR_INVALID_LEVEL;
+               SAFE_FREE(list);
+               return WERR_UNKNOWN_LEVEL;
        }
 }
 
 /****************************************************************************
 ****************************************************************************/
+
 static void fill_form_1(FORM_1 *form, nt_forms_struct *list)
 {
        form->flag=list->flag;
@@ -4577,41 +5415,67 @@ static void fill_form_1(FORM_1 *form, nt_forms_struct *list)
        
 /****************************************************************************
 ****************************************************************************/
-uint32 _new_spoolss_enumforms( POLICY_HND *handle, uint32 level,
-                              NEW_BUFFER *buffer, uint32 offered,
-                              uint32 *needed, uint32 *numofforms)
+
+WERROR _spoolss_enumforms(pipes_struct *p, SPOOL_Q_ENUMFORMS *q_u, SPOOL_R_ENUMFORMS *r_u)
 {
+/*     POLICY_HND *handle = &q_u->handle; - notused. */
+       uint32 level = q_u->level;
+       NEW_BUFFER *buffer = NULL;
+       uint32 offered = q_u->offered;
+       uint32 *needed = &r_u->needed;
+       uint32 *numofforms = &r_u->numofforms;
+       uint32 numbuiltinforms;
+
        nt_forms_struct *list=NULL;
+       nt_forms_struct *builtinlist=NULL;
        FORM_1 *forms_1;
        int buffer_size=0;
        int i;
 
-       DEBUG(4,("_new_spoolss_enumforms\n"));
+       /* that's an [in out] buffer */
+       spoolss_move_buffer(q_u->buffer, &r_u->buffer);
+       buffer = r_u->buffer;
+
+       DEBUG(4,("_spoolss_enumforms\n"));
        DEBUGADD(5,("Offered buffer size [%d]\n", offered));
        DEBUGADD(5,("Info level [%d]\n",          level));
 
+       numbuiltinforms = get_builtin_ntforms(&builtinlist);
+       DEBUGADD(5,("Number of builtin forms [%d]\n",     numbuiltinforms));
        *numofforms = get_ntforms(&list);
-       DEBUGADD(5,("Number of forms [%d]\n",     *numofforms));
+       DEBUGADD(5,("Number of user forms [%d]\n",     *numofforms));
+       *numofforms += numbuiltinforms;
 
-       if (*numofforms == 0) return ERROR_NO_MORE_ITEMS;
+       if (*numofforms == 0) return WERR_NO_MORE_ITEMS;
 
        switch (level) {
        case 1:
                if ((forms_1=(FORM_1 *)malloc(*numofforms * sizeof(FORM_1))) == NULL) {
                        *numofforms=0;
-                       return ERROR_NOT_ENOUGH_MEMORY;
+                       return WERR_NOMEM;
                }
 
                /* construct the list of form structures */
-               for (i=0; i<*numofforms; i++) {
+               for (i=0; i<numbuiltinforms; i++) {
+                       DEBUGADD(6,("Filling form number [%d]\n",i));
+                       fill_form_1(&forms_1[i], &builtinlist[i]);
+               }
+               
+               SAFE_FREE(builtinlist);
+
+               for (; i<*numofforms; i++) {
                        DEBUGADD(6,("Filling form number [%d]\n",i));
-                       fill_form_1(&forms_1[i], &list[i]);
+                       fill_form_1(&forms_1[i], &list[i-numbuiltinforms]);
                }
                
-               safe_free(list);
+               SAFE_FREE(list);
 
                /* check the required size. */
-               for (i=0; i<*numofforms; i++) {
+               for (i=0; i<numbuiltinforms; i++) {
+                       DEBUGADD(6,("adding form [%d]'s size\n",i));
+                       buffer_size += spoolss_size_form_1(&forms_1[i]);
+               }
+               for (; i<*numofforms; i++) {
                        DEBUGADD(6,("adding form [%d]'s size\n",i));
                        buffer_size += spoolss_size_form_1(&forms_1[i]);
                }
@@ -4619,41 +5483,60 @@ uint32 _new_spoolss_enumforms( POLICY_HND *handle, uint32 level,
                *needed=buffer_size;            
                
                if (!alloc_buffer_size(buffer, buffer_size)){
-                       safe_free(forms_1);
-                       return ERROR_INSUFFICIENT_BUFFER;
+                       SAFE_FREE(forms_1);
+                       return WERR_INSUFFICIENT_BUFFER;
                }
 
                /* fill the buffer with the form structures */
-               for (i=0; i<*numofforms; i++) {
+               for (i=0; i<numbuiltinforms; i++) {
+                       DEBUGADD(6,("adding form [%d] to buffer\n",i));
+                       smb_io_form_1("", buffer, &forms_1[i], 0);
+               }
+               for (; i<*numofforms; i++) {
                        DEBUGADD(6,("adding form [%d] to buffer\n",i));
-                       new_smb_io_form_1("", buffer, &forms_1[i], 0);
+                       smb_io_form_1("", buffer, &forms_1[i], 0);
                }
 
-               safe_free(forms_1);
+               SAFE_FREE(forms_1);
 
                if (*needed > offered) {
                        *numofforms=0;
-                       return ERROR_INSUFFICIENT_BUFFER;
+                       return WERR_INSUFFICIENT_BUFFER;
                }
                else
-                       return NT_STATUS_NO_PROBLEMO;
+                       return WERR_OK;
                        
        default:
-               safe_free(list);
-               return ERROR_INVALID_LEVEL;
+               SAFE_FREE(list);
+               SAFE_FREE(builtinlist);
+               return WERR_UNKNOWN_LEVEL;
        }
 
 }
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_getform( POLICY_HND *handle, uint32 level, UNISTR2 *uni_formname, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
+
+WERROR _spoolss_getform(pipes_struct *p, SPOOL_Q_GETFORM *q_u, SPOOL_R_GETFORM *r_u)
 {
+/*     POLICY_HND *handle = &q_u->handle; - notused. */
+       uint32 level = q_u->level;
+       UNISTR2 *uni_formname = &q_u->formname;
+       NEW_BUFFER *buffer = NULL;
+       uint32 offered = q_u->offered;
+       uint32 *needed = &r_u->needed;
+
        nt_forms_struct *list=NULL;
+       nt_forms_struct builtin_form;
+       BOOL foundBuiltin;
        FORM_1 form_1;
        fstring form_name;
        int buffer_size=0;
-       int numofforms, i;
+       int numofforms=0, i=0;
+
+       /* that's an [in out] buffer */
+       spoolss_move_buffer(q_u->buffer, &r_u->buffer);
+       buffer = r_u->buffer;
 
        unistr2_to_ascii(form_name, uni_formname, sizeof(form_name)-1);
 
@@ -4661,50 +5544,59 @@ uint32 _spoolss_getform( POLICY_HND *handle, uint32 level, UNISTR2 *uni_formname
        DEBUGADD(5,("Offered buffer size [%d]\n", offered));
        DEBUGADD(5,("Info level [%d]\n",          level));
 
-       numofforms = get_ntforms(&list);
-       DEBUGADD(5,("Number of forms [%d]\n",     numofforms));
+       foundBuiltin = get_a_builtin_ntform(uni_formname,&builtin_form);
+       if (!foundBuiltin) {
+               numofforms = get_ntforms(&list);
+               DEBUGADD(5,("Number of forms [%d]\n",     numofforms));
 
-       if (numofforms == 0)
-               return ERROR_NO_MORE_ITEMS;
+               if (numofforms == 0)
+                       return WERR_BADFID;
+       }
 
        switch (level) {
        case 1:
+               if (foundBuiltin) {
+                       fill_form_1(&form_1, &builtin_form);
+               } else {
 
-               /* Check if the requested name is in the list of form structures */
-               for (i=0; i<numofforms; i++) {
+                       /* Check if the requested name is in the list of form structures */
+                       for (i=0; i<numofforms; i++) {
 
-                       DEBUG(4,("_spoolss_getform: checking form %s (want %s)\n", list[i].name, form_name));
+                               DEBUG(4,("_spoolss_getform: checking form %s (want %s)\n", list[i].name, form_name));
 
-                       if (strequal(form_name, list[i].name)) {
-                               DEBUGADD(6,("Found form %s number [%d]\n", form_name, i));
-                               fill_form_1(&form_1, &list[i]);
-                               break;
+                               if (strequal(form_name, list[i].name)) {
+                                       DEBUGADD(6,("Found form %s number [%d]\n", form_name, i));
+                                       fill_form_1(&form_1, &list[i]);
+                                       break;
+                               }
+                       }
+                       
+                       SAFE_FREE(list);
+                       if (i == numofforms) {
+                               return WERR_BADFID;
                        }
                }
-               
-               safe_free(list);
-
                /* check the required size. */
 
                *needed=spoolss_size_form_1(&form_1);
                
                if (!alloc_buffer_size(buffer, buffer_size)){
-                       return ERROR_INSUFFICIENT_BUFFER;
+                       return WERR_INSUFFICIENT_BUFFER;
                }
 
                if (*needed > offered) {
-                       return ERROR_INSUFFICIENT_BUFFER;
+                       return WERR_INSUFFICIENT_BUFFER;
                }
 
                /* fill the buffer with the form structures */
                DEBUGADD(6,("adding form %s [%d] to buffer\n", form_name, i));
-               new_smb_io_form_1("", buffer, &form_1, 0);
+               smb_io_form_1("", buffer, &form_1, 0);
 
-               return NT_STATUS_NO_PROBLEMO;
+               return WERR_OK;
                        
        default:
-               safe_free(list);
-               return ERROR_INVALID_LEVEL;
+               SAFE_FREE(list);
+               return WERR_UNKNOWN_LEVEL;
        }
 }
 
@@ -4730,50 +5622,42 @@ static void fill_port_2(PORT_INFO_2 *port, char *name)
 /****************************************************************************
  enumports level 1.
 ****************************************************************************/
-static uint32 enumports_level_1(NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
+static WERROR enumports_level_1(NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
        PORT_INFO_1 *ports=NULL;
        int i=0;
 
        if (*lp_enumports_cmd()) {
-               pid_t local_pid = sys_getpid();
                char *cmd = lp_enumports_cmd();
-               char *path;
                char **qlines;
-               pstring tmp_file;
                pstring command;
                int numlines;
                int ret;
+               int fd;
 
-               if (*lp_pathname(lp_servicenumber(PRINTERS_NAME)))
-                       path = lp_pathname(lp_servicenumber(PRINTERS_NAME));
-               else
-                       path = tmpdir();
-
-               slprintf(tmp_file, sizeof(tmp_file), "%s/smbcmd.%d", path, local_pid);
-               slprintf(command, sizeof(command), "%s \"%d\"", cmd, 1);
+               slprintf(command, sizeof(command)-1, "%s \"%d\"", cmd, 1);
 
-               unlink(tmp_file);
-               DEBUG(10,("Running [%s > %s]\n", command,tmp_file));
-               ret = smbrun(command, tmp_file, False);
+               DEBUG(10,("Running [%s]\n", command));
+               ret = smbrun(command, &fd);
                DEBUG(10,("Returned [%d]\n", ret));
                if (ret != 0) {
-                       unlink(tmp_file);
+                       if (fd != -1)
+                               close(fd);
                        /* Is this the best error to return here? */
-                       return ERROR_ACCESS_DENIED;
+                       return WERR_ACCESS_DENIED;
                }
 
                numlines = 0;
-               qlines = file_lines_load(tmp_file, &numlines,True);
+               qlines = fd_lines_load(fd, &numlines);
                DEBUGADD(10,("Lines returned = [%d]\n", numlines));
-               DEBUGADD(10,("Unlinking port file [%s]\n", tmp_file));
-               unlink(tmp_file);
+               close(fd);
 
                if(numlines) {
                        if((ports=(PORT_INFO_1 *)malloc( numlines * sizeof(PORT_INFO_1) )) == NULL) {
-                               DEBUG(10,("Returning ERROR_NOT_ENOUGH_MEMORY [%x]\n", ERROR_NOT_ENOUGH_MEMORY));
+                               DEBUG(10,("Returning WERR_NOMEM [%s]\n", 
+                                         werror_str(WERR_NOMEM)));
                                file_lines_free(qlines);
-                               return ERROR_NOT_ENOUGH_MEMORY;
+                               return WERR_NOMEM;
                        }
 
                        for (i=0; i<numlines; i++) {
@@ -4790,7 +5674,7 @@ static uint32 enumports_level_1(NEW_BUFFER *buffer, uint32 offered, uint32 *need
                *returned = 1; /* Sole Samba port returned. */
 
                if((ports=(PORT_INFO_1 *)malloc( sizeof(PORT_INFO_1) )) == NULL)
-                       return ERROR_NOT_ENOUGH_MEMORY;
+                       return WERR_NOMEM;
        
                DEBUG(10,("enumports_level_1: port name %s\n", SAMBA_PRINTER_PORT_NAME));
 
@@ -4804,37 +5688,36 @@ static uint32 enumports_level_1(NEW_BUFFER *buffer, uint32 offered, uint32 *need
        }
                
        if (!alloc_buffer_size(buffer, *needed)) {
-               safe_free(ports);
-               return ERROR_INSUFFICIENT_BUFFER;
+               SAFE_FREE(ports);
+               return WERR_INSUFFICIENT_BUFFER;
        }
 
        /* fill the buffer with the ports structures */
        for (i=0; i<*returned; i++) {
                DEBUGADD(6,("adding port [%d] to buffer\n", i));
-               new_smb_io_port_1("", buffer, &ports[i], 0);
+               smb_io_port_1("", buffer, &ports[i], 0);
        }
 
-       safe_free(ports);
+       SAFE_FREE(ports);
 
        if (*needed > offered) {
                *returned=0;
-               return ERROR_INSUFFICIENT_BUFFER;
+               return WERR_INSUFFICIENT_BUFFER;
        }
-       else
-               return NT_STATUS_NO_PROBLEMO;
+
+       return WERR_OK;
 }
 
 /****************************************************************************
  enumports level 2.
 ****************************************************************************/
 
-static uint32 enumports_level_2(NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
+static WERROR enumports_level_2(NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
        PORT_INFO_2 *ports=NULL;
        int i=0;
 
        if (*lp_enumports_cmd()) {
-               pid_t local_pid = sys_getpid();
                char *cmd = lp_enumports_cmd();
                char *path;
                char **qlines;
@@ -4842,36 +5725,36 @@ static uint32 enumports_level_2(NEW_BUFFER *buffer, uint32 offered, uint32 *need
                pstring command;
                int numlines;
                int ret;
+               int fd;
 
                if (*lp_pathname(lp_servicenumber(PRINTERS_NAME)))
                        path = lp_pathname(lp_servicenumber(PRINTERS_NAME));
                else
-                       path = tmpdir();
+                       path = lp_lockdir();
 
-               slprintf(tmp_file, sizeof(tmp_file), "%s/smbcmd.%d", path, local_pid);
-               slprintf(command, sizeof(command), "%s \"%d\"", cmd, 2);
+               slprintf(tmp_file, sizeof(tmp_file)-1, "%s/smbcmd.%u.", path, (unsigned int)sys_getpid());
+               slprintf(command, sizeof(command)-1, "%s \"%d\"", cmd, 2);
 
                unlink(tmp_file);
                DEBUG(10,("Running [%s > %s]\n", command,tmp_file));
-               ret = smbrun(command, tmp_file, False);
+               ret = smbrun(command, &fd);
                DEBUGADD(10,("returned [%d]\n", ret));
                if (ret != 0) {
-                       unlink(tmp_file);
+                       if (fd != -1)
+                               close(fd);
                        /* Is this the best error to return here? */
-                       return ERROR_ACCESS_DENIED;
+                       return WERR_ACCESS_DENIED;
                }
 
                numlines = 0;
-               qlines = file_lines_load(tmp_file, &numlines,True);
+               qlines = fd_lines_load(fd, &numlines);
                DEBUGADD(10,("Lines returned = [%d]\n", numlines));
-               DEBUGADD(10,("Unlinking port file [%s]\n", tmp_file));
-               unlink(tmp_file);
+               close(fd);
 
                if(numlines) {
                        if((ports=(PORT_INFO_2 *)malloc( numlines * sizeof(PORT_INFO_2) )) == NULL) {
-                               DEBUG(10,("Returning ERROR_NOT_ENOUGH_MEMORY [%x]\n", ERROR_NOT_ENOUGH_MEMORY));
                                file_lines_free(qlines);
-                               return ERROR_NOT_ENOUGH_MEMORY;
+                               return WERR_NOMEM;
                        }
 
                        for (i=0; i<numlines; i++) {
@@ -4889,7 +5772,7 @@ static uint32 enumports_level_2(NEW_BUFFER *buffer, uint32 offered, uint32 *need
                *returned = 1;
 
                if((ports=(PORT_INFO_2 *)malloc( sizeof(PORT_INFO_2) )) == NULL)
-                       return ERROR_NOT_ENOUGH_MEMORY;
+                       return WERR_NOMEM;
        
                DEBUG(10,("enumports_level_2: port name %s\n", SAMBA_PRINTER_PORT_NAME));
 
@@ -4903,33 +5786,43 @@ static uint32 enumports_level_2(NEW_BUFFER *buffer, uint32 offered, uint32 *need
        }
                
        if (!alloc_buffer_size(buffer, *needed)) {
-               safe_free(ports);
-               return ERROR_INSUFFICIENT_BUFFER;
+               SAFE_FREE(ports);
+               return WERR_INSUFFICIENT_BUFFER;
        }
 
        /* fill the buffer with the ports structures */
        for (i=0; i<*returned; i++) {
                DEBUGADD(6,("adding port [%d] to buffer\n", i));
-               new_smb_io_port_2("", buffer, &ports[i], 0);
+               smb_io_port_2("", buffer, &ports[i], 0);
        }
 
-       safe_free(ports);
+       SAFE_FREE(ports);
 
        if (*needed > offered) {
                *returned=0;
-               return ERROR_INSUFFICIENT_BUFFER;
+               return WERR_INSUFFICIENT_BUFFER;
        }
-       else
-               return NT_STATUS_NO_PROBLEMO;
+
+       return WERR_OK;
 }
 
 /****************************************************************************
  enumports.
 ****************************************************************************/
-uint32 _spoolss_enumports( UNISTR2 *name, uint32 level,
-                          NEW_BUFFER *buffer, uint32 offered,
-                          uint32 *needed, uint32 *returned)
+
+WERROR _spoolss_enumports( pipes_struct *p, SPOOL_Q_ENUMPORTS *q_u, SPOOL_R_ENUMPORTS *r_u)
 {
+/*     UNISTR2 *name = &q_u->name; - notused. */
+       uint32 level = q_u->level;
+       NEW_BUFFER *buffer = NULL;
+       uint32 offered = q_u->offered;
+       uint32 *needed = &r_u->needed;
+       uint32 *returned = &r_u->returned;
+
+       /* that's an [in out] buffer */
+       spoolss_move_buffer(q_u->buffer, &r_u->buffer);
+       buffer = r_u->buffer;
+
        DEBUG(4,("_spoolss_enumports\n"));
        
        *returned=0;
@@ -4941,50 +5834,63 @@ uint32 _spoolss_enumports( UNISTR2 *name, uint32 level,
        case 2:
                return enumports_level_2(buffer, offered, needed, returned);
        default:
-               return ERROR_INVALID_LEVEL;
+               return WERR_UNKNOWN_LEVEL;
        }
 }
 
 /****************************************************************************
 ****************************************************************************/
-static uint32 spoolss_addprinterex_level_2( const UNISTR2 *uni_srv_name,
+static WERROR spoolss_addprinterex_level_2( pipes_struct *p, const UNISTR2 *uni_srv_name,
                                const SPOOL_PRINTER_INFO_LEVEL *info,
-                               uint32 unk0, uint32 unk1, uint32 unk2, uint32 unk3,
+                               DEVICEMODE *devmode, SEC_DESC_BUF *sec_desc_buf,
                                uint32 user_switch, const SPOOL_USER_CTR *user,
                                POLICY_HND *handle)
 {
        NT_PRINTER_INFO_LEVEL *printer = NULL;
-       fstring name;
-       int snum;
+       fstring name;
+       int     snum;
+       WERROR err = WERR_OK;
 
        if ((printer = (NT_PRINTER_INFO_LEVEL *)malloc(sizeof(NT_PRINTER_INFO_LEVEL))) == NULL) {
                DEBUG(0,("spoolss_addprinterex_level_2: malloc fail.\n"));
-               return ERROR_NOT_ENOUGH_MEMORY;
+               return WERR_NOMEM;
        }
 
        ZERO_STRUCTP(printer);
 
        /* convert from UNICODE to ASCII - this allocates the info_2 struct inside *printer.*/
-       convert_printer_info(info, printer, 2);
+       if (!convert_printer_info(info, printer, 2)) {
+               free_a_printer(&printer, 2);
+               return WERR_NOMEM;
+       }
+
+       /* check to see if the printer already exists */
+
+       if ((snum = print_queue_snum(printer->info_2->sharename)) != -1) {
+               DEBUG(5, ("_spoolss_addprinterex: Attempted to add a printer named [%s] when one already existed!\n", 
+                       printer->info_2->sharename));
+               free_a_printer(&printer, 2);
+               return WERR_PRINTER_ALREADY_EXISTS;
+       }
 
        if (*lp_addprinter_cmd() )
                if ( !add_printer_hook(printer) ) {
                        free_a_printer(&printer,2);
-                       return ERROR_ACCESS_DENIED;
+                       return WERR_ACCESS_DENIED;
        }
 
-       slprintf(name, sizeof(name)-1, "\\\\%s\\%s", global_myname,
+       slprintf(name, sizeof(name)-1, "\\\\%s\\%s", get_called_name(),
              printer->info_2->sharename);
 
        if ((snum = print_queue_snum(printer->info_2->sharename)) == -1) {
                free_a_printer(&printer,2);
-               return ERROR_ACCESS_DENIED;
+               return WERR_ACCESS_DENIED;
        }
 
        /* you must be a printer admin to add a new printer */
        if (!print_access_check(NULL, snum, PRINTER_ACCESS_ADMINISTER)) {
                free_a_printer(&printer,2);
-               return ERROR_ACCESS_DENIED;             
+               return WERR_ACCESS_DENIED;              
        }
        
        /*
@@ -4993,57 +5899,74 @@ static uint32 spoolss_addprinterex_level_2( const UNISTR2 *uni_srv_name,
 
        if (!check_printer_ok(printer->info_2, snum)) {
                free_a_printer(&printer,2);
-               return ERROR_INVALID_PARAMETER;
+               return WERR_INVALID_PARAM;
        }
 
+    /*
+        * When a printer is created, the drivername bound to the printer is used
+        * to lookup previously saved driver initialization info, which is then 
+        * bound to the new printer, simulating what happens in the Windows arch.
+        */
+       set_driver_init(printer, 2);
+       
        /* write the ASCII on disk */
-       if (add_a_printer(*printer, 2) != 0) {
+       err = mod_a_printer(*printer, 2);
+       if (!W_ERROR_IS_OK(err)) {
                free_a_printer(&printer,2);
-               return ERROR_ACCESS_DENIED;
+               return err;
        }
 
-       if (!open_printer_hnd(handle, name)) {
+       if (!open_printer_hnd(p, handle, name)) {
                /* Handle open failed - remove addition. */
                del_a_printer(printer->info_2->sharename);
                free_a_printer(&printer,2);
-               return ERROR_ACCESS_DENIED;
+               return WERR_ACCESS_DENIED;
        }
 
        free_a_printer(&printer,2);
 
-       srv_spoolss_sendnotify(handle);
+       srv_spoolss_sendnotify(p, handle);
 
-       return NT_STATUS_NO_PROBLEMO;
+       return WERR_OK;
 }
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_addprinterex( const UNISTR2 *uni_srv_name, uint32 level,
-                               const SPOOL_PRINTER_INFO_LEVEL *info,
-                               uint32 unk0, uint32 unk1, uint32 unk2, uint32 unk3,
-                               uint32 user_switch, const SPOOL_USER_CTR *user,
-                               POLICY_HND *handle)
+
+WERROR _spoolss_addprinterex( pipes_struct *p, SPOOL_Q_ADDPRINTEREX *q_u, SPOOL_R_ADDPRINTEREX *r_u)
 {
+       UNISTR2 *uni_srv_name = &q_u->server_name;
+       uint32 level = q_u->level;
+       SPOOL_PRINTER_INFO_LEVEL *info = &q_u->info;
+       DEVICEMODE *devmode = q_u->devmode_ctr.devmode;
+       SEC_DESC_BUF *sdb = q_u->secdesc_ctr;
+       uint32 user_switch = q_u->user_switch;
+       SPOOL_USER_CTR *user = &q_u->user_ctr;
+       POLICY_HND *handle = &r_u->handle;
+
        switch (level) {
                case 1:
                        /* we don't handle yet */
                        /* but I know what to do ... */
-                       return ERROR_INVALID_LEVEL;
+                       return WERR_UNKNOWN_LEVEL;
                case 2:
-                       return spoolss_addprinterex_level_2(uni_srv_name, info,
-                                                           unk0, unk1, unk2, unk3,
+                       return spoolss_addprinterex_level_2(p, uni_srv_name, info,
+                                                           devmode, sdb,
                                                            user_switch, user, handle);
                default:
-                       return ERROR_INVALID_LEVEL;
+                       return WERR_UNKNOWN_LEVEL;
        }
 }
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_addprinterdriver(pipes_struct *p, const UNISTR2 *server_name,
-                                uint32 level, const SPOOL_PRINTER_DRIVER_INFO_LEVEL *info)
+
+WERROR _spoolss_addprinterdriver(pipes_struct *p, SPOOL_Q_ADDPRINTERDRIVER *q_u, SPOOL_R_ADDPRINTERDRIVER *r_u)
 {
-       uint32 err = NT_STATUS_NO_PROBLEMO;
+/*     UNISTR2 *server_name = &q_u->server_name; - notused. */
+       uint32 level = q_u->level;
+       SPOOL_PRINTER_DRIVER_INFO_LEVEL *info = &q_u->info;
+       WERROR err = WERR_OK;
        NT_PRINTER_DRIVER_INFO_LEVEL driver;
        struct current_user user;
        
@@ -5051,21 +5974,25 @@ uint32 _spoolss_addprinterdriver(pipes_struct *p, const UNISTR2 *server_name,
 
        get_current_user(&user, p);     
        
-       convert_printer_driver_info(info, &driver, level);
+       if (!convert_printer_driver_info(info, &driver, level)) {
+               err = WERR_NOMEM;
+               goto done;
+       }
 
        DEBUG(5,("Cleaning driver's information\n"));
-       if ((err = clean_up_driver_struct(driver, level, &user)) != NT_STATUS_NO_PROBLEMO )
+       err = clean_up_driver_struct(driver, level, &user);
+       if (!W_ERROR_IS_OK(err))
                goto done;
 
        DEBUG(5,("Moving driver to final destination\n"));
        if(!move_driver_to_download_area(driver, level, &user, &err)) {
-               if (err == 0)
-                       err = ERROR_ACCESS_DENIED;
+               if (W_ERROR_IS_OK(err))
+                       err = WERR_ACCESS_DENIED;
                goto done;
        }
 
        if (add_a_printer_driver(driver, level)!=0) {
-               err = ERROR_ACCESS_DENIED;
+               err = WERR_ACCESS_DENIED;
                goto done;
        }
 
@@ -5083,7 +6010,7 @@ static void fill_driverdir_1(DRIVER_DIRECTORY_1 *info, char *name)
 
 /****************************************************************************
 ****************************************************************************/
-static uint32 getprinterdriverdir_level_1(UNISTR2 *name, UNISTR2 *uni_environment, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
+static WERROR getprinterdriverdir_level_1(UNISTR2 *name, UNISTR2 *uni_environment, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
 {
        pstring path;
        pstring long_archi;
@@ -5092,13 +6019,13 @@ static uint32 getprinterdriverdir_level_1(UNISTR2 *name, UNISTR2 *uni_environmen
 
        unistr2_to_ascii(long_archi, uni_environment, sizeof(long_archi)-1);
 
-       if (get_short_archi(short_archi, long_archi)==FALSE)
-               return ERROR_INVALID_ENVIRONMENT;
+       if (get_short_archi(short_archi, long_archi)==False)
+               return WERR_INVALID_ENVIRONMENT;
 
        if((info=(DRIVER_DIRECTORY_1 *)malloc(sizeof(DRIVER_DIRECTORY_1))) == NULL)
-               return ERROR_NOT_ENOUGH_MEMORY;
+               return WERR_NOMEM;
 
-       slprintf(path, sizeof(path)-1, "\\\\%s\\print$\\%s", global_myname, short_archi);
+       slprintf(path, sizeof(path)-1, "\\\\%s\\print$\\%s", get_called_name(), short_archi);
 
        DEBUG(4,("printer driver directory: [%s]\n", path));
 
@@ -5107,26 +6034,36 @@ static uint32 getprinterdriverdir_level_1(UNISTR2 *name, UNISTR2 *uni_environmen
        *needed += spoolss_size_driverdir_info_1(info);
 
        if (!alloc_buffer_size(buffer, *needed)) {
-               safe_free(info);
-               return ERROR_INSUFFICIENT_BUFFER;
+               SAFE_FREE(info);
+               return WERR_INSUFFICIENT_BUFFER;
        }
 
-       new_smb_io_driverdir_1("", buffer, info, 0);
+       smb_io_driverdir_1("", buffer, info, 0);
 
-       safe_free(info);
+       SAFE_FREE(info);
        
        if (*needed > offered)
-               return ERROR_INSUFFICIENT_BUFFER;
-       else
-               return NT_STATUS_NO_PROBLEMO;
+               return WERR_INSUFFICIENT_BUFFER;
+
+       return WERR_OK;
 }
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_getprinterdriverdirectory(UNISTR2 *name, UNISTR2 *uni_environment, uint32 level,
-                                       NEW_BUFFER *buffer, uint32 offered,
-                                       uint32 *needed)
+
+WERROR _spoolss_getprinterdriverdirectory(pipes_struct *p, SPOOL_Q_GETPRINTERDRIVERDIR *q_u, SPOOL_R_GETPRINTERDRIVERDIR *r_u)
 {
+       UNISTR2 *name = &q_u->name;
+       UNISTR2 *uni_environment = &q_u->environment;
+       uint32 level = q_u->level;
+       NEW_BUFFER *buffer = NULL;
+       uint32 offered = q_u->offered;
+       uint32 *needed = &r_u->needed;
+
+       /* that's an [in out] buffer */
+       spoolss_move_buffer(q_u->buffer, &r_u->buffer);
+       buffer = r_u->buffer;
+
        DEBUG(4,("_spoolss_getprinterdriverdirectory\n"));
 
        *needed=0;
@@ -5135,18 +6072,27 @@ uint32 _spoolss_getprinterdriverdirectory(UNISTR2 *name, UNISTR2 *uni_environmen
        case 1:
                return getprinterdriverdir_level_1(name, uni_environment, buffer, offered, needed);
        default:
-               return ERROR_INVALID_LEVEL;
+               return WERR_UNKNOWN_LEVEL;
        }
 }
        
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_enumprinterdata(POLICY_HND *handle, uint32 idx,
-                               uint32 in_value_len, uint32 in_data_len,
-                               uint32 *out_max_value_len, uint16 **out_value, uint32 *out_value_len,
-                               uint32 *out_type,
-                               uint32 *out_max_data_len, uint8  **data_out, uint32 *out_data_len)
+
+WERROR _spoolss_enumprinterdata(pipes_struct *p, SPOOL_Q_ENUMPRINTERDATA *q_u, SPOOL_R_ENUMPRINTERDATA *r_u)
 {
+       POLICY_HND *handle = &q_u->handle;
+       uint32 idx = q_u->index;
+       uint32 in_value_len = q_u->valuesize;
+       uint32 in_data_len = q_u->datasize;
+       uint32 *out_max_value_len = &r_u->valuesize;
+       uint16 **out_value = &r_u->value;
+       uint32 *out_value_len = &r_u->realvaluesize;
+       uint32 *out_type = &r_u->type;
+       uint32 *out_max_data_len = &r_u->datasize;
+       uint8  **data_out = &r_u->data;
+       uint32 *out_data_len = &r_u->realdatasize;
+
        NT_PRINTER_INFO_LEVEL *printer = NULL;
        
        fstring value;
@@ -5155,17 +6101,14 @@ uint32 _spoolss_enumprinterdata(POLICY_HND *handle, uint32 idx,
        uint32 biggest_valuesize;
        uint32 biggest_datasize;
        uint32 data_len;
-       Printer_entry *Printer = find_printer_index_by_hnd(handle);
+       Printer_entry *Printer = find_printer_index_by_hnd(p, handle);
        int snum;
        uint8 *data=NULL;
        uint32 type;
+       WERROR result;
 
        ZERO_STRUCT(printer);
        
-       *out_max_value_len=0;
-       *out_value=NULL;
-       *out_value_len=0;
-
        *out_type=0;
 
        *out_max_data_len=0;
@@ -5174,16 +6117,17 @@ uint32 _spoolss_enumprinterdata(POLICY_HND *handle, uint32 idx,
 
        DEBUG(5,("spoolss_enumprinterdata\n"));
 
-       if (!OPEN_HANDLE(Printer)) {
+       if (!Printer) {
                DEBUG(0,("_spoolss_enumprinterdata: Invalid handle (%s).\n", OUR_HANDLE(handle)));
-               return ERROR_INVALID_HANDLE;
+               return WERR_BADFID;
        }
 
-       if (!get_printer_snum(handle, &snum))
-               return ERROR_INVALID_HANDLE;
+       if (!get_printer_snum(p,handle, &snum))
+               return WERR_BADFID;
        
-       if (get_a_printer(&printer, 2, lp_servicename(snum)) != 0)
-               return ERROR_INVALID_HANDLE;
+       result = get_a_printer(&printer, 2, lp_servicename(snum));
+       if (!W_ERROR_IS_OK(result))
+               return result;
 
        /*
         * The NT machine wants to know the biggest size of value and data
@@ -5204,14 +6148,13 @@ uint32 _spoolss_enumprinterdata(POLICY_HND *handle, uint32 idx,
                 */
 
                if (!get_specific_param_by_index(*printer, 2, idx, value, &data, &type, &data_len)) {
-                       safe_free(data);
+                       SAFE_FREE(data);
                        free_a_printer(&printer, 2);
-                       return ERROR_NO_MORE_ITEMS;
+                       return WERR_NO_MORE_ITEMS;
                }
 #endif
 
-               safe_free(data);
-               data = NULL;
+               SAFE_FREE(data);
 
                param_index=0;
                biggest_valuesize=0;
@@ -5223,23 +6166,10 @@ uint32 _spoolss_enumprinterdata(POLICY_HND *handle, uint32 idx,
 
                        DEBUG(6,("current values: [%d], [%d]\n", biggest_valuesize, biggest_datasize));
 
-                       safe_free(data);
-                       data = NULL;
+                       SAFE_FREE(data);
                        param_index++;
                }
 
-               /*
-                * I think this is correct, it doesn't break APW and
-                * allows Gerald's Win32 test programs to work correctly,
-                * but may need altering.... JRA.
-                */
-
-               if (param_index == 0) {
-                       /* No parameters found. */
-                       free_a_printer(&printer, 2);
-                       return ERROR_NO_MORE_ITEMS;
-               }
-
                /* the value is an UNICODE string but realvaluesize is the length in bytes including the leading 0 */
                *out_value_len=2*(1+biggest_valuesize);
                *out_data_len=biggest_datasize;
@@ -5247,7 +6177,7 @@ uint32 _spoolss_enumprinterdata(POLICY_HND *handle, uint32 idx,
                DEBUG(6,("final values: [%d], [%d]\n", *out_value_len, *out_data_len));
 
                free_a_printer(&printer, 2);
-               return NT_STATUS_NO_PROBLEMO;
+               return WERR_OK;
        }
        
        /*
@@ -5256,9 +6186,29 @@ uint32 _spoolss_enumprinterdata(POLICY_HND *handle, uint32 idx,
         */
 
        if (!get_specific_param_by_index(*printer, 2, idx, value, &data, &type, &data_len)) {
-               safe_free(data);
+
+               SAFE_FREE(data);
                free_a_printer(&printer, 2);
-               return ERROR_NO_MORE_ITEMS;
+
+               /* out_value should default to "" or else NT4 has
+                  problems unmarshalling the response */
+
+               *out_max_value_len=(in_value_len/sizeof(uint16));
+               if((*out_value=(uint16 *)malloc(in_value_len*sizeof(uint8))) == NULL)
+                       return WERR_NOMEM;
+
+               ZERO_STRUCTP(*out_value);
+               *out_value_len = rpcstr_push((char *)*out_value, "", in_value_len, 0);
+
+               /* the data is counted in bytes */
+               *out_max_data_len = in_data_len;
+               *out_data_len = in_data_len;
+               if((*data_out=(uint8 *)malloc(in_data_len*sizeof(uint8))) == NULL)
+                       return WERR_NOMEM;
+
+               memset(*data_out,'\0',in_data_len);
+
+               return WERR_NO_MORE_ITEMS;
        }
 
        free_a_printer(&printer, 2);
@@ -5273,71 +6223,90 @@ uint32 _spoolss_enumprinterdata(POLICY_HND *handle, uint32 idx,
         */
        
        *out_max_value_len=(in_value_len/sizeof(uint16));
-       if((*out_value=(uint16 *)malloc(in_value_len*sizeof(uint8))) == NULL) {
-               safe_free(data);
-               return ERROR_NOT_ENOUGH_MEMORY;
+       if((*out_value=(uint16 *)talloc_zero(p->mem_ctx,in_value_len*sizeof(uint8))) == NULL) {
+               SAFE_FREE(data);
+               return WERR_NOMEM;
        }
        
-       ZERO_STRUCTP(*out_value);
-       *out_value_len = (uint32)dos_PutUniCode((char *)*out_value, value, in_value_len, True);
+       *out_value_len = rpcstr_push((char *)*out_value,value, in_value_len, 0);
 
        *out_type=type;
 
        /* the data is counted in bytes */
        *out_max_data_len=in_data_len;
-       if((*data_out=(uint8 *)malloc(in_data_len*sizeof(uint8))) == NULL) {
-               safe_free(data);
-               return ERROR_NOT_ENOUGH_MEMORY;
+       if((*data_out=(uint8 *)talloc_zero(p->mem_ctx, in_data_len*sizeof(uint8))) == NULL) {
+               SAFE_FREE(data);
+               return WERR_NOMEM;
        }
        
-       memset(*data_out,'\0',in_data_len);
        memcpy(*data_out, data, (size_t)data_len);
        *out_data_len=data_len;
 
-       safe_free(data);
+       SAFE_FREE(data);
        
-       return NT_STATUS_NO_PROBLEMO;
+       return WERR_OK;
 }
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_setprinterdata( POLICY_HND *handle,
-                               const UNISTR2 *value,
-                               uint32 type,
-                               uint32 max_len,
-                               const uint8 *data,
-                               uint32 real_len,
-                               uint32 numeric_data)
+
+WERROR _spoolss_setprinterdata( pipes_struct *p, SPOOL_Q_SETPRINTERDATA *q_u, SPOOL_R_SETPRINTERDATA *r_u)
 {
+       POLICY_HND *handle = &q_u->handle;
+       UNISTR2 *value = &q_u->value;
+       uint32 type = q_u->type;
+/*     uint32 max_len = q_u->max_len; - notused. */
+       uint8 *data = q_u->data;
+       uint32 real_len = q_u->real_len;
+/*     uint32 numeric_data = q_u->numeric_data; - notused. */
+
        NT_PRINTER_INFO_LEVEL *printer = NULL;
        NT_PRINTER_PARAM *param = NULL, old_param;
        int snum=0;
-       uint32 status = 0x0;
-       Printer_entry *Printer=find_printer_index_by_hnd(handle);
+       WERROR status = WERR_OK;
+       Printer_entry *Printer=find_printer_index_by_hnd(p, handle);
        
        DEBUG(5,("spoolss_setprinterdata\n"));
 
-       if (!OPEN_HANDLE(Printer)) {
+       if (!Printer) {
                DEBUG(0,("_spoolss_setprinterdata: Invalid handle (%s).\n", OUR_HANDLE(handle)));
-               return ERROR_INVALID_HANDLE;
+               return WERR_BADFID;
        }
 
-       if (!get_printer_snum(handle, &snum))
-               return ERROR_INVALID_HANDLE;
+       if (!get_printer_snum(p,handle, &snum))
+               return WERR_BADFID;
 
-       status = get_a_printer(&printer, 2, lp_servicename(snum));
-       if (status != 0x0)
-               return ERROR_INVALID_NAME;
+       ZERO_STRUCT(old_param);
 
-       convert_specific_param(&param, value , type, data, real_len);
+       /* 
+        * Access check : NT returns "access denied" if you make a 
+        * SetPrinterData call without the necessary privildge.
+        * we were originally returning OK if nothing changed
+        * which made Win2k issue **a lot** of SetPrinterData
+        * when connecting to a printer  --jerry
+        */
+
+       if (!print_access_check(NULL, snum, PRINTER_ACCESS_ADMINISTER)) {
+               DEBUG(3, ("security descriptor change denied by existing "
+                         "security descriptor\n"));
+               status = WERR_ACCESS_DENIED;
+               goto done;
+       }
 
        /* Check if we are making any changes or not.  Return true if
-          nothing is actually changing. */
+          nothing is actually changing.  This is not needed anymore but
+          has been left in as an optimization to keep from from
+          writing to disk as often  --jerry  */
 
-       ZERO_STRUCT(old_param);
+       status = get_a_printer(&printer, 2, lp_servicename(snum));
+       if (!W_ERROR_IS_OK(status))
+               return status;
+
+       convert_specific_param(&param, value , type, data, real_len);
 
+#if 0
        if (get_specific_param(*printer, 2, param->value, &old_param.data,
-                              &old_param.type, (unsigned int *)&old_param.data_len)) {
+                              &old_param.type, (uint32 *)&old_param.data_len)) {
 
                if (param->type == old_param.type &&
                    param->data_len == old_param.data_len &&
@@ -5345,69 +6314,78 @@ uint32 _spoolss_setprinterdata( POLICY_HND *handle,
                           old_param.data_len) == 0) {
 
                        DEBUG(3, ("setprinterdata hasn't changed\n"));
-                       status = NT_STATUS_NO_PROBLEMO;
+                       status = WERR_OK;
                        goto done;
                }
        }
-
-       /* Access check */
-
-       if (!print_access_check(NULL, snum, PRINTER_ACCESS_ADMINISTER)) {
-               DEBUG(3, ("security descriptor change denied by existing "
-                         "security descriptor\n"));
-               status = ERROR_ACCESS_DENIED;
-               goto done;
-       }
+#endif
 
        unlink_specific_param_if_exist(printer->info_2, param);
        
-       add_a_specific_param(printer->info_2, &param);
-       status = mod_a_printer(*printer, 2);
+       /*
+        * When client side code sets a magic printer data key, detect it and save
+        * the current printer data and the magic key's data (its the DEVMODE) for
+        * future printer/driver initializations.
+        */
+       if (param->type==3 && !strcmp( param->value, PHANTOM_DEVMODE_KEY)) {
+               /*
+                * Set devmode and printer initialization info
+                */
+               status = save_driver_init(printer, 2, param);
+       }
+       else {
+               add_a_specific_param(printer->info_2, &param);
+               status = mod_a_printer(*printer, 2);
+       }
 
  done:
        free_a_printer(&printer, 2);
        if (param)
                free_nt_printer_param(&param);
-       safe_free(old_param.data);
+       SAFE_FREE(old_param.data);
 
        return status;
 }
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_deleteprinterdata( POLICY_HND *handle, const UNISTR2 *value)
+
+WERROR _spoolss_deleteprinterdata(pipes_struct *p, SPOOL_Q_DELETEPRINTERDATA *q_u, SPOOL_R_DELETEPRINTERDATA *r_u)
 {
+       POLICY_HND *handle = &q_u->handle;
+       UNISTR2 *value = &q_u->valuename;
+
        NT_PRINTER_INFO_LEVEL *printer = NULL;
        NT_PRINTER_PARAM param;
        int snum=0;
-       uint32 status = 0x0;
-       Printer_entry *Printer=find_printer_index_by_hnd(handle);
+       WERROR status = WERR_OK;
+       Printer_entry *Printer=find_printer_index_by_hnd(p, handle);
        
        DEBUG(5,("spoolss_deleteprinterdata\n"));
        
-       if (!OPEN_HANDLE(Printer)) {
+       if (!Printer) {
                DEBUG(0,("_spoolss_deleteprinterdata: Invalid handle (%s).\n", OUR_HANDLE(handle)));
-               return ERROR_INVALID_HANDLE;
+               return WERR_BADFID;
        }
 
-       if (!get_printer_snum(handle, &snum))
-               return ERROR_INVALID_HANDLE;
+       if (!get_printer_snum(p, handle, &snum))
+               return WERR_BADFID;
 
        if (!print_access_check(NULL, snum, PRINTER_ACCESS_ADMINISTER)) {
-               DEBUG(3, ("_spoolss_deleteprinterdata: security descriptor change denied by existing "
-                         "security descriptor\n"));
-               return ERROR_ACCESS_DENIED;
+               DEBUG(3, ("_spoolss_deleteprinterdata: printer properties "
+                         "change denied by existing security descriptor\n"));
+               return WERR_ACCESS_DENIED;
        }
 
        status = get_a_printer(&printer, 2, lp_servicename(snum));
-       if (status != 0x0)
-               return ERROR_INVALID_NAME;
+       if (!W_ERROR_IS_OK(status))
+               return status;
 
        ZERO_STRUCTP(&param);
        unistr2_to_ascii(param.value, value, sizeof(param.value)-1);
 
        if(!unlink_specific_param_if_exist(printer->info_2, &param))
-               status = ERROR_INVALID_PARAMETER;
+               status = WERR_INVALID_PARAM;
        else
                status = mod_a_printer(*printer, 2);
 
@@ -5417,91 +6395,123 @@ uint32 _spoolss_deleteprinterdata( POLICY_HND *handle, const UNISTR2 *value)
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_addform( POLICY_HND *handle,
-                               uint32 level,
-                               const FORM *form)
+
+WERROR _spoolss_addform( pipes_struct *p, SPOOL_Q_ADDFORM *q_u, SPOOL_R_ADDFORM *r_u)
 {
+       POLICY_HND *handle = &q_u->handle;
+/*     uint32 level = q_u->level; - notused. */
+       FORM *form = &q_u->form;
+       nt_forms_struct tmpForm;
+
        int count=0;
        nt_forms_struct *list=NULL;
-       Printer_entry *Printer = find_printer_index_by_hnd(handle);
+       Printer_entry *Printer = find_printer_index_by_hnd(p, handle);
 
        DEBUG(5,("spoolss_addform\n"));
 
-       if (!OPEN_HANDLE(Printer)) {
+       if (!Printer) {
                DEBUG(0,("_spoolss_addform: Invalid handle (%s).\n", OUR_HANDLE(handle)));
-               return ERROR_INVALID_HANDLE;
+               return WERR_BADFID;
+       }
+
+       /* 
+        * FIXME!!  Feels like there should be an access check here, but haven't
+        * had time to verify.  --jerry
+        */
+
+       /* can't add if builtin */
+       if (get_a_builtin_ntform(&form->name,&tmpForm)) {
+               return WERR_INVALID_PARAM;
        }
 
        count=get_ntforms(&list);
        if(!add_a_form(&list, form, &count))
-               return ERROR_NOT_ENOUGH_MEMORY;
+               return WERR_NOMEM;
        write_ntforms(&list, count);
 
-       safe_free(list);
+       SAFE_FREE(list);
 
-       return 0x0;
+       return WERR_OK;
 }
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_deleteform( POLICY_HND *handle, UNISTR2 *form_name)
+
+WERROR _spoolss_deleteform( pipes_struct *p, SPOOL_Q_DELETEFORM *q_u, SPOOL_R_DELETEFORM *r_u)
 {
+       POLICY_HND *handle = &q_u->handle;
+       UNISTR2 *form_name = &q_u->name;
+       nt_forms_struct tmpForm;
        int count=0;
-       uint32 ret = 0;
+       WERROR ret = WERR_OK;
        nt_forms_struct *list=NULL;
-       Printer_entry *Printer = find_printer_index_by_hnd(handle);
+       Printer_entry *Printer = find_printer_index_by_hnd(p, handle);
 
        DEBUG(5,("spoolss_deleteform\n"));
 
-       if (!OPEN_HANDLE(Printer)) {
+       if (!Printer) {
                DEBUG(0,("_spoolss_deleteform: Invalid handle (%s).\n", OUR_HANDLE(handle)));
-               return ERROR_INVALID_HANDLE;
+               return WERR_BADFID;
+       }
+
+       /* can't delete if builtin */
+       if (get_a_builtin_ntform(form_name,&tmpForm)) {
+               return WERR_INVALID_PARAM;
        }
 
        count = get_ntforms(&list);
        if(!delete_a_form(&list, form_name, &count, &ret))
-               return ERROR_INVALID_PARAMETER;
+               return WERR_INVALID_PARAM;
 
-       safe_free(list);
+       SAFE_FREE(list);
 
        return ret;
 }
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_setform( POLICY_HND *handle,
-                               const UNISTR2 *uni_name,
-                               uint32 level,
-                               const FORM *form)
+
+WERROR _spoolss_setform(pipes_struct *p, SPOOL_Q_SETFORM *q_u, SPOOL_R_SETFORM *r_u)
 {
+       POLICY_HND *handle = &q_u->handle;
+/*     UNISTR2 *uni_name = &q_u->name; - notused. */
+/*     uint32 level = q_u->level; - notused. */
+       FORM *form = &q_u->form;
+       nt_forms_struct tmpForm;
+
        int count=0;
        nt_forms_struct *list=NULL;
-       Printer_entry *Printer = find_printer_index_by_hnd(handle);
+       Printer_entry *Printer = find_printer_index_by_hnd(p, handle);
 
        DEBUG(5,("spoolss_setform\n"));
 
-       if (!OPEN_HANDLE(Printer)) {
+       if (!Printer) {
                DEBUG(0,("_spoolss_setform: Invalid handle (%s).\n", OUR_HANDLE(handle)));
-               return ERROR_INVALID_HANDLE;
+               return WERR_BADFID;
        }
+       /* can't set if builtin */
+       if (get_a_builtin_ntform(&form->name,&tmpForm)) {
+               return WERR_INVALID_PARAM;
+       }
+
        count=get_ntforms(&list);
        update_a_form(&list, form, count);
        write_ntforms(&list, count);
 
-       safe_free(list);
+       SAFE_FREE(list);
 
-       return 0x0;
+       return WERR_OK;
 }
 
 /****************************************************************************
  enumprintprocessors level 1.
 ****************************************************************************/
-static uint32 enumprintprocessors_level_1(NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
+static WERROR enumprintprocessors_level_1(NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
        PRINTPROCESSOR_1 *info_1=NULL;
        
        if((info_1 = (PRINTPROCESSOR_1 *)malloc(sizeof(PRINTPROCESSOR_1))) == NULL)
-               return ERROR_NOT_ENOUGH_MEMORY;
+               return WERR_NOMEM;
 
        (*returned) = 0x1;
        
@@ -5510,26 +6520,37 @@ static uint32 enumprintprocessors_level_1(NEW_BUFFER *buffer, uint32 offered, ui
        *needed += spoolss_size_printprocessor_info_1(info_1);
 
        if (!alloc_buffer_size(buffer, *needed))
-               return ERROR_INSUFFICIENT_BUFFER;
+               return WERR_INSUFFICIENT_BUFFER;
 
        smb_io_printprocessor_info_1("", buffer, info_1, 0);
 
-       safe_free(info_1);
+       SAFE_FREE(info_1);
 
        if (*needed > offered) {
                *returned=0;
-               return ERROR_INSUFFICIENT_BUFFER;
+               return WERR_INSUFFICIENT_BUFFER;
        }
-       else
-               return NT_STATUS_NO_PROBLEMO;
+
+       return WERR_OK;
 }
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_enumprintprocessors(UNISTR2 *name, UNISTR2 *environment, uint32 level,
-                                   NEW_BUFFER *buffer, uint32 offered,
-                                   uint32 *needed, uint32 *returned)
+
+WERROR _spoolss_enumprintprocessors(pipes_struct *p, SPOOL_Q_ENUMPRINTPROCESSORS *q_u, SPOOL_R_ENUMPRINTPROCESSORS *r_u)
 {
+/*     UNISTR2 *name = &q_u->name; - notused. */
+/*     UNISTR2 *environment = &q_u->environment; - notused. */
+       uint32 level = q_u->level;
+    NEW_BUFFER *buffer = NULL;
+       uint32 offered = q_u->offered;
+    uint32 *needed = &r_u->needed;
+       uint32 *returned = &r_u->returned;
+
+       /* that's an [in out] buffer */
+       spoolss_move_buffer(q_u->buffer, &r_u->buffer);
+       buffer = r_u->buffer;
+
        DEBUG(5,("spoolss_enumprintprocessors\n"));
 
        /*
@@ -5546,19 +6567,19 @@ uint32 _spoolss_enumprintprocessors(UNISTR2 *name, UNISTR2 *environment, uint32
        case 1:
                return enumprintprocessors_level_1(buffer, offered, needed, returned);
        default:
-               return ERROR_INVALID_LEVEL;
+               return WERR_UNKNOWN_LEVEL;
        }
 }
 
 /****************************************************************************
  enumprintprocdatatypes level 1.
 ****************************************************************************/
-static uint32 enumprintprocdatatypes_level_1(NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
+static WERROR enumprintprocdatatypes_level_1(NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
        PRINTPROCDATATYPE_1 *info_1=NULL;
        
        if((info_1 = (PRINTPROCDATATYPE_1 *)malloc(sizeof(PRINTPROCDATATYPE_1))) == NULL)
-               return ERROR_NOT_ENOUGH_MEMORY;
+               return WERR_NOMEM;
 
        (*returned) = 0x1;
        
@@ -5567,26 +6588,37 @@ static uint32 enumprintprocdatatypes_level_1(NEW_BUFFER *buffer, uint32 offered,
        *needed += spoolss_size_printprocdatatype_info_1(info_1);
 
        if (!alloc_buffer_size(buffer, *needed))
-               return ERROR_INSUFFICIENT_BUFFER;
+               return WERR_INSUFFICIENT_BUFFER;
 
        smb_io_printprocdatatype_info_1("", buffer, info_1, 0);
 
-       safe_free(info_1);
+       SAFE_FREE(info_1);
 
        if (*needed > offered) {
                *returned=0;
-               return ERROR_INSUFFICIENT_BUFFER;
+               return WERR_INSUFFICIENT_BUFFER;
        }
-       else
-               return NT_STATUS_NO_PROBLEMO;
+
+       return WERR_OK;
 }
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_enumprintprocdatatypes(UNISTR2 *name, UNISTR2 *processor, uint32 level,
-                                       NEW_BUFFER *buffer, uint32 offered,
-                                       uint32 *needed, uint32 *returned)
+
+WERROR _spoolss_enumprintprocdatatypes(pipes_struct *p, SPOOL_Q_ENUMPRINTPROCDATATYPES *q_u, SPOOL_R_ENUMPRINTPROCDATATYPES *r_u)
 {
+/*     UNISTR2 *name = &q_u->name; - notused. */
+/*     UNISTR2 *processor = &q_u->processor; - notused. */
+       uint32 level = q_u->level;
+       NEW_BUFFER *buffer = NULL;
+       uint32 offered = q_u->offered;
+       uint32 *needed = &r_u->needed;
+       uint32 *returned = &r_u->returned;
+
+       /* that's an [in out] buffer */
+       spoolss_move_buffer(q_u->buffer, &r_u->buffer);
+       buffer = r_u->buffer;
+
        DEBUG(5,("_spoolss_enumprintprocdatatypes\n"));
        
        *returned=0;
@@ -5596,19 +6628,20 @@ uint32 _spoolss_enumprintprocdatatypes(UNISTR2 *name, UNISTR2 *processor, uint32
        case 1:
                return enumprintprocdatatypes_level_1(buffer, offered, needed, returned);
        default:
-               return ERROR_INVALID_LEVEL;
+               return WERR_UNKNOWN_LEVEL;
        }
 }
 
 /****************************************************************************
  enumprintmonitors level 1.
 ****************************************************************************/
-static uint32 enumprintmonitors_level_1(NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
+
+static WERROR enumprintmonitors_level_1(NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
        PRINTMONITOR_1 *info_1=NULL;
        
        if((info_1 = (PRINTMONITOR_1 *)malloc(sizeof(PRINTMONITOR_1))) == NULL)
-               return ERROR_NOT_ENOUGH_MEMORY;
+               return WERR_NOMEM;
 
        (*returned) = 0x1;
        
@@ -5617,29 +6650,29 @@ static uint32 enumprintmonitors_level_1(NEW_BUFFER *buffer, uint32 offered, uint
        *needed += spoolss_size_printmonitor_info_1(info_1);
 
        if (!alloc_buffer_size(buffer, *needed))
-               return ERROR_INSUFFICIENT_BUFFER;
+               return WERR_INSUFFICIENT_BUFFER;
 
        smb_io_printmonitor_info_1("", buffer, info_1, 0);
 
-       safe_free(info_1);
+       SAFE_FREE(info_1);
 
        if (*needed > offered) {
                *returned=0;
-               return ERROR_INSUFFICIENT_BUFFER;
+               return WERR_INSUFFICIENT_BUFFER;
        }
-       else
-               return NT_STATUS_NO_PROBLEMO;
+
+       return WERR_OK;
 }
 
 /****************************************************************************
  enumprintmonitors level 2.
 ****************************************************************************/
-static uint32 enumprintmonitors_level_2(NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
+static WERROR enumprintmonitors_level_2(NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
        PRINTMONITOR_2 *info_2=NULL;
        
        if((info_2 = (PRINTMONITOR_2 *)malloc(sizeof(PRINTMONITOR_2))) == NULL)
-               return ERROR_NOT_ENOUGH_MEMORY;
+               return WERR_NOMEM;
 
        (*returned) = 0x1;
        
@@ -5650,26 +6683,36 @@ static uint32 enumprintmonitors_level_2(NEW_BUFFER *buffer, uint32 offered, uint
        *needed += spoolss_size_printmonitor_info_2(info_2);
 
        if (!alloc_buffer_size(buffer, *needed))
-               return ERROR_INSUFFICIENT_BUFFER;
+               return WERR_INSUFFICIENT_BUFFER;
 
        smb_io_printmonitor_info_2("", buffer, info_2, 0);
 
-       safe_free(info_2);
+       SAFE_FREE(info_2);
 
        if (*needed > offered) {
                *returned=0;
-               return ERROR_INSUFFICIENT_BUFFER;
+               return WERR_INSUFFICIENT_BUFFER;
        }
-       else
-               return NT_STATUS_NO_PROBLEMO;
+
+       return WERR_OK;
 }
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_enumprintmonitors(UNISTR2 *name,uint32 level,
-                                   NEW_BUFFER *buffer, uint32 offered,
-                                   uint32 *needed, uint32 *returned)
+
+WERROR _spoolss_enumprintmonitors(pipes_struct *p, SPOOL_Q_ENUMPRINTMONITORS *q_u, SPOOL_R_ENUMPRINTMONITORS *r_u)
 {
+/*     UNISTR2 *name = &q_u->name; - notused. */
+       uint32 level = q_u->level;
+    NEW_BUFFER *buffer = NULL;
+       uint32 offered = q_u->offered;
+    uint32 *needed = &r_u->needed;
+       uint32 *returned = &r_u->returned;
+
+       /* that's an [in out] buffer */
+       spoolss_move_buffer(q_u->buffer, &r_u->buffer);
+       buffer = r_u->buffer;
+
        DEBUG(5,("spoolss_enumprintmonitors\n"));
 
        /*
@@ -5688,13 +6731,13 @@ uint32 _spoolss_enumprintmonitors(UNISTR2 *name,uint32 level,
        case 2:
                return enumprintmonitors_level_2(buffer, offered, needed, returned);
        default:
-               return ERROR_INVALID_LEVEL;
+               return WERR_UNKNOWN_LEVEL;
        }
 }
 
 /****************************************************************************
 ****************************************************************************/
-static uint32 getjob_level_1(print_queue_struct *queue, int count, int snum, uint32 jobid, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
+static WERROR getjob_level_1(print_queue_struct *queue, int count, int snum, uint32 jobid, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
 {
        int i=0;
        BOOL found=False;
@@ -5703,8 +6746,8 @@ static uint32 getjob_level_1(print_queue_struct *queue, int count, int snum, uin
        info_1=(JOB_INFO_1 *)malloc(sizeof(JOB_INFO_1));
 
        if (info_1 == NULL) {
-               safe_free(queue);
-               return ERROR_NOT_ENOUGH_MEMORY;
+               SAFE_FREE(queue);
+               return WERR_NOMEM;
        }
                
        for (i=0; i<count && found==False; i++) {
@@ -5713,48 +6756,51 @@ static uint32 getjob_level_1(print_queue_struct *queue, int count, int snum, uin
        }
        
        if (found==False) {
-               safe_free(queue);
-               safe_free(info_1);
-               /* I shoud reply something else ... I can't find the good one */
-               return NT_STATUS_NO_PROBLEMO;
+               SAFE_FREE(queue);
+               SAFE_FREE(info_1);
+               /* NT treats not found as bad param... yet another bad choice */
+               return WERR_INVALID_PARAM;
        }
        
        fill_job_info_1(info_1, &(queue[i-1]), i, snum);
        
-       safe_free(queue);
+       SAFE_FREE(queue);
        
        *needed += spoolss_size_job_info_1(info_1);
 
        if (!alloc_buffer_size(buffer, *needed)) {
-               safe_free(info_1);
-               return ERROR_INSUFFICIENT_BUFFER;
+               SAFE_FREE(info_1);
+               return WERR_INSUFFICIENT_BUFFER;
        }
 
-       new_smb_io_job_info_1("", buffer, info_1, 0);
+       smb_io_job_info_1("", buffer, info_1, 0);
 
-       safe_free(info_1);
+       SAFE_FREE(info_1);
 
        if (*needed > offered)
-               return ERROR_INSUFFICIENT_BUFFER;
-       else
-               return NT_STATUS_NO_PROBLEMO;
+               return WERR_INSUFFICIENT_BUFFER;
+
+       return WERR_OK;
 }
 
 
 /****************************************************************************
 ****************************************************************************/
-static uint32 getjob_level_2(print_queue_struct *queue, int count, int snum, uint32 jobid, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
+static WERROR getjob_level_2(print_queue_struct *queue, int count, int snum, uint32 jobid, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
 {
        int i=0;
        BOOL found=False;
        JOB_INFO_2 *info_2;
+       NT_PRINTER_INFO_LEVEL *ntprinter = NULL;
+       WERROR ret;
+
        info_2=(JOB_INFO_2 *)malloc(sizeof(JOB_INFO_2));
 
        ZERO_STRUCTP(info_2);
 
        if (info_2 == NULL) {
-               safe_free(queue);
-               return ERROR_NOT_ENOUGH_MEMORY;
+               SAFE_FREE(queue);
+               return WERR_NOMEM;
        }
 
        for (i=0; i<count && found==False; i++) {
@@ -5763,52 +6809,68 @@ static uint32 getjob_level_2(print_queue_struct *queue, int count, int snum, uin
        }
        
        if (found==False) {
-               safe_free(queue);
-               safe_free(info_2);
-               /* I shoud reply something else ... I can't find the good one */
-               return NT_STATUS_NO_PROBLEMO;
+               SAFE_FREE(queue);
+               SAFE_FREE(info_2);
+               /* NT treats not found as bad param... yet another bad choice */
+               return WERR_INVALID_PARAM;
        }
        
-       fill_job_info_2(info_2, &(queue[i-1]), i, snum);
+       ret = get_a_printer(&ntprinter, 2, lp_servicename(snum));
+       if (!W_ERROR_IS_OK(ret)) {
+               SAFE_FREE(queue);
+               return ret;
+       }
+
+       fill_job_info_2(info_2, &(queue[i-1]), i, snum, ntprinter);
        
-       safe_free(queue);
+       free_a_printer(&ntprinter, 2);
+       SAFE_FREE(queue);
        
        *needed += spoolss_size_job_info_2(info_2);
 
        if (!alloc_buffer_size(buffer, *needed)) {
-               safe_free(info_2);
-               return ERROR_INSUFFICIENT_BUFFER;
+               SAFE_FREE(info_2);
+               return WERR_INSUFFICIENT_BUFFER;
        }
 
-       new_smb_io_job_info_2("", buffer, info_2, 0);
+       smb_io_job_info_2("", buffer, info_2, 0);
 
        free_job_info_2(info_2);
+       SAFE_FREE(info_2);
 
        if (*needed > offered)
-               return ERROR_INSUFFICIENT_BUFFER;
-       else
-               return NT_STATUS_NO_PROBLEMO;
+               return WERR_INSUFFICIENT_BUFFER;
+
+       return WERR_OK;
 }
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_getjob( POLICY_HND *handle, uint32 jobid, uint32 level,
-                       NEW_BUFFER *buffer, uint32 offered,
-                       uint32 *needed)
+
+WERROR _spoolss_getjob( pipes_struct *p, SPOOL_Q_GETJOB *q_u, SPOOL_R_GETJOB *r_u)
 {
+       POLICY_HND *handle = &q_u->handle;
+       uint32 jobid = q_u->jobid;
+       uint32 level = q_u->level;
+       NEW_BUFFER *buffer = NULL;
+       uint32 offered = q_u->offered;
+       uint32 *needed = &r_u->needed;
+
        int snum;
        int count;
        print_queue_struct *queue=NULL;
        print_status_struct prt_status;
 
+       /* that's an [in out] buffer */
+       spoolss_move_buffer(q_u->buffer, &r_u->buffer);
+       buffer = r_u->buffer;
+
        DEBUG(5,("spoolss_getjob\n"));
        
-       memset(&prt_status, 0, sizeof(prt_status));
-
        *needed=0;
        
-       if (!get_printer_snum(handle, &snum))
-               return ERROR_INVALID_HANDLE;
+       if (!get_printer_snum(p, handle, &snum))
+               return WERR_BADFID;
        
        count = print_queue_status(snum, &queue, &prt_status);
        
@@ -5821,8 +6883,415 @@ uint32 _spoolss_getjob( POLICY_HND *handle, uint32 jobid, uint32 level,
        case 2:
                return getjob_level_2(queue, count, snum, jobid, buffer, offered, needed);
        default:
-               safe_free(queue);
-               return ERROR_INVALID_LEVEL;
+               SAFE_FREE(queue);
+               return WERR_UNKNOWN_LEVEL;
+       }
+}
+
+/********************************************************************
+ * spoolss_getprinterdataex
+ ********************************************************************/
+
+WERROR _spoolss_getprinterdataex(pipes_struct *p, SPOOL_Q_GETPRINTERDATAEX *q_u, SPOOL_R_GETPRINTERDATAEX *r_u)
+{
+       POLICY_HND      *handle = &q_u->handle;
+       uint32          in_size = q_u->size;
+       uint32          *type = &r_u->type;
+       uint32          *out_size = &r_u->size;
+       uint8           **data = &r_u->data;
+       uint32          *needed = &r_u->needed;
+
+       fstring         key, value;
+       Printer_entry   *Printer = find_printer_index_by_hnd(p, handle);
+       BOOL            found = False;
+
+       DEBUG(4,("_spoolss_getprinterdataex\n"));
+
+        unistr2_to_ascii(key, &q_u->keyname, sizeof(key) - 1);
+        unistr2_to_ascii(value, &q_u->valuename, sizeof(value) - 1);
+
+       /* in case of problem, return some default values */
+       *needed=0;
+       *type=0;
+       *out_size=0;
+
+               
+       if (!Printer) {
+               if((*data=(uint8 *)talloc_zero(p->mem_ctx, 4*sizeof(uint8))) == NULL)
+                       return WERR_NOMEM;
+               DEBUG(0,("_spoolss_getprinterdata: Invalid handle (%s).\n", OUR_HANDLE(handle)));
+               return WERR_BADFID;
+       }
+
+               
+       /* Is the handle to a printer or to the server? */
+
+       if (Printer->printer_type == PRINTER_HANDLE_IS_PRINTSERVER)
+       {
+               DEBUG(10,("_spoolss_getprinterdatex: Not implemented for server handles yet\n"));
+               return WERR_INVALID_PARAM;
+       }
+       else
+       {
+               /* 
+                * From MSDN documentation of GetPrinterDataEx: pass request
+                * to GetPrinterData if key is "PrinterDriverData". This is 
+                * the only key we really support. Other keys to implement:
+                * (a) DsDriver
+                * (b) DsSpooler
+                * (c) PnPData
+                */
+          
+               if (strcmp(key, "PrinterDriverData") != 0)
+                       return WERR_INVALID_PARAM;
+
+               DEBUG(10, ("_spoolss_getprinterdataex: pass me to getprinterdata\n"));
+               found = getprinterdata_printer(p, p->mem_ctx, handle, value, 
+                       type, data, needed, in_size);
+               
+       }
+        
+       if (!found) {
+               DEBUG(5, ("value not found, allocating %d\n", *out_size));
+               
+               /* reply this param doesn't exist */
+               if (*out_size) {
+                       if((*data=(uint8 *)talloc_zero(p->mem_ctx, *out_size*sizeof(uint8))) == NULL)
+                               return WERR_NOMEM;
+               } else {
+                       *data = NULL;
+               }
+
+               return WERR_INVALID_PARAM;
+       }
+       
+       if (*needed > *out_size)
+               return WERR_MORE_DATA;
+       else
+               return WERR_OK;
+}
+
+/********************************************************************
+ * spoolss_setprinterdata
+ ********************************************************************/
+
+WERROR _spoolss_setprinterdataex(pipes_struct *p, SPOOL_Q_SETPRINTERDATAEX *q_u, SPOOL_R_SETPRINTERDATAEX *r_u)
+{
+       SPOOL_Q_SETPRINTERDATA q_u_local;
+       SPOOL_R_SETPRINTERDATA r_u_local;
+        fstring key;
+
+       DEBUG(4,("_spoolss_setprinterdataex\n"));
+
+        /* From MSDN documentation of SetPrinterDataEx: pass request to
+           SetPrinterData if key is "PrinterDriverData" */
+
+        unistr2_to_ascii(key, &q_u->key, sizeof(key) - 1);
+
+        if (strcmp(key, "PrinterDriverData") == 0)
+               return WERR_INVALID_PARAM;
+               
+       ZERO_STRUCT(q_u_local); 
+       ZERO_STRUCT(r_u_local); 
+       
+       /* make a copy to call _spoolss_setprinterdata() */
+
+       memcpy(&q_u_local.handle, &q_u->handle, sizeof(POLICY_HND));
+       copy_unistr2(&q_u_local.value, &q_u->value);
+       q_u_local.type = q_u->type;
+       q_u_local.max_len = q_u->max_len;
+       q_u_local.data = q_u->data;
+       q_u_local.real_len = q_u->real_len;
+       q_u_local.numeric_data = q_u->numeric_data;
+               
+       return _spoolss_setprinterdata(p, &q_u_local, &r_u_local);
+}
+
+/********************************************************************
+ * spoolss_enumprinterkey
+ ********************************************************************/
+
+/* constants for EnumPrinterKey() */
+#define ENUMERATED_KEY_SIZE    19
+
+WERROR _spoolss_enumprinterkey(pipes_struct *p, SPOOL_Q_ENUMPRINTERKEY *q_u, SPOOL_R_ENUMPRINTERKEY *r_u)
+{
+       fstring key;
+       uint16  enumkeys[ENUMERATED_KEY_SIZE+1];
+       char*   ptr = NULL;
+       int     i;
+       char    *PrinterKey = "PrinterDriverData";
+
+       DEBUG(4,("_spoolss_enumprinterkey\n"));
+
+       unistr2_to_ascii(key, &q_u->key, sizeof(key) - 1);
+
+       /* 
+        * we only support enumating all keys (key == "")
+        * Of course, the only key we support is the "PrinterDriverData" 
+        * key
+        */     
+       if (strlen(key) == 0)
+       {
+               r_u->needed = ENUMERATED_KEY_SIZE *2;
+               if (q_u->size < r_u->needed)
+                       return WERR_MORE_DATA;
+       
+               ptr = PrinterKey;
+               for (i=0; i<ENUMERATED_KEY_SIZE-2; i++)
+               {
+                       enumkeys[i] = (uint16)(*ptr);
+                       ptr++;
+               }
+
+               /* tag of with 2 '\0's */
+               enumkeys[i++] = '\0';
+               enumkeys[i] = '\0';
+       
+               if (!make_spoolss_buffer5(p->mem_ctx, &r_u->keys, ENUMERATED_KEY_SIZE, enumkeys))
+                       return WERR_BADFILE;
+                       
+               return WERR_OK;
+       }
+       
+       /* The "PrinterDriverData" key should have no subkeys */
+       if (strcmp(key, PrinterKey) == 0)
+       {
+               r_u-> needed = 2;
+               if (q_u->size < r_u->needed)
+                       return WERR_MORE_DATA;
+               enumkeys[0] = 0x0;
+               if (!make_spoolss_buffer5(p->mem_ctx, &r_u->keys, 1, enumkeys))
+                       return WERR_BADFILE;
+                       
+               return WERR_OK;
+       }
+       
+
+       /* The return value for an unknown key is documented in MSDN
+          EnumPrinterKey description */
+        return WERR_BADFILE;
+}
+
+/********************************************************************
+ * spoolss_enumprinterdataex
+ ********************************************************************/
+
+WERROR _spoolss_enumprinterdataex(pipes_struct *p, SPOOL_Q_ENUMPRINTERDATAEX *q_u, SPOOL_R_ENUMPRINTERDATAEX *r_u)
+{
+       POLICY_HND      *handle = &q_u->handle; 
+       uint32          in_size = q_u->size;
+       uint32          num_entries, 
+                       needed;
+       NT_PRINTER_INFO_LEVEL   *printer = NULL;
+       PRINTER_ENUM_VALUES     *enum_values = NULL;
+       fstring         key, value;
+       Printer_entry   *Printer = find_printer_index_by_hnd(p, handle);
+       int             snum;
+       uint32          param_index, 
+                       data_len,
+                       type;
+       WERROR          result;
+       uint8           *data=NULL;
+       
+
+       DEBUG(4,("_spoolss_enumprinterdataex\n"));
+
+       if (!Printer) {
+               DEBUG(0,("_spoolss_enumprinterdata: Invalid handle (%s).\n", OUR_HANDLE(handle)));
+               return WERR_BADFID;
+       }
+
+               
+        /* 
+        * The only key we support is "PrinterDriverData". This should return 
+        > an array of all the key/value pairs returned by EnumPrinterDataSee 
+        * _spoolss_getprinterdataex() for details    --jerry
+        */
+   
+       unistr2_to_ascii(key, &q_u->key, sizeof(key) - 1);
+       if (strcmp(key, "PrinterDriverData") != 0)
+       {
+               DEBUG(10,("_spoolss_enumprinterdataex: Unknown keyname [%s]\n", key));
+               return WERR_INVALID_PARAM;
+       }
+
+
+       if (!get_printer_snum(p,handle, &snum))
+               return WERR_BADFID;
+       
+       ZERO_STRUCT(printer);
+       result = get_a_printer(&printer, 2, lp_servicename(snum));
+       if (!W_ERROR_IS_OK(result))
+               return result;
+
+       
+       /* 
+        * loop through all params and build the array to pass 
+        * back to the  client 
+        */
+       result = WERR_OK;
+       param_index             = 0;
+       needed                  = 0;
+       num_entries             = 0;
+       
+       while (get_specific_param_by_index(*printer, 2, param_index, value, &data, &type, &data_len)) 
+       {
+               PRINTER_ENUM_VALUES     *ptr;
+               uint32                  add_len = 0;
+
+               DEBUG(10,("retrieved value number [%d] [%s]\n", num_entries, value));
+
+               if ((ptr=talloc_realloc(p->mem_ctx, enum_values, (num_entries+1) * sizeof(PRINTER_ENUM_VALUES))) == NULL)
+               {
+                       DEBUG(0,("talloc_realloc failed to allocate more memory!\n"));
+                       result = WERR_NOMEM;
+                       goto done;
+               }
+               enum_values = ptr;
+
+               /* copy the data */
+               init_unistr(&enum_values[num_entries].valuename, value);
+               enum_values[num_entries].value_len = (strlen(value)+1) * 2;
+               enum_values[num_entries].type      = type;
+               
+               /* 
+                * NULL terminate REG_SZ
+                * FIXME!!!  We should not be correctly problems in the way
+                * we store PrinterData here.  Need to investogate 
+                * SetPrinterData[Ex]   --jerry
+                */
+               
+               if (type == REG_SZ) {
+                       /* fix alignment if the string was stored 
+                          in a bizarre fashion */
+                       if ((data_len % 2) == 0)
+                               add_len = 2;
+                       else
+                               add_len = data_len % 2;
+               }
+               
+               if (!(enum_values[num_entries].data=talloc_zero(p->mem_ctx, data_len+add_len))) {
+                       DEBUG(0,("talloc_realloc failed to allocate more memory for data!\n"));
+                       result = WERR_NOMEM;
+                       goto done;
+               }
+               memcpy(enum_values[num_entries].data, data, data_len);
+               enum_values[num_entries].data_len = data_len + add_len;
+
+               /* keep track of the size of the array in bytes */
+               
+               needed += spoolss_size_printer_enum_values(&enum_values[num_entries]);
+               
+               num_entries++;
+               param_index++;
+       }
+       
+       r_u->needed             = needed;
+       r_u->returned           = num_entries;
+
+       if (needed > in_size) {
+               result = WERR_MORE_DATA;
+               goto done;
+       }
+               
+       /* copy data into the reply */
+       
+       r_u->ctr.size           = r_u->needed;
+       r_u->ctr.size_of_array  = r_u->returned;
+       r_u->ctr.values         = enum_values;
+       
+       
+               
+done:  
+       free_a_printer(&printer, 2);
+
+       return result;
+}
+
+/****************************************************************************
+****************************************************************************/
+
+/* Disabled because it doesn't fix the bug I am looking at but it would be
+   a shame to throw away the code. -tpot */
+
+#if 0
+
+static void fill_printprocessordirectory_1(PRINTPROCESSOR_DIRECTORY_1 *info, char *name)
+{
+       init_unistr(&info->name, name);
+}
+
+static WERROR getprintprocessordirectory_level_1(UNISTR2 *name, 
+                                                UNISTR2 *environment, 
+                                                NEW_BUFFER *buffer, 
+                                                uint32 offered, 
+                                                uint32 *needed)
+{
+       pstring path;
+       pstring long_archi;
+       pstring short_archi;
+       PRINTPROCESSOR_DIRECTORY_1 *info=NULL;
+
+       unistr2_to_ascii(long_archi, environment, sizeof(long_archi)-1);
+
+       if (get_short_archi(short_archi, long_archi)==False)
+               return WERR_INVALID_ENVIRONMENT;
+
+       if((info=(PRINTPROCESSOR_DIRECTORY_1 *)malloc(sizeof(PRINTPROCESSOR_DIRECTORY_1))) == NULL)
+               return WERR_NOMEM;
+
+       /* Not sure what to return here - are UNC names valid here?.
+          Windows returns the string: C:\WINNT\System32\spool\PRTPROCS\W32X86
+          which is pretty bogus for a RPC. */
+
+       slprintf(path, sizeof(path)-1, "\\\\%s\\print$\\%s", get_called_name(), short_archi);
+
+       DEBUG(4,("print processor directory: [%s]\n", path));
+
+       fill_printprocessordirectory_1(info, path);
+       
+       *needed += spoolss_size_printprocessordirectory_info_1(info);
+
+       if (!alloc_buffer_size(buffer, *needed)) {
+               safe_free(info);
+               return WERR_INSUFFICIENT_BUFFER;
+       }
+
+       smb_io_printprocessordirectory_1("", buffer, info, 0);
+
+       safe_free(info);
+       
+       if (*needed > offered)
+               return WERR_INSUFFICIENT_BUFFER;
+       else
+               return WERR_OK;
+}
+
+WERROR _spoolss_getprintprocessordirectory(pipes_struct *p, SPOOL_Q_GETPRINTPROCESSORDIRECTORY *q_u, SPOOL_R_GETPRINTPROCESSORDIRECTORY *r_u)
+{
+       uint32 level = q_u->level;
+       NEW_BUFFER *buffer = NULL;
+       uint32 offered = q_u->offered;
+       uint32 *needed = &r_u->needed;
+
+       /* that's an [in out] buffer */
+       spoolss_move_buffer(q_u->buffer, &r_u->buffer);
+       buffer = r_u->buffer;
+
+       DEBUG(5,("_spoolss_getprintprocessordirectory\n"));
+       
+       *needed=0;
+
+       switch(level) {
+       case 1:
+               return getprintprocessordirectory_level_1
+                 (&q_u->name, &q_u->environment, buffer, offered, needed);
+       default:
+               return WERR_UNKNOWN_LEVEL;
        }
+
+       return WERR_ACCESS_DENIED;
 }
-#undef OLD_NTDOMAIN
+
+#endif