RIP BOOL. Convert BOOL -> bool. I found a few interesting
[kai/samba.git] / source3 / rpc_server / srv_spoolss_nt.c
index 2fee1972ab4bbac1f596c26372704bc9cb5c6b8a..658ed994002134f0c268ae70b3eb6ab1e5a0b263 100644 (file)
@@ -10,7 +10,7 @@
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License as published by
- *  the Free Software Foundation; either version 2 of the License, or
+ *  the Free Software Foundation; either version 3 of the License, or
  *  (at your option) any later version.
  *
  *  This program is distributed in the hope that it will be useful,
@@ -19,8 +19,7 @@
  *  GNU General Public License for more details.
  *
  *  You should have received a copy of the GNU General Public License
- *  along with this program; if not, write to the Free Software
- *  Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ *  along with this program; if not, see <http://www.gnu.org/licenses/>.
  */
 
 /* Since the SPOOLSS rpc routines are basically DOS 16-bit calls wrapped
@@ -40,23 +39,6 @@ extern userdom_struct current_user_info;
 #define MAGIC_DISPLAY_FREQUENCY 0xfade2bad
 #define PHANTOM_DEVMODE_KEY "_p_f_a_n_t_0_m_"
 
-
-/* Table to map the driver version */
-/* to OS */
-static const char * drv_ver_to_os[] = {
-       "WIN9X",   /* driver version/cversion 0 */
-       "",        /* unused ? */
-       "WINNT",   /* driver version/cversion 2 */
-       "WIN2K",   /* driver version/cversion 3 */
-};
-
-static const char *get_drv_ver_to_os(int ver)
-{
-       if (ver < 0 || ver > 3)
-               return "";
-       return drv_ver_to_os[ver];
-}
-
 struct table_node {
        const char    *long_archi;
        const char    *short_archi;
@@ -75,16 +57,21 @@ typedef struct _counter_printer_0 {
 
 static counter_printer_0 *counter_list;
 
-static struct cli_state notify_cli; /* print notify back-channel */
+static struct rpc_pipe_client *notify_cli_pipe; /* print notify back-channel pipe handle*/
 static uint32 smb_connections=0;
 
 
 /* in printing/nt_printing.c */
 
-extern STANDARD_MAPPING printer_std_mapping, printserver_std_mapping;
+extern struct standard_mapping printer_std_mapping, printserver_std_mapping;
+
+/* API table for Xcv Monitor functions */
+
+struct xcv_api_table {
+       const char *name;
+       WERROR(*fn) (NT_USER_TOKEN *token, RPC_BUFFER *in, RPC_BUFFER *out, uint32 *needed);
+};
 
-#define OUR_HANDLE(hnd) (((hnd)==NULL)?"NULL":(IVAL((hnd)->data5,4)==(uint32)sys_getpid()?"OURS":"OTHER")), \
-((unsigned int)IVAL((hnd)->data5,4)),((unsigned int)sys_getpid())
 
 /* translate between internal status numbers and NT status numbers */
 static int nt_printj_status(int v)
@@ -166,7 +153,7 @@ static void srv_spoolss_replycloseprinter(int snum, POLICY_HND *handle)
                return;
        }
 
-       result = cli_spoolss_reply_close_printer(&notify_cli, notify_cli.mem_ctx, handle);
+       result = rpccli_spoolss_reply_close_printer(notify_cli_pipe, notify_cli_pipe->cli->mem_ctx, handle);
        
        if (!W_ERROR_IS_OK(result))
                DEBUG(0,("srv_spoolss_replycloseprinter: reply_close_printer failed [%s].\n",
@@ -174,10 +161,12 @@ static void srv_spoolss_replycloseprinter(int snum, POLICY_HND *handle)
 
        /* if it's the last connection, deconnect the IPC$ share */
        if (smb_connections==1) {
-               cli_nt_session_close(&notify_cli);
-               cli_ulogoff(&notify_cli);
-               cli_shutdown(&notify_cli);
-               message_deregister(MSG_PRINTER_NOTIFY2);
+
+               cli_shutdown( notify_cli_pipe->cli );
+               notify_cli_pipe = NULL; /* The above call shuts downn the pipe also. */
+
+               messaging_deregister(smbd_messaging_context(),
+                                    MSG_PRINTER_NOTIFY2, NULL);
 
                /* Tell the connections db we're no longer interested in
                 * printer notify messages. */
@@ -199,10 +188,10 @@ static void free_printer_entry(void *ptr)
        if (Printer->notify.client_connected==True) {
                int snum = -1;
 
-               if ( Printer->printer_type == PRINTER_HANDLE_IS_PRINTSERVER) {
+               if ( Printer->printer_type == SPLHND_SERVER) {
                        snum = -1;
                        srv_spoolss_replycloseprinter(snum, &Printer->notify.client_hnd);
-               } else if (Printer->printer_type == PRINTER_HANDLE_IS_PRINTER) {
+               } else if (Printer->printer_type == SPLHND_PRINTER) {
                        snum = print_queue_snum(Printer->sharename);
                        if (snum != -1)
                                srv_spoolss_replycloseprinter(snum,
@@ -266,7 +255,7 @@ static Printer_entry *find_printer_index_by_hnd(pipes_struct *p, POLICY_HND *hnd
 {
        Printer_entry *find_printer = NULL;
 
-       if(!find_policy_by_hnd(p,hnd,(void **)&find_printer)) {
+       if(!find_policy_by_hnd(p,hnd,(void **)(void *)&find_printer)) {
                DEBUG(2,("find_printer_index_by_hnd: Printer handle not found: "));
                return NULL;
        }
@@ -275,75 +264,75 @@ static Printer_entry *find_printer_index_by_hnd(pipes_struct *p, POLICY_HND *hnd
 }
 
 /****************************************************************************
- look for a printer object cached on an open printer handle
+ Close printer index by handle.
 ****************************************************************************/
 
-WERROR find_printer_in_print_hnd_cache( TALLOC_CTX *ctx, NT_PRINTER_INFO_LEVEL_2 **info2, 
-                                        const char *servername, const char *printername )
+static bool close_printer_handle(pipes_struct *p, POLICY_HND *hnd)
 {
-       Printer_entry *p;
-       
-       DEBUG(10,("find_printer_in_print_hnd_cache: printer [\\\\%s\\%s]\n", 
-               servername, printername));
+       Printer_entry *Printer = find_printer_index_by_hnd(p, hnd);
 
-       for ( p=printers_list; p; p=p->next )
-       {
-               if ( p->printer_type==PRINTER_HANDLE_IS_PRINTER 
-                       && p->printer_info
-                       && strequal( p->sharename, printername )
-                       && strequal( p->servername, servername ) )
-               {
-                       DEBUG(10,("Found printer\n"));
-                       *info2 = dup_printer_2( ctx, p->printer_info->info_2 );
-                       if ( *info2 )
-                               return WERR_OK;
-               }
+       if (!Printer) {
+               DEBUG(2,("close_printer_handle: Invalid handle (%s:%u:%u)\n", OUR_HANDLE(hnd)));
+               return False;
        }
 
-       return WERR_INVALID_PRINTER_NAME;
-}
+       close_policy_hnd(p, hnd);
+
+       return True;
+}      
 
 /****************************************************************************
-  destroy any cached printer_info_2 structures on open handles
+ Delete a printer given a handle.
 ****************************************************************************/
-
-void invalidate_printer_hnd_cache( char *printername )
+WERROR delete_printer_hook( NT_USER_TOKEN *token, const char *sharename )
 {
-       Printer_entry *p;
+       char *cmd = lp_deleteprinter_cmd();
+       pstring command;
+       int ret;
+       SE_PRIV se_printop = SE_PRINT_OPERATOR;
+       bool is_print_op = False;
+               
+       /* can't fail if we don't try */
        
-       DEBUG(10,("invalidate_printer_hnd_cache: printer [%s]\n", printername));
-
-       for ( p=printers_list; p; p=p->next )
-       {
-               if ( p->printer_type==PRINTER_HANDLE_IS_PRINTER 
-                       && p->printer_info
-                       && StrCaseCmp(p->sharename, printername)==0)
-               {
-                       DEBUG(10,("invalidating printer_info cache for handl:\n"));
-                       free_a_printer( &p->printer_info, 2 );
-                       p->printer_info = NULL;
-               }
-       }
-
-       return;
-}
-/****************************************************************************
- Close printer index by handle.
-****************************************************************************/
+       if ( !*cmd )
+               return WERR_OK;
+               
+       pstr_sprintf(command, "%s \"%s\"", cmd, sharename);
 
-static BOOL close_printer_handle(pipes_struct *p, POLICY_HND *hnd)
-{
-       Printer_entry *Printer = find_printer_index_by_hnd(p, hnd);
+       if ( token )
+               is_print_op = user_has_privileges( token, &se_printop );
+       
+       DEBUG(10,("Running [%s]\n", command));
 
-       if (!Printer) {
-               DEBUG(2,("close_printer_handle: Invalid handle (%s:%u:%u)\n", OUR_HANDLE(hnd)));
-               return False;
+       /********** BEGIN SePrintOperatorPrivlege BLOCK **********/
+       
+       if ( is_print_op )
+               become_root();
+               
+       if ( (ret = smbrun(command, NULL)) == 0 ) {
+               /* Tell everyone we updated smb.conf. */
+               message_send_all(smbd_messaging_context(),
+                                MSG_SMB_CONF_UPDATED, NULL, 0, NULL);
        }
+               
+       if ( is_print_op )
+               unbecome_root();
 
-       close_policy_hnd(p, hnd);
+       /********** END SePrintOperatorPrivlege BLOCK **********/
+       
+       DEBUGADD(10,("returned [%d]\n", ret));
 
-       return True;
-}      
+       if (ret != 0) 
+               return WERR_BADFID; /* What to return here? */
+
+       /* go ahead and re-read the services immediately */
+       reload_services( False );
+       
+       if ( lp_servicenumber( sharename )  < 0 )
+               return WERR_ACCESS_DENIED;
+               
+       return WERR_OK;
+}
 
 /****************************************************************************
  Delete a printer given a handle.
@@ -369,18 +358,6 @@ static WERROR delete_printer_handle(pipes_struct *p, POLICY_HND *hnd)
                DEBUG(3, ("delete_printer_handle: denied by handle\n"));
                return WERR_ACCESS_DENIED;
        }
-
-#if 0
-       /* Check calling user has permission to delete printer.  Note that
-          since we set the snum parameter to -1 only administrators can
-          delete the printer.  This stops people with the Full Control
-          permission from deleting the printer. */
-
-       if (!print_access_check(NULL, -1, PRINTER_ACCESS_ADMINISTER)) {
-               DEBUG(3, ("printer delete denied by security descriptor\n"));
-               return WERR_ACCESS_DENIED;
-       }
-#endif
        
        /* this does not need a become root since the access check has been 
           done on the handle already */
@@ -390,57 +367,15 @@ static WERROR delete_printer_handle(pipes_struct *p, POLICY_HND *hnd)
                return WERR_BADFID;
        }
 
-       /* the delete printer script shoudl be run as root if the user has perms */
-       
-       if (*lp_deleteprinter_cmd()) {
-
-               char *cmd = lp_deleteprinter_cmd();
-               pstring command;
-               int ret;
-               SE_PRIV se_printop = SE_PRINT_OPERATOR;
-               BOOL is_print_op;
-               
-               pstr_sprintf(command, "%s \"%s\"", cmd, Printer->sharename);
-
-               is_print_op = user_has_privileges( p->pipe_user.nt_user_token, &se_printop );
-       
-               DEBUG(10,("Running [%s]\n", command));
-
-               /********** BEGIN SePrintOperatorPrivlege BLOCK **********/
-       
-               if ( is_print_op )
-                       become_root();
-               
-               if ( (ret = smbrun(command, NULL)) == 0 ) {
-                       /* Tell everyone we updated smb.conf. */
-                       message_send_all(conn_tdb_ctx(), MSG_SMB_CONF_UPDATED, NULL, 0, False, NULL);
-               }
-               
-               if ( is_print_op )
-                       unbecome_root();
-
-               /********** END SePrintOperatorPrivlege BLOCK **********/
-
-               DEBUGADD(10,("returned [%d]\n", ret));
-
-               if (ret != 0) 
-                       return WERR_BADFID; /* What to return here? */
-
-               /* go ahead and re-read the services immediately */
-               reload_services( False );
-
-               if ( lp_servicenumber( Printer->sharename )  < 0 )
-                       return WERR_ACCESS_DENIED;
-       }
-
-       return WERR_OK;
+       return delete_printer_hook( p->pipe_user.nt_user_token, Printer->sharename );
 }
 
 /****************************************************************************
  Return the snum of a printer corresponding to an handle.
 ****************************************************************************/
 
-static BOOL get_printer_snum(pipes_struct *p, POLICY_HND *hnd, int *number)
+static bool get_printer_snum(pipes_struct *p, POLICY_HND *hnd, int *number,
+                            struct share_params **params)
 {
        Printer_entry *Printer = find_printer_index_by_hnd(p, hnd);
                
@@ -450,11 +385,11 @@ static BOOL get_printer_snum(pipes_struct *p, POLICY_HND *hnd, int *number)
        }
        
        switch (Printer->printer_type) {
-               case PRINTER_HANDLE_IS_PRINTER:         
+               case SPLHND_PRINTER:            
                        DEBUG(4,("short name:%s\n", Printer->sharename));                       
                        *number = print_queue_snum(Printer->sharename);
                        return (*number != -1);
-               case PRINTER_HANDLE_IS_PRINTSERVER:
+               case SPLHND_SERVER:
                        return False;
                default:
                        return False;
@@ -466,7 +401,7 @@ static BOOL get_printer_snum(pipes_struct *p, POLICY_HND *hnd, int *number)
  Check if it's \\server or \\server\printer
 ****************************************************************************/
 
-static BOOL set_printer_hnd_printertype(Printer_entry *Printer, char *handlename)
+static bool set_printer_hnd_printertype(Printer_entry *Printer, char *handlename)
 {
        DEBUG(3,("Setting printer type=%s\n", handlename));
 
@@ -478,30 +413,33 @@ static BOOL set_printer_hnd_printertype(Printer_entry *Printer, char *handlename
        /* it's a print server */
        if (*handlename=='\\' && *(handlename+1)=='\\' && !strchr_m(handlename+2, '\\')) {
                DEBUGADD(4,("Printer is a print server\n"));
-               Printer->printer_type = PRINTER_HANDLE_IS_PRINTSERVER;          
+               Printer->printer_type = SPLHND_SERVER;          
        }
-       /* it's a printer */
+       /* it's a printer (set_printer_hnd_name() will handle port monitors */
        else {
                DEBUGADD(4,("Printer is a printer\n"));
-               Printer->printer_type = PRINTER_HANDLE_IS_PRINTER;
+               Printer->printer_type = SPLHND_PRINTER;
        }
 
        return True;
 }
 
 /****************************************************************************
- Set printer handle name.
+ Set printer handle name..  Accept names like \\server, \\server\printer, 
+ \\server\SHARE, & "\\server\,XcvMonitor Standard TCP/IP Port"    See
+ the MSDN docs regarding OpenPrinter() for details on the XcvData() and 
+ XcvDataPort() interface.
 ****************************************************************************/
 
-static BOOL set_printer_hnd_name(Printer_entry *Printer, char *handlename)
+static bool set_printer_hnd_name(Printer_entry *Printer, char *handlename)
 {
        int snum;
        int n_services=lp_numservices();
        char *aprinter, *printername;
        const char *servername;
        fstring sname;
-       BOOL found=False;
-       NT_PRINTER_INFO_LEVEL *printer;
+       bool found=False;
+       NT_PRINTER_INFO_LEVEL *printer = NULL;
        WERROR result;
        
        DEBUG(4,("Setting printer name=%s (len=%lu)\n", handlename, (unsigned long)strlen(handlename)));
@@ -525,38 +463,52 @@ static BOOL set_printer_hnd_name(Printer_entry *Printer, char *handlename)
 
        fstrcpy( Printer->servername, servername );
        
-       if ( Printer->printer_type == PRINTER_HANDLE_IS_PRINTSERVER )
+       if ( Printer->printer_type == SPLHND_SERVER )
                return True;
 
-       if ( Printer->printer_type != PRINTER_HANDLE_IS_PRINTER )
+       if ( Printer->printer_type != SPLHND_PRINTER )
                return False;
 
        DEBUGADD(5, ("searching for [%s]\n", aprinter ));
-
-       /* Search all sharenames first as this is easier than pulling 
-          the printer_info_2 off of disk */
        
-       snum = find_service(aprinter);
+       /* check for the Port Monitor Interface */
        
-       if ( lp_snum_ok(snum) && lp_print_ok(snum) ) {
+       if ( strequal( aprinter, SPL_XCV_MONITOR_TCPMON ) ) {
+               Printer->printer_type = SPLHND_PORTMON_TCP;
+               fstrcpy(sname, SPL_XCV_MONITOR_TCPMON);
+               found = True;
+       }
+       else if ( strequal( aprinter, SPL_XCV_MONITOR_LOCALMON ) ) {
+               Printer->printer_type = SPLHND_PORTMON_LOCAL;
+               fstrcpy(sname, SPL_XCV_MONITOR_LOCALMON);
                found = True;
-               fstrcpy( sname, aprinter );
        }
 
+       /* Search all sharenames first as this is easier than pulling 
+          the printer_info_2 off of disk. Don't use find_service() since
+          that calls out to map_username() */
+       
        /* do another loop to look for printernames */
        
        for (snum=0; !found && snum<n_services; snum++) {
 
-               /* no point in checking if this is not a printer or 
-                  we aren't allowing printername != sharename */
+               /* no point going on if this is not a printer */
 
-               if ( !(lp_snum_ok(snum) 
-                       && lp_print_ok(snum) 
-                       && !lp_force_printername(snum)) ) 
-               {
+               if ( !(lp_snum_ok(snum) && lp_print_ok(snum)) )
                        continue;
+
+               fstrcpy(sname, lp_servicename(snum));
+               if ( strequal( aprinter, sname ) ) {
+                       found = True;
+                       break;
                }
+
+               /* no point looking up the printer object if
+                  we aren't allowing printername != sharename */
                
+               if ( lp_force_printername(snum) )
+                       continue;
+
                fstrcpy(sname, lp_servicename(snum));
 
                printer = NULL;
@@ -578,14 +530,18 @@ static BOOL set_printer_hnd_name(Printer_entry *Printer, char *handlename)
                printername++;
                
                if ( strequal(printername, aprinter) ) {
+                       free_a_printer( &printer, 2);
                        found = True;
+                       break;
                }
                
                DEBUGADD(10, ("printername: %s\n", printername));
                
-                       free_a_printer( &printer, 2);
+               free_a_printer( &printer, 2);
        }
 
+       free_a_printer( &printer, 2);
+
        if ( !found ) {
                DEBUGADD(4,("Printer not found\n"));
                return False;
@@ -602,7 +558,7 @@ static BOOL set_printer_hnd_name(Printer_entry *Printer, char *handlename)
  Find first available printer slot. creates a printer handle for you.
  ****************************************************************************/
 
-static BOOL open_printer_hnd(pipes_struct *p, POLICY_HND *hnd, char *name, uint32 access_granted)
+static bool open_printer_hnd(pipes_struct *p, POLICY_HND *hnd, char *name, uint32 access_granted)
 {
        Printer_entry *new_printer;
 
@@ -651,13 +607,13 @@ static BOOL open_printer_hnd(pipes_struct *p, POLICY_HND *hnd, char *name, uint3
  given by (notify_type, notify_field).
  **************************************************************************/
 
-static BOOL is_monitoring_event_flags(uint32 flags, uint16 notify_type,
+static bool is_monitoring_event_flags(uint32 flags, uint16 notify_type,
                                      uint16 notify_field)
 {
        return True;
 }
 
-static BOOL is_monitoring_event(Printer_entry *p, uint16 notify_type,
+static bool is_monitoring_event(Printer_entry *p, uint16 notify_type,
                                uint16 notify_field)
 {
        SPOOL_NOTIFY_OPTION *option = p->notify.option;
@@ -744,23 +700,34 @@ static void notify_system_time(struct spoolss_notify_msg *msg,
                return;
        }
 
-       if (!prs_init(&ps, MAX_PDU_FRAG_LEN, mem_ctx, MARSHALL)) {
+       if (!prs_init(&ps, RPC_MAX_PDU_FRAG_LEN, mem_ctx, MARSHALL)) {
                DEBUG(5, ("notify_system_time: prs_init() failed\n"));
                return;
        }
 
        if (!make_systemtime(&systime, gmtime((time_t *)msg->notify.data))) {
                DEBUG(5, ("notify_system_time: unable to make systemtime\n"));
+               prs_mem_free(&ps);
                return;
        }
 
-       if (!spoolss_io_system_time("", &ps, 0, &systime))
+       if (!spoolss_io_system_time("", &ps, 0, &systime)) {
+               prs_mem_free(&ps);
                return;
+       }
 
        data->notify_data.data.length = prs_offset(&ps);
-       data->notify_data.data.string = TALLOC(mem_ctx, prs_offset(&ps));
-
-       prs_copy_all_data_out((char *)data->notify_data.data.string, &ps);
+       if (prs_offset(&ps)) {
+               data->notify_data.data.string = (uint16 *)
+                       TALLOC(mem_ctx, prs_offset(&ps));
+               if (!data->notify_data.data.string) {
+                       prs_mem_free(&ps);
+                       return;
+               }
+               prs_copy_all_data_out((char *)data->notify_data.data.string, &ps);
+       } else {
+               data->notify_data.data.string = NULL;
+       }
 
        prs_mem_free(&ps);
 }
@@ -946,7 +913,8 @@ static int notify_msg_ctr_addmsg( SPOOLSS_NOTIFY_MSG_CTR *ctr, SPOOLSS_NOTIFY_MS
        /* need to allocate own copy of data */
        
        if ( msg->len != 0 ) 
-               msg_grp->msgs[new_slot].notify.data = TALLOC_MEMDUP( ctr->ctx, msg->notify.data, msg->len );
+               msg_grp->msgs[new_slot].notify.data = (char *)
+                       TALLOC_MEMDUP( ctr->ctx, msg->notify.data, msg->len );
        
        return ctr->num_groups;
 }
@@ -996,7 +964,7 @@ static void send_notify2_changes( SPOOLSS_NOTIFY_MSG_CTR *ctr, uint32 idx )
                /* For this printer?  Print servers always receive 
                    notifications. */
 
-               if ( ( p->printer_type == PRINTER_HANDLE_IS_PRINTER )  &&
+               if ( ( p->printer_type == SPLHND_PRINTER )  &&
                    ( !strequal(msg_group->printername, p->sharename) ) )
                        continue;
 
@@ -1005,6 +973,10 @@ static void send_notify2_changes( SPOOLSS_NOTIFY_MSG_CTR *ctr, uint32 idx )
                /* allocate the max entries possible */
                
                data = TALLOC_ARRAY( mem_ctx, SPOOL_NOTIFY_INFO_DATA, msg_group->num_msgs);
+               if (!data) {
+                       return;
+               }
+
                ZERO_STRUCTP(data);
                
                /* build the array of change notifications */
@@ -1038,7 +1010,7 @@ static void send_notify2_changes( SPOOLSS_NOTIFY_MSG_CTR *ctr, uint32 idx )
                         * --jerry
                         */
 
-                       if ( ( p->printer_type == PRINTER_HANDLE_IS_PRINTER ) && ( msg->type == PRINTER_NOTIFY_TYPE ) )
+                       if ( ( p->printer_type == SPLHND_PRINTER ) && ( msg->type == PRINTER_NOTIFY_TYPE ) )
                                id = 0;
                        else
                                id = msg->id;
@@ -1077,7 +1049,7 @@ static void send_notify2_changes( SPOOLSS_NOTIFY_MSG_CTR *ctr, uint32 idx )
                }
 
                if ( sending_msg_count ) {
-                       cli_spoolss_rrpcn( &notify_cli, mem_ctx, &p->notify.client_hnd, 
+                       rpccli_spoolss_rrpcn( notify_cli_pipe, mem_ctx, &p->notify.client_hnd, 
                                        data_len, data, p->notify.change, 0 );
                }
        }
@@ -1090,7 +1062,7 @@ done:
 /***********************************************************************
  **********************************************************************/
 
-static BOOL notify2_unpack_msg( SPOOLSS_NOTIFY_MSG *msg, struct timeval *tv, void *buf, size_t len )
+static bool notify2_unpack_msg( SPOOLSS_NOTIFY_MSG *msg, struct timeval *tv, void *buf, size_t len )
 {
 
        uint32 tv_sec, tv_usec;
@@ -1098,18 +1070,18 @@ static BOOL notify2_unpack_msg( SPOOLSS_NOTIFY_MSG *msg, struct timeval *tv, voi
 
        /* Unpack message */
 
-       offset += tdb_unpack((char *)buf + offset, len - offset, "f",
+       offset += tdb_unpack((uint8 *)buf + offset, len - offset, "f",
                             msg->printer);
        
-       offset += tdb_unpack((char *)buf + offset, len - offset, "ddddddd",
+       offset += tdb_unpack((uint8 *)buf + offset, len - offset, "ddddddd",
                                &tv_sec, &tv_usec,
                                &msg->type, &msg->field, &msg->id, &msg->len, &msg->flags);
 
        if (msg->len == 0)
-               tdb_unpack((char *)buf + offset, len - offset, "dd",
+               tdb_unpack((uint8 *)buf + offset, len - offset, "dd",
                           &msg->notify.value[0], &msg->notify.value[1]);
        else
-               tdb_unpack((char *)buf + offset, len - offset, "B", 
+               tdb_unpack((uint8 *)buf + offset, len - offset, "B", 
                           &msg->len, &msg->notify.data);
 
        DEBUG(3, ("notify2_unpack_msg: got NOTIFY2 message for printer %s, jobid %u type %d, field 0x%02x, flags 0x%04x\n",
@@ -1122,7 +1094,7 @@ static BOOL notify2_unpack_msg( SPOOLSS_NOTIFY_MSG *msg, struct timeval *tv, voi
                DEBUG(3, ("notify2_unpack_msg: value1 = %d, value2 = %d\n", msg->notify.value[0],
                          msg->notify.value[1]));
        else
-               dump_data(3, msg->notify.data, msg->len);
+               dump_data(3, (uint8 *)msg->notify.data, msg->len);
 
        return True;
 }
@@ -1131,17 +1103,21 @@ static BOOL notify2_unpack_msg( SPOOLSS_NOTIFY_MSG *msg, struct timeval *tv, voi
  Receive a notify2 message list
  ********************************************************************/
 
-static void receive_notify2_message_list(int msg_type, pid_t src, void *msg, size_t len)
+static void receive_notify2_message_list(struct messaging_context *msg,
+                                        void *private_data,
+                                        uint32_t msg_type,
+                                        struct server_id server_id,
+                                        DATA_BLOB *data)
 {
        size_t                  msg_count, i;
-       char                    *buf = (char *)msg;
+       char                    *buf = (char *)data->data;
        char                    *msg_ptr;
        size_t                  msg_len;
        SPOOLSS_NOTIFY_MSG      notify;
        SPOOLSS_NOTIFY_MSG_CTR  messages;
        int                     num_groups;
 
-       if (len < 4) {
+       if (data->length < 4) {
                DEBUG(0,("receive_notify2_message_list: bad message format (len < 4)!\n"));
                return;
        }
@@ -1171,7 +1147,7 @@ static void receive_notify2_message_list(int msg_type, pid_t src, void *msg, siz
        for ( i=0; i<msg_count; i++ ) {
                struct timeval msg_tv;
 
-               if (msg_ptr + 4 - buf > len) {
+               if (msg_ptr + 4 - buf > data->length) {
                        DEBUG(0,("receive_notify2_message_list: bad message format (len > buf_size) !\n"));
                        return;
                }
@@ -1179,7 +1155,7 @@ static void receive_notify2_message_list(int msg_type, pid_t src, void *msg, siz
                msg_len = IVAL(msg_ptr,0);
                msg_ptr += 4;
 
-               if (msg_ptr + msg_len - buf > len) {
+               if (msg_ptr + msg_len - buf > data->length) {
                        DEBUG(0,("receive_notify2_message_list: bad message format (bad len) !\n"));
                        return;
                }
@@ -1216,29 +1192,13 @@ static void receive_notify2_message_list(int msg_type, pid_t src, void *msg, siz
        return;
 }
 
-/********************************************************************
- callback to MSG_PRINTER_CHANGED.  When a printer is changed by 
- one smbd, all of processes must clear their printer cache immediately.
- ********************************************************************/
-
-void receive_printer_mod_msg(int msg_type, pid_t src, void *buf, size_t len)
-{
-       fstring printername;
-       
-       fstrcpy( printername, buf );
-       
-       DEBUG(10,("receive_printer_mod_msg: Printer change [%s]\n", printername ));
-       
-       invalidate_printer_hnd_cache( printername );
-}
-
 /********************************************************************
  Send a message to ourself about new driver being installed
  so we can upgrade the information for each printer bound to this
  driver
  ********************************************************************/
  
-static BOOL srv_spoolss_drv_upgrade_printer(char* drivername)
+static bool srv_spoolss_drv_upgrade_printer(char* drivername)
 {
        int len = strlen(drivername);
        
@@ -1248,7 +1208,9 @@ static BOOL srv_spoolss_drv_upgrade_printer(char* drivername)
        DEBUG(10,("srv_spoolss_drv_upgrade_printer: Sending message about driver upgrade [%s]\n",
                drivername));
                
-       message_send_pid(sys_getpid(), MSG_PRINTER_DRVUPGRADE, drivername, len+1, False);
+       messaging_send_buf(smbd_messaging_context(), procid_self(),
+                          MSG_PRINTER_DRVUPGRADE,
+                          (uint8 *)drivername, len+1);
 
        return True;
 }
@@ -1258,14 +1220,19 @@ static BOOL srv_spoolss_drv_upgrade_printer(char* drivername)
  over all printers, upgrading ones as necessary 
  **********************************************************************/
  
-void do_drv_upgrade_printer(int msg_type, pid_t src, void *buf, size_t len)
+void do_drv_upgrade_printer(struct messaging_context *msg,
+                           void *private_data,
+                           uint32_t msg_type,
+                           struct server_id server_id,
+                           DATA_BLOB *data)
 {
        fstring drivername;
        int snum;
        int n_services = lp_numservices();
+       size_t len;
        
-       len = MIN(len,sizeof(drivername)-1);
-       strncpy(drivername, buf, len);
+       len = MIN(data->length,sizeof(drivername)-1);
+       strncpy(drivername, (const char *)data->data, len);
        
        DEBUG(10,("do_drv_upgrade_printer: Got message for new driver [%s]\n", drivername ));
 
@@ -1316,7 +1283,7 @@ void update_monitored_printq_cache( void )
           client_connected == True */
        while ( printer ) 
        {
-               if ( (printer->printer_type == PRINTER_HANDLE_IS_PRINTER) 
+               if ( (printer->printer_type == SPLHND_PRINTER) 
                        && printer->notify.client_connected ) 
                {
                        snum = print_queue_snum(printer->sharename);
@@ -1334,7 +1301,7 @@ void update_monitored_printq_cache( void )
  driver
  ********************************************************************/
  
-static BOOL srv_spoolss_reset_printerdata(char* drivername)
+static bool srv_spoolss_reset_printerdata(char* drivername)
 {
        int len = strlen(drivername);
        
@@ -1344,7 +1311,9 @@ static BOOL srv_spoolss_reset_printerdata(char* drivername)
        DEBUG(10,("srv_spoolss_reset_printerdata: Sending message about resetting printerdata [%s]\n",
                drivername));
                
-       message_send_pid(sys_getpid(), MSG_PRINTERDATA_INIT_RESET, drivername, len+1, False);
+       messaging_send_buf(smbd_messaging_context(), procid_self(),
+                          MSG_PRINTERDATA_INIT_RESET,
+                          (uint8 *)drivername, len+1);
 
        return True;
 }
@@ -1354,14 +1323,19 @@ static BOOL srv_spoolss_reset_printerdata(char* drivername)
  over all printers, resetting printer data as neessary 
  **********************************************************************/
  
-void reset_all_printerdata(int msg_type, pid_t src, void *buf, size_t len)
+void reset_all_printerdata(struct messaging_context *msg,
+                          void *private_data,
+                          uint32_t msg_type,
+                          struct server_id server_id,
+                          DATA_BLOB *data)
 {
        fstring drivername;
        int snum;
        int n_services = lp_numservices();
+       size_t len;
        
-       len = MIN( len, sizeof(drivername)-1 );
-       strncpy( drivername, buf, len );
+       len = MIN( data->length, sizeof(drivername)-1 );
+       strncpy( drivername, (const char *)data->data, len );
        
        DEBUG(10,("reset_all_printerdata: Got message for new driver [%s]\n", drivername ));
 
@@ -1424,7 +1398,7 @@ static DEVICEMODE* dup_devicemode(TALLOC_CTX *ctx, DEVICEMODE *devmode)
        
        /* bulk copy first */
        
-       d = TALLOC_MEMDUP(ctx, devmode, sizeof(DEVICEMODE));
+       d = (DEVICEMODE *)TALLOC_MEMDUP(ctx, devmode, sizeof(DEVICEMODE));
        if (!d)
                return NULL;
                
@@ -1433,6 +1407,9 @@ static DEVICEMODE* dup_devicemode(TALLOC_CTX *ctx, DEVICEMODE *devmode)
        len = unistrlen(devmode->devicename.buffer);
        if (len != -1) {
                d->devicename.buffer = TALLOC_ARRAY(ctx, uint16, len);
+               if (!d->devicename.buffer) {
+                       return NULL;
+               }
                if (unistrcpy(d->devicename.buffer, devmode->devicename.buffer) != len)
                        return NULL;
        }
@@ -1441,12 +1418,22 @@ static DEVICEMODE* dup_devicemode(TALLOC_CTX *ctx, DEVICEMODE *devmode)
        len = unistrlen(devmode->formname.buffer);
        if (len != -1) {
                d->devicename.buffer = TALLOC_ARRAY(ctx, uint16, len);
+               if (!d->devicename.buffer) {
+                       return NULL;
+               }
                if (unistrcpy(d->formname.buffer, devmode->formname.buffer) != len)
                        return NULL;
        }
 
-       d->private = TALLOC_MEMDUP(ctx, devmode->private, devmode->driverextra);
-       
+       if (devmode->driverextra) {
+               d->dev_private = (uint8 *)TALLOC_MEMDUP(ctx, devmode->dev_private,
+                                               devmode->driverextra);
+               if (!d->dev_private) {
+                       return NULL;
+               }       
+       } else {
+               d->dev_private = NULL;
+       }
        return d;
 }
 
@@ -1486,19 +1473,23 @@ static void copy_printer_default(TALLOC_CTX *ctx, PRINTER_DEFAULT *new_def, PRIN
  * SPOOL_Q_OPEN_PRINTER_EX structure
  ********************************************************************/
 
-static void convert_to_openprinterex(TALLOC_CTX *ctx, SPOOL_Q_OPEN_PRINTER_EX *q_u_ex, SPOOL_Q_OPEN_PRINTER *q_u)
+static WERROR convert_to_openprinterex(TALLOC_CTX *ctx, SPOOL_Q_OPEN_PRINTER_EX *q_u_ex, SPOOL_Q_OPEN_PRINTER *q_u)
 {
        if (!q_u_ex || !q_u)
-               return;
+               return WERR_OK;
 
        DEBUG(8,("convert_to_openprinterex\n"));
                                
        if ( q_u->printername ) {
-               q_u_ex->printername = TALLOC_P( ctx, UNISTR2 );
+               q_u_ex->printername = TALLOC_ZERO_P( ctx, UNISTR2 );
+               if (q_u_ex->printername == NULL)
+                       return WERR_NOMEM;
                copy_unistr2(q_u_ex->printername, q_u->printername);
        }
        
        copy_printer_default(ctx, &q_u_ex->printer_default, &q_u->printer_default);
+
+       return WERR_OK;
 }
 
 /********************************************************************
@@ -1520,7 +1511,9 @@ WERROR _spoolss_open_printer(pipes_struct *p, SPOOL_Q_OPEN_PRINTER *q_u, SPOOL_R
        
        /* convert the OpenPrinter() call to OpenPrinterEx() */
        
-       convert_to_openprinterex(p->mem_ctx, &q_u_ex, q_u);
+       r_u_ex.status = convert_to_openprinterex(p->mem_ctx, &q_u_ex, q_u);
+       if (!W_ERROR_IS_OK(r_u_ex.status))
+               return r_u_ex.status;
        
        r_u_ex.status = _spoolss_open_printer_ex(p, &q_u_ex, &r_u_ex);
        
@@ -1532,60 +1525,6 @@ WERROR _spoolss_open_printer(pipes_struct *p, SPOOL_Q_OPEN_PRINTER *q_u, SPOOL_R
 }
 
 /********************************************************************
- * spoolss_open_printer
- *
- * If the openprinterex rpc call contains a devmode,
- * it's a per-user one. This per-user devmode is derivated
- * from the global devmode. Openprinterex() contains a per-user 
- * devmode for when you do EMF printing and spooling.
- * In the EMF case, the NT workstation is only doing half the job
- * of rendering the page. The other half is done by running the printer
- * driver on the server.
- * The EMF file doesn't contain the page description (paper size, orientation, ...).
- * The EMF file only contains what is to be printed on the page.
- * So in order for the server to know how to print, the NT client sends
- * a devicemode attached to the openprinterex call.
- * But this devicemode is short lived, it's only valid for the current print job.
- *
- * If Samba would have supported EMF spooling, this devicemode would
- * have been attached to the handle, to sent it to the driver to correctly
- * rasterize the EMF file.
- *
- * As Samba only supports RAW spooling, we only receive a ready-to-print file,
- * we just act as a pass-thru between windows and the printer.
- *
- * In order to know that Samba supports only RAW spooling, NT has to call
- * getprinter() at level 2 (attribute field) or NT has to call startdoc()
- * and until NT sends a RAW job, we refuse it.
- *
- * But to call getprinter() or startdoc(), you first need a valid handle,
- * and to get an handle you have to call openprintex(). Hence why you have
- * a devicemode in the openprinterex() call.
- *
- *
- * Differences between NT4 and NT 2000.
- * NT4:
- * ---
- * On NT4, you only have a global devicemode. This global devicemode can be changed
- * by the administrator (or by a user with enough privs). Everytime a user
- * wants to print, the devicemode is resetted to the default. In Word, everytime
- * you print, the printer's characteristics are always reset to the global devicemode.
- *
- * NT 2000:
- * -------
- * In W2K, there is the notion of per-user devicemode. The first time you use
- * a printer, a per-user devicemode is build from the global devicemode.
- * If you change your per-user devicemode, it is saved in the registry, under the
- * H_KEY_CURRENT_KEY sub_tree. So that everytime you print, you have your default
- * printer preferences available.
- *
- * To change the per-user devicemode: it's the "Printing Preferences ..." button
- * on the General Tab of the printer properties windows.
- *
- * To change the global devicemode: it's the "Printing Defaults..." button
- * on the Advanced Tab of the printer properties window.
- *
- * JFM.
  ********************************************************************/
 
 WERROR _spoolss_open_printer_ex( pipes_struct *p, SPOOL_Q_OPEN_PRINTER_EX *q_u, SPOOL_R_OPEN_PRINTER_EX *r_u)
@@ -1595,7 +1534,6 @@ WERROR _spoolss_open_printer_ex( pipes_struct *p, SPOOL_Q_OPEN_PRINTER_EX *q_u,
 
        fstring name;
        int snum;
-       struct current_user user;
        Printer_entry *Printer=NULL;
 
        if ( !q_u->printername )
@@ -1604,7 +1542,7 @@ WERROR _spoolss_open_printer_ex( pipes_struct *p, SPOOL_Q_OPEN_PRINTER_EX *q_u,
        /* some sanity check because you can open a printer or a print server */
        /* aka: \\server\printer or \\server */
 
-       unistr2_to_ascii(name, q_u->printername, sizeof(name)-1);
+       unistr2_to_ascii(name, q_u->printername, sizeof(name));
 
        DEBUGADD(3,("checking name: %s\n",name));
 
@@ -1619,8 +1557,6 @@ WERROR _spoolss_open_printer_ex( pipes_struct *p, SPOOL_Q_OPEN_PRINTER_EX *q_u,
                return WERR_INVALID_PRINTER_NAME;
        }
 
-       get_current_user(&user, p);
-
        /*
         * First case: the user is opening the print server:
         *
@@ -1640,10 +1576,16 @@ WERROR _spoolss_open_printer_ex( pipes_struct *p, SPOOL_Q_OPEN_PRINTER_EX *q_u,
         * Second case: the user is opening a printer:
         * NT doesn't let us connect to a printer if the connecting user
         * doesn't have print permission.
+        * 
+        * Third case: user is opening a Port Monitor
+        * access checks same as opening a handle to the print server.
         */
 
-       if (Printer->printer_type == PRINTER_HANDLE_IS_PRINTSERVER
+       switch (Printer->printer_type 
        {
+       case SPLHND_SERVER:
+       case SPLHND_PORTMON_TCP:
+       case SPLHND_PORTMON_LOCAL:
                /* Printserver handles use global struct... */
 
                snum = -1;
@@ -1660,7 +1602,7 @@ WERROR _spoolss_open_printer_ex( pipes_struct *p, SPOOL_Q_OPEN_PRINTER_EX *q_u,
 
                if (printer_default->access_required &
                    ~(SERVER_ACCESS_ADMINISTER | SERVER_ACCESS_ENUMERATE)) {
-                       DEBUG(3, ("access DENIED for non-printserver bits"));
+                       DEBUG(3, ("access DENIED for non-printserver bits\n"));
                        close_printer_handle(p, handle);
                        return WERR_ACCESS_DENIED;
                }
@@ -1679,10 +1621,13 @@ WERROR _spoolss_open_printer_ex( pipes_struct *p, SPOOL_Q_OPEN_PRINTER_EX *q_u,
                        /* if the user is not root, doesn't have SE_PRINT_OPERATOR privilege,
                           and not a printer admin, then fail */
                        
-                       if ( user.uid != 0
-                               && !user_has_privileges( user.nt_user_token, &se_printop )
-                               && !user_in_list(uidtoname(user.uid), lp_printer_admin(snum), user.groups, user.ngroups) )
-                       {
+                       if ((p->pipe_user.ut.uid != 0) &&
+                           !user_has_privileges(p->pipe_user.nt_user_token,
+                                                &se_printop ) &&
+                           !token_contains_name_in_list(
+                                   uidtoname(p->pipe_user.ut.uid), NULL,
+                                   p->pipe_user.nt_user_token,
+                                   lp_printer_admin(snum))) {
                                close_printer_handle(p, handle);
                                return WERR_ACCESS_DENIED;
                        }
@@ -1698,14 +1643,13 @@ WERROR _spoolss_open_printer_ex( pipes_struct *p, SPOOL_Q_OPEN_PRINTER_EX *q_u,
                        ? "SERVER_ACCESS_ADMINISTER" : "SERVER_ACCESS_ENUMERATE" ));
                        
                /* We fall through to return WERR_OK */
-               
-       }
-       else
-       {
+               break;
+
+       case SPLHND_PRINTER:
                /* NT doesn't let us connect to a printer if the connecting user
                   doesn't have print permission.  */
 
-               if (!get_printer_snum(p, handle, &snum)) {
+               if (!get_printer_snum(p, handle, &snum, NULL)) {
                        close_printer_handle(p, handle);
                        return WERR_BADFID;
                }
@@ -1735,7 +1679,10 @@ WERROR _spoolss_open_printer_ex( pipes_struct *p, SPOOL_Q_OPEN_PRINTER_EX *q_u,
                        return WERR_ACCESS_DENIED;
                }
 
-               if (!user_ok(uidtoname(user.uid), snum, user.groups, user.ngroups) || !print_access_check(&user, snum, printer_default->access_required)) {
+               if (!user_ok_token(uidtoname(p->pipe_user.ut.uid),
+                                  p->pipe_user.nt_user_token, snum) ||
+                   !print_access_check(&p->pipe_user, snum,
+                                       printer_default->access_required)) {
                        DEBUG(3, ("access DENIED for printer open\n"));
                        close_printer_handle(p, handle);
                        return WERR_ACCESS_DENIED;
@@ -1755,6 +1702,11 @@ WERROR _spoolss_open_printer_ex( pipes_struct *p, SPOOL_Q_OPEN_PRINTER_EX *q_u,
                DEBUG(4,("Setting printer access = %s\n", (printer_default->access_required == PRINTER_ACCESS_ADMINISTER) 
                        ? "PRINTER_ACCESS_ADMINISTER" : "PRINTER_ACCESS_USE" ));
 
+               break;
+
+       default:
+               /* sanity check to prevent programmer error */
+               return WERR_BADFID;
        }
        
        Printer->access_granted = printer_default->access_required;
@@ -1764,7 +1716,7 @@ WERROR _spoolss_open_printer_ex( pipes_struct *p, SPOOL_Q_OPEN_PRINTER_EX *q_u,
         * save it here in case we get a job submission on this handle
         */
        
-        if ( (Printer->printer_type != PRINTER_HANDLE_IS_PRINTSERVER)
+        if ( (Printer->printer_type != SPLHND_SERVER)
                && q_u->printer_default.devmode_cont.devmode_ptr )
         { 
                convert_devicemode( Printer->sharename, q_u->printer_default.devmode_cont.devmode,
@@ -1789,26 +1741,38 @@ WERROR _spoolss_open_printer_ex( pipes_struct *p, SPOOL_Q_OPEN_PRINTER_EX *q_u,
 /****************************************************************************
 ****************************************************************************/
 
-static BOOL convert_printer_info(const SPOOL_PRINTER_INFO_LEVEL *uni,
+static bool convert_printer_info(const SPOOL_PRINTER_INFO_LEVEL *uni,
                                NT_PRINTER_INFO_LEVEL *printer, uint32 level)
 {
-       BOOL ret = True;
+       bool ret;
 
        switch (level) {
                case 2:
-                       ret = uni_2_asc_printer_info_2(uni->info_2, &printer->info_2);
-                       break;
-               default:
-                       break;
+                       /* allocate memory if needed.  Messy because 
+                          convert_printer_info is used to update an existing 
+                          printer or build a new one */
+
+                       if ( !printer->info_2 ) {
+                               printer->info_2 = TALLOC_ZERO_P( printer, NT_PRINTER_INFO_LEVEL_2 );
+                               if ( !printer->info_2 ) {
+                                       DEBUG(0,("convert_printer_info: talloc() failed!\n"));
+                                       return False;
+                               }
+                       }
+
+                       ret = uni_2_asc_printer_info_2(uni->info_2, printer->info_2);
+                       printer->info_2->setuptime = time(NULL);
+
+                       return ret;
        }
 
-       return ret;
+       return False;
 }
 
-static BOOL convert_printer_driver_info(const SPOOL_PRINTER_DRIVER_INFO_LEVEL *uni,
+static bool convert_printer_driver_info(const SPOOL_PRINTER_DRIVER_INFO_LEVEL *uni,
                                        NT_PRINTER_DRIVER_INFO_LEVEL *printer, uint32 level)
 {
-       BOOL result = True;
+       bool result = True;
 
        switch (level) {
                case 3:
@@ -1828,7 +1792,7 @@ static BOOL convert_printer_driver_info(const SPOOL_PRINTER_DRIVER_INFO_LEVEL *u
        return result;
 }
 
-BOOL convert_devicemode(const char *printername, const DEVICEMODE *devmode,
+bool convert_devicemode(const char *printername, const DEVICEMODE *devmode,
                                NT_DEVICEMODE **pp_nt_devmode)
 {
        NT_DEVICEMODE *nt_devmode = *pp_nt_devmode;
@@ -1885,12 +1849,12 @@ BOOL convert_devicemode(const char *printername, const DEVICEMODE *devmode,
         * has a new one. JRA.
         */
 
-       if ((devmode->driverextra != 0) && (devmode->private != NULL)) {
-               SAFE_FREE(nt_devmode->private);
+       if ((devmode->driverextra != 0) && (devmode->dev_private != NULL)) {
+               SAFE_FREE(nt_devmode->nt_dev_private);
                nt_devmode->driverextra=devmode->driverextra;
-               if((nt_devmode->private=SMB_MALLOC_ARRAY(uint8, nt_devmode->driverextra)) == NULL)
+               if((nt_devmode->nt_dev_private=SMB_MALLOC_ARRAY(uint8, nt_devmode->driverextra)) == NULL)
                        return False;
-               memcpy(nt_devmode->private, devmode->private, nt_devmode->driverextra);
+               memcpy(nt_devmode->nt_dev_private, devmode->dev_private, nt_devmode->driverextra);
        }
 
        *pp_nt_devmode = nt_devmode;
@@ -1912,11 +1876,11 @@ static WERROR _spoolss_enddocprinter_internal(pipes_struct *p, POLICY_HND *handl
                return WERR_BADFID;
        }
        
-       if (!get_printer_snum(p, handle, &snum))
+       if (!get_printer_snum(p, handle, &snum, NULL))
                return WERR_BADFID;
 
        Printer->document_started=False;
-       print_job_end(snum, Printer->jobid,True);
+       print_job_end(snum, Printer->jobid,NORMAL_CLOSE);
        /* error codes unhandled so far ... */
 
        return WERR_OK;
@@ -2011,14 +1975,23 @@ WERROR _spoolss_deleteprinterdriver(pipes_struct *p, SPOOL_Q_DELETEPRINTERDRIVER
        NT_PRINTER_DRIVER_INFO_LEVEL    info;
        NT_PRINTER_DRIVER_INFO_LEVEL    info_win2k;
        int                             version;
-       struct current_user             user;
        WERROR                          status;
        WERROR                          status_win2k = WERR_ACCESS_DENIED;
+       SE_PRIV                         se_printop = SE_PRINT_OPERATOR; 
        
-       get_current_user(&user, p);
-        
-       unistr2_to_ascii(driver, &q_u->driver, sizeof(driver)-1 );
-       unistr2_to_ascii(arch,   &q_u->arch,   sizeof(arch)-1   );
+       /* if the user is not root, doesn't have SE_PRINT_OPERATOR privilege,
+          and not a printer admin, then fail */
+                       
+       if ( (p->pipe_user.ut.uid != 0) 
+               && !user_has_privileges(p->pipe_user.nt_user_token, &se_printop ) 
+               && !token_contains_name_in_list( uidtoname(p->pipe_user.ut.uid), 
+                   NULL, p->pipe_user.nt_user_token, lp_printer_admin(-1)) ) 
+       {
+               return WERR_ACCESS_DENIED;
+       }
+
+       unistr2_to_ascii(driver, &q_u->driver, sizeof(driver));
+       unistr2_to_ascii(arch,   &q_u->arch,   sizeof(arch));
        
        /* check that we have a valid driver name first */
        
@@ -2059,16 +2032,19 @@ WERROR _spoolss_deleteprinterdriver(pipes_struct *p, SPOOL_Q_DELETEPRINTERDRIVER
                        /* if we get to here, we now have 2 driver info structures to remove */
                        /* remove the Win2k driver first*/
                
-                       status_win2k = delete_printer_driver(info_win2k.info_3, &user, 3, False );
+                       status_win2k = delete_printer_driver(info_win2k.info_3, &p->pipe_user, 3, False );
                        free_a_printer_driver( info_win2k, 3 );
                
                        /* this should not have failed---if it did, report to client */
                        if ( !W_ERROR_IS_OK(status_win2k) )
+                       {
+                               status = status_win2k;
                                goto done;
+                       }
                }
        }
        
-       status = delete_printer_driver(info.info_3, &user, version, False);
+       status = delete_printer_driver(info.info_3, &p->pipe_user, version, False);
        
        /* if at least one of the deletes succeeded return OK */
        
@@ -2093,15 +2069,24 @@ WERROR _spoolss_deleteprinterdriverex(pipes_struct *p, SPOOL_Q_DELETEPRINTERDRIV
        NT_PRINTER_DRIVER_INFO_LEVEL    info_win2k;
        int                             version;
        uint32                          flags = q_u->delete_flags;
-       BOOL                            delete_files;
-       struct current_user             user;
+       bool                            delete_files;
        WERROR                          status;
        WERROR                          status_win2k = WERR_ACCESS_DENIED;
+       SE_PRIV                         se_printop = SE_PRINT_OPERATOR; 
        
-       get_current_user(&user, p);
+       /* if the user is not root, doesn't have SE_PRINT_OPERATOR privilege,
+          and not a printer admin, then fail */
+                       
+       if ( (p->pipe_user.ut.uid != 0) 
+               && !user_has_privileges(p->pipe_user.nt_user_token, &se_printop ) 
+               && !token_contains_name_in_list( uidtoname(p->pipe_user.ut.uid), 
+                   NULL, p->pipe_user.nt_user_token, lp_printer_admin(-1)) ) 
+       {
+               return WERR_ACCESS_DENIED;
+       }
        
-       unistr2_to_ascii(driver, &q_u->driver, sizeof(driver)-1 );
-       unistr2_to_ascii(arch,   &q_u->arch,   sizeof(arch)-1   );
+       unistr2_to_ascii(driver, &q_u->driver, sizeof(driver));
+       unistr2_to_ascii(arch,   &q_u->arch,   sizeof(arch));
 
        /* check that we have a valid driver name first */
        if ((version=get_version_id(arch)) == -1) {
@@ -2181,7 +2166,7 @@ WERROR _spoolss_deleteprinterdriverex(pipes_struct *p, SPOOL_Q_DELETEPRINTERDRIV
                        /* if we get to here, we now have 2 driver info structures to remove */
                        /* remove the Win2k driver first*/
                
-                       status_win2k = delete_printer_driver(info_win2k.info_3, &user, 3, delete_files);
+                       status_win2k = delete_printer_driver(info_win2k.info_3, &p->pipe_user, 3, delete_files);
                        free_a_printer_driver( info_win2k, 3 );
                                
                        /* this should not have failed---if it did, report to client */
@@ -2191,7 +2176,7 @@ WERROR _spoolss_deleteprinterdriverex(pipes_struct *p, SPOOL_Q_DELETEPRINTERDRIV
                }
        }
 
-       status = delete_printer_driver(info.info_3, &user, version, delete_files);
+       status = delete_printer_driver(info.info_3, &p->pipe_user, version, delete_files);
 
        if ( W_ERROR_IS_OK(status) || W_ERROR_IS_OK(status_win2k) )
                status = WERR_OK;
@@ -2211,7 +2196,8 @@ static WERROR get_printer_dataex( TALLOC_CTX *ctx, NT_PRINTER_INFO_LEVEL *printe
                                  uint32 *needed, uint32 in_size  )
 {
        REGISTRY_VALUE          *val;
-       int                     size, data_len;
+       uint32                  size;
+       int                     data_len;
        
        if ( !(val = get_printer_data( printer->info_2, key, value)) )
                return WERR_BADFILE;
@@ -2260,11 +2246,11 @@ static WERROR delete_printer_dataex( NT_PRINTER_INFO_LEVEL *printer, const char
  Internal routine for storing printerdata
  ***************************************************************************/
 
-static WERROR set_printer_dataex( NT_PRINTER_INFO_LEVEL *printer, const char *key, const char *value, 
+WERROR set_printer_dataex( NT_PRINTER_INFO_LEVEL *printer, const char *key, const char *value, 
                                   uint32 type, uint8 *data, int real_len  )
 {
-       delete_printer_data( printer->info_2, key, value );
-       
+       /* the registry objects enforce uniqueness based on value name */
+
        return add_printer_data( printer->info_2, key, value, type, data, real_len );
 }
 
@@ -2280,15 +2266,16 @@ static WERROR getprinterdata_printer_server(TALLOC_CTX *ctx, fstring value, uint
                
        if (!StrCaseCmp(value, "W3SvcInstalled")) {
                *type = REG_DWORD;
-               if((*data = (uint8 *)TALLOC_ZERO(ctx, 4*sizeof(uint8) )) == NULL)
+               if ( !(*data = TALLOC_ARRAY(ctx, uint8, sizeof(uint32) )) )
                        return WERR_NOMEM;
+               SIVAL(*data, 0, 0x00);
                *needed = 0x4;
                return WERR_OK;
        }
 
        if (!StrCaseCmp(value, "BeepEnabled")) {
                *type = REG_DWORD;
-               if((*data = (uint8 *)TALLOC(ctx, 4*sizeof(uint8) )) == NULL)
+               if ( !(*data = TALLOC_ARRAY(ctx, uint8, sizeof(uint32) )) )
                        return WERR_NOMEM;
                SIVAL(*data, 0, 0x00);
                *needed = 0x4;                  
@@ -2297,7 +2284,7 @@ static WERROR getprinterdata_printer_server(TALLOC_CTX *ctx, fstring value, uint
 
        if (!StrCaseCmp(value, "EventLog")) {
                *type = REG_DWORD;
-               if((*data = (uint8 *)TALLOC(ctx, 4 )) == NULL)
+               if ( !(*data = TALLOC_ARRAY(ctx, uint8, sizeof(uint32) )) )
                        return WERR_NOMEM;
                /* formally was 0x1b */
                SIVAL(*data, 0, 0x0);
@@ -2307,7 +2294,7 @@ static WERROR getprinterdata_printer_server(TALLOC_CTX *ctx, fstring value, uint
 
        if (!StrCaseCmp(value, "NetPopup")) {
                *type = REG_DWORD;
-               if((*data = (uint8 *)TALLOC(ctx, 4 )) == NULL)
+               if ( !(*data = TALLOC_ARRAY(ctx, uint8, sizeof(uint32) )) )
                        return WERR_NOMEM;
                SIVAL(*data, 0, 0x00);
                *needed = 0x4;
@@ -2316,7 +2303,7 @@ static WERROR getprinterdata_printer_server(TALLOC_CTX *ctx, fstring value, uint
 
        if (!StrCaseCmp(value, "MajorVersion")) {
                *type = REG_DWORD;
-               if((*data = (uint8 *)TALLOC(ctx, 4 )) == NULL)
+               if ( !(*data = TALLOC_ARRAY(ctx, uint8, sizeof(uint32) )) )
                        return WERR_NOMEM;
 
                /* Windows NT 4.0 seems to not allow uploading of drivers
@@ -2335,7 +2322,7 @@ static WERROR getprinterdata_printer_server(TALLOC_CTX *ctx, fstring value, uint
 
        if (!StrCaseCmp(value, "MinorVersion")) {
                *type = REG_DWORD;
-               if((*data = (uint8 *)TALLOC(ctx, 4 )) == NULL)
+               if ( !(*data = TALLOC_ARRAY(ctx, uint8, sizeof(uint32) )) )
                        return WERR_NOMEM;
                SIVAL(*data, 0, 0);
                *needed = 0x4;
@@ -2353,9 +2340,9 @@ static WERROR getprinterdata_printer_server(TALLOC_CTX *ctx, fstring value, uint
                *type = REG_BINARY;
                *needed = 0x114;
 
-               if ( !(*data = TALLOC_ZERO_ARRAY(ctx, uint8, *needed)) )
+               if ( !(*data = TALLOC_ZERO_ARRAY(ctx, uint8, (*needed > in_size) ? *needed:in_size )) )
                        return WERR_NOMEM;
-               
+
                SIVAL(*data, 0, *needed);       /* size */
                SIVAL(*data, 4, 5);             /* Windows 2000 == 5.0 */
                SIVAL(*data, 8, 0);
@@ -2399,7 +2386,7 @@ static WERROR getprinterdata_printer_server(TALLOC_CTX *ctx, fstring value, uint
 
        if (!StrCaseCmp(value, "DsPresent")) {
                *type = REG_DWORD;
-               if((*data = (uint8 *)TALLOC(ctx, 4 )) == NULL)
+               if ( !(*data = TALLOC_ARRAY(ctx, uint8, sizeof(uint32) )) )
                        return WERR_NOMEM;
 
                /* only show the publish check box if we are a 
@@ -2476,13 +2463,13 @@ WERROR _spoolss_getprinterdata(pipes_struct *p, SPOOL_Q_GETPRINTERDATA *q_u, SPO
                goto done;
        }
        
-       unistr2_to_ascii(value, valuename, sizeof(value)-1);
+       unistr2_to_ascii(value, valuename, sizeof(value));
        
-       if ( Printer->printer_type == PRINTER_HANDLE_IS_PRINTSERVER )
+       if ( Printer->printer_type == SPLHND_SERVER )
                status = getprinterdata_printer_server( p->mem_ctx, value, type, data, needed, *out_size );
        else
        {
-               if ( !get_printer_snum(p,handle, &snum) ) {
+               if ( !get_printer_snum(p,handle, &snum, NULL) ) {
                        status = WERR_BADFID;
                        goto done;
                }
@@ -2522,9 +2509,8 @@ done:
                                if ( printer ) 
                                        free_a_printer( &printer, 2 );
                                return WERR_NOMEM;
-               } 
-               } 
-               else {
+                       } 
+               } else {
                        *data = NULL;
                }
        }
@@ -2541,98 +2527,66 @@ done:
  Connect to the client machine.
 **********************************************************/
 
-static BOOL spoolss_connect_to_client(struct cli_state *the_cli, 
+static bool spoolss_connect_to_client(struct rpc_pipe_client **pp_pipe,
                        struct in_addr *client_ip, const char *remote_machine)
 {
-       ZERO_STRUCTP(the_cli);
-       
-       if(cli_initialise(the_cli) == NULL) {
-               DEBUG(0,("spoolss_connect_to_client: unable to initialize client connection.\n"));
-               return False;
-       }
-       
-       if ( is_zero_ip(*client_ip) ) {
-               if(!resolve_name( remote_machine, &the_cli->dest_ip, 0x20)) {
-                       DEBUG(0,("spoolss_connect_to_client: Can't resolve address for %s\n", remote_machine));
-                       cli_shutdown(the_cli);
-               return False;
+       NTSTATUS ret;
+       struct cli_state *the_cli;
+       struct in_addr rm_addr;
+
+       if ( is_zero_ip_v4(*client_ip) ) {
+               if ( !resolve_name( remote_machine, &rm_addr, 0x20) ) {
+                       DEBUG(2,("spoolss_connect_to_client: Can't resolve address for %s\n", remote_machine));
+                       return False;
                }
 
-               if (ismyip(the_cli->dest_ip)) {
+               if ( ismyip_v4( rm_addr )) {
                        DEBUG(0,("spoolss_connect_to_client: Machine %s is one of our addresses. Cannot add to ourselves.\n", remote_machine));
-                       cli_shutdown(the_cli);
                        return False;
                }
-       }
-       else {
-               the_cli->dest_ip.s_addr = client_ip->s_addr;
+       } else {
+               rm_addr.s_addr = client_ip->s_addr;
                DEBUG(5,("spoolss_connect_to_client: Using address %s (no name resolution necessary)\n",
                        inet_ntoa(*client_ip) ));
        }
 
-       if (!cli_connect(the_cli, remote_machine, &the_cli->dest_ip)) {
-               DEBUG(0,("spoolss_connect_to_client: unable to connect to SMB server on machine %s. Error was : %s.\n", remote_machine, cli_errstr(the_cli) ));
-               cli_shutdown(the_cli);
-               return False;
-       }
-  
-       if (!attempt_netbios_session_request(the_cli, global_myname(), remote_machine, &the_cli->dest_ip)) {
-               DEBUG(0,("spoolss_connect_to_client: machine %s rejected the NetBIOS session request.\n", 
-                       remote_machine));
-               cli_shutdown(the_cli);
-               return False;
-       }
+       /* setup the connection */
 
-       the_cli->protocol = PROTOCOL_NT1;
-       cli_setup_signing_state(the_cli, lp_client_signing());
-  
-       if (!cli_negprot(the_cli)) {
-               DEBUG(0,("spoolss_connect_to_client: machine %s rejected the negotiate protocol. Error was : %s.\n", remote_machine, cli_errstr(the_cli) ));
-               cli_shutdown(the_cli);
-               return False;
-       }
+       ret = cli_full_connection( &the_cli, global_myname(), remote_machine, 
+               &rm_addr, 0, "IPC$", "IPC",
+               "", /* username */
+               "", /* domain */
+               "", /* password */
+               0, lp_client_signing(), NULL );
 
-       if (the_cli->protocol != PROTOCOL_NT1) {
-               DEBUG(0,("spoolss_connect_to_client: machine %s didn't negotiate NT protocol.\n", remote_machine));
-               cli_shutdown(the_cli);
-               return False;
-       }
-    
-       /*
-        * Do an anonymous session setup.
-        */
-    
-       if (!cli_session_setup(the_cli, "", "", 0, "", 0, "")) {
-               DEBUG(0,("spoolss_connect_to_client: machine %s rejected the session setup. Error was : %s.\n", remote_machine, cli_errstr(the_cli) ));
-               cli_shutdown(the_cli);
+       if ( !NT_STATUS_IS_OK( ret ) ) {
+               DEBUG(2,("spoolss_connect_to_client: connection to [%s] failed!\n", 
+                       remote_machine ));
                return False;
-       }
-    
-       if (!(the_cli->sec_mode & 1)) {
-               DEBUG(0,("spoolss_connect_to_client: machine %s isn't in user level security mode\n", remote_machine));
+       }       
+               
+       if ( the_cli->protocol != PROTOCOL_NT1 ) {
+               DEBUG(0,("spoolss_connect_to_client: machine %s didn't negotiate NT protocol.\n", remote_machine));
                cli_shutdown(the_cli);
                return False;
        }
     
-       if (!cli_send_tconX(the_cli, "IPC$", "IPC", "", 1)) {
-               DEBUG(0,("spoolss_connect_to_client: machine %s rejected the tconX on the IPC$ share. Error was : %s.\n", remote_machine, cli_errstr(the_cli) ));
-               cli_shutdown(the_cli);
-               return False;
-       }
-
        /*
         * Ok - we have an anonymous connection to the IPC$ share.
         * Now start the NT Domain stuff :-).
         */
 
-       if(cli_nt_session_open(the_cli, PI_SPOOLSS) == False) {
-               DEBUG(0,("spoolss_connect_to_client: unable to open the domain client session to machine %s. Error was : %s.\n", remote_machine, cli_errstr(the_cli)));
-               cli_nt_session_close(the_cli);
-               cli_ulogoff(the_cli);
+       if ( !(*pp_pipe = cli_rpc_pipe_open_noauth(the_cli, PI_SPOOLSS, &ret)) ) {
+               DEBUG(2,("spoolss_connect_to_client: unable to open the spoolss pipe on machine %s. Error was : %s.\n",
+                       remote_machine, nt_errstr(ret)));
                cli_shutdown(the_cli);
                return False;
        } 
 
+       /* make sure to save the cli_state pointer.  Keep its own talloc_ctx */
+
+       (*pp_pipe)->cli = the_cli;
+
        return True;
 }
 
@@ -2640,7 +2594,7 @@ static BOOL spoolss_connect_to_client(struct cli_state *the_cli,
  Connect to the client.
 ****************************************************************************/
 
-static BOOL srv_spoolss_replyopenprinter(int snum, const char *printer, 
+static bool srv_spoolss_replyopenprinter(int snum, const char *printer, 
                                        uint32 localprinter, uint32 type, 
                                        POLICY_HND *handle, struct in_addr *client_ip)
 {
@@ -2655,12 +2609,12 @@ static BOOL srv_spoolss_replyopenprinter(int snum, const char *printer,
 
                fstrcpy(unix_printer, printer+2); /* the +2 is to strip the leading 2 backslashs */
 
-               ZERO_STRUCT(notify_cli);
-
-               if(!spoolss_connect_to_client(&notify_cli, client_ip, unix_printer))
+               if ( !spoolss_connect_to_client( &notify_cli_pipe, client_ip, unix_printer ))
                        return False;
                        
-               message_register(MSG_PRINTER_NOTIFY2, receive_notify2_message_list);
+               messaging_register(smbd_messaging_context(), NULL,
+                                  MSG_PRINTER_NOTIFY2,
+                                  receive_notify2_message_list);
                /* Tell the connections db we're now interested in printer
                 * notify messages. */
                register_message_flags( True, FLAG_MSG_PRINT_NOTIFY );
@@ -2676,7 +2630,7 @@ static BOOL srv_spoolss_replyopenprinter(int snum, const char *printer,
 
        smb_connections++;
 
-       result = cli_spoolss_reply_open_printer(&notify_cli, notify_cli.mem_ctx, printer, localprinter, 
+       result = rpccli_spoolss_reply_open_printer(notify_cli_pipe, notify_cli_pipe->cli->mem_ctx, printer, localprinter, 
                        type, handle);
                        
        if (!W_ERROR_IS_OK(result))
@@ -2727,14 +2681,14 @@ WERROR _spoolss_rffpcnex(pipes_struct *p, SPOOL_Q_RFFPCNEX *q_u, SPOOL_R_RFFPCNE
        Printer->notify.option=dup_spool_notify_option(option);
 
        unistr2_to_ascii(Printer->notify.localmachine, localmachine, 
-                      sizeof(Printer->notify.localmachine)-1);
+                      sizeof(Printer->notify.localmachine));
 
        /* Connect to the client machine and send a ReplyOpenPrinter */
 
-       if ( Printer->printer_type == PRINTER_HANDLE_IS_PRINTSERVER)
+       if ( Printer->printer_type == SPLHND_SERVER)
                snum = -1;
-       else if ( (Printer->printer_type == PRINTER_HANDLE_IS_PRINTER) &&
-                       !get_printer_snum(p, handle, &snum) )
+       else if ( (Printer->printer_type == SPLHND_PRINTER) &&
+                       !get_printer_snum(p, handle, &snum, NULL) )
                return WERR_BADFID;
                
        client_ip.s_addr = inet_addr(p->conn->client_address);
@@ -2765,14 +2719,17 @@ void spoolss_notify_server_name(int snum,
        len = rpcstr_push(temp, printer->info_2->servername, sizeof(temp)-2, STR_TERMINATE);
 
        data->notify_data.data.length = len;
-       data->notify_data.data.string = (uint16 *)TALLOC(mem_ctx, len);
-
-       if (!data->notify_data.data.string) {
-               data->notify_data.data.length = 0;
-               return;
-       }
+       if (len) {
+               data->notify_data.data.string = (uint16 *)TALLOC(mem_ctx, len);
+               if (!data->notify_data.data.string) {
+                       data->notify_data.data.length = 0;
+                       return;
+               }
        
-       memcpy(data->notify_data.data.string, temp, len);
+               memcpy(data->notify_data.data.string, temp, len);
+       } else {
+               data->notify_data.data.string = NULL;
+       }
 }
 
 /*******************************************************************
@@ -2800,14 +2757,16 @@ void spoolss_notify_printer_name(int snum,
        len = rpcstr_push(temp, p, sizeof(temp)-2, STR_TERMINATE);
 
        data->notify_data.data.length = len;
-       data->notify_data.data.string = (uint16 *)TALLOC(mem_ctx, len);
-       
-       if (!data->notify_data.data.string) {
-               data->notify_data.data.length = 0;
-               return;
+       if (len) {
+               data->notify_data.data.string = (uint16 *)TALLOC(mem_ctx, len);
+               if (!data->notify_data.data.string) {
+                       data->notify_data.data.length = 0;
+                       return;
+               }
+               memcpy(data->notify_data.data.string, temp, len);
+       } else {
+               data->notify_data.data.string = NULL;
        }
-       
-       memcpy(data->notify_data.data.string, temp, len);
 }
 
 /*******************************************************************
@@ -2826,14 +2785,17 @@ void spoolss_notify_share_name(int snum,
        len = rpcstr_push(temp, lp_servicename(snum), sizeof(temp)-2, STR_TERMINATE);
 
        data->notify_data.data.length = len;
-       data->notify_data.data.string = (uint16 *)TALLOC(mem_ctx, len);
-       
-       if (!data->notify_data.data.string) {
-               data->notify_data.data.length = 0;
-               return;
+       if (len) {
+               data->notify_data.data.string = (uint16 *)TALLOC(mem_ctx, len);
+               if (!data->notify_data.data.string) {
+                       data->notify_data.data.length = 0;
+                       return;
+               }
+               memcpy(data->notify_data.data.string, temp, len);
+       } else {
+               data->notify_data.data.string = NULL;
        }
        
-       memcpy(data->notify_data.data.string, temp, len);
 }
 
 /*******************************************************************
@@ -2854,14 +2816,18 @@ void spoolss_notify_port_name(int snum,
        len = rpcstr_push(temp, printer->info_2->portname, sizeof(temp)-2, STR_TERMINATE);
 
        data->notify_data.data.length = len;
-       data->notify_data.data.string = (uint16 *)TALLOC(mem_ctx, len);
+       if (len) {
+               data->notify_data.data.string = (uint16 *)TALLOC(mem_ctx, len);
        
-       if (!data->notify_data.data.string) {
-               data->notify_data.data.length = 0;
-               return;
-       }
+               if (!data->notify_data.data.string) {
+                       data->notify_data.data.length = 0;
+                       return;
+               }
        
-       memcpy(data->notify_data.data.string, temp, len);
+               memcpy(data->notify_data.data.string, temp, len);
+       } else {
+               data->notify_data.data.string = NULL;
+       }
 }
 
 /*******************************************************************
@@ -2881,14 +2847,18 @@ void spoolss_notify_driver_name(int snum,
        len = rpcstr_push(temp, printer->info_2->drivername, sizeof(temp)-2, STR_TERMINATE);
 
        data->notify_data.data.length = len;
-       data->notify_data.data.string = (uint16 *)TALLOC(mem_ctx, len);
+       if (len) {
+               data->notify_data.data.string = (uint16 *)TALLOC(mem_ctx, len);
        
-       if (!data->notify_data.data.string) {
-               data->notify_data.data.length = 0;
-               return;
-       }
+               if (!data->notify_data.data.string) {
+                       data->notify_data.data.length = 0;
+                       return;
+               }
        
-       memcpy(data->notify_data.data.string, temp, len);
+               memcpy(data->notify_data.data.string, temp, len);
+       } else {
+               data->notify_data.data.string = NULL;
+       }
 }
 
 /*******************************************************************
@@ -2910,14 +2880,18 @@ void spoolss_notify_comment(int snum,
                len = rpcstr_push(temp, printer->info_2->comment, sizeof(temp)-2, STR_TERMINATE);
 
        data->notify_data.data.length = len;
-       data->notify_data.data.string = (uint16 *)TALLOC(mem_ctx, len);
+       if (len) {
+               data->notify_data.data.string = (uint16 *)TALLOC(mem_ctx, len);
        
-       if (!data->notify_data.data.string) {
-               data->notify_data.data.length = 0;
-               return;
-       }
+               if (!data->notify_data.data.string) {
+                       data->notify_data.data.length = 0;
+                       return;
+               }
        
-       memcpy(data->notify_data.data.string, temp, len);
+               memcpy(data->notify_data.data.string, temp, len);
+       } else {
+               data->notify_data.data.string = NULL;
+       }
 }
 
 /*******************************************************************
@@ -2937,14 +2911,18 @@ void spoolss_notify_location(int snum,
        len = rpcstr_push(temp, printer->info_2->location,sizeof(temp)-2, STR_TERMINATE);
 
        data->notify_data.data.length = len;
-       data->notify_data.data.string = (uint16 *)TALLOC(mem_ctx, len);
+       if (len) {
+               data->notify_data.data.string = (uint16 *)TALLOC(mem_ctx, len);
        
-       if (!data->notify_data.data.string) {
-               data->notify_data.data.length = 0;
-               return;
-       }
+               if (!data->notify_data.data.string) {
+                       data->notify_data.data.length = 0;
+                       return;
+               }
        
-       memcpy(data->notify_data.data.string, temp, len);
+               memcpy(data->notify_data.data.string, temp, len);
+       } else {
+               data->notify_data.data.string = NULL;
+       }
 }
 
 /*******************************************************************
@@ -2958,6 +2936,9 @@ static void spoolss_notify_devmode(int snum,
                                   NT_PRINTER_INFO_LEVEL *printer,
                                   TALLOC_CTX *mem_ctx)
 {
+       /* for a dummy implementation we have to zero the fields */
+       data->notify_data.data.length = 0;
+       data->notify_data.data.string = NULL;
 }
 
 /*******************************************************************
@@ -2976,14 +2957,18 @@ void spoolss_notify_sepfile(int snum,
        len = rpcstr_push(temp, printer->info_2->sepfile, sizeof(temp)-2, STR_TERMINATE);
 
        data->notify_data.data.length = len;
-       data->notify_data.data.string = (uint16 *)TALLOC(mem_ctx, len);
+       if (len) {
+               data->notify_data.data.string = (uint16 *)TALLOC(mem_ctx, len);
        
-       if (!data->notify_data.data.string) {
-               data->notify_data.data.length = 0;
-               return;
-       }
+               if (!data->notify_data.data.string) {
+                       data->notify_data.data.length = 0;
+                       return;
+               }
        
-       memcpy(data->notify_data.data.string, temp, len);
+               memcpy(data->notify_data.data.string, temp, len);
+       } else {
+               data->notify_data.data.string = NULL;
+       }
 }
 
 /*******************************************************************
@@ -3003,14 +2988,18 @@ void spoolss_notify_print_processor(int snum,
        len = rpcstr_push(temp,  printer->info_2->printprocessor, sizeof(temp)-2, STR_TERMINATE);
 
        data->notify_data.data.length = len;
-       data->notify_data.data.string = (uint16 *)TALLOC(mem_ctx, len);
+       if (len) {
+               data->notify_data.data.string = (uint16 *)TALLOC(mem_ctx, len);
        
-       if (!data->notify_data.data.string) {
-               data->notify_data.data.length = 0;
-               return;
-       }
+               if (!data->notify_data.data.string) {
+                       data->notify_data.data.length = 0;
+                       return;
+               }
        
-       memcpy(data->notify_data.data.string, temp, len);
+               memcpy(data->notify_data.data.string, temp, len);
+       } else {
+               data->notify_data.data.string = NULL;
+       }
 }
 
 /*******************************************************************
@@ -3030,14 +3019,18 @@ void spoolss_notify_parameters(int snum,
        len = rpcstr_push(temp,  printer->info_2->parameters, sizeof(temp)-2, STR_TERMINATE);
 
        data->notify_data.data.length = len;
-       data->notify_data.data.string = (uint16 *)TALLOC(mem_ctx, len);
+       if (len) {
+               data->notify_data.data.string = (uint16 *)TALLOC(mem_ctx, len);
        
-       if (!data->notify_data.data.string) {
-               data->notify_data.data.length = 0;
-               return;
-       }
+               if (!data->notify_data.data.string) {
+                       data->notify_data.data.length = 0;
+                       return;
+               }
        
-       memcpy(data->notify_data.data.string, temp, len);
+               memcpy(data->notify_data.data.string, temp, len);
+       } else {
+               data->notify_data.data.string = NULL;
+       }
 }
 
 /*******************************************************************
@@ -3057,14 +3050,18 @@ void spoolss_notify_datatype(int snum,
        len = rpcstr_push(temp, printer->info_2->datatype, sizeof(pstring)-2, STR_TERMINATE);
 
        data->notify_data.data.length = len;
-       data->notify_data.data.string = (uint16 *)TALLOC(mem_ctx, len);
+       if (len) {
+               data->notify_data.data.string = (uint16 *)TALLOC(mem_ctx, len);
        
-       if (!data->notify_data.data.string) {
-               data->notify_data.data.length = 0;
-               return;
-       }
+               if (!data->notify_data.data.string) {
+                       data->notify_data.data.length = 0;
+                       return;
+               }
        
-       memcpy(data->notify_data.data.string, temp, len);
+               memcpy(data->notify_data.data.string, temp, len);
+       } else {
+               data->notify_data.data.string = NULL;
+       }
 }
 
 /*******************************************************************
@@ -3079,8 +3076,8 @@ static void spoolss_notify_security_desc(int snum,
                                         NT_PRINTER_INFO_LEVEL *printer,
                                         TALLOC_CTX *mem_ctx)
 {
-       data->notify_data.sd.size = printer->info_2->secdesc_buf->len;
-       data->notify_data.sd.desc = dup_sec_desc( mem_ctx, printer->info_2->secdesc_buf->sec ) ;
+       data->notify_data.sd.size = printer->info_2->secdesc_buf->sd_size;
+       data->notify_data.sd.desc = dup_sec_desc( mem_ctx, printer->info_2->secdesc_buf->sd ) ;
 }
 
 /*******************************************************************
@@ -3217,14 +3214,18 @@ static void spoolss_notify_username(int snum,
        len = rpcstr_push(temp, queue->fs_user, sizeof(temp)-2, STR_TERMINATE);
 
        data->notify_data.data.length = len;
-       data->notify_data.data.string = (uint16 *)TALLOC(mem_ctx, len);
+       if (len) {
+               data->notify_data.data.string = (uint16 *)TALLOC(mem_ctx, len);
        
-       if (!data->notify_data.data.string) {
-               data->notify_data.data.length = 0;
-               return;
-       }
+               if (!data->notify_data.data.string) {
+                       data->notify_data.data.length = 0;
+                       return;
+               }
        
-       memcpy(data->notify_data.data.string, temp, len);
+               memcpy(data->notify_data.data.string, temp, len);
+       } else {
+               data->notify_data.data.string = NULL;
+       }
 }
 
 /*******************************************************************
@@ -3257,14 +3258,18 @@ static void spoolss_notify_job_name(int snum,
        len = rpcstr_push(temp, queue->fs_file, sizeof(temp)-2, STR_TERMINATE);
 
        data->notify_data.data.length = len;
-       data->notify_data.data.string = (uint16 *)TALLOC(mem_ctx, len);
+       if (len) {
+               data->notify_data.data.string = (uint16 *)TALLOC(mem_ctx, len);
        
-       if (!data->notify_data.data.string) {
-               data->notify_data.data.length = 0;
-               return;
-       }
+               if (!data->notify_data.data.string) {
+                       data->notify_data.data.length = 0;
+                       return;
+               }
        
-       memcpy(data->notify_data.data.string, temp, len);
+               memcpy(data->notify_data.data.string, temp, len);
+       } else {
+               data->notify_data.data.string = NULL;
+       }
 }
 
 /*******************************************************************
@@ -3307,14 +3312,18 @@ static void spoolss_notify_job_status_string(int snum,
        len = rpcstr_push(temp, p, sizeof(temp) - 2, STR_TERMINATE);
 
        data->notify_data.data.length = len;
-       data->notify_data.data.string = (uint16 *)TALLOC(mem_ctx, len);
+       if (len) {
+               data->notify_data.data.string = (uint16 *)TALLOC(mem_ctx, len);
        
-       if (!data->notify_data.data.string) {
-               data->notify_data.data.length = 0;
-               return;
-       }
+               if (!data->notify_data.data.string) {
+                       data->notify_data.data.length = 0;
+                       return;
+               }
        
-       memcpy(data->notify_data.data.string, temp, len);
+               memcpy(data->notify_data.data.string, temp, len);
+       } else {
+               data->notify_data.data.string = NULL;
+       }
 }
 
 /*******************************************************************
@@ -3507,25 +3516,22 @@ static uint32 size_of_notify_info_data(uint16 type, uint16 field)
 {
        int i=0;
 
-       for (i = 0; i < sizeof(notify_info_data_table); i++) 
-       {
+       for (i = 0; i < (sizeof(notify_info_data_table)/sizeof(struct s_notify_info_data_table)); i++) {
                if ( (notify_info_data_table[i].type == type)
-                       && (notify_info_data_table[i].field == field) ) 
-               {
-                       switch(notify_info_data_table[i].size) 
-                       {
-                       case NOTIFY_ONE_VALUE:
-                       case NOTIFY_TWO_VALUE:
-                               return 1;
-                       case NOTIFY_STRING:
-                               return 2;
-
-                       /* The only pointer notify data I have seen on
-                          the wire is the submitted time and this has
-                          the notify size set to 4. -tpot */
-
-                       case NOTIFY_POINTER:
-                               return 4;
+                       && (notify_info_data_table[i].field == field) ) {
+                       switch(notify_info_data_table[i].size) {
+                               case NOTIFY_ONE_VALUE:
+                               case NOTIFY_TWO_VALUE:
+                                       return 1;
+                               case NOTIFY_STRING:
+                                       return 2;
+
+                               /* The only pointer notify data I have seen on
+                                  the wire is the submitted time and this has
+                                  the notify size set to 4. -tpot */
+
+                               case NOTIFY_POINTER:
+                                       return 4;
                                        
                                case NOTIFY_SECDESC:
                                        return 5;
@@ -3542,23 +3548,23 @@ static uint32 size_of_notify_info_data(uint16 type, uint16 field)
  Return the type of notify_info_data.
 ********************************************************************/
 
-static int type_of_notify_info_data(uint16 type, uint16 field)
+static uint32 type_of_notify_info_data(uint16 type, uint16 field)
 {
-       int i=0;
+       uint32 i=0;
 
-       for (i = 0; i < sizeof(notify_info_data_table); i++) {
+       for (i = 0; i < (sizeof(notify_info_data_table)/sizeof(struct s_notify_info_data_table)); i++) {
                if (notify_info_data_table[i].type == type &&
                    notify_info_data_table[i].field == field)
                        return notify_info_data_table[i].size;
        }
 
-       return False;
+       return 0;
 }
 
 /****************************************************************************
 ****************************************************************************/
 
-static int search_notify(uint16 type, uint16 field, int *value)
+static bool search_notify(uint16 type, uint16 field, int *value)
 {      
        int i;
 
@@ -3587,17 +3593,15 @@ void construct_info_data(SPOOL_NOTIFY_INFO_DATA *info_data, uint16 type, uint16
        info_data->enc_type = type_of_notify_info_data(type, field);
 
        info_data->id = id;
-
 }
 
-
 /*******************************************************************
  *
  * fill a notify_info struct with info asked
  *
  ********************************************************************/
 
-static BOOL construct_notify_printer_info(Printer_entry *print_hnd, SPOOL_NOTIFY_INFO *info, int
+static bool construct_notify_printer_info(Printer_entry *print_hnd, SPOOL_NOTIFY_INFO *info, int
                                          snum, SPOOL_NOTIFY_OPTION_TYPE
                                          *option_type, uint32 id,
                                          TALLOC_CTX *mem_ctx) 
@@ -3606,7 +3610,7 @@ static BOOL construct_notify_printer_info(Printer_entry *print_hnd, SPOOL_NOTIFY
        uint16 type;
        uint16 field;
 
-       SPOOL_NOTIFY_INFO_DATA *current_data, *tid;
+       SPOOL_NOTIFY_INFO_DATA *current_data;
        NT_PRINTER_INFO_LEVEL *printer = NULL;
        print_queue_struct *queue=NULL;
 
@@ -3627,11 +3631,11 @@ static BOOL construct_notify_printer_info(Printer_entry *print_hnd, SPOOL_NOTIFY
                if (!search_notify(type, field, &j) )
                        continue;
 
-               if((tid=SMB_REALLOC_ARRAY(info->data, SPOOL_NOTIFY_INFO_DATA, info->count+1)) == NULL) {
+               if((info->data=SMB_REALLOC_ARRAY(info->data, SPOOL_NOTIFY_INFO_DATA, info->count+1)) == NULL) {
                        DEBUG(2,("construct_notify_printer_info: failed to enlarge buffer info->data!\n"));
+                       free_a_printer(&printer, 2);
                        return False;
-               } else 
-                       info->data = tid;
+               }
 
                current_data = &info->data[info->count];
 
@@ -3656,7 +3660,7 @@ static BOOL construct_notify_printer_info(Printer_entry *print_hnd, SPOOL_NOTIFY
  *
  ********************************************************************/
 
-static BOOL construct_notify_jobs_info(print_queue_struct *queue,
+static bool construct_notify_jobs_info(print_queue_struct *queue,
                                       SPOOL_NOTIFY_INFO *info,
                                       NT_PRINTER_INFO_LEVEL *printer,
                                       int snum, SPOOL_NOTIFY_OPTION_TYPE
@@ -3667,7 +3671,7 @@ static BOOL construct_notify_jobs_info(print_queue_struct *queue,
        uint16 type;
        uint16 field;
 
-       SPOOL_NOTIFY_INFO_DATA *current_data, *tid;
+       SPOOL_NOTIFY_INFO_DATA *current_data;
        
        DEBUG(4,("construct_notify_jobs_info\n"));
        
@@ -3683,11 +3687,10 @@ static BOOL construct_notify_jobs_info(print_queue_struct *queue,
                if (!search_notify(type, field, &j) )
                        continue;
 
-               if((tid=SMB_REALLOC_ARRAY(info->data, SPOOL_NOTIFY_INFO_DATA, info->count+1)) == NULL) {
+               if((info->data=SMB_REALLOC_ARRAY(info->data, SPOOL_NOTIFY_INFO_DATA, info->count+1)) == NULL) {
                        DEBUG(2,("construct_notify_jobs_info: failed to enlarg buffer info->data!\n"));
                        return False;
                }
-               else info->data = tid;
 
                current_data=&(info->data[info->count]);
 
@@ -3825,7 +3828,7 @@ static WERROR printer_notify_info(pipes_struct *p, POLICY_HND *hnd, SPOOL_NOTIFY
        if ( !option )
                return WERR_BADFID;
 
-       get_printer_snum(p, hnd, &snum);
+       get_printer_snum(p, hnd, &snum, NULL);
 
        for (i=0; i<option->count; i++) {
                option_type=&option->ctr.type[i];
@@ -3923,11 +3926,11 @@ WERROR _spoolss_rfnpcnex( pipes_struct *p, SPOOL_Q_RFNPCNEX *q_u, SPOOL_R_RFNPCN
        /* just ignore the SPOOL_NOTIFY_OPTION */
        
        switch (Printer->printer_type) {
-               case PRINTER_HANDLE_IS_PRINTSERVER:
+               case SPLHND_SERVER:
                        result = printserver_notify_info(p, handle, info, p->mem_ctx);
                        break;
                        
-               case PRINTER_HANDLE_IS_PRINTER:
+               case SPLHND_PRINTER:
                        result = printer_notify_info(p, handle, info, p->mem_ctx);
                        break;
        }
@@ -3943,7 +3946,7 @@ done:
  * fill a printer_info_0 struct
  ********************************************************************/
 
-static BOOL construct_printer_info_0(Printer_entry *print_hnd, PRINTER_INFO_0 *printer, int snum)
+static bool construct_printer_info_0(Printer_entry *print_hnd, PRINTER_INFO_0 *printer, int snum)
 {
        pstring chaine;
        int count;
@@ -4048,7 +4051,7 @@ static BOOL construct_printer_info_0(Printer_entry *print_hnd, PRINTER_INFO_0 *p
  * construct_printer_info_1
  * fill a printer_info_1 struct
  ********************************************************************/
-static BOOL construct_printer_info_1(Printer_entry *print_hnd, uint32 flags, PRINTER_INFO_1 *printer, int snum)
+static bool construct_printer_info_1(Printer_entry *print_hnd, uint32 flags, PRINTER_INFO_1 *printer, int snum)
 {
        pstring chaine;
        pstring chaine2;
@@ -4089,7 +4092,7 @@ static void free_dev_mode(DEVICEMODE *dev)
        if (dev == NULL)
                return;
 
-       SAFE_FREE(dev->private);
+       SAFE_FREE(dev->dev_private);
        SAFE_FREE(dev); 
 }
 
@@ -4099,7 +4102,7 @@ static void free_dev_mode(DEVICEMODE *dev)
  should be valid upon entry
 ****************************************************************************/
 
-static BOOL convert_nt_devicemode( DEVICEMODE *devmode, NT_DEVICEMODE *ntdevmode )
+static bool convert_nt_devicemode( DEVICEMODE *devmode, NT_DEVICEMODE *ntdevmode )
 {
        if ( !devmode || !ntdevmode )
                return False;
@@ -4132,8 +4135,8 @@ static BOOL convert_nt_devicemode( DEVICEMODE *devmode, NT_DEVICEMODE *ntdevmode
        devmode->mediatype        = ntdevmode->mediatype;
        devmode->dithertype       = ntdevmode->dithertype;
 
-       if (ntdevmode->private != NULL) {
-               if ((devmode->private=(uint8 *)memdup(ntdevmode->private, ntdevmode->driverextra)) == NULL)
+       if (ntdevmode->nt_dev_private != NULL) {
+               if ((devmode->dev_private=(uint8 *)memdup(ntdevmode->nt_dev_private, ntdevmode->driverextra)) == NULL)
                        return False;
        }
        
@@ -4144,7 +4147,7 @@ static BOOL convert_nt_devicemode( DEVICEMODE *devmode, NT_DEVICEMODE *ntdevmode
  Create a DEVMODE struct. Returns malloced memory.
 ****************************************************************************/
 
-DEVICEMODE *construct_dev_mode(int snum)
+DEVICEMODE *construct_dev_mode(const char *servicename)
 {
        NT_PRINTER_INFO_LEVEL   *printer = NULL;
        DEVICEMODE              *devmode = NULL;
@@ -4153,7 +4156,7 @@ DEVICEMODE *construct_dev_mode(int snum)
        
        DEBUGADD(8,("getting printer characteristics\n"));
 
-       if (!W_ERROR_IS_OK(get_a_printer(NULL, &printer, 2, lp_const_servicename(snum)))) 
+       if (!W_ERROR_IS_OK(get_a_printer(NULL, &printer, 2, servicename))) 
                return NULL;
 
        if ( !printer->info_2->devmode ) {
@@ -4186,7 +4189,7 @@ done:
  * fill a printer_info_2 struct
  ********************************************************************/
 
-static BOOL construct_printer_info_2(Printer_entry *print_hnd, PRINTER_INFO_2 *printer, int snum)
+static bool construct_printer_info_2(Printer_entry *print_hnd, PRINTER_INFO_2 *printer, int snum)
 {
        int count;
        NT_PRINTER_INFO_LEVEL *ntprinter = NULL;
@@ -4225,22 +4228,24 @@ static BOOL construct_printer_info_2(Printer_entry *print_hnd, PRINTER_INFO_2 *p
        printer->cjobs = count;                                                 /* jobs */
        printer->averageppm = ntprinter->info_2->averageppm;                    /* average pages per minute */
                        
-       if((printer->devmode = construct_dev_mode(snum)) == NULL) {
+       if ( !(printer->devmode = construct_dev_mode(
+                      lp_const_servicename(snum))) )
                DEBUG(8, ("Returning NULL Devicemode!\n"));
-       }
 
-       if (ntprinter->info_2->secdesc_buf && ntprinter->info_2->secdesc_buf->len != 0) {
-               /* steal the printer info sec_desc structure.  [badly done]. */
-               printer->secdesc = ntprinter->info_2->secdesc_buf->sec;
-               ntprinter->info_2->secdesc_buf->sec = NULL; /* Stolen memory. */
-               ntprinter->info_2->secdesc_buf->len = 0; /* Stolen memory. */
-               ntprinter->info_2->secdesc_buf->max_len = 0; /* Stolen memory. */
-       }
-       else {
-               printer->secdesc = NULL;
+       printer->secdesc = NULL;
+
+       if ( ntprinter->info_2->secdesc_buf 
+               && ntprinter->info_2->secdesc_buf->sd_size != 0 ) 
+       {
+               /* don't use talloc_steal() here unless you do a deep steal of all 
+                  the SEC_DESC members */
+
+               printer->secdesc = dup_sec_desc( talloc_tos(),
+                       ntprinter->info_2->secdesc_buf->sd );
        }
 
        free_a_printer(&ntprinter, 2);
+
        return True;
 }
 
@@ -4249,7 +4254,7 @@ static BOOL construct_printer_info_2(Printer_entry *print_hnd, PRINTER_INFO_2 *p
  * fill a printer_info_3 struct
  ********************************************************************/
 
-static BOOL construct_printer_info_3(Printer_entry *print_hnd, PRINTER_INFO_3 **pp_printer, int snum)
+static bool construct_printer_info_3(Printer_entry *print_hnd, PRINTER_INFO_3 **pp_printer, int snum)
 {
        NT_PRINTER_INFO_LEVEL *ntprinter = NULL;
        PRINTER_INFO_3 *printer = NULL;
@@ -4260,37 +4265,20 @@ static BOOL construct_printer_info_3(Printer_entry *print_hnd, PRINTER_INFO_3 **
        *pp_printer = NULL;
        if ((printer = SMB_MALLOC_P(PRINTER_INFO_3)) == NULL) {
                DEBUG(2,("construct_printer_info_3: malloc fail.\n"));
+               free_a_printer(&ntprinter, 2);
                return False;
        }
 
        ZERO_STRUCTP(printer);
        
-       printer->flags = 4; /* These are the components of the SD we are returning. */
-       if (ntprinter->info_2->secdesc_buf && ntprinter->info_2->secdesc_buf->len != 0) {
-               /* steal the printer info sec_desc structure.  [badly done]. */
-               printer->secdesc = ntprinter->info_2->secdesc_buf->sec;
-
-#if 0
-               /*
-                * Set the flags for the components we are returning.
-                */
-
-               if (printer->secdesc->owner_sid)
-                       printer->flags |= OWNER_SECURITY_INFORMATION;
-
-               if (printer->secdesc->grp_sid)
-                       printer->flags |= GROUP_SECURITY_INFORMATION;
-
-               if (printer->secdesc->dacl)
-                       printer->flags |= DACL_SECURITY_INFORMATION;
+       /* These are the components of the SD we are returning. */
 
-               if (printer->secdesc->sacl)
-                       printer->flags |= SACL_SECURITY_INFORMATION;
-#endif
+       if (ntprinter->info_2->secdesc_buf && ntprinter->info_2->secdesc_buf->sd_size != 0) {
+               /* don't use talloc_steal() here unless you do a deep steal of all 
+                  the SEC_DESC members */
 
-               ntprinter->info_2->secdesc_buf->sec = NULL; /* Stolen the malloced memory. */
-               ntprinter->info_2->secdesc_buf->len = 0; /* Stolen the malloced memory. */
-               ntprinter->info_2->secdesc_buf->max_len = 0; /* Stolen the malloced memory. */
+               printer->secdesc = dup_sec_desc( talloc_tos(),
+                       ntprinter->info_2->secdesc_buf->sd );
        }
 
        free_a_printer(&ntprinter, 2);
@@ -4304,7 +4292,7 @@ static BOOL construct_printer_info_3(Printer_entry *print_hnd, PRINTER_INFO_3 **
  * fill a printer_info_4 struct
  ********************************************************************/
 
-static BOOL construct_printer_info_4(Printer_entry *print_hnd, PRINTER_INFO_4 *printer, int snum)
+static bool construct_printer_info_4(Printer_entry *print_hnd, PRINTER_INFO_4 *printer, int snum)
 {
        NT_PRINTER_INFO_LEVEL *ntprinter = NULL;
 
@@ -4324,7 +4312,7 @@ static BOOL construct_printer_info_4(Printer_entry *print_hnd, PRINTER_INFO_4 *p
  * fill a printer_info_5 struct
  ********************************************************************/
 
-static BOOL construct_printer_info_5(Printer_entry *print_hnd, PRINTER_INFO_5 *printer, int snum)
+static bool construct_printer_info_5(Printer_entry *print_hnd, PRINTER_INFO_5 *printer, int snum)
 {
        NT_PRINTER_INFO_LEVEL *ntprinter = NULL;
 
@@ -4345,15 +4333,41 @@ static BOOL construct_printer_info_5(Printer_entry *print_hnd, PRINTER_INFO_5 *p
        return True;
 }
 
+/********************************************************************
+ * construct_printer_info_6
+ * fill a printer_info_6 struct
+ ********************************************************************/
+
+static bool construct_printer_info_6(Printer_entry *print_hnd,
+                                    PRINTER_INFO_6 *printer,
+                                    int snum)
+{
+       NT_PRINTER_INFO_LEVEL *ntprinter = NULL;
+       int count;
+       print_status_struct status;
+
+       if (!W_ERROR_IS_OK(get_a_printer(print_hnd, &ntprinter, 2,
+                                        lp_const_servicename(snum))))
+               return False;
+
+       count = print_queue_length(snum, &status);
+
+       printer->status = nt_printq_status(status.status);
+               
+       free_a_printer(&ntprinter, 2);
+
+       return True;
+}
+
 /********************************************************************
  * construct_printer_info_7
  * fill a printer_info_7 struct
  ********************************************************************/
 
-static BOOL construct_printer_info_7(Printer_entry *print_hnd, PRINTER_INFO_7 *printer, int snum)
+static bool construct_printer_info_7(Printer_entry *print_hnd, PRINTER_INFO_7 *printer, int snum)
 {
        char *guid_str = NULL;
-       struct uuid guid; 
+       struct GUID guid; 
        
        if (is_printer_published(print_hnd, snum, &guid)) {
                asprintf(&guid_str, "{%s}", smb_uuid_string_static(guid));
@@ -4377,7 +4391,7 @@ static WERROR enum_all_printers_info_1(uint32 flags, RPC_BUFFER *buffer, uint32
        int snum;
        int i;
        int n_services=lp_numservices();
-       PRINTER_INFO_1 *tp, *printers=NULL;
+       PRINTER_INFO_1 *printers=NULL;
        PRINTER_INFO_1 current_prt;
        WERROR result = WERR_OK;
        
@@ -4388,13 +4402,11 @@ static WERROR enum_all_printers_info_1(uint32 flags, RPC_BUFFER *buffer, uint32
                        DEBUG(4,("Found a printer in smb.conf: %s[%x]\n", lp_servicename(snum), snum));
 
                        if (construct_printer_info_1(NULL, flags, &current_prt, snum)) {
-                               if((tp=SMB_REALLOC_ARRAY(printers, PRINTER_INFO_1, *returned +1)) == NULL) {
+                               if((printers=SMB_REALLOC_ARRAY(printers, PRINTER_INFO_1, *returned +1)) == NULL) {
                                        DEBUG(2,("enum_all_printers_info_1: failed to enlarge printers buffer!\n"));
-                                       SAFE_FREE(printers);
                                        *returned=0;
                                        return WERR_NOMEM;
                                }
-                               else printers = tp;
                                DEBUG(4,("ReAlloced memory for [%d] PRINTER_INFO_1\n", *returned));             
 
                                memcpy(&printers[*returned], &current_prt, sizeof(PRINTER_INFO_1));
@@ -4565,24 +4577,27 @@ static WERROR enum_all_printers_info_2(RPC_BUFFER *buffer, uint32 offered, uint3
        int snum;
        int i;
        int n_services=lp_numservices();
-       PRINTER_INFO_2 *tp, *printers=NULL;
+       PRINTER_INFO_2 *printers=NULL;
        PRINTER_INFO_2 current_prt;
        WERROR result = WERR_OK;
 
+       *returned = 0;
+
        for (snum=0; snum<n_services; snum++) {
                if (lp_browseable(snum) && lp_snum_ok(snum) && lp_print_ok(snum) ) {
                        DEBUG(4,("Found a printer in smb.conf: %s[%x]\n", lp_servicename(snum), snum));
                                
                        if (construct_printer_info_2(NULL, &current_prt, snum)) {
-                               if((tp=SMB_REALLOC_ARRAY(printers, PRINTER_INFO_2, *returned +1)) == NULL) {
+                               if ( !(printers=SMB_REALLOC_ARRAY(printers, PRINTER_INFO_2, *returned +1)) ) {
                                        DEBUG(2,("enum_all_printers_info_2: failed to enlarge printers buffer!\n"));
-                                       SAFE_FREE(printers);
                                        *returned = 0;
                                        return WERR_NOMEM;
                                }
-                               else printers = tp;
-                               DEBUG(4,("ReAlloced memory for [%d] PRINTER_INFO_2\n", *returned));             
+
+                               DEBUG(4,("ReAlloced memory for [%d] PRINTER_INFO_2\n", *returned + 1));         
+
                                memcpy(&printers[*returned], &current_prt, sizeof(PRINTER_INFO_2));
+
                                (*returned)++;
                        }
                }
@@ -4608,9 +4623,10 @@ static WERROR enum_all_printers_info_2(RPC_BUFFER *buffer, uint32 offered, uint3
        
 out:
        /* clear memory */
-       for (i=0; i<*returned; i++) {
+
+       for (i=0; i<*returned; i++) 
                free_devmode(printers[i].devmode);
-       }
+
        SAFE_FREE(printers);
 
        if ( !W_ERROR_IS_OK(result) )
@@ -4707,11 +4723,13 @@ WERROR _spoolss_enumprinters( pipes_struct *p, SPOOL_Q_ENUMPRINTERS *q_u, SPOOL_
        
        /* that's an [in out] buffer */
 
-       if ( q_u->buffer ) {
-               rpcbuf_move(q_u->buffer, &r_u->buffer);
-               buffer = r_u->buffer;
+       if (!q_u->buffer && (offered!=0)) {
+               return WERR_INVALID_PARAM;
        }
 
+       rpcbuf_move(q_u->buffer, &r_u->buffer);
+       buffer = r_u->buffer;
+
        DEBUG(4,("_spoolss_enumprinters\n"));
 
        *needed=0;
@@ -4730,7 +4748,7 @@ WERROR _spoolss_enumprinters( pipes_struct *p, SPOOL_Q_ENUMPRINTERS *q_u, SPOOL_
         * Level 5: same as Level 2
         */
 
-       unistr2_to_ascii(name, servername, sizeof(name)-1);
+       unistr2_to_ascii(name, servername, sizeof(name));
        strupper_m(name);
 
        switch (level) {
@@ -4902,8 +4920,10 @@ static WERROR getprinter_level_4(Printer_entry *print_hnd, int snum, RPC_BUFFER
        if((printer=SMB_MALLOC_P(PRINTER_INFO_4))==NULL)
                return WERR_NOMEM;
 
-       if (!construct_printer_info_4(print_hnd, printer, snum))
+       if (!construct_printer_info_4(print_hnd, printer, snum)) {
+               SAFE_FREE(printer);
                return WERR_NOMEM;
+       }
        
        /* check the required size. */  
        *needed += spoolss_size_printer_info_4(printer);
@@ -4939,8 +4959,10 @@ static WERROR getprinter_level_5(Printer_entry *print_hnd, int snum, RPC_BUFFER
        if((printer=SMB_MALLOC_P(PRINTER_INFO_5))==NULL)
                return WERR_NOMEM;
 
-       if (!construct_printer_info_5(print_hnd, printer, snum))
+       if (!construct_printer_info_5(print_hnd, printer, snum)) {
+               free_printer_info_5(printer);
                return WERR_NOMEM;
+       }
        
        /* check the required size. */  
        *needed += spoolss_size_printer_info_5(printer);
@@ -4965,6 +4987,46 @@ out:
        return result;  
 }
 
+static WERROR getprinter_level_6(Printer_entry *print_hnd,
+                                int snum,
+                                RPC_BUFFER *buffer, uint32 offered,
+                                uint32 *needed)
+{
+       PRINTER_INFO_6 *printer;
+       WERROR result = WERR_OK;
+
+       if ((printer = SMB_MALLOC_P(PRINTER_INFO_6)) == NULL) {
+               return WERR_NOMEM;
+       }
+
+       if (!construct_printer_info_6(print_hnd, printer, snum)) {
+               free_printer_info_6(printer);
+               return WERR_NOMEM;
+       }
+
+       /* check the required size. */
+       *needed += spoolss_size_printer_info_6(printer);
+
+       if (*needed > offered) {
+               result = WERR_INSUFFICIENT_BUFFER;
+               goto out;
+       }
+
+       if (!rpcbuf_alloc_size(buffer, *needed)) {
+               result = WERR_NOMEM;
+               goto out;
+       }
+
+       /* fill the buffer with the structures */
+       smb_io_printer_info_6("", buffer, printer, 0);  
+       
+out:
+       /* clear memory */
+       free_printer_info_6(printer);
+       
+       return result;  
+}
+
 static WERROR getprinter_level_7(Printer_entry *print_hnd, int snum, RPC_BUFFER *buffer, uint32 offered, uint32 *needed)
 {
        PRINTER_INFO_7 *printer=NULL;
@@ -5016,14 +5078,16 @@ WERROR _spoolss_getprinter(pipes_struct *p, SPOOL_Q_GETPRINTER *q_u, SPOOL_R_GET
 
        /* that's an [in out] buffer */
 
-       if ( q_u->buffer ) {
-               rpcbuf_move(q_u->buffer, &r_u->buffer);
-               buffer = r_u->buffer;
+       if (!q_u->buffer && (offered!=0)) {
+               return WERR_INVALID_PARAM;
        }
 
+       rpcbuf_move(q_u->buffer, &r_u->buffer);
+       buffer = r_u->buffer;
+
        *needed=0;
 
-       if (!get_printer_snum(p, handle, &snum))
+       if (!get_printer_snum(p, handle, &snum, NULL))
                return WERR_BADFID;
 
        switch (level) {
@@ -5039,6 +5103,8 @@ WERROR _spoolss_getprinter(pipes_struct *p, SPOOL_Q_GETPRINTER *q_u, SPOOL_R_GET
                return getprinter_level_4(Printer, snum, buffer, offered, needed);
        case 5:         
                return getprinter_level_5(Printer, snum, buffer, offered, needed);
+       case 6:         
+               return getprinter_level_6(Printer, snum, buffer, offered, needed);
        case 7:
                return getprinter_level_7(Printer, snum, buffer, offered, needed);
        }
@@ -5068,8 +5134,10 @@ static WERROR construct_printer_driver_info_1(DRIVER_INFO_1 *info, int snum, fst
        if (!W_ERROR_IS_OK(get_a_printer(NULL, &printer, 2, lp_const_servicename(snum))))
                return WERR_INVALID_PRINTER_NAME;
 
-       if (!W_ERROR_IS_OK(get_a_printer_driver(&driver, 3, printer->info_2->drivername, architecture, version)))
+       if (!W_ERROR_IS_OK(get_a_printer_driver(&driver, 3, printer->info_2->drivername, architecture, version))) {
+               free_a_printer(&printer, 2);
                return WERR_UNKNOWN_PRINTER_DRIVER;
+       }
 
        fill_printer_driver_info_1(info, driver, servername, architecture);
 
@@ -5128,8 +5196,10 @@ static WERROR construct_printer_driver_info_2(DRIVER_INFO_2 *info, int snum, fst
        if (!W_ERROR_IS_OK(get_a_printer(NULL, &printer, 2, lp_const_servicename(snum))))
                return WERR_INVALID_PRINTER_NAME;
 
-       if (!W_ERROR_IS_OK(get_a_printer_driver(&driver, 3, printer->info_2->drivername, architecture, version)))
+       if (!W_ERROR_IS_OK(get_a_printer_driver(&driver, 3, printer->info_2->drivername, architecture, version))) {
+               free_a_printer(&printer, 2);
                return WERR_UNKNOWN_PRINTER_DRIVER;
+       }
 
        fill_printer_driver_info_2(info, driver, servername);
 
@@ -5150,7 +5220,6 @@ static uint32 init_unistr_array(uint16 **uni_array, fstring *char_array, const c
        int j=0;
        const char *v;
        pstring line;
-       uint16 *tuary;
 
        DEBUG(6,("init_unistr_array\n"));
        *uni_array=NULL;
@@ -5178,12 +5247,11 @@ static uint32 init_unistr_array(uint16 **uni_array, fstring *char_array, const c
 
                /* add one extra unit16 for the second terminating NULL */
                
-               if ( (tuary=SMB_REALLOC_ARRAY(*uni_array, uint16, j+1+strlen(line)+2)) == NULL ) {
+               if ( (*uni_array=SMB_REALLOC_ARRAY(*uni_array, uint16, j+1+strlen(line)+2)) == NULL ) {
                        DEBUG(2,("init_unistr_array: Realloc error\n" ));
                        return 0;
-               } else
-                       *uni_array = tuary;
-                       
+               }
+
                if ( !strlen(v) ) 
                        break;
                
@@ -5362,8 +5430,7 @@ static void fill_printer_driver_info_6(DRIVER_INFO_6 *info, NT_PRINTER_DRIVER_IN
        info->previousdrivernames=NULL;
        init_unistr_array(&info->previousdrivernames, &nullstr, servername);
 
-       info->driver_date.low=0;
-       info->driver_date.high=0;
+       info->driver_date=0;
 
        info->padding=0;
        info->driver_version_low=0;
@@ -5615,11 +5682,13 @@ WERROR _spoolss_getprinterdriver2(pipes_struct *p, SPOOL_Q_GETPRINTERDRIVER2 *q_
 
        /* that's an [in out] buffer */
 
-       if ( q_u->buffer ) {
-               rpcbuf_move(q_u->buffer, &r_u->buffer);
-               buffer = r_u->buffer;
+       if (!q_u->buffer && (offered!=0)) {
+               return WERR_INVALID_PARAM;
        }
 
+       rpcbuf_move(q_u->buffer, &r_u->buffer);
+       buffer = r_u->buffer;
+
        DEBUG(4,("_spoolss_getprinterdriver2\n"));
 
        if ( !(printer = find_printer_index_by_hnd( p, handle )) ) {
@@ -5632,9 +5701,9 @@ WERROR _spoolss_getprinterdriver2(pipes_struct *p, SPOOL_Q_GETPRINTERDRIVER2 *q_
        *serverminorversion = 0;
 
        fstrcpy(servername, get_server_name( printer ));
-       unistr2_to_ascii(architecture, uni_arch, sizeof(architecture)-1);
+       unistr2_to_ascii(architecture, uni_arch, sizeof(architecture));
 
-       if (!get_printer_snum(p, handle, &snum))
+       if (!get_printer_snum(p, handle, &snum, NULL))
                return WERR_BADFID;
 
        switch (level) {
@@ -5690,7 +5759,7 @@ WERROR _spoolss_endpageprinter(pipes_struct *p, SPOOL_Q_ENDPAGEPRINTER *q_u, SPO
                return WERR_BADFID;
        }
        
-       if (!get_printer_snum(p, handle, &snum))
+       if (!get_printer_snum(p, handle, &snum, NULL))
                return WERR_BADFID;
 
        Printer->page_started=False;
@@ -5716,15 +5785,12 @@ WERROR _spoolss_startdocprinter(pipes_struct *p, SPOOL_Q_STARTDOCPRINTER *q_u, S
        pstring jobname;
        fstring datatype;
        Printer_entry *Printer = find_printer_index_by_hnd(p, handle);
-       struct current_user user;
 
        if (!Printer) {
                DEBUG(2,("_spoolss_startdocprinter: Invalid handle (%s:%u:%u)\n", OUR_HANDLE(handle)));
                return WERR_BADFID;
        }
 
-       get_current_user(&user, p);
-
        /*
         * a nice thing with NT is it doesn't listen to what you tell it.
         * when asked to send _only_ RAW datas, it tries to send datas
@@ -5742,13 +5808,13 @@ WERROR _spoolss_startdocprinter(pipes_struct *p, SPOOL_Q_STARTDOCPRINTER *q_u, S
        }               
        
        /* get the share number of the printer */
-       if (!get_printer_snum(p, handle, &snum)) {
+       if (!get_printer_snum(p, handle, &snum, NULL)) {
                return WERR_BADFID;
        }
 
        unistr2_to_ascii(jobname, &info_1->docname, sizeof(jobname));
        
-       Printer->jobid = print_job_start(&user, snum, jobname, Printer->nt_devmode);
+       Printer->jobid = print_job_start(&p->pipe_user, snum, jobname, Printer->nt_devmode);
 
        /* An error occured in print_job_start() so return an appropriate
           NT error code. */
@@ -5794,7 +5860,7 @@ WERROR _spoolss_writeprinter(pipes_struct *p, SPOOL_Q_WRITEPRINTER *q_u, SPOOL_R
                return WERR_BADFID;
        }
 
-       if (!get_printer_snum(p, handle, &snum))
+       if (!get_printer_snum(p, handle, &snum, NULL))
                return WERR_BADFID;
 
        (*buffer_written) = (uint32)print_job_write(snum, Printer->jobid, (const char *)buffer,
@@ -5821,35 +5887,32 @@ WERROR _spoolss_writeprinter(pipes_struct *p, SPOOL_Q_WRITEPRINTER *q_u, SPOOL_R
 static WERROR control_printer(POLICY_HND *handle, uint32 command,
                              pipes_struct *p)
 {
-       struct current_user user;
        int snum;
        WERROR errcode = WERR_BADFUNC;
        Printer_entry *Printer = find_printer_index_by_hnd(p, handle);
 
-       get_current_user(&user, p);
-
        if (!Printer) {
                DEBUG(2,("control_printer: Invalid handle (%s:%u:%u)\n", OUR_HANDLE(handle)));
                return WERR_BADFID;
        }
 
-       if (!get_printer_snum(p, handle, &snum))
+       if (!get_printer_snum(p, handle, &snum, NULL))
                return WERR_BADFID;
 
        switch (command) {
        case PRINTER_CONTROL_PAUSE:
-               if (print_queue_pause(&user, snum, &errcode)) {
+               if (print_queue_pause(&p->pipe_user, snum, &errcode)) {
                        errcode = WERR_OK;
                }
                break;
        case PRINTER_CONTROL_RESUME:
        case PRINTER_CONTROL_UNPAUSE:
-               if (print_queue_resume(&user, snum, &errcode)) {
+               if (print_queue_resume(&p->pipe_user, snum, &errcode)) {
                        errcode = WERR_OK;
                }
                break;
        case PRINTER_CONTROL_PURGE:
-               if (print_queue_purge(&user, snum, &errcode)) {
+               if (print_queue_purge(&p->pipe_user, snum, &errcode)) {
                        errcode = WERR_OK;
                }
                break;
@@ -5871,7 +5934,6 @@ WERROR _spoolss_abortprinter(pipes_struct *p, SPOOL_Q_ABORTPRINTER *q_u, SPOOL_R
        POLICY_HND      *handle = &q_u->handle;
        Printer_entry   *Printer = find_printer_index_by_hnd(p, handle);
        int             snum;
-       struct          current_user user;
        WERROR          errcode = WERR_OK;
        
        if (!Printer) {
@@ -5879,12 +5941,10 @@ WERROR _spoolss_abortprinter(pipes_struct *p, SPOOL_Q_ABORTPRINTER *q_u, SPOOL_R
                return WERR_BADFID;
        }
        
-       if (!get_printer_snum(p, handle, &snum))
+       if (!get_printer_snum(p, handle, &snum, NULL))
                return WERR_BADFID;
        
-       get_current_user( &user, p );   
-       
-       print_job_delete( &user, snum, Printer->jobid, &errcode );      
+       print_job_delete( &p->pipe_user, snum, Printer->jobid, &errcode );      
        
        return errcode;
 }
@@ -5904,7 +5964,7 @@ static WERROR update_printer_sec(POLICY_HND *handle, uint32 level,
 
        Printer_entry *Printer = find_printer_index_by_hnd(p, handle);
 
-       if (!Printer || !get_printer_snum(p, handle, &snum)) {
+       if (!Printer || !get_printer_snum(p, handle, &snum, NULL)) {
                DEBUG(2,("update_printer_sec: Invalid handle (%s:%u:%u)\n",
                         OUR_HANDLE(handle)));
 
@@ -5912,6 +5972,12 @@ static WERROR update_printer_sec(POLICY_HND *handle, uint32 level,
                goto done;
        }
        
+       if (!secdesc_ctr) {
+               DEBUG(10,("update_printer_sec: secdesc_ctr is NULL !\n"));
+               result = WERR_INVALID_PARAM;
+               goto done;
+       }
+
        /* Check the user has permissions to change the security
           descriptor.  By experimentation with two NT machines, the user
           requires Full Access to the printer to change security
@@ -5932,20 +5998,20 @@ static WERROR update_printer_sec(POLICY_HND *handle, uint32 level,
                SEC_ACL *the_acl;
                int i;
 
-               the_acl = old_secdesc_ctr->sec->dacl;
+               the_acl = old_secdesc_ctr->sd->dacl;
                DEBUG(10, ("old_secdesc_ctr for %s has %d aces:\n", 
                           PRINTERNAME(snum), the_acl->num_aces));
 
                for (i = 0; i < the_acl->num_aces; i++) {
                        fstring sid_str;
 
-                       sid_to_string(sid_str, &the_acl->ace[i].trustee);
+                       sid_to_string(sid_str, &the_acl->aces[i].trustee);
 
                        DEBUG(10, ("%s 0x%08x\n", sid_str, 
-                                 the_acl->ace[i].info.mask));
+                                 the_acl->aces[i].access_mask));
                }
 
-               the_acl = secdesc_ctr->sec->dacl;
+               the_acl = secdesc_ctr->sd->dacl;
 
                if (the_acl) {
                        DEBUG(10, ("secdesc_ctr for %s has %d aces:\n", 
@@ -5954,10 +6020,10 @@ static WERROR update_printer_sec(POLICY_HND *handle, uint32 level,
                        for (i = 0; i < the_acl->num_aces; i++) {
                                fstring sid_str;
                                
-                               sid_to_string(sid_str, &the_acl->ace[i].trustee);
+                               sid_to_string(sid_str, &the_acl->aces[i].trustee);
                                
                                DEBUG(10, ("%s 0x%08x\n", sid_str, 
-                                          the_acl->ace[i].info.mask));
+                                          the_acl->aces[i].access_mask));
                        }
                } else {
                        DEBUG(10, ("dacl for secdesc_ctr is NULL\n"));
@@ -5965,8 +6031,12 @@ static WERROR update_printer_sec(POLICY_HND *handle, uint32 level,
        }
 
        new_secdesc_ctr = sec_desc_merge(p->mem_ctx, secdesc_ctr, old_secdesc_ctr);
+       if (!new_secdesc_ctr) {
+               result = WERR_NOMEM;
+               goto done;
+       }
 
-       if (sec_desc_equal(new_secdesc_ctr->sec, old_secdesc_ctr->sec)) {
+       if (sec_desc_equal(new_secdesc_ctr->sd, old_secdesc_ctr->sd)) {
                result = WERR_OK;
                goto done;
        }
@@ -5987,7 +6057,7 @@ static WERROR update_printer_sec(POLICY_HND *handle, uint32 level,
  _spoolss_open_printer_ex().
  ********************************************************************/
 
-static BOOL check_printer_ok(NT_PRINTER_INFO_LEVEL_2 *info, int snum)
+static bool check_printer_ok(NT_PRINTER_INFO_LEVEL_2 *info, int snum)
 {
        fstring printername;
        const char *p;
@@ -6026,13 +6096,59 @@ static BOOL check_printer_ok(NT_PRINTER_INFO_LEVEL_2 *info, int snum)
        
        
        
-       return True;
+       return True;
+}
+
+/****************************************************************************
+****************************************************************************/
+
+WERROR add_port_hook(NT_USER_TOKEN *token, const char *portname, const char *uri )
+{
+       char *cmd = lp_addport_cmd();
+       pstring command;
+       int ret;
+       int fd;
+       SE_PRIV se_printop = SE_PRINT_OPERATOR;
+       bool is_print_op = False;
+
+       if ( !*cmd ) {
+               return WERR_ACCESS_DENIED;
+       }
+               
+       slprintf(command, sizeof(command)-1, "%s \"%s\" \"%s\"", cmd, portname, uri );
+
+       if ( token )
+               is_print_op = user_has_privileges( token, &se_printop );
+
+       DEBUG(10,("Running [%s]\n", command));
+
+       /********* BEGIN SePrintOperatorPrivilege **********/
+
+       if ( is_print_op )
+               become_root();
+       
+       ret = smbrun(command, &fd);
+
+       if ( is_print_op )
+               unbecome_root();
+
+       /********* END SePrintOperatorPrivilege **********/
+
+       DEBUGADD(10,("returned [%d]\n", ret));
+
+       if ( ret != 0 ) {
+               if (fd != -1)
+                       close(fd);
+               return WERR_ACCESS_DENIED;
+       }
+       
+       return WERR_OK;
 }
 
 /****************************************************************************
 ****************************************************************************/
 
-static BOOL add_printer_hook(NT_USER_TOKEN *token, NT_PRINTER_INFO_LEVEL *printer)
+bool add_printer_hook(NT_USER_TOKEN *token, NT_PRINTER_INFO_LEVEL *printer)
 {
        char *cmd = lp_addprinter_cmd();
        char **qlines;
@@ -6042,16 +6158,19 @@ static BOOL add_printer_hook(NT_USER_TOKEN *token, NT_PRINTER_INFO_LEVEL *printe
        int fd;
        fstring remote_machine = "%m";
        SE_PRIV se_printop = SE_PRINT_OPERATOR;
-       BOOL is_print_op;
+       bool is_print_op = False;
 
-       standard_sub_basic(current_user_info.smb_name, remote_machine,sizeof(remote_machine));
+       standard_sub_basic(current_user_info.smb_name,
+                          current_user_info.domain,
+                          remote_machine,sizeof(remote_machine));
        
        slprintf(command, sizeof(command)-1, "%s \"%s\" \"%s\" \"%s\" \"%s\" \"%s\" \"%s\" \"%s\"",
                        cmd, printer->info_2->printername, printer->info_2->sharename,
                        printer->info_2->portname, printer->info_2->drivername,
                        printer->info_2->location, printer->info_2->comment, remote_machine);
 
-       is_print_op = user_has_privileges( token, &se_printop );
+       if ( token )
+               is_print_op = user_has_privileges( token, &se_printop );
 
        DEBUG(10,("Running [%s]\n", command));
 
@@ -6062,7 +6181,8 @@ static BOOL add_printer_hook(NT_USER_TOKEN *token, NT_PRINTER_INFO_LEVEL *printe
        
        if ( (ret = smbrun(command, &fd)) == 0 ) {
                /* Tell everyone we updated smb.conf. */
-               message_send_all(conn_tdb_ctx(), MSG_SMB_CONF_UPDATED, NULL, 0, False, NULL);
+               message_send_all(smbd_messaging_context(),
+                                MSG_SMB_CONF_UPDATED, NULL, 0, NULL);
        }
 
        if ( is_print_op )
@@ -6083,7 +6203,7 @@ static BOOL add_printer_hook(NT_USER_TOKEN *token, NT_PRINTER_INFO_LEVEL *printe
 
        numlines = 0;
        /* Get lines and convert them back to dos-codepage */
-       qlines = fd_lines_load(fd, &numlines);
+       qlines = fd_lines_load(fd, &numlines, 0);
        DEBUGADD(10,("Lines returned = [%d]\n", numlines));
        close(fd);
 
@@ -6100,6 +6220,7 @@ static BOOL add_printer_hook(NT_USER_TOKEN *token, NT_PRINTER_INFO_LEVEL *printe
        return True;
 }
 
+
 /********************************************************************
  * Called by spoolss_api_setprinter
  * when updating a printer description.
@@ -6125,7 +6246,7 @@ static WERROR update_printer(pipes_struct *p, POLICY_HND *handle, uint32 level,
                goto done;
        }
 
-       if (!get_printer_snum(p, handle, &snum)) {
+       if (!get_printer_snum(p, handle, &snum, NULL)) {
                result = WERR_BADFID;
                goto done;
        }
@@ -6188,17 +6309,12 @@ static WERROR update_printer(pipes_struct *p, POLICY_HND *handle, uint32 level,
                        || !strequal(printer->info_2->portname, old_printer->info_2->portname)
                        || !strequal(printer->info_2->location, old_printer->info_2->location)) )
        {
+               /* add_printer_hook() will call reload_services() */
+
                if ( !add_printer_hook(p->pipe_user.nt_user_token, printer) ) {
                        result = WERR_ACCESS_DENIED;
                        goto done;
                }
-
-               /* 
-                * make sure we actually reload the services after 
-                * this as smb.conf could have a new section in it 
-                * .... shouldn't .... but could
-                */
-               reload_services(False); 
        }
        
        /*
@@ -6308,14 +6424,20 @@ static WERROR publish_or_unpublish_printer(pipes_struct *p, POLICY_HND *handle,
 #ifdef HAVE_ADS
        SPOOL_PRINTER_INFO_LEVEL_7 *info7 = info->info_7;
        int snum;
-       Printer_entry *Printer = find_printer_index_by_hnd(p, handle);
+       Printer_entry *Printer;
+
+       if ( lp_security() != SEC_ADS ) {
+               return WERR_UNKNOWN_LEVEL;
+       }
+
+       Printer = find_printer_index_by_hnd(p, handle);
 
        DEBUG(5,("publish_or_unpublish_printer, action = %d\n",info7->action));
 
        if (!Printer)
                return WERR_BADFID;
 
-       if (!get_printer_snum(p, handle, &snum))
+       if (!get_printer_snum(p, handle, &snum, NULL))
                return WERR_BADFID;
        
        nt_printer_publish(Printer, snum, info7->action);
@@ -6382,10 +6504,10 @@ WERROR _spoolss_fcpn(pipes_struct *p, SPOOL_Q_FCPN *q_u, SPOOL_R_FCPN *r_u)
        if (Printer->notify.client_connected==True) {
                int snum = -1;
 
-               if ( Printer->printer_type == PRINTER_HANDLE_IS_PRINTSERVER)
+               if ( Printer->printer_type == SPLHND_SERVER)
                        snum = -1;
-               else if ( (Printer->printer_type == PRINTER_HANDLE_IS_PRINTER) &&
-                               !get_printer_snum(p, handle, &snum) )
+               else if ( (Printer->printer_type == SPLHND_PRINTER) &&
+                               !get_printer_snum(p, handle, &snum, NULL) )
                        return WERR_BADFID;
 
                srv_spoolss_replycloseprinter(snum, &Printer->notify.client_hnd);
@@ -6409,8 +6531,11 @@ WERROR _spoolss_addjob(pipes_struct *p, SPOOL_Q_ADDJOB *q_u, SPOOL_R_ADDJOB *r_u
 {
        /* that's an [in out] buffer */
 
-       if ( q_u->buffer ) 
-               rpcbuf_move(q_u->buffer, &r_u->buffer);
+       if (!q_u->buffer && (q_u->offered!=0)) {
+               return WERR_INVALID_PARAM;
+       }
+
+       rpcbuf_move(q_u->buffer, &r_u->buffer);
 
        r_u->needed = 0;
        return WERR_INVALID_PARAM; /* this is what a NT server
@@ -6422,9 +6547,9 @@ WERROR _spoolss_addjob(pipes_struct *p, SPOOL_Q_ADDJOB *q_u, SPOOL_R_ADDJOB *r_u
 /****************************************************************************
 ****************************************************************************/
 
-static void fill_job_info_1(JOB_INFO_1 *job_info, print_queue_struct *queue,
+static void fill_job_info_1(JOB_INFO_1 *job_info, const print_queue_struct *queue,
                             int position, int snum, 
-                            NT_PRINTER_INFO_LEVEL *ntprinter)
+                            const NT_PRINTER_INFO_LEVEL *ntprinter)
 {
        struct tm *t;
        
@@ -6449,9 +6574,9 @@ static void fill_job_info_1(JOB_INFO_1 *job_info, print_queue_struct *queue,
 /****************************************************************************
 ****************************************************************************/
 
-static BOOL fill_job_info_2(JOB_INFO_2 *job_info, print_queue_struct *queue,
+static bool fill_job_info_2(JOB_INFO_2 *job_info, const print_queue_struct *queue,
                             int position, int snum, 
-                           NT_PRINTER_INFO_LEVEL *ntprinter,
+                           const NT_PRINTER_INFO_LEVEL *ntprinter,
                            DEVICEMODE *devmode)
 {
        struct tm *t;
@@ -6494,8 +6619,8 @@ static BOOL fill_job_info_2(JOB_INFO_2 *job_info, print_queue_struct *queue,
  Enumjobs at level 1.
 ****************************************************************************/
 
-static WERROR enumjobs_level1(print_queue_struct *queue, int snum,
-                              NT_PRINTER_INFO_LEVEL *ntprinter,
+static WERROR enumjobs_level1(const print_queue_struct *queue, int snum,
+                              const NT_PRINTER_INFO_LEVEL *ntprinter,
                              RPC_BUFFER *buffer, uint32 offered,
                              uint32 *needed, uint32 *returned)
 {
@@ -6505,7 +6630,6 @@ static WERROR enumjobs_level1(print_queue_struct *queue, int snum,
        
        info=SMB_MALLOC_ARRAY(JOB_INFO_1,*returned);
        if (info==NULL) {
-               SAFE_FREE(queue);
                *returned=0;
                return WERR_NOMEM;
        }
@@ -6513,8 +6637,6 @@ static WERROR enumjobs_level1(print_queue_struct *queue, int snum,
        for (i=0; i<*returned; i++)
                fill_job_info_1( &info[i], &queue[i], i, snum, ntprinter );
 
-       SAFE_FREE(queue);
-
        /* check the required size. */  
        for (i=0; i<*returned; i++)
                (*needed) += spoolss_size_job_info_1(&info[i]);
@@ -6547,8 +6669,8 @@ out:
  Enumjobs at level 2.
 ****************************************************************************/
 
-static WERROR enumjobs_level2(print_queue_struct *queue, int snum,
-                              NT_PRINTER_INFO_LEVEL *ntprinter,
+static WERROR enumjobs_level2(const print_queue_struct *queue, int snum,
+                              const NT_PRINTER_INFO_LEVEL *ntprinter,
                              RPC_BUFFER *buffer, uint32 offered,
                              uint32 *needed, uint32 *returned)
 {
@@ -6564,14 +6686,11 @@ static WERROR enumjobs_level2(print_queue_struct *queue, int snum,
                
        /* this should not be a failure condition if the devmode is NULL */
        
-       devmode = construct_dev_mode(snum);
+       devmode = construct_dev_mode(lp_const_servicename(snum));
 
        for (i=0; i<*returned; i++)
                fill_job_info_2(&(info[i]), &queue[i], i, snum, ntprinter, devmode);
 
-       free_a_printer(&ntprinter, 2);
-       SAFE_FREE(queue);
-
        /* check the required size. */  
        for (i=0; i<*returned; i++)
                (*needed) += spoolss_size_job_info_2(&info[i]);
@@ -6621,11 +6740,13 @@ WERROR _spoolss_enumjobs( pipes_struct *p, SPOOL_Q_ENUMJOBS *q_u, SPOOL_R_ENUMJO
 
        /* that's an [in out] buffer */
 
-       if ( q_u->buffer ) {
-               rpcbuf_move(q_u->buffer, &r_u->buffer);
-               buffer = r_u->buffer;
+       if (!q_u->buffer && (offered!=0)) {
+               return WERR_INVALID_PARAM;
        }
 
+       rpcbuf_move(q_u->buffer, &r_u->buffer);
+       buffer = r_u->buffer;
+
        DEBUG(4,("_spoolss_enumjobs\n"));
 
        *needed=0;
@@ -6633,7 +6754,7 @@ WERROR _spoolss_enumjobs( pipes_struct *p, SPOOL_Q_ENUMJOBS *q_u, SPOOL_R_ENUMJO
 
        /* lookup the printer snum and tdb entry */
        
-       if (!get_printer_snum(p, handle, &snum))
+       if (!get_printer_snum(p, handle, &snum, NULL))
                return WERR_BADFID;
 
        wret = get_a_printer(NULL, &ntprinter, 2, lp_servicename(snum));
@@ -6645,22 +6766,24 @@ WERROR _spoolss_enumjobs( pipes_struct *p, SPOOL_Q_ENUMJOBS *q_u, SPOOL_R_ENUMJO
 
        if (*returned == 0) {
                SAFE_FREE(queue);
+               free_a_printer(&ntprinter, 2);
                return WERR_OK;
        }
 
        switch (level) {
        case 1:
                wret = enumjobs_level1(queue, snum, ntprinter, buffer, offered, needed, returned);
-               return wret;
+               break;
        case 2:
                wret = enumjobs_level2(queue, snum, ntprinter, buffer, offered, needed, returned);
-               return wret;
+               break;
        default:
-               SAFE_FREE(queue);
                *returned=0;
                wret = WERR_UNKNOWN_LEVEL;
+               break;
        }
        
+       SAFE_FREE(queue);
        free_a_printer( &ntprinter, 2 );
        return wret;
 }
@@ -6682,11 +6805,10 @@ WERROR _spoolss_setjob(pipes_struct *p, SPOOL_Q_SETJOB *q_u, SPOOL_R_SETJOB *r_u
        uint32 jobid = q_u->jobid;
        uint32 command = q_u->command;
 
-       struct current_user user;
        int snum;
        WERROR errcode = WERR_BADFUNC;
                
-       if (!get_printer_snum(p, handle, &snum)) {
+       if (!get_printer_snum(p, handle, &snum, NULL)) {
                return WERR_BADFID;
        }
 
@@ -6694,23 +6816,21 @@ WERROR _spoolss_setjob(pipes_struct *p, SPOOL_Q_SETJOB *q_u, SPOOL_R_SETJOB *r_u
                return WERR_INVALID_PRINTER_NAME;
        }
 
-       get_current_user(&user, p);     
-
        switch (command) {
        case JOB_CONTROL_CANCEL:
        case JOB_CONTROL_DELETE:
-               if (print_job_delete(&user, snum, jobid, &errcode)) {
+               if (print_job_delete(&p->pipe_user, snum, jobid, &errcode)) {
                        errcode = WERR_OK;
                }
                break;
        case JOB_CONTROL_PAUSE:
-               if (print_job_pause(&user, snum, jobid, &errcode)) {
+               if (print_job_pause(&p->pipe_user, snum, jobid, &errcode)) {
                        errcode = WERR_OK;
                }               
                break;
        case JOB_CONTROL_RESTART:
        case JOB_CONTROL_RESUME:
-               if (print_job_resume(&user, snum, jobid, &errcode)) {
+               if (print_job_resume(&p->pipe_user, snum, jobid, &errcode)) {
                        errcode = WERR_OK;
                }
                break;
@@ -6732,7 +6852,7 @@ static WERROR enumprinterdrivers_level1(fstring servername, fstring architecture
        uint32 version;
        fstring *list = NULL;
        NT_PRINTER_DRIVER_INFO_LEVEL driver;
-       DRIVER_INFO_1 *tdi1, *driver_info_1=NULL;
+       DRIVER_INFO_1 *driver_info_1=NULL;
        WERROR result = WERR_OK;
 
        *returned=0;
@@ -6742,17 +6862,17 @@ static WERROR enumprinterdrivers_level1(fstring servername, fstring architecture
                ndrivers=get_ntdrivers(&list, architecture, version);
                DEBUGADD(4,("we have:[%d] drivers in environment [%s] and version [%d]\n", ndrivers, architecture, version));
 
-               if(ndrivers == -1)
+               if(ndrivers == -1) {
+                       SAFE_FREE(driver_info_1);
                        return WERR_NOMEM;
+               }
 
                if(ndrivers != 0) {
-                       if((tdi1=SMB_REALLOC_ARRAY(driver_info_1, DRIVER_INFO_1, *returned+ndrivers )) == NULL) {
+                       if((driver_info_1=SMB_REALLOC_ARRAY(driver_info_1, DRIVER_INFO_1, *returned+ndrivers )) == NULL) {
                                DEBUG(0,("enumprinterdrivers_level1: failed to enlarge driver info buffer!\n"));
-                               SAFE_FREE(driver_info_1);
                                SAFE_FREE(list);
                                return WERR_NOMEM;
                        }
-                       else driver_info_1 = tdi1;
                }
 
                for (i=0; i<ndrivers; i++) {
@@ -6763,6 +6883,7 @@ static WERROR enumprinterdrivers_level1(fstring servername, fstring architecture
                                                      architecture, version);
                        if (!W_ERROR_IS_OK(status)) {
                                SAFE_FREE(list);
+                               SAFE_FREE(driver_info_1);
                                return status;
                        }
                        fill_printer_driver_info_1(&driver_info_1[*returned+i], driver, servername, architecture );             
@@ -6815,7 +6936,7 @@ static WERROR enumprinterdrivers_level2(fstring servername, fstring architecture
        uint32 version;
        fstring *list = NULL;
        NT_PRINTER_DRIVER_INFO_LEVEL driver;
-       DRIVER_INFO_2 *tdi2, *driver_info_2=NULL;
+       DRIVER_INFO_2 *driver_info_2=NULL;
        WERROR result = WERR_OK;
 
        *returned=0;
@@ -6825,17 +6946,17 @@ static WERROR enumprinterdrivers_level2(fstring servername, fstring architecture
                ndrivers=get_ntdrivers(&list, architecture, version);
                DEBUGADD(4,("we have:[%d] drivers in environment [%s] and version [%d]\n", ndrivers, architecture, version));
 
-               if(ndrivers == -1)
+               if(ndrivers == -1) {
+                       SAFE_FREE(driver_info_2);
                        return WERR_NOMEM;
+               }
 
                if(ndrivers != 0) {
-                       if((tdi2=SMB_REALLOC_ARRAY(driver_info_2, DRIVER_INFO_2, *returned+ndrivers )) == NULL) {
+                       if((driver_info_2=SMB_REALLOC_ARRAY(driver_info_2, DRIVER_INFO_2, *returned+ndrivers )) == NULL) {
                                DEBUG(0,("enumprinterdrivers_level2: failed to enlarge driver info buffer!\n"));
-                               SAFE_FREE(driver_info_2);
                                SAFE_FREE(list);
                                return WERR_NOMEM;
                        }
-                       else driver_info_2 = tdi2;
                }
                
                for (i=0; i<ndrivers; i++) {
@@ -6847,6 +6968,7 @@ static WERROR enumprinterdrivers_level2(fstring servername, fstring architecture
                                                      architecture, version);
                        if (!W_ERROR_IS_OK(status)) {
                                SAFE_FREE(list);
+                               SAFE_FREE(driver_info_2);
                                return status;
                        }
                        fill_printer_driver_info_2(&driver_info_2[*returned+i], driver, servername);            
@@ -6898,8 +7020,8 @@ static WERROR enumprinterdrivers_level3(fstring servername, fstring architecture
        int ndrivers;
        uint32 version;
        fstring *list = NULL;
+       DRIVER_INFO_3 *driver_info_3=NULL;
        NT_PRINTER_DRIVER_INFO_LEVEL driver;
-       DRIVER_INFO_3 *tdi3, *driver_info_3=NULL;
        WERROR result = WERR_OK;
 
        *returned=0;
@@ -6909,17 +7031,17 @@ static WERROR enumprinterdrivers_level3(fstring servername, fstring architecture
                ndrivers=get_ntdrivers(&list, architecture, version);
                DEBUGADD(4,("we have:[%d] drivers in environment [%s] and version [%d]\n", ndrivers, architecture, version));
 
-               if(ndrivers == -1)
+               if(ndrivers == -1) {
+                       SAFE_FREE(driver_info_3);
                        return WERR_NOMEM;
+               }
 
                if(ndrivers != 0) {
-                       if((tdi3=SMB_REALLOC_ARRAY(driver_info_3, DRIVER_INFO_3, *returned+ndrivers )) == NULL) {
+                       if((driver_info_3=SMB_REALLOC_ARRAY(driver_info_3, DRIVER_INFO_3, *returned+ndrivers )) == NULL) {
                                DEBUG(0,("enumprinterdrivers_level3: failed to enlarge driver info buffer!\n"));
-                               SAFE_FREE(driver_info_3);
                                SAFE_FREE(list);
                                return WERR_NOMEM;
                        }
-                       else driver_info_3 = tdi3;
                }
 
                for (i=0; i<ndrivers; i++) {
@@ -6931,6 +7053,7 @@ static WERROR enumprinterdrivers_level3(fstring servername, fstring architecture
                                                      architecture, version);
                        if (!W_ERROR_IS_OK(status)) {
                                SAFE_FREE(list);
+                               SAFE_FREE(driver_info_3);
                                return status;
                        }
                        fill_printer_driver_info_3(&driver_info_3[*returned+i], driver, servername);            
@@ -6964,8 +7087,9 @@ static WERROR enumprinterdrivers_level3(fstring servername, fstring architecture
        }
 
 out:
-       for (i=0; i<*returned; i++)
+       for (i=0; i<*returned; i++) {
                SAFE_FREE(driver_info_3[i].dependentfiles);
+       }
 
        SAFE_FREE(driver_info_3);
        
@@ -6992,18 +7116,20 @@ WERROR _spoolss_enumprinterdrivers( pipes_struct *p, SPOOL_Q_ENUMPRINTERDRIVERS
 
        /* that's an [in out] buffer */
 
-       if ( q_u->buffer ) {
-               rpcbuf_move(q_u->buffer, &r_u->buffer);
-               buffer = r_u->buffer;
+       if (!q_u->buffer && (offered!=0)) {
+               return WERR_INVALID_PARAM;
        }
 
+       rpcbuf_move(q_u->buffer, &r_u->buffer);
+       buffer = r_u->buffer;
+
        DEBUG(4,("_spoolss_enumprinterdrivers\n"));
        
        *needed   = 0;
        *returned = 0;
 
-       unistr2_to_ascii(architecture, &q_u->environment, sizeof(architecture)-1);
-       unistr2_to_ascii(servername, &q_u->name, sizeof(servername)-1);
+       unistr2_to_ascii(architecture, &q_u->environment, sizeof(architecture));
+       unistr2_to_ascii(servername, &q_u->name, sizeof(servername));
 
        if ( !is_myname_or_ipaddr( servername ) )
                return WERR_UNKNOWN_PRINTER_DRIVER;
@@ -7055,11 +7181,13 @@ WERROR _spoolss_enumforms(pipes_struct *p, SPOOL_Q_ENUMFORMS *q_u, SPOOL_R_ENUMF
 
        /* that's an [in out] buffer */
 
-       if ( q_u->buffer ) {
-               rpcbuf_move(q_u->buffer, &r_u->buffer);
-               buffer = r_u->buffer;
+       if (!q_u->buffer && (offered!=0) ) {
+               return WERR_INVALID_PARAM;
        }
 
+       rpcbuf_move(q_u->buffer, &r_u->buffer);
+       buffer = r_u->buffer;
+
        DEBUG(4,("_spoolss_enumforms\n"));
        DEBUGADD(5,("Offered buffer size [%d]\n", offered));
        DEBUGADD(5,("Info level [%d]\n",          level));
@@ -7070,12 +7198,17 @@ WERROR _spoolss_enumforms(pipes_struct *p, SPOOL_Q_ENUMFORMS *q_u, SPOOL_R_ENUMF
        DEBUGADD(5,("Number of user forms [%d]\n",     *numofforms));
        *numofforms += numbuiltinforms;
 
-       if (*numofforms == 0) 
+       if (*numofforms == 0) {
+               SAFE_FREE(builtinlist);
+               SAFE_FREE(list);
                return WERR_NO_MORE_ITEMS;
+       }
 
        switch (level) {
        case 1:
                if ((forms_1=SMB_MALLOC_ARRAY(FORM_1, *numofforms)) == NULL) {
+                       SAFE_FREE(builtinlist);
+                       SAFE_FREE(list);
                        *numofforms=0;
                        return WERR_NOMEM;
                }
@@ -7138,7 +7271,6 @@ WERROR _spoolss_enumforms(pipes_struct *p, SPOOL_Q_ENUMFORMS *q_u, SPOOL_R_ENUMF
                SAFE_FREE(builtinlist);
                return WERR_UNKNOWN_LEVEL;
        }
-
 }
 
 /****************************************************************************
@@ -7154,7 +7286,7 @@ WERROR _spoolss_getform(pipes_struct *p, SPOOL_Q_GETFORM *q_u, SPOOL_R_GETFORM *
 
        nt_forms_struct *list=NULL;
        nt_forms_struct builtin_form;
-       BOOL foundBuiltin;
+       bool foundBuiltin;
        FORM_1 form_1;
        fstring form_name;
        int buffer_size=0;
@@ -7162,12 +7294,14 @@ WERROR _spoolss_getform(pipes_struct *p, SPOOL_Q_GETFORM *q_u, SPOOL_R_GETFORM *
 
        /* that's an [in out] buffer */
 
-       if ( q_u->buffer ) {
-               rpcbuf_move(q_u->buffer, &r_u->buffer);
-               buffer = r_u->buffer;
+       if (!q_u->buffer && (offered!=0)) {
+               return WERR_INVALID_PARAM;
        }
 
-       unistr2_to_ascii(form_name, uni_formname, sizeof(form_name)-1);
+       rpcbuf_move(q_u->buffer, &r_u->buffer);
+       buffer = r_u->buffer;
+
+       unistr2_to_ascii(form_name, uni_formname, sizeof(form_name));
 
        DEBUG(4,("_spoolss_getform\n"));
        DEBUGADD(5,("Offered buffer size [%d]\n", offered));
@@ -7236,36 +7370,46 @@ static void fill_port_1(PORT_INFO_1 *port, const char *name)
 }
 
 /****************************************************************************
+ TODO: This probably needs distinguish between TCP/IP and Local ports 
+ somehow.
 ****************************************************************************/
 
 static void fill_port_2(PORT_INFO_2 *port, const char *name)
 {
        init_unistr(&port->port_name, name);
        init_unistr(&port->monitor_name, "Local Monitor");
-       init_unistr(&port->description, "Local Port");
+       init_unistr(&port->description, SPL_LOCAL_PORT );
        port->port_type=PORT_TYPE_WRITE;
        port->reserved=0x0;     
 }
 
+
 /****************************************************************************
  wrapper around the enumer ports command
 ****************************************************************************/
 
 WERROR enumports_hook( int *count, char ***lines )
 {
-               char *cmd = lp_enumports_cmd();
-               char **qlines;
-               pstring command;
-               int numlines;
-               int ret;
-               int fd;
+       char *cmd = lp_enumports_cmd();
+       char **qlines;
+       pstring command;
+       int numlines;
+       int ret;
+       int fd;
 
+       *count = 0;
+       *lines = NULL;
 
        /* if no hook then just fill in the default port */
        
        if ( !*cmd ) {
-               qlines = SMB_MALLOC_ARRAY( char*, 2 );
-               qlines[0] = SMB_STRDUP( SAMBA_PRINTER_PORT_NAME );
+               if (!(qlines = SMB_MALLOC_ARRAY( char*, 2 ))) {
+                       return WERR_NOMEM;
+               }
+               if (!(qlines[0] = SMB_STRDUP( SAMBA_PRINTER_PORT_NAME ))) {
+                       SAFE_FREE(qlines);
+                       return WERR_NOMEM;
+               }
                qlines[1] = NULL;
                numlines = 1;
        }
@@ -7278,14 +7422,14 @@ WERROR enumports_hook( int *count, char ***lines )
                ret = smbrun(command, &fd);
                DEBUG(10,("Returned [%d]\n", ret));
                if (ret != 0) {
-                       if (fd != -1)
+                       if (fd != -1) {
                                close(fd);
-                       
+                       }
                        return WERR_ACCESS_DENIED;
                }
 
                numlines = 0;
-               qlines = fd_lines_load(fd, &numlines);
+               qlines = fd_lines_load(fd, &numlines, 0);
                DEBUGADD(10,("Lines returned = [%d]\n", numlines));
                close(fd);
        }
@@ -7305,29 +7449,31 @@ static WERROR enumports_level_1(RPC_BUFFER *buffer, uint32 offered, uint32 *need
        PORT_INFO_1 *ports=NULL;
        int i=0;
        WERROR result = WERR_OK;
-       char **qlines;
-       int numlines;
+       char **qlines = NULL;
+       int numlines = 0;
 
-       if ( !W_ERROR_IS_OK(result = enumports_hook( &numlines, &qlines )) ) 
+       result = enumports_hook( &numlines, &qlines );
+       if (!W_ERROR_IS_OK(result)) {
+               file_lines_free(qlines);
                return result;
-
-               if(numlines) {
-                       if((ports=SMB_MALLOC_ARRAY( PORT_INFO_1, numlines )) == NULL) {
-                               DEBUG(10,("Returning WERR_NOMEM [%s]\n", 
-                                         dos_errstr(WERR_NOMEM)));
-                               file_lines_free(qlines);
-                               return WERR_NOMEM;
-                       }
-
-                       for (i=0; i<numlines; i++) {
-                               DEBUG(6,("Filling port number [%d] with port [%s]\n", i, qlines[i]));
-                               fill_port_1(&ports[i], qlines[i]);
-                       }
-
+       }
+       
+       if(numlines) {
+               if((ports=SMB_MALLOC_ARRAY( PORT_INFO_1, numlines )) == NULL) {
+                       DEBUG(10,("Returning WERR_NOMEM [%s]\n", 
+                                 dos_errstr(WERR_NOMEM)));
                        file_lines_free(qlines);
+                       return WERR_NOMEM;
+               }
+
+               for (i=0; i<numlines; i++) {
+                       DEBUG(6,("Filling port number [%d] with port [%s]\n", i, qlines[i]));
+                       fill_port_1(&ports[i], qlines[i]);
                }
+       }
+       file_lines_free(qlines);
 
-               *returned = numlines;
+       *returned = numlines;
 
        /* check the required size. */
        for (i=0; i<*returned; i++) {
@@ -7369,28 +7515,30 @@ static WERROR enumports_level_2(RPC_BUFFER *buffer, uint32 offered, uint32 *need
        PORT_INFO_2 *ports=NULL;
        int i=0;
        WERROR result = WERR_OK;
-               char **qlines;
-               int numlines;
+       char **qlines = NULL;
+       int numlines = 0;
 
-       if ( !W_ERROR_IS_OK(result = enumports_hook( &numlines, &qlines )) ) 
+       result = enumports_hook( &numlines, &qlines );
+       if ( !W_ERROR_IS_OK(result)) {
+               file_lines_free(qlines);
                return result;
-
-
-               if(numlines) {
-                       if((ports=SMB_MALLOC_ARRAY( PORT_INFO_2, numlines)) == NULL) {
-                               file_lines_free(qlines);
-                               return WERR_NOMEM;
-                       }
-
-                       for (i=0; i<numlines; i++) {
-                               DEBUG(6,("Filling port number [%d] with port [%s]\n", i, qlines[i]));
-                               fill_port_2(&(ports[i]), qlines[i]);
-                       }
-
+       }
+       
+       if(numlines) {
+               if((ports=SMB_MALLOC_ARRAY( PORT_INFO_2, numlines)) == NULL) {
                        file_lines_free(qlines);
+                       return WERR_NOMEM;
                }
 
-               *returned = numlines;
+               for (i=0; i<numlines; i++) {
+                       DEBUG(6,("Filling port number [%d] with port [%s]\n", i, qlines[i]));
+                       fill_port_2(&(ports[i]), qlines[i]);
+               }
+       }
+
+       file_lines_free(qlines);
+
+       *returned = numlines;
 
        /* check the required size. */
        for (i=0; i<*returned; i++) {
@@ -7437,11 +7585,13 @@ WERROR _spoolss_enumports( pipes_struct *p, SPOOL_Q_ENUMPORTS *q_u, SPOOL_R_ENUM
 
        /* that's an [in out] buffer */
 
-       if ( q_u->buffer ) {
-               rpcbuf_move(q_u->buffer, &r_u->buffer);
-               buffer = r_u->buffer;
+       if (!q_u->buffer && (offered!=0)) {
+               return WERR_INVALID_PARAM;
        }
 
+       rpcbuf_move(q_u->buffer, &r_u->buffer);
+       buffer = r_u->buffer;
+
        DEBUG(4,("_spoolss_enumports\n"));
        
        *returned=0;
@@ -7471,13 +7621,11 @@ static WERROR spoolss_addprinterex_level_2( pipes_struct *p, const UNISTR2 *uni_
        int     snum;
        WERROR err = WERR_OK;
 
-       if ((printer = SMB_MALLOC_P(NT_PRINTER_INFO_LEVEL)) == NULL) {
+       if ( !(printer = TALLOC_ZERO_P(NULL, NT_PRINTER_INFO_LEVEL)) ) {
                DEBUG(0,("spoolss_addprinterex_level_2: malloc fail.\n"));
                return WERR_NOMEM;
        }
 
-       ZERO_STRUCTP(printer);
-
        /* convert from UNICODE to ASCII - this allocates the info_2 struct inside *printer.*/
        if (!convert_printer_info(info, printer, 2)) {
                free_a_printer(&printer, 2);
@@ -7487,7 +7635,7 @@ static WERROR spoolss_addprinterex_level_2( pipes_struct *p, const UNISTR2 *uni_
        /* check to see if the printer already exists */
 
        if ((snum = print_queue_snum(printer->info_2->sharename)) != -1) {
-               DEBUG(5, ("_spoolss_addprinterex: Attempted to add a printer named [%s] when one already existed!\n", 
+               DEBUG(5, ("spoolss_addprinterex_level_2: Attempted to add a printer named [%s] when one already existed!\n", 
                        printer->info_2->sharename));
                free_a_printer(&printer, 2);
                return WERR_PRINTER_ALREADY_EXISTS;
@@ -7500,7 +7648,12 @@ static WERROR spoolss_addprinterex_level_2( pipes_struct *p, const UNISTR2 *uni_
                if ( !add_printer_hook(p->pipe_user.nt_user_token, printer) ) {
                        free_a_printer(&printer,2);
                        return WERR_ACCESS_DENIED;
-       }
+               }
+       } else {
+               DEBUG(0,("spoolss_addprinterex_level_2: add printer for printer %s called and no"
+                       "smb.conf parameter \"addprinter command\" is defined. This"
+                       "parameter must exist for this call to succeed\n",
+                       printer->info_2->sharename ));
        }
 
        /* use our primary netbios name since get_a_printer() will convert 
@@ -7608,28 +7761,23 @@ WERROR _spoolss_addprinterdriver(pipes_struct *p, SPOOL_Q_ADDPRINTERDRIVER *q_u,
        SPOOL_PRINTER_DRIVER_INFO_LEVEL *info = &q_u->info;
        WERROR err = WERR_OK;
        NT_PRINTER_DRIVER_INFO_LEVEL driver;
-       struct current_user user;
        fstring driver_name;
        uint32 version;
 
        ZERO_STRUCT(driver);
 
-       get_current_user(&user, p);
-       
        if (!convert_printer_driver_info(info, &driver, level)) {
                err = WERR_NOMEM;
                goto done;
        }
 
        DEBUG(5,("Cleaning driver's information\n"));
-       err = clean_up_driver_struct(driver, level, &user);
+       err = clean_up_driver_struct(driver, level, &p->pipe_user);
        if (!W_ERROR_IS_OK(err))
                goto done;
 
        DEBUG(5,("Moving driver to final destination\n"));
-       if(!move_driver_to_download_area(driver, level, &user, &err)) {
-               if (W_ERROR_IS_OK(err))
-                       err = WERR_ACCESS_DENIED;
+       if( !W_ERROR_IS_OK(err = move_driver_to_download_area(driver, level, &p->pipe_user, &err)) ) {
                goto done;
        }
 
@@ -7638,21 +7786,6 @@ WERROR _spoolss_addprinterdriver(pipes_struct *p, SPOOL_Q_ADDPRINTERDRIVER *q_u,
                goto done;
        }
 
-       /* BEGIN_ADMIN_LOG */
-        switch(level) {
-           case 3:
-               fstrcpy(driver_name, driver.info_3->name ? driver.info_3->name : "");
-               sys_adminlog(LOG_INFO,"Added printer driver. Print driver name: %s. Print driver OS: %s. Administrator name: %s.",
-                       driver_name, get_drv_ver_to_os(driver.info_3->cversion),uidtoname(user.uid));
-               break;
-           case 6:   
-               fstrcpy(driver_name, driver.info_6->name ?  driver.info_6->name : "");
-               sys_adminlog(LOG_INFO,"Added printer driver. Print driver name: %s. Print driver OS: %s. Administrator name: %s.",
-                       driver_name, get_drv_ver_to_os(driver.info_6->version),uidtoname(user.uid));
-               break;
-        }
-       /* END_ADMIN_LOG */
-
        /* 
         * I think this is where he DrvUpgradePrinter() hook would be
         * be called in a driver's interface DLL on a Windows NT 4.0/2k
@@ -7784,8 +7917,8 @@ static WERROR getprinterdriverdir_level_1(UNISTR2 *name, UNISTR2 *uni_environmen
        DRIVER_DIRECTORY_1 *info=NULL;
        WERROR result = WERR_OK;
 
-       unistr2_to_ascii(servername, name, sizeof(servername)-1);
-       unistr2_to_ascii(long_archi, uni_environment, sizeof(long_archi)-1);
+       unistr2_to_ascii(servername, name, sizeof(servername));
+       unistr2_to_ascii(long_archi, uni_environment, sizeof(long_archi));
 
        /* check for beginning double '\'s and that the server
           long enough */
@@ -7844,11 +7977,13 @@ WERROR _spoolss_getprinterdriverdirectory(pipes_struct *p, SPOOL_Q_GETPRINTERDRI
 
        /* that's an [in out] buffer */
 
-       if ( q_u->buffer ) {
-               rpcbuf_move(q_u->buffer, &r_u->buffer);
-               buffer = r_u->buffer;
+       if (!q_u->buffer && (offered!=0)) {
+               return WERR_INVALID_PARAM;
        }
 
+       rpcbuf_move(q_u->buffer, &r_u->buffer);
+       buffer = r_u->buffer;
+
        DEBUG(4,("_spoolss_getprinterdriverdirectory\n"));
 
        *needed=0;
@@ -7891,8 +8026,6 @@ WERROR _spoolss_enumprinterdata(pipes_struct *p, SPOOL_Q_ENUMPRINTERDATA *q_u, S
        int             i, key_index, num_values;
        int             name_length;
        
-       ZERO_STRUCT( printer );
-       
        *out_type = 0;
 
        *out_max_data_len = 0;
@@ -7906,14 +8039,14 @@ WERROR _spoolss_enumprinterdata(pipes_struct *p, SPOOL_Q_ENUMPRINTERDATA *q_u, S
                return WERR_BADFID;
        }
 
-       if (!get_printer_snum(p,handle, &snum))
+       if (!get_printer_snum(p,handle, &snum, NULL))
                return WERR_BADFID;
        
        result = get_a_printer(Printer, &printer, 2, lp_const_servicename(snum));
        if (!W_ERROR_IS_OK(result))
                return result;
                
-       p_data = &printer->info_2->data;        
+       p_data = printer->info_2->data; 
        key_index = lookup_printerkey( p_data, SPOOL_PRINTERDATA_KEY );
 
        result = WERR_OK;
@@ -7931,11 +8064,11 @@ WERROR _spoolss_enumprinterdata(pipes_struct *p, SPOOL_Q_ENUMPRINTERDATA *q_u, S
                biggest_valuesize = 0;
                biggest_datasize  = 0;
                                
-               num_values = regval_ctr_numvals( &p_data->keys[key_index].values );
-               
+               num_values = regval_ctr_numvals( p_data->keys[key_index].values );
+       
                for ( i=0; i<num_values; i++ )
                {
-                       val = regval_ctr_specific_value( &p_data->keys[key_index].values, i );
+                       val = regval_ctr_specific_value( p_data->keys[key_index].values, i );
                        
                        name_length = strlen(val->valuename);
                        if ( strlen(val->valuename) > biggest_valuesize ) 
@@ -7965,7 +8098,7 @@ WERROR _spoolss_enumprinterdata(pipes_struct *p, SPOOL_Q_ENUMPRINTERDATA *q_u, S
         */
        
        if ( key_index != -1 )
-               val = regval_ctr_specific_value( &p_data->keys[key_index].values, idx );
+               val = regval_ctr_specific_value( p_data->keys[key_index].values, idx );
 
        if ( !val ) 
        {
@@ -7975,14 +8108,18 @@ WERROR _spoolss_enumprinterdata(pipes_struct *p, SPOOL_Q_ENUMPRINTERDATA *q_u, S
 
                *out_max_value_len=(in_value_len/sizeof(uint16));
                
-               if((*out_value=(uint16 *)TALLOC_ZERO(p->mem_ctx, in_value_len*sizeof(uint8))) == NULL)
-               {
-                       result = WERR_NOMEM;
-                       goto done;
+               if (in_value_len) {
+                       if((*out_value=(uint16 *)TALLOC_ZERO(p->mem_ctx, in_value_len*sizeof(uint8))) == NULL)
+                       {
+                               result = WERR_NOMEM;
+                               goto done;
+                       }
+                       *out_value_len = (uint32)rpcstr_push((char *)*out_value, "", in_value_len, 0);
+               } else {
+                       *out_value=NULL;
+                       *out_value_len = 0;
                }
 
-               *out_value_len = (uint32)rpcstr_push((char *)*out_value, "", in_value_len, 0);
-
                /* the data is counted in bytes */
                
                *out_max_data_len = in_data_len;
@@ -8011,13 +8148,18 @@ WERROR _spoolss_enumprinterdata(pipes_struct *p, SPOOL_Q_ENUMPRINTERDATA *q_u, S
        
                /* name */
                *out_max_value_len=(in_value_len/sizeof(uint16));
-               if ( (*out_value = (uint16 *)TALLOC_ZERO(p->mem_ctx, in_value_len*sizeof(uint8))) == NULL ) 
-               {
-                       result = WERR_NOMEM;
-                       goto done;
-               }
+               if (in_value_len) {
+                       if ( (*out_value = (uint16 *)TALLOC_ZERO(p->mem_ctx, in_value_len*sizeof(uint8))) == NULL ) 
+                       {
+                               result = WERR_NOMEM;
+                               goto done;
+                       }
        
-               *out_value_len = (uint32)rpcstr_push((char *)*out_value, regval_name(val), in_value_len, 0);
+                       *out_value_len = (uint32)rpcstr_push((char *)*out_value, regval_name(val), (size_t)in_value_len, 0);
+               } else {
+                       *out_value = NULL;
+                       *out_value_len = 0;
+               }
 
                /* type */
                
@@ -8026,13 +8168,14 @@ WERROR _spoolss_enumprinterdata(pipes_struct *p, SPOOL_Q_ENUMPRINTERDATA *q_u, S
                /* data - counted in bytes */
 
                *out_max_data_len = in_data_len;
-               if ( (*data_out = (uint8 *)TALLOC_ZERO(p->mem_ctx, in_data_len*sizeof(uint8))) == NULL) 
+               if ( in_data_len && (*data_out = (uint8 *)TALLOC_ZERO(p->mem_ctx, in_data_len*sizeof(uint8))) == NULL) 
                {
                        result = WERR_NOMEM;
                        goto done;
                }
-               data_len = (size_t)regval_size(val);
-               memcpy( *data_out, regval_data_p(val), data_len );
+               data_len = regval_size(val);
+               if ( *data_out && data_len )
+                       memcpy( *data_out, regval_data_p(val), data_len );
                *out_data_len = data_len;
        }
 
@@ -8065,12 +8208,12 @@ WERROR _spoolss_setprinterdata( pipes_struct *p, SPOOL_Q_SETPRINTERDATA *q_u, SP
                return WERR_BADFID;
        }
 
-       if ( Printer->printer_type == PRINTER_HANDLE_IS_PRINTSERVER ) {
+       if ( Printer->printer_type == SPLHND_SERVER ) {
                DEBUG(10,("_spoolss_setprinterdata: Not implemented for server handles yet\n"));
                return WERR_INVALID_PARAM;
        }
 
-       if (!get_printer_snum(p,handle, &snum))
+       if (!get_printer_snum(p,handle, &snum, NULL))
                return WERR_BADFID;
 
        /* 
@@ -8092,7 +8235,7 @@ WERROR _spoolss_setprinterdata( pipes_struct *p, SPOOL_Q_SETPRINTERDATA *q_u, SP
        if (!W_ERROR_IS_OK(status))
                return status;
 
-       unistr2_to_ascii( valuename, value, sizeof(valuename)-1 );
+       unistr2_to_ascii(valuename, value, sizeof(valuename));
        
        /*
         * When client side code sets a magic printer data key, detect it and save
@@ -8142,7 +8285,7 @@ WERROR _spoolss_resetprinter(pipes_struct *p, SPOOL_Q_RESETPRINTER *q_u, SPOOL_R
                return WERR_BADFID;
        }
 
-       if (!get_printer_snum(p,handle, &snum))
+       if (!get_printer_snum(p,handle, &snum, NULL))
                return WERR_BADFID;
 
 
@@ -8172,7 +8315,7 @@ WERROR _spoolss_deleteprinterdata(pipes_struct *p, SPOOL_Q_DELETEPRINTERDATA *q_
                return WERR_BADFID;
        }
 
-       if (!get_printer_snum(p, handle, &snum))
+       if (!get_printer_snum(p, handle, &snum, NULL))
                return WERR_BADFID;
 
        if (Printer->access_granted != PRINTER_ACCESS_ADMINISTER) {
@@ -8184,7 +8327,7 @@ WERROR _spoolss_deleteprinterdata(pipes_struct *p, SPOOL_Q_DELETEPRINTERDATA *q_
        if (!W_ERROR_IS_OK(status))
                return status;
 
-       unistr2_to_ascii( valuename, value, sizeof(valuename)-1 );
+       unistr2_to_ascii(valuename, value, sizeof(valuename));
 
        status = delete_printer_dataex( printer, SPOOL_PRINTERDATA_KEY, valuename );
        
@@ -8222,9 +8365,9 @@ WERROR _spoolss_addform( pipes_struct *p, SPOOL_Q_ADDFORM *q_u, SPOOL_R_ADDFORM
        
        /* forms can be added on printer of on the print server handle */
        
-       if ( Printer->printer_type == PRINTER_HANDLE_IS_PRINTER )
+       if ( Printer->printer_type == SPLHND_PRINTER )
        {
-               if (!get_printer_snum(p,handle, &snum))
+               if (!get_printer_snum(p,handle, &snum, NULL))
                        return WERR_BADFID;
         
                status = get_a_printer(Printer, &printer, 2, lp_const_servicename(snum));
@@ -8258,7 +8401,7 @@ WERROR _spoolss_addform( pipes_struct *p, SPOOL_Q_ADDFORM *q_u, SPOOL_R_ADDFORM
         * ChangeID must always be set if this is a printer
         */
         
-       if ( Printer->printer_type == PRINTER_HANDLE_IS_PRINTER )
+       if ( Printer->printer_type == SPLHND_PRINTER )
                status = mod_a_printer(printer, 2);
        
 done:
@@ -8293,9 +8436,9 @@ WERROR _spoolss_deleteform( pipes_struct *p, SPOOL_Q_DELETEFORM *q_u, SPOOL_R_DE
 
        /* forms can be deleted on printer of on the print server handle */
        
-       if ( Printer->printer_type == PRINTER_HANDLE_IS_PRINTER )
+       if ( Printer->printer_type == SPLHND_PRINTER )
        {
-               if (!get_printer_snum(p,handle, &snum))
+               if (!get_printer_snum(p,handle, &snum, NULL))
                        return WERR_BADFID;
         
                status = get_a_printer(Printer, &printer, 2, lp_const_servicename(snum));
@@ -8325,7 +8468,7 @@ WERROR _spoolss_deleteform( pipes_struct *p, SPOOL_Q_DELETEFORM *q_u, SPOOL_R_DE
         * ChangeID must always be set if this is a printer
         */
         
-       if ( Printer->printer_type == PRINTER_HANDLE_IS_PRINTER )
+       if ( Printer->printer_type == SPLHND_PRINTER )
                status = mod_a_printer(printer, 2);
        
 done:
@@ -8361,9 +8504,9 @@ WERROR _spoolss_setform(pipes_struct *p, SPOOL_Q_SETFORM *q_u, SPOOL_R_SETFORM *
 
        /* forms can be modified on printer of on the print server handle */
        
-       if ( Printer->printer_type == PRINTER_HANDLE_IS_PRINTER )
+       if ( Printer->printer_type == SPLHND_PRINTER )
        {
-               if (!get_printer_snum(p,handle, &snum))
+               if (!get_printer_snum(p,handle, &snum, NULL))
                        return WERR_BADFID;
         
                status = get_a_printer(Printer, &printer, 2, lp_const_servicename(snum));
@@ -8391,7 +8534,7 @@ WERROR _spoolss_setform(pipes_struct *p, SPOOL_Q_SETFORM *q_u, SPOOL_R_SETFORM *
         * ChangeID must always be set if this is a printer
         */
         
-       if ( Printer->printer_type == PRINTER_HANDLE_IS_PRINTER )
+       if ( Printer->printer_type == SPLHND_PRINTER )
                status = mod_a_printer(printer, 2);
        
        
@@ -8455,11 +8598,13 @@ WERROR _spoolss_enumprintprocessors(pipes_struct *p, SPOOL_Q_ENUMPRINTPROCESSORS
 
        /* that's an [in out] buffer */
 
-       if ( q_u->buffer ) {
-               rpcbuf_move(q_u->buffer, &r_u->buffer);
-               buffer = r_u->buffer;
+       if (!q_u->buffer && (offered!=0)) {
+               return WERR_INVALID_PARAM;
        }
 
+       rpcbuf_move(q_u->buffer, &r_u->buffer);
+       buffer = r_u->buffer;
+
        DEBUG(5,("spoolss_enumprintprocessors\n"));
 
        /*
@@ -8487,7 +8632,7 @@ WERROR _spoolss_enumprintprocessors(pipes_struct *p, SPOOL_Q_ENUMPRINTPROCESSORS
 static WERROR enumprintprocdatatypes_level_1(RPC_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
        PRINTPROCDATATYPE_1 *info_1=NULL;
-       WERROR result = WERR_NOMEM;
+       WERROR result = WERR_OK;
        
        if((info_1 = SMB_MALLOC_P(PRINTPROCDATATYPE_1)) == NULL)
                return WERR_NOMEM;
@@ -8532,11 +8677,13 @@ WERROR _spoolss_enumprintprocdatatypes(pipes_struct *p, SPOOL_Q_ENUMPRINTPROCDAT
 
        /* that's an [in out] buffer */
 
-       if ( q_u->buffer ) {
-               rpcbuf_move(q_u->buffer, &r_u->buffer);
-               buffer = r_u->buffer;
+       if (!q_u->buffer && (offered!=0)) {
+               return WERR_INVALID_PARAM;
        }
 
+       rpcbuf_move(q_u->buffer, &r_u->buffer);
+       buffer = r_u->buffer;
+
        DEBUG(5,("_spoolss_enumprintprocdatatypes\n"));
        
        *returned=0;
@@ -8556,18 +8703,22 @@ WERROR _spoolss_enumprintprocdatatypes(pipes_struct *p, SPOOL_Q_ENUMPRINTPROCDAT
 
 static WERROR enumprintmonitors_level_1(RPC_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
-       PRINTMONITOR_1 *info_1=NULL;
+       PRINTMONITOR_1 *info_1;
        WERROR result = WERR_OK;
+       int i;
        
-       if((info_1 = SMB_MALLOC_P(PRINTMONITOR_1)) == NULL)
+       if((info_1 = SMB_MALLOC_ARRAY(PRINTMONITOR_1, 2)) == NULL)
                return WERR_NOMEM;
 
-       (*returned) = 0x1;
+       *returned = 2;
        
-       init_unistr(&info_1->name, "Local Port");
-
-       *needed += spoolss_size_printmonitor_info_1(info_1);
+       init_unistr(&(info_1[0].name), SPL_LOCAL_PORT ); 
+       init_unistr(&(info_1[1].name), SPL_TCPIP_PORT );
 
+       for ( i=0; i<*returned; i++ ) {
+               *needed += spoolss_size_printmonitor_info_1(&info_1[i]);
+       }
+       
        if (*needed > offered) {
                result = WERR_INSUFFICIENT_BUFFER;
                goto out;
@@ -8578,7 +8729,9 @@ static WERROR enumprintmonitors_level_1(RPC_BUFFER *buffer, uint32 offered, uint
                goto out;
        }
 
-       smb_io_printmonitor_info_1("", buffer, info_1, 0);
+       for ( i=0; i<*returned; i++ ) {
+               smb_io_printmonitor_info_1("", buffer, &info_1[i], 0);
+       }
 
 out:
        SAFE_FREE(info_1);
@@ -8595,20 +8748,27 @@ out:
 
 static WERROR enumprintmonitors_level_2(RPC_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
-       PRINTMONITOR_2 *info_2=NULL;
+       PRINTMONITOR_2 *info_2;
        WERROR result = WERR_OK;
+       int i;
        
-       if((info_2 = SMB_MALLOC_P(PRINTMONITOR_2)) == NULL)
+       if((info_2 = SMB_MALLOC_ARRAY(PRINTMONITOR_2, 2)) == NULL)
                return WERR_NOMEM;
 
-       (*returned) = 0x1;
+       *returned = 2;
        
-       init_unistr(&info_2->name, "Local Port");
-       init_unistr(&info_2->environment, "Windows NT X86");
-       init_unistr(&info_2->dll_name, "localmon.dll");
-
-       *needed += spoolss_size_printmonitor_info_2(info_2);
+       init_unistr( &(info_2[0].name), SPL_LOCAL_PORT );
+       init_unistr( &(info_2[0].environment), "Windows NT X86" );
+       init_unistr( &(info_2[0].dll_name), "localmon.dll" );
+       
+       init_unistr( &(info_2[1].name), SPL_TCPIP_PORT );
+       init_unistr( &(info_2[1].environment), "Windows NT X86" );
+       init_unistr( &(info_2[1].dll_name), "tcpmon.dll" );
 
+       for ( i=0; i<*returned; i++ ) {
+               *needed += spoolss_size_printmonitor_info_2(&info_2[i]);
+       }
+       
        if (*needed > offered) {
                result = WERR_INSUFFICIENT_BUFFER;
                goto out;
@@ -8619,7 +8779,9 @@ static WERROR enumprintmonitors_level_2(RPC_BUFFER *buffer, uint32 offered, uint
                goto out;
        }
 
-       smb_io_printmonitor_info_2("", buffer, info_2, 0);
+       for ( i=0; i<*returned; i++ ) {
+               smb_io_printmonitor_info_2("", buffer, &info_2[i], 0);
+       }
 
 out:
        SAFE_FREE(info_2);
@@ -8643,11 +8805,13 @@ WERROR _spoolss_enumprintmonitors(pipes_struct *p, SPOOL_Q_ENUMPRINTMONITORS *q_
 
        /* that's an [in out] buffer */
 
-       if ( q_u->buffer ) {
-               rpcbuf_move(q_u->buffer, &r_u->buffer);
-               buffer = r_u->buffer;
+       if (!q_u->buffer && (offered!=0)) {
+               return WERR_INVALID_PARAM;
        }
 
+       rpcbuf_move(q_u->buffer, &r_u->buffer);
+       buffer = r_u->buffer;
+
        DEBUG(5,("spoolss_enumprintmonitors\n"));
 
        /*
@@ -8679,7 +8843,7 @@ static WERROR getjob_level_1(print_queue_struct **queue, int count, int snum,
                             uint32 *needed)
 {
        int i=0;
-       BOOL found=False;
+       bool found=False;
        JOB_INFO_1 *info_1=NULL;
        WERROR result = WERR_OK;
 
@@ -8731,7 +8895,7 @@ static WERROR getjob_level_2(print_queue_struct **queue, int count, int snum,
                             uint32 *needed)
 {
        int             i = 0;
-       BOOL            found = False;
+       bool            found = False;
        JOB_INFO_2      *info_2;
        WERROR          result;
        DEVICEMODE      *devmode = NULL;
@@ -8762,7 +8926,7 @@ static WERROR getjob_level_2(print_queue_struct **queue, int count, int snum,
         */
         
        if ( !(nt_devmode=print_job_devmode( lp_const_servicename(snum), jobid )) )
-               devmode = construct_dev_mode(snum);
+               devmode = construct_dev_mode(lp_const_servicename(snum));
        else {
                if ((devmode = SMB_MALLOC_P(DEVICEMODE)) != NULL) {
                        ZERO_STRUCTP( devmode );
@@ -8817,16 +8981,18 @@ WERROR _spoolss_getjob( pipes_struct *p, SPOOL_Q_GETJOB *q_u, SPOOL_R_GETJOB *r_
 
        /* that's an [in out] buffer */
 
-       if ( q_u->buffer ) {
-               rpcbuf_move(q_u->buffer, &r_u->buffer);
-               buffer = r_u->buffer;
+       if (!q_u->buffer && (offered!=0)) {
+               return WERR_INVALID_PARAM;
        }
 
+       rpcbuf_move(q_u->buffer, &r_u->buffer);
+       buffer = r_u->buffer;
+
        DEBUG(5,("spoolss_getjob\n"));
        
        *needed = 0;
        
-       if (!get_printer_snum(p, handle, &snum))
+       if (!get_printer_snum(p, handle, &snum, NULL))
                return WERR_BADFID;
        
        wstatus = get_a_printer(NULL, &ntprinter, 2, lp_servicename(snum));
@@ -8883,8 +9049,8 @@ WERROR _spoolss_getprinterdataex(pipes_struct *p, SPOOL_Q_GETPRINTERDATAEX *q_u,
 
        DEBUG(4,("_spoolss_getprinterdataex\n"));
 
-        unistr2_to_ascii(keyname, &q_u->keyname, sizeof(keyname) - 1);
-        unistr2_to_ascii(valuename, &q_u->valuename, sizeof(valuename) - 1);
+        unistr2_to_ascii(keyname, &q_u->keyname, sizeof(keyname));
+        unistr2_to_ascii(valuename, &q_u->valuename, sizeof(valuename));
        
        DEBUG(10, ("_spoolss_getprinterdataex: key => [%s], value => [%s]\n", 
                keyname, valuename));
@@ -8903,13 +9069,13 @@ WERROR _spoolss_getprinterdataex(pipes_struct *p, SPOOL_Q_GETPRINTERDATAEX *q_u,
 
        /* Is the handle to a printer or to the server? */
 
-       if (Printer->printer_type == PRINTER_HANDLE_IS_PRINTSERVER) {
+       if (Printer->printer_type == SPLHND_SERVER) {
                DEBUG(10,("_spoolss_getprinterdataex: Not implemented for server handles yet\n"));
                status = WERR_INVALID_PARAM;
                goto done;
        }
        
-       if ( !get_printer_snum(p,handle, &snum) )
+       if ( !get_printer_snum(p,handle, &snum, NULL) )
                return WERR_BADFID;
 
        status = get_a_printer(Printer, &printer, 2, lp_servicename(snum));
@@ -8922,7 +9088,7 @@ WERROR _spoolss_getprinterdataex(pipes_struct *p, SPOOL_Q_GETPRINTERDATAEX *q_u,
                goto done;
        }
        
-       if ( lookup_printerkey( &printer->info_2->data, keyname ) == -1 ) {
+       if ( lookup_printerkey( printer->info_2->data, keyname ) == -1 ) {
                DEBUG(4,("_spoolss_getprinterdataex: Invalid keyname [%s]\n", keyname ));
                free_a_printer( &printer, 2 );
                status = WERR_BADFILE;
@@ -8949,10 +9115,9 @@ done:
                                status = WERR_NOMEM;
                                goto done;
                        }
-               } 
-               else {
+               } else {
                        *data = NULL;
-       }
+               }
        }
        
        if ( printer )
@@ -8990,12 +9155,12 @@ WERROR _spoolss_setprinterdataex(pipes_struct *p, SPOOL_Q_SETPRINTERDATAEX *q_u,
                return WERR_BADFID;
        }
 
-       if ( Printer->printer_type == PRINTER_HANDLE_IS_PRINTSERVER ) {
+       if ( Printer->printer_type == SPLHND_SERVER ) {
                DEBUG(10,("_spoolss_setprinterdataex: Not implemented for server handles yet\n"));
                return WERR_INVALID_PARAM;
        }
 
-       if ( !get_printer_snum(p,handle, &snum) )
+       if ( !get_printer_snum(p,handle, &snum, NULL) )
                return WERR_BADFID;
 
        /* 
@@ -9016,8 +9181,8 @@ WERROR _spoolss_setprinterdataex(pipes_struct *p, SPOOL_Q_SETPRINTERDATAEX *q_u,
        if (!W_ERROR_IS_OK(status))
                return status;
 
-        unistr2_to_ascii( valuename, &q_u->value, sizeof(valuename) - 1);
-        unistr2_to_ascii( keyname, &q_u->key, sizeof(keyname) - 1);
+        unistr2_to_ascii( valuename, &q_u->value, sizeof(valuename));
+        unistr2_to_ascii( keyname, &q_u->key, sizeof(keyname));
        
        /* check for OID in valuename */
        
@@ -9046,7 +9211,8 @@ WERROR _spoolss_setprinterdataex(pipes_struct *p, SPOOL_Q_SETPRINTERDATAEX *q_u,
                         */
                 
                        set_printer_dataex( printer, keyname, valuename, 
-                                           REG_SZ, (void*)oid_string, strlen(oid_string)+1 );          
+                                           REG_SZ, (uint8 *)oid_string,
+                                           strlen(oid_string)+1 );
                }
        
                status = mod_a_printer(printer, 2);
@@ -9081,7 +9247,7 @@ WERROR _spoolss_deleteprinterdataex(pipes_struct *p, SPOOL_Q_DELETEPRINTERDATAEX
                return WERR_BADFID;
        }
 
-       if (!get_printer_snum(p, handle, &snum))
+       if (!get_printer_snum(p, handle, &snum, NULL))
                return WERR_BADFID;
 
        if (Printer->access_granted != PRINTER_ACCESS_ADMINISTER) {
@@ -9093,8 +9259,8 @@ WERROR _spoolss_deleteprinterdataex(pipes_struct *p, SPOOL_Q_DELETEPRINTERDATAEX
        if (!W_ERROR_IS_OK(status))
                return status;
 
-       unistr2_to_ascii( valuename, value, sizeof(valuename)-1 );
-       unistr2_to_ascii( keyname, key, sizeof(keyname)-1 );
+       unistr2_to_ascii(valuename, value, sizeof(valuename));
+       unistr2_to_ascii(keyname, key, sizeof(keyname));
 
        status = delete_printer_dataex( printer, keyname, valuename );
 
@@ -9133,7 +9299,7 @@ WERROR _spoolss_enumprinterkey(pipes_struct *p, SPOOL_Q_ENUMPRINTERKEY *q_u, SPO
                return WERR_BADFID;
        }
 
-       if ( !get_printer_snum(p,handle, &snum) )
+       if ( !get_printer_snum(p,handle, &snum, NULL) )
                return WERR_BADFID;
 
        status = get_a_printer(Printer, &printer, 2, lp_const_servicename(snum));
@@ -9142,8 +9308,8 @@ WERROR _spoolss_enumprinterkey(pipes_struct *p, SPOOL_Q_ENUMPRINTERKEY *q_u, SPO
                
        /* get the list of subkey names */
        
-       unistr2_to_ascii( key, &q_u->key, sizeof(key)-1 );
-       data = &printer->info_2->data;
+       unistr2_to_ascii(key, &q_u->key, sizeof(key));
+       data = printer->info_2->data;
 
        num_keys = get_printer_subkeys( data, key, &keynames );
 
@@ -9203,7 +9369,7 @@ WERROR _spoolss_deleteprinterkey(pipes_struct *p, SPOOL_Q_DELETEPRINTERKEY *q_u,
        if ( !q_u->keyname.buffer )
                return WERR_INVALID_PARAM;
                
-       if (!get_printer_snum(p, handle, &snum))
+       if (!get_printer_snum(p, handle, &snum, NULL))
                return WERR_BADFID;
 
        if (Printer->access_granted != PRINTER_ACCESS_ADMINISTER) {
@@ -9217,7 +9383,7 @@ WERROR _spoolss_deleteprinterkey(pipes_struct *p, SPOOL_Q_DELETEPRINTERKEY *q_u,
        
        /* delete the key and all subneys */
        
-        unistr2_to_ascii(key, &q_u->keyname, sizeof(key) - 1);
+        unistr2_to_ascii(key, &q_u->keyname, sizeof(key));
  
        status = delete_all_printer_data( printer->info_2, key );       
 
@@ -9251,7 +9417,7 @@ WERROR _spoolss_enumprinterdataex(pipes_struct *p, SPOOL_Q_ENUMPRINTERDATAEX *q_
        int             i;
        REGISTRY_VALUE  *val;
        char            *value_name;
-       int             data_len;
+       uint32          data_len;
        
 
        DEBUG(4,("_spoolss_enumprinterdataex\n"));
@@ -9268,7 +9434,7 @@ WERROR _spoolss_enumprinterdataex(pipes_struct *p, SPOOL_Q_ENUMPRINTERDATAEX *q_
         * --jerry
         */
         
-       unistr2_to_ascii(key, &q_u->key, sizeof(key) - 1);
+       unistr2_to_ascii(key, &q_u->key, sizeof(key));
        if ( !strlen(key) ) {
                result = WERR_INVALID_PARAM;
                goto done;
@@ -9276,7 +9442,7 @@ WERROR _spoolss_enumprinterdataex(pipes_struct *p, SPOOL_Q_ENUMPRINTERDATAEX *q_
 
        /* get the printer off of disk */
        
-       if (!get_printer_snum(p,handle, &snum))
+       if (!get_printer_snum(p,handle, &snum, NULL))
                return WERR_BADFID;
        
        ZERO_STRUCT(printer);
@@ -9286,9 +9452,9 @@ WERROR _spoolss_enumprinterdataex(pipes_struct *p, SPOOL_Q_ENUMPRINTERDATAEX *q_
        
        /* now look for a match on the key name */
        
-       p_data = &printer->info_2->data;
+       p_data = printer->info_2->data;
        
-       unistr2_to_ascii(key, &q_u->key, sizeof(key) - 1);
+       unistr2_to_ascii(key, &q_u->key, sizeof(key));
        if ( (key_index = lookup_printerkey( p_data, key)) == -1  )
        {
                DEBUG(10,("_spoolss_enumprinterdataex: Unknown keyname [%s]\n", key));
@@ -9301,7 +9467,7 @@ WERROR _spoolss_enumprinterdataex(pipes_struct *p, SPOOL_Q_ENUMPRINTERDATAEX *q_
        
        /* allocate the memory for the array of pointers -- if necessary */
        
-       num_entries = regval_ctr_numvals( &p_data->keys[key_index].values );
+       num_entries = regval_ctr_numvals( p_data->keys[key_index].values );
        if ( num_entries )
        {
                if ( (enum_values=TALLOC_ARRAY(p->mem_ctx, PRINTER_ENUM_VALUES, num_entries)) == NULL )
@@ -9324,7 +9490,7 @@ WERROR _spoolss_enumprinterdataex(pipes_struct *p, SPOOL_Q_ENUMPRINTERDATAEX *q_
        {
                /* lookup the registry value */
                
-               val = regval_ctr_specific_value( &p_data->keys[key_index].values, i );
+               val = regval_ctr_specific_value( p_data->keys[key_index].values, i );
                DEBUG(10,("retrieved value number [%d] [%s]\n", i, regval_name(val) ));
 
                /* copy the data */
@@ -9336,9 +9502,9 @@ WERROR _spoolss_enumprinterdataex(pipes_struct *p, SPOOL_Q_ENUMPRINTERDATAEX *q_
                
                data_len = regval_size( val );
                if ( data_len ) {
-                       if ( !(enum_values[i].data = TALLOC_MEMDUP(p->mem_ctx, regval_data_p(val), data_len)) ) 
+                       if ( !(enum_values[i].data = (uint8 *)TALLOC_MEMDUP(p->mem_ctx, regval_data_p(val), data_len)) ) 
                        {
-                               DEBUG(0,("talloc_memdup failed to allocate memory [data_len=%d] for data!\n", 
+                               DEBUG(0,("TALLOC_MEMDUP failed to allocate memory [data_len=%d] for data!\n", 
                                        data_len ));
                                result = WERR_NOMEM;
                                goto done;
@@ -9353,6 +9519,15 @@ WERROR _spoolss_enumprinterdataex(pipes_struct *p, SPOOL_Q_ENUMPRINTERDATAEX *q_
        
        /* housekeeping information in the reply */
        
+       /* Fix from Martin Zielinski <mz@seh.de> - ensure
+        * the hand marshalled container size is a multiple
+        * of 4 bytes for RPC alignment.
+        */
+
+       if (needed % 4) {
+               needed += 4-(needed % 4);
+       }
+
        r_u->needed     = needed;
        r_u->returned   = num_entries;
 
@@ -9364,6 +9539,7 @@ WERROR _spoolss_enumprinterdataex(pipes_struct *p, SPOOL_Q_ENUMPRINTERDATAEX *q_
        /* copy data into the reply */
        
        r_u->ctr.size           = r_u->needed;
+
        r_u->ctr.size_of_array  = r_u->returned;
        r_u->ctr.values         = enum_values;
        
@@ -9395,7 +9571,7 @@ static WERROR getprintprocessordirectory_level_1(UNISTR2 *name,
        PRINTPROCESSOR_DIRECTORY_1 *info=NULL;
        WERROR result = WERR_OK;
 
-       unistr2_to_ascii(long_archi, environment, sizeof(long_archi)-1);
+       unistr2_to_ascii(long_archi, environment, sizeof(long_archi));
 
        if (!get_short_archi(long_archi))
                return WERR_INVALID_ENVIRONMENT;
@@ -9437,11 +9613,13 @@ WERROR _spoolss_getprintprocessordirectory(pipes_struct *p, SPOOL_Q_GETPRINTPROC
 
        /* that's an [in out] buffer */
 
-       if ( q_u->buffer ) {
-               rpcbuf_move(q_u->buffer, &r_u->buffer);
-               buffer = r_u->buffer;
+       if (!q_u->buffer && (offered!=0)) {
+               return WERR_INVALID_PARAM;
        }
 
+       rpcbuf_move(q_u->buffer, &r_u->buffer);
+       buffer = r_u->buffer;
+
        DEBUG(5,("_spoolss_getprintprocessordirectory\n"));
        
        *needed=0;
@@ -9458,23 +9636,191 @@ WERROR _spoolss_getprintprocessordirectory(pipes_struct *p, SPOOL_Q_GETPRINTPROC
        return result;
 }
 
-#if 0
+/*******************************************************************
+ Streams the monitor UI DLL name in UNICODE
+*******************************************************************/
+
+static WERROR xcvtcp_monitorui( NT_USER_TOKEN *token, RPC_BUFFER *in, 
+                                RPC_BUFFER *out, uint32 *needed )
+{
+       const char *dllname = "tcpmonui.dll";
+       
+       *needed = (strlen(dllname)+1) * 2;
+       
+       if ( rpcbuf_get_size(out) < *needed ) {
+               return WERR_INSUFFICIENT_BUFFER;                
+       }
+       
+       if ( !make_monitorui_buf( out, dllname ) ) {
+               return WERR_NOMEM;
+       }
+       
+       return WERR_OK;
+}
+
+/*******************************************************************
+ Create a new TCP/IP port
+*******************************************************************/
 
-WERROR _spoolss_replyopenprinter(pipes_struct *p, SPOOL_Q_REPLYOPENPRINTER *q_u
-                                SPOOL_R_REPLYOPENPRINTER *r_u)
+static WERROR xcvtcp_addport( NT_USER_TOKEN *token, RPC_BUFFER *in
+                              RPC_BUFFER *out, uint32 *needed )
 {
-       DEBUG(5,("_spoolss_replyopenprinter\n"));
+       NT_PORT_DATA_1 port1;
+       pstring device_uri;
 
-       DEBUG(10, ("replyopenprinter for localprinter %d\n", q_u->printer));
+       ZERO_STRUCT( port1 );
 
-       return WERR_OK;
+       /* convert to our internal port data structure */
+
+       if ( !convert_port_data_1( &port1, in ) ) {
+               return WERR_NOMEM;
+       }
+
+       /* create the device URI and call the add_port_hook() */
+
+       switch ( port1.protocol ) {
+       case PORT_PROTOCOL_DIRECT:
+               pstr_sprintf( device_uri, "socket://%s:%d/", port1.hostaddr, port1.port );
+               break;
+
+       case PORT_PROTOCOL_LPR:
+               pstr_sprintf( device_uri, "lpr://%s/%s", port1.hostaddr, port1.queue );
+               break;
+       
+       default:
+               return WERR_UNKNOWN_PORT;
+       }
+
+       return add_port_hook( token, port1.name, device_uri );
+}
+
+/*******************************************************************
+*******************************************************************/
+
+struct xcv_api_table xcvtcp_cmds[] = {
+       { "MonitorUI",  xcvtcp_monitorui },
+       { "AddPort",    xcvtcp_addport},
+       { NULL,         NULL }
+};
+
+static WERROR process_xcvtcp_command( NT_USER_TOKEN *token, const char *command, 
+                                      RPC_BUFFER *inbuf, RPC_BUFFER *outbuf, 
+                                      uint32 *needed )
+{
+       int i;
+       
+       DEBUG(10,("process_xcvtcp_command: Received command \"%s\"\n", command));
+       
+       for ( i=0; xcvtcp_cmds[i].name; i++ ) {
+               if ( strcmp( command, xcvtcp_cmds[i].name ) == 0 )
+                       return xcvtcp_cmds[i].fn( token, inbuf, outbuf, needed );
+       }
+       
+       return WERR_BADFUNC;
 }
 
-WERROR _spoolss_replycloseprinter(pipes_struct *p, SPOOL_Q_REPLYCLOSEPRINTER *q_u, 
-                                 SPOOL_R_REPLYCLOSEPRINTER *r_u)
+/*******************************************************************
+*******************************************************************/
+#if 0  /* don't support management using the "Local Port" monitor */
+
+static WERROR xcvlocal_monitorui( NT_USER_TOKEN *token, RPC_BUFFER *in, 
+                                  RPC_BUFFER *out, uint32 *needed )
 {
-       DEBUG(5,("_spoolss_replycloseprinter\n"));
+       const char *dllname = "localui.dll";
+       
+       *needed = (strlen(dllname)+1) * 2;
+       
+       if ( rpcbuf_get_size(out) < *needed ) {
+               return WERR_INSUFFICIENT_BUFFER;                
+       }
+       
+       if ( !make_monitorui_buf( out, dllname )) {
+               return WERR_NOMEM;
+       }
+       
        return WERR_OK;
 }
 
+/*******************************************************************
+*******************************************************************/
+
+struct xcv_api_table xcvlocal_cmds[] = {
+       { "MonitorUI",  xcvlocal_monitorui },
+       { NULL,         NULL }
+};
+#else
+struct xcv_api_table xcvlocal_cmds[] = {
+       { NULL,         NULL }
+};
 #endif
+
+
+
+/*******************************************************************
+*******************************************************************/
+
+static WERROR process_xcvlocal_command( NT_USER_TOKEN *token, const char *command, 
+                                        RPC_BUFFER *inbuf, RPC_BUFFER *outbuf, 
+                                       uint32 *needed )
+{
+       int i;
+       
+       DEBUG(10,("process_xcvlocal_command: Received command \"%s\"\n", command));
+
+       for ( i=0; xcvlocal_cmds[i].name; i++ ) {
+               if ( strcmp( command, xcvlocal_cmds[i].name ) == 0 )
+                       return xcvlocal_cmds[i].fn( token, inbuf, outbuf , needed );
+       }
+       return WERR_BADFUNC;
+}
+
+/*******************************************************************
+*******************************************************************/
+
+WERROR _spoolss_xcvdataport(pipes_struct *p, SPOOL_Q_XCVDATAPORT *q_u, SPOOL_R_XCVDATAPORT *r_u)
+{      
+       Printer_entry *Printer = find_printer_index_by_hnd(p, &q_u->handle);
+       fstring command;
+
+       if (!Printer) {
+               DEBUG(2,("_spoolss_xcvdataport: Invalid handle (%s:%u:%u).\n", OUR_HANDLE(&q_u->handle)));
+               return WERR_BADFID;
+       }
+
+       /* Has to be a handle to the TCP/IP port monitor */
+       
+       if ( !(Printer->printer_type & (SPLHND_PORTMON_LOCAL|SPLHND_PORTMON_TCP)) ) {
+               DEBUG(2,("_spoolss_xcvdataport: Call only valid for Port Monitors\n"));
+               return WERR_BADFID;
+       }
+       
+       /* requires administrative access to the server */
+       
+       if ( !(Printer->access_granted & SERVER_ACCESS_ADMINISTER) ) {
+               DEBUG(2,("_spoolss_xcvdataport: denied by handle permissions.\n"));
+               return WERR_ACCESS_DENIED;
+       }
+
+       /* Get the command name.  There's numerous commands supported by the 
+          TCPMON interface. */
+       
+       rpcstr_pull(command, q_u->dataname.buffer, sizeof(command), 
+               q_u->dataname.uni_str_len*2, 0);
+               
+       /* Allocate the outgoing buffer */
+       
+       rpcbuf_init( &r_u->outdata, q_u->offered, p->mem_ctx );
+       
+       switch ( Printer->printer_type ) {
+       case SPLHND_PORTMON_TCP:
+               return process_xcvtcp_command( p->pipe_user.nt_user_token, command, 
+                       &q_u->indata, &r_u->outdata, &r_u->needed );
+       case SPLHND_PORTMON_LOCAL:
+               return process_xcvlocal_command( p->pipe_user.nt_user_token, command, 
+                       &q_u->indata, &r_u->outdata, &r_u->needed );
+       }
+
+       return WERR_INVALID_PRINT_MONITOR;
+}
+
+