trying to get HEAD building again. If you want the code
[kai/samba.git] / source3 / rpc_parse / parse_spoolss.c
index d6987b46aa0e97b6f60673ff411a91a929ce1a58..1a380c64d556502c9f48cc4be0caa5ebf93169f1 100644 (file)
@@ -1,11 +1,11 @@
 /* 
- *  Unix SMB/Netbios implementation.
- *  Version 1.9.
+ *  Unix SMB/CIFS implementation.
  *  RPC Pipe client / server routines
  *  Copyright (C) Andrew Tridgell              1992-2000,
  *  Copyright (C) Luke Kenneth Casson Leighton 1996-2000,
- *  Copyright (C) Jean François Micouleau      1998-2000.
- *  Copyright (C) Gerald Carter                2000
+ *  Copyright (C) Jean François Micouleau      1998-2000,
+ *  Copyright (C) Gerald Carter                2000-2002,
+ *  Copyright (C) Tim Potter                  2001-2002.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License as published by
@@ -24,7 +24,8 @@
 
 #include "includes.h"
 
-extern int DEBUGLEVEL;
+#undef DBGC_CLASS
+#define DBGC_CLASS DBGC_RPC_PARSE
 
 /*******************************************************************
 return the length of a UNISTR string.
@@ -47,23 +48,23 @@ static uint32 str_len_uni(UNISTR *source)
 This should be moved in a more generic lib.
 ********************************************************************/  
 
-static BOOL spoolss_io_system_time(char *desc, prs_struct *ps, int depth, SYSTEMTIME *systime)
+BOOL spoolss_io_system_time(const char *desc, prs_struct *ps, int depth, SYSTEMTIME *systime)
 {
-       if(!prs_uint16("year", ps, depth, &(systime->year)))
+       if(!prs_uint16("year", ps, depth, &systime->year))
                return False;
-       if(!prs_uint16("month", ps, depth, &(systime->month)))
+       if(!prs_uint16("month", ps, depth, &systime->month))
                return False;
-       if(!prs_uint16("dayofweek", ps, depth, &(systime->dayofweek)))
+       if(!prs_uint16("dayofweek", ps, depth, &systime->dayofweek))
                return False;
-       if(!prs_uint16("day", ps, depth, &(systime->day)))
+       if(!prs_uint16("day", ps, depth, &systime->day))
                return False;
-       if(!prs_uint16("hour", ps, depth, &(systime->hour)))
+       if(!prs_uint16("hour", ps, depth, &systime->hour))
                return False;
-       if(!prs_uint16("minute", ps, depth, &(systime->minute)))
+       if(!prs_uint16("minute", ps, depth, &systime->minute))
                return False;
-       if(!prs_uint16("second", ps, depth, &(systime->second)))
+       if(!prs_uint16("second", ps, depth, &systime->second))
                return False;
-       if(!prs_uint16("milliseconds", ps, depth, &(systime->milliseconds)))
+       if(!prs_uint16("milliseconds", ps, depth, &systime->milliseconds))
                return False;
 
        return True;
@@ -90,7 +91,7 @@ BOOL make_systemtime(SYSTEMTIME *systime, struct tm *unixtime)
 reads or writes an DOC_INFO structure.
 ********************************************************************/  
 
-static BOOL smb_io_doc_info_1(char *desc, DOC_INFO_1 *info_1, prs_struct *ps, int depth)
+static BOOL smb_io_doc_info_1(const char *desc, DOC_INFO_1 *info_1, prs_struct *ps, int depth)
 {
        if (info_1 == NULL) return False;
 
@@ -121,7 +122,7 @@ static BOOL smb_io_doc_info_1(char *desc, DOC_INFO_1 *info_1, prs_struct *ps, in
 reads or writes an DOC_INFO structure.
 ********************************************************************/  
 
-static BOOL smb_io_doc_info(char *desc, DOC_INFO *info, prs_struct *ps, int depth)
+static BOOL smb_io_doc_info(const char *desc, DOC_INFO *info, prs_struct *ps, int depth)
 {
        uint32 useless_ptr=0;
        
@@ -170,7 +171,7 @@ static BOOL smb_io_doc_info(char *desc, DOC_INFO *info, prs_struct *ps, int dept
 reads or writes an DOC_INFO_CONTAINER structure.
 ********************************************************************/  
 
-static BOOL smb_io_doc_info_container(char *desc, DOC_INFO_CONTAINER *cont, prs_struct *ps, int depth)
+static BOOL smb_io_doc_info_container(const char *desc, DOC_INFO_CONTAINER *cont, prs_struct *ps, int depth)
 {
        if (cont == NULL) return False;
 
@@ -193,7 +194,11 @@ static BOOL smb_io_doc_info_container(char *desc, DOC_INFO_CONTAINER *cont, prs_
 reads or writes an NOTIFY OPTION TYPE structure.
 ********************************************************************/  
 
-static BOOL smb_io_notify_option_type(char *desc, SPOOL_NOTIFY_OPTION_TYPE *type, prs_struct *ps, int depth)
+/* NOTIFY_OPTION_TYPE and NOTIFY_OPTION_TYPE_DATA are really one
+   structure.  The _TYPE structure is really the deferred referrants (i.e
+   the notify fields array) of the _TYPE structure. -tpot */
+
+static BOOL smb_io_notify_option_type(const char *desc, SPOOL_NOTIFY_OPTION_TYPE *type, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "smb_io_notify_option_type");
        depth++;
@@ -221,7 +226,7 @@ static BOOL smb_io_notify_option_type(char *desc, SPOOL_NOTIFY_OPTION_TYPE *type
 reads or writes an NOTIFY OPTION TYPE DATA.
 ********************************************************************/  
 
-static BOOL smb_io_notify_option_type_data(char *desc, SPOOL_NOTIFY_OPTION_TYPE *type, prs_struct *ps, int depth)
+static BOOL smb_io_notify_option_type_data(const char *desc, SPOOL_NOTIFY_OPTION_TYPE *type, prs_struct *ps, int depth)
 {
        int i;
 
@@ -252,7 +257,7 @@ static BOOL smb_io_notify_option_type_data(char *desc, SPOOL_NOTIFY_OPTION_TYPE
 reads or writes an NOTIFY OPTION structure.
 ********************************************************************/  
 
-static BOOL smb_io_notify_option_type_ctr(char *desc, SPOOL_NOTIFY_OPTION_TYPE_CTR *ctr , prs_struct *ps, int depth)
+static BOOL smb_io_notify_option_type_ctr(const char *desc, SPOOL_NOTIFY_OPTION_TYPE_CTR *ctr , prs_struct *ps, int depth)
 {              
        int i;
        
@@ -284,7 +289,7 @@ static BOOL smb_io_notify_option_type_ctr(char *desc, SPOOL_NOTIFY_OPTION_TYPE_C
 reads or writes an NOTIFY OPTION structure.
 ********************************************************************/  
 
-static BOOL smb_io_notify_option(char *desc, SPOOL_NOTIFY_OPTION *option, prs_struct *ps, int depth)
+static BOOL smb_io_notify_option(const char *desc, SPOOL_NOTIFY_OPTION *option, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "smb_io_notify_option");
        depth++;
@@ -315,57 +320,76 @@ static BOOL smb_io_notify_option(char *desc, SPOOL_NOTIFY_OPTION *option, prs_st
 reads or writes an NOTIFY INFO DATA structure.
 ********************************************************************/  
 
-static BOOL smb_io_notify_info_data(char *desc,SPOOL_NOTIFY_INFO_DATA *data, prs_struct *ps, int depth)
+static BOOL smb_io_notify_info_data(const char *desc,SPOOL_NOTIFY_INFO_DATA *data, prs_struct *ps, int depth)
 {
-       uint32 useless_ptr=0xADDE0FF0;
+       uint32 useless_ptr=0x0FF0ADDE;
 
-       uint32 how_many_words;
-       BOOL isvalue;
-       uint32 x;
-       
        prs_debug(ps, depth, desc, "smb_io_notify_info_data");
        depth++;
 
-       how_many_words=data->size;
-       if (how_many_words==POINTER) {
-               how_many_words=TWO_VALUE;
-       }
-       
-       isvalue=data->enc_type;
-
        if(!prs_align(ps))
                return False;
        if(!prs_uint16("type",           ps, depth, &data->type))
                return False;
        if(!prs_uint16("field",          ps, depth, &data->field))
                return False;
-       /*prs_align(ps);*/
 
-       if(!prs_uint32("how many words", ps, depth, &how_many_words))
+       if(!prs_uint32("how many words", ps, depth, &data->size))
                return False;
        if(!prs_uint32("id",             ps, depth, &data->id))
                return False;
-       if(!prs_uint32("how many words", ps, depth, &how_many_words))
+       if(!prs_uint32("how many words", ps, depth, &data->size))
                return False;
 
+       switch (data->enc_type) {
+
+               /* One and two value data has two uint32 values */
 
-       /*prs_align(ps);*/
+       case NOTIFY_ONE_VALUE:
+       case NOTIFY_TWO_VALUE:
 
-       if (isvalue==True) {
                if(!prs_uint32("value[0]", ps, depth, &data->notify_data.value[0]))
                        return False;
                if(!prs_uint32("value[1]", ps, depth, &data->notify_data.value[1]))
                        return False;
-               /*prs_align(ps);*/
-       } else {
-               /* it's a string */
-               /* length in ascii including \0 */
-               x=2*(data->notify_data.data.length+1);
-               if(!prs_uint32("string length", ps, depth, &x ))
+               break;
+
+               /* Pointers and strings have a string length and a
+                  pointer.  For a string the length is expressed as
+                  the number of uint16 characters plus a trailing
+                  \0\0. */
+
+       case NOTIFY_POINTER:
+
+               if(!prs_uint32("string length", ps, depth, &data->notify_data.data.length ))
+                       return False;
+               if(!prs_uint32("pointer", ps, depth, &useless_ptr))
+                       return False;
+
+               break;
+
+       case NOTIFY_STRING:
+
+               if(!prs_uint32("string length", ps, depth, &data->notify_data.data.length))
                        return False;
+
                if(!prs_uint32("pointer", ps, depth, &useless_ptr))
                        return False;
-               /*prs_align(ps);*/
+
+               break;
+
+       case NOTIFY_SECDESC:
+               if( !prs_uint32( "sd size", ps, depth, &data->notify_data.sd.size ) )
+                       return False;
+               if( !prs_uint32( "pointer", ps, depth, &useless_ptr ) )
+                       return False;
+               
+               break;
+
+       default:
+               DEBUG(3, ("invalid enc_type %d for smb_io_notify_info_data\n",
+                         data->enc_type));
+               break;
        }
 
        return True;
@@ -375,25 +399,89 @@ static BOOL smb_io_notify_info_data(char *desc,SPOOL_NOTIFY_INFO_DATA *data, prs
 reads or writes an NOTIFY INFO DATA structure.
 ********************************************************************/  
 
-BOOL smb_io_notify_info_data_strings(char *desc,SPOOL_NOTIFY_INFO_DATA *data,
+BOOL smb_io_notify_info_data_strings(const char *desc,SPOOL_NOTIFY_INFO_DATA *data,
                                      prs_struct *ps, int depth)
 {
-       uint32 x;
-       BOOL isvalue;
-       
        prs_debug(ps, depth, desc, "smb_io_notify_info_data_strings");
        depth++;
        
        if(!prs_align(ps))
                return False;
 
-       isvalue=data->enc_type;
+       switch(data->enc_type) {
+
+               /* No data for values */
+
+       case NOTIFY_ONE_VALUE:
+       case NOTIFY_TWO_VALUE:
+
+               break;
+
+               /* Strings start with a length in uint16s */
+
+       case NOTIFY_STRING:
+
+               if (UNMARSHALLING(ps)) {
+                       data->notify_data.data.string = 
+                               (uint16 *)prs_alloc_mem(ps, data->notify_data.data.length);
+
+                       if (!data->notify_data.data.string) 
+                               return False;
+               }
+
+               if (MARSHALLING(ps))
+                       data->notify_data.data.length /= 2;
+
+               if(!prs_uint32("string length", ps, depth, &data->notify_data.data.length))
+                       return False;
+
+               if (!prs_uint16uni(True, "string", ps, depth, data->notify_data.data.string,
+                                  data->notify_data.data.length))
+                       return False;
+
+               if (MARSHALLING(ps))
+                       data->notify_data.data.length *= 2;
+
+               break;
+
+       case NOTIFY_POINTER:
+
+               if (UNMARSHALLING(ps)) {
+                       data->notify_data.data.string = 
+                               (uint16 *)prs_alloc_mem(ps, data->notify_data.data.length);
+
+                       if (!data->notify_data.data.string) 
+                               return False;
+               }
+
+               if(!prs_uint8s(True,"buffer",ps,depth,(uint8*)data->notify_data.data.string,data->notify_data.data.length))
+                       return False;
+
+               break;
+
+       case NOTIFY_SECDESC:    
+               if( !prs_uint32("secdesc size ", ps, depth, &data->notify_data.sd.size ) )
+                       return False;
+               if ( !sec_io_desc( "sec_desc", &data->notify_data.sd.desc, ps, depth ) )
+                       return False;
+               break;
+
+       default:
+               DEBUG(3, ("invalid enc_type %d for smb_io_notify_info_data_strings\n",
+                         data->enc_type));
+               break;
+       }
 
+#if 0
        if (isvalue==False) {
+
                /* length of string in unicode include \0 */
                x=data->notify_data.data.length+1;
+
+               if (data->field != 16)
                if(!prs_uint32("string length", ps, depth, &x ))
                        return False;
+
                if (MARSHALLING(ps)) {
                        /* These are already in little endian format. Don't byte swap. */
                        if (x == 1) {
@@ -407,7 +495,11 @@ BOOL smb_io_notify_info_data_strings(char *desc,SPOOL_NOTIFY_INFO_DATA *data,
                                if(!prs_uint8s(True,"string",ps,depth, (uint8 *)&data->notify_data.data.length,x*2)) 
                                        return False;
                        } else {
-                               if(!prs_uint8s(True,"string",ps,depth,(uint8 *)data->notify_data.data.string,x*2))
+
+                               if (data->field == 16)
+                                       x /= 2;
+
+                               if(!prs_uint16uni(True,"string",ps,depth,data->notify_data.data.string,x))
                                        return False;
                        }
                } else {
@@ -418,12 +510,18 @@ BOOL smb_io_notify_info_data_strings(char *desc,SPOOL_NOTIFY_INFO_DATA *data,
                        if (!data->notify_data.data.string) 
                                return False;
 
-                       if(!prs_uint16s(True,"string",ps,depth,data->notify_data.data.string,x))
+                       if(!prs_uint16uni(True,"string",ps,depth,data->notify_data.data.string,x))
                                return False;
                }
        }
+
+#endif
+
+#if 0  /* JERRY */
+       /* Win2k does not seem to put this parse align here */
        if(!prs_align(ps))
                return False;
+#endif
 
        return True;
 }
@@ -432,7 +530,7 @@ BOOL smb_io_notify_info_data_strings(char *desc,SPOOL_NOTIFY_INFO_DATA *data,
 reads or writes an NOTIFY INFO structure.
 ********************************************************************/  
 
-static BOOL smb_io_notify_info(char *desc, SPOOL_NOTIFY_INFO *info, prs_struct *ps, int depth)
+static BOOL smb_io_notify_info(const char *desc, SPOOL_NOTIFY_INFO *info, prs_struct *ps, int depth)
 {
        int i;
 
@@ -468,7 +566,7 @@ static BOOL smb_io_notify_info(char *desc, SPOOL_NOTIFY_INFO *info, prs_struct *
 /*******************************************************************
 ********************************************************************/  
 
-static BOOL spool_io_user_level_1(char *desc, SPOOL_USER_1 *q_u, prs_struct *ps, int depth)
+static BOOL spool_io_user_level_1(const char *desc, SPOOL_USER_1 *q_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "");
        depth++;
@@ -507,7 +605,7 @@ static BOOL spool_io_user_level_1(char *desc, SPOOL_USER_1 *q_u, prs_struct *ps,
 /*******************************************************************
 ********************************************************************/  
 
-static BOOL spool_io_user_level(char *desc, SPOOL_USER_CTR *q_u, prs_struct *ps, int depth)
+static BOOL spool_io_user_level(const char *desc, SPOOL_USER_CTR *q_u, prs_struct *ps, int depth)
 {
        if (q_u==NULL)
                return False;
@@ -517,6 +615,10 @@ static BOOL spool_io_user_level(char *desc, SPOOL_USER_CTR *q_u, prs_struct *ps,
 
        if (!prs_align(ps))
                return False;
+
+       /* From looking at many captures in ethereal, it looks like
+          the level and ptr fields should be transposed.  -tpot */
+
        if (!prs_uint32("level", ps, depth, &q_u->level))
                return False;
        if (!prs_uint32("ptr", ps, depth, &q_u->ptr))
@@ -539,8 +641,40 @@ static BOOL spool_io_user_level(char *desc, SPOOL_USER_CTR *q_u, prs_struct *ps,
  * on reading allocate memory for the private member
  ********************************************************************/
 
-static BOOL spoolss_io_devmode(char *desc, prs_struct *ps, int depth, DEVICEMODE *devmode)
+#define DM_NUM_OPTIONAL_FIELDS                 8
+
+BOOL spoolss_io_devmode(const char *desc, prs_struct *ps, int depth, DEVICEMODE *devmode)
 {
+       int available_space;            /* size of the device mode left to parse */
+                                       /* only important on unmarshalling       */
+       int i = 0;
+                                       
+       struct optional_fields {
+               fstring         name;
+               uint32*         field;
+       } opt_fields[DM_NUM_OPTIONAL_FIELDS] = {
+               { "icmmethod",          NULL },
+               { "icmintent",          NULL },
+               { "mediatype",          NULL },
+               { "dithertype",         NULL },
+               { "reserved1",          NULL },
+               { "reserved2",          NULL },
+               { "panningwidth",       NULL },
+               { "panningheight",      NULL }
+       };
+
+       /* assign at run time to keep non-gcc compilers happy */
+
+       opt_fields[0].field = &devmode->icmmethod;
+       opt_fields[1].field = &devmode->icmintent;
+       opt_fields[2].field = &devmode->mediatype;
+       opt_fields[3].field = &devmode->dithertype;
+       opt_fields[4].field = &devmode->reserved1;
+       opt_fields[5].field = &devmode->reserved2;
+       opt_fields[6].field = &devmode->panningwidth;
+       opt_fields[7].field = &devmode->panningheight;
+               
+       
        prs_debug(ps, depth, desc, "spoolss_io_devmode");
        depth++;
 
@@ -550,10 +684,31 @@ static BOOL spoolss_io_devmode(char *desc, prs_struct *ps, int depth, DEVICEMODE
                        return False;
        }
 
-       if (!prs_uint16s(True,"devicename", ps, depth, devmode->devicename.buffer, 32))
+       if (!prs_uint16uni(True,"devicename", ps, depth, devmode->devicename.buffer, MAXDEVICENAME))
                return False;
+       
        if (!prs_uint16("specversion",      ps, depth, &devmode->specversion))
                return False;
+               
+       /* Sanity Check - look for unknown specversions, but don't fail if we see one.
+          Let the size determine that */
+          
+       switch (devmode->specversion) {
+               /* list of observed spec version's */
+               case 0x0320:
+               case 0x0400:
+               case 0x0401:
+               case 0x040d:
+                       break;
+                       
+               default:
+                       DEBUG(0,("spoolss_io_devmode: Unknown specversion in devicemode [0x%x]\n",
+                               devmode->specversion));
+                       DEBUG(0,("spoolss_io_devmode: please report to samba-technical@samba.org!\n"));
+                       break;
+       }
+                       
+       
        if (!prs_uint16("driverversion",    ps, depth, &devmode->driverversion))
                return False;
        if (!prs_uint16("size",             ps, depth, &devmode->size))
@@ -595,7 +750,7 @@ static BOOL spoolss_io_devmode(char *desc, prs_struct *ps, int depth, DEVICEMODE
                        return False;
        }
 
-       if (!prs_uint16s(True, "formname",  ps, depth, devmode->formname.buffer, 32))
+       if (!prs_uint16uni(True, "formname",  ps, depth, devmode->formname.buffer, 32))
                return False;
        if (!prs_uint16("logpixels",        ps, depth, &devmode->logpixels))
                return False;
@@ -609,22 +764,49 @@ static BOOL spoolss_io_devmode(char *desc, prs_struct *ps, int depth, DEVICEMODE
                return False;
        if (!prs_uint32("displayfrequency", ps, depth, &devmode->displayfrequency))
                return False;
-       if (!prs_uint32("icmmethod",        ps, depth, &devmode->icmmethod))
-               return False;
-       if (!prs_uint32("icmintent",        ps, depth, &devmode->icmintent))
-               return False;
-       if (!prs_uint32("mediatype",        ps, depth, &devmode->mediatype))
-               return False;
-       if (!prs_uint32("dithertype",       ps, depth, &devmode->dithertype))
-               return False;
-       if (!prs_uint32("reserved1",        ps, depth, &devmode->reserved1))
-               return False;
-       if (!prs_uint32("reserved2",        ps, depth, &devmode->reserved2))
-               return False;
-       if (!prs_uint32("panningwidth",     ps, depth, &devmode->panningwidth))
+       /* 
+        * every device mode I've ever seen on the wire at least has up 
+        * to the displayfrequency field.   --jerry (05-09-2002)
+        */
+        
+       /* add uint32's + uint16's + two UNICODE strings */
+        
+       available_space = devmode->size - (sizeof(uint32)*6 + sizeof(uint16)*18 + sizeof(uint16)*64);
+       
+       /* Sanity check - we only have uint32's left tp parse */
+       
+       if ( available_space && ((available_space % sizeof(uint32)) != 0) ) {
+               DEBUG(0,("spoolss_io_devmode: available_space [%d] no in multiple of 4 bytes (size = %d)!\n",
+                       available_space, devmode->size));
+               DEBUG(0,("spoolss_io_devmode: please report to samba-technical@samba.org!\n"));
                return False;
-       if (!prs_uint32("panningheight",    ps, depth, &devmode->panningheight))
+       }
+
+       /* 
+        * Conditional parsing.  Assume that the DeviceMode has been 
+        * zero'd by the caller. 
+        */
+       
+       while ((available_space > 0)  && (i < DM_NUM_OPTIONAL_FIELDS))
+       {
+               DEBUG(11, ("spoolss_io_devmode: [%d] bytes left to parse in devmode\n", available_space));
+               if (!prs_uint32(opt_fields[i].name, ps, depth, opt_fields[i].field))
+                       return False;
+               available_space -= sizeof(uint32);
+               i++;
+       }        
+       
+       /* Sanity Check - we should no available space at this point unless 
+          MS changes the device mode structure */
+               
+       if (available_space) {
+               DEBUG(0,("spoolss_io_devmode: I've parsed all I know and there is still stuff left|\n"));
+               DEBUG(0,("spoolss_io_devmode: available_space = [%d], devmode_size = [%d]!\n",
+                       available_space, devmode->size));
+               DEBUG(0,("spoolss_io_devmode: please report to samba-technical@samba.org!\n"));
                return False;
+       }
+
 
        if (devmode->driverextra!=0) {
                if (UNMARSHALLING(ps)) {
@@ -635,7 +817,8 @@ static BOOL spoolss_io_devmode(char *desc, prs_struct *ps, int depth, DEVICEMODE
                }
                        
                DEBUG(7,("spoolss_io_devmode: parsing [%d] bytes of private\n",devmode->driverextra));
-               if (!prs_uint8s(True, "private",  ps, depth, devmode->private, devmode->driverextra))
+               if (!prs_uint8s(False, "private",  ps, depth,
+                               devmode->private, devmode->driverextra))
                        return False;
        }
 
@@ -646,7 +829,7 @@ static BOOL spoolss_io_devmode(char *desc, prs_struct *ps, int depth, DEVICEMODE
  Read or write a DEVICEMODE container
 ********************************************************************/  
 
-static BOOL spoolss_io_devmode_cont(char *desc, DEVMODE_CTR *dm_c, prs_struct *ps, int depth)
+static BOOL spoolss_io_devmode_cont(const char *desc, DEVMODE_CTR *dm_c, prs_struct *ps, int depth)
 {
        if (dm_c==NULL)
                return False;
@@ -691,7 +874,7 @@ static BOOL spoolss_io_devmode_cont(char *desc, DEVMODE_CTR *dm_c, prs_struct *p
 /*******************************************************************
 ********************************************************************/  
 
-static BOOL spoolss_io_printer_default(char *desc, PRINTER_DEFAULT *pd, prs_struct *ps, int depth)
+static BOOL spoolss_io_printer_default(const char *desc, PRINTER_DEFAULT *pd, prs_struct *ps, int depth)
 {
        if (pd==NULL)
                return False;
@@ -711,6 +894,9 @@ static BOOL spoolss_io_printer_default(char *desc, PRINTER_DEFAULT *pd, prs_stru
        if (!spoolss_io_devmode_cont("", &pd->devmode_cont, ps, depth))
                return False;
 
+       if (!prs_align(ps))
+               return False;
+
        if (!prs_uint32("access_required", ps, depth, &pd->access_required))
                return False;
 
@@ -760,7 +946,9 @@ BOOL make_spoolss_q_open_printer_ex(SPOOL_Q_OPEN_PRINTER_EX *q_u,
 /*******************************************************************
  * init a structure.
  ********************************************************************/
+
 BOOL make_spoolss_q_addprinterex(
+       TALLOC_CTX *mem_ctx,
        SPOOL_Q_ADDPRINTEREX *q_u, 
        const char *srv_name,
        const char* clientname, 
@@ -772,6 +960,8 @@ BOOL make_spoolss_q_addprinterex(
        
        if (!ctr) return False;
 
+       ZERO_STRUCTP(q_u);
+
        q_u->server_name_ptr = (srv_name!=NULL)?1:0;
        init_unistr2(&q_u->server_name, srv_name, strlen(srv_name));
 
@@ -779,12 +969,10 @@ BOOL make_spoolss_q_addprinterex(
        
        q_u->info.level = level;
        q_u->info.info_ptr = (ctr->printers_2!=NULL)?1:0;
-       switch (level)
-       {
+       switch (level) {
                case 2:
                        /* init q_u->info.info2 from *info */
-                       if (!make_spool_printer_info_2(&q_u->info.info_2, ctr->printers_2))
-                       {
+                       if (!make_spoolss_printer_info_2(mem_ctx, &q_u->info.info_2, ctr->printers_2)) {
                                DEBUG(0,("make_spoolss_q_addprinterex: Unable to fill SPOOL_Q_ADDPRINTEREX struct!\n"));
                                return False;
                        }
@@ -793,8 +981,6 @@ BOOL make_spoolss_q_addprinterex(
                        break;
        }
 
-       q_u->unk0 = q_u->unk1 = q_u->unk2 = q_u->unk3 = 0;
-
        q_u->user_switch=1;
 
        q_u->user_ctr.level=1;
@@ -817,19 +1003,15 @@ BOOL make_spoolss_q_addprinterex(
 create a SPOOL_PRINTER_INFO_2 stuct from a PRINTER_INFO_2 struct
 *******************************************************************/
 
-BOOL make_spool_printer_info_2(
-       SPOOL_PRINTER_INFO_LEVEL_2 **spool_info2, 
-       PRINTER_INFO_2 *info
-)
+BOOL make_spoolss_printer_info_2(TALLOC_CTX *mem_ctx, SPOOL_PRINTER_INFO_LEVEL_2 **spool_info2, 
+                               PRINTER_INFO_2 *info)
 {
 
        SPOOL_PRINTER_INFO_LEVEL_2 *inf;
 
        /* allocate the necessary memory */
-       inf = (SPOOL_PRINTER_INFO_LEVEL_2*)malloc(sizeof(SPOOL_PRINTER_INFO_LEVEL_2));
-       if (spool_info2 == NULL)
-       {
-               DEBUG(0,("make_spool_printer_info_2: Unable to allocate SPOOL_PRINTER_INFO_LEVEL_2 sruct!\n"));
+       if (!(inf=(SPOOL_PRINTER_INFO_LEVEL_2*)talloc(mem_ctx, sizeof(SPOOL_PRINTER_INFO_LEVEL_2)))) {
+               DEBUG(0,("make_spoolss_printer_info_2: Unable to allocate SPOOL_PRINTER_INFO_LEVEL_2 sruct!\n"));
                return False;
        }
        
@@ -865,24 +1047,24 @@ BOOL make_spool_printer_info_2(
        init_unistr2_from_unistr(&inf->datatype,        &info->datatype);
        init_unistr2_from_unistr(&inf->parameters,      &info->parameters);
        init_unistr2_from_unistr(&inf->datatype,        &info->datatype);
-       inf->secdesc    = NULL;
 
        *spool_info2 = inf;
 
        return True;
 }
 
+
 /*******************************************************************
  * read a structure.
  * called from spoolss_q_open_printer_ex (srv_spoolss.c)
  ********************************************************************/
 
-BOOL spoolss_io_q_open_printer_ex(char *desc, SPOOL_Q_OPEN_PRINTER_EX *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_open_printer(const char *desc, SPOOL_Q_OPEN_PRINTER *q_u, prs_struct *ps, int depth)
 {
        if (q_u == NULL)
                return False;
 
-       prs_debug(ps, depth, desc, "spoolss_io_q_open_printer_ex");
+       prs_debug(ps, depth, desc, "spoolss_io_q_open_printer");
        depth++;
 
        if (!prs_align(ps))
@@ -899,11 +1081,67 @@ BOOL spoolss_io_q_open_printer_ex(char *desc, SPOOL_Q_OPEN_PRINTER_EX *q_u, prs_
        if (!spoolss_io_printer_default("", &q_u->printer_default, ps, depth))
                return False;
                
+       return True;
+}
+
+/*******************************************************************
+ * write a structure.
+ * called from static spoolss_r_open_printer_ex (srv_spoolss.c)
+ * called from spoolss_open_printer_ex (cli_spoolss.c)
+ ********************************************************************/
+
+BOOL spoolss_io_r_open_printer(const char *desc, SPOOL_R_OPEN_PRINTER *r_u, prs_struct *ps, int depth)
+{
+       if (r_u == NULL) return False;
+
+       prs_debug(ps, depth, desc, "spoolss_io_r_open_printer");
+       depth++;
+       
+       if (!prs_align(ps))
+               return False;
+
+       if (!smb_io_pol_hnd("printer handle",&(r_u->handle),ps,depth))
+               return False;   
+
+       if (!prs_werror("status code", ps, depth, &(r_u->status)))
+               return False;
+               
+       return True;
+}
+
+
+/*******************************************************************
+ * read a structure.
+ * called from spoolss_q_open_printer_ex (srv_spoolss.c)
+ ********************************************************************/
+
+BOOL spoolss_io_q_open_printer_ex(const char *desc, SPOOL_Q_OPEN_PRINTER_EX *q_u, prs_struct *ps, int depth)
+{
+       if (q_u == NULL)
+               return False;
+
+       prs_debug(ps, depth, desc, "spoolss_io_q_open_printer_ex");
+       depth++;
+
+       if (!prs_align(ps))
+               return False;
+
+       if (!prs_uint32("printername_ptr", ps, depth, &q_u->printername_ptr))
+               return False;
+       if (!smb_io_unistr2("", &q_u->printername, q_u->printername_ptr, ps,depth))
+               return False;
+       
+       if (!prs_align(ps))
+               return False;
+
+       if (!spoolss_io_printer_default("", &q_u->printer_default, ps, depth))
+               return False;
+
        if (!prs_uint32("user_switch", ps, depth, &q_u->user_switch))
                return False;   
        if (!spool_io_user_level("", &q_u->user_ctr, ps, depth))
                return False;
-               
+       
        return True;
 }
 
@@ -913,7 +1151,7 @@ BOOL spoolss_io_q_open_printer_ex(char *desc, SPOOL_Q_OPEN_PRINTER_EX *q_u, prs_
  * called from spoolss_open_printer_ex (cli_spoolss.c)
  ********************************************************************/
 
-BOOL spoolss_io_r_open_printer_ex(char *desc, SPOOL_R_OPEN_PRINTER_EX *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_open_printer_ex(const char *desc, SPOOL_R_OPEN_PRINTER_EX *r_u, prs_struct *ps, int depth)
 {
        if (r_u == NULL) return False;
 
@@ -926,26 +1164,73 @@ BOOL spoolss_io_r_open_printer_ex(char *desc, SPOOL_R_OPEN_PRINTER_EX *r_u, prs_
        if (!smb_io_pol_hnd("printer handle",&(r_u->handle),ps,depth))
                return False;
 
-       if (!prs_uint32("status code", ps, depth, &(r_u->status)))
+       if (!prs_werror("status code", ps, depth, &(r_u->status)))
                return False;
 
        return True;
 }
 
+/*******************************************************************
+ * init a structure.
+ ********************************************************************/
+BOOL make_spoolss_q_deleteprinterdriver(
+       TALLOC_CTX *mem_ctx,
+       SPOOL_Q_DELETEPRINTERDRIVER *q_u, 
+       const char *server,
+       const char* arch, 
+       const char* driver 
+)
+{
+       DEBUG(5,("make_spoolss_q_deleteprinterdriver\n"));
+       
+       q_u->server_ptr = (server!=NULL)?1:0;
+
+       /* these must be NULL terminated or else NT4 will
+          complain about invalid parameters --jerry */
+       init_unistr2(&q_u->server, server, strlen(server)+1);
+       init_unistr2(&q_u->arch, arch, strlen(arch)+1);
+       init_unistr2(&q_u->driver, driver, strlen(driver)+1);
+
+       
+       return True;
+}
+
+
 /*******************************************************************
  * make a structure.
  ********************************************************************/
 
 BOOL make_spoolss_q_getprinterdata(SPOOL_Q_GETPRINTERDATA *q_u,
-                                const POLICY_HND *handle,
-                                UNISTR2 *valuename, uint32 size)
+                                  const POLICY_HND *handle,
+                                  const char *valuename, uint32 size)
 {
         if (q_u == NULL) return False;
 
         DEBUG(5,("make_spoolss_q_getprinterdata\n"));
 
         q_u->handle = *handle;
-        copy_unistr2(&q_u->valuename, valuename);
+       init_unistr2(&q_u->valuename, valuename, strlen(valuename) + 1);
+        q_u->size = size;
+
+        return True;
+}
+
+/*******************************************************************
+ * make a structure.
+ ********************************************************************/
+
+BOOL make_spoolss_q_getprinterdataex(SPOOL_Q_GETPRINTERDATAEX *q_u,
+                                    const POLICY_HND *handle,
+                                    const char *keyname, 
+                                    const char *valuename, uint32 size)
+{
+        if (q_u == NULL) return False;
+
+        DEBUG(5,("make_spoolss_q_getprinterdataex\n"));
+
+        q_u->handle = *handle;
+       init_unistr2(&q_u->valuename, valuename, strlen(valuename) + 1);
+       init_unistr2(&q_u->keyname, keyname, strlen(keyname) + 1);
         q_u->size = size;
 
         return True;
@@ -956,7 +1241,7 @@ BOOL make_spoolss_q_getprinterdata(SPOOL_Q_GETPRINTERDATA *q_u,
  * called from spoolss_q_getprinterdata (srv_spoolss.c)
  ********************************************************************/
 
-BOOL spoolss_io_q_getprinterdata(char *desc, SPOOL_Q_GETPRINTERDATA *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_getprinterdata(const char *desc, SPOOL_Q_GETPRINTERDATA *q_u, prs_struct *ps, int depth)
 {
        if (q_u == NULL)
                return False;
@@ -985,7 +1270,7 @@ BOOL spoolss_io_q_getprinterdata(char *desc, SPOOL_Q_GETPRINTERDATA *q_u, prs_st
  * called from spoolss_q_deleteprinterdata (srv_spoolss.c)
  ********************************************************************/
 
-BOOL spoolss_io_q_deleteprinterdata(char *desc, SPOOL_Q_DELETEPRINTERDATA *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_deleteprinterdata(const char *desc, SPOOL_Q_DELETEPRINTERDATA *q_u, prs_struct *ps, int depth)
 {
        if (q_u == NULL)
                return False;
@@ -1010,11 +1295,53 @@ BOOL spoolss_io_q_deleteprinterdata(char *desc, SPOOL_Q_DELETEPRINTERDATA *q_u,
  * called from spoolss_r_deleteprinterdata (srv_spoolss.c)
  ********************************************************************/
 
-BOOL spoolss_io_r_deleteprinterdata(char *desc, SPOOL_R_DELETEPRINTERDATA *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_deleteprinterdata(const char *desc, SPOOL_R_DELETEPRINTERDATA *r_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_r_deleteprinterdata");
        depth++;
-       if(!prs_uint32("status", ps, depth, &r_u->status))
+       if(!prs_werror("status", ps, depth, &r_u->status))
+               return False;
+
+       return True;
+}
+
+/*******************************************************************
+ * read a structure.
+ * called from spoolss_q_deleteprinterdataex (srv_spoolss.c)
+ ********************************************************************/
+
+BOOL spoolss_io_q_deleteprinterdataex(const char *desc, SPOOL_Q_DELETEPRINTERDATAEX *q_u, prs_struct *ps, int depth)
+{
+       if (q_u == NULL)
+               return False;
+
+       prs_debug(ps, depth, desc, "spoolss_io_q_deleteprinterdataex");
+       depth++;
+
+       if (!prs_align(ps))
+               return False;
+       if (!smb_io_pol_hnd("printer handle", &q_u->handle, ps, depth))
+               return False;
+       
+       if (!smb_io_unistr2("keyname  ", &q_u->keyname, True, ps, depth))
+               return False;
+       if (!smb_io_unistr2("valuename", &q_u->valuename, True, ps, depth))
+               return False;
+
+       return True;
+}
+
+/*******************************************************************
+ * write a structure.
+ * called from spoolss_r_deleteprinterdataex (srv_spoolss.c)
+ ********************************************************************/
+
+BOOL spoolss_io_r_deleteprinterdataex(const char *desc, SPOOL_R_DELETEPRINTERDATAEX *r_u, prs_struct *ps, int depth)
+{
+       prs_debug(ps, depth, desc, "spoolss_io_r_deleteprinterdataex");
+       depth++;
+       
+       if(!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -1025,7 +1352,7 @@ BOOL spoolss_io_r_deleteprinterdata(char *desc, SPOOL_R_DELETEPRINTERDATA *r_u,
  * called from spoolss_r_getprinterdata (srv_spoolss.c)
  ********************************************************************/
 
-BOOL spoolss_io_r_getprinterdata(char *desc, SPOOL_R_GETPRINTERDATA *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_getprinterdata(const char *desc, SPOOL_R_GETPRINTERDATA *r_u, prs_struct *ps, int depth)
 {
        if (r_u == NULL)
                return False;
@@ -1040,7 +1367,13 @@ BOOL spoolss_io_r_getprinterdata(char *desc, SPOOL_R_GETPRINTERDATA *r_u, prs_st
        if (!prs_uint32("size", ps, depth, &r_u->size))
                return False;
        
-       if (!prs_uint8s(False,"data", ps, depth, r_u->data, r_u->size))
+       if (UNMARSHALLING(ps) && r_u->size) {
+               r_u->data = prs_alloc_mem(ps, r_u->size);
+               if(!r_u->data)
+                       return False;
+       }
+
+       if (!prs_uint8s( False, "data", ps, depth, r_u->data, r_u->size ))
                return False;
                
        if (!prs_align(ps))
@@ -1048,7 +1381,7 @@ BOOL spoolss_io_r_getprinterdata(char *desc, SPOOL_R_GETPRINTERDATA *r_u, prs_st
        
        if (!prs_uint32("needed", ps, depth, &r_u->needed))
                return False;
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
                
        return True;
@@ -1075,7 +1408,7 @@ BOOL make_spoolss_q_closeprinter(SPOOL_Q_CLOSEPRINTER *q_u, POLICY_HND *hnd)
  * called from spoolss_abortprinter (cli_spoolss.c)
  ********************************************************************/
 
-BOOL spoolss_io_q_abortprinter(char *desc, SPOOL_Q_ABORTPRINTER *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_abortprinter(const char *desc, SPOOL_Q_ABORTPRINTER *q_u, prs_struct *ps, int depth)
 {
        if (q_u == NULL) return False;
 
@@ -1096,11 +1429,11 @@ BOOL spoolss_io_q_abortprinter(char *desc, SPOOL_Q_ABORTPRINTER *q_u, prs_struct
  * called from spoolss_r_abortprinter (srv_spoolss.c)
  ********************************************************************/
 
-BOOL spoolss_io_r_abortprinter(char *desc, SPOOL_R_ABORTPRINTER *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_abortprinter(const char *desc, SPOOL_R_ABORTPRINTER *r_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_r_abortprinter");
        depth++;
-       if(!prs_uint32("status", ps, depth, &r_u->status))
+       if(!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -1112,7 +1445,7 @@ BOOL spoolss_io_r_abortprinter(char *desc, SPOOL_R_ABORTPRINTER *r_u, prs_struct
  * called from spoolss_deleteprinter (cli_spoolss.c)
  ********************************************************************/
 
-BOOL spoolss_io_q_deleteprinter(char *desc, SPOOL_Q_DELETEPRINTER *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_deleteprinter(const char *desc, SPOOL_Q_DELETEPRINTER *q_u, prs_struct *ps, int depth)
 {
        if (q_u == NULL) return False;
 
@@ -1134,7 +1467,7 @@ BOOL spoolss_io_q_deleteprinter(char *desc, SPOOL_Q_DELETEPRINTER *q_u, prs_stru
  * called from spoolss_deleteprinter (cli_spoolss.c)
  ********************************************************************/
 
-BOOL spoolss_io_r_deleteprinter(char *desc, SPOOL_R_DELETEPRINTER *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_deleteprinter(const char *desc, SPOOL_R_DELETEPRINTER *r_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_r_deleteprinter");
        depth++;
@@ -1144,29 +1477,139 @@ BOOL spoolss_io_r_deleteprinter(char *desc, SPOOL_R_DELETEPRINTER *r_u, prs_stru
 
        if (!smb_io_pol_hnd("printer handle",&r_u->handle,ps,depth))
                return False;
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
        
        return True;
 }
 
+
 /*******************************************************************
  * read a structure.
- * called from static spoolss_q_closeprinter (srv_spoolss.c)
- * called from spoolss_closeprinter (cli_spoolss.c)
+ * called from api_spoolss_deleteprinterdriver (srv_spoolss.c)
+ * called from spoolss_deleteprinterdriver (cli_spoolss.c)
  ********************************************************************/
 
-BOOL spoolss_io_q_closeprinter(char *desc, SPOOL_Q_CLOSEPRINTER *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_deleteprinterdriver(const char *desc, SPOOL_Q_DELETEPRINTERDRIVER *q_u, prs_struct *ps, int depth)
 {
        if (q_u == NULL) return False;
 
-       prs_debug(ps, depth, desc, "spoolss_io_q_closeprinter");
+       prs_debug(ps, depth, desc, "spoolss_io_q_deleteprinterdriver");
        depth++;
 
        if (!prs_align(ps))
                return False;
 
-       if (!smb_io_pol_hnd("printer handle",&q_u->handle,ps,depth))
+       if(!prs_uint32("server_ptr", ps, depth, &q_u->server_ptr))
+               return False;           
+       if(!smb_io_unistr2("server", &q_u->server, q_u->server_ptr, ps, depth))
+               return False;
+       if(!smb_io_unistr2("arch", &q_u->arch, True, ps, depth))
+               return False;
+       if(!smb_io_unistr2("driver", &q_u->driver, True, ps, depth))
+               return False;
+
+
+       return True;
+}
+
+
+/*******************************************************************
+ * write a structure.
+ ********************************************************************/
+BOOL spoolss_io_r_deleteprinterdriver(const char *desc, SPOOL_R_DELETEPRINTERDRIVER *r_u, prs_struct *ps, int depth)
+{
+       if (r_u == NULL) return False;
+
+       prs_debug(ps, depth, desc, "spoolss_io_r_deleteprinterdriver");
+       depth++;
+
+       if (!prs_align(ps))
+               return False;
+
+       if (!prs_werror("status", ps, depth, &r_u->status))
+               return False;
+
+       return True;
+}
+
+
+/*******************************************************************
+ * read a structure.
+ * called from api_spoolss_deleteprinterdriver (srv_spoolss.c)
+ * called from spoolss_deleteprinterdriver (cli_spoolss.c)
+ ********************************************************************/
+
+BOOL spoolss_io_q_deleteprinterdriverex(const char *desc, SPOOL_Q_DELETEPRINTERDRIVEREX *q_u, prs_struct *ps, int depth)
+{
+       if (q_u == NULL) return False;
+
+       prs_debug(ps, depth, desc, "spoolss_io_q_deleteprinterdriverex");
+       depth++;
+
+       if (!prs_align(ps))
+               return False;
+
+       if(!prs_uint32("server_ptr", ps, depth, &q_u->server_ptr))
+               return False;           
+       if(!smb_io_unistr2("server", &q_u->server, q_u->server_ptr, ps, depth))
+               return False;
+       if(!smb_io_unistr2("arch", &q_u->arch, True, ps, depth))
+               return False;
+       if(!smb_io_unistr2("driver", &q_u->driver, True, ps, depth))
+               return False;
+
+       if (!prs_align(ps))
+               return False;
+
+       if(!prs_uint32("delete_flags ", ps, depth, &q_u->delete_flags))
+               return False;           
+       if(!prs_uint32("version      ", ps, depth, &q_u->version))
+               return False;           
+
+
+       return True;
+}
+
+
+/*******************************************************************
+ * write a structure.
+ ********************************************************************/
+BOOL spoolss_io_r_deleteprinterdriverex(const char *desc, SPOOL_R_DELETEPRINTERDRIVEREX *r_u, prs_struct *ps, int depth)
+{
+       if (r_u == NULL) return False;
+
+       prs_debug(ps, depth, desc, "spoolss_io_r_deleteprinterdriverex");
+       depth++;
+
+       if (!prs_align(ps))
+               return False;
+
+       if (!prs_werror("status", ps, depth, &r_u->status))
+               return False;
+
+       return True;
+}
+
+
+
+/*******************************************************************
+ * read a structure.
+ * called from static spoolss_q_closeprinter (srv_spoolss.c)
+ * called from spoolss_closeprinter (cli_spoolss.c)
+ ********************************************************************/
+
+BOOL spoolss_io_q_closeprinter(const char *desc, SPOOL_Q_CLOSEPRINTER *q_u, prs_struct *ps, int depth)
+{
+       if (q_u == NULL) return False;
+
+       prs_debug(ps, depth, desc, "spoolss_io_q_closeprinter");
+       depth++;
+
+       if (!prs_align(ps))
+               return False;
+
+       if (!smb_io_pol_hnd("printer handle",&q_u->handle,ps,depth))
                return False;
 
        return True;
@@ -1178,7 +1621,7 @@ BOOL spoolss_io_q_closeprinter(char *desc, SPOOL_Q_CLOSEPRINTER *q_u, prs_struct
  * called from spoolss_closeprinter (cli_spoolss.c)
  ********************************************************************/
 
-BOOL spoolss_io_r_closeprinter(char *desc, SPOOL_R_CLOSEPRINTER *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_closeprinter(const char *desc, SPOOL_R_CLOSEPRINTER *r_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_r_closeprinter");
        depth++;
@@ -1188,7 +1631,7 @@ BOOL spoolss_io_r_closeprinter(char *desc, SPOOL_R_CLOSEPRINTER *r_u, prs_struct
 
        if (!smb_io_pol_hnd("printer handle",&r_u->handle,ps,depth))
                return False;
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
        
        return True;
@@ -1199,7 +1642,7 @@ BOOL spoolss_io_r_closeprinter(char *desc, SPOOL_R_CLOSEPRINTER *r_u, prs_struct
  * called from spoolss_q_startdocprinter (srv_spoolss.c)
  ********************************************************************/
 
-BOOL spoolss_io_q_startdocprinter(char *desc, SPOOL_Q_STARTDOCPRINTER *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_startdocprinter(const char *desc, SPOOL_Q_STARTDOCPRINTER *q_u, prs_struct *ps, int depth)
 {
        if (q_u == NULL) return False;
 
@@ -1223,13 +1666,13 @@ BOOL spoolss_io_q_startdocprinter(char *desc, SPOOL_Q_STARTDOCPRINTER *q_u, prs_
  * called from spoolss_r_startdocprinter (srv_spoolss.c)
  ********************************************************************/
 
-BOOL spoolss_io_r_startdocprinter(char *desc, SPOOL_R_STARTDOCPRINTER *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_startdocprinter(const char *desc, SPOOL_R_STARTDOCPRINTER *r_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_r_startdocprinter");
        depth++;
        if(!prs_uint32("jobid", ps, depth, &r_u->jobid))
                return False;
-       if(!prs_uint32("status", ps, depth, &r_u->status))
+       if(!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -1240,7 +1683,7 @@ BOOL spoolss_io_r_startdocprinter(char *desc, SPOOL_R_STARTDOCPRINTER *r_u, prs_
  * called from spoolss_q_enddocprinter (srv_spoolss.c)
  ********************************************************************/
 
-BOOL spoolss_io_q_enddocprinter(char *desc, SPOOL_Q_ENDDOCPRINTER *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_enddocprinter(const char *desc, SPOOL_Q_ENDDOCPRINTER *q_u, prs_struct *ps, int depth)
 {
        if (q_u == NULL) return False;
 
@@ -1261,11 +1704,11 @@ BOOL spoolss_io_q_enddocprinter(char *desc, SPOOL_Q_ENDDOCPRINTER *q_u, prs_stru
  * called from spoolss_r_enddocprinter (srv_spoolss.c)
  ********************************************************************/
 
-BOOL spoolss_io_r_enddocprinter(char *desc, SPOOL_R_ENDDOCPRINTER *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_enddocprinter(const char *desc, SPOOL_R_ENDDOCPRINTER *r_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_r_enddocprinter");
        depth++;
-       if(!prs_uint32("status", ps, depth, &r_u->status))
+       if(!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -1276,7 +1719,7 @@ BOOL spoolss_io_r_enddocprinter(char *desc, SPOOL_R_ENDDOCPRINTER *r_u, prs_stru
  * called from spoolss_q_startpageprinter (srv_spoolss.c)
  ********************************************************************/
 
-BOOL spoolss_io_q_startpageprinter(char *desc, SPOOL_Q_STARTPAGEPRINTER *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_startpageprinter(const char *desc, SPOOL_Q_STARTPAGEPRINTER *q_u, prs_struct *ps, int depth)
 {
        if (q_u == NULL) return False;
 
@@ -1297,11 +1740,11 @@ BOOL spoolss_io_q_startpageprinter(char *desc, SPOOL_Q_STARTPAGEPRINTER *q_u, pr
  * called from spoolss_r_startpageprinter (srv_spoolss.c)
  ********************************************************************/
 
-BOOL spoolss_io_r_startpageprinter(char *desc, SPOOL_R_STARTPAGEPRINTER *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_startpageprinter(const char *desc, SPOOL_R_STARTPAGEPRINTER *r_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_r_startpageprinter");
        depth++;
-       if(!prs_uint32("status", ps, depth, &r_u->status))
+       if(!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -1312,7 +1755,7 @@ BOOL spoolss_io_r_startpageprinter(char *desc, SPOOL_R_STARTPAGEPRINTER *r_u, pr
  * called from spoolss_q_endpageprinter (srv_spoolss.c)
  ********************************************************************/
 
-BOOL spoolss_io_q_endpageprinter(char *desc, SPOOL_Q_ENDPAGEPRINTER *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_endpageprinter(const char *desc, SPOOL_Q_ENDPAGEPRINTER *q_u, prs_struct *ps, int depth)
 {
        if (q_u == NULL) return False;
 
@@ -1333,11 +1776,11 @@ BOOL spoolss_io_q_endpageprinter(char *desc, SPOOL_Q_ENDPAGEPRINTER *q_u, prs_st
  * called from spoolss_r_endpageprinter (srv_spoolss.c)
  ********************************************************************/
 
-BOOL spoolss_io_r_endpageprinter(char *desc, SPOOL_R_ENDPAGEPRINTER *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_endpageprinter(const char *desc, SPOOL_R_ENDPAGEPRINTER *r_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_r_endpageprinter");
        depth++;
-       if(!prs_uint32("status", ps, depth, &r_u->status))
+       if(!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -1348,7 +1791,7 @@ BOOL spoolss_io_r_endpageprinter(char *desc, SPOOL_R_ENDPAGEPRINTER *r_u, prs_st
  * called from spoolss_q_writeprinter (srv_spoolss.c)
  ********************************************************************/
 
-BOOL spoolss_io_q_writeprinter(char *desc, SPOOL_Q_WRITEPRINTER *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_writeprinter(const char *desc, SPOOL_Q_WRITEPRINTER *q_u, prs_struct *ps, int depth)
 {
        if (q_u == NULL) return False;
 
@@ -1385,13 +1828,13 @@ BOOL spoolss_io_q_writeprinter(char *desc, SPOOL_Q_WRITEPRINTER *q_u, prs_struct
  * called from spoolss_r_writeprinter (srv_spoolss.c)
  ********************************************************************/
 
-BOOL spoolss_io_r_writeprinter(char *desc, SPOOL_R_WRITEPRINTER *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_writeprinter(const char *desc, SPOOL_R_WRITEPRINTER *r_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_r_writeprinter");
        depth++;
        if(!prs_uint32("buffer_written", ps, depth, &r_u->buffer_written))
                return False;
-       if(!prs_uint32("status", ps, depth, &r_u->status))
+       if(!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -1402,7 +1845,7 @@ BOOL spoolss_io_r_writeprinter(char *desc, SPOOL_R_WRITEPRINTER *r_u, prs_struct
  * called from spoolss_q_rffpcnex (srv_spoolss.c)
  ********************************************************************/
 
-BOOL spoolss_io_q_rffpcnex(char *desc, SPOOL_Q_RFFPCNEX *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_rffpcnex(const char *desc, SPOOL_Q_RFFPCNEX *q_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_q_rffpcnex");
        depth++;
@@ -1448,12 +1891,12 @@ BOOL spoolss_io_q_rffpcnex(char *desc, SPOOL_Q_RFFPCNEX *q_u, prs_struct *ps, in
  * called from spoolss_r_rffpcnex (srv_spoolss.c)
  ********************************************************************/
 
-BOOL spoolss_io_r_rffpcnex(char *desc, SPOOL_R_RFFPCNEX *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_rffpcnex(const char *desc, SPOOL_R_RFFPCNEX *r_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_r_rffpcnex");
        depth++;
 
-       if(!prs_uint32("status", ps, depth, &r_u->status))
+       if(!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -1464,7 +1907,7 @@ BOOL spoolss_io_r_rffpcnex(char *desc, SPOOL_R_RFFPCNEX *r_u, prs_struct *ps, in
  * called from spoolss_q_rfnpcnex (srv_spoolss.c)
  ********************************************************************/
 
-BOOL spoolss_io_q_rfnpcnex(char *desc, SPOOL_Q_RFNPCNEX *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_rfnpcnex(const char *desc, SPOOL_Q_RFNPCNEX *q_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_q_rfnpcnex");
        depth++;
@@ -1499,7 +1942,7 @@ BOOL spoolss_io_q_rfnpcnex(char *desc, SPOOL_Q_RFNPCNEX *q_u, prs_struct *ps, in
  * called from spoolss_r_rfnpcnex (srv_spoolss.c)
  ********************************************************************/
 
-BOOL spoolss_io_r_rfnpcnex(char *desc, SPOOL_R_RFNPCNEX *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_rfnpcnex(const char *desc, SPOOL_R_RFNPCNEX *r_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_r_rfnpcnex");
        depth++;
@@ -1515,7 +1958,7 @@ BOOL spoolss_io_r_rfnpcnex(char *desc, SPOOL_R_RFNPCNEX *r_u, prs_struct *ps, in
        
        if(!prs_align(ps))
                return False;
-       if(!prs_uint32("status", ps, depth, &r_u->status))
+       if(!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -1559,12 +2002,19 @@ static uint32 size_of_relative_string(UNISTR *string)
        uint32 size=0;
        
        size=str_len_uni(string);       /* the string length       */
-       size=size+1;                    /* add the leading zero    */
+       size=size+1;                    /* add the trailing zero   */
        size=size*2;                    /* convert in char         */
-       /* Ensure size is 4 byte multiple (prs_align is being called...). */
-       size += ((4 - (size & 3)) & 3);
        size=size+4;                    /* add the size of the ptr */   
 
+#if 0  /* JERRY */
+       /* 
+        * Do not include alignment as Win2k does not align relative
+        * strings within a buffer   --jerry 
+        */
+       /* Ensure size is 4 byte multiple (prs_align is being called...). */
+       /* size += ((4 - (size & 3)) & 3); */
+#endif 
+
        return size;
 }
 
@@ -1592,32 +2042,6 @@ static uint32 size_of_systemtime(SYSTEMTIME *systime)
                return (sizeof(SYSTEMTIME) +4);
 }
 
-/*******************************************************************
- * write a UNICODE string.
- * used by all the RPC structs passing a buffer
- ********************************************************************/
-
-static BOOL spoolss_smb_io_unistr(char *desc, UNISTR *uni, prs_struct *ps, int depth)
-{
-       if (uni == NULL)
-               return False;
-
-       prs_debug(ps, depth, desc, "spoolss_smb_io_unistr");
-       depth++;
-       
-       /* there should be no align here as it can mess up
-          parsing a NEW_BUFFER->prs */
-#if 0  /* JERRY */
-       if (!prs_align(ps))
-               return False;
-#endif
-               
-       if (!prs_unistr("unistr", ps, depth, uni))
-               return False;
-
-       return True;
-}
-
 /*******************************************************************
  * write a UNICODE string and its relative pointer.
  * used by all the RPC structs passing a buffer
@@ -1638,7 +2062,7 @@ static BOOL spoolss_smb_io_unistr(char *desc, UNISTR *uni, prs_struct *ps, int d
  *
  ********************************************************************/
 
-static BOOL new_smb_io_relstr(char *desc, NEW_BUFFER *buffer, int depth, UNISTR *string)
+static BOOL smb_io_relstr(const char *desc, NEW_BUFFER *buffer, int depth, UNISTR *string)
 {
        prs_struct *ps=&buffer->prs;
        
@@ -1649,8 +2073,14 @@ static BOOL new_smb_io_relstr(char *desc, NEW_BUFFER *buffer, int depth, UNISTR
                buffer->string_at_end -= (size_of_relative_string(string) - 4);
                if(!prs_set_offset(ps, buffer->string_at_end))
                        return False;
+#if 0  /* JERRY */
+               /*
+                * Win2k does not align strings in a buffer
+                * Tested against WinNT 4.0 SP 6a & 2k SP2  --jerry
+                */
                if (!prs_align(ps))
                        return False;
+#endif
                buffer->string_at_end = prs_offset(ps);
                
                /* write the string */
@@ -1672,12 +2102,15 @@ static BOOL new_smb_io_relstr(char *desc, NEW_BUFFER *buffer, int depth, UNISTR
                if (!prs_uint32("offset", ps, depth, &(buffer->string_at_end)))
                        return False;
 
+               if (buffer->string_at_end == 0)
+                       return True;
+
                old_offset = prs_offset(ps);
                if(!prs_set_offset(ps, buffer->string_at_end+buffer->struct_start))
                        return False;
 
                /* read the string */
-               if (!spoolss_smb_io_unistr(desc, string, ps, depth))
+               if (!smb_io_unistr(desc, string, ps, depth))
                        return False;
 
                if(!prs_set_offset(ps, old_offset))
@@ -1691,7 +2124,7 @@ static BOOL new_smb_io_relstr(char *desc, NEW_BUFFER *buffer, int depth, UNISTR
  * used by 2 RPC structs
  ********************************************************************/
 
-static BOOL new_smb_io_relarraystr(char *desc, NEW_BUFFER *buffer, int depth, uint16 **string)
+static BOOL smb_io_relarraystr(const char *desc, NEW_BUFFER *buffer, int depth, uint16 **string)
 {
        UNISTR chaine;
        
@@ -1729,19 +2162,19 @@ static BOOL new_smb_io_relarraystr(char *desc, NEW_BUFFER *buffer, int depth, ui
                        buffer->string_at_end -= (q-p+1)*sizeof(uint16);
 
                        if(!prs_set_offset(ps, buffer->string_at_end)) {
-                               free(chaine.buffer);
+                               SAFE_FREE(chaine.buffer);
                                return False;
                        }
 
                        /* write the string */
-                       if (!spoolss_smb_io_unistr(desc, &chaine, ps, depth)) {
-                               free(chaine.buffer);
+                       if (!smb_io_unistr(desc, &chaine, ps, depth)) {
+                               SAFE_FREE(chaine.buffer);
                                return False;
                        }
                        q++;
                        p=q;
 
-                       free(chaine.buffer);
+                       SAFE_FREE(chaine.buffer);
                }
                
                if(!prs_set_offset(ps, struct_offset))
@@ -1773,7 +2206,7 @@ static BOOL new_smb_io_relarraystr(char *desc, NEW_BUFFER *buffer, int depth, ui
                        return False;
        
                do {
-                       if (!spoolss_smb_io_unistr(desc, &chaine, ps, depth))
+                       if (!smb_io_unistr(desc, &chaine, ps, depth))
                                return False;
                        
                        l_chaine=str_len_uni(&chaine);
@@ -1783,12 +2216,17 @@ static BOOL new_smb_io_relarraystr(char *desc, NEW_BUFFER *buffer, int depth, ui
                           an extra NULL for termination */
                        if (l_chaine > 0)
                        {
+                               uint16 *tc2;
+                       
                                realloc_size = (l_chaine2+l_chaine+2)*sizeof(uint16);
 
                                /* Yes this should be realloc - it's freed below. JRA */
 
-                               if((chaine2=(uint16 *)Realloc(chaine2, realloc_size)) == NULL)
+                               if((tc2=(uint16 *)Realloc(chaine2, realloc_size)) == NULL) {
+                                       SAFE_FREE(chaine2);
                                        return False;
+                               }
+                               else chaine2 = tc2;
                                memcpy(chaine2+l_chaine2, chaine.buffer, (l_chaine+1)*sizeof(uint16));
                                l_chaine2+=l_chaine+1;
                        }
@@ -1801,7 +2239,7 @@ static BOOL new_smb_io_relarraystr(char *desc, NEW_BUFFER *buffer, int depth, ui
                {
                        chaine2[l_chaine2] = '\0';
                        *string=(uint16 *)talloc_memdup(prs_get_mem_context(ps),chaine2,realloc_size);
-                       free(chaine2);
+                       SAFE_FREE(chaine2);
                }
 
                if(!prs_set_offset(ps, old_offset))
@@ -1814,11 +2252,11 @@ static BOOL new_smb_io_relarraystr(char *desc, NEW_BUFFER *buffer, int depth, ui
  Parse a DEVMODE structure and its relative pointer.
 ********************************************************************/
 
-static BOOL new_smb_io_relsecdesc(char *desc, NEW_BUFFER *buffer, int depth, SEC_DESC **secdesc)
+static BOOL smb_io_relsecdesc(const char *desc, NEW_BUFFER *buffer, int depth, SEC_DESC **secdesc)
 {
        prs_struct *ps= &buffer->prs;
 
-       prs_debug(ps, depth, desc, "new_smb_io_relsecdesc");
+       prs_debug(ps, depth, desc, "smb_io_relsecdesc");
        depth++;
 
        if (MARSHALLING(ps)) {
@@ -1875,11 +2313,11 @@ static BOOL new_smb_io_relsecdesc(char *desc, NEW_BUFFER *buffer, int depth, SEC
  Parse a DEVMODE structure and its relative pointer.
 ********************************************************************/
 
-static BOOL new_smb_io_reldevmode(char *desc, NEW_BUFFER *buffer, int depth, DEVICEMODE **devmode)
+static BOOL smb_io_reldevmode(const char *desc, NEW_BUFFER *buffer, int depth, DEVICEMODE **devmode)
 {
        prs_struct *ps=&buffer->prs;
 
-       prs_debug(ps, depth, desc, "new_smb_io_reldevmode");
+       prs_debug(ps, depth, desc, "smb_io_reldevmode");
        depth++;
 
        if (MARSHALLING(ps)) {
@@ -1918,6 +2356,10 @@ static BOOL new_smb_io_reldevmode(char *desc, NEW_BUFFER *buffer, int depth, DEV
                /* read the offset */
                if (!prs_uint32("offset", ps, depth, &buffer->string_at_end))
                        return False;
+               if (buffer->string_at_end == 0) {
+                       *devmode = NULL;
+                       return True;
+               }
 
                old_offset = prs_offset(ps);
                if(!prs_set_offset(ps, buffer->string_at_end + buffer->struct_start))
@@ -1939,7 +2381,7 @@ static BOOL new_smb_io_reldevmode(char *desc, NEW_BUFFER *buffer, int depth, DEV
  Parse a PRINTER_INFO_0 structure.
 ********************************************************************/  
 
-BOOL new_smb_io_printer_info_0(char *desc, NEW_BUFFER *buffer, PRINTER_INFO_0 *info, int depth)
+BOOL smb_io_printer_info_0(const char *desc, NEW_BUFFER *buffer, PRINTER_INFO_0 *info, int depth)
 {
        prs_struct *ps=&buffer->prs;
 
@@ -1948,9 +2390,9 @@ BOOL new_smb_io_printer_info_0(char *desc, NEW_BUFFER *buffer, PRINTER_INFO_0 *i
        
        buffer->struct_start=prs_offset(ps);
 
-       if (!new_smb_io_relstr("printername", buffer, depth, &info->printername))
+       if (!smb_io_relstr("printername", buffer, depth, &info->printername))
                return False;
-       if (!new_smb_io_relstr("servername", buffer, depth, &info->servername))
+       if (!smb_io_relstr("servername", buffer, depth, &info->servername))
                return False;
        
        if(!prs_uint32("cjobs", ps, depth, &info->cjobs))
@@ -2040,22 +2482,22 @@ BOOL new_smb_io_printer_info_0(char *desc, NEW_BUFFER *buffer, PRINTER_INFO_0 *i
  Parse a PRINTER_INFO_1 structure.
 ********************************************************************/  
 
-BOOL new_smb_io_printer_info_1(char *desc, NEW_BUFFER *buffer, PRINTER_INFO_1 *info, int depth)
+BOOL smb_io_printer_info_1(const char *desc, NEW_BUFFER *buffer, PRINTER_INFO_1 *info, int depth)
 {
        prs_struct *ps=&buffer->prs;
 
-       prs_debug(ps, depth, desc, "new_smb_io_printer_info_1");
+       prs_debug(ps, depth, desc, "smb_io_printer_info_1");
        depth++;        
        
        buffer->struct_start=prs_offset(ps);
 
        if (!prs_uint32("flags", ps, depth, &info->flags))
                return False;
-       if (!new_smb_io_relstr("description", buffer, depth, &info->description))
+       if (!smb_io_relstr("description", buffer, depth, &info->description))
                return False;
-       if (!new_smb_io_relstr("name", buffer, depth, &info->name))
+       if (!smb_io_relstr("name", buffer, depth, &info->name))
                return False;
-       if (!new_smb_io_relstr("comment", buffer, depth, &info->comment))
+       if (!smb_io_relstr("comment", buffer, depth, &info->comment))
                return False;   
 
        return True;
@@ -2065,44 +2507,71 @@ BOOL new_smb_io_printer_info_1(char *desc, NEW_BUFFER *buffer, PRINTER_INFO_1 *i
  Parse a PRINTER_INFO_2 structure.
 ********************************************************************/  
 
-BOOL new_smb_io_printer_info_2(char *desc, NEW_BUFFER *buffer, PRINTER_INFO_2 *info, int depth)
+BOOL smb_io_printer_info_2(const char *desc, NEW_BUFFER *buffer, PRINTER_INFO_2 *info, int depth)
 {
        prs_struct *ps=&buffer->prs;
+       uint32 dm_offset, sd_offset, current_offset;
+       uint32 dummy_value = 0, has_secdesc = 0;
 
-       prs_debug(ps, depth, desc, "new_smb_io_printer_info_2");
+       prs_debug(ps, depth, desc, "smb_io_printer_info_2");
        depth++;        
        
        buffer->struct_start=prs_offset(ps);
        
-       if (!new_smb_io_relstr("servername", buffer, depth, &info->servername))
+       if (!smb_io_relstr("servername", buffer, depth, &info->servername))
                return False;
-       if (!new_smb_io_relstr("printername", buffer, depth, &info->printername))
+       if (!smb_io_relstr("printername", buffer, depth, &info->printername))
                return False;
-       if (!new_smb_io_relstr("sharename", buffer, depth, &info->sharename))
+       if (!smb_io_relstr("sharename", buffer, depth, &info->sharename))
                return False;
-       if (!new_smb_io_relstr("portname", buffer, depth, &info->portname))
+       if (!smb_io_relstr("portname", buffer, depth, &info->portname))
                return False;
-       if (!new_smb_io_relstr("drivername", buffer, depth, &info->drivername))
+       if (!smb_io_relstr("drivername", buffer, depth, &info->drivername))
                return False;
-       if (!new_smb_io_relstr("comment", buffer, depth, &info->comment))
+       if (!smb_io_relstr("comment", buffer, depth, &info->comment))
                return False;
-       if (!new_smb_io_relstr("location", buffer, depth, &info->location))
+       if (!smb_io_relstr("location", buffer, depth, &info->location))
                return False;
 
-       /* NT parses the DEVMODE at the end of the struct */
-       if (!new_smb_io_reldevmode("devmode", buffer, depth, &info->devmode))
+       /* save current offset and wind forwared by a uint32 */
+       dm_offset = prs_offset(ps);
+       if (!prs_uint32("devmode", ps, depth, &dummy_value))
                return False;
        
-       if (!new_smb_io_relstr("sepfile", buffer, depth, &info->sepfile))
+       if (!smb_io_relstr("sepfile", buffer, depth, &info->sepfile))
+               return False;
+       if (!smb_io_relstr("printprocessor", buffer, depth, &info->printprocessor))
+               return False;
+       if (!smb_io_relstr("datatype", buffer, depth, &info->datatype))
+               return False;
+       if (!smb_io_relstr("parameters", buffer, depth, &info->parameters))
                return False;
-       if (!new_smb_io_relstr("printprocessor", buffer, depth, &info->printprocessor))
+
+       /* save current offset for the sec_desc */
+       sd_offset = prs_offset(ps);
+       if (!prs_uint32("sec_desc", ps, depth, &has_secdesc))
                return False;
-       if (!new_smb_io_relstr("datatype", buffer, depth, &info->datatype))
+
+       
+       /* save current location so we can pick back up here */
+       current_offset = prs_offset(ps);
+       
+       /* parse the devmode */
+       if (!prs_set_offset(ps, dm_offset))
                return False;
-       if (!new_smb_io_relstr("parameters", buffer, depth, &info->parameters))
+       if (!smb_io_reldevmode("devmode", buffer, depth, &info->devmode))
                return False;
+       
+       /* parse the sec_desc */
+       if (has_secdesc) {
+               if (!prs_set_offset(ps, sd_offset))
+                       return False;
+               if (!smb_io_relsecdesc("secdesc", buffer, depth, &info->secdesc))
+                       return False;
+       }
 
-       if (!new_smb_io_relsecdesc("secdesc", buffer, depth, &info->secdesc))
+       /* pick up where we left off */
+       if (!prs_set_offset(ps, current_offset))
                return False;
 
        if (!prs_uint32("attributes", ps, depth, &info->attributes))
@@ -2122,13 +2591,6 @@ BOOL new_smb_io_printer_info_2(char *desc, NEW_BUFFER *buffer, PRINTER_INFO_2 *i
        if (!prs_uint32("averageppm", ps, depth, &info->averageppm))
                return False;
 
-#if 0 /* JFMTEST */
-       if (!prs_uint32_post("secdesc_ptr", ps, depth, NULL, sec_offset, info->secdesc ? prs_offset(ps)-buffer->struct_start : 0 ))
-               return False;
-
-       if (!sec_io_desc("secdesc", &info->secdesc, ps, depth)) 
-               return False;
-#endif
        return True;
 }
 
@@ -2136,11 +2598,11 @@ BOOL new_smb_io_printer_info_2(char *desc, NEW_BUFFER *buffer, PRINTER_INFO_2 *i
  Parse a PRINTER_INFO_3 structure.
 ********************************************************************/  
 
-BOOL new_smb_io_printer_info_3(char *desc, NEW_BUFFER *buffer, PRINTER_INFO_3 *info, int depth)
+BOOL smb_io_printer_info_3(const char *desc, NEW_BUFFER *buffer, PRINTER_INFO_3 *info, int depth)
 {
        prs_struct *ps=&buffer->prs;
 
-       prs_debug(ps, depth, desc, "new_smb_io_printer_info_3");
+       prs_debug(ps, depth, desc, "smb_io_printer_info_3");
        depth++;        
        
        buffer->struct_start=prs_offset(ps);
@@ -2153,20 +2615,88 @@ BOOL new_smb_io_printer_info_3(char *desc, NEW_BUFFER *buffer, PRINTER_INFO_3 *i
        return True;
 }
 
+/*******************************************************************
+ Parse a PRINTER_INFO_4 structure.
+********************************************************************/  
+
+BOOL smb_io_printer_info_4(const char *desc, NEW_BUFFER *buffer, PRINTER_INFO_4 *info, int depth)
+{
+       prs_struct *ps=&buffer->prs;
+
+       prs_debug(ps, depth, desc, "smb_io_printer_info_4");
+       depth++;        
+       
+       buffer->struct_start=prs_offset(ps);
+       
+       if (!smb_io_relstr("printername", buffer, depth, &info->printername))
+               return False;
+       if (!smb_io_relstr("servername", buffer, depth, &info->servername))
+               return False;
+       if (!prs_uint32("attributes", ps, depth, &info->attributes))
+               return False;
+       return True;
+}
+
+/*******************************************************************
+ Parse a PRINTER_INFO_5 structure.
+********************************************************************/  
+
+BOOL smb_io_printer_info_5(const char *desc, NEW_BUFFER *buffer, PRINTER_INFO_5 *info, int depth)
+{
+       prs_struct *ps=&buffer->prs;
+
+       prs_debug(ps, depth, desc, "smb_io_printer_info_5");
+       depth++;        
+       
+       buffer->struct_start=prs_offset(ps);
+       
+       if (!smb_io_relstr("printername", buffer, depth, &info->printername))
+               return False;
+       if (!smb_io_relstr("portname", buffer, depth, &info->portname))
+               return False;
+       if (!prs_uint32("attributes", ps, depth, &info->attributes))
+               return False;
+       if (!prs_uint32("device_not_selected_timeout", ps, depth, &info->device_not_selected_timeout))
+               return False;
+       if (!prs_uint32("transmission_retry_timeout", ps, depth, &info->transmission_retry_timeout))
+               return False;
+       return True;
+}
+
+/*******************************************************************
+ Parse a PRINTER_INFO_7 structure.
+********************************************************************/  
+
+BOOL smb_io_printer_info_7(const char *desc, NEW_BUFFER *buffer, PRINTER_INFO_7 *info, int depth)
+{
+       prs_struct *ps=&buffer->prs;
+
+       prs_debug(ps, depth, desc, "smb_io_printer_info_7");
+       depth++;        
+       
+       buffer->struct_start=prs_offset(ps);
+       
+       if (!smb_io_relstr("guid", buffer, depth, &info->guid))
+               return False;
+       if (!prs_uint32("action", ps, depth, &info->action))
+               return False;
+       return True;
+}
+
 /*******************************************************************
  Parse a PORT_INFO_1 structure.
 ********************************************************************/  
 
-BOOL new_smb_io_port_info_1(char *desc, NEW_BUFFER *buffer, PORT_INFO_1 *info, int depth)
+BOOL smb_io_port_info_1(const char *desc, NEW_BUFFER *buffer, PORT_INFO_1 *info, int depth)
 {
        prs_struct *ps=&buffer->prs;
 
-       prs_debug(ps, depth, desc, "new_smb_io_port_info_1");
+       prs_debug(ps, depth, desc, "smb_io_port_info_1");
        depth++;        
        
        buffer->struct_start=prs_offset(ps);
        
-       if (!new_smb_io_relstr("port_name", buffer, depth, &info->port_name))
+       if (!smb_io_relstr("port_name", buffer, depth, &info->port_name))
                return False;
 
        return True;
@@ -2176,20 +2706,20 @@ BOOL new_smb_io_port_info_1(char *desc, NEW_BUFFER *buffer, PORT_INFO_1 *info, i
  Parse a PORT_INFO_2 structure.
 ********************************************************************/  
 
-BOOL new_smb_io_port_info_2(char *desc, NEW_BUFFER *buffer, PORT_INFO_2 *info, int depth)
+BOOL smb_io_port_info_2(const char *desc, NEW_BUFFER *buffer, PORT_INFO_2 *info, int depth)
 {
        prs_struct *ps=&buffer->prs;
 
-       prs_debug(ps, depth, desc, "new_smb_io_port_info_2");
+       prs_debug(ps, depth, desc, "smb_io_port_info_2");
        depth++;        
        
        buffer->struct_start=prs_offset(ps);
        
-       if (!new_smb_io_relstr("port_name", buffer, depth, &info->port_name))
+       if (!smb_io_relstr("port_name", buffer, depth, &info->port_name))
                return False;
-       if (!new_smb_io_relstr("monitor_name", buffer, depth, &info->monitor_name))
+       if (!smb_io_relstr("monitor_name", buffer, depth, &info->monitor_name))
                return False;
-       if (!new_smb_io_relstr("description", buffer, depth, &info->description))
+       if (!smb_io_relstr("description", buffer, depth, &info->description))
                return False;
        if (!prs_uint32("port_type", ps, depth, &info->port_type))
                return False;
@@ -2203,16 +2733,16 @@ BOOL new_smb_io_port_info_2(char *desc, NEW_BUFFER *buffer, PORT_INFO_2 *info, i
  Parse a DRIVER_INFO_1 structure.
 ********************************************************************/
 
-BOOL new_smb_io_printer_driver_info_1(char *desc, NEW_BUFFER *buffer, DRIVER_INFO_1 *info, int depth) 
+BOOL smb_io_printer_driver_info_1(const char *desc, NEW_BUFFER *buffer, DRIVER_INFO_1 *info, int depth) 
 {
        prs_struct *ps=&buffer->prs;
 
-       prs_debug(ps, depth, desc, "new_smb_io_printer_driver_info_1");
+       prs_debug(ps, depth, desc, "smb_io_printer_driver_info_1");
        depth++;        
        
        buffer->struct_start=prs_offset(ps);
 
-       if (!new_smb_io_relstr("name", buffer, depth, &info->name))
+       if (!smb_io_relstr("name", buffer, depth, &info->name))
                return False;
 
        return True;
@@ -2222,26 +2752,26 @@ BOOL new_smb_io_printer_driver_info_1(char *desc, NEW_BUFFER *buffer, DRIVER_INF
  Parse a DRIVER_INFO_2 structure.
 ********************************************************************/
 
-BOOL new_smb_io_printer_driver_info_2(char *desc, NEW_BUFFER *buffer, DRIVER_INFO_2 *info, int depth) 
+BOOL smb_io_printer_driver_info_2(const char *desc, NEW_BUFFER *buffer, DRIVER_INFO_2 *info, int depth) 
 {
        prs_struct *ps=&buffer->prs;
 
-       prs_debug(ps, depth, desc, "new_smb_io_printer_driver_info_2");
+       prs_debug(ps, depth, desc, "smb_io_printer_driver_info_2");
        depth++;        
        
        buffer->struct_start=prs_offset(ps);
 
        if (!prs_uint32("version", ps, depth, &info->version))
                return False;
-       if (!new_smb_io_relstr("name", buffer, depth, &info->name))
+       if (!smb_io_relstr("name", buffer, depth, &info->name))
                return False;
-       if (!new_smb_io_relstr("architecture", buffer, depth, &info->architecture))
+       if (!smb_io_relstr("architecture", buffer, depth, &info->architecture))
                return False;
-       if (!new_smb_io_relstr("driverpath", buffer, depth, &info->driverpath))
+       if (!smb_io_relstr("driverpath", buffer, depth, &info->driverpath))
                return False;
-       if (!new_smb_io_relstr("datafile", buffer, depth, &info->datafile))
+       if (!smb_io_relstr("datafile", buffer, depth, &info->datafile))
                return False;
-       if (!new_smb_io_relstr("configfile", buffer, depth, &info->configfile))
+       if (!smb_io_relstr("configfile", buffer, depth, &info->configfile))
                return False;
 
        return True;
@@ -2251,36 +2781,36 @@ BOOL new_smb_io_printer_driver_info_2(char *desc, NEW_BUFFER *buffer, DRIVER_INF
  Parse a DRIVER_INFO_3 structure.
 ********************************************************************/
 
-BOOL new_smb_io_printer_driver_info_3(char *desc, NEW_BUFFER *buffer, DRIVER_INFO_3 *info, int depth)
+BOOL smb_io_printer_driver_info_3(const char *desc, NEW_BUFFER *buffer, DRIVER_INFO_3 *info, int depth)
 {
        prs_struct *ps=&buffer->prs;
 
-       prs_debug(ps, depth, desc, "new_smb_io_printer_driver_info_3");
+       prs_debug(ps, depth, desc, "smb_io_printer_driver_info_3");
        depth++;        
        
        buffer->struct_start=prs_offset(ps);
 
        if (!prs_uint32("version", ps, depth, &info->version))
                return False;
-       if (!new_smb_io_relstr("name", buffer, depth, &info->name))
+       if (!smb_io_relstr("name", buffer, depth, &info->name))
                return False;
-       if (!new_smb_io_relstr("architecture", buffer, depth, &info->architecture))
+       if (!smb_io_relstr("architecture", buffer, depth, &info->architecture))
                return False;
-       if (!new_smb_io_relstr("driverpath", buffer, depth, &info->driverpath))
+       if (!smb_io_relstr("driverpath", buffer, depth, &info->driverpath))
                return False;
-       if (!new_smb_io_relstr("datafile", buffer, depth, &info->datafile))
+       if (!smb_io_relstr("datafile", buffer, depth, &info->datafile))
                return False;
-       if (!new_smb_io_relstr("configfile", buffer, depth, &info->configfile))
+       if (!smb_io_relstr("configfile", buffer, depth, &info->configfile))
                return False;
-       if (!new_smb_io_relstr("helpfile", buffer, depth, &info->helpfile))
+       if (!smb_io_relstr("helpfile", buffer, depth, &info->helpfile))
                return False;
 
-       if (!new_smb_io_relarraystr("dependentfiles", buffer, depth, &info->dependentfiles))
+       if (!smb_io_relarraystr("dependentfiles", buffer, depth, &info->dependentfiles))
                return False;
 
-       if (!new_smb_io_relstr("monitorname", buffer, depth, &info->monitorname))
+       if (!smb_io_relstr("monitorname", buffer, depth, &info->monitorname))
                return False;
-       if (!new_smb_io_relstr("defaultdatatype", buffer, depth, &info->defaultdatatype))
+       if (!smb_io_relstr("defaultdatatype", buffer, depth, &info->defaultdatatype))
                return False;
 
        return True;
@@ -2290,39 +2820,39 @@ BOOL new_smb_io_printer_driver_info_3(char *desc, NEW_BUFFER *buffer, DRIVER_INF
  Parse a DRIVER_INFO_6 structure.
 ********************************************************************/
 
-BOOL new_smb_io_printer_driver_info_6(char *desc, NEW_BUFFER *buffer, DRIVER_INFO_6 *info, int depth)
+BOOL smb_io_printer_driver_info_6(const char *desc, NEW_BUFFER *buffer, DRIVER_INFO_6 *info, int depth)
 {
        prs_struct *ps=&buffer->prs;
 
-       prs_debug(ps, depth, desc, "new_smb_io_printer_driver_info_6");
+       prs_debug(ps, depth, desc, "smb_io_printer_driver_info_6");
        depth++;        
        
        buffer->struct_start=prs_offset(ps);
 
        if (!prs_uint32("version", ps, depth, &info->version))
                return False;
-       if (!new_smb_io_relstr("name", buffer, depth, &info->name))
+       if (!smb_io_relstr("name", buffer, depth, &info->name))
                return False;
-       if (!new_smb_io_relstr("architecture", buffer, depth, &info->architecture))
+       if (!smb_io_relstr("architecture", buffer, depth, &info->architecture))
                return False;
-       if (!new_smb_io_relstr("driverpath", buffer, depth, &info->driverpath))
+       if (!smb_io_relstr("driverpath", buffer, depth, &info->driverpath))
                return False;
-       if (!new_smb_io_relstr("datafile", buffer, depth, &info->datafile))
+       if (!smb_io_relstr("datafile", buffer, depth, &info->datafile))
                return False;
-       if (!new_smb_io_relstr("configfile", buffer, depth, &info->configfile))
+       if (!smb_io_relstr("configfile", buffer, depth, &info->configfile))
                return False;
-       if (!new_smb_io_relstr("helpfile", buffer, depth, &info->helpfile))
+       if (!smb_io_relstr("helpfile", buffer, depth, &info->helpfile))
                return False;
 
-       if (!new_smb_io_relarraystr("dependentfiles", buffer, depth, &info->dependentfiles))
+       if (!smb_io_relarraystr("dependentfiles", buffer, depth, &info->dependentfiles))
                return False;
 
-       if (!new_smb_io_relstr("monitorname", buffer, depth, &info->monitorname))
+       if (!smb_io_relstr("monitorname", buffer, depth, &info->monitorname))
                return False;
-       if (!new_smb_io_relstr("defaultdatatype", buffer, depth, &info->defaultdatatype))
+       if (!smb_io_relstr("defaultdatatype", buffer, depth, &info->defaultdatatype))
                return False;
 
-       if (!new_smb_io_relarraystr("previousdrivernames", buffer, depth, &info->previousdrivernames))
+       if (!smb_io_relarraystr("previousdrivernames", buffer, depth, &info->previousdrivernames))
                return False;
 
        if (!prs_uint32("date.low", ps, depth, &info->driver_date.low))
@@ -2339,13 +2869,13 @@ BOOL new_smb_io_printer_driver_info_6(char *desc, NEW_BUFFER *buffer, DRIVER_INF
        if (!prs_uint32("driver_version_high", ps, depth, &info->driver_version_high))
                return False;
 
-       if (!new_smb_io_relstr("mfgname", buffer, depth, &info->mfgname))
+       if (!smb_io_relstr("mfgname", buffer, depth, &info->mfgname))
                return False;
-       if (!new_smb_io_relstr("oem_url", buffer, depth, &info->oem_url))
+       if (!smb_io_relstr("oem_url", buffer, depth, &info->oem_url))
                return False;
-       if (!new_smb_io_relstr("hardware_id", buffer, depth, &info->hardware_id))
+       if (!smb_io_relstr("hardware_id", buffer, depth, &info->hardware_id))
                return False;
-       if (!new_smb_io_relstr("provider", buffer, depth, &info->provider))
+       if (!smb_io_relstr("provider", buffer, depth, &info->provider))
                return False;
        
        return True;
@@ -2355,28 +2885,28 @@ BOOL new_smb_io_printer_driver_info_6(char *desc, NEW_BUFFER *buffer, DRIVER_INF
  Parse a JOB_INFO_1 structure.
 ********************************************************************/  
 
-BOOL new_smb_io_job_info_1(char *desc, NEW_BUFFER *buffer, JOB_INFO_1 *info, int depth)
+BOOL smb_io_job_info_1(const char *desc, NEW_BUFFER *buffer, JOB_INFO_1 *info, int depth)
 {
        prs_struct *ps=&buffer->prs;
 
-       prs_debug(ps, depth, desc, "new_smb_io_job_info_1");
+       prs_debug(ps, depth, desc, "smb_io_job_info_1");
        depth++;        
        
        buffer->struct_start=prs_offset(ps);
 
        if (!prs_uint32("jobid", ps, depth, &info->jobid))
                return False;
-       if (!new_smb_io_relstr("printername", buffer, depth, &info->printername))
+       if (!smb_io_relstr("printername", buffer, depth, &info->printername))
                return False;
-       if (!new_smb_io_relstr("machinename", buffer, depth, &info->machinename))
+       if (!smb_io_relstr("machinename", buffer, depth, &info->machinename))
                return False;
-       if (!new_smb_io_relstr("username", buffer, depth, &info->username))
+       if (!smb_io_relstr("username", buffer, depth, &info->username))
                return False;
-       if (!new_smb_io_relstr("document", buffer, depth, &info->document))
+       if (!smb_io_relstr("document", buffer, depth, &info->document))
                return False;
-       if (!new_smb_io_relstr("datatype", buffer, depth, &info->datatype))
+       if (!smb_io_relstr("datatype", buffer, depth, &info->datatype))
                return False;
-       if (!new_smb_io_relstr("text_status", buffer, depth, &info->text_status))
+       if (!smb_io_relstr("text_status", buffer, depth, &info->text_status))
                return False;
        if (!prs_uint32("status", ps, depth, &info->status))
                return False;
@@ -2398,40 +2928,40 @@ BOOL new_smb_io_job_info_1(char *desc, NEW_BUFFER *buffer, JOB_INFO_1 *info, int
  Parse a JOB_INFO_2 structure.
 ********************************************************************/  
 
-BOOL new_smb_io_job_info_2(char *desc, NEW_BUFFER *buffer, JOB_INFO_2 *info, int depth)
+BOOL smb_io_job_info_2(const char *desc, NEW_BUFFER *buffer, JOB_INFO_2 *info, int depth)
 {      
-       uint pipo=0;
+       uint32 pipo=0;
        prs_struct *ps=&buffer->prs;
        
-       prs_debug(ps, depth, desc, "new_smb_io_job_info_2");
+       prs_debug(ps, depth, desc, "smb_io_job_info_2");
        depth++;        
 
        buffer->struct_start=prs_offset(ps);
        
        if (!prs_uint32("jobid",ps, depth, &info->jobid))
                return False;
-       if (!new_smb_io_relstr("printername", buffer, depth, &info->printername))
+       if (!smb_io_relstr("printername", buffer, depth, &info->printername))
                return False;
-       if (!new_smb_io_relstr("machinename", buffer, depth, &info->machinename))
+       if (!smb_io_relstr("machinename", buffer, depth, &info->machinename))
                return False;
-       if (!new_smb_io_relstr("username", buffer, depth, &info->username))
+       if (!smb_io_relstr("username", buffer, depth, &info->username))
                return False;
-       if (!new_smb_io_relstr("document", buffer, depth, &info->document))
+       if (!smb_io_relstr("document", buffer, depth, &info->document))
                return False;
-       if (!new_smb_io_relstr("notifyname", buffer, depth, &info->notifyname))
+       if (!smb_io_relstr("notifyname", buffer, depth, &info->notifyname))
                return False;
-       if (!new_smb_io_relstr("datatype", buffer, depth, &info->datatype))
+       if (!smb_io_relstr("datatype", buffer, depth, &info->datatype))
                return False;
 
-       if (!new_smb_io_relstr("printprocessor", buffer, depth, &info->printprocessor))
+       if (!smb_io_relstr("printprocessor", buffer, depth, &info->printprocessor))
                return False;
-       if (!new_smb_io_relstr("parameters", buffer, depth, &info->parameters))
+       if (!smb_io_relstr("parameters", buffer, depth, &info->parameters))
                return False;
-       if (!new_smb_io_relstr("drivername", buffer, depth, &info->drivername))
+       if (!smb_io_relstr("drivername", buffer, depth, &info->drivername))
                return False;
-       if (!new_smb_io_reldevmode("devmode", buffer, depth, &info->devmode))
+       if (!smb_io_reldevmode("devmode", buffer, depth, &info->devmode))
                return False;
-       if (!new_smb_io_relstr("text_status", buffer, depth, &info->text_status))
+       if (!smb_io_relstr("text_status", buffer, depth, &info->text_status))
                return False;
 
 /*     SEC_DESC sec_desc;*/
@@ -2465,11 +2995,11 @@ BOOL new_smb_io_job_info_2(char *desc, NEW_BUFFER *buffer, JOB_INFO_2 *info, int
 /*******************************************************************
 ********************************************************************/  
 
-BOOL new_smb_io_form_1(char *desc, NEW_BUFFER *buffer, FORM_1 *info, int depth)
+BOOL smb_io_form_1(const char *desc, NEW_BUFFER *buffer, FORM_1 *info, int depth)
 {
        prs_struct *ps=&buffer->prs;
        
-       prs_debug(ps, depth, desc, "new_smb_io_form_1");
+       prs_debug(ps, depth, desc, "smb_io_form_1");
        depth++;
                
        buffer->struct_start=prs_offset(ps);
@@ -2477,7 +3007,7 @@ BOOL new_smb_io_form_1(char *desc, NEW_BUFFER *buffer, FORM_1 *info, int depth)
        if (!prs_uint32("flag", ps, depth, &info->flag))
                return False;
                
-       if (!new_smb_io_relstr("name", buffer, depth, &info->name))
+       if (!smb_io_relstr("name", buffer, depth, &info->name))
                return False;
 
        if (!prs_uint32("width", ps, depth, &info->width))
@@ -2500,11 +3030,11 @@ BOOL new_smb_io_form_1(char *desc, NEW_BUFFER *buffer, FORM_1 *info, int depth)
  Read/write a BUFFER struct.
 ********************************************************************/  
 
-static BOOL new_spoolss_io_buffer(char *desc, prs_struct *ps, int depth, NEW_BUFFER **pp_buffer)
+static BOOL spoolss_io_buffer(const char *desc, prs_struct *ps, int depth, NEW_BUFFER **pp_buffer)
 {
        NEW_BUFFER *buffer = *pp_buffer;
 
-       prs_debug(ps, depth, desc, "new_spoolss_io_buffer");
+       prs_debug(ps, depth, desc, "spoolss_io_buffer");
        depth++;
        
        if (UNMARSHALLING(ps))
@@ -2586,15 +3116,16 @@ static BOOL new_spoolss_io_buffer(char *desc, prs_struct *ps, int depth, NEW_BUF
  move a BUFFER from the query to the reply.
  As the data pointers in NEW_BUFFER are malloc'ed, not talloc'ed,
  this is ok. This is an OPTIMIZATION and is not strictly neccessary.
+ Clears the memory to zero also.
 ********************************************************************/  
 
-void new_spoolss_move_buffer(NEW_BUFFER *src, NEW_BUFFER **dest)
+void spoolss_move_buffer(NEW_BUFFER *src, NEW_BUFFER **dest)
 {
        prs_switch_type(&src->prs, MARSHALL);
        if(!prs_set_offset(&src->prs, 0))
                return;
-       prs_force_dynamic(&(src->prs));
-
+       prs_force_dynamic(&src->prs);
+       prs_mem_clear(&src->prs);
        *dest=src;
 }
 
@@ -2611,11 +3142,11 @@ uint32 new_get_buffer_size(NEW_BUFFER *buffer)
  Parse a DRIVER_DIRECTORY_1 structure.
 ********************************************************************/  
 
-BOOL new_smb_io_driverdir_1(char *desc, NEW_BUFFER *buffer, DRIVER_DIRECTORY_1 *info, int depth)
+BOOL smb_io_driverdir_1(const char *desc, NEW_BUFFER *buffer, DRIVER_DIRECTORY_1 *info, int depth)
 {
        prs_struct *ps=&buffer->prs;
 
-       prs_debug(ps, depth, desc, "new_smb_io_driverdir_1");
+       prs_debug(ps, depth, desc, "smb_io_driverdir_1");
        depth++;
 
        buffer->struct_start=prs_offset(ps);
@@ -2630,16 +3161,16 @@ BOOL new_smb_io_driverdir_1(char *desc, NEW_BUFFER *buffer, DRIVER_DIRECTORY_1 *
  Parse a PORT_INFO_1 structure.
 ********************************************************************/  
 
-BOOL new_smb_io_port_1(char *desc, NEW_BUFFER *buffer, PORT_INFO_1 *info, int depth)
+BOOL smb_io_port_1(const char *desc, NEW_BUFFER *buffer, PORT_INFO_1 *info, int depth)
 {
        prs_struct *ps=&buffer->prs;
 
-       prs_debug(ps, depth, desc, "new_smb_io_port_1");
+       prs_debug(ps, depth, desc, "smb_io_port_1");
        depth++;
 
        buffer->struct_start=prs_offset(ps);
 
-       if(!new_smb_io_relstr("port_name", buffer, depth, &info->port_name))
+       if(!smb_io_relstr("port_name", buffer, depth, &info->port_name))
                return False;
 
        return True;
@@ -2649,20 +3180,20 @@ BOOL new_smb_io_port_1(char *desc, NEW_BUFFER *buffer, PORT_INFO_1 *info, int de
  Parse a PORT_INFO_2 structure.
 ********************************************************************/  
 
-BOOL new_smb_io_port_2(char *desc, NEW_BUFFER *buffer, PORT_INFO_2 *info, int depth)
+BOOL smb_io_port_2(const char *desc, NEW_BUFFER *buffer, PORT_INFO_2 *info, int depth)
 {
        prs_struct *ps=&buffer->prs;
 
-       prs_debug(ps, depth, desc, "new_smb_io_port_2");
+       prs_debug(ps, depth, desc, "smb_io_port_2");
        depth++;
 
        buffer->struct_start=prs_offset(ps);
 
-       if(!new_smb_io_relstr("port_name", buffer, depth, &info->port_name))
+       if(!smb_io_relstr("port_name", buffer, depth, &info->port_name))
                return False;
-       if(!new_smb_io_relstr("monitor_name", buffer, depth, &info->monitor_name))
+       if(!smb_io_relstr("monitor_name", buffer, depth, &info->monitor_name))
                return False;
-       if(!new_smb_io_relstr("description", buffer, depth, &info->description))
+       if(!smb_io_relstr("description", buffer, depth, &info->description))
                return False;
        if(!prs_uint32("port_type", ps, depth, &info->port_type))
                return False;
@@ -2675,7 +3206,7 @@ BOOL new_smb_io_port_2(char *desc, NEW_BUFFER *buffer, PORT_INFO_2 *info, int de
 /*******************************************************************
 ********************************************************************/  
 
-BOOL smb_io_printprocessor_info_1(char *desc, NEW_BUFFER *buffer, PRINTPROCESSOR_1 *info, int depth)
+BOOL smb_io_printprocessor_info_1(const char *desc, NEW_BUFFER *buffer, PRINTPROCESSOR_1 *info, int depth)
 {
        prs_struct *ps=&buffer->prs;
 
@@ -2684,7 +3215,7 @@ BOOL smb_io_printprocessor_info_1(char *desc, NEW_BUFFER *buffer, PRINTPROCESSOR
 
        buffer->struct_start=prs_offset(ps);
        
-       if (new_smb_io_relstr("name", buffer, depth, &info->name))
+       if (smb_io_relstr("name", buffer, depth, &info->name))
                return False;
 
        return True;
@@ -2693,7 +3224,7 @@ BOOL smb_io_printprocessor_info_1(char *desc, NEW_BUFFER *buffer, PRINTPROCESSOR
 /*******************************************************************
 ********************************************************************/  
 
-BOOL smb_io_printprocdatatype_info_1(char *desc, NEW_BUFFER *buffer, PRINTPROCDATATYPE_1 *info, int depth)
+BOOL smb_io_printprocdatatype_info_1(const char *desc, NEW_BUFFER *buffer, PRINTPROCDATATYPE_1 *info, int depth)
 {
        prs_struct *ps=&buffer->prs;
 
@@ -2702,7 +3233,7 @@ BOOL smb_io_printprocdatatype_info_1(char *desc, NEW_BUFFER *buffer, PRINTPROCDA
 
        buffer->struct_start=prs_offset(ps);
        
-       if (new_smb_io_relstr("name", buffer, depth, &info->name))
+       if (smb_io_relstr("name", buffer, depth, &info->name))
                return False;
 
        return True;
@@ -2711,7 +3242,7 @@ BOOL smb_io_printprocdatatype_info_1(char *desc, NEW_BUFFER *buffer, PRINTPROCDA
 /*******************************************************************
 ********************************************************************/  
 
-BOOL smb_io_printmonitor_info_1(char *desc, NEW_BUFFER *buffer, PRINTMONITOR_1 *info, int depth)
+BOOL smb_io_printmonitor_info_1(const char *desc, NEW_BUFFER *buffer, PRINTMONITOR_1 *info, int depth)
 {
        prs_struct *ps=&buffer->prs;
 
@@ -2720,7 +3251,7 @@ BOOL smb_io_printmonitor_info_1(char *desc, NEW_BUFFER *buffer, PRINTMONITOR_1 *
 
        buffer->struct_start=prs_offset(ps);
 
-       if (!new_smb_io_relstr("name", buffer, depth, &info->name))
+       if (!smb_io_relstr("name", buffer, depth, &info->name))
                return False;
 
        return True;
@@ -2729,7 +3260,7 @@ BOOL smb_io_printmonitor_info_1(char *desc, NEW_BUFFER *buffer, PRINTMONITOR_1 *
 /*******************************************************************
 ********************************************************************/  
 
-BOOL smb_io_printmonitor_info_2(char *desc, NEW_BUFFER *buffer, PRINTMONITOR_2 *info, int depth)
+BOOL smb_io_printmonitor_info_2(const char *desc, NEW_BUFFER *buffer, PRINTMONITOR_2 *info, int depth)
 {
        prs_struct *ps=&buffer->prs;
 
@@ -2738,11 +3269,11 @@ BOOL smb_io_printmonitor_info_2(char *desc, NEW_BUFFER *buffer, PRINTMONITOR_2 *
 
        buffer->struct_start=prs_offset(ps);
 
-       if (!new_smb_io_relstr("name", buffer, depth, &info->name))
+       if (!smb_io_relstr("name", buffer, depth, &info->name))
                return False;
-       if (!new_smb_io_relstr("environment", buffer, depth, &info->environment))
+       if (!smb_io_relstr("environment", buffer, depth, &info->environment))
                return False;
-       if (!new_smb_io_relstr("dll_name", buffer, depth, &info->dll_name))
+       if (!smb_io_relstr("dll_name", buffer, depth, &info->dll_name))
                return False;
 
        return True;
@@ -2831,7 +3362,7 @@ uint32 spoolss_size_printer_info_2(PRINTER_INFO_2 *info)
        uint32 size=0;
                
        size += 4;
-       /* JRA !!!! TESTME - WHAT ABOUT prs_align.... !!! */
+       
        size += sec_desc_size( info->secdesc );
 
        size+=size_of_device_mode( info->devmode );
@@ -2857,9 +3388,53 @@ uint32 spoolss_size_printer_info_2(PRINTER_INFO_2 *info)
        size+=size_of_uint32( &info->status );
        size+=size_of_uint32( &info->cjobs );
        size+=size_of_uint32( &info->averageppm );      
+               
+       /* 
+        * add any adjustments for alignment.  This is
+        * not optimal since we could be calling this
+        * function from a loop (e.g. enumprinters), but 
+        * it is easier to maintain the calculation here and
+        * not place the burden on the caller to remember.   --jerry
+        */
+       if ((size % 4) != 0)
+               size += 4 - (size % 4);
+       
+       return size;
+}
+
+/*******************************************************************
+return the size required by a struct in the stream
+********************************************************************/
+
+uint32 spoolss_size_printer_info_4(PRINTER_INFO_4 *info)
+{
+       uint32 size=0;
+               
+       size+=size_of_relative_string( &info->printername );
+       size+=size_of_relative_string( &info->servername );
+
+       size+=size_of_uint32( &info->attributes );
        return size;
 }
 
+/*******************************************************************
+return the size required by a struct in the stream
+********************************************************************/
+
+uint32 spoolss_size_printer_info_5(PRINTER_INFO_5 *info)
+{
+       uint32 size=0;
+               
+       size+=size_of_relative_string( &info->printername );
+       size+=size_of_relative_string( &info->portname );
+
+       size+=size_of_uint32( &info->attributes );
+       size+=size_of_uint32( &info->device_not_selected_timeout );
+       size+=size_of_uint32( &info->transmission_retry_timeout );
+       return size;
+}
+
+
 /*******************************************************************
 return the size required by a struct in the stream
 ********************************************************************/
@@ -2875,6 +3450,19 @@ uint32 spoolss_size_printer_info_3(PRINTER_INFO_3 *info)
 return the size required by a struct in the stream
 ********************************************************************/
 
+uint32 spoolss_size_printer_info_7(PRINTER_INFO_7 *info)
+{
+       uint32 size=0;
+               
+       size+=size_of_relative_string( &info->guid );
+       size+=size_of_uint32( &info->action );
+       return size;
+}
+
+/*******************************************************************
+return the size required by a struct in the stream
+********************************************************************/
+
 uint32 spoolss_size_printer_driver_info_1(DRIVER_INFO_1 *info)
 {
        int size=0;
@@ -3089,6 +3677,21 @@ uint32 spoolss_size_driverdir_info_1(DRIVER_DIRECTORY_1 *info)
 return the size required by a struct in the stream
 ********************************************************************/  
 
+uint32 spoolss_size_printprocessordirectory_info_1(PRINTPROCESSOR_DIRECTORY_1 *info)
+{
+       int size=0;
+
+       size=str_len_uni(&info->name);  /* the string length       */
+       size=size+1;                    /* add the leading zero    */
+       size=size*2;                    /* convert in char         */
+
+       return size;
+}
+
+/*******************************************************************
+return the size required by a struct in the stream
+********************************************************************/  
+
 uint32 spoolss_size_port_info_2(PORT_INFO_2 *info)
 {
        int size=0;
@@ -3130,12 +3733,31 @@ uint32 spoolss_size_printprocdatatype_info_1(PRINTPROCDATATYPE_1 *info)
 /*******************************************************************
 return the size required by a struct in the stream
 ********************************************************************/  
-
-uint32 spoolss_size_printmonitor_info_1(PRINTMONITOR_1 *info)
+uint32 spoolss_size_printer_enum_values(PRINTER_ENUM_VALUES *p)
 {
-       int size=0;
-       size+=size_of_relative_string( &info->name );
-
+       uint32  size = 0; 
+       
+       if (!p)
+               return 0;
+       
+       /* uint32(offset) + uint32(length) + length) */
+       size += (size_of_uint32(&p->value_len)*2) + p->value_len;
+       size += (size_of_uint32(&p->data_len)*2) + p->data_len + (p->data_len%2) ;
+       
+       size += size_of_uint32(&p->type);
+                      
+       return size;
+}
+
+/*******************************************************************
+return the size required by a struct in the stream
+********************************************************************/  
+
+uint32 spoolss_size_printmonitor_info_1(PRINTMONITOR_1 *info)
+{
+       int size=0;
+       size+=size_of_relative_string( &info->name );
+
        return size;
 }
 
@@ -3185,7 +3807,7 @@ BOOL make_spoolss_q_getprinterdriver2(SPOOL_Q_GETPRINTERDRIVER2 *q_u,
  * called from spoolss_getprinterdriver2 (srv_spoolss.c)
  ********************************************************************/
 
-BOOL spoolss_io_q_getprinterdriver2(char *desc, SPOOL_Q_GETPRINTERDRIVER2 *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_getprinterdriver2(const char *desc, SPOOL_Q_GETPRINTERDRIVER2 *q_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_q_getprinterdriver2");
        depth++;
@@ -3205,7 +3827,7 @@ BOOL spoolss_io_q_getprinterdriver2(char *desc, SPOOL_Q_GETPRINTERDRIVER2 *q_u,
        if(!prs_uint32("level", ps, depth, &q_u->level))
                return False;
                
-       if(!new_spoolss_io_buffer("", ps, depth, &q_u->buffer))
+       if(!spoolss_io_buffer("", ps, depth, &q_u->buffer))
                return False;
 
        if(!prs_align(ps))
@@ -3227,7 +3849,7 @@ BOOL spoolss_io_q_getprinterdriver2(char *desc, SPOOL_Q_GETPRINTERDRIVER2 *q_u,
  * called from spoolss_getprinterdriver2 (srv_spoolss.c)
  ********************************************************************/
 
-BOOL spoolss_io_r_getprinterdriver2(char *desc, SPOOL_R_GETPRINTERDRIVER2 *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_getprinterdriver2(const char *desc, SPOOL_R_GETPRINTERDRIVER2 *r_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_r_getprinterdriver2");
        depth++;
@@ -3235,7 +3857,7 @@ BOOL spoolss_io_r_getprinterdriver2(char *desc, SPOOL_R_GETPRINTERDRIVER2 *r_u,
        if (!prs_align(ps))
                return False;
                
-       if (!new_spoolss_io_buffer("", ps, depth, &r_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &r_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -3246,7 +3868,7 @@ BOOL spoolss_io_r_getprinterdriver2(char *desc, SPOOL_R_GETPRINTERDRIVER2 *r_u,
                return False;
        if (!prs_uint32("serverminorversion", ps, depth, &r_u->serverminorversion))
                return False;           
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;            
@@ -3256,9 +3878,14 @@ BOOL spoolss_io_r_getprinterdriver2(char *desc, SPOOL_R_GETPRINTERDRIVER2 *r_u,
  * init a structure.
  ********************************************************************/
 
-BOOL make_spoolss_q_enumprinters(SPOOL_Q_ENUMPRINTERS *q_u, uint32 flags, 
-                               fstring servername, uint32 level, 
-                               NEW_BUFFER *buffer, uint32 offered)
+BOOL make_spoolss_q_enumprinters(
+       SPOOL_Q_ENUMPRINTERS *q_u, 
+       uint32 flags, 
+       char *servername, 
+       uint32 level, 
+       NEW_BUFFER *buffer, 
+       uint32 offered
+)
 {
        q_u->flags=flags;
        
@@ -3295,7 +3922,7 @@ BOOL make_spoolss_q_enumports(SPOOL_Q_ENUMPORTS *q_u,
  * called from spoolss_enumprinters (srv_spoolss.c)
  ********************************************************************/
 
-BOOL spoolss_io_q_enumprinters(char *desc, SPOOL_Q_ENUMPRINTERS *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_enumprinters(const char *desc, SPOOL_Q_ENUMPRINTERS *q_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_q_enumprinters");
        depth++;
@@ -3316,7 +3943,7 @@ BOOL spoolss_io_q_enumprinters(char *desc, SPOOL_Q_ENUMPRINTERS *q_u, prs_struct
        if (!prs_uint32("level", ps, depth, &q_u->level))
                return False;
 
-       if (!new_spoolss_io_buffer("", ps, depth, &q_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &q_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -3331,15 +3958,15 @@ BOOL spoolss_io_q_enumprinters(char *desc, SPOOL_Q_ENUMPRINTERS *q_u, prs_struct
  Parse a SPOOL_R_ENUMPRINTERS structure.
  ********************************************************************/
 
-BOOL new_spoolss_io_r_enumprinters(char *desc, SPOOL_R_ENUMPRINTERS *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_enumprinters(const char *desc, SPOOL_R_ENUMPRINTERS *r_u, prs_struct *ps, int depth)
 {
-       prs_debug(ps, depth, desc, "new_spoolss_io_r_enumprinters");
+       prs_debug(ps, depth, desc, "spoolss_io_r_enumprinters");
        depth++;
 
        if (!prs_align(ps))
                return False;
                
-       if (!new_spoolss_io_buffer("", ps, depth, &r_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &r_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -3351,7 +3978,7 @@ BOOL new_spoolss_io_r_enumprinters(char *desc, SPOOL_R_ENUMPRINTERS *r_u, prs_st
        if (!prs_uint32("returned", ps, depth, &r_u->returned))
                return False;
                
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;            
@@ -3363,7 +3990,7 @@ BOOL new_spoolss_io_r_enumprinters(char *desc, SPOOL_R_ENUMPRINTERS *r_u, prs_st
  *
  ********************************************************************/
 
-BOOL spoolss_io_r_getprinter(char *desc, SPOOL_R_GETPRINTER *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_getprinter(const char *desc, SPOOL_R_GETPRINTER *r_u, prs_struct *ps, int depth)
 {      
        prs_debug(ps, depth, desc, "spoolss_io_r_getprinter");
        depth++;
@@ -3371,7 +3998,7 @@ BOOL spoolss_io_r_getprinter(char *desc, SPOOL_R_GETPRINTER *r_u, prs_struct *ps
        if (!prs_align(ps))
                return False;
                
-       if (!new_spoolss_io_buffer("", ps, depth, &r_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &r_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -3380,7 +4007,7 @@ BOOL spoolss_io_r_getprinter(char *desc, SPOOL_R_GETPRINTER *r_u, prs_struct *ps
        if (!prs_uint32("needed", ps, depth, &r_u->needed))
                return False;
                
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;            
@@ -3391,7 +4018,7 @@ BOOL spoolss_io_r_getprinter(char *desc, SPOOL_R_GETPRINTER *r_u, prs_struct *ps
  * called from spoolss_getprinter (srv_spoolss.c)
  ********************************************************************/
 
-BOOL spoolss_io_q_getprinter(char *desc, SPOOL_Q_GETPRINTER *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_getprinter(const char *desc, SPOOL_Q_GETPRINTER *q_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_q_getprinter");
        depth++;
@@ -3404,7 +4031,7 @@ BOOL spoolss_io_q_getprinter(char *desc, SPOOL_Q_GETPRINTER *q_u, prs_struct *ps
        if (!prs_uint32("level", ps, depth, &q_u->level))
                return False;
 
-       if (!new_spoolss_io_buffer("", ps, depth, &q_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &q_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -3419,8 +4046,14 @@ BOOL spoolss_io_q_getprinter(char *desc, SPOOL_Q_GETPRINTER *q_u, prs_struct *ps
  * init a structure.
  ********************************************************************/
 
-BOOL make_spoolss_q_getprinter(SPOOL_Q_GETPRINTER *q_u, const POLICY_HND *hnd, uint32 level, 
-                               NEW_BUFFER *buffer, uint32 offered)
+BOOL make_spoolss_q_getprinter(
+       TALLOC_CTX *mem_ctx,
+       SPOOL_Q_GETPRINTER *q_u, 
+       const POLICY_HND *hnd, 
+       uint32 level, 
+       NEW_BUFFER *buffer, 
+       uint32 offered
+)
 {
        if (q_u == NULL)
        {
@@ -3435,10 +4068,69 @@ BOOL make_spoolss_q_getprinter(SPOOL_Q_GETPRINTER *q_u, const POLICY_HND *hnd, u
        return True;
 }
 
+/*******************************************************************
+ * init a structure.
+ ********************************************************************/
+BOOL make_spoolss_q_setprinter(TALLOC_CTX *mem_ctx, SPOOL_Q_SETPRINTER *q_u, 
+                               const POLICY_HND *hnd, uint32 level, PRINTER_INFO_CTR *info, 
+                               uint32 command)
+{
+       SEC_DESC *secdesc;
+       DEVICEMODE *devmode;
+
+       if (q_u == NULL)
+               return False;
+       
+       memcpy(&q_u->handle, hnd, sizeof(q_u->handle));
+
+       q_u->level = level;
+       q_u->info.level = level;
+       q_u->info.info_ptr = (info != NULL) ? 1 : 0;
+       switch (level) {
+
+         /* There's no such thing as a setprinter level 1 */
+
+       case 2:
+               secdesc = info->printers_2->secdesc;
+               devmode = info->printers_2->devmode;
+               
+               make_spoolss_printer_info_2 (mem_ctx, &q_u->info.info_2, info->printers_2);
+#if 1  /* JERRY TEST */
+               q_u->secdesc_ctr = (SEC_DESC_BUF*)malloc(sizeof(SEC_DESC_BUF));
+               if (!q_u->secdesc_ctr)
+                       return False;
+               q_u->secdesc_ctr->ptr = (secdesc != NULL) ? 1: 0;
+               q_u->secdesc_ctr->max_len = (secdesc) ? sizeof(SEC_DESC) + (2*sizeof(uint32)) : 0;
+               q_u->secdesc_ctr->len = (secdesc) ? sizeof(SEC_DESC) + (2*sizeof(uint32)) : 0;
+               q_u->secdesc_ctr->sec = secdesc;
+
+               q_u->devmode_ctr.devmode_ptr = (devmode != NULL) ? 1 : 0;
+               q_u->devmode_ctr.size = (devmode != NULL) ? sizeof(DEVICEMODE) + (3*sizeof(uint32)) : 0;
+               q_u->devmode_ctr.devmode = devmode;
+#else
+               q_u->secdesc_ctr = NULL;
+       
+               q_u->devmode_ctr.devmode_ptr = 0;
+               q_u->devmode_ctr.size = 0;
+               q_u->devmode_ctr.devmode = NULL;
+#endif
+               break;
+       default: 
+               DEBUG(0,("make_spoolss_q_setprinter: Unknown info level [%d]\n", level));
+                       break;
+       }
+
+       
+       q_u->command = command;
+
+       return True;
+}
+
+
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spoolss_io_r_setprinter(char *desc, SPOOL_R_SETPRINTER *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_setprinter(const char *desc, SPOOL_R_SETPRINTER *r_u, prs_struct *ps, int depth)
 {              
        prs_debug(ps, depth, desc, "spoolss_io_r_setprinter");
        depth++;
@@ -3446,7 +4138,7 @@ BOOL spoolss_io_r_setprinter(char *desc, SPOOL_R_SETPRINTER *r_u, prs_struct *ps
        if(!prs_align(ps))
                return False;
        
-       if(!prs_uint32("status", ps, depth, &r_u->status))
+       if(!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -3456,7 +4148,7 @@ BOOL spoolss_io_r_setprinter(char *desc, SPOOL_R_SETPRINTER *r_u, prs_struct *ps
  Marshall/unmarshall a SPOOL_Q_SETPRINTER struct.
 ********************************************************************/  
 
-BOOL spoolss_io_q_setprinter(char *desc, SPOOL_Q_SETPRINTER *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_setprinter(const char *desc, SPOOL_Q_SETPRINTER *q_u, prs_struct *ps, int depth)
 {
        uint32 ptr_sec_desc = 0;
 
@@ -3477,6 +4169,9 @@ BOOL spoolss_io_q_setprinter(char *desc, SPOOL_Q_SETPRINTER *q_u, prs_struct *ps
        if (!spoolss_io_devmode_cont(desc, &q_u->devmode_ctr, ps, depth))
                return False;
        
+       if(!prs_align(ps))
+               return False;
+
        switch (q_u->level)
        {
                case 2:
@@ -3495,13 +4190,14 @@ BOOL spoolss_io_q_setprinter(char *desc, SPOOL_Q_SETPRINTER *q_u, prs_struct *ps
                if (!sec_io_desc_buf(desc, &q_u->secdesc_ctr, ps, depth))
                        return False;
        } else {
-               uint32 dummy;
+               uint32 dummy = 0;
 
                /* Parse a NULL security descriptor.  This should really
                   happen inside the sec_io_desc_buf() function. */
 
                prs_debug(ps, depth, "", "sec_io_desc_buf");
-               if (!prs_uint32("size", ps, depth + 1, &dummy)) return False;
+               if (!prs_uint32("size", ps, depth + 1, &dummy))
+                       return False;
                if (!prs_uint32("ptr", ps, depth + 1, &dummy)) return
                                                                       False;
        }
@@ -3515,7 +4211,7 @@ BOOL spoolss_io_q_setprinter(char *desc, SPOOL_Q_SETPRINTER *q_u, prs_struct *ps
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spoolss_io_r_fcpn(char *desc, SPOOL_R_FCPN *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_fcpn(const char *desc, SPOOL_R_FCPN *r_u, prs_struct *ps, int depth)
 {              
        prs_debug(ps, depth, desc, "spoolss_io_r_fcpn");
        depth++;
@@ -3523,7 +4219,7 @@ BOOL spoolss_io_r_fcpn(char *desc, SPOOL_R_FCPN *r_u, prs_struct *ps, int depth)
        if(!prs_align(ps))
                return False;
        
-       if(!prs_uint32("status", ps, depth, &r_u->status))
+       if(!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -3532,7 +4228,7 @@ BOOL spoolss_io_r_fcpn(char *desc, SPOOL_R_FCPN *r_u, prs_struct *ps, int depth)
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spoolss_io_q_fcpn(char *desc, SPOOL_Q_FCPN *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_fcpn(const char *desc, SPOOL_Q_FCPN *q_u, prs_struct *ps, int depth)
 {
 
        prs_debug(ps, depth, desc, "spoolss_io_q_fcpn");
@@ -3551,7 +4247,7 @@ BOOL spoolss_io_q_fcpn(char *desc, SPOOL_Q_FCPN *q_u, prs_struct *ps, int depth)
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spoolss_io_r_addjob(char *desc, SPOOL_R_ADDJOB *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_addjob(const char *desc, SPOOL_R_ADDJOB *r_u, prs_struct *ps, int depth)
 {              
        prs_debug(ps, depth, desc, "");
        depth++;
@@ -3559,7 +4255,7 @@ BOOL spoolss_io_r_addjob(char *desc, SPOOL_R_ADDJOB *r_u, prs_struct *ps, int de
        if(!prs_align(ps))
                return False;
        
-       if(!new_spoolss_io_buffer("", ps, depth, &r_u->buffer))
+       if(!spoolss_io_buffer("", ps, depth, &r_u->buffer))
                return False;
 
        if(!prs_align(ps))
@@ -3568,7 +4264,7 @@ BOOL spoolss_io_r_addjob(char *desc, SPOOL_R_ADDJOB *r_u, prs_struct *ps, int de
        if(!prs_uint32("needed", ps, depth, &r_u->needed))
                return False;
 
-       if(!prs_uint32("status", ps, depth, &r_u->status))
+       if(!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -3577,7 +4273,7 @@ BOOL spoolss_io_r_addjob(char *desc, SPOOL_R_ADDJOB *r_u, prs_struct *ps, int de
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spoolss_io_q_addjob(char *desc, SPOOL_Q_ADDJOB *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_addjob(const char *desc, SPOOL_Q_ADDJOB *q_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "");
        depth++;
@@ -3590,7 +4286,7 @@ BOOL spoolss_io_q_addjob(char *desc, SPOOL_Q_ADDJOB *q_u, prs_struct *ps, int de
        if(!prs_uint32("level", ps, depth, &q_u->level))
                return False;
        
-       if(!new_spoolss_io_buffer("", ps, depth, &q_u->buffer))
+       if(!spoolss_io_buffer("", ps, depth, &q_u->buffer))
                return False;
 
        if(!prs_align(ps))
@@ -3605,7 +4301,7 @@ BOOL spoolss_io_q_addjob(char *desc, SPOOL_Q_ADDJOB *q_u, prs_struct *ps, int de
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spoolss_io_r_enumjobs(char *desc, SPOOL_R_ENUMJOBS *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_enumjobs(const char *desc, SPOOL_R_ENUMJOBS *r_u, prs_struct *ps, int depth)
 {              
        prs_debug(ps, depth, desc, "spoolss_io_r_enumjobs");
        depth++;
@@ -3613,7 +4309,7 @@ BOOL spoolss_io_r_enumjobs(char *desc, SPOOL_R_ENUMJOBS *r_u, prs_struct *ps, in
        if (!prs_align(ps))
                return False;
                
-       if (!new_spoolss_io_buffer("", ps, depth, &r_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &r_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -3625,7 +4321,7 @@ BOOL spoolss_io_r_enumjobs(char *desc, SPOOL_R_ENUMJOBS *r_u, prs_struct *ps, in
        if (!prs_uint32("returned", ps, depth, &r_u->returned))
                return False;
                
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;            
@@ -3657,7 +4353,7 @@ BOOL make_spoolss_q_enumjobs(SPOOL_Q_ENUMJOBS *q_u, const POLICY_HND *hnd,
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spoolss_io_q_enumjobs(char *desc, SPOOL_Q_ENUMJOBS *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_enumjobs(const char *desc, SPOOL_Q_ENUMJOBS *q_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_q_enumjobs");
        depth++;
@@ -3675,9 +4371,12 @@ BOOL spoolss_io_q_enumjobs(char *desc, SPOOL_Q_ENUMJOBS *q_u, prs_struct *ps, in
        if (!prs_uint32("level", ps, depth, &q_u->level))
                return False;
 
-       if (!new_spoolss_io_buffer("", ps, depth, &q_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &q_u->buffer))
                return False;   
 
+       if(!prs_align(ps))
+               return False;
+
        if (!prs_uint32("offered", ps, depth, &q_u->offered))
                return False;
 
@@ -3687,7 +4386,7 @@ BOOL spoolss_io_q_enumjobs(char *desc, SPOOL_Q_ENUMJOBS *q_u, prs_struct *ps, in
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spoolss_io_r_schedulejob(char *desc, SPOOL_R_SCHEDULEJOB *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_schedulejob(const char *desc, SPOOL_R_SCHEDULEJOB *r_u, prs_struct *ps, int depth)
 {              
        prs_debug(ps, depth, desc, "spoolss_io_r_schedulejob");
        depth++;
@@ -3695,7 +4394,7 @@ BOOL spoolss_io_r_schedulejob(char *desc, SPOOL_R_SCHEDULEJOB *r_u, prs_struct *
        if(!prs_align(ps))
                return False;
        
-       if(!prs_uint32("status", ps, depth, &r_u->status))
+       if(!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -3704,7 +4403,7 @@ BOOL spoolss_io_r_schedulejob(char *desc, SPOOL_R_SCHEDULEJOB *r_u, prs_struct *
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spoolss_io_q_schedulejob(char *desc, SPOOL_Q_SCHEDULEJOB *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_schedulejob(const char *desc, SPOOL_Q_SCHEDULEJOB *q_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_q_schedulejob");
        depth++;
@@ -3723,7 +4422,7 @@ BOOL spoolss_io_q_schedulejob(char *desc, SPOOL_Q_SCHEDULEJOB *q_u, prs_struct *
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spoolss_io_r_setjob(char *desc, SPOOL_R_SETJOB *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_setjob(const char *desc, SPOOL_R_SETJOB *r_u, prs_struct *ps, int depth)
 {              
        prs_debug(ps, depth, desc, "spoolss_io_r_setjob");
        depth++;
@@ -3731,7 +4430,7 @@ BOOL spoolss_io_r_setjob(char *desc, SPOOL_R_SETJOB *r_u, prs_struct *ps, int de
        if(!prs_align(ps))
                return False;
        
-       if(!prs_uint32("status", ps, depth, &r_u->status))
+       if(!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -3740,7 +4439,7 @@ BOOL spoolss_io_r_setjob(char *desc, SPOOL_R_SETJOB *r_u, prs_struct *ps, int de
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spoolss_io_q_setjob(char *desc, SPOOL_Q_SETJOB *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_setjob(const char *desc, SPOOL_Q_SETJOB *q_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_q_setjob");
        depth++;
@@ -3768,7 +4467,7 @@ BOOL spoolss_io_q_setjob(char *desc, SPOOL_Q_SETJOB *q_u, prs_struct *ps, int de
  Parse a SPOOL_R_ENUMPRINTERDRIVERS structure.
 ********************************************************************/  
 
-BOOL new_spoolss_io_r_enumprinterdrivers(char *desc, SPOOL_R_ENUMPRINTERDRIVERS *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_enumprinterdrivers(const char *desc, SPOOL_R_ENUMPRINTERDRIVERS *r_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_r_enumprinterdrivers");
        depth++;
@@ -3776,7 +4475,7 @@ BOOL new_spoolss_io_r_enumprinterdrivers(char *desc, SPOOL_R_ENUMPRINTERDRIVERS
        if (!prs_align(ps))
                return False;
                
-       if (!new_spoolss_io_buffer("", ps, depth, &r_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &r_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -3788,7 +4487,7 @@ BOOL new_spoolss_io_r_enumprinterdrivers(char *desc, SPOOL_R_ENUMPRINTERDRIVERS
        if (!prs_uint32("returned", ps, depth, &r_u->returned))
                return False;
                
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;            
@@ -3818,7 +4517,7 @@ BOOL make_spoolss_q_enumprinterdrivers(SPOOL_Q_ENUMPRINTERDRIVERS *q_u,
  Parse a SPOOL_Q_ENUMPRINTERDRIVERS structure.
 ********************************************************************/  
 
-BOOL spoolss_io_q_enumprinterdrivers(char *desc, SPOOL_Q_ENUMPRINTERDRIVERS *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_enumprinterdrivers(const char *desc, SPOOL_Q_ENUMPRINTERDRIVERS *q_u, prs_struct *ps, int depth)
 {
 
        prs_debug(ps, depth, desc, "spoolss_io_q_enumprinterdrivers");
@@ -3844,7 +4543,7 @@ BOOL spoolss_io_q_enumprinterdrivers(char *desc, SPOOL_Q_ENUMPRINTERDRIVERS *q_u
        if (!prs_uint32("level", ps, depth, &q_u->level))
                return False;
                
-       if (!new_spoolss_io_buffer("", ps, depth, &q_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &q_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -3859,7 +4558,7 @@ BOOL spoolss_io_q_enumprinterdrivers(char *desc, SPOOL_Q_ENUMPRINTERDRIVERS *q_u
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spoolss_io_q_enumforms(char *desc, SPOOL_Q_ENUMFORMS *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_enumforms(const char *desc, SPOOL_Q_ENUMFORMS *q_u, prs_struct *ps, int depth)
 {
 
        prs_debug(ps, depth, desc, "spoolss_io_q_enumforms");
@@ -3872,7 +4571,7 @@ BOOL spoolss_io_q_enumforms(char *desc, SPOOL_Q_ENUMFORMS *q_u, prs_struct *ps,
        if (!prs_uint32("level", ps, depth, &q_u->level))
                return False;   
        
-       if (!new_spoolss_io_buffer("", ps, depth, &q_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &q_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -3886,15 +4585,15 @@ BOOL spoolss_io_q_enumforms(char *desc, SPOOL_Q_ENUMFORMS *q_u, prs_struct *ps,
 /*******************************************************************
 ********************************************************************/  
 
-BOOL new_spoolss_io_r_enumforms(char *desc, SPOOL_R_ENUMFORMS *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_enumforms(const char *desc, SPOOL_R_ENUMFORMS *r_u, prs_struct *ps, int depth)
 {
-       prs_debug(ps, depth, desc, "new_spoolss_io_r_enumforms");
+       prs_debug(ps, depth, desc, "spoolss_io_r_enumforms");
        depth++;
 
        if (!prs_align(ps))
                return False;
                
-       if (!new_spoolss_io_buffer("", ps, depth, &r_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &r_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -3906,7 +4605,7 @@ BOOL new_spoolss_io_r_enumforms(char *desc, SPOOL_R_ENUMFORMS *r_u, prs_struct *
        if (!prs_uint32("numofforms", ps, depth, &r_u->numofforms))
                return False;
                
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -3915,7 +4614,7 @@ BOOL new_spoolss_io_r_enumforms(char *desc, SPOOL_R_ENUMFORMS *r_u, prs_struct *
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spoolss_io_q_getform(char *desc, SPOOL_Q_GETFORM *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_getform(const char *desc, SPOOL_Q_GETFORM *q_u, prs_struct *ps, int depth)
 {
 
        prs_debug(ps, depth, desc, "spoolss_io_q_getform");
@@ -3934,7 +4633,7 @@ BOOL spoolss_io_q_getform(char *desc, SPOOL_Q_GETFORM *q_u, prs_struct *ps, int
        if (!prs_uint32("level", ps, depth, &q_u->level))
                return False;   
        
-       if (!new_spoolss_io_buffer("", ps, depth, &q_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &q_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -3948,15 +4647,15 @@ BOOL spoolss_io_q_getform(char *desc, SPOOL_Q_GETFORM *q_u, prs_struct *ps, int
 /*******************************************************************
 ********************************************************************/  
 
-BOOL new_spoolss_io_r_getform(char *desc, SPOOL_R_GETFORM *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_getform(const char *desc, SPOOL_R_GETFORM *r_u, prs_struct *ps, int depth)
 {
-       prs_debug(ps, depth, desc, "new_spoolss_io_r_getform");
+       prs_debug(ps, depth, desc, "spoolss_io_r_getform");
        depth++;
 
        if (!prs_align(ps))
                return False;
                
-       if (!new_spoolss_io_buffer("", ps, depth, &r_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &r_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -3965,7 +4664,7 @@ BOOL new_spoolss_io_r_getform(char *desc, SPOOL_R_GETFORM *r_u, prs_struct *ps,
        if (!prs_uint32("size of buffer needed", ps, depth, &r_u->needed))
                return False;
                
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -3975,15 +4674,15 @@ BOOL new_spoolss_io_r_getform(char *desc, SPOOL_R_GETFORM *r_u, prs_struct *ps,
  Parse a SPOOL_R_ENUMPORTS structure.
 ********************************************************************/  
 
-BOOL new_spoolss_io_r_enumports(char *desc, SPOOL_R_ENUMPORTS *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_enumports(const char *desc, SPOOL_R_ENUMPORTS *r_u, prs_struct *ps, int depth)
 {
-       prs_debug(ps, depth, desc, "new_spoolss_io_r_enumports");
+       prs_debug(ps, depth, desc, "spoolss_io_r_enumports");
        depth++;
 
        if (!prs_align(ps))
                return False;
                
-       if (!new_spoolss_io_buffer("", ps, depth, &r_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &r_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -3995,7 +4694,7 @@ BOOL new_spoolss_io_r_enumports(char *desc, SPOOL_R_ENUMPORTS *r_u, prs_struct *
        if (!prs_uint32("returned", ps, depth, &r_u->returned))
                return False;
                
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;            
@@ -4004,7 +4703,7 @@ BOOL new_spoolss_io_r_enumports(char *desc, SPOOL_R_ENUMPORTS *r_u, prs_struct *
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spoolss_io_q_enumports(char *desc, SPOOL_Q_ENUMPORTS *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_enumports(const char *desc, SPOOL_Q_ENUMPORTS *q_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "");
        depth++;
@@ -4022,7 +4721,7 @@ BOOL spoolss_io_q_enumports(char *desc, SPOOL_Q_ENUMPORTS *q_u, prs_struct *ps,
        if (!prs_uint32("level", ps, depth, &q_u->level))
                return False;
                
-       if (!new_spoolss_io_buffer("", ps, depth, &q_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &q_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -4037,7 +4736,7 @@ BOOL spoolss_io_q_enumports(char *desc, SPOOL_Q_ENUMPORTS *q_u, prs_struct *ps,
  Parse a SPOOL_PRINTER_INFO_LEVEL_1 structure.
 ********************************************************************/  
 
-BOOL spool_io_printer_info_level_1(char *desc, SPOOL_PRINTER_INFO_LEVEL_1 *il, prs_struct *ps, int depth)
+BOOL spool_io_printer_info_level_1(const char *desc, SPOOL_PRINTER_INFO_LEVEL_1 *il, prs_struct *ps, int depth)
 {      
        prs_debug(ps, depth, desc, "spool_io_printer_info_level_1");
        depth++;
@@ -4068,7 +4767,7 @@ BOOL spool_io_printer_info_level_1(char *desc, SPOOL_PRINTER_INFO_LEVEL_1 *il, p
  Parse a SPOOL_PRINTER_INFO_LEVEL_3 structure.
 ********************************************************************/  
 
-BOOL spool_io_printer_info_level_3(char *desc, SPOOL_PRINTER_INFO_LEVEL_3 *il, prs_struct *ps, int depth)
+BOOL spool_io_printer_info_level_3(const char *desc, SPOOL_PRINTER_INFO_LEVEL_3 *il, prs_struct *ps, int depth)
 {      
        prs_debug(ps, depth, desc, "spool_io_printer_info_level_3");
        depth++;
@@ -4086,7 +4785,7 @@ BOOL spool_io_printer_info_level_3(char *desc, SPOOL_PRINTER_INFO_LEVEL_3 *il, p
  Parse a SPOOL_PRINTER_INFO_LEVEL_2 structure.
 ********************************************************************/  
 
-BOOL spool_io_printer_info_level_2(char *desc, SPOOL_PRINTER_INFO_LEVEL_2 *il, prs_struct *ps, int depth)
+BOOL spool_io_printer_info_level_2(const char *desc, SPOOL_PRINTER_INFO_LEVEL_2 *il, prs_struct *ps, int depth)
 {      
        prs_debug(ps, depth, desc, "spool_io_printer_info_level_2");
        depth++;
@@ -4165,10 +4864,28 @@ BOOL spool_io_printer_info_level_2(char *desc, SPOOL_PRINTER_INFO_LEVEL_2 *il, p
        return True;
 }
 
+BOOL spool_io_printer_info_level_7(const char *desc, SPOOL_PRINTER_INFO_LEVEL_7 *il, prs_struct *ps, int depth)
+{      
+       prs_debug(ps, depth, desc, "spool_io_printer_info_level_7");
+       depth++;
+               
+       if(!prs_align(ps))
+               return False;
+
+       if(!prs_uint32("guid_ptr", ps, depth, &il->guid_ptr))
+               return False;
+       if(!prs_uint32("action", ps, depth, &il->action))
+               return False;
+
+       if(!smb_io_unistr2("servername", &il->guid, il->guid_ptr, ps, depth))
+               return False;
+       return True;
+}
+
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spool_io_printer_info_level(char *desc, SPOOL_PRINTER_INFO_LEVEL *il, prs_struct *ps, int depth)
+BOOL spool_io_printer_info_level(const char *desc, SPOOL_PRINTER_INFO_LEVEL *il, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spool_io_printer_info_level");
        depth++;
@@ -4230,6 +4947,13 @@ BOOL spool_io_printer_info_level(char *desc, SPOOL_PRINTER_INFO_LEVEL *il, prs_s
                                return False;
                        break;          
                }
+               case 7:
+                       if (UNMARSHALLING(ps))
+                               if ((il->info_7=(SPOOL_PRINTER_INFO_LEVEL_7 *)prs_alloc_mem(ps,sizeof(SPOOL_PRINTER_INFO_LEVEL_7))) == NULL)
+                                       return False;
+                       if (!spool_io_printer_info_level_7("", il->info_7, ps, depth))
+                               return False;
+                       break;
        }
 
        return True;
@@ -4238,8 +4962,10 @@ BOOL spool_io_printer_info_level(char *desc, SPOOL_PRINTER_INFO_LEVEL *il, prs_s
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spoolss_io_q_addprinterex(char *desc, SPOOL_Q_ADDPRINTEREX *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_addprinterex(const char *desc, SPOOL_Q_ADDPRINTEREX *q_u, prs_struct *ps, int depth)
 {
+       uint32 ptr_sec_desc = 0;
+
        prs_debug(ps, depth, desc, "spoolss_io_q_addprinterex");
        depth++;
 
@@ -4259,25 +4985,35 @@ BOOL spoolss_io_q_addprinterex(char *desc, SPOOL_Q_ADDPRINTEREX *q_u, prs_struct
        if(!spool_io_printer_info_level("", &q_u->info, ps, depth))
                return False;
        
-       /* the 4 unknown are all 0 */
+       if (!spoolss_io_devmode_cont(desc, &q_u->devmode_ctr, ps, depth))
+               return False;
 
-       /* 
-        * en fait ils sont pas inconnu
-        * par recoupement avec rpcSetPrinter
-        * c'est le devicemode 
-        * et le security descriptor.
-        */
-       
        if(!prs_align(ps))
                return False;
-       if(!prs_uint32("unk0", ps, depth, &q_u->unk0))
-               return False;
-       if(!prs_uint32("unk1", ps, depth, &q_u->unk1))
-               return False;
-       if(!prs_uint32("unk2", ps, depth, &q_u->unk2))
-               return False;
-       if(!prs_uint32("unk3", ps, depth, &q_u->unk3))
-               return False;
+
+       switch (q_u->level) {
+               case 2:
+                       ptr_sec_desc = q_u->info.info_2->secdesc_ptr;
+                       break;
+               case 3:
+                       ptr_sec_desc = q_u->info.info_3->secdesc_ptr;
+                       break;
+       }
+       if (ptr_sec_desc) {
+               if (!sec_io_desc_buf(desc, &q_u->secdesc_ctr, ps, depth))
+                       return False;
+       } else {
+               uint32 dummy;
+
+               /* Parse a NULL security descriptor.  This should really
+                       happen inside the sec_io_desc_buf() function. */
+
+               prs_debug(ps, depth, "", "sec_io_desc_buf");
+               if (!prs_uint32("size", ps, depth + 1, &dummy))
+                       return False;
+               if (!prs_uint32("ptr", ps, depth + 1, &dummy))
+                       return False;
+       }
 
        if(!prs_uint32("user_switch", ps, depth, &q_u->user_switch))
                return False;
@@ -4290,7 +5026,7 @@ BOOL spoolss_io_q_addprinterex(char *desc, SPOOL_Q_ADDPRINTEREX *q_u, prs_struct
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spoolss_io_r_addprinterex(char *desc, SPOOL_R_ADDPRINTEREX *r_u, 
+BOOL spoolss_io_r_addprinterex(const char *desc, SPOOL_R_ADDPRINTEREX *r_u, 
                               prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_r_addprinterex");
@@ -4299,7 +5035,7 @@ BOOL spoolss_io_r_addprinterex(char *desc, SPOOL_R_ADDPRINTEREX *r_u,
        if(!smb_io_pol_hnd("printer handle",&r_u->handle,ps,depth))
                return False;
 
-       if(!prs_uint32("status", ps, depth, &r_u->status))
+       if(!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -4308,7 +5044,7 @@ BOOL spoolss_io_r_addprinterex(char *desc, SPOOL_R_ADDPRINTEREX *r_u,
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spool_io_printer_driver_info_level_3(char *desc, SPOOL_PRINTER_DRIVER_INFO_LEVEL_3 **q_u, 
+BOOL spool_io_printer_driver_info_level_3(const char *desc, SPOOL_PRINTER_DRIVER_INFO_LEVEL_3 **q_u, 
                                           prs_struct *ps, int depth)
 {      
        SPOOL_PRINTER_DRIVER_INFO_LEVEL_3 *il;
@@ -4386,7 +5122,7 @@ BOOL spool_io_printer_driver_info_level_3(char *desc, SPOOL_PRINTER_DRIVER_INFO_
 parse a SPOOL_PRINTER_DRIVER_INFO_LEVEL_6 structure
 ********************************************************************/  
 
-BOOL spool_io_printer_driver_info_level_6(char *desc, SPOOL_PRINTER_DRIVER_INFO_LEVEL_6 **q_u, 
+BOOL spool_io_printer_driver_info_level_6(const char *desc, SPOOL_PRINTER_DRIVER_INFO_LEVEL_6 **q_u, 
                                           prs_struct *ps, int depth)
 {      
        SPOOL_PRINTER_DRIVER_INFO_LEVEL_6 *il;
@@ -4408,60 +5144,56 @@ BOOL spool_io_printer_driver_info_level_6(char *desc, SPOOL_PRINTER_DRIVER_INFO_
        if(!prs_align(ps))
                return False;
 
+       /* 
+        * I know this seems weird, but I have no other explanation.
+        * This is observed behavior on both NT4 and 2K servers.
+        * --jerry
+        */
+        
+       if (!prs_align_uint64(ps))
+               return False;
 
        /* parse the main elements the packet */
 
-       if(!prs_uint32("version", ps, depth, &il->version))
+       if(!prs_uint32("cversion       ", ps, depth, &il->version))
                return False;
-
-       if(!prs_uint32("name_ptr", ps, depth, &il->name_ptr))
-               return False;   
-       /*
-        * If name_ptr is NULL then the next 4 bytes are the name_ptr. A driver 
-        * with a NULL name just isn't a driver For example: "HP LaserJet 4si"
-        * from W2K CDROM (which uses unidriver). JohnR 010205
-        */
-       if (!il->name_ptr) {
-               DEBUG(5,("spool_io_printer_driver_info_level_6: name_ptr is NULL! Get next value\n"));
-               if(!prs_uint32("name_ptr", ps, depth, &il->name_ptr))
-                       return False;   
-       }
-       
-       if(!prs_uint32("environment_ptr", ps, depth, &il->environment_ptr))
+       if(!prs_uint32("name           ", ps, depth, &il->name_ptr))
+               return False;
+       if(!prs_uint32("environment    ", ps, depth, &il->environment_ptr))
                return False;
-       if(!prs_uint32("driverpath_ptr", ps, depth, &il->driverpath_ptr))
+       if(!prs_uint32("driverpath     ", ps, depth, &il->driverpath_ptr))
                return False;
-       if(!prs_uint32("datafile_ptr", ps, depth, &il->datafile_ptr))
+       if(!prs_uint32("datafile       ", ps, depth, &il->datafile_ptr))
                return False;
-       if(!prs_uint32("configfile_ptr", ps, depth, &il->configfile_ptr))
+       if(!prs_uint32("configfile     ", ps, depth, &il->configfile_ptr))
                return False;
-       if(!prs_uint32("helpfile_ptr", ps, depth, &il->helpfile_ptr))
+       if(!prs_uint32("helpfile       ", ps, depth, &il->helpfile_ptr))
                return False;
-       if(!prs_uint32("monitorname_ptr", ps, depth, &il->monitorname_ptr))
+       if(!prs_uint32("monitorname    ", ps, depth, &il->monitorname_ptr))
                return False;
-       if(!prs_uint32("defaultdatatype_ptr", ps, depth, &il->defaultdatatype_ptr))
+       if(!prs_uint32("defaultdatatype", ps, depth, &il->defaultdatatype_ptr))
                return False;
-       if(!prs_uint32("dependentfiles_len", ps, depth, &il->dependentfiles_len))
+       if(!prs_uint32("dependentfiles ", ps, depth, &il->dependentfiles_len))
                return False;
-       if(!prs_uint32("dependentfiles_ptr", ps, depth, &il->dependentfiles_ptr))
+       if(!prs_uint32("dependentfiles ", ps, depth, &il->dependentfiles_ptr))
                return False;
-       if(!prs_uint32("previousnames_len", ps, depth, &il->previousnames_len))
+       if(!prs_uint32("previousnames  ", ps, depth, &il->previousnames_len))
                return False;
-       if(!prs_uint32("previousnames_ptr", ps, depth, &il->previousnames_ptr))
+       if(!prs_uint32("previousnames  ", ps, depth, &il->previousnames_ptr))
                return False;
-       if(!smb_io_time("driverdate", &il->driverdate, ps, depth))
+       if(!smb_io_time("driverdate    ", &il->driverdate, ps, depth))
                return False;
-       if(!prs_uint32("dummy4", ps, depth, &il->dummy4))
+       if(!prs_uint32("dummy4         ", ps, depth, &il->dummy4))
                return False;
-       if(!prs_uint64("driverversion", ps, depth, &il->driverversion))
+       if(!prs_uint64("driverversion  ", ps, depth, &il->driverversion))
                return False;
-       if(!prs_uint32("mfgname_ptr", ps, depth, &il->mfgname_ptr))
+       if(!prs_uint32("mfgname        ", ps, depth, &il->mfgname_ptr))
                return False;
-       if(!prs_uint32("oemurl_ptr", ps, depth, &il->oemurl_ptr))
+       if(!prs_uint32("oemurl         ", ps, depth, &il->oemurl_ptr))
                return False;
-       if(!prs_uint32("hardwareid_ptr", ps, depth, &il->hardwareid_ptr))
+       if(!prs_uint32("hardwareid     ", ps, depth, &il->hardwareid_ptr))
                return False;
-       if(!prs_uint32("provider_ptr", ps, depth, &il->provider_ptr))
+       if(!prs_uint32("provider       ", ps, depth, &il->provider_ptr))
                return False;
 
        /* parse the structures in the packet */
@@ -4546,34 +5278,42 @@ BOOL spool_io_printer_driver_info_level_6(char *desc, SPOOL_PRINTER_DRIVER_INFO_
 ********************************************************************/  
 static BOOL uniarray_2_dosarray(BUFFER5 *buf5, fstring **ar)
 {
-       fstring f;
+       fstring f, *tar;
        int n = 0;
        char *src;
 
-       if (buf5==NULL) return False;
+       if (buf5==NULL)
+               return False;
 
        src = (char *)buf5->buffer;
        *ar = NULL;
 
        while (src < ((char *)buf5->buffer) + buf5->buf_len*2) {
-               unistr_to_dos(f, src, sizeof(f)-1);
+               rpcstr_pull(f, src, sizeof(f)-1, -1, STR_TERMINATE);
                src = skip_unibuf(src, 2*buf5->buf_len - PTR_DIFF(src,buf5->buffer));
-               *ar = (fstring *)Realloc(*ar, sizeof(fstring)*(n+2));
+               tar = (fstring *)Realloc(*ar, sizeof(fstring)*(n+2));
+               if (!tar)
+                       return False;
+               else
+                       *ar = tar;
                fstrcpy((*ar)[n], f);
                n++;
        }
        fstrcpy((*ar)[n], "");
-
        return True;
 }
 
+
+
+
 /*******************************************************************
  read a UNICODE array with null terminated strings 
  and null terminated array 
  and size of array at beginning
 ********************************************************************/  
 
-BOOL smb_io_unibuffer(char *desc, UNISTR2 *buffer, prs_struct *ps, int depth)
+BOOL smb_io_unibuffer(const char *desc, UNISTR2 *buffer, prs_struct *ps, int depth)
 {
        if (buffer==NULL) return False;
 
@@ -4592,7 +5332,7 @@ BOOL smb_io_unibuffer(char *desc, UNISTR2 *buffer, prs_struct *ps, int depth)
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spool_io_printer_driver_info_level(char *desc, SPOOL_PRINTER_DRIVER_INFO_LEVEL *il, prs_struct *ps, int depth)
+BOOL spool_io_printer_driver_info_level(const char *desc, SPOOL_PRINTER_DRIVER_INFO_LEVEL *il, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spool_io_printer_driver_info_level");
        depth++;
@@ -4627,11 +5367,9 @@ BOOL spool_io_printer_driver_info_level(char *desc, SPOOL_PRINTER_DRIVER_INFO_LE
  init a SPOOL_Q_ADDPRINTERDRIVER struct
  ******************************************************************/
 
-BOOL make_spoolss_q_addprinterdriver(
-       SPOOL_Q_ADDPRINTERDRIVER *q_u, 
-       const char* srv_name, 
-       uint32 level, 
-       PRINTER_DRIVER_CTR *info)
+BOOL make_spoolss_q_addprinterdriver(TALLOC_CTX *mem_ctx,
+                               SPOOL_Q_ADDPRINTERDRIVER *q_u, const char* srv_name, 
+                               uint32 level, PRINTER_DRIVER_CTR *info)
 {
        DEBUG(5,("make_spoolss_q_addprinterdriver\n"));
        
@@ -4644,57 +5382,50 @@ BOOL make_spoolss_q_addprinterdriver(
        q_u->info.ptr = (info!=NULL)?1:0;
        switch (level)
        {
-               /* info level 3 is supported by Windows 95/98, 
-                  WinNT and Win2k */
-               case 3 :
-                       q_u->info.info_3=(SPOOL_PRINTER_DRIVER_INFO_LEVEL_3*)
-                                         malloc(sizeof(SPOOL_PRINTER_DRIVER_INFO_LEVEL_3));
-                       memset (q_u->info.info_3, 0x0, sizeof(SPOOL_PRINTER_DRIVER_INFO_LEVEL_3));
-                       make_spool_driver_info_3(q_u->info.info_3, info->info3);
-                       break;
+       /* info level 3 is supported by Windows 95/98, WinNT and Win2k */
+       case 3 :
+               make_spoolss_driver_info_3(mem_ctx, &q_u->info.info_3, info->info3);
+               break;
                
-               /* info level 6 is supported by WinME and Win2k */
-               case 6:
-                       /* WRITEME!!  will add later  --jerry */
-                       break;
-               default:
-                       DEBUG(0,("make_spoolss_q_addprinterdriver: Unknown \
-info level [%d]\n", level));
-                       break;
-       
+       default:
+               DEBUG(0,("make_spoolss_q_addprinterdriver: Unknown info level [%d]\n", level));
+               break;
        }
        
        return True;
 }
 
-BOOL make_spool_driver_info_3(
-       SPOOL_PRINTER_DRIVER_INFO_LEVEL_3 *spool_drv_info,
-       DRIVER_INFO_3 *info3
-)
+BOOL make_spoolss_driver_info_3(TALLOC_CTX *mem_ctx, 
+       SPOOL_PRINTER_DRIVER_INFO_LEVEL_3 **spool_drv_info,
+                               DRIVER_INFO_3 *info3)
 {
        uint32          len = 0;
        uint16          *ptr = info3->dependentfiles;
        BOOL            done = False;
        BOOL            null_char = False;
-
-       spool_drv_info->cversion        = info3->version;
-       spool_drv_info->name_ptr        = (info3->name.buffer!=NULL)?1:0;
-       spool_drv_info->environment_ptr = (info3->architecture.buffer!=NULL)?1:0;
-       spool_drv_info->driverpath_ptr  = (info3->driverpath.buffer!=NULL)?1:0;
-       spool_drv_info->datafile_ptr    = (info3->datafile.buffer!=NULL)?1:0;
-       spool_drv_info->configfile_ptr  = (info3->configfile.buffer!=NULL)?1:0;
-       spool_drv_info->helpfile_ptr    = (info3->helpfile.buffer!=NULL)?1:0;
-       spool_drv_info->monitorname_ptr = (info3->monitorname.buffer!=NULL)?1:0;
-       spool_drv_info->defaultdatatype_ptr     = (info3->defaultdatatype.buffer!=NULL)?1:0;
-
-       init_unistr2_from_unistr(&spool_drv_info->name, &info3->name);
-       init_unistr2_from_unistr(&spool_drv_info->environment, &info3->architecture);
-       init_unistr2_from_unistr(&spool_drv_info->driverpath, &info3->driverpath);
-       init_unistr2_from_unistr(&spool_drv_info->datafile, &info3->datafile);
-       init_unistr2_from_unistr(&spool_drv_info->configfile, &info3->configfile);
-       init_unistr2_from_unistr(&spool_drv_info->helpfile, &info3->helpfile);
-       init_unistr2_from_unistr(&spool_drv_info->monitorname, &info3->monitorname);
-       init_unistr2_from_unistr(&spool_drv_info->defaultdatatype, &info3->defaultdatatype);
+       SPOOL_PRINTER_DRIVER_INFO_LEVEL_3 *inf;
+
+       if (!(inf=(SPOOL_PRINTER_DRIVER_INFO_LEVEL_3*)talloc_zero(mem_ctx, sizeof(SPOOL_PRINTER_DRIVER_INFO_LEVEL_3))))
+               return False;
+       
+       inf->cversion   = info3->version;
+       inf->name_ptr   = (info3->name.buffer!=NULL)?1:0;
+       inf->environment_ptr    = (info3->architecture.buffer!=NULL)?1:0;
+       inf->driverpath_ptr     = (info3->driverpath.buffer!=NULL)?1:0;
+       inf->datafile_ptr       = (info3->datafile.buffer!=NULL)?1:0;
+       inf->configfile_ptr     = (info3->configfile.buffer!=NULL)?1:0;
+       inf->helpfile_ptr       = (info3->helpfile.buffer!=NULL)?1:0;
+       inf->monitorname_ptr    = (info3->monitorname.buffer!=NULL)?1:0;
+       inf->defaultdatatype_ptr        = (info3->defaultdatatype.buffer!=NULL)?1:0;
+
+       init_unistr2_from_unistr(&inf->name, &info3->name);
+       init_unistr2_from_unistr(&inf->environment, &info3->architecture);
+       init_unistr2_from_unistr(&inf->driverpath, &info3->driverpath);
+       init_unistr2_from_unistr(&inf->datafile, &info3->datafile);
+       init_unistr2_from_unistr(&inf->configfile, &info3->configfile);
+       init_unistr2_from_unistr(&inf->helpfile, &info3->helpfile);
+       init_unistr2_from_unistr(&inf->monitorname, &info3->monitorname);
+       init_unistr2_from_unistr(&inf->defaultdatatype, &info3->defaultdatatype);
 
        while (!done)
        {
@@ -4717,30 +5448,32 @@ BOOL make_spool_driver_info_3(
                len++;
                ptr++;
        }
-       spool_drv_info->dependentfiles_ptr = (info3->dependentfiles!=NULL)?1:0;
-       spool_drv_info->dependentfilessize = len;
-       if(!make_spool_buffer5(&spool_drv_info->dependentfiles, len, info3->dependentfiles))
+       inf->dependentfiles_ptr = (info3->dependentfiles != NULL) ? 1 : 0;
+       inf->dependentfilessize = len;
+       if(!make_spoolss_buffer5(mem_ctx, &inf->dependentfiles, len, info3->dependentfiles))
+       {
+               SAFE_FREE(inf);
                return False;
+       }
+       
+       *spool_drv_info = inf;
        
        return True;
-}           
+}
 
 /*******************************************************************
  make a BUFFER5 struct from a uint16*
  ******************************************************************/
-
-BOOL make_spool_buffer5(BUFFER5 *buf5, uint32 len, uint16 *src)
+BOOL make_spoolss_buffer5(TALLOC_CTX *mem_ctx, BUFFER5 *buf5, uint32 len, uint16 *src)
 {
 
        buf5->buf_len = len;
-       if((buf5->buffer=(uint16*)malloc(sizeof(uint16)*len)) == NULL)
+       if((buf5->buffer=(uint16*)talloc_memdup(mem_ctx, src, sizeof(uint16)*len)) == NULL)
        {
-               DEBUG(0,("make_spool_buffer5: Unable to talloc memory for buffer!\n"));
+               DEBUG(0,("make_spoolss_buffer5: Unable to malloc memory for buffer!\n"));
                return False;
        }
        
-       memcpy(buf5->buffer, src, sizeof(uint16)*len);
-
        return True;
 }
 
@@ -4748,7 +5481,7 @@ BOOL make_spool_buffer5(BUFFER5 *buf5, uint32 len, uint16 *src)
  fill in the prs_struct for a ADDPRINTERDRIVER request PDU
  ********************************************************************/  
 
-BOOL spoolss_io_q_addprinterdriver(char *desc, SPOOL_Q_ADDPRINTERDRIVER *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_addprinterdriver(const char *desc, SPOOL_Q_ADDPRINTERDRIVER *q_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_q_addprinterdriver");
        depth++;
@@ -4775,12 +5508,59 @@ BOOL spoolss_io_q_addprinterdriver(char *desc, SPOOL_Q_ADDPRINTERDRIVER *q_u, pr
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spoolss_io_r_addprinterdriver(char *desc, SPOOL_R_ADDPRINTERDRIVER *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_addprinterdriver(const char *desc, SPOOL_R_ADDPRINTERDRIVER *q_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_r_addprinterdriver");
        depth++;
 
-       if(!prs_uint32("status", ps, depth, &q_u->status))
+       if(!prs_werror("status", ps, depth, &q_u->status))
+               return False;
+
+       return True;
+}
+
+/*******************************************************************
+ fill in the prs_struct for a ADDPRINTERDRIVER request PDU
+ ********************************************************************/  
+
+BOOL spoolss_io_q_addprinterdriverex(const char *desc, SPOOL_Q_ADDPRINTERDRIVEREX *q_u, prs_struct *ps, int depth)
+{
+       prs_debug(ps, depth, desc, "spoolss_io_q_addprinterdriverex");
+       depth++;
+
+       if(!prs_align(ps))
+               return False;
+
+       if(!prs_uint32("server_name_ptr", ps, depth, &q_u->server_name_ptr))
+               return False;
+       if(!smb_io_unistr2("server_name", &q_u->server_name, q_u->server_name_ptr, ps, depth))
+               return False;
+               
+       if(!prs_align(ps))
+               return False;
+       if(!prs_uint32("info_level", ps, depth, &q_u->level))
+               return False;
+
+       if(!spool_io_printer_driver_info_level("", &q_u->info, ps, depth))
+               return False;
+
+       if(!prs_align(ps))
+               return False;
+       if(!prs_uint32("copy flags", ps, depth, &q_u->copy_flags))
+               return False;
+               
+       return True;
+}
+
+/*******************************************************************
+********************************************************************/  
+
+BOOL spoolss_io_r_addprinterdriverex(const char *desc, SPOOL_R_ADDPRINTERDRIVEREX *q_u, prs_struct *ps, int depth)
+{
+       prs_debug(ps, depth, desc, "spoolss_io_r_addprinterdriverex");
+       depth++;
+
+       if(!prs_werror("status", ps, depth, &q_u->status))
                return False;
 
        return True;
@@ -4827,9 +5607,11 @@ BOOL uni_2_asc_printer_driver_3(SPOOL_PRINTER_DRIVER_INFO_LEVEL_3 *uni,
        DEBUGADD(8,( "monitorname:     %s\n", d->monitorname));
        DEBUGADD(8,( "defaultdatatype: %s\n", d->defaultdatatype));
 
-       uniarray_2_dosarray(&uni->dependentfiles, &d->dependentfiles );
-
-       return True;
+       if (uniarray_2_dosarray(&uni->dependentfiles, &d->dependentfiles ))
+               return True;
+       
+       SAFE_FREE(*asc);
+       return False;
 }
 
 /*******************************************************************
@@ -4872,10 +5654,16 @@ BOOL uni_2_asc_printer_driver_6(SPOOL_PRINTER_DRIVER_INFO_LEVEL_6 *uni,
        DEBUGADD(8,( "monitorname:     %s\n", d->monitorname));
        DEBUGADD(8,( "defaultdatatype: %s\n", d->defaultdatatype));
 
-       uniarray_2_dosarray(&uni->dependentfiles, &d->dependentfiles );
-       uniarray_2_dosarray(&uni->previousnames, &d->previousnames );
-
+       if (!uniarray_2_dosarray(&uni->dependentfiles, &d->dependentfiles ))
+               goto error;
+       if (!uniarray_2_dosarray(&uni->previousnames, &d->previousnames ))
+               goto error;
+       
        return True;
+       
+error:
+       SAFE_FREE(*asc);
+       return False;
 }
 
 BOOL uni_2_asc_printer_info_2(const SPOOL_PRINTER_INFO_LEVEL_2 *uni,
@@ -4950,7 +5738,7 @@ BOOL make_spoolss_q_getprinterdriverdir(SPOOL_Q_GETPRINTERDRIVERDIR *q_u,
  Parse a SPOOL_Q_GETPRINTERDRIVERDIR structure.
 ********************************************************************/  
 
-BOOL spoolss_io_q_getprinterdriverdir(char *desc, SPOOL_Q_GETPRINTERDRIVERDIR *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_getprinterdriverdir(const char *desc, SPOOL_Q_GETPRINTERDRIVERDIR *q_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_q_getprinterdriverdir");
        depth++;
@@ -4976,7 +5764,7 @@ BOOL spoolss_io_q_getprinterdriverdir(char *desc, SPOOL_Q_GETPRINTERDRIVERDIR *q
        if(!prs_uint32("level", ps, depth, &q_u->level))
                return False;
                
-       if(!new_spoolss_io_buffer("", ps, depth, &q_u->buffer))
+       if(!spoolss_io_buffer("", ps, depth, &q_u->buffer))
                return False;
                
        if(!prs_align(ps))
@@ -4992,7 +5780,7 @@ BOOL spoolss_io_q_getprinterdriverdir(char *desc, SPOOL_Q_GETPRINTERDRIVERDIR *q
  Parse a SPOOL_R_GETPRINTERDRIVERDIR structure.
 ********************************************************************/  
 
-BOOL spoolss_io_r_getprinterdriverdir(char *desc, SPOOL_R_GETPRINTERDRIVERDIR *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_getprinterdriverdir(const char *desc, SPOOL_R_GETPRINTERDRIVERDIR *r_u, prs_struct *ps, int depth)
 {              
        prs_debug(ps, depth, desc, "spoolss_io_r_getprinterdriverdir");
        depth++;
@@ -5000,7 +5788,7 @@ BOOL spoolss_io_r_getprinterdriverdir(char *desc, SPOOL_R_GETPRINTERDRIVERDIR *r
        if (!prs_align(ps))
                return False;
                
-       if (!new_spoolss_io_buffer("", ps, depth, &r_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &r_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -5009,7 +5797,7 @@ BOOL spoolss_io_r_getprinterdriverdir(char *desc, SPOOL_R_GETPRINTERDRIVERDIR *r
        if (!prs_uint32("needed", ps, depth, &r_u->needed))
                return False;
                
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;            
@@ -5018,7 +5806,7 @@ BOOL spoolss_io_r_getprinterdriverdir(char *desc, SPOOL_R_GETPRINTERDRIVERDIR *r
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spoolss_io_r_enumprintprocessors(char *desc, SPOOL_R_ENUMPRINTPROCESSORS *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_enumprintprocessors(const char *desc, SPOOL_R_ENUMPRINTPROCESSORS *r_u, prs_struct *ps, int depth)
 {              
        prs_debug(ps, depth, desc, "spoolss_io_r_enumprintprocessors");
        depth++;
@@ -5026,7 +5814,7 @@ BOOL spoolss_io_r_enumprintprocessors(char *desc, SPOOL_R_ENUMPRINTPROCESSORS *r
        if (!prs_align(ps))
                return False;
                
-       if (!new_spoolss_io_buffer("", ps, depth, &r_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &r_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -5038,7 +5826,7 @@ BOOL spoolss_io_r_enumprintprocessors(char *desc, SPOOL_R_ENUMPRINTPROCESSORS *r
        if (!prs_uint32("returned", ps, depth, &r_u->returned))
                return False;
                
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;            
@@ -5047,7 +5835,7 @@ BOOL spoolss_io_r_enumprintprocessors(char *desc, SPOOL_R_ENUMPRINTPROCESSORS *r
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spoolss_io_q_enumprintprocessors(char *desc, SPOOL_Q_ENUMPRINTPROCESSORS *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_enumprintprocessors(const char *desc, SPOOL_Q_ENUMPRINTPROCESSORS *q_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_q_enumprintprocessors");
        depth++;
@@ -5074,7 +5862,7 @@ BOOL spoolss_io_q_enumprintprocessors(char *desc, SPOOL_Q_ENUMPRINTPROCESSORS *q
        if (!prs_uint32("level", ps, depth, &q_u->level))
                return False;
                
-       if(!new_spoolss_io_buffer("", ps, depth, &q_u->buffer))
+       if(!spoolss_io_buffer("", ps, depth, &q_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -5089,7 +5877,58 @@ BOOL spoolss_io_q_enumprintprocessors(char *desc, SPOOL_Q_ENUMPRINTPROCESSORS *q
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spoolss_io_r_enumprintprocdatatypes(char *desc, SPOOL_R_ENUMPRINTPROCDATATYPES *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_addprintprocessor(const char *desc, SPOOL_Q_ADDPRINTPROCESSOR *q_u, prs_struct *ps, int depth)
+{
+       prs_debug(ps, depth, desc, "spoolss_io_q_addprintprocessor");
+       depth++;
+
+       if (!prs_align(ps))
+               return False;
+               
+       if (!prs_uint32("server_ptr", ps, depth, &q_u->server_ptr))
+               return False;
+       if (!smb_io_unistr2("server", &q_u->server, q_u->server_ptr, ps, depth))
+               return False;
+               
+       if (!prs_align(ps))
+               return False;
+       if (!smb_io_unistr2("environment", &q_u->environment, True, ps, depth))
+               return False;
+               
+       if (!prs_align(ps))
+               return False;
+       if (!smb_io_unistr2("path", &q_u->path, True, ps, depth))
+               return False;
+
+       if (!prs_align(ps))
+               return False;
+       if (!smb_io_unistr2("name", &q_u->name, True, ps, depth))
+               return False;
+
+       return True;
+}
+
+/*******************************************************************
+********************************************************************/  
+
+BOOL spoolss_io_r_addprintprocessor(const char *desc, SPOOL_R_ADDPRINTPROCESSOR *r_u, prs_struct *ps, int depth)
+{              
+       prs_debug(ps, depth, desc, "spoolss_io_r_addprintproicessor");
+       depth++;
+
+       if (!prs_align(ps))
+               return False;
+               
+       if (!prs_werror("status", ps, depth, &r_u->status))
+               return False;
+
+       return True;            
+}
+
+/*******************************************************************
+********************************************************************/  
+
+BOOL spoolss_io_r_enumprintprocdatatypes(const char *desc, SPOOL_R_ENUMPRINTPROCDATATYPES *r_u, prs_struct *ps, int depth)
 {              
        prs_debug(ps, depth, desc, "spoolss_io_r_enumprintprocdatatypes");
        depth++;
@@ -5097,7 +5936,7 @@ BOOL spoolss_io_r_enumprintprocdatatypes(char *desc, SPOOL_R_ENUMPRINTPROCDATATY
        if (!prs_align(ps))
                return False;
                
-       if (!new_spoolss_io_buffer("", ps, depth, &r_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &r_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -5109,7 +5948,7 @@ BOOL spoolss_io_r_enumprintprocdatatypes(char *desc, SPOOL_R_ENUMPRINTPROCDATATY
        if (!prs_uint32("returned", ps, depth, &r_u->returned))
                return False;
                
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;            
@@ -5118,7 +5957,7 @@ BOOL spoolss_io_r_enumprintprocdatatypes(char *desc, SPOOL_R_ENUMPRINTPROCDATATY
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spoolss_io_q_enumprintprocdatatypes(char *desc, SPOOL_Q_ENUMPRINTPROCDATATYPES *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_enumprintprocdatatypes(const char *desc, SPOOL_Q_ENUMPRINTPROCDATATYPES *q_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_q_enumprintprocdatatypes");
        depth++;
@@ -5145,7 +5984,7 @@ BOOL spoolss_io_q_enumprintprocdatatypes(char *desc, SPOOL_Q_ENUMPRINTPROCDATATY
        if (!prs_uint32("level", ps, depth, &q_u->level))
                return False;
                
-       if(!new_spoolss_io_buffer("buffer", ps, depth, &q_u->buffer))
+       if(!spoolss_io_buffer("buffer", ps, depth, &q_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -5161,7 +6000,7 @@ BOOL spoolss_io_q_enumprintprocdatatypes(char *desc, SPOOL_Q_ENUMPRINTPROCDATATY
  Parse a SPOOL_Q_ENUMPRINTMONITORS structure.
 ********************************************************************/  
 
-BOOL spoolss_io_q_enumprintmonitors(char *desc, SPOOL_Q_ENUMPRINTMONITORS *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_enumprintmonitors(const char *desc, SPOOL_Q_ENUMPRINTMONITORS *q_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_q_enumprintmonitors");
        depth++;
@@ -5180,7 +6019,7 @@ BOOL spoolss_io_q_enumprintmonitors(char *desc, SPOOL_Q_ENUMPRINTMONITORS *q_u,
        if (!prs_uint32("level", ps, depth, &q_u->level))
                return False;
                
-       if(!new_spoolss_io_buffer("", ps, depth, &q_u->buffer))
+       if(!spoolss_io_buffer("", ps, depth, &q_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -5195,7 +6034,7 @@ BOOL spoolss_io_q_enumprintmonitors(char *desc, SPOOL_Q_ENUMPRINTMONITORS *q_u,
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spoolss_io_r_enumprintmonitors(char *desc, SPOOL_R_ENUMPRINTMONITORS *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_enumprintmonitors(const char *desc, SPOOL_R_ENUMPRINTMONITORS *r_u, prs_struct *ps, int depth)
 {              
        prs_debug(ps, depth, desc, "spoolss_io_r_enumprintmonitors");
        depth++;
@@ -5203,7 +6042,7 @@ BOOL spoolss_io_r_enumprintmonitors(char *desc, SPOOL_R_ENUMPRINTMONITORS *r_u,
        if (!prs_align(ps))
                return False;
                
-       if (!new_spoolss_io_buffer("", ps, depth, &r_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &r_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -5215,7 +6054,7 @@ BOOL spoolss_io_r_enumprintmonitors(char *desc, SPOOL_R_ENUMPRINTMONITORS *r_u,
        if (!prs_uint32("returned", ps, depth, &r_u->returned))
                return False;
                
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;            
@@ -5224,7 +6063,7 @@ BOOL spoolss_io_r_enumprintmonitors(char *desc, SPOOL_R_ENUMPRINTMONITORS *r_u,
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spoolss_io_r_enumprinterdata(char *desc, SPOOL_R_ENUMPRINTERDATA *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_enumprinterdata(const char *desc, SPOOL_R_ENUMPRINTERDATA *r_u, prs_struct *ps, int depth)
 {      
        prs_debug(ps, depth, desc, "spoolss_io_r_enumprinterdata");
        depth++;
@@ -5234,15 +6073,17 @@ BOOL spoolss_io_r_enumprinterdata(char *desc, SPOOL_R_ENUMPRINTERDATA *r_u, prs_
        if(!prs_uint32("valuesize", ps, depth, &r_u->valuesize))
                return False;
 
-       if (MARSHALLING(ps)) {
-               /* "Value is actually a UNICODE string. It's already little-endian so don't reverse. */
-               if(!prs_uint8s(False, "value", ps, depth, (uint8 *)r_u->value, r_u->valuesize * 2))
-                       return False;
-       } else {
-               if(!prs_uint16s(False, "value", ps, depth, r_u->value, r_u->valuesize ))
+       if (UNMARSHALLING(ps) && r_u->valuesize) {
+               r_u->value = (uint16 *)prs_alloc_mem(ps, r_u->valuesize * 2);
+               if (!r_u->value) {
+                       DEBUG(0, ("spoolss_io_r_enumprinterdata: out of memory for printerdata value\n"));
                        return False;
+               }
        }
 
+       if(!prs_uint16uni(False, "value", ps, depth, r_u->value, r_u->valuesize ))
+               return False;
+
        if(!prs_align(ps))
                return False;
 
@@ -5254,6 +6095,15 @@ BOOL spoolss_io_r_enumprinterdata(char *desc, SPOOL_R_ENUMPRINTERDATA *r_u, prs_
 
        if(!prs_uint32("datasize", ps, depth, &r_u->datasize))
                return False;
+
+       if (UNMARSHALLING(ps) && r_u->datasize) {
+               r_u->data = (uint8 *)prs_alloc_mem(ps, r_u->datasize);
+               if (!r_u->data) {
+                       DEBUG(0, ("spoolss_io_r_enumprinterdata: out of memory for printerdata data\n"));
+                       return False;
+               }
+       }
+
        if(!prs_uint8s(False, "data", ps, depth, r_u->data, r_u->datasize))
                return False;
        if(!prs_align(ps))
@@ -5261,7 +6111,7 @@ BOOL spoolss_io_r_enumprinterdata(char *desc, SPOOL_R_ENUMPRINTERDATA *r_u, prs_
 
        if(!prs_uint32("realdatasize", ps, depth, &r_u->realdatasize))
                return False;
-       if(!prs_uint32("status", ps, depth, &r_u->status))
+       if(!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -5270,7 +6120,7 @@ BOOL spoolss_io_r_enumprinterdata(char *desc, SPOOL_R_ENUMPRINTERDATA *r_u, prs_
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spoolss_io_q_enumprinterdata(char *desc, SPOOL_Q_ENUMPRINTERDATA *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_enumprinterdata(const char *desc, SPOOL_Q_ENUMPRINTERDATA *q_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_q_enumprinterdata");
        depth++;
@@ -5307,20 +6157,66 @@ BOOL make_spoolss_q_enumprinterdata(SPOOL_Q_ENUMPRINTERDATA *q_u,
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spoolss_io_q_setprinterdata(char *desc, SPOOL_Q_SETPRINTERDATA *q_u, prs_struct *ps, int depth)
+BOOL make_spoolss_q_enumprinterdataex(SPOOL_Q_ENUMPRINTERDATAEX *q_u,
+                                     const POLICY_HND *hnd, const char *key,
+                                     uint32 size)
 {
-       prs_debug(ps, depth, desc, "spoolss_io_q_setprinterdata");
-       depth++;
+       memcpy(&q_u->handle, hnd, sizeof(q_u->handle));
+       init_unistr2(&q_u->key, key, strlen(key)+1);
+       q_u->size = size;
 
-       if(!prs_align(ps))
-               return False;
-       if(!smb_io_pol_hnd("printer handle", &q_u->handle, ps, depth))
-               return False;
-       if(!smb_io_unistr2("", &q_u->value, True, ps, depth))
-               return False;
+       return True;
+}
 
-       if(!prs_align(ps))
-               return False;
+/*******************************************************************
+********************************************************************/  
+BOOL make_spoolss_q_setprinterdata(SPOOL_Q_SETPRINTERDATA *q_u, const POLICY_HND *hnd,
+                                  char* value, uint32 data_type, char* data, uint32 data_size)
+{
+       memcpy(&q_u->handle, hnd, sizeof(q_u->handle));
+       q_u->type = data_type;
+       init_unistr2(&q_u->value, value, strlen(value)+1);
+
+       q_u->max_len = q_u->real_len = data_size;
+       q_u->data = data;
+       
+       return True;
+}
+
+/*******************************************************************
+********************************************************************/  
+BOOL make_spoolss_q_setprinterdataex(SPOOL_Q_SETPRINTERDATAEX *q_u, const POLICY_HND *hnd,
+                                    char *key, char* value, uint32 data_type, char* data, 
+                                    uint32 data_size)
+{
+       memcpy(&q_u->handle, hnd, sizeof(q_u->handle));
+       q_u->type = data_type;
+       init_unistr2(&q_u->value, value, strlen(value)+1);
+       init_unistr2(&q_u->key, key, strlen(key)+1);
+
+       q_u->max_len = q_u->real_len = data_size;
+       q_u->data = data;
+       
+       return True;
+}
+
+/*******************************************************************
+********************************************************************/  
+
+BOOL spoolss_io_q_setprinterdata(const char *desc, SPOOL_Q_SETPRINTERDATA *q_u, prs_struct *ps, int depth)
+{
+       prs_debug(ps, depth, desc, "spoolss_io_q_setprinterdata");
+       depth++;
+
+       if(!prs_align(ps))
+               return False;
+       if(!smb_io_pol_hnd("printer handle", &q_u->handle, ps, depth))
+               return False;
+       if(!smb_io_unistr2("", &q_u->value, True, ps, depth))
+               return False;
+
+       if(!prs_align(ps))
+               return False;
 
        if(!prs_uint32("type", ps, depth, &q_u->type))
                return False;
@@ -5330,16 +6226,18 @@ BOOL spoolss_io_q_setprinterdata(char *desc, SPOOL_Q_SETPRINTERDATA *q_u, prs_st
 
        switch (q_u->type)
        {
-               case 0x1:
-               case 0x3:
-               case 0x4:
-               case 0x7:
-                       if (UNMARSHALLING(ps))
-                               q_u->data=(uint8 *)prs_alloc_mem(ps, q_u->max_len * sizeof(uint8));
-                       if(q_u->data == NULL)
-                               return False;
-                       if(!prs_uint8s(False,"data", ps, depth, q_u->data, q_u->max_len))
-                               return False;
+               case REG_SZ:
+               case REG_BINARY:
+               case REG_DWORD:
+               case REG_MULTI_SZ:
+            if (q_u->max_len) {
+                if (UNMARSHALLING(ps))
+                               q_u->data=(uint8 *)prs_alloc_mem(ps, q_u->max_len * sizeof(uint8));
+                       if(q_u->data == NULL)
+                               return False;
+                       if(!prs_uint8s(False,"data", ps, depth, q_u->data, q_u->max_len))
+                               return False;
+            }
                        if(!prs_align(ps))
                                return False;
                        break;
@@ -5354,14 +6252,14 @@ BOOL spoolss_io_q_setprinterdata(char *desc, SPOOL_Q_SETPRINTERDATA *q_u, prs_st
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spoolss_io_r_setprinterdata(char *desc, SPOOL_R_SETPRINTERDATA *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_setprinterdata(const char *desc, SPOOL_R_SETPRINTERDATA *r_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_r_setprinterdata");
        depth++;
 
        if(!prs_align(ps))
                return False;
-       if(!prs_uint32("status",     ps, depth, &r_u->status))
+       if(!prs_werror("status",     ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -5369,37 +6267,42 @@ BOOL spoolss_io_r_setprinterdata(char *desc, SPOOL_R_SETPRINTERDATA *r_u, prs_st
 
 /*******************************************************************
 ********************************************************************/  
-
-BOOL convert_specific_param(NT_PRINTER_PARAM **param, const UNISTR2 *value,
-                               uint32 type, const uint8 *data, uint32 len)
+BOOL spoolss_io_q_resetprinter(const char *desc, SPOOL_Q_RESETPRINTER *q_u, prs_struct *ps, int depth)
 {
-       DEBUG(5,("converting a specific param struct\n"));
+       prs_debug(ps, depth, desc, "spoolss_io_q_resetprinter");
+       depth++;
 
-       if (*param == NULL)
-       {
-               *param=(NT_PRINTER_PARAM *)malloc(sizeof(NT_PRINTER_PARAM));
-               if(*param == NULL)
-                       return False;
-               memset((char *)*param, '\0', sizeof(NT_PRINTER_PARAM));
-               DEBUGADD(6,("Allocated a new PARAM struct\n"));
-       }
-       unistr2_to_ascii((*param)->value, value, sizeof((*param)->value)-1);
-       (*param)->type = type;
-       
-       /* le champ data n'est pas NULL termine */
-       /* on stocke donc la longueur */
-       
-       (*param)->data_len=len;
-       
-       if (len) {
-               (*param)->data=(uint8 *)malloc(len * sizeof(uint8));
-               if((*param)->data == NULL)
-                       return False;
-               memcpy((*param)->data, data, len);
-       }
+       if (!prs_align(ps))
+               return False;
+       if (!smb_io_pol_hnd("printer handle", &q_u->handle, ps, depth))
+               return False;
+
+       if (!prs_uint32("datatype_ptr", ps, depth, &q_u->datatype_ptr))
+               return False;
                
-       DEBUGADD(6,("\tvalue:[%s], len:[%d]\n",(*param)->value, (*param)->data_len));
-       dump_data(10, (char *)(*param)->data, (*param)->data_len);
+       if (q_u->datatype_ptr) {
+               if (!smb_io_unistr2("datatype", &q_u->datatype, q_u->datatype_ptr?True:False, ps, depth))
+               return False;
+       }
+
+       if (!spoolss_io_devmode_cont(desc, &q_u->devmode_ctr, ps, depth))
+               return False;
+
+       return True;
+}
+
+
+/*******************************************************************
+********************************************************************/  
+BOOL spoolss_io_r_resetprinter(const char *desc, SPOOL_R_RESETPRINTER *r_u, prs_struct *ps, int depth)
+{
+       prs_debug(ps, depth, desc, "spoolss_io_r_resetprinter");
+       depth++;
+
+       if(!prs_align(ps))
+               return False;
+       if(!prs_werror("status",     ps, depth, &r_u->status))
+               return False;
 
        return True;
 }
@@ -5407,7 +6310,7 @@ BOOL convert_specific_param(NT_PRINTER_PARAM **param, const UNISTR2 *value,
 /*******************************************************************
 ********************************************************************/  
 
-static BOOL spoolss_io_addform(char *desc, FORM *f, uint32 ptr, prs_struct *ps, int depth)
+static BOOL spoolss_io_addform(const char *desc, FORM *f, uint32 ptr, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_addform");
        depth++;
@@ -5443,7 +6346,7 @@ static BOOL spoolss_io_addform(char *desc, FORM *f, uint32 ptr, prs_struct *ps,
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spoolss_io_q_deleteform(char *desc, SPOOL_Q_DELETEFORM *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_deleteform(const char *desc, SPOOL_Q_DELETEFORM *q_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_q_deleteform");
        depth++;
@@ -5461,14 +6364,14 @@ BOOL spoolss_io_q_deleteform(char *desc, SPOOL_Q_DELETEFORM *q_u, prs_struct *ps
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spoolss_io_r_deleteform(char *desc, SPOOL_R_DELETEFORM *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_deleteform(const char *desc, SPOOL_R_DELETEFORM *r_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_r_deleteform");
        depth++;
 
        if(!prs_align(ps))
                return False;
-       if(!prs_uint32("status",        ps, depth, &r_u->status))
+       if(!prs_werror("status",        ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -5477,9 +6380,9 @@ BOOL spoolss_io_r_deleteform(char *desc, SPOOL_R_DELETEFORM *r_u, prs_struct *ps
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spoolss_io_q_addform(char *desc, SPOOL_Q_ADDFORM *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_addform(const char *desc, SPOOL_Q_ADDFORM *q_u, prs_struct *ps, int depth)
 {
-       uint32 useless_ptr=0;
+       uint32 useless_ptr=1;
        prs_debug(ps, depth, desc, "spoolss_io_q_addform");
        depth++;
 
@@ -5506,14 +6409,14 @@ BOOL spoolss_io_q_addform(char *desc, SPOOL_Q_ADDFORM *q_u, prs_struct *ps, int
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spoolss_io_r_addform(char *desc, SPOOL_R_ADDFORM *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_addform(const char *desc, SPOOL_R_ADDFORM *r_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_r_addform");
        depth++;
 
        if(!prs_align(ps))
                return False;
-       if(!prs_uint32("status",        ps, depth, &r_u->status))
+       if(!prs_werror("status",        ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -5522,9 +6425,9 @@ BOOL spoolss_io_r_addform(char *desc, SPOOL_R_ADDFORM *r_u, prs_struct *ps, int
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spoolss_io_q_setform(char *desc, SPOOL_Q_SETFORM *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_setform(const char *desc, SPOOL_Q_SETFORM *q_u, prs_struct *ps, int depth)
 {
-       uint32 useless_ptr=0;
+       uint32 useless_ptr=1;
        prs_debug(ps, depth, desc, "spoolss_io_q_setform");
        depth++;
 
@@ -5557,14 +6460,14 @@ BOOL spoolss_io_q_setform(char *desc, SPOOL_Q_SETFORM *q_u, prs_struct *ps, int
 /*******************************************************************
 ********************************************************************/  
 
-BOOL spoolss_io_r_setform(char *desc, SPOOL_R_SETFORM *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_setform(const char *desc, SPOOL_R_SETFORM *r_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_r_setform");
        depth++;
 
        if(!prs_align(ps))
                return False;
-       if(!prs_uint32("status",        ps, depth, &r_u->status))
+       if(!prs_werror("status",        ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -5574,7 +6477,7 @@ BOOL spoolss_io_r_setform(char *desc, SPOOL_R_SETFORM *r_u, prs_struct *ps, int
  Parse a SPOOL_R_GETJOB structure.
 ********************************************************************/  
 
-BOOL spoolss_io_r_getjob(char *desc, SPOOL_R_GETJOB *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_getjob(const char *desc, SPOOL_R_GETJOB *r_u, prs_struct *ps, int depth)
 {              
        prs_debug(ps, depth, desc, "spoolss_io_r_getjob");
        depth++;
@@ -5582,7 +6485,7 @@ BOOL spoolss_io_r_getjob(char *desc, SPOOL_R_GETJOB *r_u, prs_struct *ps, int de
        if (!prs_align(ps))
                return False;
                
-       if (!new_spoolss_io_buffer("", ps, depth, &r_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &r_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -5591,7 +6494,7 @@ BOOL spoolss_io_r_getjob(char *desc, SPOOL_R_GETJOB *r_u, prs_struct *ps, int de
        if (!prs_uint32("needed", ps, depth, &r_u->needed))
                return False;
                
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;            
@@ -5601,7 +6504,7 @@ BOOL spoolss_io_r_getjob(char *desc, SPOOL_R_GETJOB *r_u, prs_struct *ps, int de
  Parse a SPOOL_Q_GETJOB structure.
 ********************************************************************/  
 
-BOOL spoolss_io_q_getjob(char *desc, SPOOL_Q_GETJOB *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_getjob(const char *desc, SPOOL_Q_GETJOB *q_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "");
        depth++;
@@ -5616,7 +6519,7 @@ BOOL spoolss_io_q_getjob(char *desc, SPOOL_Q_GETJOB *q_u, prs_struct *ps, int de
        if(!prs_uint32("level", ps, depth, &q_u->level))
                return False;
        
-       if(!new_spoolss_io_buffer("", ps, depth, &q_u->buffer))
+       if(!spoolss_io_buffer("", ps, depth, &q_u->buffer))
                return False;
 
        if(!prs_align(ps))
@@ -5631,14 +6534,14 @@ BOOL spoolss_io_q_getjob(char *desc, SPOOL_Q_GETJOB *q_u, prs_struct *ps, int de
 void free_devmode(DEVICEMODE *devmode)
 {
        if (devmode!=NULL) {
-               safe_free(devmode->private);
-               safe_free(devmode);
+               SAFE_FREE(devmode->private);
+               SAFE_FREE(devmode);
        }
 }
 
 void free_printer_info_1(PRINTER_INFO_1 *printer)
 {
-       safe_free(printer);
+       SAFE_FREE(printer);
 }
 
 void free_printer_info_2(PRINTER_INFO_2 *printer)
@@ -5646,15 +6549,28 @@ void free_printer_info_2(PRINTER_INFO_2 *printer)
        if (printer!=NULL) {
                free_devmode(printer->devmode);
                printer->devmode = NULL;
-               safe_free(printer);
+               SAFE_FREE(printer);
        }
 }
 
 void free_printer_info_3(PRINTER_INFO_3 *printer)
 {
-       if (printer!=NULL) {
-               safe_free(printer);
-       }
+       SAFE_FREE(printer);
+}
+
+void free_printer_info_4(PRINTER_INFO_4 *printer)
+{
+       SAFE_FREE(printer);
+}
+
+void free_printer_info_5(PRINTER_INFO_5 *printer)
+{
+       SAFE_FREE(printer);
+}
+
+void free_printer_info_7(PRINTER_INFO_7 *printer)
+{
+       SAFE_FREE(printer);
 }
 
 void free_job_info_2(JOB_INFO_2 *job)
@@ -5688,7 +6604,7 @@ BOOL make_spoolss_q_replyopenprinter(SPOOL_Q_REPLYOPENPRINTER *q_u,
  Parse a SPOOL_Q_REPLYOPENPRINTER structure.
 ********************************************************************/  
 
-BOOL spoolss_io_q_replyopenprinter(char *desc, SPOOL_Q_REPLYOPENPRINTER *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_replyopenprinter(const char *desc, SPOOL_Q_REPLYOPENPRINTER *q_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_q_replyopenprinter");
        depth++;
@@ -5719,7 +6635,7 @@ BOOL spoolss_io_q_replyopenprinter(char *desc, SPOOL_Q_REPLYOPENPRINTER *q_u, pr
  Parse a SPOOL_R_REPLYOPENPRINTER structure.
 ********************************************************************/  
 
-BOOL spoolss_io_r_replyopenprinter(char *desc, SPOOL_R_REPLYOPENPRINTER *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_replyopenprinter(const char *desc, SPOOL_R_REPLYOPENPRINTER *r_u, prs_struct *ps, int depth)
 {              
        prs_debug(ps, depth, desc, "spoolss_io_r_replyopenprinter");
        depth++;
@@ -5730,12 +6646,79 @@ BOOL spoolss_io_r_replyopenprinter(char *desc, SPOOL_R_REPLYOPENPRINTER *r_u, pr
        if(!smb_io_pol_hnd("printer handle",&r_u->handle,ps,depth))
                return False;
 
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;            
 }
 
+/*******************************************************************
+ * init a structure.
+ ********************************************************************/
+BOOL make_spoolss_q_routerreplyprinter(SPOOL_Q_ROUTERREPLYPRINTER *q_u, POLICY_HND *hnd, 
+                                       uint32 condition, uint32 change_id)
+{
+
+       memcpy(&q_u->handle, hnd, sizeof(q_u->handle));
+
+       q_u->condition = condition;
+       q_u->change_id = change_id;
+
+       /* magic values */
+       q_u->unknown1 = 0x1;
+       memset(q_u->unknown2, 0x0, 5);
+       q_u->unknown2[0] = 0x1;
+
+       return True;
+}
+
+/*******************************************************************
+ Parse a SPOOL_Q_ROUTERREPLYPRINTER structure.
+********************************************************************/
+BOOL spoolss_io_q_routerreplyprinter (const char *desc, SPOOL_Q_ROUTERREPLYPRINTER *q_u, prs_struct *ps, int depth)
+{
+
+       prs_debug(ps, depth, desc, "spoolss_io_q_routerreplyprinter");
+       depth++;
+
+       if (!prs_align(ps))
+               return False;
+
+       if(!smb_io_pol_hnd("printer handle",&q_u->handle,ps,depth))
+               return False;
+
+       if (!prs_uint32("condition", ps, depth, &q_u->condition))
+               return False;
+
+       if (!prs_uint32("unknown1", ps, depth, &q_u->unknown1))
+               return False;
+
+       if (!prs_uint32("change_id", ps, depth, &q_u->change_id))
+               return False;
+
+       if (!prs_uint8s(False, "private",  ps, depth, q_u->unknown2, 5))
+               return False;
+
+       return True;
+}
+
+/*******************************************************************
+ Parse a SPOOL_R_ROUTERREPLYPRINTER structure.
+********************************************************************/
+BOOL spoolss_io_r_routerreplyprinter (const char *desc, SPOOL_R_ROUTERREPLYPRINTER *r_u, prs_struct *ps, int depth)
+{
+       prs_debug(ps, depth, desc, "spoolss_io_r_routerreplyprinter");
+       depth++;
+
+       if (!prs_align(ps))
+               return False;
+
+       if (!prs_werror("status", ps, depth, &r_u->status))
+               return False;
+
+       return True;
+}
+
 /*******************************************************************
  * init a structure.
  ********************************************************************/
@@ -5754,7 +6737,7 @@ BOOL make_spoolss_q_reply_closeprinter(SPOOL_Q_REPLYCLOSEPRINTER *q_u, POLICY_HN
  Parse a SPOOL_Q_REPLYCLOSEPRINTER structure.
 ********************************************************************/  
 
-BOOL spoolss_io_q_replycloseprinter(char *desc, SPOOL_Q_REPLYCLOSEPRINTER *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_replycloseprinter(const char *desc, SPOOL_Q_REPLYCLOSEPRINTER *q_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_q_replycloseprinter");
        depth++;
@@ -5772,7 +6755,7 @@ BOOL spoolss_io_q_replycloseprinter(char *desc, SPOOL_Q_REPLYCLOSEPRINTER *q_u,
  Parse a SPOOL_R_REPLYCLOSEPRINTER structure.
 ********************************************************************/  
 
-BOOL spoolss_io_r_replycloseprinter(char *desc, SPOOL_R_REPLYCLOSEPRINTER *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_replycloseprinter(const char *desc, SPOOL_R_REPLYCLOSEPRINTER *r_u, prs_struct *ps, int depth)
 {              
        prs_debug(ps, depth, desc, "spoolss_io_r_replycloseprinter");
        depth++;
@@ -5783,18 +6766,85 @@ BOOL spoolss_io_r_replycloseprinter(char *desc, SPOOL_R_REPLYCLOSEPRINTER *r_u,
        if(!smb_io_pol_hnd("printer handle",&r_u->handle,ps,depth))
                return False;
 
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;            
 }
 
+#if 0  /* JERRY - not currently used but could be :-) */
+
+/*******************************************************************
+ Deep copy a SPOOL_NOTIFY_INFO_DATA structure
+ ******************************************************************/
+static BOOL copy_spool_notify_info_data(SPOOL_NOTIFY_INFO_DATA *dst, 
+                               SPOOL_NOTIFY_INFO_DATA *src, int n)
+{
+       int i;
+
+       memcpy(dst, src, sizeof(SPOOL_NOTIFY_INFO_DATA)*n);
+       
+       for (i=0; i<n; i++) {
+               int len;
+               uint16 *s = NULL;
+               
+               if (src->size != POINTER) 
+                       continue;
+               len = src->notify_data.data.length;
+               s = malloc(sizeof(uint16)*len);
+               if (s == NULL) {
+                       DEBUG(0,("copy_spool_notify_info_data: malloc() failed!\n"));
+                       return False;
+               }
+               
+               memcpy(s, src->notify_data.data.string, len*2);
+               dst->notify_data.data.string = s;
+       }
+       
+       return True;
+}
+
+/*******************************************************************
+ Deep copy a SPOOL_NOTIFY_INFO structure
+ ******************************************************************/
+static BOOL copy_spool_notify_info(SPOOL_NOTIFY_INFO *dst, SPOOL_NOTIFY_INFO *src)
+{
+       if (!dst) {
+               DEBUG(0,("copy_spool_notify_info: NULL destination pointer!\n"));
+               return False;
+       }
+               
+       dst->version = src->version;
+       dst->flags   = src->flags;
+       dst->count   = src->count;
+       
+       if (dst->count) 
+       {
+               dst->data = malloc(dst->count * sizeof(SPOOL_NOTIFY_INFO_DATA));
+               
+               DEBUG(10,("copy_spool_notify_info: allocating space for [%d] PRINTER_NOTIFY_INFO_DATA entries\n",
+                       dst->count));
+
+               if (dst->data == NULL) {
+                       DEBUG(0,("copy_spool_notify_info: malloc() failed for [%d] entries!\n", 
+                               dst->count));
+                       return False;
+               }
+               
+               return (copy_spool_notify_info_data(dst->data, src->data, src->count));
+       }
+       
+       return True;
+}
+#endif /* JERRY */
+
 /*******************************************************************
  * init a structure.
  ********************************************************************/
 
 BOOL make_spoolss_q_reply_rrpcn(SPOOL_Q_REPLY_RRPCN *q_u, POLICY_HND *hnd,
-                               uint32 change_low, uint32 change_high)
+                               uint32 change_low, uint32 change_high,
+                               SPOOL_NOTIFY_INFO *info)
 {      
        if (q_u == NULL)
                return False;
@@ -5807,11 +6857,23 @@ BOOL make_spoolss_q_reply_rrpcn(SPOOL_Q_REPLY_RRPCN *q_u, POLICY_HND *hnd,
        q_u->unknown0=0x0;
        q_u->unknown1=0x0;
 
-       q_u->info_ptr=1;
+       q_u->info_ptr=0x0FF0ADDE;
 
        q_u->info.version=2;
+       
+       if (info->count) {
+               DEBUG(10,("make_spoolss_q_reply_rrpcn: [%d] PRINTER_NOTIFY_INFO_DATA\n",
+                       info->count));
+               q_u->info.version = info->version;
+               q_u->info.flags   = info->flags;
+               q_u->info.count   = info->count;
+               /* pointer field - be careful! */
+               q_u->info.data    = info->data;
+       }
+       else  {
        q_u->info.flags=PRINTER_NOTIFY_INFO_DISCARDED;
        q_u->info.count=0;
+       }
 
        return True;
 }
@@ -5820,7 +6882,7 @@ BOOL make_spoolss_q_reply_rrpcn(SPOOL_Q_REPLY_RRPCN *q_u, POLICY_HND *hnd,
  Parse a SPOOL_Q_REPLY_RRPCN structure.
 ********************************************************************/  
 
-BOOL spoolss_io_q_reply_rrpcn(char *desc, SPOOL_Q_REPLY_RRPCN *q_u, prs_struct *ps, int depth)
+BOOL spoolss_io_q_reply_rrpcn(const char *desc, SPOOL_Q_REPLY_RRPCN *q_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_q_reply_rrpcn");
        depth++;
@@ -5857,9 +6919,9 @@ BOOL spoolss_io_q_reply_rrpcn(char *desc, SPOOL_Q_REPLY_RRPCN *q_u, prs_struct *
  Parse a SPOOL_R_REPLY_RRPCN structure.
 ********************************************************************/  
 
-BOOL spoolss_io_r_reply_rrpcn(char *desc, SPOOL_R_REPLY_RRPCN *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_reply_rrpcn(const char *desc, SPOOL_R_REPLY_RRPCN *r_u, prs_struct *ps, int depth)
 {              
-       prs_debug(ps, depth, desc, "spoolss_io_r_replycloseprinter");
+       prs_debug(ps, depth, desc, "spoolss_io_r_reply_rrpcn");
        depth++;
 
        if (!prs_align(ps))
@@ -5868,8 +6930,821 @@ BOOL spoolss_io_r_reply_rrpcn(char *desc, SPOOL_R_REPLY_RRPCN *r_u, prs_struct *
        if (!prs_uint32("unknown0", ps, depth, &r_u->unknown0))
                return False;
 
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;            
 }
+
+/*******************************************************************
+ * read a structure.
+ * called from spoolss_q_getprinterdataex (srv_spoolss.c)
+ ********************************************************************/
+
+BOOL spoolss_io_q_getprinterdataex(const char *desc, SPOOL_Q_GETPRINTERDATAEX *q_u, prs_struct *ps, int depth)
+{
+       if (q_u == NULL)
+               return False;
+
+       prs_debug(ps, depth, desc, "spoolss_io_q_getprinterdataex");
+       depth++;
+
+       if (!prs_align(ps))
+               return False;
+       if (!smb_io_pol_hnd("printer handle",&q_u->handle,ps,depth))
+               return False;
+       if (!prs_align(ps))
+               return False;
+       if (!smb_io_unistr2("keyname", &q_u->keyname,True,ps,depth))
+               return False;
+       if (!prs_align(ps))
+               return False;
+       if (!smb_io_unistr2("valuename", &q_u->valuename,True,ps,depth))
+               return False;
+       if (!prs_align(ps))
+               return False;
+       if (!prs_uint32("size", ps, depth, &q_u->size))
+               return False;
+
+       return True;
+}
+
+/*******************************************************************
+ * write a structure.
+ * called from spoolss_r_getprinterdataex (srv_spoolss.c)
+ ********************************************************************/
+
+BOOL spoolss_io_r_getprinterdataex(const char *desc, SPOOL_R_GETPRINTERDATAEX *r_u, prs_struct *ps, int depth)
+{
+       if (r_u == NULL)
+               return False;
+
+       prs_debug(ps, depth, desc, "spoolss_io_r_getprinterdataex");
+       depth++;
+
+       if (!prs_align(ps))
+               return False;
+       if (!prs_uint32("type", ps, depth, &r_u->type))
+               return False;
+       if (!prs_uint32("size", ps, depth, &r_u->size))
+               return False;
+       
+       if (UNMARSHALLING(ps) && r_u->size) {
+               r_u->data = prs_alloc_mem(ps, r_u->size);
+               if(!r_u->data)
+                       return False;
+       }
+
+       if (!prs_uint8s(False,"data", ps, depth, r_u->data, r_u->size))
+               return False;
+               
+       if (!prs_align(ps))
+               return False;
+       
+       if (!prs_uint32("needed", ps, depth, &r_u->needed))
+               return False;
+       if (!prs_werror("status", ps, depth, &r_u->status))
+               return False;
+               
+       return True;
+}
+
+/*******************************************************************
+ * read a structure.
+ ********************************************************************/  
+
+BOOL spoolss_io_q_setprinterdataex(const char *desc, SPOOL_Q_SETPRINTERDATAEX *q_u, prs_struct *ps, int depth)
+{
+       prs_debug(ps, depth, desc, "spoolss_io_q_setprinterdataex");
+       depth++;
+
+       if(!prs_align(ps))
+               return False;
+       if(!smb_io_pol_hnd("printer handle", &q_u->handle, ps, depth))
+               return False;
+       if(!smb_io_unistr2("", &q_u->key, True, ps, depth))
+               return False;
+
+       if(!prs_align(ps))
+               return False;
+
+       if(!smb_io_unistr2("", &q_u->value, True, ps, depth))
+               return False;
+
+       if(!prs_align(ps))
+               return False;
+
+       if(!prs_uint32("type", ps, depth, &q_u->type))
+               return False;
+
+       if(!prs_uint32("max_len", ps, depth, &q_u->max_len))
+               return False;
+
+       switch (q_u->type)
+       {
+               case 0x1:
+               case 0x3:
+               case 0x4:
+               case 0x7:
+                       if (q_u->max_len) {
+                               if (UNMARSHALLING(ps))
+                                       q_u->data=(uint8 *)prs_alloc_mem(ps, q_u->max_len * sizeof(uint8));
+                               if(q_u->data == NULL)
+                                       return False;
+                               if(!prs_uint8s(False,"data", ps, depth, q_u->data, q_u->max_len))
+                                       return False;
+                       }
+                       if(!prs_align(ps))
+                               return False;
+                       break;
+       }       
+       
+       if(!prs_uint32("real_len", ps, depth, &q_u->real_len))
+               return False;
+
+       return True;
+}
+
+/*******************************************************************
+ * write a structure.
+ ********************************************************************/  
+
+BOOL spoolss_io_r_setprinterdataex(const char *desc, SPOOL_R_SETPRINTERDATAEX *r_u, prs_struct *ps, int depth)
+{
+       prs_debug(ps, depth, desc, "spoolss_io_r_setprinterdataex");
+       depth++;
+
+       if(!prs_align(ps))
+               return False;
+       if(!prs_werror("status",     ps, depth, &r_u->status))
+               return False;
+
+       return True;
+}
+
+/*******************************************************************
+ * read a structure.
+ ********************************************************************/  
+BOOL make_spoolss_q_enumprinterkey(SPOOL_Q_ENUMPRINTERKEY *q_u, 
+                                  POLICY_HND *hnd, const char *key, 
+                                  uint32 size)
+{
+       DEBUG(5,("make_spoolss_q_enumprinterkey\n"));
+
+       memcpy(&q_u->handle, hnd, sizeof(q_u->handle));
+       init_unistr2(&q_u->key, key, strlen(key)+1);
+       q_u->size = size;
+
+       return True;
+}
+
+/*******************************************************************
+ * read a structure.
+ ********************************************************************/  
+
+BOOL spoolss_io_q_enumprinterkey(const char *desc, SPOOL_Q_ENUMPRINTERKEY *q_u, prs_struct *ps, int depth)
+{
+       prs_debug(ps, depth, desc, "spoolss_io_q_enumprinterkey");
+       depth++;
+
+       if(!prs_align(ps))
+               return False;
+       if(!smb_io_pol_hnd("printer handle", &q_u->handle, ps, depth))
+               return False;
+               
+       if(!smb_io_unistr2("", &q_u->key, True, ps, depth))
+               return False;
+
+       if(!prs_align(ps))
+               return False;
+       
+       if(!prs_uint32("size", ps, depth, &q_u->size))
+               return False;
+
+       return True;
+}
+
+/*******************************************************************
+ * write a structure.
+ ********************************************************************/  
+
+BOOL spoolss_io_r_enumprinterkey(const char *desc, SPOOL_R_ENUMPRINTERKEY *r_u, prs_struct *ps, int depth)
+{
+       prs_debug(ps, depth, desc, "spoolss_io_r_enumprinterkey");
+       depth++;
+
+       if(!prs_align(ps))
+               return False;
+
+       if (!smb_io_buffer5("", &r_u->keys, ps, depth))
+               return False;
+       
+       if(!prs_align(ps))
+               return False;
+
+       if(!prs_uint32("needed",     ps, depth, &r_u->needed))
+               return False;
+
+       if(!prs_werror("status",     ps, depth, &r_u->status))
+               return False;
+
+       return True;
+}
+
+/*******************************************************************
+ * read a structure.
+ ********************************************************************/  
+
+BOOL make_spoolss_q_deleteprinterkey(SPOOL_Q_DELETEPRINTERKEY *q_u, 
+                                    POLICY_HND *hnd, char *keyname)
+{
+       DEBUG(5,("make_spoolss_q_deleteprinterkey\n"));
+
+       memcpy(&q_u->handle, hnd, sizeof(q_u->handle));
+       init_unistr2(&q_u->keyname, keyname, strlen(keyname)+1);
+
+       return True;
+}
+
+/*******************************************************************
+ * read a structure.
+ ********************************************************************/  
+
+BOOL spoolss_io_q_deleteprinterkey(const char *desc, SPOOL_Q_DELETEPRINTERKEY *q_u, prs_struct *ps, int depth)
+{
+       prs_debug(ps, depth, desc, "spoolss_io_q_deleteprinterkey");
+       depth++;
+
+       if(!prs_align(ps))
+               return False;
+       if(!smb_io_pol_hnd("printer handle", &q_u->handle, ps, depth))
+               return False;
+               
+       if(!smb_io_unistr2("", &q_u->keyname, True, ps, depth))
+               return False;
+
+       return True;
+}
+
+/*******************************************************************
+ * write a structure.
+ ********************************************************************/  
+
+BOOL spoolss_io_r_deleteprinterkey(const char *desc, SPOOL_R_DELETEPRINTERKEY *r_u, prs_struct *ps, int depth)
+{
+       prs_debug(ps, depth, desc, "spoolss_io_r_deleteprinterkey");
+       depth++;
+
+       if(!prs_align(ps))
+               return False;
+               
+       if(!prs_werror("status",     ps, depth, &r_u->status))
+               return False;
+
+       return True;
+}
+
+
+/*******************************************************************
+ * read a structure.
+ ********************************************************************/  
+
+BOOL spoolss_io_q_enumprinterdataex(const char *desc, SPOOL_Q_ENUMPRINTERDATAEX *q_u, prs_struct *ps, int depth)
+{
+       prs_debug(ps, depth, desc, "spoolss_io_q_enumprinterdataex");
+       depth++;
+
+       if(!prs_align(ps))
+               return False;
+       if(!smb_io_pol_hnd("printer handle", &q_u->handle, ps, depth))
+               return False;
+               
+       if(!smb_io_unistr2("", &q_u->key, True, ps, depth))
+               return False;
+
+       if(!prs_align(ps))
+               return False;
+       
+       if(!prs_uint32("size", ps, depth, &q_u->size))
+               return False;
+
+       return True;
+}
+
+/*******************************************************************
+********************************************************************/  
+
+static BOOL spoolss_io_printer_enum_values_ctr(const char *desc, prs_struct *ps, 
+                               PRINTER_ENUM_VALUES_CTR *ctr, int depth)
+{
+       int     i;
+       uint32  valuename_offset,
+               data_offset,
+               current_offset;
+       const uint32 basic_unit = 20; /* size of static portion of enum_values */
+       
+       prs_debug(ps, depth, desc, "spoolss_io_printer_enum_values_ctr");
+       depth++;        
+       
+       /* 
+        * offset data begins at 20 bytes per structure * size_of_array.
+        * Don't forget the uint32 at the beginning 
+        * */
+       
+       current_offset = basic_unit * ctr->size_of_array;
+       
+       /* first loop to write basic enum_value information */
+       
+       if (UNMARSHALLING(ps)) {
+               ctr->values = (PRINTER_ENUM_VALUES *)prs_alloc_mem(
+                       ps, ctr->size_of_array * sizeof(PRINTER_ENUM_VALUES));
+               if (!ctr->values)
+                       return False;
+       }
+
+       for (i=0; i<ctr->size_of_array; i++) {
+               valuename_offset = current_offset;
+               if (!prs_uint32("valuename_offset", ps, depth, &valuename_offset))
+                       return False;
+
+               if (!prs_uint32("value_len", ps, depth, &ctr->values[i].value_len))
+                       return False;
+       
+               if (!prs_uint32("type", ps, depth, &ctr->values[i].type))
+                       return False;
+       
+               data_offset = ctr->values[i].value_len + valuename_offset;
+               
+               if (!prs_uint32("data_offset", ps, depth, &data_offset))
+                       return False;
+
+               if (!prs_uint32("data_len", ps, depth, &ctr->values[i].data_len))
+                       return False;
+                       
+               current_offset  = data_offset + ctr->values[i].data_len - basic_unit;
+               /* account for 2 byte alignment */
+               current_offset += (current_offset % 2);
+       }
+
+       /* 
+        * loop #2 for writing the dynamically size objects; pay 
+        * attention to 2-byte alignment here....
+        */
+       
+       for (i=0; i<ctr->size_of_array; i++) {
+       
+               if (!prs_unistr("valuename", ps, depth, &ctr->values[i].valuename))
+                       return False;
+               
+               if (UNMARSHALLING(ps) && ctr->values[i].data_len) {
+                       ctr->values[i].data = (uint8 *)prs_alloc_mem(
+                               ps, ctr->values[i].data_len);
+                       if (!ctr->values[i].data)
+                               return False;
+                       if (!prs_uint8s(False, "data", ps, depth, ctr->values[i].data, ctr->values[i].data_len))
+                               return False;
+               }
+                       
+               if ( !prs_align_uint16(ps) )
+                       return False;
+       }
+
+       return True;    
+}
+
+/*******************************************************************
+ * write a structure.
+ ********************************************************************/  
+
+BOOL spoolss_io_r_enumprinterdataex(const char *desc, SPOOL_R_ENUMPRINTERDATAEX *r_u, prs_struct *ps, int depth)
+{
+       uint32 data_offset, end_offset;
+       prs_debug(ps, depth, desc, "spoolss_io_r_enumprinterdataex");
+       depth++;
+
+       if(!prs_align(ps))
+               return False;
+
+       if (!prs_uint32("size", ps, depth, &r_u->ctr.size))
+               return False;
+
+       data_offset = prs_offset(ps);
+
+       if (!prs_set_offset(ps, data_offset + r_u->ctr.size))
+               return False;
+
+       if(!prs_align(ps))
+               return False;
+
+       if(!prs_uint32("needed",     ps, depth, &r_u->needed))
+               return False;
+
+       if(!prs_uint32("returned",   ps, depth, &r_u->returned))
+               return False;
+
+       if(!prs_werror("status",     ps, depth, &r_u->status))
+               return False;
+
+       r_u->ctr.size_of_array = r_u->returned;
+
+       end_offset = prs_offset(ps);
+
+       if (!prs_set_offset(ps, data_offset))
+               return False;
+
+       if (r_u->ctr.size)
+               if (!spoolss_io_printer_enum_values_ctr("", ps, &r_u->ctr, depth ))
+                       return False;
+
+       if (!prs_set_offset(ps, end_offset))
+               return False;
+                                                                                                                                                       return True;
+}
+
+/*******************************************************************
+ * write a structure.
+ ********************************************************************/  
+
+/* 
+   uint32 GetPrintProcessorDirectory(
+       [in] unistr2 *name,
+       [in] unistr2 *environment,
+       [in] uint32 level,
+       [in,out] NEW_BUFFER buffer,
+       [in] uint32 offered,
+       [out] uint32 needed,
+       [out] uint32 returned
+   );
+
+*/
+
+BOOL make_spoolss_q_getprintprocessordirectory(SPOOL_Q_GETPRINTPROCESSORDIRECTORY *q_u, const char *name, char *environment, int level, NEW_BUFFER *buffer, uint32 offered)
+{
+       DEBUG(5,("make_spoolss_q_getprintprocessordirectory\n"));
+
+       init_unistr2(&q_u->name, name, strlen(name)+1);
+       init_unistr2(&q_u->environment, environment, strlen(environment)+1);
+
+       q_u->level = level;
+
+       q_u->buffer = buffer;
+       q_u->offered = offered;
+
+       return True;
+}
+
+BOOL spoolss_io_q_getprintprocessordirectory(const char *desc, SPOOL_Q_GETPRINTPROCESSORDIRECTORY *q_u, prs_struct *ps, int depth)
+{
+       uint32 ptr;
+
+       prs_debug(ps, depth, desc, "spoolss_io_q_getprintprocessordirectory");
+       depth++;
+
+       if(!prs_align(ps))
+               return False;   
+
+       if (!prs_uint32("ptr", ps, depth, &ptr)) 
+               return False;
+
+       if (ptr) {
+               if(!smb_io_unistr2("name", &q_u->name, True, ps, depth))
+                       return False;
+       }
+
+       if (!prs_align(ps))
+               return False;
+
+       if (!prs_uint32("ptr", ps, depth, &ptr))
+               return False;
+
+       if (ptr) {
+               if(!smb_io_unistr2("environment", &q_u->environment, True, 
+                                  ps, depth))
+                       return False;
+       }
+
+       if (!prs_align(ps))
+               return False;
+
+       if(!prs_uint32("level",   ps, depth, &q_u->level))
+               return False;
+
+       if(!spoolss_io_buffer("", ps, depth, &q_u->buffer))
+               return False;
+       
+       if(!prs_align(ps))
+               return False;
+
+       if(!prs_uint32("offered", ps, depth, &q_u->offered))
+               return False;
+
+       return True;
+}
+
+/*******************************************************************
+ * write a structure.
+ ********************************************************************/  
+
+BOOL spoolss_io_r_getprintprocessordirectory(const char *desc, SPOOL_R_GETPRINTPROCESSORDIRECTORY *r_u, prs_struct *ps, int depth)
+{
+       prs_debug(ps, depth, desc, "spoolss_io_r_getprintprocessordirectory");
+       depth++;
+
+       if(!prs_align(ps))
+               return False;
+
+       if(!spoolss_io_buffer("", ps, depth, &r_u->buffer))
+               return False;
+       
+       if(!prs_align(ps))
+               return False;
+
+       if(!prs_uint32("needed",     ps, depth, &r_u->needed))
+               return False;
+               
+       if(!prs_werror("status",     ps, depth, &r_u->status))
+               return False;
+
+       return True;
+}
+
+BOOL smb_io_printprocessordirectory_1(const char *desc, NEW_BUFFER *buffer, PRINTPROCESSOR_DIRECTORY_1 *info, int depth)
+{
+       prs_struct *ps=&buffer->prs;
+
+       prs_debug(ps, depth, desc, "smb_io_printprocessordirectory_1");
+       depth++;
+
+       buffer->struct_start=prs_offset(ps);
+
+       if (!smb_io_unistr(desc, &info->name, ps, depth))
+               return False;
+
+       return True;
+}
+
+/*******************************************************************
+ * init a structure.
+ ********************************************************************/
+
+BOOL make_spoolss_q_addform(SPOOL_Q_ADDFORM *q_u, POLICY_HND *handle, 
+                           int level, FORM *form)
+{
+       memcpy(&q_u->handle, handle, sizeof(POLICY_HND));
+       q_u->level = level;
+       q_u->level2 = level;
+       memcpy(&q_u->form, form, sizeof(FORM));
+
+       return True;
+}
+
+/*******************************************************************
+ * init a structure.
+ ********************************************************************/
+
+BOOL make_spoolss_q_setform(SPOOL_Q_SETFORM *q_u, POLICY_HND *handle, 
+                           int level, const char *form_name, FORM *form)
+{
+       memcpy(&q_u->handle, handle, sizeof(POLICY_HND));
+       q_u->level = level;
+       q_u->level2 = level;
+       memcpy(&q_u->form, form, sizeof(FORM));
+       init_unistr2(&q_u->name, form_name, strlen(form_name) + 1);
+
+       return True;
+}
+
+/*******************************************************************
+ * init a structure.
+ ********************************************************************/
+
+BOOL make_spoolss_q_deleteform(SPOOL_Q_DELETEFORM *q_u, POLICY_HND *handle, 
+                              const char *form)
+{
+       memcpy(&q_u->handle, handle, sizeof(POLICY_HND));
+       init_unistr2(&q_u->name, form, strlen(form) + 1);
+       return True;
+}
+
+/*******************************************************************
+ * init a structure.
+ ********************************************************************/
+
+BOOL make_spoolss_q_getform(SPOOL_Q_GETFORM *q_u, POLICY_HND *handle, 
+                            const char *formname, uint32 level, 
+                           NEW_BUFFER *buffer, uint32 offered)
+{
+        memcpy(&q_u->handle, handle, sizeof(POLICY_HND));
+        q_u->level = level;
+        init_unistr2(&q_u->formname, formname, strlen(formname) + 1);
+        q_u->buffer=buffer;
+        q_u->offered=offered;
+
+        return True;
+}
+
+/*******************************************************************
+ * init a structure.
+ ********************************************************************/
+
+BOOL make_spoolss_q_enumforms(SPOOL_Q_ENUMFORMS *q_u, POLICY_HND *handle, 
+                             uint32 level, NEW_BUFFER *buffer,
+                             uint32 offered)
+{
+        memcpy(&q_u->handle, handle, sizeof(POLICY_HND));
+        q_u->level = level;
+        q_u->buffer=buffer;
+        q_u->offered=offered;
+
+       return True;
+}
+
+/*******************************************************************
+ * init a structure.
+ ********************************************************************/
+
+BOOL make_spoolss_q_setjob(SPOOL_Q_SETJOB *q_u, POLICY_HND *handle, 
+                          uint32 jobid, uint32 level, uint32 command)
+{
+        memcpy(&q_u->handle, handle, sizeof(POLICY_HND));
+       q_u->jobid = jobid;
+        q_u->level = level;
+
+       /* Hmm - the SPOOL_Q_SETJOB structure has a JOB_INFO ctr in it but
+          the server side code has it marked as unused. */
+
+        q_u->command = command;
+
+       return True;
+}
+
+/*******************************************************************
+ * init a structure.
+ ********************************************************************/
+
+BOOL make_spoolss_q_getjob(SPOOL_Q_GETJOB *q_u, POLICY_HND *handle, 
+                          uint32 jobid, uint32 level, NEW_BUFFER *buffer,
+                          uint32 offered)
+{
+        memcpy(&q_u->handle, handle, sizeof(POLICY_HND));
+        q_u->jobid = jobid;
+        q_u->level = level;
+        q_u->buffer = buffer;
+        q_u->offered = offered;
+
+       return True;
+}
+
+/*******************************************************************
+ * init a structure.
+ ********************************************************************/
+
+BOOL make_spoolss_q_startpageprinter(SPOOL_Q_STARTPAGEPRINTER *q_u, 
+                                    POLICY_HND *handle)
+{
+        memcpy(&q_u->handle, handle, sizeof(POLICY_HND));
+
+       return True;
+}
+
+/*******************************************************************
+ * init a structure.
+ ********************************************************************/
+
+BOOL make_spoolss_q_endpageprinter(SPOOL_Q_ENDPAGEPRINTER *q_u, 
+                                  POLICY_HND *handle)
+{
+        memcpy(&q_u->handle, handle, sizeof(POLICY_HND));
+
+       return True;
+}
+
+/*******************************************************************
+ * init a structure.
+ ********************************************************************/
+
+BOOL make_spoolss_q_startdocprinter(SPOOL_Q_STARTDOCPRINTER *q_u, 
+                                   POLICY_HND *handle, uint32 level,
+                                   char *docname, char *outputfile,
+                                   char *datatype)
+{
+       DOC_INFO_CONTAINER *ctr = &q_u->doc_info_container;
+
+        memcpy(&q_u->handle, handle, sizeof(POLICY_HND));
+
+       ctr->level = level;
+
+       switch (level) {
+       case 1:
+               ctr->docinfo.switch_value = level;
+
+               ctr->docinfo.doc_info_1.p_docname = docname ? 1 : 0;
+               ctr->docinfo.doc_info_1.p_outputfile = outputfile ? 1 : 0;
+               ctr->docinfo.doc_info_1.p_datatype = datatype ? 1 : 0;
+
+               if (docname)
+                       init_unistr2(&ctr->docinfo.doc_info_1.docname, docname,
+                                    strlen(docname) + 1);
+
+               if (outputfile)
+                       init_unistr2(&ctr->docinfo.doc_info_1.outputfile, outputfile,
+                                    strlen(outputfile) + 1);
+
+               if (datatype)
+                       init_unistr2(&ctr->docinfo.doc_info_1.datatype, datatype,
+                                    strlen(datatype) + 1);
+
+               break;
+       case 2:
+               /* DOC_INFO_2 is only used by Windows 9x and since it
+                  doesn't do printing over RPC we don't have to worry
+                  about it. */
+       default:
+               DEBUG(3, ("unsupported info level %d\n", level));
+               return False;
+       }
+
+       return True;
+}
+
+/*******************************************************************
+ * init a structure.
+ ********************************************************************/
+
+BOOL make_spoolss_q_enddocprinter(SPOOL_Q_ENDDOCPRINTER *q_u, 
+                                 POLICY_HND *handle)
+{
+        memcpy(&q_u->handle, handle, sizeof(POLICY_HND));
+
+       return True;
+}
+
+/*******************************************************************
+ * init a structure.
+ ********************************************************************/
+
+BOOL make_spoolss_q_writeprinter(SPOOL_Q_WRITEPRINTER *q_u, 
+                                POLICY_HND *handle, uint32 data_size,
+                                char *data)
+{
+        memcpy(&q_u->handle, handle, sizeof(POLICY_HND));
+       q_u->buffer_size = q_u->buffer_size2 = data_size;
+       q_u->buffer = data;
+       return True;
+}
+
+/*******************************************************************
+ * init a structure.
+ ********************************************************************/
+
+BOOL make_spoolss_q_deleteprinterdata(SPOOL_Q_DELETEPRINTERDATA *q_u, 
+                                POLICY_HND *handle, char *valuename)
+{
+        memcpy(&q_u->handle, handle, sizeof(POLICY_HND));
+       init_unistr2(&q_u->valuename, valuename, strlen(valuename) + 1);
+
+       return True;
+}
+
+/*******************************************************************
+ * init a structure.
+ ********************************************************************/
+
+BOOL make_spoolss_q_deleteprinterdataex(SPOOL_Q_DELETEPRINTERDATAEX *q_u, 
+                                       POLICY_HND *handle, char *key,
+                                       char *value)
+{
+        memcpy(&q_u->handle, handle, sizeof(POLICY_HND));
+       init_unistr2(&q_u->valuename, value, strlen(value) + 1);
+       init_unistr2(&q_u->keyname, key, strlen(key) + 1);
+
+       return True;
+}
+
+/*******************************************************************
+ * init a structure.
+ ********************************************************************/
+
+BOOL make_spoolss_q_rffpcnex(SPOOL_Q_RFFPCNEX *q_u, POLICY_HND *handle,
+                            uint32 flags, uint32 options, const char *localmachine,
+                            uint32 printerlocal, SPOOL_NOTIFY_OPTION *option)
+{
+        memcpy(&q_u->handle, handle, sizeof(POLICY_HND));
+
+       q_u->flags = flags;
+       q_u->options = options;
+
+       q_u->localmachine_ptr = 1;
+
+       init_unistr2(&q_u->localmachine, localmachine, 
+                    strlen(localmachine) + 1);
+
+       q_u->printerlocal = printerlocal;
+
+       if (option)
+               q_u->option_ptr = 1;
+
+       q_u->option = option;
+
+       return True;
+}