This commit was manufactured by cvs2svn to create branch 'SAMBA_3_0'.(This used to...
[kai/samba.git] / source3 / rpc_client / cli_lsarpc.c
index f80d6613f66570952a78f1e7beb520dcf8ba6b88..db873236e46b49790462d679211f3e70710b4f1e 100644 (file)
-
 /* 
- *  Unix SMB/Netbios implementation.
- *  Version 1.9.
- *  RPC Pipe client / server routines
- *  Copyright (C) Andrew Tridgell              1992-1997,
- *  Copyright (C) Luke Kenneth Casson Leighton 1996-1997,
- *  Copyright (C) Paul Ashton                       1997.
- *  
- *  This program is free software; you can redistribute it and/or modify
- *  it under the terms of the GNU General Public License as published by
- *  the Free Software Foundation; either version 2 of the License, or
- *  (at your option) any later version.
- *  
- *  This program is distributed in the hope that it will be useful,
- *  but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  GNU General Public License for more details.
- *  
- *  You should have received a copy of the GNU General Public License
- *  along with this program; if not, write to the Free Software
- *  Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
- */
-
-
-#ifdef SYSLOG
-#undef SYSLOG
-#endif
+   Unix SMB/CIFS implementation.
+   RPC pipe client
+   Copyright (C) Tim Potter                        2000-2001,
+   Copyright (C) Andrew Tridgell              1992-1997,2000,
+   Copyright (C) Luke Kenneth Casson Leighton 1996-1997,2000,
+   Copyright (C) Paul Ashton                       1997,2000,
+   Copyright (C) Elrond                                 2000,
+   Copyright (C) Rafal Szczesniak                       2002
+   
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 2 of the License, or
+   (at your option) any later version.
+   
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+   
+   You should have received a copy of the GNU General Public License
+   along with this program; if not, write to the Free Software
+   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+*/
 
 #include "includes.h"
 
-extern int DEBUGLEVEL;
+/** @defgroup lsa LSA - Local Security Architecture
+ *  @ingroup rpc_client
+ *
+ * @{
+ **/
+
+/**
+ * @file cli_lsarpc.c
+ *
+ * RPC client routines for the LSA RPC pipe.  LSA means "local
+ * security authority", which is half of a password database.
+ **/
+
+/** Open a LSA policy handle
+ *
+ * @param cli Handle on an initialised SMB connection */
+
+NTSTATUS cli_lsa_open_policy(struct cli_state *cli, TALLOC_CTX *mem_ctx,
+                             BOOL sec_qos, uint32 des_access, POLICY_HND *pol)
+{
+       prs_struct qbuf, rbuf;
+       LSA_Q_OPEN_POL q;
+       LSA_R_OPEN_POL r;
+       LSA_SEC_QOS qos;
+       NTSTATUS result;
+
+       ZERO_STRUCT(q);
+       ZERO_STRUCT(r);
+
+       /* Initialise parse structures */
+
+       prs_init(&qbuf, MAX_PDU_FRAG_LEN, mem_ctx, MARSHALL);
+       prs_init(&rbuf, 0, mem_ctx, UNMARSHALL);
+
+       /* Initialise input parameters */
+
+       if (sec_qos) {
+               init_lsa_sec_qos(&qos, 2, 1, 0);
+               init_q_open_pol(&q, '\\', 0, des_access, &qos);
+       } else {
+               init_q_open_pol(&q, '\\', 0, des_access, NULL);
+       }
+
+       /* Marshall data and send request */
+
+       if (!lsa_io_q_open_pol("", &q, &qbuf, 0) ||
+           !rpc_api_pipe_req(cli, LSA_OPENPOLICY, &qbuf, &rbuf)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
 
+       /* Unmarshall response */
 
-/****************************************************************************
-do a LSA Open Policy
-****************************************************************************/
-BOOL lsa_open_policy(struct cli_state *cli,
-                       char *server_name, POLICY_HND *hnd,
-                       BOOL sec_qos)
+       if (!lsa_io_r_open_pol("", &r, &rbuf, 0)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+
+       /* Return output parameters */
+
+       if (NT_STATUS_IS_OK(result = r.status)) {
+               *pol = r.pol;
+#ifdef __INSURE__
+               pol->marker = malloc(1);
+#endif
+       }
+
+ done:
+       prs_mem_free(&qbuf);
+       prs_mem_free(&rbuf);
+
+       return result;
+}
+
+/** Open a LSA policy handle
+  *
+  * @param cli Handle on an initialised SMB connection 
+  */
+
+NTSTATUS cli_lsa_open_policy2(struct cli_state *cli, TALLOC_CTX *mem_ctx,
+                              BOOL sec_qos, uint32 des_access, POLICY_HND *pol)
 {
-       prs_struct rbuf;
-       prs_struct buf; 
-       LSA_Q_OPEN_POL q_o;
+       prs_struct qbuf, rbuf;
+       LSA_Q_OPEN_POL2 q;
+       LSA_R_OPEN_POL2 r;
        LSA_SEC_QOS qos;
-       BOOL valid_pol = False;
+       NTSTATUS result;
+
+       ZERO_STRUCT(q);
+       ZERO_STRUCT(r);
 
-       if (hnd == NULL) return False;
+       /* Initialise parse structures */
 
-       prs_init(&buf , 1024, 4, SAFETY_MARGIN, False);
-       prs_init(&rbuf, 0   , 4, SAFETY_MARGIN, True );
+       prs_init(&qbuf, MAX_PDU_FRAG_LEN, mem_ctx, MARSHALL);
+       prs_init(&rbuf, 0, mem_ctx, UNMARSHALL);
 
-       /* create and send a MSRPC command with api LSA_OPENPOLICY */
+       /* Initialise input parameters */
 
-       DEBUG(4,("LSA Open Policy\n"));
+       if (sec_qos) {
+               init_lsa_sec_qos(&qos, 2, 1, 0);
+               init_q_open_pol2(&q, cli->srv_name_slash, 0, des_access, 
+                                 &qos);
+       } else {
+               init_q_open_pol2(&q, cli->srv_name_slash, 0, des_access, 
+                                 NULL);
+       }
+
+       /* Marshall data and send request */
 
-       /* store the parameters */
-       if (sec_qos)
-       {
-               make_lsa_sec_qos(&qos, 2, 1, 0, 0x20000000);
-               make_q_open_pol(&q_o, 0x5c, 0, 0, &qos);
+       if (!lsa_io_q_open_pol2("", &q, &qbuf, 0) ||
+           !rpc_api_pipe_req(cli, LSA_OPENPOLICY2, &qbuf, &rbuf)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
        }
-       else
-       {
-               make_q_open_pol(&q_o, 0x5c, 0, 0x1, NULL);
+
+       /* Unmarshall response */
+
+       if (!lsa_io_r_open_pol2("", &r, &rbuf, 0)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
        }
 
-       /* turn parameters into data stream */
-       lsa_io_q_open_pol("", &q_o, &buf, 0);
+       /* Return output parameters */
 
-       /* send the data on \PIPE\ */
-       if (rpc_api_pipe_req(cli, LSA_OPENPOLICY, &buf, &rbuf))
-       {
-               LSA_R_OPEN_POL r_o;
-               BOOL p;
+       if (NT_STATUS_IS_OK(result = r.status)) {
+               *pol = r.pol;
+#ifdef __INSURE__
+               pol->marker = (char *)malloc(1);
+#endif
+       }
 
-               lsa_io_r_open_pol("", &r_o, &rbuf, 0);
-               p = rbuf.offset != 0;
+ done:
+       prs_mem_free(&qbuf);
+       prs_mem_free(&rbuf);
 
-               if (p && r_o.status != 0)
-               {
-                       /* report error code */
-                       DEBUG(0,("LSA_OPENPOLICY: %s\n", get_nt_error_msg(r_o.status)));
-                       p = False;
-               }
+       return result;
+}
 
-               if (p)
-               {
-                       /* ok, at last: we're happy. return the policy handle */
-                       memcpy(hnd, r_o.pol.data, sizeof(hnd->data));
-                       valid_pol = True;
-               }
+/** Close a LSA policy handle */
+
+NTSTATUS cli_lsa_close(struct cli_state *cli, TALLOC_CTX *mem_ctx, 
+                       POLICY_HND *pol)
+{
+       prs_struct qbuf, rbuf;
+       LSA_Q_CLOSE q;
+       LSA_R_CLOSE r;
+       NTSTATUS result;
+
+       ZERO_STRUCT(q);
+       ZERO_STRUCT(r);
+
+       /* Initialise parse structures */
+
+       prs_init(&qbuf, MAX_PDU_FRAG_LEN, mem_ctx, MARSHALL);
+       prs_init(&rbuf, 0, mem_ctx, UNMARSHALL);
+
+       /* Marshall data and send request */
+
+       init_lsa_q_close(&q, pol);
+
+       if (!lsa_io_q_close("", &q, &qbuf, 0) ||
+           !rpc_api_pipe_req(cli, LSA_CLOSE, &qbuf, &rbuf)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+
+       /* Unmarshall response */
+
+       if (!lsa_io_r_close("", &r, &rbuf, 0)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+
+       /* Return output parameters */
+
+       if (NT_STATUS_IS_OK(result = r.status)) {
+#ifdef __INSURE__
+               SAFE_FREE(pol->marker);
+#endif
+               *pol = r.pol;
        }
 
+ done:
+       prs_mem_free(&qbuf);
        prs_mem_free(&rbuf);
-       prs_mem_free(&buf );
 
-       return valid_pol;
+       return result;
 }
 
-/****************************************************************************
-do a LSA Lookup Names
-****************************************************************************/
-BOOL lsa_lookup_names(struct cli_state *cli,
-                       POLICY_HND *hnd,
-                       int num_names,
-                       char **names,
-                       DOM_SID **sids,
-                       int *num_sids)
+/** Lookup a list of sids */
+
+NTSTATUS cli_lsa_lookup_sids(struct cli_state *cli, TALLOC_CTX *mem_ctx,
+                             POLICY_HND *pol, int num_sids, DOM_SID *sids, 
+                             char ***domains, char ***names, uint32 **types)
 {
-       prs_struct rbuf;
-       prs_struct buf; 
-       LSA_Q_LOOKUP_NAMES q_l;
-       BOOL valid_response = False;
+       prs_struct qbuf, rbuf;
+       LSA_Q_LOOKUP_SIDS q;
+       LSA_R_LOOKUP_SIDS r;
+       DOM_R_REF ref;
+       LSA_TRANS_NAME_ENUM t_names;
+       NTSTATUS result;
+       int i;
 
-       if (hnd == NULL || num_sids == 0 || sids == NULL) return False;
+       ZERO_STRUCT(q);
+       ZERO_STRUCT(r);
 
-       prs_init(&buf , 1024, 4, SAFETY_MARGIN, False);
-       prs_init(&rbuf, 0   , 4, SAFETY_MARGIN, True );
+       /* Initialise parse structures */
 
-       /* create and send a MSRPC command with api LSA_LOOKUP_NAMES */
+       prs_init(&qbuf, MAX_PDU_FRAG_LEN, mem_ctx, MARSHALL);
+       prs_init(&rbuf, 0, mem_ctx, UNMARSHALL);
 
-       DEBUG(4,("LSA Lookup NAMEs\n"));
+       /* Marshall data and send request */
 
-       /* store the parameters */
-       make_q_lookup_names(&q_l, hnd, num_names, names);
+       init_q_lookup_sids(mem_ctx, &q, pol, num_sids, sids, 1);
 
-       /* turn parameters into data stream */
-       lsa_io_q_lookup_names("", &q_l, &buf, 0);
+       if (!lsa_io_q_lookup_sids("", &q, &qbuf, 0) ||
+           !rpc_api_pipe_req(cli, LSA_LOOKUPSIDS, &qbuf, &rbuf)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
 
-       /* send the data on \PIPE\ */
-       if (rpc_api_pipe_req(cli, LSA_LOOKUPNAMES, &buf, &rbuf))
-       {
-               LSA_R_LOOKUP_NAMES r_l;
-               DOM_R_REF ref;
-               DOM_RID2 t_rids[MAX_LOOKUP_SIDS];
-               BOOL p;
+       /* Unmarshall response */
 
-               ZERO_STRUCT(ref);
-               ZERO_STRUCT(t_rids);
+       ZERO_STRUCT(ref);
+       ZERO_STRUCT(t_names);
 
-               r_l.dom_ref = &ref;
-               r_l.dom_rid = t_rids;
+       r.dom_ref = &ref;
+       r.names = &t_names;
 
-               lsa_io_r_lookup_names("", &r_l, &rbuf, 0);
-               p = rbuf.offset != 0;
-               
-               if (p && r_l.status != 0)
-               {
-                       /* report error code */
-                       DEBUG(0,("LSA_LOOKUP_NAMES: %s\n", get_nt_error_msg(r_l.status)));
-                       p = False;
-               }
+       if (!lsa_io_r_lookup_sids("", &r, &rbuf, 0)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
 
-               if (p)
-               {
-                       if (r_l.undoc_buffer != 0 && ref.undoc_buffer != 0)
-                       {
-                               valid_response = True;
-                       }
-               }
+       result = r.status;
 
-               if (num_sids != NULL && valid_response)
-               {
-                       (*num_sids) = r_l.num_entries;
-               }
-               if (valid_response)
-               {
-                       int i;
-                       for (i = 0; i < r_l.num_entries; i++)
-                       {
-                               if (t_rids[i].rid_idx >= ref.num_ref_doms_1 &&
-                                   t_rids[i].rid_idx != 0xffffffff)
-                               {
-                                       DEBUG(0,("LSA_LOOKUP_NAMES: domain index %d out of bounds\n",
-                                                 t_rids[i].rid_idx));
-                                       valid_response = False;
-                                       break;
-                               }
+       if (!NT_STATUS_IS_OK(result) &&
+           NT_STATUS_V(result) != NT_STATUS_V(STATUS_SOME_UNMAPPED)) {
+         
+               /* An actual error occured */
+
+               goto done;
+       }
+
+       /* Return output parameters */
+
+       if (r.mapped_count == 0) {
+               result = NT_STATUS_NONE_MAPPED;
+               goto done;
+       }
+
+       if (!((*domains) = (char **)talloc(mem_ctx, sizeof(char *) *
+                                          num_sids))) {
+               DEBUG(0, ("cli_lsa_lookup_sids(): out of memory\n"));
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+
+       if (!((*names) = (char **)talloc(mem_ctx, sizeof(char *) *
+                                        num_sids))) {
+               DEBUG(0, ("cli_lsa_lookup_sids(): out of memory\n"));
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+
+       if (!((*types) = (uint32 *)talloc(mem_ctx, sizeof(uint32) *
+                                         num_sids))) {
+               DEBUG(0, ("cli_lsa_lookup_sids(): out of memory\n"));
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+               
+       for (i = 0; i < num_sids; i++) {
+               fstring name, dom_name;
+               uint32 dom_idx = t_names.name[i].domain_idx;
+
+               /* Translate optimised name through domain index array */
+
+               if (dom_idx != 0xffffffff) {
+
+                       rpcstr_pull_unistr2_fstring(
+                                dom_name, &ref.ref_dom[dom_idx].uni_dom_name);
+                       rpcstr_pull_unistr2_fstring(
+                                name, &t_names.uni_name[i]);
+
+                       (*names)[i] = talloc_strdup(mem_ctx, name);
+                       (*domains)[i] = talloc_strdup(mem_ctx, dom_name);
+                       (*types)[i] = t_names.name[i].sid_name_use;
+                       
+                       if (((*names)[i] == NULL) || ((*domains)[i] == NULL)) {
+                               DEBUG(0, ("cli_lsa_lookup_sids(): out of memory\n"));
+                               result = NT_STATUS_UNSUCCESSFUL;
+                               goto done;
                        }
-               }
 
-               if (sids != NULL && valid_response && r_l.num_entries != 0)
-               {
-                       (*sids) = (DOM_SID*)malloc((*num_sids) * sizeof(DOM_SID));
+               } else {
+                       (*names)[i] = NULL;
+                       (*types)[i] = SID_NAME_UNKNOWN;
                }
+       }
+
+ done:
+       prs_mem_free(&qbuf);
+       prs_mem_free(&rbuf);
+
+       return result;
+}
+
+/** Lookup a list of names */
+
+NTSTATUS cli_lsa_lookup_names(struct cli_state *cli, TALLOC_CTX *mem_ctx,
+                              POLICY_HND *pol, int num_names, 
+                             const char **names, DOM_SID **sids, 
+                             uint32 **types)
+{
+       prs_struct qbuf, rbuf;
+       LSA_Q_LOOKUP_NAMES q;
+       LSA_R_LOOKUP_NAMES r;
+       DOM_R_REF ref;
+       NTSTATUS result;
+       int i;
+       
+       ZERO_STRUCT(q);
+       ZERO_STRUCT(r);
+
+       /* Initialise parse structures */
+
+       prs_init(&qbuf, MAX_PDU_FRAG_LEN, mem_ctx, MARSHALL);
+       prs_init(&rbuf, 0, mem_ctx, UNMARSHALL);
+
+       /* Marshall data and send request */
+
+       init_q_lookup_names(mem_ctx, &q, pol, num_names, names);
+
+       if (!lsa_io_q_lookup_names("", &q, &qbuf, 0) ||
+           !rpc_api_pipe_req(cli, LSA_LOOKUPNAMES, &qbuf, &rbuf)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+       
+       /* Unmarshall response */
+
+       ZERO_STRUCT(ref);
+       r.dom_ref = &ref;
+
+       if (!lsa_io_r_lookup_names("", &r, &rbuf, 0)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+
+       result = r.status;
+
+       if (!NT_STATUS_IS_OK(result) && NT_STATUS_V(result) !=
+           NT_STATUS_V(STATUS_SOME_UNMAPPED)) {
+
+               /* An actual error occured */
+
+               goto done;
+       }
+
+       /* Return output parameters */
+
+       if (r.mapped_count == 0) {
+               result = NT_STATUS_NONE_MAPPED;
+               goto done;
+       }
+
+       if (!((*sids = (DOM_SID *)talloc(mem_ctx, sizeof(DOM_SID) *
+                                        num_names)))) {
+               DEBUG(0, ("cli_lsa_lookup_sids(): out of memory\n"));
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+
+       if (!((*types = (uint32 *)talloc(mem_ctx, sizeof(uint32) *
+                                        num_names)))) {
+               DEBUG(0, ("cli_lsa_lookup_sids(): out of memory\n"));
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
 
-               if (sids != NULL && (*sids) != NULL)
-               {
-                       int i;
-                       /* take each name, construct a SID */
-                       for (i = 0; i < (*num_sids); i++)
-                       {
-                               uint32 dom_idx = t_rids[i].rid_idx;
-                               DOM_SID *sid = &(*sids)[i];
-                               if (dom_idx != 0xffffffff)
-                               {
-                                       sid_copy(sid, &ref.ref_dom[dom_idx].ref_dom.sid);
-                               }
-                               else
-                               {
-                                       ZERO_STRUCTP(sid);
-                               }
+       for (i = 0; i < num_names; i++) {
+               DOM_RID2 *t_rids = r.dom_rid;
+               uint32 dom_idx = t_rids[i].rid_idx;
+               uint32 dom_rid = t_rids[i].rid;
+               DOM_SID *sid = &(*sids)[i];
+
+               /* Translate optimised sid through domain index array */
+
+               if (dom_idx != 0xffffffff) {
+
+                       sid_copy(sid, &ref.ref_dom[dom_idx].ref_dom.sid);
+
+                       if (dom_rid != 0xffffffff) {
+                               sid_append_rid(sid, dom_rid);
                        }
+
+                       (*types)[i] = t_rids[i].type;
+               } else {
+                       ZERO_STRUCTP(sid);
+                       (*types)[i] = SID_NAME_UNKNOWN;
                }
        }
 
+ done:
+       prs_mem_free(&qbuf);
        prs_mem_free(&rbuf);
-       prs_mem_free(&buf );
 
-       return valid_response;
+       return result;
 }
 
-/****************************************************************************
-do a LSA Lookup SIDs
-****************************************************************************/
-BOOL lsa_lookup_sids(struct cli_state *cli,
-                       POLICY_HND *hnd,
-                       int num_sids,
-                       DOM_SID **sids,
-                       char ***names,
-                       int *num_names)
+/** Query info policy
+ *
+ *  @param domain_sid - returned remote server's domain sid */
+
+NTSTATUS cli_lsa_query_info_policy(struct cli_state *cli, TALLOC_CTX *mem_ctx,
+                                   POLICY_HND *pol, uint16 info_class, 
+                                   fstring domain_name, DOM_SID *domain_sid)
 {
-       prs_struct rbuf;
-       prs_struct buf; 
-       LSA_Q_LOOKUP_SIDS q_l;
-       BOOL valid_response = False;
+       prs_struct qbuf, rbuf;
+       LSA_Q_QUERY_INFO q;
+       LSA_R_QUERY_INFO r;
+       NTSTATUS result;
 
-       if (hnd == NULL || num_sids == 0 || sids == NULL) return False;
+       ZERO_STRUCT(q);
+       ZERO_STRUCT(r);
 
-       prs_init(&buf , 1024, 4, SAFETY_MARGIN, False);
-       prs_init(&rbuf, 0   , 4, SAFETY_MARGIN, True );
+       /* Initialise parse structures */
 
-       /* create and send a MSRPC command with api LSA_LOOKUP_SIDS */
+       prs_init(&qbuf, MAX_PDU_FRAG_LEN, mem_ctx, MARSHALL);
+       prs_init(&rbuf, 0, mem_ctx, UNMARSHALL);
 
-       DEBUG(4,("LSA Lookup SIDs\n"));
+       /* Marshall data and send request */
 
-       /* store the parameters */
-       make_q_lookup_sids(&q_l, hnd, num_sids, sids, 1);
+       init_q_query(&q, pol, info_class);
 
-       /* turn parameters into data stream */
-       lsa_io_q_lookup_sids("", &q_l, &buf, 0);
+       if (!lsa_io_q_query("", &q, &qbuf, 0) ||
+           !rpc_api_pipe_req(cli, LSA_QUERYINFOPOLICY, &qbuf, &rbuf)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
 
-       /* send the data on \PIPE\ */
-       if (rpc_api_pipe_req(cli, LSA_LOOKUPSIDS, &buf, &rbuf))
-       {
-               LSA_R_LOOKUP_SIDS r_l;
-               DOM_R_REF ref;
-               LSA_TRANS_NAME_ENUM t_names;
-               BOOL p;
+       /* Unmarshall response */
 
-               r_l.dom_ref = &ref;
-               r_l.names   = &t_names;
+       if (!lsa_io_r_query("", &r, &rbuf, 0)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
 
-               lsa_io_r_lookup_sids("", &r_l, &rbuf, 0);
-               p = rbuf.offset != 0;
-               
-               if (p && r_l.status != 0)
-               {
-                       /* report error code */
-                       DEBUG(0,("LSA_LOOKUP_SIDS: %s\n", get_nt_error_msg(r_l.status)));
-                       p = False;
+       if (!NT_STATUS_IS_OK(result = r.status)) {
+               goto done;
+       }
+
+       /* Return output parameters */
+
+       ZERO_STRUCTP(domain_sid);
+       domain_name[0] = '\0';
+
+       switch (info_class) {
+
+       case 3:
+               if (r.dom.id3.buffer_dom_name != 0) {
+                       unistr2_to_ascii(domain_name,
+                                        &r.dom.id3.
+                                        uni_domain_name,
+                                        sizeof (fstring) - 1);
                }
 
-               if (p)
-               {
-                       if (t_names.ptr_trans_names != 0 && ref.undoc_buffer != 0)
-                       {
-                               valid_response = True;
-                       }
+               if (r.dom.id3.buffer_dom_sid != 0) {
+                       *domain_sid = r.dom.id3.dom_sid.sid;
                }
 
-               if (num_names != NULL && valid_response)
-               {
-                       (*num_names) = t_names.num_entries;
+               break;
+
+       case 5:
+               
+               if (r.dom.id5.buffer_dom_name != 0) {
+                       unistr2_to_ascii(domain_name, &r.dom.id5.
+                                        uni_domain_name,
+                                        sizeof (fstring) - 1);
                }
-               if (valid_response)
-               {
-                       int i;
-                       for (i = 0; i < t_names.num_entries; i++)
-                       {
-                               if (t_names.name[i].domain_idx >= ref.num_ref_doms_1)
-                               {
-                                       DEBUG(0,("LSA_LOOKUP_SIDS: domain index out of bounds\n"));
-                                       valid_response = False;
-                                       break;
-                               }
-                       }
+                       
+               if (r.dom.id5.buffer_dom_sid != 0) {
+                       *domain_sid = r.dom.id5.dom_sid.sid;
                }
 
-               if (names != NULL && valid_response && t_names.num_entries != 0)
-               {
-                       (*names) = (char**)malloc((*num_names) * sizeof(char*));
-               }
+               break;
+               
+       default:
+               DEBUG(3, ("unknown info class %d\n", info_class));
+               break;                
+       }
+       
+ done:
+       prs_mem_free(&qbuf);
+       prs_mem_free(&rbuf);
 
-               if (names != NULL && (*names) != NULL)
-               {
-                       int i;
-                       /* take each name, construct a \DOMAIN\name string */
-                       for (i = 0; i < (*num_names); i++)
-                       {
-                               fstring name;
-                               fstring dom_name;
-                               fstring full_name;
-                               uint32 dom_idx = t_names.name[i].domain_idx;
-
-                               if (dom_idx != 0xffffffff)
-                               {
-                                       fstrcpy(dom_name, unistr2_to_str(&ref.ref_dom[dom_idx].uni_dom_name));
-                                       fstrcpy(name    , unistr2_to_str(&t_names.uni_name[i]));
-                                       
-                                       memset(full_name, 0, sizeof(full_name));
-
-                                       slprintf(full_name, sizeof(full_name)-1, "%s\\%s",
-                                                dom_name, name);
-
-                                       (*names)[i] = strdup(full_name);
-                               }
-                               else
-                               {
-                                       (*names)[i] = NULL;
-                               }
-                       }
-               }
+       return result;
+}
+
+/** Query info policy2
+ *
+ *  @param domain_name - returned remote server's domain name
+ *  @param dns_name - returned remote server's dns domain name
+ *  @param forest_name - returned remote server's forest name
+ *  @param domain_guid - returned remote server's domain guid
+ *  @param domain_sid - returned remote server's domain sid */
+
+NTSTATUS cli_lsa_query_info_policy2(struct cli_state *cli, TALLOC_CTX *mem_ctx,
+                                   POLICY_HND *pol, uint16 info_class, 
+                                   fstring domain_name, fstring dns_name,
+                                   fstring forest_name, GUID *domain_guid,
+                                   DOM_SID *domain_sid)
+{
+       prs_struct qbuf, rbuf;
+       LSA_Q_QUERY_INFO2 q;
+       LSA_R_QUERY_INFO2 r;
+       NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
+
+       if (info_class != 12)
+               goto done;
+
+       ZERO_STRUCT(q);
+       ZERO_STRUCT(r);
+
+       /* Initialise parse structures */
+
+       prs_init(&qbuf, MAX_PDU_FRAG_LEN, mem_ctx, MARSHALL);
+       prs_init(&rbuf, 0, mem_ctx, UNMARSHALL);
+
+       /* Marshall data and send request */
+
+       init_q_query2(&q, pol, info_class);
+
+       if (!lsa_io_q_query_info2("", &q, &qbuf, 0) ||
+           !rpc_api_pipe_req(cli, LSA_QUERYINFO2, &qbuf, &rbuf)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+
+       /* Unmarshall response */
+
+       if (!lsa_io_r_query_info2("", &r, &rbuf, 0)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
        }
 
+       if (!NT_STATUS_IS_OK(result = r.status)) {
+               goto done;
+       }
+
+       /* Return output parameters */
+
+       ZERO_STRUCTP(domain_sid);
+       ZERO_STRUCTP(domain_guid);
+       domain_name[0] = '\0';
+
+       if (r.info.dns_dom_info.hdr_nb_dom_name.buffer) {
+               unistr2_to_ascii(domain_name,
+                                &r.info.dns_dom_info.uni_nb_dom_name,
+                                sizeof(fstring) - 1);
+       }
+       if (r.info.dns_dom_info.hdr_dns_dom_name.buffer) {
+               unistr2_to_ascii(dns_name,
+                                &r.info.dns_dom_info.uni_dns_dom_name,
+                                sizeof(fstring) - 1);
+       }
+       if (r.info.dns_dom_info.hdr_forest_name.buffer) {
+               unistr2_to_ascii(forest_name,
+                                &r.info.dns_dom_info.uni_forest_name,
+                                sizeof(fstring) - 1);
+       }
+       
+       memcpy(domain_guid, &r.info.dns_dom_info.dom_guid, sizeof(GUID));
+
+       if (r.info.dns_dom_info.ptr_dom_sid != 0) {
+               *domain_sid = r.info.dns_dom_info.dom_sid.sid;
+       }
+       
+ done:
+       prs_mem_free(&qbuf);
        prs_mem_free(&rbuf);
-       prs_mem_free(&buf );
 
-       return valid_response;
+       return result;
 }
 
-/****************************************************************************
-do a LSA Query Info Policy
-****************************************************************************/
-BOOL lsa_query_info_pol(struct cli_state *cli,
-                       POLICY_HND *hnd, uint16 info_class,
-                       fstring domain_name, DOM_SID *domain_sid)
+/**
+ * Enumerate list of trusted domains
+ *
+ * @param cli client state (cli_state) structure of the connection
+ * @param mem_ctx memory context
+ * @param pol opened lsa policy handle
+ * @param enum_ctx enumeration context ie. index of first returned domain entry
+ * @param pref_num_domains preferred max number of entries returned in one response
+ * @param num_domains total number of trusted domains returned by response
+ * @param domain_names returned trusted domain names
+ * @param domain_sids returned trusted domain sids
+ *
+ * @return nt status code of response
+ **/
+
+NTSTATUS cli_lsa_enum_trust_dom(struct cli_state *cli, TALLOC_CTX *mem_ctx,
+                                POLICY_HND *pol, uint32 *enum_ctx, 
+                                uint32 *num_domains,
+                                char ***domain_names, DOM_SID **domain_sids)
 {
-       prs_struct rbuf;
-       prs_struct buf; 
-       LSA_Q_QUERY_INFO q_q;
-       BOOL valid_response = False;
+       prs_struct qbuf, rbuf;
+       LSA_Q_ENUM_TRUST_DOM q;
+       LSA_R_ENUM_TRUST_DOM r;
+       NTSTATUS result;
+       int i;
 
-       ZERO_STRUCTP(domain_sid);
-       domain_name[0] = 0;
+       ZERO_STRUCT(q);
+       ZERO_STRUCT(r);
+
+       /* Initialise parse structures */
 
-       if (hnd == NULL || domain_name == NULL || domain_sid == NULL) return False;
+       prs_init(&qbuf, MAX_PDU_FRAG_LEN, mem_ctx, MARSHALL);
+       prs_init(&rbuf, 0, mem_ctx, UNMARSHALL);
 
-       prs_init(&buf , 1024, 4, SAFETY_MARGIN, False);
-       prs_init(&rbuf, 0   , 4, SAFETY_MARGIN, True );
+       /* Marshall data and send request */
 
-       /* create and send a MSRPC command with api LSA_QUERYINFOPOLICY */
+       /* 64k is enough for about 2000 trusted domains */
+        init_q_enum_trust_dom(&q, pol, *enum_ctx, 0x10000);
 
-       DEBUG(4,("LSA Query Info Policy\n"));
+       if (!lsa_io_q_enum_trust_dom("", &q, &qbuf, 0) ||
+           !rpc_api_pipe_req(cli, LSA_ENUMTRUSTDOM, &qbuf, &rbuf)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+
+       /* Unmarshall response */
 
-       /* store the parameters */
-       make_q_query(&q_q, hnd, info_class);
+       if (!lsa_io_r_enum_trust_dom("", &r, &rbuf, 0)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
 
-       /* turn parameters into data stream */
-       lsa_io_q_query("", &q_q, &buf, 0);
+       result = r.status;
 
-       /* send the data on \PIPE\ */
-       if (rpc_api_pipe_req(cli, LSA_QUERYINFOPOLICY, &buf, &rbuf))
-       {
-               LSA_R_QUERY_INFO r_q;
-               BOOL p;
+       if (!NT_STATUS_IS_OK(result) &&
+           !NT_STATUS_EQUAL(result, NT_STATUS_NO_MORE_ENTRIES) &&
+           !NT_STATUS_EQUAL(result, STATUS_MORE_ENTRIES)) {
 
-               lsa_io_r_query("", &r_q, &rbuf, 0);
-               p = rbuf.offset != 0;
-               
-               if (p && r_q.status != 0)
-               {
-                       /* report error code */
-                       DEBUG(0,("LSA_QUERYINFOPOLICY: %s\n", get_nt_error_msg(r_q.status)));
-                       p = False;
+               /* An actual error ocured */
+
+               goto done;
+       }
+
+       /* Return output parameters */
+
+       if (r.num_domains) {
+
+               /* Allocate memory for trusted domain names and sids */
+
+               *domain_names = (char **)talloc(mem_ctx, sizeof(char *) *
+                                               r.num_domains);
+
+               if (!*domain_names) {
+                       DEBUG(0, ("cli_lsa_enum_trust_dom(): out of memory\n"));
+                       result = NT_STATUS_NO_MEMORY;
+                       goto done;
                }
 
-               if (p && r_q.info_class != q_q.info_class)
-               {
-                       /* report different info classes */
-                       DEBUG(0,("LSA_QUERYINFOPOLICY: error info_class (q,r) differ - (%x,%x)\n",
-                                       q_q.info_class, r_q.info_class));
-                       p = False;
+               *domain_sids = (DOM_SID *)talloc(mem_ctx, sizeof(DOM_SID) *
+                                                r.num_domains);
+               if (!domain_sids) {
+                       DEBUG(0, ("cli_lsa_enum_trust_dom(): out of memory\n"));
+                       result = NT_STATUS_NO_MEMORY;
+                       goto done;
                }
 
-               if (p)
-               {
-                       fstring sid_str;
-                       /* ok, at last: we're happy. */
-                       switch (r_q.info_class)
-                       {
-                               case 3:
-                               {
-                                       if (r_q.dom.id3.buffer_dom_name != 0)
-                                       {
-                                               char *dom_name = unistrn2(r_q.dom.id3.uni_domain_name.buffer,
-                                                                         r_q.dom.id3.uni_domain_name.uni_str_len);
-                                               fstrcpy(domain_name, dom_name);
-                                       }
-                                       if (r_q.dom.id3.buffer_dom_sid != 0)
-                                       {
-                                               *domain_sid = r_q.dom.id3.dom_sid.sid;
-                                       }
-
-                                       valid_response = True;
-                                       break;
-                               }
-                               case 5:
-                               {
-                                       if (r_q.dom.id5.buffer_dom_name != 0)
-                                       {
-                                               char *dom_name = unistrn2(r_q.dom.id5.uni_domain_name.buffer,
-                                                                         r_q.dom.id5.uni_domain_name.uni_str_len);
-                                               fstrcpy(domain_name, dom_name);
-                                       }
-                                       if (r_q.dom.id5.buffer_dom_sid != 0)
-                                       {
-                                               *domain_sid = r_q.dom.id5.dom_sid.sid;
-                                       }
-
-                                       valid_response = True;
-                                       break;
-                               }
-                               default:
-                               {
-                                       DEBUG(3,("LSA_QUERYINFOPOLICY: unknown info class\n"));
-                                       domain_name[0] = 0;
-
-                                       break;
-                               }
-                       }
-               
-                       sid_to_string(sid_str, domain_sid);
-                       DEBUG(3,("LSA_QUERYINFOPOLICY (level %x): domain:%s  domain sid:%s\n",
-                                 r_q.info_class, domain_name, sid_str));
+               /* Copy across names and sids */
+
+               for (i = 0; i < r.num_domains; i++) {
+                       fstring tmp;
+
+                       unistr2_to_ascii(tmp, &r.uni_domain_name[i], 
+                                        sizeof(tmp) - 1);
+                       (*domain_names)[i] = talloc_strdup(mem_ctx, tmp);
+                       sid_copy(&(*domain_sids)[i], &r.domain_sid[i].sid);
                }
        }
 
+       *num_domains = r.num_domains;
+       *enum_ctx = r.enum_context;
+
+ done:
+       prs_mem_free(&qbuf);
        prs_mem_free(&rbuf);
-       prs_mem_free(&buf );
 
-       return valid_response;
+       return result;
 }
 
-/****************************************************************************
-do a LSA Close
-****************************************************************************/
-BOOL lsa_close(struct cli_state *cli, POLICY_HND *hnd)
+
+/** Enumerate privileges*/
+
+NTSTATUS cli_lsa_enum_privilege(struct cli_state *cli, TALLOC_CTX *mem_ctx,
+                                POLICY_HND *pol, uint32 *enum_context, uint32 pref_max_length,
+                               uint32 *count, char ***privs_name, uint32 **privs_high, uint32 **privs_low)
 {
-       prs_struct rbuf;
-       prs_struct buf; 
-       LSA_Q_CLOSE q_c;
-    BOOL valid_close = False;
+       prs_struct qbuf, rbuf;
+       LSA_Q_ENUM_PRIVS q;
+       LSA_R_ENUM_PRIVS r;
+       NTSTATUS result;
+       int i;
+
+       ZERO_STRUCT(q);
+       ZERO_STRUCT(r);
 
-       if (hnd == NULL) return False;
+       /* Initialise parse structures */
 
-       /* create and send a MSRPC command with api LSA_OPENPOLICY */
+       prs_init(&qbuf, MAX_PDU_FRAG_LEN, mem_ctx, MARSHALL);
+       prs_init(&rbuf, 0, mem_ctx, UNMARSHALL);
 
-       prs_init(&buf , 1024, 4, SAFETY_MARGIN, False);
-       prs_init(&rbuf, 0   , 4, SAFETY_MARGIN, True );
+       /* Marshall data and send request */
 
-       DEBUG(4,("LSA Close\n"));
+       init_q_enum_privs(&q, pol, *enum_context, pref_max_length);
 
-       /* store the parameters */
-       make_lsa_q_close(&q_c, hnd);
+       if (!lsa_io_q_enum_privs("", &q, &qbuf, 0) ||
+           !rpc_api_pipe_req(cli, LSA_ENUM_PRIVS, &qbuf, &rbuf)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
 
-       /* turn parameters into data stream */
-       lsa_io_q_close("", &q_c, &buf, 0);
+       /* Unmarshall response */
 
-       /* send the data on \PIPE\ */
-       if (rpc_api_pipe_req(cli, LSA_CLOSE, &buf, &rbuf))
-       {
-               LSA_R_CLOSE r_c;
-               BOOL p;
+       if (!lsa_io_r_enum_privs("", &r, &rbuf, 0)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
 
-               lsa_io_r_close("", &r_c, &rbuf, 0);
-               p = rbuf.offset != 0;
+       if (!NT_STATUS_IS_OK(result = r.status)) {
+               goto done;
+       }
 
-               if (p && r_c.status != 0)
-               {
-                       /* report error code */
-                       DEBUG(0,("LSA_CLOSE: %s\n", get_nt_error_msg(r_c.status)));
-                       p = False;
-               }
+       /* Return output parameters */
 
-               if (p)
-               {
-                       /* check that the returned policy handle is all zeros */
-                       int i;
-                       valid_close = True;
-
-                       for (i = 0; i < sizeof(r_c.pol.data); i++)
-                       {
-                               if (r_c.pol.data[i] != 0)
-                               {
-                                       valid_close = False;
-                                       break;
-                               }
-                       }       
-                       if (!valid_close)
-                       {
-                               DEBUG(0,("LSA_CLOSE: non-zero handle returned\n"));
-                       }
-               }
+       *enum_context = r.enum_context;
+       *count = r.count;
+
+       if (!((*privs_name = (char **)talloc(mem_ctx, sizeof(char *) * r.count)))) {
+               DEBUG(0, ("(cli_lsa_enum_privilege): out of memory\n"));
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+
+       if (!((*privs_high = (uint32 *)talloc(mem_ctx, sizeof(uint32) * r.count)))) {
+               DEBUG(0, ("(cli_lsa_enum_privilege): out of memory\n"));
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+
+       if (!((*privs_low = (uint32 *)talloc(mem_ctx, sizeof(uint32) * r.count)))) {
+               DEBUG(0, ("(cli_lsa_enum_privilege): out of memory\n"));
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+
+       for (i = 0; i < r.count; i++) {
+               fstring name;
+
+               rpcstr_pull_unistr2_fstring( name, &r.privs[i].name);
+
+               (*privs_name)[i] = talloc_strdup(mem_ctx, name);
+
+               (*privs_high)[i] = r.privs[i].luid_high;
+               (*privs_low)[i] = r.privs[i].luid_low;
+       }
+
+ done:
+       prs_mem_free(&qbuf);
+       prs_mem_free(&rbuf);
+
+       return result;
+}
+
+/** Get privilege name */
+
+NTSTATUS cli_lsa_get_dispname(struct cli_state *cli, TALLOC_CTX *mem_ctx,
+                             POLICY_HND *pol, const char *name, 
+                             uint16 lang_id, uint16 lang_id_sys,
+                             fstring description, uint16 *lang_id_desc)
+{
+       prs_struct qbuf, rbuf;
+       LSA_Q_PRIV_GET_DISPNAME q;
+       LSA_R_PRIV_GET_DISPNAME r;
+       NTSTATUS result;
+
+       ZERO_STRUCT(q);
+       ZERO_STRUCT(r);
+
+       /* Initialise parse structures */
+
+       prs_init(&qbuf, MAX_PDU_FRAG_LEN, mem_ctx, MARSHALL);
+       prs_init(&rbuf, 0, mem_ctx, UNMARSHALL);
+
+       /* Marshall data and send request */
+
+       init_lsa_priv_get_dispname(&q, pol, name, lang_id, lang_id_sys);
+
+       if (!lsa_io_q_priv_get_dispname("", &q, &qbuf, 0) ||
+           !rpc_api_pipe_req(cli, LSA_PRIV_GET_DISPNAME, &qbuf, &rbuf)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+
+       /* Unmarshall response */
+
+       if (!lsa_io_r_priv_get_dispname("", &r, &rbuf, 0)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+
+       if (!NT_STATUS_IS_OK(result = r.status)) {
+               goto done;
+       }
+
+       /* Return output parameters */
+       
+       rpcstr_pull_unistr2_fstring(description , &r.desc);
+       *lang_id_desc = r.lang_id;
+
+ done:
+       prs_mem_free(&qbuf);
+       prs_mem_free(&rbuf);
+
+       return result;
+}
+
+/** Enumerate list of SIDs  */
+
+NTSTATUS cli_lsa_enum_sids(struct cli_state *cli, TALLOC_CTX *mem_ctx,
+                                POLICY_HND *pol, uint32 *enum_ctx, uint32 pref_max_length, 
+                                uint32 *num_sids, DOM_SID **sids)
+{
+       prs_struct qbuf, rbuf;
+       LSA_Q_ENUM_ACCOUNTS q;
+       LSA_R_ENUM_ACCOUNTS r;
+       NTSTATUS result;
+       int i;
+
+       ZERO_STRUCT(q);
+       ZERO_STRUCT(r);
+
+       /* Initialise parse structures */
+
+       prs_init(&qbuf, MAX_PDU_FRAG_LEN, mem_ctx, MARSHALL);
+       prs_init(&rbuf, 0, mem_ctx, UNMARSHALL);
+
+       /* Marshall data and send request */
+
+        init_lsa_q_enum_accounts(&q, pol, *enum_ctx, pref_max_length);
+
+       if (!lsa_io_q_enum_accounts("", &q, &qbuf, 0) ||
+           !rpc_api_pipe_req(cli, LSA_ENUM_ACCOUNTS, &qbuf, &rbuf)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+
+       /* Unmarshall response */
+
+       if (!lsa_io_r_enum_accounts("", &r, &rbuf, 0)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+
+       result = r.status;
+
+       if (!NT_STATUS_IS_OK(result = r.status)) {
+               goto done;
+       }
+
+       if (r.sids.num_entries==0)
+               goto done;
+
+       /* Return output parameters */
+
+       *sids = (DOM_SID *)talloc(mem_ctx, sizeof(DOM_SID) * r.sids.num_entries);
+       if (!*sids) {
+               DEBUG(0, ("(cli_lsa_enum_sids): out of memory\n"));
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+
+       /* Copy across names and sids */
+
+       for (i = 0; i < r.sids.num_entries; i++) {
+               sid_copy(&(*sids)[i], &r.sids.sid[i].sid);
+       }
+
+       *num_sids= r.sids.num_entries;
+       *enum_ctx = r.enum_context;
+
+ done:
+       prs_mem_free(&qbuf);
+       prs_mem_free(&rbuf);
+
+       return result;
+}
+
+/** Open a LSA user handle
+ *
+ * @param cli Handle on an initialised SMB connection */
+
+NTSTATUS cli_lsa_open_account(struct cli_state *cli, TALLOC_CTX *mem_ctx,
+                             POLICY_HND *dom_pol, DOM_SID *sid, uint32 des_access, 
+                            POLICY_HND *user_pol)
+{
+       prs_struct qbuf, rbuf;
+       LSA_Q_OPENACCOUNT q;
+       LSA_R_OPENACCOUNT r;
+       NTSTATUS result;
+
+       ZERO_STRUCT(q);
+       ZERO_STRUCT(r);
+
+       /* Initialise parse structures */
+
+       prs_init(&qbuf, MAX_PDU_FRAG_LEN, mem_ctx, MARSHALL);
+       prs_init(&rbuf, 0, mem_ctx, UNMARSHALL);
+
+       /* Initialise input parameters */
+
+       init_lsa_q_open_account(&q, dom_pol, sid, des_access);
+
+       /* Marshall data and send request */
+
+       if (!lsa_io_q_open_account("", &q, &qbuf, 0) ||
+           !rpc_api_pipe_req(cli, LSA_OPENACCOUNT, &qbuf, &rbuf)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+
+       /* Unmarshall response */
+
+       if (!lsa_io_r_open_account("", &r, &rbuf, 0)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+
+       /* Return output parameters */
+
+       if (NT_STATUS_IS_OK(result = r.status)) {
+               *user_pol = r.pol;
+       }
+
+ done:
+       prs_mem_free(&qbuf);
+       prs_mem_free(&rbuf);
+
+       return result;
+}
+
+/** Enumerate user privileges
+ *
+ * @param cli Handle on an initialised SMB connection */
+
+NTSTATUS cli_lsa_enum_privsaccount(struct cli_state *cli, TALLOC_CTX *mem_ctx,
+                             POLICY_HND *pol, uint32 *count, LUID_ATTR **set)
+{
+       prs_struct qbuf, rbuf;
+       LSA_Q_ENUMPRIVSACCOUNT q;
+       LSA_R_ENUMPRIVSACCOUNT r;
+       NTSTATUS result;
+       int i;
+
+       ZERO_STRUCT(q);
+       ZERO_STRUCT(r);
+
+       /* Initialise parse structures */
+
+       prs_init(&qbuf, MAX_PDU_FRAG_LEN, mem_ctx, MARSHALL);
+       prs_init(&rbuf, 0, mem_ctx, UNMARSHALL);
+
+       /* Initialise input parameters */
+
+       init_lsa_q_enum_privsaccount(&q, pol);
+
+       /* Marshall data and send request */
+
+       if (!lsa_io_q_enum_privsaccount("", &q, &qbuf, 0) ||
+           !rpc_api_pipe_req(cli, LSA_ENUMPRIVSACCOUNT, &qbuf, &rbuf)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+
+       /* Unmarshall response */
+
+       if (!lsa_io_r_enum_privsaccount("", &r, &rbuf, 0)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+
+       /* Return output parameters */
+
+       if (!NT_STATUS_IS_OK(result = r.status)) {
+               goto done;
+       }
+
+       if (r.count == 0)
+               goto done;
+
+       if (!((*set = (LUID_ATTR *)talloc(mem_ctx, sizeof(LUID_ATTR) * r.count)))) {
+               DEBUG(0, ("(cli_lsa_enum_privsaccount): out of memory\n"));
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+
+       for (i=0; i<r.count; i++) {
+               (*set)[i].luid.low = r.set.set[i].luid.low;
+               (*set)[i].luid.high = r.set.set[i].luid.high;
+               (*set)[i].attr = r.set.set[i].attr;
+       }
+
+       *count=r.count;
+ done:
+       prs_mem_free(&qbuf);
+       prs_mem_free(&rbuf);
+
+       return result;
+}
+
+/** Get a privilege value given its name */
+
+NTSTATUS cli_lsa_lookupprivvalue(struct cli_state *cli, TALLOC_CTX *mem_ctx,
+                                POLICY_HND *pol, const char *name, LUID *luid)
+{
+       prs_struct qbuf, rbuf;
+       LSA_Q_LOOKUPPRIVVALUE q;
+       LSA_R_LOOKUPPRIVVALUE r;
+       NTSTATUS result;
+
+       ZERO_STRUCT(q);
+       ZERO_STRUCT(r);
+
+       /* Initialise parse structures */
+
+       prs_init(&qbuf, MAX_PDU_FRAG_LEN, mem_ctx, MARSHALL);
+       prs_init(&rbuf, 0, mem_ctx, UNMARSHALL);
+
+       /* Marshall data and send request */
+
+       init_lsa_q_lookupprivvalue(&q, pol, name);
+
+       if (!lsa_io_q_lookupprivvalue("", &q, &qbuf, 0) ||
+           !rpc_api_pipe_req(cli, LSA_LOOKUPPRIVVALUE, &qbuf, &rbuf)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+
+       /* Unmarshall response */
+
+       if (!lsa_io_r_lookupprivvalue("", &r, &rbuf, 0)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+
+       if (!NT_STATUS_IS_OK(result = r.status)) {
+               goto done;
+       }
+
+       /* Return output parameters */
+
+       (*luid).low=r.luid.low;
+       (*luid).high=r.luid.high;
+
+ done:
+       prs_mem_free(&qbuf);
+       prs_mem_free(&rbuf);
+
+       return result;
+}
+
+/** Query LSA security object */
+
+NTSTATUS cli_lsa_query_secobj(struct cli_state *cli, TALLOC_CTX *mem_ctx,
+                             POLICY_HND *pol, uint32 sec_info, 
+                             SEC_DESC_BUF **psdb)
+{
+       prs_struct qbuf, rbuf;
+       LSA_Q_QUERY_SEC_OBJ q;
+       LSA_R_QUERY_SEC_OBJ r;
+       NTSTATUS result;
+
+       ZERO_STRUCT(q);
+       ZERO_STRUCT(r);
+
+       /* Initialise parse structures */
+
+       prs_init(&qbuf, MAX_PDU_FRAG_LEN, mem_ctx, MARSHALL);
+       prs_init(&rbuf, 0, mem_ctx, UNMARSHALL);
+
+       /* Marshall data and send request */
+
+       init_q_query_sec_obj(&q, pol, sec_info);
+
+       if (!lsa_io_q_query_sec_obj("", &q, &qbuf, 0) ||
+           !rpc_api_pipe_req(cli, LSA_QUERYSECOBJ, &qbuf, &rbuf)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+
+       /* Unmarshall response */
+
+       if (!lsa_io_r_query_sec_obj("", &r, &rbuf, 0)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+
+       if (!NT_STATUS_IS_OK(result = r.status)) {
+               goto done;
        }
 
+       /* Return output parameters */
+
+       if (psdb)
+               *psdb = r.buf;
+
+ done:
+       prs_mem_free(&qbuf);
        prs_mem_free(&rbuf);
-       prs_mem_free(&buf );
 
-       return valid_close;
+       return result;
+}
+
+
+/* Enumerate account rights This is similar to enum_privileges but
+   takes a SID directly, avoiding the open_account call.
+*/
+
+NTSTATUS cli_lsa_enum_account_rights(struct cli_state *cli, TALLOC_CTX *mem_ctx,
+                                    POLICY_HND *pol, DOM_SID sid,
+                                    uint32 *count, char ***privs_name)
+{
+       prs_struct qbuf, rbuf;
+       LSA_Q_ENUM_ACCT_RIGHTS q;
+       LSA_R_ENUM_ACCT_RIGHTS r;
+       NTSTATUS result;
+       int i;
+
+       ZERO_STRUCT(q);
+       ZERO_STRUCT(r);
+
+       /* Initialise parse structures */
+
+       prs_init(&qbuf, MAX_PDU_FRAG_LEN, mem_ctx, MARSHALL);
+       prs_init(&rbuf, 0, mem_ctx, UNMARSHALL);
+
+       /* Marshall data and send request */
+       init_q_enum_acct_rights(&q, pol, 2, &sid);
+
+       if (!lsa_io_q_enum_acct_rights("", &q, &qbuf, 0) ||
+           !rpc_api_pipe_req(cli, LSA_ENUMACCTRIGHTS, &qbuf, &rbuf)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+
+       if (!lsa_io_r_enum_acct_rights("", &r, &rbuf, 0)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+
+       if (!NT_STATUS_IS_OK(result = r.status)) {
+               goto done;
+       }
+
+       *count = r.count;
+       if (! *count) {
+               goto done;
+       }
+
+       *privs_name = (char **)talloc(mem_ctx, (*count) * sizeof(char **));
+       for (i=0;i<*count;i++) {
+               pull_ucs2_talloc(mem_ctx, &(*privs_name)[i], r.rights.strings[i].string.buffer);
+       }
+
+done:
+
+       return result;
+}
+
+
+
+/* add account rights to an account. */
+
+NTSTATUS cli_lsa_add_account_rights(struct cli_state *cli, TALLOC_CTX *mem_ctx,
+                                   POLICY_HND *pol, DOM_SID sid,
+                                   uint32 count, const char **privs_name)
+{
+       prs_struct qbuf, rbuf;
+       LSA_Q_ADD_ACCT_RIGHTS q;
+       LSA_R_ADD_ACCT_RIGHTS r;
+       NTSTATUS result;
+
+       ZERO_STRUCT(q);
+
+       /* Initialise parse structures */
+       prs_init(&qbuf, MAX_PDU_FRAG_LEN, mem_ctx, MARSHALL);
+       prs_init(&rbuf, 0, mem_ctx, UNMARSHALL);
+
+       /* Marshall data and send request */
+       init_q_add_acct_rights(&q, pol, &sid, count, privs_name);
+
+       if (!lsa_io_q_add_acct_rights("", &q, &qbuf, 0) ||
+           !rpc_api_pipe_req(cli, LSA_ADDACCTRIGHTS, &qbuf, &rbuf)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+
+       /* Unmarshall response */
+
+       if (!lsa_io_r_add_acct_rights("", &r, &rbuf, 0)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+
+       if (!NT_STATUS_IS_OK(result = r.status)) {
+               goto done;
+       }
+done:
+
+       return result;
+}
+
+
+/* remove account rights for an account. */
+
+NTSTATUS cli_lsa_remove_account_rights(struct cli_state *cli, TALLOC_CTX *mem_ctx,
+                                      POLICY_HND *pol, DOM_SID sid, BOOL removeall,
+                                      uint32 count, const char **privs_name)
+{
+       prs_struct qbuf, rbuf;
+       LSA_Q_REMOVE_ACCT_RIGHTS q;
+       LSA_R_REMOVE_ACCT_RIGHTS r;
+       NTSTATUS result;
+
+       ZERO_STRUCT(q);
+
+       /* Initialise parse structures */
+       prs_init(&qbuf, MAX_PDU_FRAG_LEN, mem_ctx, MARSHALL);
+       prs_init(&rbuf, 0, mem_ctx, UNMARSHALL);
+
+       /* Marshall data and send request */
+       init_q_remove_acct_rights(&q, pol, &sid, removeall?1:0, count, privs_name);
+
+       if (!lsa_io_q_remove_acct_rights("", &q, &qbuf, 0) ||
+           !rpc_api_pipe_req(cli, LSA_REMOVEACCTRIGHTS, &qbuf, &rbuf)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+
+       /* Unmarshall response */
+
+       if (!lsa_io_r_remove_acct_rights("", &r, &rbuf, 0)) {
+               result = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+
+       if (!NT_STATUS_IS_OK(result = r.status)) {
+               goto done;
+       }
+done:
+
+       return result;
 }
 
 
+#if 0
+
+/** An example of how to use the routines in this file.  Fetch a DOMAIN
+    sid. Does complete cli setup / teardown anonymously. */
+
+BOOL fetch_domain_sid( char *domain, char *remote_machine, DOM_SID *psid)
+{
+       extern pstring global_myname;
+       struct cli_state cli;
+       NTSTATUS result;
+       POLICY_HND lsa_pol;
+       BOOL ret = False;
+       ZERO_STRUCT(cli);
+       if(cli_initialise(&cli) == False) {
+               DEBUG(0,("fetch_domain_sid: unable to initialize client connection.\n"));
+               return False;
+       }
+       if(!resolve_name( remote_machine, &cli.dest_ip, 0x20)) {
+               DEBUG(0,("fetch_domain_sid: Can't resolve address for %s\n", remote_machine));
+               goto done;
+       }
+       if (!cli_connect(&cli, remote_machine, &cli.dest_ip)) {
+               DEBUG(0,("fetch_domain_sid: unable to connect to SMB server on \
+machine %s. Error was : %s.\n", remote_machine, cli_errstr(&cli) ));
+               goto done;
+       }
+
+       if (!attempt_netbios_session_request(&cli, global_myname, remote_machine, &cli.dest_ip)) {
+               DEBUG(0,("fetch_domain_sid: machine %s rejected the NetBIOS session request.\n", 
+                       remote_machine));
+               goto done;
+       }
+       cli.protocol = PROTOCOL_NT1;
+       if (!cli_negprot(&cli)) {
+               DEBUG(0,("fetch_domain_sid: machine %s rejected the negotiate protocol. \
+Error was : %s.\n", remote_machine, cli_errstr(&cli) ));
+               goto done;
+       }
+       if (cli.protocol != PROTOCOL_NT1) {
+               DEBUG(0,("fetch_domain_sid: machine %s didn't negotiate NT protocol.\n",
+                       remote_machine));
+               goto done;
+       }
+       /*
+        * Do an anonymous session setup.
+        */
+       if (!cli_session_setup(&cli, "", "", 0, "", 0, "")) {
+               DEBUG(0,("fetch_domain_sid: machine %s rejected the session setup. \
+Error was : %s.\n", remote_machine, cli_errstr(&cli) ));
+               goto done;
+       }
+       if (!(cli.sec_mode & NEGOTIATE_SECURITY_USER_LEVEL)) {
+               DEBUG(0,("fetch_domain_sid: machine %s isn't in user level security mode\n",
+                       remote_machine));
+               goto done;
+       }
+
+       if (!cli_send_tconX(&cli, "IPC$", "IPC", "", 1)) {
+               DEBUG(0,("fetch_domain_sid: machine %s rejected the tconX on the IPC$ share. \
+Error was : %s.\n", remote_machine, cli_errstr(&cli) ));
+               goto done;
+       }
+
+       /* Fetch domain sid */
+       if (!cli_nt_session_open(&cli, PI_LSARPC)) {
+               DEBUG(0, ("fetch_domain_sid: Error connecting to SAM pipe\n"));
+               goto done;
+       }
+       result = cli_lsa_open_policy(&cli, cli.mem_ctx, True, SEC_RIGHTS_QUERY_VALUE, &lsa_pol);
+       if (!NT_STATUS_IS_OK(result)) {
+               DEBUG(0, ("fetch_domain_sid: Error opening lsa policy handle. %s\n",
+                       nt_errstr(result) ));
+               goto done;
+       }
+       result = cli_lsa_query_info_policy(&cli, cli.mem_ctx, &lsa_pol, 5, domain, psid);
+       if (!NT_STATUS_IS_OK(result)) {
+               DEBUG(0, ("fetch_domain_sid: Error querying lsa policy handle. %s\n",
+                       nt_errstr(result) ));
+               goto done;
+       }
+       ret = True;
+
+  done:
+
+       cli_shutdown(&cli);
+       return ret;
+}
+
+#endif
+
+/** @} **/