Revert "Make use of smbd_gpfs_get_realfilename_path in unix_convert"

[kai/samba.git] / source3 / modules / gpfs.c

diff --git a/source3/modules/gpfs.c b/source3/modules/gpfs.c
index a0d33fa33a0c1919a0dcfe38691b2c1856f9b1b8..c4b2518e0218e5cb557911d93a8fa9bc453be685 100644 (file)
--- a/source3/modules/gpfs.c
+++ b/source3/modules/gpfs.c
@@ -24,7 +24,6 @@
 #include "gpfs_gpl.h"
 #include "vfs_gpfs.h"
 
-static void *libgpfs_handle = NULL;
 static bool gpfs_share_modes;
 static bool gpfs_leases;
 
@@ -44,7 +43,7 @@ bool set_gpfs_sharemode(files_struct *fsp, uint32 access_mask,
        if (!gpfs_share_modes) {
                return True;
        }
-       
+
        if (gpfs_set_share_fn == NULL) {
                return False;
        }
@@ -105,7 +104,7 @@ int set_gpfs_lease(int fd, int leasetype)
        if (leasetype == F_WRLCK) {
                gpfs_type = GPFS_LEASE_WRITE;
        }
-       
+
        /* we unconditionally set CAP_LEASE, rather than looking for
           -1/EACCES as there is a bug in some versions of
           libgpfs_gpl.so which results in a leaked fd on /dev/ss0
@@ -135,65 +134,64 @@ int smbd_gpfs_putacl(char *pathname, int flags, void *acl)
        return gpfs_putacl_fn(pathname, flags, acl);
 }
 
-void init_gpfs(void)
+static bool init_gpfs_function_lib(void *plibhandle_pointer,
+                                  const char *libname,
+                                  void *pfn_pointer, const char *fn_name)
 {
-       if (libgpfs_handle != NULL) {
-               return;
-       }
-
-       libgpfs_handle = dlopen("libgpfs_gpl.so", RTLD_LAZY);
-
-       if (libgpfs_handle == NULL) {
-               DEBUG(10, ("dlopen for libgpfs_gpl failed: %s\n",
-                          strerror(errno)));
-               return;
+       bool did_open_here = false;
+       void **libhandle_pointer = (void **)plibhandle_pointer;
+       void **fn_pointer = (void **)pfn_pointer;
+
+       if (*libhandle_pointer == NULL) {
+               *libhandle_pointer = sys_dlopen(libname, RTLD_LAZY);
+               did_open_here = true;
+       }
+       if (*libhandle_pointer == NULL) {
+               DEBUG(10, ("Could not open lib %s\n", libname));
+               return false;
+       }
+
+       *fn_pointer = sys_dlsym(*libhandle_pointer, fn_name);
+       if (*fn_pointer == NULL) {
+               DEBUG(10, ("Did not find symbol %s in lib %s\n",
+                          fn_name, libname));
+               if (did_open_here) {
+                       sys_dlclose(*libhandle_pointer);
+                       *libhandle_pointer = NULL;
+               }
+               return false;
        }
 
-       DEBUG(10, ("libgpfs_gpl.so loaded\n"));
-
-       gpfs_set_share_fn = dlsym(libgpfs_handle, "gpfs_set_share");
-       if (gpfs_set_share_fn == NULL) {
-               DEBUG(3, ("libgpfs_gpl.so does not contain the symbol "
-                         "'gpfs_set_share'\n"));
-               goto failed;
-       }
+       return true;
+}
 
-       gpfs_set_lease_fn = dlsym(libgpfs_handle, "gpfs_set_lease");
-       if (gpfs_set_lease_fn == NULL) {
-               DEBUG(3, ("libgpfs_gpl.so does not contain the symbol "
-                         "'gpfs_set_lease'\n"));
-               dlclose(libgpfs_handle);
+static bool init_gpfs_function(void *fn_pointer, const char *fn_name)
+{
+       static void *libgpfs_handle = NULL;
+       static void *libgpfs_gpl_handle = NULL;
 
-               goto failed;
+       if (init_gpfs_function_lib(&libgpfs_handle, "libgpfs.so",
+                                  fn_pointer, fn_name)) {
+               return true;
        }
-
-       gpfs_getacl_fn = dlsym(libgpfs_handle, "gpfs_getacl");
-       if (gpfs_getacl_fn == NULL) {
-               DEBUG(3, ("libgpfs_gpl.so does not contain the symbol "
-                         "'gpfs_getacl'\n"));
-               goto failed;
+       if (init_gpfs_function_lib(&libgpfs_gpl_handle, "libgpfs_gpl.so",
+                                  fn_pointer, fn_name)) {
+               return true;
        }
+       return false;
+}
 
-       gpfs_putacl_fn = dlsym(libgpfs_handle, "gpfs_putacl");
-       if (gpfs_putacl_fn == NULL) {
-               DEBUG(3, ("libgpfs_gpl.so does not contain the symbol "
-                         "'gpfs_putacl'\n"));
-               goto failed;
-       }
+void init_gpfs(void)
+{
+       init_gpfs_function(&gpfs_set_share_fn, "gpfs_set_share");
+       init_gpfs_function(&gpfs_set_lease_fn, "gpfs_set_lease");
+       init_gpfs_function(&gpfs_getacl_fn, "gpfs_getacl");
+       init_gpfs_function(&gpfs_putacl_fn, "gpfs_putacl");
 
        gpfs_share_modes = lp_parm_bool(-1, "gpfs", "sharemodes", True);
        gpfs_leases      = lp_parm_bool(-1, "gpfs", "leases", True);
 
        return;
-
-failed:
-       dlclose(libgpfs_handle);
-       /* leave libgpfs_handle != NULL around, no point
-          in trying twice */
-       gpfs_set_share_fn = NULL;
-       gpfs_set_lease_fn = NULL;
-       gpfs_getacl_fn = NULL;
-       gpfs_putacl_fn = NULL;
 }
 
 #else