r16945: Sync trunk -> 3.0 for 3.0.24 code. Still need
[kai/samba.git] / source3 / libsmb / trusts_util.c
index 77e63709aac304a2375c00288d79d3c59ed453b8..e4061883eb1f96c3064040e8e4412298b11a37ff 100644 (file)
  Caller must have the cli connected to the netlogon pipe
  already.
 **********************************************************/
-static NTSTATUS just_change_the_password(struct cli_state *cli, TALLOC_CTX *mem_ctx, 
-                                        unsigned char orig_trust_passwd_hash[16],
-                                        unsigned char new_trust_passwd_hash[16],
+
+static NTSTATUS just_change_the_password(struct rpc_pipe_client *cli, TALLOC_CTX *mem_ctx, 
+                                        const unsigned char orig_trust_passwd_hash[16],
+                                        const unsigned char new_trust_passwd_hash[16],
                                         uint32 sec_channel_type)
 {
        NTSTATUS result;
-       uint32 neg_flags = 0x000001ff;
 
-       result = cli_nt_setup_creds(cli, sec_channel_type, orig_trust_passwd_hash, &neg_flags, 2);
-       
-       if (!NT_STATUS_IS_OK(result)) {
-               DEBUG(3,("just_change_the_password: unable to setup creds (%s)!\n",
-                        nt_errstr(result)));
-               return result;
+       /* Check if the netlogon pipe is open using schannel. If so we
+          already have valid creds. If not we must set them up. */
+
+       if (cli->auth.auth_type != PIPE_AUTH_TYPE_SCHANNEL) {
+               uint32 neg_flags = NETLOGON_NEG_AUTH2_FLAGS;
+
+               result = rpccli_netlogon_setup_creds(cli, 
+                                       cli->cli->desthost, /* server name */
+                                       lp_workgroup(), /* domain */
+                                       global_myname(), /* client name */
+                                       global_myname(), /* machine account name */
+                                       orig_trust_passwd_hash,
+                                       sec_channel_type,
+                                       &neg_flags);
+
+               if (!NT_STATUS_IS_OK(result)) {
+                       DEBUG(3,("just_change_the_password: unable to setup creds (%s)!\n",
+                                nt_errstr(result)));
+                       return result;
+               }
        }
 
-       result = cli_net_srv_pwset(cli, mem_ctx, global_myname(), new_trust_passwd_hash);
+       result = rpccli_net_srv_pwset(cli, mem_ctx, global_myname(), new_trust_passwd_hash);
 
        if (!NT_STATUS_IS_OK(result)) {
                DEBUG(0,("just_change_the_password: unable to change password (%s)!\n",
@@ -60,7 +74,7 @@ static NTSTATUS just_change_the_password(struct cli_state *cli, TALLOC_CTX *mem_
  Caller must have already setup the connection to the NETLOGON pipe
 **********************************************************/
 
-NTSTATUS trust_pw_change_and_store_it(struct cli_state *cli, TALLOC_CTX *mem_ctx, 
+NTSTATUS trust_pw_change_and_store_it(struct rpc_pipe_client *cli, TALLOC_CTX *mem_ctx, 
                                      const char *domain,
                                      unsigned char orig_trust_passwd_hash[16],
                                      uint32 sec_channel_type)
@@ -72,7 +86,11 @@ NTSTATUS trust_pw_change_and_store_it(struct cli_state *cli, TALLOC_CTX *mem_ctx
                
        /* Create a random machine account password */
        str = generate_random_str(DEFAULT_TRUST_ACCOUNT_PASSWORD_LENGTH);
-       new_trust_passwd = talloc_strdup(mem_ctx, str);
+
+       if ((new_trust_passwd = talloc_strdup(mem_ctx, str)) == NULL) {
+               DEBUG(0, ("talloc_strdup failed\n"));
+               return NT_STATUS_NO_MEMORY;
+       }
        
        E_md4hash(new_trust_passwd, new_trust_passwd_hash);
 
@@ -81,7 +99,7 @@ NTSTATUS trust_pw_change_and_store_it(struct cli_state *cli, TALLOC_CTX *mem_ctx
        
        if (NT_STATUS_IS_OK(nt_status)) {
                DEBUG(3,("%s : trust_pw_change_and_store_it: Changed password.\n", 
-                        timestring(False)));
+                        current_timestring(False)));
                /*
                 * Return the result of trying to write the new password
                 * back into the trust account file.
@@ -100,16 +118,13 @@ NTSTATUS trust_pw_change_and_store_it(struct cli_state *cli, TALLOC_CTX *mem_ctx
  already setup the connection to the NETLOGON pipe
 **********************************************************/
 
-NTSTATUS trust_pw_find_change_and_store_it(struct cli_state *cli, 
+NTSTATUS trust_pw_find_change_and_store_it(struct rpc_pipe_client *cli, 
                                           TALLOC_CTX *mem_ctx, 
                                           const char *domain) 
 {
        unsigned char old_trust_passwd_hash[16];
-       char *up_domain;
        uint32 sec_channel_type = 0;
 
-       up_domain = talloc_strdup(mem_ctx, domain);
-
        if (!secrets_fetch_trust_account_password(domain,
                                                  old_trust_passwd_hash, 
                                                  NULL, &sec_channel_type)) {
@@ -120,7 +135,6 @@ NTSTATUS trust_pw_find_change_and_store_it(struct cli_state *cli,
        return trust_pw_change_and_store_it(cli, mem_ctx, domain,
                                            old_trust_passwd_hash,
                                            sec_channel_type);
-       
 }
 
 /*********************************************************************
@@ -137,6 +151,7 @@ BOOL enumerate_domain_trusts( TALLOC_CTX *mem_ctx, const char *domain,
        struct in_addr  dc_ip;
        uint32          enum_ctx = 0;
        struct cli_state *cli = NULL;
+       struct rpc_pipe_client *lsa_pipe;
        BOOL            retry;
 
        *domain_names = NULL;
@@ -145,7 +160,7 @@ BOOL enumerate_domain_trusts( TALLOC_CTX *mem_ctx, const char *domain,
 
        /* lookup a DC first */
 
-       if ( !get_dc_name(domain, dc_name, &dc_ip) ) {
+       if ( !get_dc_name(domain, NULL, dc_name, &dc_ip) ) {
                DEBUG(3,("enumerate_domain_trusts: can't locate a DC for domain %s\n",
                        domain));
                return False;
@@ -154,37 +169,37 @@ BOOL enumerate_domain_trusts( TALLOC_CTX *mem_ctx, const char *domain,
        /* setup the anonymous connection */
 
        result = cli_full_connection( &cli, global_myname(), dc_name, &dc_ip, 0, "IPC$", "IPC",
-               "", "", "", 0, &retry);
+               "", "", "", 0, Undefined, &retry);
        if ( !NT_STATUS_IS_OK(result) )
                goto done;
 
        /* open the LSARPC_PIPE */
 
-       if ( !cli_nt_session_open( cli, PI_LSARPC ) ) {
-               result = NT_STATUS_UNSUCCESSFUL;
+       lsa_pipe = cli_rpc_pipe_open_noauth( cli, PI_LSARPC, &result );
+       if ( !lsa_pipe) {
                goto done;
        }
 
        /* get a handle */
 
-       result = cli_lsa_open_policy(cli, mem_ctx, True,
+       result = rpccli_lsa_open_policy(lsa_pipe, mem_ctx, True,
                POLICY_VIEW_LOCAL_INFORMATION, &pol);
        if ( !NT_STATUS_IS_OK(result) )
                goto done;
 
        /* Lookup list of trusted domains */
 
-       result = cli_lsa_enum_trust_dom(cli, mem_ctx, &pol, &enum_ctx,
+       result = rpccli_lsa_enum_trust_dom(lsa_pipe, mem_ctx, &pol, &enum_ctx,
                num_domains, domain_names, sids);
        if ( !NT_STATUS_IS_OK(result) )
                goto done;
 
 done:
        /* cleanup */
-
-       cli_nt_session_close( cli );
-       cli_shutdown( cli );
+       if (cli) {
+               DEBUG(10,("enumerate_domain_trusts: shutting down connection...\n"));
+               cli_shutdown( cli );
+       }
 
        return NT_STATUS_IS_OK(result);
 }
-