Replace cli_rpc_pipe_close by a talloc destructor on rpc_pipe_struct
[kai/samba.git] / source3 / libsmb / clientgen.c
index 9021d1a36280ba678ac03df4f249b395addd87f8..e64b6fa278a233f08ac24102c5ff23e33e90ff9b 100644 (file)
@@ -6,7 +6,7 @@
    
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 2 of the License, or
+   the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
    
    This program is distributed in the hope that it will be useful,
    GNU General Public License for more details.
    
    You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software
-   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
 #include "includes.h"
 
-extern int smb_read_error;
+/*******************************************************************
+ Setup the word count and byte count for a client smb message.
+********************************************************************/
+
+int cli_set_message(char *buf,int num_words,int num_bytes,bool zero)
+{
+       if (zero && (num_words || num_bytes)) {
+               memset(buf + smb_size,'\0',num_words*2 + num_bytes);
+       }
+       SCVAL(buf,smb_wct,num_words);
+       SSVAL(buf,smb_vwv + num_words*SIZEOFWORD,num_bytes);
+       smb_setlen(buf,smb_size + num_words*2 + num_bytes - 4);
+       return (smb_size + num_words*2 + num_bytes);
+}
 
 /****************************************************************************
  Change the timeout (in milliseconds).
@@ -49,33 +61,51 @@ int cli_set_port(struct cli_state *cli, int port)
  *MUST* be of size BUFFER_SIZE+SAFETY_MARGIN.
  The timeout is in milliseconds
 
- This is exactly the same as receive_smb except that it can be set to never return
+ This is exactly the same as receive_smb except that it never returns
  a session keepalive packet (just as receive_smb used to do).
  receive_smb was changed to return keepalives as the oplock processing means this call
  should never go into a blocking read.
 ****************************************************************************/
 
-static ssize_t client_receive_smb(struct cli_state *cli, BOOL eat_keepalives, size_t maxlen)
+static ssize_t client_receive_smb(struct cli_state *cli, size_t maxlen)
 {
-       ssize_t len;
-       int fd = cli->fd;
-       char *buffer = cli->inbuf;
-       unsigned int timeout = cli->timeout;
+       size_t len;
 
        for(;;) {
-               len = receive_smb_raw(fd, buffer, timeout, maxlen);
+               NTSTATUS status;
 
-               if (len < 0) {
+               set_smb_read_error(&cli->smb_rw_error, SMB_READ_OK);
+
+               status = receive_smb_raw(cli->fd, cli->inbuf, cli->timeout,
+                                        maxlen, &len);
+               if (!NT_STATUS_IS_OK(status)) {
                        DEBUG(10,("client_receive_smb failed\n"));
-                       show_msg(buffer);
+                       show_msg(cli->inbuf);
+
+                       if (NT_STATUS_EQUAL(status, NT_STATUS_END_OF_FILE)) {
+                               set_smb_read_error(&cli->smb_rw_error,
+                                                  SMB_READ_EOF);
+                               return -1;
+                       }
+
+                       if (NT_STATUS_EQUAL(status, NT_STATUS_IO_TIMEOUT)) {
+                               set_smb_read_error(&cli->smb_rw_error,
+                                                  SMB_READ_TIMEOUT);
+                               return -1;
+                       }
+
+                       set_smb_read_error(&cli->smb_rw_error, SMB_READ_ERROR);
+                       return -1;
+               }
+
+               if (len < 0) {
                        return len;
                }
 
                /* Ignore session keepalive packets. */
-               if (eat_keepalives && (CVAL(buffer,0) == SMBkeepalive)) {
-                       continue;
+               if(CVAL(cli->inbuf,0) != SMBkeepalive) {
+                       break;
                }
-               break;
        }
 
        if (cli_encryption_on(cli)) {
@@ -83,13 +113,12 @@ static ssize_t client_receive_smb(struct cli_state *cli, BOOL eat_keepalives, si
                if (!NT_STATUS_IS_OK(status)) {
                        DEBUG(0, ("SMB decryption failed on incoming packet! Error %s\n",
                                nt_errstr(status)));
-                       cli->smb_rw_error = READ_BAD_DECRYPT;
-                       close(cli->fd);
-                       cli->fd = -1;
+                       cli->smb_rw_error = SMB_READ_BAD_DECRYPT;
                        return -1;
                }
        }
-       show_msg(buffer);
+
+       show_msg(cli->inbuf);
        return len;
 }
 
@@ -97,21 +126,16 @@ static ssize_t client_receive_smb(struct cli_state *cli, BOOL eat_keepalives, si
  Recv an smb.
 ****************************************************************************/
 
-BOOL cli_receive_smb_internal(struct cli_state *cli, BOOL eat_keepalives)
+bool cli_receive_smb(struct cli_state *cli)
 {
        ssize_t len;
 
        /* fd == -1 causes segfaults -- Tom (tom@ninja.nl) */
        if (cli->fd == -1)
-               return False; 
+               return false; 
 
  again:
-       len = client_receive_smb(cli, eat_keepalives, 0);
-
-       if (len >= 0 && !eat_keepalives && (CVAL(cli->inbuf,0) == SMBkeepalive)) {
-               /* Give back the keepalive. */
-               return True;
-       }
+       len = client_receive_smb(cli, 0);
        
        if (len > 0) {
                /* it might be an oplock break request */
@@ -123,7 +147,7 @@ BOOL cli_receive_smb_internal(struct cli_state *cli, BOOL eat_keepalives)
                                int fnum = SVAL(cli->inbuf,smb_vwv2);
                                unsigned char level = CVAL(cli->inbuf,smb_vwv3+1);
                                if (!cli->oplock_handler(cli, fnum, level)) {
-                                       return False;
+                                       return false;
                                }
                        }
                        /* try to prevent loops */
@@ -133,15 +157,14 @@ BOOL cli_receive_smb_internal(struct cli_state *cli, BOOL eat_keepalives)
        }
 
        /* If the server is not responding, note that now */
-       if (len <= 0) {
+       if (len < 0) {
                 DEBUG(0, ("Receiving SMB: Server stopped responding\n"));
-               cli->smb_rw_error = smb_read_error;
                close(cli->fd);
                cli->fd = -1;
-               return False;
+               return false;
        }
 
-       if (!cli_check_sign_mac(cli)) {
+       if (!cli_check_sign_mac(cli, cli->inbuf)) {
                /*
                 * If we get a signature failure in sessionsetup, then
                 * the server sometimes just reflects the sent signature
@@ -158,50 +181,48 @@ BOOL cli_receive_smb_internal(struct cli_state *cli, BOOL eat_keepalives)
                         * Reflected signature on login error. 
                         * Set bad sig but don't close fd.
                         */
-                       cli->smb_rw_error = READ_BAD_SIG;
-                       return True;
+                       cli->smb_rw_error = SMB_READ_BAD_SIG;
+                       return true;
                }
 
                DEBUG(0, ("SMB Signature verification failed on incoming packet!\n"));
-               cli->smb_rw_error = READ_BAD_SIG;
+               cli->smb_rw_error = SMB_READ_BAD_SIG;
                close(cli->fd);
                cli->fd = -1;
-               return False;
-       }
-
-       return True;
+               return false;
+       };
+       return true;
 }
 
 /****************************************************************************
- Recv an smb - eat keepalives.
+ Read the data portion of a readX smb.
+ The timeout is in milliseconds
 ****************************************************************************/
 
-BOOL cli_receive_smb(struct cli_state *cli)
+ssize_t cli_receive_smb_data(struct cli_state *cli, char *buffer, size_t len)
 {
-       return cli_receive_smb_internal(cli, True);
-}
+       NTSTATUS status;
 
-/****************************************************************************
- Recv an smb - return keepalives.
-****************************************************************************/
+       set_smb_read_error(&cli->smb_rw_error, SMB_READ_OK);
 
-BOOL cli_receive_smb_return_keepalive(struct cli_state *cli)
-{
-       return cli_receive_smb_internal(cli, False);
-}
+       status = read_socket_with_timeout(
+               cli->fd, buffer, len, len, cli->timeout, NULL);
+       if (NT_STATUS_IS_OK(status)) {
+               return len;
+       }
 
-/****************************************************************************
- Read the data portion of a readX smb.
- The timeout is in milliseconds
-****************************************************************************/
+       if (NT_STATUS_EQUAL(status, NT_STATUS_END_OF_FILE)) {
+               set_smb_read_error(&cli->smb_rw_error, SMB_READ_EOF);
+               return -1;
+       }
 
-ssize_t cli_receive_smb_data(struct cli_state *cli, char *buffer, size_t len)
-{
-       if (cli->timeout > 0) {
-               return read_socket_with_timeout(cli->fd, buffer, len, len, cli->timeout);
-       } else {
-               return read_data(cli->fd, buffer, len);
+       if (NT_STATUS_EQUAL(status, NT_STATUS_IO_TIMEOUT)) {
+               set_smb_read_error(&cli->smb_rw_error, SMB_READ_TIMEOUT);
+               return -1;
        }
+
+       set_smb_read_error(&cli->smb_rw_error, SMB_READ_ERROR);
+       return -1;
 }
 
 /****************************************************************************
@@ -209,17 +230,17 @@ ssize_t cli_receive_smb_data(struct cli_state *cli, char *buffer, size_t len)
  We can only use this if encryption and signing are off.
 ****************************************************************************/
 
-BOOL cli_receive_smb_readX_header(struct cli_state *cli)
+bool cli_receive_smb_readX_header(struct cli_state *cli)
 {
        ssize_t len, offset;
 
        if (cli->fd == -1)
-               return False; 
+               return false; 
 
  again:
 
        /* Read up to the size of a readX header reply. */
-       len = client_receive_smb(cli, True, (smb_size - 4) + 24);
+       len = client_receive_smb(cli, (smb_size - 4) + 24);
        
        if (len > 0) {
                /* it might be an oplock break request */
@@ -234,14 +255,15 @@ BOOL cli_receive_smb_readX_header(struct cli_state *cli)
                        }
 
                        /* Read the rest of the data. */
-                       if (!cli_receive_smb_data(cli,cli->inbuf+len,total_len - len)) {
+                       if ((total_len - len > 0) &&
+                           !cli_receive_smb_data(cli,cli->inbuf+len,total_len - len)) {
                                goto read_err;
                        }
 
                        if (cli->oplock_handler) {
                                int fnum = SVAL(cli->inbuf,smb_vwv2);
                                unsigned char level = CVAL(cli->inbuf,smb_vwv3+1);
-                               if (!cli->oplock_handler(cli, fnum, level)) return False;
+                               if (!cli->oplock_handler(cli, fnum, level)) return false;
                        }
                        /* try to prevent loops */
                        SCVAL(cli->inbuf,smb_com,0xFF);
@@ -280,20 +302,20 @@ BOOL cli_receive_smb_readX_header(struct cli_state *cli)
                }
        }
 
-       return True;
+       return true;
 
   read_err:
 
-       cli->smb_rw_error = smb_read_error = READ_ERROR;
+       cli->smb_rw_error = SMB_READ_ERROR;
        close(cli->fd);
        cli->fd = -1;
-       return False;
+       return false;
 }
 
 static ssize_t write_socket(int fd, const char *buf, size_t len)
 {
         ssize_t ret=0;
-                                                                                                                                            
+
         DEBUG(6,("write_socket(%d,%d)\n",fd,(int)len));
         ret = write_data(fd,buf,len);
 
@@ -301,7 +323,7 @@ static ssize_t write_socket(int fd, const char *buf, size_t len)
         if(ret <= 0)
                 DEBUG(0,("write_socket: Error writing %d bytes to socket %d: ERRNO = %s\n",
                         (int)len, fd, strerror(errno) ));
-                                                                                                                                            
+
         return(ret);
 }
 
@@ -309,30 +331,30 @@ static ssize_t write_socket(int fd, const char *buf, size_t len)
  Send an smb to a fd.
 ****************************************************************************/
 
-BOOL cli_send_smb(struct cli_state *cli)
+bool cli_send_smb(struct cli_state *cli)
 {
        size_t len;
        size_t nwritten=0;
        ssize_t ret;
        char *buf_out = cli->outbuf;
-       BOOL enc_on = cli_encryption_on(cli);
+       bool enc_on = cli_encryption_on(cli);
 
        /* fd == -1 causes segfaults -- Tom (tom@ninja.nl) */
-       if (cli->fd == -1) {
-               return False;
-       }
+       if (cli->fd == -1)
+               return false;
 
-       cli_calculate_sign_mac(cli);
+       cli_calculate_sign_mac(cli, cli->outbuf);
 
        if (enc_on) {
-               NTSTATUS status = cli_encrypt_message(cli, &buf_out);
+               NTSTATUS status = cli_encrypt_message(cli, cli->outbuf,
+                                                     &buf_out);
                if (!NT_STATUS_IS_OK(status)) {
                        close(cli->fd);
                        cli->fd = -1;
-                       cli->smb_rw_error = WRITE_ERROR;
+                       cli->smb_rw_error = SMB_WRITE_ERROR;
                        DEBUG(0,("Error in encrypting client message. Error %s\n",
                                nt_errstr(status) ));
-                       return False;
+                       return false;
                }
        }
 
@@ -346,53 +368,123 @@ BOOL cli_send_smb(struct cli_state *cli)
                        }
                        close(cli->fd);
                        cli->fd = -1;
-                       cli->smb_rw_error = WRITE_ERROR;
+                       cli->smb_rw_error = SMB_WRITE_ERROR;
                        DEBUG(0,("Error writing %d bytes to client. %d (%s)\n",
                                (int)len,(int)ret, strerror(errno) ));
-                       return False;
+                       return false;
                }
                nwritten += ret;
        }
 
-       cli_free_enc_buffer(cli, buf_out);
+       if (enc_on) {
+               cli_free_enc_buffer(cli, buf_out);
+       }
 
        /* Increment the mid so we can tell between responses. */
        cli->mid++;
-       if (!cli->mid) {
+       if (!cli->mid)
                cli->mid++;
+       return true;
+}
+
+/****************************************************************************
+ Send a "direct" writeX smb to a fd.
+****************************************************************************/
+
+bool cli_send_smb_direct_writeX(struct cli_state *cli,
+                               const char *p,
+                               size_t extradata)
+{
+       /* First length to send is the offset to the data. */
+       size_t len = SVAL(cli->outbuf,smb_vwv11) + 4;
+       size_t nwritten=0;
+       ssize_t ret;
+
+       /* fd == -1 causes segfaults -- Tom (tom@ninja.nl) */
+       if (cli->fd == -1) {
+               return false;
+       }
+
+       if (client_is_signing_on(cli)) {
+               DEBUG(0,("cli_send_smb_large: cannot send signed packet.\n"));
+               return false;
        }
-       return True;
+
+       while (nwritten < len) {
+               ret = write_socket(cli->fd,cli->outbuf+nwritten,len - nwritten);
+               if (ret <= 0) {
+                       close(cli->fd);
+                       cli->fd = -1;
+                       cli->smb_rw_error = SMB_WRITE_ERROR;
+                       DEBUG(0,("Error writing %d bytes to client. %d (%s)\n",
+                               (int)len,(int)ret, strerror(errno) ));
+                       return false;
+               }
+               nwritten += ret;
+       }
+
+       /* Now write the extra data. */
+       nwritten=0;
+       while (nwritten < extradata) {
+               ret = write_socket(cli->fd,p+nwritten,extradata - nwritten);
+               if (ret <= 0) {
+                       close(cli->fd);
+                       cli->fd = -1;
+                       cli->smb_rw_error = SMB_WRITE_ERROR;
+                       DEBUG(0,("Error writing %d extradata "
+                               "bytes to client. %d (%s)\n",
+                               (int)extradata,(int)ret, strerror(errno) ));
+                       return false;
+               }
+               nwritten += ret;
+       }
+
+       /* Increment the mid so we can tell between responses. */
+       cli->mid++;
+       if (!cli->mid)
+               cli->mid++;
+       return true;
 }
 
 /****************************************************************************
  Setup basics in a outgoing packet.
 ****************************************************************************/
 
-void cli_setup_packet(struct cli_state *cli)
+void cli_setup_packet_buf(struct cli_state *cli, char *buf)
 {
+       uint16 flags2;
        cli->rap_error = 0;
-       SSVAL(cli->outbuf,smb_pid,cli->pid);
-       SSVAL(cli->outbuf,smb_uid,cli->vuid);
-       SSVAL(cli->outbuf,smb_mid,cli->mid);
-       if (cli->protocol > PROTOCOL_CORE) {
-               uint16 flags2;
-               if (cli->case_sensitive) {
-                       SCVAL(cli->outbuf,smb_flg,0x0);
-               } else {
-                       /* Default setting, case insensitive. */
-                       SCVAL(cli->outbuf,smb_flg,0x8);
-               }
-               flags2 = FLAGS2_LONG_PATH_COMPONENTS;
-               if (cli->capabilities & CAP_UNICODE)
-                       flags2 |= FLAGS2_UNICODE_STRINGS;
-               if ((cli->capabilities & CAP_DFS) && cli->dfsroot)
-                       flags2 |= FLAGS2_DFS_PATHNAMES;
-               if (cli->capabilities & CAP_STATUS32)
-                       flags2 |= FLAGS2_32_BIT_ERROR_CODES;
-               if (cli->use_spnego)
-                       flags2 |= FLAGS2_EXTENDED_SECURITY;
-               SSVAL(cli->outbuf,smb_flg2, flags2);
+       SIVAL(buf,smb_rcls,0);
+       SSVAL(buf,smb_pid,cli->pid);
+       memset(buf+smb_pidhigh, 0, 12);
+       SSVAL(buf,smb_uid,cli->vuid);
+       SSVAL(buf,smb_mid,cli->mid);
+
+       if (cli->protocol <= PROTOCOL_CORE) {
+               return;
+       }
+
+       if (cli->case_sensitive) {
+               SCVAL(buf,smb_flg,0x0);
+       } else {
+               /* Default setting, case insensitive. */
+               SCVAL(buf,smb_flg,0x8);
        }
+       flags2 = FLAGS2_LONG_PATH_COMPONENTS;
+       if (cli->capabilities & CAP_UNICODE)
+               flags2 |= FLAGS2_UNICODE_STRINGS;
+       if ((cli->capabilities & CAP_DFS) && cli->dfsroot)
+               flags2 |= FLAGS2_DFS_PATHNAMES;
+       if (cli->capabilities & CAP_STATUS32)
+               flags2 |= FLAGS2_32_BIT_ERROR_CODES;
+       if (cli->use_spnego)
+               flags2 |= FLAGS2_EXTENDED_SECURITY;
+       SSVAL(buf,smb_flg2, flags2);
+}
+
+void cli_setup_packet(struct cli_state *cli)
+{
+       cli_setup_packet_buf(cli, cli->outbuf);
 }
 
 /****************************************************************************
@@ -401,7 +493,7 @@ void cli_setup_packet(struct cli_state *cli)
 
 void cli_setup_bcc(struct cli_state *cli, void *p)
 {
-       set_message_bcc(NULL,cli->outbuf, PTR_DIFF(p, smb_buf(cli->outbuf)));
+       set_message_bcc(cli->outbuf, PTR_DIFF(p, smb_buf(cli->outbuf)));
 }
 
 /****************************************************************************
@@ -414,7 +506,7 @@ void cli_init_creds(struct cli_state *cli, const char *username, const char *dom
        fstrcpy(cli->user_name, username);
        pwd_set_cleartext(&cli->pwd, password);
        if (!*username) {
-               cli->pwd.null_pwd = True;
+               cli->pwd.null_pwd = true;
        }
 
         DEBUG(10,("cli_init_creds: user %s domain %s\n", cli->user_name, cli->domain));
@@ -429,16 +521,16 @@ void cli_setup_signing_state(struct cli_state *cli, int signing_state)
        if (signing_state == Undefined)
                return;
 
-       if (signing_state == False) {
-               cli->sign_info.allow_smb_signing = False;
-               cli->sign_info.mandatory_signing = False;
+       if (signing_state == false) {
+               cli->sign_info.allow_smb_signing = false;
+               cli->sign_info.mandatory_signing = false;
                return;
        }
 
-       cli->sign_info.allow_smb_signing = True;
+       cli->sign_info.allow_smb_signing = true;
 
        if (signing_state == Required) 
-               cli->sign_info.mandatory_signing = True;
+               cli->sign_info.mandatory_signing = true;
 }
 
 /****************************************************************************
@@ -455,7 +547,7 @@ struct cli_state *cli_initialise(void)
                return NULL;
        }
 
-       cli = SMB_MALLOC_P(struct cli_state);
+       cli = talloc(NULL, struct cli_state);
        if (!cli) {
                return NULL;
        }
@@ -475,8 +567,8 @@ struct cli_state *cli_initialise(void)
        cli->outbuf = (char *)SMB_MALLOC(cli->bufsize+SAFETY_MARGIN);
        cli->inbuf = (char *)SMB_MALLOC(cli->bufsize+SAFETY_MARGIN);
        cli->oplock_handler = cli_oplock_ack;
-       cli->case_sensitive = False;
-       cli->smb_rw_error = 0;
+       cli->case_sensitive = false;
+       cli->smb_rw_error = SMB_READ_OK;
 
        cli->use_spnego = lp_client_use_spnego();
 
@@ -486,20 +578,17 @@ struct cli_state *cli_initialise(void)
           client routines using DOS errors instead of STATUS32
           ones.  This intended only as a temporary hack. */    
        if (getenv("CLI_FORCE_DOSERR"))
-               cli->force_dos_errors = True;
+               cli->force_dos_errors = true;
 
        if (lp_client_signing()) 
-               cli->sign_info.allow_smb_signing = True;
+               cli->sign_info.allow_smb_signing = true;
 
        if (lp_client_signing() == Required) 
-               cli->sign_info.mandatory_signing = True;
+               cli->sign_info.mandatory_signing = true;
                                    
        if (!cli->outbuf || !cli->inbuf)
                 goto error;
 
-       if ((cli->mem_ctx = talloc_init("cli based talloc")) == NULL)
-                goto error;
-
        memset(cli->outbuf, 0, cli->bufsize);
        memset(cli->inbuf, 0, cli->bufsize);
 
@@ -527,55 +616,17 @@ struct cli_state *cli_initialise(void)
         return NULL;
 }
 
-/****************************************************************************
- External interface.
- Close an open named pipe over SMB. Free any authentication data.
- Returns False if the cli_close call failed.
- ****************************************************************************/
-
-BOOL cli_rpc_pipe_close(struct rpc_pipe_client *cli)
-{
-       BOOL ret;
-
-       if (!cli) {
-               return False;
-       }
-
-       ret = cli_close(cli->cli, cli->fnum);
-
-       if (!ret) {
-               DEBUG(1,("cli_rpc_pipe_close: cli_close failed on pipe %s, "
-                         "fnum 0x%x "
-                         "to machine %s.  Error was %s\n",
-                         cli->pipe_name,
-                         (int) cli->fnum,
-                         cli->cli->desthost,
-                         cli_errstr(cli->cli)));
-       }
-
-       if (cli->auth.cli_auth_data_free_func) {
-               (*cli->auth.cli_auth_data_free_func)(&cli->auth);
-       }
-
-       DEBUG(10,("cli_rpc_pipe_close: closed pipe %s to machine %s\n",
-               cli->pipe_name, cli->cli->desthost ));
-
-       DLIST_REMOVE(cli->cli->pipe_list, cli);
-       talloc_destroy(cli->mem_ctx);
-       return ret;
-}
-
 /****************************************************************************
  Close all pipes open on this session.
 ****************************************************************************/
 
 void cli_nt_pipes_close(struct cli_state *cli)
 {
-       struct rpc_pipe_client *cp, *next;
-
-       for (cp = cli->pipe_list; cp; cp = next) {
-               next = cp->next;
-               cli_rpc_pipe_close(cp);
+       while (cli->pipe_list != NULL) {
+               /*
+                * No TALLOC_FREE here!
+                */
+               talloc_free(cli->pipe_list);
        }
 }
 
@@ -595,11 +646,11 @@ void cli_shutdown(struct cli_state *cli)
         * later.  This tree disconnect forces the peer to clean up, since the
         * connection will be going away.
         *
-        * Also, do not do tree disconnect when cli->smb_rw_error is DO_NOT_DO_TDIS
+        * Also, do not do tree disconnect when cli->smb_rw_error is SMB_DO_NOT_DO_TDIS
         * the only user for this so far is smbmount which passes opened connection
         * down to kernel's smbfs module.
         */
-       if ( (cli->cnum != (uint16)-1) && (cli->smb_rw_error != DO_NOT_DO_TDIS ) ) {
+       if ( (cli->cnum != (uint16)-1) && (cli->smb_rw_error != SMB_DO_NOT_DO_TDIS ) ) {
                cli_tdis(cli);
        }
         
@@ -607,23 +658,16 @@ void cli_shutdown(struct cli_state *cli)
        SAFE_FREE(cli->inbuf);
 
        cli_free_signing_context(cli);
-       cli_free_encryption_context(cli);
-
        data_blob_free(&cli->secblob);
        data_blob_free(&cli->user_session_key);
 
-       if (cli->mem_ctx) {
-               talloc_destroy(cli->mem_ctx);
-               cli->mem_ctx = NULL;
-       }
-
        if (cli->fd != -1) {
                close(cli->fd);
        }
        cli->fd = -1;
-       cli->smb_rw_error = 0;
+       cli->smb_rw_error = SMB_READ_OK;
 
-       SAFE_FREE(cli);
+       TALLOC_FREE(cli);
 }
 
 /****************************************************************************
@@ -650,9 +694,9 @@ uint16 cli_setpid(struct cli_state *cli, uint16 pid)
  Set the case sensitivity flag on the packets. Returns old state.
 ****************************************************************************/
 
-BOOL cli_set_case_sensitive(struct cli_state *cli, BOOL case_sensitive)
+bool cli_set_case_sensitive(struct cli_state *cli, bool case_sensitive)
 {
-       BOOL ret = cli->case_sensitive;
+       bool ret = cli->case_sensitive;
        cli->case_sensitive = case_sensitive;
        return ret;
 }
@@ -661,36 +705,38 @@ BOOL cli_set_case_sensitive(struct cli_state *cli, BOOL case_sensitive)
 Send a keepalive packet to the server
 ****************************************************************************/
 
-BOOL cli_send_keepalive(struct cli_state *cli)
+bool cli_send_keepalive(struct cli_state *cli)
 {
         if (cli->fd == -1) {
                 DEBUG(3, ("cli_send_keepalive: fd == -1\n"));
-                return False;
+                return false;
         }
         if (!send_keepalive(cli->fd)) {
                 close(cli->fd);
                 cli->fd = -1;
                 DEBUG(0,("Error sending keepalive packet to client.\n"));
-                return False;
+                return false;
         }
-        return True;
+        return true;
 }
 
 /****************************************************************************
  Send/receive a SMBecho command: ping the server
 ****************************************************************************/
 
-BOOL cli_echo(struct cli_state *cli, unsigned char *data, size_t length)
+bool cli_echo(struct cli_state *cli, uint16 num_echos,
+             unsigned char *data, size_t length)
 {
        char *p;
+       int i;
 
        SMB_ASSERT(length < 1024);
 
        memset(cli->outbuf,'\0',smb_size);
-       set_message(NULL,cli->outbuf,1,length,True);
+       cli_set_message(cli->outbuf,1,length,true);
        SCVAL(cli->outbuf,smb_com,SMBecho);
        SSVAL(cli->outbuf,smb_tid,65535);
-       SSVAL(cli->outbuf,smb_vwv0,1);
+       SSVAL(cli->outbuf,smb_vwv0,num_echos);
        cli_setup_packet(cli);
        p = smb_buf(cli->outbuf);
        memcpy(p, data, length);
@@ -699,12 +745,16 @@ BOOL cli_echo(struct cli_state *cli, unsigned char *data, size_t length)
        cli_setup_bcc(cli, p);
 
        cli_send_smb(cli);
-       if (!cli_receive_smb(cli)) {
-               return False;
-       }
 
-       if (cli_is_error(cli)) {
-               return False;
+       for (i=0; i<num_echos; i++) {
+               if (!cli_receive_smb(cli)) {
+                       return false;
+               }
+
+               if (cli_is_error(cli)) {
+                       return false;
+               }
        }
-       return True;
+
+       return true;
 }