r8790: Finish the migration of aliases and privilages with SamSync, by adding
[kai/samba.git] / source / rpc_server / samr / dcesrv_samr.c
index 6412192127147466d5ecc06d39c9a9313839f834..26593d16975ff47c7bb9f88aca8628e01abf463b 100644 (file)
@@ -4,6 +4,8 @@
    endpoint server for the samr pipe
 
    Copyright (C) Andrew Tridgell 2004
+   Copyright (C) Volker Lendecke 2004
+   Copyright (C) Andrew Bartlett <abartlet@samba.org> 2004-2005
    
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
 */
 
 #include "includes.h"
+#include "librpc/gen_ndr/ndr_samr.h"
+#include "rpc_server/dcerpc_server.h"
 #include "rpc_server/common/common.h"
+#include "rpc_server/samr/dcesrv_samr.h"
+#include "system/time.h"
+#include "lib/ldb/include/ldb.h"
+#include "ads.h"
 
-/*
-  this type allows us to distinguish handle types
-*/
-enum samr_handle {
-       SAMR_HANDLE_CONNECT,
-       SAMR_HANDLE_DOMAIN,
-       SAMR_HANDLE_USER,
-       SAMR_HANDLE_GROUP,
-       SAMR_HANDLE_ALIAS
-};
-
-
-/*
-  state asscoiated with a samr_Connect*() operation
-*/
-struct samr_connect_state {
-       int reference_count;
-       void *sam_ctx;
-       TALLOC_CTX *mem_ctx;
-       uint32 access_mask;
-};
-
-/*
-  state associated with a samr_OpenDomain() operation
-*/
-struct samr_domain_state {
-       struct samr_connect_state *connect_state;
-       int reference_count;
-       void *sam_ctx;
-       TALLOC_CTX *mem_ctx;
-       uint32 access_mask;
-       const char *domain_sid;
-       const char *domain_name;
-       const char *basedn;
-};
-
-/*
-  state associated with a open account handle
-*/
-struct samr_account_state {
-       struct samr_domain_state *domain_state;
-       void *sam_ctx;
-       TALLOC_CTX *mem_ctx;
-       uint32 access_mask;
-       const char *account_sid;
-       const char *account_name;
-       const char *basedn;
-};
-
-
-/*
-  destroy connection state
-*/
-static void samr_Connect_close(struct samr_connect_state *state)
-{
-       state->reference_count--;
-       if (state->reference_count == 0) {
-               samdb_close(state->sam_ctx);
-               talloc_destroy(state->mem_ctx);
-       }
-}
 
 /*
-  destroy an open connection. This closes the database connection
+  This is a bad temporary hack until we have at least some kind of schema
+  support
 */
-static void samr_Connect_destroy(struct dcesrv_connection *conn, struct dcesrv_handle *h)
+static char *ldb_hexstr(TALLOC_CTX *mem_ctx, uint32_t val)
 {
-       struct samr_connect_state *state = h->data;
-       samr_Connect_close(state);
+       return talloc_asprintf(mem_ctx, "0x%.8x", val);
 }
 
 /* 
@@ -102,42 +49,33 @@ static void samr_Connect_destroy(struct dcesrv_connection *conn, struct dcesrv_h
 static NTSTATUS samr_Connect(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                             struct samr_Connect *r)
 {
-       struct samr_connect_state *state;
+       struct samr_connect_state *c_state;
        struct dcesrv_handle *handle;
-       TALLOC_CTX *connect_mem_ctx;
 
-       ZERO_STRUCTP(r->out.handle);
-
-       connect_mem_ctx = talloc_init("samr_Connect");
-       if (!connect_mem_ctx) {
-               return NT_STATUS_NO_MEMORY;
-       }
+       ZERO_STRUCTP(r->out.connect_handle);
 
-       state = talloc_p(connect_mem_ctx, struct samr_connect_state);
-       if (!state) {
+       c_state = talloc(dce_call->conn, struct samr_connect_state);
+       if (!c_state) {
                return NT_STATUS_NO_MEMORY;
        }
-       state->mem_ctx = connect_mem_ctx;
 
        /* make sure the sam database is accessible */
-       state->sam_ctx = samdb_connect();
-       if (state->sam_ctx == NULL) {
-               talloc_destroy(state->mem_ctx);
+       c_state->sam_ctx = samdb_connect(c_state);
+       if (c_state->sam_ctx == NULL) {
+               talloc_free(c_state);
                return NT_STATUS_INVALID_SYSTEM_SERVICE;
        }
 
-       handle = dcesrv_handle_new(dce_call->conn, SAMR_HANDLE_CONNECT);
+       handle = dcesrv_handle_new(dce_call->context, SAMR_HANDLE_CONNECT);
        if (!handle) {
-               talloc_destroy(state->mem_ctx);
+               talloc_free(c_state);
                return NT_STATUS_NO_MEMORY;
        }
 
-       handle->data = state;
-       handle->destroy = samr_Connect_destroy;
+       handle->data = talloc_steal(handle, c_state);
 
-       state->reference_count = 1;
-       state->access_mask = r->in.access_mask;
-       *r->out.handle = handle->wire_handle;
+       c_state->access_mask = r->in.access_mask;
+       *r->out.connect_handle = handle->wire_handle;
 
        return NT_STATUS_OK;
 }
@@ -155,10 +93,7 @@ static NTSTATUS samr_Close(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_c
 
        DCESRV_PULL_HANDLE(h, r->in.handle, DCESRV_HANDLE_ANY);
 
-       /* this causes the callback samr_XXX_destroy() to be called by
-          the handle destroy code which destroys the state associated
-          with the handle */
-       dcesrv_handle_destroy(dce_call->conn, h);
+       talloc_free(h);
 
        ZERO_STRUCTP(r->out.handle);
 
@@ -182,7 +117,23 @@ static NTSTATUS samr_SetSecurity(struct dcesrv_call_state *dce_call, TALLOC_CTX
 static NTSTATUS samr_QuerySecurity(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                                   struct samr_QuerySecurity *r)
 {
-       DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
+       struct dcesrv_handle *h;
+       struct sec_desc_buf *sd;
+
+       r->out.sdbuf = NULL;
+
+       DCESRV_PULL_HANDLE(h, r->in.handle, DCESRV_HANDLE_ANY);
+
+       sd = talloc(mem_ctx, struct sec_desc_buf);
+       if (sd == NULL) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       sd->sd = samdb_default_security_descriptor(mem_ctx);
+
+       r->out.sdbuf = sd;
+
+       return NT_STATUS_OK;
 }
 
 
@@ -207,34 +158,26 @@ static NTSTATUS samr_Shutdown(struct dcesrv_call_state *dce_call, TALLOC_CTX *me
 static NTSTATUS samr_LookupDomain(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                                  struct samr_LookupDomain *r)
 {
-       struct samr_connect_state *state;
+       struct samr_connect_state *c_state;
        struct dcesrv_handle *h;
-       struct dom_sid2 *sid;
-       const char *sidstr;
+       struct dom_sid *sid;
                
        r->out.sid = NULL;
 
-       DCESRV_PULL_HANDLE(h, r->in.handle, SAMR_HANDLE_CONNECT);
+       DCESRV_PULL_HANDLE(h, r->in.connect_handle, SAMR_HANDLE_CONNECT);
 
-       state = h->data;
+       c_state = h->data;
 
-       if (r->in.domain->name == NULL) {
+       if (r->in.domain_name->string == NULL) {
                return NT_STATUS_INVALID_PARAMETER;
        }
 
-       sidstr = samdb_search_string(state->sam_ctx,
-                                    mem_ctx, NULL, "objectSid",
-                                    "(&(name=%s)(objectclass=domain))",
-                                    r->in.domain->name);
-       if (sidstr == NULL) {
-               return NT_STATUS_NO_SUCH_DOMAIN;
-       }
-
-       sid = dom_sid_parse_talloc(mem_ctx, sidstr);
+       sid = samdb_search_dom_sid(c_state->sam_ctx,
+                                  mem_ctx, NULL, "objectSid",
+                                  "(&(name=%s)(objectclass=domain))",
+                                  r->in.domain_name->string);
        if (sid == NULL) {
-               DEBUG(1,("samdb: Invalid sid '%s' for domain %s\n",
-                        sidstr, r->in.domain->name));
-               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+               return NT_STATUS_NO_SUCH_DOMAIN;
        }
 
        r->out.sid = sid;
@@ -251,7 +194,7 @@ static NTSTATUS samr_LookupDomain(struct dcesrv_call_state *dce_call, TALLOC_CTX
 static NTSTATUS samr_EnumDomains(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                                 struct samr_EnumDomains *r)
 {
-       struct samr_connect_state *state;
+       struct samr_connect_state *c_state;
        struct dcesrv_handle *h;
        struct samr_SamArray *array;
        const char **domains;
@@ -261,15 +204,15 @@ static NTSTATUS samr_EnumDomains(struct dcesrv_call_state *dce_call, TALLOC_CTX
        r->out.sam = NULL;
        r->out.num_entries = 0;
 
-       DCESRV_PULL_HANDLE(h, r->in.handle, SAMR_HANDLE_CONNECT);
+       DCESRV_PULL_HANDLE(h, r->in.connect_handle, SAMR_HANDLE_CONNECT);
 
-       state = h->data;
+       c_state = h->data;
 
-       count = samdb_search_string_multiple(state->sam_ctx,
+       count = samdb_search_string_multiple(c_state->sam_ctx,
                                             mem_ctx, NULL, &domains, 
                                             "name", "(objectclass=domain)");
        if (count == -1) {
-               DEBUG(1,("samdb: no domains found in EnumDomains\n"));
+               DEBUG(0,("samdb: no domains found in EnumDomains\n"));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
@@ -282,7 +225,7 @@ static NTSTATUS samr_EnumDomains(struct dcesrv_call_state *dce_call, TALLOC_CTX
                return NT_STATUS_OK;
        }
 
-       array = talloc_p(mem_ctx, struct samr_SamArray);
+       array = talloc(mem_ctx, struct samr_SamArray);
        if (array == NULL) {
                return NT_STATUS_NO_MEMORY;
        }
@@ -290,46 +233,24 @@ static NTSTATUS samr_EnumDomains(struct dcesrv_call_state *dce_call, TALLOC_CTX
        array->count = 0;
        array->entries = NULL;
 
-       array->entries = talloc_array_p(mem_ctx, struct samr_SamEntry, count - start_i);
+       array->entries = talloc_array(mem_ctx, struct samr_SamEntry, count - start_i);
        if (array->entries == NULL) {
                return NT_STATUS_NO_MEMORY;
        }
 
        for (i=0;i<count-start_i;i++) {
                array->entries[i].idx = start_i + i;
-               array->entries[i].name.name = domains[start_i+i];
+               array->entries[i].name.string = domains[start_i+i];
        }
 
        r->out.sam = array;
-       r->out.num_entries = i - start_i;
+       r->out.num_entries = i;
        array->count = r->out.num_entries;
 
        return NT_STATUS_OK;
 }
 
 
-/*
-  close an open domain context
-*/
-static void samr_Domain_close(struct dcesrv_connection *conn, 
-                             struct samr_domain_state *state)
-{
-       state->reference_count--;
-       if (state->reference_count == 0) {
-               samr_Connect_close(state->connect_state);
-               talloc_destroy(state->mem_ctx);
-       }
-}
-
-/*
-  destroy an open domain context
-*/
-static void samr_Domain_destroy(struct dcesrv_connection *conn, struct dcesrv_handle *h)
-{
-       struct samr_domain_state *state = h->data;
-       samr_Domain_close(conn, state);
-}
-
 /* 
   samr_OpenDomain 
 */
@@ -337,17 +258,16 @@ static NTSTATUS samr_OpenDomain(struct dcesrv_call_state *dce_call, TALLOC_CTX *
                                struct samr_OpenDomain *r)
 {
        struct dcesrv_handle *h_conn, *h_domain;
-       const char *sidstr, *domain_name;
+       const char *domain_name;
        struct samr_connect_state *c_state;
-       struct samr_domain_state *state;
-       TALLOC_CTX *mem_ctx2;
+       struct samr_domain_state *d_state;
        const char * const attrs[2] = { "name", NULL};
        struct ldb_message **msgs;
        int ret;
 
        ZERO_STRUCTP(r->out.domain_handle);
 
-       DCESRV_PULL_HANDLE(h_conn, r->in.handle, SAMR_HANDLE_CONNECT);
+       DCESRV_PULL_HANDLE(h_conn, r->in.connect_handle, SAMR_HANDLE_CONNECT);
 
        c_state = h_conn->data;
 
@@ -355,15 +275,10 @@ static NTSTATUS samr_OpenDomain(struct dcesrv_call_state *dce_call, TALLOC_CTX *
                return NT_STATUS_INVALID_PARAMETER;
        }
 
-       sidstr = dom_sid_string(mem_ctx, r->in.sid);
-       if (sidstr == NULL) {
-               return NT_STATUS_INVALID_PARAMETER;
-       }
-
-       ret = samdb_search(c_state->sam_ctx,
+       ret = gendb_search(c_state->sam_ctx,
                           mem_ctx, NULL, &msgs, attrs,
                           "(&(objectSid=%s)(objectclass=domain))", 
-                          sidstr);
+                          ldap_encode_ndr_dom_sid(mem_ctx, r->in.sid));
        if (ret != 1) {
                return NT_STATUS_NO_SUCH_DOMAIN;
        }
@@ -373,52 +288,151 @@ static NTSTATUS samr_OpenDomain(struct dcesrv_call_state *dce_call, TALLOC_CTX *
                return NT_STATUS_NO_SUCH_DOMAIN;
        }
 
-       mem_ctx2 = talloc_init("OpenDomain(%s)\n", domain_name);
-       if (!mem_ctx2) {
-               return NT_STATUS_NO_MEMORY;
-       }
-
-       state = talloc_p(mem_ctx2, struct samr_domain_state);
-       if (!state) {
-               talloc_destroy(mem_ctx2);
+       d_state = talloc(c_state, struct samr_domain_state);
+       if (!d_state) {
                return NT_STATUS_NO_MEMORY;
        }
 
-       state->reference_count = 1;
-       state->connect_state = c_state;
-       state->sam_ctx = c_state->sam_ctx;
-       state->mem_ctx = mem_ctx2;
-       state->domain_sid = talloc_strdup(mem_ctx2, sidstr);
-       state->domain_name = talloc_strdup(mem_ctx2, domain_name);
-       state->basedn = talloc_strdup(mem_ctx2, msgs[0]->dn);
-       if (!state->domain_sid || !state->domain_name || !state->basedn) {
-               talloc_destroy(mem_ctx2);
+       d_state->connect_state = talloc_reference(d_state, c_state);
+       d_state->sam_ctx = c_state->sam_ctx;
+       d_state->domain_sid = dom_sid_dup(d_state, r->in.sid);
+       d_state->domain_name = talloc_strdup(d_state, domain_name);
+       d_state->domain_dn = talloc_strdup(d_state, msgs[0]->dn);
+       if (!d_state->domain_sid || !d_state->domain_name || !d_state->domain_dn) {
+               talloc_free(d_state);
                return NT_STATUS_NO_MEMORY;             
        }
-       state->access_mask = r->in.access_mask;
+       d_state->access_mask = r->in.access_mask;
 
-       h_domain = dcesrv_handle_new(dce_call->conn, SAMR_HANDLE_DOMAIN);
+       h_domain = dcesrv_handle_new(dce_call->context, SAMR_HANDLE_DOMAIN);
        if (!h_domain) {
-               talloc_destroy(mem_ctx2);
+               talloc_free(d_state);
                return NT_STATUS_NO_MEMORY;
        }
+       
+       h_domain->data = talloc_steal(h_domain, d_state);
 
-       c_state->reference_count++;
-       h_domain->data = state;
-       h_domain->destroy = samr_Domain_destroy;
        *r->out.domain_handle = h_domain->wire_handle;
 
        return NT_STATUS_OK;
 }
 
+/*
+  return DomInfo1
+*/
+static NTSTATUS samr_info_DomInfo1(struct samr_domain_state *state,
+                                  TALLOC_CTX *mem_ctx,
+                                  struct samr_DomInfo1 *info)
+{
+       const char * const attrs[] = { "minPwdLength", "pwdHistoryLength",
+                                      "pwdProperties", "maxPwdAge",
+                                      "minPwdAge", NULL };
+       int ret;
+       struct ldb_message **res;
+
+       ret = gendb_search_dn(state->sam_ctx, mem_ctx,
+                             state->domain_dn , &res, attrs);
+       if (ret != 1) {
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+       }
+
+       info->min_password_length =
+               samdb_result_uint(res[0], "minPwdLength", 0);
+       info->password_history_length =
+               samdb_result_uint(res[0], "pwdHistoryLength", 0);
+       info->password_properties = 
+               samdb_result_uint(res[0], "pwdProperties", 0);
+       info->max_password_age = 
+               samdb_result_int64(res[0], "maxPwdAge", 0);
+       info->min_password_age = 
+               samdb_result_int64(res[0], "minPwdAge", 0);
+
+       return NT_STATUS_OK;
+}
+
+/*
+  return DomInfo2
+*/
+static NTSTATUS samr_info_DomInfo2(struct samr_domain_state *state, TALLOC_CTX *mem_ctx,
+                                  struct samr_DomInfo2 *info)
+{
+       const char * const attrs[] = { "comment", "name", NULL };
+       int ret;
+       struct ldb_message **res;
+
+       ret = gendb_search_dn(state->sam_ctx, mem_ctx,
+                             state->domain_dn , &res, attrs);
+       if (ret != 1) {
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+       }
+
+       /* where is this supposed to come from? is it settable? */
+       info->force_logoff_time = 0x8000000000000000LL;
+
+       info->comment.string = samdb_result_string(res[0], "comment", NULL);
+       info->domain_name.string  = samdb_result_string(res[0], "name", NULL);
+
+       info->primary.string = lp_netbios_name();
+       info->sequence_num = 0;
+       info->role = ROLE_DOMAIN_PDC;
+       info->num_users = samdb_search_count(state->sam_ctx, mem_ctx, NULL, "(objectClass=user)");
+       info->num_groups = samdb_search_count(state->sam_ctx, mem_ctx, NULL,
+                                             "(&(objectClass=group)(sAMAccountType=%u))",
+                                             ATYPE_GLOBAL_GROUP);
+       info->num_aliases = samdb_search_count(state->sam_ctx, mem_ctx, NULL,
+                                              "(&(objectClass=group)(sAMAccountType=%u))",
+                                              ATYPE_LOCAL_GROUP);
+
+       return NT_STATUS_OK;
+}
+
+/*
+  return DomInfo3
+*/
+static NTSTATUS samr_info_DomInfo3(struct samr_domain_state *state,
+                                  TALLOC_CTX *mem_ctx,
+                                  struct samr_DomInfo3 *info)
+{
+       /* where is this supposed to come from? is it settable? */
+       info->force_logoff_time = 0x8000000000000000LL;
+
+       return NT_STATUS_OK;
+}
 
 /* 
   samr_QueryDomainInfo 
 */
 static NTSTATUS samr_QueryDomainInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
-                      struct samr_QueryDomainInfo *r)
+                                    struct samr_QueryDomainInfo *r)
 {
-       DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
+       struct dcesrv_handle *h;
+       struct samr_domain_state *d_state;
+
+       r->out.info = NULL;
+
+       DCESRV_PULL_HANDLE(h, r->in.domain_handle, SAMR_HANDLE_DOMAIN);
+
+       d_state = h->data;
+
+       r->out.info = talloc(mem_ctx, union samr_DomainInfo);
+       if (!r->out.info) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       ZERO_STRUCTP(r->out.info);
+
+       switch (r->in.level) {
+       case 1:
+               return samr_info_DomInfo1(d_state, mem_ctx,
+                                         &r->out.info->info1);
+       case 2:
+               return samr_info_DomInfo2(d_state, mem_ctx, &r->out.info->info2);
+       case 3:
+               return samr_info_DomInfo3(d_state, mem_ctx,
+                                         &r->out.info->info3);
+       }
+
+       return NT_STATUS_INVALID_INFO_CLASS;
 }
 
 
@@ -431,16 +445,6 @@ static NTSTATUS samr_SetDomainInfo(struct dcesrv_call_state *dce_call, TALLOC_CT
        DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
 }
 
-/*
-  destroy an open account context
-*/
-static void samr_Account_destroy(struct dcesrv_connection *conn, struct dcesrv_handle *h)
-{
-       struct samr_account_state *state = h->data;
-       samr_Domain_close(conn, state->domain_state);
-       talloc_destroy(state->mem_ctx);
-}
-
 /* 
   samr_CreateDomainGroup 
 */
@@ -448,33 +452,30 @@ static NTSTATUS samr_CreateDomainGroup(struct dcesrv_call_state *dce_call, TALLO
                                       struct samr_CreateDomainGroup *r)
 {
        struct samr_domain_state *d_state;
-       struct samr_account_state *state;
+       struct samr_account_state *a_state;
        struct dcesrv_handle *h;
        const char *name;
-       struct ldb_message msg;
-       uint32 rid;
-       const char *groupname, *sidstr;
-       time_t now = time(NULL);
-       TALLOC_CTX *mem_ctx2;
+       struct ldb_message *msg;
+       struct dom_sid *sid;
+       const char *groupname;
        struct dcesrv_handle *g_handle;
        int ret;
-       NTSTATUS status;
 
        ZERO_STRUCTP(r->out.group_handle);
        *r->out.rid = 0;
 
-       DCESRV_PULL_HANDLE(h, r->in.handle, SAMR_HANDLE_DOMAIN);
+       DCESRV_PULL_HANDLE(h, r->in.domain_handle, SAMR_HANDLE_DOMAIN);
 
        d_state = h->data;
 
-       groupname = r->in.name->name;
+       groupname = r->in.name->string;
 
        if (groupname == NULL) {
                return NT_STATUS_INVALID_PARAMETER;
        }
 
        /* check if the group already exists */
-       name = samdb_search_string(d_state->sam_ctx, mem_ctx, d_state->basedn
+       name = samdb_search_string(d_state->sam_ctx, mem_ctx, NULL
                                   "sAMAccountName",
                                   "(&(sAMAccountName=%s)(objectclass=group))",
                                   groupname);
@@ -482,104 +483,163 @@ static NTSTATUS samr_CreateDomainGroup(struct dcesrv_call_state *dce_call, TALLO
                return NT_STATUS_GROUP_EXISTS;
        }
 
-       ZERO_STRUCT(msg);
-
-       /* pull in all the template attributes */
-       ret = samdb_copy_template(d_state->sam_ctx, mem_ctx, &msg, 
-                                 "(&(name=TemplateGroup)(objectclass=groupTemplate))");
-       if (ret != 0) {
-               DEBUG(1,("Failed to load TemplateUser from samdb\n"));
-               return NT_STATUS_INTERNAL_DB_CORRUPTION;
-       }
-
-       /* allocate a rid */
-       status = samdb_allocate_next_id(d_state->sam_ctx, mem_ctx, 
-                                       d_state->basedn, "nextRid", &rid);
-       if (!NT_STATUS_IS_OK(status)) {
-               return status;
-       }
-
-       /* and the group SID */
-       sidstr = talloc_asprintf(mem_ctx, "%s-%u", d_state->domain_sid, rid);
-       if (!sidstr) {
+       msg = ldb_msg_new(mem_ctx);
+       if (msg == NULL) {
                return NT_STATUS_NO_MEMORY;
        }
 
        /* add core elements to the ldb_message for the user */
-       msg.dn = talloc_asprintf(mem_ctx, "CN=%s,CN=Users,%s", groupname,
-                                d_state->basedn);
-       if (!msg.dn) {
+       msg->dn = talloc_asprintf(mem_ctx, "CN=%s,CN=Users,%s", groupname,
+                                 d_state->domain_dn);
+       if (!msg->dn) {
                return NT_STATUS_NO_MEMORY;
        }
-       samdb_msg_add_string(d_state->sam_ctx, mem_ctx, &msg,
-                            "name", groupname);
-       samdb_msg_add_string(d_state->sam_ctx, mem_ctx, &msg,
-                            "cn", groupname);
-       samdb_msg_add_string(d_state->sam_ctx, mem_ctx, &msg,
-                            "sAMAccountName", groupname);
-       samdb_msg_add_string(d_state->sam_ctx, mem_ctx, &msg,
-                            "objectClass", "group");
-       samdb_msg_add_string(d_state->sam_ctx, mem_ctx, &msg,
-                            "objectSid", sidstr);
-       samdb_msg_set_ldaptime(d_state->sam_ctx, mem_ctx, &msg,
-                              "whenCreated", now);
-       samdb_msg_set_ldaptime(d_state->sam_ctx, mem_ctx, &msg,
-                              "whenChanged", now);
+       samdb_msg_add_string(d_state->sam_ctx, mem_ctx, msg, "sAMAccountName", groupname);
+       samdb_msg_add_string(d_state->sam_ctx, mem_ctx, msg, "objectClass", "group");
                             
        /* create the group */
-       ret = samdb_add(d_state->sam_ctx, mem_ctx, &msg);
+       ret = samdb_add(d_state->sam_ctx, mem_ctx, msg);
        if (ret != 0) {
-               DEBUG(1,("Failed to create group record %s\n", msg.dn));
+               DEBUG(0,("Failed to create group record %s\n", msg->dn));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
-       /* create group state and new policy handle */
-       mem_ctx2 = talloc_init("CreateDomainGroup(%s)", groupname);
-       if (!mem_ctx2) {
+       a_state = talloc(d_state, struct samr_account_state);
+       if (!a_state) {
                return NT_STATUS_NO_MEMORY;
        }
+       a_state->sam_ctx = d_state->sam_ctx;
+       a_state->access_mask = r->in.access_mask;
+       a_state->domain_state = talloc_reference(a_state, d_state);
+       a_state->account_dn = talloc_steal(a_state, msg->dn);
 
-       state = talloc_p(mem_ctx2, struct samr_account_state);
-       if (!state) {
-               return NT_STATUS_NO_MEMORY;
+       /* retrieve the sid for the group just created */
+       sid = samdb_search_dom_sid(d_state->sam_ctx, a_state,
+                                  msg->dn, "objectSid", "dn=%s", msg->dn);
+       if (sid == NULL) {
+               return NT_STATUS_UNSUCCESSFUL;
        }
-       state->mem_ctx = mem_ctx2;
-       state->sam_ctx = d_state->sam_ctx;
-       state->access_mask = r->in.access_mask;
-       state->domain_state = d_state;
-       state->basedn = talloc_steal(mem_ctx, mem_ctx2, msg.dn);
-       state->account_sid = talloc_strdup(mem_ctx2, sidstr);
-       state->account_name = talloc_strdup(mem_ctx2, groupname);
-       if (!state->account_name || !state->account_sid) {
+
+       a_state->account_name = talloc_strdup(a_state, groupname);
+       if (!a_state->account_name) {
                return NT_STATUS_NO_MEMORY;
        }
 
        /* create the policy handle */
-       g_handle = dcesrv_handle_new(dce_call->conn, SAMR_HANDLE_GROUP);
+       g_handle = dcesrv_handle_new(dce_call->context, SAMR_HANDLE_GROUP);
        if (!g_handle) {
                return NT_STATUS_NO_MEMORY;
        }
 
-       g_handle->data = state;
-       g_handle->destroy = samr_Account_destroy;
-
-       /* the domain state is in use one more time */
-       d_state->reference_count++;
+       g_handle->data = talloc_steal(g_handle, a_state);
 
        *r->out.group_handle = g_handle->wire_handle;
-       *r->out.rid = rid;      
+       *r->out.rid = sid->sub_auths[sid->num_auths-1];
 
        return NT_STATUS_OK;
 }
 
 
+/*
+  comparison function for sorting SamEntry array
+*/
+static int compare_SamEntry(struct samr_SamEntry *e1, struct samr_SamEntry *e2)
+{
+       return e1->idx - e2->idx;
+}
+
 /* 
   samr_EnumDomainGroups 
 */
 static NTSTATUS samr_EnumDomainGroups(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                                      struct samr_EnumDomainGroups *r)
 {
-       DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
+       struct dcesrv_handle *h;
+       struct samr_domain_state *d_state;
+       struct ldb_message **res;
+       int ldb_cnt, count, i, first;
+       struct samr_SamEntry *entries;
+       const char * const attrs[3] = { "objectSid", "sAMAccountName", NULL };
+
+       *r->out.resume_handle = 0;
+       r->out.sam = NULL;
+       r->out.num_entries = 0;
+
+       DCESRV_PULL_HANDLE(h, r->in.domain_handle, SAMR_HANDLE_DOMAIN);
+
+       d_state = h->data;
+
+       /* search for all domain groups in this domain. This could possibly be
+          cached and resumed based on resume_key */
+       ldb_cnt = samdb_search_domain(d_state->sam_ctx, mem_ctx,
+                                     d_state->domain_dn, &res, attrs,
+                                     d_state->domain_sid,
+                                     "(&(grouptype=%s)(objectclass=group))",
+                                     ldb_hexstr(mem_ctx,
+                                                GTYPE_SECURITY_GLOBAL_GROUP));
+       if (ldb_cnt == -1) {
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+       }
+       if (ldb_cnt == 0 || r->in.max_size == 0) {
+               return NT_STATUS_OK;
+       }
+
+       /* convert to SamEntry format */
+       entries = talloc_array(mem_ctx, struct samr_SamEntry, ldb_cnt);
+       if (!entries) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       count = 0;
+
+       for (i=0;i<ldb_cnt;i++) {
+               struct dom_sid *group_sid;
+
+               group_sid = samdb_result_dom_sid(mem_ctx, res[i],
+                                                "objectSid");
+               if (group_sid == NULL)
+                       continue;
+
+               entries[count].idx =
+                       group_sid->sub_auths[group_sid->num_auths-1];
+               entries[count].name.string =
+                       samdb_result_string(res[i], "sAMAccountName", "");
+               count += 1;
+       }
+
+       /* sort the results by rid */
+       qsort(entries, count, sizeof(struct samr_SamEntry), 
+             (comparison_fn_t)compare_SamEntry);
+
+       /* find the first entry to return */
+       for (first=0;
+            first<count && entries[first].idx <= *r->in.resume_handle;
+            first++) ;
+
+       if (first == count) {
+               return NT_STATUS_OK;
+       }
+
+       /* return the rest, limit by max_size. Note that we 
+          use the w2k3 element size value of 54 */
+       r->out.num_entries = count - first;
+       r->out.num_entries = MIN(r->out.num_entries, 
+                                1+(r->in.max_size/SAMR_ENUM_USERS_MULTIPLIER));
+
+       r->out.sam = talloc(mem_ctx, struct samr_SamArray);
+       if (!r->out.sam) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       r->out.sam->entries = entries+first;
+       r->out.sam->count = r->out.num_entries;
+
+       if (r->out.num_entries < count - first) {
+               *r->out.resume_handle = entries[first+r->out.num_entries-1].idx;
+               return STATUS_MORE_ENTRIES;
+       }
+
+       return NT_STATUS_OK;
 }
 
 
@@ -592,119 +652,125 @@ static NTSTATUS samr_CreateUser2(struct dcesrv_call_state *dce_call, TALLOC_CTX
                                 struct samr_CreateUser2 *r)
 {
        struct samr_domain_state *d_state;
-       struct samr_account_state *state;
+       struct samr_account_state *a_state;
        struct dcesrv_handle *h;
        const char *name;
-       struct ldb_message msg;
-       uint32 rid;
-       const char *username, *sidstr;
-       time_t now = time(NULL);
-       TALLOC_CTX *mem_ctx2;
+       struct ldb_message *msg;
+       struct dom_sid *sid;
+       const char *account_name;
        struct dcesrv_handle *u_handle;
        int ret;
-       NTSTATUS status;
+       const char *container, *obj_class=NULL;
+       char *cn_name;
+       int cn_name_len;
 
-       ZERO_STRUCTP(r->out.acct_handle);
+       ZERO_STRUCTP(r->out.user_handle);
        *r->out.access_granted = 0;
        *r->out.rid = 0;
 
-       DCESRV_PULL_HANDLE(h, r->in.handle, SAMR_HANDLE_DOMAIN);
+       DCESRV_PULL_HANDLE(h, r->in.domain_handle, SAMR_HANDLE_DOMAIN);
 
        d_state = h->data;
 
-       username = r->in.username->name;
+       account_name = r->in.account_name->string;
 
-       if (username == NULL) {
+       if (account_name == NULL) {
                return NT_STATUS_INVALID_PARAMETER;
        }
 
        /* check if the user already exists */
-       name = samdb_search_string(d_state->sam_ctx, mem_ctx, d_state->basedn
+       name = samdb_search_string(d_state->sam_ctx, mem_ctx, NULL
                                   "sAMAccountName", 
-                                  "(&(sAMAccountName=%s)(objectclass=user))", username);
+                                  "(&(sAMAccountName=%s)(objectclass=user))", account_name);
        if (name != NULL) {
                return NT_STATUS_USER_EXISTS;
        }
 
-       ZERO_STRUCT(msg);
-
-       /* pull in all the template attributes */
-       ret = samdb_copy_template(d_state->sam_ctx, mem_ctx, &msg, 
-                                 "(&(name=TemplateUser)(objectclass=userTemplate))");
-       if (ret != 0) {
-               DEBUG(1,("Failed to load TemplateUser from samdb\n"));
-               return NT_STATUS_INTERNAL_DB_CORRUPTION;
-       }
-       
-       /* allocate a rid */
-       status = samdb_allocate_next_id(d_state->sam_ctx, mem_ctx, 
-                                       d_state->basedn, "nextRid", &rid);
-       if (!NT_STATUS_IS_OK(status)) {
-               return status;
+       msg = ldb_msg_new(mem_ctx);
+       if (msg == NULL) {
+               return NT_STATUS_NO_MEMORY;
        }
 
-       /* and the users SID */
-       sidstr = talloc_asprintf(mem_ctx, "%s-%u", d_state->domain_sid, rid);
-       if (!sidstr) {
-               return NT_STATUS_NO_MEMORY;
+       cn_name   = talloc_strdup(mem_ctx, account_name);
+       NT_STATUS_HAVE_NO_MEMORY(cn_name);
+       cn_name_len = strlen(cn_name);
+
+       /* This must be one of these values *only* */
+       if (r->in.acct_flags == ACB_NORMAL) {
+               container = "Users";
+               obj_class = "user";
+
+       } else if (r->in.acct_flags == ACB_WSTRUST) {
+               if (cn_name[cn_name_len - 1] != '$') {
+                       return NT_STATUS_FOOBAR;
+               }
+               cn_name[cn_name_len - 1] = '\0';
+               container = "Computers";
+               obj_class = "computer";
+
+       } else if (r->in.acct_flags == ACB_SVRTRUST) {
+               if (cn_name[cn_name_len - 1] != '$') {
+                       return NT_STATUS_FOOBAR;                
+               }
+               cn_name[cn_name_len - 1] = '\0';
+               container = "Domain Controllers";
+               obj_class = "computer";
+
+       } else if (r->in.acct_flags == ACB_DOMTRUST) {
+               container = "Users";
+               obj_class = "user";
+
+       } else {
+               return NT_STATUS_INVALID_PARAMETER;
        }
 
        /* add core elements to the ldb_message for the user */
-       msg.dn = talloc_asprintf(mem_ctx, "CN=%s,CN=Users,%s", username, d_state->basedn);
-       if (!msg.dn) {
+       msg->dn = talloc_asprintf(mem_ctx, "CN=%s,CN=%s,%s", cn_name, container, d_state->domain_dn);
+       if (!msg->dn) {
                return NT_STATUS_NO_MEMORY;             
        }
-       samdb_msg_add_string(d_state->sam_ctx, mem_ctx, &msg, "name", username);
-       samdb_msg_add_string(d_state->sam_ctx, mem_ctx, &msg, "cn", username);
-       samdb_msg_add_string(d_state->sam_ctx, mem_ctx, &msg, "sAMAccountName", username);
-       samdb_msg_add_string(d_state->sam_ctx, mem_ctx, &msg, "objectClass", "user");
-       samdb_msg_add_string(d_state->sam_ctx, mem_ctx, &msg, "objectSid", sidstr);
-       samdb_msg_set_ldaptime(d_state->sam_ctx, mem_ctx, &msg, "whenCreated", now);
-       samdb_msg_set_ldaptime(d_state->sam_ctx, mem_ctx, &msg, "whenChanged", now);
-
+       samdb_msg_add_string(d_state->sam_ctx, mem_ctx, msg, "sAMAccountName", account_name);
+       samdb_msg_add_string(d_state->sam_ctx, mem_ctx, msg, "objectClass", obj_class);
        /* create the user */
-       ret = samdb_add(d_state->sam_ctx, mem_ctx, &msg);
+       ret = samdb_add(d_state->sam_ctx, mem_ctx, msg);
        if (ret != 0) {
-               DEBUG(1,("Failed to create user record %s\n", msg.dn));
+               DEBUG(0,("Failed to create user record %s\n", msg->dn));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
-       /* create user state and new policy handle */
-       mem_ctx2 = talloc_init("CreateUser(%s)", username);
-       if (!mem_ctx2) {
+       a_state = talloc(d_state, struct samr_account_state);
+       if (!a_state) {
                return NT_STATUS_NO_MEMORY;
        }
+       a_state->sam_ctx = d_state->sam_ctx;
+       a_state->access_mask = r->in.access_mask;
+       a_state->domain_state = talloc_reference(a_state, d_state);
+       a_state->account_dn = talloc_steal(a_state, msg->dn);
 
-       state = talloc_p(mem_ctx2, struct samr_account_state);
-       if (!state) {
-               return NT_STATUS_NO_MEMORY;
+       /* retrieve the sid for the user just created */
+       sid = samdb_search_dom_sid(d_state->sam_ctx, a_state,
+                                  msg->dn, "objectSid", "dn=%s", msg->dn);
+       if (sid == NULL) {
+               return NT_STATUS_UNSUCCESSFUL;
        }
-       state->mem_ctx = mem_ctx2;
-       state->sam_ctx = d_state->sam_ctx;
-       state->access_mask = r->in.access_mask;
-       state->domain_state = d_state;
-       state->basedn = talloc_steal(mem_ctx, mem_ctx2, msg.dn);
-       state->account_sid = talloc_strdup(mem_ctx2, sidstr);
-       state->account_name = talloc_strdup(mem_ctx2, username);
-       if (!state->account_name || !state->account_sid) {
+
+       a_state->account_name = talloc_strdup(a_state, account_name);
+       if (!a_state->account_name) {
                return NT_STATUS_NO_MEMORY;
        }
 
        /* create the policy handle */
-       u_handle = dcesrv_handle_new(dce_call->conn, SAMR_HANDLE_USER);
+       u_handle = dcesrv_handle_new(dce_call->context, SAMR_HANDLE_USER);
        if (!u_handle) {
                return NT_STATUS_NO_MEMORY;
        }
 
-       u_handle->data = state;
-       u_handle->destroy = samr_Account_destroy;
-
-       /* the domain state is in use one more time */
-       d_state->reference_count++;
+       u_handle->data = talloc_steal(u_handle, a_state);
 
-       *r->out.acct_handle = u_handle->wire_handle;
+       *r->out.user_handle = u_handle->wire_handle;
        *r->out.access_granted = 0xf07ff; /* TODO: fix access mask calculations */
-       *r->out.rid = rid;      
+
+       *r->out.rid = sid->sub_auths[sid->num_auths-1];
 
        return NT_STATUS_OK;
 }
@@ -717,29 +783,21 @@ static NTSTATUS samr_CreateUser(struct dcesrv_call_state *dce_call, TALLOC_CTX *
                                struct samr_CreateUser *r)
 {
        struct samr_CreateUser2 r2;
-       uint32 access_granted;
+       uint32_t access_granted = 0;
 
 
        /* a simple wrapper around samr_CreateUser2 works nicely */
-       r2.in.handle = r->in.handle;
-       r2.in.username = r->in.username;
-       r2.in.acct_flags = 1234;
+       r2.in.domain_handle = r->in.domain_handle;
+       r2.in.account_name = r->in.account_name;
+       r2.in.acct_flags = ACB_NORMAL;
        r2.in.access_mask = r->in.access_mask;
-       r2.out.acct_handle = r->out.acct_handle;
+       r2.out.user_handle = r->out.user_handle;
        r2.out.access_granted = &access_granted;
        r2.out.rid = r->out.rid;
 
        return samr_CreateUser2(dce_call, mem_ctx, &r2);
 }
 
-/*
-  comparison function for sorting SamEntry array
-*/
-static int compare_SamEntry(struct samr_SamEntry *e1, struct samr_SamEntry *e2)
-{
-       return e1->idx - e2->idx;
-}
-
 /* 
   samr_EnumDomainUsers 
 */
@@ -747,7 +805,7 @@ static NTSTATUS samr_EnumDomainUsers(struct dcesrv_call_state *dce_call, TALLOC_
                                     struct samr_EnumDomainUsers *r)
 {
        struct dcesrv_handle *h;
-       struct samr_domain_state *state;
+       struct samr_domain_state *d_state;
        struct ldb_message **res;
        int count, i, first;
        struct samr_SamEntry *entries;
@@ -757,13 +815,13 @@ static NTSTATUS samr_EnumDomainUsers(struct dcesrv_call_state *dce_call, TALLOC_
        r->out.sam = NULL;
        r->out.num_entries = 0;
 
-       DCESRV_PULL_HANDLE(h, r->in.handle, SAMR_HANDLE_DOMAIN);
+       DCESRV_PULL_HANDLE(h, r->in.domain_handle, SAMR_HANDLE_DOMAIN);
 
-       state = h->data;
+       d_state = h->data;
        
        /* search for all users in this domain. This could possibly be cached and 
           resumed based on resume_key */
-       count = samdb_search(state->sam_ctx, mem_ctx, state->basedn, &res, attrs, 
+       count = gendb_search(d_state->sam_ctx, mem_ctx, d_state->domain_dn, &res, attrs, 
                             "objectclass=user");
        if (count == -1) {
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
@@ -773,13 +831,13 @@ static NTSTATUS samr_EnumDomainUsers(struct dcesrv_call_state *dce_call, TALLOC_
        }
 
        /* convert to SamEntry format */
-       entries = talloc_array_p(mem_ctx, struct samr_SamEntry, count);
+       entries = talloc_array(mem_ctx, struct samr_SamEntry, count);
        if (!entries) {
                return NT_STATUS_NO_MEMORY;
        }
        for (i=0;i<count;i++) {
                entries[i].idx = samdb_result_rid_from_sid(mem_ctx, res[i], "objectSid", 0);
-               entries[i].name.name = samdb_result_string(res[i], "sAMAccountName", "");
+               entries[i].name.string = samdb_result_string(res[i], "sAMAccountName", "");
        }
 
        /* sort the results by rid */
@@ -801,7 +859,7 @@ static NTSTATUS samr_EnumDomainUsers(struct dcesrv_call_state *dce_call, TALLOC_
        r->out.num_entries = MIN(r->out.num_entries, 
                                 1+(r->in.max_size/SAMR_ENUM_USERS_MULTIPLIER));
 
-       r->out.sam = talloc_p(mem_ctx, struct samr_SamArray);
+       r->out.sam = talloc(mem_ctx, struct samr_SamArray);
        if (!r->out.sam) {
                return NT_STATUS_NO_MEMORY;
        }
@@ -824,17 +882,190 @@ static NTSTATUS samr_EnumDomainUsers(struct dcesrv_call_state *dce_call, TALLOC_
 static NTSTATUS samr_CreateDomAlias(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_CreateDomAlias *r)
 {
-       DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
-}
+       struct samr_domain_state *d_state;
+       struct samr_account_state *a_state;
+       struct dcesrv_handle *h;
+       const char *alias_name, *name;
+       struct ldb_message *msg;
+       struct dom_sid *sid;
+       struct dcesrv_handle *a_handle;
+       int ret;
 
+       ZERO_STRUCTP(r->out.alias_handle);
+       *r->out.rid = 0;
 
-/* 
-  samr_EnumDomainAliases 
-*/
-static NTSTATUS samr_EnumDomainAliases(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
-                      struct samr_EnumDomainAliases *r)
+       DCESRV_PULL_HANDLE(h, r->in.domain_handle, SAMR_HANDLE_DOMAIN);
+
+       d_state = h->data;
+
+       alias_name = r->in.alias_name->string;
+
+       if (alias_name == NULL) {
+               return NT_STATUS_INVALID_PARAMETER;
+       }
+
+       /* Check if alias already exists */
+       name = samdb_search_string(d_state->sam_ctx, mem_ctx, NULL,
+                                  "sAMAccountName",
+                                  "(sAMAccountName=%s)(objectclass=group))",
+                                  alias_name);
+
+       if (name != NULL) {
+               return NT_STATUS_ALIAS_EXISTS;
+       }
+
+       msg = ldb_msg_new(mem_ctx);
+       if (msg == NULL) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       /* add core elements to the ldb_message for the alias */
+       msg->dn = talloc_asprintf(mem_ctx, "CN=%s,CN=Users,%s", alias_name,
+                                d_state->domain_dn);
+       if (!msg->dn) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       samdb_msg_add_string(d_state->sam_ctx, mem_ctx, msg, "sAMAccountName", alias_name);
+       samdb_msg_add_string(d_state->sam_ctx, mem_ctx, msg, "objectClass", "group");
+       samdb_msg_add_string(d_state->sam_ctx, mem_ctx, msg, "groupType", "0x80000004");
+
+       /* create the alias */
+       ret = samdb_add(d_state->sam_ctx, mem_ctx, msg);
+       if (ret != 0) {
+               DEBUG(0,("Failed to create alias record %s\n", msg->dn));
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+       }
+
+       a_state = talloc(d_state, struct samr_account_state);
+       if (!a_state) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       a_state->sam_ctx = d_state->sam_ctx;
+       a_state->access_mask = r->in.access_mask;
+       a_state->domain_state = talloc_reference(a_state, d_state);
+       a_state->account_dn = talloc_steal(a_state, msg->dn);
+
+       /* retrieve the sid for the alias just created */
+       sid = samdb_search_dom_sid(d_state->sam_ctx, a_state,
+                                  msg->dn, "objectSid", "dn=%s", msg->dn);
+
+       a_state->account_name = talloc_strdup(a_state, alias_name);
+       if (!a_state->account_name) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       /* create the policy handle */
+       a_handle = dcesrv_handle_new(dce_call->context, SAMR_HANDLE_ALIAS);
+       if (a_handle == NULL)
+               return NT_STATUS_NO_MEMORY;
+
+       a_handle->data = talloc_steal(a_handle, a_state);
+
+       *r->out.alias_handle = a_handle->wire_handle;
+
+       *r->out.rid = sid->sub_auths[sid->num_auths-1];
+
+       return NT_STATUS_OK;
+}
+
+
+/* 
+  samr_EnumDomainAliases 
+*/
+static NTSTATUS samr_EnumDomainAliases(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+                      struct samr_EnumDomainAliases *r)
 {
-       DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
+       struct dcesrv_handle *h;
+       struct samr_domain_state *d_state;
+       struct ldb_message **res;
+       int ldb_cnt, count, i, first;
+       struct samr_SamEntry *entries;
+       const char * const attrs[3] = { "objectSid", "sAMAccountName", NULL };
+
+       *r->out.resume_handle = 0;
+       r->out.sam = NULL;
+       r->out.num_entries = 0;
+
+       DCESRV_PULL_HANDLE(h, r->in.domain_handle, SAMR_HANDLE_DOMAIN);
+
+       d_state = h->data;
+
+       /* search for all domain groups in this domain. This could possibly be
+          cached and resumed based on resume_key */
+       ldb_cnt = samdb_search_domain(d_state->sam_ctx, mem_ctx,
+                                     d_state->domain_dn,
+                                     &res, attrs, 
+                                     d_state->domain_sid,
+                                     "(&(|(grouptype=%s)(grouptype=%s)))"
+                                     "(objectclass=group))",
+                                     ldb_hexstr(mem_ctx,
+                                                GTYPE_SECURITY_BUILTIN_LOCAL_GROUP),
+                                     ldb_hexstr(mem_ctx,
+                                                GTYPE_SECURITY_DOMAIN_LOCAL_GROUP));
+       if (ldb_cnt == -1) {
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+       }
+       if (ldb_cnt == 0) {
+               return NT_STATUS_OK;
+       }
+
+       /* convert to SamEntry format */
+       entries = talloc_array(mem_ctx, struct samr_SamEntry, ldb_cnt);
+       if (!entries) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       count = 0;
+
+       for (i=0;i<ldb_cnt;i++) {
+               struct dom_sid *alias_sid;
+
+               alias_sid = samdb_result_dom_sid(mem_ctx, res[i],
+                                                "objectSid");
+
+               if (alias_sid == NULL)
+                       continue;
+
+               entries[count].idx =
+                       alias_sid->sub_auths[alias_sid->num_auths-1];
+               entries[count].name.string =
+                       samdb_result_string(res[i], "sAMAccountName", "");
+               count += 1;
+       }
+
+       /* sort the results by rid */
+       qsort(entries, count, sizeof(struct samr_SamEntry), 
+             (comparison_fn_t)compare_SamEntry);
+
+       /* find the first entry to return */
+       for (first=0;
+            first<count && entries[first].idx <= *r->in.resume_handle;
+            first++) ;
+
+       if (first == count) {
+               return NT_STATUS_OK;
+       }
+
+       r->out.num_entries = count - first;
+       r->out.num_entries = MIN(r->out.num_entries, 1000);
+
+       r->out.sam = talloc(mem_ctx, struct samr_SamArray);
+       if (!r->out.sam) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       r->out.sam->entries = entries+first;
+       r->out.sam->count = r->out.num_entries;
+
+       if (r->out.num_entries < count - first) {
+               *r->out.resume_handle =
+                       entries[first+r->out.num_entries-1].idx;
+               return STATUS_MORE_ENTRIES;
+       }
+
+       return NT_STATUS_OK;
 }
 
 
@@ -844,7 +1075,76 @@ static NTSTATUS samr_EnumDomainAliases(struct dcesrv_call_state *dce_call, TALLO
 static NTSTATUS samr_GetAliasMembership(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_GetAliasMembership *r)
 {
-       DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
+       struct dcesrv_handle *h;
+       struct samr_domain_state *d_state;
+       struct ldb_message **res;
+       int i, count = 0;
+
+       DCESRV_PULL_HANDLE(h, r->in.domain_handle, SAMR_HANDLE_DOMAIN);
+
+       d_state = h->data;
+
+       if (r->in.sids->num_sids > 0) {
+               const char *filter;
+               const char * const attrs[2] = { "objectSid", NULL };
+
+               filter = talloc_asprintf(mem_ctx,
+                                        "(&(|(grouptype=%s)(grouptype=%s))"
+                                        "(objectclass=group)(|",
+                                        ldb_hexstr(mem_ctx,
+                                                   GTYPE_SECURITY_BUILTIN_LOCAL_GROUP),
+                                        ldb_hexstr(mem_ctx,
+                                                   GTYPE_SECURITY_DOMAIN_LOCAL_GROUP));
+               if (filter == NULL)
+                       return NT_STATUS_NO_MEMORY;
+
+               for (i=0; i<r->in.sids->num_sids; i++) {
+                       const char *memberdn;
+
+                       memberdn = 
+                               samdb_search_string(d_state->sam_ctx,
+                                                   mem_ctx, NULL, "dn",
+                                                   "(objectSid=%s)",
+                                                   ldap_encode_ndr_dom_sid(mem_ctx, 
+                                                                           r->in.sids->sids[i].sid));
+
+                       if (memberdn == NULL)
+                               continue;
+
+                       filter = talloc_asprintf(mem_ctx, "%s(member=%s)",
+                                                filter, memberdn);
+                       if (filter == NULL)
+                               return NT_STATUS_NO_MEMORY;
+               }
+
+               count = samdb_search_domain(d_state->sam_ctx, mem_ctx,
+                                           d_state->domain_dn, &res, attrs,
+                                           d_state->domain_sid, "%s))", filter);
+               if (count < 0)
+                       return NT_STATUS_INTERNAL_DB_CORRUPTION;
+       }
+
+       r->out.rids->count = 0;
+       r->out.rids->ids = talloc_array(mem_ctx, uint32_t, count);
+       if (r->out.rids->ids == NULL)
+               return NT_STATUS_NO_MEMORY;
+
+       for (i=0; i<count; i++) {
+               struct dom_sid *alias_sid;
+
+               alias_sid = samdb_result_dom_sid(mem_ctx, res[i], "objectSid");
+
+               if (alias_sid == NULL) {
+                       DEBUG(0, ("Could not find objectSid\n"));
+                       continue;
+               }
+
+               r->out.rids->ids[r->out.rids->count] =
+                       alias_sid->sub_auths[alias_sid->num_auths-1];
+               r->out.rids->count += 1;
+       }
+
+       return NT_STATUS_OK;
 }
 
 
@@ -855,7 +1155,7 @@ static NTSTATUS samr_LookupNames(struct dcesrv_call_state *dce_call, TALLOC_CTX
                                 struct samr_LookupNames *r)
 {
        struct dcesrv_handle *h;
-       struct samr_domain_state *state;
+       struct samr_domain_state *d_state;
        int i;
        NTSTATUS status = NT_STATUS_OK;
        const char * const attrs[] = { "sAMAccountType", "objectSid", NULL };
@@ -864,16 +1164,16 @@ static NTSTATUS samr_LookupNames(struct dcesrv_call_state *dce_call, TALLOC_CTX
        ZERO_STRUCT(r->out.rids);
        ZERO_STRUCT(r->out.types);
 
-       DCESRV_PULL_HANDLE(h, r->in.handle, SAMR_HANDLE_DOMAIN);
+       DCESRV_PULL_HANDLE(h, r->in.domain_handle, SAMR_HANDLE_DOMAIN);
 
-       state = h->data;
+       d_state = h->data;
 
        if (r->in.num_names == 0) {
                return NT_STATUS_OK;
        }
 
-       r->out.rids.ids = talloc_array_p(mem_ctx, uint32, r->in.num_names);
-       r->out.types.ids = talloc_array_p(mem_ctx, uint32, r->in.num_names);
+       r->out.rids.ids = talloc_array(mem_ctx, uint32_t, r->in.num_names);
+       r->out.types.ids = talloc_array(mem_ctx, uint32_t, r->in.num_names);
        if (!r->out.rids.ids || !r->out.types.ids) {
                return NT_STATUS_NO_MEMORY;
        }
@@ -882,50 +1182,34 @@ static NTSTATUS samr_LookupNames(struct dcesrv_call_state *dce_call, TALLOC_CTX
 
        for (i=0;i<r->in.num_names;i++) {
                struct ldb_message **res;
-               struct dom_sid2 *sid;
-               const char *sidstr;
-               uint32 atype, rtype;
+               struct dom_sid *sid;
+               uint32_t atype, rtype;
 
                r->out.rids.ids[i] = 0;
                r->out.types.ids[i] = SID_NAME_UNKNOWN;
 
-               count = samdb_search(state->sam_ctx, mem_ctx, state->basedn, &res, attrs, 
-                                    "sAMAccountName=%s", r->in.names[i].name);
+               count = gendb_search(d_state->sam_ctx, mem_ctx, d_state->domain_dn, &res, attrs, 
+                                    "sAMAccountName=%s", r->in.names[i].string);
                if (count != 1) {
                        status = STATUS_SOME_UNMAPPED;
                        continue;
                }
 
-               sidstr = samdb_result_string(res[0], "objectSid", NULL);
-               if (sidstr == NULL) {
-                       status = STATUS_SOME_UNMAPPED;
-                       continue;
-               }
-               
-               sid = dom_sid_parse_talloc(mem_ctx, sidstr);
+               sid = samdb_result_dom_sid(mem_ctx, res[0], "objectSid");
                if (sid == NULL) {
                        status = STATUS_SOME_UNMAPPED;
                        continue;
                }
-
+               
                atype = samdb_result_uint(res[0], "sAMAccountType", 0);
                if (atype == 0) {
                        status = STATUS_SOME_UNMAPPED;
                        continue;
                }
 
-               switch (atype & 0xF0000000) {
-               case ATYPE_ACCOUNT:
-                       rtype = SID_NAME_USER;
-                       break;
-               case ATYPE_GLOBAL_GROUP:
-                       rtype = SID_NAME_DOM_GRP;
-                       break;
-               case ATYPE_LOCAL_GROUP:
-                       rtype = SID_NAME_ALIAS;
-                       break;
-               default:
-                       DEBUG(1,("Unknown sAMAccountType 0x%08x\n", atype));
+               rtype = samdb_atype_map(atype);
+               
+               if (rtype == SID_NAME_UNKNOWN) {
                        status = STATUS_SOME_UNMAPPED;
                        continue;
                }
@@ -945,7 +1229,82 @@ static NTSTATUS samr_LookupNames(struct dcesrv_call_state *dce_call, TALLOC_CTX
 static NTSTATUS samr_LookupRids(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_LookupRids *r)
 {
-       DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
+       struct dcesrv_handle *h;
+       struct samr_domain_state *d_state;
+       int i, total;
+       NTSTATUS status = NT_STATUS_OK;
+       struct lsa_String *names;
+       uint32_t *ids;
+
+       ZERO_STRUCT(r->out.names);
+       ZERO_STRUCT(r->out.types);
+
+       DCESRV_PULL_HANDLE(h, r->in.domain_handle, SAMR_HANDLE_DOMAIN);
+
+       d_state = h->data;
+
+       if (r->in.num_rids == 0)
+               return NT_STATUS_OK;
+
+       names = talloc_array(mem_ctx, struct lsa_String, r->in.num_rids);
+       ids = talloc_array(mem_ctx, uint32_t, r->in.num_rids);
+
+       if ((names == NULL) || (ids == NULL))
+               return NT_STATUS_NO_MEMORY;
+
+       total = 0;
+
+       for (i=0; i<r->in.num_rids; i++) {
+               struct ldb_message **res;
+               int count;
+               const char * const attrs[] = {  "sAMAccountType",
+                                               "sAMAccountName", NULL };
+               uint32_t atype;
+               struct dom_sid *sid;
+
+               ids[i] = SID_NAME_UNKNOWN;
+
+               sid = dom_sid_add_rid(mem_ctx, d_state->domain_sid, r->in.rids[i]);
+               if (sid == NULL) {
+                       names[i].string = NULL;
+                       status = STATUS_SOME_UNMAPPED;
+                       continue;
+               }
+               
+               count = gendb_search(d_state->sam_ctx, mem_ctx,
+                                    d_state->domain_dn, &res, attrs,
+                                    "(objectSid=%s)", 
+                                    ldap_encode_ndr_dom_sid(mem_ctx, sid));
+               if (count != 1) {
+                       names[i].string = NULL;
+                       status = STATUS_SOME_UNMAPPED;
+                       continue;
+               }
+
+               names[i].string = samdb_result_string(res[0], "sAMAccountName",
+                                                     NULL);
+
+               atype = samdb_result_uint(res[0], "sAMAccountType", 0);
+               if (atype == 0) {
+                       status = STATUS_SOME_UNMAPPED;
+                       continue;
+               }
+
+               ids[i] = samdb_atype_map(atype);
+               
+               if (ids[i] == SID_NAME_UNKNOWN) {
+                       status = STATUS_SOME_UNMAPPED;
+                       continue;
+               }
+       }
+
+       r->out.names.names = names;
+       r->out.names.count = r->in.num_rids;
+
+       r->out.types.ids = ids;
+       r->out.types.count = r->in.num_rids;
+
+       return status;
 }
 
 
@@ -956,80 +1315,74 @@ static NTSTATUS samr_OpenGroup(struct dcesrv_call_state *dce_call, TALLOC_CTX *m
                       struct samr_OpenGroup *r)
 {
        struct samr_domain_state *d_state;
-       struct samr_account_state *state;
+       struct samr_account_state *a_state;
        struct dcesrv_handle *h;
-       const char *groupname, *sidstr;
-       TALLOC_CTX *mem_ctx2;
+       const char *groupname;
+       struct dom_sid *sid;
        struct ldb_message **msgs;
        struct dcesrv_handle *g_handle;
        const char * const attrs[2] = { "sAMAccountName", NULL };
        int ret;
 
-       ZERO_STRUCTP(r->out.acct_handle);
+       ZERO_STRUCTP(r->out.group_handle);
 
-       DCESRV_PULL_HANDLE(h, r->in.handle, SAMR_HANDLE_DOMAIN);
+       DCESRV_PULL_HANDLE(h, r->in.domain_handle, SAMR_HANDLE_DOMAIN);
 
        d_state = h->data;
 
        /* form the group SID */
-       sidstr = talloc_asprintf(mem_ctx, "%s-%u", d_state->domain_sid, r->in.rid);
-       if (!sidstr) {
+       sid = dom_sid_add_rid(mem_ctx, d_state->domain_sid, r->in.rid);
+       if (!sid) {
                return NT_STATUS_NO_MEMORY;
        }
 
        /* search for the group record */
-       ret = samdb_search(d_state->sam_ctx,
-                          mem_ctx, d_state->basedn, &msgs, attrs,
-                          "(&(objectSid=%s)(objectclass=group))", 
-                          sidstr);
+       ret = gendb_search(d_state->sam_ctx,
+                          mem_ctx, d_state->domain_dn, &msgs, attrs,
+                          "(&(objectSid=%s)(objectclass=group)"
+                          "(grouptype=%s))",
+                          ldap_encode_ndr_dom_sid(mem_ctx, sid),
+                          ldb_hexstr(mem_ctx,
+                                     GTYPE_SECURITY_GLOBAL_GROUP));
        if (ret == 0) {
                return NT_STATUS_NO_SUCH_GROUP;
        }
        if (ret != 1) {
-               DEBUG(1,("Found %d records matching sid %s\n", ret, sidstr));
+               DEBUG(0,("Found %d records matching sid %s\n", 
+                        ret, dom_sid_string(mem_ctx, sid)));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
        groupname = samdb_result_string(msgs[0], "sAMAccountName", NULL);
        if (groupname == NULL) {
-               DEBUG(1,("sAMAccountName field missing for sid %s\n", sidstr));
+               DEBUG(0,("sAMAccountName field missing for sid %s\n", 
+                        dom_sid_string(mem_ctx, sid)));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
-       /* create group state and new policy handle */
-       mem_ctx2 = talloc_init("OpenGroup(%u)", r->in.rid);
-       if (!mem_ctx2) {
-               return NT_STATUS_NO_MEMORY;
-       }
-
-       state = talloc_p(mem_ctx2, struct samr_account_state);
-       if (!state) {
+       a_state = talloc(d_state, struct samr_account_state);
+       if (!a_state) {
                return NT_STATUS_NO_MEMORY;
        }
-       state->mem_ctx = mem_ctx2;
-       state->sam_ctx = d_state->sam_ctx;
-       state->access_mask = r->in.access_mask;
-       state->domain_state = d_state;
-       state->basedn = talloc_steal(mem_ctx, mem_ctx2, msgs[0]->dn);
-       state->account_sid = talloc_strdup(mem_ctx2, sidstr);
-       state->account_name = talloc_strdup(mem_ctx2, groupname);
-       if (!state->account_name || !state->account_sid) {
+       a_state->sam_ctx = d_state->sam_ctx;
+       a_state->access_mask = r->in.access_mask;
+       a_state->domain_state = talloc_reference(a_state, d_state);
+       a_state->account_dn = talloc_steal(a_state, msgs[0]->dn);
+       a_state->account_sid = talloc_steal(a_state, sid);
+       a_state->account_name = talloc_strdup(a_state, groupname);
+       if (!a_state->account_name) {
                return NT_STATUS_NO_MEMORY;
        }
 
        /* create the policy handle */
-       g_handle = dcesrv_handle_new(dce_call->conn, SAMR_HANDLE_GROUP);
+       g_handle = dcesrv_handle_new(dce_call->context, SAMR_HANDLE_GROUP);
        if (!g_handle) {
                return NT_STATUS_NO_MEMORY;
        }
 
-       g_handle->data = state;
-       g_handle->destroy = samr_Account_destroy;
-
-       /* the domain state is in use one more time */
-       d_state->reference_count++;
+       g_handle->data = talloc_steal(g_handle, a_state);
 
-       *r->out.acct_handle = g_handle->wire_handle;
+       *r->out.group_handle = g_handle->wire_handle;
 
        return NT_STATUS_OK;
 }
@@ -1045,11 +1398,11 @@ static NTSTATUS samr_OpenGroup(struct dcesrv_call_state *dce_call, TALLOC_CTX *m
 #define QUERY_NTTIME(msg, field, attr) \
        r->out.info->field = samdb_result_nttime(msg, attr, 0);
 #define QUERY_APASSC(msg, field, attr) \
-       r->out.info->field = samdb_result_allow_pwd_change(state->sam_ctx, mem_ctx, \
-                                                          state->domain_state->basedn, msg, attr);
+       r->out.info->field = samdb_result_allow_password_change(a_state->sam_ctx, mem_ctx, \
+                                                          a_state->domain_state->domain_dn, msg, attr);
 #define QUERY_FPASSC(msg, field, attr) \
-       r->out.info->field = samdb_result_force_pwd_change(state->sam_ctx, mem_ctx, \
-                                                          state->domain_state->basedn, msg, attr);
+       r->out.info->field = samdb_result_force_password_change(a_state->sam_ctx, mem_ctx, \
+                                                          a_state->domain_state->domain_dn, msg, attr);
 #define QUERY_LHOURS(msg, field, attr) \
        r->out.info->field = samdb_result_logon_hours(mem_ctx, msg, attr);
 #define QUERY_AFLAGS(msg, field, attr) \
@@ -1060,25 +1413,25 @@ static NTSTATUS samr_OpenGroup(struct dcesrv_call_state *dce_call, TALLOC_CTX *m
 
 #define SET_STRING(mod, field, attr) do { \
        if (r->in.info->field == NULL) return NT_STATUS_INVALID_PARAMETER; \
-       if (samdb_msg_add_string(state->sam_ctx, mem_ctx, mod, attr, r->in.info->field) != 0) { \
+       if (samdb_msg_add_string(a_state->sam_ctx, mem_ctx, mod, attr, r->in.info->field) != 0) { \
                return NT_STATUS_NO_MEMORY; \
        } \
 } while (0)
 
 #define SET_UINT(mod, field, attr) do { \
-       if (samdb_msg_add_uint(state->sam_ctx, mem_ctx, mod, attr, r->in.info->field) != 0) { \
+       if (samdb_msg_add_uint(a_state->sam_ctx, mem_ctx, mod, attr, r->in.info->field) != 0) { \
                return NT_STATUS_NO_MEMORY; \
        } \
 } while (0)
 
 #define SET_AFLAGS(msg, field, attr) do { \
-       if (samdb_msg_add_acct_flags(state->sam_ctx, mem_ctx, msg, attr, r->in.info->field) != 0) { \
+       if (samdb_msg_add_acct_flags(a_state->sam_ctx, mem_ctx, msg, attr, r->in.info->field) != 0) { \
                return NT_STATUS_NO_MEMORY; \
        } \
 } while (0)
 
 #define SET_LHOURS(msg, field, attr) do { \
-       if (samdb_msg_add_logon_hours(state->sam_ctx, mem_ctx, msg, attr, r->in.info->field) != 0) { \
+       if (samdb_msg_add_logon_hours(a_state->sam_ctx, mem_ctx, msg, attr, &r->in.info->field) != 0) { \
                return NT_STATUS_NO_MEMORY; \
        } \
 } while (0)
@@ -1090,7 +1443,7 @@ static NTSTATUS samr_QueryGroupInfo(struct dcesrv_call_state *dce_call, TALLOC_C
                       struct samr_QueryGroupInfo *r)
 {
        struct dcesrv_handle *h;
-       struct samr_account_state *state;
+       struct samr_account_state *a_state;
        struct ldb_message *msg, **res;
        const char * const attrs[4] = { "sAMAccountName", "description",
                                        "numMembers", NULL };
@@ -1098,20 +1451,20 @@ static NTSTATUS samr_QueryGroupInfo(struct dcesrv_call_state *dce_call, TALLOC_C
 
        r->out.info = NULL;
 
-       DCESRV_PULL_HANDLE(h, r->in.handle, SAMR_HANDLE_GROUP);
+       DCESRV_PULL_HANDLE(h, r->in.group_handle, SAMR_HANDLE_GROUP);
 
-       state = h->data;
+       a_state = h->data;
 
        /* pull all the group attributes */
-       ret = samdb_search(state->sam_ctx, mem_ctx, NULL, &res, attrs,
-                          "dn=%s", state->basedn);
+       ret = gendb_search_dn(a_state->sam_ctx, mem_ctx,
+                             a_state->account_dn, &res, attrs);
        if (ret != 1) {
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
        msg = res[0];
 
        /* allocate the info structure */
-       r->out.info = talloc_p(mem_ctx, union samr_GroupInfo);
+       r->out.info = talloc(mem_ctx, union samr_GroupInfo);
        if (r->out.info == NULL) {
                return NT_STATUS_NO_MEMORY;
        }
@@ -1119,20 +1472,20 @@ static NTSTATUS samr_QueryGroupInfo(struct dcesrv_call_state *dce_call, TALLOC_C
 
        /* Fill in the level */
        switch (r->in.level) {
-       case GroupInfoAll:
-               QUERY_STRING(msg, all.name.name,        "sAMAccountName");
-               r->out.info->all.unknown = 7; /* Do like w2k3 */
+       case GROUPINFOALL:
+               QUERY_STRING(msg, all.name.string,        "sAMAccountName");
+               r->out.info->all.attributes = 7; /* Do like w2k3 */
                QUERY_UINT  (msg, all.num_members,      "numMembers")
-               QUERY_STRING(msg, all.description.name, "description");
+               QUERY_STRING(msg, all.description.string, "description");
                break;
-       case GroupInfoName:
-               QUERY_STRING(msg, name.name,            "sAMAccountName");
+       case GROUPINFONAME:
+               QUERY_STRING(msg, name.string,            "sAMAccountName");
                break;
-       case GroupInfoX:
+       case GROUPINFOX:
                r->out.info->unknown.unknown = 7;
                break;
-       case GroupInfoDescription:
-               QUERY_STRING(msg, description.name, "description");
+       case GROUPINFODESCRIPTION:
+               QUERY_STRING(msg, description.string, "description");
                break;
        default:
                r->out.info = NULL;
@@ -1147,46 +1500,45 @@ static NTSTATUS samr_QueryGroupInfo(struct dcesrv_call_state *dce_call, TALLOC_C
   samr_SetGroupInfo 
 */
 static NTSTATUS samr_SetGroupInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
-                      struct samr_SetGroupInfo *r)
+                                 struct samr_SetGroupInfo *r)
 {
        struct dcesrv_handle *h;
-       struct samr_account_state *state;
-       struct ldb_message mod, *msg = &mod;
-       int i, ret;
+       struct samr_account_state *a_state;
+       struct ldb_message *msg;
+       int ret;
+
+       DCESRV_PULL_HANDLE(h, r->in.group_handle, SAMR_HANDLE_GROUP);
 
-       DCESRV_PULL_HANDLE(h, r->in.handle, SAMR_HANDLE_GROUP);
+       a_state = h->data;
 
-       state = h->data;
+       msg = ldb_msg_new(mem_ctx);
+       if (msg == NULL) {
+               return NT_STATUS_NO_MEMORY;
+       }       
 
-       ZERO_STRUCT(mod);
-       mod.dn = talloc_strdup(mem_ctx, state->basedn);
-       if (!mod.dn) {
+       msg->dn = talloc_strdup(mem_ctx, a_state->account_dn);
+       if (!msg->dn) {
                return NT_STATUS_NO_MEMORY;
        }
 
        switch (r->in.level) {
-       case GroupInfoDescription:
-               SET_STRING(msg, description.name,         "description");
+       case GROUPINFODESCRIPTION:
+               SET_STRING(msg, description.string,         "description");
                break;
-       case GroupInfoName:
+       case GROUPINFONAME:
                /* On W2k3 this does not change the name, it changes the
                 * sAMAccountName attribute */
-               SET_STRING(msg, name.name,                "sAMAccountName");
+               SET_STRING(msg, name.string,                "sAMAccountName");
                break;
-       case GroupInfoX:
+       case GROUPINFOX:
                /* This does not do anything obviously visible in W2k3 LDAP */
                break;
        default:
                return NT_STATUS_INVALID_INFO_CLASS;
        }
 
-       /* mark all the message elements as LDB_FLAG_MOD_REPLACE */
-       for (i=0;i<mod.num_elements;i++) {
-               mod.elements[i].flags = LDB_FLAG_MOD_REPLACE;
-       }
-
        /* modify the samdb record */
-       ret = samdb_modify(state->sam_ctx, mem_ctx, &mod);
+       ret = samdb_replace(a_state->sam_ctx, mem_ctx, msg);
        if (ret != 0) {
                /* we really need samdb.c to return NTSTATUS */
                return NT_STATUS_UNSUCCESSFUL;
@@ -1202,7 +1554,57 @@ static NTSTATUS samr_SetGroupInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX
 static NTSTATUS samr_AddGroupMember(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_AddGroupMember *r)
 {
-       DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
+       struct dcesrv_handle *h;
+       struct samr_account_state *a_state;
+       struct samr_domain_state *d_state;
+       struct ldb_message *mod;
+       struct dom_sid *membersid;
+       const char *memberdn;
+       struct ldb_message **msgs;
+       const char * const attrs[2] = { "dn", NULL };
+       int ret;
+
+       DCESRV_PULL_HANDLE(h, r->in.group_handle, SAMR_HANDLE_GROUP);
+
+       a_state = h->data;
+       d_state = a_state->domain_state;
+
+       membersid = dom_sid_add_rid(mem_ctx, d_state->domain_sid, r->in.rid);
+       if (membersid == NULL)
+               return NT_STATUS_NO_MEMORY;
+
+       /* In native mode, AD can also nest domain groups. Not sure yet
+        * whether this is also available via RPC. */
+       ret = gendb_search(d_state->sam_ctx, mem_ctx, d_state->domain_dn,
+                          &msgs, attrs, "(&(objectSid=%s)(objectclass=user))",
+                          ldap_encode_ndr_dom_sid(mem_ctx, membersid));
+
+       if (ret == 0)
+               return NT_STATUS_NO_SUCH_USER;
+
+       if (ret > 1)
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+
+       memberdn = samdb_result_string(msgs[0], "dn", NULL);
+
+       if (memberdn == NULL)
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+
+       mod = ldb_msg_new(mem_ctx);
+       if (mod == NULL) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       mod->dn = talloc_reference(mem_ctx, a_state->account_dn);
+
+       if (samdb_msg_add_addval(d_state->sam_ctx, mem_ctx, mod, "member",
+                                memberdn) != 0)
+               return NT_STATUS_UNSUCCESSFUL;
+
+       if (samdb_modify(a_state->sam_ctx, mem_ctx, mod) != 0)
+               return NT_STATUS_UNSUCCESSFUL;
+
+       return NT_STATUS_OK;
 }
 
 
@@ -1213,21 +1615,21 @@ static NTSTATUS samr_DeleteDomainGroup(struct dcesrv_call_state *dce_call, TALLO
                       struct samr_DeleteDomainGroup *r)
 {
        struct dcesrv_handle *h;
-       struct samr_account_state *state;
+       struct samr_account_state *a_state;
        int ret;
 
-        *r->out.handle = *r->in.handle;
+        *r->out.group_handle = *r->in.group_handle;
 
-       DCESRV_PULL_HANDLE(h, r->in.handle, SAMR_HANDLE_GROUP);
+       DCESRV_PULL_HANDLE(h, r->in.group_handle, SAMR_HANDLE_GROUP);
 
-       state = h->data;
+       a_state = h->data;
 
-       ret = samdb_delete(state->sam_ctx, mem_ctx, state->basedn);
+       ret = samdb_delete(a_state->sam_ctx, mem_ctx, a_state->account_dn);
        if (ret != 0) {
                return NT_STATUS_UNSUCCESSFUL;
        }
 
-       ZERO_STRUCTP(r->out.handle);
+       ZERO_STRUCTP(r->out.group_handle);
 
        return NT_STATUS_OK;
 }
@@ -1239,7 +1641,57 @@ static NTSTATUS samr_DeleteDomainGroup(struct dcesrv_call_state *dce_call, TALLO
 static NTSTATUS samr_DeleteGroupMember(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_DeleteGroupMember *r)
 {
-       DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
+       struct dcesrv_handle *h;
+       struct samr_account_state *a_state;
+       struct samr_domain_state *d_state;
+       struct ldb_message *mod;
+       struct dom_sid *membersid;
+       const char *memberdn;
+       struct ldb_message **msgs;
+       const char * const attrs[2] = { "dn", NULL };
+       int ret;
+
+       DCESRV_PULL_HANDLE(h, r->in.group_handle, SAMR_HANDLE_GROUP);
+
+       a_state = h->data;
+       d_state = a_state->domain_state;
+
+       membersid = dom_sid_add_rid(mem_ctx, d_state->domain_sid, r->in.rid);
+       if (membersid == NULL)
+               return NT_STATUS_NO_MEMORY;
+
+       /* In native mode, AD can also nest domain groups. Not sure yet
+        * whether this is also available via RPC. */
+       ret = gendb_search(d_state->sam_ctx, mem_ctx, d_state->domain_dn,
+                          &msgs, attrs, "(&(objectSid=%s)(objectclass=user))",
+                          ldap_encode_ndr_dom_sid(mem_ctx, membersid));
+
+       if (ret == 0)
+               return NT_STATUS_NO_SUCH_USER;
+
+       if (ret > 1)
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+
+       memberdn = samdb_result_string(msgs[0], "dn", NULL);
+
+       if (memberdn == NULL)
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+
+       mod = ldb_msg_new(mem_ctx);
+       if (mod == NULL) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       mod->dn = talloc_reference(mem_ctx, a_state->account_dn);
+
+       if (samdb_msg_add_delval(d_state->sam_ctx, mem_ctx, mod, "member",
+                                memberdn) != 0)
+               return NT_STATUS_UNSUCCESSFUL;
+
+       if (samdb_modify(a_state->sam_ctx, mem_ctx, mod) != 0)
+               return NT_STATUS_UNSUCCESSFUL;
+
+       return NT_STATUS_OK;
 }
 
 
@@ -1249,7 +1701,73 @@ static NTSTATUS samr_DeleteGroupMember(struct dcesrv_call_state *dce_call, TALLO
 static NTSTATUS samr_QueryGroupMember(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_QueryGroupMember *r)
 {
-       DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
+       struct dcesrv_handle *h;
+       struct samr_account_state *a_state;
+       struct ldb_message **res;
+       struct ldb_message_element *el;
+       struct samr_RidTypeArray *array;
+       const char * const attrs[2] = { "member", NULL };
+       int ret;
+
+       DCESRV_PULL_HANDLE(h, r->in.group_handle, SAMR_HANDLE_GROUP);
+
+       a_state = h->data;
+
+       /* pull the member attribute */
+       ret = gendb_search_dn(a_state->sam_ctx, mem_ctx,
+                             a_state->account_dn, &res, attrs);
+
+       if (ret != 1) {
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+       }
+
+       array = talloc(mem_ctx, struct samr_RidTypeArray);
+
+       if (array == NULL)
+               return NT_STATUS_NO_MEMORY;
+
+       ZERO_STRUCTP(array);
+
+       el = ldb_msg_find_element(res[0], "member");
+
+       if (el != NULL) {
+               int i;
+
+               array->count = el->num_values;
+
+               array->rids = talloc_array(mem_ctx, uint32_t,
+                                            el->num_values);
+               if (array->rids == NULL)
+                       return NT_STATUS_NO_MEMORY;
+
+               array->types = talloc_array(mem_ctx, uint32_t,
+                                           el->num_values);
+               if (array->types == NULL)
+                       return NT_STATUS_NO_MEMORY;
+
+               for (i=0; i<el->num_values; i++) {
+                       struct ldb_message **res2;
+                       const char * const attrs2[2] = { "objectSid", NULL };
+                       ret = gendb_search_dn(a_state->sam_ctx, mem_ctx,
+                                          (char *)el->values[i].data,
+                                          &res2, attrs2);
+                       if (ret != 1)
+                               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+
+                       array->rids[i] =
+                               samdb_result_rid_from_sid(mem_ctx, res2[0],
+                                                         "objectSid", 0);
+
+                       if (array->rids[i] == 0)
+                               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+
+                       array->types[i] = 7; /* RID type of some kind, not sure what the value means. */
+               }
+       }
+
+       r->out.rids = array;
+
+       return NT_STATUS_OK;
 }
 
 
@@ -1269,7 +1787,78 @@ static NTSTATUS samr_SetMemberAttributesOfGroup(struct dcesrv_call_state *dce_ca
 static NTSTATUS samr_OpenAlias(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_OpenAlias *r)
 {
-       DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
+       struct samr_domain_state *d_state;
+       struct samr_account_state *a_state;
+       struct dcesrv_handle *h;
+       const char *alias_name;
+       struct dom_sid *sid;
+       struct ldb_message **msgs;
+       struct dcesrv_handle *g_handle;
+       const char * const attrs[2] = { "sAMAccountName", NULL };
+       int ret;
+
+       ZERO_STRUCTP(r->out.alias_handle);
+
+       DCESRV_PULL_HANDLE(h, r->in.domain_handle, SAMR_HANDLE_DOMAIN);
+
+       d_state = h->data;
+
+       /* form the alias SID */
+       sid = dom_sid_add_rid(mem_ctx, d_state->domain_sid, r->in.rid);
+       if (sid == NULL)
+               return NT_STATUS_NO_MEMORY;
+
+       /* search for the group record */
+       ret = gendb_search(d_state->sam_ctx,
+                          mem_ctx, d_state->domain_dn, &msgs, attrs,
+                          "(&(objectSid=%s)(objectclass=group)"
+                          "(|(grouptype=%s)(grouptype=%s)))",
+                          ldap_encode_ndr_dom_sid(mem_ctx, sid),
+                          ldb_hexstr(mem_ctx,
+                                     GTYPE_SECURITY_BUILTIN_LOCAL_GROUP),
+                          ldb_hexstr(mem_ctx,
+                                     GTYPE_SECURITY_DOMAIN_LOCAL_GROUP));
+       if (ret == 0) {
+               return NT_STATUS_NO_SUCH_ALIAS;
+       }
+       if (ret != 1) {
+               DEBUG(0,("Found %d records matching sid %s\n", 
+                        ret, dom_sid_string(mem_ctx, sid)));
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+       }
+
+       alias_name = samdb_result_string(msgs[0], "sAMAccountName", NULL);
+       if (alias_name == NULL) {
+               DEBUG(0,("sAMAccountName field missing for sid %s\n", 
+                        dom_sid_string(mem_ctx, sid)));
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+       }
+
+       a_state = talloc(d_state, struct samr_account_state);
+       if (!a_state) {
+               return NT_STATUS_NO_MEMORY;
+       }
+       a_state->sam_ctx = d_state->sam_ctx;
+       a_state->access_mask = r->in.access_mask;
+       a_state->domain_state = talloc_reference(a_state, d_state);
+       a_state->account_dn = talloc_steal(a_state, msgs[0]->dn);
+       a_state->account_sid = talloc_steal(a_state, sid);
+       a_state->account_name = talloc_strdup(a_state, alias_name);
+       if (!a_state->account_name) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       /* create the policy handle */
+       g_handle = dcesrv_handle_new(dce_call->context, SAMR_HANDLE_ALIAS);
+       if (!g_handle) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       g_handle->data = talloc_steal(g_handle, a_state);
+
+       *r->out.alias_handle = g_handle->wire_handle;
+
+       return NT_STATUS_OK;
 }
 
 
@@ -1279,7 +1868,52 @@ static NTSTATUS samr_OpenAlias(struct dcesrv_call_state *dce_call, TALLOC_CTX *m
 static NTSTATUS samr_QueryAliasInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_QueryAliasInfo *r)
 {
-       DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
+       struct dcesrv_handle *h;
+       struct samr_account_state *a_state;
+       struct ldb_message *msg, **res;
+       const char * const attrs[4] = { "sAMAccountName", "description",
+                                       "numMembers", NULL };
+       int ret;
+
+       r->out.info = NULL;
+
+       DCESRV_PULL_HANDLE(h, r->in.alias_handle, SAMR_HANDLE_ALIAS);
+
+       a_state = h->data;
+
+       /* pull all the alias attributes */
+       ret = gendb_search_dn(a_state->sam_ctx, mem_ctx,
+                             a_state->account_dn ,&res, attrs);
+       if (ret != 1) {
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+       }
+       msg = res[0];
+
+       /* allocate the info structure */
+       r->out.info = talloc(mem_ctx, union samr_AliasInfo);
+       if (r->out.info == NULL) {
+               return NT_STATUS_NO_MEMORY;
+       }
+       ZERO_STRUCTP(r->out.info);
+
+       switch(r->in.level) {
+       case ALIASINFOALL:
+               QUERY_STRING(msg, all.name.string, "sAMAccountName");
+               QUERY_UINT  (msg, all.num_members, "numMembers");
+               QUERY_STRING(msg, all.description.string, "description");
+               break;
+       case ALIASINFONAME:
+               QUERY_STRING(msg, name.string, "sAMAccountName");
+               break;
+       case ALIASINFODESCRIPTION:
+               QUERY_STRING(msg, description.string, "description");
+               break;
+       default:
+               r->out.info = NULL;
+               return NT_STATUS_INVALID_INFO_CLASS;
+       }
+       
+       return NT_STATUS_OK;
 }
 
 
@@ -1289,17 +1923,73 @@ static NTSTATUS samr_QueryAliasInfo(struct dcesrv_call_state *dce_call, TALLOC_C
 static NTSTATUS samr_SetAliasInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_SetAliasInfo *r)
 {
-       DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
+       struct dcesrv_handle *h;
+       struct samr_account_state *a_state;
+       struct ldb_message *msg;
+       int ret;
+
+       DCESRV_PULL_HANDLE(h, r->in.alias_handle, SAMR_HANDLE_ALIAS);
+
+       a_state = h->data;
+
+       msg = ldb_msg_new(mem_ctx);
+       if (msg == NULL) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       msg->dn = talloc_strdup(mem_ctx, a_state->account_dn);
+       if (!msg->dn) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       switch (r->in.level) {
+       case ALIASINFODESCRIPTION:
+               SET_STRING(msg, description.string,         "description");
+               break;
+       case ALIASINFONAME:
+               /* On W2k3 this does not change the name, it changes the
+                * sAMAccountName attribute */
+               SET_STRING(msg, name.string,                "sAMAccountName");
+               break;
+       default:
+               return NT_STATUS_INVALID_INFO_CLASS;
+       }
+
+       /* modify the samdb record */
+       ret = samdb_replace(a_state->sam_ctx, mem_ctx, msg);
+       if (ret != 0) {
+               /* we really need samdb.c to return NTSTATUS */
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       return NT_STATUS_OK;
 }
 
 
-/* 
-  samr_DeleteDomAlias 
-*/
-static NTSTATUS samr_DeleteDomAlias(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
-                      struct samr_DeleteDomAlias *r)
-{
-       DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
+/* 
+  samr_DeleteDomAlias 
+*/
+static NTSTATUS samr_DeleteDomAlias(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+                      struct samr_DeleteDomAlias *r)
+{
+       struct dcesrv_handle *h;
+       struct samr_account_state *a_state;
+       int ret;
+
+        *r->out.alias_handle = *r->in.alias_handle;
+
+       DCESRV_PULL_HANDLE(h, r->in.alias_handle, SAMR_HANDLE_ALIAS);
+
+       a_state = h->data;
+
+       ret = samdb_delete(a_state->sam_ctx, mem_ctx, a_state->account_dn);
+       if (ret != 0) {
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       ZERO_STRUCTP(r->out.alias_handle);
+
+       return NT_STATUS_OK;
 }
 
 
@@ -1309,7 +1999,106 @@ static NTSTATUS samr_DeleteDomAlias(struct dcesrv_call_state *dce_call, TALLOC_C
 static NTSTATUS samr_AddAliasMember(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_AddAliasMember *r)
 {
-       DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
+       struct dcesrv_handle *h;
+       struct samr_account_state *a_state;
+       struct samr_domain_state *d_state;
+       struct ldb_message *mod;
+       struct ldb_message **msgs;
+       const char * const attrs[2] = { "dn", NULL };
+       const char *memberdn = NULL;
+       int ret;
+
+       DCESRV_PULL_HANDLE(h, r->in.alias_handle, SAMR_HANDLE_ALIAS);
+
+       a_state = h->data;
+       d_state = a_state->domain_state;
+
+       ret = gendb_search(d_state->sam_ctx, mem_ctx, NULL,
+                          &msgs, attrs, "(objectsid=%s)", 
+                          ldap_encode_ndr_dom_sid(mem_ctx, r->in.sid));
+
+       if (ret == 1) {
+               memberdn = ldb_msg_find_string(msgs[0], "dn", NULL);
+       } else  if (ret > 1) {
+               DEBUG(0,("Found %d records matching sid %s\n", 
+                        ret, dom_sid_string(mem_ctx, r->in.sid)));
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+       } else if (ret == 0) {
+               struct ldb_message *msg;
+               const char *basedn, *sidstr;
+
+               sidstr = dom_sid_string(mem_ctx, r->in.sid);
+               NT_STATUS_HAVE_NO_MEMORY(sidstr);
+
+               /* We might have to create a ForeignSecurityPrincipal, but
+                * only if it's not our own domain */
+               if (dom_sid_in_domain(d_state->domain_sid, r->in.sid))
+                       return NT_STATUS_OBJECT_NAME_NOT_FOUND;
+
+               msg = ldb_msg_new(mem_ctx);
+               if (msg == NULL) {
+                       return NT_STATUS_NO_MEMORY;
+               }
+
+               /* TODO: Hmmm. This feels wrong. How do I find the base dn to
+                * put the ForeignSecurityPrincipals? d_state->domain_dn does
+                * not work, this is wrong for the Builtin domain, there's no
+                * cn=For...,cn=Builtin,dc={BASEDN}.  -- vl
+                */
+
+               basedn = samdb_search_string(d_state->sam_ctx, mem_ctx, NULL,
+                                            "dn",
+                                            "(&(objectClass=container)"
+                                            "(cn=ForeignSecurityPrincipals))");
+
+               if (basedn == NULL) {
+                       DEBUG(0, ("Failed to find DN for "
+                                 "ForeignSecurityPrincipal container\n"));
+                       return NT_STATUS_INTERNAL_DB_CORRUPTION;
+               }
+
+               /* add core elements to the ldb_message for the alias */
+               msg->dn = talloc_asprintf(mem_ctx, "CN=%s,%s", sidstr, basedn);
+               if (msg->dn == NULL)
+                       return NT_STATUS_NO_MEMORY;
+
+               memberdn = msg->dn;
+
+               samdb_msg_add_string(d_state->sam_ctx, mem_ctx, msg,
+                                    "objectClass",
+                                    "foreignSecurityPrincipal");
+
+               /* create the alias */
+               ret = samdb_add(d_state->sam_ctx, mem_ctx, msg);
+               if (ret != 0) {
+                       DEBUG(0,("Failed to create foreignSecurityPrincipal "
+                                "record %s\n", msg->dn));
+                       return NT_STATUS_INTERNAL_DB_CORRUPTION;
+               }
+       } else {
+               DEBUG(0, ("samdb_search returned %d\n", ret));
+       }
+
+       if (memberdn == NULL) {
+               DEBUG(0, ("Could not find memberdn\n"));
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+       }
+
+       mod = ldb_msg_new(mem_ctx);
+       if (mod == NULL) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       mod->dn = talloc_reference(mem_ctx, a_state->account_dn);
+
+       if (samdb_msg_add_addval(d_state->sam_ctx, mem_ctx, mod, "member",
+                                memberdn) != 0)
+               return NT_STATUS_UNSUCCESSFUL;
+
+       if (samdb_modify(a_state->sam_ctx, mem_ctx, mod) != 0)
+               return NT_STATUS_UNSUCCESSFUL;
+
+       return NT_STATUS_OK;
 }
 
 
@@ -1319,7 +2108,39 @@ static NTSTATUS samr_AddAliasMember(struct dcesrv_call_state *dce_call, TALLOC_C
 static NTSTATUS samr_DeleteAliasMember(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_DeleteAliasMember *r)
 {
-       DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
+       struct dcesrv_handle *h;
+       struct samr_account_state *a_state;
+       struct samr_domain_state *d_state;
+       struct ldb_message *mod;
+       const char *memberdn;
+
+       DCESRV_PULL_HANDLE(h, r->in.alias_handle, SAMR_HANDLE_ALIAS);
+
+       a_state = h->data;
+       d_state = a_state->domain_state;
+
+       memberdn = samdb_search_string(d_state->sam_ctx, mem_ctx, NULL,
+                                      "dn", "(objectSid=%s)", 
+                                      ldap_encode_ndr_dom_sid(mem_ctx, r->in.sid));
+
+       if (memberdn == NULL)
+               return NT_STATUS_OBJECT_NAME_NOT_FOUND;
+
+       mod = ldb_msg_new(mem_ctx);
+       if (mod == NULL) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       mod->dn = talloc_reference(mem_ctx, a_state->account_dn);
+
+       if (samdb_msg_add_delval(d_state->sam_ctx, mem_ctx, mod, "member",
+                                memberdn) != 0)
+               return NT_STATUS_UNSUCCESSFUL;
+
+       if (samdb_modify(a_state->sam_ctx, mem_ctx, mod) != 0)
+               return NT_STATUS_UNSUCCESSFUL;
+
+       return NT_STATUS_OK;
 }
 
 
@@ -1329,9 +2150,61 @@ static NTSTATUS samr_DeleteAliasMember(struct dcesrv_call_state *dce_call, TALLO
 static NTSTATUS samr_GetMembersInAlias(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_GetMembersInAlias *r)
 {
-       DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
-}
+       struct dcesrv_handle *h;
+       struct samr_account_state *a_state;
+       struct samr_domain_state *d_state;
+       struct ldb_message **msgs;
+       struct lsa_SidPtr *sids;
+       struct ldb_message_element *el;
+       const char * const attrs[2] = { "member", NULL};
+       int ret;
+
+       DCESRV_PULL_HANDLE(h, r->in.alias_handle, SAMR_HANDLE_ALIAS);
+
+       a_state = h->data;
+       d_state = a_state->domain_state;
+
+       ret = gendb_search_dn(d_state->sam_ctx, mem_ctx,
+                             a_state->account_dn, &msgs, attrs);
+
+       if (ret != 1)
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+
+       r->out.sids->num_sids = 0;
+       r->out.sids->sids = NULL;
+
+       el = ldb_msg_find_element(msgs[0], "member");
+
+       if (el != NULL) {
+               int i;
+
+               sids = talloc_array(mem_ctx, struct lsa_SidPtr,
+                                     el->num_values);
+
+               if (sids == NULL)
+                       return NT_STATUS_NO_MEMORY;
 
+               for (i=0; i<el->num_values; i++) {
+                       struct ldb_message **msgs2;
+                       const char * const attrs2[2] = { "objectSid", NULL };
+                       ret = gendb_search_dn(a_state->sam_ctx, mem_ctx,
+                                          (char *)el->values[i].data,
+                                          &msgs2, attrs2);
+                       if (ret != 1)
+                               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+
+                       sids[i].sid = samdb_result_dom_sid(mem_ctx, msgs2[0],
+                                                          "objectSid");
+
+                       if (sids[i].sid == NULL)
+                               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+               }
+               r->out.sids->num_sids = el->num_values;
+               r->out.sids->sids = sids;
+       }
+
+       return NT_STATUS_OK;
+}
 
 /* 
   samr_OpenUser 
@@ -1340,80 +2213,71 @@ static NTSTATUS samr_OpenUser(struct dcesrv_call_state *dce_call, TALLOC_CTX *me
                              struct samr_OpenUser *r)
 {
        struct samr_domain_state *d_state;
-       struct samr_account_state *state;
+       struct samr_account_state *a_state;
        struct dcesrv_handle *h;
-       const char *username, *sidstr;
-       TALLOC_CTX *mem_ctx2;
+       const char *account_name;
+       struct dom_sid *sid;
        struct ldb_message **msgs;
        struct dcesrv_handle *u_handle;
        const char * const attrs[2] = { "sAMAccountName", NULL };
        int ret;
 
-       ZERO_STRUCTP(r->out.acct_handle);
+       ZERO_STRUCTP(r->out.user_handle);
 
-       DCESRV_PULL_HANDLE(h, r->in.handle, SAMR_HANDLE_DOMAIN);
+       DCESRV_PULL_HANDLE(h, r->in.domain_handle, SAMR_HANDLE_DOMAIN);
 
        d_state = h->data;
 
        /* form the users SID */
-       sidstr = talloc_asprintf(mem_ctx, "%s-%u", d_state->domain_sid, r->in.rid);
-       if (!sidstr) {
+       sid = dom_sid_add_rid(mem_ctx, d_state->domain_sid, r->in.rid);
+       if (!sid) {
                return NT_STATUS_NO_MEMORY;
        }
 
        /* search for the user record */
-       ret = samdb_search(d_state->sam_ctx,
-                          mem_ctx, d_state->basedn, &msgs, attrs,
+       ret = gendb_search(d_state->sam_ctx,
+                          mem_ctx, d_state->domain_dn, &msgs, attrs,
                           "(&(objectSid=%s)(objectclass=user))", 
-                          sidstr);
+                          ldap_encode_ndr_dom_sid(mem_ctx, sid));
        if (ret == 0) {
                return NT_STATUS_NO_SUCH_USER;
        }
        if (ret != 1) {
-               DEBUG(1,("Found %d records matching sid %s\n", ret, sidstr));
+               DEBUG(0,("Found %d records matching sid %s\n", ret, 
+                        dom_sid_string(mem_ctx, sid)));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
-       username = samdb_result_string(msgs[0], "sAMAccountName", NULL);
-       if (username == NULL) {
-               DEBUG(1,("sAMAccountName field missing for sid %s\n", sidstr));
+       account_name = samdb_result_string(msgs[0], "sAMAccountName", NULL);
+       if (account_name == NULL) {
+               DEBUG(0,("sAMAccountName field missing for sid %s\n", 
+                        dom_sid_string(mem_ctx, sid)));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
-       /* create user state and new policy handle */
-       mem_ctx2 = talloc_init("OpenUser(%u)", r->in.rid);
-       if (!mem_ctx2) {
+       a_state = talloc(mem_ctx, struct samr_account_state);
+       if (!a_state) {
                return NT_STATUS_NO_MEMORY;
        }
-
-       state = talloc_p(mem_ctx2, struct samr_account_state);
-       if (!state) {
-               return NT_STATUS_NO_MEMORY;
-       }
-       state->mem_ctx = mem_ctx2;
-       state->sam_ctx = d_state->sam_ctx;
-       state->access_mask = r->in.access_mask;
-       state->domain_state = d_state;
-       state->basedn = talloc_steal(mem_ctx, mem_ctx2, msgs[0]->dn);
-       state->account_sid = talloc_strdup(mem_ctx2, sidstr);
-       state->account_name = talloc_strdup(mem_ctx2, username);
-       if (!state->account_name || !state->account_sid) {
+       a_state->sam_ctx = d_state->sam_ctx;
+       a_state->access_mask = r->in.access_mask;
+       a_state->domain_state = talloc_reference(a_state, d_state);
+       a_state->account_dn = talloc_steal(a_state, msgs[0]->dn);
+       a_state->account_sid = talloc_steal(a_state, sid);
+       a_state->account_name = talloc_strdup(a_state, account_name);
+       if (!a_state->account_name) {
                return NT_STATUS_NO_MEMORY;
        }
 
        /* create the policy handle */
-       u_handle = dcesrv_handle_new(dce_call->conn, SAMR_HANDLE_USER);
+       u_handle = dcesrv_handle_new(dce_call->context, SAMR_HANDLE_USER);
        if (!u_handle) {
                return NT_STATUS_NO_MEMORY;
        }
 
-       u_handle->data = state;
-       u_handle->destroy = samr_Account_destroy;
-
-       /* the domain state is in use one more time */
-       d_state->reference_count++;
+       u_handle->data = talloc_steal(u_handle, a_state);
 
-       *r->out.acct_handle = u_handle->wire_handle;
+       *r->out.user_handle = u_handle->wire_handle;
 
        return NT_STATUS_OK;
 
@@ -1427,21 +2291,21 @@ static NTSTATUS samr_DeleteUser(struct dcesrv_call_state *dce_call, TALLOC_CTX *
                                struct samr_DeleteUser *r)
 {
        struct dcesrv_handle *h;
-       struct samr_account_state *state;
+       struct samr_account_state *a_state;
        int ret;
 
-       *r->out.handle = *r->in.handle;
+       *r->out.user_handle = *r->in.user_handle;
 
-       DCESRV_PULL_HANDLE(h, r->in.handle, SAMR_HANDLE_USER);
+       DCESRV_PULL_HANDLE(h, r->in.user_handle, SAMR_HANDLE_USER);
 
-       state = h->data;
+       a_state = h->data;
 
-       ret = samdb_delete(state->sam_ctx, mem_ctx, state->basedn);
+       ret = samdb_delete(a_state->sam_ctx, mem_ctx, a_state->account_dn);
        if (ret != 0) {
                return NT_STATUS_UNSUCCESSFUL;
        }
 
-       ZERO_STRUCTP(r->out.handle);
+       ZERO_STRUCTP(r->out.user_handle);
 
        return NT_STATUS_OK;
 }
@@ -1454,26 +2318,26 @@ static NTSTATUS samr_QueryUserInfo(struct dcesrv_call_state *dce_call, TALLOC_CT
                                   struct samr_QueryUserInfo *r)
 {
        struct dcesrv_handle *h;
-       struct samr_account_state *state;
+       struct samr_account_state *a_state;
        struct ldb_message *msg, **res;
        int ret;
 
        r->out.info = NULL;
 
-       DCESRV_PULL_HANDLE(h, r->in.handle, SAMR_HANDLE_USER);
+       DCESRV_PULL_HANDLE(h, r->in.user_handle, SAMR_HANDLE_USER);
 
-       state = h->data;
+       a_state = h->data;
 
        /* pull all the user attributes */
-       ret = samdb_search(state->sam_ctx, mem_ctx, NULL, &res, NULL,
-                          "dn=%s", state->basedn);
+       ret = gendb_search_dn(a_state->sam_ctx, mem_ctx,
+                             a_state->account_dn ,&res, NULL);
        if (ret != 1) {
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
        msg = res[0];
 
        /* allocate the info structure */
-       r->out.info = talloc_p(mem_ctx, union samr_UserInfo);
+       r->out.info = talloc(mem_ctx, union samr_UserInfo);
        if (r->out.info == NULL) {
                return NT_STATUS_NO_MEMORY;
        }
@@ -1482,140 +2346,140 @@ static NTSTATUS samr_QueryUserInfo(struct dcesrv_call_state *dce_call, TALLOC_CT
        /* fill in the reply */
        switch (r->in.level) {
        case 1:
-               QUERY_STRING(msg, info1.username.name,    "sAMAccountName");
-               QUERY_STRING(msg, info1.full_name.name,   "displayName");
-               QUERY_UINT  (msg, info1.primary_gid,      "primaryGroupID");
-               QUERY_STRING(msg, info1.description.name, "description");
-               QUERY_STRING(msg, info1.comment.name,     "comment");
+               QUERY_STRING(msg, info1.account_name.string,   "sAMAccountName");
+               QUERY_STRING(msg, info1.full_name.string,      "displayName");
+               QUERY_UINT  (msg, info1.primary_gid,           "primaryGroupID");
+               QUERY_STRING(msg, info1.description.string,    "description");
+               QUERY_STRING(msg, info1.comment.string,        "comment");
                break;
 
        case 2:
-               QUERY_STRING(msg, info2.comment.name,     "comment");
-               QUERY_UINT  (msg, info2.country_code,     "countryCode");
-               QUERY_UINT  (msg, info2.code_page,        "codePage");
+               QUERY_STRING(msg, info2.comment.string,        "comment");
+               QUERY_UINT  (msg, info2.country_code,          "countryCode");
+               QUERY_UINT  (msg, info2.code_page,             "codePage");
                break;
 
        case 3:
-               QUERY_STRING(msg, info3.username.name,       "sAMAccountName");
-               QUERY_STRING(msg, info3.full_name.name,      "displayName");
-               QUERY_RID   (msg, info3.rid,                 "objectSid");
-               QUERY_UINT  (msg, info3.primary_gid,         "primaryGroupID");
-               QUERY_STRING(msg, info3.home_directory.name, "homeDirectory");
-               QUERY_STRING(msg, info3.home_drive.name,     "homeDrive");
-               QUERY_STRING(msg, info3.logon_script.name,   "scriptPath");
-               QUERY_STRING(msg, info3.profile.name,        "profilePath");
-               QUERY_STRING(msg, info3.workstations.name,   "userWorkstations");
-               QUERY_NTTIME(msg, info3.last_logon,          "lastLogon");
-               QUERY_NTTIME(msg, info3.last_logoff,         "lastLogoff");
-               QUERY_NTTIME(msg, info3.last_pwd_change,     "pwdLastSet");
-               QUERY_APASSC(msg, info3.allow_pwd_change,    "pwdLastSet");
-               QUERY_FPASSC(msg, info3.force_pwd_change,    "pwdLastSet");
-               QUERY_LHOURS(msg, info3.logon_hours,         "logonHours");
-               QUERY_UINT  (msg, info3.bad_pwd_count,       "badPwdCount");
-               QUERY_UINT  (msg, info3.num_logons,          "logonCount");
-               QUERY_AFLAGS(msg, info3.acct_flags,          "userAccountControl");
+               QUERY_STRING(msg, info3.account_name.string,   "sAMAccountName");
+               QUERY_STRING(msg, info3.full_name.string,      "displayName");
+               QUERY_RID   (msg, info3.rid,                   "objectSid");
+               QUERY_UINT  (msg, info3.primary_gid,           "primaryGroupID");
+               QUERY_STRING(msg, info3.home_directory.string, "homeDirectory");
+               QUERY_STRING(msg, info3.home_drive.string,     "homeDrive");
+               QUERY_STRING(msg, info3.logon_script.string,   "scriptPath");
+               QUERY_STRING(msg, info3.profile_path.string,   "profilePath");
+               QUERY_STRING(msg, info3.workstations.string,   "userWorkstations");
+               QUERY_NTTIME(msg, info3.last_logon,            "lastLogon");
+               QUERY_NTTIME(msg, info3.last_logoff,           "lastLogoff");
+               QUERY_NTTIME(msg, info3.last_password_change,  "pwdLastSet");
+               QUERY_APASSC(msg, info3.allow_password_change, "pwdLastSet");
+               QUERY_FPASSC(msg, info3.force_password_change, "pwdLastSet");
+               QUERY_LHOURS(msg, info3.logon_hours,           "logonHours");
+               QUERY_UINT  (msg, info3.bad_password_count,    "badPwdCount");
+               QUERY_UINT  (msg, info3.logon_count,           "logonCount");
+               QUERY_AFLAGS(msg, info3.acct_flags,            "userAccountControl");
                break;
 
        case 4:
-               QUERY_LHOURS(msg, info4.logon_hours,         "logonHours");
+               QUERY_LHOURS(msg, info4.logon_hours,           "logonHours");
                break;
 
        case 5:
-               QUERY_STRING(msg, info5.username.name,       "sAMAccountName");
-               QUERY_STRING(msg, info5.full_name.name,      "displayName");
-               QUERY_RID   (msg, info5.rid,                 "objectSid");
-               QUERY_UINT  (msg, info5.primary_gid,         "primaryGroupID");
-               QUERY_STRING(msg, info5.home_directory.name, "homeDirectory");
-               QUERY_STRING(msg, info5.home_drive.name,     "homeDrive");
-               QUERY_STRING(msg, info5.logon_script.name,   "scriptPath");
-               QUERY_STRING(msg, info5.profile.name,        "profilePath");
-               QUERY_STRING(msg, info5.description.name,    "description");
-               QUERY_STRING(msg, info5.workstations.name,   "userWorkstations");
-               QUERY_NTTIME(msg, info5.last_logon,          "lastLogon");
-               QUERY_NTTIME(msg, info5.last_logoff,         "lastLogoff");
-               QUERY_LHOURS(msg, info5.logon_hours,         "logonHours");
-               QUERY_UINT  (msg, info5.bad_pwd_count,       "badPwdCount");
-               QUERY_UINT  (msg, info5.num_logons,          "logonCount");
-               QUERY_NTTIME(msg, info5.last_pwd_change,     "pwdLastSet");
-               QUERY_NTTIME(msg, info5.acct_expiry,         "accountExpires");
-               QUERY_AFLAGS(msg, info5.acct_flags,          "userAccountControl");
+               QUERY_STRING(msg, info5.account_name.string,   "sAMAccountName");
+               QUERY_STRING(msg, info5.full_name.string,      "displayName");
+               QUERY_RID   (msg, info5.rid,                   "objectSid");
+               QUERY_UINT  (msg, info5.primary_gid,           "primaryGroupID");
+               QUERY_STRING(msg, info5.home_directory.string, "homeDirectory");
+               QUERY_STRING(msg, info5.home_drive.string,     "homeDrive");
+               QUERY_STRING(msg, info5.logon_script.string,   "scriptPath");
+               QUERY_STRING(msg, info5.profile_path.string,   "profilePath");
+               QUERY_STRING(msg, info5.description.string,    "description");
+               QUERY_STRING(msg, info5.workstations.string,   "userWorkstations");
+               QUERY_NTTIME(msg, info5.last_logon,            "lastLogon");
+               QUERY_NTTIME(msg, info5.last_logoff,           "lastLogoff");
+               QUERY_LHOURS(msg, info5.logon_hours,           "logonHours");
+               QUERY_UINT  (msg, info5.bad_password_count,    "badPwdCount");
+               QUERY_UINT  (msg, info5.logon_count,           "logonCount");
+               QUERY_NTTIME(msg, info5.last_password_change,  "pwdLastSet");
+               QUERY_NTTIME(msg, info5.acct_expiry,           "accountExpires");
+               QUERY_AFLAGS(msg, info5.acct_flags,            "userAccountControl");
                break;
 
        case 6:
-               QUERY_STRING(msg, info6.username.name,       "sAMAccountName");
-               QUERY_STRING(msg, info6.full_name.name,      "displayName");
+               QUERY_STRING(msg, info6.account_name.string,   "sAMAccountName");
+               QUERY_STRING(msg, info6.full_name.string,      "displayName");
                break;
 
        case 7:
-               QUERY_STRING(msg, info7.username.name,       "sAMAccountName");
+               QUERY_STRING(msg, info7.account_name.string,   "sAMAccountName");
                break;
 
        case 8:
-               QUERY_STRING(msg, info8.full_name.name,      "displayName");
+               QUERY_STRING(msg, info8.full_name.string,      "displayName");
                break;
 
        case 9:
-               QUERY_UINT  (msg, info9.primary_gid,         "primaryGroupID");
+               QUERY_UINT  (msg, info9.primary_gid,           "primaryGroupID");
                break;
 
        case 10:
-               QUERY_STRING(msg, info10.home_directory.name, "homeDirectory");
-               QUERY_STRING(msg, info10.home_drive.name,     "homeDrive");
+               QUERY_STRING(msg, info10.home_directory.string,"homeDirectory");
+               QUERY_STRING(msg, info10.home_drive.string,    "homeDrive");
                break;
 
        case 11:
-               QUERY_STRING(msg, info11.logon_script.name,   "scriptPath");
+               QUERY_STRING(msg, info11.logon_script.string,  "scriptPath");
                break;
 
        case 12:
-               QUERY_STRING(msg, info12.profile.name,        "profilePath");
+               QUERY_STRING(msg, info12.profile_path.string,  "profilePath");
                break;
 
        case 13:
-               QUERY_STRING(msg, info13.description.name,    "description");
+               QUERY_STRING(msg, info13.description.string,   "description");
                break;
 
        case 14:
-               QUERY_STRING(msg, info14.workstations.name,   "userWorkstations");
+               QUERY_STRING(msg, info14.workstations.string,  "userWorkstations");
                break;
 
        case 16:
-               QUERY_AFLAGS(msg, info16.acct_flags,          "userAccountControl");
+               QUERY_AFLAGS(msg, info16.acct_flags,           "userAccountControl");
                break;
 
        case 17:
-               QUERY_NTTIME(msg, info17.acct_expiry,         "accountExpires");
+               QUERY_NTTIME(msg, info17.acct_expiry,          "accountExpires");
 
        case 20:
-               QUERY_STRING(msg, info20.callback.name,       "userParameters");
+               QUERY_STRING(msg, info20.parameters.string,    "userParameters");
                break;
 
        case 21:
-               QUERY_NTTIME(msg, info21.last_logon,          "lastLogon");
-               QUERY_NTTIME(msg, info21.last_logoff,         "lastLogoff");
-               QUERY_NTTIME(msg, info21.last_pwd_change,     "pwdLastSet");
-               QUERY_NTTIME(msg, info21.acct_expiry,         "accountExpires");
-               QUERY_APASSC(msg, info21.allow_pwd_change,    "pwdLastSet");
-               QUERY_FPASSC(msg, info21.force_pwd_change,    "pwdLastSet");
-               QUERY_STRING(msg, info21.username.name,       "sAMAccountName");
-               QUERY_STRING(msg, info21.full_name.name,      "displayName");
-               QUERY_STRING(msg, info21.home_directory.name, "homeDirectory");
-               QUERY_STRING(msg, info21.home_drive.name,     "homeDrive");
-               QUERY_STRING(msg, info21.logon_script.name,   "scriptPath");
-               QUERY_STRING(msg, info21.profile.name,        "profilePath");
-               QUERY_STRING(msg, info21.description.name,    "description");
-               QUERY_STRING(msg, info21.workstations.name,   "userWorkstations");
-               QUERY_STRING(msg, info21.comment.name,        "comment");
-               QUERY_STRING(msg, info21.callback.name,       "userParameters");
-               QUERY_RID   (msg, info21.rid,                 "objectSid");
-               QUERY_UINT  (msg, info21.primary_gid,         "primaryGroupID");
-               QUERY_AFLAGS(msg, info21.acct_flags,          "userAccountControl");
+               QUERY_NTTIME(msg, info21.last_logon,           "lastLogon");
+               QUERY_NTTIME(msg, info21.last_logoff,          "lastLogoff");
+               QUERY_NTTIME(msg, info21.last_password_change, "pwdLastSet");
+               QUERY_NTTIME(msg, info21.acct_expiry,          "accountExpires");
+               QUERY_APASSC(msg, info21.allow_password_change,"pwdLastSet");
+               QUERY_FPASSC(msg, info21.force_password_change,"pwdLastSet");
+               QUERY_STRING(msg, info21.account_name.string,  "sAMAccountName");
+               QUERY_STRING(msg, info21.full_name.string,     "displayName");
+               QUERY_STRING(msg, info21.home_directory.string,"homeDirectory");
+               QUERY_STRING(msg, info21.home_drive.string,    "homeDrive");
+               QUERY_STRING(msg, info21.logon_script.string,  "scriptPath");
+               QUERY_STRING(msg, info21.profile_path.string,  "profilePath");
+               QUERY_STRING(msg, info21.description.string,   "description");
+               QUERY_STRING(msg, info21.workstations.string,  "userWorkstations");
+               QUERY_STRING(msg, info21.comment.string,       "comment");
+               QUERY_STRING(msg, info21.parameters.string,    "userParameters");
+               QUERY_RID   (msg, info21.rid,                  "objectSid");
+               QUERY_UINT  (msg, info21.primary_gid,          "primaryGroupID");
+               QUERY_AFLAGS(msg, info21.acct_flags,           "userAccountControl");
                r->out.info->info21.fields_present = 0x00FFFFFF;
-               QUERY_LHOURS(msg, info21.logon_hours,         "logonHours");
-               QUERY_UINT  (msg, info21.bad_pwd_count,       "badPwdCount");
-               QUERY_UINT  (msg, info21.num_logons,          "logonCount");
-               QUERY_UINT  (msg, info21.country_code,        "countryCode");
-               QUERY_UINT  (msg, info21.code_page,           "codePage");
+               QUERY_LHOURS(msg, info21.logon_hours,          "logonHours");
+               QUERY_UINT  (msg, info21.bad_password_count,   "badPwdCount");
+               QUERY_UINT  (msg, info21.logon_count,          "logonCount");
+               QUERY_UINT  (msg, info21.country_code,         "countryCode");
+               QUERY_UINT  (msg, info21.code_page,            "codePage");
                break;
                
 
@@ -1635,98 +2499,233 @@ static NTSTATUS samr_SetUserInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX
                                 struct samr_SetUserInfo *r)
 {
        struct dcesrv_handle *h;
-       struct samr_account_state *state;
-       struct ldb_message mod, *msg = &mod;
-       int i, ret;
+       struct samr_account_state *a_state;
+       struct ldb_message *msg;
+       int ret;
+       NTSTATUS status = NT_STATUS_OK;
 
-       DCESRV_PULL_HANDLE(h, r->in.handle, SAMR_HANDLE_USER);
+       DCESRV_PULL_HANDLE(h, r->in.user_handle, SAMR_HANDLE_USER);
 
-       state = h->data;
+       a_state = h->data;
 
-       ZERO_STRUCT(mod);
-       mod.dn = talloc_strdup(mem_ctx, state->basedn);
-       if (!mod.dn) {
+       msg = ldb_msg_new(mem_ctx);
+       if (msg == NULL) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       msg->dn = talloc_reference(mem_ctx, a_state->account_dn);
+       if (!msg->dn) {
                return NT_STATUS_NO_MEMORY;
        }
 
        switch (r->in.level) {
        case 2:
-               SET_STRING(msg, info2.comment.name,         "comment");
-               SET_UINT  (msg, info2.country_code,         "countryCode");
-               SET_UINT  (msg, info2.code_page,            "codePage");
+               SET_STRING(msg, info2.comment.string,          "comment");
+               SET_UINT  (msg, info2.country_code,            "countryCode");
+               SET_UINT  (msg, info2.code_page,               "codePage");
                break;
 
        case 4:
-               SET_LHOURS(msg, info4.logon_hours,          "logonHours");
+               SET_LHOURS(msg, info4.logon_hours,             "logonHours");
                break;
 
        case 6:
-               SET_STRING(msg, info6.full_name.name,       "displayName");
+               SET_STRING(msg, info6.full_name.string,        "displayName");
+               break;
+
+       case 7:
+               SET_STRING(msg, info7.account_name.string,     "samAccountName");
                break;
 
        case 8:
-               SET_STRING(msg, info8.full_name.name,       "displayName");
+               SET_STRING(msg, info8.full_name.string,        "displayName");
                break;
 
        case 9:
-               SET_UINT(msg, info9.primary_gid,            "primaryGroupID");
+               SET_UINT(msg, info9.primary_gid,               "primaryGroupID");
                break;
 
        case 10:
-               SET_STRING(msg, info10.home_directory.name, "homeDirectory");
-               SET_STRING(msg, info10.home_drive.name,     "homeDrive");
+               SET_STRING(msg, info10.home_directory.string,  "homeDirectory");
+               SET_STRING(msg, info10.home_drive.string,      "homeDrive");
                break;
 
        case 11:
-               SET_STRING(msg, info11.logon_script.name,   "scriptPath");
+               SET_STRING(msg, info11.logon_script.string,    "scriptPath");
                break;
 
        case 12:
-               SET_STRING(msg, info12.profile.name,        "profilePath");
+               SET_STRING(msg, info12.profile_path.string,    "profilePath");
                break;
 
        case 13:
-               SET_STRING(msg, info13.description.name,    "description");
+               SET_STRING(msg, info13.description.string,     "description");
                break;
 
        case 14:
-               SET_STRING(msg, info14.workstations.name,   "userWorkstations");
+               SET_STRING(msg, info14.workstations.string,    "userWorkstations");
                break;
 
        case 16:
-               SET_AFLAGS(msg, info16.acct_flags,          "userAccountControl");
+               SET_AFLAGS(msg, info16.acct_flags,             "userAccountControl");
                break;
 
        case 20:
-               SET_STRING(msg, info20.callback.name,       "userParameters");
+               SET_STRING(msg, info20.parameters.string,      "userParameters");
                break;
 
        case 21:
 #define IFSET(bit) if (bit & r->in.info->info21.fields_present)
-               IFSET(SAMR_FIELD_NAME)         SET_STRING(msg, info21.full_name.name,    "displayName");
-               IFSET(SAMR_FIELD_DESCRIPTION)  SET_STRING(msg, info21.description.name,  "description");
-               IFSET(SAMR_FIELD_COMMENT)      SET_STRING(msg, info21.comment.name,      "comment");
-               IFSET(SAMR_FIELD_LOGON_SCRIPT) SET_STRING(msg, info21.logon_script.name, "scriptPath");
-               IFSET(SAMR_FIELD_PROFILE)      SET_STRING(msg, info21.profile.name,      "profilePath");
-               IFSET(SAMR_FIELD_WORKSTATION)  SET_STRING(msg, info21.workstations.name, "userWorkstations");
-               IFSET(SAMR_FIELD_LOGON_HOURS)  SET_LHOURS(msg, info21.logon_hours,       "logonHours");
-               IFSET(SAMR_FIELD_CALLBACK)     SET_STRING(msg, info21.callback.name,     "userParameters");
-               IFSET(SAMR_FIELD_COUNTRY_CODE) SET_UINT(msg, info21.country_code,        "countryCode");
-               IFSET(SAMR_FIELD_CODE_PAGE)    SET_UINT(msg, info21.code_page,           "codePage");
+               IFSET(SAMR_FIELD_ACCOUNT_NAME)         
+                       SET_STRING(msg, info21.account_name.string, "samAccountName");
+               IFSET(SAMR_FIELD_FULL_NAME)         
+                       SET_STRING(msg, info21.full_name.string,    "displayName");
+               IFSET(SAMR_FIELD_DESCRIPTION)  
+                       SET_STRING(msg, info21.description.string,  "description");
+               IFSET(SAMR_FIELD_COMMENT)      
+                       SET_STRING(msg, info21.comment.string,      "comment");
+               IFSET(SAMR_FIELD_LOGON_SCRIPT) 
+                       SET_STRING(msg, info21.logon_script.string, "scriptPath");
+               IFSET(SAMR_FIELD_PROFILE_PATH)      
+                       SET_STRING(msg, info21.profile_path.string, "profilePath");
+               IFSET(SAMR_FIELD_WORKSTATIONS)  
+                       SET_STRING(msg, info21.workstations.string, "userWorkstations");
+               IFSET(SAMR_FIELD_LOGON_HOURS)  
+                       SET_LHOURS(msg, info21.logon_hours,         "logonHours");
+               IFSET(SAMR_FIELD_ACCT_FLAGS)     
+                       SET_AFLAGS(msg, info21.acct_flags,          "userAccountControl");
+               IFSET(SAMR_FIELD_PARAMETERS)     
+                       SET_STRING(msg, info21.parameters.string,   "userParameters");
+               IFSET(SAMR_FIELD_COUNTRY_CODE) 
+                       SET_UINT  (msg, info21.country_code,        "countryCode");
+               IFSET(SAMR_FIELD_CODE_PAGE)    
+                       SET_UINT  (msg, info21.code_page,           "codePage");
+
+
+               /* Any reason the rest of these can't be set? */
+#undef IFSET
+               break;
+
+       case 23:
+#define IFSET(bit) if (bit & r->in.info->info23.info.fields_present)
+               IFSET(SAMR_FIELD_ACCOUNT_NAME)         
+                       SET_STRING(msg, info23.info.account_name.string, "samAccountName");
+               IFSET(SAMR_FIELD_FULL_NAME)         
+                       SET_STRING(msg, info23.info.full_name.string,    "displayName");
+               IFSET(SAMR_FIELD_DESCRIPTION)  
+                       SET_STRING(msg, info23.info.description.string,  "description");
+               IFSET(SAMR_FIELD_COMMENT)      
+                       SET_STRING(msg, info23.info.comment.string,      "comment");
+               IFSET(SAMR_FIELD_LOGON_SCRIPT) 
+                       SET_STRING(msg, info23.info.logon_script.string, "scriptPath");
+               IFSET(SAMR_FIELD_PROFILE_PATH)      
+                       SET_STRING(msg, info23.info.profile_path.string, "profilePath");
+               IFSET(SAMR_FIELD_WORKSTATIONS)  
+                       SET_STRING(msg, info23.info.workstations.string, "userWorkstations");
+               IFSET(SAMR_FIELD_LOGON_HOURS)  
+                       SET_LHOURS(msg, info23.info.logon_hours,         "logonHours");
+               IFSET(SAMR_FIELD_ACCT_FLAGS)     
+                       SET_AFLAGS(msg, info23.info.acct_flags,          "userAccountControl");
+               IFSET(SAMR_FIELD_PARAMETERS)     
+                       SET_STRING(msg, info23.info.parameters.string,   "userParameters");
+               IFSET(SAMR_FIELD_COUNTRY_CODE) 
+                       SET_UINT  (msg, info23.info.country_code,        "countryCode");
+               IFSET(SAMR_FIELD_CODE_PAGE)    
+                       SET_UINT  (msg, info23.info.code_page,           "codePage");
+               IFSET(SAMR_FIELD_PASSWORD) {
+                       status = samr_set_password(dce_call,
+                                                  a_state->sam_ctx,
+                                                  a_state->account_dn,
+                                                  a_state->domain_state->domain_dn,
+                                                  mem_ctx, msg, 
+                                                  &r->in.info->info23.password);
+               } else IFSET(SAMR_FIELD_PASSWORD2) {
+                       status = samr_set_password(dce_call,
+                                                  a_state->sam_ctx,
+                                                  a_state->account_dn,
+                                                  a_state->domain_state->domain_dn,
+                                                  mem_ctx, msg, 
+                                                  &r->in.info->info23.password);
+               }
+#undef IFSET
+               break;
+
+               /* the set password levels are handled separately */
+       case 24:
+               status = samr_set_password(dce_call,
+                                          a_state->sam_ctx,
+                                          a_state->account_dn,
+                                          a_state->domain_state->domain_dn,
+                                          mem_ctx, msg, 
+                                          &r->in.info->info24.password);
+               break;
+
+       case 25:
+#define IFSET(bit) if (bit & r->in.info->info25.info.fields_present)
+               IFSET(SAMR_FIELD_ACCOUNT_NAME)         
+                       SET_STRING(msg, info25.info.account_name.string, "samAccountName");
+               IFSET(SAMR_FIELD_FULL_NAME)         
+                       SET_STRING(msg, info25.info.full_name.string,    "displayName");
+               IFSET(SAMR_FIELD_DESCRIPTION)  
+                       SET_STRING(msg, info25.info.description.string,  "description");
+               IFSET(SAMR_FIELD_COMMENT)      
+                       SET_STRING(msg, info25.info.comment.string,      "comment");
+               IFSET(SAMR_FIELD_LOGON_SCRIPT) 
+                       SET_STRING(msg, info25.info.logon_script.string, "scriptPath");
+               IFSET(SAMR_FIELD_PROFILE_PATH)      
+                       SET_STRING(msg, info25.info.profile_path.string, "profilePath");
+               IFSET(SAMR_FIELD_WORKSTATIONS)  
+                       SET_STRING(msg, info25.info.workstations.string, "userWorkstations");
+               IFSET(SAMR_FIELD_LOGON_HOURS)  
+                       SET_LHOURS(msg, info25.info.logon_hours,         "logonHours");
+               IFSET(SAMR_FIELD_ACCT_FLAGS)     
+                       SET_AFLAGS(msg, info25.info.acct_flags,          "userAccountControl");
+               IFSET(SAMR_FIELD_PARAMETERS)     
+                       SET_STRING(msg, info25.info.parameters.string,   "userParameters");
+               IFSET(SAMR_FIELD_COUNTRY_CODE) 
+                       SET_UINT  (msg, info25.info.country_code,        "countryCode");
+               IFSET(SAMR_FIELD_CODE_PAGE)    
+                       SET_UINT  (msg, info25.info.code_page,           "codePage");
+               IFSET(SAMR_FIELD_PASSWORD) {
+                       status = samr_set_password_ex(dce_call,
+                                                     a_state->sam_ctx,
+                                                     a_state->account_dn,
+                                                     a_state->domain_state->domain_dn,
+                                                     mem_ctx, msg, 
+                                                     &r->in.info->info25.password);
+               } else IFSET(SAMR_FIELD_PASSWORD2) {
+                       status = samr_set_password_ex(dce_call,
+                                                     a_state->sam_ctx,
+                                                     a_state->account_dn,
+                                                     a_state->domain_state->domain_dn,
+                                                     mem_ctx, msg, 
+                                                     &r->in.info->info25.password);
+               }
+#undef IFSET
+               break;
+
+               /* the set password levels are handled separately */
+       case 26:
+               status = samr_set_password_ex(dce_call,
+                                             a_state->sam_ctx,
+                                             a_state->account_dn,
+                                             a_state->domain_state->domain_dn,
+                                             mem_ctx, msg, 
+                                             &r->in.info->info26.password);
                break;
+               
 
        default:
                /* many info classes are not valid for SetUserInfo */
                return NT_STATUS_INVALID_INFO_CLASS;
        }
 
-       /* mark all the message elements as LDB_FLAG_MOD_REPLACE */
-       for (i=0;i<mod.num_elements;i++) {
-               mod.elements[i].flags = LDB_FLAG_MOD_REPLACE;
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
        }
 
        /* modify the samdb record */
-       ret = samdb_modify(state->sam_ctx, mem_ctx, &mod);
+       ret = samdb_replace(a_state->sam_ctx, mem_ctx, msg);
        if (ret != 0) {
                /* we really need samdb.c to return NTSTATUS */
                return NT_STATUS_UNSUCCESSFUL;
@@ -1736,23 +2735,69 @@ static NTSTATUS samr_SetUserInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX
 }
 
 
-/* 
-  samr_ChangePasswordUser 
-*/
-static NTSTATUS samr_ChangePasswordUser(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
-                      struct samr_ChangePasswordUser *r)
-{
-       DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
-}
-
-
 /* 
   samr_GetGroupsForUser 
 */
 static NTSTATUS samr_GetGroupsForUser(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_GetGroupsForUser *r)
 {
-       DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
+       struct dcesrv_handle *h;
+       struct samr_account_state *a_state;
+       struct samr_domain_state *d_state;
+       struct ldb_message **res;
+       const char * const attrs[2] = { "objectSid", NULL };
+       struct samr_RidWithAttributeArray *array;
+       int count;
+
+       DCESRV_PULL_HANDLE(h, r->in.user_handle, SAMR_HANDLE_USER);
+
+       a_state = h->data;
+       d_state = a_state->domain_state;
+
+       count = samdb_search_domain(a_state->sam_ctx, mem_ctx, NULL, &res,
+                                   attrs, d_state->domain_sid,
+                                   "(&(member=%s)(grouptype=%s)(objectclass=group))",
+                                   a_state->account_dn,
+                                   ldb_hexstr(mem_ctx,
+                                              GTYPE_SECURITY_GLOBAL_GROUP));
+       if (count < 0)
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+
+       array = talloc(mem_ctx, struct samr_RidWithAttributeArray);
+       if (array == NULL)
+               return NT_STATUS_NO_MEMORY;
+
+       array->count = 0;
+       array->rids = NULL;
+
+       if (count > 0) {
+               int i;
+               array->rids = talloc_array(mem_ctx, struct samr_RidWithAttribute,
+                                           count);
+
+               if (array->rids == NULL)
+                       return NT_STATUS_NO_MEMORY;
+
+               for (i=0; i<count; i++) {
+                       struct dom_sid *group_sid;
+
+                       group_sid = samdb_result_dom_sid(mem_ctx, res[i],
+                                                        "objectSid");
+                       if (group_sid == NULL) {
+                               DEBUG(0, ("Couldn't find objectSid attrib\n"));
+                               continue;
+                       }
+
+                       array->rids[array->count].rid =
+                               group_sid->sub_auths[group_sid->num_auths-1];
+                       array->rids[array->count].attributes = SE_GROUP_MANDATORY | SE_GROUP_ENABLED_BY_DEFAULT | SE_GROUP_ENABLED;
+                       array->count += 1;
+               }
+       }
+
+       r->out.rids = array;
+
+       return NT_STATUS_OK;
 }
 
 
@@ -1762,7 +2807,197 @@ static NTSTATUS samr_GetGroupsForUser(struct dcesrv_call_state *dce_call, TALLOC
 static NTSTATUS samr_QueryDisplayInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_QueryDisplayInfo *r)
 {
-       DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
+       struct dcesrv_handle *h;
+       struct samr_domain_state *d_state;
+       struct ldb_message **res;
+       int ldb_cnt, count, i;
+       const char * const attrs[4] = { "objectSid", "sAMAccountName",
+                                       "description", NULL };
+       struct samr_DispEntryFull *entriesFull = NULL;
+       struct samr_DispEntryAscii *entriesAscii = NULL;
+       struct samr_DispEntryGeneral * entriesGeneral = NULL;
+       const char *filter;
+
+       DCESRV_PULL_HANDLE(h, r->in.domain_handle, SAMR_HANDLE_DOMAIN);
+
+       d_state = h->data;
+
+       switch (r->in.level) {
+       case 1:
+       case 4:
+               filter = talloc_asprintf(mem_ctx, "(&(objectclass=user)"
+                                        "(sAMAccountType=%s))",
+                                        ldb_hexstr(mem_ctx,
+                                                   ATYPE_NORMAL_ACCOUNT));
+               break;
+       case 2:
+               filter = talloc_asprintf(mem_ctx, "(&(objectclass=user)"
+                                        "(sAMAccountType=%s))",
+                                        ldb_hexstr(mem_ctx,
+                                                   ATYPE_WORKSTATION_TRUST));
+               break;
+       case 3:
+       case 5:
+               filter = talloc_asprintf(mem_ctx, "(&(grouptype=%s)"
+                                        "(objectclass=group))",
+                                        ldb_hexstr(mem_ctx, GTYPE_SECURITY_GLOBAL_GROUP));
+               break;
+       default:
+               return NT_STATUS_INVALID_INFO_CLASS;
+       }
+
+       /* search for all requested objects in this domain. This could
+          possibly be cached and resumed based on resume_key */
+       ldb_cnt = samdb_search_domain(d_state->sam_ctx, mem_ctx,
+                                     d_state->domain_dn, &res, attrs,
+                                     d_state->domain_sid, "%s", filter);
+       if (ldb_cnt == -1) {
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+       }
+       if (ldb_cnt == 0 || r->in.max_entries == 0) {
+               return NT_STATUS_OK;
+       }
+
+       switch (r->in.level) {
+       case 1:
+               entriesGeneral = talloc_array(mem_ctx,
+                                               struct samr_DispEntryGeneral,
+                                               ldb_cnt);
+               break;
+       case 2:
+       case 3:
+               entriesFull = talloc_array(mem_ctx,
+                                            struct samr_DispEntryFull,
+                                            ldb_cnt);
+               break;
+       case 4:
+       case 5:
+               entriesAscii = talloc_array(mem_ctx,
+                                             struct samr_DispEntryAscii,
+                                             ldb_cnt);
+               break;
+       }
+
+       if ((entriesGeneral == NULL) && (entriesFull == NULL) &&
+           (entriesAscii == NULL))
+               return NT_STATUS_NO_MEMORY;
+
+       count = 0;
+
+       for (i=0; i<ldb_cnt; i++) {
+               struct dom_sid *objectsid;
+
+               objectsid = samdb_result_dom_sid(mem_ctx, res[i],
+                                                "objectSid");
+               if (objectsid == NULL)
+                       continue;
+
+               switch(r->in.level) {
+               case 1:
+                       entriesGeneral[count].idx = count + 1;
+                       entriesGeneral[count].rid = 
+                               objectsid->sub_auths[objectsid->num_auths-1];
+                       entriesGeneral[count].acct_flags =
+                               samdb_result_acct_flags(res[i], 
+                                                       "userAccountControl");
+                       entriesGeneral[count].account_name.string =
+                               samdb_result_string(res[i],
+                                                   "sAMAccountName", "");
+                       entriesGeneral[count].full_name.string =
+                               samdb_result_string(res[i], "displayName", "");
+                       entriesGeneral[count].description.string =
+                               samdb_result_string(res[i], "description", "");
+                       break;
+               case 2:
+               case 3:
+                       entriesFull[count].idx = count + 1;
+                       entriesFull[count].rid =
+                               objectsid->sub_auths[objectsid->num_auths-1];
+                       entriesFull[count].acct_flags =
+                               samdb_result_acct_flags(res[i], 
+                                                       "userAccountControl");
+                       if (r->in.level == 3) {
+                               /* We get a "7" here for groups */
+                               entriesFull[count].acct_flags = 7;
+                       }
+                       entriesFull[count].account_name.string =
+                               samdb_result_string(res[i], "sAMAccountName",
+                                                   "");
+                       entriesFull[count].description.string =
+                               samdb_result_string(res[i], "description", "");
+                       break;
+               case 4:
+               case 5:
+                       entriesAscii[count].idx = count + 1;
+                       entriesAscii[count].account_name.string =
+                               samdb_result_string(res[i], "sAMAccountName",
+                                                   "");
+                       break;
+               }
+
+               count += 1;
+       }
+
+       r->out.total_size = count;
+
+       if (r->in.start_idx >= count) {
+               r->out.returned_size = 0;
+               switch(r->in.level) {
+               case 1:
+                       r->out.info.info1.count = r->out.returned_size;
+                       r->out.info.info1.entries = NULL;
+                       break;
+               case 2:
+                       r->out.info.info2.count = r->out.returned_size;
+                       r->out.info.info2.entries = NULL;
+                       break;
+               case 3:
+                       r->out.info.info3.count = r->out.returned_size;
+                       r->out.info.info3.entries = NULL;
+                       break;
+               case 4:
+                       r->out.info.info4.count = r->out.returned_size;
+                       r->out.info.info4.entries = NULL;
+                       break;
+               case 5:
+                       r->out.info.info5.count = r->out.returned_size;
+                       r->out.info.info5.entries = NULL;
+                       break;
+               }
+       } else {
+               r->out.returned_size = MIN(count - r->in.start_idx,
+                                          r->in.max_entries);
+               switch(r->in.level) {
+               case 1:
+                       r->out.info.info1.count = r->out.returned_size;
+                       r->out.info.info1.entries =
+                               &(entriesGeneral[r->in.start_idx]);
+                       break;
+               case 2:
+                       r->out.info.info2.count = r->out.returned_size;
+                       r->out.info.info2.entries =
+                               &(entriesFull[r->in.start_idx]);
+                       break;
+               case 3:
+                       r->out.info.info3.count = r->out.returned_size;
+                       r->out.info.info3.entries =
+                               &(entriesFull[r->in.start_idx]);
+                       break;
+               case 4:
+                       r->out.info.info4.count = r->out.returned_size;
+                       r->out.info.info4.entries =
+                               &(entriesAscii[r->in.start_idx]);
+                       break;
+               case 5:
+                       r->out.info.info5.count = r->out.returned_size;
+                       r->out.info.info5.entries =
+                               &(entriesAscii[r->in.start_idx]);
+                       break;
+               }
+       }
+
+       return (r->out.returned_size < (count - r->in.start_idx)) ?
+               STATUS_MORE_ENTRIES : NT_STATUS_OK;
 }
 
 
@@ -1803,18 +3038,22 @@ static NTSTATUS samr_GetUserPwInfo(struct dcesrv_call_state *dce_call, TALLOC_CT
                                   struct samr_GetUserPwInfo *r)
 {
        struct dcesrv_handle *h;
-       struct samr_account_state *state;
+       struct samr_account_state *a_state;
 
        ZERO_STRUCT(r->out.info);
 
-       DCESRV_PULL_HANDLE(h, r->in.handle, SAMR_HANDLE_USER);
+       DCESRV_PULL_HANDLE(h, r->in.user_handle, SAMR_HANDLE_USER);
 
-       state = h->data;
+       a_state = h->data;
 
-       r->out.info.min_pwd_len = samdb_search_uint(state->sam_ctx, mem_ctx, 0, NULL, "minPwdLength", 
-                                                   "dn=%s", state->domain_state->basedn);
-       r->out.info.password_properties = samdb_search_uint(state->sam_ctx, mem_ctx, 0, NULL, "pwdProperties", 
-                                                           "dn=%s", state->basedn);
+       r->out.info.min_password_length = samdb_search_uint(a_state->sam_ctx, mem_ctx, 0,
+                                                           a_state->domain_state->domain_dn, "minPwdLength", 
+                                                           "dn=%s", 
+                                                           a_state->domain_state->domain_dn);
+       r->out.info.password_properties = samdb_search_uint(a_state->sam_ctx, mem_ctx, 0,
+                                                           a_state->account_dn, 
+                                                           "pwdProperties", 
+                                                           "dn=%s", a_state->account_dn);
        return NT_STATUS_OK;
 }
 
@@ -1825,7 +3064,67 @@ static NTSTATUS samr_GetUserPwInfo(struct dcesrv_call_state *dce_call, TALLOC_CT
 static NTSTATUS samr_RemoveMemberFromForeignDomain(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_RemoveMemberFromForeignDomain *r)
 {
-       DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
+       struct dcesrv_handle *h;
+       struct samr_domain_state *d_state;
+       const char *memberdn;
+       struct ldb_message **res;
+       const char * const attrs[3] = { "dn", "objectSid", NULL };
+       int i, count;
+
+       DCESRV_PULL_HANDLE(h, r->in.domain_handle, SAMR_HANDLE_DOMAIN);
+
+       d_state = h->data;
+
+       memberdn = samdb_search_string(d_state->sam_ctx, mem_ctx, NULL,
+                                      "dn", "(objectSid=%s)", 
+                                      ldap_encode_ndr_dom_sid(mem_ctx, r->in.sid));
+       if (memberdn == NULL)
+               return NT_STATUS_OBJECT_NAME_NOT_FOUND;
+
+       /* TODO: Does this call only remove alias members, or does it do this
+        * for domain groups as well? */
+
+       count = samdb_search_domain(d_state->sam_ctx, mem_ctx,
+                                   d_state->domain_dn, &res, attrs,
+                                   d_state->domain_sid,
+                                   "(&(member=%s)(objectClass=group)"
+                                   "(|(groupType=%s)(groupType=%s)))",
+                                   memberdn,
+                                   ldb_hexstr(mem_ctx,
+                                              GTYPE_SECURITY_BUILTIN_LOCAL_GROUP),
+                                   ldb_hexstr(mem_ctx,
+                                              GTYPE_SECURITY_DOMAIN_LOCAL_GROUP));
+
+       if (count < 0)
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+
+       for (i=0; i<count; i++) {
+               struct ldb_message *mod;
+
+               mod = ldb_msg_new(mem_ctx);
+               if (mod == NULL) {
+                       return NT_STATUS_NO_MEMORY;
+               }
+
+               mod->dn = talloc_reference(mod,
+                                          samdb_result_string(res[i], "dn",
+                                                              NULL));
+               if (mod->dn == NULL) {
+                       talloc_free(mod);
+                       continue;
+               }
+
+               if (samdb_msg_add_delval(d_state->sam_ctx, mem_ctx, mod,
+                                        "member", memberdn) != 0)
+                       return NT_STATUS_NO_MEMORY;
+
+               if (samdb_modify(d_state->sam_ctx, mem_ctx, mod) != 0)
+                       return NT_STATUS_UNSUCCESSFUL;
+
+               talloc_free(mod);
+       }
+
+       return NT_STATUS_OK;
 }
 
 
@@ -1850,7 +3149,8 @@ static NTSTATUS samr_QueryUserInfo2(struct dcesrv_call_state *dce_call, TALLOC_C
        struct samr_QueryUserInfo r1;
        NTSTATUS status;
 
-       r1.in.handle = r->in.handle;
+       ZERO_STRUCT(r1.out);
+       r1.in.user_handle = r->in.user_handle;
        r1.in.level  = r->in.level;
        
        status = samr_QueryUserInfo(dce_call, mem_ctx, &r1);
@@ -1865,9 +3165,25 @@ static NTSTATUS samr_QueryUserInfo2(struct dcesrv_call_state *dce_call, TALLOC_C
   samr_QueryDisplayInfo2 
 */
 static NTSTATUS samr_QueryDisplayInfo2(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
-                      struct samr_QueryDisplayInfo2 *r)
+                                      struct samr_QueryDisplayInfo2 *r)
 {
-       DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
+       struct samr_QueryDisplayInfo q;
+       NTSTATUS result;
+
+       q.in.domain_handle = r->in.domain_handle;
+       q.in.level = r->in.level;
+       q.in.start_idx = r->in.start_idx;
+       q.in.max_entries = r->in.max_entries;
+       q.in.buf_size = r->in.buf_size;
+       ZERO_STRUCT(q.out);
+
+       result = samr_QueryDisplayInfo(dce_call, mem_ctx, &q);
+
+       r->out.total_size = q.out.total_size;
+       r->out.returned_size = q.out.returned_size;
+       r->out.info = q.out.info;
+
+       return result;
 }
 
 
@@ -1911,30 +3227,13 @@ static NTSTATUS samr_RemoveMultipleMembersFromAlias(struct dcesrv_call_state *dc
 }
 
 
-/* 
-  samr_OemChangePasswordUser2 
-*/
-static NTSTATUS samr_OemChangePasswordUser2(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
-                      struct samr_OemChangePasswordUser2 *r)
-{
-       DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
-}
-
-
-/* 
-  samr_ChangePasswordUser2 
-*/
-static NTSTATUS samr_ChangePasswordUser2(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
-                      struct samr_ChangePasswordUser2 *r)
-{
-       DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
-}
-
-
 /* 
   samr_GetDomPwInfo 
 
   this fetches the default password properties for a domain
+
+  note that w2k3 completely ignores the domain name in this call, and 
+  always returns the information for the servers primary domain
 */
 static NTSTATUS samr_GetDomPwInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                                  struct samr_GetDomPwInfo *r)
@@ -1942,37 +3241,32 @@ static NTSTATUS samr_GetDomPwInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX
        struct ldb_message **msgs;
        int ret;
        const char * const attrs[] = {"minPwdLength", "pwdProperties", NULL };
-       void *sam_ctx;
+       struct ldb_context *sam_ctx;
 
-       if (r->in.name == NULL || r->in.name->name == NULL) {
-               return NT_STATUS_NO_SUCH_DOMAIN;
-       }
+       ZERO_STRUCT(r->out.info);
 
-       sam_ctx = samdb_connect();
+       sam_ctx = samdb_connect(mem_ctx);
        if (sam_ctx == NULL) {
                return NT_STATUS_INVALID_SYSTEM_SERVICE;
        }
 
-       ret = samdb_search(sam_ctx, 
+       ret = gendb_search(sam_ctx, 
                           mem_ctx, NULL, &msgs, attrs, 
-                          "(&(name=%s)(objectclass=domain))",
-                          r->in.name->name);
+                          "(&(!(objectClass=builtinDomain))(objectclass=domain))");
        if (ret <= 0) {
-               samdb_close(sam_ctx);
                return NT_STATUS_NO_SUCH_DOMAIN;
        }
        if (ret > 1) {
-               samdb_search_free(sam_ctx, mem_ctx, msgs);
-               samdb_close(sam_ctx);
+               talloc_free(msgs);
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
-       r->out.info.min_pwd_len         = samdb_result_uint(msgs[0], "minPwdLength", 0);
+       r->out.info.min_password_length = samdb_result_uint(msgs[0], "minPwdLength", 0);
        r->out.info.password_properties = samdb_result_uint(msgs[0], "pwdProperties", 1);
 
-       samdb_search_free(sam_ctx, mem_ctx, msgs);
+       talloc_free(msgs);
 
-       samdb_close(sam_ctx);
+       talloc_free(sam_ctx);
        return NT_STATUS_OK;
 }
 
@@ -1987,7 +3281,7 @@ static NTSTATUS samr_Connect2(struct dcesrv_call_state *dce_call, TALLOC_CTX *me
 
        c.in.system_name = NULL;
        c.in.access_mask = r->in.access_mask;
-       c.out.handle = r->out.handle;
+       c.out.connect_handle = r->out.connect_handle;
 
        return samr_Connect(dce_call, mem_ctx, &c);
 }
@@ -2003,7 +3297,7 @@ static NTSTATUS samr_SetUserInfo2(struct dcesrv_call_state *dce_call, TALLOC_CTX
 {
        struct samr_SetUserInfo r2;
 
-       r2.in.handle = r->in.handle;
+       r2.in.user_handle = r->in.user_handle;
        r2.in.level = r->in.level;
        r2.in.info = r->in.info;
 
@@ -2041,7 +3335,7 @@ static NTSTATUS samr_Connect3(struct dcesrv_call_state *dce_call, TALLOC_CTX *me
 
        c.in.system_name = NULL;
        c.in.access_mask = r->in.access_mask;
-       c.out.handle = r->out.handle;
+       c.out.connect_handle = r->out.connect_handle;
 
        return samr_Connect(dce_call, mem_ctx, &c);
 }
@@ -2057,22 +3351,12 @@ static NTSTATUS samr_Connect4(struct dcesrv_call_state *dce_call, TALLOC_CTX *me
 
        c.in.system_name = NULL;
        c.in.access_mask = r->in.access_mask;
-       c.out.handle = r->out.handle;
+       c.out.connect_handle = r->out.connect_handle;
 
        return samr_Connect(dce_call, mem_ctx, &c);
 }
 
 
-/* 
-  samr_ChangePasswordUser3 
-*/
-static NTSTATUS samr_ChangePasswordUser3(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
-                      struct samr_ChangePasswordUser3 *r)
-{
-       DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
-}
-
-
 /* 
   samr_Connect5 
 */
@@ -2084,7 +3368,7 @@ static NTSTATUS samr_Connect5(struct dcesrv_call_state *dce_call, TALLOC_CTX *me
 
        c.in.system_name = NULL;
        c.in.access_mask = r->in.access_mask;
-       c.out.handle = r->out.handle;
+       c.out.connect_handle = r->out.connect_handle;
 
        status = samr_Connect(dce_call, mem_ctx, &c);
 
@@ -2120,7 +3404,7 @@ static NTSTATUS samr_SetDsrmPassword(struct dcesrv_call_state *dce_call, TALLOC_
   samr_ValidatePassword 
 */
 static NTSTATUS samr_ValidatePassword(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
-                      struct samr_ValidatePassword *r)
+                                     struct samr_ValidatePassword *r)
 {
        DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
 }