Andrew Bartlett [Mon, 28 May 2012 04:55:39 +0000 (14:55 +1000)]
lib/param: Add .flags to max/min protocol to match s3
This reduces the difference in the parameter tables.
Andrew Bartlett
Andrew Bartlett [Mon, 28 May 2012 04:53:26 +0000 (14:53 +1000)]
lib/param: Add .flags to wins parameters to match s3
This reduces the difference in the parameter tables.
Andrew Bartlett
Andrew Bartlett [Mon, 28 May 2012 04:47:28 +0000 (14:47 +1000)]
lib/param: Harmonise 'password server' parameter between s3 and s4
Andrew Bartlett [Tue, 22 May 2012 01:56:50 +0000 (11:56 +1000)]
s3-build: Remove build of libtdb.so from the autoconf build
We now either link tdb statically or we use the system provided tdb
This means that we now only have one build system for externally-available
tdb, which in turn ensures we have a consistent shared library built as
libtdb.so
Andrew Bartlett
Andrew Bartlett [Tue, 22 May 2012 01:55:49 +0000 (11:55 +1000)]
s3-build: Remove build of libtalloc.so from the autoconf build
We now either link talloc statically or we use the system provided talloc
This means that we now only have one build system for externally-available
talloc, which in turn ensures we have a consistent shared library built as
libtalloc.so
Andrew Bartlett
Andrew Bartlett [Mon, 28 May 2012 02:13:14 +0000 (12:13 +1000)]
s3-iconv: Remove unused script/gen-8bit-gap.sh
We decided to rely on a system iconv rather than these
modules.
Andrew Bartlett
Andrew Bartlett [Mon, 28 May 2012 02:50:34 +0000 (12:50 +1000)]
build: Provide .pc file for libsmbsharemodes
This is not the exact same file as the autoconf build, because of
the differnet processing semantics.
Andrew Bartlett
Andrew Bartlett [Mon, 28 May 2012 02:50:05 +0000 (12:50 +1000)]
build: Provide .pc file for libnetapi
This is not the exact same file as the autoconf build, because of
the differnet processing semantics.
Andrew Bartlett
Andrew Bartlett [Tue, 29 May 2012 08:56:56 +0000 (18:56 +1000)]
build: Remove unused release scripts for tevent
These now use waf dist, and the script/librelease.sh script as a wrapper.
The mksyms.sh call in the source3/Makefile uses the copy in source3/script
Andrew Bartlett
Andrew Bartlett [Tue, 29 May 2012 08:56:36 +0000 (18:56 +1000)]
build: Remove unused release scripts for tdb
These now use waf dist, and the script/librelease.sh script as a wrapper.
The mksyms.sh call in the source3/Makefile uses the copy in source3/script
Andrew Bartlett
Andrew Bartlett [Mon, 28 May 2012 02:15:05 +0000 (12:15 +1000)]
build: Remove unused release scripts for talloc
These now use waf dist, and the script/librelease.sh script as a wrapper.
The mksyms.sh call in the source3/Makefile uses the copy in source3/script
Andrew Bartlett
Kai Blin [Tue, 29 May 2012 21:05:14 +0000 (23:05 +0200)]
libcli/dns: Rename UDP-based calls to reflect their use
Autobuild-User: Kai Blin <kai@samba.org>
Autobuild-Date: Wed May 30 02:35:27 CEST 2012 on sn-devel-104
Kai Blin [Fri, 25 May 2012 05:54:39 +0000 (07:54 +0200)]
Add myself as libcli/dns maintainer
Kai Blin [Tue, 29 May 2012 22:30:29 +0000 (00:30 +0200)]
s4-dns: Use W_ERROR_HAVE_NO_MEMORY in create_response_rr
Kai Blin [Tue, 29 May 2012 22:23:33 +0000 (00:23 +0200)]
s4-dns: Use proper talloc hierarchy for NS records in create_response_rr
Kai Blin [Tue, 29 May 2012 22:23:14 +0000 (00:23 +0200)]
s4-dns: Use proper talloc hierarchy for AAAA records in create_response_rr
Volker Lendecke [Tue, 29 May 2012 08:03:13 +0000 (10:03 +0200)]
s4-dns: Remove sync dns_process
Signed-off-by: Kai Blin <kai@samba.org>
Volker Lendecke [Mon, 28 May 2012 16:42:54 +0000 (18:42 +0200)]
s4-dns: Make the TCP dns server async
Signed-off-by: Kai Blin <kai@samba.org>
Volker Lendecke [Mon, 28 May 2012 16:42:54 +0000 (18:42 +0200)]
s4-dns: Make the UDP dns server async
Signed-off-by: Kai Blin <kai@samba.org>
Volker Lendecke [Mon, 28 May 2012 16:23:50 +0000 (18:23 +0200)]
s4-dns: Remove sync dns_server_process_query
Signed-off-by: Kai Blin <kai@samba.org>
Volker Lendecke [Thu, 24 May 2012 15:02:57 +0000 (17:02 +0200)]
s4-dns: Make dns_process_send asyn
Signed-off-by: Kai Blin <kai@samba.org>
Volker Lendecke [Thu, 24 May 2012 14:46:29 +0000 (16:46 +0200)]
s4-dns: Remove unused sync ask_forwarder wrapper
Signed-off-by: Kai Blin <kai@samba.org>
Volker Lendecke [Thu, 24 May 2012 12:53:47 +0000 (14:53 +0200)]
s4-dns: Make dns_server_process_query async
Signed-off-by: Kai Blin <kai@samba.org>
Volker Lendecke [Thu, 24 May 2012 11:49:41 +0000 (13:49 +0200)]
s4-dns: Make ask_forwarder async
Signed-off-by: Kai Blin <kai@samba.org>
Volker Lendecke [Thu, 24 May 2012 11:49:26 +0000 (13:49 +0200)]
lib: add tevent_req_poll_werror
Signed-off-by: Kai Blin <kai@samba.org>
Volker Lendecke [Tue, 29 May 2012 13:20:21 +0000 (15:20 +0200)]
s4-dns: Create a proper talloc hierarchy in create_response_rr
Pair-Programmed-With: Michael Adam <obnox@samba.org>
Signed-off-by: Kai Blin <kai@samba.org>
Volker Lendecke [Tue, 29 May 2012 07:45:44 +0000 (09:45 +0200)]
s4-dns: Add debug output for unmappable WERROR to DNS errcode
Signed-off-by: Kai Blin <kai@samba.org>
Volker Lendecke [Tue, 29 May 2012 06:53:44 +0000 (08:53 +0200)]
s4-dns: Fix some typos
Signed-off-by: Kai Blin <kai@samba.org>
Volker Lendecke [Tue, 29 May 2012 06:45:07 +0000 (08:45 +0200)]
librpc: Fix some typos
Signed-off-by: Kai Blin <kai@samba.org>
Volker Lendecke [Thu, 24 May 2012 14:15:41 +0000 (16:15 +0200)]
s4-dns: Remove some break; statements
We fall through implicitly, and that pattern is used elsewhere in Samba as
well.
Signed-off-by: Kai Blin <kai@samba.org>
Volker Lendecke [Thu, 24 May 2012 13:59:32 +0000 (15:59 +0200)]
s4-dns: Fix an unlikely potential memleak
If state was alloc'ed to NULL, in_packet to != NULL and out_packet to NULL, we
leak in_packet.
Signed-off-by: Kai Blin <kai@samba.org>
Volker Lendecke [Thu, 24 May 2012 12:57:49 +0000 (14:57 +0200)]
s4-dns: Use talloc_asprintf_append_buffer in create_response_rr
Signed-off-by: Kai Blin <kai@samba.org>
Volker Lendecke [Thu, 24 May 2012 12:57:11 +0000 (14:57 +0200)]
s4-dns: Add some NULL checks to create_response_rr
Signed-off-by: Kai Blin <kai@samba.org>
Matthias Dieter Wallnöfer [Thu, 24 May 2012 18:43:17 +0000 (20:43 +0200)]
s4:dbchecker - handle the "none" case correctly
This means that *no* fixing will be done, also the first possible one
will be omitted as well.
Reviewed-by: abartlet
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Tue May 29 21:36:25 CEST 2012 on sn-devel-104
Stefan Metzmacher [Tue, 29 May 2012 12:08:43 +0000 (14:08 +0200)]
s3:smb2_ioctl: verify credit charge
Based on a patch from Christian Ambach <ambi@samba.org>.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue May 29 18:55:29 CEST 2012 on sn-devel-104
Stefan Metzmacher [Tue, 29 May 2012 11:25:31 +0000 (13:25 +0200)]
s3:smb2_ioctl: add more validation checks
metze
Stefan Metzmacher [Tue, 29 May 2012 10:06:22 +0000 (12:06 +0200)]
s3:smb2_ioctl: add some more validation checks
Based on a patch from Christian Ambach <ambi@samba.org>.
metze
Günther Deschner [Fri, 25 May 2012 12:50:11 +0000 (14:50 +0200)]
s4-torture: verify #8373 and add ndr nbt tests for LOGON_PRIMARY_QUERY nbt_netlogon_requests.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue May 29 15:49:10 CEST 2012 on sn-devel-104
Christian Ambach [Thu, 10 May 2012 12:51:13 +0000 (14:51 +0200)]
s4:torture report connection error via torture_fail
to make smbtorture report the error instead of complaining about missing torture_ call
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue May 29 13:57:42 CEST 2012 on sn-devel-104
Christian Ambach [Fri, 11 May 2012 17:03:50 +0000 (19:03 +0200)]
s3:smbd/smb2_find add a debug message
like the ones in the other calls that check for max sizes
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Christian Ambach [Fri, 11 May 2012 17:03:32 +0000 (19:03 +0200)]
s3:smbd/smb2_getinfo add a debug message
like the ones in the other calls that check for max sizes
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Christian Ambach [Fri, 11 May 2012 17:02:21 +0000 (19:02 +0200)]
s3:smbd/smb2_setinfo add a debug message
similar to the ones present in other paths
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Christian Ambach [Fri, 11 May 2012 17:01:43 +0000 (19:01 +0200)]
s3:smbd/smb2_read improve debug message
make the message similar to the ones in other paths
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Tue, 29 May 2012 08:08:51 +0000 (10:08 +0200)]
libcli/smb: add some more FSCTL_* defines
metze
Stefan Metzmacher [Tue, 29 May 2012 05:27:14 +0000 (07:27 +0200)]
s3:smb2cli_ioctl: fix requests without output_buffer.length > 0 against windows
This fixes DCERPC over SMB2 against windows servers.
metze
Björn Jacke [Tue, 29 May 2012 06:01:40 +0000 (08:01 +0200)]
s3: fix compile of krb5 locator on Solaris
the krb5 locator plugin on Solaris needs LIBREPLACE_LIBS (bug #8732)
Autobuild-User: Björn Jacke <bj@sernet.de>
Autobuild-Date: Tue May 29 09:58:42 CEST 2012 on sn-devel-104
Alexander Bokovoy [Mon, 28 May 2012 16:03:00 +0000 (19:03 +0300)]
freebsd9: support both WAF MIT krb5 build and autoconf build against MIT krb5
System-provided Heimdal Kerberos in FreeBSD 9 lacks proper support for parsing MS PAC.
This leaves us with MIT krb5 package from ports or embedded Heimdal in source4.
MIT krb5 from ports is 1.9.2, it supports all needed features for AD support in smbd,
as well as WAF MIT krb5 build. In order to use it, one needs to install 'krb5' package.
Autoconf build:
--with-krb5=/usr/local
WAF build:
--with-system-mitkrb5 /usr/local
or otherwise krb5-config from system Heimdal will overtake and break the detection, leaving
you with a mixture of Kerberos libraries from different locations.
WAF build accepts multiple paths as sub-arguments of the --with-system-mitkrb5 and searches
through them for krb5-config, i.e. /usr/local /usr/kerberos ...
Autobuild-User: Alexander Bokovoy <ab@samba.org>
Autobuild-Date: Mon May 28 23:40:30 CEST 2012 on sn-devel-104
Stefan Metzmacher [Mon, 28 May 2012 17:44:04 +0000 (19:44 +0200)]
s4:ntvfs/ipc: fix protocol specific processing of pipe names
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon May 28 21:48:47 CEST 2012 on sn-devel-104
Stefan Metzmacher [Mon, 28 May 2012 13:56:14 +0000 (15:56 +0200)]
s3:selftest: run rpc.samba3.smb[1|2]-pipe-name
metze
Stefan Metzmacher [Mon, 28 May 2012 14:49:23 +0000 (16:49 +0200)]
s3:rpc_server: don't do any magic in is_known_pipename() anymore
The callers have to check if they allow something else than
the raw pipe file name.
If we allow more than windows allows, we risks Samba specific
client behavior. E.g. winbindd only works against Samba servers.
metze
Stefan Metzmacher [Mon, 28 May 2012 16:23:50 +0000 (18:23 +0200)]
s3:smbd: fix reply_open_pipe_and_X() to behave like windows (2008 R2)
See rpc.samba3.smb1-pipe-name.
metze
Stefan Metzmacher [Mon, 28 May 2012 14:40:36 +0000 (16:40 +0200)]
s3:smbd: only strip \\ off the name if present (for ntcreatex)
metze
Stefan Metzmacher [Mon, 28 May 2012 14:27:29 +0000 (16:27 +0200)]
s3:rpc_server: return OBJECT_NAME_NOT_FOUND instead of PIPE_NOT_AVAILABLE
metze
Stefan Metzmacher [Mon, 28 May 2012 13:25:53 +0000 (15:25 +0200)]
s3:smb2_create: do not remove leading backslash from pipe names
metze
Stefan Metzmacher [Mon, 28 May 2012 14:23:22 +0000 (16:23 +0200)]
s4:torture/samba3rpc: add smb1-pipe-name
metze
Stefan Metzmacher [Mon, 28 May 2012 13:38:00 +0000 (15:38 +0200)]
s4:torture/samba3rpc: add smb2-pipe-name
metze
Stefan Metzmacher [Mon, 28 May 2012 13:29:17 +0000 (15:29 +0200)]
s3:cli_np_tstream: pass a leading backslash for the pipe name for SMB1
metze
Stefan Metzmacher [Mon, 28 May 2012 16:43:29 +0000 (18:43 +0200)]
s3:rpc_client: tstream_cli_np_open_send() doesn't expect a leading backslash
This fixes winbindd against a windows server using SMB2.
metze
Luk Claes [Sat, 26 May 2012 10:14:51 +0000 (12:14 +0200)]
s3:libsmb: get rid of cli_ucs2
Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon May 28 16:58:03 CEST 2012 on sn-devel-104
Luk Claes [Sat, 26 May 2012 10:07:38 +0000 (12:07 +0200)]
s3:libsmb: get rid of clisigning routines
Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Luk Claes [Sat, 26 May 2012 09:45:09 +0000 (11:45 +0200)]
s3:libsmb: get rid of cli_has_async_calls
Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Luk Claes [Sun, 20 May 2012 15:54:29 +0000 (17:54 +0200)]
s3:libsmb: get rid of cli_negprot
Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Luk Claes [Sun, 20 May 2012 14:26:25 +0000 (16:26 +0200)]
s3:libsmb: get rid of cli_state_disconnect
Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Luk Claes [Sat, 19 May 2012 16:50:27 +0000 (18:50 +0200)]
s3:libsmb: get rid of cli_state_server_time_zone
Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Luk Claes [Sat, 19 May 2012 16:47:31 +0000 (18:47 +0200)]
s3:libsmb: get rid of cli_state_security_mode
Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Luk Claes [Sat, 19 May 2012 16:44:48 +0000 (18:44 +0200)]
s3:libsmb: get rid of cli_state_server_gss_blob
Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Luk Claes [Sat, 19 May 2012 16:42:56 +0000 (18:42 +0200)]
s3:libsmb: get rid of cli_state_server_challenge
Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Luk Claes [Sat, 19 May 2012 16:39:44 +0000 (18:39 +0200)]
s3:libsmb: get rid of cli_state_encryption_on
Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Luk Claes [Sat, 19 May 2012 16:35:51 +0000 (18:35 +0200)]
s3:libsmb: get rid of cli_state_max_requests
Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Luk Claes [Sat, 19 May 2012 16:32:51 +0000 (18:32 +0200)]
s3:libsmb: get rid of cli_state_server_session_key
Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Luk Claes [Sat, 19 May 2012 16:23:40 +0000 (18:23 +0200)]
s3:libsmb: get rid of cli_state_capabilities
Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Luk Claes [Sat, 19 May 2012 16:09:30 +0000 (18:09 +0200)]
s3:libsmb: get rid of cli_state_protocol
Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Luk Claes [Sat, 19 May 2012 15:31:50 +0000 (17:31 +0200)]
s3:libsmb: get rid of cli_state_remote_name
Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Luk Claes [Sat, 19 May 2012 15:15:23 +0000 (17:15 +0200)]
s3:libsmb: get rid of cli_state_*_sockaddr
Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Luk Claes [Sat, 19 May 2012 14:58:28 +0000 (16:58 +0200)]
s3:libsmb: get rid of cli_sockopt
Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Luk Claes [Sat, 19 May 2012 14:21:14 +0000 (16:21 +0200)]
s3:libsmb: remove unused (un)set_pending functions
Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Jelmer Vernooij [Sun, 27 May 2012 12:17:52 +0000 (14:17 +0200)]
Avoid all(), as it's not available in Python 2.4.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun May 27 16:13:34 CEST 2012 on sn-devel-104
Andrew Bartlett [Sun, 27 May 2012 03:20:56 +0000 (13:20 +1000)]
build: Remove all references to libuuid
We simply do not need this library any more.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sun May 27 11:08:22 CEST 2012 on sn-devel-104
Andriy Syrovenko [Sat, 26 May 2012 20:29:44 +0000 (23:29 +0300)]
build: Add option to specify where gettext is (/usr/local by default)
This should help configure script to find gettext on FreeBSD and
(possibly) some other systems as well.
Andriy Syrovenko [Sat, 26 May 2012 20:41:16 +0000 (23:41 +0300)]
Eliminate dependency on an external uuid library.
Andrew Bartlett [Tue, 22 May 2012 02:01:44 +0000 (12:01 +1000)]
s3-build: Remove build of libaddns.a from the autoconf build
We always link libaddns statically as part of the net object lists
This means that we no longer provide externally-available
libaddns, as the waf build declared this as a private library.
This never had a public API, .so or a header file.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sat May 26 09:45:34 CEST 2012 on sn-devel-104
Andrew Bartlett [Fri, 18 May 2012 12:02:57 +0000 (22:02 +1000)]
s3-utils: Use ads_do_search_retry in net ads search
This makes it possible to search against a slow server, as will
fallback from 1000 to (eventually) 125 users at a time.
Andrew Bartlett
Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat May 26 03:53:34 CEST 2012 on sn-devel-104
Andrew Bartlett [Fri, 18 May 2012 12:01:14 +0000 (22:01 +1000)]
s3-libads: Use a reducing page size to try and cope with a slow LDAP server
If we cannot get 1000 users downloaded in 15seconds, try with 500, 250
and then 125 users at a time.
Andrew Bartlett
Signed-off-by: Jeremy Allison <jra@samba.org>
Andrew Bartlett [Fri, 18 May 2012 07:40:59 +0000 (17:40 +1000)]
s3-winbindd: Always map the LDAP error code to an NTSTATUS
We do this so that we catch LDAP_TIMELIMIT_EXCEEDED as NT_STATUS_IO_TIMEOUT, which
has special handling in winbindd_cache.c
Andrew Bartlett
Signed-off-by: Jeremy Allison <jra@samba.org>
Andrew Bartlett [Fri, 18 May 2012 07:38:48 +0000 (17:38 +1000)]
s3-libads: Map LDAP_TIMELIMIT_EXCEEDED as NT_STATUS_IO_TIMEOUT
This allows Samba to then handle this error in the same way it would for RPC connections
Andrew Bartlett
Signed-off-by: Jeremy Allison <jra@samba.org>
Alexander Bokovoy [Fri, 25 May 2012 15:45:17 +0000 (18:45 +0300)]
dns_hosts_file: move to a separate subsystem
After discussion with Kai move dns_hosts_file to a separate subsystem
and merge it into libaddns private library for s3/s4 client use.
Also remove dependency in libcli/nbt, the code from libcli/dns subsystems
is not used there at all.
Autobuild-User: Alexander Bokovoy <ab@samba.org>
Autobuild-Date: Fri May 25 22:22:44 CEST 2012 on sn-devel-104
Alexander Bokovoy [Fri, 25 May 2012 10:25:12 +0000 (13:25 +0300)]
s3-configure.in: when ADS support is disabled, unset HAVE_GSSAPI
Stefan Metzmacher [Wed, 16 May 2012 07:11:40 +0000 (09:11 +0200)]
s3:selftest: run smbtorture3 CLEANUP3 in the s3dc:local environment
metze
Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri May 25 20:09:15 CEST 2012 on sn-devel-104
Volker Lendecke [Fri, 11 May 2012 12:39:42 +0000 (14:39 +0200)]
s3: Test whether get_share_mode_lock cleans up stale processes
Signed-off-by: Jeremy Allison <jra@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Volker Lendecke [Mon, 7 May 2012 14:34:11 +0000 (16:34 +0200)]
s3: Do not check the PIDs is parse_share_modes
We do that when conflicts arise
Signed-off-by: Jeremy Allison <jra@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Jeremy Allison [Tue, 22 May 2012 19:28:04 +0000 (12:28 -0700)]
Ensure we only return NT_STATUS_DELETE_PENDING if the share modes are valid.
Ensure we only return *file_existed = true if there were valid share modes.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Volker Lendecke [Mon, 7 May 2012 13:23:29 +0000 (15:23 +0200)]
s3: Check for serverid_exists in close_directory
Signed-off-by: Jeremy Allison <jra@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Volker Lendecke [Mon, 7 May 2012 13:23:29 +0000 (15:23 +0200)]
s3: Check for serverid_exists in close_remove_share_mode
Signed-off-by: Jeremy Allison <jra@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Volker Lendecke [Mon, 14 May 2012 12:57:34 +0000 (14:57 +0200)]
s3: Be less picky on stale share mode entries
If a process died, the share mode entry might be bogus. Ignore those entries.
Signed-off-by: Jeremy Allison <jra@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Volker Lendecke [Mon, 7 May 2012 13:23:29 +0000 (15:23 +0200)]
s3: Check for serverid_exists in find_oplock_types
Signed-off-by: Jeremy Allison <jra@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Volker Lendecke [Mon, 7 May 2012 13:23:10 +0000 (15:23 +0200)]
s3: Check for serverid_exists in rename_share_filename
Signed-off-by: Jeremy Allison <jra@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Volker Lendecke [Mon, 7 May 2012 13:23:29 +0000 (15:23 +0200)]
s3: Check for serverid_exists in smb_posix_unlink
Signed-off-by: Jeremy Allison <jra@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Volker Lendecke [Mon, 7 May 2012 13:23:10 +0000 (15:23 +0200)]
s3: Check for serverid_exists in open_mode_check
Signed-off-by: Jeremy Allison <jra@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Volker Lendecke [Mon, 7 May 2012 10:22:50 +0000 (12:22 +0200)]
s3: Check for serverid_exists in notify_deferred_opens
We will remove the check in parse_share_modes soon
Signed-off-by: Jeremy Allison <jra@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Jeremy Allison [Tue, 22 May 2012 19:27:06 +0000 (12:27 -0700)]
Fix an invalid state only reachable on server crash/abort.
Remove any delete-on-close tokens and clear the count if there are no
valid share modes.
Signed-off-by: Stefan Metzmacher <metze@samba.org>