Jeremy Allison [Sat, 11 Mar 2006 02:09:18 +0000 (02:09 +0000)]
r14182: Ensure we know that dom_sid cannot be null.
Jeremy.
Jeremy Allison [Fri, 10 Mar 2006 23:52:37 +0000 (23:52 +0000)]
r14178: Clarify code for Coverity #49. Ensure we know we
can't have an uninitialized *returned val.
Jeremy.
Jeremy Allison [Fri, 10 Mar 2006 23:22:38 +0000 (23:22 +0000)]
r14176: Fix coverity bug #30. Ensure no possible null deref.
Jeremy.
Jeremy Allison [Fri, 10 Mar 2006 18:32:18 +0000 (18:32 +0000)]
r14170: Paranioa fix for sesssetup.
Fix Coverity bug #26. Guard against NULL ref.
Jeremy.
Jeremy Allison [Fri, 10 Mar 2006 17:52:41 +0000 (17:52 +0000)]
r14168: Fix Coverity #219. I think this is a false coverity
warning as it seems to get confused with assignment
and comparison. Clarify the code anyway.
Jeremy.
Jeremy Allison [Fri, 10 Mar 2006 17:51:22 +0000 (17:51 +0000)]
r14166: Fix const warning.
Jeremy.
Alexander Bokovoy [Fri, 10 Mar 2006 14:39:29 +0000 (14:39 +0000)]
r14158: Fix coverity CID #147 -- do not dereference pointers before checking their existence
Jim McDonough [Fri, 10 Mar 2006 14:28:51 +0000 (14:28 +0000)]
r14156: Fix coverity #114: free storage alloc'ed by sstring_sub()
Jim McDonough [Fri, 10 Mar 2006 14:20:09 +0000 (14:20 +0000)]
r14155: Fix coverity #115: free storage alloc'ed by sstring_sub()
Jim McDonough [Fri, 10 Mar 2006 14:17:44 +0000 (14:17 +0000)]
r14153: Fix coverity #116: free storage alloc'ed by sstring_sub()
Jim McDonough [Fri, 10 Mar 2006 14:14:23 +0000 (14:14 +0000)]
r14152: Fix coverity #117: free storage alloc'ed by sstring_sub
Jim McDonough [Fri, 10 Mar 2006 14:09:34 +0000 (14:09 +0000)]
r14150: Fix coverity #118: not freeing alloc'ed storage returned from
sstring_sub().
Günther Deschner [Fri, 10 Mar 2006 13:36:39 +0000 (13:36 +0000)]
r14148: Removing the not very well tested krb5 ticket refresh handling activated
over --with-kcm. No time to look after it for the moment.
Guenther
Jim McDonough [Fri, 10 Mar 2006 13:33:02 +0000 (13:33 +0000)]
r14147: Fix coverity #119. alloc'ed memory returned not saved, so not freed.
Need to go back and correct the assumption that an "ldap xxx suffix"
parm must have an OU.
Günther Deschner [Fri, 10 Mar 2006 13:14:01 +0000 (13:14 +0000)]
r14146: Just some typos.
Guenther
Günther Deschner [Fri, 10 Mar 2006 13:12:38 +0000 (13:12 +0000)]
r14145: Add missing WITH_KCM hunks from my local tree.
Guenther
Günther Deschner [Fri, 10 Mar 2006 13:01:08 +0000 (13:01 +0000)]
r14144: allow to set sec_info in rpcclients lsa_query_secobj.
Guenther
Jim McDonough [Fri, 10 Mar 2006 09:41:08 +0000 (09:41 +0000)]
r14135: Fix for Coverity #123: resource leak. Also rework much of the code to
make it cleaner. There's still more to do on this...
Volker Lendecke [Fri, 10 Mar 2006 09:07:03 +0000 (09:07 +0000)]
r14134: Fix Coverity bug # 137
Volker Lendecke [Fri, 10 Mar 2006 08:56:13 +0000 (08:56 +0000)]
r14133: Fix Coverity bug # 140
Volker Lendecke [Fri, 10 Mar 2006 08:53:15 +0000 (08:53 +0000)]
r14132: Fix Coverity bug # 150.
Jerry, you might want to check this.
Thanks
Volker
Volker Lendecke [Fri, 10 Mar 2006 08:47:59 +0000 (08:47 +0000)]
r14131: Fix Coverity bug # 127
Günther Deschner [Fri, 10 Mar 2006 08:43:32 +0000 (08:43 +0000)]
r14130: Remove make_server_info_pac alltogether, make_server_info_info3 does
already do what we need.
Guenther
Günther Deschner [Fri, 10 Mar 2006 08:26:40 +0000 (08:26 +0000)]
r14129: Add the group sids from the Kerberos PAC to the user token.
Guenther
Steve French [Fri, 10 Mar 2006 04:18:29 +0000 (04:18 +0000)]
r14128: Remove warning generated by coverity scan tool (missing SAFE_FREE in error path)
Steve French [Fri, 10 Mar 2006 04:05:49 +0000 (04:05 +0000)]
r14127: Remove coverity warning on mount.cifs.c
Steve French [Fri, 10 Mar 2006 03:47:57 +0000 (03:47 +0000)]
r14126: resolve two warnings from the coverity scan
Jeremy Allison [Thu, 9 Mar 2006 23:20:52 +0000 (23:20 +0000)]
r14121: We never pass NULL to the rpc_api_pipe fn so don't
trigger coverity checks by testing for NULL.
Jeremy.
Jeremy Allison [Thu, 9 Mar 2006 22:49:38 +0000 (22:49 +0000)]
r14118: Fix coverity bug #24. Missing return statement meant
a possible NULL ptr deref.
Jeremy.
Jeremy Allison [Thu, 9 Mar 2006 22:46:42 +0000 (22:46 +0000)]
r14115: Fix coverity bug #23. Don't deref a potentially null ptr.
Jeremy.
Gerald Carter [Thu, 9 Mar 2006 22:31:37 +0000 (22:31 +0000)]
r14112: * fix checks on return code from register_vuid() which could actually
fail and we would still return success in the SMBsesssetup reply :-(
* Make sure to create the local token for the server_fino struct
in reply_spnego_kerberos() so that register_vuid() does not fail.
(how did this ever work?)
James Peach [Thu, 9 Mar 2006 22:31:05 +0000 (22:31 +0000)]
r14111: Work around additional typedefs in the gamin implementation
of the FAM API.
Jeremy Allison [Thu, 9 Mar 2006 22:00:12 +0000 (22:00 +0000)]
r14106: Fix from William Jojo for AIX vfs builds. Thanks Bill !
Jeremy.
Volker Lendecke [Thu, 9 Mar 2006 21:15:10 +0000 (21:15 +0000)]
r14103: Fix a memleak found by valgrind (!!)
Volker Lendecke [Thu, 9 Mar 2006 21:13:54 +0000 (21:13 +0000)]
r14102: Fix Coverity bug # 70
Volker Lendecke [Thu, 9 Mar 2006 21:07:15 +0000 (21:07 +0000)]
r14101: Fix a segfault in trustdom establish, cli is NULL here.
Volker Lendecke [Thu, 9 Mar 2006 20:51:22 +0000 (20:51 +0000)]
r14099: Fix Coverity # 113
Volker Lendecke [Thu, 9 Mar 2006 20:42:01 +0000 (20:42 +0000)]
r14098: Fix Coverity # 112
Jeremy Allison [Thu, 9 Mar 2006 19:51:38 +0000 (19:51 +0000)]
r14092: Fix coverity bug #22. Ensure no possible null
deref.
Jeremy.
Jeremy Allison [Thu, 9 Mar 2006 19:13:55 +0000 (19:13 +0000)]
r14090: Fix coverity bug #21, don't deref potential null.
Jeremy.
Jeremy Allison [Thu, 9 Mar 2006 19:03:31 +0000 (19:03 +0000)]
r14088: Fix Coverity bug #20. Don't deref possible null.
Jeremy.
Jeremy Allison [Thu, 9 Mar 2006 18:35:57 +0000 (18:35 +0000)]
r14087: Protect against domain being NULL. Finish Coverity #152.
Jeremy.
Jim McDonough [Thu, 9 Mar 2006 18:03:54 +0000 (18:03 +0000)]
r14085: Fix coverity bg #152, uninit'ed var.
Jeremy Allison [Thu, 9 Mar 2006 18:01:42 +0000 (18:01 +0000)]
r14083: Fix coverity bug #19. Don't deref possible NULL.
Jeremy.
Jeremy Allison [Thu, 9 Mar 2006 17:56:16 +0000 (17:56 +0000)]
r14080: Fix Coverity bug #18. Ensure non-null before ref.
Jeremy.
Gerald Carter [Thu, 9 Mar 2006 16:28:38 +0000 (16:28 +0000)]
r14077: fix build breakage
Günther Deschner [Thu, 9 Mar 2006 16:08:15 +0000 (16:08 +0000)]
r14076: When the backends trusted_domains call comes back with no trusts the
NTSTATUS code will be NT_STATUS_NO_MORE_ENTRIES. In that case store
NT_STATUS_OK in the centry so that the entry does not automatically
deleted upon startup or invalidated upon next query.
Guenther
Gerald Carter [Thu, 9 Mar 2006 15:51:55 +0000 (15:51 +0000)]
r14075: * add support for long variable names in smb.conf in the form of %(....)
* add support for %(DomainSID)
* replace standard_sub_XXX() functions with wrappers around their
alloc_sub_XXX() counterparts
* add support for using SIDs in read list, et. al. (anything that
is checked by nt_token_contains_name_in_list())
Günther Deschner [Thu, 9 Mar 2006 14:51:40 +0000 (14:51 +0000)]
r14074: Some cleanup; there is no point in declaring and mapping
KRB5KRB_ERR_RESPONSE_TOO_BIG when the krb5 library does not know about
this.
Guenther
Günther Deschner [Thu, 9 Mar 2006 11:01:43 +0000 (11:01 +0000)]
r14062: Forgot those in the uint16/32 acb_info switch.
Guenther
Günther Deschner [Thu, 9 Mar 2006 10:57:39 +0000 (10:57 +0000)]
r14061: Some debugging for the new LOGON/ACB-flags.
Guenther
Günther Deschner [Thu, 9 Mar 2006 09:08:11 +0000 (09:08 +0000)]
r14060: Only set the last rebind timestamp when we did rebind after a non-read
LDAP operation. That way we avoid the replication sleep after a simple
redirected search operation
Guenther
Lars Müller [Wed, 8 Mar 2006 21:46:16 +0000 (21:46 +0000)]
r14057: Remove generated script/gen-8bit-gap.sh while calling rule realclean.
Ignore script/gen-8bit-gap.sh in branches/SAMBA_3_0/source/script as we
already do in trunk.
Lars Müller [Wed, 8 Mar 2006 21:42:12 +0000 (21:42 +0000)]
r14056: Also install the mount.smbfs sym link to rootsbindir. Therfore we have
to substitute rootsbindir in {,un}installbin.sh.in.
Pass $prefix as third arg to installbin/ uninstallbin as rootsbindir by
default is $prefix/sbin.
Jim McDonough [Wed, 8 Mar 2006 21:29:49 +0000 (21:29 +0000)]
r14053: Implement Simo's suggestion: don't use /dev/null for a 'bad' path for
users/workstations
Lars Müller [Wed, 8 Mar 2006 21:20:43 +0000 (21:20 +0000)]
r14052: Remove BASEDIR use in the Makefile. BASEDIR=prefix=@prefix@ till now.
I suggest to stay with ^BASEDIR= @prefix@$ for at least the next release
to give external projects - like samba-vscan project - time to adopt
this change.
BASEDIR is non of the default autoconf variables. prefix is.
Jerry1: If possible please announce this with the next release. I'll
self reply to technical.
Jerry2: This does not break your makepkg stuff as you set BASEDIR
_not_ from the Makefile.
Günther Deschner [Wed, 8 Mar 2006 21:10:20 +0000 (21:10 +0000)]
r14051: Add remaining (documented) userAccountControl bits, thanks to Luke
Howard for pointing this out.
Guenther
Günther Deschner [Wed, 8 Mar 2006 21:05:32 +0000 (21:05 +0000)]
r14050: Add the ACB_PWEXPIRED bit abartlet has found.
Guenther
Günther Deschner [Wed, 8 Mar 2006 20:57:41 +0000 (20:57 +0000)]
r14049: Found some more MSV1_0 bits and their behaviour;
just for documentation purpose.
Guenther
Jeremy Allison [Wed, 8 Mar 2006 20:07:24 +0000 (20:07 +0000)]
r14047: Coverity fix #17. Ensure srv_name and info cannot
be zero before deref.
Jeremy.
Jeremy Allison [Wed, 8 Mar 2006 20:02:50 +0000 (20:02 +0000)]
r14045: Coverity fix #14. Ensure if len is set buf != NULL.
Jeremy.
Jeremy Allison [Wed, 8 Mar 2006 17:50:44 +0000 (17:50 +0000)]
r14043: After discussion with Jerry revert part of the
Coverity null-ref patch - put prs_rpcbuffer_p
back to the way it was (with an additional
coverity paranoia check) - move the real test
into rpcbuf_alloc_size instead.
Jeremy.
Gerald Carter [Wed, 8 Mar 2006 15:18:14 +0000 (15:18 +0000)]
r14042: check that create_local_nt_token() succeeds before dereferncing the NT_USER_TOKEN*
Volker Lendecke [Wed, 8 Mar 2006 08:51:19 +0000 (08:51 +0000)]
r14036: Ok, the last one generated a const warning. Also fix Coverity # 119.
net rpc vampire is ugly....
Volker
Volker Lendecke [Wed, 8 Mar 2006 08:41:36 +0000 (08:41 +0000)]
r14035: Fix Coverity bug # 124
Volker Lendecke [Wed, 8 Mar 2006 08:28:42 +0000 (08:28 +0000)]
r14034: Fix Coverity id # 125.
Jeremy, you might want to take a look here.
Volker
Volker Lendecke [Wed, 8 Mar 2006 08:22:42 +0000 (08:22 +0000)]
r14033: Fix Coverity bug # 126
Jeremy Allison [Wed, 8 Mar 2006 07:30:37 +0000 (07:30 +0000)]
r14031: Coverity bug CID #110. Free all resources correctly
on pipe initialization failure.
Jeremy.
Jeremy Allison [Wed, 8 Mar 2006 07:20:11 +0000 (07:20 +0000)]
r14030: Fix resource leak in error codepath. Coverity CID #64.
Jeremy.
Jeremy Allison [Wed, 8 Mar 2006 07:13:23 +0000 (07:13 +0000)]
r14026: Fix resource leak on error exit. Coverity CID #65.
Jeremy.
Volker Lendecke [Wed, 8 Mar 2006 06:51:38 +0000 (06:51 +0000)]
r14025: Remove unused code. When we want to export samsync, we better first port
pidl...
Fix Coverity # 15.
Volker
Jeremy Allison [Wed, 8 Mar 2006 06:42:39 +0000 (06:42 +0000)]
r14023: My last bug fix still left a potential null deref.
C- "must try harder" :-).
Jeremy.
Volker Lendecke [Wed, 8 Mar 2006 06:39:33 +0000 (06:39 +0000)]
r14022: Fix Coverity bug # 92
Jeremy Allison [Wed, 8 Mar 2006 06:36:40 +0000 (06:36 +0000)]
r14020: Coverity bug CID #66. Missing free on error exit.
Jeremy.
Jeremy Allison [Wed, 8 Mar 2006 06:32:26 +0000 (06:32 +0000)]
r14018: Coverity error CID #27. Missing return -1 on error condition.
Jeremy.
Volker Lendecke [Wed, 8 Mar 2006 06:32:21 +0000 (06:32 +0000)]
r14017: Okay, okay, I have turned a double-free into dead code :-)
Fix Coverity # 214.
Volker
Jeremy Allison [Wed, 8 Mar 2006 06:16:54 +0000 (06:16 +0000)]
r14014: Coverity paranoia. Shut it up by making the guarentee
in the code explicit - but this was a false positive (CID #16).
Jeremy.
Jeremy Allison [Wed, 8 Mar 2006 02:05:36 +0000 (02:05 +0000)]
r14009: Remove last const warning (have to use CONST_DISCARD).
Jeremy.
Jeremy Allison [Wed, 8 Mar 2006 01:43:23 +0000 (01:43 +0000)]
r14007: Coverity bug CID #197. Don't compare against 0, we
mean the ttl instead.
Jeremy.
Jeremy Allison [Wed, 8 Mar 2006 01:40:15 +0000 (01:40 +0000)]
r14006: Fix a couple of irritating warnings.
Jeremy.
Jeremy Allison [Wed, 8 Mar 2006 01:18:18 +0000 (01:18 +0000)]
r14003: Clarify code that lead to Coverity report #13.
Not a bug, but better to remove false positives.
Jeremy.
Jeremy Allison [Wed, 8 Mar 2006 01:04:17 +0000 (01:04 +0000)]
r14002: Quick fix for Coverity CID #12.
Jeremy
Jeremy Allison [Wed, 8 Mar 2006 01:01:34 +0000 (01:01 +0000)]
r13999: Quick fix for Coverity bug #11.
Jeremy.
Lars Müller [Tue, 7 Mar 2006 23:04:08 +0000 (23:04 +0000)]
r13997: Prefix $prefix by default even to rootsbindir as we else run in trouble
if we use ./configure --prefix=dir && make install
Vendors might use ./configure --with-rootsbindir=/sbin && make
DESTDIR=/var/tmp/samba/ install if they use a buildroot.
Thanks to Björn Jacke for pointing me at the stderr output of the build
farm.
Jeremy Allison [Tue, 7 Mar 2006 21:13:19 +0000 (21:13 +0000)]
r13994: Belt and braces - ensure RPC_BUFFER is valid.
Jeremy.
Volker Lendecke [Tue, 7 Mar 2006 21:03:48 +0000 (21:03 +0000)]
r13991: Fix Coverity bug # 69
Jeremy Allison [Tue, 7 Mar 2006 20:52:43 +0000 (20:52 +0000)]
r13989: Fix for Coverity bug #45 and associated spoolss RPC_BUFFER
problems. Ensure that if the parse succeeds on UNMARSHALL
we have a valid (although possibly empty) RPC_BUFFER returned.
Jeremy.
Volker Lendecke [Tue, 7 Mar 2006 20:44:12 +0000 (20:44 +0000)]
r13987: Fix Coverity bug # 74. This tool is good...
Thanks,
Volker
Volker Lendecke [Tue, 7 Mar 2006 20:32:08 +0000 (20:32 +0000)]
r13984: Fix Coverity bug # 98
Volker Lendecke [Tue, 7 Mar 2006 20:24:28 +0000 (20:24 +0000)]
r13983: Fix Coverity bug # 111
Volker Lendecke [Tue, 7 Mar 2006 20:14:47 +0000 (20:14 +0000)]
r13981: Fix Coverity bug # 138
Volker Lendecke [Tue, 7 Mar 2006 19:52:26 +0000 (19:52 +0000)]
r13980: Fix Coverity bug # 63. Jeremy, could you take a look at this?
Thanks,
Volker
Volker Lendecke [Tue, 7 Mar 2006 19:24:28 +0000 (19:24 +0000)]
r13979: We've dereferenced my_methods already, so there's no point in checking for
!= NULL. Coverity #149.
Volker
Jeremy Allison [Tue, 7 Mar 2006 19:18:56 +0000 (19:18 +0000)]
r13978: Here is why it's essential to use SAFE_FREE instead of free.
If we use free(data.dptr) and then the subsequent tdb_open
fails in _reg_perfcount_get_counter_data() then data.dptr
is left as a non-zero pointer that has been freed. This would
cause it to be reused later on. Coverity bug #162.
Jeremy.
Jeremy Allison [Tue, 7 Mar 2006 18:52:48 +0000 (18:52 +0000)]
r13975: Re-fix Coverity #156 - I had left the hidden arg. inconsistent
between Realloc and realloc_array.
Jeremy.
Jeremy Allison [Tue, 7 Mar 2006 18:00:21 +0000 (18:00 +0000)]
r13971: Fix Coverity bugs #209 - #213 - it detected mistakes
in the pointer aliasing once realloc could change
a pointer. This was in the bugzilla.samba.org database
as #687 but we never figured out what it was !
Jeremy.
Jim McDonough [Tue, 7 Mar 2006 17:49:26 +0000 (17:49 +0000)]
r13968: fix typo, caught by Guenther
Günther Deschner [Tue, 7 Mar 2006 16:56:31 +0000 (16:56 +0000)]
r13965: Make sure we always reset the userAccountControl bits when re-joining
with an existing account.
Guenther
Volker Lendecke [Tue, 7 Mar 2006 16:33:36 +0000 (16:33 +0000)]
r13958: Fix Coverity Bug # 141
Jim McDonough [Tue, 7 Mar 2006 16:29:25 +0000 (16:29 +0000)]
r13957: Based on patch from Richard Renard <richard.renard@idealx.com>:
Fix machine accounts (should not have valid shells) and users with no
home directory (were getting previous user's directory).
git.samba.org / kai / samba-autobuild / .git / log