kai/samba-autobuild/.git
7 years agontdb: allocator attribute.
Rusty Russell [Tue, 19 Jun 2012 03:12:08 +0000 (12:42 +0930)]
ntdb: allocator attribute.

This is designed to allow us to make ntdb_context (and NTDB_DATA returned
from ntdb_fetch) a talloc pointer.  But it can also be used for any other
alternate allocator.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agontdb: still prepare recovery area with NTDB_NOSYNC.
Rusty Russell [Tue, 19 Jun 2012 03:09:33 +0000 (12:39 +0930)]
ntdb: still prepare recovery area with NTDB_NOSYNC.

NTDB_NOSYNC now just prevents the fsync/msync calls, which speeds
testing while still providing full coverage.  It also provides safety
against processes dying during transaction commit (though obviously,
not against the machine dying).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agontdb: simply disallow NULL names.
Rusty Russell [Tue, 19 Jun 2012 03:08:33 +0000 (12:38 +0930)]
ntdb: simply disallow NULL names.

TDB allows this for internal databases, but it's a bad idea, since the
name is useful for logging.

They're a hassle to deal with, and we'd just end up putting "unnamed"
in there, so let the user deal with it.  If they don't, they get an
informative core dump.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agontdb: reduce transaction pagesize from 64k to 16k.
Rusty Russell [Mon, 18 Jun 2012 13:00:30 +0000 (22:30 +0930)]
ntdb: reduce transaction pagesize from 64k to 16k.

The performance numbers for transaction pagesize are indeterminate:
larger pagesizes means a smaller transaction array, and a better
chance of having a contiguous record (more efficient for
ntdb_parse_record and some internal operations inside a transaction).

On the other hand, large pagesize means more I/O even if we change a
few bytes.

But it also controls the multiple by which we will enlarge the file,
and hence the minimum db size.  It's 4k for tdb1, but 16k seems
reasonable in these modern times.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agontdb: remove last block transactoin logic.
Rusty Russell [Mon, 18 Jun 2012 13:00:30 +0000 (22:30 +0930)]
ntdb: remove last block transactoin logic.

Now our database is always a multiple of NTDB_PGSIZE, we can remove the
special handling for the last block.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agontdb: create initial database to be multiple of NTDB_PGSIZE.
Rusty Russell [Mon, 18 Jun 2012 13:00:29 +0000 (22:30 +0930)]
ntdb: create initial database to be multiple of NTDB_PGSIZE.

As copied from tdb1, there is logic in the transaction code to handle
a non-PGSIZE multiple db, but in fact this only happens for a
completely unused database: as soon as we add anything to it, it is
expanded to a NTDB_PGSIZE multiple.

If we create the database with a free record which pads it out to
NTDB_PGSIZE, we can remove this last-page-is-different logic.

Of course, the fake ntdbs we create in our tests now also need to be
multiples of NTDB_PGSIZE, so we change some numbers there too.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agontdb: make sure file is always a multiple of PAGESIZE (now NTDB_PGSIZE)
Rusty Russell [Mon, 18 Jun 2012 13:00:29 +0000 (22:30 +0930)]
ntdb: make sure file is always a multiple of PAGESIZE (now NTDB_PGSIZE)

ntdb uses tdb's transaction code, and it has an undocumented but implicit
assumption: that the transaction recovery area is always aligned to the
transaction pagesize.  This means that no block will overlap the recovery
area.

This is maintained by rounding the size of the database up, so do the same
for ntdb.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agontdb: fix recovery data write.
Rusty Russell [Mon, 18 Jun 2012 13:00:29 +0000 (22:30 +0930)]
ntdb: fix recovery data write.

We were missing the last few bytes.  Found by 100 runs of ntdbtorture
-t -k.

The transaction test code didn't catch this, because usually those
last few bytes are irrelevant to the actual contents of the database.
We fix the test.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agontdb: enhance external-helper test code.
Rusty Russell [Mon, 18 Jun 2012 13:00:29 +0000 (22:30 +0930)]
ntdb: enhance external-helper test code.

Our external test helper is a bit primitive when it comes to doing STORE or
FETCH commands: let us specify the data we expect, instead of assuming it's
the same as the key.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agontdb: use NTDB_LOG_WARNING level for failed open() without O_CREAT.
Rusty Russell [Mon, 18 Jun 2012 13:00:28 +0000 (22:30 +0930)]
ntdb: use NTDB_LOG_WARNING level for failed open() without O_CREAT.

This is a fairly common pattern in Samba, and if we log an error on
every open it spams the logs.  On the other hand, other errors are
potentially more serious, so we still use NTDB_LOG_ERROR on them.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agoccan: remove bogus debug print.
Rusty Russell [Mon, 18 Jun 2012 13:00:28 +0000 (22:30 +0930)]
ccan: remove bogus debug print.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agontdb: make fork test more thorough.
Rusty Russell [Mon, 18 Jun 2012 13:00:28 +0000 (22:30 +0930)]
ntdb: make fork test more thorough.

We document that the child of a fork() can do a brunlock() if the parent
does a brlock: we should not log an error when they do this.

Also, test the case where we fork() and return inside a parse function
(which is allowed).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agontdb: print \n at end of log messages in tests.
Rusty Russell [Mon, 18 Jun 2012 13:00:28 +0000 (22:30 +0930)]
ntdb: print \n at end of log messages in tests.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agontdb: reduce race between creating file and getting open lock.
Rusty Russell [Mon, 18 Jun 2012 13:00:27 +0000 (22:30 +0930)]
ntdb: reduce race between creating file and getting open lock.

In tdb, we grab the open lock immediately after we open the file.  In
ntdb, we usually did some work first.  tdbtorture managed to get in
before the creator grabbed the lock:

testing with 3 processes, 5000 loops, seed=1338246020
ntdb:torture.ntdb:IO Error:ntdb_open: torture.ntdb is not a ntdb file
29023:torture.ntdb:db open failed

At cost of a little duplicated code, we can reduce the race.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agontdb: catch any valgrind errors in test
Rusty Russell [Mon, 18 Jun 2012 13:00:27 +0000 (22:30 +0930)]
ntdb: catch any valgrind errors in test

Make --valgrind and --valgrind-log options work!

Amitay figured this out!

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agontdb: catch any valgrind errors in test
Rusty Russell [Mon, 18 Jun 2012 13:00:27 +0000 (22:30 +0930)]
ntdb: catch any valgrind errors in test

We need --error-exitcode=, otherwise valgrind errors don't cause the
test to fail.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agontdb: remove ntdb_error()
Rusty Russell [Mon, 18 Jun 2012 13:00:27 +0000 (22:30 +0930)]
ntdb: remove ntdb_error()

It was a hack to make compatibility easier.  Since we're not doing that,
it can go away: all callers must use the return value now.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agoTDB2: Goodbye TDB2, Hello NTDB.
Rusty Russell [Mon, 18 Jun 2012 13:00:26 +0000 (22:30 +0930)]
TDB2: Goodbye TDB2, Hello NTDB.

This renames everything from tdb2 to ntdb: importantly, we no longer
use the tdb_ namespace, so you can link against both ntdb and tdb if
you want to.

This also enables building of standalone ntdb by the autobuild script.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agotdb2: Fix typo in TDB1_porting.txt
Kirill Smelkov [Mon, 18 Jun 2012 13:00:26 +0000 (22:30 +0930)]
tdb2: Fix typo in TDB1_porting.txt

Judging by code it's tdb1, where you needed to free old key's dptr
manually.

Signed-off-by: Kirill Smelkov <kirr@mns.spb.ru>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agoTDB2: more internal cleanups after TDB1 compatibility removal.
Rusty Russell [Mon, 18 Jun 2012 13:00:26 +0000 (22:30 +0930)]
TDB2: more internal cleanups after TDB1 compatibility removal.

This eliminates the separate tdb2 substructure, and makes some
tdb1-required functions static.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agoTDB2: remove TDB1 compatibility.
Rusty Russell [Mon, 18 Jun 2012 13:00:25 +0000 (22:30 +0930)]
TDB2: remove TDB1 compatibility.

This rips out all the TDB1 compatibility from tdb2.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agoTDB2: make SAMBA use tdb1 again for the moment.
Rusty Russell [Mon, 18 Jun 2012 13:00:04 +0000 (22:30 +0930)]
TDB2: make SAMBA use tdb1 again for the moment.

Otherwise the following surgery will break the SAMBA build and testsuite.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agoccan: check for err.h ourselves
Rusty Russell [Mon, 18 Jun 2012 10:36:45 +0000 (20:06 +0930)]
ccan: check for err.h ourselves

Heimdal does this, but that doesn't help the autoconf build or the standalone
libntdb build.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agoWHATSNEW: Fix typo.
Jelmer Vernooij [Mon, 18 Jun 2012 23:01:17 +0000 (01:01 +0200)]
WHATSNEW: Fix typo.

"dcerpc endpoint services" -> "dcerpc endpoint servers"

Autobuild-User(master): Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date(master): Tue Jun 19 04:40:12 CEST 2012 on sn-devel-104

7 years agotdb/wscript: Remove unecessary semicolons.
Jelmer Vernooij [Mon, 28 May 2012 12:16:44 +0000 (14:16 +0200)]
tdb/wscript: Remove unecessary semicolons.

7 years agowafsamba/irixcc: add '-c99' option to cc
Stefan Metzmacher [Mon, 18 Jun 2012 22:46:51 +0000 (00:46 +0200)]
wafsamba/irixcc: add '-c99' option to cc

Lets see if this fixes the build on IRIX.

metze

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Jun 19 02:42:21 CEST 2012 on sn-devel-104

7 years agoRevert "s3: temporary hack to make the waf build work withouth autotools being required"
Björn Jacke [Mon, 18 Jun 2012 12:13:26 +0000 (14:13 +0200)]
Revert "s3: temporary hack to make the waf build work withouth autotools being required"

This reverts commit f1becfa27b6b4e35541e6df0cafdec0ad47d2e3f. The hack was
actually only required due to a configuration issue in our buildfarm scripts.

Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Mon Jun 18 20:07:08 CEST 2012 on sn-devel-104

7 years agoselftest/flapping: samba4.nss.test is also flakey for s3member
Stefan Metzmacher [Mon, 18 Jun 2012 13:25:25 +0000 (15:25 +0200)]
selftest/flapping: samba4.nss.test is also flakey for s3member

[1426/1518 in 1h24m58s] samba4.nss.test using winbind(s3member)
UNEXPECTED(failure): samba4.nss.test using winbind(s3member).run nsstest(s3member)
REASON: _StringException: _StringException: ERROR setpwent: NSS_STATUS=-1  1 (nss_errno=0)
ERROR getpwent: NSS_STATUS=-1  1 (nss_errno=0)
ERROR endpwent: NSS_STATUS=-1  1 (nss_errno=0)
ERROR setgrent: NSS_STATUS=-1  1 (nss_errno=0)
ERROR getgrent: NSS_STATUS=-1  1 (nss_errno=0)
ERROR endgrent: NSS_STATUS=-1  1 (nss_errno=0)
ERROR Non existent user gave error -1
ERROR Non existent uid gave error -1
ERROR Non existent group gave error -1
ERROR Non existent gid gave error -1
total_errors=10

metze

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Mon Jun 18 17:59:25 CEST 2012 on sn-devel-104

7 years agos3:autoconf: add -Iautoconf -Iautoconf/source3 at configure stage
Stefan Metzmacher [Mon, 18 Jun 2012 07:14:55 +0000 (09:14 +0200)]
s3:autoconf: add -Iautoconf -Iautoconf/source3 at configure stage

There're some configure tests which require this.

metze

7 years agos3:Makefile.in: remove pidl generated files with 'make realdistclean'
Stefan Metzmacher [Mon, 18 Jun 2012 07:33:48 +0000 (09:33 +0200)]
s3:Makefile.in: remove pidl generated files with 'make realdistclean'

metze

7 years agos3:Makefile.in: fix 'make realdistclean' after moving generated files to autoconf/
Stefan Metzmacher [Mon, 18 Jun 2012 07:32:17 +0000 (09:32 +0200)]
s3:Makefile.in: fix 'make realdistclean' after moving generated files to autoconf/

metze

7 years agos3:Makefile.in: fix 'make clean' after moving generated files to autoconf/
Stefan Metzmacher [Mon, 18 Jun 2012 07:32:17 +0000 (09:32 +0200)]
s3:Makefile.in: fix 'make clean' after moving generated files to autoconf/

metze

7 years agos3:autogen.sh: fix autoconf/lib/param/param_proto.h location
Stefan Metzmacher [Mon, 18 Jun 2012 08:31:09 +0000 (10:31 +0200)]
s3:autogen.sh: fix autoconf/lib/param/param_proto.h location

metze

7 years agolib/param: add missing prototype of lpcfg_parm_long()
Stefan Metzmacher [Mon, 18 Jun 2012 08:02:47 +0000 (10:02 +0200)]
lib/param: add missing prototype of lpcfg_parm_long()

metze

7 years agos3:autoconf-build: build the idmap backends tdb2, rid, and hash by default (shared)
Michael Adam [Mon, 18 Jun 2012 09:04:43 +0000 (11:04 +0200)]
s3:autoconf-build: build the idmap backends tdb2, rid, and hash by default (shared)

Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Mon Jun 18 13:38:50 CEST 2012 on sn-devel-104

7 years agos3:waf-build: build the idmap backends tdb2, rid, and hash by default (shared)
Michael Adam [Mon, 18 Jun 2012 08:53:53 +0000 (10:53 +0200)]
s3:waf-build: build the idmap backends tdb2, rid, and hash by default (shared)

7 years agos3:idmap_tdb: fix miss in rename of dbwrap_trans_store_uint32() to dbwrap_trans_store...
Michael Adam [Mon, 18 Jun 2012 08:27:54 +0000 (10:27 +0200)]
s3:idmap_tdb: fix miss in rename of dbwrap_trans_store_uint32() to dbwrap_trans_store_uint32_bystring()

7 years agodbwrap: Rename dbwrap_fetch_uint32->dbwrap_fetch_uint32_bystring
Amitay Isaacs [Mon, 18 Jun 2012 07:07:57 +0000 (17:07 +1000)]
dbwrap: Rename dbwrap_fetch_uint32->dbwrap_fetch_uint32_bystring

Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos3:configure: check for SPLICE_F_MOVE at configure stage
Stefan Metzmacher [Mon, 18 Jun 2012 06:49:18 +0000 (08:49 +0200)]
s3:configure: check for SPLICE_F_MOVE at configure stage

This should fix the waf build on AIX, which has a splice symbol.

metze

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Mon Jun 18 11:43:01 CEST 2012 on sn-devel-104

7 years agoheimdal:lib/wind: include <stdlib.h> at the end
Stefan Metzmacher [Sun, 17 Jun 2012 12:18:49 +0000 (14:18 +0200)]
heimdal:lib/wind: include <stdlib.h> at the end

This makes sure config.h gets includes first.

This should fix the build on AIX.

metze

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Sun Jun 17 16:16:24 CEST 2012 on sn-devel-104

7 years agoheimdal:lib/wind: make sure errorlist_table.c includes config.h as first header
Stefan Metzmacher [Sat, 16 Jun 2012 20:03:29 +0000 (22:03 +0200)]
heimdal:lib/wind: make sure errorlist_table.c includes config.h as first header

This should fix the build on AIX.

metze

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Sat Jun 16 23:59:07 CEST 2012 on sn-devel-104

7 years agoattr: Look for attr/attributes.h too.
Jelmer Vernooij [Sat, 16 Jun 2012 13:37:52 +0000 (15:37 +0200)]
attr: Look for attr/attributes.h too.

Fixes finding of ATTR_ROOT on GNU/kFreeBSD.

Autobuild-User(master): Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date(master): Sat Jun 16 18:54:27 CEST 2012 on sn-devel-104

7 years agoheimdal:lib/krb5: don't name a struct 'token'
Stefan Metzmacher [Sat, 16 Jun 2012 11:25:18 +0000 (13:25 +0200)]
heimdal:lib/krb5: don't name a struct 'token'

This is a static const struct and the name is never used,
so just make it an anonymous struct.

This hopefully fixes the build on AIX:

"../source4/heimdal/lib/roken/roken-common.h", line 276.9: 1506-236 (W) Macro name __attribute__ has been redefined.
"../source4/heimdal/lib/roken/roken-common.h", line 276.9: 1506-358 (I) "__attribute__" is defined on line 45 of ../source4/heimdal/lib/com_err/com_err.h.
"../source4/heimdal/lib/krb5/expand_path.c", line 331.21: 1506-334 (S) Identifier token has already been defined on line 98 of "/usr/include/net/if_arp.h".
"../source4/heimdal/lib/krb5/expand_path.c", line 390.43: 1506-019 (S) Expecting an array or a pointer to object type.
"../source4/heimdal/lib/krb5/expand_path.c", line 391.31: 1506-019 (S) Expecting an array or a pointer to object type.
"../source4/heimdal/lib/krb5/expand_path.c", line 392.20: 1506-019 (S) Expecting an array or a pointer to object type.
"../source4/heimdal/lib/krb5/expand_path.c", line 392.48: 1506-019 (S) Expecting an array or a pointer to object type.
"../source4/heimdal/lib/krb5/expand_path.c", line 393.39: 1506-019 (S) Expecting an array or a pointer to object type.
Waf: Leaving directory `/opt/home/build/build_farm/samba_4_0_test/bin'
Build failed:  -> task failed (err #1):
{task: cc expand_path.c -> expand_path_52.o}
gmake: *** [all] Error 1

metze

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Sat Jun 16 15:20:59 CEST 2012 on sn-devel-104

7 years agos3-auth: Remove auth_netlogond
Andrew Bartlett [Sun, 3 Jun 2012 00:56:46 +0000 (10:56 +1000)]
s3-auth: Remove auth_netlogond

auth_netlogond was an important module in the development of the
combined Samba 4.0, and was the first module to link smbd with the AD
authentication store, showing that it was possible for NTLM
authentication to be offloaded to the AD server components.

We now have auth_samba4, which provides the full GENSEC stack to smbd,
which also matches exactly the group membership and privileges
assignment and which is supported and tested as part of the official
Samba 4.0 release configuration.

Andrew Bartlett

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sat Jun 16 10:13:20 CEST 2012 on sn-devel-104

7 years agos3-passdb: Remove pdb_ads
Andrew Bartlett [Sun, 3 Jun 2012 00:54:06 +0000 (10:54 +1000)]
s3-passdb: Remove pdb_ads

pdb_ads was an important module in the development of the combined Samba 4.0, and
was the first module to show that standard samba3 tools such as smbpasswd can be
made to operate on the sam.ldb.

We now have pdb_samba4, which operates directly on the sam.ldb, rather than via
ldapi://, which uses transactions and which is supported and tested as part
of the official Samba 4.0 release configuration.

This module is not as complete (for example, it does not honour the idmap
configuration) and requires that the samba binary be running to operate.

Andrew Bartlett

7 years agos4-classicupgrade: Also ask testparm for 'smb passwd file'
Andrew Bartlett [Sat, 16 Jun 2012 05:34:50 +0000 (15:34 +1000)]
s4-classicupgrade: Also ask testparm for 'smb passwd file'

7 years agoWHATSNEW: Bump the version and announce the s3fs default
Andrew Bartlett [Sat, 16 Jun 2012 03:12:50 +0000 (13:12 +1000)]
WHATSNEW: Bump the version and announce the s3fs default

7 years agos4-classicupgrade: Use "samba classic" description for samba3 NT4-like domains in...
Andrew Bartlett [Sat, 16 Jun 2012 03:06:44 +0000 (13:06 +1000)]
s4-classicupgrade: Use "samba classic" description for samba3 NT4-like domains in samba3upgrade

7 years agos4-lib/param: FLAG DAY for the default FILE SERVER
Andrew Bartlett [Sat, 16 Jun 2012 02:54:12 +0000 (12:54 +1000)]
s4-lib/param: FLAG DAY for the default FILE SERVER

This commit changes the default file server to be s3fs.  Existing
installs wishing to keep the ntvfs file server need to set this in
their smb.conf:

server services = +smb -s3fs
dcerpc endpoint services = +winreg +srvsvc

Andrew Bartlett

7 years agos4-s3upgrade: Assert that administrator has a SID of -500, and only skip root if...
Andrew Bartlett [Sat, 16 Jun 2012 04:19:42 +0000 (14:19 +1000)]
s4-s3upgrade: Assert that administrator has a SID of -500, and only skip root if it is -500

Many upgraded installations have root as -1000, and so that account needs to be kept.

Andrew Bartlett

7 years agos4-s3upgrade: Add my wins.dat and fix the parsing error
Andrew Bartlett [Sat, 16 Jun 2012 03:58:06 +0000 (13:58 +1000)]
s4-s3upgrade: Add my wins.dat and fix the parsing error

The issue was that the numbers at the end of the lines are space
padded.

Andrew Bartlett

7 years agos4-s3upgrade: improve idmap import to use posixAccount and posixGroup entries
Andrew Bartlett [Sun, 10 Jun 2012 10:42:25 +0000 (20:42 +1000)]
s4-s3upgrade: improve idmap import to use posixAccount and posixGroup entries

7 years agos4-idmap: Add mapping using uidNumber and gidNumber like idmap_ad
Andrew Bartlett [Sun, 10 Jun 2012 05:52:14 +0000 (15:52 +1000)]
s4-idmap: Add mapping using uidNumber and gidNumber like idmap_ad

This is a solution for users who are upgrading from Samba 3.x in
particuar, or have clients that will be using idmap_ad.  This avoids
needing to have duplicate values in idmap.ldb and in the directory.

No check for conflicts is made with the idmap.ldb - the AD store always wins.

Andrew Bartlett

7 years agoSame fix as bug 8989 - Samba 3.5.x (and probably all other versions of Samba) does...
Jeremy Allison [Sat, 16 Jun 2012 04:10:59 +0000 (21:10 -0700)]
Same fix as bug 8989 - Samba 3.5.x (and probably all other versions of Samba) does not send correct responses to NT Transact Secondary when no data and no params

for the Trans2 calls. See MS-CIFS 2.2.4.47.2 for details.

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Jun 16 07:59:19 CEST 2012 on sn-devel-104

7 years agoFix Bug 8989 - Samba 3.5.x (and probably all other versions of Samba) does not send...
Jeremy Allison [Sat, 16 Jun 2012 04:10:37 +0000 (21:10 -0700)]
Fix Bug 8989 - Samba 3.5.x (and probably all other versions of Samba) does not send correct responses to NT Transact Secondary when no data and no params

Found by Richard Sharpe <realrichardsharpe@gmail.com>. The correct
command code in a reply to NT Transact Secondary (0xa1) is
NT Transact (0xa0).

7 years agos3: Slightly simplify grant_fsp_oplock_type
Volker Lendecke [Wed, 30 May 2012 09:28:19 +0000 (11:28 +0200)]
s3: Slightly simplify grant_fsp_oplock_type

The "else" is not necessary, we did a return in the if-branch

Signed-off-by: Jeremy Allison <jra@samba.org>
7 years agos4-selftest: Add tests for dbcheck on an old database that needs repair
Andrew Bartlett [Sat, 16 Jun 2012 01:56:53 +0000 (11:56 +1000)]
s4-selftest: Add tests for dbcheck on an old database that needs repair

We changed a lot since alpha13, so there are lots of legitimate errors to fix.

Andrew Bartlett

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sat Jun 16 05:44:15 CEST 2012 on sn-devel-104

7 years agos4-dbcheck: Always specify the dhcheck control
Andrew Bartlett [Sat, 16 Jun 2012 01:51:22 +0000 (11:51 +1000)]
s4-dbcheck: Always specify the dhcheck control

This will then allow us to make schema modifications, overriding the default ban.

Andrew Bartlett

7 years agoselftest: Add targetdir and tdbrestore parameters to undump.sh
Andrew Bartlett [Sat, 16 Jun 2012 01:06:59 +0000 (11:06 +1000)]
selftest: Add targetdir and tdbrestore parameters to undump.sh

7 years agobuild: Remove support for non-64bit sendfile()
Andrew Bartlett [Tue, 5 Jun 2012 04:43:24 +0000 (14:43 +1000)]
build: Remove support for non-64bit sendfile()

Some early Linux 2.6 platforms can not handle sendfile and _FILE_OFFSET_BITS == 64

This disables sendfile() on these platforms.

Andrew Bartlett

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sat Jun 16 02:21:28 CEST 2012 on sn-devel-104

7 years agoselftest/flapping: mark samba4.nss.test using winbind(s3dc) as flakey
Stefan Metzmacher [Fri, 15 Jun 2012 16:30:43 +0000 (18:30 +0200)]
selftest/flapping: mark samba4.nss.test using winbind(s3dc) as flakey

I saw this at least 10 times in the last weeks.

[1425/1517 in 1h12m22s] samba4.nss.test using winbind(s3dc)
UNEXPECTED(failure): samba4.nss.test using winbind(s3dc).run nsstest(s3dc)
REASON: _StringException: _StringException: ERROR setpwent: NSS_STATUS=-1  1 (nss_errno=0)
ERROR getpwent: NSS_STATUS=-1  1 (nss_errno=0)
ERROR endpwent: NSS_STATUS=-1  1 (nss_errno=0)
ERROR setgrent: NSS_STATUS=-1  1 (nss_errno=0)
ERROR getgrent: NSS_STATUS=-1  1 (nss_errno=0)
ERROR endgrent: NSS_STATUS=-1  1 (nss_errno=0)
ERROR Non existent user gave error -1
ERROR Non existent uid gave error -1
ERROR Non existent group gave error -1
ERROR Non existent gid gave error -1
total_errors=10

FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites)

metze

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri Jun 15 20:24:11 CEST 2012 on sn-devel-104

7 years agodocs-xml: vfs_gpfs: add comment "per share option"
Björn Baumbach [Fri, 15 Jun 2012 10:33:32 +0000 (12:33 +0200)]
docs-xml: vfs_gpfs: add comment "per share option"

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agodocs-xml: vfs_gpfs: fix typo
Björn Baumbach [Fri, 15 Jun 2012 10:33:32 +0000 (12:33 +0200)]
docs-xml: vfs_gpfs: fix typo

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agodocs-xml: add gpfs:acl option to vfs_gpfs man page
Björn Baumbach [Fri, 15 Jun 2012 10:33:32 +0000 (12:33 +0200)]
docs-xml: add gpfs:acl option to vfs_gpfs man page

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3:vfs_gpfs: add "gpfs:acl" option
Björn Baumbach [Thu, 14 Jun 2012 12:15:44 +0000 (14:15 +0200)]
s3:vfs_gpfs: add "gpfs:acl" option

With "gpfs:acl=no" you can pass the acl calls to the next SMB_VFS module.

Based on a patch from Hans-Dieter Schuster <hans-dieter.schuster@ts.fujitsu.com>

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

7 years agodbwrap: Remove an unnecessary ZERO_STRUCT
Volker Lendecke [Tue, 5 Jun 2012 09:28:44 +0000 (11:28 +0200)]
dbwrap: Remove an unnecessary ZERO_STRUCT

We assign the only struct member one line down

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3-winbindd: fix the build of idmap_ad modules.
Günther Deschner [Thu, 14 Jun 2012 10:55:55 +0000 (12:55 +0200)]
s3-winbindd: fix the build of idmap_ad modules.

Guenther

Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Fri Jun 15 18:16:11 CEST 2012 on sn-devel-104

7 years agos3-lib: Fix conversion of lib/events.c to modern tevent names
Andrew Bartlett [Fri, 15 Jun 2012 11:52:35 +0000 (21:52 +1000)]
s3-lib: Fix conversion of lib/events.c to modern tevent names

This corrects an error in 8e31d97c8b62d34aff5d52bfe46dbcc5805dae03.

Andrew Bartlett

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Jun 15 16:25:20 CEST 2012 on sn-devel-104

7 years agodbwrap: dbwrap_trans_store_uint32->dbwrap_trans_store_uint32_bystring
Volker Lendecke [Fri, 15 Jun 2012 07:51:21 +0000 (09:51 +0200)]
dbwrap: dbwrap_trans_store_uint32->dbwrap_trans_store_uint32_bystring

Signed-off-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Fri Jun 15 14:20:04 CEST 2012 on sn-devel-104

7 years agodbwrap: dbwrap_trans_store_int32->dbwrap_trans_store_int32_bystring
Volker Lendecke [Fri, 15 Jun 2012 07:48:20 +0000 (09:48 +0200)]
dbwrap: dbwrap_trans_store_int32->dbwrap_trans_store_int32_bystring

Signed-off-by: Michael Adam <obnox@samba.org>
7 years agodbwrap: dbwrap_trans_change_int32_atomic->dbwrap_trans_change_int32_atomic_bystring
Volker Lendecke [Fri, 15 Jun 2012 07:45:18 +0000 (09:45 +0200)]
dbwrap: dbwrap_trans_change_int32_atomic->dbwrap_trans_change_int32_atomic_bystring

Signed-off-by: Michael Adam <obnox@samba.org>
7 years agodbwrap: dbwrap_change_int32_atomic->dbwrap_change_int32_atomic_bystring
Volker Lendecke [Fri, 15 Jun 2012 07:43:13 +0000 (09:43 +0200)]
dbwrap: dbwrap_change_int32_atomic->dbwrap_change_int32_atomic_bystring

Signed-off-by: Michael Adam <obnox@samba.org>
7 years agodbwrap: dbwrap_trans_change_uint32_atomic->dbwrap_trans_change_uint32_atomic_bystring
Volker Lendecke [Fri, 15 Jun 2012 07:20:25 +0000 (09:20 +0200)]
dbwrap: dbwrap_trans_change_uint32_atomic->dbwrap_trans_change_uint32_atomic_bystring

Signed-off-by: Michael Adam <obnox@samba.org>
7 years agodbwrap: dbwrap_change_uint32_atomic->dbwrap_change_uint32_atomic_bystring
Volker Lendecke [Fri, 15 Jun 2012 07:18:17 +0000 (09:18 +0200)]
dbwrap: dbwrap_change_uint32_atomic->dbwrap_change_uint32_atomic_bystring

Signed-off-by: Michael Adam <obnox@samba.org>
7 years agodbwrap: dbwrap_store_uint32->dbwrap_store_uint32_bystring
Volker Lendecke [Fri, 15 Jun 2012 07:09:57 +0000 (09:09 +0200)]
dbwrap: dbwrap_store_uint32->dbwrap_store_uint32_bystring

Signed-off-by: Michael Adam <obnox@samba.org>
7 years agodbwrap: dbwrap_fetch_uint32->dbwrap_fetch_uint32_bystring
Volker Lendecke [Thu, 14 Jun 2012 18:39:27 +0000 (20:39 +0200)]
dbwrap: dbwrap_fetch_uint32->dbwrap_fetch_uint32_bystring

Signed-off-by: Michael Adam <obnox@samba.org>
7 years agodbwrap: dbwrap_store_int32->dbwrap_store_int32_bystring
Volker Lendecke [Thu, 14 Jun 2012 18:30:16 +0000 (20:30 +0200)]
dbwrap: dbwrap_store_int32->dbwrap_store_int32_bystring

Signed-off-by: Michael Adam <obnox@samba.org>
7 years agodbwrap: dbwrap_fetch_int32->dbwrap_fetch_int32_bystring
Volker Lendecke [Thu, 14 Jun 2012 18:26:28 +0000 (20:26 +0200)]
dbwrap: dbwrap_fetch_int32->dbwrap_fetch_int32_bystring

Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos3-build: Do not write loadparm generated files into the build tree
Andrew Bartlett [Fri, 15 Jun 2012 02:34:28 +0000 (12:34 +1000)]
s3-build: Do not write loadparm generated files into the build tree

We need to keep these files away from where waf might see them.

Andrew Bartlett

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Jun 15 11:10:14 CEST 2012 on sn-devel-104

7 years agos3-lib: Convert lib/events.c to modern tevent names
Andrew Bartlett [Mon, 11 Jun 2012 04:53:20 +0000 (14:53 +1000)]
s3-lib: Convert lib/events.c to modern tevent names

7 years agodocs: document new server role values
Andrew Bartlett [Mon, 11 Jun 2012 01:40:17 +0000 (11:40 +1000)]
docs: document new server role values

7 years agos3-auth: rework default auth methods around the lp_server_role() parameter
Andrew Bartlett [Mon, 11 Jun 2012 00:51:47 +0000 (10:51 +1000)]
s3-auth: rework default auth methods around the lp_server_role() parameter

To cover all the enum values, ROLE_ACTIVE_DIRECTORY_DOMAIN_CONTROLLER
is mapped to the samba4 auth module, and this is no longer required to
be specified in fileserver.conf.

Andrew Bartlett

7 years agolib/param: Use server role = 'standalone server' to be consistant with member server
Andrew Bartlett [Mon, 11 Jun 2012 00:50:08 +0000 (10:50 +1000)]
lib/param: Use server role = 'standalone server' to be consistant with member server

standalne is left as an alias.

Andrew Bartlett

7 years agolib/param: make security=domain and security=ads conflict with being a DC
Andrew Bartlett [Mon, 11 Jun 2012 00:40:32 +0000 (10:40 +1000)]
lib/param: make security=domain and security=ads conflict with being a DC

This simplifies our supported configurations down to those that we test and expect
to work.  security=domain and domain logons = yes has never made much sense, and
security=ads and domain logons = yes was only ever used in early experiments for
our AD support using smbd.

The correct way to be an AD DC is to set "server role = active directory domain controller"

Andrew Bartlett

7 years agolib/param: Create a seperate server role for "active directory domain controller"
Andrew Bartlett [Sun, 10 Jun 2012 12:08:20 +0000 (22:08 +1000)]
lib/param: Create a seperate server role for "active directory domain controller"

This will allow us to detect from the smb.conf if this is a Samba4 AD
DC which will allow smarter handling of (for example) accidentially
starting smbd rather than samba.

To cope with upgrades from existing Samba4 installs, 'domain
controller' is a synonym of 'active directory domain controller' and
new parameters 'classic primary domain controller' and 'classic backup
domain controller' are added.

Andrew Bartlett

7 years agos3-auth: Merge SEC_DOMAIN and SEC_ADS cases in creating the default auth module list
Andrew Bartlett [Sun, 10 Jun 2012 06:05:58 +0000 (16:05 +1000)]
s3-auth: Merge SEC_DOMAIN and SEC_ADS cases in creating the default auth module list

7 years agos3-auth: Fix system info3 return to be just SID_NT_SYSTEM
Andrew Bartlett [Wed, 13 Jun 2012 23:35:10 +0000 (09:35 +1000)]
s3-auth: Fix system info3 return to be just SID_NT_SYSTEM

The SID for the SYSTEM token should be a fixed value, and not the
administrator.  Note however that it will be replaced by the SID of
sec_initial_uid() by the create_local_token() code.  Fixing this
requires fixes the other parts of the code that cannot cope with a
token of just SID_NT_SYSTEM.

Andrew Bartlett

7 years agos3-auth: Fix system token generation not to dereference pointer as an integer
Andrew Bartlett [Wed, 13 Jun 2012 23:30:37 +0000 (09:30 +1000)]
s3-auth: Fix system token generation not to dereference pointer as an integer

This continues on from commit caaebb455cf955f66c2f662c53998c480cb2d6c9
which is marked as being part of bug #8944, ldapsam:trusted and ipasam
and an additional fix for bug #8567
(0528cb5f3a15b72dcb34ece21a3ffb3e7b8d6eb9).

The problem here was that the primary_gid was simply the pointer result
of dom_sid_parse_talloc() cast to a uint32_t (found by the IRIX cc on
the build farm).

Andrew Bartlett

7 years agos3-auth: Give the SYSTEM token all privileges
Andrew Bartlett [Thu, 14 Jun 2012 23:14:26 +0000 (09:14 +1000)]
s3-auth: Give the SYSTEM token all privileges

7 years agos3:smb2_server: remember the request_time on an incoming request
Stefan Metzmacher [Wed, 11 Apr 2012 14:54:17 +0000 (16:54 +0200)]
s3:smb2_server: remember the request_time on an incoming request

metze

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri Jun 15 09:17:33 CEST 2012 on sn-devel-104

7 years agos3:smbd: remember the request_time on an incoming request
Stefan Metzmacher [Wed, 11 Apr 2012 14:54:17 +0000 (16:54 +0200)]
s3:smbd: remember the request_time on an incoming request

metze

7 years agoheimdal:lib/hdb: <config.h> needs to be the first header
Stefan Metzmacher [Thu, 14 Jun 2012 20:15:24 +0000 (22:15 +0200)]
heimdal:lib/hdb: <config.h> needs to be the first header

This should fix build problems on AIX.

metze

7 years agoauth.idl: mark confidential attributes as [noprint]
Stefan Metzmacher [Thu, 14 Jun 2012 15:52:23 +0000 (17:52 +0200)]
auth.idl: mark confidential attributes as [noprint]

We should allow NDR_PRINT_DEBUG() to log them.

TODO: we could add some more magic which logs it at level 100.

metze

7 years agos3:vfs: change files_struct.fnum from int to uint64_t
Michael Adam [Thu, 14 Jun 2012 11:34:46 +0000 (13:34 +0200)]
s3:vfs: change files_struct.fnum from int to uint64_t

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri Jun 15 05:22:41 CEST 2012 on sn-devel-104

7 years agos3:smbd: change trans2.c to use fsp_fnum_dbg() for fsp->fnum logging.
Michael Adam [Thu, 14 Jun 2012 11:31:43 +0000 (13:31 +0200)]
s3:smbd: change trans2.c to use fsp_fnum_dbg() for fsp->fnum logging.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3:smbd: change smb2_write.c to use fsp_fnum_dbg() for fsp->fnum logging.
Michael Adam [Thu, 14 Jun 2012 11:28:17 +0000 (13:28 +0200)]
s3:smbd: change smb2_write.c to use fsp_fnum_dbg() for fsp->fnum logging.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3:smbd: change smb2_setinfo.c to use fsp_fnum_dbg() for fsp->fnum logging.
Michael Adam [Thu, 14 Jun 2012 11:26:39 +0000 (13:26 +0200)]
s3:smbd: change smb2_setinfo.c to use fsp_fnum_dbg() for fsp->fnum logging.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3:smbd: change smb2_read.c to use fsp_fnum_dbg() for fsp->fnum logging.
Michael Adam [Thu, 14 Jun 2012 11:25:29 +0000 (13:25 +0200)]
s3:smbd: change smb2_read.c to use fsp_fnum_dbg() for fsp->fnum logging.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3:smbd: change smb2_notify.c to use fsp_fnum_dbg() for fsp->fnum logging.
Michael Adam [Thu, 14 Jun 2012 11:23:11 +0000 (13:23 +0200)]
s3:smbd: change smb2_notify.c to use fsp_fnum_dbg() for fsp->fnum logging.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3:smbd: change smb2_lock.c to use fsp_fnum_dbg() for fsp->fnum logging.
Michael Adam [Thu, 14 Jun 2012 11:22:27 +0000 (13:22 +0200)]
s3:smbd: change smb2_lock.c to use fsp_fnum_dbg() for fsp->fnum logging.

Signed-off-by: Stefan Metzmacher <metze@samba.org>