Volker Lendecke [Sun, 23 Mar 2008 17:08:13 +0000 (18:08 +0100)]
Fix Coverity ID 472
Simo, S4 also has this code. You might want to cherry-pick.
Volker
Volker Lendecke [Sun, 23 Mar 2008 16:58:26 +0000 (17:58 +0100)]
Fix Coverity ID 477
Volker Lendecke [Sun, 23 Mar 2008 16:57:01 +0000 (17:57 +0100)]
Fix Coverity ID 478
Volker Lendecke [Sun, 23 Mar 2008 16:54:48 +0000 (17:54 +0100)]
Fix Coverity ID 479
Volker Lendecke [Sun, 23 Mar 2008 16:53:05 +0000 (17:53 +0100)]
Fix Coverity ID 480
Volker Lendecke [Sun, 23 Mar 2008 16:50:55 +0000 (17:50 +0100)]
Fix Coverity ID 450
Volker Lendecke [Sun, 23 Mar 2008 16:49:04 +0000 (17:49 +0100)]
Fix Coverity ID 453
Volker Lendecke [Sun, 23 Mar 2008 16:32:46 +0000 (17:32 +0100)]
Fix Coverity ID 462
Volker Lendecke [Sun, 23 Mar 2008 14:58:09 +0000 (15:58 +0100)]
Fix Coverity ID 432
Volker Lendecke [Sun, 23 Mar 2008 14:56:41 +0000 (15:56 +0100)]
Fix Coverity ID 436
Volker Lendecke [Sun, 23 Mar 2008 14:51:52 +0000 (15:51 +0100)]
Fix Coverity warnings
ID 449, 448, 447, 446, 445, 444, 443, 442, 441, 440, 439, 438, 437
Karolin Seeger [Sun, 23 Mar 2008 06:28:13 +0000 (07:28 +0100)]
VERSION: Update pre release number.
Karolin
Michael Adam [Sat, 22 Mar 2008 01:45:04 +0000 (02:45 +0100)]
libgpo: open the registry in gp_init_reg_ctx().
I forgot the regdb_open() call: registry_init_basic() closes
the registry in the end... sorry.
Michael
Michael Adam [Sat, 22 Mar 2008 01:29:02 +0000 (02:29 +0100)]
libgpo: replace hand-crafted registry initialization by registry_init_basic.
IMO there is no need to imitate a custom registry backend.
Only default regdb hooks are used here, so a plain initialization
of regdb should suffice.
This way, only reg_api is used in libgpo, and no registry
backend code is visible.
Michael
Michael Adam [Sat, 22 Mar 2008 01:22:54 +0000 (02:22 +0100)]
libgpo: use reg_setkeysecurity() instead of regdb_set_secdesc().
That is, use the reg_api function instead of the backend function.
For this, code had to be changed, to take a "struct registry_key"
instead of a char *.
Michael
Michael Adam [Sat, 22 Mar 2008 01:05:53 +0000 (02:05 +0100)]
registry: add reg_init_basic() - init registry with only the db backend.
Michael
Michael Adam [Sat, 22 Mar 2008 00:54:18 +0000 (01:54 +0100)]
registry: close registry in exit path in registry_init_smbconf().
Michael
Michael Adam [Sat, 22 Mar 2008 00:53:44 +0000 (01:53 +0100)]
registry: some whitespace cleanup in init_registry().
Michael
Michael Adam [Sat, 22 Mar 2008 00:52:03 +0000 (01:52 +0100)]
registry: remove unneeded talloc stackframe variable.
Michael
Michael Adam [Sat, 22 Mar 2008 00:49:21 +0000 (01:49 +0100)]
registry: close regdb in error path (and use it) in init_registry().
Michael
Michael Adam [Fri, 21 Mar 2008 22:50:49 +0000 (23:50 +0100)]
registry: fix registry_init_smbconf() to close the registry at the end.
Michael
Michael Adam [Fri, 21 Mar 2008 22:39:01 +0000 (23:39 +0100)]
libsmbconf: add internal open/close handling to registry backend.
This internally keeps track of opened registry in the private data
struct. The first call that really accesses data, opens the registry
and it is kept open until the destructor is called.
This behaviour might be changed in the future.
Michael
Michael Adam [Fri, 21 Mar 2008 21:55:20 +0000 (22:55 +0100)]
libsmbconf: add a comment.
Michael
Michael Adam [Fri, 21 Mar 2008 21:52:27 +0000 (22:52 +0100)]
libsmbconf: add private_data section to smbconf_ctx.
This private data should be used by backends.
The token for the registry backend is moved from
the context to the private data section, since
this is registry specific.
Michael
Michael Adam [Fri, 21 Mar 2008 16:55:31 +0000 (17:55 +0100)]
libsmbconf: add a "path" variable to the conf context.
This is passed to the module init routines.
In case of the registry, this is the path of the
basekey in registry, that is to be used, defaulting
to KEY_SMBCONF (HKLM\software\samba\smbconf), when
NULL is given. This is the only case currently used.
In order to support other keys, registry initialization
for smbconf has to be changed to support different keys.
Michael
Michael Adam [Fri, 21 Mar 2008 15:45:25 +0000 (16:45 +0100)]
libsmbconf: add structuring comments to the prototypes in the public header.
Michael
Michael Adam [Fri, 21 Mar 2008 15:42:42 +0000 (16:42 +0100)]
libsmbconf: adapt a comment to new circumstances
Michael
Michael Adam [Fri, 21 Mar 2008 15:40:20 +0000 (16:40 +0100)]
libsmbconf: group together functions in smbconf.c more appropriately
Michael
Michael Adam [Fri, 21 Mar 2008 15:35:52 +0000 (16:35 +0100)]
libsmbconf: add a comment.
Michael
Michael Adam [Fri, 21 Mar 2008 15:26:50 +0000 (16:26 +0100)]
libsmbconf: move registry implementation to a module of its own.
Michael
Volker Lendecke [Fri, 21 Mar 2008 12:39:48 +0000 (13:39 +0100)]
On Solaris, size_t seems to be only 32 bit.
Fix bug 5341, thanks a lot to Karoly Vegh for testing it!
Volker
Volker Lendecke [Fri, 21 Mar 2008 10:52:34 +0000 (11:52 +0100)]
Fix Coverity ID 473
Simo, S4 also has this bug, you might want to merge the fix.
Volker Lendecke [Fri, 21 Mar 2008 10:48:09 +0000 (11:48 +0100)]
Fix Coverity ID 506
Volker Lendecke [Fri, 21 Mar 2008 10:45:57 +0000 (11:45 +0100)]
Fix Coverity ID 507
Volker Lendecke [Fri, 21 Mar 2008 10:42:42 +0000 (11:42 +0100)]
Fix Coverity ID 537
Volker Lendecke [Fri, 21 Mar 2008 10:41:15 +0000 (11:41 +0100)]
Fix Coverity ID 538
Volker Lendecke [Fri, 21 Mar 2008 09:40:40 +0000 (10:40 +0100)]
Fix Coverity ID 547
Günther, please check. If r->in.ads==NULL, we can't call ads_leave_realm at
all.
Thanks,
Volker
Volker Lendecke [Fri, 21 Mar 2008 09:28:33 +0000 (10:28 +0100)]
Fix Coverity ID 548
Günther, please check -- in all infolevels we do a comment=talloc_strdup
Thanks,
Volker
Volker Lendecke [Fri, 21 Mar 2008 09:20:53 +0000 (10:20 +0100)]
Fix Coverity IDs 553, 552
Günther Deschner [Fri, 21 Mar 2008 03:13:49 +0000 (04:13 +0100)]
Add my copyright.
Guenther
Günther Deschner [Fri, 21 Mar 2008 03:12:52 +0000 (04:12 +0100)]
Remove remaining old srvsvc client and server rpc code entirely.
Guenther
Günther Deschner [Fri, 21 Mar 2008 02:59:02 +0000 (03:59 +0100)]
Remove double RPC_PARSE_OBJ2 from Makefile.
Guenther
Günther Deschner [Fri, 21 Mar 2008 02:56:54 +0000 (03:56 +0100)]
Move MAX.*ENTRY definitions out of old rpc srvsvc parsing code.
Guenther
Günther Deschner [Fri, 21 Mar 2008 02:53:18 +0000 (03:53 +0100)]
Remove unused marshalling for SRV_NET_SESS_ENUM.
Guenther
Günther Deschner [Fri, 21 Mar 2008 02:51:37 +0000 (03:51 +0100)]
Use pidl for _srvsvc_NetSessEnum().
Guenther
Günther Deschner [Fri, 21 Mar 2008 02:50:49 +0000 (03:50 +0100)]
Add support for setting resume handle in netsessenum rpcclient command.
Guenther
Günther Deschner [Fri, 21 Mar 2008 01:01:58 +0000 (02:01 +0100)]
Remove unused marshalling for SRV_NET_CONN_ENUM.
Guenther
Günther Deschner [Fri, 21 Mar 2008 00:58:43 +0000 (01:58 +0100)]
Use pidl for _srvsvc_NetConnEnum().
Guenther
Günther Deschner [Fri, 21 Mar 2008 00:14:23 +0000 (01:14 +0100)]
Allow to set or unset resume_handle in netconnenum in rpcclient.
Guenther
Michael Adam [Fri, 21 Mar 2008 01:29:09 +0000 (02:29 +0100)]
libsmbconf: reformaat - fix some whispacing/tabs
Michael
Michael Adam [Fri, 21 Mar 2008 01:20:16 +0000 (02:20 +0100)]
libsmbconf: add backend specific init function.
Hide generic init function taking smbconf_ops argument
from public api.
Michael
Michael Adam [Fri, 21 Mar 2008 01:01:55 +0000 (02:01 +0100)]
libsmbconf: add shutdown handler to smbconf_ops.
Michael
Michael Adam [Fri, 21 Mar 2008 00:15:20 +0000 (01:15 +0100)]
libsmbconf: fix comments
Michael
Michael Adam [Fri, 21 Mar 2008 00:04:57 +0000 (01:04 +0100)]
libsmbconf: rename smbconf_close() to smbconf_shutdown().
Michael
Michael Adam [Thu, 20 Mar 2008 22:41:39 +0000 (23:41 +0100)]
libsmbconf: rename smbconf_open() to smbconf_init().
That's more appropriate.
Michael
Michael Adam [Thu, 20 Mar 2008 17:40:09 +0000 (18:40 +0100)]
libsmbconf: add open and close operations to the smbconf_ops.
Note: currently, reg_init_smbconf opens the registry, but does
not close it. This has to be changed. so that it is closed.
And then libsmbconf will need these open/close functions
Michael
Michael Adam [Thu, 20 Mar 2008 11:28:41 +0000 (12:28 +0100)]
libsmbconf: introduce a smbconf_ops layer to allow interchangeable backends.
Michael
Michael Adam [Thu, 20 Mar 2008 11:25:44 +0000 (12:25 +0100)]
libsmbconf: move smbconf_reg_initialize() down to the smbconf operations.
Michael
Michael Adam [Thu, 20 Mar 2008 10:54:30 +0000 (11:54 +0100)]
libsmbconf: add existence check for service to smbconf_delete_share().
Michael
Michael Adam [Thu, 20 Mar 2008 10:53:40 +0000 (11:53 +0100)]
libsmbconf: add existence check for service to smbconf_get_share().
Michael
Michael Adam [Thu, 20 Mar 2008 10:52:13 +0000 (11:52 +0100)]
libsmbconf: add check for NULL servicename to smbconf_share_exists().
Michael
Michael Adam [Thu, 20 Mar 2008 10:50:06 +0000 (11:50 +0100)]
libsmbconf: fix a comment
Michael Adam [Thu, 20 Mar 2008 10:49:26 +0000 (11:49 +0100)]
libsmbconf: refactor out registry implementation of smbconf operations.
This leaves most of the api functions mere wrappers except for some
common initial checks.
Michael
Michael Adam [Thu, 20 Mar 2008 09:43:17 +0000 (10:43 +0100)]
libsmbconf: refactor autocreation of [global] into a helper function.
Michael
Michael Adam [Wed, 19 Mar 2008 11:37:17 +0000 (12:37 +0100)]
libsmbconf: put the smbconf context struct into a private header.
Michael
Michael Adam [Wed, 19 Mar 2008 09:47:23 +0000 (10:47 +0100)]
libsmbconf: change the API to always take the smbconf_ctx parameter first.
..for consistency. Exception: the open/init function, where the smbconf_ctx
is created from the given talloc context.
Michael
Michael Adam [Wed, 19 Mar 2008 09:15:16 +0000 (10:15 +0100)]
libsmbconf: fix indentation.
Michael
Michael Adam [Tue, 18 Mar 2008 22:29:11 +0000 (23:29 +0100)]
libsmbconf: change smbconf_get_seqnum() to smbconf_changed().
The former seqnum is hidden inside a struct smbconf_csn.
And the get_seqnum is united with a changed function that
stores the seqnum inside the given csn.
Michael
Michael Adam [Mon, 17 Mar 2008 23:51:15 +0000 (00:51 +0100)]
libsmbconf: fix a comment
Michael
Volker Lendecke [Thu, 20 Mar 2008 20:58:39 +0000 (21:58 +0100)]
A level 25 setuserinfo does change the pwdlastset
Michael Adam [Thu, 20 Mar 2008 15:50:52 +0000 (16:50 +0100)]
smbd: fix session setup with security = share.
Broken by pstring removal in
9ed12bfc48fe7f9b1863a9dd88e881974083053c.
Jeremy, please check.
Thanks to Yannick Bergeron <yaberger@ca.ibm.com> for noting this.
Michael
Volker Lendecke [Thu, 20 Mar 2008 15:15:38 +0000 (16:15 +0100)]
Fix an uninitialized variable warning
root [Thu, 20 Mar 2008 14:59:37 +0000 (15:59 +0100)]
Port
3c1f1f0797e from 3-0-ctdb
We need to inform ctdb about the client's TCP connection so that after a fail
over ctdbd can trigger the client to reconnect very quickly
Volker Lendecke [Thu, 20 Mar 2008 11:49:13 +0000 (12:49 +0100)]
Fix some warnings in the tsmsm module
Alexander, please check!
Michael Adam [Wed, 19 Mar 2008 14:18:06 +0000 (15:18 +0100)]
loadparm: reenable checking files for updates while in registry configuration.
This is necessary now that includes (to files) are enabled from registry.
Michael
Michael Adam [Wed, 19 Mar 2008 10:00:29 +0000 (11:00 +0100)]
loadparm: remove unneeded include.
libnet.h unneeded after separation of libsmbconf from libnet.
Michael
Michael Adam [Thu, 20 Mar 2008 13:35:41 +0000 (14:35 +0100)]
registry: use available string constant in debug statement.
Michael
Michael Adam [Thu, 20 Mar 2008 13:33:43 +0000 (14:33 +0100)]
registry: in regdb_init, not only complain about INFO/version, store it...
Michael
Michael Adam [Thu, 20 Mar 2008 13:26:42 +0000 (14:26 +0100)]
registry: reformat regdb_init() slightly, breaking long lines.
Michael
Michael Adam [Thu, 20 Mar 2008 13:24:12 +0000 (14:24 +0100)]
registry: untangle assignment and if-statement in regdb_init().
Michael
Michael Adam [Thu, 20 Mar 2008 13:08:29 +0000 (14:08 +0100)]
registry: separate initialization of registry data from regdb_init().
Leave this to the users (currently registry_init_smbconf() and
init_registry()) to initialize as much of preliminary registry data
as needed.
Michael
Michael Adam [Thu, 20 Mar 2008 13:01:13 +0000 (14:01 +0100)]
registry: add a transaction wrapper to init_registry_key_internal().
Michael
Michael Adam [Thu, 20 Mar 2008 12:59:09 +0000 (13:59 +0100)]
registry: refactor creation of subkeys out of init_registry_data().
Michael
Karolin Seeger [Thu, 20 Mar 2008 13:15:29 +0000 (14:15 +0100)]
Start to prepare WHATSNEW for 3.2.0pre3.
Karolin
Günther Deschner [Thu, 20 Mar 2008 00:40:04 +0000 (01:40 +0100)]
Remove unused marshalling for SVCCTL_ENUM_DEPENDENT_SERVICES.
Guenther
Günther Deschner [Thu, 20 Mar 2008 00:38:23 +0000 (01:38 +0100)]
Use pidl for _svcctl_EnumDependentServicesW().
Guenther
Günther Deschner [Thu, 20 Mar 2008 00:35:58 +0000 (01:35 +0100)]
Re-run make idl.
Guenther
Günther Deschner [Thu, 20 Mar 2008 00:32:20 +0000 (01:32 +0100)]
Fix IDL for svcctl_EnumDependentServicesW().
Guenther
Günther Deschner [Thu, 20 Mar 2008 00:26:37 +0000 (01:26 +0100)]
Move svc_status_string() out of rpc_client/cli_svcctl.c
Guenther
Günther Deschner [Thu, 20 Mar 2008 00:24:55 +0000 (01:24 +0100)]
No need to compose CLI_SERVER_NAME_SLASH in "net rpc service" anymore.
Guenther
Günther Deschner [Wed, 19 Mar 2008 23:31:26 +0000 (00:31 +0100)]
Add error mapping for WERR_SERVICE_NEVER_STARTED.
Guenther
Günther Deschner [Wed, 19 Mar 2008 23:30:01 +0000 (00:30 +0100)]
Fix crash bug in check_sam_security() when make_server_info_sam() did a
talloc_steal and talloc_free on the sam account already.
Guenther
Kai Blin [Wed, 19 Mar 2008 22:32:38 +0000 (23:32 +0100)]
ntlm_auth: Improve compliance to the Squid helper protocol
This fixes bug #4235.
Patch from Pawel Worach <pawel.worach@gmail.com> with some linebreaks
added by me.
Also fix one BH message that the original patch didn't fix.
Michael Adam [Tue, 18 Mar 2008 16:50:23 +0000 (17:50 +0100)]
libreplace: replace.c does not need system/network.h anymore.
Michael
(cherry picked from commit
2d3c2f34f33338ff422047dae9cc262522689328)
Michael Adam [Tue, 18 Mar 2008 16:20:47 +0000 (17:20 +0100)]
libreplace: move rep_socketpair() to its own module.
Prototype is now in system/network.h,
implementation in socketpair.c, and
check in socketpair.m4.
Now the last networking function has vanished from replace.c.
Michael
(cherry picked from commit
94ac8a25be15b55f66eff96fdddc2fdc71a43b1e)
Volker Lendecke [Wed, 19 Mar 2008 21:37:24 +0000 (22:37 +0100)]
!NT_STATUS_IS_OK != NT_STATUS_IS_ERR
When reading from a pipe, Windows return STATUS_BUFFER_OVERFLOW which is *not*
an error.
Volker Lendecke [Wed, 19 Mar 2008 16:04:50 +0000 (17:04 +0100)]
Fix a warning
Volker Lendecke [Wed, 19 Mar 2008 15:09:37 +0000 (16:09 +0100)]
Merge
dd9e0bea31751 from 3-0-ctdb -- use NetSamLogonEx when possible
NetSamLogonEx has the advantage that it does not use the credential chain
Volker Lendecke [Wed, 19 Mar 2008 15:08:24 +0000 (16:08 +0100)]
Fix some "nexted extern" warnins
Volker Lendecke [Wed, 19 Mar 2008 14:01:30 +0000 (15:01 +0100)]
Fix bug 5338 -- thanks to Yuya Katayama <yuya999@gmail.com>