kai/samba-autobuild/.git
4 years agos4:torture:raw:notify: let NOTIFY_MASK_TEST use torture_assert macros
Michael Adam [Fri, 27 Mar 2015 09:19:26 +0000 (10:19 +0100)]
s4:torture:raw:notify: let NOTIFY_MASK_TEST use torture_assert macros

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos4:torture:raw:notify: remove extra do-loop in NOTIFY_MASK_TEST macro.
Michael Adam [Thu, 26 Mar 2015 23:43:30 +0000 (00:43 +0100)]
s4:torture:raw:notify: remove extra do-loop in NOTIFY_MASK_TEST macro.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos4:torture:raw:notify: use torture_assert instead of printf in failure case
Michael Adam [Thu, 26 Mar 2015 18:41:06 +0000 (19:41 +0100)]
s4:torture:raw:notify: use torture_assert instead of printf in failure case

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos4:torture:raw:notify: remove superfluous conditional goto
Michael Adam [Thu, 26 Mar 2015 18:36:52 +0000 (19:36 +0100)]
s4:torture:raw:notify: remove superfluous conditional goto

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos4:torture:raw:notify: treat torture_open_connection calls with torture_assert
Michael Adam [Thu, 26 Mar 2015 18:22:08 +0000 (19:22 +0100)]
s4:torture:raw:notify: treat torture_open_connection calls with torture_assert

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos4:torture:raw:notify: use torture_assert with torture_setup_dir
Michael Adam [Thu, 26 Mar 2015 18:18:43 +0000 (19:18 +0100)]
s4:torture:raw:notify: use torture_assert with torture_setup_dir

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos4:torture:raw:notify: add a few comments to torture_assert calls
Michael Adam [Thu, 26 Mar 2015 18:13:58 +0000 (19:13 +0100)]
s4:torture:raw:notify: add a few comments to torture_assert calls

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos4:torture:raw:notify: improve the CHECK_WSTR() macro
Michael Adam [Thu, 26 Mar 2015 18:11:16 +0000 (19:11 +0100)]
s4:torture:raw:notify: improve the CHECK_WSTR() macro

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos4:torture:raw:notify: make check_rename_reply() properly use torture_result
Michael Adam [Thu, 26 Mar 2015 18:08:26 +0000 (19:08 +0100)]
s4:torture:raw:notify: make check_rename_reply() properly use torture_result

Only change currently: the CHECK_WSTR calls report the line
number of this function now instead of the handed in
line of the callers. This could be fixed by turning this
function into a macro...

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos4:torture:raw:notify: remove CHECK_WSTR2.
Michael Adam [Thu, 26 Mar 2015 17:58:05 +0000 (18:58 +0100)]
s4:torture:raw:notify: remove CHECK_WSTR2.

The original CHECK_WSTR() macro was not setting torture failure,
leading to errors instead of propoer failures.

The original CHECK_WSTR2() macro was exactly like the CHECK_WSTR
macro but using propoer torture_result() calls.

This patch removes the original CHECK_WSTR(), renames CHECK_WSTR2
to CHECK_WSTR and adapts the callers, hence removing the source
of many potential missing torture_assert messages.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos4:torture:raw:notify: remove CHECK_VAL.
Michael Adam [Thu, 26 Mar 2015 17:45:47 +0000 (18:45 +0100)]
s4:torture:raw:notify: remove CHECK_VAL.

This macro is not setting torture failure, leading to errors instead
of failures. Use torture_assert_ntstatus_(ok|equal)* macros.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos4:torture:raw:notify: remove CHECK_STATUS.
Michael Adam [Thu, 26 Mar 2015 11:00:15 +0000 (12:00 +0100)]
s4:torture:raw:notify: remove CHECK_STATUS.

This macro is not setting torture failure, leading to errors instead
of failures. Use torture_assert_ntstatus_(ok|equal)* macros.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agotorture: add torture_assert_not_null[_goto]
Michael Adam [Thu, 26 Mar 2015 20:20:23 +0000 (21:20 +0100)]
torture: add torture_assert_not_null[_goto]

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agotorture: add torture_assert_int_not_equal_goto
Michael Adam [Fri, 27 Mar 2015 09:02:28 +0000 (10:02 +0100)]
torture: add torture_assert_int_not_equal_goto

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos3:trusts_util: generate completely random passwords in trust_pw_change()
Stefan Metzmacher [Fri, 30 Jan 2015 09:21:59 +0000 (09:21 +0000)]
s3:trusts_util: generate completely random passwords in trust_pw_change()

Instead of having every 2nd byte as '\0' in the utf16 password,
because the utf8 form is based on an ascii subset, we convert
the random buffer from CH_UTF16MUNGED to CH_UTF8.

This way we have a random but valid utf8 string,
which is almost like what Windows is doing.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos3:trusts_util: pass new_trust_version to netlogon_creds_cli_ServerPasswordSet()...
Stefan Metzmacher [Fri, 30 Jan 2015 09:21:59 +0000 (09:21 +0000)]
s3:trusts_util: pass new_trust_version to netlogon_creds_cli_ServerPasswordSet() in trust_pw_change()

We should maintain current and previous passwords on both sides of the trust,
which mean we need to pass our view of the new version to the remote DC.

This avoid problems with replication delays and make sure the kvno
for cross-realm tickets is in sync.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos3:trusts_util: make use of pdb_get_trust_credentials() and pdb_get_trusted_domain...
Stefan Metzmacher [Fri, 30 Jan 2015 09:21:59 +0000 (09:21 +0000)]
s3:trusts_util: make use of pdb_get_trust_credentials() and pdb_get_trusted_domain() in trust_pw_change()

Using pdb_get_trust_credentials() works for all kind of trusts
and gives us much more details regarding the credentials.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos3:trusts_util: add support for SEC_CHAN_DNS_DOMAIN in trust_pw_change()
Stefan Metzmacher [Fri, 30 Jan 2015 09:21:59 +0000 (09:21 +0000)]
s3:trusts_util: add support for SEC_CHAN_DNS_DOMAIN in trust_pw_change()

SEC_CHAN_DNS_DOMAIN trusts use longer passwords, Windows uses 240 UTF16 bytes.

Some trustAttribute flags may also make impact on the length on Windows,
but we could be better if we know that the remote domain is an AD domain.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos3:rpc_server/lsa: we need to normalize the trustAuth* blobs before storing them
Stefan Metzmacher [Sat, 31 Jan 2015 10:45:12 +0000 (11:45 +0100)]
s3:rpc_server/lsa: we need to normalize the trustAuth* blobs before storing them

The number of current and previous elements need to match and we have to
fill TRUST_AUTH_TYPE_NONE if needed.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos4:rpc_server/lsa: we need to normalize the trustAuth* blobs before storing them
Stefan Metzmacher [Sat, 31 Jan 2015 10:45:12 +0000 (11:45 +0100)]
s4:rpc_server/lsa: we need to normalize the trustAuth* blobs before storing them

The number of current and previous elements need to match and we have to
fill TRUST_AUTH_TYPE_NONE if needed.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos4:rpc_server/lsa: notify winbindd about new trusted domains
Stefan Metzmacher [Fri, 23 Jan 2015 15:59:27 +0000 (16:59 +0100)]
s4:rpc_server/lsa: notify winbindd about new trusted domains

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos3:winbindd: add MSG_WINBIND_NEW_TRUSTED_DOMAIN that takes a lsa_TrustDomainInfoInfoEx
Stefan Metzmacher [Fri, 23 Jan 2015 15:59:07 +0000 (16:59 +0100)]
s3:winbindd: add MSG_WINBIND_NEW_TRUSTED_DOMAIN that takes a lsa_TrustDomainInfoInfoEx

When a new trusted domain is added in the LSA server, we need to immediately
have the domain within winbindd. This notification is done via a
MSG_WINBIND_NEW_TRUSTED_DOMAIN message.

In future we might want just a "rescan direct trusts" message,
but that requires a lot of redesign within winbindd.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agolsa.idl: mark lsa_TrustDomainInfoInfoEx as public
Stefan Metzmacher [Sat, 24 Jan 2015 10:22:54 +0000 (11:22 +0100)]
lsa.idl: mark lsa_TrustDomainInfoInfoEx as public

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos4:selftest: run dbcheck against the ad_dc environment too
Stefan Metzmacher [Fri, 27 Mar 2015 09:45:58 +0000 (10:45 +0100)]
s4:selftest: run dbcheck against the ad_dc environment too

This is the environment that is configured like real world configurations.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos4:rpc_server/lsa: implement the policy security descriptor
Stefan Metzmacher [Wed, 25 Mar 2015 19:11:12 +0000 (19:11 +0000)]
s4:rpc_server/lsa: implement the policy security descriptor

We now check the requested access mask in OpenPolicy*()
and return NT_STATUS_ACCESS_DENIED if the request is not granted.

E.g. validating a domain trust via the Windows gui requires this
in order prompt the user for the credentials. Otherwise
we fail any other call with ACCESS_DENIED later and the
gui just displays a strange error message.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos4:rpc_server/lsa: normalize the access_mask for lsa account objects
Stefan Metzmacher [Thu, 26 Mar 2015 20:52:27 +0000 (21:52 +0100)]
s4:rpc_server/lsa: normalize the access_mask for lsa account objects

We still grant all access in the access_mask, but we don't check the
mask at all yet...

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agolibcli/security: add security_descriptor_for_client() helper function
Stefan Metzmacher [Thu, 26 Mar 2015 13:39:35 +0000 (14:39 +0100)]
libcli/security: add security_descriptor_for_client() helper function

This prepares a possibly stripped security descriptor for a client.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agolibcli/security: support "IS" in SDDL for SID_NT_IUSR
Stefan Metzmacher [Wed, 25 Mar 2015 19:10:48 +0000 (19:10 +0000)]
libcli/security: support "IS" in SDDL for SID_NT_IUSR

TODO: we should import the whole lists from [MS-DTYP].

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos3:rpcclient: only require netlogon_creds for specified netlogon calls
Stefan Metzmacher [Thu, 26 Mar 2015 13:41:09 +0000 (14:41 +0100)]
s3:rpcclient: only require netlogon_creds for specified netlogon calls

A lot of calls on the netlogon pipe doesn't require netlogon credentials,
e.g. netr_LogonControl*() should work just with administrator credentials.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agoCheck for third party Python modules during configure.
Jelmer Vernooij [Sat, 28 Mar 2015 16:11:51 +0000 (16:11 +0000)]
Check for third party Python modules during configure.

Inform the user whether the module was found on the system, or if the
bundled copy is being used. If the module is not found, suggest what
they can do to make it available to Samba.

Change-Id: I89ec57a2acf87768ca3714add59575578d2ee399
Signed-Off-By: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Mon Mar 30 13:40:33 CEST 2015 on sn-devel-104

4 years agoMove configure part of third party to third_party/wscript.
Jelmer Vernooij [Sat, 28 Mar 2015 15:43:29 +0000 (15:43 +0000)]
Move configure part of third party to third_party/wscript.

Change-Id: I34875a8bde99df2e0a2659677e88640bb0ec1816
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
4 years agoPass --recursive to 'git clone' in autobuild.
Jelmer Vernooij [Sat, 28 Mar 2015 16:15:03 +0000 (16:15 +0000)]
Pass --recursive to 'git clone' in autobuild.

This makes it possible to use submodules in Samba.

Change-Id: Iccb1876b1daf82864b18486f2dca9036d7d3c75c
Signed-Off-By: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
4 years agogroupdb: Fix a typo
Volker Lendecke [Sun, 29 Mar 2015 16:17:46 +0000 (18:17 +0200)]
groupdb: Fix a typo

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
4 years agoheimdal: Fix a warning
Volker Lendecke [Sun, 29 Mar 2015 13:59:41 +0000 (15:59 +0200)]
heimdal: Fix a warning

99% this is what was meant....

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
4 years agoheimdal: Fix a warning
Volker Lendecke [Sun, 29 Mar 2015 13:59:41 +0000 (15:59 +0200)]
heimdal: Fix a warning

99% this is what was meant....

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
4 years agovfs_gpfs: Remove warning after failure of get_gpfs_fset_id
Christof Schmitt [Fri, 27 Mar 2015 20:16:41 +0000 (13:16 -0700)]
vfs_gpfs: Remove warning after failure of get_gpfs_fset_id

get_gpfs_fset_id already emits more detailed warnings, there is no need
to print an additional warning in the calling function.

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
4 years agoctdb-tests: Switch to tcp check in rpcinfo stub
Amitay Isaacs [Fri, 27 Mar 2015 01:00:56 +0000 (12:00 +1100)]
ctdb-tests: Switch to tcp check in rpcinfo stub

Use -T tcp instead of deprecated options -u and -t.  Also, check for
localhost.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Fri Mar 27 09:16:50 CET 2015 on sn-devel-104

4 years agoctdb-scripts: Use tcp connection for checking RPC services
Amitay Isaacs [Fri, 27 Mar 2015 01:04:03 +0000 (12:04 +1100)]
ctdb-scripts: Use tcp connection for checking RPC services

It's possible for a RPC service to register only for UDP and not TCP.
Since we assume all the NFS operations are over TCP, always check RPC
services over TCP.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-scripts: Respect $RPCMOUNTDOPTS when restarting rpc.mountd
Martin Schwenke [Tue, 24 Mar 2015 09:12:51 +0000 (20:12 +1100)]
ctdb-scripts: Respect $RPCMOUNTDOPTS when restarting rpc.mountd

$RPCMOUNTDOPTS is ignored when restarting rpc.statd due to the service
being unresponsive.  This variable can be used to increase the number
of rpc.mountd threads when there are a lot of clients reattaching so
ignoring it can mean that only a single rpc.mount thread is started.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-daemon: Drop tunable that is no longer in use
Amitay Isaacs [Wed, 30 Jul 2014 04:31:54 +0000 (14:31 +1000)]
ctdb-daemon: Drop tunable that is no longer in use

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-recoverd: Fix typo in comment
Amitay Isaacs [Wed, 30 Jul 2014 02:32:08 +0000 (12:32 +1000)]
ctdb-recoverd: Fix typo in comment

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoselftest: Use 'logging' parameter instead of 'syslog'
Christof Schmitt [Mon, 23 Mar 2015 23:16:36 +0000 (16:16 -0700)]
selftest: Use 'logging' parameter instead of 'syslog'

'syslog' has been deprecated, so use the new 'logging' parameter
instead.

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Fri Mar 27 06:38:32 CET 2015 on sn-devel-104

4 years agos4-process_model: Panic if the standard init function fails
Andreas Schneider [Thu, 26 Mar 2015 09:58:18 +0000 (10:58 +0100)]
s4-process_model: Panic if the standard init function fails

Pair-Programmed-With: Michael Adam <obnox@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agos4-process_model: Do not close random fds while forking.
Andreas Schneider [Thu, 26 Mar 2015 09:48:31 +0000 (10:48 +0100)]
s4-process_model: Do not close random fds while forking.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11180

The issue has been found with nss_wrapper debug output running:
    samba4.ntvfs.cifs.krb5.base.lock

In the case here, we fork a child and close the fd without resetting
the pipe fd variable. Then the fd was used to open the nss_wrapper
hosts file which got the same fd. We forked again in the process model
called close() on the re-used fd (of the pipe variable) again without
nss_wrapper noticing.  Now Samba opened the secrets tdb and got
the same fd as nss_wrapper was using for the hosts file and next
nss_wrapper tried to parse a TDB ...

Pair-Programmed-With: Michael Adam <obnox@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agos4:kdc/db-glue: samba_kdc_trust_message2entry() should use the normalized principal...
Stefan Metzmacher [Thu, 26 Mar 2015 09:24:05 +0000 (09:24 +0000)]
s4:kdc/db-glue: samba_kdc_trust_message2entry() should use the normalized principal as salt

smbclient //w2012r2-183.w2012r2-l4.base/netlogon -c 'ls' -k yes -Uadministrator@S4XDOM.BASE%A1b2C3d4
worked while
smbclient //w2012r2-183.w2012r2-l4.base/netlogon -c 'ls' -k yes -Uadministrator@s4xdom.base
failed, if aes keys are used across the trust.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Fri Mar 27 04:02:05 CET 2015 on sn-devel-104

4 years agolibcli/util: remove unused WERR_BAD_PASSWORD
Stefan Metzmacher [Thu, 26 Mar 2015 10:00:10 +0000 (11:00 +0100)]
libcli/util: remove unused WERR_BAD_PASSWORD

The values are the same, but WERR_INVALID_PASSWORD matches the documentation.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agolibcli/auth: use WERR_INVALID_PASSWORD instead of WERR_BAD_PASSWORD
Stefan Metzmacher [Thu, 26 Mar 2015 10:00:10 +0000 (11:00 +0100)]
libcli/auth: use WERR_INVALID_PASSWORD instead of WERR_BAD_PASSWORD

The values are the same, but WERR_INVALID_PASSWORD matches the documentation.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agodocs-xml/Samba3-HOWTO: add reference to WERR_INVALID_PASSWORD were we had only WERR_B...
Stefan Metzmacher [Thu, 26 Mar 2015 10:00:10 +0000 (11:00 +0100)]
docs-xml/Samba3-HOWTO: add reference to WERR_INVALID_PASSWORD were we had only WERR_BAD_PASSWORD

The values are the same, but WERR_INVALID_PASSWORD matches the documentation
and the new win_errstr() output.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agoselftest: use dns_lookup_* = true in krb5.conf
Stefan Metzmacher [Tue, 24 Mar 2015 18:05:10 +0000 (19:05 +0100)]
selftest: use dns_lookup_* = true in krb5.conf

We only need to specify explicit entries for the local realm
in order to provision the server.

Everything else is handled by real dns or faked dns via resolv wrapper.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos4-kdc/db_glue: avoid accessing private struct members when there are accessor funcs.
Günther Deschner [Tue, 10 Feb 2015 12:23:14 +0000 (13:23 +0100)]
s4-kdc/db_glue: avoid accessing private struct members when there are accessor funcs.

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agos4-kdc/db_glue: use smb_krb5_principal_set_type().
Günther Deschner [Tue, 10 Feb 2015 12:14:21 +0000 (13:14 +0100)]
s4-kdc/db_glue: use smb_krb5_principal_set_type().

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agokrb5_wrap: fix documentation for smb_krb5_principal_get_comp_string().
Günther Deschner [Tue, 10 Feb 2015 12:38:41 +0000 (13:38 +0100)]
krb5_wrap: fix documentation for smb_krb5_principal_get_comp_string().

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agokrb5_wrap: add smb_krb5_principal_set_type().
Günther Deschner [Tue, 10 Feb 2015 12:13:01 +0000 (13:13 +0100)]
krb5_wrap: add smb_krb5_principal_set_type().

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agos4-auth: fix DEBUG statement.
Günther Deschner [Sat, 7 Feb 2015 14:12:45 +0000 (15:12 +0100)]
s4-auth: fix DEBUG statement.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agogensec: map KRB5KRB_AP_ERR_BAD_INTEGRITY to logon failure.
Günther Deschner [Sat, 7 Feb 2015 09:48:30 +0000 (10:48 +0100)]
gensec: map KRB5KRB_AP_ERR_BAD_INTEGRITY to logon failure.

When requesting initiator credentials fails, we need to map the error code
KRB5KRB_AP_ERR_BAD_INTEGRITY to NT_STATUS_LOGON_FAILURE as well. This is what
current MIT kerberos returns.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agos4-kdc/db-glue: make sure to use smb_krb5_get_pw_salt and smb_krb5_create_key_from_st...
Günther Deschner [Fri, 19 Dec 2014 15:35:48 +0000 (16:35 +0100)]
s4-kdc/db-glue: make sure to use smb_krb5_get_pw_salt and smb_krb5_create_key_from_string.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agolib/krb5_wrap: use krb5_const_principal in smb_krb5_get_pw_salt().
Günther Deschner [Thu, 26 Mar 2015 10:31:34 +0000 (11:31 +0100)]
lib/krb5_wrap: use krb5_const_principal in smb_krb5_get_pw_salt().

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agolib/krb5_wrap: use krb5_const_principal in smb_krb5_create_key_from_string.
Günther Deschner [Thu, 26 Mar 2015 10:21:06 +0000 (11:21 +0100)]
lib/krb5_wrap: use krb5_const_principal in smb_krb5_create_key_from_string.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agos4-auth: avoid double free of krb5 kt_entries when compiling with MIT kerberos library.
Günther Deschner [Tue, 29 Jul 2014 16:32:20 +0000 (18:32 +0200)]
s4-auth: avoid double free of krb5 kt_entries when compiling with MIT kerberos library.

Guenther

Pair-Programmed-With: Andreas Schneider <asn@samba.org>

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agos4-gensec: Check if we have delegated credentials.
Andreas Schneider [Tue, 29 Jul 2014 10:33:49 +0000 (12:33 +0200)]
s4-gensec: Check if we have delegated credentials.

With MIT Kerberos it is possible that the GSS_C_DELEG_FLAG is set, but
the delegated_cred_handle is NULL which results in a NULL-pointer
dereference. This way we fix it.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agos4-kdc/db-glue: use smb_krb5_principal_get_comp_string in dbglue.
Günther Deschner [Fri, 16 May 2014 09:44:49 +0000 (11:44 +0200)]
s4-kdc/db-glue: use smb_krb5_principal_get_comp_string in dbglue.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agos4-kdc/db-glue: use principal_comp_str{case}cmp.
Günther Deschner [Fri, 16 May 2014 09:44:02 +0000 (11:44 +0200)]
s4-kdc/db-glue: use principal_comp_str{case}cmp.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agos4-kdc/db-glue: add principal_comp_str{case}cmp
Günther Deschner [Thu, 15 May 2014 13:57:06 +0000 (15:57 +0200)]
s4-kdc/db-glue: add principal_comp_str{case}cmp

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agos4-kdc: pass down only a samba_kdc_entry to samba_krbtgt_is_in_db().
Günther Deschner [Fri, 9 May 2014 22:49:44 +0000 (00:49 +0200)]
s4-kdc: pass down only a samba_kdc_entry to samba_krbtgt_is_in_db().

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agos4-kdc: pass down only a samba_kdc_entry to samba_kdc_get_pac_blob().
Günther Deschner [Fri, 9 May 2014 22:26:21 +0000 (00:26 +0200)]
s4-kdc: pass down only a samba_kdc_entry to samba_kdc_get_pac_blob().

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agos4-kdc: pass down only a samba_kdc_entry to samba_princ_needs_pac().
Günther Deschner [Fri, 9 May 2014 21:26:42 +0000 (23:26 +0200)]
s4-kdc: pass down only a samba_kdc_entry to samba_princ_needs_pac().

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agos4-kdc/db_glue: pass down only a samba_kdc_entry to samba_kdc_check_s4u2proxy().
Günther Deschner [Fri, 9 May 2014 12:58:08 +0000 (14:58 +0200)]
s4-kdc/db_glue: pass down only a samba_kdc_entry to samba_kdc_check_s4u2proxy().

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agos4-kdc/db_glue: pass down only a samba_kdc_entry to samba_kdc_check_pkinit_ms_upn_mat...
Günther Deschner [Fri, 9 May 2014 12:56:22 +0000 (14:56 +0200)]
s4-kdc/db_glue: pass down only a samba_kdc_entry to samba_kdc_check_pkinit_ms_upn_match().

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agos4-kdc/db_glue: pass down only a samba_kdc_entry to samba_kdc_check_s4u2self().
Günther Deschner [Fri, 9 May 2014 12:54:23 +0000 (14:54 +0200)]
s4-kdc/db_glue: pass down only a samba_kdc_entry to samba_kdc_check_s4u2self().

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agos4-kdc: build some kdc components only for Heimdal KDCs.
Günther Deschner [Thu, 8 May 2014 13:15:40 +0000 (15:15 +0200)]
s4-kdc: build some kdc components only for Heimdal KDCs.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agolib/krb5_wrap: provide KRB5KDC_ERR_KEY_EXPIRED error code matching MIT.
Günther Deschner [Thu, 8 May 2014 12:47:05 +0000 (14:47 +0200)]
lib/krb5_wrap: provide KRB5KDC_ERR_KEY_EXPIRED error code matching MIT.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agos4-kdc/db_glue: workaround different CLIENT_NAME_MISMATCH error codes.
Günther Deschner [Thu, 8 May 2014 12:42:20 +0000 (14:42 +0200)]
s4-kdc/db_glue: workaround different CLIENT_NAME_MISMATCH error codes.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agolibrpc/ndr_nbt: we need to keep a trailing '.' in the last component of an nbt_string
Stefan Metzmacher [Wed, 25 Mar 2015 15:04:06 +0000 (15:04 +0000)]
librpc/ndr_nbt: we need to keep a trailing '.' in the last component of an nbt_string

Windows uses a username of 'domain.example.com.' as username and we need to
return it that way in the NETLOGON_SAM_LOGON_RESPONSE_EX reply.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agolsa.idl: add LSA_POLICY_NOTIFICATION to LSA_POLICY_ALL_ACCESS
Stefan Metzmacher [Wed, 25 Mar 2015 19:15:42 +0000 (20:15 +0100)]
lsa.idl: add LSA_POLICY_NOTIFICATION to LSA_POLICY_ALL_ACCESS

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos4:selftest: run rpc.netlogon.admin against also ad_dc
Stefan Metzmacher [Mon, 23 Mar 2015 19:37:23 +0000 (20:37 +0100)]
s4:selftest: run rpc.netlogon.admin against also ad_dc

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agotorture: Run lsa.trusted.domains auth tests against samba4
Andrew Bartlett [Tue, 10 Mar 2015 03:23:40 +0000 (16:23 +1300)]
torture: Run lsa.trusted.domains auth tests against samba4

We only need to skip th CreateTrustedDomainEx, which the docs strongly suggested not to use
in any case.

Andrew Bartlett

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agotorture-lsa: Allow rpc.lsa.trusted.domains to run successfully
Andrew Bartlett [Tue, 10 Mar 2015 03:04:30 +0000 (16:04 +1300)]
torture-lsa: Allow rpc.lsa.trusted.domains to run successfully

We need to create a new binding, as the old binding has the wrong pipe in it (lsa, not netlogon).

Otherwise, we try to bind using the LSA UUID on the netlogon pipe, and Samba rejects that

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos4:torture/rpc: use torture_skip() if torture:Forest_Trust_Dom2_Binding isn't specifi...
Stefan Metzmacher [Tue, 10 Mar 2015 09:14:29 +0000 (10:14 +0100)]
s4:torture/rpc: use torture_skip() if torture:Forest_Trust_Dom2_Binding isn't specified for rpc.lsa.forest.trust

We should exit 0 in this case, as it's not really an error.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos4:torture/rpc: test the old password in test_validate_trust() for rpc.lsa.forest...
Stefan Metzmacher [Tue, 10 Mar 2015 09:14:29 +0000 (10:14 +0100)]
s4:torture/rpc: test the old password in test_validate_trust() for rpc.lsa.forest.trust

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos4:torture/rpc: really use LSA_TRUST_ATTRIBUTE_FOREST_TRANSITIVE in rpc.lsa.forest...
Stefan Metzmacher [Tue, 10 Mar 2015 09:14:29 +0000 (10:14 +0100)]
s4:torture/rpc: really use LSA_TRUST_ATTRIBUTE_FOREST_TRANSITIVE in rpc.lsa.forest.trust

We really want to test forest trust and not external trusts here!

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos4:torture/rpc: use torture_assert*() macros for rpc.lsa.forest.trust
Stefan Metzmacher [Tue, 10 Mar 2015 09:14:29 +0000 (10:14 +0100)]
s4:torture/rpc: use torture_assert*() macros for rpc.lsa.forest.trust

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos4:torture/rpc: fix test_EnumTrustDomEx() with existing domains
Stefan Metzmacher [Mon, 23 Mar 2015 23:16:29 +0000 (00:16 +0100)]
s4:torture/rpc: fix test_EnumTrustDomEx() with existing domains

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos4:rpc_server/lsa: correctly set *r->out.resume_handle with NT_STATUS_OK in lsa_EnumT...
Stefan Metzmacher [Tue, 24 Mar 2015 01:13:10 +0000 (02:13 +0100)]
s4:rpc_server/lsa: correctly set *r->out.resume_handle with NT_STATUS_OK in lsa_EnumTrustedDomainsEx()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos4:torture/rpc: use unique sids and names for trusted domains
Stefan Metzmacher [Mon, 23 Mar 2015 22:15:45 +0000 (23:15 +0100)]
s4:torture/rpc: use unique sids and names for trusted domains

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos4:torture/rpc: sync test_LogonControl2Ex with test_LogonControl2
Stefan Metzmacher [Mon, 23 Mar 2015 12:30:11 +0000 (13:30 +0100)]
s4:torture/rpc: sync test_LogonControl2Ex with test_LogonControl2

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos4:torture/rpc: let rpc.netlogon.admin pass against windows 2012r2
Stefan Metzmacher [Mon, 23 Mar 2015 15:01:31 +0000 (16:01 +0100)]
s4:torture/rpc: let rpc.netlogon.admin pass against windows 2012r2

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos3:rpc_server/netlogon: improve the netr_LogonControl*() error returns
Stefan Metzmacher [Tue, 24 Mar 2015 12:29:14 +0000 (13:29 +0100)]
s3:rpc_server/netlogon: improve the netr_LogonControl*() error returns

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos4:torture/rpc: let test_LogonControl() also accept WERR_NOT_SUPPORTED for NETLOGON_C...
Stefan Metzmacher [Mon, 23 Mar 2015 14:32:59 +0000 (15:32 +0100)]
s4:torture/rpc: let test_LogonControl() also accept WERR_NOT_SUPPORTED for NETLOGON_CONTROL_TRUNCATE_LOG

There's no reason to have this implemented in samba.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos4:torture/rpc: don't use the same names for 3 different tests
Stefan Metzmacher [Mon, 23 Mar 2015 15:02:19 +0000 (16:02 +0100)]
s4:torture/rpc: don't use the same names for 3 different tests

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agolibcli/util: let WERR_UNKNOWN_LEVEL be an alias to WERR_INVALID_LEVEL
Stefan Metzmacher [Mon, 23 Mar 2015 10:32:55 +0000 (11:32 +0100)]
libcli/util: let WERR_UNKNOWN_LEVEL be an alias to WERR_INVALID_LEVEL

WERR_INVALID_LEVEL is the documented name that should be printed
in logs.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agonsswitch: improve error messages in wbinfo calls
Stefan Metzmacher [Sat, 21 Mar 2015 16:31:30 +0000 (17:31 +0100)]
nsswitch: improve error messages in wbinfo calls

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos4:heimdal_build: remove allow_warnings=True from HEIMDAL_ASN1()
Stefan Metzmacher [Sat, 21 Mar 2015 09:00:22 +0000 (10:00 +0100)]
s4:heimdal_build: remove allow_warnings=True from HEIMDAL_ASN1()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agoRename SMB2_OP_FIND to SMB2_OP_QUERY_DIRECTORY so that it conforms with the MS docume...
Richard Sharpe [Tue, 24 Mar 2015 14:16:26 +0000 (07:16 -0700)]
Rename SMB2_OP_FIND to SMB2_OP_QUERY_DIRECTORY so that it conforms with the MS document MS-SMB2.

Signed-off-by: Richard Sharpe <rsharpe@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Mar 27 01:24:47 CET 2015 on sn-devel-104

4 years agoMove update-external.sh to third_party/
Jelmer Vernooij [Wed, 25 Mar 2015 11:13:42 +0000 (11:13 +0000)]
Move update-external.sh to third_party/

Signed-Off-By: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agoMerge update-waf.sh into update-external.sh
Jelmer Vernooij [Wed, 25 Mar 2015 11:13:41 +0000 (11:13 +0000)]
Merge update-waf.sh into update-external.sh

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agoMove waf into third_party/.
Jelmer Vernooij [Wed, 25 Mar 2015 11:13:40 +0000 (11:13 +0000)]
Move waf into third_party/.

Signed-Off-By: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agos3: libsmbclient: Add missing talloc stackframe.
Jeremy Allison [Thu, 26 Mar 2015 17:09:46 +0000 (10:09 -0700)]
s3: libsmbclient: Add missing talloc stackframe.

Bug 11177 - no talloc stackframe at ../source3/libsmb/clifsinfo.c:444, leaking memory

https://bugzilla.samba.org/show_bug.cgi?id=11177

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Thu Mar 26 22:21:30 CET 2015 on sn-devel-104

4 years agodocs: fix duplicate word in explanation of parameter 'logging'.
Michael Adam [Thu, 26 Mar 2015 12:45:50 +0000 (13:45 +0100)]
docs: fix duplicate word in explanation of parameter 'logging'.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
4 years agolibnetapi: Fix 241166 Fixing logically dead code
Anoop C S [Thu, 26 Mar 2015 08:35:19 +0000 (14:05 +0530)]
libnetapi: Fix 241166 Fixing logically dead code

Signed-off-by: Anoop C S <achiraya@redhat.com>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Thu Mar 26 17:30:27 CET 2015 on sn-devel-104

4 years agoregistry: Fix 1273042 Identical code for if/else branch
Anoop C S [Thu, 26 Mar 2015 12:36:44 +0000 (18:06 +0530)]
registry: Fix 1273042 Identical code for if/else branch

Signed-off-by: Anoop C S <achiraya@redhat.com>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>