kai/samba-autobuild/.git
17 years agoThis commit was manufactured by cvs2svn to create branch 'SAMBA_3_0'.
cvs2svn Import User [Fri, 19 Mar 2004 17:36:57 +0000 (17:36 +0000)]
This commit was manufactured by cvs2svn to create branch 'SAMBA_3_0'.

17 years agoApply some more of Derrell Lipman's changes.
Richard Sharpe [Fri, 19 Mar 2004 17:36:56 +0000 (17:36 +0000)]
Apply some more of Derrell Lipman's changes.

17 years agoadd --with-libdir and --with-mandir (patch from Guenther Deschner)
Gerald Carter [Fri, 19 Mar 2004 16:59:59 +0000 (16:59 +0000)]
add --with-libdir and --with-mandir (patch from Guenther Deschner)

17 years agoadd --with-libdir and --with-mandir (patch from Guenther Deschner)
Gerald Carter [Fri, 19 Mar 2004 16:58:16 +0000 (16:58 +0000)]
add --with-libdir and --with-mandir (patch from Guenther Deschner)

17 years agobumping version to 3.0.3pre2
Gerald Carter [Fri, 19 Mar 2004 16:23:54 +0000 (16:23 +0000)]
bumping version to 3.0.3pre2

17 years agoupdating release notes & merging Derrel Lipman's libsmbclient patch from HEAD
Gerald Carter [Fri, 19 Mar 2004 16:22:47 +0000 (16:22 +0000)]
updating release notes & merging Derrel Lipman's libsmbclient patch from HEAD

17 years agocleaning up a few compiler warngings
Gerald Carter [Fri, 19 Mar 2004 16:21:50 +0000 (16:21 +0000)]
cleaning up a few compiler warngings

17 years agowrap cli_tdis() in check to make sure we have a valid cnum
Gerald Carter [Fri, 19 Mar 2004 15:52:16 +0000 (15:52 +0000)]
wrap cli_tdis() in check to make sure we have a valid cnum

17 years agoadd privileges support to ldapsam too
Simo Sorce [Fri, 19 Mar 2004 14:31:09 +0000 (14:31 +0000)]
add privileges support to ldapsam too

17 years agobackport from head
Simo Sorce [Fri, 19 Mar 2004 11:28:36 +0000 (11:28 +0000)]
backport from head

17 years agothe buffer must be greater then src string len otherwise bad things happen!
Simo Sorce [Fri, 19 Mar 2004 11:27:14 +0000 (11:27 +0000)]
the buffer must be greater then src string len otherwise bad things happen!

17 years agoFix gcc warnings. Fix mkproto with new type.
Jeremy Allison [Fri, 19 Mar 2004 01:29:18 +0000 (01:29 +0000)]
Fix gcc warnings. Fix mkproto with new type.
Jeremy.

17 years agoFix gcc warnings. Fix mkproto with new type.
Jeremy Allison [Fri, 19 Mar 2004 01:29:14 +0000 (01:29 +0000)]
Fix gcc warnings. Fix mkproto with new type.
Jeremy.

17 years agoMerge from HEAD for Amanda group.
Jeremy Allison [Thu, 18 Mar 2004 23:45:15 +0000 (23:45 +0000)]
Merge from HEAD for Amanda group.
Apply Craig Barratt's fixes to allow multiple exlusion files and patterns.
Jeremy.

17 years agoApply Craig Barratt's fixes to allow multiple exlusion files and patterns.
Richard Sharpe [Thu, 18 Mar 2004 22:29:54 +0000 (22:29 +0000)]
Apply Craig Barratt's fixes to allow multiple exlusion files and patterns.

Much of this was applied by hand because of the changes in the code. However,
it builds and smbclient seems to work still. The Amanda folks are testing
and it seems to work there as well.

17 years agomerge from 3.0...LDAP password lockout support
Jim McDonough [Thu, 18 Mar 2004 20:05:00 +0000 (20:05 +0000)]
merge from 3.0...LDAP password lockout support

17 years agoPassword lockout for LDAP backend. Caches autolock flag, bad count, and
Jim McDonough [Thu, 18 Mar 2004 19:22:51 +0000 (19:22 +0000)]
Password lockout for LDAP backend.  Caches autolock flag, bad count, and
bad time locally, updating the directory only for hitting the policy limit
or resetting.

This needed to be done at the passdb level rather than auth, because some
of the functions need to be supported from tools such as pdbedit.  It was
done at the LDAP backend level instead of generically after discussion,
because of the complexity of inserting it at a higher level.

The login cache read/write/delete is outside of the ldap backend, so it could
easily be called by other backends.  tdbsam won't call it for obvious
reasons, and authors of other backends need to decide if they want to
implement it.

17 years agoBUG 932: ulrich@holeschak.de (Ulrich Holeschak); fix local password change using...
Gerald Carter [Thu, 18 Mar 2004 18:10:30 +0000 (18:10 +0000)]
BUG 932: ulrich@holeschak.de (Ulrich Holeschak); fix local password change using pam_smbpass

17 years agoBUG 932: ulrich@holeschak.de (Ulrich Holeschak); fix local password change using...
Gerald Carter [Thu, 18 Mar 2004 18:09:59 +0000 (18:09 +0000)]
BUG 932: ulrich@holeschak.de (Ulrich Holeschak); fix local password change using pam_smbpass

17 years agoCorrectness patch from fumiya@miraclelinux.com to count characters correctly,
Jeremy Allison [Thu, 18 Mar 2004 17:58:50 +0000 (17:58 +0000)]
Correctness patch from fumiya@miraclelinux.com to count characters correctly,
doesn't affect what got put on the wire.
Jeremy.

17 years agoCorrectness patch from fumiya@miraclelinux.com to count characters correctly,
Jeremy Allison [Thu, 18 Mar 2004 17:58:47 +0000 (17:58 +0000)]
Correctness patch from fumiya@miraclelinux.com to count characters correctly,
doesn't affect what got put on the wire.
Jeremy.

17 years agoCommit Derrell Lipman's changes and fixes to libsmbclient. The build but
Richard Sharpe [Thu, 18 Mar 2004 17:11:52 +0000 (17:11 +0000)]
Commit Derrell Lipman's changes and fixes to libsmbclient. The build but
I have not tested them beyond building. I did fix the two instances of
safe_strxxx that were introduced.

17 years agoupdating release notes in preparation fro 3.0.3pre1
Gerald Carter [Thu, 18 Mar 2004 16:50:01 +0000 (16:50 +0000)]
updating release notes in preparation fro 3.0.3pre1

17 years agoFix sambaUserWorkstations on a Samba DC
Volker Lendecke [Thu, 18 Mar 2004 07:38:56 +0000 (07:38 +0000)]
Fix sambaUserWorkstations on a Samba DC

17 years agoFix sambaUserWorkstations for network samlogons against us as DC. Strip
Volker Lendecke [Thu, 18 Mar 2004 07:37:39 +0000 (07:37 +0000)]
Fix sambaUserWorkstations for network samlogons against us as DC. Strip
the \\ off the workstation.

Volker

17 years agoFix sambaUserWorkstations for network samlogons against us as DC. Strip
Volker Lendecke [Thu, 18 Mar 2004 07:36:36 +0000 (07:36 +0000)]
Fix sambaUserWorkstations for network samlogons against us as DC. Strip
the \\ off the workstation.

Volker

17 years agoTwo little annoyances:
Volker Lendecke [Thu, 18 Mar 2004 07:33:26 +0000 (07:33 +0000)]
Two little annoyances:

net rpc did not inform you if no smbd is running.

I never liked the error message (!) Success! when we established a trust.

Volker

17 years agoTwo little annoyances:
Volker Lendecke [Thu, 18 Mar 2004 07:32:15 +0000 (07:32 +0000)]
Two little annoyances:

net rpc did not inform you if no smbd is running.

I never liked the error message (!) Success! when we established a trust.

Volker

17 years agoAdded a varient of Volker's patch to fix the "self-referrals as anonymous user"
Jeremy Allison [Thu, 18 Mar 2004 02:17:23 +0000 (02:17 +0000)]
Added a varient of Volker's patch to fix the "self-referrals as anonymous user"
problem.
Jeremy.

17 years agoAdded a varient of Volker's patch to fix the "self-referrals as anonymous user"
Jeremy Allison [Thu, 18 Mar 2004 02:17:20 +0000 (02:17 +0000)]
Added a varient of Volker's patch to fix the "self-referrals as anonymous user"
problem.
Jeremy.

17 years agoRemove excess logging when probing for the length of the next mb char.
Jeremy Allison [Wed, 17 Mar 2004 19:23:48 +0000 (19:23 +0000)]
Remove excess logging when probing for the length of the next mb char.
Jeremy.

17 years agoRemove excess logging when probing for the length of the next mb char.
Jeremy Allison [Wed, 17 Mar 2004 19:23:44 +0000 (19:23 +0000)]
Remove excess logging when probing for the length of the next mb char.
Jeremy.

17 years agoasu/syntax/pc_netlink doesn't fill in the pipe name in the rpc_bind response so dont...
Gerald Carter [Wed, 17 Mar 2004 17:39:00 +0000 (17:39 +0000)]
asu/syntax/pc_netlink doesn't fill in the pipe name in the rpc_bind response so dont check for it

17 years agoasu/syntax/pc_netlink doesn't fill in the pipe name in the rpc_bind response so dont...
Gerald Carter [Wed, 17 Mar 2004 17:38:38 +0000 (17:38 +0000)]
asu/syntax/pc_netlink doesn't fill in the pipe name in the rpc_bind response so dont check for it

17 years agoBUG 758 -- patch from jpeach@sgi.com (James Peach); fix pdma build
Gerald Carter [Wed, 17 Mar 2004 17:13:36 +0000 (17:13 +0000)]
BUG 758 -- patch from jpeach@sgi.com (James Peach); fix pdma build

17 years agoBUG 758 -- patch from jpeach@sgi.com (James Peach); fix pdma build
Gerald Carter [Wed, 17 Mar 2004 17:13:26 +0000 (17:13 +0000)]
BUG 758 -- patch from jpeach@sgi.com (James Peach); fix pdma build

17 years agoChange check_path_syntax() to use the new next_mb_char_size() function
Jeremy Allison [Wed, 17 Mar 2004 02:08:31 +0000 (02:08 +0000)]
Change check_path_syntax() to use the new next_mb_char_size() function
to make it generic. Remove the mb-codepage "blacklist". Alexander, please
check this fix as it reverts your blacklist changes, but I'm hoping it
fixes the problem in a more generic way for all charsets. I'm not trying
to trample on your (excellent!) work here, just make things more generic
without special cases.
Jeremy.

17 years agoChange check_path_syntax() to use the new next_mb_char_size() function
Jeremy Allison [Wed, 17 Mar 2004 02:08:27 +0000 (02:08 +0000)]
Change check_path_syntax() to use the new next_mb_char_size() function
to make it generic. Remove the mb-codepage "blacklist". Alexander, please
check this fix as it reverts your blacklist changes, but I'm hoping it
fixes the problem in a more generic way for all charsets. I'm not trying
to trample on your (excellent!) work here, just make things more generic
without special cases.
Jeremy.

17 years agoAdd function next_mb_char_size() that returns a size_t of the number of
Jeremy Allison [Tue, 16 Mar 2004 21:59:20 +0000 (21:59 +0000)]
Add function next_mb_char_size() that returns a size_t of the number of
bytes in the mb character at a pointer. Will be useful in fixing check_path_syntax()
to not use a "blacklist". Also re-added my (C) to reply.c. I mean, really - I've
been adding code to the file for over 10 years and I recognise many of the
fuctions as mine ! :-).
Jeremy.

17 years agoAdd function next_mb_char_size() that returns a size_t of the number of
Jeremy Allison [Tue, 16 Mar 2004 21:59:11 +0000 (21:59 +0000)]
Add function next_mb_char_size() that returns a size_t of the number of
bytes in the mb character at a pointer. Will be useful in fixing check_path_syntax()
to not use a "blacklist". Also re-added my (C) to reply.c. I mean, really - I've
been adding code to the file for over 10 years and I recognise many of the
fuctions as mine ! :-).
Jeremy.

17 years agomerges from 3.0
Gerald Carter [Tue, 16 Mar 2004 20:32:14 +0000 (20:32 +0000)]
merges from 3.0

17 years agofix overlapping memory bug when copying username
Gerald Carter [Tue, 16 Mar 2004 20:28:47 +0000 (20:28 +0000)]
fix overlapping memory bug when copying username

17 years agoBUG 748 - patch from jpeach@sgi.com (James Peach); relax arg parsing to sambalp script
Gerald Carter [Tue, 16 Mar 2004 19:44:40 +0000 (19:44 +0000)]
BUG 748 - patch from jpeach@sgi.com (James Peach); relax arg parsing to sambalp script

17 years agoBUG 768 - patch from jpeach@sgi.com (James Peach); accept profileing arg to init...
Gerald Carter [Tue, 16 Mar 2004 19:43:04 +0000 (19:43 +0000)]
BUG 768 - patch from jpeach@sgi.com (James Peach); accept profileing arg to init script

17 years agoBUG 979 -- fix quota display on AIX; patch from Heinrich.Mislik@univie.ac.at (Heinric...
Gerald Carter [Tue, 16 Mar 2004 19:06:30 +0000 (19:06 +0000)]
BUG 979 -- fix quota display on AIX; patch from Heinrich.Mislik@univie.ac.at (Heinrich Mislik)

17 years agoBUG 979 -- fix quota display on AIX; patch from Heinrich.Mislik@univie.ac.at (Heinric...
Gerald Carter [Tue, 16 Mar 2004 19:06:03 +0000 (19:06 +0000)]
BUG 979 -- fix quota display on AIX; patch from Heinrich.Mislik@univie.ac.at (Heinrich Mislik)

17 years agoBUG 1182: patch from john.klinger@lmco.com (John Klinger) to reanable the -n 'no...
Gerald Carter [Tue, 16 Mar 2004 18:54:09 +0000 (18:54 +0000)]
BUG 1182: patch from   john.klinger@lmco.com (John Klinger) to reanable the -n 'no cache' option for winbindd

17 years agoFix check_path_syntax() for multibyte encodings which have no '\' as second byte.
Alexander Bokovoy [Tue, 16 Mar 2004 17:21:06 +0000 (17:21 +0000)]
Fix check_path_syntax() for multibyte encodings which have no '\' as second byte.
This is intermediate fix as discussed with Jeremy until we move check_path_syntax() to UCS2 internally where all
ambiguity is resolved. Please add other encodings into charcnv.c with such property.

17 years agoFix check_path_syntax() for multibyte encodings which have no '\' as second byte.
Alexander Bokovoy [Tue, 16 Mar 2004 17:18:57 +0000 (17:18 +0000)]
Fix check_path_syntax() for multibyte encodings which have no '\' as second byte.
This is intermediate fix as discussed with Jeremy until we move check_path_syntax() to UCS2 internally where all
ambiguity is resolved. Please add other encodings into charcnv.c with such property.'
'

17 years agomerging print change notify fix from HP appliance. Also might address some one the...
Gerald Carter [Tue, 16 Mar 2004 17:07:18 +0000 (17:07 +0000)]
merging print change notify fix from HP appliance.  Also might address some one the issues in BUG 1007

17 years agomerging print change notify fix from HP appliance. Also might address some one the...
Gerald Carter [Tue, 16 Mar 2004 17:06:11 +0000 (17:06 +0000)]
merging print change notify fix from HP appliance.  Also might address some one the issues in BUG 1007

17 years agoBUG 1165, 1126: Fix bug with secondary groups (security = ads) and winbind use defaul...
Gerald Carter [Tue, 16 Mar 2004 16:44:54 +0000 (16:44 +0000)]
BUG 1165, 1126: Fix bug with secondary groups (security = ads) and winbind use default domain = yes

17 years agoBUG 1165, 1126: Fix bug with secondary groups (security = ads) and winbind use defaul...
Gerald Carter [Tue, 16 Mar 2004 16:41:54 +0000 (16:41 +0000)]
BUG 1165, 1126: Fix bug with secondary groups (security = ads) and winbind use default domain = yes

17 years agoMake sure we don't clobber the stack when response consists of the empty
Richard Sharpe [Tue, 16 Mar 2004 06:56:20 +0000 (06:56 +0000)]
Make sure we don't clobber the stack when response consists of the empty
string.

17 years agoAvoid mb conversion overflow when sending an announcement.
Jeremy Allison [Tue, 16 Mar 2004 00:10:34 +0000 (00:10 +0000)]
Avoid mb conversion overflow when sending an announcement.
Jeremy.

17 years agoAvoid mb conversion overflow when sending an announcement.
Jeremy Allison [Tue, 16 Mar 2004 00:10:30 +0000 (00:10 +0000)]
Avoid mb conversion overflow when sending an announcement.
Jeremy.

17 years agoUse "unix netbios name" type unstring - 64 bytes long to manipulate netbios
Jeremy Allison [Mon, 15 Mar 2004 21:53:59 +0000 (21:53 +0000)]
Use "unix netbios name" type unstring - 64 bytes long to manipulate netbios
names in nmbd. Allows conversion from dos codepage mb strings (ie. SJIS) to
expand to utf8 size on read.
Jeremy.

17 years agoUse "unix netbios name" type unstring - 64 bytes long to manipulate netbios
Jeremy Allison [Mon, 15 Mar 2004 21:45:45 +0000 (21:45 +0000)]
Use "unix netbios name" type unstring - 64 bytes long to manipulate netbios
names in nmbd. Allows conversion from dos codepage mb strings (ie. SJIS) to
expand to utf8 size on read.
Jeremy.

17 years agoremoving extra comma in --with-fhs
Gerald Carter [Mon, 15 Mar 2004 16:20:22 +0000 (16:20 +0000)]
removing extra comma in --with-fhs

17 years agoremoving extra comma in --with-fhs
Gerald Carter [Mon, 15 Mar 2004 16:20:03 +0000 (16:20 +0000)]
removing extra comma in --with-fhs

17 years agomore fixes from 3.0
Gerald Carter [Mon, 15 Mar 2004 16:17:51 +0000 (16:17 +0000)]
more fixes from 3.0

17 years agoinclude swatdir in 'make showlayout'
Gerald Carter [Mon, 15 Mar 2004 16:14:04 +0000 (16:14 +0000)]
include swatdir in 'make showlayout'

17 years agosync small fixes from 3.0 and fix compiler warning in priv code
Gerald Carter [Mon, 15 Mar 2004 16:12:52 +0000 (16:12 +0000)]
sync small fixes from 3.0 and fix compiler warning in priv code

17 years agofix byte ordering problem when storing the updating pid for the lpq cache; was causin...
Gerald Carter [Mon, 15 Mar 2004 15:16:29 +0000 (15:16 +0000)]
fix byte ordering problem when storing the updating pid for the lpq cache; was causing an abort in process_exists() on solaris

17 years agofix byte ordering problem when storing the updating pid for the lpq cache; was causin...
Gerald Carter [Mon, 15 Mar 2004 15:06:33 +0000 (15:06 +0000)]
fix byte ordering problem when storing the updating pid for the lpq cache; was causing an abort in process_exists() on solaris

17 years agoOk, one of the latest cleanups did too much... :-)
Volker Lendecke [Sun, 14 Mar 2004 11:15:37 +0000 (11:15 +0000)]
Ok, one of the latest cleanups did too much... :-)

Re-add adding the local aliases to winbindd_getgroups.

Volker

17 years agoClean up a bit :-)
Volker Lendecke [Sun, 14 Mar 2004 10:36:07 +0000 (10:36 +0000)]
Clean up a bit :-)

Volker

17 years agoFix 'getent group aliasname', this did not look in pdb.
Volker Lendecke [Sun, 14 Mar 2004 10:28:21 +0000 (10:28 +0000)]
Fix 'getent group aliasname', this did not look in pdb.

17 years agoAdd and delete aliases via srv_samr_nt. For that I added a RID allocation call
Volker Lendecke [Sun, 14 Mar 2004 10:24:19 +0000 (10:24 +0000)]
Add and delete aliases via srv_samr_nt. For that I added a RID allocation call
to winbindd. idmap_allocate_rid wants information about whether this will be a
user or a group, I did not export this to the winbind interface.

The reason for idmap to get that info is to keep consistent with the
algorithmic convention to alloc only even rids for users and odd rids for
groups. I'm not fully convinced that this really gains us anything. Any real
good arguments?

Volker

17 years agoWhen trying to remove a user from a group, winbind should be informed
Volker Lendecke [Sun, 14 Mar 2004 07:16:05 +0000 (07:16 +0000)]
When trying to remove a user from a group, winbind should be informed
about the user and group...

Volker

17 years agoWhen trying to remove a user from a group, winbind should be informed
Volker Lendecke [Sun, 14 Mar 2004 07:15:39 +0000 (07:15 +0000)]
When trying to remove a user from a group, winbind should be informed
about the user and group...

Volker

17 years agoMerge from 3.0
Tim Potter [Sun, 14 Mar 2004 03:47:55 +0000 (03:47 +0000)]
Merge from 3.0

17 years agoUse possessive in message asking for user's password.
Tim Potter [Sun, 14 Mar 2004 03:47:03 +0000 (03:47 +0000)]
Use possessive in message asking for user's password.

17 years agoMake alias membership maintainable via net rpc group add/delmem. Alias
Volker Lendecke [Sat, 13 Mar 2004 17:57:24 +0000 (17:57 +0000)]
Make alias membership maintainable via net rpc group add/delmem. Alias
creation and deletion still has to be done as well as a 'net alias' command.

Volker

17 years agoRest of my winbindd_passdb alias support
Volker Lendecke [Sat, 13 Mar 2004 17:38:07 +0000 (17:38 +0000)]
Rest of my winbindd_passdb alias support

17 years agoAdd alias support to winbindd_passdb. Sorry, Simo, this does not leave too
Volker Lendecke [Sat, 13 Mar 2004 17:35:47 +0000 (17:35 +0000)]
Add alias support to winbindd_passdb. Sorry, Simo, this does not leave too
much of your winbindd_passdb, users are currently not provided by that, only
aliases. Currently the code to maintain that stuff is not yet in, this will be
next, see my next posting to samba-technical.

Volker

17 years agoRemove the prototype for alias support in winbind again. This will be
Volker Lendecke [Sat, 13 Mar 2004 16:43:25 +0000 (16:43 +0000)]
Remove the prototype for alias support in winbind again. This will be
replaced by a winbindd_passdb.c checkin soon.

Volker

17 years agoAdd find_alias, create_alias, delete_alias, get_aliasinfo, set_aliasinfo and
Volker Lendecke [Sat, 13 Mar 2004 16:30:39 +0000 (16:30 +0000)]
Add find_alias, create_alias, delete_alias, get_aliasinfo, set_aliasinfo and
enum_aliases to passdb. create and delete are not yet filled, you have to do
this with net groupmap and net idmap restore.

Volker

17 years agoEnsure we don't truncate strcmps to nstring anymore...
Jeremy Allison [Sat, 13 Mar 2004 02:47:21 +0000 (02:47 +0000)]
Ensure we don't truncate strcmps to nstring anymore...
Jeremy.

17 years agoEnsure we don't truncate strcmps to nstring anymore...
Jeremy Allison [Sat, 13 Mar 2004 02:47:19 +0000 (02:47 +0000)]
Ensure we don't truncate strcmps to nstring anymore...
Jeremy.

17 years agoModified fix for bugid #784. Based on a patch from moriyama@miraclelinux.com (MORIYAM...
Jeremy Allison [Sat, 13 Mar 2004 02:16:26 +0000 (02:16 +0000)]
Modified fix for bugid #784. Based on a patch from moriyama@miraclelinux.com (MORIYAMA Masayuki).
Don't use nstrings to hold workgroup and netbios names. The problem with them is that MB netbios
and workgroup names in unix charset (particularly utf8) may be up to 3x bigger than the name
when represented in dos charset (ie. cp932). So go back to using fstrings for these but
translate into nstrings (ie. 16 byte length values) for transport on the wire.
Jeremy.

17 years agoModified fix for bugid #784. Based on a patch from moriyama@miraclelinux.com (MORIYAM...
Jeremy Allison [Sat, 13 Mar 2004 02:16:21 +0000 (02:16 +0000)]
Modified fix for bugid #784. Based on a patch from moriyama@miraclelinux.com (MORIYAMA Masayuki).
Don't use nstrings to hold workgroup and netbios names. The problem with them is that MB netbios
and workgroup names in unix charset (particularly utf8) may be up to 3x bigger than the name
when represented in dos charset (ie. cp932). So go back to using fstrings for these but
translate into nstrings (ie. 16 byte length values) for transport on the wire.
Jeremy.

17 years agoFirst part of patch from moriyama@miraclelinux.com (MORIYAMA Masayuki) to
Jeremy Allison [Sat, 13 Mar 2004 00:28:55 +0000 (00:28 +0000)]
First part of patch from moriyama@miraclelinux.com (MORIYAMA Masayuki) to
fix up netbios names with mb strings. Includes reformat of libsmb/nmblib.c
so it's readable.
Jeremy.

17 years agoFirst part of patch from moriyama@miraclelinux.com (MORIYAMA Masayuki) to
Jeremy Allison [Sat, 13 Mar 2004 00:28:53 +0000 (00:28 +0000)]
First part of patch from moriyama@miraclelinux.com (MORIYAMA Masayuki) to
fix up netbios names with mb strings. Includes reformat of libsmb/nmblib.c
so it's readable.
Jeremy.

17 years agoif we are truncating to the . we need to start at the beginning in case
Herb Lewis [Fri, 12 Mar 2004 21:35:15 +0000 (21:35 +0000)]
if we are truncating to the . we need to start at the beginning in case
there are multiple "."'s in the name.

This code is protected with an #ifdef TRUNCATE_NETBIOS_NAME and this
is #define'd to 1 directly above. Should we also get rid of the #ifdef?

17 years agoBug report 1079 and fix both from Bert Driehuis.
Christopher R. Hertel [Fri, 12 Mar 2004 20:27:23 +0000 (20:27 +0000)]
Bug report 1079 and fix both from Bert Driehuis.

This is an odd corner case having to do with <1C> group names (DC names).
<1C> group names are called (by MS) "Internet Special Groups", which means
that Microsoft's WINS servers will attempt to handle these names in
something approximating an RFC1001/1002 compliant manner.

The problem being reported here is this:  If an initial registration sent
by one of the group members is lost (network error, whatever) then
subsequent refreshes from that particular machine will also fail.  This
only happens if the name is already active (because of other group
members).

In most cases, we (and MS) handle refreshes as registrations if the name
is not in the database.  In this situation, we missed the corner case.

Bert's fix adds an 'else if' that catches the situation in which a refresh
for an unlisted IP of an active <1C> group name is received.  The refresh
is simply handled as a registration when this happens.

[Note: Committing in HEAD.  I am writing some tools to do registrations
       and refreshes so that I can test this.  I don't have an NT Domain
       for testing so I'm going to have to fudge.  This fix is small (I
       cleaned up some Debug messages and comments in addition to the fix)
       and if you want to test it with 3.0.x you can just copy the HEAD
       version into your 3.0.x tree and recompile.]

17 years agoFix from Robert.Dahlem@gmx.net (Robert Dahlem) for bugid #1048
Jeremy Allison [Fri, 12 Mar 2004 20:24:07 +0000 (20:24 +0000)]
Fix from Robert.Dahlem@gmx.net (Robert Dahlem) for bugid #1048
when mangled names are turned off.
Jeremy.

17 years agoFix from Robert.Dahlem@gmx.net (Robert Dahlem) for bugid #1048
Jeremy Allison [Fri, 12 Mar 2004 20:24:05 +0000 (20:24 +0000)]
Fix from Robert.Dahlem@gmx.net (Robert Dahlem) for bugid #1048
when mangled names are turned off.
Jeremy.

17 years agoFix problems with very long filenames in both smbd and smbclient.
Alexander Bokovoy [Fri, 12 Mar 2004 14:37:37 +0000 (14:37 +0000)]
Fix problems with very long filenames in both smbd and smbclient.
It appears that we pass filename through resolve_wildcards() as pstring and use fstring temporary buffer there.
As result, a long filename in unix charset (UTF-8 by default) can easily expand over 255 bytes while
Windows is able to send to us such names (e.g. Japanese name of ~190 mb chars) which we unable to process through
this small fstring buffer. Tested with W2K and smbclient, Japanese and Cyrillics.

17 years agoFix problems with very long filenames in both smbd and smbclient.
Alexander Bokovoy [Fri, 12 Mar 2004 14:28:14 +0000 (14:28 +0000)]
Fix problems with very long filenames in both smbd and smbclient.
It appears that we pass filename through resolve_wildcards() as pstring and use fstring temporary buffer there.
As result, a long filename in unix charset (UTF-8 by default) can easily expand over 255 bytes while
Windows is able to send to us such names (e.g. Japanese name of ~190 mb chars) which we unable to process through
this small fstring buffer. Tested with W2K and smbclient, Japanese and Cyrillics.

17 years agoFix build after Jeremy -- yet another place where convert_string() wasn't updated
Alexander Bokovoy [Fri, 12 Mar 2004 12:58:49 +0000 (12:58 +0000)]
Fix build after Jeremy -- yet another place where convert_string() wasn't updated

17 years agoFix build after Jeremy -- yet another place where convert_string() wasn't updated
Alexander Bokovoy [Fri, 12 Mar 2004 12:57:39 +0000 (12:57 +0000)]
Fix build after Jeremy -- yet another place where convert_string() wasn't updated

17 years agoFix string overflow due to wrong size calculation
Alexander Bokovoy [Fri, 12 Mar 2004 11:29:13 +0000 (11:29 +0000)]
Fix string overflow due to wrong size calculation

17 years agoFix string overflow due to wrong size calculation
Alexander Bokovoy [Fri, 12 Mar 2004 11:21:50 +0000 (11:21 +0000)]
Fix string overflow due to wrong size calculation

17 years agoAllow msdfs symlink syntax to be more forgiving (it took me ages to remember
Jeremy Allison [Fri, 12 Mar 2004 01:43:25 +0000 (01:43 +0000)]
Allow msdfs symlink syntax to be more forgiving (it took me ages to remember
what it was :-). Allow msdfs links to now look like UNC paths : eg.
sym_link -> msdfs://server/share/path/in/share
or :
sym_link -> msdfs:\\server\share\path\in\share
Jeremy.

17 years agoAllow msdfs symlink syntax to be more forgiving (it took me ages to remember
Jeremy Allison [Fri, 12 Mar 2004 01:43:23 +0000 (01:43 +0000)]
Allow msdfs symlink syntax to be more forgiving (it took me ages to remember
what it was :-). Allow msdfs links to now look like UNC paths : eg.
sym_link -> msdfs://server/share/path/in/share
or :
sym_link -> msdfs:\\server\share\path\in\share
Jeremy.

17 years agoFix bug introduced by Jim (touche :-) :-) - use new smbldap_get_single_pstring
Jeremy Allison [Thu, 11 Mar 2004 23:02:52 +0000 (23:02 +0000)]
Fix bug introduced by Jim (touche :-) :-) - use new smbldap_get_single_pstring
call :-).
Jeremy.

17 years agoRestore the contract on all convert_stringXX() interfaces. Add a "allow_bad_conv"
Jeremy Allison [Thu, 11 Mar 2004 22:59:58 +0000 (22:59 +0000)]
Restore the contract on all convert_stringXX() interfaces. Add a "allow_bad_conv"
boolean parameter that allows broken iconv conversions to work. Gets rid of the
nasty errno checks in mangle_hash2 and check_path_syntax and allows correct
return code checking.
Jeremy.

17 years agoRestore the contract on all convert_stringXX() interfaces. Add a "allow_bad_conv"
Jeremy Allison [Thu, 11 Mar 2004 22:48:24 +0000 (22:48 +0000)]
Restore the contract on all convert_stringXX() interfaces. Add a "allow_bad_conv"
boolean parameter that allows broken iconv conversions to work. Gets rid of the
nasty errno checks in mangle_hash2 and check_path_syntax and allows correct
return code checking.
Jeremy.

17 years agoMerge from 3.0. Fix munged dial in pdb_ldap
Jim McDonough [Thu, 11 Mar 2004 18:10:08 +0000 (18:10 +0000)]
Merge from 3.0.  Fix munged dial in pdb_ldap