kai/samba-autobuild/.git
7 years agodocs: Fix typo.
Karolin Seeger [Wed, 6 Feb 2013 08:08:15 +0000 (09:08 +0100)]
docs: Fix typo.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
7 years agos4-nbt: Ensure source4/ nbt client and server honour 'disable netbios'
Andrew Bartlett [Wed, 6 Feb 2013 09:58:18 +0000 (20:58 +1100)]
s4-nbt: Ensure source4/ nbt client and server honour 'disable netbios'

Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sun Feb 17 11:25:34 CET 2013 on sn-devel-104

7 years agoFallback to the internal resolver on EAI_FAIL.
Landon Fuller [Sun, 17 Feb 2013 03:57:40 +0000 (22:57 -0500)]
Fallback to the internal resolver on EAI_FAIL.

On Linux, non-RFC 1034-complaint names (such as gc._msdsc.example.org)
will result in the resolver returning the non-POSIX EAI_NODATA. In that
case, the case statement here would fall back on the internal resolver,
allowing resolution to complete successfully.

On FreeBSD, the libc resolver uses the same validation code, but
the POSIX result of EAI_FAIL is returned instead of EAI_NODATA. Since
there was no case for this error code, no fallback to the internal
resolver would occur. This led to replication failing on FreeBSD.

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sun Feb 17 07:06:36 CET 2013 on sn-devel-104

7 years agotdb: Fix a typo
Volker Lendecke [Sat, 16 Feb 2013 12:26:36 +0000 (13:26 +0100)]
tdb: Fix a typo

Signed-off-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Simo Sorce <idra@samba.org>
Autobuild-Date(master): Sat Feb 16 17:13:32 CET 2013 on sn-devel-104

7 years agoFix the maxfids test so that it does not fork lots of processes and so that it works...
Richard Sharpe [Fri, 15 Feb 2013 00:04:24 +0000 (16:04 -0800)]
Fix the maxfids test so that it does not fork lots of processes and so that it works for all cases of maxfids.

Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Feb 15 07:09:59 CET 2013 on sn-devel-104

7 years agotevent: Remove the previous "standard" tevent backend implementation.
Jeremy Allison [Mon, 11 Feb 2013 19:42:08 +0000 (11:42 -0800)]
tevent: Remove the previous "standard" tevent backend implementation.

This was a horrible hybrid of duplicated epoll and select()
code.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Feb 14 22:40:30 CET 2013 on sn-devel-104

7 years agotevent: Add in the new implementation of "standard" tevent backend.
Jeremy Allison [Mon, 11 Feb 2013 19:40:49 +0000 (11:40 -0800)]
tevent: Add in the new implementation of "standard" tevent backend.

Falls back cleanly from epoll -> poll, or uses poll if
epoll not available.

Signed-off-by: Jeremy Allison <jra@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 years agotevent: Add a private function tevent_poll_event_add_fd_internal().
Jeremy Allison [Mon, 11 Feb 2013 19:20:28 +0000 (11:20 -0800)]
tevent: Add a private function tevent_poll_event_add_fd_internal().

Not yet used, but will be called by the "standard"
fallback from epoll -> poll backends.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 years agotevent: make use of tevent_find_ops_byname() in tevent_context_init_byname()
Stefan Metzmacher [Thu, 14 Feb 2013 08:30:31 +0000 (09:30 +0100)]
tevent: make use of tevent_find_ops_byname() in tevent_context_init_byname()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agotevent: make sure tevent_backend_init() only runs once
Stefan Metzmacher [Thu, 14 Feb 2013 08:29:57 +0000 (09:29 +0100)]
tevent: make sure tevent_backend_init() only runs once

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agotevent: Add a utility function tevent_find_ops_byname().
Jeremy Allison [Mon, 11 Feb 2013 18:56:58 +0000 (10:56 -0800)]
tevent: Add a utility function tevent_find_ops_byname().

Returns an event ops struct given a string name. Not
yet used, but will be part of the new "standard" fallback
code.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 years agotevent: Add in the same tevent_re_initialise() fix Metze put in the tevent_poll backend.
Jeremy Allison [Mon, 11 Feb 2013 18:53:15 +0000 (10:53 -0800)]
tevent: Add in the same tevent_re_initialise() fix Metze put in the tevent_poll backend.

We might be called during tevent_re_initialise()
which means we need to free our old additional_data.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 years agotevent: Add in some test code to allow the panic fallback path to be tested.
Jeremy Allison [Mon, 11 Feb 2013 18:52:30 +0000 (10:52 -0800)]
tevent: Add in some test code to allow the panic fallback path to be tested.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 years agotevent: Plumb in the panic fallback code into the epoll_panic() runtime call.
Jeremy Allison [Mon, 11 Feb 2013 18:48:02 +0000 (10:48 -0800)]
tevent: Plumb in the panic fallback code into the epoll_panic() runtime call.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 years agotevent: Add an internal function tevent_epoll_set_panic_fallback().
Jeremy Allison [Mon, 11 Feb 2013 18:43:39 +0000 (10:43 -0800)]
tevent: Add an internal function tevent_epoll_set_panic_fallback().

Can be set externally, allows us to fallback if epoll
fails at runtime.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 years agotevent: pass 'bool replay' to epoll_panic()
Stefan Metzmacher [Thu, 14 Feb 2013 09:58:55 +0000 (10:58 +0100)]
tevent: pass 'bool replay' to epoll_panic()

A fallback panic handler will need to know if
there was an error while waiting for events
(replay=true) or if the error happened on modify
(replay=false).

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agotevent: Ensure we return after every call to epoll_panic().
Jeremy Allison [Mon, 11 Feb 2013 18:38:01 +0000 (10:38 -0800)]
tevent: Ensure we return after every call to epoll_panic().

Currently we can't return from this, but the new fallback
code will change this.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 years agotevent: Preparing to fix "standard" backend fallback. Initialize standard after epoll.
Jeremy Allison [Mon, 11 Feb 2013 18:36:52 +0000 (10:36 -0800)]
tevent: Preparing to fix "standard" backend fallback. Initialize standard after epoll.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 years agodocs: fix typo in serverrole.xml
Samba-JP oota [Thu, 14 Feb 2013 13:55:51 +0000 (22:55 +0900)]
docs: fix typo in serverrole.xml

Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Thu Feb 14 18:43:57 CET 2013 on sn-devel-104

7 years agowaf: Make sure we link against samba-util.
Andreas Schneider [Thu, 14 Feb 2013 11:34:01 +0000 (12:34 +0100)]
waf: Make sure we link against samba-util.

libcmdline-credentials.so needs samba_getpass() from libsamba-util.so,
so we need to link against it.

Reviewed-by: Andrew Bartlet <abartlet@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Feb 14 16:56:29 CET 2013 on sn-devel-104

7 years agos3:idmap_autorid: fix freeing of non-talloced memory (uninitialized pointer) (bug...
Michael Adam [Mon, 11 Feb 2013 21:52:55 +0000 (22:52 +0100)]
s3:idmap_autorid: fix freeing of non-talloced memory (uninitialized pointer) (bug #9653)

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Feb 13 09:51:53 CET 2013 on sn-devel-104

7 years agoAdd a herald with version string to smbtorture
Richard Sharpe [Wed, 6 Feb 2013 21:02:13 +0000 (13:02 -0800)]
Add a herald with version string to smbtorture

Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Richard Sharpe <sharpe@samba.org>
Autobuild-Date(master): Wed Feb 13 08:03:21 CET 2013 on sn-devel-104

7 years agoFix bug 9519 - Samba returns unexpected error on SMB posix open.
Jeremy Allison [Tue, 12 Feb 2013 18:48:09 +0000 (10:48 -0800)]
Fix bug 9519 - Samba returns unexpected error on SMB posix open.

Explicitly ignore bare O_EXCL flags instead of returning INVALID_PARAMETER.
That's what the Linux kernel does.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Jeff Layton <jlayton@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Feb 12 22:59:21 CET 2013 on sn-devel-104

7 years agoFix some cut-and-paste and spelling in debug messages
Guenter Kukkukk [Tue, 12 Feb 2013 04:37:09 +0000 (05:37 +0100)]
Fix some cut-and-paste and spelling in debug messages

Signed-off-by: Guenter Kukkukk <kukks@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Feb 12 07:28:27 CET 2013 on sn-devel-104

7 years agoFix bug #9642 - vfs_afsacl.c won't build.
Jeremy Allison [Sat, 9 Feb 2013 01:08:28 +0000 (17:08 -0800)]
Fix bug #9642 - vfs_afsacl.c won't build.

Add missing mem_ctx argument.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Mon Feb 11 20:24:00 CET 2013 on sn-devel-104

7 years agoImprove the configure tests for aio_suspend to get rid of warnings. Timur provided...
Richard Sharpe [Sat, 9 Feb 2013 03:56:56 +0000 (19:56 -0800)]
Improve the configure tests for aio_suspend to get rid of warnings. Timur provided the wscript method, I added the configure.in correction.

Signed-off-by: Timur Bakeyev <timur@freebsd.org>
Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sat Feb  9 09:24:06 CET 2013 on sn-devel-104

7 years agos3: Make SMB2_GETINFO multi-volume aware.
Ira Cooper [Wed, 6 Feb 2013 13:35:25 +0000 (13:35 +0000)]
s3: Make SMB2_GETINFO multi-volume aware.

Not all shares are a single volume.  Some actually
expose multiple volumes under a single share.  In these
cases showing the amount of space free as the space free
at the base of the directory heirarchy is wrong.

Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Feb  8 21:44:37 CET 2013 on sn-devel-104

7 years agowinbind: Fix an incompatible pointer type warning
Volker Lendecke [Mon, 4 Feb 2013 14:52:49 +0000 (15:52 +0100)]
winbind: Fix an incompatible pointer type warning

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri Feb  8 15:27:51 CET 2013 on sn-devel-104

7 years agodbwrap: Prevent transactions on non-persistent dbs
Volker Lendecke [Fri, 11 Jan 2013 14:32:39 +0000 (15:32 +0100)]
dbwrap: Prevent transactions on non-persistent dbs

dbwrap_ctdb does not allow this anyway. This patch will avoid suprises
when going non-clustered to clustered. Not everybody is developing
against a clustered environment :-)

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 years agotorture: We use transactions for CLEAR_IF_FIRST db
Volker Lendecke [Fri, 11 Jan 2013 16:29:01 +0000 (17:29 +0100)]
torture: We use transactions for CLEAR_IF_FIRST db

This does not work in the ctdb case

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 years agoldb: Add more data test data for one level test cases
Matthieu Patou [Tue, 8 Jan 2013 08:09:32 +0000 (00:09 -0800)]
ldb: Add more data test data for one level test cases

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Feb  8 06:46:40 CET 2013 on sn-devel-104

7 years agoldb: Add tests for the python api
Matthieu Patou [Tue, 8 Jan 2013 08:28:03 +0000 (00:28 -0800)]
ldb: Add tests for the python api

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 years agodsdb-operational: rework the loop for attribute removal
Matthieu Patou [Fri, 28 Dec 2012 02:29:49 +0000 (18:29 -0800)]
dsdb-operational: rework the loop for attribute removal

Instead of doing ldb_in_list size(operational_remove) * (attrs_user +
attr_searched) * number of entries times to get the list of attributes to remove we construct this
list before the search and then use it for every entries.

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 years agoldb: Add more tests related to onelevel search
Matthieu Patou [Sun, 30 Dec 2012 05:48:46 +0000 (21:48 -0800)]
ldb: Add more tests related to onelevel search

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 years agoldb: use strncmp instead of strcmp when comparing the val part
Matthieu Patou [Thu, 13 Dec 2012 10:18:34 +0000 (02:18 -0800)]
ldb: use strncmp instead of strcmp when comparing the val part

val part of a DN's component is DATA_BLOB and nothing insure that it
will be finished by a '\0'

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 years agoldb: make test output more readable
Matthieu Patou [Sun, 30 Dec 2012 00:42:28 +0000 (16:42 -0800)]
ldb: make test output more readable

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 years agoldb-tdb: Document ltdb_index_add1 for more clarity
Matthieu Patou [Mon, 17 Dec 2012 09:45:30 +0000 (01:45 -0800)]
ldb-tdb: Document ltdb_index_add1 for more clarity

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 years agoldb-tdb: Fix a wrong parameter in ltdb_store
Matthieu Patou [Thu, 27 Dec 2012 05:41:52 +0000 (21:41 -0800)]
ldb-tdb: Fix a wrong parameter in ltdb_store

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 years agoldb_tdb: raise level of full index scan message so that it starts to be really visible
Matthieu Patou [Mon, 7 Jan 2013 06:17:26 +0000 (22:17 -0800)]
ldb_tdb: raise level of full index scan message so that it starts to be really visible

We don't want to have to set log level to 4 or 5 AND set the environment
variable to be able to see those log messages

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 years agodsdb-repl: make message more clearer
Matthieu Patou [Wed, 23 Jan 2013 19:33:30 +0000 (11:33 -0800)]
dsdb-repl: make message more clearer

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 years agoreplmetadata: raise msg level for conflict resolution so that we don't polute logs
Matthieu Patou [Sat, 26 Jan 2013 09:53:41 +0000 (01:53 -0800)]
replmetadata: raise msg level for conflict resolution so that we don't polute logs

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 years agodsdb-repl: do not ask to add ref when doing getncchange for an exop
Matthieu Patou [Sat, 26 Jan 2013 09:53:28 +0000 (01:53 -0800)]
dsdb-repl: do not ask to add ref when doing getncchange for an exop

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 years agodsdb-cracknames: Fix potential double free and memory leaks
Matthieu Patou [Mon, 24 Dec 2012 18:01:30 +0000 (10:01 -0800)]
dsdb-cracknames: Fix potential double free and memory leaks

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 years agoBUG 9633: Recursive mget should continue on EPERM.
David Disseldorp [Mon, 4 Feb 2013 18:04:39 +0000 (19:04 +0100)]
BUG 9633: Recursive mget should continue on EPERM.

Regression introduced by 14ff2e8de9bd8d0064762234555260f5eea643fe.
When downloading files recursively, smbclient halts if it encounters
a folder to which it does not have permission to traverse.

Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Feb  7 15:50:36 CET 2013 on sn-devel-104

7 years agos3-rpc_server: Fix password encoding in _netr_ServerGetTrustInfo().
Sumit Bose [Mon, 4 Feb 2013 12:15:18 +0000 (13:15 +0100)]
s3-rpc_server: Fix password encoding in _netr_ServerGetTrustInfo().

Reviewed-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
7 years agos3-rpc_server: Dont wipe out ref pointers in _netr_ServerGetTrustInfo().
Günther Deschner [Tue, 11 Dec 2012 08:29:37 +0000 (09:29 +0100)]
s3-rpc_server: Dont wipe out ref pointers in _netr_ServerGetTrustInfo().

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
7 years agoautoconf: rename pdb_ldap module to pdb_ldapsam
Alexander Bokovoy [Wed, 6 Feb 2013 10:22:12 +0000 (12:22 +0200)]
autoconf: rename pdb_ldap module to pdb_ldapsam

Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Alexander Bokovoy <ab@samba.org>
Autobuild-Date(master): Wed Feb  6 13:32:53 CET 2013 on sn-devel-104

7 years agosource3/wscript: support 'pdb_ldap' module in configure
Alexander Bokovoy [Wed, 6 Feb 2013 08:43:16 +0000 (10:43 +0200)]
source3/wscript: support 'pdb_ldap' module in configure

While PASSDB module ldapsam is called pdb_ldapsam internally,
support specifying 'pdb_ldap' during configure step.

This should make transition to pdb_ldapsam transparent to distributions.

Reviewed-by: Andreas Schneider <asn@samba.org>
7 years agoRename pdb_ldap to pdb_ldapsam
Andreas Schneider [Mon, 28 Jan 2013 15:16:42 +0000 (16:16 +0100)]
Rename pdb_ldap to pdb_ldapsam

This patch moves pdb_ldap to pdb_ldapsam unconditionally
and makes possible to load ldapsam.so dynamically

Reviewed-by: Alexander Bokovoy <ab@samba.org>
7 years agoPIDL: fix parsing linemarkers in preprocessor output
Alexander Bokovoy [Wed, 6 Feb 2013 08:17:57 +0000 (10:17 +0200)]
PIDL: fix parsing linemarkers in preprocessor output

When PIDL calls out to C preprocessor to expand IDL files
and parse the output, it filters out linemarkers and line control
information as described in http://gcc.gnu.org/onlinedocs/cpp/Preprocessor-Output.html
and http://gcc.gnu.org/onlinedocs/cpp/Line-Control.html#Line-Control

With gcc 4.8 stdc-predef.h is included automatically and linemarker for the
file has extended flags that PIDL couldn't parse ('system header that needs to
be extern "C" protected for C++')

Thanks to Jakub Jelinek <jakub@redhat.com> for explanation of the linemarker format.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=906517

Reviewed-by: Andreas Schneider <asn@samba.org>
7 years agodocs: Add missing ")".
Samba-JP oota [Wed, 6 Feb 2013 08:04:16 +0000 (09:04 +0100)]
docs: Add missing ")".

Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Karolin Seeger <kseeger@samba.org>
Autobuild-User(master): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(master): Wed Feb  6 10:47:11 CET 2013 on sn-devel-104

7 years agos3:auth small optimization in create_token_from_sid
Christian Ambach [Tue, 29 Jan 2013 16:19:17 +0000 (17:19 +0100)]
s3:auth small optimization in create_token_from_sid

save some calls to lp_idmap_default_range(), calling it
once is enough

Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Tue Feb  5 19:14:25 CET 2013 on sn-devel-104

7 years agos3:net: reduce indentation in net idmap delete for symmetry and consistency
Michael Adam [Wed, 30 Jan 2013 14:50:52 +0000 (15:50 +0100)]
s3:net: reduce indentation in net idmap delete for symmetry and consistency

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Christian Ambach <ambi@samba.org>
7 years agos3:net: introduce a talloc stackframe for net idmap delete
Michael Adam [Wed, 30 Jan 2013 14:46:47 +0000 (15:46 +0100)]
s3:net: introduce a talloc stackframe for net idmap delete

this simplifies the freeing at the end

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Christian Ambach <ambi@samba.org>
7 years agos3:net_idmap_delete do not lock two records at the same time
Christian Ambach [Fri, 7 Dec 2012 12:43:57 +0000 (13:43 +0100)]
s3:net_idmap_delete do not lock two records at the same time

the lock order check will prohibit this and as we are running inside
a transaction there is no need to lock the records before deleting them

Pair-Programmed-With: Michael Adam <obnox@samba.org>

Signed-off-by: Christian Ambach <ambi@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos3:net idmap: use lp_idmap_default_backend() now that we have it.
Michael Adam [Tue, 29 Jan 2013 12:34:26 +0000 (13:34 +0100)]
s3:net idmap: use lp_idmap_default_backend() now that we have it.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Christian Ambach <ambi@samba.org>
7 years agos3:param: add new lp_idmap_default_backend()
Michael Adam [Tue, 29 Jan 2013 12:26:11 +0000 (13:26 +0100)]
s3:param: add new lp_idmap_default_backend()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Christian Ambach <ambi@samba.org>
7 years agos3:param: introduce new lp_idmap_backend() that takes the domain
Michael Adam [Tue, 29 Jan 2013 12:24:20 +0000 (13:24 +0100)]
s3:param: introduce new lp_idmap_backend() that takes the domain

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Christian Ambach <ambi@samba.org>
7 years agos3:param: add a comment
Michael Adam [Mon, 28 Jan 2013 14:41:13 +0000 (15:41 +0100)]
s3:param: add a comment

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Christian Ambach <ambi@samba.org>
7 years agos3:param: remove unused function lp_idmap_backend()
Michael Adam [Mon, 28 Jan 2013 13:35:53 +0000 (14:35 +0100)]
s3:param: remove unused function lp_idmap_backend()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Christian Ambach <ambi@samba.org>
7 years agos3:net idmap: remove call to lp_idmap_backend() - this is useless.
Michael Adam [Mon, 28 Jan 2013 13:29:21 +0000 (14:29 +0100)]
s3:net idmap: remove call to lp_idmap_backend() - this is useless.

The variable behind lp_idmap_backend() is never set.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Christian Ambach <ambi@samba.org>
7 years agos3:param: remove unused functions lp_idmap_uid() and lp_idmap_gid()
Michael Adam [Mon, 28 Jan 2013 13:21:44 +0000 (14:21 +0100)]
s3:param: remove unused functions lp_idmap_uid() and lp_idmap_gid()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Christian Ambach <ambi@samba.org>
7 years agos3:auth: use new lp_idmap_default_range() instead of lp_idmap_gid() in create_token_f...
Michael Adam [Mon, 28 Jan 2013 15:45:30 +0000 (16:45 +0100)]
s3:auth: use new lp_idmap_default_range() instead of lp_idmap_gid() in create_token_from_sid()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Christian Ambach <ambi@samba.org>
7 years agos3:param: add utility function lp_idmap_default_range()
Michael Adam [Mon, 28 Jan 2013 15:35:50 +0000 (16:35 +0100)]
s3:param: add utility function lp_idmap_default_range()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Christian Ambach <ambi@samba.org>
7 years agos3:param: add a utility function lp_idmap_range() to get the configured range for...
Michael Adam [Mon, 28 Jan 2013 15:31:23 +0000 (16:31 +0100)]
s3:param: add a utility function lp_idmap_range() to get the configured range for a given domain.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Christian Ambach <ambi@samba.org>
7 years agos3:param: remove an old comment (that is not up-to date any more)
Michael Adam [Mon, 28 Jan 2013 13:18:48 +0000 (14:18 +0100)]
s3:param: remove an old comment (that is not up-to date any more)

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Christian Ambach <ambi@samba.org>
7 years agotdb: Remove "header" from tdb_context
Volker Lendecke [Thu, 20 Dec 2012 15:36:02 +0000 (16:36 +0100)]
tdb: Remove "header" from tdb_context

header.hash_size was the only thing we ever referenced outside of
tdb_open_ex and its direct callees. So this shrinks the tdb_context by
164 bytes.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Feb  5 13:18:28 CET 2013 on sn-devel-104

7 years agotdb: Pass argument "header" to check_header_hash
Volker Lendecke [Thu, 20 Dec 2012 15:14:23 +0000 (16:14 +0100)]
tdb: Pass argument "header" to check_header_hash

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 years agotdb: Pass argument "header" to tdb_new_database
Volker Lendecke [Thu, 20 Dec 2012 15:14:23 +0000 (16:14 +0100)]
tdb: Pass argument "header" to tdb_new_database

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 years agosamba-tool/domain provision: add support for utf-8 passwords for --adminpass
Stefan Metzmacher [Mon, 4 Feb 2013 10:41:39 +0000 (11:41 +0100)]
samba-tool/domain provision: add support for utf-8 passwords for --adminpass

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Mon Feb  4 18:54:32 CET 2013 on sn-devel-104

7 years agosamba-tool/user setpassword: fix help message
Stefan Metzmacher [Mon, 4 Feb 2013 12:35:48 +0000 (13:35 +0100)]
samba-tool/user setpassword: fix help message

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
7 years agos4:scripting/python: add support for utf-8 passwords from the command line
Stefan Metzmacher [Mon, 4 Feb 2013 10:41:39 +0000 (11:41 +0100)]
s4:scripting/python: add support for utf-8 passwords from the command line

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
7 years agos3:dbrwap_ctdb: ZERO_STRUCT(rec) just to be sure in traverse_persistent_callback_read()
Michael Adam [Mon, 4 Feb 2013 12:10:34 +0000 (13:10 +0100)]
s3:dbrwap_ctdb: ZERO_STRUCT(rec) just to be sure in traverse_persistent_callback_read()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 years agos3:dbwrap_ctdb: ZERO_STRUCT(rec) just to be sure in traverse_read_callback()
Michael Adam [Mon, 4 Feb 2013 12:09:46 +0000 (13:09 +0100)]
s3:dbwrap_ctdb: ZERO_STRUCT(rec) just to be sure in traverse_read_callback()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 years agos3:dbwrap_ctdb: add "db_context" to "db_record"
Stefan Metzmacher [Fri, 1 Feb 2013 07:48:00 +0000 (02:48 -0500)]
s3:dbwrap_ctdb: add "db_context" to "db_record"

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
7 years agos3:dbwrap_ctdb: setup result->name in db_open_ctdb()
Stefan Metzmacher [Fri, 1 Feb 2013 08:14:16 +0000 (03:14 -0500)]
s3:dbwrap_ctdb: setup result->name in db_open_ctdb()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
7 years agolib/dbwrap: talloc_strdup() name in db_open_file()
Stefan Metzmacher [Fri, 1 Feb 2013 08:13:35 +0000 (03:13 -0500)]
lib/dbwrap: talloc_strdup() name in db_open_file()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
7 years agolib/util: improve check_password_quality() to handle utf8
Stefan Metzmacher [Mon, 4 Feb 2013 07:45:48 +0000 (08:45 +0100)]
lib/util: improve check_password_quality() to handle utf8

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
7 years agodsdb/util: rework samdb_check_password() to support utf8
Stefan Metzmacher [Mon, 4 Feb 2013 08:19:54 +0000 (09:19 +0100)]
dsdb/util: rework samdb_check_password() to support utf8

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
7 years agodsdb/password_hash: rename variable 'stat' to 'vstat'
Stefan Metzmacher [Mon, 4 Feb 2013 08:47:31 +0000 (09:47 +0100)]
dsdb/password_hash: rename variable 'stat' to 'vstat'

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
7 years agodsdb/password_hash: make sure that io->n.cleartext_utf8.data is a null terminated...
Stefan Metzmacher [Mon, 4 Feb 2013 08:18:59 +0000 (09:18 +0100)]
dsdb/password_hash: make sure that io->n.cleartext_utf8.data is a null terminated string

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
7 years agos3: use generate_random_password() instead of generate_random_str()
Stefan Metzmacher [Fri, 1 Feb 2013 12:14:05 +0000 (13:14 +0100)]
s3: use generate_random_password() instead of generate_random_str()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
7 years agoRevert "selftest: skip smb2.ioctl tests on ntvfs"
David Disseldorp [Sun, 3 Feb 2013 16:06:37 +0000 (17:06 +0100)]
Revert "selftest: skip smb2.ioctl tests on ntvfs"

This reverts commit cf27c2fbb6e7422cb962f4c63a53515321c65a70.

The following concerns were raised with regard to the relocation of
tests from selftest/knownfail to selftest/skip.

Andrew Bartlett <abartlet@samba.org> wrote:

Unless there is some entirely undesirable side-effect, this patch throws
away valuable testing, because it removes the test of the testsuite for
failure (ie, does the test work!), and it removes the documentation of
the difference between the servers (if someone did add some this to the
ntvfs server, it would never be tested).

It also removes a test that if this unimplemented functionality is
called, that we don't crash and die.

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Mon Feb  4 15:57:29 CET 2013 on sn-devel-104

7 years agos3:modules remove gpfs_getacl_alloc
Christian Ambach [Tue, 8 Jan 2013 16:10:27 +0000 (17:10 +0100)]
s3:modules remove gpfs_getacl_alloc

last caller has gone

Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Feb  4 14:10:08 CET 2013 on sn-devel-104

7 years agos3:modules use vfs_gpfs_getacl in gpfsacl_get_posix_acl
Christian Ambach [Tue, 8 Jan 2013 16:10:10 +0000 (17:10 +0100)]
s3:modules use vfs_gpfs_getacl in gpfsacl_get_posix_acl

as preparation to remove gpfs_getacl_alloc()

Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 years agos3:modules use vfs_gpfs_getacl in gpfsacl_set_nt_acl_internal
Christian Ambach [Tue, 8 Jan 2013 16:07:09 +0000 (17:07 +0100)]
s3:modules use vfs_gpfs_getacl in gpfsacl_set_nt_acl_internal

as preparation to remove gpfs_getacl_alloc()

Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 years agos3:modules use vfs_gpfs_getacl in gpfs_get_nfs4_acl
Christian Ambach [Tue, 8 Jan 2013 15:54:16 +0000 (16:54 +0100)]
s3:modules use vfs_gpfs_getacl in gpfs_get_nfs4_acl

as preparation to remove gpfs_getacl_alloc()

Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 years agos3:torture/vfstest add memreport option
Christian Ambach [Fri, 16 Nov 2012 21:58:06 +0000 (22:58 +0100)]
s3:torture/vfstest add memreport option

this will run a talloc_report_full on the talloc stackframe after each command

Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 years agos3:torture/vfstest implement sys_acl_blob_get_fd
Christian Ambach [Thu, 15 Nov 2012 14:25:52 +0000 (15:25 +0100)]
s3:torture/vfstest implement sys_acl_blob_get_fd

Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 years agos3:torture/vfstest implement sys_acl_blob_get_file
Christian Ambach [Thu, 15 Nov 2012 14:19:07 +0000 (15:19 +0100)]
s3:torture/vfstest implement sys_acl_blob_get_file

Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 years agos3:vfs_gpfs use non_posix_sys_acl_blob_get_*_helper
Christian Ambach [Tue, 30 Oct 2012 12:44:40 +0000 (13:44 +0100)]
s3:vfs_gpfs use non_posix_sys_acl_blob_get_*_helper

use the helper functions to return the blob based on the
raw GPFS ACL blob (if it is a NFSv4 ACL). If not, fall back
to the POSIX ACL code

Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 years agos3:vfs_gpfs add a generic vfs_gpfs_getacl function
Christian Ambach [Mon, 5 Nov 2012 18:26:57 +0000 (19:26 +0100)]
s3:vfs_gpfs add a generic vfs_gpfs_getacl function

in contrast to gpfs_getacl_alloc which always puts the
ACL on talloc_tos(), this one allows to specify the memory
context and if the caller is interested in the raw ACL blob
or a structured version

Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 years agos3:modules/vfs_gpfs add GPFS_GETACL_NATIVE define
Christian Ambach [Tue, 8 Jan 2013 14:15:02 +0000 (15:15 +0100)]
s3:modules/vfs_gpfs add GPFS_GETACL_NATIVE define

this is not in the official GPFS header file, but can be found
in the GPL'd kernel module sources

Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 years agos3:modules/non_posix_acls: only stat if we do not have it cached
Christian Ambach [Tue, 30 Oct 2012 12:43:59 +0000 (13:43 +0100)]
s3:modules/non_posix_acls: only stat if we do not have it cached

most probably we already have the stat() information

Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 years agos3:autoconf add non_posix_acls to NFS4ACL_OBJ
Christian Ambach [Tue, 30 Oct 2012 09:47:22 +0000 (10:47 +0100)]
s3:autoconf add non_posix_acls to NFS4ACL_OBJ

Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 years agos3:autoconf introduce NFS4ACL_OBJ
Christian Ambach [Tue, 30 Oct 2012 09:45:23 +0000 (10:45 +0100)]
s3:autoconf introduce NFS4ACL_OBJ

use a definition instead of listing it separately

Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 years agos3-waf:modules add non_posix_acls dependency to vfs_gpfs
Christian Ambach [Tue, 8 Jan 2013 16:56:50 +0000 (17:56 +0100)]
s3-waf:modules add non_posix_acls dependency to vfs_gpfs

Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 years agovfs: Add helper function for non posix ACL modules
Andrew Bartlett [Wed, 24 Oct 2012 11:39:59 +0000 (22:39 +1100)]
vfs: Add helper function for non posix ACL modules

This handles the stat, and fills in the pre-supplied blob into a
wrapper sturcture that can then be returned to vfs_acl_common for
hashing.

Andrew Bartlett

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Christian Ambach <ambi@samba.org>
7 years agoidl: Provide a common wrapper for the data to hash for a non-POSIX ACL
Andrew Bartlett [Wed, 24 Oct 2012 06:06:33 +0000 (17:06 +1100)]
idl: Provide a common wrapper for the data to hash for a non-POSIX ACL

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Christian Ambach <ambi@samba.org>
7 years agoselftest: add a test that demonstrates how new ACL blob code helps
Christian Ambach [Wed, 30 Jan 2013 10:00:48 +0000 (11:00 +0100)]
selftest: add a test that demonstrates how new ACL blob code helps

this test shows that a change to POSIX ACL->SD mapping behavior does not invalidate the stored SD

Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>