kai/samba-autobuild/.git
12 years agodrsuapi: rerun make idl and add drsblobs generated files.
Günther Deschner [Thu, 26 Jun 2008 10:07:07 +0000 (12:07 +0200)]
drsuapi: rerun make idl and add drsblobs generated files.

Guenther

12 years agodrsuapi: add drsblobs.idl from samba4.
Günther Deschner [Thu, 26 Jun 2008 09:57:37 +0000 (11:57 +0200)]
drsuapi: add drsblobs.idl from samba4.

Guenther

12 years agonet_vampire: add some error output to libnet_dssync.
Günther Deschner [Thu, 26 Jun 2008 08:22:40 +0000 (10:22 +0200)]
net_vampire: add some error output to libnet_dssync.

Guenther

12 years agoerrors: add WERR_DS_DRA_BAD_NC and WERR_DS_DRA_BAD_DN.
Günther Deschner [Thu, 26 Jun 2008 07:49:13 +0000 (09:49 +0200)]
errors: add WERR_DS_DRA_BAD_NC and WERR_DS_DRA_BAD_DN.

Guenther

12 years agoMerge branch 'v3-3-test' of ssh://jra@git.samba.org/data/git/samba into v3-3-test
Jeremy Allison [Wed, 25 Jun 2008 22:24:18 +0000 (15:24 -0700)]
Merge branch 'v3-3-test' of ssh://jra@git.samba.org/data/git/samba into v3-3-test

12 years agoPart of fix for #5551. Split out the group enumeration functions to a BUILTIN and...
Jeremy Allison [Wed, 25 Jun 2008 22:23:32 +0000 (15:23 -0700)]
Part of fix for #5551. Split out the group enumeration functions to a BUILTIN and a Domain
specific version. Stops the domain groups appearing twice.
Jeremy.

12 years agorpcclient: add samr chgpasswd command.
Günther Deschner [Wed, 25 Jun 2008 09:50:50 +0000 (11:50 +0200)]
rpcclient: add samr chgpasswd command.

Guenther

12 years agorpc_client: add rpccli_samr_chgpasswd_user() call.
Günther Deschner [Wed, 25 Jun 2008 09:50:17 +0000 (11:50 +0200)]
rpc_client: add rpccli_samr_chgpasswd_user() call.

Guenther

12 years agorename rpccli_samr_chgpasswd3 to rpccli_samr_chgpasswd_user3.
Günther Deschner [Wed, 25 Jun 2008 19:49:57 +0000 (21:49 +0200)]
rename rpccli_samr_chgpasswd3 to rpccli_samr_chgpasswd_user3.

Guenther

12 years agorename rpccli_samr_chgpasswd_user to rpccli_samr_chgpasswd_user2.
Günther Deschner [Wed, 25 Jun 2008 08:35:59 +0000 (10:35 +0200)]
rename rpccli_samr_chgpasswd_user to rpccli_samr_chgpasswd_user2.

Guenther

12 years agoFinal (hopefully :-) part of fix for bug #5551. Allow passdb backend to enumerate...
Jeremy Allison [Wed, 25 Jun 2008 19:44:18 +0000 (12:44 -0700)]
Final (hopefully :-) part of fix for bug #5551. Allow passdb backend to enumerate domain groups.
Jeremy

12 years agoFix the build
Volker Lendecke [Wed, 25 Jun 2008 14:24:33 +0000 (16:24 +0200)]
Fix the build

12 years agomake parametic options case insensitive
Andrew Tridgell [Wed, 25 Jun 2008 11:27:17 +0000 (21:27 +1000)]
make parametic options case insensitive

This is needed as some options are uppercased internally in Samba, such as the idmap config option
Without this change it is not possible to set these options via net conf which lowercases options

12 years agonetapi: add NetUserChangePassword() example code.
Günther Deschner [Tue, 24 Jun 2008 22:47:17 +0000 (00:47 +0200)]
netapi: add NetUserChangePassword() example code.

Guenther

12 years agonetapi: add NetUserChangePassword() to public headers.
Günther Deschner [Tue, 24 Jun 2008 22:47:41 +0000 (00:47 +0200)]
netapi: add NetUserChangePassword() to public headers.

Guenther

12 years agonetapi: add NetUserChangePassword skeleton.
Günther Deschner [Tue, 24 Jun 2008 22:32:02 +0000 (00:32 +0200)]
netapi: add NetUserChangePassword skeleton.

Guenther

12 years agore-run make idl.
Günther Deschner [Tue, 24 Jun 2008 22:29:25 +0000 (00:29 +0200)]
re-run make idl.

Guenther

12 years agonetapi: add NetUserChangePassword() to IDL.
Günther Deschner [Tue, 24 Jun 2008 22:29:06 +0000 (00:29 +0200)]
netapi: add NetUserChangePassword() to IDL.

Guenther

12 years agorpc_client: let cli_get_session_key() return talloced session key.
Günther Deschner [Tue, 24 Jun 2008 22:21:37 +0000 (00:21 +0200)]
rpc_client: let cli_get_session_key() return talloced session key.

Thanks, Volker, for pointing this out.

Guenther

12 years agoFix for bug #5551, smbd recursing back into winbindd from a winbindd call.
Jeremy Allison [Wed, 25 Jun 2008 01:01:59 +0000 (18:01 -0700)]
Fix for bug #5551, smbd recursing back into winbindd from a winbindd call.
Jeremy.

12 years agoFix bug #5555. Don't return NT_STATUS_PASSWORD_MUST_CHANGE error on machine account...
Jeremy Allison [Tue, 24 Jun 2008 23:37:15 +0000 (16:37 -0700)]
Fix bug #5555. Don't return NT_STATUS_PASSWORD_MUST_CHANGE error on machine account logon.
Jeremy.

12 years agonet_vampire: add basic libnet_dssync() infrastructure.
Günther Deschner [Mon, 23 Jun 2008 21:13:21 +0000 (23:13 +0200)]
net_vampire: add basic libnet_dssync() infrastructure.

Guenther

12 years agorpc_client: add cli_get_session_key().
Günther Deschner [Tue, 10 Jun 2008 19:35:34 +0000 (21:35 +0200)]
rpc_client: add cli_get_session_key().

Guenther

12 years agonet: add basic support for sealed RPC connections (using NET_FLAGS_SEAL).
Günther Deschner [Tue, 24 Jun 2008 08:34:16 +0000 (10:34 +0200)]
net: add basic support for sealed RPC connections (using NET_FLAGS_SEAL).

Guenther

12 years agocrypto: add decrypt_drsuapi_blob from samba4.
Günther Deschner [Mon, 23 Jun 2008 14:02:04 +0000 (16:02 +0200)]
crypto: add decrypt_drsuapi_blob from samba4.

Guenther

12 years agore-run make idl.
Günther Deschner [Tue, 24 Jun 2008 18:57:17 +0000 (20:57 +0200)]
re-run make idl.

Guenther

12 years agodrsuapi: add some more attribute IDs.
Günther Deschner [Tue, 24 Jun 2008 18:57:03 +0000 (20:57 +0200)]
drsuapi: add some more attribute IDs.

Guenther

12 years agonet_vampire: add code to vampire a SAM database to a keytab file.
Günther Deschner [Wed, 18 Jun 2008 10:52:00 +0000 (12:52 +0200)]
net_vampire: add code to vampire a SAM database to a keytab file.

Guenther

12 years agonet_vampire: add username/password to samsync_context.
Günther Deschner [Tue, 24 Jun 2008 10:30:34 +0000 (12:30 +0200)]
net_vampire: add username/password to samsync_context.

Guenther

12 years agolibads: use ads_connect_user_creds in some places.
Günther Deschner [Tue, 24 Jun 2008 11:06:38 +0000 (13:06 +0200)]
libads: use ads_connect_user_creds in some places.

Guenther

12 years agolibads: add ads_connect_user_creds() that won't overwrite given user creds.
Günther Deschner [Tue, 24 Jun 2008 11:02:03 +0000 (13:02 +0200)]
libads: add ads_connect_user_creds() that won't overwrite given user creds.

Guenther

12 years agolibads: add ADS_AUTH_USER_CREDS to avoid magic overwriting of usernames.
Günther Deschner [Tue, 24 Jun 2008 10:11:06 +0000 (12:11 +0200)]
libads: add ADS_AUTH_USER_CREDS to avoid magic overwriting of usernames.

Guenther

12 years agokerberos: add smb_krb5_keytab_name().
Günther Deschner [Wed, 18 Jun 2008 10:48:35 +0000 (12:48 +0200)]
kerberos: add smb_krb5_keytab_name().

Guenther

12 years agokerberos: make smb_krb5_kt_add_entry public, allow to pass keys without salting them.
Günther Deschner [Wed, 18 Jun 2008 10:45:57 +0000 (12:45 +0200)]
kerberos: make smb_krb5_kt_add_entry public, allow to pass keys without salting them.

Guenther

12 years agonet ads: Fix typos.
Karolin Seeger [Tue, 24 Jun 2008 13:55:30 +0000 (15:55 +0200)]
net ads: Fix typos.

Karolin

12 years agorpc_client: Avoid warning in builds without krb5 headers.
Karolin Seeger [Tue, 24 Jun 2008 13:53:23 +0000 (15:53 +0200)]
rpc_client: Avoid warning in builds without krb5 headers.

warning: ‘cli_auth_kerberos_data_destructor’ defined but not used

Karolin

12 years agoRemove "conn" from pipes_struct
Volker Lendecke [Mon, 23 Jun 2008 06:38:27 +0000 (08:38 +0200)]
Remove "conn" from pipes_struct

For spoolss, we need the client's IP address

12 years agoCorrect calculation of "remark" in srv_srvsvc_nt.c
Volker Lendecke [Mon, 23 Jun 2008 06:33:04 +0000 (08:33 +0200)]
Correct calculation of "remark" in srv_srvsvc_nt.c

Very likely the client is not interested in the values for the IPC$ share :-)

12 years agoMove the responsibility to keep the cwd from srv_dfs_nt to msdfs.c
Volker Lendecke [Sun, 22 Jun 2008 20:19:10 +0000 (22:19 +0200)]
Move the responsibility to keep the cwd from srv_dfs_nt to msdfs.c

12 years agore-run make idl.
Günther Deschner [Wed, 18 Jun 2008 10:42:27 +0000 (12:42 +0200)]
re-run make idl.

Guenther

12 years agodrsuapi: fill in some more drsuapi_DsAttributeIds.
Günther Deschner [Wed, 18 Jun 2008 10:42:11 +0000 (12:42 +0200)]
drsuapi: fill in some more drsuapi_DsAttributeIds.

Guenther

12 years agonet_vampire: more libnet_samsync restructuring.
Günther Deschner [Mon, 23 Jun 2008 15:29:01 +0000 (17:29 +0200)]
net_vampire: more libnet_samsync restructuring.

Guenther

12 years agonet_vampire: prepend libnet_ to the public samsync functions.
Günther Deschner [Mon, 23 Jun 2008 15:03:53 +0000 (17:03 +0200)]
net_vampire: prepend libnet_ to the public samsync functions.

Guenther

12 years agonet_vampire: move out display routines to one file.
Günther Deschner [Tue, 17 Jun 2008 19:53:01 +0000 (21:53 +0200)]
net_vampire: move out display routines to one file.

Guenther

12 years agonet_vampire: move out passdb routines to one file.
Günther Deschner [Tue, 17 Jun 2008 19:44:30 +0000 (21:44 +0200)]
net_vampire: move out passdb routines to one file.

Guenther

12 years agonet_vampire: fix included header.
Günther Deschner [Tue, 17 Jun 2008 19:42:27 +0000 (21:42 +0200)]
net_vampire: fix included header.

Guenther

12 years agonet_vampire: display more deltas while doing samdump.
Günther Deschner [Tue, 17 Jun 2008 19:32:12 +0000 (21:32 +0200)]
net_vampire: display more deltas while doing samdump.

Guenther

12 years agonet_vampire: move pull_netr_AcctLockStr() to libnet.
Günther Deschner [Tue, 17 Jun 2008 19:22:06 +0000 (21:22 +0200)]
net_vampire: move pull_netr_AcctLockStr() to libnet.

Guenther

12 years agotime: move uint64s_nt_time_to_unix_abs() to lib/time.c
Günther Deschner [Mon, 16 Jun 2008 11:36:53 +0000 (13:36 +0200)]
time: move uint64s_nt_time_to_unix_abs() to lib/time.c

Guenther

12 years agoAdd documentation for kerberos support in libsmbclient.
Andreas Schneider [Mon, 23 Jun 2008 14:29:40 +0000 (16:29 +0200)]
Add documentation for kerberos support in libsmbclient.

Signed-off-by: Andreas Schneider <anschneider@suse.de>
Signed-off-by: Derrell Lipman <derrell.lipman@unwireduniverse.com>
12 years agoAdd krb5 support for the testbrowse example.
Andreas Schneider [Mon, 23 Jun 2008 09:00:20 +0000 (11:00 +0200)]
Add krb5 support for the testbrowse example.

Signed-off-by: Andreas Schneider <anschneider@suse.de>
Signed-off-by: Derrell Lipman <derrell.lipman@unwireduniverse.com>
12 years agolibsmbconf: add "includes" to the forbidden_valnames[].
Michael Adam [Mon, 23 Jun 2008 09:11:08 +0000 (11:11 +0200)]
libsmbconf: add "includes" to the forbidden_valnames[].

This removes the warning messages 'Unknown parameter encountered: "includes"'.

Michael

12 years agolibsmbconf: fastpaths first in smbconf_reg_valname_valid().
Michael Adam [Mon, 23 Jun 2008 09:09:38 +0000 (11:09 +0200)]
libsmbconf: fastpaths first in smbconf_reg_valname_valid().

Before dropping into lp_parameter_is_valid().

Michael

12 years agoSamba3 HOWTO: Remove trailing whitespaces.
Karolin Seeger [Mon, 23 Jun 2008 08:15:53 +0000 (10:15 +0200)]
Samba3 HOWTO: Remove trailing whitespaces.

Karolin
(cherry picked from commit c7a9c903acbba9c70211e6f3c25964533bbc1622)
(cherry picked from commit 62e485eebd8a40b5692caa79bb3ed6108f0b835b)

12 years agoman pages: Correct version in man winbindd again.
Karolin Seeger [Mon, 23 Jun 2008 08:28:09 +0000 (10:28 +0200)]
man pages: Correct version in man winbindd again.

Karolin
(cherry picked from commit ef44968276bfde2fdd3370e2558fb469357414be)
(cherry picked from commit 9fd1d784cf6044c5c03cf7ab0f2373e08df64295)

12 years agoFixed publishing date info.
John H Terpstra [Wed, 28 May 2008 16:02:26 +0000 (11:02 -0500)]
Fixed publishing date info.
(cherry picked from commit b96c9d54cfd29ec87d59655839a4136977a98032)
(cherry picked from commit e4d03d3aede0cd611283a041eafdcd1e836aad33)

12 years agoAdded TDB File documentation requested by some users.
John H Terpstra [Wed, 28 May 2008 16:00:49 +0000 (11:00 -0500)]
Added TDB File documentation requested by some users.
(cherry picked from commit 5035311af639336fdc51fa9829e984ff281216f9)
(cherry picked from commit a7531f4964ac8f861a41e9fa446e5a3aa69eaaa2)

12 years agoClarification that hosts resolution is done by winbind only on IRIX, all other system...
John H Terpstra [Mon, 19 May 2008 18:02:08 +0000 (13:02 -0500)]
Clarification that hosts resolution is done by winbind only on IRIX, all other systems use libnss_wins.so.
(cherry picked from commit 3a8ea6be389bedbcdb5668664d862768c026f669)
(cherry picked from commit 8522db2075f8c9e869c6224f2852ce355bba987d)

12 years agoClarification that hosts resolution is done by winbind only on IRIX, all other system...
John H Terpstra [Mon, 19 May 2008 18:00:01 +0000 (13:00 -0500)]
Clarification that hosts resolution is done by winbind only on IRIX, all other systems use libnss_wins.so.
(cherry picked from commit 2a953d6ba252e5ba4e28b7fae5979e7c47fe9bd0)
(cherry picked from commit 59bb2b0c9a6397bb0202055d7b00dce30d7bf03b)

12 years agoinit_shared_module -> init_samba_module
Volker Lendecke [Mon, 23 Jun 2008 05:14:46 +0000 (07:14 +0200)]
init_shared_module -> init_samba_module

12 years agoRemove the "exists" parameter from create_msdfs_link
Volker Lendecke [Sun, 22 Jun 2008 18:33:28 +0000 (20:33 +0200)]
Remove the "exists" parameter from create_msdfs_link

Jeremy, setting "exists" to True in _dfs_Add prevented the initial creation of
a new symlink for me, because the SMB_VFS_UNLINK failed. This also exists in
3.2. I only check it into 3.3 as I would like you to look at it first.

Thanks,

Volker

12 years agoCheck for sec_initial_uid() instead of uid==0 in dfs management
Volker Lendecke [Sun, 22 Jun 2008 18:27:20 +0000 (20:27 +0200)]
Check for sec_initial_uid() instead of uid==0 in dfs management

12 years agoReduce memory usage in form_junctions() a little bit
Volker Lendecke [Sun, 22 Jun 2008 09:28:57 +0000 (11:28 +0200)]
Reduce memory usage in form_junctions() a little bit

12 years agoFix an abort in junction_to_local_path
Volker Lendecke [Sun, 22 Jun 2008 16:36:37 +0000 (18:36 +0200)]
Fix an abort in junction_to_local_path

12 years agoFix a crash in _dfs_Enum
Volker Lendecke [Sun, 22 Jun 2008 11:06:35 +0000 (13:06 +0200)]
Fix a crash in _dfs_Enum
(cherry picked from commit 4a996476297963d4cb300b4d45c23e83a493c339)

12 years agoFix an uninitialized variable access in callers of parse_msdfs_symlink
Volker Lendecke [Sun, 22 Jun 2008 10:50:30 +0000 (12:50 +0200)]
Fix an uninitialized variable access in callers of parse_msdfs_symlink

At least form_junctions() does not initialize refcount, and I don't see it in
get_referred_path(). For the latters, the callers might initialize it. But even
if they did, I think parse_msdfs_symlink() should unconditionally return the
number of referrals it found. I don't think it makes sense to count them up
from somewhere else.

12 years agoFix a double-closedir() in form_junctions()
Volker Lendecke [Sat, 21 Jun 2008 14:39:05 +0000 (16:39 +0200)]
Fix a double-closedir() in form_junctions()

12 years agoAttempt to fix the darwin build
Volker Lendecke [Sat, 21 Jun 2008 14:15:02 +0000 (16:15 +0200)]
Attempt to fix the darwin build

12 years agoUse "init_shared_module" instead of "init_module" for initializing .so's
Volker Lendecke [Fri, 20 Jun 2008 12:30:02 +0000 (14:30 +0200)]
Use "init_shared_module" instead of "init_module" for initializing .so's

12 years agoMake pipes_struct its own talloc ctx
Volker Lendecke [Fri, 20 Jun 2008 14:22:49 +0000 (16:22 +0200)]
Make pipes_struct its own talloc ctx

12 years agoFix a SAFE_FREE/TALLOC_FREE mixup
Volker Lendecke [Fri, 20 Jun 2008 14:22:32 +0000 (16:22 +0200)]
Fix a SAFE_FREE/TALLOC_FREE mixup

12 years agonet: Don't crash on invalid command line options.
Kai Blin [Fri, 20 Jun 2008 22:07:21 +0000 (00:07 +0200)]
net: Don't crash on invalid command line options.

This backs out the workaround Jerry added in
4c3bfea9f8d238f9100eaa264b9b2941dff5a6dd.
Thanks for the catch.

12 years agoFix bug #5531 - fix conversion of ns units when converting from nttime to timespec.
Jeremy Allison [Fri, 20 Jun 2008 20:23:31 +0000 (13:23 -0700)]
Fix bug #5531 - fix conversion of ns units when converting from nttime to timespec.
Fix from hkurma@datadomain.com.
Jeremy.

12 years agoFix bug #5533. Winbindd fails to cope correctly with a workgroup name containing...
Jeremy Allison [Fri, 20 Jun 2008 19:49:14 +0000 (12:49 -0700)]
Fix bug #5533. Winbindd fails to cope correctly with a workgroup name containing a '.'.
Jeremy.

12 years agonet: Fix crash when specifying invalid options on the command line
root [Thu, 19 Jun 2008 17:14:32 +0000 (12:14 -0500)]
net: Fix crash when specifying invalid options on the command line

12 years agoRemove current_user references from nttrans.c
Volker Lendecke [Thu, 19 Jun 2008 16:48:10 +0000 (18:48 +0200)]
Remove current_user references from nttrans.c

12 years agoRemove current_user references from trans2.c
Volker Lendecke [Thu, 19 Jun 2008 16:46:57 +0000 (18:46 +0200)]
Remove current_user references from trans2.c

This involved replacing the CHECK_NTQUOTA_HANDLE_OK macro by a function.

12 years agoRemove some current_user references from trans2.c
Volker Lendecke [Thu, 19 Jun 2008 16:36:54 +0000 (18:36 +0200)]
Remove some current_user references from trans2.c

12 years agoRemove reference to current_user from reply.c
Volker Lendecke [Thu, 19 Jun 2008 16:21:41 +0000 (18:21 +0200)]
Remove reference to current_user from reply.c

12 years agoWrap the unix token info in a unix_user_token in auth_serversupplied_info
Volker Lendecke [Thu, 19 Jun 2008 14:54:12 +0000 (16:54 +0200)]
Wrap the unix token info in a unix_user_token in auth_serversupplied_info

No functional change, this is a preparation for more current_user ref removal

12 years agoRemove the "current_user" arg from fsp_belongs_conn
Volker Lendecke [Thu, 19 Jun 2008 14:31:59 +0000 (16:31 +0200)]
Remove the "current_user" arg from fsp_belongs_conn

fsp_belongs_conn only used the vuid struct member anyway, and this is available
in the smb_request structure as well.

12 years agoRemove the "current_user" arg from check_fsp
Volker Lendecke [Thu, 19 Jun 2008 14:31:59 +0000 (16:31 +0200)]
Remove the "current_user" arg from check_fsp

check_fsp only used the vuid struct member anyway, and this is available in the
smb_request structure as well.

12 years agoloadparm: use the return value of the special handlers in lp_load().
Michael Adam [Thu, 19 Jun 2008 15:21:04 +0000 (17:21 +0200)]
loadparm: use the return value of the special handlers in lp_load().

Up to now, the bool return value was silently ignored.

Michael

12 years agoloadparm: don't treat a missing include file as an error in handle_include().
Michael Adam [Thu, 19 Jun 2008 15:20:22 +0000 (17:20 +0200)]
loadparm: don't treat a missing include file as an error in handle_include().

Michael

12 years agotestsuite: enable the testparm_s3 tests.
Michael Adam [Thu, 19 Jun 2008 15:19:21 +0000 (17:19 +0200)]
testsuite: enable the testparm_s3 tests.

Michael

12 years agotestsuite: add a testparm_s3 test script.
Michael Adam [Thu, 19 Jun 2008 15:14:39 +0000 (17:14 +0200)]
testsuite: add a testparm_s3 test script.

This is a first testparm/lp_load test that runs testparm on a couple
of configuration files. The main purpose for now is to test the options
that have special handlers (to check whether the handlers succeed).
In particular, all the Macro expansions that are available via
alloc_sub_basic() are tested with the include handler. This is to
catch such crashbugs as #5548 where %m expansion led to a segfault.

The tests now are very simple. Just check if testparm completes
successfully on the given config files. This can (and should) be
elaborated in the future.

Michael

12 years agotestsuite: update introductory comment to test_net_regsistry.sh
Michael Adam [Thu, 19 Jun 2008 11:52:49 +0000 (13:52 +0200)]
testsuite: update introductory comment to test_net_regsistry.sh

This is now used to test rpc and local access depending on
command line parameters.

Michael

12 years agoRemove current_user_info reference from vfs_recycle.c
Volker Lendecke [Thu, 19 Jun 2008 13:48:05 +0000 (15:48 +0200)]
Remove current_user_info reference from vfs_recycle.c

12 years agoRemove current_user_info reference from vfs_fake_perms.c
Volker Lendecke [Thu, 19 Jun 2008 13:46:44 +0000 (15:46 +0200)]
Remove current_user_info reference from vfs_fake_perms.c

12 years agoRemove current_user_info reference from vfs_expand_msdfs.c
Volker Lendecke [Thu, 19 Jun 2008 13:44:15 +0000 (15:44 +0200)]
Remove current_user_info reference from vfs_expand_msdfs.c

12 years agocurrent_user is not used in vfs_aixacl2.c
Volker Lendecke [Thu, 19 Jun 2008 13:43:52 +0000 (15:43 +0200)]
current_user is not used in vfs_aixacl2.c

12 years agoRWX on a file does not imply DELETE access
Volker Lendecke [Tue, 17 Jun 2008 14:22:43 +0000 (16:22 +0200)]
RWX on a file does not imply DELETE access

Without this the changed checks in can_delete_file_in_directory give DELETE
access where there is none. So we can end up granting the ntcreate&x preparing
the unlink where we should not, which leads to a NT_STATUS_ACCESS_DENIED at
close time later, which in turn does *not* give the access denied error message
in the Windows GUI.

can_delete_file_in_directory will grant access now by looking at the directory
permissions.

12 years agoFix checks in can_delete_file_in_directory()
Volker Lendecke [Thu, 19 Jun 2008 12:53:46 +0000 (14:53 +0200)]
Fix checks in can_delete_file_in_directory()

With at least NFSv4 ACLs around the write permission for the owner is a bogus
check if we can delete a file in a directory. Like in Windows, there are two
ways which can grant us such: First, the DELETE permission on the file itself,
or if that does not help, the DELETE_CHILD permission on the directory. It
might be a bit more code that runs, but essentially we should end up with the
same set of syscalls in the non-acl case.

12 years agoRemove some code
Volker Lendecke [Thu, 19 Jun 2008 10:03:31 +0000 (12:03 +0200)]
Remove some code

Did not measure it, but I think a single write is better than a read and a
conditional branch

12 years agoFix typo
Volker Lendecke [Thu, 19 Jun 2008 09:59:55 +0000 (11:59 +0200)]
Fix typo

12 years agoFix the build on FreeBSD 4.6.2
Volker Lendecke [Thu, 19 Jun 2008 07:50:34 +0000 (09:50 +0200)]
Fix the build on FreeBSD 4.6.2

12 years agoFix 'make distclean'. delheaders: no longer exists as a dependency.
Jeremy Allison [Wed, 18 Jun 2008 19:56:36 +0000 (12:56 -0700)]
Fix 'make distclean'. delheaders: no longer exists as a dependency.
Jeremy.

12 years agoRemove prototype of unimplemented smbc_chown() function.
Derrell Lipman [Wed, 18 Jun 2008 15:00:46 +0000 (11:00 -0400)]
Remove prototype of unimplemented smbc_chown() function.

12 years agoRevert "Fix a memleak in svcctl_init_keys()"
Volker Lendecke [Wed, 18 Jun 2008 14:30:37 +0000 (16:30 +0200)]
Revert "Fix a memleak in svcctl_init_keys()"

This reverts commit b1afb31f3cadd4749bf6e3eb5d8935588bf8ebfc.

This one is very strange: I need to investigate why valgrind showed it as
leaking, and why in my initial tests this did not fail.
(cherry picked from commit 24730f5981efb920811e7929a9483bd72bb0984c)

12 years agoFix Bug #5548 (segfauls in handle_include with %m macro expansion).
Michael Adam [Wed, 18 Jun 2008 12:50:53 +0000 (14:50 +0200)]
Fix Bug #5548 (segfauls in handle_include with %m macro expansion).

In alloc_sub_basic, when expanding '%m', substitute "" instead of
NULL for remote_machine when this is NULL. Else a NULL string
is returned.

Michael