kai/samba-autobuild/.git
6 years agos4:auth/kerberos: make use of samba_tevent_context_init()
Stefan Metzmacher [Mon, 18 Feb 2013 08:12:58 +0000 (09:12 +0100)]
s4:auth/kerberos: make use of samba_tevent_context_init()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
6 years agolibrpc/rpc: make use of samba_tevent_context_init()
Stefan Metzmacher [Mon, 18 Feb 2013 08:09:31 +0000 (09:09 +0100)]
librpc/rpc: make use of samba_tevent_context_init()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
6 years agolibcli/smb: make use of samba_tevent_context_init()
Stefan Metzmacher [Mon, 18 Feb 2013 08:07:11 +0000 (09:07 +0100)]
libcli/smb: make use of samba_tevent_context_init()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
6 years agolibcli/cldap: make use of samba_tevent_context_init()
Stefan Metzmacher [Mon, 18 Feb 2013 08:06:29 +0000 (09:06 +0100)]
libcli/cldap: make use of samba_tevent_context_init()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
6 years agolib/util: add samba_tevent_context_init()
Stefan Metzmacher [Mon, 18 Feb 2013 07:54:51 +0000 (08:54 +0100)]
lib/util: add samba_tevent_context_init()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
6 years agobuild/autoconf: fix check for GNU ld version
Björn Jacke [Tue, 19 Feb 2013 14:30:34 +0000 (15:30 +0100)]
build/autoconf: fix check for GNU ld version

we need to look for the version once in the stdout and once in the stderr
output. Some version of ld output to stdout, some output to stderr. redirecting
stderr to stdout messes the output up in our case, that's why we have to do two
runs. See also bug #7825.

Signed-off-by: Bjoern Jacke <bj@sernet.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Tue Feb 19 20:56:12 CET 2013 on sn-devel-104

6 years agos3:build fix the build with --fake-kaserver
Christian Ambach [Mon, 18 Feb 2013 16:34:25 +0000 (17:34 +0100)]
s3:build fix the build with --fake-kaserver

this fixes Bug 9643 - Build in source3 of bin/net fails when configure option
--with-fake-kaserver is used

Bug: https://bugzilla.samba.org/show_bug.cgi?id=9643

Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue Feb 19 19:15:19 CET 2013 on sn-devel-104

6 years agos3:lib/afs fix the build
Christian Ambach [Mon, 18 Feb 2013 15:55:30 +0000 (16:55 +0100)]
s3:lib/afs fix the build

Fix Bug 9644 - Compile of source3/lib/afs.c fails

Bug: https://bugzilla.samba.org/show_bug.cgi?id=9644

Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
6 years agotdb: Slightly simplify transaction_write
Volker Lendecke [Tue, 19 Feb 2013 11:23:36 +0000 (12:23 +0100)]
tdb: Slightly simplify transaction_write

realloc(NULL, ...) is equivalent to malloc. We are already using this
realloc property for tdb->lockrecs. It should not make any difference
in speed, it just makes for a little simpler code.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Feb 19 17:30:13 CET 2013 on sn-devel-104

6 years agotdb: Make tdb_release_transaction_locks use tdb_allrecord_unlock
Volker Lendecke [Sat, 16 Feb 2013 21:08:52 +0000 (22:08 +0100)]
tdb: Make tdb_release_transaction_locks use tdb_allrecord_unlock

The transaction code uses tdb_alrecord_lock/upgrade, so it should also
use the tdb_allrecord_unlock function just for symmetry reasons

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agotdb: Don't segfault if tdb_open_ex for check failed
Volker Lendecke [Sat, 16 Feb 2013 21:07:41 +0000 (22:07 +0100)]
tdb: Don't segfault if tdb_open_ex for check failed

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agotdb: Factor out the retry loop from tdb_allrecord_upgrade
Volker Lendecke [Sat, 16 Feb 2013 15:49:56 +0000 (16:49 +0100)]
tdb: Factor out the retry loop from tdb_allrecord_upgrade

For the mutex code we will have to lock the hashchain and the record
lock area independently. So we will have to call the loop twice. And,
it's a small refactoring for the better anyway I think.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agotdb: Simplify fcntl_lock() a bit
Volker Lendecke [Sat, 16 Feb 2013 13:17:57 +0000 (14:17 +0100)]
tdb: Simplify fcntl_lock() a bit

All arguments but the cmd are the same. To me this looks a bit better
and saves some bytes in the object code.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agotdb: Use tdb_null in freelistcheck
Volker Lendecke [Sat, 16 Feb 2013 12:39:28 +0000 (13:39 +0100)]
tdb: Use tdb_null in freelistcheck

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agotdb: Enhance lock tracking a bit
Volker Lendecke [Thu, 14 Feb 2013 15:10:31 +0000 (16:10 +0100)]
tdb: Enhance lock tracking a bit

lock-tracking.c mirrors the in-kernel fcntl structures to detect
unexpected use of fcntl calls. During my mutex work I changed our fcntl
use so that we unlock the allrecord_lock in two pieces: The range covering
the hash locks and the range covering the data area for the individual
traverse record locks. Splitting locks is not covered by lock-tracking.c.

This patch extends lock-tracking.c with this little piece. It's still
far from complete to track the full range of fcntl semantics. It is not
strictly needed right now, but it does not hurt either.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agos3:smbd: preserve file type mode bits in file_set_dosmode()
Michael Adam [Tue, 19 Feb 2013 12:27:10 +0000 (13:27 +0100)]
s3:smbd: preserve file type mode bits in file_set_dosmode()

When translating between dos modes and unix modes, these bits were dropped from
the stat->st_ex_mode field.

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Tue Feb 19 15:45:31 CET 2013 on sn-devel-104

6 years agogencache: fix an extra newline in a DEBUG message in gencache_set_data_blob()
Michael Adam [Wed, 13 Feb 2013 08:46:33 +0000 (09:46 +0100)]
gencache: fix an extra newline in a DEBUG message in gencache_set_data_blob()

by using timestring() instead of ctime()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agogencache: fix an extra newline in a DEBUG message in gencache_iterate_fn()
Michael Adam [Wed, 13 Feb 2013 08:45:09 +0000 (09:45 +0100)]
gencache: fix an extra newline in a DEBUG message in gencache_iterate_fn()

by using timestring() instead of ctime()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agogencache: fix an extra newline in a DEBUG message in gencache_iterate_blobs_fn()
Michael Adam [Wed, 13 Feb 2013 08:43:19 +0000 (09:43 +0100)]
gencache: fix an extra newline in a DEBUG message in gencache_iterate_blobs_fn()

by using timestring() instead of ctime()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agolib/util/time: strip a potential trailing newline in the asctime case.
Michael Adam [Wed, 13 Feb 2013 15:51:54 +0000 (16:51 +0100)]
lib/util/time: strip a potential trailing newline in the asctime case.

If strftime() is not available, asctime() is used, and this usually
appends a newline character to the result. This is not desired for
timestamp().

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agogencache: unify a DEBUG message in gencache_set_data_blob()
Michael Adam [Mon, 11 Feb 2013 12:41:12 +0000 (13:41 +0100)]
gencache: unify a DEBUG message in gencache_set_data_blob()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agogencache: unify a DEBUG message in gencache_iterate_fn()
Michael Adam [Mon, 11 Feb 2013 12:42:58 +0000 (13:42 +0100)]
gencache: unify a DEBUG message in gencache_iterate_fn()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agogencache: unify a DEBUG message in gencache_iterate_blobs_fn()
Michael Adam [Mon, 11 Feb 2013 12:42:28 +0000 (13:42 +0100)]
gencache: unify a DEBUG message in gencache_iterate_blobs_fn()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agogencache: unify a DEBUG message in gencache_del()
Michael Adam [Mon, 11 Feb 2013 12:43:32 +0000 (13:43 +0100)]
gencache: unify a DEBUG message in gencache_del()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agopackaging(RHEL-CTDB): remove unpackaged manpages (samba and samba-tool)
Michael Adam [Thu, 25 Oct 2012 09:35:50 +0000 (05:35 -0400)]
packaging(RHEL-CTDB): remove unpackaged manpages (samba and samba-tool)

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agopackaging(RHEL-CTDB): package the fake-acls vfs module
Michael Adam [Thu, 25 Oct 2012 09:34:23 +0000 (05:34 -0400)]
packaging(RHEL-CTDB): package the fake-acls vfs module

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agos3:net: new implementation of "servid wipedbs" with smbXsrv_*
Gregor Beck [Thu, 13 Dec 2012 12:00:28 +0000 (13:00 +0100)]
s3:net: new implementation of "servid wipedbs" with smbXsrv_*

Signed-off-by: Gregor Beck <gbeck@sernet.de>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Tue Feb 19 13:56:57 CET 2013 on sn-devel-104

6 years agolib/util_tdb: factor out tdb_data_talloc_copy()
Gregor Beck [Thu, 10 Jan 2013 10:09:09 +0000 (11:09 +0100)]
lib/util_tdb: factor out tdb_data_talloc_copy()

Signed-off-by: Gregor Beck <gbeck@sernet.de>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agos3:smbXsrv_open: add smbXsrv_open_global_traverse()
Gregor Beck [Wed, 12 Dec 2012 15:06:50 +0000 (16:06 +0100)]
s3:smbXsrv_open: add smbXsrv_open_global_traverse()

Signed-off-by: Gregor Beck <gbeck@sernet.de>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agos3:smbXsrv_tcon: pass record in smbXsrv_tcon_global_traverse()
Gregor Beck [Thu, 13 Dec 2012 14:27:07 +0000 (15:27 +0100)]
s3:smbXsrv_tcon: pass record in smbXsrv_tcon_global_traverse()

Signed-off-by: Gregor Beck <gbeck@sernet.de>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agos3:smbXsrv_session: pass record in smbXsrv_session_global_traverse()
Gregor Beck [Thu, 13 Dec 2012 14:26:49 +0000 (15:26 +0100)]
s3:smbXsrv_session: pass record in smbXsrv_session_global_traverse()

Signed-off-by: Gregor Beck <gbeck@sernet.de>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agos3:smbd:smb2: fix segfault (access after free) in durable disconnect code
Michael Adam [Mon, 18 Feb 2013 22:21:24 +0000 (23:21 +0100)]
s3:smbd:smb2: fix segfault (access after free) in durable disconnect code

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Tue Feb 19 11:12:01 CET 2013 on sn-devel-104

6 years agosamba_upgradeprovision: Use tdb_util.tdb_copy not shutil.copy2
Andrew Bartlett [Sun, 17 Feb 2013 07:15:52 +0000 (18:15 +1100)]
samba_upgradeprovision: Use tdb_util.tdb_copy not shutil.copy2

This is really important, because copying a file will both ignore
locks held by another process and break any locks we hold (due to
POSIX brain-damage regarding multiple fds on one file in a process).

By leaving this to tdbbackup in a child, both of these issues are avoided.

Andrew Bartlett

Reviewed-by: Matthieu Patou <mat@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Feb 19 07:48:18 CET 2013 on sn-devel-104

6 years agosamba_upgradeprovision: Do not update privileges.ldb any more (unchanged since 2009)
Andrew Bartlett [Sun, 17 Feb 2013 07:41:00 +0000 (18:41 +1100)]
samba_upgradeprovision: Do not update privileges.ldb any more (unchanged since 2009)

This update was only a total oblitoration of the existing database
and not a merge, and the shutil.copy would both disregard and break
locks on the database that are held at this point.

Andrew Bartlett

Reviewed-by: Matthieu Patou <mat@samba.org>
6 years agoscripting: Make tdb_copy a common util function in samba.tdb_util
Andrew Bartlett [Sun, 17 Feb 2013 07:14:06 +0000 (18:14 +1100)]
scripting: Make tdb_copy a common util function in samba.tdb_util

This will allow samba_upgradeprovision to also call it.

Andrew Bartlett

Reviewed-by: Matthieu Patou <mat@samba.org>
6 years agoscripting: Make tdb_copy use the python subprocess module
Andrew Bartlett [Sun, 17 Feb 2013 06:57:42 +0000 (17:57 +1100)]
scripting: Make tdb_copy use the python subprocess module

This makes the code more robust to spaces in the file names (etc).

Andrew Bartlett

Reviewed-by: Matthieu Patou <mat@samba.org>
6 years agosamba_upgradeprovision: Remove options to fix FS ACLs
Andrew Bartlett [Fri, 15 Feb 2013 21:51:51 +0000 (08:51 +1100)]
samba_upgradeprovision: Remove options to fix FS ACLs

samba-tool ntacl sysvolreset handles this better, and makes this tool
much less confusing internally.

Andrew Bartlett

Reviewed-by: Matthieu Patou <mat@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Feb 19 06:06:41 CET 2013 on sn-devel-104

6 years agos3:smbd: add debugging to close code (regarding disconnect of a durable)
Michael Adam [Tue, 12 Feb 2013 16:44:51 +0000 (17:44 +0100)]
s3:smbd: add debugging to close code (regarding disconnect of a durable)

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Mon Feb 18 17:42:45 CET 2013 on sn-devel-104

6 years agos4:torture: fix segfault in test_durable_open_open2_oplock()
Stefan Metzmacher [Wed, 13 Feb 2013 13:11:57 +0000 (14:11 +0100)]
s4:torture: fix segfault in test_durable_open_open2_oplock()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
6 years agos4:torture:smb2: fix segfault on error condition in the durable-open.delete_on_close2...
Michael Adam [Wed, 13 Feb 2013 14:05:40 +0000 (15:05 +0100)]
s4:torture:smb2: fix segfault on error condition in the durable-open.delete_on_close2 test

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agos4:torture:smb2: fix segfault on error condition in the durable-open.delete_on_close1...
Michael Adam [Wed, 13 Feb 2013 14:04:10 +0000 (15:04 +0100)]
s4:torture:smb2: fix segfault on error condition in the durable-open.delete_on_close1 test

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agos4:torture:smb2: fix segfault on error condition in the durable-open.reopen4 test
Michael Adam [Wed, 13 Feb 2013 14:03:00 +0000 (15:03 +0100)]
s4:torture:smb2: fix segfault on error condition in the durable-open.reopen4 test

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agos4:torture:smb2: fix segfault on error condition in the durable-open.reopen3 test
Michael Adam [Wed, 13 Feb 2013 14:01:47 +0000 (15:01 +0100)]
s4:torture:smb2: fix segfault on error condition in the durable-open.reopen3 test

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agos4:torture:smb2: fix segfault on error condition in the durable-open.reopen2a test
Michael Adam [Wed, 13 Feb 2013 14:00:26 +0000 (15:00 +0100)]
s4:torture:smb2: fix segfault on error condition in the durable-open.reopen2a test

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agos4:torture:smb2: fix segfault on error condition in durable-open.reopen2 test
Michael Adam [Wed, 13 Feb 2013 13:58:29 +0000 (14:58 +0100)]
s4:torture:smb2: fix segfault on error condition in durable-open.reopen2 test

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agos4:torture:smb2:durable: make test functions static
Michael Adam [Tue, 12 Feb 2013 20:51:06 +0000 (21:51 +0100)]
s4:torture:smb2:durable: make test functions static

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agos4:torture: add a durable-open-disconnect test (suite)
Michael Adam [Tue, 12 Feb 2013 16:45:23 +0000 (17:45 +0100)]
s4:torture: add a durable-open-disconnect test (suite)

this opens a durable, disconnects it and exits

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agos3:smbd: use smbXsrv_open_close() instead of smbXsrv_open_update()
Stefan Metzmacher [Wed, 13 Feb 2013 13:26:43 +0000 (08:26 -0500)]
s3:smbd: use smbXsrv_open_close() instead of smbXsrv_open_update()

This makes sure we store the correct disconnect_time for disconnected
durable handles.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
6 years agosrv_epmapper.c: Fix typo.
Karolin Seeger [Mon, 18 Feb 2013 09:25:09 +0000 (10:25 +0100)]
srv_epmapper.c: Fix typo.

priviledge -> privilege

Signed-off-by: Karolin Seeger <kseeger@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Feb 18 13:57:40 CET 2013 on sn-devel-104

6 years agowb_samba3_cmd.c: Fix typo in comment.
Karolin Seeger [Mon, 18 Feb 2013 09:05:23 +0000 (10:05 +0100)]
wb_samba3_cmd.c: Fix typo in comment.

redundent -> redundant

Signed-off-by: Karolin Seeger <kseeger@samba.org>
6 years agobrlock_tdb.c: Fix typo in comment.
Karolin Seeger [Mon, 18 Feb 2013 09:04:42 +0000 (10:04 +0100)]
brlock_tdb.c: Fix typo in comment.

redundent -> redundant

Signed-off-by: Karolin Seeger <kseeger@samba.org>
6 years agosrv_netlog_nt.c: Fix typo in comment.
Karolin Seeger [Mon, 18 Feb 2013 09:03:51 +0000 (10:03 +0100)]
srv_netlog_nt.c: Fix typo in comment.

redundent -> redundant

Signed-off-by: Karolin Seeger <kseeger@samba.org>
6 years agobrlock.c: Fix typo in comment.
Karolin Seeger [Mon, 18 Feb 2013 09:02:51 +0000 (10:02 +0100)]
brlock.c: Fix typo in comment.

redundent -> redundant

Signed-off-by: Karolin Seeger <kseeger@samba.org>
6 years agovfs_gpfs: Fix typos in comments.
Karolin Seeger [Mon, 18 Feb 2013 09:01:21 +0000 (10:01 +0100)]
vfs_gpfs: Fix typos in comments.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
6 years agofault.c: Fix typo in comment.
Karolin Seeger [Mon, 18 Feb 2013 08:59:52 +0000 (09:59 +0100)]
fault.c: Fix typo in comment.

redundent -> redundant

Signed-off-by: Karolin Seeger <kseeger@samba.org>
6 years agodocs: Fix typo.
Karolin Seeger [Wed, 6 Feb 2013 08:08:15 +0000 (09:08 +0100)]
docs: Fix typo.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
6 years agos4-nbt: Ensure source4/ nbt client and server honour 'disable netbios'
Andrew Bartlett [Wed, 6 Feb 2013 09:58:18 +0000 (20:58 +1100)]
s4-nbt: Ensure source4/ nbt client and server honour 'disable netbios'

Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sun Feb 17 11:25:34 CET 2013 on sn-devel-104

6 years agoFallback to the internal resolver on EAI_FAIL.
Landon Fuller [Sun, 17 Feb 2013 03:57:40 +0000 (22:57 -0500)]
Fallback to the internal resolver on EAI_FAIL.

On Linux, non-RFC 1034-complaint names (such as gc._msdsc.example.org)
will result in the resolver returning the non-POSIX EAI_NODATA. In that
case, the case statement here would fall back on the internal resolver,
allowing resolution to complete successfully.

On FreeBSD, the libc resolver uses the same validation code, but
the POSIX result of EAI_FAIL is returned instead of EAI_NODATA. Since
there was no case for this error code, no fallback to the internal
resolver would occur. This led to replication failing on FreeBSD.

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sun Feb 17 07:06:36 CET 2013 on sn-devel-104

6 years agotdb: Fix a typo
Volker Lendecke [Sat, 16 Feb 2013 12:26:36 +0000 (13:26 +0100)]
tdb: Fix a typo

Signed-off-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Simo Sorce <idra@samba.org>
Autobuild-Date(master): Sat Feb 16 17:13:32 CET 2013 on sn-devel-104

6 years agoFix the maxfids test so that it does not fork lots of processes and so that it works...
Richard Sharpe [Fri, 15 Feb 2013 00:04:24 +0000 (16:04 -0800)]
Fix the maxfids test so that it does not fork lots of processes and so that it works for all cases of maxfids.

Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Feb 15 07:09:59 CET 2013 on sn-devel-104

6 years agotevent: Remove the previous "standard" tevent backend implementation.
Jeremy Allison [Mon, 11 Feb 2013 19:42:08 +0000 (11:42 -0800)]
tevent: Remove the previous "standard" tevent backend implementation.

This was a horrible hybrid of duplicated epoll and select()
code.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Feb 14 22:40:30 CET 2013 on sn-devel-104

6 years agotevent: Add in the new implementation of "standard" tevent backend.
Jeremy Allison [Mon, 11 Feb 2013 19:40:49 +0000 (11:40 -0800)]
tevent: Add in the new implementation of "standard" tevent backend.

Falls back cleanly from epoll -> poll, or uses poll if
epoll not available.

Signed-off-by: Jeremy Allison <jra@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agotevent: Add a private function tevent_poll_event_add_fd_internal().
Jeremy Allison [Mon, 11 Feb 2013 19:20:28 +0000 (11:20 -0800)]
tevent: Add a private function tevent_poll_event_add_fd_internal().

Not yet used, but will be called by the "standard"
fallback from epoll -> poll backends.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agotevent: make use of tevent_find_ops_byname() in tevent_context_init_byname()
Stefan Metzmacher [Thu, 14 Feb 2013 08:30:31 +0000 (09:30 +0100)]
tevent: make use of tevent_find_ops_byname() in tevent_context_init_byname()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
6 years agotevent: make sure tevent_backend_init() only runs once
Stefan Metzmacher [Thu, 14 Feb 2013 08:29:57 +0000 (09:29 +0100)]
tevent: make sure tevent_backend_init() only runs once

Signed-off-by: Stefan Metzmacher <metze@samba.org>
6 years agotevent: Add a utility function tevent_find_ops_byname().
Jeremy Allison [Mon, 11 Feb 2013 18:56:58 +0000 (10:56 -0800)]
tevent: Add a utility function tevent_find_ops_byname().

Returns an event ops struct given a string name. Not
yet used, but will be part of the new "standard" fallback
code.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agotevent: Add in the same tevent_re_initialise() fix Metze put in the tevent_poll backend.
Jeremy Allison [Mon, 11 Feb 2013 18:53:15 +0000 (10:53 -0800)]
tevent: Add in the same tevent_re_initialise() fix Metze put in the tevent_poll backend.

We might be called during tevent_re_initialise()
which means we need to free our old additional_data.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agotevent: Add in some test code to allow the panic fallback path to be tested.
Jeremy Allison [Mon, 11 Feb 2013 18:52:30 +0000 (10:52 -0800)]
tevent: Add in some test code to allow the panic fallback path to be tested.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agotevent: Plumb in the panic fallback code into the epoll_panic() runtime call.
Jeremy Allison [Mon, 11 Feb 2013 18:48:02 +0000 (10:48 -0800)]
tevent: Plumb in the panic fallback code into the epoll_panic() runtime call.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agotevent: Add an internal function tevent_epoll_set_panic_fallback().
Jeremy Allison [Mon, 11 Feb 2013 18:43:39 +0000 (10:43 -0800)]
tevent: Add an internal function tevent_epoll_set_panic_fallback().

Can be set externally, allows us to fallback if epoll
fails at runtime.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agotevent: pass 'bool replay' to epoll_panic()
Stefan Metzmacher [Thu, 14 Feb 2013 09:58:55 +0000 (10:58 +0100)]
tevent: pass 'bool replay' to epoll_panic()

A fallback panic handler will need to know if
there was an error while waiting for events
(replay=true) or if the error happened on modify
(replay=false).

Signed-off-by: Stefan Metzmacher <metze@samba.org>
6 years agotevent: Ensure we return after every call to epoll_panic().
Jeremy Allison [Mon, 11 Feb 2013 18:38:01 +0000 (10:38 -0800)]
tevent: Ensure we return after every call to epoll_panic().

Currently we can't return from this, but the new fallback
code will change this.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agotevent: Preparing to fix "standard" backend fallback. Initialize standard after epoll.
Jeremy Allison [Mon, 11 Feb 2013 18:36:52 +0000 (10:36 -0800)]
tevent: Preparing to fix "standard" backend fallback. Initialize standard after epoll.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agodocs: fix typo in serverrole.xml
Samba-JP oota [Thu, 14 Feb 2013 13:55:51 +0000 (22:55 +0900)]
docs: fix typo in serverrole.xml

Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Thu Feb 14 18:43:57 CET 2013 on sn-devel-104

6 years agowaf: Make sure we link against samba-util.
Andreas Schneider [Thu, 14 Feb 2013 11:34:01 +0000 (12:34 +0100)]
waf: Make sure we link against samba-util.

libcmdline-credentials.so needs samba_getpass() from libsamba-util.so,
so we need to link against it.

Reviewed-by: Andrew Bartlet <abartlet@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Feb 14 16:56:29 CET 2013 on sn-devel-104

6 years agos3:idmap_autorid: fix freeing of non-talloced memory (uninitialized pointer) (bug...
Michael Adam [Mon, 11 Feb 2013 21:52:55 +0000 (22:52 +0100)]
s3:idmap_autorid: fix freeing of non-talloced memory (uninitialized pointer) (bug #9653)

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Feb 13 09:51:53 CET 2013 on sn-devel-104

6 years agoAdd a herald with version string to smbtorture
Richard Sharpe [Wed, 6 Feb 2013 21:02:13 +0000 (13:02 -0800)]
Add a herald with version string to smbtorture

Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Richard Sharpe <sharpe@samba.org>
Autobuild-Date(master): Wed Feb 13 08:03:21 CET 2013 on sn-devel-104

6 years agoFix bug 9519 - Samba returns unexpected error on SMB posix open.
Jeremy Allison [Tue, 12 Feb 2013 18:48:09 +0000 (10:48 -0800)]
Fix bug 9519 - Samba returns unexpected error on SMB posix open.

Explicitly ignore bare O_EXCL flags instead of returning INVALID_PARAMETER.
That's what the Linux kernel does.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Jeff Layton <jlayton@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Feb 12 22:59:21 CET 2013 on sn-devel-104

6 years agoFix some cut-and-paste and spelling in debug messages
Guenter Kukkukk [Tue, 12 Feb 2013 04:37:09 +0000 (05:37 +0100)]
Fix some cut-and-paste and spelling in debug messages

Signed-off-by: Guenter Kukkukk <kukks@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Feb 12 07:28:27 CET 2013 on sn-devel-104

6 years agoFix bug #9642 - vfs_afsacl.c won't build.
Jeremy Allison [Sat, 9 Feb 2013 01:08:28 +0000 (17:08 -0800)]
Fix bug #9642 - vfs_afsacl.c won't build.

Add missing mem_ctx argument.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Mon Feb 11 20:24:00 CET 2013 on sn-devel-104

6 years agoImprove the configure tests for aio_suspend to get rid of warnings. Timur provided...
Richard Sharpe [Sat, 9 Feb 2013 03:56:56 +0000 (19:56 -0800)]
Improve the configure tests for aio_suspend to get rid of warnings. Timur provided the wscript method, I added the configure.in correction.

Signed-off-by: Timur Bakeyev <timur@freebsd.org>
Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sat Feb  9 09:24:06 CET 2013 on sn-devel-104

6 years agos3: Make SMB2_GETINFO multi-volume aware.
Ira Cooper [Wed, 6 Feb 2013 13:35:25 +0000 (13:35 +0000)]
s3: Make SMB2_GETINFO multi-volume aware.

Not all shares are a single volume.  Some actually
expose multiple volumes under a single share.  In these
cases showing the amount of space free as the space free
at the base of the directory heirarchy is wrong.

Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Feb  8 21:44:37 CET 2013 on sn-devel-104

6 years agowinbind: Fix an incompatible pointer type warning
Volker Lendecke [Mon, 4 Feb 2013 14:52:49 +0000 (15:52 +0100)]
winbind: Fix an incompatible pointer type warning

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri Feb  8 15:27:51 CET 2013 on sn-devel-104

6 years agodbwrap: Prevent transactions on non-persistent dbs
Volker Lendecke [Fri, 11 Jan 2013 14:32:39 +0000 (15:32 +0100)]
dbwrap: Prevent transactions on non-persistent dbs

dbwrap_ctdb does not allow this anyway. This patch will avoid suprises
when going non-clustered to clustered. Not everybody is developing
against a clustered environment :-)

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agotorture: We use transactions for CLEAR_IF_FIRST db
Volker Lendecke [Fri, 11 Jan 2013 16:29:01 +0000 (17:29 +0100)]
torture: We use transactions for CLEAR_IF_FIRST db

This does not work in the ctdb case

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
6 years agoldb: Add more data test data for one level test cases
Matthieu Patou [Tue, 8 Jan 2013 08:09:32 +0000 (00:09 -0800)]
ldb: Add more data test data for one level test cases

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Feb  8 06:46:40 CET 2013 on sn-devel-104

6 years agoldb: Add tests for the python api
Matthieu Patou [Tue, 8 Jan 2013 08:28:03 +0000 (00:28 -0800)]
ldb: Add tests for the python api

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
6 years agodsdb-operational: rework the loop for attribute removal
Matthieu Patou [Fri, 28 Dec 2012 02:29:49 +0000 (18:29 -0800)]
dsdb-operational: rework the loop for attribute removal

Instead of doing ldb_in_list size(operational_remove) * (attrs_user +
attr_searched) * number of entries times to get the list of attributes to remove we construct this
list before the search and then use it for every entries.

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
6 years agoldb: Add more tests related to onelevel search
Matthieu Patou [Sun, 30 Dec 2012 05:48:46 +0000 (21:48 -0800)]
ldb: Add more tests related to onelevel search

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
6 years agoldb: use strncmp instead of strcmp when comparing the val part
Matthieu Patou [Thu, 13 Dec 2012 10:18:34 +0000 (02:18 -0800)]
ldb: use strncmp instead of strcmp when comparing the val part

val part of a DN's component is DATA_BLOB and nothing insure that it
will be finished by a '\0'

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
6 years agoldb: make test output more readable
Matthieu Patou [Sun, 30 Dec 2012 00:42:28 +0000 (16:42 -0800)]
ldb: make test output more readable

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
6 years agoldb-tdb: Document ltdb_index_add1 for more clarity
Matthieu Patou [Mon, 17 Dec 2012 09:45:30 +0000 (01:45 -0800)]
ldb-tdb: Document ltdb_index_add1 for more clarity

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
6 years agoldb-tdb: Fix a wrong parameter in ltdb_store
Matthieu Patou [Thu, 27 Dec 2012 05:41:52 +0000 (21:41 -0800)]
ldb-tdb: Fix a wrong parameter in ltdb_store

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
6 years agoldb_tdb: raise level of full index scan message so that it starts to be really visible
Matthieu Patou [Mon, 7 Jan 2013 06:17:26 +0000 (22:17 -0800)]
ldb_tdb: raise level of full index scan message so that it starts to be really visible

We don't want to have to set log level to 4 or 5 AND set the environment
variable to be able to see those log messages

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
6 years agodsdb-repl: make message more clearer
Matthieu Patou [Wed, 23 Jan 2013 19:33:30 +0000 (11:33 -0800)]
dsdb-repl: make message more clearer

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
6 years agoreplmetadata: raise msg level for conflict resolution so that we don't polute logs
Matthieu Patou [Sat, 26 Jan 2013 09:53:41 +0000 (01:53 -0800)]
replmetadata: raise msg level for conflict resolution so that we don't polute logs

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
6 years agodsdb-repl: do not ask to add ref when doing getncchange for an exop
Matthieu Patou [Sat, 26 Jan 2013 09:53:28 +0000 (01:53 -0800)]
dsdb-repl: do not ask to add ref when doing getncchange for an exop

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
6 years agodsdb-cracknames: Fix potential double free and memory leaks
Matthieu Patou [Mon, 24 Dec 2012 18:01:30 +0000 (10:01 -0800)]
dsdb-cracknames: Fix potential double free and memory leaks

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
6 years agoBUG 9633: Recursive mget should continue on EPERM.
David Disseldorp [Mon, 4 Feb 2013 18:04:39 +0000 (19:04 +0100)]
BUG 9633: Recursive mget should continue on EPERM.

Regression introduced by 14ff2e8de9bd8d0064762234555260f5eea643fe.
When downloading files recursively, smbclient halts if it encounters
a folder to which it does not have permission to traverse.

Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Feb  7 15:50:36 CET 2013 on sn-devel-104

6 years agos3-rpc_server: Fix password encoding in _netr_ServerGetTrustInfo().
Sumit Bose [Mon, 4 Feb 2013 12:15:18 +0000 (13:15 +0100)]
s3-rpc_server: Fix password encoding in _netr_ServerGetTrustInfo().

Reviewed-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>