kai/samba-autobuild/.git
13 years agoClarification that hosts resolution is done by winbind only on IRIX, all other system...
John H Terpstra [Mon, 19 May 2008 18:00:01 +0000 (13:00 -0500)]
Clarification that hosts resolution is done by winbind only on IRIX, all other systems use libnss_wins.so.
(cherry picked from commit 2a953d6ba252e5ba4e28b7fae5979e7c47fe9bd0)
(cherry picked from commit 59bb2b0c9a6397bb0202055d7b00dce30d7bf03b)

13 years agoinit_shared_module -> init_samba_module
Volker Lendecke [Mon, 23 Jun 2008 05:14:46 +0000 (07:14 +0200)]
init_shared_module -> init_samba_module

13 years agoRemove the "exists" parameter from create_msdfs_link
Volker Lendecke [Sun, 22 Jun 2008 18:33:28 +0000 (20:33 +0200)]
Remove the "exists" parameter from create_msdfs_link

Jeremy, setting "exists" to True in _dfs_Add prevented the initial creation of
a new symlink for me, because the SMB_VFS_UNLINK failed. This also exists in
3.2. I only check it into 3.3 as I would like you to look at it first.

Thanks,

Volker

13 years agoCheck for sec_initial_uid() instead of uid==0 in dfs management
Volker Lendecke [Sun, 22 Jun 2008 18:27:20 +0000 (20:27 +0200)]
Check for sec_initial_uid() instead of uid==0 in dfs management

13 years agoReduce memory usage in form_junctions() a little bit
Volker Lendecke [Sun, 22 Jun 2008 09:28:57 +0000 (11:28 +0200)]
Reduce memory usage in form_junctions() a little bit

13 years agoFix an abort in junction_to_local_path
Volker Lendecke [Sun, 22 Jun 2008 16:36:37 +0000 (18:36 +0200)]
Fix an abort in junction_to_local_path

13 years agoFix a crash in _dfs_Enum
Volker Lendecke [Sun, 22 Jun 2008 11:06:35 +0000 (13:06 +0200)]
Fix a crash in _dfs_Enum
(cherry picked from commit 4a996476297963d4cb300b4d45c23e83a493c339)

13 years agoFix an uninitialized variable access in callers of parse_msdfs_symlink
Volker Lendecke [Sun, 22 Jun 2008 10:50:30 +0000 (12:50 +0200)]
Fix an uninitialized variable access in callers of parse_msdfs_symlink

At least form_junctions() does not initialize refcount, and I don't see it in
get_referred_path(). For the latters, the callers might initialize it. But even
if they did, I think parse_msdfs_symlink() should unconditionally return the
number of referrals it found. I don't think it makes sense to count them up
from somewhere else.

13 years agoFix a double-closedir() in form_junctions()
Volker Lendecke [Sat, 21 Jun 2008 14:39:05 +0000 (16:39 +0200)]
Fix a double-closedir() in form_junctions()

13 years agoAttempt to fix the darwin build
Volker Lendecke [Sat, 21 Jun 2008 14:15:02 +0000 (16:15 +0200)]
Attempt to fix the darwin build

13 years agoUse "init_shared_module" instead of "init_module" for initializing .so's
Volker Lendecke [Fri, 20 Jun 2008 12:30:02 +0000 (14:30 +0200)]
Use "init_shared_module" instead of "init_module" for initializing .so's

13 years agoMake pipes_struct its own talloc ctx
Volker Lendecke [Fri, 20 Jun 2008 14:22:49 +0000 (16:22 +0200)]
Make pipes_struct its own talloc ctx

13 years agoFix a SAFE_FREE/TALLOC_FREE mixup
Volker Lendecke [Fri, 20 Jun 2008 14:22:32 +0000 (16:22 +0200)]
Fix a SAFE_FREE/TALLOC_FREE mixup

13 years agonet: Don't crash on invalid command line options.
Kai Blin [Fri, 20 Jun 2008 22:07:21 +0000 (00:07 +0200)]
net: Don't crash on invalid command line options.

This backs out the workaround Jerry added in
4c3bfea9f8d238f9100eaa264b9b2941dff5a6dd.
Thanks for the catch.

13 years agoFix bug #5531 - fix conversion of ns units when converting from nttime to timespec.
Jeremy Allison [Fri, 20 Jun 2008 20:23:31 +0000 (13:23 -0700)]
Fix bug #5531 - fix conversion of ns units when converting from nttime to timespec.
Fix from hkurma@datadomain.com.
Jeremy.

13 years agoFix bug #5533. Winbindd fails to cope correctly with a workgroup name containing...
Jeremy Allison [Fri, 20 Jun 2008 19:49:14 +0000 (12:49 -0700)]
Fix bug #5533. Winbindd fails to cope correctly with a workgroup name containing a '.'.
Jeremy.

13 years agonet: Fix crash when specifying invalid options on the command line
root [Thu, 19 Jun 2008 17:14:32 +0000 (12:14 -0500)]
net: Fix crash when specifying invalid options on the command line

13 years agoRemove current_user references from nttrans.c
Volker Lendecke [Thu, 19 Jun 2008 16:48:10 +0000 (18:48 +0200)]
Remove current_user references from nttrans.c

13 years agoRemove current_user references from trans2.c
Volker Lendecke [Thu, 19 Jun 2008 16:46:57 +0000 (18:46 +0200)]
Remove current_user references from trans2.c

This involved replacing the CHECK_NTQUOTA_HANDLE_OK macro by a function.

13 years agoRemove some current_user references from trans2.c
Volker Lendecke [Thu, 19 Jun 2008 16:36:54 +0000 (18:36 +0200)]
Remove some current_user references from trans2.c

13 years agoRemove reference to current_user from reply.c
Volker Lendecke [Thu, 19 Jun 2008 16:21:41 +0000 (18:21 +0200)]
Remove reference to current_user from reply.c

13 years agoWrap the unix token info in a unix_user_token in auth_serversupplied_info
Volker Lendecke [Thu, 19 Jun 2008 14:54:12 +0000 (16:54 +0200)]
Wrap the unix token info in a unix_user_token in auth_serversupplied_info

No functional change, this is a preparation for more current_user ref removal

13 years agoRemove the "current_user" arg from fsp_belongs_conn
Volker Lendecke [Thu, 19 Jun 2008 14:31:59 +0000 (16:31 +0200)]
Remove the "current_user" arg from fsp_belongs_conn

fsp_belongs_conn only used the vuid struct member anyway, and this is available
in the smb_request structure as well.

13 years agoRemove the "current_user" arg from check_fsp
Volker Lendecke [Thu, 19 Jun 2008 14:31:59 +0000 (16:31 +0200)]
Remove the "current_user" arg from check_fsp

check_fsp only used the vuid struct member anyway, and this is available in the
smb_request structure as well.

13 years agoloadparm: use the return value of the special handlers in lp_load().
Michael Adam [Thu, 19 Jun 2008 15:21:04 +0000 (17:21 +0200)]
loadparm: use the return value of the special handlers in lp_load().

Up to now, the bool return value was silently ignored.

Michael

13 years agoloadparm: don't treat a missing include file as an error in handle_include().
Michael Adam [Thu, 19 Jun 2008 15:20:22 +0000 (17:20 +0200)]
loadparm: don't treat a missing include file as an error in handle_include().

Michael

13 years agotestsuite: enable the testparm_s3 tests.
Michael Adam [Thu, 19 Jun 2008 15:19:21 +0000 (17:19 +0200)]
testsuite: enable the testparm_s3 tests.

Michael

13 years agotestsuite: add a testparm_s3 test script.
Michael Adam [Thu, 19 Jun 2008 15:14:39 +0000 (17:14 +0200)]
testsuite: add a testparm_s3 test script.

This is a first testparm/lp_load test that runs testparm on a couple
of configuration files. The main purpose for now is to test the options
that have special handlers (to check whether the handlers succeed).
In particular, all the Macro expansions that are available via
alloc_sub_basic() are tested with the include handler. This is to
catch such crashbugs as #5548 where %m expansion led to a segfault.

The tests now are very simple. Just check if testparm completes
successfully on the given config files. This can (and should) be
elaborated in the future.

Michael

13 years agotestsuite: update introductory comment to test_net_regsistry.sh
Michael Adam [Thu, 19 Jun 2008 11:52:49 +0000 (13:52 +0200)]
testsuite: update introductory comment to test_net_regsistry.sh

This is now used to test rpc and local access depending on
command line parameters.

Michael

13 years agoRemove current_user_info reference from vfs_recycle.c
Volker Lendecke [Thu, 19 Jun 2008 13:48:05 +0000 (15:48 +0200)]
Remove current_user_info reference from vfs_recycle.c

13 years agoRemove current_user_info reference from vfs_fake_perms.c
Volker Lendecke [Thu, 19 Jun 2008 13:46:44 +0000 (15:46 +0200)]
Remove current_user_info reference from vfs_fake_perms.c

13 years agoRemove current_user_info reference from vfs_expand_msdfs.c
Volker Lendecke [Thu, 19 Jun 2008 13:44:15 +0000 (15:44 +0200)]
Remove current_user_info reference from vfs_expand_msdfs.c

13 years agocurrent_user is not used in vfs_aixacl2.c
Volker Lendecke [Thu, 19 Jun 2008 13:43:52 +0000 (15:43 +0200)]
current_user is not used in vfs_aixacl2.c

13 years agoRWX on a file does not imply DELETE access
Volker Lendecke [Tue, 17 Jun 2008 14:22:43 +0000 (16:22 +0200)]
RWX on a file does not imply DELETE access

Without this the changed checks in can_delete_file_in_directory give DELETE
access where there is none. So we can end up granting the ntcreate&x preparing
the unlink where we should not, which leads to a NT_STATUS_ACCESS_DENIED at
close time later, which in turn does *not* give the access denied error message
in the Windows GUI.

can_delete_file_in_directory will grant access now by looking at the directory
permissions.

13 years agoFix checks in can_delete_file_in_directory()
Volker Lendecke [Thu, 19 Jun 2008 12:53:46 +0000 (14:53 +0200)]
Fix checks in can_delete_file_in_directory()

With at least NFSv4 ACLs around the write permission for the owner is a bogus
check if we can delete a file in a directory. Like in Windows, there are two
ways which can grant us such: First, the DELETE permission on the file itself,
or if that does not help, the DELETE_CHILD permission on the directory. It
might be a bit more code that runs, but essentially we should end up with the
same set of syscalls in the non-acl case.

13 years agoRemove some code
Volker Lendecke [Thu, 19 Jun 2008 10:03:31 +0000 (12:03 +0200)]
Remove some code

Did not measure it, but I think a single write is better than a read and a
conditional branch

13 years agoFix typo
Volker Lendecke [Thu, 19 Jun 2008 09:59:55 +0000 (11:59 +0200)]
Fix typo

13 years agoFix the build on FreeBSD 4.6.2
Volker Lendecke [Thu, 19 Jun 2008 07:50:34 +0000 (09:50 +0200)]
Fix the build on FreeBSD 4.6.2

13 years agoFix 'make distclean'. delheaders: no longer exists as a dependency.
Jeremy Allison [Wed, 18 Jun 2008 19:56:36 +0000 (12:56 -0700)]
Fix 'make distclean'. delheaders: no longer exists as a dependency.
Jeremy.

13 years agoRemove prototype of unimplemented smbc_chown() function.
Derrell Lipman [Wed, 18 Jun 2008 15:00:46 +0000 (11:00 -0400)]
Remove prototype of unimplemented smbc_chown() function.

13 years agoRevert "Fix a memleak in svcctl_init_keys()"
Volker Lendecke [Wed, 18 Jun 2008 14:30:37 +0000 (16:30 +0200)]
Revert "Fix a memleak in svcctl_init_keys()"

This reverts commit b1afb31f3cadd4749bf6e3eb5d8935588bf8ebfc.

This one is very strange: I need to investigate why valgrind showed it as
leaking, and why in my initial tests this did not fail.
(cherry picked from commit 24730f5981efb920811e7929a9483bd72bb0984c)

13 years agoFix Bug #5548 (segfauls in handle_include with %m macro expansion).
Michael Adam [Wed, 18 Jun 2008 12:50:53 +0000 (14:50 +0200)]
Fix Bug #5548 (segfauls in handle_include with %m macro expansion).

In alloc_sub_basic, when expanding '%m', substitute "" instead of
NULL for remote_machine when this is NULL. Else a NULL string
is returned.

Michael

13 years agofile_access: add a function header comment for can_access_file_acl().
Michael Adam [Tue, 17 Jun 2008 22:06:46 +0000 (00:06 +0200)]
file_access: add a function header comment for can_access_file_acl().

Michael

13 years agosmbd/dir.c: remove unneeded stat buf parameter from user_can_read_file()
Michael Adam [Tue, 17 Jun 2008 22:02:28 +0000 (00:02 +0200)]
smbd/dir.c: remove unneeded stat buf parameter from user_can_read_file()

This is not needed anymore since user_can_access_file_acl() ist used.

Michael

13 years agofile_access: remove unneeded stat buf parameter from can_access_file_acl().
Michael Adam [Tue, 17 Jun 2008 21:58:49 +0000 (23:58 +0200)]
file_access: remove unneeded stat buf parameter from can_access_file_acl().

This is a security descriptor level function only.

Michael

13 years agonet sam: fix typo in comment
Michael Adam [Tue, 17 Jun 2008 21:57:26 +0000 (23:57 +0200)]
net sam: fix typo in comment

Michael

13 years agonet sam: fix typo in debug message.
Michael Adam [Tue, 17 Jun 2008 21:56:42 +0000 (23:56 +0200)]
net sam: fix typo in debug message.

Michael

13 years agotestsuite: give admin rights to testuser only for the "net rpc registry" test.
Michael Adam [Tue, 17 Jun 2008 21:54:15 +0000 (23:54 +0200)]
testsuite: give admin rights to testuser only for the "net rpc registry" test.

Remove the user from BUILTIN\Administrators at the end of the tests.
Note: BUILTIN\Administrators is not deletet at the end because that
functionality is not implemented.

Michael

13 years agotestsuite: don't give the testuser administrative rights globally.
Michael Adam [Tue, 17 Jun 2008 21:51:23 +0000 (23:51 +0200)]
testsuite: don't give the testuser administrative rights globally.

It breaks RPC-SAMBA3-GETUSERNAME for reasons I have not quite
understood yet. Somhow loosing rights fails when the user
belogns to BUILTIN\Administrators at some point.

Michael

13 years agoFix a brown paper bag segfault in clitar
Volker Lendecke [Tue, 17 Jun 2008 19:08:56 +0000 (21:08 +0200)]
Fix a brown paper bag segfault in clitar

Thanks to "No Body is Perfect" from gmail, whoever that is :-)

Volker
(cherry picked from commit 679d8dfa390601f777bfb43c02cd921eae5edcf4)

13 years agorpcclient: add more generic internal dscracknames call.
Günther Deschner [Wed, 11 Jun 2008 08:12:29 +0000 (10:12 +0200)]
rpcclient: add more generic internal dscracknames call.

Guenther

13 years agonetapi: use NetUserEnum filter in example code.
Günther Deschner [Mon, 9 Jun 2008 09:02:27 +0000 (11:02 +0200)]
netapi: use NetUserEnum filter in example code.

Guenther

13 years agonetapi: add NetUserEnum filter constants to public headers.
Günther Deschner [Tue, 17 Jun 2008 11:13:10 +0000 (13:13 +0200)]
netapi: add NetUserEnum filter constants to public headers.

Guenther

13 years agonetapi: implement NetUserEnum filters.
Günther Deschner [Mon, 9 Jun 2008 09:01:59 +0000 (11:01 +0200)]
netapi: implement NetUserEnum filters.

Guenther

13 years agore-run make idl.
Günther Deschner [Mon, 9 Jun 2008 09:01:09 +0000 (11:01 +0200)]
re-run make idl.

Guenther

13 years agonetapi: add NetUserEnum filter constants to IDL.
Günther Deschner [Mon, 9 Jun 2008 09:00:23 +0000 (11:00 +0200)]
netapi: add NetUserEnum filter constants to IDL.

Guenther

13 years agonetapi: some IDL cosmetics.
Günther Deschner [Mon, 9 Jun 2008 08:59:23 +0000 (10:59 +0200)]
netapi: some IDL cosmetics.

Guenther

13 years agonetapi: add NetRemoteTOD example code.
Günther Deschner [Tue, 17 Jun 2008 11:18:02 +0000 (13:18 +0200)]
netapi: add NetRemoteTOD example code.

Guenther

13 years agonetapi: implement NetRemoteTOD().
Günther Deschner [Fri, 6 Jun 2008 14:41:19 +0000 (16:41 +0200)]
netapi: implement NetRemoteTOD().

Guenther

13 years agonetapi: make NetRemoteTOD() headers public.
Günther Deschner [Fri, 6 Jun 2008 14:44:35 +0000 (16:44 +0200)]
netapi: make NetRemoteTOD() headers public.

Guenther

13 years agonetapi: add NetRemoteTOD() skeleton.
Günther Deschner [Fri, 6 Jun 2008 11:50:39 +0000 (13:50 +0200)]
netapi: add NetRemoteTOD() skeleton.

Guenther

13 years agore-run make idl.
Günther Deschner [Fri, 6 Jun 2008 10:51:12 +0000 (12:51 +0200)]
re-run make idl.

Guenther

13 years agonetapi: add NetRemoteTOD() to IDL.
Günther Deschner [Fri, 6 Jun 2008 10:50:02 +0000 (12:50 +0200)]
netapi: add NetRemoteTOD() to IDL.

Guenther

13 years agonet_vampire: add error and result_message to samsync_context.
Günther Deschner [Tue, 17 Jun 2008 17:49:58 +0000 (19:49 +0200)]
net_vampire: add error and result_message to samsync_context.

Guenther

13 years agonet_vampire: add domain_name to samsync_context.
Günther Deschner [Tue, 17 Jun 2008 16:02:03 +0000 (18:02 +0200)]
net_vampire: add domain_name to samsync_context.

Guenther

13 years agolibads: add ads_get_machine_kvno() to make ads_get_kvno() a bit more generic.
Günther Deschner [Tue, 17 Jun 2008 14:20:29 +0000 (16:20 +0200)]
libads: add ads_get_machine_kvno() to make ads_get_kvno() a bit more generic.

Guenther

13 years agoclikrb5: remove unrequired create_kerberos_key_from_string_direct() prototype.
Günther Deschner [Tue, 17 Jun 2008 15:58:38 +0000 (17:58 +0200)]
clikrb5: remove unrequired create_kerberos_key_from_string_direct() prototype.

Guenther

13 years agodsgetdcname: allow to use NULL mem_ctx.
Günther Deschner [Tue, 17 Jun 2008 14:18:50 +0000 (16:18 +0200)]
dsgetdcname: allow to use NULL mem_ctx.

Guenther

13 years agolibads: fix logic error in ads_get_kvno().
Günther Deschner [Tue, 17 Jun 2008 14:17:03 +0000 (16:17 +0200)]
libads: fix logic error in ads_get_kvno().

Guenther

13 years agoFix a memleak in svcctl_init_keys()
Volker Lendecke [Tue, 17 Jun 2008 14:06:42 +0000 (16:06 +0200)]
Fix a memleak in svcctl_init_keys()

13 years agoFix a segfault in wbcLookupRids
Volker Lendecke [Tue, 17 Jun 2008 13:17:22 +0000 (15:17 +0200)]
Fix a segfault in wbcLookupRids

The done: part could access uninitialized memory if intermediate
BAIL_ON_WBC_ERROR fire.

Jerry, please check!

Thanks,

Volker
(cherry picked from commit 31f4c33dcc744e81be54389756378e25aa2bb75e)

13 years agoFix a segfault in wbcLookupSid
Volker Lendecke [Tue, 17 Jun 2008 12:53:07 +0000 (14:53 +0200)]
Fix a segfault in wbcLookupSid

If the BAIL_ON_WBC_ERROR directly after wbcRequestResponse kicks in, *domain
and *name have not been initialized yet. So the cleanup routine in the done:
part of the routine (which did not check for domain!=NULL etc) would access
uninitialized memory.

Jerry, please check!

Thanks,

Volker
(cherry picked from commit 3d7e0cc40b1992f4555807acec4f00450e30e2de)

13 years agoMerge branch 'v3-3-test' of ssh://git.samba.org/data/git/samba into 3-3-abartlet
Andrew Bartlett [Tue, 17 Jun 2008 12:46:34 +0000 (22:46 +1000)]
Merge branch 'v3-3-test' of ssh://git.samba.org/data/git/samba into 3-3-abartlet

13 years agoWithout stdlib.h we don't get a prototype for free().
Andrew Bartlett [Tue, 17 Jun 2008 12:45:29 +0000 (22:45 +1000)]
Without stdlib.h we don't get a prototype for free().

This test fails if GCC emits any warnings (presumably to detect the
function propertly), but unless we include this message then free()
fail.  Why we need to call free in a configure test is probably
something to blame on valgrind...

Andrew Bartlett

13 years agoReplace a very unusual variable declaration by a more conventional one
Volker Lendecke [Tue, 17 Jun 2008 12:31:07 +0000 (14:31 +0200)]
Replace a very unusual variable declaration by a more conventional one

13 years agoman pages: Move 'smbsh' man page to the examples directory.
Karolin Seeger [Tue, 17 Jun 2008 11:18:17 +0000 (13:18 +0200)]
man pages: Move 'smbsh' man page to the examples directory.

smbsh.c is located in the examples directory. It does not make sense
to install a man page without installing the tool itself.

This fixes bug #4724.

Karolin

13 years agoFix a memleak in wbcAuthenticateUserEx()
Volker Lendecke [Tue, 17 Jun 2008 11:00:13 +0000 (13:00 +0200)]
Fix a memleak in wbcAuthenticateUserEx()
(cherry picked from commit 72b381689af9cae83ab08532cffd0188f2da4807)

13 years agoRevert "Fix a memleak caused by a crappy get_sorted_dc_list() API"
Volker Lendecke [Tue, 17 Jun 2008 10:21:03 +0000 (12:21 +0200)]
Revert "Fix a memleak caused by a crappy get_sorted_dc_list() API"

This reverts commit 2ea03a1e95a30e321e390bef9408a1215711de07.

13 years agoRevert "Fix a memleak in ads_find_dc() in case get_sorted_dc_list() fails"
Volker Lendecke [Tue, 17 Jun 2008 10:20:54 +0000 (12:20 +0200)]
Revert "Fix a memleak in ads_find_dc() in case get_sorted_dc_list() fails"

This reverts commit df8d089bc63c2a52cbdf3504cded8df620a59902.

13 years agonetapi: Fix Bug #5545 (libnetapi_init without $USER)
Günther Deschner [Tue, 17 Jun 2008 08:31:44 +0000 (10:31 +0200)]
netapi: Fix Bug #5545 (libnetapi_init without $USER)

Based on patch from Erik van Pienbroek.

Guenther

13 years agonet_vampire: fix samsync_process_database().
Günther Deschner [Tue, 17 Jun 2008 08:38:07 +0000 (10:38 +0200)]
net_vampire: fix samsync_process_database().

Turns out the password hashes are not rid encrypted in the samsync reply.

Guenther

13 years agonet_vampire: fix build warning.
Günther Deschner [Tue, 17 Jun 2008 08:36:53 +0000 (10:36 +0200)]
net_vampire: fix build warning.

Guenther

13 years agonet_vampire: use generic output filename and use correct argv element.
Günther Deschner [Mon, 16 Jun 2008 11:49:05 +0000 (13:49 +0200)]
net_vampire: use generic output filename and use correct argv element.

Guenther

13 years agonet_vampire: move ldif code out of net_rpc_samsync.c
Günther Deschner [Mon, 16 Jun 2008 10:37:57 +0000 (12:37 +0200)]
net_vampire: move ldif code out of net_rpc_samsync.c

Guenther

13 years agonet_vampire: move some samsync functions to libnet.
Günther Deschner [Mon, 16 Jun 2008 10:09:08 +0000 (12:09 +0200)]
net_vampire: move some samsync functions to libnet.

Guenther

13 years agoAdd some debug to notify
Volker Lendecke [Tue, 17 Jun 2008 08:46:20 +0000 (10:46 +0200)]
Add some debug to notify

13 years agoRemove references to SVN.
Karolin Seeger [Tue, 17 Jun 2008 08:36:51 +0000 (10:36 +0200)]
Remove references to SVN.

Karolin

13 years agoRemove reference to current_user from modules/nfs4_acls.c .
Michael Adam [Mon, 16 Jun 2008 21:50:17 +0000 (23:50 +0200)]
Remove reference to current_user from modules/nfs4_acls.c .

Michael

13 years agoidmap: Fix typos in comments.
Karolin Seeger [Tue, 17 Jun 2008 08:30:19 +0000 (10:30 +0200)]
idmap: Fix typos in comments.

Karolin

13 years agoFix typo.
Karolin Seeger [Tue, 17 Jun 2008 07:44:21 +0000 (09:44 +0200)]
Fix typo.

arguements -> arguments

Karolin

13 years agowinbind cache: Don't create SN cache entries during name-to-sid queries.
Karolin Seeger [Mon, 16 Jun 2008 13:21:28 +0000 (15:21 +0200)]
winbind cache: Don't create SN cache entries during name-to-sid queries.

Clients can request name-to-sid queries for different combinations of
upper and lower case names. We don't want to create the reverse caching
entries for each combination used.

This avoids inconsistent answers on sid-to-name queries.

Please review!

Karolin

13 years agoFix bug 5500 -- thanks to mathion at thorrovydeti.com for reporting
Volker Lendecke [Mon, 16 Jun 2008 11:27:16 +0000 (13:27 +0200)]
Fix bug 5500 -- thanks to mathion at thorrovydeti.com for reporting
(cherry picked from commit 996c3ce6f0dbe79b0679ae30afd873c24fe5b1eb)

13 years agoAdd forgotten protoypes
Volker Lendecke [Sun, 15 Jun 2008 16:43:37 +0000 (18:43 +0200)]
Add forgotten protoypes

13 years agoRemove the current_user references from open.c
Volker Lendecke [Sun, 15 Jun 2008 11:41:16 +0000 (13:41 +0200)]
Remove the current_user references from open.c

current_user_info was "only" used in a debug msg, and current_user.ut.uid is
also available via conn->server_info

13 years agoRemove the current_user reference from fake_file.c
Volker Lendecke [Sun, 15 Jun 2008 11:37:53 +0000 (13:37 +0200)]
Remove the current_user reference from fake_file.c

The current vuid is not only available there, it is also in the current
smb_request structure.

13 years agoRemove unused "extern struct current_user" from dir.c
Volker Lendecke [Sun, 15 Jun 2008 09:40:33 +0000 (11:40 +0200)]
Remove unused "extern struct current_user" from dir.c

13 years agoRemove the reference to current_user from file_access.c
Volker Lendecke [Sun, 15 Jun 2008 09:39:31 +0000 (11:39 +0200)]
Remove the reference to current_user from file_access.c

conn holds the current user info

13 years agoFix an uninitialized variable found by the IBM checker
Volker Lendecke [Sat, 14 Jun 2008 22:22:47 +0000 (00:22 +0200)]
Fix an uninitialized variable found by the IBM checker

BAIL_ON_PTR_ERROR jumps to done: which will access extra_data before it's
initialized.

Stefan, please check!

Volker
(cherry picked from commit b59636f78d351ed6d52c4a9fdccdb7850388526c)

13 years agoFix group parsing in libwbclient's copy_group_entry()
Volker Lendecke [Sat, 14 Jun 2008 22:14:27 +0000 (00:14 +0200)]
Fix group parsing in libwbclient's copy_group_entry()

This (also) fixes a flaw pointed out by the IBM checker. When verifying that I
found out that the parsing was not working as I would have expected it to.

Jerry, please check!
(cherry picked from commit c2c7790155ab02e1e351caf2bed192ce72913663)

13 years agoMove connection-specific vuid cache clear to uid.c
Volker Lendecke [Sat, 14 Jun 2008 14:59:07 +0000 (16:59 +0200)]
Move connection-specific vuid cache clear to uid.c