kai/samba-autobuild/.git
10 years agoFix typo reported by Söderlund David <david.soderlund@baesystems.se>.
John H Terpstra [Wed, 16 Jun 2010 13:56:42 +0000 (08:56 -0500)]
Fix typo reported by Söderlund David <david.soderlund@baesystems.se>.

10 years agos3-auth: in make_user_info_for_reply_enc make sure to check length and data
Günther Deschner [Wed, 16 Jun 2010 12:18:45 +0000 (14:18 +0200)]
s3-auth: in make_user_info_for_reply_enc make sure to check length and data
pointer of nt and lm hash.

This fixes kernel cifs client with sec=ntlmv2.

Guenther

10 years agos3-build: allow to build bin/ndrdump4 (just as bin/smbtorture4)
Günther Deschner [Wed, 16 Jun 2010 12:17:44 +0000 (14:17 +0200)]
s3-build: allow to build bin/ndrdump4 (just as bin/smbtorture4)

Jelmer, please check.

Guenther

10 years agontlmssp: add decode_NTLMv2_RESPONSE to IDL.
Günther Deschner [Wed, 16 Jun 2010 12:16:57 +0000 (14:16 +0200)]
ntlmssp: add decode_NTLMv2_RESPONSE to IDL.

Guenther

10 years agos3-auth: fix debug message in check_winbind_security().
Günther Deschner [Wed, 16 Jun 2010 10:31:11 +0000 (12:31 +0200)]
s3-auth: fix debug message in check_winbind_security().

Guenther

10 years agos3-tdb: Added missing out of memory check in rename_file_with_suffix().
Andreas Schneider [Tue, 15 Jun 2010 12:25:12 +0000 (14:25 +0200)]
s3-tdb: Added missing out of memory check in rename_file_with_suffix().

10 years agos4:lib: merge LDB_WRAP and LDBSAMBA and make LDBSAMBA a library.
Stefan Metzmacher [Wed, 16 Jun 2010 11:43:38 +0000 (13:43 +0200)]
s4:lib: merge LDB_WRAP and LDBSAMBA and make LDBSAMBA a library.

This is needed to remove samba specifc symbols from the bundled
ldb, in order to get the ABI right.

metze

Signed-off-by: Andreas Schneider <asn@samba.org>
10 years agos4-smbtorture: only pull info when status code indicates success in smbcli_rap_netpri...
Günther Deschner [Wed, 16 Jun 2010 09:03:31 +0000 (11:03 +0200)]
s4-smbtorture: only pull info when status code indicates success in smbcli_rap_netprintqgetinfo().

Guenther

10 years agoRevert "s4-smbtorture: only pull info when status code indicates success in smbcli_ra...
Günther Deschner [Wed, 16 Jun 2010 10:18:32 +0000 (12:18 +0200)]
Revert "s4-smbtorture: only pull info when status code indicates success in smbcli_rap_netprintqgetinfo()."

This reverts commit 1f1c04010a55e67d8dc2110276eed4cf2a8a0afa.

10 years agopidl: make sure to fill in cli->pipes_struct->hdr_req.opnum in s3 server dispatch...
Günther Deschner [Wed, 16 Jun 2010 10:07:43 +0000 (12:07 +0200)]
pidl: make sure to fill in cli->pipes_struct->hdr_req.opnum in s3 server dispatch tables.

Guenther

10 years agos3-lanman: Fix return code for "" printqname in api_DosPrintQGetInfo().
Günther Deschner [Wed, 16 Jun 2010 09:04:34 +0000 (11:04 +0200)]
s3-lanman: Fix return code for "" printqname in api_DosPrintQGetInfo().

Guenther

10 years agos4-smbtorture: test smbcli_rap_netprintqgetinfo() with "" printqname.
Günther Deschner [Wed, 16 Jun 2010 09:04:12 +0000 (11:04 +0200)]
s4-smbtorture: test smbcli_rap_netprintqgetinfo() with "" printqname.

Guenther

10 years agos4-smbtorture: only pull info when status code indicates success in smbcli_rap_netpri...
Günther Deschner [Wed, 16 Jun 2010 09:03:31 +0000 (11:03 +0200)]
s4-smbtorture: only pull info when status code indicates success in smbcli_rap_netprintqgetinfo().

Guenther

10 years agos3-printing: add BUILTIN\Print Operators as FULL CONTROL to default sd.
Günther Deschner [Fri, 11 Jun 2010 09:24:06 +0000 (11:24 +0200)]
s3-printing: add BUILTIN\Print Operators as FULL CONTROL to default sd.

Guenther

10 years agos3-spoolss: Provide a memory context for clean_up_driver_struct().
Andreas Schneider [Wed, 16 Jun 2010 09:44:36 +0000 (11:44 +0200)]
s3-spoolss: Provide a memory context for clean_up_driver_struct().

If we use a stack variable to setup spoolss_AddDriverInfoCtr this would
segfault with a talloc bad magic value.

10 years agos4:dsdb Allow renames with (now removed) linked attributes
Andrew Bartlett [Wed, 16 Jun 2010 02:01:10 +0000 (12:01 +1000)]
s4:dsdb Allow renames with (now removed) linked attributes

It is important to allow the rename, even if we just have one-way
links, as this happens on deleted objects, which have the backlinks
alredy removed by repl_meta_data.

Andrew Bartlett

10 years agos4:selftest Change domain name for functional level 2000 DC
Andrew Bartlett [Tue, 15 Jun 2010 23:16:05 +0000 (09:16 +1000)]
s4:selftest Change domain name for functional level 2000 DC

10 years agos4:libnet Remove 'ads min function level' checks.
Andrew Bartlett [Tue, 15 Jun 2010 13:01:51 +0000 (23:01 +1000)]
s4:libnet Remove 'ads min function level' checks.

We support Windows 2000 native now.

Andrew Bartlett

10 years agos4:dsdb Fix linked_attributes to cope with the Feb 2010 changes to DLIST
Andrew Bartlett [Tue, 15 Jun 2010 12:57:14 +0000 (22:57 +1000)]
s4:dsdb Fix linked_attributes to cope with the Feb 2010 changes to DLIST

The DLIST macros changed in behaviour in Feb 2010, and walking the
lists backwards is no longer safe if you don't use the macros.

Andrew Bartlett

10 years agos4:dsdb Assert that we can't get backlinks as input in linked_attributes
Andrew Bartlett [Tue, 15 Jun 2010 12:26:22 +0000 (22:26 +1000)]
s4:dsdb Assert that we can't get backlinks as input in linked_attributes

The objectclass_attr module should prevent users creating such links,
and the mrepl_meta_data module should only create them in functional
level 2003 or above.

Andrew Bartlett

10 years agos4:selftest Add test environment for functional level 2000
Andrew Bartlett [Tue, 15 Jun 2010 12:24:36 +0000 (22:24 +1000)]
s4:selftest Add test environment for functional level 2000

This required that we pass the name of the realm down as a parameter,
so we can start up two different realms.

Andrew Bartlett

10 years agos4:provision Add import for DS_DOMAIN_FUNCTION_2000
Andrew Bartlett [Tue, 15 Jun 2010 10:45:25 +0000 (20:45 +1000)]
s4:provision Add import for DS_DOMAIN_FUNCTION_2000

10 years agos4:provision Allow functional level 2000 to be chosen
Andrew Bartlett [Tue, 15 Jun 2010 09:52:58 +0000 (19:52 +1000)]
s4:provision Allow functional level 2000 to be chosen

10 years agos4:selftest Add vampire_dc test environment
Andrew Bartlett [Thu, 11 Mar 2010 23:36:12 +0000 (10:36 +1100)]
s4:selftest Add vampire_dc test environment

This starts a domain controller, after running 'net vampire' to
populate it.  We don't use it as the 'all' environment yet, as the
rest of the code isn't quite ready to handle it.

Andrew Bartlett

10 years agos4:dsdb use dsdb_module_modify() rather than ldb_next_request()
Andrew Bartlett [Mon, 14 Jun 2010 05:50:13 +0000 (15:50 +1000)]
s4:dsdb use dsdb_module_modify() rather than ldb_next_request()

This does exactly the same thing, but with less code.

Andrew Bartlett

10 years agos4:dsdb Handle backlinks for Windows 2000 level linked attributes
Andrew Bartlett [Sun, 13 Jun 2010 05:54:23 +0000 (15:54 +1000)]
s4:dsdb Handle backlinks for Windows 2000 level linked attributes

This revives the code from 5964acfa741d691c0196f91c0796122ec025f177,
before tridge and I simplified this too much, and removed the Windows
2000 functional level linked attribute support.

By telling the linked_attributes module that repl_meta_data has
handled the links, we avoid a conflict for the new style (functional
level 2003 and above) linked attributes.  However, we still need
backlinks for 2000 style linked attributes, so this allows that code
in the linked_attributes module to be revived to handle those.

Andrew Bartlett

10 years agos4:dsdb Add control for signaling between repl_meta_data and linked_attributes
Andrew Bartlett [Mon, 14 Jun 2010 05:30:36 +0000 (15:30 +1000)]
s4:dsdb Add control for signaling between repl_meta_data and linked_attributes

This control will allow the linked_attributes module to know if
repl_meta_data has already handled the creation of forward and back
links.

Andrew Bartlett

10 years agoRemove unused function.
Jeremy Allison [Tue, 15 Jun 2010 22:33:44 +0000 (15:33 -0700)]
Remove unused function.

10 years agowaf: Fix installation of pidl manapges.
Jelmer Vernooij [Tue, 15 Jun 2010 22:00:01 +0000 (00:00 +0200)]
waf: Fix installation of pidl manapges.

10 years agos4 torture: RAW-SEARCH: break out some of the old search levels
Aravind Srinivasan [Tue, 15 Jun 2010 18:21:34 +0000 (11:21 -0700)]
s4 torture: RAW-SEARCH: break out some of the old search levels

* Added two new parameters: raw_search_search and raw_ea_size which
  can be enabled/disabled based on whether the server supports
  RAW_SEARCH_SEARCH and/or RAW_SEARCH_EA_SIZE levels

* Skip unsupported levels from the server and give a warning rather
  than failing.

Signed-off-by: Tim Prouty <tprouty@samba.org>
10 years agos4 torture: RAW-SEARCH: Only test supported info levels
Tim Prouty [Mon, 14 Jun 2010 23:50:29 +0000 (16:50 -0700)]
s4 torture: RAW-SEARCH: Only test supported info levels

10 years agos4-waf: Fix build of libldb_ildap against system ldb.
Jelmer Vernooij [Tue, 15 Jun 2010 18:52:01 +0000 (20:52 +0200)]
s4-waf: Fix build of libldb_ildap against system ldb.

10 years agowafsamba: Fix include path inheritance from module subsystems.
Jelmer Vernooij [Tue, 15 Jun 2010 18:35:22 +0000 (20:35 +0200)]
wafsamba: Fix include path inheritance from module subsystems.

10 years agodcerpc-samr: Fix library name.
Jelmer Vernooij [Tue, 15 Jun 2010 14:38:15 +0000 (16:38 +0200)]
dcerpc-samr: Fix library name.

10 years agoAttempt to fix SamDB test infrastructure (not used in Samba anywhere, only in OpenCha...
Jelmer Vernooij [Mon, 14 Jun 2010 00:15:32 +0000 (02:15 +0200)]
Attempt to fix SamDB test infrastructure (not used in Samba anywhere, only in OpenChange).

10 years agoldb: Bump version number, use same ABI version for Samba4 and non-Samba 4 versions.s
Jelmer Vernooij [Tue, 15 Jun 2010 11:12:23 +0000 (13:12 +0200)]
ldb: Bump version number, use same ABI version for Samba4 and non-Samba 4 versions.s

10 years agoldb: Fix included ldb build.
Jelmer Vernooij [Tue, 15 Jun 2010 00:46:16 +0000 (02:46 +0200)]
ldb: Fix included ldb build.

10 years agowafsamba: Fix filenames for ldb modules.
Jelmer Vernooij [Mon, 14 Jun 2010 23:35:42 +0000 (01:35 +0200)]
wafsamba: Fix filenames for ldb modules.

10 years agowafsamba: Fix building of modules as shared libraries.
Jelmer Vernooij [Mon, 14 Jun 2010 23:24:20 +0000 (01:24 +0200)]
wafsamba: Fix building of modules as shared libraries.

10 years agowafsamba: Improve assertion error message to include the module.
Jelmer Vernooij [Mon, 14 Jun 2010 23:00:40 +0000 (01:00 +0200)]
wafsamba: Improve assertion error message to include the module.

10 years agoldb: Only build standard ldb modules when building bundled ldb.
Jelmer Vernooij [Mon, 14 Jun 2010 22:59:49 +0000 (00:59 +0200)]
ldb: Only build standard ldb modules when building bundled ldb.

10 years agodsdb: Fix includes when building against system ldb.
Jelmer Vernooij [Mon, 14 Jun 2010 22:55:03 +0000 (00:55 +0200)]
dsdb: Fix includes when building against system ldb.

10 years agowafsamba: Only add init function if not building module as shared library.
Jelmer Vernooij [Thu, 10 Jun 2010 11:02:59 +0000 (13:02 +0200)]
wafsamba: Only add init function if not building module as shared library.

10 years agodsdb: Build modules as external modules when using system ldb.
Jelmer Vernooij [Wed, 2 Jun 2010 11:37:15 +0000 (13:37 +0200)]
dsdb: Build modules as external modules when using system ldb.

10 years agoldb-samba: Add missing dependency on credentials code.
Jelmer Vernooij [Tue, 1 Jun 2010 11:28:50 +0000 (13:28 +0200)]
ldb-samba: Add missing dependency on credentials code.

10 years agos3-waf: fix the build.
Günther Deschner [Tue, 15 Jun 2010 09:43:30 +0000 (11:43 +0200)]
s3-waf: fix the build.

Guenther

10 years agos4:dsdb Move linked attribute restrictions to objectclass_attrs
Andrew Bartlett [Mon, 14 Jun 2010 03:19:43 +0000 (13:19 +1000)]
s4:dsdb Move linked attribute restrictions to objectclass_attrs

This puts more of the schema restrictions in one place.

Andrew Bartlett

10 years agos4:dsdb Add const to dsdb_dn functions that operate on an ldb_val.
Andrew Bartlett [Mon, 14 Jun 2010 03:27:59 +0000 (13:27 +1000)]
s4:dsdb Add const to dsdb_dn functions that operate on an ldb_val.

Andrew Bartlett

10 years agos4:selftest Remove unused basedn specification in selftest env setup
Andrew Bartlett [Tue, 15 Jun 2010 00:20:37 +0000 (10:20 +1000)]
s4:selftest Remove unused basedn specification in selftest env setup

10 years agos4:selftest Remove becomedc tests from knownfail, these should now pass
Andrew Bartlett [Sat, 12 Jun 2010 03:24:57 +0000 (13:24 +1000)]
s4:selftest Remove becomedc tests from knownfail, these should now pass

Signed-off-by: Kamen Mazdrashki <kamenim@samba.org>
10 years agos4:dsdb Rework the vampire schema handling to convert 3 times.
Andrew Bartlett [Sat, 12 Jun 2010 01:05:47 +0000 (11:05 +1000)]
s4:dsdb Rework the vampire schema handling to convert 3 times.

This seems like a lot of duplicate work, but by the end we should
have, in normal LDB format, the remote DRS schema, having bootstrapped
it with the locally loaded schema.

The multiple steps are to resolve the problems with references to
schema items that we don't 'yet' know about.

Andrew Bartlett

Signed-off-by: Kamen Mazdrashki <kamenim@samba.org>
10 years agos4:provision Allow a specific prefix map to be loaded into a new schema provision
Andrew Bartlett [Thu, 10 Jun 2010 11:33:45 +0000 (21:33 +1000)]
s4:provision Allow a specific prefix map to be loaded into a new schema provision

This allows the prefixMap from a DRS server to be used when loading
the schema from the local files.  This helps us then import other
schema with this map in place.

Andrew Bartlett

Signed-off-by: Kamen Mazdrashki <kamenim@samba.org>
10 years agos4:dsdb Keep the DRS-based prefix map for use in provision-based schema
Andrew Bartlett [Wed, 9 Jun 2010 11:53:01 +0000 (21:53 +1000)]
s4:dsdb Keep the DRS-based prefix map for use in provision-based schema

We need to use the remote prefix map for the provision schema, or else
we can't decode new, non-standard attributes into OIDs.  Then once we
decode that schema, we can try again and get them properly translated.

Andrew Bartlett

Signed-off-by: Kamen Mazdrashki <kamenim@samba.org>
10 years agos4:dsdb Allow the setting an override on the schema
Andrew Bartlett [Wed, 9 Jun 2010 10:52:02 +0000 (20:52 +1000)]
s4:dsdb Allow the setting an override on the schema

The change here is to try and convert a per the previous rules, but if
we don't know a particular OID as a attributeID, then store it as an
OID (for example).  This allows known values to be converted as
before, but still copes with unknown values.

Andrew Bartlett

Signed-off-by: Kamen Mazdrashki <kamenim@samba.org>
10 years agos4:dsdb Use the schema from our local provision to decode the schema
Andrew Bartlett [Wed, 9 Jun 2010 08:57:52 +0000 (18:57 +1000)]
s4:dsdb Use the schema from our local provision to decode the schema

This works on the assumption that the schema partition can only
contain schema objects.

We may need to pass down some kind of 'relax' to the DRS -> LDB
conversion code, so that it allows incomplete conversions, so that we
don't fail if a new attribute is present, and we can't decode it.
This would then be resolved the second time we do the conversion.

Andrew Bartlett

Signed-off-by: Kamen Mazdrashki <kamenim@samba.org>
10 years agos4:torture Rework NET-API-BECOMEDC test to use libnet_vampire callbacks.
Andrew Bartlett [Sat, 12 Jun 2010 07:24:26 +0000 (17:24 +1000)]
s4:torture Rework NET-API-BECOMEDC test to use libnet_vampire callbacks.

The libnet_vampire code was derived from this code in the first place,
but has continued to evolve, while this code has often bitrotted.
This avoids the needless duplication of the callbacks, while keeping
the toture wrapper.

Andrew Bartlett

Signed-off-by: Kamen Mazdrashki <kamenim@samba.org>
10 years agos4:libnet Steal ldb and lp_ctx from python result into correct structures.
Andrew Bartlett [Sat, 12 Jun 2010 07:23:32 +0000 (17:23 +1000)]
s4:libnet Steal ldb and lp_ctx from python result into correct structures.

Signed-off-by: Kamen Mazdrashki <kamenim@samba.org>
10 years agos4:libnet Make the libnet_vampire default callbacks non-static
Andrew Bartlett [Sat, 12 Jun 2010 07:22:20 +0000 (17:22 +1000)]
s4:libnet Make the libnet_vampire default callbacks non-static

These are intended to be called from the NET-API-BECOMEDC torture test
to avoid duplication of code.

Andrew Bartlett

Signed-off-by: Kamen Mazdrashki <kamenim@samba.org>
10 years agos4 torture: RAW-WRITE should check lockread_supported
Zachary Loafman [Wed, 18 Nov 2009 00:21:44 +0000 (00:21 +0000)]
s4 torture: RAW-WRITE should check lockread_supported

Signed-off-by: Tim Prouty <tprouty@samba.org>
10 years agoSMB2 correctness fix. As we've already returned the credits in an interim
Jeremy Allison [Mon, 14 Jun 2010 23:58:15 +0000 (16:58 -0700)]
SMB2 correctness fix. As we've already returned the credits in an interim
response, don't add more in the final return.

Jeremy.

10 years agoFix warning messages about unused result of talloc_move. We're really talloc_steal...
Jeremy Allison [Mon, 14 Jun 2010 22:55:19 +0000 (15:55 -0700)]
Fix warning messages about unused result of talloc_move. We're really talloc_steal'ing here.

10 years agos4:Descriptor tests clean-up.
Nadezhda Ivanova [Mon, 14 Jun 2010 12:12:00 +0000 (15:12 +0300)]
s4:Descriptor tests clean-up.

A bit of refactoring and modified the tests to use encrypted connection so that they pass against Windows unconditionally.

10 years agos4:provision: Make gc._msdcs DNS entries A/AAAA records
Andrew Kroeger [Sun, 13 Jun 2010 15:48:31 +0000 (10:48 -0500)]
s4:provision: Make gc._msdcs DNS entries A/AAAA records

When adding an additional DC as a GC server, the new DC attempts to register its
own gc._msdcs records.  If the existing gc._msdcs record is a CNAME, BIND fails
the update with the message "attempt to add non-CNAME alongside CNAME ignored",
and the new DC is not registered as a GC server.

The A & AAAA record types for gc._msdcs have been verified against the DNS
server of a W2K8 DC.

10 years agos3: Make g_smb_perfcount_handlers static
Volker Lendecke [Mon, 14 Jun 2010 10:04:18 +0000 (12:04 +0200)]
s3: Make g_smb_perfcount_handlers static

10 years agos4:SAMR server - cosmetic fix
Matthias Dieter Wallnöfer [Mon, 14 Jun 2010 09:41:32 +0000 (11:41 +0200)]
s4:SAMR server - cosmetic fix

10 years agos4:SAMR server - on alias search operations do never use the domain DN as base dn
Matthias Dieter Wallnöfer [Mon, 14 Jun 2010 09:30:27 +0000 (11:30 +0200)]
s4:SAMR server - on alias search operations do never use the domain DN as base dn

Aliases (especially in the "builtin" domain) are often domain-independant.

10 years agos3: Remove some dispensable ()
Volker Lendecke [Mon, 14 Jun 2010 09:10:16 +0000 (11:10 +0200)]
s3: Remove some dispensable ()

10 years agos4-waf: Fix installation of .so links for libraries that are not bundled but have...
Jelmer Vernooij [Sun, 13 Jun 2010 18:52:47 +0000 (20:52 +0200)]
s4-waf: Fix installation of .so links for libraries that are not bundled but have a mangled name.

10 years agolibrpc: Install the right headers.
Jelmer Vernooij [Sun, 13 Jun 2010 17:55:53 +0000 (19:55 +0200)]
librpc: Install the right headers.

10 years agoSupport system talloc/tevent headers.
Jelmer Vernooij [Sun, 13 Jun 2010 17:39:20 +0000 (19:39 +0200)]
Support system talloc/tevent headers.

10 years agolibgpo: Use system libraries if possible.
Jelmer Vernooij [Sun, 13 Jun 2010 17:35:48 +0000 (19:35 +0200)]
libgpo: Use system libraries if possible.

10 years agolibrpc: Fix netlogon.h file to install - not the torture one but the one
Jelmer Vernooij [Sun, 13 Jun 2010 17:21:17 +0000 (19:21 +0200)]
librpc: Fix netlogon.h file to install - not the torture one but the one
generated by pidl.

10 years agoparam/share: Use static prototypes.
Jelmer Vernooij [Sun, 13 Jun 2010 17:21:02 +0000 (19:21 +0200)]
param/share: Use static prototypes.

10 years agoDo not use headermap.txt for the header installation
Thomas Nagy [Mon, 24 May 2010 00:26:36 +0000 (02:26 +0200)]
Do not use headermap.txt for the header installation

Try to find the headers by searching on the filesystem. Warn when
a public header replacement cannot be found (talloc.h, ...).

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
10 years agos4:fix allocated control OIDs for "password_hash" LDB module
Matthias Dieter Wallnöfer [Sun, 13 Jun 2010 16:19:37 +0000 (18:19 +0200)]
s4:fix allocated control OIDs for "password_hash" LDB module

The password hash module controls overlapped others. Sorry, but the
"schema_samba4.ldif" hasn't been kept up-to-date.

10 years agos4-provision: Use logger in provision backends.
Jelmer Vernooij [Sun, 13 Jun 2010 15:43:25 +0000 (17:43 +0200)]
s4-provision: Use logger in provision backends.

10 years agos4-test: Use smb.conf path set in environment rather than using
Jelmer Vernooij [Sun, 13 Jun 2010 14:38:24 +0000 (16:38 +0200)]
s4-test: Use smb.conf path set in environment rather than using
command-line options.

This is the first step towards supporting custom test runners.

10 years agoRemove unused version options for subunitrun.
Jelmer Vernooij [Sun, 13 Jun 2010 14:02:26 +0000 (16:02 +0200)]
Remove unused version options for subunitrun.

10 years agoFriendlier message.
Jelmer Vernooij [Sun, 13 Jun 2010 13:57:44 +0000 (15:57 +0200)]
Friendlier message.

10 years agoupgradeprovision: Use logging infrastructure.
Jelmer Vernooij [Sun, 13 Jun 2010 13:32:41 +0000 (15:32 +0200)]
upgradeprovision: Use logging infrastructure.

10 years agoupgrade: Properly cancel/commit transactions in a couple more places.
Jelmer Vernooij [Sun, 13 Jun 2010 13:13:12 +0000 (15:13 +0200)]
upgrade: Properly cancel/commit transactions in a couple more places.

10 years agos4-python: Start using standard python logging infrastructure rather
Jelmer Vernooij [Sun, 13 Jun 2010 13:05:50 +0000 (15:05 +0200)]
s4-python: Start using standard python logging infrastructure rather
than simple messaging callbacks.

10 years agoFix aio_read detection for -lrt
Volker Lendecke [Sun, 13 Jun 2010 12:13:42 +0000 (14:13 +0200)]
Fix aio_read detection for -lrt

10 years agos3: Remove fsp_belongs_conn
Volker Lendecke [Sun, 13 Jun 2010 13:17:31 +0000 (15:17 +0200)]
s3: Remove fsp_belongs_conn

check_open_fsp does exactly the same

10 years agos3: Remove some leftovers from macros
Volker Lendecke [Sun, 13 Jun 2010 13:01:34 +0000 (15:01 +0200)]
s3: Remove some leftovers from macros

check_fsp and check_fsp_open used to be macros

10 years agos3: Remove the pointless PRINTERNAME macro
Volker Lendecke [Sun, 13 Jun 2010 10:11:26 +0000 (12:11 +0200)]
s3: Remove the pointless PRINTERNAME macro

10 years agos3: Remove the pointless SERVICE macro
Volker Lendecke [Sun, 13 Jun 2010 10:07:37 +0000 (12:07 +0200)]
s3: Remove the pointless SERVICE macro

10 years agos4:dcesrv_samr_GetGroupsForUser - return error code if a SID wasn't found
Matthias Dieter Wallnöfer [Sat, 12 Jun 2010 15:50:52 +0000 (17:50 +0200)]
s4:dcesrv_samr_GetGroupsForUser - return error code if a SID wasn't found

This shouldn't happen since SIDs are mandatory for security objects

10 years agos4:dcesrv_samr_QueryGroupMember/GetMembersInAlias - unify the structure
Matthias Dieter Wallnöfer [Sat, 12 Jun 2010 15:45:14 +0000 (17:45 +0200)]
s4:dcesrv_samr_QueryGroupMember/GetMembersInAlias - unify the structure

Mostly cosmetic fixes

10 years agos4:password_hash LDB module - this does really deactivate the MS LAN manager hash
Matthias Dieter Wallnöfer [Sat, 12 Jun 2010 11:22:54 +0000 (13:22 +0200)]
s4:password_hash LDB module - this does really deactivate the MS LAN manager hash

Previously, only the conversion from cleartext to the LM hash was deactivated,
and not when the user specified it directly through "dBCSPwd".

10 years agos4:password_hash LDB module - fix comment
Matthias Dieter Wallnöfer [Sat, 12 Jun 2010 11:22:22 +0000 (13:22 +0200)]
s4:password_hash LDB module - fix comment

10 years agos4:torture - SAMR testsuite - now we do support "GetAliasMembership" as expected
Matthias Dieter Wallnöfer [Sat, 12 Jun 2010 10:17:33 +0000 (12:17 +0200)]
s4:torture - SAMR testsuite - now we do support "GetAliasMembership" as expected

10 years agos4:dcesrv_samr_GetAliasMembership - provide a correct implementation
Matthias Dieter Wallnöfer [Sat, 12 Jun 2010 10:14:59 +0000 (12:14 +0200)]
s4:dcesrv_samr_GetAliasMembership - provide a correct implementation

We could also have no valid SID specified at all and also then we have to
return an empty array with "NT_STATUS_OK". This shows the torture testsuite.

10 years agos4:dcesrv_samr_EnumDomainGroups/Aliases - when we don't get a SID then the database...
Matthias Dieter Wallnöfer [Sat, 12 Jun 2010 09:39:25 +0000 (11:39 +0200)]
s4:dcesrv_samr_EnumDomainGroups/Aliases - when we don't get a SID then the database is corrupted

Group/User/Alias entries do always have a SID (it's a mandatory attribute in the
SAM directory)!

10 years agos4:dcesrv_samr_QueryAliasInfo - return "NT_STATUS_NO_SUCH_ALIAS" when it wasn't found
Matthias Dieter Wallnöfer [Fri, 11 Jun 2010 22:06:36 +0000 (00:06 +0200)]
s4:dcesrv_samr_QueryAliasInfo - return "NT_STATUS_NO_SUCH_ALIAS" when it wasn't found

10 years agos4:dcesrv_samr_QueryGroupInfo - make it more like "QueryAliasInfo"
Matthias Dieter Wallnöfer [Fri, 11 Jun 2010 22:06:07 +0000 (00:06 +0200)]
s4:dcesrv_samr_QueryGroupInfo - make it more like "QueryAliasInfo"

10 years agos4:dcesrv_samr_QueryUserInfo - minor fixes
Matthias Dieter Wallnöfer [Fri, 11 Jun 2010 21:59:12 +0000 (23:59 +0200)]
s4:dcesrv_samr_QueryUserInfo - minor fixes

Return  "NT_STATUS_NO_SUCH_USER" when user account doesn't exist.

10 years agos4:dcesrv_samr_QueryDomainInfo - allocate the "info" structure only when really needed
Matthias Dieter Wallnöfer [Fri, 11 Jun 2010 21:57:39 +0000 (23:57 +0200)]
s4:dcesrv_samr_QueryDomainInfo - allocate the "info" structure only when really needed

That means the allocation should move after the lookup (as it is on
"QueryUserInfo"). Return "NT_STATUS_NO_SUCH_DOMAIN" on an invalid domain.

10 years agos4:dcesrv_samr_EnumDomainGroups - mostly small fixes
Matthias Dieter Wallnöfer [Fri, 11 Jun 2010 21:44:46 +0000 (23:44 +0200)]
s4:dcesrv_samr_EnumDomainGroups - mostly small fixes

10 years agos4:dcesrv_samr_EnumDomainAliases - return an empty array also when no entry was returned
Matthias Dieter Wallnöfer [Sat, 12 Jun 2010 09:49:26 +0000 (11:49 +0200)]
s4:dcesrv_samr_EnumDomainAliases - return an empty array also when no entry was returned