Stefan Metzmacher [Thu, 18 Dec 2008 14:02:42 +0000 (15:02 +0100)]
s3:cluster: register the client connection via CTDB_CONTROL_TCP_ADD
This means we correctly pass IPv6 addresses too.
(CTDB_CONTROL_TCP_CLIENT was IPv4 only)
metze
Volker Lendecke [Tue, 30 Dec 2008 14:47:06 +0000 (15:47 +0100)]
Fix a memory leak in cups_pull_comment_location
We allocated "request" with ippNew, so we also should ippDelete it.
Volker Lendecke [Tue, 30 Dec 2008 13:05:26 +0000 (14:05 +0100)]
Fix a spinning smbd when printing
Without this, we end up adding more than one timed event. In the event handler
print_notify_event_send_messages() only one event will be deleted, all others
will fire indefinitely.
Volker Lendecke [Mon, 29 Dec 2008 21:07:56 +0000 (22:07 +0100)]
Print the vuid in BENCH-SESSSETUP
Volker Lendecke [Mon, 29 Dec 2008 21:06:08 +0000 (22:06 +0100)]
Second part of the bugfix for #5933
Incrementing the next vuid did not correctly overflow
Now we survive BENCH-SESSSETUP with -o 100000. Takes a while though :-)
Thanks a lot to Ofer Tal <otsmb@shmoop.org> for reporting #5933
Volker Lendecke [Mon, 29 Dec 2008 21:01:57 +0000 (22:01 +0100)]
First part of bugfix for #5933
Ofer Tal <otsmb@shmoop.org> fully correctly noted that we're incrementing
num_validated_vuids twice per session setup, but decrement it only once.
Looking at sesssetup.c we always call register_initial_vuid() before
register_existing_vuid(), so there's no point in incrementing it in
register_existing_vuid().
Jeremy, please check!
Volker Lendecke [Mon, 29 Dec 2008 20:07:41 +0000 (21:07 +0100)]
Move a comment to its place
Volker Lendecke [Mon, 29 Dec 2008 20:03:15 +0000 (21:03 +0100)]
Simplify invalidate_vuid slightly
get_valid_user_struct_internal() checks for UID_FIELD_INVALID itself
Volker Lendecke [Mon, 29 Dec 2008 20:01:13 +0000 (21:01 +0100)]
Simplify is_partial_auth_vuid slightly
Volker Lendecke [Mon, 29 Dec 2008 18:50:39 +0000 (19:50 +0100)]
Simplify invalidate_all_vuids() slightly
invalidate_vuid takes care of removing the user_struct from validated_users
Stefan Metzmacher [Tue, 30 Dec 2008 09:09:59 +0000 (10:09 +0100)]
Fix the merged build
metze
Stefan Metzmacher [Tue, 30 Dec 2008 07:58:52 +0000 (08:58 +0100)]
lib/tevent: fix standalone make distclean realdistclean
Bug report by Brad Hards <bradh@frogmouth.net>.
metze
Stefan Metzmacher [Mon, 29 Dec 2008 20:07:11 +0000 (21:07 +0100)]
pidl: don't generate invalid C code
When we don't know how to handle a type for the python bindings,
we should not generate invalid C code.
Jelmer: please fix do the full fix for this.
metze
Stefan Metzmacher [Mon, 15 Dec 2008 18:28:27 +0000 (19:28 +0100)]
s3:pdb_tdb: store the next rid counter in passdb.tdb instead of winbind_idmap.tdb
This upgrades the TDBSAM_VERSION to 4 and SAMU_BUFFER_V4.
metze
Stefan Metzmacher [Tue, 16 Dec 2008 10:51:14 +0000 (11:51 +0100)]
s3:passdb: add SAMU_BUFFER_V4 with no changes
The upgrade is required because of the followin TDBSAM_VERSION
upgrade.
metze
Stefan Metzmacher [Mon, 15 Dec 2008 17:46:37 +0000 (18:46 +0100)]
s3:passdb: make marshalling struct samu from and to a buffer more generic
This marshalling isn't specific to tdbsam and it's
ugly to have the related functions in two different files.
metze
Stefan Metzmacher [Mon, 29 Dec 2008 19:55:02 +0000 (20:55 +0100)]
s4:cluster: fix dependency to TDB_WRAP
metze
Stefan Metzmacher [Mon, 29 Dec 2008 19:24:57 +0000 (20:24 +0100)]
s4:lib/tevent: rename structs
list=""
list="$list event_context:tevent_context"
list="$list fd_event:tevent_fd"
list="$list timed_event:tevent_timer"
for s in $list; do
o=`echo $s | cut -d ':' -f1`
n=`echo $s | cut -d ':' -f2`
r=`git grep "struct $o" |cut -d ':' -f1 |sort -u`
files=`echo "$r" | grep -v source3 | grep -v nsswitch | grep -v packaging4`
for f in $files; do
cat $f | sed -e "s/struct $o/struct $n/g" > $f.tmp
mv $f.tmp $f
done
done
metze
Stefan Metzmacher [Mon, 29 Dec 2008 16:48:35 +0000 (17:48 +0100)]
s4:pvfs_aio: use tevent
metze
Stefan Metzmacher [Mon, 29 Dec 2008 16:33:51 +0000 (17:33 +0100)]
s4:sys_lease_linux: use tevent
metze
Volker Lendecke [Mon, 29 Dec 2008 16:08:38 +0000 (17:08 +0100)]
Fix SESSSETUP_BENCH torture test for long runtimes
deadtime hits without any files open. To enable long runtimes, open a file with
delete_on_close set.
Stefan Metzmacher [Mon, 29 Dec 2008 10:02:32 +0000 (11:02 +0100)]
s4:cluster: remove old/broken ctdb code
We don't need a full copy of ctdb...
If we want to readd cluster support,
we should just use a ctdb client library.
metze
Stefan Metzmacher [Mon, 29 Dec 2008 10:24:05 +0000 (11:24 +0100)]
s4: remove unused dbwrap code
If we readd this later, we should share the code with
samba3 and make it async/non-blocking.
metze
Stefan Metzmacher [Mon, 29 Dec 2008 10:52:53 +0000 (11:52 +0100)]
s4: Revert "r24284: change brlock_tdb.c to use the dbwrap API. This actually makes the"
This reverts commit
4792285282e2ec78ccb0ebc3cac6465d1d26ef10.
Conflicts:
source4/ntvfs/common/brlock_tdb.c
source4/ntvfs/common/config.mk
Volker Lendecke [Mon, 22 Dec 2008 21:42:44 +0000 (22:42 +0100)]
Add code to test write_data_iov a bit
Volker Lendecke [Mon, 22 Dec 2008 21:32:12 +0000 (22:32 +0100)]
Attempt to fix bug 5953: Make cli_send_smb_direct_writeX use writev
It seems there are SMB servers around which can't cope with the write header
being sent in a packet of its own. With writev we keep the advantage of direct
writes, giving the kernel the chance to coalesce the write calls.
Volker Lendecke [Mon, 22 Dec 2008 21:17:59 +0000 (22:17 +0100)]
Make write_data use write_data_iov
Volker Lendecke [Mon, 22 Dec 2008 21:17:28 +0000 (22:17 +0100)]
Add write_data_iov
Volker Lendecke [Sun, 21 Dec 2008 22:22:30 +0000 (23:22 +0100)]
Add sys_writev
Kai Blin [Sun, 28 Dec 2008 11:04:40 +0000 (12:04 +0100)]
s4 winbind: Copy SID to avoid "discard const" warning
Kai Blin [Fri, 26 Dec 2008 11:45:50 +0000 (12:45 +0100)]
s4 winbind: Add support for WINBINDD_GETGRGID call
Kai Blin [Fri, 26 Dec 2008 10:32:09 +0000 (11:32 +0100)]
s4 libnet: Add support for groupinfo by sid lookup
Kai Blin [Fri, 26 Dec 2008 10:08:13 +0000 (11:08 +0100)]
s4 winbind: Fix typos in debug output
Kai Blin [Fri, 26 Dec 2008 10:04:01 +0000 (11:04 +0100)]
wbinfo4: Add --gid-info option
Kai Blin [Fri, 26 Dec 2008 10:02:02 +0000 (11:02 +0100)]
wbinfo: Add --gid-info option.
Kai Blin [Fri, 26 Dec 2008 09:36:29 +0000 (10:36 +0100)]
s4 winbind: Add implementation for WINBINDD_GETGRNAM
Kai Blin [Fri, 26 Dec 2008 09:35:00 +0000 (10:35 +0100)]
s4 winbind: Avoid a "discards const" compiler warning.
Kai Blin [Fri, 26 Dec 2008 09:17:38 +0000 (10:17 +0100)]
s4 libnet: Add group_name member to struct libnet_GroupInfo's out struct.
Stefan Metzmacher [Mon, 29 Dec 2008 08:37:02 +0000 (09:37 +0100)]
s4:kdc: pass down event_context explicit
metze
Stefan Metzmacher [Mon, 29 Dec 2008 08:36:20 +0000 (09:36 +0100)]
s4:libnet_samdump_keytab: pass down event_context explicit
metze
Stefan Metzmacher [Wed, 17 Dec 2008 16:16:50 +0000 (17:16 +0100)]
s3:dbwrap: fix dbwrap_store_uint32() to match dbwrap_store_int32()
All callers expect 0 an success and -1 on error.
metze
Stefan Metzmacher [Mon, 29 Dec 2008 07:40:04 +0000 (08:40 +0100)]
pyglue: fix the build with automatic dependecies
metze
Stefan Metzmacher [Wed, 24 Dec 2008 12:52:57 +0000 (13:52 +0100)]
lib/tevent: rename event_* => tevent_* in the header file
We have compat macros to keep the callers happy.
metze
Steven Danneman [Mon, 29 Dec 2008 01:22:28 +0000 (17:22 -0800)]
Add -D option to sharesec util to delete the entire security descriptor.
* also modified --usage descriptions to be more accurate
Steven Danneman [Mon, 29 Dec 2008 01:21:36 +0000 (17:21 -0800)]
Change error messages in sharesec util to go to stderr instead of stdout
Steven Danneman [Mon, 29 Dec 2008 01:16:28 +0000 (17:16 -0800)]
Make sure share_info.tdb is open before attempting to delete an entry
Steven Danneman [Fri, 26 Dec 2008 20:41:29 +0000 (12:41 -0800)]
Make sharesec utility part of the default binary install.
Steven Danneman [Thu, 25 Dec 2008 01:03:22 +0000 (17:03 -0800)]
Cleaned up whitespace issues in sharesec.c
Jelmer Vernooij [Sun, 28 Dec 2008 03:12:46 +0000 (04:12 +0100)]
Fix Samba 3 merged build - include tevent.
Kai Blin [Fri, 26 Dec 2008 13:09:02 +0000 (14:09 +0100)]
Fix some tevent includes, trying to fix the build
Kai Blin [Fri, 26 Dec 2008 12:32:26 +0000 (13:32 +0100)]
Try to fix the build by fixing some typos in the vfs code
Jeremy Allison [Thu, 25 Dec 2008 20:13:12 +0000 (12:13 -0800)]
Fix bug #5990 - strict allocate should be checked before ftruncate
reported by and based on a patch by Yasuma Takeda
<yasuma@osstech.co.jp>.
Jeremy.
Michael Adam [Wed, 1 Oct 2008 06:53:15 +0000 (08:53 +0200)]
s3:idmap: Remove passd check from idmap_backends_unixid_to_sid().
As noted by Metzy, it makes no sense here to check id->sid.
What is worse, this might even be passed in uninitialized.
This still fixes the bug for me (of course), but we might need
to check, if another special handling of passdb is needed
(possibly changing from constant return code NT_STATUS_OK...)
Michael
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Wed, 1 Oct 2008 06:30:15 +0000 (08:30 +0200)]
s:Fix uid_to_sid mapping when the idmap cache is empty.
This failed for backends other than passed, since
idmap_backends_unixid_to_sid() always asked passdb first,
which returned Success no matter whether a mapping was
found or not.
One effect wast that getpwuid failed after "net cache flush".
Only after filling the cache with a getpwnam call it succeeded.
This fix makes the behaviour of idmap_backends_unixid_to_sid()
exactly the same as that of idmap_backends_sid_to_unixid()
Michael
Signed-off-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Wed, 24 Dec 2008 12:50:47 +0000 (13:50 +0100)]
lib/tevent: libtevent will change a lot until it's version 1.0.0
metze
Jelmer Vernooij [Wed, 24 Dec 2008 04:39:29 +0000 (05:39 +0100)]
Fix accidental condition inversion.
Jelmer Vernooij [Tue, 23 Dec 2008 23:15:43 +0000 (00:15 +0100)]
Rename samba-socket -> samba_socket to fix a couple more compiler
warnings.
Jelmer Vernooij [Tue, 23 Dec 2008 22:26:32 +0000 (23:26 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba
Jelmer Vernooij [Tue, 23 Dec 2008 22:24:12 +0000 (23:24 +0100)]
s4: Fix make clean to remove gen_ndr objects.
Jelmer Vernooij [Tue, 23 Dec 2008 22:22:57 +0000 (23:22 +0100)]
Fix more compiler warnings.
Jelmer Vernooij [Tue, 23 Dec 2008 22:02:54 +0000 (23:02 +0100)]
Use 32-bit smbpid in interface as required by SMB2, in line with
1bdd08227e7d046305705050f21f0f1b6dd6994a.
Jelmer Vernooij [Tue, 23 Dec 2008 21:57:11 +0000 (22:57 +0100)]
Fix more compiler warnings in various places.
Jelmer Vernooij [Tue, 23 Dec 2008 21:57:00 +0000 (22:57 +0100)]
Install tevent_internal.h, as Samba 4 needs it.
Jelmer Vernooij [Tue, 23 Dec 2008 21:12:23 +0000 (22:12 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba
Jelmer Vernooij [Tue, 23 Dec 2008 21:11:21 +0000 (22:11 +0100)]
Fix compiler warnings in libnet.
Jelmer Vernooij [Tue, 23 Dec 2008 21:10:34 +0000 (22:10 +0100)]
Fix use of "time offset" parameter, and add test to make sure I don't break it again :-)
Jeremy Allison [Tue, 23 Dec 2008 20:11:12 +0000 (12:11 -0800)]
Fix more asprintf warnings and some error path errors.
Jeremy.
Jeremy Allison [Tue, 23 Dec 2008 19:56:48 +0000 (11:56 -0800)]
More asprintf warning fixes.
Jeremy.
Jeremy Allison [Tue, 23 Dec 2008 19:45:26 +0000 (11:45 -0800)]
More asprintf warning fixes.
Jeremy.
Jeremy Allison [Tue, 23 Dec 2008 19:27:19 +0000 (11:27 -0800)]
Fix more asprintf errors and error code paths.
Jeremy.
Matthias Dieter Wallnöfer [Tue, 23 Dec 2008 19:17:59 +0000 (20:17 +0100)]
Add missing includes, required for use of gensec by 3rd-party
applications.
Jelmer Vernooij [Tue, 23 Dec 2008 19:13:17 +0000 (20:13 +0100)]
pytevent: Add missing file.
Jelmer Vernooij [Tue, 23 Dec 2008 18:59:57 +0000 (19:59 +0100)]
Allow using external libtevent.
Jelmer Vernooij [Tue, 23 Dec 2008 18:39:52 +0000 (19:39 +0100)]
standalone: Use more variables, preparing to include these files from main
Samba 4 makefile.
Jeremy Allison [Tue, 23 Dec 2008 18:43:02 +0000 (10:43 -0800)]
Merge branch 'master' of ssh://jra@git.samba.org/data/git/samba
Jeremy Allison [Tue, 23 Dec 2008 18:42:25 +0000 (10:42 -0800)]
Fix more ‘asprintf’, declared with attribute warn_unused_result.
Jeremy.
Jelmer Vernooij [Tue, 23 Dec 2008 18:30:16 +0000 (19:30 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba
Jelmer Vernooij [Tue, 23 Dec 2008 18:28:22 +0000 (19:28 +0100)]
Move Samba4-specific file out of common libtevent.
Jeremy Allison [Tue, 23 Dec 2008 18:27:24 +0000 (10:27 -0800)]
Fix more "warning: ignoring return value of ‘asprintf’, declared with
attribute warn_unused_result"
Jeremy.
Jeremy Allison [Tue, 23 Dec 2008 17:50:10 +0000 (09:50 -0800)]
Fix another "format not a string literal and no format arguments" warning.
Jeremy
Jelmer Vernooij [Tue, 23 Dec 2008 11:14:25 +0000 (12:14 +0100)]
Fix silly typo.
Jelmer Vernooij [Tue, 23 Dec 2008 10:48:14 +0000 (11:48 +0100)]
pyldb: Provide replacement for sizeargfunc, not available before Python2.5.
Jelmer Vernooij [Tue, 23 Dec 2008 10:44:10 +0000 (11:44 +0100)]
samba.tests.samdb: Fix test after merger of samba.security and
samba.dcerpc.security
Jelmer Vernooij [Tue, 23 Dec 2008 10:25:06 +0000 (11:25 +0100)]
python: Define Py_ssize_t if the Python library doesn't.
Tim Prouty [Tue, 23 Dec 2008 06:35:24 +0000 (22:35 -0800)]
s3: Fix stream marshalling to return the correct streaminfo status
When there are enough streams on a file to fill up the max_data_count
when responding to a trans2 streaminfo, samba is returning
NT_STATUS_BUFFER_TOO_SMALL. Windows handles this by returning
NT_STATUS_BUFFER_OVERFLOW while still sending as much of the data that
it can fit into the buffer. When the windows client sees
BUFFER_OVERFLOW, it retries the streaminfo with a larger buffer (2x).
The windows client starts at 2K and will continue increasing the
buffer size by two until it reaches 64K. If the streams don't fit in
64K the windows client seems to give up.
This patch fixes marshall_stream_info to overfill the buffer by 1
stream so that send_trans2_replies can properly detect the overflow
and return the correct status.
Jelmer Vernooij [Tue, 23 Dec 2008 04:34:21 +0000 (05:34 +0100)]
pyldb: Fix segfault because of incorrect reference counting.
Jelmer Vernooij [Tue, 23 Dec 2008 04:07:29 +0000 (05:07 +0100)]
pyldb: Avoid use of pytalloc, as it may not be available.
Jeremy Allison [Tue, 23 Dec 2008 04:08:14 +0000 (20:08 -0800)]
In gcc version 4.3.2 we get warnings for functions declared with
attribute warn_unused_result. Start to fix these.
Jeremy.
Jelmer Vernooij [Tue, 23 Dec 2008 03:21:35 +0000 (04:21 +0100)]
ldb: Include tevent.h rather than events.h.
Jelmer Vernooij [Tue, 23 Dec 2008 03:18:31 +0000 (04:18 +0100)]
ldb: Fix linking against tevent library (rather than events)
replace: Fix copyright for dlfcn.c.
Jelmer Vernooij [Tue, 23 Dec 2008 03:06:21 +0000 (04:06 +0100)]
pytalloc: Add some comments, use talloc object location in repr rather
than python object location.
Jelmer Vernooij [Tue, 23 Dec 2008 02:24:39 +0000 (03:24 +0100)]
python/tevent: Remove use of pytalloc.h.
Jelmer Vernooij [Tue, 23 Dec 2008 02:17:01 +0000 (03:17 +0100)]
pidl: Fix typelist test after addition of type origin tracking.
Jelmer Vernooij [Tue, 23 Dec 2008 01:06:05 +0000 (02:06 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba
Jelmer Vernooij [Tue, 23 Dec 2008 01:04:50 +0000 (02:04 +0100)]
merged build: Remove shared-build related variables, as they are already set up correctly by the main configure.
Jelmer Vernooij [Tue, 23 Dec 2008 00:53:38 +0000 (01:53 +0100)]
Use make variable for Samba 4 shared library output directory.
Jelmer Vernooij [Tue, 23 Dec 2008 00:40:08 +0000 (01:40 +0100)]
Fix prefixing swig library directory with prefix.
Jelmer Vernooij [Tue, 23 Dec 2008 00:03:49 +0000 (01:03 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba
Jelmer Vernooij [Mon, 22 Dec 2008 23:59:39 +0000 (00:59 +0100)]
Use relative paths for Python modules. Seems to workaround a strange bug in
GNU make.
Tim Prouty [Mon, 22 Dec 2008 23:04:10 +0000 (15:04 -0800)]
s4: Fix a getaddrinfo/EAI_NODATA portability issue
FreeBSD has explicitly deprecated EAI_NODATA as a return value from
getaddrinfo by removing it from netdb.h. On systems that don't have
EAI_NODATA, EAI_NONAME should be used instead.