Gerald Carter [Wed, 9 Nov 2005 19:37:13 +0000 (19:37 +0000)]
r11617: fix typo
Jeremy Allison [Wed, 9 Nov 2005 19:35:23 +0000 (19:35 +0000)]
r11614: Replace old crc32 code with one from the FreeBSD tree.
* COPYRIGHT (C) 1986 Gary S. Brown. You may use this program, or
* code or tables extracted from it, as desired without restriction.
Jeremy.
Gerald Carter [Wed, 9 Nov 2005 18:33:37 +0000 (18:33 +0000)]
r11613: fixing versions
Gerald Carter [Wed, 9 Nov 2005 02:13:53 +0000 (02:13 +0000)]
r11591: bumping version 3.0.22pre1
Volker Lendecke [Tue, 8 Nov 2005 20:13:26 +0000 (20:13 +0000)]
r11585: Implement the possibility to have AFS users as SIDs in pts.
Volker
Derrell Lipman [Tue, 8 Nov 2005 18:23:51 +0000 (18:23 +0000)]
r11583: r10556@cabra: derrell | 2005-11-08 13:20:56 -0500
fix copy/paste error
Derrell Lipman [Tue, 8 Nov 2005 18:23:47 +0000 (18:23 +0000)]
r11582: r10193@cabra: derrell | 2005-11-08 13:12:39 -0500
Fixed "clean" target -- bin/libmsrpc.a was not being deleted.
Jerry, the shared version of libmsrpc is not using a version number. For consistency, I added LIBMSRPC_MAJOR and LIBMSRPC_MINOR definitions but they are not
currently being used. I don't know if the non-use of version is intentional
or not.
Gerald Carter [Tue, 8 Nov 2005 18:22:32 +0000 (18:22 +0000)]
r11580: fix an uninitialized variable that was causing winbindd to die in winbindd_dual_getsidaliases()
Gerald Carter [Tue, 8 Nov 2005 16:33:45 +0000 (16:33 +0000)]
r11579: syncing up perf counter code cfrom trunk
Gerald Carter [Tue, 8 Nov 2005 16:29:15 +0000 (16:29 +0000)]
r11577: adding perl interpreter she-bang to top of parselog.pl script
Jeremy Allison [Tue, 8 Nov 2005 06:19:34 +0000 (06:19 +0000)]
r11573: Adding Andrew Bartlett's patch to make machine account
logons work if the client gives the MSV1_0_ALLOW_SERVER_TRUST_ACCOUNT
or MSV1_0_ALLOW_WORKSTATION_TRUST_ACCOUNT flags. This changes
the auth module interface to 2 (from 1). The effect of this is
that clients can access resources as a machine account if they
set these flags. This is the same as Windows (think of a VPN
where the vpn client authenticates itself to a VPN server
using machine account credentials - the vpn server checks
that the machine password was valid by performing a machine
account check with the PDC in the same was as it would a
user account check. I may add in a restriction (parameter)
to allow this behaviour to be turned off (as it was previously).
That may be on by default.
Andrew Bartlett please review this change carefully.
Jeremy.
Jeremy Allison [Mon, 7 Nov 2005 23:28:42 +0000 (23:28 +0000)]
r11566: From metze. Use "interpret_addr(lp_socket_address())" for port 138.
Jeremy.
Jeremy Allison [Mon, 7 Nov 2005 19:18:00 +0000 (19:18 +0000)]
r11560: Fix core dump if setmntent returns NULL.
Pointed out by Jay Fanlason @ Red Hat.
Jeremy.
Volker Lendecke [Mon, 7 Nov 2005 16:00:35 +0000 (16:00 +0000)]
r11556: Fix "make everything"
Volker Lendecke [Mon, 7 Nov 2005 14:16:50 +0000 (14:16 +0000)]
r11551: Add a few more initialize_krb5_error_table
Gerald Carter [Mon, 7 Nov 2005 13:45:28 +0000 (13:45 +0000)]
r11549: fixing GPL notices
Gerald Carter [Mon, 7 Nov 2005 13:43:06 +0000 (13:43 +0000)]
r11548: adding simple script to tail syslog and write to eventlog tdb
Jeremy Allison [Sun, 6 Nov 2005 01:55:09 +0000 (01:55 +0000)]
r11530: Add the "time offset" parameter back in for people who
might use it.
Jeremy.
Jeremy Allison [Sat, 5 Nov 2005 04:21:55 +0000 (04:21 +0000)]
r11511: A classic "friday night check-in" :-). This moves much
of the Samba4 timezone handling code back into Samba3.
Gets rid of "kludge-gmt" and removes the effectiveness
of the parameter "time offset" (I can add this back
in very easily if needed) - it's no longer being
looked at. I'm hoping this will fix the problems people
have been having with DST transitions. I'll start comprehensive
testing tomorrow, but for now all modifications are done.
Splits time get/set functions into srv_XXX and cli_XXX
as they need to look at different timezone offsets.
Get rid of much of the "efficiency" cruft that was
added to Samba back in the day when the C library
timezone handling functions were slow.
Jeremy.
Jeremy Allison [Sat, 5 Nov 2005 00:02:01 +0000 (00:02 +0000)]
r11508: Removed incorrect patch hunk. Thanks to Andrew
Bartlett for pointing this out.
Jeremy.
Jeremy Allison [Fri, 4 Nov 2005 17:40:35 +0000 (17:40 +0000)]
r11506: Added description of ACL in usage message.
Jeremy.
Jeremy Allison [Fri, 4 Nov 2005 17:39:42 +0000 (17:39 +0000)]
r11504: Added Andrew Bartletts removal of another NTLMSSP implementation
patch.
Jeremy.
Jeremy Allison [Fri, 4 Nov 2005 01:21:46 +0000 (01:21 +0000)]
r11494: Finally fix #3192 - remember iDiskfreeCacheTime is
an *integer*, not a pointer. Doh !
Jeremy.
Jeremy Allison [Fri, 4 Nov 2005 00:03:55 +0000 (00:03 +0000)]
r11492: Fix bug #3224 (I hope). Correctly use machine_account_name
and client_name when doing netlogon credential setup.
Jeremy.
Jeremy Allison [Thu, 3 Nov 2005 20:26:24 +0000 (20:26 +0000)]
r11491: If we get a reject ensure we're printing out the server/domain/machine
a/c we were asking for.
Jeremy.
Jeremy Allison [Wed, 2 Nov 2005 20:32:11 +0000 (20:32 +0000)]
r11482: Arrg. Can't believe this code was in this state. If you
don't initialize the mask then setting "special" access
gets set to *random* permissions !
Jeremy.
Jeremy Allison [Wed, 2 Nov 2005 02:35:48 +0000 (02:35 +0000)]
r11464: Allow smbcacls to modify a SD on W2K3. This may fix several
bugzilla bugs - I need to go through and check. I also
need to test against WNT/W2K and WXP.
Jeremy.
Jeremy Allison [Wed, 2 Nov 2005 02:13:08 +0000 (02:13 +0000)]
r11460: Improve error messages in parsing security descriptors.
Jeremy.
Jeremy Allison [Wed, 2 Nov 2005 00:37:35 +0000 (00:37 +0000)]
r11454: Last 2 uninitialized warnings.
Jeremy.
Jeremy Allison [Wed, 2 Nov 2005 00:19:26 +0000 (00:19 +0000)]
r11451: Fix -O1 "might be using uninitialized" errors.
Jeremy.
Jeremy Allison [Tue, 1 Nov 2005 23:49:40 +0000 (23:49 +0000)]
r11448: Move decl before code.
Jeremy.
Jeremy Allison [Tue, 1 Nov 2005 23:29:02 +0000 (23:29 +0000)]
r11446: Remove unused fn. Remove unneeded strncpy use.
Jeremy.
Jeremy Allison [Tue, 1 Nov 2005 19:24:55 +0000 (19:24 +0000)]
r11443: Fix error code returns on client spoolss code. Fix them
up a *lot*.
Jeremy.
Jeremy Allison [Tue, 1 Nov 2005 02:07:26 +0000 (02:07 +0000)]
r11435: Allow the hash size of the tdb open (locking) database
to be set in local.h. Change from the default (131) to
another prime (1049). Should this be an smb.conf tunable parameter
based on the number of open file descriptors available ?
If so what scaling factor ? More tests to follow.
Jeremy.
Jeremy Allison [Mon, 31 Oct 2005 23:47:57 +0000 (23:47 +0000)]
r11433: Fix for bug #3223 - ensure we're root before doing
any potential lib/smbldap.c calls.
Jeremy.
Jeremy Allison [Mon, 31 Oct 2005 22:30:05 +0000 (22:30 +0000)]
r11428: Fix bug #3192 by actually hooking up the dfree caching
function. Oops.
Jeremy.
Jeremy Allison [Mon, 31 Oct 2005 20:11:58 +0000 (20:11 +0000)]
r11420: Fix issue pointed out by Dina Fine <dina@exanet.com>. We can
only tell at parse time from the wire if an incoming name
has wildcards or not. If it's a mangled name and we demangle
the demangled name may contain wildcard characters. Ensure
these are ignored.
Jeremy.
Simo Sorce [Sat, 29 Oct 2005 13:31:57 +0000 (13:31 +0000)]
r11398: Keep s3 in sync with trunk
Simo Sorce [Sat, 29 Oct 2005 13:19:27 +0000 (13:19 +0000)]
r11395: Update the Debian packaging.
Move form stable to stable distribution names based hives.
Jeremy Allison [Sat, 29 Oct 2005 00:27:16 +0000 (00:27 +0000)]
r11389: Attempt to fix bug #3212 - ignore bogus OS/2 EA set values on
trans2_mkdir/trans2_open/trans2_setfilepathingo.
Jeremy.
Jeremy Allison [Fri, 28 Oct 2005 22:22:23 +0000 (22:22 +0000)]
r11383: Patch from Alex Masterov <alex@infobit.ru> to fix
XATTR calls on *BSD systems (bug #3218).
Jeremy.
Volker Lendecke [Fri, 28 Oct 2005 21:08:31 +0000 (21:08 +0000)]
r11381: Correctly connect to 445 and 139 after a successful getdcname.
Volker
Jeremy Allison [Fri, 28 Oct 2005 20:36:21 +0000 (20:36 +0000)]
r11379: Remove external dependencies from sharemodes library.
Jeremy.
Paul Green [Fri, 28 Oct 2005 16:17:46 +0000 (16:17 +0000)]
r11375: Update to the latest config.guess and config.sub files.
Volker Lendecke [Fri, 28 Oct 2005 09:15:27 +0000 (09:15 +0000)]
r11368: Remove a memleak that just cost me half an hour: If we terminate inside a
message handler, the list of messages from retrieve_all_messages is not
properly freed. Not important, just confusing :-)
Volker
Jeremy Allison [Fri, 28 Oct 2005 01:42:03 +0000 (01:42 +0000)]
r11346: Fix for bug found by Dina Fine. If in case sensitive mode then
the mangle cache is no good (3 letter extension could be wrong
case - so don't demangle in this case - leave as mangled and
allow the mangling of the directory entry read (which is done
case insensitively) to match instead. This will lead to more
false positive matches but we fail completely without it.
Jeremy.
Jeremy Allison [Thu, 27 Oct 2005 23:30:25 +0000 (23:30 +0000)]
r11344: I don't think share mode conflicts occur on deleting
a directory when you've got permissions. Need to write
a smbtorture test for this.
Jeremy.
Jeremy Allison [Thu, 27 Oct 2005 22:35:08 +0000 (22:35 +0000)]
r11341: Put directory opens into the share mode db so we
can treat them similarly to file opens (delete on
close, share mode violations etc.). This fixes bug
#3216 I will up the default hash size on the locking
db in a later commit as this means more entries.
Jeremy.
Jeremy Allison [Thu, 27 Oct 2005 18:25:41 +0000 (18:25 +0000)]
r11338: Move knowledge of \\ needed into rpc_client/cli_netlogon
(this is the way it's been done in other functions). Instead
of moving this into the IDL, I think the best solution would
be to write a wrapper function around any call that needs
this (this is what we already do for many of the calls).
Jeremy.
Jeremy Allison [Thu, 27 Oct 2005 18:06:29 +0000 (18:06 +0000)]
r11336: Start to get my control back :-). Volker, I think
Andrew Bartlett is right - making lsa code do it the
netlogon way, not vica-versa.
Jeremy.
Gerald Carter [Thu, 27 Oct 2005 13:30:23 +0000 (13:30 +0000)]
r11332: eventlog API uses NTSTATUS, not WERROR for return codes
Volker Lendecke [Thu, 27 Oct 2005 12:51:24 +0000 (12:51 +0000)]
r11328: Actually verify that the bind on a pipe succeeded with a samr_connect or
lsa_openpolicy and fall back appropriately. In particular an ntlmssp bind
failure can not be detected before the first real rpc request, at least
according to abartlet :-)
Works for me against w2k3, w2k and nt4. Sooner or later I should test against
samba4 ... :-)
Volker
Volker Lendecke [Thu, 27 Oct 2005 12:47:06 +0000 (12:47 +0000)]
r11327: Make user domain settable by pdbedit
Volker Lendecke [Thu, 27 Oct 2005 12:45:10 +0000 (12:45 +0000)]
r11326: Fix alignment in getdc response
Volker Lendecke [Thu, 27 Oct 2005 11:16:36 +0000 (11:16 +0000)]
r11324: Re-formatting before I can get a very *narrow* focus on the bugs in here. ;-)
We can only tell if the bind succeeded on the first real RPC call. So we have
to decide according to success of samrconnect whether we have to fall
back. Similarly for lsaopenpolicy.
Volker
Volker Lendecke [Thu, 27 Oct 2005 11:01:29 +0000 (11:01 +0000)]
r11323: Fix usage of rpccli_netlogon_getdcname. Add some debug messages.
Volker
Volker Lendecke [Thu, 27 Oct 2005 08:27:48 +0000 (08:27 +0000)]
r11320: Fix error handling for rpccli_netlogon_getdcname. Jeremy, the other functions
in cli_netlogon look similarly suspicious.
Volker
Volker Lendecke [Thu, 27 Oct 2005 07:57:39 +0000 (07:57 +0000)]
r11319: read_buf_len and write_buf_len are no longer used, remove them.
Volker
Gerald Carter [Wed, 26 Oct 2005 13:44:46 +0000 (13:44 +0000)]
r11301: why would you look for printf in -lnsl[_s]? Fixing configure checks
Gerald Carter [Tue, 25 Oct 2005 14:56:22 +0000 (14:56 +0000)]
r11296: removing unused variable and ifdef'd out code
Gerald Carter [Tue, 25 Oct 2005 14:54:41 +0000 (14:54 +0000)]
r11295: new service hashing code has assumign that the service
name stored in the array was normalized. This was causing
records to not be deleted on a reload. As a result,
I was getting the wrong path for various services.
Seems to be ok after this change.
Also converted canonicalize_servicename() to just
use strupper_m() rather than doing the conversion itself.
Jeremy, i think this should be ok but please check.
also cleaned up some things in the hash service code
and added debug messages for sanity purposes.
Gerald Carter [Tue, 25 Oct 2005 12:49:24 +0000 (12:49 +0000)]
r11292: Missed merge from Samba 2.2 many years ago....
Don't count open pipes in the num_files_open on a connection.
conn_idle_all() handles this by looking for open rpc handles
If there are no open handles, we can close the IPC$ share.
Volker Lendecke [Tue, 25 Oct 2005 09:42:22 +0000 (09:42 +0000)]
r11286: Fix a potential segfault
Jeremy Allison [Tue, 25 Oct 2005 05:26:53 +0000 (05:26 +0000)]
r11283: Move to using sival_int from sival_ptr. Part of bug #2922.
Jeremy.
Gerald Carter [Mon, 24 Oct 2005 16:55:26 +0000 (16:55 +0000)]
r11280: BUG 3201: make sure request structure is cleared prior to sending the request to winbindd (prevents the WB_RECURSE flags from accidentially getting set
Gerald Carter [Mon, 24 Oct 2005 14:11:16 +0000 (14:11 +0000)]
r11275: patch from Chris to remove the empty struct in libmsrpc.h (fix build with Sun compiler)
Jeremy Allison [Sun, 23 Oct 2005 19:00:40 +0000 (19:00 +0000)]
r11269: Ensure the new canonicalize_servicename() is mb safe.
MB service names may contain embedded ' ' characters.
Jeremy.
Volker Lendecke [Sun, 23 Oct 2005 16:29:02 +0000 (16:29 +0000)]
r11266: Speed up loading smb.conf for large numbers of share definitions. The problem
was a O(n^2) loop: Whenever a service definition was found, we linearly
searched the already loaded share definitions, the patch adds an internal tdb
for this. For a smb.conf with 2000 shares this speeds up loading by about a
factor of 50.
Might be a fix for bug #1117.
Thanks to Michael Adam <ma@sernet.de>,
Volker
Jeremy Allison [Fri, 21 Oct 2005 22:48:27 +0000 (22:48 +0000)]
r11256: Remove use of long long and strtoll in libsmbclient (we
can't assume long long is always there). Removed unused
var in new a/c rename code.
long long still used in eventlog code but Jerry has promised
to fix that.
Jeremy.
Volker Lendecke [Fri, 21 Oct 2005 21:46:49 +0000 (21:46 +0000)]
r11253: Fix an annoying timeout when no nmbd is around
Volker Lendecke [Fri, 21 Oct 2005 21:25:26 +0000 (21:25 +0000)]
r11251: Fix a comment
Günther Deschner [Fri, 21 Oct 2005 12:50:39 +0000 (12:50 +0000)]
r11242: use LDAP bitwise machting rule when searching for groups in ADS.
This avoids that each time a full-group-dump is requested from ADS; the
bitwise match allows to only query those groups we are interested in.
The ADS LDAP server changed to RFC compliant behaviour when decoding the ldap
filter with extensible match in the latest SPs (fixes). From the patch:
/* Workaround ADS LDAP bug present in MS W2K3 SP0 and W2K SP4 w/o
* rollup-fixes:
*
* According to Section 5.1(4) of RFC 2251 if a value of a type is it's
* default value, it MUST be absent. In case of extensible matching the
* "dnattr" boolean defaults to FALSE and so it must be only be present
* when set to TRUE.
*
* When it is set to FALSE and the OpenLDAP lib (correctly) encodes a
* filter using bitwise matching rule then a buggy AD fails to decode
* the extensible match. As a workaround set it to TRUE and thereby add
* the dnAttributes "dn" field to cope with those older AD versions.
* It should not harm and won't put any additional load on the AD since
* none of the dn components have a bitmask-attribute.
*
* Thanks to Ralf Haferkamp for input and testing */
Guenther
Gerald Carter [Fri, 21 Oct 2005 02:14:23 +0000 (02:14 +0000)]
r11240: * fix invalid read reported by valgrind in the
spoolss backchannel connection by rewriting
spoolss_connect_to_client(). Ensure that we
save the cli_state* in the rpc_pipe_client struct.
* fix typo in debug message in cli_start_connection"
Jeremy Allison [Thu, 20 Oct 2005 21:10:05 +0000 (21:10 +0000)]
r11237: Fix acl evaluation bug found by Marc Cousin <mcousin@sigma.fr>
We should only check the S_IWGRP permissions if we haven't already
seen an owning group SMB_ACL_GROUP_OBJ ace entry. If there is an
SMB_ACL_GROUP_OBJ ace entry then the group bits in st_gid are
the same as the SMB_ACL_MASK bits, not the SMB_ACL_GROUP_OBJ
bits. Thanks to Marc Cousin <mcousin@sigma.fr> for pointing
this out.
Jeremy.
Jim McDonough [Thu, 20 Oct 2005 20:40:47 +0000 (20:40 +0000)]
r11236: Implement user rename for smbpasswd and ldap backends. Some cleanup on
tdb as well to make naming consistent.
Gerald Carter [Thu, 20 Oct 2005 20:26:11 +0000 (20:26 +0000)]
r11235: fix segfault in addprinter due to mixing talloc() and malloc()'d memory
Jeremy Allison [Thu, 20 Oct 2005 18:15:44 +0000 (18:15 +0000)]
r11233: Forgot to add the statvfs file. Oops.
Jeremy.
Jeremy Allison [Thu, 20 Oct 2005 17:33:17 +0000 (17:33 +0000)]
r11232: Added ab's POSIX statvfs vfs call. Sorry for the delay ab.
Jeremy.
Jim McDonough [Thu, 20 Oct 2005 16:07:36 +0000 (16:07 +0000)]
r11230: Remove the '//' i was using to test something...oops
Jim McDonough [Thu, 20 Oct 2005 16:05:12 +0000 (16:05 +0000)]
r11229: an even bigger speedup spotted by Volker. string_to_sid() is now taking 1/5th
the time it used to. Replace strcasecmp with invididual char checks for
"S-" sid prefix.
Jim McDonough [Thu, 20 Oct 2005 15:09:41 +0000 (15:09 +0000)]
r11228: Speed up string_to_sid by removing next_token calls, thus eliminating
the need for allocating memory to duplicate the string.
Gerald Carter [Thu, 20 Oct 2005 14:29:24 +0000 (14:29 +0000)]
r11227: patch from brian moran to fix typo in eventlog message file registry value name
Lars Müller [Thu, 20 Oct 2005 12:58:40 +0000 (12:58 +0000)]
r11224: Add feature to get our configuration from config.log into installman.sh.
This allows us to install for example smbsh.1 only if SMBWRAPPER is set.
Removed also one rm call as we copy and do not append to the same file
in the next step. There is no file permission risk as we chmod 0644 in
any case later.
Replaced one basename call by shell substitution.
Günther Deschner [Thu, 20 Oct 2005 08:13:00 +0000 (08:13 +0000)]
r11213: Fix the build
Guenther
Jeremy Allison [Wed, 19 Oct 2005 20:02:12 +0000 (20:02 +0000)]
r11190: Fix enhancement request #3192.
This does 2 things.
1). Makes dfree command a per-share parameter (it should be anyway IMHO).
2). Adds a "dfree cache time" parameter in seconds that specifies how long a
dfree command output should be cached for. Default is zero (no caching).
Jeremy.
Günther Deschner [Wed, 19 Oct 2005 14:34:17 +0000 (14:34 +0000)]
r11183: add small helper function to return a PAC_LOGON_INFO.
Guenther
Gerald Carter [Wed, 19 Oct 2005 02:50:45 +0000 (02:50 +0000)]
r11170: root free pass on eventlog open access check
Gerald Carter [Tue, 18 Oct 2005 22:50:24 +0000 (22:50 +0000)]
r11169: removing duplicate 'map read only' entry
Gerald Carter [Tue, 18 Oct 2005 21:24:42 +0000 (21:24 +0000)]
r11167: -lsec should be include in $ACL_LIBS and not $LIBS on solaris
Gerald Carter [Tue, 18 Oct 2005 21:22:49 +0000 (21:22 +0000)]
r11166: missed a specfile fix for redhat
Gerald Carter [Tue, 18 Oct 2005 19:34:42 +0000 (19:34 +0000)]
r11165: deparate the library install commands from the logic of whether to build the library at all. Still needs some more cleanup but this works for now
Gerald Carter [Tue, 18 Oct 2005 19:32:19 +0000 (19:32 +0000)]
r11164: solaris packaging fixes
Gerald Carter [Tue, 18 Oct 2005 18:55:29 +0000 (18:55 +0000)]
r11163: fix installation of libmsrpc
Gerald Carter [Tue, 18 Oct 2005 18:26:43 +0000 (18:26 +0000)]
r11161: another regression from merge; make sure to build vfs_full_audit modulebranches/SAMBA_3_0_RELEASE/source/configure.in
Jeremy Allison [Tue, 18 Oct 2005 18:17:45 +0000 (18:17 +0000)]
r11159: Added some const to fix warnings.
Jeremy.
Gerald Carter [Tue, 18 Oct 2005 18:12:42 +0000 (18:12 +0000)]
r11158: more RedHat spec file fixes; I think this is the last one for 3.0.21pre1
Jeremy Allison [Tue, 18 Oct 2005 18:08:23 +0000 (18:08 +0000)]
r11156: Remove valgrind disabling ifdef that got added by mistake.
Jeremy.
Jeremy Allison [Tue, 18 Oct 2005 18:02:37 +0000 (18:02 +0000)]
r11155: Remove warning in torturous logic.
Jeremy.
Gerald Carter [Tue, 18 Oct 2005 17:20:50 +0000 (17:20 +0000)]
r11152: fix some regressions caused by the trunk->3.0 merge when install docs with SWAT
Gerald Carter [Tue, 18 Oct 2005 16:05:34 +0000 (16:05 +0000)]
r11150: fix solaris acl linking problem on sunos5.9; not quite sure how this got broken