kai/samba-autobuild/.git
4 years agoctdb-daemon: Rename struct ctdb_public_ip_list to public_ip_list
Amitay Isaacs [Wed, 28 Oct 2015 06:10:54 +0000 (17:10 +1100)]
ctdb-daemon: Rename struct ctdb_public_ip_list to public_ip_list

A private structure need not have ctdb_ prefix.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-daemon: Rename struct ctdb_node_map to ctdb_node_map_old
Amitay Isaacs [Thu, 29 Oct 2015 06:22:48 +0000 (17:22 +1100)]
ctdb-daemon: Rename struct ctdb_node_map to ctdb_node_map_old

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-include: Remove unnecessary typedefs
Amitay Isaacs [Wed, 28 Oct 2015 05:58:02 +0000 (16:58 +1100)]
ctdb-include: Remove unnecessary typedefs

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-daemon: Rename struct ctdb_req_keepalive to ctdb_req_keepalive_old
Amitay Isaacs [Thu, 29 Oct 2015 05:45:41 +0000 (16:45 +1100)]
ctdb-daemon: Rename struct ctdb_req_keepalive to ctdb_req_keepalive_old

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-daemon: Rename struct ctdb_reply_control to ctdb_reply_control_old
Amitay Isaacs [Thu, 29 Oct 2015 05:44:08 +0000 (16:44 +1100)]
ctdb-daemon: Rename struct ctdb_reply_control to ctdb_reply_control_old

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-daemon: Rename struct ctdb_req_control to ctdb_req_control_old
Amitay Isaacs [Thu, 29 Oct 2015 05:42:05 +0000 (16:42 +1100)]
ctdb-daemon: Rename struct ctdb_req_control to ctdb_req_control_old

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-daemon: Rename struct ctdb_req_message to ctdb_req_message_old
Amitay Isaacs [Thu, 29 Oct 2015 05:36:30 +0000 (16:36 +1100)]
ctdb-daemon: Rename struct ctdb_req_message to ctdb_req_message_old

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-daemon: Rename struct ctdb_reply_dmaster to ctdb_reply_dmaster_old
Amitay Isaacs [Thu, 29 Oct 2015 05:34:01 +0000 (16:34 +1100)]
ctdb-daemon: Rename struct ctdb_reply_dmaster to ctdb_reply_dmaster_old

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-daemon: Rename struct ctdb_req_dmaster to ctdb_req_dmaster_old
Amitay Isaacs [Thu, 29 Oct 2015 05:32:09 +0000 (16:32 +1100)]
ctdb-daemon: Rename struct ctdb_req_dmaster to ctdb_req_dmaster_old

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-daemon: Rename struct ctdb_reply_error to ctdb_reply_error_old
Amitay Isaacs [Thu, 29 Oct 2015 05:30:31 +0000 (16:30 +1100)]
ctdb-daemon: Rename struct ctdb_reply_error to ctdb_reply_error_old

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-daemon: Rename struct ctdb_reply_call to ctdb_reply_call_old
Amitay Isaacs [Thu, 29 Oct 2015 05:29:01 +0000 (16:29 +1100)]
ctdb-daemon: Rename struct ctdb_reply_call to ctdb_reply_call_old

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-daemon: Rename struct ctdb_req_call to ctdb_req_call_old
Amitay Isaacs [Thu, 29 Oct 2015 05:26:29 +0000 (16:26 +1100)]
ctdb-daemon: Rename struct ctdb_req_call to ctdb_req_call_old

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-daemon: Rename enum ctdb_eventscript_call to ctdb_event
Amitay Isaacs [Wed, 28 Oct 2015 05:54:10 +0000 (16:54 +1100)]
ctdb-daemon: Rename enum ctdb_eventscript_call to ctdb_event

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-daemon: Rename struct ctdb_scripts_wire to ctdb_script_list_old
Amitay Isaacs [Wed, 28 Oct 2015 09:02:45 +0000 (20:02 +1100)]
ctdb-daemon: Rename struct ctdb_scripts_wire to ctdb_script_list_old

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-daemon: Rename struct ctdb_script_wire to ctdb_script
Amitay Isaacs [Wed, 28 Oct 2015 05:49:47 +0000 (16:49 +1100)]
ctdb-daemon: Rename struct ctdb_script_wire to ctdb_script

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoChanging log level of two entries to DBG_NOTICE
Marc Muehlfeld [Tue, 3 Nov 2015 09:09:13 +0000 (10:09 +0100)]
Changing log level of two entries to DBG_NOTICE

On domain members using RFC2307, machine acccounts without an uidNumber
attribute are not retrieved via idmap_ad. This leads to many of the following
two error messages:
   Username DOMAIN\machineaccountname$ is invalid on this system
and
   Failed to map kerberos principal to system user (NT_STATUS_LOGON_FAILURE)
Machine accounts don't have an uidNumber attribute, if not set manually. To
avoid flooding the logs, setting message from debug level 1 to DBG_NOTICE.

Bugreport: https://bugzilla.samba.org/show_bug.cgi?id=9912

Signed-off-by: Marc Muehlfeld <mmuehlfeld@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Nov  4 00:46:15 CET 2015 on sn-devel-104

4 years agobackupkey: Fix CID 1338078 (RESOURCE_LEAK)
Volker Lendecke [Tue, 3 Nov 2015 11:00:56 +0000 (12:00 +0100)]
backupkey: Fix CID 1338078 (RESOURCE_LEAK)

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agonotifyd: Do not include CTDB headers without CLUSTER_SUPPORT enabled
Amitay Isaacs [Tue, 3 Nov 2015 01:14:41 +0000 (12:14 +1100)]
notifyd: Do not include CTDB headers without CLUSTER_SUPPORT enabled

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue Nov  3 15:15:56 CET 2015 on sn-devel-104

4 years agosmbd: Do not include CTDB headers without CLUSTER_SUPPORT enabled
Amitay Isaacs [Tue, 3 Nov 2015 01:37:38 +0000 (12:37 +1100)]
smbd: Do not include CTDB headers without CLUSTER_SUPPORT enabled

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
4 years agos4.torture.smb2/session : Replace CHECK_VAL with torture macros
Anoop C S [Tue, 13 Oct 2015 08:55:20 +0000 (14:25 +0530)]
s4.torture.smb2/session : Replace CHECK_VAL with torture macros

Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Nov  3 03:17:14 CET 2015 on sn-devel-104

4 years agos3:smb2_server: make the logic of SMB2_CANCEL DLIST_REMOVE() clearer
Stefan Metzmacher [Mon, 2 Nov 2015 12:40:24 +0000 (13:40 +0100)]
s3:smb2_server: make the logic of SMB2_CANCEL DLIST_REMOVE() clearer

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11581

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agomanpage: corrected small typo error
YvanM [Sun, 1 Nov 2015 10:53:45 +0000 (11:53 +0100)]
manpage: corrected small typo error

Corrected mistakes, probably comming from a too fast
"copy and paste", in the smb.conf manpage.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11584

Signed-off-by: YvanM <yvan.masson@openmailbox.org>
Reviewed-by: Björn Jacke <bj@sernet.de>
Reviewed-by: Karolin Seeger <kseeger@samba.org>
Autobuild-User(master): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(master): Mon Nov  2 14:43:15 CET 2015 on sn-devel-104

4 years agobuild:wafsamba: Remove the now unneeded special treatment of rpath flags
Thomas Nagy [Sat, 31 Oct 2015 13:39:35 +0000 (14:39 +0100)]
build:wafsamba: Remove the now unneeded special treatment of rpath flags

The flags parsing fixes were backported to waf 1.5 from waf 1.8. There is no reason
to keep the flags parsing fixes in Samba.

Signed-off-by: Thomas Nagy <tnagy@waf.io>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Nov  2 03:35:31 CET 2015 on sn-devel-104

4 years agobuild:wafsamba: Update waf/wafadmin/Tools/config_c.py from upstream
Thomas Nagy [Sat, 31 Oct 2015 13:38:10 +0000 (14:38 +0100)]
build:wafsamba: Update waf/wafadmin/Tools/config_c.py from upstream

The upstream version features the flags processing fixes present in Waf 1.8.

Signed-off-by: Thomas Nagy <tnagy@waf.io>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agobuildtools: Ignore exact Python version for ABI checking
Petr Viktorin [Fri, 14 Aug 2015 10:17:48 +0000 (12:17 +0200)]
buildtools: Ignore exact Python version for ABI checking

Utilities for Python libraries are built for a specific Python
version. Starting with Python 3, the Python version is recorded
in the shared library filename as an ABI tag, e.g. "pytalloc.cpython-34m.so.
The exact version doesn't matter for Samba's ABI check.
Replace the ABI tag with a simpler one that just records the major
version of Python.

Signed-off-by: Petr Viktorin <pviktori@redhat.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Sun Nov  1 01:09:06 CET 2015 on sn-devel-104

4 years agos4:heimdal_build: also use check_system_heimdal_lib() for "com_err"
Stefan Metzmacher [Thu, 27 Aug 2015 09:44:23 +0000 (11:44 +0200)]
s4:heimdal_build: also use check_system_heimdal_lib() for "com_err"

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
4 years agos4:heimdal_build: handle CHECK_BUNDLED_SYSTEM returning False in check_system_heimdal...
Stefan Metzmacher [Thu, 27 Aug 2015 09:40:09 +0000 (11:40 +0200)]
s4:heimdal_build: handle CHECK_BUNDLED_SYSTEM returning False in check_system_heimdal_lib()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
4 years agoscript/autobuild.py: exclude !pytalloc-util and !pyldb-util from bundling in samba...
Stefan Metzmacher [Thu, 27 Aug 2015 09:05:08 +0000 (11:05 +0200)]
script/autobuild.py: exclude !pytalloc-util and !pyldb-util from bundling in samba-libs

We need to make sure we're really not bundling any of these.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11458

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
4 years agos3: Remove unnecessary __P() macro
Felix Janda [Thu, 22 Oct 2015 10:42:07 +0000 (12:42 +0200)]
s3: Remove unnecessary __P() macro

__P() is used for compatibility with old K&R C compilers. With
ANSI C this macro has no effect. Since we are assuming ANSI C in
the rest of the code, the macro is not necessary.

This fixes a compilation error with musl libc because of undeclared
__P().

Signed-off-by: Felix Janda <felix.janda@posteo.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agolib/replace: Make sure that replacement strto[u]ll does not reset errno unexpectedly
Felix Janda [Thu, 22 Oct 2015 10:37:55 +0000 (12:37 +0200)]
lib/replace: Make sure that replacement strto[u]ll does not reset errno unexpectedly

Fix the replacement functions for strtoll and strtoull to not set errno
to 0 if errno is EINVAL before calling, strto[u]ll does not modify errno
and the base is ok.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=11455

Signed-off-by: Felix Janda <felix.janda@posteo.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agolib/replace: Replace BSD strtoull by wrapping strtoull instead of strtouq
Felix Janda [Thu, 22 Oct 2015 10:32:48 +0000 (12:32 +0200)]
lib/replace: Replace BSD strtoull by wrapping strtoull instead of strtouq

Same as commit e50bf6d537ef09e936d19d6e0bf63f9bbc5d4818 but for strtoull
instead of strtoll.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=11455

Signed-off-by: Felix Janda <felix.janda@posteo.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agos4.torture.smb2/session: Add torture assert for close
Anoop C S [Mon, 26 Oct 2015 11:03:11 +0000 (16:33 +0530)]
s4.torture.smb2/session: Add torture assert for close

Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Sat Oct 31 15:52:22 CET 2015 on sn-devel-104

4 years agos4.torture.smb2/session: Add torture assert for unlink
Anoop C S [Thu, 29 Oct 2015 14:50:52 +0000 (20:20 +0530)]
s4.torture.smb2/session: Add torture assert for unlink

Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agos4.torture.smb2/session : Replace CHECK_STATUS with torture macros
Anoop C S [Thu, 8 Oct 2015 13:32:06 +0000 (19:02 +0530)]
s4.torture.smb2/session : Replace CHECK_STATUS with torture macros

Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agosmbd: Fix/simplify scavenger routines
Volker Lendecke [Thu, 29 Oct 2015 13:27:32 +0000 (14:27 +0100)]
smbd: Fix/simplify scavenger routines

Use read_data/write_data, "ofs" was not incremented

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Oct 30 22:53:56 CET 2015 on sn-devel-104

4 years agos3-smbd: Fix use after issue in smbd_smb2_request_dispatch()
Andreas Schneider [Fri, 30 Oct 2015 08:01:28 +0000 (09:01 +0100)]
s3-smbd: Fix use after issue in smbd_smb2_request_dispatch()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11581

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Oct 30 19:49:47 CET 2015 on sn-devel-104

4 years agoctdb-banning: Do not set recovery mode to ACTIVE in daemon
Amitay Isaacs [Fri, 30 Oct 2015 03:25:50 +0000 (14:25 +1100)]
ctdb-banning: Do not set recovery mode to ACTIVE in daemon

When a node gets banned, it should go into recovery and freeze all
databases.  We rely on the recovery daemon to detect the banned state
and put the node in recovery and freeze all databases.

Recent change in b4357a79d916b1f8ade8fa78563fbef0ce670aa9 took explicit
freezing out of banning code but left the setting of recovery mode
to ACTIVE.  Recovery daemon will freeze databases only if the recovery
mode is NORMAL.  Recovery mode set to ACTIVE is an indication that the
freeze has started.

Do not set the recovery mode to ACTIVE in banning.  Let recovery daemon
take care of it.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Fri Oct 30 10:32:38 CET 2015 on sn-devel-104

4 years agoctdb-include: Order function prototypes as per ctdb_client.c
Amitay Isaacs [Tue, 27 Oct 2015 06:34:06 +0000 (17:34 +1100)]
ctdb-include: Order function prototypes as per ctdb_client.c

This makes sure that all function prototypes in ctdb_client.h are in
the same order of functions defined in ctdb_client.c.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Fri Oct 30 05:04:49 CET 2015 on sn-devel-104

4 years agoctdb-include: Remove unused structures and prototypes
Amitay Isaacs [Tue, 27 Oct 2015 05:45:12 +0000 (16:45 +1100)]
ctdb-include: Remove unused structures and prototypes

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-include: Move client function prototypes to ctdb_client.h
Amitay Isaacs [Tue, 27 Oct 2015 04:34:30 +0000 (15:34 +1100)]
ctdb-include: Move client function prototypes to ctdb_client.h

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-include: Move protocol structures from ctdb_private.h to ctdb_protocol.h
Amitay Isaacs [Tue, 27 Oct 2015 05:29:36 +0000 (16:29 +1100)]
ctdb-include: Move protocol structures from ctdb_private.h to ctdb_protocol.h

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-include: Move protocol structures from ctdb_client.h to ctdb_protocol.h
Amitay Isaacs [Tue, 27 Oct 2015 04:32:12 +0000 (15:32 +1100)]
ctdb-include: Move protocol structures from ctdb_client.h to ctdb_protocol.h

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-include: Group function prototypes from server/eventscript.c
Amitay Isaacs [Fri, 23 Oct 2015 05:00:39 +0000 (16:00 +1100)]
ctdb-include: Group function prototypes from server/eventscript.c

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-include: Group function prototypes from server/ctdb_vacuum.c
Amitay Isaacs [Fri, 23 Oct 2015 04:49:32 +0000 (15:49 +1100)]
ctdb-include: Group function prototypes from server/ctdb_vacuum.c

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-include: Group function prototypes from server/ctdb_uptime.c
Amitay Isaacs [Fri, 23 Oct 2015 04:46:49 +0000 (15:46 +1100)]
ctdb-include: Group function prototypes from server/ctdb_uptime.c

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-include: Group function prototypes from server/ctdb_update_record.c
Amitay Isaacs [Fri, 23 Oct 2015 04:45:55 +0000 (15:45 +1100)]
ctdb-include: Group function prototypes from server/ctdb_update_record.c

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-include: Group function prototypes from server/ctdb_tunables.c
Amitay Isaacs [Fri, 23 Oct 2015 04:44:21 +0000 (15:44 +1100)]
ctdb-include: Group function prototypes from server/ctdb_tunables.c

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-include: Group function prototypes from server/ctdb_traverse.c
Amitay Isaacs [Fri, 23 Oct 2015 04:42:50 +0000 (15:42 +1100)]
ctdb-include: Group function prototypes from server/ctdb_traverse.c

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-include: Group function prototypes from server/ctdb_takeover.c
Amitay Isaacs [Fri, 23 Oct 2015 04:40:19 +0000 (15:40 +1100)]
ctdb-include: Group function prototypes from server/ctdb_takeover.c

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-include: Group function prototypes from server/ctdb_statistics.c
Amitay Isaacs [Fri, 23 Oct 2015 04:31:34 +0000 (15:31 +1100)]
ctdb-include: Group function prototypes from server/ctdb_statistics.c

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-include: Group function prototypes from server/ctdb_serverids.c
Amitay Isaacs [Fri, 23 Oct 2015 04:30:37 +0000 (15:30 +1100)]
ctdb-include: Group function prototypes from server/ctdb_serverids.c

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-include: Group function prototypes from server/ctdb_server.c
Amitay Isaacs [Fri, 23 Oct 2015 04:28:56 +0000 (15:28 +1100)]
ctdb-include: Group function prototypes from server/ctdb_server.c

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-include: Group function prototypes from server/ctdb_recoverd.c
Amitay Isaacs [Fri, 23 Oct 2015 04:57:25 +0000 (15:57 +1100)]
ctdb-include: Group function prototypes from server/ctdb_recoverd.c

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-include: Group function prototypes from server/ctdb_recover.c
Amitay Isaacs [Fri, 23 Oct 2015 04:54:59 +0000 (15:54 +1100)]
ctdb-include: Group function prototypes from server/ctdb_recover.c

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-include: Group function prototypes from server/ctdb_persistent.c
Amitay Isaacs [Fri, 23 Oct 2015 04:25:24 +0000 (15:25 +1100)]
ctdb-include: Group function prototypes from server/ctdb_persistent.c

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-include: Group function prototypes from server/ctdb_monitor.c
Amitay Isaacs [Fri, 23 Oct 2015 04:23:18 +0000 (15:23 +1100)]
ctdb-include: Group function prototypes from server/ctdb_monitor.c

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-include: Group function prototypes from server/ctdb_ltdb_server.c
Amitay Isaacs [Fri, 23 Oct 2015 04:21:13 +0000 (15:21 +1100)]
ctdb-include: Group function prototypes from server/ctdb_ltdb_server.c

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-include: Group function prototypes from server/ctdb_logging_syslog.c
Amitay Isaacs [Fri, 23 Oct 2015 04:15:28 +0000 (15:15 +1100)]
ctdb-include: Group function prototypes from server/ctdb_logging_syslog.c

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-include: Group function prototypes from server/ctdb_logging_file.c
Amitay Isaacs [Fri, 23 Oct 2015 04:14:53 +0000 (15:14 +1100)]
ctdb-include: Group function prototypes from server/ctdb_logging_file.c

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-include: Group function prototypes from server/ctdb_logging.c
Amitay Isaacs [Fri, 23 Oct 2015 04:13:54 +0000 (15:13 +1100)]
ctdb-include: Group function prototypes from server/ctdb_logging.c

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-include: Group function prototypes from server/ctdb_lock.c
Amitay Isaacs [Fri, 23 Oct 2015 04:10:48 +0000 (15:10 +1100)]
ctdb-include: Group function prototypes from server/ctdb_lock.c

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-include: Group function prototypes from server/ctdb_keepalive.c
Amitay Isaacs [Fri, 23 Oct 2015 04:08:51 +0000 (15:08 +1100)]
ctdb-include: Group function prototypes from server/ctdb_keepalive.c

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-include: Group function prototypes from server/ctdb_freeze.c
Amitay Isaacs [Fri, 23 Oct 2015 04:08:05 +0000 (15:08 +1100)]
ctdb-include: Group function prototypes from server/ctdb_freeze.c

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-include: Group function prototypes from server/ctdb_daemon.c
Amitay Isaacs [Fri, 23 Oct 2015 04:04:17 +0000 (15:04 +1100)]
ctdb-include: Group function prototypes from server/ctdb_daemon.c

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-include: Group function prototypes from server/ctdb_control.c
Amitay Isaacs [Fri, 23 Oct 2015 03:58:14 +0000 (14:58 +1100)]
ctdb-include: Group function prototypes from server/ctdb_control.c

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-include: Group function prototypes from server/ctdb_call.c
Amitay Isaacs [Fri, 23 Oct 2015 03:56:00 +0000 (14:56 +1100)]
ctdb-include: Group function prototypes from server/ctdb_call.c

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-include: Group function prototypes from server/ctdb_banning.c
Amitay Isaacs [Fri, 23 Oct 2015 03:48:44 +0000 (14:48 +1100)]
ctdb-include: Group function prototypes from server/ctdb_banning.c

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-include: Group function prototypes from tcp and ib
Amitay Isaacs [Fri, 23 Oct 2015 03:47:09 +0000 (14:47 +1100)]
ctdb-include: Group function prototypes from tcp and ib

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-daemon: Separate prototypes for common client/server functions
Amitay Isaacs [Fri, 23 Oct 2015 03:17:34 +0000 (14:17 +1100)]
ctdb-daemon: Separate prototypes for common client/server functions

This groups function prototypes for common client/server functions in
common/common.h and removes them from ctdb_private.h.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-common: Add missing prototype for ctdb_cmdline_client()
Amitay Isaacs [Tue, 27 Oct 2015 04:26:26 +0000 (15:26 +1100)]
ctdb-common: Add missing prototype for ctdb_cmdline_client()

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-build: Calculate correct version when building from tarball
Amitay Isaacs [Fri, 23 Oct 2015 02:05:20 +0000 (13:05 +1100)]
ctdb-build: Calculate correct version when building from tarball

When building standalone ctdb from git repo, samba_version_file correctly
includes git sha in VERSION string.  When building standalone ctdb from
tarball, samba_version_file puts UNKNOWN in the VERSION string.

Use the packaged include/ctdb_version.h file to set the correct git sha.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-daemon: Remove unused header file include/internal/includes.h
Amitay Isaacs [Tue, 13 Oct 2015 06:57:49 +0000 (17:57 +1100)]
ctdb-daemon: Remove unused header file include/internal/includes.h

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-daemon: Remove dependency on includes.h
Amitay Isaacs [Mon, 26 Oct 2015 05:50:46 +0000 (16:50 +1100)]
ctdb-daemon: Remove dependency on includes.h

Instead of includes.h, include the required header files explicitly.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-daemon: Stop using tevent compatibility definitions
Amitay Isaacs [Mon, 26 Oct 2015 05:50:09 +0000 (16:50 +1100)]
ctdb-daemon: Stop using tevent compatibility definitions

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-include: Move include/internal/cmdline.h to common/
Amitay Isaacs [Tue, 13 Oct 2015 04:19:59 +0000 (15:19 +1100)]
ctdb-include: Move include/internal/cmdline.h to common/

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-daemon: Separate prototypes for system specific functions
Amitay Isaacs [Fri, 23 Oct 2015 03:11:53 +0000 (14:11 +1100)]
ctdb-daemon: Separate prototypes for system specific functions

This groups function prototypes for system specific functions in
common/system.h and removes them from ctdb_private.h.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoKCC: allow --test-all-reps-from to work with --import-ldif
Douglas Bagnall [Tue, 23 Jun 2015 04:38:29 +0000 (16:38 +1200)]
KCC: allow --test-all-reps-from to work with --import-ldif

The ldif files lack information that a normal database has, which means
the ldif import function has to use some trickery to set the local DSA.
Once the local DSA is thus set, the fake database is a bit useless from
the point of view of other DSAs. We get around this by re-importing it
each time.

This is doing something slightly different than the normal samdb
--test-all-reps-from, in that the changes are not preserved between each
DSA's run. With the samdb database (unless using --readonly), the later
DSA's will see changes the early ones made. The ordering is arbitrary.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Oct 29 08:11:54 CET 2015 on sn-devel-104

4 years agoKCC: samba_kcc --tmpdb X won't run if X already exists
Douglas Bagnall [Tue, 23 Jun 2015 04:38:29 +0000 (16:38 +1200)]
KCC: samba_kcc --tmpdb X won't run if X already exists

Part of an ongoing safety campaign, making it harder to overwrite
your valuable things while keeping it easy enough to test crazy schemes.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
4 years agoKCC: with --import-ldif, don't default to standard DB url
Douglas Bagnall [Tue, 23 Jun 2015 04:38:29 +0000 (16:38 +1200)]
KCC: with --import-ldif, don't default to standard DB url

Before samba_kcc would always assume `-H /usr/local/whatever`, and this
interacted badly with the likes of `--test-all-reps-from` and
`--forget-intersite-links`.  When I say badly, I mean it crashed because
the file is absent on my dev machine.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
4 years agoKCC: kcc.import_ldif doesn't need creds
Douglas Bagnall [Tue, 23 Jun 2015 04:38:29 +0000 (16:38 +1200)]
KCC: kcc.import_ldif doesn't need creds

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
4 years agoKCC: remove NTDSConnection API methods that are never used
Douglas Bagnall [Tue, 23 Jun 2015 04:38:29 +0000 (16:38 +1200)]
KCC: remove NTDSConnection API methods that are never used

These are not used, and using them would not be considered Pythonic. The
flags they alter are always changed directly.

The similar set_modified() method IS used.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
4 years agoKCC: whitespace for pep8
Douglas Bagnall [Tue, 23 Jun 2015 04:38:29 +0000 (16:38 +1200)]
KCC: whitespace for pep8

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
4 years agoKCC: fix pep8 line length in load_ip_transport()
Douglas Bagnall [Tue, 23 Jun 2015 04:38:29 +0000 (16:38 +1200)]
KCC: fix pep8 line length in load_ip_transport()

You are right to sigh about this one.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
4 years agoKCC: Correct capitalisation of KCCError
Douglas Bagnall [Mon, 22 Jun 2015 04:38:29 +0000 (16:38 +1200)]
KCC: Correct capitalisation of KCCError

previously we had "raise KccError", which of course would raise a
NameError.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
4 years agoKCC: raise KCCError, not Exception, in multiple places
Douglas Bagnall [Mon, 22 Jun 2015 04:38:29 +0000 (16:38 +1200)]
KCC: raise KCCError, not Exception, in multiple places

"except Exception" lines will still catch them, but more fine-grained
control is possible.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
4 years agoKCC: NTDSConnection.load_connection() requires objectGUID
Douglas Bagnall [Mon, 22 Jun 2015 04:38:29 +0000 (16:38 +1200)]
KCC: NTDSConnection.load_connection() requires objectGUID

If there is no GUID, that is an error, so we raise an exception instead
of stepping around it.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
4 years agoKCC: remove debug print statements from intrasite and intersite
Douglas Bagnall [Mon, 22 Jun 2015 04:38:29 +0000 (16:38 +1200)]
KCC: remove debug print statements from intrasite and intersite

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
4 years agoKCC: load samdb before calling kcc.run()
Douglas Bagnall [Mon, 22 Jun 2015 04:38:29 +0000 (16:38 +1200)]
KCC: load samdb before calling kcc.run()

kcc.run() is a mega-function that does nearly everything, including
loading the database. The --list-valid-dsas and --test-all-reps-from
tasks also want to load the database, but not do all that other run()
stuff, so it makes sense to pull it out. When the samdb has not been
loaded, run() will still load it -- this avoids having to change all
the tests.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
4 years agoKCC: load the object GUID with --import-ldif
Douglas Bagnall [Mon, 22 Jun 2015 04:38:29 +0000 (16:38 +1200)]
KCC: load the object GUID with --import-ldif

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
4 years agoKCC: avoid logging alarming things about exected events
Douglas Bagnall [Mon, 22 Jun 2015 04:38:29 +0000 (16:38 +1200)]
KCC: avoid logging alarming things about exected events

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
4 years agoKCC: shift --test-all-reps-from call to after kcc loading
Douglas Bagnall [Wed, 17 Jun 2015 04:38:29 +0000 (16:38 +1200)]
KCC: shift --test-all-reps-from call to after kcc loading

This is in an effort to allow --test-all-reps-from to work with
--import-ldif (though so far it doesn't for other reasons). Rather than
replicate all the ldif loading logic within test_all_reps_from, we just
wait delay the test_all_reps_from() call.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
4 years agoKCC: Simplify RNG seeding logic, dropping the default value
Douglas Bagnall [Wed, 17 Jun 2015 04:38:29 +0000 (16:38 +1200)]
KCC: Simplify RNG seeding logic, dropping the default value

There is no particular justification for the previous default, other
than being deterministic makes testing more reliable. The algorithms
using randomness do not assume determinism.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
4 years agoKCC: more debug info when --import-ldif goes badly
Douglas Bagnall [Wed, 17 Jun 2015 04:38:29 +0000 (16:38 +1200)]
KCC: more debug info when --import-ldif goes badly

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
4 years agoKCC: default to not loading new samdb when we already have one
Douglas Bagnall [Wed, 17 Jun 2015 04:38:29 +0000 (16:38 +1200)]
KCC: default to not loading new samdb when we already have one

This should make things simpler in the --import-ldif case.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
4 years agoKCC: fix typo in error path
Douglas Bagnall [Wed, 17 Jun 2015 04:38:29 +0000 (16:38 +1200)]
KCC: fix typo in error path

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
4 years agoKCC: better explain our confusion in colour_vertices comment
Douglas Bagnall [Wed, 10 Jun 2015 04:38:29 +0000 (16:38 +1200)]
KCC: better explain our confusion in colour_vertices comment

Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
4 years agoKCC: clarify debugging messages in bridgehead finding code
Douglas Bagnall [Wed, 10 Jun 2015 04:38:29 +0000 (16:38 +1200)]
KCC: clarify debugging messages in bridgehead finding code

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
4 years agoKCC: keep track of IP transport for dsa.new_connection()
Douglas Bagnall [Wed, 10 Jun 2015 04:38:29 +0000 (16:38 +1200)]
KCC: keep track of IP transport for dsa.new_connection()

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
4 years agoKCC: set system flags for new intrasite connections
Douglas Bagnall [Wed, 10 Jun 2015 04:38:29 +0000 (16:38 +1200)]
KCC: set system flags for new intrasite connections

These flags are mandatory for intrasite connections.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
4 years agoKCC: correctly use dsa.new_connection() system_flags argument
Douglas Bagnall [Wed, 10 Jun 2015 04:38:29 +0000 (16:38 +1200)]
KCC: correctly use dsa.new_connection() system_flags argument

The dsa.system_flags attribute is important and gets saved in the
database, but was never getting altered because we were setting dsa.flags
instead.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>