Jelmer Vernooij [Tue, 19 Jan 2010 22:05:04 +0000 (11:05 +1300)]
selftest: Use SUBUNIT_FORMATTER command, if set in the environment.
Wilco Baan Hofman [Tue, 19 Jan 2010 11:06:01 +0000 (12:06 +0100)]
Fix unintentional free of the last value when adding a new value to a key.
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Günther Deschner [Tue, 19 Jan 2010 16:15:05 +0000 (17:15 +0100)]
s4-smbtorture: remove unneeded ncaclrpc dir setup from RPC-SPOOLSS-NOTIFY.
Guenther
Volker Lendecke [Tue, 19 Jan 2010 15:51:33 +0000 (16:51 +0100)]
s3: Fix a typo
Günther Deschner [Tue, 19 Jan 2010 15:22:45 +0000 (16:22 +0100)]
s4-smbtorture: also configure check smbc_setOptionCaseSensitive for LIBSMBCLIENT testsuite.
Guenther
Kai Blin [Tue, 19 Jan 2010 13:48:12 +0000 (14:48 +0100)]
s3 net/i18n: Update .po files
Kai Blin [Tue, 19 Jan 2010 10:43:54 +0000 (11:43 +0100)]
s3 net: Fix compile warnings
Volker Lendecke [Tue, 19 Jan 2010 13:18:53 +0000 (14:18 +0100)]
s3: Remove a comment from ancient times that no longer applies
Günther Deschner [Mon, 18 Jan 2010 23:31:54 +0000 (00:31 +0100)]
s3-selftest: finally enable RPC-SPOOLSS-NOTIFY against s3.
Guenther
Günther Deschner [Mon, 18 Jan 2010 23:33:57 +0000 (00:33 +0100)]
s3-spoolss: stricter name checks when opening back-channel notify connection.
Make sure to always check if the name the client passed in
spoolss_RemoteFindFirstPrinterChangeNotifyEx is not one of our names.
Guenther
Günther Deschner [Mon, 18 Jan 2010 23:55:48 +0000 (00:55 +0100)]
s3-selftest: use absolute path when setting SOCKET_WRAPPER_DIR.
Guenther
Günther Deschner [Mon, 18 Jan 2010 23:27:50 +0000 (00:27 +0100)]
s4-smbtorture: support spoolss_ReplyClosePrinter server call in RPC-SPOOLSS-NOTIFY.
A handle obtained with spoolss_ReplyOpenPrinter will be closed with
spoolss_ReplyClosePrinter when we call spoolss_ClosePrinter on the remote side.
Guenther
Günther Deschner [Mon, 18 Jan 2010 23:22:57 +0000 (00:22 +0100)]
s4-smbtorture: restructure spoolss server implementations in RPC-SPOOLSS-NOTIFY.
Guenther
Günther Deschner [Mon, 18 Jan 2010 23:19:47 +0000 (00:19 +0100)]
s4-smbtorture: skip ReplyOpenPrinter test in RPC-SPOOLSS-NOTIFY while testing s3.
Guenther
Günther Deschner [Tue, 19 Jan 2010 13:10:47 +0000 (14:10 +0100)]
s4-smbtorture: strip trailing whitespace.
Guenther
Kai Blin [Tue, 19 Jan 2010 09:06:26 +0000 (10:06 +0100)]
s3 net/i18n: update .po files
Kai Blin [Tue, 19 Jan 2010 08:23:42 +0000 (09:23 +0100)]
s3 net/i18n: Use only one spelling for "Usage:"
Kai Blin [Tue, 19 Jan 2010 08:36:55 +0000 (09:36 +0100)]
s3 net: Fix compile error with WITH_DNS_UPDATES
bd3c922e2bc1a163efc1d8c9cb59578bebb79616 introduced a compile-time error
when building with WITH_DNS_UPDATES.
Björn Jacke [Mon, 18 Jan 2010 22:39:19 +0000 (23:39 +0100)]
s3/net: split up some printable stings to ease i18n
If we put strings like "Usage:" into separate _() macros and not the whole
"Usage:..." string we can cover much more messages by only one single
translation. The drawback is that the message in the sources looks less pretty.
Björn Jacke [Mon, 18 Jan 2010 22:25:41 +0000 (23:25 +0100)]
s3/i18n/de: improve some German translations
Björn Jacke [Mon, 18 Jan 2010 21:07:55 +0000 (22:07 +0100)]
ѕ3/i18n/de: fix typo
Günther Deschner [Fri, 15 Jan 2010 15:36:25 +0000 (16:36 +0100)]
testprogs: add tests for GetPrinterData{Ex} and EnumPrinterDataEx.
Guenther
Günther Deschner [Fri, 15 Jan 2010 15:25:20 +0000 (16:25 +0100)]
testprogs: add tests for GetForm.
Guenther
Günther Deschner [Fri, 15 Jan 2010 15:24:40 +0000 (16:24 +0100)]
testprogs: pass down LPPRINTER_DEFAULTS in spoolss test.
Guenther
Lars Müller [Mon, 18 Jan 2010 10:52:33 +0000 (11:52 +0100)]
Merge branch 'master' of git://git.samba.org/samba
Lars Müller [Mon, 18 Jan 2010 10:49:01 +0000 (11:49 +0100)]
Work around bad use of autoconf interna
Merge fix made by Andreas Schwab <schwab@linux-m68k.org>. This change
had been in use by SUSE since 2008-07-03.
André Hentschel [Thu, 14 Jan 2010 18:49:18 +0000 (19:49 +0100)]
net: Add German translation, specially for the command listing
Signed-off-by: Kai Blin <kai@samba.org>
Olivier Sessink [Mon, 18 Jan 2010 10:40:33 +0000 (11:40 +0100)]
s3-docs: Add man page for vfs_scannedonly.
Fix bug #7028.
Günther Deschner [Mon, 18 Jan 2010 09:59:08 +0000 (10:59 +0100)]
s3-selftest: use testenv dc so that smbtorture4 actually uses the client configuration.
Found while trying to get RPC-SPOOLSS-NOTIFY working against s3.
Guenther
Marcin Gryszkalis [Mon, 18 Jan 2010 09:15:29 +0000 (10:15 +0100)]
s3: Show share path in swat statuspage
Volker Lendecke [Sun, 17 Jan 2010 22:07:39 +0000 (23:07 +0100)]
s3: Fix the format string for smbcontrol pool-usage
With the dot I have seen printf to not print anything
Andrew Tridgell [Sun, 17 Jan 2010 10:59:56 +0000 (21:59 +1100)]
idl: switched to using the WSPP names for the 'neighbour' DRS options
The documentation shows that all these functions in fact use the same
flags variable type. To be consistent between functions, and to allow
easy reference to the WSPP docs, it is better for us to also use this
generic DrsOptions bitfield rather than one per operations.
Volker Lendecke [Tue, 10 Nov 2009 22:14:58 +0000 (23:14 +0100)]
s3: Protect against an invalid bcc in SMBsendtxt
Volker Lendecke [Sun, 17 Jan 2010 13:57:54 +0000 (14:57 +0100)]
s3: For "smbcontrol <pid> pool-usage", print the first 50 bytes of a string
Volker Lendecke [Sun, 17 Jan 2010 12:52:53 +0000 (13:52 +0100)]
s3: Fix some nonempty blank lines
Jeremy Allison [Sun, 17 Jan 2010 01:03:06 +0000 (17:03 -0800)]
Modification of fix for bug 6876 - Delete of an object whose parent folder does not have delete rights fails even if the delete right is set on the object
Suggested by Volker. Reduce the surface area of the
become_root() unbecome_root() code to reduce the chance
of errors.
Jeremy.
Andrew Tridgell [Sat, 16 Jan 2010 19:52:14 +0000 (06:52 +1100)]
s4-drs: allow for security bypass for DsReplicaGetInfo
Use --option=drs:disable_sec_check=true until the group membership bug
with the PAC is fixed.
Andrew Tridgell [Sat, 16 Jan 2010 19:48:09 +0000 (06:48 +1100)]
s4-dsdb: isGlobalCatalogReady should be shown by default
This caused repadmin.exe to crash. Thanks to Hongwei for tracking this
down for us.
Jelmer Vernooij [Sat, 16 Jan 2010 23:35:26 +0000 (12:35 +1300)]
ldap: Fix test failure that seemed to go unreported previously.
Jelmer Vernooij [Sat, 16 Jan 2010 23:26:53 +0000 (12:26 +1300)]
ldap.py: Remove unused imports.
Volker Lendecke [Sat, 16 Jan 2010 12:31:44 +0000 (13:31 +0100)]
s3: Fix a crash in libsmbclient used against the OpenSolaris CIFS server
A user has sent me a sniff where the OpenSolaris CIFS server returns "32" in
totalentries, but the array in ctr only contains 15 entries. Look at the right
delimiter for walking the array.
Kai Blin [Sat, 16 Jan 2010 11:37:30 +0000 (12:37 +0100)]
s4 selftest: Fix and reenable WINBIND-STRUCT.NETBIOS_NAME test
Andrew Tridgell [Sat, 16 Jan 2010 06:57:17 +0000 (17:57 +1100)]
s4-kerberos: raise the general kerberos debug level to 3
level 2 for every krb request is a bit much
Jelmer Vernooij [Sat, 16 Jan 2010 06:56:21 +0000 (19:56 +1300)]
subunit/testtools: Include newer version.
Jelmer Vernooij [Fri, 8 Jan 2010 01:09:20 +0000 (02:09 +0100)]
Import testtools as well, required for subunit.
Jelmer Vernooij [Thu, 31 Dec 2009 17:48:41 +0000 (18:48 +0100)]
subunit: Import new version.
Jelmer Vernooij [Thu, 31 Dec 2009 17:32:17 +0000 (18:32 +0100)]
Add README about subunit.
Jelmer Vernooij [Thu, 31 Dec 2009 17:31:23 +0000 (18:31 +0100)]
Add script for updating the copy of subunit.
Jelmer Vernooij [Thu, 31 Dec 2009 17:17:23 +0000 (18:17 +0100)]
Fix permissions - net subcommand modules don't need to be executable.
Andrew Tridgell [Sat, 16 Jan 2010 03:44:24 +0000 (14:44 +1100)]
s4-torture: fixed DsReplicaGetInfo elements
Andrew Tridgell [Sat, 16 Jan 2010 02:40:51 +0000 (13:40 +1100)]
s4-kcc: added DsReplicaGetInfo pending ops call
Just return 0 pending ops for now
Andrew Tridgell [Sat, 16 Jan 2010 02:20:46 +0000 (13:20 +1100)]
s4-provision: added w2k8r2 ldap capabilities
Andrew Tridgell [Sat, 16 Jan 2010 02:20:24 +0000 (13:20 +1100)]
s4-devel: added rebuild_zone.sh
This rebuilds a DNS zone file, including all DCs from sam.ldb
Andrew Tridgell [Sat, 16 Jan 2010 02:19:50 +0000 (13:19 +1100)]
s4-provision: added "check-names ignore;" to allow for _msdcs A records
Andrew Tridgell [Sat, 16 Jan 2010 01:10:40 +0000 (12:10 +1100)]
s4-kcc: added DsReplicaGetInfo CURSORS2 level
Andrew Tridgell [Sat, 16 Jan 2010 01:03:01 +0000 (12:03 +1100)]
s4-idl: in DsReplicaGetInfo unknown2 is actually an enumeration_context
Andrew Tridgell [Sat, 16 Jan 2010 00:49:39 +0000 (11:49 +1100)]
s4-kcc: added support for CURSORS info level in DsReplicaGetInfo
Andrew Tridgell [Sat, 16 Jan 2010 00:49:09 +0000 (11:49 +1100)]
s4-dsdb: take advantage of local cursor and sort
in getncchanges and repl task we don't need the extra load and sort
any more.
Andrew Tridgell [Sat, 16 Jan 2010 00:48:25 +0000 (11:48 +1100)]
s4-dsdb: add our local cursor and sort in dsdb_load_udv_*()
This makes things much simpler for the callers
Andrew Tridgell [Sat, 16 Jan 2010 00:08:59 +0000 (11:08 +1100)]
s4-drs: use dsdb_load_udv_v2() in getncchanges code
Andrew Tridgell [Sat, 16 Jan 2010 00:08:44 +0000 (11:08 +1100)]
s4-dsdb: use dsdb_load_udv_v2() in repl task
Andrew Tridgell [Sat, 16 Jan 2010 00:08:15 +0000 (11:08 +1100)]
s4-dsdb: added dsdb_load_udv_v2() and dsdb_load_udv_v1()
Andrew Tridgell [Fri, 15 Jan 2010 23:37:26 +0000 (10:37 +1100)]
s4-kcc: simplify the ReplicaGetInfo implementation a bit
Andrew Tridgell [Fri, 15 Jan 2010 23:36:56 +0000 (10:36 +1100)]
s4-kcc: squash a warning
Andrew Tridgell [Fri, 15 Jan 2010 23:36:40 +0000 (10:36 +1100)]
s4-drs: better debug info when security checks fail
show the security token of the user at debug level 2
Andrew Tridgell [Fri, 15 Jan 2010 23:36:06 +0000 (10:36 +1100)]
s4-dsdb: require admin access for DsReplicaGetInfo
Andrew Tridgell [Fri, 15 Jan 2010 08:36:16 +0000 (19:36 +1100)]
s4-drs: framework for DsGetReplInfo(), includes the DS_REPL_INFO_NEIGHBORS infoType.
This patch includes the framework for the implementation of all infoTypes of
the DsGetReplInfo() call, and includes the implementation for the first one,
the DS_REPL_INFO_NEIGHBORS.
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Andrew Tridgell [Fri, 15 Jan 2010 08:34:32 +0000 (19:34 +1100)]
s4-drs: give better debug info on unsupported DRS calls
Erick Nogueira do Nascimento [Wed, 23 Dec 2009 19:54:30 +0000 (17:54 -0200)]
s4-drs: torture test for DsGetReplInfo() (RPC-DSGETINFO test).
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Andrew Tridgell [Fri, 15 Jan 2010 08:13:26 +0000 (19:13 +1100)]
s4-dsdb: added isGlobalCatalogReady
needed for dcdiag.exe
Jeremy Allison [Sat, 16 Jan 2010 01:33:24 +0000 (17:33 -0800)]
Second part of bug 7045 - Bad (non memory copying) interfaces in smbc_setXXXX calls.
Protect against SMB_STRDUP of null...
Jeremy.
Jeremy Allison [Sat, 16 Jan 2010 01:22:35 +0000 (17:22 -0800)]
Fix bug 7045 - Bad (non memory copying) interfaces in smbc_setXXXX calls.
In smbc_free_context libsmbclient just called free() on the string options
so it assumes the callers have malloced them before setting them via smbc_set
calls.
Change to corretly malloc/free string options to the library.
Jeremy
Andrew Tridgell [Fri, 15 Jan 2010 21:58:27 +0000 (08:58 +1100)]
s4-ldb: cope with bad ptr alignment in ldb_index.c
We can't assume that a rec_ptr will come back from a tdb traverse with
alignment sufficient for a pointer.
Kai Blin [Fri, 15 Jan 2010 01:08:35 +0000 (02:08 +0100)]
s4 selftest: Ignore more winbind test known to fail
Günther Deschner [Thu, 14 Jan 2010 23:25:06 +0000 (00:25 +0100)]
s4-smbtorture: add setup_schannel_netlogon_pipe() function.
Guenther
Jeremy Allison [Thu, 14 Jan 2010 23:39:30 +0000 (15:39 -0800)]
Fix bug #7036 - net rpc getsid fails in hardened windows environments.
Fix suggested by Dave.Daugherty@Centrify.com.
Andreas Schneider [Thu, 14 Jan 2010 11:57:56 +0000 (12:57 +0100)]
s4-torture: Migrate ntp_signd test to tsocket.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Olivier Sessink [Thu, 14 Jan 2010 20:13:14 +0000 (12:13 -0800)]
Part 4 of bug #7028 - include scannedonly VFS module
Fix some issues with handling names ending in '/'.
Günther Deschner [Thu, 14 Jan 2010 18:34:26 +0000 (19:34 +0100)]
s3-libsmbclient: Fix crash bug in SMBC_parse_path().
Patch from Tim Waugh <twaugh@redhat.com>.
This resolves https://bugzilla.redhat.com/show_bug.cgi?id=552658
LIBSMBCLIENT-OPENDIR torture test checks this as well.
Guenther
Günther Deschner [Tue, 12 Jan 2010 16:42:00 +0000 (17:42 +0100)]
s4-smbtorture: add rather simple libsmbclient torture testsuite.
Guenther
Michael Adam [Thu, 14 Jan 2010 13:24:35 +0000 (14:24 +0100)]
s3:auth: fix account unlock regression introduced with fix for bug #4347
By an oversight, the patchset for #4347 made the unlocking of a locked
account after the lockout duration ineffective.
Thanks to Björn for finding this!
Michael
Kai Blin [Wed, 13 Jan 2010 12:58:20 +0000 (13:58 +0100)]
s3 selftest: Enable the WINBIND-STRUCT tests
Kai Blin [Thu, 14 Jan 2010 12:21:44 +0000 (13:21 +0100)]
s3 test: Fix WINBINDD-STRUCT tests
The struct-based tests are working in make selftest, make them work in plain
"make test" as well.
Kai Blin [Wed, 13 Jan 2010 15:46:17 +0000 (16:46 +0100)]
s3 selftest: Fix LOOKUP_SID test.
WINBINDD_LIST_USERS does not give a domain name if we're a DC and the user is
from our domain.
Kai Blin [Wed, 13 Jan 2010 15:02:00 +0000 (16:02 +0100)]
s3 selftest: Fix WINBINDD_LIST_GROUPS test
If there's no groups in the database, there are no entries in extra_data. This
caused WINBINDD_LIST_GROUPS test to fail. Use the fact that
WINBINDD_LIST_GROUPS now reports the number of groups in data.num_entries to
identify the "no groups" case.
Kai Blin [Wed, 13 Jan 2010 14:59:57 +0000 (15:59 +0100)]
s3 winbindd: Return number of groups in data.num_entries for WINBINDD_LIST_GROUPS
This allows to test if there's something wrong with the group list in
extra_data or if there's simply no groups in the database.
Volker, please check.
Kai Blin [Wed, 13 Jan 2010 14:21:14 +0000 (15:21 +0100)]
s3 selftest: Allow the enumeration of users and groups
This fixes the WINBINDD_GETPWENT test.
Kai Blin [Wed, 13 Jan 2010 13:49:26 +0000 (14:49 +0100)]
s3 selftest: Fix the WINBINDD_GETDCNAMEe test.
The WINBINDD_GETDCNAME test expected an NSS_STATUS_SUCCESS return from all
calls. However, this does not apply for BUILTIN and the DC's own domain.
Make the test work again by skipping those two.
Kai Blin [Wed, 13 Jan 2010 13:10:33 +0000 (14:10 +0100)]
s3 winbindd: Get WINBINDD_CHECK_MACHACC torture test to work again.
WINBINDD_CHECK_MACHACC used to report an NTSTATUS error and appropriate error
strings. Make this work again.
Matthias Dieter Wallnöfer [Wed, 13 Jan 2010 16:39:28 +0000 (17:39 +0100)]
s4:provision_users.ldif - Add a comment that some objects under "Users" are now located elsewhere
This is needed due to the new RID/SID distribution system
Matthias Dieter Wallnöfer [Sun, 10 Jan 2010 13:20:09 +0000 (14:20 +0100)]
s4:provision_users.ldif - Add objects for IIS
Some WSPP locations point out that beginning with Windows Server 2008 they're
also per default present.
Compared against Windows Server 2008
Matthias Dieter Wallnöfer [Mon, 11 Jan 2010 21:12:01 +0000 (22:12 +0100)]
s4:provision_users.ldif - Add additional BUILTIN objects
Compared against Windows Server 2008
Matthias Dieter Wallnöfer [Mon, 11 Jan 2010 21:01:42 +0000 (22:01 +0100)]
s4:provision_users.ldif - add the restant part of the objects needing for RODC support
RODC = Read Only Domain Controllers
Compared against Windows Server 2008
Matthias Dieter Wallnöfer [Mon, 11 Jan 2010 20:57:32 +0000 (21:57 +0100)]
s4:provision_users.ldif - Fix up errors on existing entries
Compared against Windows Server 2008
Matthias Dieter Wallnöfer [Mon, 11 Jan 2010 20:44:18 +0000 (21:44 +0100)]
s4:provision_users.ldif - Simple reordering
Sorted according the SID - easier for later enhancements.
Matthias Dieter Wallnöfer [Mon, 11 Jan 2010 20:36:40 +0000 (21:36 +0100)]
s4:provision_users.ldif - Remove system objects from the wrong place
Objects like the "Cryptographic Operators", "Event Log Readers" don't belong
here but into the builtin domain.
Matthias Dieter Wallnöfer [Tue, 12 Jan 2010 21:16:36 +0000 (22:16 +0100)]
s4:SAMR RPC - Fix the criteria for group searches
This should match the MS-SAMR documentation (section 3.1.5.5.1.1)
Andrew Tridgell [Thu, 14 Jan 2010 03:40:53 +0000 (14:40 +1100)]
s4-idl: get rid of the operation specific DRS options flags
It was confusing to have several sets of incomplete options when WSPP
uses a single set.
Andrew Tridgell [Thu, 14 Jan 2010 03:38:18 +0000 (14:38 +1100)]
s4-torture: switch smbtorture to the generic DRS options
Andrew Tridgell [Thu, 14 Jan 2010 03:38:00 +0000 (14:38 +1100)]
s4-drs: switch the DRS server to the generic DRS options flags