kai/samba-autobuild/.git
9 years agos4-kerberos Mention the remote address we fail to contact the KDC on
Andrew Bartlett [Fri, 5 Nov 2010 06:08:52 +0000 (17:08 +1100)]
s4-kerberos Mention the remote address we fail to contact the KDC on

9 years agos4-ldb: show the reason for module initialization failure
Andrew Tridgell [Fri, 5 Nov 2010 03:10:30 +0000 (14:10 +1100)]
s4-ldb: show the reason for module initialization failure

9 years agos4: net -> samba-tool
Andrew Tridgell [Fri, 5 Nov 2010 03:10:11 +0000 (14:10 +1100)]
s4: net -> samba-tool

9 years agos4-join: added DC join to the python join code
Andrew Tridgell [Fri, 5 Nov 2010 03:09:49 +0000 (14:09 +1100)]
s4-join: added DC join to the python join code

this will replace the old vampire code

9 years agos4-pydrs: added rodc option to python drs replication
Andrew Tridgell [Fri, 5 Nov 2010 03:08:49 +0000 (14:08 +1100)]
s4-pydrs: added rodc option to python drs replication

9 years agos4-pydsdb: added DsReplicaAttribute()
Andrew Tridgell [Fri, 5 Nov 2010 03:06:10 +0000 (14:06 +1100)]
s4-pydsdb: added DsReplicaAttribute()

this allows us to form a DsReplicaAttribute structure from python

9 years agopidl: use a union assignment instead of memmove
Andrew Tridgell [Fri, 5 Nov 2010 00:52:20 +0000 (11:52 +1100)]
pidl: use a union assignment instead of memmove

this means we don't lose type checking

Pair-Programmed-With: Jelmer Vernooij <jelmer@samba.org>

9 years agos4:password_hash LDB module - fix indentation
Matthias Dieter Wallnöfer [Fri, 5 Nov 2010 11:49:42 +0000 (12:49 +0100)]
s4:password_hash LDB module - fix indentation

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Nov  5 12:31:28 UTC 2010 on sn-devel-104

9 years agos3: Allow disabling of mdns registrations
Volker Lendecke [Fri, 5 Nov 2010 10:41:09 +0000 (11:41 +0100)]
s3: Allow disabling of mdns registrations

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Nov  5 11:24:41 UTC 2010 on sn-devel-104

9 years agofix in_screen so that it works on os that don't chdir to $PWD
Matthieu Patou [Mon, 1 Nov 2010 13:55:25 +0000 (00:55 +1100)]
fix in_screen so that it works on os that don't chdir to $PWD

That's the case on freebsd 7.2

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Nov  5 09:27:19 UTC 2010 on sn-devel-104

9 years agotsocket: fill in sa.sa_len if the system supports it
Stefan Metzmacher [Thu, 21 Oct 2010 05:00:34 +0000 (07:00 +0200)]
tsocket: fill in sa.sa_len if the system supports it

metze

9 years agoldb:ldb.h - reorder extended operations list
Matthias Dieter Wallnöfer [Thu, 4 Nov 2010 20:58:16 +0000 (21:58 +0100)]
ldb:ldb.h - reorder extended operations list

We always define the controls and operations with a comment block. The data
structure definitions lie a bit below.

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Nov  5 08:44:14 UTC 2010 on sn-devel-104

9 years agos4:dsdb/drepl_notify: reuse dreplsrv_notify_operation structures
Stefan Metzmacher [Thu, 4 Nov 2010 17:07:18 +0000 (18:07 +0100)]
s4:dsdb/drepl_notify: reuse dreplsrv_notify_operation structures

Otherwise we'll requeue the same notify events on and on.

(gdb) p *((struct dreplsrv_service *) 0x1b52190)->ops.notifies
$8 = {prev = 0xe4cb30, next = 0x1a25440, service = 0x1b52190, uSN = 123905,
source_dsa = 0x164c100, is_urgent = false, replica_flags = 29}
(gdb) p *((struct dreplsrv_service *) 0x1b52190)->ops.notifies->next
$9 = {prev = 0x80e000, next = 0x1b7bf70, service = 0x1b52190, uSN = 123589,
source_dsa = 0x1a2d930, is_urgent = false, replica_flags = 29}
(gdb) p *((struct dreplsrv_service *) 0x1b52190)->ops.notifies->next->next
$10 = {prev = 0x1a25440, next = 0x1d0c310, service = 0x1b52190, uSN = 1587,
source_dsa = 0x13d3210, is_urgent = false, replica_flags = 29}
(gdb) p *((struct dreplsrv_service *) 0x1b52190)->ops.notifies->next->next->next
$11 = {prev = 0x1b7bf70, next = 0x1ba1420, service = 0x1b52190, uSN = 123905,
source_dsa = 0x164c100, is_urgent = false, replica_flags = 29}
(gdb) p *((struct dreplsrv_service *)
0x1b52190)->ops.notifies->next->next->next->next
$12 = {prev = 0x1d0c310, next = 0x1c43510, service = 0x1b52190, uSN = 123589,
source_dsa = 0x1a2d930, is_urgent = false, replica_flags = 29}
(gdb) p *((struct dreplsrv_service *)
0x1b52190)->ops.notifies->next->next->next->next->next
$13 = {prev = 0x1ba1420, next = 0xed97b0, service = 0x1b52190, uSN = 1587,
source_dsa = 0x13d3210, is_urgent = false, replica_flags = 29}
(gdb) p *((struct dreplsrv_service *)
0x1b52190)->ops.notifies->next->next->next->next->next->next
$14 = {prev = 0x1c43510, next = 0xe4ce80, service = 0x1b52190, uSN = 123905,
source_dsa = 0x164c100, is_urgent = false, replica_flags = 29}

We can reuse this operations, while they're not yet started.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Nov  5 07:15:04 UTC 2010 on sn-devel-104

9 years agos4/auth: Add logon_parameters to authenticate_username_pw
Anatoliy Atanasov [Thu, 4 Nov 2010 22:00:13 +0000 (00:00 +0200)]
s4/auth: Add logon_parameters to authenticate_username_pw

We need to be able to set the logon parameters in the same way as in the
ntlm server so we can handle openldap simple authentication call correctly.

Autobuild-User: Anatoliy Atanasov <anatoliy@samba.org>
Autobuild-Date: Fri Nov  5 06:32:43 UTC 2010 on sn-devel-104

9 years agos4/test: Added test for simple bind with machine account
Anatoliy Atanasov [Thu, 4 Nov 2010 21:57:48 +0000 (23:57 +0200)]
s4/test: Added test for simple bind with machine account

Samba4 returns error on simple bind, when we do it using openldap
simple_bind_s api.

9 years agotalloc: Add python talloc module, move convenience functions to it.
Jelmer Vernooij [Fri, 5 Nov 2010 02:00:45 +0000 (03:00 +0100)]
talloc: Add python talloc module, move convenience functions to it.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Fri Nov  5 02:48:21 UTC 2010 on sn-devel-104

9 years agotalloc: rename pytalloc.c to pytalloc_util.c
Jelmer Vernooij [Fri, 5 Nov 2010 01:35:55 +0000 (02:35 +0100)]
talloc: rename pytalloc.c to pytalloc_util.c

9 years agowaf: Put private libraries in a separate directory when building.
Jelmer Vernooij [Fri, 5 Nov 2010 01:30:01 +0000 (02:30 +0100)]
waf: Put private libraries in a separate directory when building.

Thanks to Tridge for pointing out what exactly I had to change. :-)

9 years agowafsamba: Use project name variable rather than hardcoding 'samba4'.
Jelmer Vernooij [Fri, 5 Nov 2010 01:08:44 +0000 (02:08 +0100)]
wafsamba: Use project name variable rather than hardcoding 'samba4'.

Suggested-By: Andrew Tridgell <tridge@samba.org>
9 years agowafsamba: Drop private library prefix when installing private libraries
Jelmer Vernooij [Thu, 4 Nov 2010 23:33:51 +0000 (00:33 +0100)]
wafsamba: Drop private library prefix when installing private libraries
to a custom path.

9 years agowafsamba: Support expanding variables in LIBDIR/PRIVATELIBDIR variables.
Jelmer Vernooij [Thu, 4 Nov 2010 23:20:16 +0000 (00:20 +0100)]
wafsamba: Support expanding variables in LIBDIR/PRIVATELIBDIR variables.

9 years agoAdd --disable-rpath-private-install flag.
Jelmer Vernooij [Thu, 4 Nov 2010 23:03:20 +0000 (00:03 +0100)]
Add --disable-rpath-private-install flag.

9 years agoAdd --with-privatelibdir build option.
Jelmer Vernooij [Thu, 4 Nov 2010 22:23:39 +0000 (23:23 +0100)]
Add --with-privatelibdir build option.

9 years agosamba_utils: Use LIBDIR rather than assuming it is set to $prefix/lib.
Jelmer Vernooij [Thu, 4 Nov 2010 22:02:50 +0000 (23:02 +0100)]
samba_utils: Use LIBDIR rather than assuming it is set to $prefix/lib.

9 years agoselftest: Allow some tests to output empty subunit data.
Jelmer Vernooij [Thu, 4 Nov 2010 01:07:57 +0000 (02:07 +0100)]
selftest: Allow some tests to output empty subunit data.

9 years agos4-ldap_server Don't DEBUG() at level 2 every time a caller disconnects
Andrew Bartlett [Thu, 4 Nov 2010 23:28:04 +0000 (10:28 +1100)]
s4-ldap_server Don't DEBUG() at level 2 every time a caller disconnects

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Nov  5 00:12:37 UTC 2010 on sn-devel-104

9 years agos4: don't run etags over .inst files
Andrew Tridgell [Thu, 4 Nov 2010 22:01:47 +0000 (09:01 +1100)]
s4: don't run etags over .inst files

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Nov  4 22:51:06 UTC 2010 on sn-devel-104

9 years agocompression: added a simple lzxpress test
Andrew Tridgell [Thu, 4 Nov 2010 22:01:28 +0000 (09:01 +1100)]
compression: added a simple lzxpress test

9 years agocompression: fixed an uninitialised data but in lzxpress
Andrew Tridgell [Thu, 4 Nov 2010 22:00:57 +0000 (09:00 +1100)]
compression: fixed an uninitialised data but in lzxpress

9 years agos3: Remove the use of cli_send_trans from cli_get_fs_full_size_info
Volker Lendecke [Thu, 4 Nov 2010 18:23:06 +0000 (19:23 +0100)]
s3: Remove the use of cli_send_trans from cli_get_fs_full_size_info

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Nov  4 22:08:53 UTC 2010 on sn-devel-104

9 years agos4:ldap.py/passwords.py - just use objectclass "user" for users
Matthias Dieter Wallnöfer [Mon, 1 Nov 2010 16:23:34 +0000 (17:23 +0100)]
s4:ldap.py/passwords.py - just use objectclass "user" for users

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Nov  4 21:09:00 UTC 2010 on sn-devel-104

9 years agos3: Remove an unused prototype
Volker Lendecke [Thu, 4 Nov 2010 17:49:55 +0000 (18:49 +0100)]
s3: Remove an unused prototype

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Nov  4 17:44:09 UTC 2010 on sn-devel-104

9 years agos4:dsdb/objectclass_attrs: not all objects have delete protected attributes as must...
Stefan Metzmacher [Thu, 4 Nov 2010 11:37:29 +0000 (12:37 +0100)]
s4:dsdb/objectclass_attrs: not all objects have delete protected attributes as must contain

Before we got the following error, while starting samba after a
'samba-tool vampire':

Failed to store repsFrom - objectclass_attrs: delete protected attribute
'objectSid' on entry 'DC=ForestDnsZones,DC=alpha,DC=sz,DC=salzgitter-ag,DC=lab'
missing!

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Nov  4 17:01:59 UTC 2010 on sn-devel-104

9 years agos4:dsdb/samdb: optimize samldb_prim_group_change()
Stefan Metzmacher [Wed, 3 Nov 2010 11:33:54 +0000 (12:33 +0100)]
s4:dsdb/samdb: optimize samldb_prim_group_change()

We should only do searches when we have to.

metze

9 years agos4:dsdb/common: fix memory leak in samdb_ntds_settings_dn()
Stefan Metzmacher [Thu, 4 Nov 2010 13:29:12 +0000 (14:29 +0100)]
s4:dsdb/common: fix memory leak in samdb_ntds_settings_dn()

fetch and set should use the same name!

metze

9 years agos4:dsdb/kcc: fix memory leak in kcctpl_copy_output_edges()
Stefan Metzmacher [Thu, 4 Nov 2010 12:32:06 +0000 (13:32 +0100)]
s4:dsdb/kcc: fix memory leak in kcctpl_copy_output_edges()

metze

9 years agos3-waf: add check for httpConnect and httpConnectEncrypt.
Günther Deschner [Wed, 3 Nov 2010 16:16:06 +0000 (17:16 +0100)]
s3-waf: add check for httpConnect and httpConnectEncrypt.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Nov  4 14:10:40 UTC 2010 on sn-devel-104

9 years agos4-ldb_module.h: use LDB error code for ldb_error() macro rather than LDB_DEBUG_FATAL
Kamen Mazdrashki [Thu, 4 Nov 2010 01:27:10 +0000 (03:27 +0200)]
s4-ldb_module.h: use LDB error code for ldb_error() macro rather than LDB_DEBUG_FATAL

We end up calling ldb_error_at() which expects an LDB error,
but LDB_DEBUG_FATAL is not such code. It is actually equal to LDB_SUCCESS.

Thus the effect is that we report a *fatal* error, but return
LDB_SUCCESS in many places.

Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Thu Nov  4 12:57:33 UTC 2010 on sn-devel-104

9 years agos4-devel: Verify prefixMap is saved correctly in LDB on disk
Kamen Mazdrashki [Wed, 3 Nov 2010 21:43:21 +0000 (23:43 +0200)]
s4-devel: Verify prefixMap is saved correctly in LDB on disk

9 years agourgent_replication: forbid empty subunit output.
Jelmer Vernooij [Thu, 4 Nov 2010 11:29:42 +0000 (12:29 +0100)]
urgent_replication: forbid empty subunit output.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Thu Nov  4 12:13:47 UTC 2010 on sn-devel-104

9 years agoselftest: Allow some tests to output empty subunit data.
Jelmer Vernooij [Thu, 4 Nov 2010 01:07:57 +0000 (02:07 +0100)]
selftest: Allow some tests to output empty subunit data.

9 years agos4-dsdb Fix urgent_replication test not to set an invalid userAccountControl
Andrew Bartlett [Thu, 4 Nov 2010 02:16:11 +0000 (13:16 +1100)]
s4-dsdb Fix urgent_replication test not to set an invalid userAccountControl

A userAccountControl value of 0 or 1 is invalid, you must include one of
the account types.

Andrew Bartlett

9 years agourgent_replication: Fix syntax error.
Jelmer Vernooij [Thu, 4 Nov 2010 00:36:57 +0000 (01:36 +0100)]
urgent_replication: Fix syntax error.

9 years agos4-dsdb: use LDB_FLAG_MOD_REPLACE for isDeleted
Andrew Tridgell [Thu, 4 Nov 2010 09:34:37 +0000 (20:34 +1100)]
s4-dsdb: use LDB_FLAG_MOD_REPLACE for isDeleted

isDeleted could have been set to FALSE previously

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Nov  4 10:18:10 UTC 2010 on sn-devel-104

9 years agos4-dsdb: use LDB_FLAG_INTERNAL_DISABLE_SINGLE_VALUE_CHECK in dsdb
Andrew Tridgell [Thu, 4 Nov 2010 09:33:31 +0000 (20:33 +1100)]
s4-dsdb: use LDB_FLAG_INTERNAL_DISABLE_SINGLE_VALUE_CHECK in dsdb

when we are creating linked attributes with multiple values (some
deleted), use LDB_FLAG_INTERNAL_DISABLE_SINGLE_VALUE_CHECK to disable
that checking.

9 years agos4-ldb: implement LDB_FLAG_INTERNAL_DISABLE_SINGLE_VALUE_CHECK
Andrew Tridgell [Thu, 4 Nov 2010 09:27:43 +0000 (20:27 +1100)]
s4-ldb: implement LDB_FLAG_INTERNAL_DISABLE_SINGLE_VALUE_CHECK

this disables the single value checking for one attribute. It is much
more specific than a general RELAX control, and also more efficient. I
think we should try to have more precise overrides like this, rather
than using RELAX as a general purpose override

9 years agos4-ldb: don't load modules from the same directory twice
Andrew Tridgell [Thu, 4 Nov 2010 09:13:17 +0000 (20:13 +1100)]
s4-ldb: don't load modules from the same directory twice

this prevents samba dying if you do a 'make install' while it is
running. Otherwise the make install changes the inode numbers of the
modules in the modules directory, causing them to reload, which causes
multiple modules of the same name to try and load

9 years agos4-ldb: honor controls on search in ldbedit
Andrew Tridgell [Thu, 4 Nov 2010 09:05:59 +0000 (20:05 +1100)]
s4-ldb: honor controls on search in ldbedit

9 years agoMove the checking of single valued attributes back into the tdb backend.
Andrew Tridgell [Thu, 4 Nov 2010 09:02:16 +0000 (20:02 +1100)]
Move the checking of single valued attributes back into the tdb backend.

The backend is the only place that can do this properly. It makes no
sense to do it anywhere else. As a result of it moving out of the
backend we ended up with some bugs causing multiple values in single
valued attributes (eg. isDeleted), which can really damage the
inregrity of the database.

For the override of single valued values needed for deleted linked
attributes we should use attribute flags.

This reverts commit 1949864417f3d10fb8996df7db259649eb777271.

9 years agos4-test: fixed quoting in deletetest.py
Andrew Tridgell [Thu, 4 Nov 2010 02:23:47 +0000 (13:23 +1100)]
s4-test: fixed quoting in deletetest.py

9 years agos4-auth: unconditionally set previous_ev
Andrew Tridgell [Thu, 4 Nov 2010 01:52:08 +0000 (12:52 +1100)]
s4-auth: unconditionally set previous_ev

we need the caller to know when the previous_ev was NULL

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agodebug: fixed default debug settings
Andrew Tridgell [Wed, 3 Nov 2010 23:25:30 +0000 (10:25 +1100)]
debug: fixed default debug settings

this fixes -d in our command line tools (eg. samba-tool)

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Nov  4 01:48:15 UTC 2010 on sn-devel-104

9 years agoSpeed test with user objects
Zahari Zahariev [Fri, 29 Oct 2010 16:34:13 +0000 (19:34 +0300)]
Speed test with user objects

This is a modest speed test that aims to show performance difference
between Samba4 vs MS Active Directory. It should be used with Samba-style
credentials and no arguments like every other python unittest.

Signed-off-by: Anatoliy Atanasov <anatoliy.atanasov@postpath.com>
Autobuild-User: Anatoliy Atanasov <anatoliy@samba.org>
Autobuild-Date: Thu Nov  4 00:11:20 UTC 2010 on sn-devel-104

9 years agolibrpc/ndr: use new strlen_m_ext_term() in ndr_charset_length(): fix bug #7594
Michael Adam [Sun, 31 Oct 2010 00:04:25 +0000 (02:04 +0200)]
librpc/ndr: use new strlen_m_ext_term() in ndr_charset_length(): fix bug #7594

This fixes the calculation of needed space for destination unicode charset.

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Nov  3 23:28:07 UTC 2010 on sn-devel-104

9 years agolib/util/charset/charconv: clarify comments in next_codepoint_convenience_ext()
Michael Adam [Sun, 31 Oct 2010 07:21:41 +0000 (08:21 +0100)]
lib/util/charset/charconv: clarify comments in next_codepoint_convenience_ext()

Give the unicod U+<hexnumber> notation of the codepoints
referred to in the comments. Also reformat the comments some.

9 years agolib/util/charset/util_unistr: clarify the comment header for strlen_m().
Michael Adam [Sun, 31 Oct 2010 07:02:17 +0000 (08:02 +0100)]
lib/util/charset/util_unistr: clarify the comment header for strlen_m().

9 years agolib/util/charset/util_unistr: add strlen_m_ext_term() - variant of strlen_m_ext(...
Michael Adam [Sun, 31 Oct 2010 00:02:16 +0000 (02:02 +0200)]
lib/util/charset/util_unistr: add strlen_m_ext_term() - variant of strlen_m_ext() counting terminator

9 years agolib/util/charset/util_unistr: add strlen_m_ext that takes input and output charset
Michael Adam [Sat, 30 Oct 2010 00:03:02 +0000 (02:03 +0200)]
lib/util/charset/util_unistr: add strlen_m_ext that takes input and output charset

The function calculates the number of units (8 or 16-bit, depending
on the destination charset), that would be needed to convert the
input string which is expected to be in in src_charset encoding
to the dst_charset (which should be a unicode charset).

9 years agolib/charcnv/util_unistr: add next_codepoint_ext() that accepts input charset.
Michael Adam [Sun, 31 Oct 2010 01:18:46 +0000 (02:18 +0100)]
lib/charcnv/util_unistr: add next_codepoint_ext() that accepts input charset.

next_codepoint() takes as string in CH_UNIX encoding and returns the
unicode codepoint of the next (possibly multibyte) character of the
input string.

The new next_codepoint_ext() function adds the encoding of the input
string as a parameter. next_codepoint() now only calls next_codepoint_ext()
with CH_UNIX als src_charset argument.

9 years agolib/charset/charcnv: rename a parameter of next_codepoint_convenience_ext() for clarity
Michael Adam [Mon, 1 Nov 2010 14:53:43 +0000 (15:53 +0100)]
lib/charset/charcnv: rename a parameter of next_codepoint_convenience_ext() for clarity

9 years agolib/charset/charcnv: add next_codepoint_convenience_ext() that accepts input charset.
Michael Adam [Fri, 29 Oct 2010 20:06:05 +0000 (22:06 +0200)]
lib/charset/charcnv: add next_codepoint_convenience_ext() that accepts input charset.

next_codepoint_convenience() takes as string in CH_UNIX encoding and returns the
unicode codepoint of the next (possibly multibyte) character of the
input string.

The new next_codepoint_convenience_ext() function adds the encoding of the input
string as a parameter. next_codepoint_convenience() now only calls
next_codepoint_convenience_ext() with CH_UNIX als src_charset argument.

9 years agos3:util_str: add strlen_m_ext_term() - variant of strlen_m_ext() counting terminator
Michael Adam [Sun, 31 Oct 2010 00:02:16 +0000 (02:02 +0200)]
s3:util_str: add strlen_m_ext_term() - variant of strlen_m_ext() counting terminator

9 years agos3:lib/util_str: add strlen_m_ext() that takes input and output charset
Michael Adam [Sat, 30 Oct 2010 00:03:02 +0000 (02:03 +0200)]
s3:lib/util_str: add strlen_m_ext() that takes input and output charset

The function calculates the number of units (8 or 16-bit, depending
on the destination charset), that would be needed to convert the
input string which is expected to be in in src_charset encoding
to the dst_charset (which should be a unicode charset).

9 years agos3:lib/util_str: clarify the comment header for strlen_m().
Michael Adam [Fri, 29 Oct 2010 20:21:47 +0000 (22:21 +0200)]
s3:lib/util_str: clarify the comment header for strlen_m().

9 years agos3:lib/charcnv: clarify comments in next_codepoint_ext()
Michael Adam [Fri, 29 Oct 2010 20:11:30 +0000 (22:11 +0200)]
s3:lib/charcnv: clarify comments in next_codepoint_ext()

(giving the unicod U+<hexnumber> notation of the codepoints
 referred to in the comments)

9 years agos3:lib/charcnv: rename a parameter for clarity in next_codepoint_ext()
Michael Adam [Mon, 1 Nov 2010 14:42:21 +0000 (15:42 +0100)]
s3:lib/charcnv: rename a parameter for clarity in next_codepoint_ext()

9 years agos3:lib/charcnv: reformat comments in next_codepoint_ext()
Michael Adam [Mon, 1 Nov 2010 14:42:21 +0000 (15:42 +0100)]
s3:lib/charcnv: reformat comments in next_codepoint_ext()

9 years agos3:lib/charcnv: add next_codepoint_ext() that accepts input charset.
Michael Adam [Fri, 29 Oct 2010 20:06:05 +0000 (22:06 +0200)]
s3:lib/charcnv: add next_codepoint_ext() that accepts input charset.

next_codepoint() takes as string in CH_UNIX encoding and returns the
unicode codepoint of the next (possibly multibyte) character of the
input string.

The new next_codepoint_ext() function adds the encoding of the input
string as a parameter. next_codepoint() now only calls next_codepoint_ext()
with CH_UNIX als src_charset argument.

9 years agoutil/charset: remove a duplicate comment.
Michael Adam [Fri, 29 Oct 2010 18:50:28 +0000 (20:50 +0200)]
util/charset: remove a duplicate comment.

This seems to have been copied twice from source3/ code.

9 years agobuild: a more portable way of finding waf in makefiles
Andrew Tridgell [Wed, 3 Nov 2010 21:29:11 +0000 (08:29 +1100)]
build: a more portable way of finding waf in makefiles

this avoids using the non-portable shell command in makefiles

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Nov  3 22:44:59 UTC 2010 on sn-devel-104

9 years agoselftest/tests.py: Fix typos.
Jelmer Vernooij [Wed, 3 Nov 2010 18:14:02 +0000 (19:14 +0100)]
selftest/tests.py: Fix typos.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Wed Nov  3 19:55:55 UTC 2010 on sn-devel-104

9 years agoprovision: Look for in source setup data first, in case an older version
Jelmer Vernooij [Wed, 3 Nov 2010 18:13:03 +0000 (19:13 +0100)]
provision: Look for in source setup data first, in case an older version
of samba 4 is installed in the system.

9 years agosamba: Make in_source_tree() public.
Jelmer Vernooij [Wed, 3 Nov 2010 18:12:17 +0000 (19:12 +0100)]
samba: Make in_source_tree() public.

9 years agourgent_replication: Fix formatting
Jelmer Vernooij [Wed, 3 Nov 2010 18:11:26 +0000 (19:11 +0100)]
urgent_replication: Fix formatting

9 years agopossibleinferiors: Report subunit.
Jelmer Vernooij [Wed, 3 Nov 2010 17:43:38 +0000 (18:43 +0100)]
possibleinferiors: Report subunit.

9 years agopossibleinferiors: Fix formatting.
Jelmer Vernooij [Wed, 3 Nov 2010 17:41:49 +0000 (18:41 +0100)]
possibleinferiors: Fix formatting.

9 years agoreplace/wscript: add size checks for stdint.h types
Stefan Metzmacher [Wed, 3 Nov 2010 16:40:39 +0000 (17:40 +0100)]
replace/wscript: add size checks for stdint.h types

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Nov  3 19:12:39 UTC 2010 on sn-devel-104

9 years agoreplace/wscript: do the size checks directly after the type checks
Stefan Metzmacher [Wed, 3 Nov 2010 16:40:12 +0000 (17:40 +0100)]
replace/wscript: do the size checks directly after the type checks

metze

9 years agoreplace/wscript: define bool to int instead of off_t
Stefan Metzmacher [Wed, 3 Nov 2010 16:35:47 +0000 (17:35 +0100)]
replace/wscript: define bool to int instead of off_t

metze

9 years agoreplace/wscript: check for uint8_t
Stefan Metzmacher [Wed, 3 Nov 2010 16:34:35 +0000 (17:34 +0100)]
replace/wscript: check for uint8_t

metze

9 years agos4:dsdb/samldb: avoid nested unindexed searches in samldb_member_check()
Stefan Metzmacher [Wed, 3 Nov 2010 11:34:47 +0000 (12:34 +0100)]
s4:dsdb/samldb: avoid nested unindexed searches in samldb_member_check()

With 20000 objects in the database it's no fun to add members...

metze

9 years agos4:dsdb/tests/python/sam.py: test with member: <SID=...>
Stefan Metzmacher [Wed, 3 Nov 2010 16:41:10 +0000 (17:41 +0100)]
s4:dsdb/tests/python/sam.py: test with member: <SID=...>

metze

9 years agos4:descriptor LDB module - a bit cleanup
Matthias Dieter Wallnöfer [Mon, 1 Nov 2010 16:50:23 +0000 (17:50 +0100)]
s4:descriptor LDB module - a bit cleanup

- add more OOM checks where needed
- remove message of an error which cannot happen anymore (since now the
  structural objectclass is always checked by the objectclass LDB module)

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Wed Nov  3 18:30:52 UTC 2010 on sn-devel-104

9 years agos4:sam.py - assign valid values when performing the special-attributes constraint...
Matthias Dieter Wallnöfer [Wed, 3 Nov 2010 17:02:28 +0000 (18:02 +0100)]
s4:sam.py - assign valid values when performing the special-attributes constraint checks

The problem is that s4 per construction does the checks in a different order. It
first checks for validity (pre-operation trigger in samldb LDB module) and then
for the schema (post-operation trigger in objectclass_attrs LDB module).
constraints (post-operation trigger

9 years agos4:samldb LDB module - improve the "get_single_valued_attr" call and move it into...
Matthias Dieter Wallnöfer [Wed, 3 Nov 2010 16:50:30 +0000 (17:50 +0100)]
s4:samldb LDB module - improve the "get_single_valued_attr" call and move it into "ldb_modules/util.c"

It will be used by other LDB modules as well.

9 years agos4:objectclass_attrs LDB module - introduce the hardcoded delete-protected attributes...
Matthias Dieter Wallnöfer [Wed, 3 Nov 2010 16:29:58 +0000 (17:29 +0100)]
s4:objectclass_attrs LDB module - introduce the hardcoded delete-protected attributes list

This is a hardcoded list in AD of attributes, which can never be deleted.

9 years agopydsdb: Import testtools before subunit for those that don't have
Jelmer Vernooij [Wed, 3 Nov 2010 16:53:19 +0000 (17:53 +0100)]
pydsdb: Import testtools before subunit for those that don't have
testtools installed.

Also, cleanup some imports.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Wed Nov  3 17:47:55 UTC 2010 on sn-devel-104

9 years agofilter-subunit: Add --fail-on-empty argument.
Jelmer Vernooij [Wed, 3 Nov 2010 15:30:40 +0000 (16:30 +0100)]
filter-subunit: Add --fail-on-empty argument.

9 years agos3: Align nttrans replies the same way Windows does it
Volker Lendecke [Fri, 3 Jul 2009 11:28:01 +0000 (13:28 +0200)]
s3: Align nttrans replies the same way Windows does it

If you look at traces of "smbcacls" reading a secdesc from Samba and from W2k3
shows this difference in the querysecdesc nttrans reply. This patch is
necessary to enable viewing previous versions via the shadow copy modules from
Windows 2008. The other client versions seem not to care, but W2k8 does.

Signed-off-by: Michael Adam <obnox@samba.org>
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Nov  3 17:04:28 UTC 2010 on sn-devel-104

9 years agos4:objectclass LDB module - the structural objectclass has always to be specified
Matthias Dieter Wallnöfer [Mon, 1 Nov 2010 14:23:48 +0000 (15:23 +0100)]
s4:objectclass LDB module - the structural objectclass has always to be specified

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Wed Nov  3 16:20:55 UTC 2010 on sn-devel-104

9 years agos4:objectclass_attrs LDB module - refactor the "dSHeuristics" checker
Matthias Dieter Wallnöfer [Wed, 3 Nov 2010 15:25:17 +0000 (16:25 +0100)]
s4:objectclass_attrs LDB module - refactor the "dSHeuristics" checker

The checks are done when there are more than 0 values. The other checks should
be performed by the other parts of the module.

9 years agos4:objectclass_attrs LDB module - simplify the invoke of the "dSHeuristics" checker
Matthias Dieter Wallnöfer [Wed, 3 Nov 2010 15:21:37 +0000 (16:21 +0100)]
s4:objectclass_attrs LDB module - simplify the invoke of the "dSHeuristics" checker

It's always invoked on add and modify operations.

9 years agos4-tests: Tests for the dSHeuristics attribute value restrictions
Nadezhda Ivanova [Wed, 3 Nov 2010 13:15:02 +0000 (15:15 +0200)]
s4-tests: Tests for the dSHeuristics attribute value restrictions

Autobuild-User: Nadezhda Ivanova <nivanova@samba.org>
Autobuild-Date: Wed Nov  3 13:58:42 UTC 2010 on sn-devel-104

9 years agos4-dsdb: Implemented value restrictions for the dSHeuristics attribute
Nadezhda Ivanova [Wed, 3 Nov 2010 13:14:06 +0000 (15:14 +0200)]
s4-dsdb: Implemented value restrictions for the dSHeuristics attribute

9 years agos3: Fix a getgrent crash with many groups
Volker Lendecke [Wed, 3 Nov 2010 12:08:37 +0000 (13:08 +0100)]
s3: Fix a getgrent crash with many groups

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Nov  3 12:58:49 UTC 2010 on sn-devel-104

9 years agos4-server: cleanup allocation of process models
Andrew Tridgell [Wed, 3 Nov 2010 09:57:38 +0000 (20:57 +1100)]
s4-server: cleanup allocation of process models

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Nov  3 10:40:52 UTC 2010 on sn-devel-104

9 years agos4-ldb: fixed sorting of module names
Andrew Tridgell [Wed, 3 Nov 2010 09:37:08 +0000 (20:37 +1100)]
s4-ldb: fixed sorting of module names

this should also fix a valgrind error on freebsd

thanks to Matthieu for spotting this

9 years agos4:objectguid LDB module - remove "objectguid_find_attribute"
Matthias Dieter Wallnöfer [Wed, 3 Nov 2010 08:39:15 +0000 (09:39 +0100)]
s4:objectguid LDB module - remove "objectguid_find_attribute"

It's exactly the same as "ldb_msg_find_element".

In addition remove a comment which points out a "fixme" for a semi-async call
since we started to permit them again.

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Wed Nov  3 09:29:46 UTC 2010 on sn-devel-104

9 years agos4:RPC server - always set the response pad data in base of the request one
Matthias Dieter Wallnöfer [Wed, 3 Nov 2010 08:23:33 +0000 (09:23 +0100)]
s4:RPC server - always set the response pad data in base of the request one

Otherwise it could remain uninitialised - should fix bug #7769.

9 years agos4:RPC server - cosmetic fixes - indentation, comments
Matthias Dieter Wallnöfer [Wed, 3 Nov 2010 08:23:00 +0000 (09:23 +0100)]
s4:RPC server - cosmetic fixes - indentation, comments