From: Andrew Bartlett <abartlet@samba.org>
Date: Sat, 7 Feb 2015 06:45:24 +0000 (+1300)
Subject: torture-krb5: Provide a generic handler to catch and print unexpected KRB_ERROR packets
X-Git-Tag: tevent-0.9.23~178
X-Git-Url: http://git.samba.org/samba.git/?p=kai%2Fsamba-autobuild%2F.git;a=commitdiff_plain;h=bfccf0abf8a11788b59edab1983d14114906c7f4

torture-krb5: Provide a generic handler to catch and print unexpected KRB_ERROR packets

This may aid debugging in the future.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-By: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by:  Kamen Mazdrashki <kamenim@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sun Feb  8 10:37:23 CET 2015 on sn-devel-104
---

diff --git a/source4/torture/krb5/kdc-canon.c b/source4/torture/krb5/kdc-canon.c
index e745fe5d8ed..312c7b59378 100644
--- a/source4/torture/krb5/kdc-canon.c
+++ b/source4/torture/krb5/kdc-canon.c
@@ -60,16 +60,16 @@ struct test_data {
 
 enum test_stage {
 	TEST_AS_REQ = 0,
-	TEST_TGS_REQ_KRBTGT_CANON,
-	TEST_TGS_REQ_CANON,
-	TEST_SELF_TRUST_TGS_REQ,
-	TEST_TGS_REQ,
-	TEST_TGS_REQ_KRBTGT,
-	TEST_TGS_REQ_HOST,
-	TEST_TGS_REQ_HOST_SRV_INST,
-	TEST_TGS_REQ_HOST_SRV_HST,
-	TEST_AS_REQ_SELF,
-	TEST_DONE
+	TEST_TGS_REQ_KRBTGT_CANON = 1,
+	TEST_TGS_REQ_CANON = 2,
+	TEST_SELF_TRUST_TGS_REQ = 3,
+	TEST_TGS_REQ = 4,
+	TEST_TGS_REQ_KRBTGT = 5,
+	TEST_TGS_REQ_HOST = 6,
+	TEST_TGS_REQ_HOST_SRV_INST = 7,
+	TEST_TGS_REQ_HOST_SRV_HST = 8,
+	TEST_AS_REQ_SELF = 9,
+	TEST_DONE = 10
 };
 
 struct torture_krb5_context {
@@ -1224,6 +1224,18 @@ static krb5_error_code smb_krb5_send_and_recv_func_canon_override(krb5_context c
 		break;
 	}
 	if (ok == false) {
+		KRB_ERROR error;
+		size_t used;
+		torture_warning(test_context->tctx, "Packet of length %llu failed post-recv checks in test stage %d", (unsigned long long)recv_buf->length, test_context->test_stage);
+		if (decode_KRB_ERROR(recv_buf->data, recv_buf->length, &error, &used) == 0) {
+			torture_warning(test_context->tctx, 
+					"STAGE: %d Unexpectedly got a KRB-ERROR packet "
+					"with error code %d (%s)",
+					test_context->test_stage,
+					error.error_code,
+					error_message(error.error_code + KRB5KDC_ERR_NONE));
+			free_KRB_ERROR(&error);
+		}
 		return EINVAL;
 	}