From: Volker Lendecke <vl@samba.org>
Date: Sat, 10 Mar 2018 17:01:08 +0000 (+0100)
Subject: libsmb: Introduce a helper variable
X-Git-Tag: ldb-1.4.0~661
X-Git-Url: http://git.samba.org/samba.git/?p=kai%2Fsamba-autobuild%2F.git;a=commitdiff_plain;h=295c53405ab5f12b79e62d54e288a7c9bafc857f

libsmb: Introduce a helper variable

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/libsmb/clidgram.c b/source3/libsmb/clidgram.c
index 4ae57a30d33..cb319b1a7e8 100644
--- a/source3/libsmb/clidgram.c
+++ b/source3/libsmb/clidgram.c
@@ -308,6 +308,7 @@ struct tevent_req *nbt_getdc_send(TALLOC_CTX *mem_ctx,
 	struct tevent_req *req, *subreq;
 	struct nbt_getdc_state *state;
 	uint16_t dgm_id;
+	bool ok;
 
 	req = tevent_req_create(mem_ctx, &state, struct nbt_getdc_state);
 	if (req == NULL) {
@@ -338,9 +339,10 @@ struct tevent_req *nbt_getdc_send(TALLOC_CTX *mem_ctx,
 
 	generate_random_buffer((uint8_t *)(void *)&dgm_id, sizeof(dgm_id));
 
-	if (!prep_getdc_request(dc_addr, domain_name, sid, nt_version,
+	ok = prep_getdc_request(dc_addr, domain_name, sid, nt_version,
 				state->my_mailslot, dgm_id & 0x7fff,
-				&state->p)) {
+				&state->p);
+	if (!ok) {
 		DEBUG(3, ("prep_getdc_request failed\n"));
 		tevent_req_nterror(req, NT_STATUS_INVALID_PARAMETER);
 		return tevent_req_post(req, ev);