s4: Fix a few warnings.
authorJelmer Vernooij <jelmer@samba.org>
Wed, 20 Jan 2010 03:27:38 +0000 (16:27 +1300)
committerJelmer Vernooij <jelmer@samba.org>
Thu, 21 Jan 2010 03:15:11 +0000 (16:15 +1300)
source4/auth/pyauth.c
source4/lib/ldb/tools/cmdline.c
source4/lib/stream/packet.h
source4/param/provision.c
source4/torture/rpc/samba3rpc.c
source4/torture/smb2/acls.c

index 7ec7f3e7f2c449b54c713c0c1b756b3576a1c53f..865609e8e3630535f5757ab6ed98636ba05e6cd1 100644 (file)
@@ -16,6 +16,7 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
+#include <Python.h>
 #include "includes.h"
 #include "param/param.h"
 #include "pyauth.h"
index 44ae23b26c629dc0db78ecc1ae85821e938a1ace..f2becb17af403079a905f5482b683181cb963d16 100644 (file)
@@ -33,6 +33,8 @@
 #include "auth/auth.h"
 #include "ldb_wrap.h"
 #include "param/param.h"
+#include "librpc/gen_ndr/drsblobs.h"
+#include "dsdb/schema/schema.h"
 #include "dsdb/common/proto.h"
 #endif
 
index 85f0f26265c9e1c45620468639a95ac5b939ab68..a274bd397c180b2fa78f7c4b99f11d4c48d42569 100644 (file)
@@ -23,6 +23,7 @@
 struct packet_context;
 struct tevent_context;
 struct tevent_fd;
+struct socket_context;
 
 typedef NTSTATUS (*packet_full_request_fn_t)(void *private_data,
                                             DATA_BLOB blob, size_t *packet_size);
index 7bd10ca522cd0efc18adc4a5053660aa3a2aff3b..920a5d8639e8a5b0e664c159a9d7d7b376eca2a1 100644 (file)
@@ -68,7 +68,7 @@ static PyObject *PyLdb_FromLdbContext(struct ldb_context *ldb_ctx)
        if (ldb_mod == NULL)
                return NULL;
 
-       ldb_ctx_type = PyObject_GetAttrString(ldb_mod, "Ldb");
+       ldb_ctx_type = (PyTypeObject *)PyObject_GetAttrString(ldb_mod, "Ldb");
 
        ret = (PyLdbObject *)ldb_ctx_type->tp_alloc(ldb_ctx_type, 0);
        if (ret == NULL) {
index 7cae8db34455192c4232c6efe3fb922f73124bb8..86f41b058bcff32f29901835483a77ed3348a3fa 100644 (file)
@@ -3551,7 +3551,6 @@ bool torture_samba3_getaliasmembership_0(struct torture_context *torture)
 {
        struct dcerpc_pipe *p;
        NTSTATUS status;
-       bool ret;
        struct samr_Connect2 c;
        struct samr_OpenDomain o;
        struct dom_sid sid;
index c746d961107fd59e20b54ae5540013e46a319e15..8177a1ab2e8e94d38558e35e9461cf5f4e9cce56 100644 (file)
        status = smb2_getinfo_file(tree, tctx, &_q); \
        CHECK_STATUS(status, NT_STATUS_OK); \
        /* Handle a Vista bug where SEC_STD_SYNCHRONIZE doesn't come back. */ \
-       if (((flags & CHECK_ACCESS_IGNORE) == CHECK_ACCESS_IGNORE) && \
+       if ((((flags) & CHECK_ACCESS_IGNORE) == CHECK_ACCESS_IGNORE) && \
            ((_q.access_information.out.access_flags & CHECK_ACCESS_IGNORE) != CHECK_ACCESS_IGNORE)) { \
                torture_comment(tctx, "SKIPPING (Vista bug): (%s) Incorrect access_flags 0x%08x - should be 0x%08x\n", \
                       __location__, _q.access_information.out.access_flags, (flags)); \
        } \
        if ((_q.access_information.out.access_flags & ~CHECK_ACCESS_IGNORE) != \
-           ((flags & ~CHECK_ACCESS_IGNORE))) { \
+           (((flags) & ~CHECK_ACCESS_IGNORE))) { \
                torture_result(tctx, TORTURE_FAIL, "(%s) Incorrect access_flags 0x%08x - should be 0x%08x\n", \
                       __location__, _q.access_information.out.access_flags, (flags)); \
                ret = false; \