lib/popt: Patch memory leak in popthelp.c

Memory created as "t" was not being free'd.

Change-Id: I5f6e20acc6c440a1cd9908aed7a90de2000f22f8
Coverity-Id: 240599
Coverity-Id: 240600
Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>

diff --git a/lib/popt/popthelp.c b/lib/popt/popthelp.c
index 0ed355a18d73b56f0c106384de9165f112153007..4e2a1a56ced3a16f08a747e2411bdda7f1f69e1e 100644 (file)
--- a/lib/popt/popthelp.c
+++ b/lib/popt/popthelp.c
@@ -253,8 +253,8 @@ static void singleOptionHelp(FILE * fp, int maxLeftCol,
                                }
                                *te++ = ' ';
                                strcpy(te, defs);
-                               defs = (char *)_free(defs);
                        }
+                       defs = (char *)_free(defs);
                        defs = t;
                }
        }
@@ -326,7 +326,7 @@ static void singleOptionHelp(FILE * fp, int maxLeftCol,
 
     left = (char *)_free(left);
     if (defs) {
-       help = defs; defs = NULL;
+       help = defs;
     }
 
     helpLength = strlen(help);