selftest/gdb_*: make use of 'mktemp'
authorStefan Metzmacher <metze@samba.org>
Wed, 23 Nov 2016 11:26:18 +0000 (12:26 +0100)
committerAndrew Bartlett <abartlet@samba.org>
Thu, 1 Dec 2016 04:54:21 +0000 (05:54 +0100)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
selftest/gdb_backtrace
selftest/gdb_run

index 28ac064bcd400fbfc09b40697f34de422926e0b5..ef02e784efc926277ab88664f588b3a2a587f97a 100755 (executable)
@@ -90,8 +90,16 @@ test x"${need_binary}" = x"yes" && {
        }
 }
 
-BATCHFILE_PRE=/tmp/gdb_backtrace_pre.$$
-BATCHFILE_MAIN=/tmp/gdb_backtrace_main.$$
+BATCHFILE_PRE=`mktemp --tmpdir gdb_backtrace_pre.XXXXXXXXXX`
+test -n "${BATCHFILE_PRE}" || {
+       echo "mktemp doesn't work" 1>&2
+       exit 1
+}
+BATCHFILE_MAIN=`mktemp --tmpdir gdb_backtrace_main.XXXXXXXXXX`
+test -n "${BATCHFILE_MAIN}" || {
+       echo "mktemp doesn't work" 1>&2
+       exit 1
+}
 case "${DB}" in
        ladebug)
 cat << EOF  > ${BATCHFILE_PRE}
index 8ad101ed60a68b47d3b1c67763092eabfd24570a..42d91b8559b780dcf3125884960f67e22d6e3d45 100755 (executable)
@@ -4,11 +4,12 @@ ENV="$1"
 
 shift 1
 
-if test -z "$TMPDIR"; then
-       TMPDIR="/tmp"
-fi
+TMPFILE=`mktemp --tmpdir gdb_run.XXXXXXXXXX`
+test -n "${TMPFILE}" || {
+       echo "mktemp doesn't work" 1>&2
+       exit 1
+}
 
-TMPFILE=$TMPDIR/gdb_run.$$
 cat << EOF  > $TMPFILE
 run
 bt