s3:libads: Fix memory leaks in ads_krb5_chg_password()
authorAndreas Schneider <asn@samba.org>
Thu, 9 Aug 2018 14:02:16 +0000 (16:02 +0200)
committerJeremy Allison <jra@samba.org>
Fri, 10 Aug 2018 23:49:16 +0000 (01:49 +0200)
Found by covscan.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13567

Pair-Programmed-With: Justin Stephenson <jstephen@redhat.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
source3/libads/krb5_setpw.c

index bc96ac603b111dd1c5fe7a9b4f54287cee4b9813..0418fec5ad392cdfeea36c076b293b657aa0a4c0 100644 (file)
@@ -224,6 +224,7 @@ static ADS_STATUS ads_krb5_chg_password(const char *kdc_host,
        krb5_get_init_creds_opt_free(context, opts);
        krb5_free_context(context);
        free(realm);
+       smb_krb5_free_addresses(context, addr);
        DEBUG(1,("ads_krb5_chg_password: asprintf fail\n"));
        return ADS_ERROR_NT(NT_STATUS_NO_MEMORY);
     }
@@ -234,6 +235,7 @@ static ADS_STATUS ads_krb5_chg_password(const char *kdc_host,
                                           kerb_prompter, NULL, 
                                           0, chpw_princ, opts);
        krb5_get_init_creds_opt_free(context, opts);
+       smb_krb5_free_addresses(context, addr);
     SAFE_FREE(chpw_princ);
     SAFE_FREE(password);