vfs_snapper: drop unneeded fstat handler
authorDavid Disseldorp <ddiss@samba.org>
Mon, 25 Mar 2019 17:06:15 +0000 (18:06 +0100)
committerJeremy Allison <jra@samba.org>
Wed, 27 Mar 2019 18:21:38 +0000 (18:21 +0000)
fstat is handle based, and unlike vfs_shadow_copy2, we don't need to
make any changes to the returned sbuf, so remove the existing handler
which does nothing.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13858

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Mar 27 18:21:38 UTC 2019 on sn-devel-144

source3/modules/vfs_snapper.c

index 0f52f9e71c57b5083f8116ae2d923145c9eeefbd..fac4aa698de66852f5b5859d278216f5648eb2e5 100644 (file)
@@ -2165,24 +2165,6 @@ static int snapper_gmt_lstat(vfs_handle_struct *handle,
        return ret;
 }
 
-static int snapper_gmt_fstat(vfs_handle_struct *handle, files_struct *fsp,
-                            SMB_STRUCT_STAT *sbuf)
-{
-       time_t timestamp;
-       int ret;
-
-       ret = SMB_VFS_NEXT_FSTAT(handle, fsp, sbuf);
-       if (ret == -1) {
-               return ret;
-       }
-       if (!snapper_gmt_strip_snapshot(talloc_tos(), handle,
-                                       fsp->fsp_name->base_name,
-                                       &timestamp, NULL)) {
-               return 0;
-       }
-       return 0;
-}
-
 static int snapper_gmt_open(vfs_handle_struct *handle,
                            struct smb_filename *smb_fname, files_struct *fsp,
                            int flags, mode_t mode)
@@ -3111,7 +3093,6 @@ static struct vfs_fn_pointers snapper_fns = {
        .symlink_fn = snapper_gmt_symlink,
        .stat_fn = snapper_gmt_stat,
        .lstat_fn = snapper_gmt_lstat,
-       .fstat_fn = snapper_gmt_fstat,
        .open_fn = snapper_gmt_open,
        .unlink_fn = snapper_gmt_unlink,
        .chmod_fn = snapper_gmt_chmod,