s3: modules: vfs_default: Remove CHMOD_ACL in chmod.
authorJeremy Allison <jra@samba.org>
Thu, 17 May 2018 18:05:20 +0000 (11:05 -0700)
committerJeremy Allison <jra@samba.org>
Fri, 25 May 2018 16:39:24 +0000 (18:39 +0200)
Now I understand the use of the mask in POSIX ACLs
this extra step is no longer needed.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
source3/modules/vfs_default.c

index 956cebfd59275c513e0a82b8cbc4c6ad6f7e83f4..a2bc7c0e9f92d3543b482b3a626466a81d9e999d 100644 (file)
@@ -1983,27 +1983,6 @@ static int vfswrap_chmod(vfs_handle_struct *handle,
        int result;
 
        START_PROFILE(syscall_chmod);
-
-       /*
-        * We need to do this due to the fact that the default POSIX ACL
-        * chmod modifies the ACL *mask* for the group owner, not the
-        * group owner bits directly. JRA.
-        */
-
-
-       {
-               int saved_errno = errno; /* We might get ENOSYS */
-               result = SMB_VFS_CHMOD_ACL(handle->conn,
-                               smb_fname,
-                               mode);
-               if (result == 0) {
-                       END_PROFILE(syscall_chmod);
-                       return result;
-               }
-               /* Error - return the old errno. */
-               errno = saved_errno;
-       }
-
        result = chmod(smb_fname->base_name, mode);
        END_PROFILE(syscall_chmod);
        return result;