s4-dns: fixed a crash bug in dlz_bind9 code
authorAndrew Tridgell <tridge@samba.org>
Tue, 21 Dec 2010 00:57:50 +0000 (11:57 +1100)
committerAndrew Tridgell <tridge@samba.org>
Tue, 21 Dec 2010 01:42:37 +0000 (02:42 +0100)
we need to keep el_ctx for the next part of the loop

source4/dns_server/dlz_bind9.c

index 7e18165e5f5d83bbc7b64908c6edd26981b248ca..dc4c4bcd1e11aa0c7b1e63b9950f24cab72e92b9 100644 (file)
@@ -821,13 +821,11 @@ _PUBLIC_ isc_result_t dlz_allnodes(const char *zone, void *dbdata,
                        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
                                state->log(ISC_LOG_ERROR, "samba_dlz: failed to parse dnsRecord for %s",
                                           ldb_dn_get_linearized(dn));
-                               talloc_free(el_ctx);
                                continue;
                        }
 
                        result = b9_putnamedrr(state, allnodes, name, &rec);
                        if (result != ISC_R_SUCCESS) {
-                               talloc_free(el_ctx);
                                continue;
                        }
                }